blob: 3bd79fdda8a4fbcda0944c4ea83fbb88c078a0e2 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000036import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000037import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000040import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000041from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000042
43# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000044import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000045import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000046import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070047import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000048import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000049import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020050import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000052import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
69 self.kwargs = kwargs
70 self.message = message
71 self.info = None
72
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000073
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074def normpath(path):
75 '''Version of os.path.normpath that also changes backward slashes to
76 forward slashes when not running on Windows.
77 '''
78 # This is safe to always do because the Windows version of os.path.normpath
79 # will replace forward slashes with backward slashes.
80 path = path.replace(os.sep, '/')
81 return os.path.normpath(path)
82
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000083
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000084def _RightHandSideLinesImpl(affected_files):
85 """Implements RightHandSideLines for InputApi and GclChange."""
86 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000087 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000088 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000089 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000090
91
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000092class PresubmitOutput(object):
93 def __init__(self, input_stream=None, output_stream=None):
94 self.input_stream = input_stream
95 self.output_stream = output_stream
96 self.reviewers = []
97 self.written_output = []
98 self.error_count = 0
99
100 def prompt_yes_no(self, prompt_string):
101 self.write(prompt_string)
102 if self.input_stream:
103 response = self.input_stream.readline().strip().lower()
104 if response not in ('y', 'yes'):
105 self.fail()
106 else:
107 self.fail()
108
109 def fail(self):
110 self.error_count += 1
111
112 def should_continue(self):
113 return not self.error_count
114
115 def write(self, s):
116 self.written_output.append(s)
117 if self.output_stream:
118 self.output_stream.write(s)
119
120 def getvalue(self):
121 return ''.join(self.written_output)
122
123
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000124# Top level object so multiprocessing can pickle
125# Public access through OutputApi object.
126class _PresubmitResult(object):
127 """Base class for result objects."""
128 fatal = False
129 should_prompt = False
130
131 def __init__(self, message, items=None, long_text=''):
132 """
133 message: A short one-line message to indicate errors.
134 items: A list of short strings to indicate where errors occurred.
135 long_text: multi-line text output, e.g. from another tool
136 """
137 self._message = message
138 self._items = items or []
139 if items:
140 self._items = items
141 self._long_text = long_text.rstrip()
142
143 def handle(self, output):
144 output.write(self._message)
145 output.write('\n')
146 for index, item in enumerate(self._items):
147 output.write(' ')
148 # Write separately in case it's unicode.
149 output.write(str(item))
150 if index < len(self._items) - 1:
151 output.write(' \\')
152 output.write('\n')
153 if self._long_text:
154 output.write('\n***************\n')
155 # Write separately in case it's unicode.
156 output.write(self._long_text)
157 output.write('\n***************\n')
158 if self.fatal:
159 output.fail()
160
161
162# Top level object so multiprocessing can pickle
163# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000164class _PresubmitError(_PresubmitResult):
165 """A hard presubmit error."""
166 fatal = True
167
168
169# Top level object so multiprocessing can pickle
170# Public access through OutputApi object.
171class _PresubmitPromptWarning(_PresubmitResult):
172 """An warning that prompts the user if they want to continue."""
173 should_prompt = True
174
175
176# Top level object so multiprocessing can pickle
177# Public access through OutputApi object.
178class _PresubmitNotifyResult(_PresubmitResult):
179 """Just print something to the screen -- but it's not even a warning."""
180 pass
181
182
183# Top level object so multiprocessing can pickle
184# Public access through OutputApi object.
185class _MailTextResult(_PresubmitResult):
186 """A warning that should be included in the review request email."""
187 def __init__(self, *args, **kwargs):
188 super(_MailTextResult, self).__init__()
189 raise NotImplementedError()
190
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000191class GerritAccessor(object):
192 """Limited Gerrit functionality for canned presubmit checks to work.
193
194 To avoid excessive Gerrit calls, caches the results.
195 """
196
197 def __init__(self, host):
198 self.host = host
199 self.cache = {}
200
201 def _FetchChangeDetail(self, issue):
202 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100203 try:
204 return gerrit_util.GetChangeDetail(
205 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700206 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100207 except gerrit_util.GerritError as e:
208 if e.http_status == 404:
209 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
210 'no credentials to fetch issue details' % issue)
211 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000212
213 def GetChangeInfo(self, issue):
214 """Returns labels and all revisions (patchsets) for this issue.
215
216 The result is a dictionary according to Gerrit REST Api.
217 https://gerrit-review.googlesource.com/Documentation/rest-api.html
218
219 However, API isn't very clear what's inside, so see tests for example.
220 """
221 assert issue
222 cache_key = int(issue)
223 if cache_key not in self.cache:
224 self.cache[cache_key] = self._FetchChangeDetail(issue)
225 return self.cache[cache_key]
226
227 def GetChangeDescription(self, issue, patchset=None):
228 """If patchset is none, fetches current patchset."""
229 info = self.GetChangeInfo(issue)
230 # info is a reference to cache. We'll modify it here adding description to
231 # it to the right patchset, if it is not yet there.
232
233 # Find revision info for the patchset we want.
234 if patchset is not None:
235 for rev, rev_info in info['revisions'].iteritems():
236 if str(rev_info['_number']) == str(patchset):
237 break
238 else:
239 raise Exception('patchset %s doesn\'t exist in issue %s' % (
240 patchset, issue))
241 else:
242 rev = info['current_revision']
243 rev_info = info['revisions'][rev]
244
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100245 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000246
247 def GetChangeOwner(self, issue):
248 return self.GetChangeInfo(issue)['owner']['email']
249
250 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700251 changeinfo = self.GetChangeInfo(issue)
252 if approving_only:
253 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
254 values = labelinfo.get('values', {}).keys()
255 try:
256 max_value = max(int(v) for v in values)
257 reviewers = [r for r in labelinfo.get('all', [])
258 if r.get('value', 0) == max_value]
259 except ValueError: # values is the empty list
260 reviewers = []
261 else:
262 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
263 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000264
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000265
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000266class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000267 """An instance of OutputApi gets passed to presubmit scripts so that they
268 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000270 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000271 PresubmitError = _PresubmitError
272 PresubmitPromptWarning = _PresubmitPromptWarning
273 PresubmitNotifyResult = _PresubmitNotifyResult
274 MailTextResult = _MailTextResult
275
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000276 def __init__(self, is_committing):
277 self.is_committing = is_committing
278
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000279 def PresubmitPromptOrNotify(self, *args, **kwargs):
280 """Warn the user when uploading, but only notify if committing."""
281 if self.is_committing:
282 return self.PresubmitNotifyResult(*args, **kwargs)
283 return self.PresubmitPromptWarning(*args, **kwargs)
284
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800285 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
286 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
287
288 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
289 keeping it alphabetically sorted. Returns the results that should be
290 returned from the PostUploadHook.
291
292 Args:
293 cl: The git_cl.Changelist object.
294 bots_to_include: A list of strings of bots to include, in the form
295 "master:slave".
296 message: A message to be printed in the case that
297 CQ_INCLUDE_TRYBOTS was updated.
298 """
299 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700300 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
301
302 prior_bots = []
303 if cl.IsGerrit():
304 trybot_footers = git_footers.parse_footers(description).get(
305 git_footers.normalize_name('Cq-Include-Trybots'), [])
306 for f in trybot_footers:
307 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800308 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700309 trybot_tags = include_re.finditer(description)
310 for t in trybot_tags:
311 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
312
313 if set(prior_bots) >= set(bots_to_include):
314 return []
315 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
316
317 if cl.IsGerrit():
318 description = git_footers.remove_footer(
319 description, 'Cq-Include-Trybots')
320 description = git_footers.add_footer(
321 description, 'Cq-Include-Trybots', all_bots,
322 before_keys=['Change-Id'])
323 else:
324 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
325 m = include_re.search(description)
326 if m:
327 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700328 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700329 description = '%s\n%s\n' % (description, new_include_trybots)
330
331 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800332 return [self.PresubmitNotifyResult(message)]
333
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000334
335class InputApi(object):
336 """An instance of this object is passed to presubmit scripts so they can
337 know stuff about the change they're looking at.
338 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000339 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800340 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000341
maruel@chromium.org3410d912009-06-09 20:56:16 +0000342 # File extensions that are considered source files from a style guide
343 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000344 #
345 # Files without an extension aren't included in the list. If you want to
346 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
347 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000348 DEFAULT_WHITE_LIST = (
349 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000350 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
351 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000352 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000353 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000354 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000355 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000356 )
357
358 # Path regexp that should be excluded from being considered containing source
359 # files. Don't modify this list from a presubmit script!
360 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000361 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000362 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000363 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
364 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000365 # Output directories (just in case)
366 r".*\bDebug[\\\/].*",
367 r".*\bRelease[\\\/].*",
368 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000369 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000370 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000371 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000372 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000373 r"(|.*[\\\/])\.git[\\\/].*",
374 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000375 # There is no point in processing a patch file.
376 r".+\.diff$",
377 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000378 )
379
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000380 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000381 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000382 """Builds an InputApi object.
383
384 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000385 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000386 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000387 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000388 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000389 gerrit_obj: provides basic Gerrit codereview functionality.
390 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000391 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000392 # Version number of the presubmit_support script.
393 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000394 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000395 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000396 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000398 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000399 # TBD
400 self.host_url = 'http://codereview.chromium.org'
401 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000402 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000403
404 # We expose various modules and functions as attributes of the input_api
405 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900406 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000407 self.basename = os.path.basename
408 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000409 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000410 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700411 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000412 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000413 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000414 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000415 self.os_listdir = os.listdir
416 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000417 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000418 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 self.pickle = pickle
420 self.marshal = marshal
421 self.re = re
422 self.subprocess = subprocess
423 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000424 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000425 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000426 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000427 self.urllib2 = urllib2
428
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000429 # To easily fork python.
430 self.python_executable = sys.executable
431 self.environ = os.environ
432
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000433 # InputApi.platform is the platform you're currently running on.
434 self.platform = sys.platform
435
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000436 self.cpu_count = multiprocessing.cpu_count()
437
Aaron Gable5254da12017-09-06 21:05:39 +0000438 # this is done here because in RunTests, the current working directory has
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000439 # changed, which causes Pool() to explode fantastically when run on windows
440 # (because it tries to load the __main__ module, which imports lots of
441 # things relative to the current working directory).
Aaron Gable5254da12017-09-06 21:05:39 +0000442 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000443
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000444 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000445 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000446
447 # We carry the canned checks so presubmit scripts can easily use them.
448 self.canned_checks = presubmit_canned_checks
449
Jochen Eisinger72606f82017-04-04 10:44:18 +0200450
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000451 # TODO(dpranke): figure out a list of all approved owners for a repo
452 # in order to be able to handle wildcard OWNERS files?
453 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200454 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200455 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000456 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000458
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000459 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000460 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000461 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800462 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000463 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000464 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000465 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
466 for (a, b, header) in cpplint._re_pattern_templates
467 ]
468
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000469 def PresubmitLocalPath(self):
470 """Returns the local path of the presubmit script currently being run.
471
472 This is useful if you don't want to hard-code absolute paths in the
473 presubmit script. For example, It can be used to find another file
474 relative to the PRESUBMIT.py script, so the whole tree can be branched and
475 the presubmit script still works, without editing its content.
476 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000477 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000478
agable0b65e732016-11-22 09:25:46 -0800479 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000480 """Same as input_api.change.AffectedFiles() except only lists files
481 (and optionally directories) in the same directory as the current presubmit
482 script, or subdirectories thereof.
483 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000484 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000485 if len(dir_with_slash) == 1:
486 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000487
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000488 return filter(
489 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800490 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000491
agable0b65e732016-11-22 09:25:46 -0800492 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000493 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800494 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000495 logging.debug("LocalPaths: %s", paths)
496 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000497
agable0b65e732016-11-22 09:25:46 -0800498 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000499 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800500 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501
agable0b65e732016-11-22 09:25:46 -0800502 def AffectedTestableFiles(self, include_deletes=None):
503 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000504 in the same directory as the current presubmit script, or subdirectories
505 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000506 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000507 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800508 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000509 " is deprecated and ignored" % str(include_deletes),
510 category=DeprecationWarning,
511 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800512 return filter(lambda x: x.IsTestableFile(),
513 self.AffectedFiles(include_deletes=False))
514
515 def AffectedTextFiles(self, include_deletes=None):
516 """An alias to AffectedTestableFiles for backwards compatibility."""
517 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000518
maruel@chromium.org3410d912009-06-09 20:56:16 +0000519 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
520 """Filters out files that aren't considered "source file".
521
522 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
523 and InputApi.DEFAULT_BLACK_LIST is used respectively.
524
525 The lists will be compiled as regular expression and
526 AffectedFile.LocalPath() needs to pass both list.
527
528 Note: Copy-paste this function to suit your needs or use a lambda function.
529 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000530 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000531 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000532 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000533 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000534 return True
535 return False
536 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
537 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
538
539 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800540 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000541
542 If source_file is None, InputApi.FilterSourceFile() is used.
543 """
544 if not source_file:
545 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800546 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000547
548 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000549 """An iterator over all text lines in "new" version of changed files.
550
551 Only lists lines from new or modified text files in the change that are
552 contained by the directory of the currently executing presubmit script.
553
554 This is useful for doing line-by-line regex checks, like checking for
555 trailing whitespace.
556
557 Yields:
558 a 3 tuple:
559 the AffectedFile instance of the current file;
560 integer line number (1-based); and
561 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000562
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000563 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000564 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000565 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000566 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000567
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000568 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000569 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000570
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000571 Deny reading anything outside the repository.
572 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000573 if isinstance(file_item, AffectedFile):
574 file_item = file_item.AbsoluteLocalPath()
575 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000576 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000577 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000578
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000579 @property
580 def tbr(self):
581 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400582 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000583
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000584 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000585 tests = []
586 msgs = []
587 for t in tests_mix:
588 if isinstance(t, OutputApi.PresubmitResult):
589 msgs.append(t)
590 else:
591 assert issubclass(t.message, _PresubmitResult)
592 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000593 if self.verbose:
594 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000595 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000596 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000597 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000598 else:
599 msgs.extend(map(CallCommand, tests))
600 return [m for m in msgs if m]
601
scottmg86099d72016-09-01 09:16:51 -0700602 def ShutdownPool(self):
603 self._run_tests_pool.close()
604 self._run_tests_pool.join()
605 self._run_tests_pool = None
606
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607
nick@chromium.orgff526192013-06-10 19:30:26 +0000608class _DiffCache(object):
609 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000610 def __init__(self, upstream=None):
611 """Stores the upstream revision against which all diffs will be computed."""
612 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000613
614 def GetDiff(self, path, local_root):
615 """Get the diff for a particular path."""
616 raise NotImplementedError()
617
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700618 def GetOldContents(self, path, local_root):
619 """Get the old version for a particular path."""
620 raise NotImplementedError()
621
nick@chromium.orgff526192013-06-10 19:30:26 +0000622
nick@chromium.orgff526192013-06-10 19:30:26 +0000623class _GitDiffCache(_DiffCache):
624 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000625 def __init__(self, upstream):
626 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000627 self._diffs_by_file = None
628
629 def GetDiff(self, path, local_root):
630 if not self._diffs_by_file:
631 # Compute a single diff for all files and parse the output; should
632 # with git this is much faster than computing one diff for each file.
633 diffs = {}
634
635 # Don't specify any filenames below, because there are command line length
636 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000637 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
638 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000639
640 # This regex matches the path twice, separated by a space. Note that
641 # filename itself may contain spaces.
642 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
643 current_diff = []
644 keep_line_endings = True
645 for x in unified_diff.splitlines(keep_line_endings):
646 match = file_marker.match(x)
647 if match:
648 # Marks the start of a new per-file section.
649 diffs[match.group('filename')] = current_diff = [x]
650 elif x.startswith('diff --git'):
651 raise PresubmitFailure('Unexpected diff line: %s' % x)
652 else:
653 current_diff.append(x)
654
655 self._diffs_by_file = dict(
656 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
657
658 if path not in self._diffs_by_file:
659 raise PresubmitFailure(
660 'Unified diff did not contain entry for file %s' % path)
661
662 return self._diffs_by_file[path]
663
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700664 def GetOldContents(self, path, local_root):
665 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
666
nick@chromium.orgff526192013-06-10 19:30:26 +0000667
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000668class AffectedFile(object):
669 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000670
671 DIFF_CACHE = _DiffCache
672
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000673 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800674 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000675 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000676 self._path = path
677 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000678 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000679 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000680 self._cached_changed_contents = None
681 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000682 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700683 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000684
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685 def LocalPath(self):
686 """Returns the path of this file on the local disk relative to client root.
687 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000688 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689
690 def AbsoluteLocalPath(self):
691 """Returns the absolute path of this file on the local disk.
692 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000693 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000694
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695 def Action(self):
696 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000697 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698
agable0b65e732016-11-22 09:25:46 -0800699 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000700 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000701
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000702 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000703 raise NotImplementedError() # Implement when needed
704
agable0b65e732016-11-22 09:25:46 -0800705 def IsTextFile(self):
706 """An alias to IsTestableFile for backwards compatibility."""
707 return self.IsTestableFile()
708
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700709 def OldContents(self):
710 """Returns an iterator over the lines in the old version of file.
711
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700712 The old version is the file before any modifications in the user's
713 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700714
715 Contents will be empty if the file is a directory or does not exist.
716 Note: The carriage returns (LF or CR) are stripped off.
717 """
718 return self._diff_cache.GetOldContents(self.LocalPath(),
719 self._local_root).splitlines()
720
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 def NewContents(self):
722 """Returns an iterator over the lines in the new version of file.
723
724 The new version is the file in the user's workspace, i.e. the "right hand
725 side".
726
727 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000728 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000730 if self._cached_new_contents is None:
731 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800732 try:
733 self._cached_new_contents = gclient_utils.FileRead(
734 self.AbsoluteLocalPath(), 'rU').splitlines()
735 except IOError:
736 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000737 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000738
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000739 def ChangedContents(self):
740 """Returns a list of tuples (line number, line text) of all new lines.
741
742 This relies on the scm diff output describing each changed code section
743 with a line of the form
744
745 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
746 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000747 if self._cached_changed_contents is not None:
748 return self._cached_changed_contents[:]
749 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000750 line_num = 0
751
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000752 for line in self.GenerateScmDiff().splitlines():
753 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
754 if m:
755 line_num = int(m.groups(1)[0])
756 continue
757 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000758 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000759 if not line.startswith('-'):
760 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000761 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000762
maruel@chromium.org5de13972009-06-10 18:16:06 +0000763 def __str__(self):
764 return self.LocalPath()
765
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000766 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000767 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000768
maruel@chromium.org58407af2011-04-12 23:15:57 +0000769
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000770class GitAffectedFile(AffectedFile):
771 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000772 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800773 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000774
nick@chromium.orgff526192013-06-10 19:30:26 +0000775 DIFF_CACHE = _GitDiffCache
776
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000777 def __init__(self, *args, **kwargs):
778 AffectedFile.__init__(self, *args, **kwargs)
779 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800780 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000781
agable0b65e732016-11-22 09:25:46 -0800782 def IsTestableFile(self):
783 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000784 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800785 # A deleted file is not testable.
786 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000787 else:
agable0b65e732016-11-22 09:25:46 -0800788 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
789 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000790
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000791
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000792class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000793 """Describe a change.
794
795 Used directly by the presubmit scripts to query the current change being
796 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000797
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000798 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000799 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000800 self.KEY: equivalent to tags['KEY']
801 """
802
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000803 _AFFECTED_FILES = AffectedFile
804
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000805 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000806 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000807 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000808 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809
maruel@chromium.org58407af2011-04-12 23:15:57 +0000810 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000811 self, name, description, local_root, files, issue, patchset, author,
812 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000813 if files is None:
814 files = []
815 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000816 # Convert root into an absolute path.
817 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000818 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000819 self.issue = issue
820 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000821 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000822
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000823 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000824 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000825 self._description_without_tags = ''
826 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000827
maruel@chromium.orge085d812011-10-10 19:49:15 +0000828 assert all(
829 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
830
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000831 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000832 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000833 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
834 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000835 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000836
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000837 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000838 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000839 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000840
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000841 def DescriptionText(self):
842 """Returns the user-entered changelist description, minus tags.
843
844 Any line in the user-provided description starting with e.g. "FOO="
845 (whitespace permitted before and around) is considered a tag line. Such
846 lines are stripped out of the description this function returns.
847 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000848 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000849
850 def FullDescriptionText(self):
851 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000852 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000853
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000854 def SetDescriptionText(self, description):
855 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000856
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000857 Also updates the list of tags."""
858 self._full_description = description
859
860 # From the description text, build up a dictionary of key/value pairs
861 # plus the description minus all key/value or "tag" lines.
862 description_without_tags = []
863 self.tags = {}
864 for line in self._full_description.splitlines():
865 m = self.TAG_LINE_RE.match(line)
866 if m:
867 self.tags[m.group('key')] = m.group('value')
868 else:
869 description_without_tags.append(line)
870
871 # Change back to text and remove whitespace at end.
872 self._description_without_tags = (
873 '\n'.join(description_without_tags).rstrip())
874
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000875 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000876 """Returns the repository (checkout) root directory for this change,
877 as an absolute path.
878 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000879 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880
881 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000882 """Return tags directly as attributes on the object."""
883 if not re.match(r"^[A-Z_]*$", attr):
884 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000885 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886
Aaron Gablefc03e672017-05-15 14:09:42 -0700887 def BugsFromDescription(self):
888 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700889 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
890 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
891 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -0700892
893 def ReviewersFromDescription(self):
894 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700895 # We don't support a "R:" git-footer for reviewers; that is in metadata.
896 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
897 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -0700898
899 def TBRsFromDescription(self):
900 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700901 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
902 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
903 # determined by self-CR+1s.
904 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
905 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -0700906
907 # TODO(agable): Delete these once we're sure they're unused.
908 @property
909 def BUG(self):
910 return ','.join(self.BugsFromDescription())
911 @property
912 def R(self):
913 return ','.join(self.ReviewersFromDescription())
914 @property
915 def TBR(self):
916 return ','.join(self.TBRsFromDescription())
917
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000918 def AllFiles(self, root=None):
919 """List all files under source control in the repo."""
920 raise NotImplementedError()
921
agable0b65e732016-11-22 09:25:46 -0800922 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000923 """Returns a list of AffectedFile instances for all files in the change.
924
925 Args:
926 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +0000927 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000928
929 Returns:
930 [AffectedFile(path, action), AffectedFile(path, action)]
931 """
agable0b65e732016-11-22 09:25:46 -0800932 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +0000933
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000934 if include_deletes:
935 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -0700936 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000937
agable0b65e732016-11-22 09:25:46 -0800938 def AffectedTestableFiles(self, include_deletes=None):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000939 """Return a list of the existing text files in a change."""
940 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800941 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000942 " is deprecated and ignored" % str(include_deletes),
943 category=DeprecationWarning,
944 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800945 return filter(lambda x: x.IsTestableFile(),
946 self.AffectedFiles(include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000947
agable0b65e732016-11-22 09:25:46 -0800948 def AffectedTextFiles(self, include_deletes=None):
949 """An alias to AffectedTestableFiles for backwards compatibility."""
950 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951
agable0b65e732016-11-22 09:25:46 -0800952 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000953 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800954 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000955
agable0b65e732016-11-22 09:25:46 -0800956 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000957 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800958 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959
960 def RightHandSideLines(self):
961 """An iterator over all text lines in "new" version of changed files.
962
963 Lists lines from new or modified text files in the change.
964
965 This is useful for doing line-by-line regex checks, like checking for
966 trailing whitespace.
967
968 Yields:
969 a 3 tuple:
970 the AffectedFile instance of the current file;
971 integer line number (1-based); and
972 the contents of the line as a string.
973 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000974 return _RightHandSideLinesImpl(
975 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -0800976 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000977
Jochen Eisingerd0573ec2017-04-13 10:55:06 +0200978 def OriginalOwnersFiles(self):
979 """A map from path names of affected OWNERS files to their old content."""
980 def owners_file_filter(f):
981 return 'OWNERS' in os.path.split(f.LocalPath())[1]
982 files = self.AffectedFiles(file_filter=owners_file_filter)
983 return dict([(f.LocalPath(), f.OldContents()) for f in files])
984
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000985
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000986class GitChange(Change):
987 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000988 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000989
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000990 def AllFiles(self, root=None):
991 """List all files under source control in the repo."""
992 root = root or self.RepositoryRoot()
993 return subprocess.check_output(
994 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
995
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000996
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000997def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998 """Finds all presubmit files that apply to a given set of source files.
999
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001000 If inherit-review-settings-ok is present right under root, looks for
1001 PRESUBMIT.py in directories enclosing root.
1002
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001003 Args:
1004 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001005 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001006
1007 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001008 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001009 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001010 files = [normpath(os.path.join(root, f)) for f in files]
1011
1012 # List all the individual directories containing files.
1013 directories = set([os.path.dirname(f) for f in files])
1014
1015 # Ignore root if inherit-review-settings-ok is present.
1016 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1017 root = None
1018
1019 # Collect all unique directories that may contain PRESUBMIT.py.
1020 candidates = set()
1021 for directory in directories:
1022 while True:
1023 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001024 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001025 candidates.add(directory)
1026 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001027 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001028 parent_dir = os.path.dirname(directory)
1029 if parent_dir == directory:
1030 # We hit the system root directory.
1031 break
1032 directory = parent_dir
1033
1034 # Look for PRESUBMIT.py in all candidate directories.
1035 results = []
1036 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001037 try:
1038 for f in os.listdir(directory):
1039 p = os.path.join(directory, f)
1040 if os.path.isfile(p) and re.match(
1041 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1042 results.append(p)
1043 except OSError:
1044 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001045
tobiasjs2836bcf2016-08-16 04:08:16 -07001046 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001047 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001048
1049
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001050class GetTryMastersExecuter(object):
1051 @staticmethod
1052 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1053 """Executes GetPreferredTryMasters() from a single presubmit script.
1054
1055 Args:
1056 script_text: The text of the presubmit script.
1057 presubmit_path: Project script to run.
1058 project: Project name to pass to presubmit script for bot selection.
1059
1060 Return:
1061 A map of try masters to map of builders to set of tests.
1062 """
1063 context = {}
1064 try:
1065 exec script_text in context
1066 except Exception, e:
1067 raise PresubmitFailure('"%s" had an exception.\n%s'
1068 % (presubmit_path, e))
1069
1070 function_name = 'GetPreferredTryMasters'
1071 if function_name not in context:
1072 return {}
1073 get_preferred_try_masters = context[function_name]
1074 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1075 raise PresubmitFailure(
1076 'Expected function "GetPreferredTryMasters" to take two arguments.')
1077 return get_preferred_try_masters(project, change)
1078
1079
rmistry@google.com5626a922015-02-26 14:03:30 +00001080class GetPostUploadExecuter(object):
1081 @staticmethod
1082 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1083 """Executes PostUploadHook() from a single presubmit script.
1084
1085 Args:
1086 script_text: The text of the presubmit script.
1087 presubmit_path: Project script to run.
1088 cl: The Changelist object.
1089 change: The Change object.
1090
1091 Return:
1092 A list of results objects.
1093 """
1094 context = {}
1095 try:
1096 exec script_text in context
1097 except Exception, e:
1098 raise PresubmitFailure('"%s" had an exception.\n%s'
1099 % (presubmit_path, e))
1100
1101 function_name = 'PostUploadHook'
1102 if function_name not in context:
1103 return {}
1104 post_upload_hook = context[function_name]
1105 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1106 raise PresubmitFailure(
1107 'Expected function "PostUploadHook" to take three arguments.')
1108 return post_upload_hook(cl, change, OutputApi(False))
1109
1110
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001111def _MergeMasters(masters1, masters2):
1112 """Merges two master maps. Merges also the tests of each builder."""
1113 result = {}
1114 for (master, builders) in itertools.chain(masters1.iteritems(),
1115 masters2.iteritems()):
1116 new_builders = result.setdefault(master, {})
1117 for (builder, tests) in builders.iteritems():
1118 new_builders.setdefault(builder, set([])).update(tests)
1119 return result
1120
1121
1122def DoGetTryMasters(change,
1123 changed_files,
1124 repository_root,
1125 default_presubmit,
1126 project,
1127 verbose,
1128 output_stream):
1129 """Get the list of try masters from the presubmit scripts.
1130
1131 Args:
1132 changed_files: List of modified files.
1133 repository_root: The repository root.
1134 default_presubmit: A default presubmit script to execute in any case.
1135 project: Optional name of a project used in selecting trybots.
1136 verbose: Prints debug info.
1137 output_stream: A stream to write debug output to.
1138
1139 Return:
1140 Map of try masters to map of builders to set of tests.
1141 """
1142 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1143 if not presubmit_files and verbose:
1144 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1145 results = {}
1146 executer = GetTryMastersExecuter()
1147
1148 if default_presubmit:
1149 if verbose:
1150 output_stream.write("Running default presubmit script.\n")
1151 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1152 results = _MergeMasters(results, executer.ExecPresubmitScript(
1153 default_presubmit, fake_path, project, change))
1154 for filename in presubmit_files:
1155 filename = os.path.abspath(filename)
1156 if verbose:
1157 output_stream.write("Running %s\n" % filename)
1158 # Accept CRLF presubmit script.
1159 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1160 results = _MergeMasters(results, executer.ExecPresubmitScript(
1161 presubmit_script, filename, project, change))
1162
1163 # Make sets to lists again for later JSON serialization.
1164 for builders in results.itervalues():
1165 for builder in builders:
1166 builders[builder] = list(builders[builder])
1167
1168 if results and verbose:
1169 output_stream.write('%s\n' % str(results))
1170 return results
1171
1172
rmistry@google.com5626a922015-02-26 14:03:30 +00001173def DoPostUploadExecuter(change,
1174 cl,
1175 repository_root,
1176 verbose,
1177 output_stream):
1178 """Execute the post upload hook.
1179
1180 Args:
1181 change: The Change object.
1182 cl: The Changelist object.
1183 repository_root: The repository root.
1184 verbose: Prints debug info.
1185 output_stream: A stream to write debug output to.
1186 """
1187 presubmit_files = ListRelevantPresubmitFiles(
1188 change.LocalPaths(), repository_root)
1189 if not presubmit_files and verbose:
1190 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1191 results = []
1192 executer = GetPostUploadExecuter()
1193 # The root presubmit file should be executed after the ones in subdirectories.
1194 # i.e. the specific post upload hooks should run before the general ones.
1195 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1196 presubmit_files.reverse()
1197
1198 for filename in presubmit_files:
1199 filename = os.path.abspath(filename)
1200 if verbose:
1201 output_stream.write("Running %s\n" % filename)
1202 # Accept CRLF presubmit script.
1203 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1204 results.extend(executer.ExecPresubmitScript(
1205 presubmit_script, filename, cl, change))
1206 output_stream.write('\n')
1207 if results:
1208 output_stream.write('** Post Upload Hook Messages **\n')
1209 for result in results:
1210 result.handle(output_stream)
1211 output_stream.write('\n')
1212
1213 return results
1214
1215
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001217 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001218 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001219 """
1220 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001221 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001222 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001223 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001224 gerrit_obj: provides basic Gerrit codereview functionality.
1225 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001226 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001227 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001228 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001229 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001230 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001231 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001232 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001233
1234 def ExecPresubmitScript(self, script_text, presubmit_path):
1235 """Executes a single presubmit script.
1236
1237 Args:
1238 script_text: The text of the presubmit script.
1239 presubmit_path: The path to the presubmit file (this will be reported via
1240 input_api.PresubmitLocalPath()).
1241
1242 Return:
1243 A list of result objects, empty if no problems.
1244 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001245
chase@chromium.org8e416c82009-10-06 04:30:44 +00001246 # Change to the presubmit file's directory to support local imports.
1247 main_path = os.getcwd()
1248 os.chdir(os.path.dirname(presubmit_path))
1249
1250 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001251 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001252 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001253 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001254 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001255 try:
1256 exec script_text in context
1257 except Exception, e:
1258 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001259
1260 # These function names must change if we make substantial changes to
1261 # the presubmit API that are not backwards compatible.
1262 if self.committing:
1263 function_name = 'CheckChangeOnCommit'
1264 else:
1265 function_name = 'CheckChangeOnUpload'
1266 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001267 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001268 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001269 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001270 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001271 if not (isinstance(result, types.TupleType) or
1272 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001273 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274 'Presubmit functions must return a tuple or list')
1275 for item in result:
1276 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001277 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001278 'All presubmit results must be of types derived from '
1279 'output_api.PresubmitResult')
1280 else:
1281 result = () # no error since the script doesn't care about current event.
1282
scottmg86099d72016-09-01 09:16:51 -07001283 input_api.ShutdownPool()
1284
chase@chromium.org8e416c82009-10-06 04:30:44 +00001285 # Return the process to the original working directory.
1286 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001287 return result
1288
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001289def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290 committing,
1291 verbose,
1292 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001293 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001294 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001295 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001296 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001297 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001298 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001299 """Runs all presubmit checks that apply to the files in the change.
1300
1301 This finds all PRESUBMIT.py files in directories enclosing the files in the
1302 change (up to the repository root) and calls the relevant entrypoint function
1303 depending on whether the change is being committed or uploaded.
1304
1305 Prints errors, warnings and notifications. Prompts the user for warnings
1306 when needed.
1307
1308 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001309 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001310 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001311 verbose: Prints debug info.
1312 output_stream: A stream to write output from presubmit tests to.
1313 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001314 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001315 may_prompt: Enable (y/n) questions on warning or error. If False,
1316 any questions are answered with yes by default.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001317 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001318 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001319 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001320
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001321 Warning:
1322 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1323 SHOULD be sys.stdin.
1324
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001325 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001326 A PresubmitOutput object. Use output.should_continue() to figure out
1327 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001328 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001329 old_environ = os.environ
1330 try:
1331 # Make sure python subprocesses won't generate .pyc files.
1332 os.environ = os.environ.copy()
1333 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001334
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001335 output = PresubmitOutput(input_stream, output_stream)
1336 if committing:
1337 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001338 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001339 output.write("Running presubmit upload checks ...\n")
1340 start_time = time.time()
1341 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001342 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001343 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001344 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001345 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001346 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001347 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001348 if default_presubmit:
1349 if verbose:
1350 output.write("Running default presubmit script.\n")
1351 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1352 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1353 for filename in presubmit_files:
1354 filename = os.path.abspath(filename)
1355 if verbose:
1356 output.write("Running %s\n" % filename)
1357 # Accept CRLF presubmit script.
1358 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1359 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001360
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001361 errors = []
1362 notifications = []
1363 warnings = []
1364 for result in results:
1365 if result.fatal:
1366 errors.append(result)
1367 elif result.should_prompt:
1368 warnings.append(result)
1369 else:
1370 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001371
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001372 output.write('\n')
1373 for name, items in (('Messages', notifications),
1374 ('Warnings', warnings),
1375 ('ERRORS', errors)):
1376 if items:
1377 output.write('** Presubmit %s **\n' % name)
1378 for item in items:
1379 item.handle(output)
1380 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001381
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001382 total_time = time.time() - start_time
1383 if total_time > 1.0:
1384 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001385
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001386 if errors:
1387 output.fail()
1388 elif warnings:
1389 output.write('There were presubmit warnings. ')
1390 if may_prompt:
1391 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1392 else:
1393 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001394
1395 global _ASKED_FOR_FEEDBACK
1396 # Ask for feedback one time out of 5.
1397 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001398 output.write(
1399 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1400 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1401 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001402 _ASKED_FOR_FEEDBACK = True
1403 return output
1404 finally:
1405 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001406
1407
1408def ScanSubDirs(mask, recursive):
1409 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001410 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001411
1412 results = []
1413 for root, dirs, files in os.walk('.'):
1414 if '.svn' in dirs:
1415 dirs.remove('.svn')
1416 if '.git' in dirs:
1417 dirs.remove('.git')
1418 for name in files:
1419 if fnmatch.fnmatch(name, mask):
1420 results.append(os.path.join(root, name))
1421 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001422
1423
1424def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001425 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001426 files = []
1427 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001428 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001429 return files
1430
1431
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001432def load_files(options, args):
1433 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001434 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001435 if args:
1436 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001437 change_scm = scm.determine_scm(options.root)
1438 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001439 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001440 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001441 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001442 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001443 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001444 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001445 if not files:
1446 return None, None
1447 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001448 return change_class, files
1449
1450
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001451class NonexistantCannedCheckFilter(Exception):
1452 pass
1453
1454
1455@contextlib.contextmanager
1456def canned_check_filter(method_names):
1457 filtered = {}
1458 try:
1459 for method_name in method_names:
1460 if not hasattr(presubmit_canned_checks, method_name):
1461 raise NonexistantCannedCheckFilter(method_name)
1462 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1463 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1464 yield
1465 finally:
1466 for name, method in filtered.iteritems():
1467 setattr(presubmit_canned_checks, name, method)
1468
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001469
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001470def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001471 """Runs an external program, potentially from a child process created by the
1472 multiprocessing module.
1473
1474 multiprocessing needs a top level function with a single argument.
1475 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001476 cmd_data.kwargs['stdout'] = subprocess.PIPE
1477 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1478 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001479 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001480 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001481 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001482 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001483 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001484 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001485 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1486 if code != 0:
1487 return cmd_data.message(
1488 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1489 if cmd_data.info:
1490 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001491
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001492
sbc@chromium.org013731e2015-02-26 18:28:43 +00001493def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001494 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001495 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001496 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001497 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001498 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1499 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001500 parser.add_option("-r", "--recursive", action="store_true",
1501 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001502 parser.add_option("-v", "--verbose", action="count", default=0,
1503 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001504 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001505 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001506 parser.add_option("--description", default='')
1507 parser.add_option("--issue", type='int', default=0)
1508 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001509 parser.add_option("--root", default=os.getcwd(),
1510 help="Search for PRESUBMIT.py up to this directory. "
1511 "If inherit-review-settings-ok is present in this "
1512 "directory, parent directories up to the root file "
1513 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001514 parser.add_option("--upstream",
1515 help="Git only: the base ref or upstream branch against "
1516 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001517 parser.add_option("--default_presubmit")
1518 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001519 parser.add_option("--skip_canned", action='append', default=[],
1520 help="A list of checks to skip which appear in "
1521 "presubmit_canned_checks. Can be provided multiple times "
1522 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001523 parser.add_option("--dry_run", action='store_true',
1524 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001525 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001526 parser.add_option("--gerrit_fetch", action='store_true',
1527 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001528 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1529 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001530 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1531 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001532 # These are for OAuth2 authentication for bots. See also apply_issue.py
1533 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1534 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1535
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001536 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001537 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001538 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001539
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001540 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001541 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001542 elif options.verbose:
1543 logging.basicConfig(level=logging.INFO)
1544 else:
1545 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001546
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001547 if (any((options.rietveld_url, options.rietveld_email_file,
1548 options.rietveld_fetch, options.rietveld_private_key_file))
1549 and any((options.gerrit_url, options.gerrit_fetch))):
1550 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1551 'allowed')
1552
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001553 if options.rietveld_email and options.rietveld_email_file:
1554 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1555 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001556 if options.rietveld_email_file:
1557 with open(options.rietveld_email_file, "rb") as f:
1558 options.rietveld_email = f.read().strip()
1559
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001560 change_class, files = load_files(options, args)
1561 if not change_class:
1562 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001563 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001564
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001565 rietveld_obj, gerrit_obj = None, None
1566
maruel@chromium.org239f4112011-06-03 20:08:23 +00001567 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001568 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001569 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001570 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1571 options.rietveld_url,
1572 options.rietveld_email,
1573 options.rietveld_private_key_file)
1574 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001575 rietveld_obj = rietveld.CachingRietveld(
1576 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001577 auth_config,
1578 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001579 if options.rietveld_fetch:
1580 assert options.issue
1581 props = rietveld_obj.get_issue_properties(options.issue, False)
1582 options.author = props['owner_email']
1583 options.description = props['description']
1584 logging.info('Got author: "%s"', options.author)
1585 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001586
1587 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001588 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001589 rietveld_obj = None
1590 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1591 options.author = gerrit_obj.GetChangeOwner(options.issue)
1592 options.description = gerrit_obj.GetChangeDescription(options.issue,
1593 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001594 logging.info('Got author: "%s"', options.author)
1595 logging.info('Got description: """\n%s\n"""', options.description)
1596
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001597 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001598 with canned_check_filter(options.skip_canned):
1599 results = DoPresubmitChecks(
1600 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001601 options.description,
1602 options.root,
1603 files,
1604 options.issue,
1605 options.patchset,
1606 options.author,
1607 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001608 options.commit,
1609 options.verbose,
1610 sys.stdout,
1611 sys.stdin,
1612 options.default_presubmit,
1613 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001614 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001615 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001616 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001617 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001618 except NonexistantCannedCheckFilter, e:
1619 print >> sys.stderr, (
1620 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1621 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001622 except PresubmitFailure, e:
1623 print >> sys.stderr, e
1624 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1625 print >> sys.stderr, 'If all fails, contact maruel@'
1626 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001627
1628
1629if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001630 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001631 try:
1632 sys.exit(main())
1633 except KeyboardInterrupt:
1634 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001635 sys.exit(2)