blob: ffe33cadfbde18ccc1692d87c71da24b28c0b550 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
dcheng091b7db2016-06-16 01:27:51 -070019import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000020import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000039import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000040from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041
42# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000043import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000045import gclient_utils
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000050import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
54
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000055# Ask for feedback only once in program lifetime.
56_ASKED_FOR_FEEDBACK = False
57
58
maruel@chromium.org899e1c12011-04-07 17:03:18 +000059class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000060 pass
61
62
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000063class CommandData(object):
64 def __init__(self, name, cmd, kwargs, message):
65 self.name = name
66 self.cmd = cmd
67 self.kwargs = kwargs
68 self.message = message
69 self.info = None
70
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000071
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000072def normpath(path):
73 '''Version of os.path.normpath that also changes backward slashes to
74 forward slashes when not running on Windows.
75 '''
76 # This is safe to always do because the Windows version of os.path.normpath
77 # will replace forward slashes with backward slashes.
78 path = path.replace(os.sep, '/')
79 return os.path.normpath(path)
80
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000081
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000082def _RightHandSideLinesImpl(affected_files):
83 """Implements RightHandSideLines for InputApi and GclChange."""
84 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000085 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000086 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000087 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000088
89
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000090class PresubmitOutput(object):
91 def __init__(self, input_stream=None, output_stream=None):
92 self.input_stream = input_stream
93 self.output_stream = output_stream
94 self.reviewers = []
95 self.written_output = []
96 self.error_count = 0
97
98 def prompt_yes_no(self, prompt_string):
99 self.write(prompt_string)
100 if self.input_stream:
101 response = self.input_stream.readline().strip().lower()
102 if response not in ('y', 'yes'):
103 self.fail()
104 else:
105 self.fail()
106
107 def fail(self):
108 self.error_count += 1
109
110 def should_continue(self):
111 return not self.error_count
112
113 def write(self, s):
114 self.written_output.append(s)
115 if self.output_stream:
116 self.output_stream.write(s)
117
118 def getvalue(self):
119 return ''.join(self.written_output)
120
121
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000122# Top level object so multiprocessing can pickle
123# Public access through OutputApi object.
124class _PresubmitResult(object):
125 """Base class for result objects."""
126 fatal = False
127 should_prompt = False
128
129 def __init__(self, message, items=None, long_text=''):
130 """
131 message: A short one-line message to indicate errors.
132 items: A list of short strings to indicate where errors occurred.
133 long_text: multi-line text output, e.g. from another tool
134 """
135 self._message = message
136 self._items = items or []
137 if items:
138 self._items = items
139 self._long_text = long_text.rstrip()
140
141 def handle(self, output):
142 output.write(self._message)
143 output.write('\n')
144 for index, item in enumerate(self._items):
145 output.write(' ')
146 # Write separately in case it's unicode.
147 output.write(str(item))
148 if index < len(self._items) - 1:
149 output.write(' \\')
150 output.write('\n')
151 if self._long_text:
152 output.write('\n***************\n')
153 # Write separately in case it's unicode.
154 output.write(self._long_text)
155 output.write('\n***************\n')
156 if self.fatal:
157 output.fail()
158
159
160# Top level object so multiprocessing can pickle
161# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000162class _PresubmitError(_PresubmitResult):
163 """A hard presubmit error."""
164 fatal = True
165
166
167# Top level object so multiprocessing can pickle
168# Public access through OutputApi object.
169class _PresubmitPromptWarning(_PresubmitResult):
170 """An warning that prompts the user if they want to continue."""
171 should_prompt = True
172
173
174# Top level object so multiprocessing can pickle
175# Public access through OutputApi object.
176class _PresubmitNotifyResult(_PresubmitResult):
177 """Just print something to the screen -- but it's not even a warning."""
178 pass
179
180
181# Top level object so multiprocessing can pickle
182# Public access through OutputApi object.
183class _MailTextResult(_PresubmitResult):
184 """A warning that should be included in the review request email."""
185 def __init__(self, *args, **kwargs):
186 super(_MailTextResult, self).__init__()
187 raise NotImplementedError()
188
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000189class GerritAccessor(object):
190 """Limited Gerrit functionality for canned presubmit checks to work.
191
192 To avoid excessive Gerrit calls, caches the results.
193 """
194
195 def __init__(self, host):
196 self.host = host
197 self.cache = {}
198
199 def _FetchChangeDetail(self, issue):
200 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100201 try:
202 return gerrit_util.GetChangeDetail(
203 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700204 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100205 except gerrit_util.GerritError as e:
206 if e.http_status == 404:
207 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
208 'no credentials to fetch issue details' % issue)
209 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000210
211 def GetChangeInfo(self, issue):
212 """Returns labels and all revisions (patchsets) for this issue.
213
214 The result is a dictionary according to Gerrit REST Api.
215 https://gerrit-review.googlesource.com/Documentation/rest-api.html
216
217 However, API isn't very clear what's inside, so see tests for example.
218 """
219 assert issue
220 cache_key = int(issue)
221 if cache_key not in self.cache:
222 self.cache[cache_key] = self._FetchChangeDetail(issue)
223 return self.cache[cache_key]
224
225 def GetChangeDescription(self, issue, patchset=None):
226 """If patchset is none, fetches current patchset."""
227 info = self.GetChangeInfo(issue)
228 # info is a reference to cache. We'll modify it here adding description to
229 # it to the right patchset, if it is not yet there.
230
231 # Find revision info for the patchset we want.
232 if patchset is not None:
233 for rev, rev_info in info['revisions'].iteritems():
234 if str(rev_info['_number']) == str(patchset):
235 break
236 else:
237 raise Exception('patchset %s doesn\'t exist in issue %s' % (
238 patchset, issue))
239 else:
240 rev = info['current_revision']
241 rev_info = info['revisions'][rev]
242
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100243 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000244
245 def GetChangeOwner(self, issue):
246 return self.GetChangeInfo(issue)['owner']['email']
247
248 def GetChangeReviewers(self, issue, approving_only=True):
agable565adb52016-07-22 14:48:07 -0700249 cr = self.GetChangeInfo(issue)['labels']['Code-Review']
250 max_value = max(int(k) for k in cr['values'].keys())
Aaron Gablef5644a92016-12-02 15:31:58 -0800251 return [r.get('email') for r in cr.get('all', [])
agable565adb52016-07-22 14:48:07 -0700252 if not approving_only or r.get('value', 0) == max_value]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000253
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000254
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000255class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000256 """An instance of OutputApi gets passed to presubmit scripts so that they
257 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000258 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000259 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000260 PresubmitError = _PresubmitError
261 PresubmitPromptWarning = _PresubmitPromptWarning
262 PresubmitNotifyResult = _PresubmitNotifyResult
263 MailTextResult = _MailTextResult
264
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000265 def __init__(self, is_committing):
266 self.is_committing = is_committing
267
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000268 def PresubmitPromptOrNotify(self, *args, **kwargs):
269 """Warn the user when uploading, but only notify if committing."""
270 if self.is_committing:
271 return self.PresubmitNotifyResult(*args, **kwargs)
272 return self.PresubmitPromptWarning(*args, **kwargs)
273
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800274 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
275 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
276
277 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
278 keeping it alphabetically sorted. Returns the results that should be
279 returned from the PostUploadHook.
280
281 Args:
282 cl: The git_cl.Changelist object.
283 bots_to_include: A list of strings of bots to include, in the form
284 "master:slave".
285 message: A message to be printed in the case that
286 CQ_INCLUDE_TRYBOTS was updated.
287 """
288 description = cl.GetDescription(force=True)
289 all_bots = []
290 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)', re.M | re.I)
291 m = include_re.search(description)
292 if m:
293 all_bots = [i.strip() for i in m.group(1).split(';') if i.strip()]
294 if set(all_bots) >= set(bots_to_include):
295 return []
296 # Sort the bots to keep them in some consistent order -- not required.
297 all_bots = sorted(set(all_bots) | set(bots_to_include))
298 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(all_bots)
299 if m:
300 new_description = include_re.sub(new_include_trybots, description)
301 else:
302 new_description = description + '\n' + new_include_trybots + '\n'
303 cl.UpdateDescription(new_description, force=True)
304 return [self.PresubmitNotifyResult(message)]
305
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000306
307class InputApi(object):
308 """An instance of this object is passed to presubmit scripts so they can
309 know stuff about the change they're looking at.
310 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000311 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800312 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000313
maruel@chromium.org3410d912009-06-09 20:56:16 +0000314 # File extensions that are considered source files from a style guide
315 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000316 #
317 # Files without an extension aren't included in the list. If you want to
318 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
319 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000320 DEFAULT_WHITE_LIST = (
321 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000322 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
323 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000324 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000325 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000326 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000327 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000328 )
329
330 # Path regexp that should be excluded from being considered containing source
331 # files. Don't modify this list from a presubmit script!
332 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000333 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000334 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000335 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
336 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000337 # Output directories (just in case)
338 r".*\bDebug[\\\/].*",
339 r".*\bRelease[\\\/].*",
340 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000341 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000342 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000343 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000344 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000345 r"(|.*[\\\/])\.git[\\\/].*",
346 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000347 # There is no point in processing a patch file.
348 r".+\.diff$",
349 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000350 )
351
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000352 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000353 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000354 """Builds an InputApi object.
355
356 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000357 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000358 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000359 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000360 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000361 gerrit_obj: provides basic Gerrit codereview functionality.
362 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000363 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000364 # Version number of the presubmit_support script.
365 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000366 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000367 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000368 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000369 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000370 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000371 # TBD
372 self.host_url = 'http://codereview.chromium.org'
373 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000374 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000375
376 # We expose various modules and functions as attributes of the input_api
377 # so that presubmit scripts don't have to import them.
378 self.basename = os.path.basename
379 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000380 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000381 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700382 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000383 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000384 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000385 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000386 self.os_listdir = os.listdir
387 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000388 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000389 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000390 self.pickle = pickle
391 self.marshal = marshal
392 self.re = re
393 self.subprocess = subprocess
394 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000395 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000396 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000397 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000398 self.urllib2 = urllib2
399
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000400 # To easily fork python.
401 self.python_executable = sys.executable
402 self.environ = os.environ
403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404 # InputApi.platform is the platform you're currently running on.
405 self.platform = sys.platform
406
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000407 self.cpu_count = multiprocessing.cpu_count()
408
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000409 # this is done here because in RunTests, the current working directory has
410 # changed, which causes Pool() to explode fantastically when run on windows
411 # (because it tries to load the __main__ module, which imports lots of
412 # things relative to the current working directory).
413 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
414
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000415 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000416 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000417
418 # We carry the canned checks so presubmit scripts can easily use them.
419 self.canned_checks = presubmit_canned_checks
420
Jochen Eisinger72606f82017-04-04 10:44:18 +0200421
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000422 # TODO(dpranke): figure out a list of all approved owners for a repo
423 # in order to be able to handle wildcard OWNERS files?
424 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200425 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200426 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000427 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000428 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000429
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000430 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000431 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000432 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800433 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000434 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000435 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000436 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
437 for (a, b, header) in cpplint._re_pattern_templates
438 ]
439
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000440 def PresubmitLocalPath(self):
441 """Returns the local path of the presubmit script currently being run.
442
443 This is useful if you don't want to hard-code absolute paths in the
444 presubmit script. For example, It can be used to find another file
445 relative to the PRESUBMIT.py script, so the whole tree can be branched and
446 the presubmit script still works, without editing its content.
447 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000448 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000449
agable0b65e732016-11-22 09:25:46 -0800450 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000451 """Same as input_api.change.AffectedFiles() except only lists files
452 (and optionally directories) in the same directory as the current presubmit
453 script, or subdirectories thereof.
454 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000455 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000456 if len(dir_with_slash) == 1:
457 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000458
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000459 return filter(
460 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800461 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462
agable0b65e732016-11-22 09:25:46 -0800463 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000464 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800465 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000466 logging.debug("LocalPaths: %s", paths)
467 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000468
agable0b65e732016-11-22 09:25:46 -0800469 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800471 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000472
agable0b65e732016-11-22 09:25:46 -0800473 def AffectedTestableFiles(self, include_deletes=None):
474 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000475 in the same directory as the current presubmit script, or subdirectories
476 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000477 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000478 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800479 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000480 " is deprecated and ignored" % str(include_deletes),
481 category=DeprecationWarning,
482 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800483 return filter(lambda x: x.IsTestableFile(),
484 self.AffectedFiles(include_deletes=False))
485
486 def AffectedTextFiles(self, include_deletes=None):
487 """An alias to AffectedTestableFiles for backwards compatibility."""
488 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
491 """Filters out files that aren't considered "source file".
492
493 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
494 and InputApi.DEFAULT_BLACK_LIST is used respectively.
495
496 The lists will be compiled as regular expression and
497 AffectedFile.LocalPath() needs to pass both list.
498
499 Note: Copy-paste this function to suit your needs or use a lambda function.
500 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000501 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000502 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000503 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000504 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 return True
506 return False
507 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
508 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
509
510 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800511 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512
513 If source_file is None, InputApi.FilterSourceFile() is used.
514 """
515 if not source_file:
516 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800517 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518
519 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000520 """An iterator over all text lines in "new" version of changed files.
521
522 Only lists lines from new or modified text files in the change that are
523 contained by the directory of the currently executing presubmit script.
524
525 This is useful for doing line-by-line regex checks, like checking for
526 trailing whitespace.
527
528 Yields:
529 a 3 tuple:
530 the AffectedFile instance of the current file;
531 integer line number (1-based); and
532 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000533
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000534 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000535 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000536 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000537 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000538
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000539 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000540 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000541
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000542 Deny reading anything outside the repository.
543 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000544 if isinstance(file_item, AffectedFile):
545 file_item = file_item.AbsoluteLocalPath()
546 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000547 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000548 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000549
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000550 @property
551 def tbr(self):
552 """Returns if a change is TBR'ed."""
553 return 'TBR' in self.change.tags
554
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000555 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000556 tests = []
557 msgs = []
558 for t in tests_mix:
559 if isinstance(t, OutputApi.PresubmitResult):
560 msgs.append(t)
561 else:
562 assert issubclass(t.message, _PresubmitResult)
563 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000564 if self.verbose:
565 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000566 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000567 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000568 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000569 else:
570 msgs.extend(map(CallCommand, tests))
571 return [m for m in msgs if m]
572
scottmg86099d72016-09-01 09:16:51 -0700573 def ShutdownPool(self):
574 self._run_tests_pool.close()
575 self._run_tests_pool.join()
576 self._run_tests_pool = None
577
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000578
nick@chromium.orgff526192013-06-10 19:30:26 +0000579class _DiffCache(object):
580 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000581 def __init__(self, upstream=None):
582 """Stores the upstream revision against which all diffs will be computed."""
583 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000584
585 def GetDiff(self, path, local_root):
586 """Get the diff for a particular path."""
587 raise NotImplementedError()
588
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700589 def GetOldContents(self, path, local_root):
590 """Get the old version for a particular path."""
591 raise NotImplementedError()
592
nick@chromium.orgff526192013-06-10 19:30:26 +0000593
nick@chromium.orgff526192013-06-10 19:30:26 +0000594class _GitDiffCache(_DiffCache):
595 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000596 def __init__(self, upstream):
597 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000598 self._diffs_by_file = None
599
600 def GetDiff(self, path, local_root):
601 if not self._diffs_by_file:
602 # Compute a single diff for all files and parse the output; should
603 # with git this is much faster than computing one diff for each file.
604 diffs = {}
605
606 # Don't specify any filenames below, because there are command line length
607 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000608 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
609 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000610
611 # This regex matches the path twice, separated by a space. Note that
612 # filename itself may contain spaces.
613 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
614 current_diff = []
615 keep_line_endings = True
616 for x in unified_diff.splitlines(keep_line_endings):
617 match = file_marker.match(x)
618 if match:
619 # Marks the start of a new per-file section.
620 diffs[match.group('filename')] = current_diff = [x]
621 elif x.startswith('diff --git'):
622 raise PresubmitFailure('Unexpected diff line: %s' % x)
623 else:
624 current_diff.append(x)
625
626 self._diffs_by_file = dict(
627 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
628
629 if path not in self._diffs_by_file:
630 raise PresubmitFailure(
631 'Unified diff did not contain entry for file %s' % path)
632
633 return self._diffs_by_file[path]
634
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700635 def GetOldContents(self, path, local_root):
636 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
637
nick@chromium.orgff526192013-06-10 19:30:26 +0000638
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639class AffectedFile(object):
640 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000641
642 DIFF_CACHE = _DiffCache
643
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000644 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800645 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000646 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000647 self._path = path
648 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000649 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000650 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000651 self._cached_changed_contents = None
652 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000653 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700654 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656 def LocalPath(self):
657 """Returns the path of this file on the local disk relative to client root.
658 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000659 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000660
661 def AbsoluteLocalPath(self):
662 """Returns the absolute path of this file on the local disk.
663 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000664 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000665
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000666 def Action(self):
667 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000668 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000669
agable0b65e732016-11-22 09:25:46 -0800670 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000671 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000672
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000673 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000674 raise NotImplementedError() # Implement when needed
675
agable0b65e732016-11-22 09:25:46 -0800676 def IsTextFile(self):
677 """An alias to IsTestableFile for backwards compatibility."""
678 return self.IsTestableFile()
679
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700680 def OldContents(self):
681 """Returns an iterator over the lines in the old version of file.
682
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700683 The old version is the file before any modifications in the user's
684 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700685
686 Contents will be empty if the file is a directory or does not exist.
687 Note: The carriage returns (LF or CR) are stripped off.
688 """
689 return self._diff_cache.GetOldContents(self.LocalPath(),
690 self._local_root).splitlines()
691
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000692 def NewContents(self):
693 """Returns an iterator over the lines in the new version of file.
694
695 The new version is the file in the user's workspace, i.e. the "right hand
696 side".
697
698 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000699 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000701 if self._cached_new_contents is None:
702 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800703 try:
704 self._cached_new_contents = gclient_utils.FileRead(
705 self.AbsoluteLocalPath(), 'rU').splitlines()
706 except IOError:
707 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000708 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000709
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000710 def ChangedContents(self):
711 """Returns a list of tuples (line number, line text) of all new lines.
712
713 This relies on the scm diff output describing each changed code section
714 with a line of the form
715
716 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
717 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000718 if self._cached_changed_contents is not None:
719 return self._cached_changed_contents[:]
720 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000721 line_num = 0
722
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000723 for line in self.GenerateScmDiff().splitlines():
724 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
725 if m:
726 line_num = int(m.groups(1)[0])
727 continue
728 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000729 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000730 if not line.startswith('-'):
731 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000732 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000733
maruel@chromium.org5de13972009-06-10 18:16:06 +0000734 def __str__(self):
735 return self.LocalPath()
736
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000737 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000738 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000739
maruel@chromium.org58407af2011-04-12 23:15:57 +0000740
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000741class GitAffectedFile(AffectedFile):
742 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000743 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800744 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000745
nick@chromium.orgff526192013-06-10 19:30:26 +0000746 DIFF_CACHE = _GitDiffCache
747
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000748 def __init__(self, *args, **kwargs):
749 AffectedFile.__init__(self, *args, **kwargs)
750 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800751 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000752
agable0b65e732016-11-22 09:25:46 -0800753 def IsTestableFile(self):
754 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000755 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800756 # A deleted file is not testable.
757 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000758 else:
agable0b65e732016-11-22 09:25:46 -0800759 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
760 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000761
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000762
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000763class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000764 """Describe a change.
765
766 Used directly by the presubmit scripts to query the current change being
767 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000768
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000769 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000770 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000771 self.KEY: equivalent to tags['KEY']
772 """
773
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000774 _AFFECTED_FILES = AffectedFile
775
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000776 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000777 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000778 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000779 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000780
maruel@chromium.org58407af2011-04-12 23:15:57 +0000781 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000782 self, name, description, local_root, files, issue, patchset, author,
783 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000784 if files is None:
785 files = []
786 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000787 # Convert root into an absolute path.
788 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000789 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000790 self.issue = issue
791 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000792 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000793
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000794 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000795 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000796 self._description_without_tags = ''
797 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000798
maruel@chromium.orge085d812011-10-10 19:49:15 +0000799 assert all(
800 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
801
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000802 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000803 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000804 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
805 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000806 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000807
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000808 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000810 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000811
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000812 def DescriptionText(self):
813 """Returns the user-entered changelist description, minus tags.
814
815 Any line in the user-provided description starting with e.g. "FOO="
816 (whitespace permitted before and around) is considered a tag line. Such
817 lines are stripped out of the description this function returns.
818 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000819 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000820
821 def FullDescriptionText(self):
822 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000823 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000824
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000825 def SetDescriptionText(self, description):
826 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000827
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000828 Also updates the list of tags."""
829 self._full_description = description
830
831 # From the description text, build up a dictionary of key/value pairs
832 # plus the description minus all key/value or "tag" lines.
833 description_without_tags = []
834 self.tags = {}
835 for line in self._full_description.splitlines():
836 m = self.TAG_LINE_RE.match(line)
837 if m:
838 self.tags[m.group('key')] = m.group('value')
839 else:
840 description_without_tags.append(line)
841
842 # Change back to text and remove whitespace at end.
843 self._description_without_tags = (
844 '\n'.join(description_without_tags).rstrip())
845
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000846 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000847 """Returns the repository (checkout) root directory for this change,
848 as an absolute path.
849 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000850 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000851
852 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000853 """Return tags directly as attributes on the object."""
854 if not re.match(r"^[A-Z_]*$", attr):
855 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000856 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000857
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000858 def AllFiles(self, root=None):
859 """List all files under source control in the repo."""
860 raise NotImplementedError()
861
agable0b65e732016-11-22 09:25:46 -0800862 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000863 """Returns a list of AffectedFile instances for all files in the change.
864
865 Args:
866 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +0000867 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000868
869 Returns:
870 [AffectedFile(path, action), AffectedFile(path, action)]
871 """
agable0b65e732016-11-22 09:25:46 -0800872 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +0000873
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874 if include_deletes:
875 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -0700876 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000877
agable0b65e732016-11-22 09:25:46 -0800878 def AffectedTestableFiles(self, include_deletes=None):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000879 """Return a list of the existing text files in a change."""
880 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800881 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000882 " is deprecated and ignored" % str(include_deletes),
883 category=DeprecationWarning,
884 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800885 return filter(lambda x: x.IsTestableFile(),
886 self.AffectedFiles(include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887
agable0b65e732016-11-22 09:25:46 -0800888 def AffectedTextFiles(self, include_deletes=None):
889 """An alias to AffectedTestableFiles for backwards compatibility."""
890 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000891
agable0b65e732016-11-22 09:25:46 -0800892 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000893 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800894 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000895
agable0b65e732016-11-22 09:25:46 -0800896 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000897 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800898 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000899
900 def RightHandSideLines(self):
901 """An iterator over all text lines in "new" version of changed files.
902
903 Lists lines from new or modified text files in the change.
904
905 This is useful for doing line-by-line regex checks, like checking for
906 trailing whitespace.
907
908 Yields:
909 a 3 tuple:
910 the AffectedFile instance of the current file;
911 integer line number (1-based); and
912 the contents of the line as a string.
913 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000914 return _RightHandSideLinesImpl(
915 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -0800916 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000917
Jochen Eisingerd0573ec2017-04-13 10:55:06 +0200918 def OriginalOwnersFiles(self):
919 """A map from path names of affected OWNERS files to their old content."""
920 def owners_file_filter(f):
921 return 'OWNERS' in os.path.split(f.LocalPath())[1]
922 files = self.AffectedFiles(file_filter=owners_file_filter)
923 return dict([(f.LocalPath(), f.OldContents()) for f in files])
924
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000925
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000926class GitChange(Change):
927 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000928 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000929
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000930 def AllFiles(self, root=None):
931 """List all files under source control in the repo."""
932 root = root or self.RepositoryRoot()
933 return subprocess.check_output(
934 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
935
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000936
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000937def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000938 """Finds all presubmit files that apply to a given set of source files.
939
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000940 If inherit-review-settings-ok is present right under root, looks for
941 PRESUBMIT.py in directories enclosing root.
942
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943 Args:
944 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000945 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000946
947 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000948 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000950 files = [normpath(os.path.join(root, f)) for f in files]
951
952 # List all the individual directories containing files.
953 directories = set([os.path.dirname(f) for f in files])
954
955 # Ignore root if inherit-review-settings-ok is present.
956 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
957 root = None
958
959 # Collect all unique directories that may contain PRESUBMIT.py.
960 candidates = set()
961 for directory in directories:
962 while True:
963 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000964 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000965 candidates.add(directory)
966 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000967 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000968 parent_dir = os.path.dirname(directory)
969 if parent_dir == directory:
970 # We hit the system root directory.
971 break
972 directory = parent_dir
973
974 # Look for PRESUBMIT.py in all candidate directories.
975 results = []
976 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -0700977 try:
978 for f in os.listdir(directory):
979 p = os.path.join(directory, f)
980 if os.path.isfile(p) and re.match(
981 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
982 results.append(p)
983 except OSError:
984 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000985
tobiasjs2836bcf2016-08-16 04:08:16 -0700986 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000987 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000988
989
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +0000990class GetTryMastersExecuter(object):
991 @staticmethod
992 def ExecPresubmitScript(script_text, presubmit_path, project, change):
993 """Executes GetPreferredTryMasters() from a single presubmit script.
994
995 Args:
996 script_text: The text of the presubmit script.
997 presubmit_path: Project script to run.
998 project: Project name to pass to presubmit script for bot selection.
999
1000 Return:
1001 A map of try masters to map of builders to set of tests.
1002 """
1003 context = {}
1004 try:
1005 exec script_text in context
1006 except Exception, e:
1007 raise PresubmitFailure('"%s" had an exception.\n%s'
1008 % (presubmit_path, e))
1009
1010 function_name = 'GetPreferredTryMasters'
1011 if function_name not in context:
1012 return {}
1013 get_preferred_try_masters = context[function_name]
1014 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1015 raise PresubmitFailure(
1016 'Expected function "GetPreferredTryMasters" to take two arguments.')
1017 return get_preferred_try_masters(project, change)
1018
1019
rmistry@google.com5626a922015-02-26 14:03:30 +00001020class GetPostUploadExecuter(object):
1021 @staticmethod
1022 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1023 """Executes PostUploadHook() from a single presubmit script.
1024
1025 Args:
1026 script_text: The text of the presubmit script.
1027 presubmit_path: Project script to run.
1028 cl: The Changelist object.
1029 change: The Change object.
1030
1031 Return:
1032 A list of results objects.
1033 """
1034 context = {}
1035 try:
1036 exec script_text in context
1037 except Exception, e:
1038 raise PresubmitFailure('"%s" had an exception.\n%s'
1039 % (presubmit_path, e))
1040
1041 function_name = 'PostUploadHook'
1042 if function_name not in context:
1043 return {}
1044 post_upload_hook = context[function_name]
1045 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1046 raise PresubmitFailure(
1047 'Expected function "PostUploadHook" to take three arguments.')
1048 return post_upload_hook(cl, change, OutputApi(False))
1049
1050
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001051def _MergeMasters(masters1, masters2):
1052 """Merges two master maps. Merges also the tests of each builder."""
1053 result = {}
1054 for (master, builders) in itertools.chain(masters1.iteritems(),
1055 masters2.iteritems()):
1056 new_builders = result.setdefault(master, {})
1057 for (builder, tests) in builders.iteritems():
1058 new_builders.setdefault(builder, set([])).update(tests)
1059 return result
1060
1061
1062def DoGetTryMasters(change,
1063 changed_files,
1064 repository_root,
1065 default_presubmit,
1066 project,
1067 verbose,
1068 output_stream):
1069 """Get the list of try masters from the presubmit scripts.
1070
1071 Args:
1072 changed_files: List of modified files.
1073 repository_root: The repository root.
1074 default_presubmit: A default presubmit script to execute in any case.
1075 project: Optional name of a project used in selecting trybots.
1076 verbose: Prints debug info.
1077 output_stream: A stream to write debug output to.
1078
1079 Return:
1080 Map of try masters to map of builders to set of tests.
1081 """
1082 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1083 if not presubmit_files and verbose:
1084 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1085 results = {}
1086 executer = GetTryMastersExecuter()
1087
1088 if default_presubmit:
1089 if verbose:
1090 output_stream.write("Running default presubmit script.\n")
1091 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1092 results = _MergeMasters(results, executer.ExecPresubmitScript(
1093 default_presubmit, fake_path, project, change))
1094 for filename in presubmit_files:
1095 filename = os.path.abspath(filename)
1096 if verbose:
1097 output_stream.write("Running %s\n" % filename)
1098 # Accept CRLF presubmit script.
1099 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1100 results = _MergeMasters(results, executer.ExecPresubmitScript(
1101 presubmit_script, filename, project, change))
1102
1103 # Make sets to lists again for later JSON serialization.
1104 for builders in results.itervalues():
1105 for builder in builders:
1106 builders[builder] = list(builders[builder])
1107
1108 if results and verbose:
1109 output_stream.write('%s\n' % str(results))
1110 return results
1111
1112
rmistry@google.com5626a922015-02-26 14:03:30 +00001113def DoPostUploadExecuter(change,
1114 cl,
1115 repository_root,
1116 verbose,
1117 output_stream):
1118 """Execute the post upload hook.
1119
1120 Args:
1121 change: The Change object.
1122 cl: The Changelist object.
1123 repository_root: The repository root.
1124 verbose: Prints debug info.
1125 output_stream: A stream to write debug output to.
1126 """
1127 presubmit_files = ListRelevantPresubmitFiles(
1128 change.LocalPaths(), repository_root)
1129 if not presubmit_files and verbose:
1130 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1131 results = []
1132 executer = GetPostUploadExecuter()
1133 # The root presubmit file should be executed after the ones in subdirectories.
1134 # i.e. the specific post upload hooks should run before the general ones.
1135 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1136 presubmit_files.reverse()
1137
1138 for filename in presubmit_files:
1139 filename = os.path.abspath(filename)
1140 if verbose:
1141 output_stream.write("Running %s\n" % filename)
1142 # Accept CRLF presubmit script.
1143 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1144 results.extend(executer.ExecPresubmitScript(
1145 presubmit_script, filename, cl, change))
1146 output_stream.write('\n')
1147 if results:
1148 output_stream.write('** Post Upload Hook Messages **\n')
1149 for result in results:
1150 result.handle(output_stream)
1151 output_stream.write('\n')
1152
1153 return results
1154
1155
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001156class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001157 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001158 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001159 """
1160 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001161 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001162 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001163 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001164 gerrit_obj: provides basic Gerrit codereview functionality.
1165 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001166 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001167 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001169 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001170 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001171 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001172 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001173
1174 def ExecPresubmitScript(self, script_text, presubmit_path):
1175 """Executes a single presubmit script.
1176
1177 Args:
1178 script_text: The text of the presubmit script.
1179 presubmit_path: The path to the presubmit file (this will be reported via
1180 input_api.PresubmitLocalPath()).
1181
1182 Return:
1183 A list of result objects, empty if no problems.
1184 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001185
chase@chromium.org8e416c82009-10-06 04:30:44 +00001186 # Change to the presubmit file's directory to support local imports.
1187 main_path = os.getcwd()
1188 os.chdir(os.path.dirname(presubmit_path))
1189
1190 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001191 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001192 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001193 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001194 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001195 try:
1196 exec script_text in context
1197 except Exception, e:
1198 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001199
1200 # These function names must change if we make substantial changes to
1201 # the presubmit API that are not backwards compatible.
1202 if self.committing:
1203 function_name = 'CheckChangeOnCommit'
1204 else:
1205 function_name = 'CheckChangeOnUpload'
1206 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001207 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001208 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001209 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001210 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001211 if not (isinstance(result, types.TupleType) or
1212 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001213 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001214 'Presubmit functions must return a tuple or list')
1215 for item in result:
1216 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001217 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001218 'All presubmit results must be of types derived from '
1219 'output_api.PresubmitResult')
1220 else:
1221 result = () # no error since the script doesn't care about current event.
1222
scottmg86099d72016-09-01 09:16:51 -07001223 input_api.ShutdownPool()
1224
chase@chromium.org8e416c82009-10-06 04:30:44 +00001225 # Return the process to the original working directory.
1226 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227 return result
1228
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001229def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001230 committing,
1231 verbose,
1232 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001233 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001234 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001235 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001236 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001237 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001238 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239 """Runs all presubmit checks that apply to the files in the change.
1240
1241 This finds all PRESUBMIT.py files in directories enclosing the files in the
1242 change (up to the repository root) and calls the relevant entrypoint function
1243 depending on whether the change is being committed or uploaded.
1244
1245 Prints errors, warnings and notifications. Prompts the user for warnings
1246 when needed.
1247
1248 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001249 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001250 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251 verbose: Prints debug info.
1252 output_stream: A stream to write output from presubmit tests to.
1253 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001254 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001255 may_prompt: Enable (y/n) questions on warning or error. If False,
1256 any questions are answered with yes by default.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001257 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001258 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001259 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001260
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001261 Warning:
1262 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1263 SHOULD be sys.stdin.
1264
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001265 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001266 A PresubmitOutput object. Use output.should_continue() to figure out
1267 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001268 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001269 old_environ = os.environ
1270 try:
1271 # Make sure python subprocesses won't generate .pyc files.
1272 os.environ = os.environ.copy()
1273 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001275 output = PresubmitOutput(input_stream, output_stream)
1276 if committing:
1277 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001278 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001279 output.write("Running presubmit upload checks ...\n")
1280 start_time = time.time()
1281 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001282 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001283 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001284 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001285 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001286 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001287 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001288 if default_presubmit:
1289 if verbose:
1290 output.write("Running default presubmit script.\n")
1291 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1292 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1293 for filename in presubmit_files:
1294 filename = os.path.abspath(filename)
1295 if verbose:
1296 output.write("Running %s\n" % filename)
1297 # Accept CRLF presubmit script.
1298 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1299 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001301 errors = []
1302 notifications = []
1303 warnings = []
1304 for result in results:
1305 if result.fatal:
1306 errors.append(result)
1307 elif result.should_prompt:
1308 warnings.append(result)
1309 else:
1310 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001311
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001312 output.write('\n')
1313 for name, items in (('Messages', notifications),
1314 ('Warnings', warnings),
1315 ('ERRORS', errors)):
1316 if items:
1317 output.write('** Presubmit %s **\n' % name)
1318 for item in items:
1319 item.handle(output)
1320 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001321
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001322 total_time = time.time() - start_time
1323 if total_time > 1.0:
1324 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001325
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001326 if errors:
1327 output.fail()
1328 elif warnings:
1329 output.write('There were presubmit warnings. ')
1330 if may_prompt:
1331 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1332 else:
1333 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001334
1335 global _ASKED_FOR_FEEDBACK
1336 # Ask for feedback one time out of 5.
1337 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001338 output.write(
1339 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1340 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1341 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001342 _ASKED_FOR_FEEDBACK = True
1343 return output
1344 finally:
1345 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001346
1347
1348def ScanSubDirs(mask, recursive):
1349 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001350 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001351
1352 results = []
1353 for root, dirs, files in os.walk('.'):
1354 if '.svn' in dirs:
1355 dirs.remove('.svn')
1356 if '.git' in dirs:
1357 dirs.remove('.git')
1358 for name in files:
1359 if fnmatch.fnmatch(name, mask):
1360 results.append(os.path.join(root, name))
1361 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001362
1363
1364def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001365 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001366 files = []
1367 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001368 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001369 return files
1370
1371
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001372def load_files(options, args):
1373 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001374 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001375 if args:
1376 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001377 change_scm = scm.determine_scm(options.root)
1378 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001379 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001380 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001381 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001382 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001383 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001384 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001385 if not files:
1386 return None, None
1387 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001388 return change_class, files
1389
1390
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001391class NonexistantCannedCheckFilter(Exception):
1392 pass
1393
1394
1395@contextlib.contextmanager
1396def canned_check_filter(method_names):
1397 filtered = {}
1398 try:
1399 for method_name in method_names:
1400 if not hasattr(presubmit_canned_checks, method_name):
1401 raise NonexistantCannedCheckFilter(method_name)
1402 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1403 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1404 yield
1405 finally:
1406 for name, method in filtered.iteritems():
1407 setattr(presubmit_canned_checks, name, method)
1408
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001409
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001410def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001411 """Runs an external program, potentially from a child process created by the
1412 multiprocessing module.
1413
1414 multiprocessing needs a top level function with a single argument.
1415 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001416 cmd_data.kwargs['stdout'] = subprocess.PIPE
1417 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1418 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001419 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001420 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001421 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001422 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001423 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001424 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001425 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1426 if code != 0:
1427 return cmd_data.message(
1428 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1429 if cmd_data.info:
1430 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001431
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001432
sbc@chromium.org013731e2015-02-26 18:28:43 +00001433def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001434 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001435 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001436 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001437 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001438 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1439 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001440 parser.add_option("-r", "--recursive", action="store_true",
1441 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001442 parser.add_option("-v", "--verbose", action="count", default=0,
1443 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001444 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001445 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001446 parser.add_option("--description", default='')
1447 parser.add_option("--issue", type='int', default=0)
1448 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001449 parser.add_option("--root", default=os.getcwd(),
1450 help="Search for PRESUBMIT.py up to this directory. "
1451 "If inherit-review-settings-ok is present in this "
1452 "directory, parent directories up to the root file "
1453 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001454 parser.add_option("--upstream",
1455 help="Git only: the base ref or upstream branch against "
1456 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001457 parser.add_option("--default_presubmit")
1458 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001459 parser.add_option("--skip_canned", action='append', default=[],
1460 help="A list of checks to skip which appear in "
1461 "presubmit_canned_checks. Can be provided multiple times "
1462 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001463 parser.add_option("--dry_run", action='store_true',
1464 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001465 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001466 parser.add_option("--gerrit_fetch", action='store_true',
1467 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001468 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1469 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001470 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1471 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001472 # These are for OAuth2 authentication for bots. See also apply_issue.py
1473 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1474 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1475
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001476 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001477 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001478 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001479
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001480 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001481 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001482 elif options.verbose:
1483 logging.basicConfig(level=logging.INFO)
1484 else:
1485 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001486
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001487 if (any((options.rietveld_url, options.rietveld_email_file,
1488 options.rietveld_fetch, options.rietveld_private_key_file))
1489 and any((options.gerrit_url, options.gerrit_fetch))):
1490 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1491 'allowed')
1492
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001493 if options.rietveld_email and options.rietveld_email_file:
1494 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1495 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001496 if options.rietveld_email_file:
1497 with open(options.rietveld_email_file, "rb") as f:
1498 options.rietveld_email = f.read().strip()
1499
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001500 change_class, files = load_files(options, args)
1501 if not change_class:
1502 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001503 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001504
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001505 rietveld_obj, gerrit_obj = None, None
1506
maruel@chromium.org239f4112011-06-03 20:08:23 +00001507 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001508 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001509 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001510 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1511 options.rietveld_url,
1512 options.rietveld_email,
1513 options.rietveld_private_key_file)
1514 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001515 rietveld_obj = rietveld.CachingRietveld(
1516 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001517 auth_config,
1518 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001519 if options.rietveld_fetch:
1520 assert options.issue
1521 props = rietveld_obj.get_issue_properties(options.issue, False)
1522 options.author = props['owner_email']
1523 options.description = props['description']
1524 logging.info('Got author: "%s"', options.author)
1525 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001526
1527 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001528 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001529 rietveld_obj = None
1530 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1531 options.author = gerrit_obj.GetChangeOwner(options.issue)
1532 options.description = gerrit_obj.GetChangeDescription(options.issue,
1533 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001534 logging.info('Got author: "%s"', options.author)
1535 logging.info('Got description: """\n%s\n"""', options.description)
1536
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001537 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001538 with canned_check_filter(options.skip_canned):
1539 results = DoPresubmitChecks(
1540 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001541 options.description,
1542 options.root,
1543 files,
1544 options.issue,
1545 options.patchset,
1546 options.author,
1547 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001548 options.commit,
1549 options.verbose,
1550 sys.stdout,
1551 sys.stdin,
1552 options.default_presubmit,
1553 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001554 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001555 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001556 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001557 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001558 except NonexistantCannedCheckFilter, e:
1559 print >> sys.stderr, (
1560 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1561 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001562 except PresubmitFailure, e:
1563 print >> sys.stderr, e
1564 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1565 print >> sys.stderr, 'If all fails, contact maruel@'
1566 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001567
1568
1569if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001570 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001571 try:
1572 sys.exit(main())
1573 except KeyboardInterrupt:
1574 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001575 sys.exit(2)