blob: 014dbdafa4e83b2bcd531c1daf5a87351c77b0fb [file] [log] [blame]
iannucci@chromium.org405b87e2015-11-12 18:08:34 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00008"""A git-command for integrating reviews on Rietveld and Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000034import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000035import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000036import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000037import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000038
39try:
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080040 import readline # pylint: disable=import-error,W0611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000041except ImportError:
42 pass
43
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000044from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000045from third_party import httplib2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000046from third_party import upload
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000047import auth
skobes6468b902016-10-24 08:45:10 -070048import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000049import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000050import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000051import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000052import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000053import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000054import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000055import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000057import git_footers
piman@chromium.org336f9122014-09-04 02:16:55 +000058import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000059import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000060import presubmit_support
maruel@chromium.orgcab38e92011-04-09 00:30:51 +000061import rietveld
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040063import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000064import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000065import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000066import watchlists
67
tandrii7400cf02016-06-21 08:48:07 -070068__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000069
tandrii9d2c7a32016-06-22 03:42:45 -070070COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
iannuccie7f68952016-08-15 17:45:29 -070071DEFAULT_SERVER = 'https://codereview.chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080072POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000073DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +000074REFS_THAT_ALIAS_TO_OTHER_REFS = {
75 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
76 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
77}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000078
thestig@chromium.org44202a22014-03-11 19:22:18 +000079# Valid extensions for files we want to lint.
80DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
81DEFAULT_LINT_IGNORE_REGEX = r"$^"
82
borenet6c0efe62016-10-19 08:13:29 -070083# Buildbucket master name prefix.
84MASTER_PREFIX = 'master.'
85
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000086# Shortcut since it quickly becomes redundant.
87Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +000088
maruel@chromium.orgddd59412011-11-30 14:20:38 +000089# Initialized in main()
90settings = None
91
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010092# Used by tests/git_cl_test.py to add extra logging.
93# Inside the weirdly failing test, add this:
94# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -070095# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010096_IS_BEING_TESTED = False
97
maruel@chromium.orgddd59412011-11-30 14:20:38 +000098
Christopher Lamf732cd52017-01-24 12:40:11 +110099def DieWithError(message, change_desc=None):
100 if change_desc:
101 SaveDescriptionBackup(change_desc)
102
vapiera7fbd5a2016-06-16 09:17:49 -0700103 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000104 sys.exit(1)
105
106
Christopher Lamf732cd52017-01-24 12:40:11 +1100107def SaveDescriptionBackup(change_desc):
108 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
109 print('\nError after CL description prompt -- saving description to %s\n' %
110 backup_path)
111 backup_file = open(backup_path, 'w')
112 backup_file.write(change_desc.description)
113 backup_file.close()
114
115
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000116def GetNoGitPagerEnv():
117 env = os.environ.copy()
118 # 'cat' is a magical git string that disables pagers on all platforms.
119 env['GIT_PAGER'] = 'cat'
120 return env
121
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000122
bsep@chromium.org627d9002016-04-29 00:00:52 +0000123def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000124 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000125 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000126 except subprocess2.CalledProcessError as e:
127 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000128 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000129 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000130 'Command "%s" failed.\n%s' % (
131 ' '.join(args), error_message or e.stdout or ''))
132 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000133
134
135def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000136 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000137 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000138
139
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000140def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000141 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700142 if suppress_stderr:
143 stderr = subprocess2.VOID
144 else:
145 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000146 try:
tandrii5d48c322016-08-18 16:19:37 -0700147 (out, _), code = subprocess2.communicate(['git'] + args,
148 env=GetNoGitPagerEnv(),
149 stdout=subprocess2.PIPE,
150 stderr=stderr)
151 return code, out
152 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900153 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700154 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000155
156
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000157def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000158 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000159 return RunGitWithCode(args, suppress_stderr=True)[1]
160
161
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000162def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000163 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000164 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000165 return (version.startswith(prefix) and
166 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000167
168
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000169def BranchExists(branch):
170 """Return True if specified branch exists."""
171 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
172 suppress_stderr=True)
173 return not code
174
175
tandrii2a16b952016-10-19 07:09:44 -0700176def time_sleep(seconds):
177 # Use this so that it can be mocked in tests without interfering with python
178 # system machinery.
179 import time # Local import to discourage others from importing time globally.
180 return time.sleep(seconds)
181
182
maruel@chromium.org90541732011-04-01 17:54:18 +0000183def ask_for_data(prompt):
184 try:
185 return raw_input(prompt)
186 except KeyboardInterrupt:
187 # Hide the exception.
188 sys.exit(1)
189
190
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100191def confirm_or_exit(prefix='', action='confirm'):
192 """Asks user to press enter to continue or press Ctrl+C to abort."""
193 if not prefix or prefix.endswith('\n'):
194 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100195 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100196 mid = ' Press'
197 elif prefix.endswith(' '):
198 mid = 'press'
199 else:
200 mid = ' press'
201 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
202
203
204def ask_for_explicit_yes(prompt):
205 """Returns whether user typed 'y' or 'yes' to confirm the given prompt"""
206 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
207 while True:
208 if 'yes'.startswith(result):
209 return True
210 if 'no'.startswith(result):
211 return False
212 result = ask_for_data('Please, type yes or no: ').lower()
213
214
tandrii5d48c322016-08-18 16:19:37 -0700215def _git_branch_config_key(branch, key):
216 """Helper method to return Git config key for a branch."""
217 assert branch, 'branch name is required to set git config for it'
218 return 'branch.%s.%s' % (branch, key)
219
220
221def _git_get_branch_config_value(key, default=None, value_type=str,
222 branch=False):
223 """Returns git config value of given or current branch if any.
224
225 Returns default in all other cases.
226 """
227 assert value_type in (int, str, bool)
228 if branch is False: # Distinguishing default arg value from None.
229 branch = GetCurrentBranch()
230
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000231 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700232 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000233
tandrii5d48c322016-08-18 16:19:37 -0700234 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700235 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700236 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700237 # git config also has --int, but apparently git config suffers from integer
238 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700239 args.append(_git_branch_config_key(branch, key))
240 code, out = RunGitWithCode(args)
241 if code == 0:
242 value = out.strip()
243 if value_type == int:
244 return int(value)
245 if value_type == bool:
246 return bool(value.lower() == 'true')
247 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000248 return default
249
250
tandrii5d48c322016-08-18 16:19:37 -0700251def _git_set_branch_config_value(key, value, branch=None, **kwargs):
252 """Sets the value or unsets if it's None of a git branch config.
253
254 Valid, though not necessarily existing, branch must be provided,
255 otherwise currently checked out branch is used.
256 """
257 if not branch:
258 branch = GetCurrentBranch()
259 assert branch, 'a branch name OR currently checked out branch is required'
260 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700261 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700262 if value is None:
263 args.append('--unset')
264 elif isinstance(value, bool):
265 args.append('--bool')
266 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700267 else:
tandrii33a46ff2016-08-23 05:53:40 -0700268 # git config also has --int, but apparently git config suffers from integer
269 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700270 value = str(value)
271 args.append(_git_branch_config_key(branch, key))
272 if value is not None:
273 args.append(value)
274 RunGit(args, **kwargs)
275
276
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100277def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700278 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100279
280 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
281 """
282 # Git also stores timezone offset, but it only affects visual display,
283 # actual point in time is defined by this timestamp only.
284 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
285
286
287def _git_amend_head(message, committer_timestamp):
288 """Amends commit with new message and desired committer_timestamp.
289
290 Sets committer timezone to UTC.
291 """
292 env = os.environ.copy()
293 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
294 return RunGit(['commit', '--amend', '-m', message], env=env)
295
296
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000297def add_git_similarity(parser):
298 parser.add_option(
tandrii5d48c322016-08-18 16:19:37 -0700299 '--similarity', metavar='SIM', type=int, action='store',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000300 help='Sets the percentage that a pair of files need to match in order to'
301 ' be considered copies (default 50)')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000302 parser.add_option(
303 '--find-copies', action='store_true',
304 help='Allows git to look for copies.')
305 parser.add_option(
306 '--no-find-copies', action='store_false', dest='find_copies',
307 help='Disallows git from looking for copies.')
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000308
309 old_parser_args = parser.parse_args
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700310
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000311 def Parse(args):
312 options, args = old_parser_args(args)
313
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000314 if options.similarity is None:
tandrii5d48c322016-08-18 16:19:37 -0700315 options.similarity = _git_get_branch_config_value(
316 'git-cl-similarity', default=50, value_type=int)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000317 else:
iannucci@chromium.org79540052012-10-19 23:15:26 +0000318 print('Note: Saving similarity of %d%% in git config.'
319 % options.similarity)
tandrii5d48c322016-08-18 16:19:37 -0700320 _git_set_branch_config_value('git-cl-similarity', options.similarity)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000321
iannucci@chromium.org79540052012-10-19 23:15:26 +0000322 options.similarity = max(0, min(options.similarity, 100))
323
324 if options.find_copies is None:
tandrii5d48c322016-08-18 16:19:37 -0700325 options.find_copies = _git_get_branch_config_value(
326 'git-find-copies', default=True, value_type=bool)
iannucci@chromium.org79540052012-10-19 23:15:26 +0000327 else:
tandrii5d48c322016-08-18 16:19:37 -0700328 _git_set_branch_config_value('git-find-copies', bool(options.find_copies))
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000329
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000330 return options, args
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700331
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000332 parser.parse_args = Parse
333
334
machenbach@chromium.org45453142015-09-15 08:45:22 +0000335def _get_properties_from_options(options):
336 properties = dict(x.split('=', 1) for x in options.properties)
337 for key, val in properties.iteritems():
338 try:
339 properties[key] = json.loads(val)
340 except ValueError:
341 pass # If a value couldn't be evaluated, treat it as a string.
342 return properties
343
344
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000345def _prefix_master(master):
346 """Convert user-specified master name to full master name.
347
348 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
349 name, while the developers always use shortened master name
350 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
351 function does the conversion for buildbucket migration.
352 """
borenet6c0efe62016-10-19 08:13:29 -0700353 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000354 return master
borenet6c0efe62016-10-19 08:13:29 -0700355 return '%s%s' % (MASTER_PREFIX, master)
356
357
358def _unprefix_master(bucket):
359 """Convert bucket name to shortened master name.
360
361 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
362 name, while the developers always use shortened master name
363 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
364 function does the conversion for buildbucket migration.
365 """
366 if bucket.startswith(MASTER_PREFIX):
367 return bucket[len(MASTER_PREFIX):]
368 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000369
370
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000371def _buildbucket_retry(operation_name, http, *args, **kwargs):
372 """Retries requests to buildbucket service and returns parsed json content."""
373 try_count = 0
374 while True:
375 response, content = http.request(*args, **kwargs)
376 try:
377 content_json = json.loads(content)
378 except ValueError:
379 content_json = None
380
381 # Buildbucket could return an error even if status==200.
382 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000383 error = content_json.get('error')
384 if error.get('code') == 403:
385 raise BuildbucketResponseException(
386 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000387 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000388 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000389 raise BuildbucketResponseException(msg)
390
391 if response.status == 200:
392 if not content_json:
393 raise BuildbucketResponseException(
394 'Buildbucket returns invalid json content: %s.\n'
395 'Please file bugs at http://crbug.com, label "Infra-BuildBucket".' %
396 content)
397 return content_json
398 if response.status < 500 or try_count >= 2:
399 raise httplib2.HttpLib2Error(content)
400
401 # status >= 500 means transient failures.
402 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700403 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000404 try_count += 1
405 assert False, 'unreachable'
406
407
qyearsley1fdfcb62016-10-24 13:22:03 -0700408def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700409 """Returns a dict mapping bucket names to builders and tests,
410 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700411 """
qyearsleydd49f942016-10-28 11:57:22 -0700412 # If no bots are listed, we try to get a set of builders and tests based
413 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700414 if not options.bot:
415 change = changelist.GetChange(
416 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700417 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700418 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700419 change=change,
420 changed_files=change.LocalPaths(),
421 repository_root=settings.GetRoot(),
422 default_presubmit=None,
423 project=None,
424 verbose=options.verbose,
425 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700426 if masters is None:
427 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100428 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700429
qyearsley1fdfcb62016-10-24 13:22:03 -0700430 if options.bucket:
431 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700432 if options.master:
433 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700434
qyearsleydd49f942016-10-28 11:57:22 -0700435 # If bots are listed but no master or bucket, then we need to find out
436 # the corresponding master for each bot.
437 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
438 if error_message:
439 option_parser.error(
440 'Tryserver master cannot be found because: %s\n'
441 'Please manually specify the tryserver master, e.g. '
442 '"-m tryserver.chromium.linux".' % error_message)
443 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700444
445
qyearsley123a4682016-10-26 09:12:17 -0700446def _get_bucket_map_for_builders(builders):
447 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700448 map_url = 'https://builders-map.appspot.com/'
449 try:
qyearsley123a4682016-10-26 09:12:17 -0700450 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700451 except urllib2.URLError as e:
452 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
453 (map_url, e))
454 except ValueError as e:
455 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700456 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700457 return None, 'Failed to build master map.'
458
qyearsley123a4682016-10-26 09:12:17 -0700459 bucket_map = {}
460 for builder in builders:
qyearsley123a4682016-10-26 09:12:17 -0700461 masters = builders_map.get(builder, [])
462 if not masters:
qyearsley1fdfcb62016-10-24 13:22:03 -0700463 return None, ('No matching master for builder %s.' % builder)
qyearsley123a4682016-10-26 09:12:17 -0700464 if len(masters) > 1:
qyearsley1fdfcb62016-10-24 13:22:03 -0700465 return None, ('The builder name %s exists in multiple masters %s.' %
qyearsley123a4682016-10-26 09:12:17 -0700466 (builder, masters))
467 bucket = _prefix_master(masters[0])
468 bucket_map.setdefault(bucket, {})[builder] = []
469
470 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700471
472
borenet6c0efe62016-10-19 08:13:29 -0700473def _trigger_try_jobs(auth_config, changelist, buckets, options,
tandriide281ae2016-10-12 06:02:30 -0700474 category='git_cl_try', patchset=None):
qyearsley1fdfcb62016-10-24 13:22:03 -0700475 """Sends a request to Buildbucket to trigger try jobs for a changelist.
476
477 Args:
478 auth_config: AuthConfig for Rietveld.
479 changelist: Changelist that the try jobs are associated with.
480 buckets: A nested dict mapping bucket names to builders to tests.
481 options: Command-line options.
482 """
tandriide281ae2016-10-12 06:02:30 -0700483 assert changelist.GetIssue(), 'CL must be uploaded first'
484 codereview_url = changelist.GetCodereviewServer()
485 assert codereview_url, 'CL must be uploaded first'
486 patchset = patchset or changelist.GetMostRecentPatchset()
487 assert patchset, 'CL must be uploaded first'
488
489 codereview_host = urlparse.urlparse(codereview_url).hostname
490 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000491 http = authenticator.authorize(httplib2.Http())
492 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700493
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000494 buildbucket_put_url = (
495 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000496 hostname=options.buildbucket_host))
tandriide281ae2016-10-12 06:02:30 -0700497 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
498 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
499 hostname=codereview_host,
500 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000501 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700502
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700503 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700504 shared_parameters_properties['category'] = category
505 if options.clobber:
506 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700507 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700508 if extra_properties:
509 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000510
511 batch_req_body = {'builds': []}
512 print_text = []
513 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700514 for bucket, builders_and_tests in sorted(buckets.iteritems()):
515 print_text.append('Bucket: %s' % bucket)
516 master = None
517 if bucket.startswith(MASTER_PREFIX):
518 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000519 for builder, tests in sorted(builders_and_tests.iteritems()):
520 print_text.append(' %s: %s' % (builder, tests))
521 parameters = {
522 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000523 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100524 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000525 'revision': options.revision,
526 }],
tandrii8c5a3532016-11-04 07:52:02 -0700527 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000528 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000529 if 'presubmit' in builder.lower():
530 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000531 if tests:
532 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700533
534 tags = [
535 'builder:%s' % builder,
536 'buildset:%s' % buildset,
537 'user_agent:git_cl_try',
538 ]
539 if master:
540 parameters['properties']['master'] = master
541 tags.append('master:%s' % master)
542
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000543 batch_req_body['builds'].append(
544 {
545 'bucket': bucket,
546 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000547 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700548 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000549 }
550 )
551
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700553 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000554 http,
555 buildbucket_put_url,
556 'PUT',
557 body=json.dumps(batch_req_body),
558 headers={'Content-Type': 'application/json'}
559 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000560 print_text.append('To see results here, run: git cl try-results')
561 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700562 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000563
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000564
tandrii221ab252016-10-06 08:12:04 -0700565def fetch_try_jobs(auth_config, changelist, buildbucket_host,
566 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700567 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000568
qyearsley53f48a12016-09-01 10:45:13 -0700569 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000570 """
tandrii221ab252016-10-06 08:12:04 -0700571 assert buildbucket_host
572 assert changelist.GetIssue(), 'CL must be uploaded first'
573 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
574 patchset = patchset or changelist.GetMostRecentPatchset()
575 assert patchset, 'CL must be uploaded first'
576
577 codereview_url = changelist.GetCodereviewServer()
578 codereview_host = urlparse.urlparse(codereview_url).hostname
579 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000580 if authenticator.has_cached_credentials():
581 http = authenticator.authorize(httplib2.Http())
582 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700583 print('Warning: Some results might be missing because %s' %
584 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700585 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000586 http = httplib2.Http()
587
588 http.force_exception_to_status_code = True
589
tandrii221ab252016-10-06 08:12:04 -0700590 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
591 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
592 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000593 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700594 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000595 params = {'tag': 'buildset:%s' % buildset}
596
597 builds = {}
598 while True:
599 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700600 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000601 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700602 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000603 for build in content.get('builds', []):
604 builds[build['id']] = build
605 if 'next_cursor' in content:
606 params['start_cursor'] = content['next_cursor']
607 else:
608 break
609 return builds
610
611
qyearsleyeab3c042016-08-24 09:18:28 -0700612def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000613 """Prints nicely result of fetch_try_jobs."""
614 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700615 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000616 return
617
618 # Make a copy, because we'll be modifying builds dictionary.
619 builds = builds.copy()
620 builder_names_cache = {}
621
622 def get_builder(b):
623 try:
624 return builder_names_cache[b['id']]
625 except KeyError:
626 try:
627 parameters = json.loads(b['parameters_json'])
628 name = parameters['builder_name']
629 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700630 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700631 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000632 name = None
633 builder_names_cache[b['id']] = name
634 return name
635
636 def get_bucket(b):
637 bucket = b['bucket']
638 if bucket.startswith('master.'):
639 return bucket[len('master.'):]
640 return bucket
641
642 if options.print_master:
643 name_fmt = '%%-%ds %%-%ds' % (
644 max(len(str(get_bucket(b))) for b in builds.itervalues()),
645 max(len(str(get_builder(b))) for b in builds.itervalues()))
646 def get_name(b):
647 return name_fmt % (get_bucket(b), get_builder(b))
648 else:
649 name_fmt = '%%-%ds' % (
650 max(len(str(get_builder(b))) for b in builds.itervalues()))
651 def get_name(b):
652 return name_fmt % get_builder(b)
653
654 def sort_key(b):
655 return b['status'], b.get('result'), get_name(b), b.get('url')
656
657 def pop(title, f, color=None, **kwargs):
658 """Pop matching builds from `builds` dict and print them."""
659
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000660 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000661 colorize = str
662 else:
663 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
664
665 result = []
666 for b in builds.values():
667 if all(b.get(k) == v for k, v in kwargs.iteritems()):
668 builds.pop(b['id'])
669 result.append(b)
670 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700671 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000672 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700673 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000674
675 total = len(builds)
676 pop(status='COMPLETED', result='SUCCESS',
677 title='Successes:', color=Fore.GREEN,
678 f=lambda b: (get_name(b), b.get('url')))
679 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
680 title='Infra Failures:', color=Fore.MAGENTA,
681 f=lambda b: (get_name(b), b.get('url')))
682 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
683 title='Failures:', color=Fore.RED,
684 f=lambda b: (get_name(b), b.get('url')))
685 pop(status='COMPLETED', result='CANCELED',
686 title='Canceled:', color=Fore.MAGENTA,
687 f=lambda b: (get_name(b),))
688 pop(status='COMPLETED', result='FAILURE',
689 failure_reason='INVALID_BUILD_DEFINITION',
690 title='Wrong master/builder name:', color=Fore.MAGENTA,
691 f=lambda b: (get_name(b),))
692 pop(status='COMPLETED', result='FAILURE',
693 title='Other failures:',
694 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
695 pop(status='COMPLETED',
696 title='Other finished:',
697 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
698 pop(status='STARTED',
699 title='Started:', color=Fore.YELLOW,
700 f=lambda b: (get_name(b), b.get('url')))
701 pop(status='SCHEDULED',
702 title='Scheduled:',
703 f=lambda b: (get_name(b), 'id=%s' % b['id']))
704 # The last section is just in case buildbucket API changes OR there is a bug.
705 pop(title='Other:',
706 f=lambda b: (get_name(b), 'id=%s' % b['id']))
707 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700708 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000709
710
qyearsley53f48a12016-09-01 10:45:13 -0700711def write_try_results_json(output_file, builds):
712 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
713
714 The input |builds| dict is assumed to be generated by Buildbucket.
715 Buildbucket documentation: http://goo.gl/G0s101
716 """
717
718 def convert_build_dict(build):
719 return {
720 'buildbucket_id': build.get('id'),
721 'status': build.get('status'),
722 'result': build.get('result'),
723 'bucket': build.get('bucket'),
724 'builder_name': json.loads(
725 build.get('parameters_json', '{}')).get('builder_name'),
726 'failure_reason': build.get('failure_reason'),
727 'url': build.get('url'),
728 }
729
730 converted = []
731 for _, build in sorted(builds.items()):
732 converted.append(convert_build_dict(build))
733 write_json(output_file, converted)
734
735
iannucci@chromium.org79540052012-10-19 23:15:26 +0000736def print_stats(similarity, find_copies, args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000737 """Prints statistics about the change to the user."""
738 # --no-ext-diff is broken in some versions of Git, so try to work around
739 # this by overriding the environment (but there is still a problem if the
740 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000741 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000742 if 'GIT_EXTERNAL_DIFF' in env:
743 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000744
745 if find_copies:
scottmgb84b5e32016-11-10 09:25:33 -0800746 similarity_options = ['-l100000', '-C%s' % similarity]
iannucci@chromium.org79540052012-10-19 23:15:26 +0000747 else:
748 similarity_options = ['-M%s' % similarity]
749
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000750 try:
751 stdout = sys.stdout.fileno()
752 except AttributeError:
753 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000754 return subprocess2.call(
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000755 ['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000756 'diff', '--no-ext-diff', '--stat'] + similarity_options + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000757 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000758
759
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000760class BuildbucketResponseException(Exception):
761 pass
762
763
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764class Settings(object):
765 def __init__(self):
766 self.default_server = None
767 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000768 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000769 self.tree_status_url = None
770 self.viewvc_url = None
771 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000772 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000773 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000774 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000775 self.git_editor = None
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000776 self.project = None
kjellander@chromium.org6abc6522014-12-02 07:34:49 +0000777 self.force_https_commit_url = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000778
779 def LazyUpdateIfNeeded(self):
780 """Updates the settings from a codereview.settings file, if available."""
781 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000782 # The only value that actually changes the behavior is
783 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000784 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000785 error_ok=True
786 ).strip().lower()
787
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000788 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000789 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000790 LoadCodereviewSettingsFromFile(cr_settings_file)
791 self.updated = True
792
793 def GetDefaultServerUrl(self, error_ok=False):
794 if not self.default_server:
795 self.LazyUpdateIfNeeded()
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000796 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000797 self._GetRietveldConfig('server', error_ok=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000798 if error_ok:
799 return self.default_server
800 if not self.default_server:
801 error_message = ('Could not find settings file. You must configure '
802 'your review setup by running "git cl config".')
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000803 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000804 self._GetRietveldConfig('server', error_message=error_message))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000805 return self.default_server
806
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000807 @staticmethod
808 def GetRelativeRoot():
809 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000810
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000811 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000812 if self.root is None:
813 self.root = os.path.abspath(self.GetRelativeRoot())
814 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000815
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000816 def GetGitMirror(self, remote='origin'):
817 """If this checkout is from a local git mirror, return a Mirror object."""
szager@chromium.org81593742016-03-09 20:27:58 +0000818 local_url = RunGit(['config', '--get', 'remote.%s.url' % remote]).strip()
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000819 if not os.path.isdir(local_url):
820 return None
821 git_cache.Mirror.SetCachePath(os.path.dirname(local_url))
822 remote_url = git_cache.Mirror.CacheDirToUrl(local_url)
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100823 # Use the /dev/null print_func to avoid terminal spew.
Andrii Shyshkalov18975322017-01-25 16:44:13 +0100824 mirror = git_cache.Mirror(remote_url, print_func=lambda *args: None)
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000825 if mirror.exists():
826 return mirror
827 return None
828
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000829 def GetTreeStatusUrl(self, error_ok=False):
830 if not self.tree_status_url:
831 error_message = ('You must configure your tree status URL by running '
832 '"git cl config".')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000833 self.tree_status_url = self._GetRietveldConfig(
834 'tree-status-url', error_ok=error_ok, error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000835 return self.tree_status_url
836
837 def GetViewVCUrl(self):
838 if not self.viewvc_url:
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000839 self.viewvc_url = self._GetRietveldConfig('viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000840 return self.viewvc_url
841
rmistry@google.com90752582014-01-14 21:04:50 +0000842 def GetBugPrefix(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000843 return self._GetRietveldConfig('bug-prefix', error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +0000844
rmistry@google.com78948ed2015-07-08 23:09:57 +0000845 def GetIsSkipDependencyUpload(self, branch_name):
846 """Returns true if specified branch should skip dep uploads."""
847 return self._GetBranchConfig(branch_name, 'skip-deps-uploads',
848 error_ok=True)
849
rmistry@google.com5626a922015-02-26 14:03:30 +0000850 def GetRunPostUploadHook(self):
851 run_post_upload_hook = self._GetRietveldConfig(
852 'run-post-upload-hook', error_ok=True)
853 return run_post_upload_hook == "True"
854
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000855 def GetDefaultCCList(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000856 return self._GetRietveldConfig('cc', error_ok=True)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000857
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000858 def GetDefaultPrivateFlag(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000859 return self._GetRietveldConfig('private', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000860
ukai@chromium.orge8077812012-02-03 03:41:46 +0000861 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700862 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000863 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700864 self.is_gerrit = (
865 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000866 return self.is_gerrit
867
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000868 def GetSquashGerritUploads(self):
869 """Return true if uploads to Gerrit should be squashed by default."""
870 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700871 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
872 if self.squash_gerrit_uploads is None:
873 # Default is squash now (http://crbug.com/611892#c23).
874 self.squash_gerrit_uploads = not (
875 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
876 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000877 return self.squash_gerrit_uploads
878
tandriia60502f2016-06-20 02:01:53 -0700879 def GetSquashGerritUploadsOverride(self):
880 """Return True or False if codereview.settings should be overridden.
881
882 Returns None if no override has been defined.
883 """
884 # See also http://crbug.com/611892#c23
885 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
886 error_ok=True).strip()
887 if result == 'true':
888 return True
889 if result == 'false':
890 return False
891 return None
892
tandrii@chromium.org28253532016-04-14 13:46:56 +0000893 def GetGerritSkipEnsureAuthenticated(self):
894 """Return True if EnsureAuthenticated should not be done for Gerrit
895 uploads."""
896 if self.gerrit_skip_ensure_authenticated is None:
897 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000898 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000899 error_ok=True).strip() == 'true')
900 return self.gerrit_skip_ensure_authenticated
901
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000902 def GetGitEditor(self):
903 """Return the editor specified in the git config, or None if none is."""
904 if self.git_editor is None:
905 self.git_editor = self._GetConfig('core.editor', error_ok=True)
906 return self.git_editor or None
907
thestig@chromium.org44202a22014-03-11 19:22:18 +0000908 def GetLintRegex(self):
909 return (self._GetRietveldConfig('cpplint-regex', error_ok=True) or
910 DEFAULT_LINT_REGEX)
911
912 def GetLintIgnoreRegex(self):
913 return (self._GetRietveldConfig('cpplint-ignore-regex', error_ok=True) or
914 DEFAULT_LINT_IGNORE_REGEX)
915
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000916 def GetProject(self):
917 if not self.project:
918 self.project = self._GetRietveldConfig('project', error_ok=True)
919 return self.project
920
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000921 def _GetRietveldConfig(self, param, **kwargs):
922 return self._GetConfig('rietveld.' + param, **kwargs)
923
rmistry@google.com78948ed2015-07-08 23:09:57 +0000924 def _GetBranchConfig(self, branch_name, param, **kwargs):
925 return self._GetConfig('branch.' + branch_name + '.' + param, **kwargs)
926
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000927 def _GetConfig(self, param, **kwargs):
928 self.LazyUpdateIfNeeded()
929 return RunGit(['config', param], **kwargs).strip()
930
931
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100932@contextlib.contextmanager
933def _get_gerrit_project_config_file(remote_url):
934 """Context manager to fetch and store Gerrit's project.config from
935 refs/meta/config branch and store it in temp file.
936
937 Provides a temporary filename or None if there was error.
938 """
939 error, _ = RunGitWithCode([
940 'fetch', remote_url,
941 '+refs/meta/config:refs/git_cl/meta/config'])
942 if error:
943 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700944 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100945 (remote_url, error))
946 yield None
947 return
948
949 error, project_config_data = RunGitWithCode(
950 ['show', 'refs/git_cl/meta/config:project.config'])
951 if error:
952 print('WARNING: project.config file not found')
953 yield None
954 return
955
956 with gclient_utils.temporary_directory() as tempdir:
957 project_config_file = os.path.join(tempdir, 'project.config')
958 gclient_utils.FileWrite(project_config_file, project_config_data)
959 yield project_config_file
960
961
962def _is_git_numberer_enabled(remote_url, remote_ref):
963 """Returns True if Git Numberer is enabled on this ref."""
964 # TODO(tandrii): this should be deleted once repos below are 100% on Gerrit.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100965 KNOWN_PROJECTS_WHITELIST = [
966 'chromium/src',
967 'external/webrtc',
968 'v8/v8',
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +0100969 'infra/experimental',
Edward Lemur32357d32017-09-11 20:22:45 +0200970 # For webrtc.googlesource.com/src.
971 'src',
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100972 ]
973
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100974 assert remote_ref and remote_ref.startswith('refs/'), remote_ref
975 url_parts = urlparse.urlparse(remote_url)
976 project_name = url_parts.path.lstrip('/').rstrip('git./')
977 for known in KNOWN_PROJECTS_WHITELIST:
978 if project_name.endswith(known):
979 break
980 else:
981 # Early exit to avoid extra fetches for repos that aren't using Git
982 # Numberer.
983 return False
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100984
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100985 with _get_gerrit_project_config_file(remote_url) as project_config_file:
986 if project_config_file is None:
987 # Failed to fetch project.config, which shouldn't happen on open source
988 # repos KNOWN_PROJECTS_WHITELIST.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100989 return False
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100990 def get_opts(x):
991 code, out = RunGitWithCode(
992 ['config', '-f', project_config_file, '--get-all',
993 'plugin.git-numberer.validate-%s-refglob' % x])
994 if code == 0:
995 return out.strip().splitlines()
996 return []
997 enabled, disabled = map(get_opts, ['enabled', 'disabled'])
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100998
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100999 logging.info('validator config enabled %s disabled %s refglobs for '
1000 '(this ref: %s)', enabled, disabled, remote_ref)
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001001
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001002 def match_refglobs(refglobs):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001003 for refglob in refglobs:
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001004 if remote_ref == refglob or fnmatch.fnmatch(remote_ref, refglob):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001005 return True
1006 return False
1007
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001008 if match_refglobs(disabled):
1009 return False
1010 return match_refglobs(enabled)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001011
1012
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001013def ShortBranchName(branch):
1014 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001015 return branch.replace('refs/heads/', '', 1)
1016
1017
1018def GetCurrentBranchRef():
1019 """Returns branch ref (e.g., refs/heads/master) or None."""
1020 return RunGit(['symbolic-ref', 'HEAD'],
1021 stderr=subprocess2.VOID, error_ok=True).strip() or None
1022
1023
1024def GetCurrentBranch():
1025 """Returns current branch or None.
1026
1027 For refs/heads/* branches, returns just last part. For others, full ref.
1028 """
1029 branchref = GetCurrentBranchRef()
1030 if branchref:
1031 return ShortBranchName(branchref)
1032 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001033
1034
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001035class _CQState(object):
1036 """Enum for states of CL with respect to Commit Queue."""
1037 NONE = 'none'
1038 DRY_RUN = 'dry_run'
1039 COMMIT = 'commit'
1040
1041 ALL_STATES = [NONE, DRY_RUN, COMMIT]
1042
1043
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001044class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001045 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001046 self.issue = issue
1047 self.patchset = patchset
1048 self.hostname = hostname
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001049 assert codereview in (None, 'rietveld', 'gerrit')
1050 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001051
1052 @property
1053 def valid(self):
1054 return self.issue is not None
1055
1056
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001057def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001058 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1059 fail_result = _ParsedIssueNumberArgument()
1060
1061 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001062 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001063 if not arg.startswith('http'):
1064 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001065
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001066 url = gclient_utils.UpgradeToHttps(arg)
1067 try:
1068 parsed_url = urlparse.urlparse(url)
1069 except ValueError:
1070 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001071
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001072 if codereview is not None:
1073 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1074 return parsed or fail_result
1075
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001076 results = {}
1077 for name, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1078 parsed = cls.ParseIssueURL(parsed_url)
1079 if parsed is not None:
1080 results[name] = parsed
1081
1082 if not results:
1083 return fail_result
1084 if len(results) == 1:
1085 return results.values()[0]
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001086
1087 if parsed_url.netloc and parsed_url.netloc.split('.')[0].endswith('-review'):
1088 # This is likely Gerrit.
1089 return results['gerrit']
1090 # Choose Rietveld as before if URL can parsed by either.
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001091 return results['rietveld']
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001092
1093
Aaron Gablea45ee112016-11-22 15:14:38 -08001094class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001095 def __init__(self, issue, url):
1096 self.issue = issue
1097 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001098 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001099
1100 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001101 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001102 self.issue, self.url)
1103
1104
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001105_CommentSummary = collections.namedtuple(
1106 '_CommentSummary', ['date', 'message', 'sender',
1107 # TODO(tandrii): these two aren't known in Gerrit.
1108 'approval', 'disapproval'])
1109
1110
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001111class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001112 """Changelist works with one changelist in local branch.
1113
1114 Supports two codereview backends: Rietveld or Gerrit, selected at object
1115 creation.
1116
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001117 Notes:
1118 * Not safe for concurrent multi-{thread,process} use.
1119 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001120 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001121 """
1122
1123 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1124 """Create a new ChangeList instance.
1125
1126 If issue is given, the codereview must be given too.
1127
1128 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1129 Otherwise, it's decided based on current configuration of the local branch,
1130 with default being 'rietveld' for backwards compatibility.
1131 See _load_codereview_impl for more details.
1132
1133 **kwargs will be passed directly to codereview implementation.
1134 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001135 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001136 global settings
1137 if not settings:
1138 # Happens when git_cl.py is used as a utility library.
1139 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001140
1141 if issue:
1142 assert codereview, 'codereview must be known, if issue is known'
1143
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001144 self.branchref = branchref
1145 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001146 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001147 self.branch = ShortBranchName(self.branchref)
1148 else:
1149 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001150 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001151 self.lookedup_issue = False
1152 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001153 self.has_description = False
1154 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001155 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001156 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001157 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001158 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001159 self._remote = None
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001160
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001161 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001162 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001163 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001164 assert self._codereview_impl
1165 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001166
1167 def _load_codereview_impl(self, codereview=None, **kwargs):
1168 if codereview:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001169 assert codereview in _CODEREVIEW_IMPLEMENTATIONS
1170 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1171 self._codereview = codereview
1172 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001173 return
1174
1175 # Automatic selection based on issue number set for a current branch.
1176 # Rietveld takes precedence over Gerrit.
1177 assert not self.issue
1178 # Whether we find issue or not, we are doing the lookup.
1179 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001180 if self.GetBranch():
1181 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1182 issue = _git_get_branch_config_value(
1183 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1184 if issue:
1185 self._codereview = codereview
1186 self._codereview_impl = cls(self, **kwargs)
1187 self.issue = int(issue)
1188 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001189
1190 # No issue is set for this branch, so decide based on repo-wide settings.
1191 return self._load_codereview_impl(
1192 codereview='gerrit' if settings.GetIsGerrit() else 'rietveld',
1193 **kwargs)
1194
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001195 def IsGerrit(self):
1196 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001197
1198 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001199 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001200
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001201 The return value is a string suitable for passing to git cl with the --cc
1202 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001203 """
1204 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001205 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001206 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001207 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1208 return self.cc
1209
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001210 def GetCCListWithoutDefault(self):
1211 """Return the users cc'd on this CL excluding default ones."""
1212 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001213 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001214 return self.cc
1215
Daniel Cheng7227d212017-11-17 08:12:37 -08001216 def ExtendCC(self, more_cc):
1217 """Extends the list of users to cc on this CL based on the changed files."""
1218 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219
1220 def GetBranch(self):
1221 """Returns the short branch name, e.g. 'master'."""
1222 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001223 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001224 if not branchref:
1225 return None
1226 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001227 self.branch = ShortBranchName(self.branchref)
1228 return self.branch
1229
1230 def GetBranchRef(self):
1231 """Returns the full branch name, e.g. 'refs/heads/master'."""
1232 self.GetBranch() # Poke the lazy loader.
1233 return self.branchref
1234
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001235 def ClearBranch(self):
1236 """Clears cached branch data of this object."""
1237 self.branch = self.branchref = None
1238
tandrii5d48c322016-08-18 16:19:37 -07001239 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1240 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1241 kwargs['branch'] = self.GetBranch()
1242 return _git_get_branch_config_value(key, default, **kwargs)
1243
1244 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1245 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1246 assert self.GetBranch(), (
1247 'this CL must have an associated branch to %sset %s%s' %
1248 ('un' if value is None else '',
1249 key,
1250 '' if value is None else ' to %r' % value))
1251 kwargs['branch'] = self.GetBranch()
1252 return _git_set_branch_config_value(key, value, **kwargs)
1253
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001254 @staticmethod
1255 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001256 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001257 e.g. 'origin', 'refs/heads/master'
1258 """
1259 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001260 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1261
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001262 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001263 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001264 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001265 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1266 error_ok=True).strip()
1267 if upstream_branch:
1268 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001269 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001270 # Else, try to guess the origin remote.
1271 remote_branches = RunGit(['branch', '-r']).split()
1272 if 'origin/master' in remote_branches:
1273 # Fall back on origin/master if it exits.
1274 remote = 'origin'
1275 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001276 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001277 DieWithError(
1278 'Unable to determine default branch to diff against.\n'
1279 'Either pass complete "git diff"-style arguments, like\n'
1280 ' git cl upload origin/master\n'
1281 'or verify this branch is set up to track another \n'
1282 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001283
1284 return remote, upstream_branch
1285
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001286 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001287 upstream_branch = self.GetUpstreamBranch()
1288 if not BranchExists(upstream_branch):
1289 DieWithError('The upstream for the current branch (%s) does not exist '
1290 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001291 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001292 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001293
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001294 def GetUpstreamBranch(self):
1295 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001296 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001297 if remote is not '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001298 upstream_branch = upstream_branch.replace('refs/heads/',
1299 'refs/remotes/%s/' % remote)
1300 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1301 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001302 self.upstream_branch = upstream_branch
1303 return self.upstream_branch
1304
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001305 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001306 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001307 remote, branch = None, self.GetBranch()
1308 seen_branches = set()
1309 while branch not in seen_branches:
1310 seen_branches.add(branch)
1311 remote, branch = self.FetchUpstreamTuple(branch)
1312 branch = ShortBranchName(branch)
1313 if remote != '.' or branch.startswith('refs/remotes'):
1314 break
1315 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001316 remotes = RunGit(['remote'], error_ok=True).split()
1317 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001318 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001319 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001320 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001321 logging.warn('Could not determine which remote this change is '
1322 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001323 else:
1324 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001325 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001326 branch = 'HEAD'
1327 if branch.startswith('refs/remotes'):
1328 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001329 elif branch.startswith('refs/branch-heads/'):
1330 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001331 else:
1332 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001333 return self._remote
1334
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001335 def GitSanityChecks(self, upstream_git_obj):
1336 """Checks git repo status and ensures diff is from local commits."""
1337
sbc@chromium.org79706062015-01-14 21:18:12 +00001338 if upstream_git_obj is None:
1339 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001340 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001341 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001342 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001343 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001344 return False
1345
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001346 # Verify the commit we're diffing against is in our current branch.
1347 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1348 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1349 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001350 print('ERROR: %s is not in the current branch. You may need to rebase '
1351 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001352 return False
1353
1354 # List the commits inside the diff, and verify they are all local.
1355 commits_in_diff = RunGit(
1356 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1357 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1358 remote_branch = remote_branch.strip()
1359 if code != 0:
1360 _, remote_branch = self.GetRemoteBranch()
1361
1362 commits_in_remote = RunGit(
1363 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1364
1365 common_commits = set(commits_in_diff) & set(commits_in_remote)
1366 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001367 print('ERROR: Your diff contains %d commits already in %s.\n'
1368 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1369 'the diff. If you are using a custom git flow, you can override'
1370 ' the reference used for this check with "git config '
1371 'gitcl.remotebranch <git-ref>".' % (
1372 len(common_commits), remote_branch, upstream_git_obj),
1373 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001374 return False
1375 return True
1376
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001377 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001378 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001379
1380 Returns None if it is not set.
1381 """
tandrii5d48c322016-08-18 16:19:37 -07001382 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001383
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001384 def GetRemoteUrl(self):
1385 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1386
1387 Returns None if there is no remote.
1388 """
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001389 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001390 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1391
1392 # If URL is pointing to a local directory, it is probably a git cache.
1393 if os.path.isdir(url):
1394 url = RunGit(['config', 'remote.%s.url' % remote],
1395 error_ok=True,
1396 cwd=url).strip()
1397 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001398
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001399 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001400 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001401 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001402 self.issue = self._GitGetBranchConfigValue(
1403 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001404 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001405 return self.issue
1406
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001407 def GetIssueURL(self):
1408 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001409 issue = self.GetIssue()
1410 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001411 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001412 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001413
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001414 def GetDescription(self, pretty=False, force=False):
1415 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001416 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001417 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001418 self.has_description = True
1419 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001420 # Set width to 72 columns + 2 space indent.
1421 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001422 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001423 lines = self.description.splitlines()
1424 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001425 return self.description
1426
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001427 def GetDescriptionFooters(self):
1428 """Returns (non_footer_lines, footers) for the commit message.
1429
1430 Returns:
1431 non_footer_lines (list(str)) - Simple list of description lines without
1432 any footer. The lines do not contain newlines, nor does the list contain
1433 the empty line between the message and the footers.
1434 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1435 [("Change-Id", "Ideadbeef...."), ...]
1436 """
1437 raw_description = self.GetDescription()
1438 msg_lines, _, footers = git_footers.split_footers(raw_description)
1439 if footers:
1440 msg_lines = msg_lines[:len(msg_lines)-1]
1441 return msg_lines, footers
1442
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001443 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001444 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001445 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001446 self.patchset = self._GitGetBranchConfigValue(
1447 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001448 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001449 return self.patchset
1450
1451 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001452 """Set this branch's patchset. If patchset=0, clears the patchset."""
1453 assert self.GetBranch()
1454 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001455 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001456 else:
1457 self.patchset = int(patchset)
1458 self._GitSetBranchConfigValue(
1459 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001460
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001461 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001462 """Set this branch's issue. If issue isn't given, clears the issue."""
1463 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001464 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001465 issue = int(issue)
1466 self._GitSetBranchConfigValue(
1467 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001468 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001469 codereview_server = self._codereview_impl.GetCodereviewServer()
1470 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001471 self._GitSetBranchConfigValue(
1472 self._codereview_impl.CodereviewServerConfigKey(),
1473 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001474 else:
tandrii5d48c322016-08-18 16:19:37 -07001475 # Reset all of these just to be clean.
1476 reset_suffixes = [
1477 'last-upload-hash',
1478 self._codereview_impl.IssueConfigKey(),
1479 self._codereview_impl.PatchsetConfigKey(),
1480 self._codereview_impl.CodereviewServerConfigKey(),
1481 ] + self._PostUnsetIssueProperties()
1482 for prop in reset_suffixes:
1483 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001484 msg = RunGit(['log', '-1', '--format=%B']).strip()
1485 if msg and git_footers.get_footer_change_id(msg):
1486 print('WARNING: The change patched into this branch has a Change-Id. '
1487 'Removing it.')
1488 RunGit(['commit', '--amend', '-m',
1489 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001490 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001491 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001492
dnjba1b0f32016-09-02 12:37:42 -07001493 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001494 if not self.GitSanityChecks(upstream_branch):
1495 DieWithError('\nGit sanity check failure')
1496
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001497 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001498 if not root:
1499 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001500 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001501
1502 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001503 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001504 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001505 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001506 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001507 except subprocess2.CalledProcessError:
1508 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001509 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001510 'This branch probably doesn\'t exist anymore. To reset the\n'
1511 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001512 ' git branch --set-upstream-to origin/master %s\n'
1513 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001514 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001515
maruel@chromium.org52424302012-08-29 15:14:30 +00001516 issue = self.GetIssue()
1517 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001518 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001519 description = self.GetDescription()
1520 else:
1521 # If the change was never uploaded, use the log messages of all commits
1522 # up to the branch point, as git cl upload will prefill the description
1523 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001524 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1525 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001526
1527 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001528 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001529 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001530 name,
1531 description,
1532 absroot,
1533 files,
1534 issue,
1535 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001536 author,
1537 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001538
dsansomee2d6fd92016-09-08 00:10:47 -07001539 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001540 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001541 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001542 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001543
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001544 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1545 """Sets the description for this CL remotely.
1546
1547 You can get description_lines and footers with GetDescriptionFooters.
1548
1549 Args:
1550 description_lines (list(str)) - List of CL description lines without
1551 newline characters.
1552 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1553 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1554 `List-Of-Tokens`). It will be case-normalized so that each token is
1555 title-cased.
1556 """
1557 new_description = '\n'.join(description_lines)
1558 if footers:
1559 new_description += '\n'
1560 for k, v in footers:
1561 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1562 if not git_footers.FOOTER_PATTERN.match(foot):
1563 raise ValueError('Invalid footer %r' % foot)
1564 new_description += foot + '\n'
1565 self.UpdateDescription(new_description, force)
1566
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001567 def RunHook(self, committing, may_prompt, verbose, change):
1568 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1569 try:
1570 return presubmit_support.DoPresubmitChecks(change, committing,
1571 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1572 default_presubmit=None, may_prompt=may_prompt,
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001573 rietveld_obj=self._codereview_impl.GetRietveldObjForPresubmit(),
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001574 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
vapierfd77ac72016-06-16 08:33:57 -07001575 except presubmit_support.PresubmitFailure as e:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001576 DieWithError(
1577 ('%s\nMaybe your depot_tools is out of date?\n'
1578 'If all fails, contact maruel@') % e)
1579
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001580 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1581 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001582 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1583 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001584 else:
1585 # Assume url.
1586 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1587 urlparse.urlparse(issue_arg))
1588 if not parsed_issue_arg or not parsed_issue_arg.valid:
1589 DieWithError('Failed to parse issue argument "%s". '
1590 'Must be an issue number or a valid URL.' % issue_arg)
1591 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001592 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001593
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001594 def CMDUpload(self, options, git_diff_args, orig_args):
1595 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001596 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001597 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001598 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001599 else:
1600 if self.GetBranch() is None:
1601 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1602
1603 # Default to diffing against common ancestor of upstream branch
1604 base_branch = self.GetCommonAncestorWithUpstream()
1605 git_diff_args = [base_branch, 'HEAD']
1606
Aaron Gablec4c40d12017-05-22 11:49:53 -07001607 # Warn about Rietveld deprecation for initial uploads to Rietveld.
1608 if not self.IsGerrit() and not self.GetIssue():
1609 print('=====================================')
1610 print('NOTICE: Rietveld is being deprecated. '
1611 'You can upload changes to Gerrit with')
1612 print(' git cl upload --gerrit')
1613 print('or set Gerrit to be your default code review tool with')
1614 print(' git config gerrit.host true')
1615 print('=====================================')
1616
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001617 # Fast best-effort checks to abort before running potentially
1618 # expensive hooks if uploading is likely to fail anyway. Passing these
1619 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001620 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001621 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001622
1623 # Apply watchlists on upload.
1624 change = self.GetChange(base_branch, None)
1625 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1626 files = [f.LocalPath() for f in change.AffectedFiles()]
1627 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001628 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001629
1630 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001631 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001632 # Set the reviewer list now so that presubmit checks can access it.
1633 change_description = ChangeDescription(change.FullDescriptionText())
1634 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001635 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001636 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001637 change)
1638 change.SetDescriptionText(change_description.description)
1639 hook_results = self.RunHook(committing=False,
1640 may_prompt=not options.force,
1641 verbose=options.verbose,
1642 change=change)
1643 if not hook_results.should_continue():
1644 return 1
1645 if not options.reviewers and hook_results.reviewers:
1646 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001647 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001648
Ravi Mistryfda50ca2016-11-14 10:19:18 -05001649 # TODO(tandrii): Checking local patchset against remote patchset is only
1650 # supported for Rietveld. Extend it to Gerrit or remove it completely.
1651 if self.GetIssue() and not self.IsGerrit():
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001652 latest_patchset = self.GetMostRecentPatchset()
1653 local_patchset = self.GetPatchset()
1654 if (latest_patchset and local_patchset and
1655 local_patchset != latest_patchset):
vapiera7fbd5a2016-06-16 09:17:49 -07001656 print('The last upload made from this repository was patchset #%d but '
1657 'the most recent patchset on the server is #%d.'
1658 % (local_patchset, latest_patchset))
1659 print('Uploading will still work, but if you\'ve uploaded to this '
1660 'issue from another machine or branch the patch you\'re '
1661 'uploading now might not include those changes.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001662 confirm_or_exit(action='upload')
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001663
1664 print_stats(options.similarity, options.find_copies, git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001665 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001666 if not ret:
tandrii4d0545a2016-07-06 03:56:49 -07001667 if options.use_commit_queue:
1668 self.SetCQState(_CQState.COMMIT)
1669 elif options.cq_dry_run:
1670 self.SetCQState(_CQState.DRY_RUN)
1671
tandrii5d48c322016-08-18 16:19:37 -07001672 _git_set_branch_config_value('last-upload-hash',
1673 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001674 # Run post upload hooks, if specified.
1675 if settings.GetRunPostUploadHook():
1676 presubmit_support.DoPostUploadExecuter(
1677 change,
1678 self,
1679 settings.GetRoot(),
1680 options.verbose,
1681 sys.stdout)
1682
1683 # Upload all dependencies if specified.
1684 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001685 print()
1686 print('--dependencies has been specified.')
1687 print('All dependent local branches will be re-uploaded.')
1688 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001689 # Remove the dependencies flag from args so that we do not end up in a
1690 # loop.
1691 orig_args.remove('--dependencies')
1692 ret = upload_branch_deps(self, orig_args)
1693 return ret
1694
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001695 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001696 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001697
1698 Issue must have been already uploaded and known.
1699 """
1700 assert new_state in _CQState.ALL_STATES
1701 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001702 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001703 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001704 return 0
1705 except KeyboardInterrupt:
1706 raise
1707 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001708 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001709 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001710 ' * Your project has no CQ,\n'
1711 ' * You don\'t have permission to change the CQ state,\n'
1712 ' * There\'s a bug in this code (see stack trace below).\n'
1713 'Consider specifying which bots to trigger manually or asking your '
1714 'project owners for permissions or contacting Chrome Infra at:\n'
1715 'https://www.chromium.org/infra\n\n' %
1716 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001717 # Still raise exception so that stack trace is printed.
1718 raise
1719
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001720 # Forward methods to codereview specific implementation.
1721
Aaron Gable636b13f2017-07-14 10:42:48 -07001722 def AddComment(self, message, publish=None):
1723 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001724
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001725 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001726 """Returns list of _CommentSummary for each comment.
1727
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001728 args:
1729 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001730 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001731 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001732
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001733 def CloseIssue(self):
1734 return self._codereview_impl.CloseIssue()
1735
1736 def GetStatus(self):
1737 return self._codereview_impl.GetStatus()
1738
1739 def GetCodereviewServer(self):
1740 return self._codereview_impl.GetCodereviewServer()
1741
tandriide281ae2016-10-12 06:02:30 -07001742 def GetIssueOwner(self):
1743 """Get owner from codereview, which may differ from this checkout."""
1744 return self._codereview_impl.GetIssueOwner()
1745
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001746 def GetMostRecentPatchset(self):
1747 return self._codereview_impl.GetMostRecentPatchset()
1748
tandriide281ae2016-10-12 06:02:30 -07001749 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001750 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001751 return self._codereview_impl.CannotTriggerTryJobReason()
1752
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001753 def GetTryJobProperties(self, patchset=None):
1754 """Returns dictionary of properties to launch try job."""
1755 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001756
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001757 def __getattr__(self, attr):
1758 # This is because lots of untested code accesses Rietveld-specific stuff
1759 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001760 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001761 # Note that child method defines __getattr__ as well, and forwards it here,
1762 # because _RietveldChangelistImpl is not cleaned up yet, and given
1763 # deprecation of Rietveld, it should probably be just removed.
1764 # Until that time, avoid infinite recursion by bypassing __getattr__
1765 # of implementation class.
1766 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001767
1768
1769class _ChangelistCodereviewBase(object):
1770 """Abstract base class encapsulating codereview specifics of a changelist."""
1771 def __init__(self, changelist):
1772 self._changelist = changelist # instance of Changelist
1773
1774 def __getattr__(self, attr):
1775 # Forward methods to changelist.
1776 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1777 # _RietveldChangelistImpl to avoid this hack?
1778 return getattr(self._changelist, attr)
1779
1780 def GetStatus(self):
1781 """Apply a rough heuristic to give a simple summary of an issue's review
1782 or CQ status, assuming adherence to a common workflow.
1783
1784 Returns None if no issue for this branch, or specific string keywords.
1785 """
1786 raise NotImplementedError()
1787
1788 def GetCodereviewServer(self):
1789 """Returns server URL without end slash, like "https://codereview.com"."""
1790 raise NotImplementedError()
1791
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001792 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001793 """Fetches and returns description from the codereview server."""
1794 raise NotImplementedError()
1795
tandrii5d48c322016-08-18 16:19:37 -07001796 @classmethod
1797 def IssueConfigKey(cls):
1798 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001799 raise NotImplementedError()
1800
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001801 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001802 def PatchsetConfigKey(cls):
1803 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001804 raise NotImplementedError()
1805
tandrii5d48c322016-08-18 16:19:37 -07001806 @classmethod
1807 def CodereviewServerConfigKey(cls):
1808 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001809 raise NotImplementedError()
1810
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001811 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001812 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001813 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001814
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001815 def GetRietveldObjForPresubmit(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001816 # This is an unfortunate Rietveld-embeddedness in presubmit.
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001817 # For non-Rietveld code reviews, this probably should return a dummy object.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001818 raise NotImplementedError()
1819
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001820 def GetGerritObjForPresubmit(self):
1821 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1822 return None
1823
dsansomee2d6fd92016-09-08 00:10:47 -07001824 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001825 """Update the description on codereview site."""
1826 raise NotImplementedError()
1827
Aaron Gable636b13f2017-07-14 10:42:48 -07001828 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001829 """Posts a comment to the codereview site."""
1830 raise NotImplementedError()
1831
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001832 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001833 raise NotImplementedError()
1834
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001835 def CloseIssue(self):
1836 """Closes the issue."""
1837 raise NotImplementedError()
1838
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001839 def GetMostRecentPatchset(self):
1840 """Returns the most recent patchset number from the codereview site."""
1841 raise NotImplementedError()
1842
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001843 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001844 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001845 """Fetches and applies the issue.
1846
1847 Arguments:
1848 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1849 reject: if True, reject the failed patch instead of switching to 3-way
1850 merge. Rietveld only.
1851 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1852 only.
1853 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001854 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001855 """
1856 raise NotImplementedError()
1857
1858 @staticmethod
1859 def ParseIssueURL(parsed_url):
1860 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1861 failed."""
1862 raise NotImplementedError()
1863
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001864 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001865 """Best effort check that user is authenticated with codereview server.
1866
1867 Arguments:
1868 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001869 refresh: whether to attempt to refresh credentials. Ignored if not
1870 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001871 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001872 raise NotImplementedError()
1873
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001874 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001875 """Best effort check that uploading isn't supposed to fail for predictable
1876 reasons.
1877
1878 This method should raise informative exception if uploading shouldn't
1879 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001880
1881 Arguments:
1882 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001883 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001884 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001885
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001886 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001887 """Uploads a change to codereview."""
1888 raise NotImplementedError()
1889
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001890 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001891 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001892
1893 Issue must have been already uploaded and known.
1894 """
1895 raise NotImplementedError()
1896
tandriie113dfd2016-10-11 10:20:12 -07001897 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001898 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001899 raise NotImplementedError()
1900
tandriide281ae2016-10-12 06:02:30 -07001901 def GetIssueOwner(self):
1902 raise NotImplementedError()
1903
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001904 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001905 raise NotImplementedError()
1906
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001907
1908class _RietveldChangelistImpl(_ChangelistCodereviewBase):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001909
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001910 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001911 super(_RietveldChangelistImpl, self).__init__(changelist)
1912 assert settings, 'must be initialized in _ChangelistCodereviewBase'
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001913 if not codereview_host:
martiniss6eda05f2016-06-30 10:18:35 -07001914 settings.GetDefaultServerUrl()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001915
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001916 self._rietveld_server = codereview_host
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01001917 self._auth_config = auth_config or auth.make_auth_config()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001918 self._props = None
1919 self._rpc_server = None
1920
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001921 def GetCodereviewServer(self):
1922 if not self._rietveld_server:
1923 # If we're on a branch then get the server potentially associated
1924 # with that branch.
1925 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001926 self._rietveld_server = gclient_utils.UpgradeToHttps(
1927 self._GitGetBranchConfigValue(self.CodereviewServerConfigKey()))
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001928 if not self._rietveld_server:
1929 self._rietveld_server = settings.GetDefaultServerUrl()
1930 return self._rietveld_server
1931
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001932 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001933 """Best effort check that user is authenticated with Rietveld server."""
1934 if self._auth_config.use_oauth2:
1935 authenticator = auth.get_authenticator_for_host(
1936 self.GetCodereviewServer(), self._auth_config)
1937 if not authenticator.has_cached_credentials():
1938 raise auth.LoginRequiredError(self.GetCodereviewServer())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001939 if refresh:
1940 authenticator.get_access_token()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001941
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001942 def EnsureCanUploadPatchset(self, force):
1943 # No checks for Rietveld because we are deprecating Rietveld.
1944 pass
1945
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001946 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001947 issue = self.GetIssue()
1948 assert issue
1949 try:
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001950 return self.RpcServer().get_description(issue, force=force).strip()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001951 except urllib2.HTTPError as e:
1952 if e.code == 404:
1953 DieWithError(
1954 ('\nWhile fetching the description for issue %d, received a '
1955 '404 (not found)\n'
1956 'error. It is likely that you deleted this '
1957 'issue on the server. If this is the\n'
1958 'case, please run\n\n'
1959 ' git cl issue 0\n\n'
1960 'to clear the association with the deleted issue. Then run '
1961 'this command again.') % issue)
1962 else:
1963 DieWithError(
1964 '\nFailed to fetch issue description. HTTP error %d' % e.code)
1965 except urllib2.URLError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07001966 print('Warning: Failed to retrieve CL description due to network '
1967 'failure.', file=sys.stderr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001968 return ''
1969
1970 def GetMostRecentPatchset(self):
1971 return self.GetIssueProperties()['patchsets'][-1]
1972
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001973 def GetIssueProperties(self):
1974 if self._props is None:
1975 issue = self.GetIssue()
1976 if not issue:
1977 self._props = {}
1978 else:
1979 self._props = self.RpcServer().get_issue_properties(issue, True)
1980 return self._props
1981
tandriie113dfd2016-10-11 10:20:12 -07001982 def CannotTriggerTryJobReason(self):
1983 props = self.GetIssueProperties()
1984 if not props:
1985 return 'Rietveld doesn\'t know about your issue %s' % self.GetIssue()
1986 if props.get('closed'):
1987 return 'CL %s is closed' % self.GetIssue()
1988 if props.get('private'):
1989 return 'CL %s is private' % self.GetIssue()
1990 return None
1991
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001992 def GetTryJobProperties(self, patchset=None):
1993 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07001994 project = (self.GetIssueProperties() or {}).get('project')
1995 return {
1996 'issue': self.GetIssue(),
1997 'patch_project': project,
1998 'patch_storage': 'rietveld',
1999 'patchset': patchset or self.GetPatchset(),
2000 'rietveld': self.GetCodereviewServer(),
2001 }
2002
tandriide281ae2016-10-12 06:02:30 -07002003 def GetIssueOwner(self):
2004 return (self.GetIssueProperties() or {}).get('owner_email')
2005
Aaron Gable636b13f2017-07-14 10:42:48 -07002006 def AddComment(self, message, publish=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002007 return self.RpcServer().add_comment(self.GetIssue(), message)
2008
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002009 def GetCommentsSummary(self, _readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002010 summary = []
2011 for message in self.GetIssueProperties().get('messages', []):
2012 date = datetime.datetime.strptime(message['date'], '%Y-%m-%d %H:%M:%S.%f')
2013 summary.append(_CommentSummary(
2014 date=date,
2015 disapproval=bool(message['disapproval']),
2016 approval=bool(message['approval']),
2017 sender=message['sender'],
2018 message=message['text'],
2019 ))
2020 return summary
2021
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002022 def GetStatus(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002023 """Applies a rough heuristic to give a simple summary of an issue's review
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002024 or CQ status, assuming adherence to a common workflow.
2025
2026 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gablea1bab272017-04-11 16:38:18 -07002027 * 'error' - error from review tool (including deleted issues)
2028 * 'unsent' - not sent for review
2029 * 'waiting' - waiting for review
2030 * 'reply' - waiting for owner to reply to review
2031 * 'not lgtm' - Code-Review label has been set negatively
2032 * 'lgtm' - LGTM from at least one approved reviewer
2033 * 'commit' - in the commit queue
2034 * 'closed' - closed
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002035 """
2036 if not self.GetIssue():
2037 return None
2038
2039 try:
2040 props = self.GetIssueProperties()
2041 except urllib2.HTTPError:
2042 return 'error'
2043
2044 if props.get('closed'):
2045 # Issue is closed.
2046 return 'closed'
tandrii@chromium.orgb4f6a222016-03-03 01:11:04 +00002047 if props.get('commit') and not props.get('cq_dry_run', False):
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002048 # Issue is in the commit queue.
2049 return 'commit'
2050
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002051 messages = props.get('messages') or []
Aaron Gablea1bab272017-04-11 16:38:18 -07002052 if not messages:
2053 # No message was sent.
2054 return 'unsent'
2055
2056 if get_approving_reviewers(props):
2057 return 'lgtm'
2058 elif get_approving_reviewers(props, disapproval=True):
2059 return 'not lgtm'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002060
tandrii9d2c7a32016-06-22 03:42:45 -07002061 # Skip CQ messages that don't require owner's action.
2062 while messages and messages[-1]['sender'] == COMMIT_BOT_EMAIL:
2063 if 'Dry run:' in messages[-1]['text']:
2064 messages.pop()
2065 elif 'The CQ bit was unchecked' in messages[-1]['text']:
2066 # This message always follows prior messages from CQ,
2067 # so skip this too.
2068 messages.pop()
2069 else:
2070 # This is probably a CQ messages warranting user attention.
2071 break
2072
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002073 if messages[-1]['sender'] != props.get('owner_email'):
tandrii9d2c7a32016-06-22 03:42:45 -07002074 # Non-LGTM reply from non-owner and not CQ bot.
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002075 return 'reply'
2076 return 'waiting'
2077
dsansomee2d6fd92016-09-08 00:10:47 -07002078 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01002079 self.RpcServer().update_description(self.GetIssue(), description)
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002080
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002081 def CloseIssue(self):
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002082 return self.RpcServer().close_issue(self.GetIssue())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002083
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002084 def SetFlag(self, flag, value):
tandrii4b233bd2016-07-06 03:50:29 -07002085 return self.SetFlags({flag: value})
2086
2087 def SetFlags(self, flags):
2088 """Sets flags on this CL/patchset in Rietveld.
tandrii4b233bd2016-07-06 03:50:29 -07002089 """
phajdan.jr68598232016-08-10 03:28:28 -07002090 patchset = self.GetPatchset() or self.GetMostRecentPatchset()
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002091 try:
tandrii4b233bd2016-07-06 03:50:29 -07002092 return self.RpcServer().set_flags(
phajdan.jr68598232016-08-10 03:28:28 -07002093 self.GetIssue(), patchset, flags)
vapierfd77ac72016-06-16 08:33:57 -07002094 except urllib2.HTTPError as e:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002095 if e.code == 404:
2096 DieWithError('The issue %s doesn\'t exist.' % self.GetIssue())
2097 if e.code == 403:
2098 DieWithError(
2099 ('Access denied to issue %s. Maybe the patchset %s doesn\'t '
phajdan.jr68598232016-08-10 03:28:28 -07002100 'match?') % (self.GetIssue(), patchset))
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002101 raise
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002102
maruel@chromium.orgcab38e92011-04-09 00:30:51 +00002103 def RpcServer(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002104 """Returns an upload.RpcServer() to access this review's rietveld instance.
2105 """
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002106 if not self._rpc_server:
maruel@chromium.org4bac4b52012-11-27 20:33:52 +00002107 self._rpc_server = rietveld.CachingRietveld(
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002108 self.GetCodereviewServer(),
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01002109 self._auth_config)
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002110 return self._rpc_server
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002111
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002112 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002113 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002114 return 'rietveldissue'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002115
tandrii5d48c322016-08-18 16:19:37 -07002116 @classmethod
2117 def PatchsetConfigKey(cls):
2118 return 'rietveldpatchset'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002119
tandrii5d48c322016-08-18 16:19:37 -07002120 @classmethod
2121 def CodereviewServerConfigKey(cls):
2122 return 'rietveldserver'
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002123
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002124 def GetRietveldObjForPresubmit(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002125 return self.RpcServer()
2126
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002127 def SetCQState(self, new_state):
2128 props = self.GetIssueProperties()
2129 if props.get('private'):
2130 DieWithError('Cannot set-commit on private issue')
2131
2132 if new_state == _CQState.COMMIT:
tandrii4d843592016-07-27 08:22:56 -07002133 self.SetFlags({'commit': '1', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002134 elif new_state == _CQState.NONE:
tandrii4b233bd2016-07-06 03:50:29 -07002135 self.SetFlags({'commit': '0', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002136 else:
tandrii4b233bd2016-07-06 03:50:29 -07002137 assert new_state == _CQState.DRY_RUN
2138 self.SetFlags({'commit': '1', 'cq_dry_run': '1'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002139
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002140 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002141 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002142 # PatchIssue should never be called with a dirty tree. It is up to the
2143 # caller to check this, but just in case we assert here since the
2144 # consequences of the caller not checking this could be dire.
2145 assert(not git_common.is_dirty_git_tree('apply'))
2146 assert(parsed_issue_arg.valid)
2147 self._changelist.issue = parsed_issue_arg.issue
2148 if parsed_issue_arg.hostname:
2149 self._rietveld_server = 'https://%s' % parsed_issue_arg.hostname
2150
skobes6468b902016-10-24 08:45:10 -07002151 patchset = parsed_issue_arg.patchset or self.GetMostRecentPatchset()
2152 patchset_object = self.RpcServer().get_patch(self.GetIssue(), patchset)
2153 scm_obj = checkout.GitCheckout(settings.GetRoot(), None, None, None, None)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002154 try:
skobes6468b902016-10-24 08:45:10 -07002155 scm_obj.apply_patch(patchset_object)
2156 except Exception as e:
2157 print(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002158 return 1
2159
2160 # If we had an issue, commit the current state and register the issue.
2161 if not nocommit:
Aaron Gabled343c632017-03-15 11:02:26 -07002162 self.SetIssue(self.GetIssue())
2163 self.SetPatchset(patchset)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002164 RunGit(['commit', '-m', (self.GetDescription() + '\n\n' +
2165 'patch from issue %(i)s at patchset '
2166 '%(p)s (http://crrev.com/%(i)s#ps%(p)s)'
2167 % {'i': self.GetIssue(), 'p': patchset})])
vapiera7fbd5a2016-06-16 09:17:49 -07002168 print('Committed patch locally.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002169 else:
vapiera7fbd5a2016-06-16 09:17:49 -07002170 print('Patch applied to index.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002171 return 0
2172
2173 @staticmethod
2174 def ParseIssueURL(parsed_url):
2175 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2176 return None
wychen3c1c1722016-08-04 11:46:36 -07002177 # Rietveld patch: https://domain/<number>/#ps<patchset>
2178 match = re.match(r'/(\d+)/$', parsed_url.path)
2179 match2 = re.match(r'ps(\d+)$', parsed_url.fragment)
2180 if match and match2:
skobes6468b902016-10-24 08:45:10 -07002181 return _ParsedIssueNumberArgument(
wychen3c1c1722016-08-04 11:46:36 -07002182 issue=int(match.group(1)),
2183 patchset=int(match2.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002184 hostname=parsed_url.netloc,
2185 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002186 # Typical url: https://domain/<issue_number>[/[other]]
2187 match = re.match('/(\d+)(/.*)?$', parsed_url.path)
2188 if match:
skobes6468b902016-10-24 08:45:10 -07002189 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002190 issue=int(match.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002191 hostname=parsed_url.netloc,
2192 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002193 # Rietveld patch: https://domain/download/issue<number>_<patchset>.diff
2194 match = re.match(r'/download/issue(\d+)_(\d+).diff$', parsed_url.path)
2195 if match:
skobes6468b902016-10-24 08:45:10 -07002196 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002197 issue=int(match.group(1)),
2198 patchset=int(match.group(2)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002199 hostname=parsed_url.netloc,
2200 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002201 return None
2202
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002203 def CMDUploadChange(self, options, args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002204 """Upload the patch to Rietveld."""
2205 upload_args = ['--assume_yes'] # Don't ask about untracked files.
2206 upload_args.extend(['--server', self.GetCodereviewServer()])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002207 upload_args.extend(auth.auth_config_to_command_options(self._auth_config))
2208 if options.emulate_svn_auto_props:
2209 upload_args.append('--emulate_svn_auto_props')
2210
2211 change_desc = None
2212
2213 if options.email is not None:
2214 upload_args.extend(['--email', options.email])
2215
2216 if self.GetIssue():
nodirca166002016-06-27 10:59:51 -07002217 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002218 upload_args.extend(['--title', options.title])
2219 if options.message:
2220 upload_args.extend(['--message', options.message])
2221 upload_args.extend(['--issue', str(self.GetIssue())])
vapiera7fbd5a2016-06-16 09:17:49 -07002222 print('This branch is associated with issue %s. '
2223 'Adding patch to that issue.' % self.GetIssue())
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002224 else:
nodirca166002016-06-27 10:59:51 -07002225 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002226 upload_args.extend(['--title', options.title])
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002227 if options.message:
2228 message = options.message
2229 else:
2230 message = CreateDescriptionFromLog(args)
2231 if options.title:
2232 message = options.title + '\n\n' + message
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002233 change_desc = ChangeDescription(message)
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002234 if options.reviewers or options.add_owners_to:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002235 change_desc.update_reviewers(options.reviewers, options.tbrs,
2236 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002237 if not options.force:
Aaron Gable3a16ed12017-03-23 10:51:55 -07002238 change_desc.prompt(bug=options.bug, git_footer=False)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002239
2240 if not change_desc.description:
vapiera7fbd5a2016-06-16 09:17:49 -07002241 print('Description is empty; aborting.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002242 return 1
2243
2244 upload_args.extend(['--message', change_desc.description])
2245 if change_desc.get_reviewers():
2246 upload_args.append('--reviewers=%s' % ','.join(
2247 change_desc.get_reviewers()))
2248 if options.send_mail:
2249 if not change_desc.get_reviewers():
Christopher Lamf732cd52017-01-24 12:40:11 +11002250 DieWithError("Must specify reviewers to send email.", change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002251 upload_args.append('--send_mail')
2252
2253 # We check this before applying rietveld.private assuming that in
2254 # rietveld.cc only addresses which we can send private CLs to are listed
2255 # if rietveld.private is set, and so we should ignore rietveld.cc only
2256 # when --private is specified explicitly on the command line.
2257 if options.private:
2258 logging.warn('rietveld.cc is ignored since private flag is specified. '
2259 'You need to review and add them manually if necessary.')
2260 cc = self.GetCCListWithoutDefault()
2261 else:
2262 cc = self.GetCCList()
2263 cc = ','.join(filter(None, (cc, ','.join(options.cc))))
bradnelsond975b302016-10-23 12:20:23 -07002264 if change_desc.get_cced():
2265 cc = ','.join(filter(None, (cc, ','.join(change_desc.get_cced()))))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002266 if cc:
2267 upload_args.extend(['--cc', cc])
2268
2269 if options.private or settings.GetDefaultPrivateFlag() == "True":
2270 upload_args.append('--private')
2271
2272 upload_args.extend(['--git_similarity', str(options.similarity)])
2273 if not options.find_copies:
2274 upload_args.extend(['--git_no_find_copies'])
2275
2276 # Include the upstream repo's URL in the change -- this is useful for
2277 # projects that have their source spread across multiple repos.
2278 remote_url = self.GetGitBaseUrlFromConfig()
2279 if not remote_url:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002280 if self.GetRemoteUrl() and '/' in self.GetUpstreamBranch():
2281 remote_url = '%s@%s' % (self.GetRemoteUrl(),
2282 self.GetUpstreamBranch().split('/')[-1])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002283 if remote_url:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002284 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002285 target_ref = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002286 if target_ref:
2287 upload_args.extend(['--target_ref', target_ref])
2288
2289 # Look for dependent patchsets. See crbug.com/480453 for more details.
2290 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
2291 upstream_branch = ShortBranchName(upstream_branch)
2292 if remote is '.':
2293 # A local branch is being tracked.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002294 local_branch = upstream_branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002295 if settings.GetIsSkipDependencyUpload(local_branch):
vapiera7fbd5a2016-06-16 09:17:49 -07002296 print()
2297 print('Skipping dependency patchset upload because git config '
2298 'branch.%s.skip-deps-uploads is set to True.' % local_branch)
2299 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002300 else:
2301 auth_config = auth.extract_auth_config_from_options(options)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002302 branch_cl = Changelist(branchref='refs/heads/'+local_branch,
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002303 auth_config=auth_config)
2304 branch_cl_issue_url = branch_cl.GetIssueURL()
2305 branch_cl_issue = branch_cl.GetIssue()
2306 branch_cl_patchset = branch_cl.GetPatchset()
2307 if branch_cl_issue_url and branch_cl_issue and branch_cl_patchset:
2308 upload_args.extend(
2309 ['--depends_on_patchset', '%s:%s' % (
2310 branch_cl_issue, branch_cl_patchset)])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002311 print(
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002312 '\n'
2313 'The current branch (%s) is tracking a local branch (%s) with '
2314 'an associated CL.\n'
2315 'Adding %s/#ps%s as a dependency patchset.\n'
2316 '\n' % (self.GetBranch(), local_branch, branch_cl_issue_url,
2317 branch_cl_patchset))
2318
2319 project = settings.GetProject()
2320 if project:
2321 upload_args.extend(['--project', project])
Aaron Gable665a4392017-06-29 10:53:46 -07002322 else:
2323 print()
2324 print('WARNING: Uploading without a project specified. Please ensure '
2325 'your repo\'s codereview.settings has a "PROJECT: foo" line.')
2326 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002327
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002328 try:
2329 upload_args = ['upload'] + upload_args + args
2330 logging.info('upload.RealMain(%s)', upload_args)
2331 issue, patchset = upload.RealMain(upload_args)
2332 issue = int(issue)
2333 patchset = int(patchset)
2334 except KeyboardInterrupt:
2335 sys.exit(1)
2336 except:
2337 # If we got an exception after the user typed a description for their
2338 # change, back up the description before re-raising.
2339 if change_desc:
Christopher Lamf732cd52017-01-24 12:40:11 +11002340 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002341 raise
2342
2343 if not self.GetIssue():
2344 self.SetIssue(issue)
2345 self.SetPatchset(patchset)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002346 return 0
2347
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002348
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002349class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002350 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002351 # auth_config is Rietveld thing, kept here to preserve interface only.
2352 super(_GerritChangelistImpl, self).__init__(changelist)
2353 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002354 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002355 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002356 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002357 # Map from change number (issue) to its detail cache.
2358 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002359
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002360 if codereview_host is not None:
2361 assert not codereview_host.startswith('https://'), codereview_host
2362 self._gerrit_host = codereview_host
2363 self._gerrit_server = 'https://%s' % codereview_host
2364
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002365 def _GetGerritHost(self):
2366 # Lazy load of configs.
2367 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07002368 if self._gerrit_host and '.' not in self._gerrit_host:
2369 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
2370 # This happens for internal stuff http://crbug.com/614312.
2371 parsed = urlparse.urlparse(self.GetRemoteUrl())
2372 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002373 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07002374 ' Your current remote is: %s' % self.GetRemoteUrl())
2375 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
2376 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002377 return self._gerrit_host
2378
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002379 def _GetGitHost(self):
2380 """Returns git host to be used when uploading change to Gerrit."""
2381 return urlparse.urlparse(self.GetRemoteUrl()).netloc
2382
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002383 def GetCodereviewServer(self):
2384 if not self._gerrit_server:
2385 # If we're on a branch then get the server potentially associated
2386 # with that branch.
2387 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07002388 self._gerrit_server = self._GitGetBranchConfigValue(
2389 self.CodereviewServerConfigKey())
2390 if self._gerrit_server:
2391 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002392 if not self._gerrit_server:
2393 # We assume repo to be hosted on Gerrit, and hence Gerrit server
2394 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002395 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002396 parts[0] = parts[0] + '-review'
2397 self._gerrit_host = '.'.join(parts)
2398 self._gerrit_server = 'https://%s' % self._gerrit_host
2399 return self._gerrit_server
2400
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002401 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002402 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002403 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002404
tandrii5d48c322016-08-18 16:19:37 -07002405 @classmethod
2406 def PatchsetConfigKey(cls):
2407 return 'gerritpatchset'
2408
2409 @classmethod
2410 def CodereviewServerConfigKey(cls):
2411 return 'gerritserver'
2412
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01002413 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002414 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002415 if settings.GetGerritSkipEnsureAuthenticated():
2416 # For projects with unusual authentication schemes.
2417 # See http://crbug.com/603378.
2418 return
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002419 # Lazy-loader to identify Gerrit and Git hosts.
2420 if gerrit_util.GceAuthenticator.is_gce():
2421 return
2422 self.GetCodereviewServer()
2423 git_host = self._GetGitHost()
2424 assert self._gerrit_server and self._gerrit_host
2425 cookie_auth = gerrit_util.CookiesAuthenticator()
2426
2427 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
2428 git_auth = cookie_auth.get_auth_header(git_host)
2429 if gerrit_auth and git_auth:
2430 if gerrit_auth == git_auth:
2431 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002432 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002433 print((
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002434 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002435 ' %s\n'
2436 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002437 ' Consider running the following command:\n'
2438 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002439 ' %s\n'
Andrii Shyshkalov8e4576f2017-05-10 15:46:53 +02002440 ' %s') %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002441 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002442 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002443 cookie_auth.get_new_password_message(git_host)))
2444 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002445 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002446 return
2447 else:
2448 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02002449 ([] if gerrit_auth else [self._gerrit_host]) +
2450 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002451 DieWithError('Credentials for the following hosts are required:\n'
2452 ' %s\n'
2453 'These are read from %s (or legacy %s)\n'
2454 '%s' % (
2455 '\n '.join(missing),
2456 cookie_auth.get_gitcookies_path(),
2457 cookie_auth.get_netrc_path(),
2458 cookie_auth.get_new_password_message(git_host)))
2459
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002460 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002461 if not self.GetIssue():
2462 return
2463
2464 # Warm change details cache now to avoid RPCs later, reducing latency for
2465 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002466 self._GetChangeDetail(
2467 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002468
2469 status = self._GetChangeDetail()['status']
2470 if status in ('MERGED', 'ABANDONED'):
2471 DieWithError('Change %s has been %s, new uploads are not allowed' %
2472 (self.GetIssueURL(),
2473 'submitted' if status == 'MERGED' else 'abandoned'))
2474
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002475 if gerrit_util.GceAuthenticator.is_gce():
2476 return
2477 cookies_user = gerrit_util.CookiesAuthenticator().get_auth_email(
2478 self._GetGerritHost())
2479 if self.GetIssueOwner() == cookies_user:
2480 return
2481 logging.debug('change %s owner is %s, cookies user is %s',
2482 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002483 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002484 # so ask what Gerrit thinks of this user.
2485 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2486 if details['email'] == self.GetIssueOwner():
2487 return
2488 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002489 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002490 'as %s.\n'
2491 'Uploading may fail due to lack of permissions.' %
2492 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2493 confirm_or_exit(action='upload')
2494
2495
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002496 def _PostUnsetIssueProperties(self):
2497 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002498 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002499
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002500 def GetRietveldObjForPresubmit(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002501 class ThisIsNotRietveldIssue(object):
2502 def __nonzero__(self):
2503 # This is a hack to make presubmit_support think that rietveld is not
2504 # defined, yet still ensure that calls directly result in a decent
2505 # exception message below.
2506 return False
2507
2508 def __getattr__(self, attr):
2509 print(
2510 'You aren\'t using Rietveld at the moment, but Gerrit.\n'
2511 'Using Rietveld in your PRESUBMIT scripts won\'t work.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002512 'Please, either change your PRESUBMIT to not use rietveld_obj.%s,\n'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002513 'or use Rietveld for codereview.\n'
2514 'See also http://crbug.com/579160.' % attr)
2515 raise NotImplementedError()
2516 return ThisIsNotRietveldIssue()
2517
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002518 def GetGerritObjForPresubmit(self):
2519 return presubmit_support.GerritAccessor(self._GetGerritHost())
2520
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002521 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002522 """Apply a rough heuristic to give a simple summary of an issue's review
2523 or CQ status, assuming adherence to a common workflow.
2524
2525 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002526 * 'error' - error from review tool (including deleted issues)
2527 * 'unsent' - no reviewers added
2528 * 'waiting' - waiting for review
2529 * 'reply' - waiting for uploader to reply to review
2530 * 'lgtm' - Code-Review label has been set
2531 * 'commit' - in the commit queue
2532 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002533 """
2534 if not self.GetIssue():
2535 return None
2536
2537 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002538 data = self._GetChangeDetail([
2539 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002540 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002541 return 'error'
2542
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002543 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002544 return 'closed'
2545
Aaron Gable9ab38c62017-04-06 14:36:33 -07002546 if data['labels'].get('Commit-Queue', {}).get('approved'):
2547 # The section will have an "approved" subsection if anyone has voted
2548 # the maximum value on the label.
2549 return 'commit'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002550
Aaron Gable9ab38c62017-04-06 14:36:33 -07002551 if data['labels'].get('Code-Review', {}).get('approved'):
2552 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002553
2554 if not data.get('reviewers', {}).get('REVIEWER', []):
2555 return 'unsent'
2556
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002557 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002558 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2559 last_message_author = messages.pop().get('author', {})
2560 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002561 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2562 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002563 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002564 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002565 if last_message_author.get('_account_id') == owner:
2566 # Most recent message was by owner.
2567 return 'waiting'
2568 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002569 # Some reply from non-owner.
2570 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002571
2572 # Somehow there are no messages even though there are reviewers.
2573 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002574
2575 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002576 data = self._GetChangeDetail(['CURRENT_REVISION'])
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002577 return data['revisions'][data['current_revision']]['_number']
2578
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002579 def FetchDescription(self, force=False):
2580 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2581 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002582 current_rev = data['current_revision']
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +01002583 return data['revisions'][current_rev]['commit']['message']
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002584
dsansomee2d6fd92016-09-08 00:10:47 -07002585 def UpdateDescriptionRemote(self, description, force=False):
2586 if gerrit_util.HasPendingChangeEdit(self._GetGerritHost(), self.GetIssue()):
2587 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002588 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002589 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002590 'unpublished edit. Either publish the edit in the Gerrit web UI '
2591 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002592
2593 gerrit_util.DeletePendingChangeEdit(self._GetGerritHost(),
2594 self.GetIssue())
scottmg@chromium.org6d1266e2016-04-26 11:12:26 +00002595 gerrit_util.SetCommitMessage(self._GetGerritHost(), self.GetIssue(),
Andrii Shyshkalovea4fc832016-12-01 14:53:23 +01002596 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002597
Aaron Gable636b13f2017-07-14 10:42:48 -07002598 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002599 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
Aaron Gable636b13f2017-07-14 10:42:48 -07002600 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002601
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002602 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002603 # DETAILED_ACCOUNTS is to get emails in accounts.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002604 messages = self._GetChangeDetail(
2605 options=['MESSAGES', 'DETAILED_ACCOUNTS']).get('messages', [])
2606 file_comments = gerrit_util.GetChangeComments(
2607 self._GetGerritHost(), self.GetIssue())
2608
2609 # Build dictionary of file comments for easy access and sorting later.
2610 # {author+date: {path: {patchset: {line: url+message}}}}
2611 comments = collections.defaultdict(
2612 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2613 for path, line_comments in file_comments.iteritems():
2614 for comment in line_comments:
2615 if comment.get('tag', '').startswith('autogenerated'):
2616 continue
2617 key = (comment['author']['email'], comment['updated'])
2618 if comment.get('side', 'REVISION') == 'PARENT':
2619 patchset = 'Base'
2620 else:
2621 patchset = 'PS%d' % comment['patch_set']
2622 line = comment.get('line', 0)
2623 url = ('https://%s/c/%s/%s/%s#%s%s' %
2624 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2625 'b' if comment.get('side') == 'PARENT' else '',
2626 str(line) if line else ''))
2627 comments[key][path][patchset][line] = (url, comment['message'])
2628
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002629 summary = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002630 for msg in messages:
2631 # Don't bother showing autogenerated messages.
2632 if msg.get('tag') and msg.get('tag').startswith('autogenerated'):
2633 continue
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002634 # Gerrit spits out nanoseconds.
2635 assert len(msg['date'].split('.')[-1]) == 9
2636 date = datetime.datetime.strptime(msg['date'][:-3],
2637 '%Y-%m-%d %H:%M:%S.%f')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002638 message = msg['message']
2639 key = (msg['author']['email'], msg['date'])
2640 if key in comments:
2641 message += '\n'
2642 for path, patchsets in sorted(comments.get(key, {}).items()):
2643 if readable:
2644 message += '\n%s' % path
2645 for patchset, lines in sorted(patchsets.items()):
2646 for line, (url, content) in sorted(lines.items()):
2647 if line:
2648 line_str = 'Line %d' % line
2649 path_str = '%s:%d:' % (path, line)
2650 else:
2651 line_str = 'File comment'
2652 path_str = '%s:0:' % path
2653 if readable:
2654 message += '\n %s, %s: %s' % (patchset, line_str, url)
2655 message += '\n %s\n' % content
2656 else:
2657 message += '\n%s ' % path_str
2658 message += '\n%s\n' % content
2659
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002660 summary.append(_CommentSummary(
2661 date=date,
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002662 message=message,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002663 sender=msg['author']['email'],
2664 # These could be inferred from the text messages and correlated with
2665 # Code-Review label maximum, however this is not reliable.
2666 # Leaving as is until the need arises.
2667 approval=False,
2668 disapproval=False,
2669 ))
2670 return summary
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002671
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002672 def CloseIssue(self):
2673 gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')
2674
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002675 def SubmitIssue(self, wait_for_merge=True):
2676 gerrit_util.SubmitChange(self._GetGerritHost(), self.GetIssue(),
2677 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002678
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002679 def _GetChangeDetail(self, options=None, issue=None,
2680 no_cache=False):
2681 """Returns details of the issue by querying Gerrit and caching results.
2682
2683 If fresh data is needed, set no_cache=True which will clear cache and
2684 thus new data will be fetched from Gerrit.
2685 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002686 options = options or []
2687 issue = issue or self.GetIssue()
tandriic2405f52016-10-10 08:13:15 -07002688 assert issue, 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002689
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002690 # Optimization to avoid multiple RPCs:
2691 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2692 'CURRENT_COMMIT' not in options):
2693 options.append('CURRENT_COMMIT')
2694
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002695 # Normalize issue and options for consistent keys in cache.
2696 issue = str(issue)
2697 options = [o.upper() for o in options]
2698
2699 # Check in cache first unless no_cache is True.
2700 if no_cache:
2701 self._detail_cache.pop(issue, None)
2702 else:
2703 options_set = frozenset(options)
2704 for cached_options_set, data in self._detail_cache.get(issue, []):
2705 # Assumption: data fetched before with extra options is suitable
2706 # for return for a smaller set of options.
2707 # For example, if we cached data for
2708 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2709 # and request is for options=[CURRENT_REVISION],
2710 # THEN we can return prior cached data.
2711 if options_set.issubset(cached_options_set):
2712 return data
2713
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002714 try:
Aaron Gable19ee16c2017-04-18 11:56:35 -07002715 data = gerrit_util.GetChangeDetail(
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002716 self._GetGerritHost(), str(issue), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002717 except gerrit_util.GerritError as e:
2718 if e.http_status == 404:
Aaron Gablea45ee112016-11-22 15:14:38 -08002719 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002720 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002721
2722 self._detail_cache.setdefault(issue, []).append((frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002723 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002724
agable32978d92016-11-01 12:55:02 -07002725 def _GetChangeCommit(self, issue=None):
2726 issue = issue or self.GetIssue()
2727 assert issue, 'issue is required to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002728 try:
2729 data = gerrit_util.GetChangeCommit(self._GetGerritHost(), str(issue))
2730 except gerrit_util.GerritError as e:
2731 if e.http_status == 404:
2732 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
2733 raise
agable32978d92016-11-01 12:55:02 -07002734 return data
2735
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002736 def CMDLand(self, force, bypass_hooks, verbose):
2737 if git_common.is_dirty_git_tree('land'):
2738 return 1
tandriid60367b2016-06-22 05:25:12 -07002739 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
2740 if u'Commit-Queue' in detail.get('labels', {}):
2741 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002742 confirm_or_exit('\nIt seems this repository has a Commit Queue, '
2743 'which can test and land changes for you. '
2744 'Are you sure you wish to bypass it?\n',
2745 action='bypass CQ')
tandriid60367b2016-06-22 05:25:12 -07002746
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002747 differs = True
tandriic4344b52016-08-29 06:04:54 -07002748 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002749 # Note: git diff outputs nothing if there is no diff.
2750 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002751 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002752 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002753 if detail['current_revision'] == last_upload:
2754 differs = False
2755 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002756 print('WARNING: Local branch contents differ from latest uploaded '
2757 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002758 if differs:
2759 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002760 confirm_or_exit(
2761 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2762 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002763 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002764 elif not bypass_hooks:
2765 hook_results = self.RunHook(
2766 committing=True,
2767 may_prompt=not force,
2768 verbose=verbose,
2769 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None))
2770 if not hook_results.should_continue():
2771 return 1
2772
2773 self.SubmitIssue(wait_for_merge=True)
2774 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002775 links = self._GetChangeCommit().get('web_links', [])
2776 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002777 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002778 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002779 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002780 return 0
2781
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002782 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002783 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002784 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002785 assert not directory
2786 assert parsed_issue_arg.valid
2787
2788 self._changelist.issue = parsed_issue_arg.issue
2789
2790 if parsed_issue_arg.hostname:
2791 self._gerrit_host = parsed_issue_arg.hostname
2792 self._gerrit_server = 'https://%s' % self._gerrit_host
2793
tandriic2405f52016-10-10 08:13:15 -07002794 try:
2795 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002796 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002797 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002798
2799 if not parsed_issue_arg.patchset:
2800 # Use current revision by default.
2801 revision_info = detail['revisions'][detail['current_revision']]
2802 patchset = int(revision_info['_number'])
2803 else:
2804 patchset = parsed_issue_arg.patchset
2805 for revision_info in detail['revisions'].itervalues():
2806 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2807 break
2808 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002809 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002810 (parsed_issue_arg.patchset, self.GetIssue()))
2811
2812 fetch_info = revision_info['fetch']['http']
2813 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002814
Aaron Gable62619a32017-06-16 08:22:09 -07002815 if force:
2816 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2817 print('Checked out commit for change %i patchset %i locally' %
2818 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002819 elif nocommit:
2820 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2821 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002822 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002823 RunGit(['cherry-pick', 'FETCH_HEAD'])
2824 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002825 (parsed_issue_arg.issue, patchset))
2826 print('Note: this created a local commit which does not have '
2827 'the same hash as the one uploaded for review. This will make '
2828 'uploading changes based on top of this branch difficult.\n'
2829 'If you want to do that, use "git cl patch --force" instead.')
2830
Stefan Zagerd08043c2017-10-12 12:07:02 -07002831 if self.GetBranch():
2832 self.SetIssue(parsed_issue_arg.issue)
2833 self.SetPatchset(patchset)
2834 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2835 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2836 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2837 else:
2838 print('WARNING: You are in detached HEAD state.\n'
2839 'The patch has been applied to your checkout, but you will not be '
2840 'able to upload a new patch set to the gerrit issue.\n'
2841 'Try using the \'-b\' option if you would like to work on a '
2842 'branch and/or upload a new patch set.')
2843
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002844 return 0
2845
2846 @staticmethod
2847 def ParseIssueURL(parsed_url):
2848 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2849 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002850 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2851 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002852 # Short urls like https://domain/<issue_number> can be used, but don't allow
2853 # specifying the patchset (you'd 404), but we allow that here.
2854 if parsed_url.path == '/':
2855 part = parsed_url.fragment
2856 else:
2857 part = parsed_url.path
Aaron Gable01b91062017-08-24 17:48:40 -07002858 match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002859 if match:
2860 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002861 issue=int(match.group(3)),
2862 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002863 hostname=parsed_url.netloc,
2864 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002865 return None
2866
tandrii16e0b4e2016-06-07 10:34:28 -07002867 def _GerritCommitMsgHookCheck(self, offer_removal):
2868 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2869 if not os.path.exists(hook):
2870 return
2871 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2872 # custom developer made one.
2873 data = gclient_utils.FileRead(hook)
2874 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2875 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002876 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002877 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002878 'and may interfere with it in subtle ways.\n'
2879 'We recommend you remove the commit-msg hook.')
2880 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002881 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002882 gclient_utils.rm_file_or_tree(hook)
2883 print('Gerrit commit-msg hook removed.')
2884 else:
2885 print('OK, will keep Gerrit commit-msg hook in place.')
2886
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002887 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002888 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002889 if options.squash and options.no_squash:
2890 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002891
2892 if not options.squash and not options.no_squash:
2893 # Load default for user, repo, squash=true, in this order.
2894 options.squash = settings.GetSquashGerritUploads()
2895 elif options.no_squash:
2896 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002897
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002898 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002899 branch = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002900
Aaron Gableb56ad332017-01-06 15:24:31 -08002901 # This may be None; default fallback value is determined in logic below.
2902 title = options.title
2903
Dominic Battre7d1c4842017-10-27 09:17:28 +02002904 # Extract bug number from branch name.
2905 bug = options.bug
2906 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2907 if not bug and match:
2908 bug = match.group(1)
2909
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002910 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002911 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002912 if self.GetIssue():
2913 # Try to get the message from a previous upload.
2914 message = self.GetDescription()
2915 if not message:
2916 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002917 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002918 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002919 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002920 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002921 # When uploading a subsequent patchset, -m|--message is taken
2922 # as the patchset title if --title was not provided.
2923 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002924 else:
2925 default_title = RunGit(
2926 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002927 if options.force:
2928 title = default_title
2929 else:
2930 title = ask_for_data(
2931 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002932 change_id = self._GetChangeDetail()['change_id']
2933 while True:
2934 footer_change_ids = git_footers.get_footer_change_id(message)
2935 if footer_change_ids == [change_id]:
2936 break
2937 if not footer_change_ids:
2938 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002939 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002940 continue
2941 # There is already a valid footer but with different or several ids.
2942 # Doing this automatically is non-trivial as we don't want to lose
2943 # existing other footers, yet we want to append just 1 desired
2944 # Change-Id. Thus, just create a new footer, but let user verify the
2945 # new description.
2946 message = '%s\n\nChange-Id: %s' % (message, change_id)
2947 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002948 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002949 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002950 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002951 'Please, check the proposed correction to the description, '
2952 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2953 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2954 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002955 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002956 if not options.force:
2957 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002958 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002959 message = change_desc.description
2960 if not message:
2961 DieWithError("Description is empty. Aborting...")
2962 # Continue the while loop.
2963 # Sanity check of this code - we should end up with proper message
2964 # footer.
2965 assert [change_id] == git_footers.get_footer_change_id(message)
2966 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002967 else: # if not self.GetIssue()
2968 if options.message:
2969 message = options.message
2970 else:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002971 message = CreateDescriptionFromLog(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002972 if options.title:
2973 message = options.title + '\n\n' + message
2974 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002975
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002976 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002977 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002978 # On first upload, patchset title is always this string, while
2979 # --title flag gets converted to first line of message.
2980 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002981 if not change_desc.description:
2982 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002983 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002984 if len(change_ids) > 1:
2985 DieWithError('too many Change-Id footers, at most 1 allowed.')
2986 if not change_ids:
2987 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002988 change_desc.set_description(git_footers.add_footer_change_id(
2989 change_desc.description,
2990 GenerateGerritChangeId(change_desc.description)))
2991 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002992 assert len(change_ids) == 1
2993 change_id = change_ids[0]
2994
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002995 if options.reviewers or options.tbrs or options.add_owners_to:
2996 change_desc.update_reviewers(options.reviewers, options.tbrs,
2997 options.add_owners_to, change)
2998
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002999 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003000 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
3001 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003002 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07003003 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
3004 desc_tempfile.write(change_desc.description)
3005 desc_tempfile.close()
3006 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
3007 '-F', desc_tempfile.name]).strip()
3008 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003009 else:
3010 change_desc = ChangeDescription(
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003011 options.message or CreateDescriptionFromLog(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003012 if not change_desc.description:
3013 DieWithError("Description is empty. Aborting...")
3014
3015 if not git_footers.get_footer_change_id(change_desc.description):
3016 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003017 change_desc.set_description(
3018 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07003019 if options.reviewers or options.tbrs or options.add_owners_to:
3020 change_desc.update_reviewers(options.reviewers, options.tbrs,
3021 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003022 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003023 # For no-squash mode, we assume the remote called "origin" is the one we
3024 # want. It is not worthwhile to support different workflows for
3025 # no-squash mode.
3026 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003027 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
3028
3029 assert change_desc
3030 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
3031 ref_to_push)]).splitlines()
3032 if len(commits) > 1:
3033 print('WARNING: This will upload %d commits. Run the following command '
3034 'to see which commits will be uploaded: ' % len(commits))
3035 print('git log %s..%s' % (parent, ref_to_push))
3036 print('You can also use `git squash-branch` to squash these into a '
3037 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003038 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003039
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003040 if options.reviewers or options.tbrs or options.add_owners_to:
3041 change_desc.update_reviewers(options.reviewers, options.tbrs,
3042 options.add_owners_to, change)
3043
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003044 # Extra options that can be specified at push time. Doc:
3045 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003046 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003047
Aaron Gable844cf292017-06-28 11:32:59 -07003048 # By default, new changes are started in WIP mode, and subsequent patchsets
3049 # don't send email. At any time, passing --send-mail will mark the change
3050 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07003051 if options.send_mail:
3052 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07003053 refspec_opts.append('notify=ALL')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003054 elif not self.GetIssue():
3055 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07003056 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003057 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07003058
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003059 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07003060 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003061
Aaron Gable9b713dd2016-12-14 16:04:21 -08003062 if title:
Nick Carter8692b182017-11-06 16:30:38 -08003063 # Punctuation and whitespace in |title| must be percent-encoded.
3064 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003065
agablec6787972016-09-09 16:13:34 -07003066 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07003067 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07003068
rmistry9eadede2016-09-19 11:22:43 -07003069 if options.topic:
3070 # Documentation on Gerrit topics is here:
3071 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003072 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07003073
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003074 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08003075 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003076 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08003077 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003078 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
3079
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003080 refspec_suffix = ''
3081 if refspec_opts:
3082 refspec_suffix = '%' + ','.join(refspec_opts)
3083 assert ' ' not in refspec_suffix, (
3084 'spaces not allowed in refspec: "%s"' % refspec_suffix)
3085 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
3086
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003087 try:
3088 push_stdout = gclient_utils.CheckCallAndFilter(
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003089 ['git', 'push', self.GetRemoteUrl(), refspec],
3090 print_stdout=True,
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003091 # Flush after every line: useful for seeing progress when running as
3092 # recipe.
3093 filter_fn=lambda _: sys.stdout.flush())
3094 except subprocess2.CalledProcessError:
3095 DieWithError('Failed to create a change. Please examine output above '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003096 'for the reason of the failure.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003097 'Hint: run command below to diagnose common Git/Gerrit '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003098 'credential problems:\n'
3099 ' git cl creds-check\n',
3100 change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003101
3102 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07003103 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003104 change_numbers = [m.group(1)
3105 for m in map(regex.match, push_stdout.splitlines())
3106 if m]
3107 if len(change_numbers) != 1:
3108 DieWithError(
3109 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11003110 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003111 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07003112 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07003113
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003114 reviewers = sorted(change_desc.get_reviewers())
3115
tandrii88189772016-09-29 04:29:57 -07003116 # Add cc's from the CC_LIST and --cc flag (if any).
Aaron Gabled1052492017-05-15 15:05:34 -07003117 if not options.private:
3118 cc = self.GetCCList().split(',')
3119 else:
3120 cc = []
tandrii88189772016-09-29 04:29:57 -07003121 if options.cc:
3122 cc.extend(options.cc)
3123 cc = filter(None, [email.strip() for email in cc])
bradnelsond975b302016-10-23 12:20:23 -07003124 if change_desc.get_cced():
3125 cc.extend(change_desc.get_cced())
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003126
3127 gerrit_util.AddReviewers(
3128 self._GetGerritHost(), self.GetIssue(), reviewers, cc,
3129 notify=bool(options.send_mail))
3130
Aaron Gablefd238082017-06-07 13:42:34 -07003131 if change_desc.get_reviewers(tbr_only=True):
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003132 labels = self._GetChangeDetail(['LABELS']).get('labels', {})
3133 score = 1
3134 if 'Code-Review' in labels and 'values' in labels['Code-Review']:
3135 score = max([int(x) for x in labels['Code-Review']['values'].keys()])
3136 print('Adding self-LGTM (Code-Review +%d) because of TBRs.' % score)
Aaron Gablefd238082017-06-07 13:42:34 -07003137 gerrit_util.SetReview(
3138 self._GetGerritHost(), self.GetIssue(),
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003139 msg='Self-approving for TBR',
3140 labels={'Code-Review': score})
Aaron Gablefd238082017-06-07 13:42:34 -07003141
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003142 return 0
3143
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003144 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
3145 change_desc):
3146 """Computes parent of the generated commit to be uploaded to Gerrit.
3147
3148 Returns revision or a ref name.
3149 """
3150 if custom_cl_base:
3151 # Try to avoid creating additional unintended CLs when uploading, unless
3152 # user wants to take this risk.
3153 local_ref_of_target_remote = self.GetRemoteBranch()[1]
3154 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
3155 local_ref_of_target_remote])
3156 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003157 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003158 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
3159 'If you proceed with upload, more than 1 CL may be created by '
3160 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
3161 'If you are certain that specified base `%s` has already been '
3162 'uploaded to Gerrit as another CL, you may proceed.\n' %
3163 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
3164 if not force:
3165 confirm_or_exit(
3166 'Do you take responsibility for cleaning up potential mess '
3167 'resulting from proceeding with upload?',
3168 action='upload')
3169 return custom_cl_base
3170
Aaron Gablef97e33d2017-03-30 15:44:27 -07003171 if remote != '.':
3172 return self.GetCommonAncestorWithUpstream()
3173
3174 # If our upstream branch is local, we base our squashed commit on its
3175 # squashed version.
3176 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
3177
Aaron Gablef97e33d2017-03-30 15:44:27 -07003178 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07003179 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07003180
3181 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003182 # TODO(tandrii): consider checking parent change in Gerrit and using its
3183 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
3184 # the tree hash of the parent branch. The upside is less likely bogus
3185 # requests to reupload parent change just because it's uploadhash is
3186 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07003187 parent = RunGit(['config',
3188 'branch.%s.gerritsquashhash' % upstream_branch_name],
3189 error_ok=True).strip()
3190 # Verify that the upstream branch has been uploaded too, otherwise
3191 # Gerrit will create additional CLs when uploading.
3192 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
3193 RunGitSilent(['rev-parse', parent + ':'])):
3194 DieWithError(
3195 '\nUpload upstream branch %s first.\n'
3196 'It is likely that this branch has been rebased since its last '
3197 'upload, so you just need to upload it again.\n'
3198 '(If you uploaded it with --no-squash, then branch dependencies '
3199 'are not supported, and you should reupload with --squash.)'
3200 % upstream_branch_name,
3201 change_desc)
3202 return parent
3203
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003204 def _AddChangeIdToCommitMessage(self, options, args):
3205 """Re-commits using the current message, assumes the commit hook is in
3206 place.
3207 """
3208 log_desc = options.message or CreateDescriptionFromLog(args)
3209 git_command = ['commit', '--amend', '-m', log_desc]
3210 RunGit(git_command)
3211 new_log_desc = CreateDescriptionFromLog(args)
3212 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07003213 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003214 return new_log_desc
3215 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00003216 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003217
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003218 def SetCQState(self, new_state):
3219 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003220 vote_map = {
3221 _CQState.NONE: 0,
3222 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003223 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003224 }
Aaron Gablefc62f762017-07-17 11:12:07 -07003225 labels = {'Commit-Queue': vote_map[new_state]}
3226 notify = False if new_state == _CQState.DRY_RUN else None
3227 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
3228 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003229
tandriie113dfd2016-10-11 10:20:12 -07003230 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07003231 try:
3232 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08003233 except GerritChangeNotExists:
3234 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07003235
3236 if data['status'] in ('ABANDONED', 'MERGED'):
3237 return 'CL %s is closed' % self.GetIssue()
3238
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003239 def GetTryJobProperties(self, patchset=None):
3240 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07003241 data = self._GetChangeDetail(['ALL_REVISIONS'])
3242 patchset = int(patchset or self.GetPatchset())
3243 assert patchset
3244 revision_data = None # Pylint wants it to be defined.
3245 for revision_data in data['revisions'].itervalues():
3246 if int(revision_data['_number']) == patchset:
3247 break
3248 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08003249 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07003250 (patchset, self.GetIssue()))
3251 return {
3252 'patch_issue': self.GetIssue(),
3253 'patch_set': patchset or self.GetPatchset(),
3254 'patch_project': data['project'],
3255 'patch_storage': 'gerrit',
3256 'patch_ref': revision_data['fetch']['http']['ref'],
3257 'patch_repository_url': revision_data['fetch']['http']['url'],
3258 'patch_gerrit_url': self.GetCodereviewServer(),
3259 }
tandriie113dfd2016-10-11 10:20:12 -07003260
tandriide281ae2016-10-12 06:02:30 -07003261 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07003262 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07003263
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003264
3265_CODEREVIEW_IMPLEMENTATIONS = {
3266 'rietveld': _RietveldChangelistImpl,
3267 'gerrit': _GerritChangelistImpl,
3268}
3269
tandrii@chromium.org013a2802016-03-29 09:52:33 +00003270
iannuccie53c9352016-08-17 14:40:40 -07003271def _add_codereview_issue_select_options(parser, extra=""):
3272 _add_codereview_select_options(parser)
3273
3274 text = ('Operate on this issue number instead of the current branch\'s '
3275 'implicit issue.')
3276 if extra:
3277 text += ' '+extra
3278 parser.add_option('-i', '--issue', type=int, help=text)
3279
3280
3281def _process_codereview_issue_select_options(parser, options):
3282 _process_codereview_select_options(parser, options)
3283 if options.issue is not None and not options.forced_codereview:
3284 parser.error('--issue must be specified with either --rietveld or --gerrit')
3285
3286
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003287def _add_codereview_select_options(parser):
3288 """Appends --gerrit and --rietveld options to force specific codereview."""
3289 parser.codereview_group = optparse.OptionGroup(
3290 parser, 'EXPERIMENTAL! Codereview override options')
3291 parser.add_option_group(parser.codereview_group)
3292 parser.codereview_group.add_option(
3293 '--gerrit', action='store_true',
3294 help='Force the use of Gerrit for codereview')
3295 parser.codereview_group.add_option(
3296 '--rietveld', action='store_true',
3297 help='Force the use of Rietveld for codereview')
3298
3299
3300def _process_codereview_select_options(parser, options):
3301 if options.gerrit and options.rietveld:
3302 parser.error('Options --gerrit and --rietveld are mutually exclusive')
3303 options.forced_codereview = None
3304 if options.gerrit:
3305 options.forced_codereview = 'gerrit'
3306 elif options.rietveld:
3307 options.forced_codereview = 'rietveld'
3308
3309
tandriif9aefb72016-07-01 09:06:51 -07003310def _get_bug_line_values(default_project, bugs):
3311 """Given default_project and comma separated list of bugs, yields bug line
3312 values.
3313
3314 Each bug can be either:
3315 * a number, which is combined with default_project
3316 * string, which is left as is.
3317
3318 This function may produce more than one line, because bugdroid expects one
3319 project per line.
3320
3321 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
3322 ['v8:123', 'chromium:789']
3323 """
3324 default_bugs = []
3325 others = []
3326 for bug in bugs.split(','):
3327 bug = bug.strip()
3328 if bug:
3329 try:
3330 default_bugs.append(int(bug))
3331 except ValueError:
3332 others.append(bug)
3333
3334 if default_bugs:
3335 default_bugs = ','.join(map(str, default_bugs))
3336 if default_project:
3337 yield '%s:%s' % (default_project, default_bugs)
3338 else:
3339 yield default_bugs
3340 for other in sorted(others):
3341 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3342 yield other
3343
3344
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003345class ChangeDescription(object):
3346 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003347 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003348 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003349 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003350 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003351 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3352 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
3353 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
3354 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003355
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003356 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00003357 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003358
agable@chromium.org42c20792013-09-12 17:34:49 +00003359 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003360 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003361 return '\n'.join(self._description_lines)
3362
3363 def set_description(self, desc):
3364 if isinstance(desc, basestring):
3365 lines = desc.splitlines()
3366 else:
3367 lines = [line.rstrip() for line in desc]
3368 while lines and not lines[0]:
3369 lines.pop(0)
3370 while lines and not lines[-1]:
3371 lines.pop(-1)
3372 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003373
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003374 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3375 """Rewrites the R=/TBR= line(s) as a single line each.
3376
3377 Args:
3378 reviewers (list(str)) - list of additional emails to use for reviewers.
3379 tbrs (list(str)) - list of additional emails to use for TBRs.
3380 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3381 the change that are missing OWNER coverage. If this is not None, you
3382 must also pass a value for `change`.
3383 change (Change) - The Change that should be used for OWNERS lookups.
3384 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003385 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003386 assert isinstance(tbrs, list), tbrs
3387
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003388 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003389 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003390
3391 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003392 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003393
3394 reviewers = set(reviewers)
3395 tbrs = set(tbrs)
3396 LOOKUP = {
3397 'TBR': tbrs,
3398 'R': reviewers,
3399 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003400
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003401 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003402 regexp = re.compile(self.R_LINE)
3403 matches = [regexp.match(line) for line in self._description_lines]
3404 new_desc = [l for i, l in enumerate(self._description_lines)
3405 if not matches[i]]
3406 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003407
agable@chromium.org42c20792013-09-12 17:34:49 +00003408 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003409
3410 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003411 for match in matches:
3412 if not match:
3413 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003414 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3415
3416 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003417 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003418 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003419 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003420 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003421 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003422 LOOKUP[add_owners_to].update(
3423 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003424
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003425 # If any folks ended up in both groups, remove them from tbrs.
3426 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003427
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003428 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3429 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003430
3431 # Put the new lines in the description where the old first R= line was.
3432 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3433 if 0 <= line_loc < len(self._description_lines):
3434 if new_tbr_line:
3435 self._description_lines.insert(line_loc, new_tbr_line)
3436 if new_r_line:
3437 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003438 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003439 if new_r_line:
3440 self.append_footer(new_r_line)
3441 if new_tbr_line:
3442 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003443
Aaron Gable3a16ed12017-03-23 10:51:55 -07003444 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003445 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003446 self.set_description([
3447 '# Enter a description of the change.',
3448 '# This will be displayed on the codereview site.',
3449 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003450 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003451 '--------------------',
3452 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003453
agable@chromium.org42c20792013-09-12 17:34:49 +00003454 regexp = re.compile(self.BUG_LINE)
3455 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003456 prefix = settings.GetBugPrefix()
3457 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003458 if git_footer:
3459 self.append_footer('Bug: %s' % ', '.join(values))
3460 else:
3461 for value in values:
3462 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003463
agable@chromium.org42c20792013-09-12 17:34:49 +00003464 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003465 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003466 if not content:
3467 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003468 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003469
3470 # Strip off comments.
agable@chromium.org42c20792013-09-12 17:34:49 +00003471 clean_lines = [line.rstrip() for line in lines if not line.startswith('#')]
3472 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003473 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003474 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003475
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003476 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003477 """Adds a footer line to the description.
3478
3479 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3480 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3481 that Gerrit footers are always at the end.
3482 """
3483 parsed_footer_line = git_footers.parse_footer(line)
3484 if parsed_footer_line:
3485 # Line is a gerrit footer in the form: Footer-Key: any value.
3486 # Thus, must be appended observing Gerrit footer rules.
3487 self.set_description(
3488 git_footers.add_footer(self.description,
3489 key=parsed_footer_line[0],
3490 value=parsed_footer_line[1]))
3491 return
3492
3493 if not self._description_lines:
3494 self._description_lines.append(line)
3495 return
3496
3497 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3498 if gerrit_footers:
3499 # git_footers.split_footers ensures that there is an empty line before
3500 # actual (gerrit) footers, if any. We have to keep it that way.
3501 assert top_lines and top_lines[-1] == ''
3502 top_lines, separator = top_lines[:-1], top_lines[-1:]
3503 else:
3504 separator = [] # No need for separator if there are no gerrit_footers.
3505
3506 prev_line = top_lines[-1] if top_lines else ''
3507 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3508 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3509 top_lines.append('')
3510 top_lines.append(line)
3511 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003512
tandrii99a72f22016-08-17 14:33:24 -07003513 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003514 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003515 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003516 reviewers = [match.group(2).strip()
3517 for match in matches
3518 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003519 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003520
bradnelsond975b302016-10-23 12:20:23 -07003521 def get_cced(self):
3522 """Retrieves the list of reviewers."""
3523 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3524 cced = [match.group(2).strip() for match in matches if match]
3525 return cleanup_list(cced)
3526
Nodir Turakulov23b82142017-11-16 11:04:25 -08003527 def get_hash_tags(self):
3528 """Extracts and sanitizes a list of Gerrit hashtags."""
3529 subject = (self._description_lines or ('',))[0]
3530 subject = re.sub(
3531 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3532
3533 tags = []
3534 start = 0
3535 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3536 while True:
3537 m = bracket_exp.match(subject, start)
3538 if not m:
3539 break
3540 tags.append(self.sanitize_hash_tag(m.group(1)))
3541 start = m.end()
3542
3543 if not tags:
3544 # Try "Tag: " prefix.
3545 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3546 if m:
3547 tags.append(self.sanitize_hash_tag(m.group(1)))
3548 return tags
3549
3550 @classmethod
3551 def sanitize_hash_tag(cls, tag):
3552 """Returns a sanitized Gerrit hash tag.
3553
3554 A sanitized hashtag can be used as a git push refspec parameter value.
3555 """
3556 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3557
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003558 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3559 """Updates this commit description given the parent.
3560
3561 This is essentially what Gnumbd used to do.
3562 Consult https://goo.gl/WMmpDe for more details.
3563 """
3564 assert parent_msg # No, orphan branch creation isn't supported.
3565 assert parent_hash
3566 assert dest_ref
3567 parent_footer_map = git_footers.parse_footers(parent_msg)
3568 # This will also happily parse svn-position, which GnumbD is no longer
3569 # supporting. While we'd generate correct footers, the verifier plugin
3570 # installed in Gerrit will block such commit (ie git push below will fail).
3571 parent_position = git_footers.get_position(parent_footer_map)
3572
3573 # Cherry-picks may have last line obscuring their prior footers,
3574 # from git_footers perspective. This is also what Gnumbd did.
3575 cp_line = None
3576 if (self._description_lines and
3577 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3578 cp_line = self._description_lines.pop()
3579
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003580 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003581
3582 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3583 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003584 for i, line in enumerate(footer_lines):
3585 k, v = git_footers.parse_footer(line) or (None, None)
3586 if k and k.startswith('Cr-'):
3587 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003588
3589 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003590 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003591 if parent_position[0] == dest_ref:
3592 # Same branch as parent.
3593 number = int(parent_position[1]) + 1
3594 else:
3595 number = 1 # New branch, and extra lineage.
3596 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3597 int(parent_position[1])))
3598
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003599 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3600 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003601
3602 self._description_lines = top_lines
3603 if cp_line:
3604 self._description_lines.append(cp_line)
3605 if self._description_lines[-1] != '':
3606 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003607 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003608
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003609
Aaron Gablea1bab272017-04-11 16:38:18 -07003610def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003611 """Retrieves the reviewers that approved a CL from the issue properties with
3612 messages.
3613
3614 Note that the list may contain reviewers that are not committer, thus are not
3615 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003616
3617 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003618 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003619 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003620 return sorted(
3621 set(
3622 message['sender']
3623 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003624 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003625 )
3626 )
3627
3628
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003629def FindCodereviewSettingsFile(filename='codereview.settings'):
3630 """Finds the given file starting in the cwd and going up.
3631
3632 Only looks up to the top of the repository unless an
3633 'inherit-review-settings-ok' file exists in the root of the repository.
3634 """
3635 inherit_ok_file = 'inherit-review-settings-ok'
3636 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003637 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003638 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3639 root = '/'
3640 while True:
3641 if filename in os.listdir(cwd):
3642 if os.path.isfile(os.path.join(cwd, filename)):
3643 return open(os.path.join(cwd, filename))
3644 if cwd == root:
3645 break
3646 cwd = os.path.dirname(cwd)
3647
3648
3649def LoadCodereviewSettingsFromFile(fileobj):
3650 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003651 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003652
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003653 def SetProperty(name, setting, unset_error_ok=False):
3654 fullname = 'rietveld.' + name
3655 if setting in keyvals:
3656 RunGit(['config', fullname, keyvals[setting]])
3657 else:
3658 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3659
tandrii48df5812016-10-17 03:55:37 -07003660 if not keyvals.get('GERRIT_HOST', False):
3661 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003662 # Only server setting is required. Other settings can be absent.
3663 # In that case, we ignore errors raised during option deletion attempt.
3664 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +00003665 SetProperty('private', 'PRIVATE', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003666 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3667 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003668 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003669 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3670 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
sheyang@chromium.org152cf832014-06-11 21:37:49 +00003671 SetProperty('project', 'PROJECT', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003672 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3673 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003674
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003675 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003676 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003677
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003678 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003679 RunGit(['config', 'gerrit.squash-uploads',
3680 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003681
tandrii@chromium.org28253532016-04-14 13:46:56 +00003682 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003683 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003684 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3685
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003686 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003687 # should be of the form
3688 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3689 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003690 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3691 keyvals['ORIGIN_URL_CONFIG']])
3692
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003693
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003694def urlretrieve(source, destination):
3695 """urllib is broken for SSL connections via a proxy therefore we
3696 can't use urllib.urlretrieve()."""
3697 with open(destination, 'w') as f:
3698 f.write(urllib2.urlopen(source).read())
3699
3700
ukai@chromium.org712d6102013-11-27 00:52:58 +00003701def hasSheBang(fname):
3702 """Checks fname is a #! script."""
3703 with open(fname) as f:
3704 return f.read(2).startswith('#!')
3705
3706
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003707# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3708def DownloadHooks(*args, **kwargs):
3709 pass
3710
3711
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003712def DownloadGerritHook(force):
3713 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003714
3715 Args:
3716 force: True to update hooks. False to install hooks if not present.
3717 """
3718 if not settings.GetIsGerrit():
3719 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003720 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003721 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3722 if not os.access(dst, os.X_OK):
3723 if os.path.exists(dst):
3724 if not force:
3725 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003726 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003727 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003728 if not hasSheBang(dst):
3729 DieWithError('Not a script: %s\n'
3730 'You need to download from\n%s\n'
3731 'into .git/hooks/commit-msg and '
3732 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003733 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3734 except Exception:
3735 if os.path.exists(dst):
3736 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003737 DieWithError('\nFailed to download hooks.\n'
3738 'You need to download from\n%s\n'
3739 'into .git/hooks/commit-msg and '
3740 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003741
3742
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00003743def GetRietveldCodereviewSettingsInteractively():
3744 """Prompt the user for settings."""
3745 server = settings.GetDefaultServerUrl(error_ok=True)
3746 prompt = 'Rietveld server (host[:port])'
3747 prompt += ' [%s]' % (server or DEFAULT_SERVER)
3748 newserver = ask_for_data(prompt + ':')
3749 if not server and not newserver:
3750 newserver = DEFAULT_SERVER
3751 if newserver:
3752 newserver = gclient_utils.UpgradeToHttps(newserver)
3753 if newserver != server:
3754 RunGit(['config', 'rietveld.server', newserver])
3755
3756 def SetProperty(initial, caption, name, is_url):
3757 prompt = caption
3758 if initial:
3759 prompt += ' ("x" to clear) [%s]' % initial
3760 new_val = ask_for_data(prompt + ':')
3761 if new_val == 'x':
3762 RunGit(['config', '--unset-all', 'rietveld.' + name], error_ok=True)
3763 elif new_val:
3764 if is_url:
3765 new_val = gclient_utils.UpgradeToHttps(new_val)
3766 if new_val != initial:
3767 RunGit(['config', 'rietveld.' + name, new_val])
3768
3769 SetProperty(settings.GetDefaultCCList(), 'CC list', 'cc', False)
3770 SetProperty(settings.GetDefaultPrivateFlag(),
3771 'Private flag (rietveld only)', 'private', False)
3772 SetProperty(settings.GetTreeStatusUrl(error_ok=True), 'Tree status URL',
3773 'tree-status-url', False)
3774 SetProperty(settings.GetViewVCUrl(), 'ViewVC URL', 'viewvc-url', True)
3775 SetProperty(settings.GetBugPrefix(), 'Bug Prefix', 'bug-prefix', False)
3776 SetProperty(settings.GetRunPostUploadHook(), 'Run Post Upload Hook',
3777 'run-post-upload-hook', False)
3778
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003779
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003780class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003781 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003782
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003783 _GOOGLESOURCE = 'googlesource.com'
3784
3785 def __init__(self):
3786 # Cached list of [host, identity, source], where source is either
3787 # .gitcookies or .netrc.
3788 self._all_hosts = None
3789
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003790 def ensure_configured_gitcookies(self):
3791 """Runs checks and suggests fixes to make git use .gitcookies from default
3792 path."""
3793 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3794 configured_path = RunGitSilent(
3795 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003796 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003797 if configured_path:
3798 self._ensure_default_gitcookies_path(configured_path, default)
3799 else:
3800 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003801
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003802 @staticmethod
3803 def _ensure_default_gitcookies_path(configured_path, default_path):
3804 assert configured_path
3805 if configured_path == default_path:
3806 print('git is already configured to use your .gitcookies from %s' %
3807 configured_path)
3808 return
3809
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003810 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003811 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3812 (configured_path, default_path))
3813
3814 if not os.path.exists(configured_path):
3815 print('However, your configured .gitcookies file is missing.')
3816 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3817 action='reconfigure')
3818 RunGit(['config', '--global', 'http.cookiefile', default_path])
3819 return
3820
3821 if os.path.exists(default_path):
3822 print('WARNING: default .gitcookies file already exists %s' %
3823 default_path)
3824 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3825 default_path)
3826
3827 confirm_or_exit('Move existing .gitcookies to default location?',
3828 action='move')
3829 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003830 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003831 print('Moved and reconfigured git to use .gitcookies from %s' %
3832 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003833
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003834 @staticmethod
3835 def _configure_gitcookies_path(default_path):
3836 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3837 if os.path.exists(netrc_path):
3838 print('You seem to be using outdated .netrc for git credentials: %s' %
3839 netrc_path)
3840 print('This tool will guide you through setting up recommended '
3841 '.gitcookies store for git credentials.\n'
3842 '\n'
3843 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3844 ' git config --global --unset http.cookiefile\n'
3845 ' mv %s %s.backup\n\n' % (default_path, default_path))
3846 confirm_or_exit(action='setup .gitcookies')
3847 RunGit(['config', '--global', 'http.cookiefile', default_path])
3848 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003849
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003850 def get_hosts_with_creds(self, include_netrc=False):
3851 if self._all_hosts is None:
3852 a = gerrit_util.CookiesAuthenticator()
3853 self._all_hosts = [
3854 (h, u, s)
3855 for h, u, s in itertools.chain(
3856 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3857 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3858 )
3859 if h.endswith(self._GOOGLESOURCE)
3860 ]
3861
3862 if include_netrc:
3863 return self._all_hosts
3864 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3865
3866 def print_current_creds(self, include_netrc=False):
3867 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3868 if not hosts:
3869 print('No Git/Gerrit credentials found')
3870 return
3871 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3872 header = [('Host', 'User', 'Which file'),
3873 ['=' * l for l in lengths]]
3874 for row in (header + hosts):
3875 print('\t'.join((('%%+%ds' % l) % s)
3876 for l, s in zip(lengths, row)))
3877
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003878 @staticmethod
3879 def _parse_identity(identity):
3880 """Parses identity "git-<ldap>.example.com" into <ldap> and domain."""
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003881 # Special case: users whose ldaps contain ".", which are generally not
3882 # distinguishable from sub-domains. But we do know typical domains:
3883 if identity.endswith('.chromium.org'):
3884 domain = 'chromium.org'
3885 username = identity[:-len('.chromium.org')]
3886 else:
3887 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003888 if username.startswith('git-'):
3889 username = username[len('git-'):]
3890 return username, domain
3891
3892 def _get_usernames_of_domain(self, domain):
3893 """Returns list of usernames referenced by .gitcookies in a given domain."""
3894 identities_by_domain = {}
3895 for _, identity, _ in self.get_hosts_with_creds():
3896 username, domain = self._parse_identity(identity)
3897 identities_by_domain.setdefault(domain, []).append(username)
3898 return identities_by_domain.get(domain)
3899
3900 def _canonical_git_googlesource_host(self, host):
3901 """Normalizes Gerrit hosts (with '-review') to Git host."""
3902 assert host.endswith(self._GOOGLESOURCE)
3903 # Prefix doesn't include '.' at the end.
3904 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3905 if prefix.endswith('-review'):
3906 prefix = prefix[:-len('-review')]
3907 return prefix + '.' + self._GOOGLESOURCE
3908
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003909 def _canonical_gerrit_googlesource_host(self, host):
3910 git_host = self._canonical_git_googlesource_host(host)
3911 prefix = git_host.split('.', 1)[0]
3912 return prefix + '-review.' + self._GOOGLESOURCE
3913
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003914 def _get_counterpart_host(self, host):
3915 assert host.endswith(self._GOOGLESOURCE)
3916 git = self._canonical_git_googlesource_host(host)
3917 gerrit = self._canonical_gerrit_googlesource_host(git)
3918 return git if gerrit == host else gerrit
3919
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003920 def has_generic_host(self):
3921 """Returns whether generic .googlesource.com has been configured.
3922
3923 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3924 """
3925 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3926 if host == '.' + self._GOOGLESOURCE:
3927 return True
3928 return False
3929
3930 def _get_git_gerrit_identity_pairs(self):
3931 """Returns map from canonic host to pair of identities (Git, Gerrit).
3932
3933 One of identities might be None, meaning not configured.
3934 """
3935 host_to_identity_pairs = {}
3936 for host, identity, _ in self.get_hosts_with_creds():
3937 canonical = self._canonical_git_googlesource_host(host)
3938 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3939 idx = 0 if canonical == host else 1
3940 pair[idx] = identity
3941 return host_to_identity_pairs
3942
3943 def get_partially_configured_hosts(self):
3944 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003945 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3946 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3947 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003948
3949 def get_conflicting_hosts(self):
3950 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003951 host
3952 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003953 if None not in (i1, i2) and i1 != i2)
3954
3955 def get_duplicated_hosts(self):
3956 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3957 return set(host for host, count in counters.iteritems() if count > 1)
3958
3959 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3960 'chromium.googlesource.com': 'chromium.org',
3961 'chrome-internal.googlesource.com': 'google.com',
3962 }
3963
3964 def get_hosts_with_wrong_identities(self):
3965 """Finds hosts which **likely** reference wrong identities.
3966
3967 Note: skips hosts which have conflicting identities for Git and Gerrit.
3968 """
3969 hosts = set()
3970 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3971 pair = self._get_git_gerrit_identity_pairs().get(host)
3972 if pair and pair[0] == pair[1]:
3973 _, domain = self._parse_identity(pair[0])
3974 if domain != expected:
3975 hosts.add(host)
3976 return hosts
3977
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003978 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003979 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003980 hosts = sorted(hosts)
3981 assert hosts
3982 if extra_column_func is None:
3983 extras = [''] * len(hosts)
3984 else:
3985 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003986 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3987 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003988 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003989 lines.append(tmpl % he)
3990 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003991
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003992 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003993 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003994 yield ('.googlesource.com wildcard record detected',
3995 ['Chrome Infrastructure team recommends to list full host names '
3996 'explicitly.'],
3997 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003998
3999 dups = self.get_duplicated_hosts()
4000 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004001 yield ('The following hosts were defined twice',
4002 self._format_hosts(dups),
4003 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004004
4005 partial = self.get_partially_configured_hosts()
4006 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004007 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
4008 'These hosts are missing',
4009 self._format_hosts(partial, lambda host: 'but %s defined' %
4010 self._get_counterpart_host(host)),
4011 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004012
4013 conflicting = self.get_conflicting_hosts()
4014 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004015 yield ('The following Git hosts have differing credentials from their '
4016 'Gerrit counterparts',
4017 self._format_hosts(conflicting, lambda host: '%s vs %s' %
4018 tuple(self._get_git_gerrit_identity_pairs()[host])),
4019 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004020
4021 wrong = self.get_hosts_with_wrong_identities()
4022 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004023 yield ('These hosts likely use wrong identity',
4024 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
4025 (self._get_git_gerrit_identity_pairs()[host][0],
4026 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
4027 wrong)
4028
4029 def find_and_report_problems(self):
4030 """Returns True if there was at least one problem, else False."""
4031 found = False
4032 bad_hosts = set()
4033 for title, sublines, hosts in self._find_problems():
4034 if not found:
4035 found = True
4036 print('\n\n.gitcookies problem report:\n')
4037 bad_hosts.update(hosts or [])
4038 print(' %s%s' % (title , (':' if sublines else '')))
4039 if sublines:
4040 print()
4041 print(' %s' % '\n '.join(sublines))
4042 print()
4043
4044 if bad_hosts:
4045 assert found
4046 print(' You can manually remove corresponding lines in your %s file and '
4047 'visit the following URLs with correct account to generate '
4048 'correct credential lines:\n' %
4049 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
4050 print(' %s' % '\n '.join(sorted(set(
4051 gerrit_util.CookiesAuthenticator().get_new_password_url(
4052 self._canonical_git_googlesource_host(host))
4053 for host in bad_hosts
4054 ))))
4055 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004056
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004057
4058def CMDcreds_check(parser, args):
4059 """Checks credentials and suggests changes."""
4060 _, _ = parser.parse_args(args)
4061
4062 if gerrit_util.GceAuthenticator.is_gce():
Aaron Gabled10ca0e2017-09-11 11:24:10 -07004063 DieWithError(
4064 'This command is not designed for GCE, are you on a bot?\n'
4065 'If you need to run this, export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004066
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01004067 checker = _GitCookiesChecker()
4068 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004069
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004070 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004071 checker.print_current_creds(include_netrc=True)
4072
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004073 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004074 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004075 return 0
4076 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004077
4078
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004079@subcommand.usage('[repo root containing codereview.settings]')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004080def CMDconfig(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004081 """Edits configuration for this tree."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004082
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004083 print('WARNING: git cl config works for Rietveld only.')
tandrii5d0a0422016-09-14 06:24:35 -07004084 # TODO(tandrii): remove this once we switch to Gerrit.
4085 # See bugs http://crbug.com/637561 and http://crbug.com/600469.
pgervais@chromium.org87884cc2014-01-03 22:23:41 +00004086 parser.add_option('--activate-update', action='store_true',
4087 help='activate auto-updating [rietveld] section in '
4088 '.git/config')
4089 parser.add_option('--deactivate-update', action='store_true',
4090 help='deactivate auto-updating [rietveld] section in '
4091 '.git/config')
4092 options, args = parser.parse_args(args)
4093
4094 if options.deactivate_update:
4095 RunGit(['config', 'rietveld.autoupdate', 'false'])
4096 return
4097
4098 if options.activate_update:
4099 RunGit(['config', '--unset', 'rietveld.autoupdate'])
4100 return
4101
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004102 if len(args) == 0:
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00004103 GetRietveldCodereviewSettingsInteractively()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004104 return 0
4105
4106 url = args[0]
4107 if not url.endswith('codereview.settings'):
4108 url = os.path.join(url, 'codereview.settings')
4109
4110 # Load code review settings and download hooks (if available).
4111 LoadCodereviewSettingsFromFile(urllib2.urlopen(url))
4112 return 0
4113
4114
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004115def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004116 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004117 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
4118 branch = ShortBranchName(branchref)
4119 _, args = parser.parse_args(args)
4120 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07004121 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004122 return RunGit(['config', 'branch.%s.base-url' % branch],
4123 error_ok=False).strip()
4124 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004125 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004126 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
4127 error_ok=False).strip()
4128
4129
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004130def color_for_status(status):
4131 """Maps a Changelist status to color, for CMDstatus and other tools."""
4132 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07004133 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004134 'waiting': Fore.BLUE,
4135 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07004136 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004137 'lgtm': Fore.GREEN,
4138 'commit': Fore.MAGENTA,
4139 'closed': Fore.CYAN,
4140 'error': Fore.WHITE,
4141 }.get(status, Fore.WHITE)
4142
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00004143
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004144def get_cl_statuses(changes, fine_grained, max_processes=None):
4145 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004146
4147 If fine_grained is true, this will fetch CL statuses from the server.
4148 Otherwise, simply indicate if there's a matching url for the given branches.
4149
4150 If max_processes is specified, it is used as the maximum number of processes
4151 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
4152 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004153
4154 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004155 """
qyearsley12fa6ff2016-08-24 09:18:40 -07004156 # Silence upload.py otherwise it becomes unwieldy.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004157 upload.verbosity = 0
4158
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004159 if not changes:
4160 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004161
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004162 if not fine_grained:
4163 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07004164 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004165 for cl in changes:
4166 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004167 return
4168
4169 # First, sort out authentication issues.
4170 logging.debug('ensuring credentials exist')
4171 for cl in changes:
4172 cl.EnsureAuthenticated(force=False, refresh=True)
4173
4174 def fetch(cl):
4175 try:
4176 return (cl, cl.GetStatus())
4177 except:
4178 # See http://crbug.com/629863.
4179 logging.exception('failed to fetch status for %s:', cl)
4180 raise
4181
4182 threads_count = len(changes)
4183 if max_processes:
4184 threads_count = max(1, min(threads_count, max_processes))
4185 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
4186
4187 pool = ThreadPool(threads_count)
4188 fetched_cls = set()
4189 try:
4190 it = pool.imap_unordered(fetch, changes).__iter__()
4191 while True:
4192 try:
4193 cl, status = it.next(timeout=5)
4194 except multiprocessing.TimeoutError:
4195 break
4196 fetched_cls.add(cl)
4197 yield cl, status
4198 finally:
4199 pool.close()
4200
4201 # Add any branches that failed to fetch.
4202 for cl in set(changes) - fetched_cls:
4203 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004204
rmistry@google.com2dd99862015-06-22 12:22:18 +00004205
4206def upload_branch_deps(cl, args):
4207 """Uploads CLs of local branches that are dependents of the current branch.
4208
4209 If the local branch dependency tree looks like:
4210 test1 -> test2.1 -> test3.1
4211 -> test3.2
4212 -> test2.2 -> test3.3
4213
4214 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
4215 run on the dependent branches in this order:
4216 test2.1, test3.1, test3.2, test2.2, test3.3
4217
4218 Note: This function does not rebase your local dependent branches. Use it when
4219 you make a change to the parent branch that will not conflict with its
4220 dependent branches, and you would like their dependencies updated in
4221 Rietveld.
4222 """
4223 if git_common.is_dirty_git_tree('upload-branch-deps'):
4224 return 1
4225
4226 root_branch = cl.GetBranch()
4227 if root_branch is None:
4228 DieWithError('Can\'t find dependent branches from detached HEAD state. '
4229 'Get on a branch!')
Andrii Shyshkalov1090fd52017-01-26 09:37:54 +01004230 if not cl.GetIssue() or (not cl.IsGerrit() and not cl.GetPatchset()):
rmistry@google.com2dd99862015-06-22 12:22:18 +00004231 DieWithError('Current branch does not have an uploaded CL. We cannot set '
4232 'patchset dependencies without an uploaded CL.')
4233
4234 branches = RunGit(['for-each-ref',
4235 '--format=%(refname:short) %(upstream:short)',
4236 'refs/heads'])
4237 if not branches:
4238 print('No local branches found.')
4239 return 0
4240
4241 # Create a dictionary of all local branches to the branches that are dependent
4242 # on it.
4243 tracked_to_dependents = collections.defaultdict(list)
4244 for b in branches.splitlines():
4245 tokens = b.split()
4246 if len(tokens) == 2:
4247 branch_name, tracked = tokens
4248 tracked_to_dependents[tracked].append(branch_name)
4249
vapiera7fbd5a2016-06-16 09:17:49 -07004250 print()
4251 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004252 dependents = []
4253 def traverse_dependents_preorder(branch, padding=''):
4254 dependents_to_process = tracked_to_dependents.get(branch, [])
4255 padding += ' '
4256 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07004257 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00004258 dependents.append(dependent)
4259 traverse_dependents_preorder(dependent, padding)
4260 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07004261 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004262
4263 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004264 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004265 return 0
4266
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01004267 confirm_or_exit('This command will checkout all dependent branches and run '
4268 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004269
andybons@chromium.org962f9462016-02-03 20:00:42 +00004270 # Add a default patchset title to all upload calls in Rietveld.
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00004271 if not cl.IsGerrit():
andybons@chromium.org962f9462016-02-03 20:00:42 +00004272 args.extend(['-t', 'Updated patchset dependency'])
4273
rmistry@google.com2dd99862015-06-22 12:22:18 +00004274 # Record all dependents that failed to upload.
4275 failures = {}
4276 # Go through all dependents, checkout the branch and upload.
4277 try:
4278 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004279 print()
4280 print('--------------------------------------')
4281 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004282 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07004283 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004284 try:
4285 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07004286 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004287 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004288 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00004289 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07004290 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004291 finally:
4292 # Swap back to the original root branch.
4293 RunGit(['checkout', '-q', root_branch])
4294
vapiera7fbd5a2016-06-16 09:17:49 -07004295 print()
4296 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004297 for dependent_branch in dependents:
4298 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07004299 print(' %s : %s' % (dependent_branch, upload_status))
4300 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004301
4302 return 0
4303
4304
kmarshall3bff56b2016-06-06 18:31:47 -07004305def CMDarchive(parser, args):
4306 """Archives and deletes branches associated with closed changelists."""
4307 parser.add_option(
4308 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07004309 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07004310 parser.add_option(
4311 '-f', '--force', action='store_true',
4312 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07004313 parser.add_option(
4314 '-d', '--dry-run', action='store_true',
4315 help='Skip the branch tagging and removal steps.')
4316 parser.add_option(
4317 '-t', '--notags', action='store_true',
4318 help='Do not tag archived branches. '
4319 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07004320
4321 auth.add_auth_options(parser)
4322 options, args = parser.parse_args(args)
4323 if args:
4324 parser.error('Unsupported args: %s' % ' '.join(args))
4325 auth_config = auth.extract_auth_config_from_options(options)
4326
4327 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4328 if not branches:
4329 return 0
4330
vapiera7fbd5a2016-06-16 09:17:49 -07004331 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07004332 changes = [Changelist(branchref=b, auth_config=auth_config)
4333 for b in branches.splitlines()]
4334 alignment = max(5, max(len(c.GetBranch()) for c in changes))
4335 statuses = get_cl_statuses(changes,
4336 fine_grained=True,
4337 max_processes=options.maxjobs)
4338 proposal = [(cl.GetBranch(),
4339 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
4340 for cl, status in statuses
4341 if status == 'closed']
4342 proposal.sort()
4343
4344 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07004345 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07004346 return 0
4347
4348 current_branch = GetCurrentBranch()
4349
vapiera7fbd5a2016-06-16 09:17:49 -07004350 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07004351 if options.notags:
4352 for next_item in proposal:
4353 print(' ' + next_item[0])
4354 else:
4355 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
4356 for next_item in proposal:
4357 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07004358
kmarshall9249e012016-08-23 12:02:16 -07004359 # Quit now on precondition failure or if instructed by the user, either
4360 # via an interactive prompt or by command line flags.
4361 if options.dry_run:
4362 print('\nNo changes were made (dry run).\n')
4363 return 0
4364 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07004365 print('You are currently on a branch \'%s\' which is associated with a '
4366 'closed codereview issue, so archive cannot proceed. Please '
4367 'checkout another branch and run this command again.' %
4368 current_branch)
4369 return 1
kmarshall9249e012016-08-23 12:02:16 -07004370 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07004371 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
4372 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07004373 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07004374 return 1
4375
4376 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07004377 if not options.notags:
4378 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07004379 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07004380
vapiera7fbd5a2016-06-16 09:17:49 -07004381 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004382
4383 return 0
4384
4385
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004386def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004387 """Show status of changelists.
4388
4389 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004390 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004391 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004392 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004393 - Red 'not LGTM'ed
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004394 - Magenta in the commit queue
4395 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004396 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004397
4398 Also see 'git cl comments'.
4399 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004400 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004401 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004402 parser.add_option('-f', '--fast', action='store_true',
4403 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004404 parser.add_option(
4405 '-j', '--maxjobs', action='store', type=int,
4406 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004407
4408 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07004409 _add_codereview_issue_select_options(
4410 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004411 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07004412 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004413 if args:
4414 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004415 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004416
iannuccie53c9352016-08-17 14:40:40 -07004417 if options.issue is not None and not options.field:
4418 parser.error('--field must be specified with --issue')
iannucci3c972b92016-08-17 13:24:10 -07004419
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004420 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07004421 cl = Changelist(auth_config=auth_config, issue=options.issue,
4422 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004423 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07004424 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004425 elif options.field == 'id':
4426 issueid = cl.GetIssue()
4427 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004428 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004429 elif options.field == 'patch':
4430 patchset = cl.GetPatchset()
4431 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004432 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004433 elif options.field == 'status':
4434 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004435 elif options.field == 'url':
4436 url = cl.GetIssueURL()
4437 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004438 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004439 return 0
4440
4441 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4442 if not branches:
4443 print('No local branch found.')
4444 return 0
4445
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004446 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004447 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004448 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004449 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004450 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004451 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004452 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004453
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004454 branch_statuses = {}
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004455 alignment = max(5, max(len(ShortBranchName(c.GetBranch())) for c in changes))
4456 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4457 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004458 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004459 c, status = output.next()
4460 branch_statuses[c.GetBranch()] = status
4461 status = branch_statuses.pop(branch)
4462 url = cl.GetIssueURL()
4463 if url and (not status or status == 'error'):
4464 # The issue probably doesn't exist anymore.
4465 url += ' (broken)'
4466
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004467 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004468 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004469 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004470 color = ''
4471 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004472 status_str = '(%s)' % status if status else ''
vapiera7fbd5a2016-06-16 09:17:49 -07004473 print(' %*s : %s%s %s%s' % (
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004474 alignment, ShortBranchName(branch), color, url,
vapiera7fbd5a2016-06-16 09:17:49 -07004475 status_str, reset))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004476
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004477
4478 branch = GetCurrentBranch()
vapiera7fbd5a2016-06-16 09:17:49 -07004479 print()
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004480 print('Current branch: %s' % branch)
4481 for cl in changes:
4482 if cl.GetBranch() == branch:
4483 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004484 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004485 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004486 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004487 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004488 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004489 print('Issue description:')
4490 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004491 return 0
4492
4493
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004494def colorize_CMDstatus_doc():
4495 """To be called once in main() to add colors to git cl status help."""
4496 colors = [i for i in dir(Fore) if i[0].isupper()]
4497
4498 def colorize_line(line):
4499 for color in colors:
4500 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004501 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004502 indent = len(line) - len(line.lstrip(' ')) + 1
4503 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4504 return line
4505
4506 lines = CMDstatus.__doc__.splitlines()
4507 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4508
4509
phajdan.jre328cf92016-08-22 04:12:17 -07004510def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004511 if path == '-':
4512 json.dump(contents, sys.stdout)
4513 else:
4514 with open(path, 'w') as f:
4515 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004516
4517
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004518@subcommand.usage('[issue_number]')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004519def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004520 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004521
4522 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004523 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004524 parser.add_option('-r', '--reverse', action='store_true',
4525 help='Lookup the branch(es) for the specified issues. If '
4526 'no issues are specified, all branches with mapped '
4527 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004528 parser.add_option('--json',
4529 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004530 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004531 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004532 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004533
dnj@chromium.org406c4402015-03-03 17:22:28 +00004534 if options.reverse:
4535 branches = RunGit(['for-each-ref', 'refs/heads',
4536 '--format=%(refname:short)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004537 # Reverse issue lookup.
4538 issue_branch_map = {}
4539 for branch in branches:
4540 cl = Changelist(branchref=branch)
4541 issue_branch_map.setdefault(cl.GetIssue(), []).append(branch)
4542 if not args:
4543 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004544 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004545 for issue in args:
4546 if not issue:
4547 continue
phajdan.jre328cf92016-08-22 04:12:17 -07004548 result[int(issue)] = issue_branch_map.get(int(issue))
vapiera7fbd5a2016-06-16 09:17:49 -07004549 print('Branch for issue number %s: %s' % (
4550 issue, ', '.join(issue_branch_map.get(int(issue)) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004551 if options.json:
4552 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004553 return 0
4554
4555 if len(args) > 0:
4556 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4557 if not issue.valid:
4558 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4559 'or no argument to list it.\n'
4560 'Maybe you want to run git cl status?')
4561 cl = Changelist(codereview=issue.codereview)
4562 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004563 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004564 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004565 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4566 if options.json:
4567 write_json(options.json, {
4568 'issue': cl.GetIssue(),
4569 'issue_url': cl.GetIssueURL(),
4570 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004571 return 0
4572
4573
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004574def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004575 """Shows or posts review comments for any changelist."""
4576 parser.add_option('-a', '--add-comment', dest='comment',
4577 help='comment to add to an issue')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004578 parser.add_option('-i', '--issue', dest='issue',
4579 help='review issue id (defaults to current issue). '
4580 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004581 parser.add_option('-m', '--machine-readable', dest='readable',
4582 action='store_false', default=True,
4583 help='output comments in a format compatible with '
4584 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004585 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004586 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004587 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004588 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004589 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004590 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004591 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004592
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004593 issue = None
4594 if options.issue:
4595 try:
4596 issue = int(options.issue)
4597 except ValueError:
4598 DieWithError('A review issue id is expected to be a number')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004599 if not options.forced_codereview:
4600 parser.error('--gerrit or --rietveld is required if --issue is specified')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004601
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004602 cl = Changelist(issue=issue,
Andrii Shyshkalov70909e12017-04-10 14:38:32 +02004603 codereview=options.forced_codereview,
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004604 auth_config=auth_config)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004605
4606 if options.comment:
4607 cl.AddComment(options.comment)
4608 return 0
4609
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004610 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4611 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004612 for comment in summary:
4613 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004614 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004615 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004616 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004617 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004618 color = Fore.MAGENTA
4619 else:
4620 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004621 print('\n%s%s %s%s\n%s' % (
4622 color,
4623 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4624 comment.sender,
4625 Fore.RESET,
4626 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4627
smut@google.comc85ac942015-09-15 16:34:43 +00004628 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004629 def pre_serialize(c):
4630 dct = c.__dict__.copy()
4631 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4632 return dct
smut@google.comc85ac942015-09-15 16:34:43 +00004633 with open(options.json_file, 'wb') as f:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004634 json.dump(map(pre_serialize, summary), f)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004635 return 0
4636
4637
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004638@subcommand.usage('[codereview url or issue id]')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004639def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004640 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004641 parser.add_option('-d', '--display', action='store_true',
4642 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004643 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004644 help='New description to set for this issue (- for stdin, '
4645 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004646 parser.add_option('-f', '--force', action='store_true',
4647 help='Delete any unpublished Gerrit edits for this issue '
4648 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004649
4650 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004651 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004652 options, args = parser.parse_args(args)
4653 _process_codereview_select_options(parser, options)
4654
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004655 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004656 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004657 target_issue_arg = ParseIssueNumberArgument(args[0],
4658 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004659 if not target_issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02004660 parser.error('invalid codereview url or CL id')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004661
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004662 auth_config = auth.extract_auth_config_from_options(options)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004663
martiniss6eda05f2016-06-30 10:18:35 -07004664 kwargs = {
4665 'auth_config': auth_config,
4666 'codereview': options.forced_codereview,
4667 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004668 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004669 if target_issue_arg:
4670 kwargs['issue'] = target_issue_arg.issue
4671 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004672 if target_issue_arg.codereview and not options.forced_codereview:
4673 detected_codereview_from_url = True
4674 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004675
4676 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004677 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004678 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004679 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004680
4681 if detected_codereview_from_url:
4682 logging.info('canonical issue/change URL: %s (type: %s)\n',
4683 cl.GetIssueURL(), target_issue_arg.codereview)
4684
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004685 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004686
smut@google.com34fb6b12015-07-13 20:03:26 +00004687 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004688 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004689 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004690
4691 if options.new_description:
4692 text = options.new_description
4693 if text == '-':
4694 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004695 elif text == '+':
4696 base_branch = cl.GetCommonAncestorWithUpstream()
4697 change = cl.GetChange(base_branch, None, local_description=True)
4698 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004699
4700 description.set_description(text)
4701 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004702 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004703
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004704 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004705 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004706 return 0
4707
4708
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004709def CreateDescriptionFromLog(args):
4710 """Pulls out the commit log to use as a base for the CL description."""
4711 log_args = []
4712 if len(args) == 1 and not args[0].endswith('.'):
4713 log_args = [args[0] + '..']
4714 elif len(args) == 1 and args[0].endswith('...'):
4715 log_args = [args[0][:-1]]
4716 elif len(args) == 2:
4717 log_args = [args[0] + '..' + args[1]]
4718 else:
4719 log_args = args[:] # Hope for the best!
maruel@chromium.org373af802012-05-25 21:07:33 +00004720 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004721
4722
thestig@chromium.org44202a22014-03-11 19:22:18 +00004723def CMDlint(parser, args):
4724 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004725 parser.add_option('--filter', action='append', metavar='-x,+y',
4726 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004727 auth.add_auth_options(parser)
4728 options, args = parser.parse_args(args)
4729 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004730
4731 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004732 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004733 try:
4734 import cpplint
4735 import cpplint_chromium
4736 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004737 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004738 return 1
4739
4740 # Change the current working directory before calling lint so that it
4741 # shows the correct base.
4742 previous_cwd = os.getcwd()
4743 os.chdir(settings.GetRoot())
4744 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004745 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004746 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4747 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004748 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004749 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004750 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004751
4752 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004753 command = args + files
4754 if options.filter:
4755 command = ['--filter=' + ','.join(options.filter)] + command
4756 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004757
4758 white_regex = re.compile(settings.GetLintRegex())
4759 black_regex = re.compile(settings.GetLintIgnoreRegex())
4760 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4761 for filename in filenames:
4762 if white_regex.match(filename):
4763 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004764 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004765 else:
4766 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4767 extra_check_functions)
4768 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004769 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004770 finally:
4771 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004772 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004773 if cpplint._cpplint_state.error_count != 0:
4774 return 1
4775 return 0
4776
4777
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004778def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004779 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004780 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004781 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004782 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004783 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004784 parser.add_option('--all', action='store_true',
4785 help='Run checks against all files, not just modified ones')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004786 auth.add_auth_options(parser)
4787 options, args = parser.parse_args(args)
4788 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004789
sbc@chromium.org71437c02015-04-09 19:29:40 +00004790 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004791 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004792 return 1
4793
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004794 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004795 if args:
4796 base_branch = args[0]
4797 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004798 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004799 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004800
Aaron Gable8076c282017-11-29 14:39:41 -08004801 if options.all:
4802 base_change = cl.GetChange(base_branch, None)
4803 files = [('M', f) for f in base_change.AllFiles()]
4804 change = presubmit_support.GitChange(
4805 base_change.Name(),
4806 base_change.FullDescriptionText(),
4807 base_change.RepositoryRoot(),
4808 files,
4809 base_change.issue,
4810 base_change.patchset,
4811 base_change.author_email,
4812 base_change._upstream)
4813 else:
4814 change = cl.GetChange(base_branch, None)
4815
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004816 cl.RunHook(
4817 committing=not options.upload,
4818 may_prompt=False,
4819 verbose=options.verbose,
Aaron Gable8076c282017-11-29 14:39:41 -08004820 change=change)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004821 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004822
4823
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004824def GenerateGerritChangeId(message):
4825 """Returns Ixxxxxx...xxx change id.
4826
4827 Works the same way as
4828 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4829 but can be called on demand on all platforms.
4830
4831 The basic idea is to generate git hash of a state of the tree, original commit
4832 message, author/committer info and timestamps.
4833 """
4834 lines = []
4835 tree_hash = RunGitSilent(['write-tree'])
4836 lines.append('tree %s' % tree_hash.strip())
4837 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4838 if code == 0:
4839 lines.append('parent %s' % parent.strip())
4840 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4841 lines.append('author %s' % author.strip())
4842 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4843 lines.append('committer %s' % committer.strip())
4844 lines.append('')
4845 # Note: Gerrit's commit-hook actually cleans message of some lines and
4846 # whitespace. This code is not doing this, but it clearly won't decrease
4847 # entropy.
4848 lines.append(message)
4849 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
4850 stdin='\n'.join(lines))
4851 return 'I%s' % change_hash.strip()
4852
4853
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004854def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004855 """Computes the remote branch ref to use for the CL.
4856
4857 Args:
4858 remote (str): The git remote for the CL.
4859 remote_branch (str): The git remote branch for the CL.
4860 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004861 """
4862 if not (remote and remote_branch):
4863 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004864
wittman@chromium.org455dc922015-01-26 20:15:50 +00004865 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004866 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004867 # refs, which are then translated into the remote full symbolic refs
4868 # below.
4869 if '/' not in target_branch:
4870 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4871 else:
4872 prefix_replacements = (
4873 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4874 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4875 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4876 )
4877 match = None
4878 for regex, replacement in prefix_replacements:
4879 match = re.search(regex, target_branch)
4880 if match:
4881 remote_branch = target_branch.replace(match.group(0), replacement)
4882 break
4883 if not match:
4884 # This is a branch path but not one we recognize; use as-is.
4885 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004886 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4887 # Handle the refs that need to land in different refs.
4888 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004889
wittman@chromium.org455dc922015-01-26 20:15:50 +00004890 # Create the true path to the remote branch.
4891 # Does the following translation:
4892 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4893 # * refs/remotes/origin/master -> refs/heads/master
4894 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4895 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4896 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4897 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4898 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4899 'refs/heads/')
4900 elif remote_branch.startswith('refs/remotes/branch-heads'):
4901 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004902
wittman@chromium.org455dc922015-01-26 20:15:50 +00004903 return remote_branch
4904
4905
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004906def cleanup_list(l):
4907 """Fixes a list so that comma separated items are put as individual items.
4908
4909 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4910 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4911 """
4912 items = sum((i.split(',') for i in l), [])
4913 stripped_items = (i.strip() for i in items)
4914 return sorted(filter(None, stripped_items))
4915
4916
Aaron Gable4db38df2017-11-03 14:59:07 -07004917@subcommand.usage('[flags]')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004918def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004919 """Uploads the current changelist to codereview.
4920
4921 Can skip dependency patchset uploads for a branch by running:
4922 git config branch.branch_name.skip-deps-uploads True
4923 To unset run:
4924 git config --unset branch.branch_name.skip-deps-uploads
4925 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004926
4927 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4928 a bug number, this bug number is automatically populated in the CL
4929 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004930
4931 If subject contains text in square brackets or has "<text>: " prefix, such
4932 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4933 [git-cl] add support for hashtags
4934 Foo bar: implement foo
4935 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004936 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004937 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4938 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004939 parser.add_option('--bypass-watchlists', action='store_true',
4940 dest='bypass_watchlists',
4941 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004942 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004943 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004944 parser.add_option('--message', '-m', dest='message',
4945 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004946 parser.add_option('-b', '--bug',
4947 help='pre-populate the bug number(s) for this issue. '
4948 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004949 parser.add_option('--message-file', dest='message_file',
4950 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004951 parser.add_option('--title', '-t', dest='title',
4952 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004953 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004954 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004955 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004956 parser.add_option('--tbrs',
4957 action='append', default=[],
4958 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004959 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004960 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004961 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004962 parser.add_option('--hashtag', dest='hashtags',
4963 action='append', default=[],
4964 help=('Gerrit hashtag for new CL; '
4965 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004966 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004967 help='send email to reviewer(s) and cc(s) immediately')
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004968 parser.add_option('--emulate_svn_auto_props',
4969 '--emulate-svn-auto-props',
4970 action="store_true",
ukai@chromium.orge8077812012-02-03 03:41:46 +00004971 dest="emulate_svn_auto_props",
4972 help="Emulate Subversion's auto properties feature.")
ukai@chromium.orge8077812012-02-03 03:41:46 +00004973 parser.add_option('-c', '--use-commit-queue', action='store_true',
Aaron Gableedbc4132017-09-11 13:22:28 -07004974 help='tell the commit queue to commit this patchset; '
4975 'implies --send-mail')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004976 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004977 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004978 metavar='TARGET',
4979 help='Apply CL to remote ref TARGET. ' +
4980 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004981 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004982 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00004983 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004984 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004985 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004986 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004987 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4988 const='TBR', help='add a set of OWNERS to TBR')
4989 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4990 const='R', help='add a set of OWNERS to R')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004991 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4992 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004993 help='Send the patchset to do a CQ dry run right after '
4994 'upload.')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004995 parser.add_option('--dependencies', action='store_true',
4996 help='Uploads CLs of all the local branches that depend on '
4997 'the current branch')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004998
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004999 # TODO: remove Rietveld flags
5000 parser.add_option('--private', action='store_true',
5001 help='set the review private (rietveld only)')
5002 parser.add_option('--email', default=None,
5003 help='email address to use to connect to Rietveld')
5004
rmistry@google.com2dd99862015-06-22 12:22:18 +00005005 orig_args = args
iannucci@chromium.org53937ba2012-10-02 18:20:43 +00005006 add_git_similarity(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005007 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005008 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005009 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005010 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005011 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005012
sbc@chromium.org71437c02015-04-09 19:29:40 +00005013 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00005014 return 1
5015
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005016 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07005017 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005018 options.cc = cleanup_list(options.cc)
5019
tandriib80458a2016-06-23 12:20:07 -07005020 if options.message_file:
5021 if options.message:
5022 parser.error('only one of --message and --message-file allowed.')
5023 options.message = gclient_utils.FileRead(options.message_file)
5024 options.message_file = None
5025
tandrii4d0545a2016-07-06 03:56:49 -07005026 if options.cq_dry_run and options.use_commit_queue:
5027 parser.error('only one of --use-commit-queue and --cq-dry-run allowed.')
5028
Aaron Gableedbc4132017-09-11 13:22:28 -07005029 if options.use_commit_queue:
5030 options.send_mail = True
5031
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00005032 # For sanity of test expectations, do this otherwise lazy-loading *now*.
5033 settings.GetIsGerrit()
5034
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005035 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00005036 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005037
5038
Francois Dorayd42c6812017-05-30 15:10:20 -04005039@subcommand.usage('--description=<description file>')
5040def CMDsplit(parser, args):
5041 """Splits a branch into smaller branches and uploads CLs.
5042
5043 Creates a branch and uploads a CL for each group of files modified in the
5044 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07005045 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04005046 the shared OWNERS file.
5047 """
5048 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05005049 help="A text file containing a CL description in which "
5050 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04005051 parser.add_option("-c", "--comment", dest="comment_file",
5052 help="A text file containing a CL comment.")
5053 options, _ = parser.parse_args(args)
5054
5055 if not options.description_file:
5056 parser.error('No --description flag specified.')
5057
5058 def WrappedCMDupload(args):
5059 return CMDupload(OptionParser(), args)
5060
5061 return split_cl.SplitCl(options.description_file, options.comment_file,
5062 Changelist, WrappedCMDupload)
5063
5064
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005065@subcommand.usage('DEPRECATED')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005066def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005067 """DEPRECATED: Used to commit the current changelist via git-svn."""
5068 message = ('git-cl no longer supports committing to SVN repositories via '
5069 'git-svn. You probably want to use `git cl land` instead.')
5070 print(message)
5071 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005072
5073
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005074# Two special branches used by git cl land.
5075MERGE_BRANCH = 'git-cl-commit'
5076CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
5077
5078
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005079@subcommand.usage('[upstream branch to apply against]')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00005080def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005081 """Commits the current changelist via git.
5082
5083 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
5084 upstream and closes the issue automatically and atomically.
5085
5086 Otherwise (in case of Rietveld):
5087 Squashes branch into a single commit.
5088 Updates commit message with metadata (e.g. pointer to review).
5089 Pushes the code upstream.
5090 Updates review and closes.
5091 """
5092 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
5093 help='bypass upload presubmit hook')
5094 parser.add_option('-m', dest='message',
5095 help="override review description")
Aaron Gablef7543cd2017-07-20 14:26:31 -07005096 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005097 help="force yes to questions (don't prompt)")
5098 parser.add_option('-c', dest='contributor',
5099 help="external contributor for patch (appended to " +
5100 "description and used as author for git). Should be " +
5101 "formatted as 'First Last <email@example.com>'")
5102 add_git_similarity(parser)
5103 auth.add_auth_options(parser)
5104 (options, args) = parser.parse_args(args)
5105 auth_config = auth.extract_auth_config_from_options(options)
5106
5107 cl = Changelist(auth_config=auth_config)
5108
5109 # TODO(tandrii): refactor this into _RietveldChangelistImpl method.
5110 if cl.IsGerrit():
5111 if options.message:
5112 # This could be implemented, but it requires sending a new patch to
5113 # Gerrit, as Gerrit unlike Rietveld versions messages with patchsets.
5114 # Besides, Gerrit has the ability to change the commit message on submit
5115 # automatically, thus there is no need to support this option (so far?).
5116 parser.error('-m MESSAGE option is not supported for Gerrit.')
5117 if options.contributor:
5118 parser.error(
5119 '-c CONTRIBUTOR option is not supported for Gerrit.\n'
5120 'Before uploading a commit to Gerrit, ensure it\'s author field is '
5121 'the contributor\'s "name <email>". If you can\'t upload such a '
5122 'commit for review, contact your repository admin and request'
5123 '"Forge-Author" permission.')
5124 if not cl.GetIssue():
5125 DieWithError('You must upload the change first to Gerrit.\n'
5126 ' If you would rather have `git cl land` upload '
5127 'automatically for you, see http://crbug.com/642759')
5128 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
5129 options.verbose)
5130
5131 current = cl.GetBranch()
5132 remote, upstream_branch = cl.FetchUpstreamTuple(cl.GetBranch())
5133 if remote == '.':
5134 print()
5135 print('Attempting to push branch %r into another local branch!' % current)
5136 print()
5137 print('Either reparent this branch on top of origin/master:')
5138 print(' git reparent-branch --root')
5139 print()
5140 print('OR run `git rebase-update` if you think the parent branch is ')
5141 print('already committed.')
5142 print()
5143 print(' Current parent: %r' % upstream_branch)
5144 return 1
5145
5146 if not args:
5147 # Default to merging against our best guess of the upstream branch.
5148 args = [cl.GetUpstreamBranch()]
5149
5150 if options.contributor:
5151 if not re.match('^.*\s<\S+@\S+>$', options.contributor):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07005152 print("Please provide contributor as 'First Last <email@example.com>'")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005153 return 1
5154
5155 base_branch = args[0]
5156
5157 if git_common.is_dirty_git_tree('land'):
5158 return 1
5159
5160 # This rev-list syntax means "show all commits not in my branch that
5161 # are in base_branch".
5162 upstream_commits = RunGit(['rev-list', '^' + cl.GetBranchRef(),
5163 base_branch]).splitlines()
5164 if upstream_commits:
5165 print('Base branch "%s" has %d commits '
5166 'not in this branch.' % (base_branch, len(upstream_commits)))
5167 print('Run "git merge %s" before attempting to land.' % base_branch)
5168 return 1
5169
5170 merge_base = RunGit(['merge-base', base_branch, 'HEAD']).strip()
5171 if not options.bypass_hooks:
5172 author = None
5173 if options.contributor:
5174 author = re.search(r'\<(.*)\>', options.contributor).group(1)
5175 hook_results = cl.RunHook(
5176 committing=True,
5177 may_prompt=not options.force,
5178 verbose=options.verbose,
5179 change=cl.GetChange(merge_base, author))
5180 if not hook_results.should_continue():
5181 return 1
5182
5183 # Check the tree status if the tree status URL is set.
5184 status = GetTreeStatus()
5185 if 'closed' == status:
5186 print('The tree is closed. Please wait for it to reopen. Use '
5187 '"git cl land --bypass-hooks" to commit on a closed tree.')
5188 return 1
5189 elif 'unknown' == status:
5190 print('Unable to determine tree status. Please verify manually and '
5191 'use "git cl land --bypass-hooks" to commit on a closed tree.')
5192 return 1
5193
5194 change_desc = ChangeDescription(options.message)
5195 if not change_desc.description and cl.GetIssue():
5196 change_desc = ChangeDescription(cl.GetDescription())
5197
5198 if not change_desc.description:
5199 if not cl.GetIssue() and options.bypass_hooks:
5200 change_desc = ChangeDescription(CreateDescriptionFromLog([merge_base]))
5201 else:
5202 print('No description set.')
5203 print('Visit %s/edit to set it.' % (cl.GetIssueURL()))
5204 return 1
5205
5206 # Keep a separate copy for the commit message, because the commit message
5207 # contains the link to the Rietveld issue, while the Rietveld message contains
5208 # the commit viewvc url.
5209 if cl.GetIssue():
Aaron Gablea1bab272017-04-11 16:38:18 -07005210 change_desc.update_reviewers(
Robert Iannucci6c98dc62017-04-18 11:38:00 -07005211 get_approving_reviewers(cl.GetIssueProperties()), [])
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005212
5213 commit_desc = ChangeDescription(change_desc.description)
5214 if cl.GetIssue():
5215 # Xcode won't linkify this URL unless there is a non-whitespace character
5216 # after it. Add a period on a new line to circumvent this. Also add a space
5217 # before the period to make sure that Gitiles continues to correctly resolve
5218 # the URL.
5219 commit_desc.append_footer('Review-Url: %s .' % cl.GetIssueURL())
5220 if options.contributor:
5221 commit_desc.append_footer('Patch from %s.' % options.contributor)
5222
5223 print('Description:')
5224 print(commit_desc.description)
5225
5226 branches = [merge_base, cl.GetBranchRef()]
5227 if not options.force:
5228 print_stats(options.similarity, options.find_copies, branches)
5229
5230 # We want to squash all this branch's commits into one commit with the proper
5231 # description. We do this by doing a "reset --soft" to the base branch (which
5232 # keeps the working copy the same), then landing that.
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005233 # Delete the special branches if they exist.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005234 for branch in [MERGE_BRANCH, CHERRY_PICK_BRANCH]:
5235 showref_cmd = ['show-ref', '--quiet', '--verify', 'refs/heads/%s' % branch]
5236 result = RunGitWithCode(showref_cmd)
5237 if result[0] == 0:
5238 RunGit(['branch', '-D', branch])
5239
5240 # We might be in a directory that's present in this branch but not in the
5241 # trunk. Move up to the top of the tree so that git commands that expect a
5242 # valid CWD won't fail after we check out the merge branch.
5243 rel_base_path = settings.GetRelativeRoot()
5244 if rel_base_path:
5245 os.chdir(rel_base_path)
5246
5247 # Stuff our change into the merge branch.
5248 # We wrap in a try...finally block so if anything goes wrong,
5249 # we clean up the branches.
5250 retcode = -1
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005251 revision = None
5252 try:
5253 RunGit(['checkout', '-q', '-b', MERGE_BRANCH])
5254 RunGit(['reset', '--soft', merge_base])
5255 if options.contributor:
5256 RunGit(
5257 [
5258 'commit', '--author', options.contributor,
5259 '-m', commit_desc.description,
5260 ])
5261 else:
5262 RunGit(['commit', '-m', commit_desc.description])
5263
5264 remote, branch = cl.FetchUpstreamTuple(cl.GetBranch())
5265 mirror = settings.GetGitMirror(remote)
5266 if mirror:
5267 pushurl = mirror.url
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01005268 git_numberer_enabled = _is_git_numberer_enabled(pushurl, branch)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005269 else:
5270 pushurl = remote # Usually, this is 'origin'.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01005271 git_numberer_enabled = _is_git_numberer_enabled(
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005272 RunGit(['config', 'remote.%s.url' % remote]).strip(), branch)
5273
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005274 retcode = PushToGitWithAutoRebase(
5275 pushurl, branch, commit_desc.description, git_numberer_enabled)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005276 if retcode == 0:
5277 revision = RunGit(['rev-parse', 'HEAD']).strip()
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005278 if git_numberer_enabled:
5279 change_desc = ChangeDescription(
5280 RunGit(['show', '-s', '--format=%B', 'HEAD']).strip())
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005281 except: # pylint: disable=bare-except
5282 if _IS_BEING_TESTED:
5283 logging.exception('this is likely your ACTUAL cause of test failure.\n'
5284 + '-' * 30 + '8<' + '-' * 30)
5285 logging.error('\n' + '-' * 30 + '8<' + '-' * 30 + '\n\n\n')
5286 raise
5287 finally:
5288 # And then swap back to the original branch and clean up.
5289 RunGit(['checkout', '-q', cl.GetBranch()])
5290 RunGit(['branch', '-D', MERGE_BRANCH])
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005291 RunGit(['branch', '-D', CHERRY_PICK_BRANCH], error_ok=True)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005292
5293 if not revision:
5294 print('Failed to push. If this persists, please file a bug.')
5295 return 1
5296
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005297 if cl.GetIssue():
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005298 viewvc_url = settings.GetViewVCUrl()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01005299 if viewvc_url and revision:
5300 change_desc.append_footer(
5301 'Committed: %s%s' % (viewvc_url, revision))
5302 elif revision:
5303 change_desc.append_footer('Committed: %s' % (revision,))
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005304 print('Closing issue '
5305 '(you may be prompted for your codereview password)...')
5306 cl.UpdateDescription(change_desc.description)
5307 cl.CloseIssue()
5308 props = cl.GetIssueProperties()
5309 patch_num = len(props['patchsets'])
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01005310 comment = "Committed patchset #%d (id:%d) manually as %s" % (
5311 patch_num, props['patchsets'][-1], revision)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005312 if options.bypass_hooks:
5313 comment += ' (tree was closed).' if GetTreeStatus() == 'closed' else '.'
5314 else:
5315 comment += ' (presubmit successful).'
5316 cl.RpcServer().add_comment(cl.GetIssue(), comment)
5317
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005318 if os.path.isfile(POSTUPSTREAM_HOOK):
5319 RunCommand([POSTUPSTREAM_HOOK, merge_base], error_ok=True)
5320
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01005321 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005322
5323
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005324def PushToGitWithAutoRebase(remote, branch, original_description,
5325 git_numberer_enabled, max_attempts=3):
5326 """Pushes current HEAD commit on top of remote's branch.
5327
5328 Attempts to fetch and autorebase on push failures.
5329 Adds git number footers on the fly.
5330
5331 Returns integer code from last command.
5332 """
5333 cherry = RunGit(['rev-parse', 'HEAD']).strip()
5334 code = 0
5335 attempts_left = max_attempts
5336 while attempts_left:
5337 attempts_left -= 1
5338 print('Attempt %d of %d' % (max_attempts - attempts_left, max_attempts))
5339
5340 # Fetch remote/branch into local cherry_pick_branch, overriding the latter.
5341 # If fetch fails, retry.
5342 print('Fetching %s/%s...' % (remote, branch))
5343 code, out = RunGitWithCode(
5344 ['retry', 'fetch', remote,
5345 '+%s:refs/heads/%s' % (branch, CHERRY_PICK_BRANCH)])
5346 if code:
5347 print('Fetch failed with exit code %d.' % code)
5348 print(out.strip())
5349 continue
5350
5351 print('Cherry-picking commit on top of latest %s' % branch)
5352 RunGitWithCode(['checkout', 'refs/heads/%s' % CHERRY_PICK_BRANCH],
5353 suppress_stderr=True)
5354 parent_hash = RunGit(['rev-parse', 'HEAD']).strip()
5355 code, out = RunGitWithCode(['cherry-pick', cherry])
5356 if code:
5357 print('Your patch doesn\'t apply cleanly to \'%s\' HEAD @ %s, '
5358 'the following files have merge conflicts:' %
5359 (branch, parent_hash))
5360 print(RunGit(['diff', '--name-status', '--diff-filter=U']).strip())
5361 print('Please rebase your patch and try again.')
5362 RunGitWithCode(['cherry-pick', '--abort'])
5363 break
5364
5365 commit_desc = ChangeDescription(original_description)
5366 if git_numberer_enabled:
5367 logging.debug('Adding git number footers')
5368 parent_msg = RunGit(['show', '-s', '--format=%B', parent_hash]).strip()
5369 commit_desc.update_with_git_number_footers(parent_hash, parent_msg,
5370 branch)
5371 # Ensure timestamps are monotonically increasing.
5372 timestamp = max(1 + _get_committer_timestamp(parent_hash),
5373 _get_committer_timestamp('HEAD'))
5374 _git_amend_head(commit_desc.description, timestamp)
5375
5376 code, out = RunGitWithCode(
5377 ['push', '--porcelain', remote, 'HEAD:%s' % branch])
5378 print(out)
5379 if code == 0:
5380 break
5381 if IsFatalPushFailure(out):
5382 print('Fatal push error. Make sure your .netrc credentials and git '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02005383 'user.email are correct and you have push access to the repo.\n'
5384 'Hint: run command below to diangose common Git/Gerrit credential '
5385 'problems:\n'
5386 ' git cl creds-check\n')
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005387 break
5388 return code
5389
5390
5391def IsFatalPushFailure(push_stdout):
5392 """True if retrying push won't help."""
5393 return '(prohibited by Gerrit)' in push_stdout
5394
5395
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005396@subcommand.usage('<patch url or issue id or issue url>')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005397def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00005398 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005399 parser.add_option('-b', dest='newbranch',
5400 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005401 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07005402 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005403 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07005404 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005405 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005406 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00005407 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005408 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005409 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005410 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005411
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005412
5413 group = optparse.OptionGroup(
5414 parser,
5415 'Options for continuing work on the current issue uploaded from a '
5416 'different clone (e.g. different machine). Must be used independently '
5417 'from the other options. No issue number should be specified, and the '
5418 'branch must have an issue number associated with it')
5419 group.add_option('--reapply', action='store_true', dest='reapply',
5420 help='Reset the branch and reapply the issue.\n'
5421 'CAUTION: This will undo any local changes in this '
5422 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005423
5424 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005425 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005426 parser.add_option_group(group)
5427
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005428 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005429 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005430 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005431 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005432 auth_config = auth.extract_auth_config_from_options(options)
5433
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005434 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005435 if options.newbranch:
5436 parser.error('--reapply works on the current branch only')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005437 if len(args) > 0:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005438 parser.error('--reapply implies no additional arguments')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005439
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005440 cl = Changelist(auth_config=auth_config,
5441 codereview=options.forced_codereview)
5442 if not cl.GetIssue():
5443 parser.error('current branch must have an associated issue')
5444
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005445 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005446 if upstream is None:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005447 parser.error('No upstream branch specified. Cannot reset branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005448
5449 RunGit(['reset', '--hard', upstream])
5450 if options.pull:
5451 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005452
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005453 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
5454 options.directory)
5455
5456 if len(args) != 1 or not args[0]:
5457 parser.error('Must specify issue number or url')
5458
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005459 target_issue_arg = ParseIssueNumberArgument(args[0],
5460 options.forced_codereview)
5461 if not target_issue_arg.valid:
5462 parser.error('invalid codereview url or CL id')
5463
5464 cl_kwargs = {
5465 'auth_config': auth_config,
5466 'codereview_host': target_issue_arg.hostname,
5467 'codereview': options.forced_codereview,
5468 }
5469 detected_codereview_from_url = False
5470 if target_issue_arg.codereview and not options.forced_codereview:
5471 detected_codereview_from_url = True
5472 cl_kwargs['codereview'] = target_issue_arg.codereview
5473 cl_kwargs['issue'] = target_issue_arg.issue
5474
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005475 # We don't want uncommitted changes mixed up with the patch.
5476 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005477 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005478
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005479 if options.newbranch:
5480 if options.force:
5481 RunGit(['branch', '-D', options.newbranch],
5482 stderr=subprocess2.PIPE, error_ok=True)
5483 RunGit(['new-branch', options.newbranch])
5484
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005485 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005486
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005487 if cl.IsGerrit():
5488 if options.reject:
5489 parser.error('--reject is not supported with Gerrit codereview.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005490 if options.directory:
5491 parser.error('--directory is not supported with Gerrit codereview.')
5492
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005493 if detected_codereview_from_url:
5494 print('canonical issue/change URL: %s (type: %s)\n' %
5495 (cl.GetIssueURL(), target_issue_arg.codereview))
5496
5497 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07005498 options.nocommit, options.directory,
5499 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005500
5501
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005502def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005503 """Fetches the tree status and returns either 'open', 'closed',
5504 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005505 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005506 if url:
5507 status = urllib2.urlopen(url).read().lower()
5508 if status.find('closed') != -1 or status == '0':
5509 return 'closed'
5510 elif status.find('open') != -1 or status == '1':
5511 return 'open'
5512 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005513 return 'unset'
5514
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005515
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005516def GetTreeStatusReason():
5517 """Fetches the tree status from a json url and returns the message
5518 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00005519 url = settings.GetTreeStatusUrl()
5520 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005521 connection = urllib2.urlopen(json_url)
5522 status = json.loads(connection.read())
5523 connection.close()
5524 return status['message']
5525
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005526
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005527def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005528 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005529 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005530 status = GetTreeStatus()
5531 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07005532 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005533 return 2
5534
vapiera7fbd5a2016-06-16 09:17:49 -07005535 print('The tree is %s' % status)
5536 print()
5537 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005538 if status != 'open':
5539 return 1
5540 return 0
5541
5542
maruel@chromium.org15192402012-09-06 12:38:29 +00005543def CMDtry(parser, args):
qyearsley1fdfcb62016-10-24 13:22:03 -07005544 """Triggers try jobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07005545 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00005546 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005547 '-b', '--bot', action='append',
5548 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
5549 'times to specify multiple builders. ex: '
5550 '"-b win_rel -b win_layout". See '
5551 'the try server waterfall for the builders name and the tests '
5552 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00005553 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07005554 '-B', '--bucket', default='',
5555 help=('Buildbucket bucket to send the try requests.'))
5556 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005557 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005558 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005559 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005560 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07005561 help='Revision to use for the try job; default: the revision will '
5562 'be determined by the try recipe that builder runs, which usually '
5563 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00005564 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005565 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07005566 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07005567 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00005568 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005569 '--project',
5570 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07005571 'in recipe to determine to which repository or directory to '
5572 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00005573 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005574 '-p', '--property', dest='properties', action='append', default=[],
5575 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07005576 'key2=value2 etc. The value will be treated as '
5577 'json if decodable, or as string otherwise. '
5578 'NOTE: using this may make your try job not usable for CQ, '
5579 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00005580 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005581 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5582 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005583 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005584 auth.add_auth_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00005585 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005586 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00005587
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005588 if options.master and options.master.startswith('luci.'):
5589 parser.error(
5590 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00005591 # Make sure that all properties are prop=value pairs.
5592 bad_params = [x for x in options.properties if '=' not in x]
5593 if bad_params:
5594 parser.error('Got properties with missing "=": %s' % bad_params)
5595
maruel@chromium.org15192402012-09-06 12:38:29 +00005596 if args:
5597 parser.error('Unknown arguments: %s' % args)
5598
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005599 cl = Changelist(auth_config=auth_config)
maruel@chromium.org15192402012-09-06 12:38:29 +00005600 if not cl.GetIssue():
5601 parser.error('Need to upload first')
5602
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01005603 if cl.IsGerrit():
5604 # HACK: warm up Gerrit change detail cache to save on RPCs.
5605 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
5606
tandriie113dfd2016-10-11 10:20:12 -07005607 error_message = cl.CannotTriggerTryJobReason()
5608 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07005609 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00005610
borenet6c0efe62016-10-19 08:13:29 -07005611 if options.bucket and options.master:
5612 parser.error('Only one of --bucket and --master may be used.')
5613
qyearsley1fdfcb62016-10-24 13:22:03 -07005614 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00005615
qyearsleydd49f942016-10-28 11:57:22 -07005616 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
5617 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07005618 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07005619 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07005620 print('git cl try with no bots now defaults to CQ dry run.')
5621 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
5622 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00005623
borenet6c0efe62016-10-19 08:13:29 -07005624 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005625 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07005626 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07005627 'of bot requires an initial job from a parent (usually a builder). '
5628 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07005629 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005630 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00005631
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00005632 patchset = cl.GetMostRecentPatchset()
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005633 # TODO(tandrii): Checking local patchset against remote patchset is only
5634 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5635 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandriide281ae2016-10-12 06:02:30 -07005636 print('Warning: Codereview server has newer patchsets (%s) than most '
5637 'recent upload from local checkout (%s). Did a previous upload '
5638 'fail?\n'
5639 'By default, git cl try uses the latest patchset from '
5640 'codereview, continuing to use patchset %s.\n' %
5641 (patchset, cl.GetPatchset(), patchset))
qyearsley1fdfcb62016-10-24 13:22:03 -07005642
tandrii568043b2016-10-11 07:49:18 -07005643 try:
borenet6c0efe62016-10-19 08:13:29 -07005644 _trigger_try_jobs(auth_config, cl, buckets, options, 'git_cl_try',
5645 patchset)
tandrii568043b2016-10-11 07:49:18 -07005646 except BuildbucketResponseException as ex:
5647 print('ERROR: %s' % ex)
5648 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00005649 return 0
5650
5651
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005652def CMDtry_results(parser, args):
tandrii1838bad2016-10-06 00:10:52 -07005653 """Prints info about try jobs associated with current CL."""
5654 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005655 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005656 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005657 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005658 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005659 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005660 '--color', action='store_true', default=setup_color.IS_TTY,
5661 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005662 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005663 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5664 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005665 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005666 '--json', help=('Path of JSON output file to write try job results to,'
5667 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005668 parser.add_option_group(group)
5669 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005670 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005671 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005672 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005673 if args:
5674 parser.error('Unrecognized args: %s' % ' '.join(args))
5675
5676 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005677 cl = Changelist(
5678 issue=options.issue, codereview=options.forced_codereview,
5679 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005680 if not cl.GetIssue():
5681 parser.error('Need to upload first')
5682
tandrii221ab252016-10-06 08:12:04 -07005683 patchset = options.patchset
5684 if not patchset:
5685 patchset = cl.GetMostRecentPatchset()
5686 if not patchset:
5687 parser.error('Codereview doesn\'t know about issue %s. '
5688 'No access to issue or wrong issue number?\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01005689 'Either upload first, or pass --patchset explicitly' %
tandrii221ab252016-10-06 08:12:04 -07005690 cl.GetIssue())
5691
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005692 # TODO(tandrii): Checking local patchset against remote patchset is only
5693 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5694 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandrii45b2a582016-10-11 03:14:16 -07005695 print('Warning: Codereview server has newer patchsets (%s) than most '
5696 'recent upload from local checkout (%s). Did a previous upload '
5697 'fail?\n'
tandriide281ae2016-10-12 06:02:30 -07005698 'By default, git cl try-results uses the latest patchset from '
5699 'codereview, continuing to use patchset %s.\n' %
tandrii45b2a582016-10-11 03:14:16 -07005700 (patchset, cl.GetPatchset(), patchset))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005701 try:
tandrii221ab252016-10-06 08:12:04 -07005702 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005703 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005704 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005705 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005706 if options.json:
5707 write_try_results_json(options.json, jobs)
5708 else:
5709 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005710 return 0
5711
5712
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005713@subcommand.usage('[new upstream branch]')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005714def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005715 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005716 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005717 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005718 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005719
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005720 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005721 if args:
5722 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005723 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005724 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005725 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005726 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005727
5728 # Clear configured merge-base, if there is one.
5729 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005730 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005731 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005732 return 0
5733
5734
thestig@chromium.org00858c82013-12-02 23:08:03 +00005735def CMDweb(parser, args):
5736 """Opens the current CL in the web browser."""
5737 _, args = parser.parse_args(args)
5738 if args:
5739 parser.error('Unrecognized args: %s' % ' '.join(args))
5740
5741 issue_url = Changelist().GetIssueURL()
5742 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005743 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005744 return 1
5745
5746 webbrowser.open(issue_url)
5747 return 0
5748
5749
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005750def CMDset_commit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005751 """Sets the commit bit to trigger the Commit Queue."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005752 parser.add_option('-d', '--dry-run', action='store_true',
5753 help='trigger in dry run mode')
5754 parser.add_option('-c', '--clear', action='store_true',
5755 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005756 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005757 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005758 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005759 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005760 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005761 if args:
5762 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005763 if options.dry_run and options.clear:
5764 parser.error('Make up your mind: both --dry-run and --clear not allowed')
5765
iannuccie53c9352016-08-17 14:40:40 -07005766 cl = Changelist(auth_config=auth_config, issue=options.issue,
5767 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005768 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005769 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005770 elif options.dry_run:
5771 state = _CQState.DRY_RUN
5772 else:
5773 state = _CQState.COMMIT
5774 if not cl.GetIssue():
5775 parser.error('Must upload the issue first')
tandrii9de9ec62016-07-13 03:01:59 -07005776 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005777 return 0
5778
5779
groby@chromium.org411034a2013-02-26 15:12:01 +00005780def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005781 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005782 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005783 auth.add_auth_options(parser)
5784 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005785 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005786 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005787 if args:
5788 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005789 cl = Changelist(auth_config=auth_config, issue=options.issue,
5790 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005791 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005792 if not cl.GetIssue():
5793 DieWithError('ERROR No issue to close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005794 cl.CloseIssue()
5795 return 0
5796
5797
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005798def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005799 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005800 parser.add_option(
5801 '--stat',
5802 action='store_true',
5803 dest='stat',
5804 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005805 auth.add_auth_options(parser)
5806 options, args = parser.parse_args(args)
5807 auth_config = auth.extract_auth_config_from_options(options)
5808 if args:
5809 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005810
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005811 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005812 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005813 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005814 if not issue:
5815 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005816
Aaron Gablea718c3e2017-08-28 17:47:28 -07005817 base = cl._GitGetBranchConfigValue('last-upload-hash')
5818 if not base:
5819 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5820 if not base:
5821 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5822 revision_info = detail['revisions'][detail['current_revision']]
5823 fetch_info = revision_info['fetch']['http']
5824 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5825 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005826
Aaron Gablea718c3e2017-08-28 17:47:28 -07005827 cmd = ['git', 'diff']
5828 if options.stat:
5829 cmd.append('--stat')
5830 cmd.append(base)
5831 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005832
5833 return 0
5834
5835
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005836def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005837 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005838 parser.add_option(
5839 '--no-color',
5840 action='store_true',
5841 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005842 parser.add_option(
5843 '--batch',
5844 action='store_true',
5845 help='Do not run interactively, just suggest some')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005846 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005847 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005848 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005849
5850 author = RunGit(['config', 'user.email']).strip() or None
5851
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005852 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005853
5854 if args:
5855 if len(args) > 1:
5856 parser.error('Unknown args')
5857 base_branch = args[0]
5858 else:
5859 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005860 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005861
5862 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005863 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5864
5865 if options.batch:
5866 db = owners.Database(change.RepositoryRoot(), file, os.path)
5867 print('\n'.join(db.reviewers_for(affected_files, author)))
5868 return 0
5869
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005870 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005871 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005872 change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02005873 author, fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005874 disable_color=options.no_color,
5875 override_files=change.OriginalOwnersFiles()).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005876
5877
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005878def BuildGitDiffCmd(diff_type, upstream_commit, args):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005879 """Generates a diff command."""
5880 # Generate diff for the current branch's changes.
5881 diff_cmd = ['diff', '--no-ext-diff', '--no-prefix', diff_type,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005882 upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005883
5884 if args:
5885 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005886 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005887 diff_cmd.append(arg)
5888 else:
5889 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005890
5891 return diff_cmd
5892
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005893
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005894def MatchingFileType(file_name, extensions):
5895 """Returns true if the file name ends with one of the given extensions."""
5896 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005897
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005898
enne@chromium.org555cfe42014-01-29 18:21:39 +00005899@subcommand.usage('[files or directories to diff]')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005900def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005901 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005902 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005903 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005904 parser.add_option('--full', action='store_true',
5905 help='Reformat the full content of all touched files')
5906 parser.add_option('--dry-run', action='store_true',
5907 help='Don\'t modify any file on disk.')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005908 parser.add_option('--python', action='store_true',
5909 help='Format python code with yapf (experimental).')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005910 parser.add_option('--js', action='store_true',
5911 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005912 parser.add_option('--diff', action='store_true',
5913 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005914 parser.add_option('--presubmit', action='store_true',
5915 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005916 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005917
Daniel Chengc55eecf2016-12-30 03:11:02 -08005918 # Normalize any remaining args against the current path, so paths relative to
5919 # the current directory are still resolved as expected.
5920 args = [os.path.join(os.getcwd(), arg) for arg in args]
5921
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005922 # git diff generates paths against the root of the repository. Change
5923 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005924 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005925 if rel_base_path:
5926 os.chdir(rel_base_path)
5927
digit@chromium.org29e47272013-05-17 17:01:46 +00005928 # Grab the merge-base commit, i.e. the upstream commit of the current
5929 # branch when it was created or the last time it was rebased. This is
5930 # to cover the case where the user may have called "git fetch origin",
5931 # moving the origin branch to a newer commit, but hasn't rebased yet.
5932 upstream_commit = None
5933 cl = Changelist()
5934 upstream_branch = cl.GetUpstreamBranch()
5935 if upstream_branch:
5936 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5937 upstream_commit = upstream_commit.strip()
5938
5939 if not upstream_commit:
5940 DieWithError('Could not find base commit for this branch. '
5941 'Are you in detached state?')
5942
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005943 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5944 diff_output = RunGit(changed_files_cmd)
5945 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005946 # Filter out files deleted by this CL
5947 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005948
Christopher Lamc5ba6922017-01-24 11:19:14 +11005949 if opts.js:
5950 CLANG_EXTS.append('.js')
5951
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005952 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5953 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5954 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005955 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005956
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005957 top_dir = os.path.normpath(
5958 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5959
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005960 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5961 # formatted. This is used to block during the presubmit.
5962 return_value = 0
5963
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005964 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005965 # Locate the clang-format binary in the checkout
5966 try:
5967 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005968 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005969 DieWithError(e)
5970
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005971 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005972 cmd = [clang_format_tool]
5973 if not opts.dry_run and not opts.diff:
5974 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005975 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005976 if opts.diff:
5977 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005978 else:
5979 env = os.environ.copy()
5980 env['PATH'] = str(os.path.dirname(clang_format_tool))
5981 try:
5982 script = clang_format.FindClangFormatScriptInChromiumTree(
5983 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005984 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005985 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005986
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005987 cmd = [sys.executable, script, '-p0']
5988 if not opts.dry_run and not opts.diff:
5989 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005990
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005991 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5992 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005993
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005994 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5995 if opts.diff:
5996 sys.stdout.write(stdout)
5997 if opts.dry_run and len(stdout) > 0:
5998 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005999
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00006000 # Similar code to above, but using yapf on .py files rather than clang-format
6001 # on C/C++ files
6002 if opts.python:
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00006003 yapf_tool = gclient_utils.FindExecutable('yapf')
6004 if yapf_tool is None:
6005 DieWithError('yapf not found in PATH')
6006
6007 if opts.full:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00006008 if python_diff_files:
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00006009 cmd = [yapf_tool]
6010 if not opts.dry_run and not opts.diff:
6011 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00006012 stdout = RunCommand(cmd + python_diff_files, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00006013 if opts.diff:
6014 sys.stdout.write(stdout)
6015 else:
6016 # TODO(sbc): yapf --lines mode still has some issues.
6017 # https://github.com/google/yapf/issues/154
6018 DieWithError('--python currently only works with --full')
6019
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00006020 # Dart's formatter does not have the nice property of only operating on
6021 # modified chunks, so hard code full.
6022 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006023 try:
6024 command = [dart_format.FindDartFmtToolInChromiumTree()]
6025 if not opts.dry_run and not opts.diff:
6026 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00006027 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006028
ppi@chromium.org6593d932016-03-03 15:41:15 +00006029 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006030 if opts.dry_run and stdout:
6031 return_value = 2
6032 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07006033 print('Warning: Unable to check Dart code formatting. Dart SDK not '
6034 'found in this checkout. Files in other languages are still '
6035 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006036
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00006037 # Format GN build files. Always run on full build files for canonical form.
6038 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01006039 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07006040 if opts.dry_run or opts.diff:
6041 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00006042 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07006043 gn_ret = subprocess2.call(cmd + [gn_diff_file],
6044 shell=sys.platform == 'win32',
6045 cwd=top_dir)
6046 if opts.dry_run and gn_ret == 2:
6047 return_value = 2 # Not formatted.
6048 elif opts.diff and gn_ret == 2:
6049 # TODO this should compute and print the actual diff.
6050 print("This change has GN build file diff for " + gn_diff_file)
6051 elif gn_ret != 0:
6052 # For non-dry run cases (and non-2 return values for dry-run), a
6053 # nonzero error code indicates a failure, probably because the file
6054 # doesn't parse.
6055 DieWithError("gn format failed on " + gn_diff_file +
6056 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00006057
Ilya Shermane081cbe2017-08-15 17:51:04 -07006058 # Skip the metrics formatting from the global presubmit hook. These files have
6059 # a separate presubmit hook that issues an error if the files need formatting,
6060 # whereas the top-level presubmit script merely issues a warning. Formatting
6061 # these files is somewhat slow, so it's important not to duplicate the work.
6062 if not opts.presubmit:
6063 for xml_dir in GetDirtyMetricsDirs(diff_files):
6064 tool_dir = os.path.join(top_dir, xml_dir)
6065 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
6066 if opts.dry_run or opts.diff:
6067 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07006068 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07006069 if opts.diff:
6070 sys.stdout.write(stdout)
6071 if opts.dry_run and stdout:
6072 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05006073
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006074 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00006075
Steven Holte2e664bf2017-04-21 13:10:47 -07006076def GetDirtyMetricsDirs(diff_files):
6077 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
6078 metrics_xml_dirs = [
6079 os.path.join('tools', 'metrics', 'actions'),
6080 os.path.join('tools', 'metrics', 'histograms'),
6081 os.path.join('tools', 'metrics', 'rappor'),
6082 os.path.join('tools', 'metrics', 'ukm')]
6083 for xml_dir in metrics_xml_dirs:
6084 if any(file.startswith(xml_dir) for file in xml_diff_files):
6085 yield xml_dir
6086
agable@chromium.orgfab8f822013-05-06 17:43:09 +00006087
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006088@subcommand.usage('<codereview url or issue id>')
6089def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00006090 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006091 _, args = parser.parse_args(args)
6092
6093 if len(args) != 1:
6094 parser.print_help()
6095 return 1
6096
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00006097 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00006098 if not issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02006099 parser.error('invalid codereview url or CL id')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02006100
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00006101 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006102
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00006103 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00006104 output = RunGit(['config', '--local', '--get-regexp',
6105 r'branch\..*\.%s' % issueprefix],
6106 error_ok=True)
6107 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00006108 if issue == target_issue:
6109 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006110
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00006111 branches = []
6112 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07006113 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006114 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07006115 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006116 return 1
6117 if len(branches) == 1:
6118 RunGit(['checkout', branches[0]])
6119 else:
vapiera7fbd5a2016-06-16 09:17:49 -07006120 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006121 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07006122 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006123 which = raw_input('Choose by index: ')
6124 try:
6125 RunGit(['checkout', branches[int(which)]])
6126 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07006127 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006128 return 1
6129
6130 return 0
6131
6132
maruel@chromium.org29404b52014-09-08 22:58:00 +00006133def CMDlol(parser, args):
6134 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07006135 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00006136 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
6137 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
6138 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07006139 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00006140 return 0
6141
6142
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006143class OptionParser(optparse.OptionParser):
6144 """Creates the option parse and add --verbose support."""
6145 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006146 optparse.OptionParser.__init__(
6147 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006148 self.add_option(
6149 '-v', '--verbose', action='count', default=0,
6150 help='Use 2 times for more debugging info')
6151
6152 def parse_args(self, args=None, values=None):
6153 options, args = optparse.OptionParser.parse_args(self, args, values)
6154 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01006155 logging.basicConfig(
6156 level=levels[min(options.verbose, len(levels) - 1)],
6157 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
6158 '%(filename)s] %(message)s')
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006159 return options, args
6160
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006161
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006162def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006163 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07006164 print('\nYour python version %s is unsupported, please upgrade.\n' %
6165 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006166 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006167
maruel@chromium.orgddd59412011-11-30 14:20:38 +00006168 # Reload settings.
6169 global settings
6170 settings = Settings()
6171
maruel@chromium.org39c0b222013-08-17 16:57:01 +00006172 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006173 dispatcher = subcommand.CommandDispatcher(__name__)
6174 try:
6175 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00006176 except auth.AuthenticationError as e:
6177 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07006178 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006179 if e.code != 500:
6180 raise
6181 DieWithError(
6182 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
6183 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00006184 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006185
6186
6187if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006188 # These affect sys.stdout so do it outside of main() to simplify mocks in
6189 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00006190 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00006191 setup_color.init()
sbc@chromium.org013731e2015-02-26 18:28:43 +00006192 try:
6193 sys.exit(main(sys.argv[1:]))
6194 except KeyboardInterrupt:
6195 sys.stderr.write('interrupted\n')
6196 sys.exit(1)