blob: ce8d0fab02ce7d1832b84e1d980dc8800ce3b139 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
asapersson35151f32016-05-02 23:44:01 -0700143class MockSendPacketObserver : public SendPacketObserver {
144 public:
145 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
146};
147
Stefan Holmera246cfb2016-08-23 17:51:42 +0200148class MockTransportFeedbackObserver : public TransportFeedbackObserver {
149 public:
elad.alond12a8e12017-03-23 11:04:48 -0700150 MOCK_METHOD4(AddPacket,
151 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200152 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800153 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200154};
155
minyue3a407ee2017-04-03 01:10:33 -0700156class MockOverheadObserver : public OverheadObserver {
157 public:
158 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
159};
160
161class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000162 protected:
163 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000164 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800165 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000166 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700167 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000168 rtp_sender_(),
169 payload_(kPayload),
170 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700171 kMarkerBit(true),
172 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
173 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000174
Erik Språng7b52f102018-02-07 14:37:37 +0100175 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200176
Erik Språng7b52f102018-02-07 14:37:37 +0100177 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700178 rtp_sender_.reset(new RTPSender(
179 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800180 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700181 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100182 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800183 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700184 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800185 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000186 }
187
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000188 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700189 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700190 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700191 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
192 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200193 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700194 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700195 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000196 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000197 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000198 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700199 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000200
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000201 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800202 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000203 }
204
205 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800206 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
207 }
208
209 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
210 bool marker_bit,
211 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000212 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000213 EXPECT_EQ(payload_, rtp_header.payloadType);
214 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
215 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
216 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800217 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000218 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000219 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000220
danilchapb6f1fb52016-10-19 06:11:39 -0700221 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
222 bool marker_bit,
223 uint32_t timestamp,
224 int64_t capture_time_ms) {
225 auto packet = rtp_sender_->AllocatePacket();
226 packet->SetPayloadType(payload_type);
227 packet->SetMarker(marker_bit);
228 packet->SetTimestamp(timestamp);
229 packet->set_capture_time_ms(capture_time_ms);
230 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
231 return packet;
232 }
233
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000234 void SendPacket(int64_t capture_time_ms, int payload_length) {
235 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700236 auto packet =
237 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
238 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000239
240 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700241 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
242 kAllowRetransmission,
243 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000244 }
asapersson35151f32016-05-02 23:44:01 -0700245
246 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700247 const uint32_t kTimestamp = 1234;
248 const uint8_t kPayloadType = 127;
249 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
250 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
251 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
252 0, 1500));
253
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200254 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700255 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200256 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200257 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700258 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700259 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000260};
261
Peter Boströme23e7372015-10-08 11:44:14 +0200262// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
263// default code path.
264class RtpSenderTestWithoutPacer : public RtpSenderTest {
265 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100266 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200267};
268
spranga8ae6f22017-09-04 07:23:56 -0700269class TestRtpSenderVideo : public RTPSenderVideo {
270 public:
271 TestRtpSenderVideo(Clock* clock,
272 RTPSender* rtp_sender,
273 FlexfecSender* flexfec_sender)
274 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
275 ~TestRtpSenderVideo() override {}
276
277 StorageType GetStorageType(const RTPVideoHeader& header,
278 int32_t retransmission_settings,
279 int64_t expected_retransmission_time_ms) {
280 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
281 retransmission_settings,
282 expected_retransmission_time_ms);
283 }
284};
285
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000286class RtpSenderVideoTest : public RtpSenderTest {
287 protected:
danilchap162abd32015-12-10 02:39:40 -0800288 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200289 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100290 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000291 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700292 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000293 }
spranga8ae6f22017-09-04 07:23:56 -0700294 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000295};
296
minyue3a407ee2017-04-03 01:10:33 -0700297TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200298 // Configure rtp_sender with csrc.
299 std::vector<uint32_t> csrcs;
300 csrcs.push_back(0x23456789);
301 rtp_sender_->SetCsrcs(csrcs);
302
303 auto packet = rtp_sender_->AllocatePacket();
304
305 ASSERT_TRUE(packet);
306 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
307 EXPECT_EQ(csrcs, packet->Csrcs());
308}
309
minyue3a407ee2017-04-03 01:10:33 -0700310TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200311 // Configure rtp_sender with extensions.
312 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
313 kRtpExtensionTransmissionTimeOffset,
314 kTransmissionTimeOffsetExtensionId));
315 ASSERT_EQ(
316 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
317 kAbsoluteSendTimeExtensionId));
318 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
319 kAudioLevelExtensionId));
320 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
321 kRtpExtensionTransportSequenceNumber,
322 kTransportSequenceNumberExtensionId));
323 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
324 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
325
326 auto packet = rtp_sender_->AllocatePacket();
327
328 ASSERT_TRUE(packet);
329 // Preallocate BWE extensions RtpSender set itself.
330 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
331 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
332 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
333 // Do not allocate media specific extensions.
334 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
335 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
336}
337
minyue3a407ee2017-04-03 01:10:33 -0700338TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200339 auto packet = rtp_sender_->AllocatePacket();
340 ASSERT_TRUE(packet);
341 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
342
343 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
344
345 EXPECT_EQ(sequence_number, packet->SequenceNumber());
346 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
347}
348
minyue3a407ee2017-04-03 01:10:33 -0700349TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200350 auto packet = rtp_sender_->AllocatePacket();
351 ASSERT_TRUE(packet);
352
353 rtp_sender_->SetSendingMediaStatus(false);
354 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
355}
356
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100357TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200358 constexpr size_t kPaddingSize = 100;
359 auto packet = rtp_sender_->AllocatePacket();
360 ASSERT_TRUE(packet);
361
philipel8aadd502017-02-23 02:56:13 -0800362 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200363 packet->SetMarker(false);
364 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100365 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800366 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200367
368 packet->SetMarker(true);
369 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
370 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800371 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200372}
373
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100374TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
375 MockTransport transport;
376 const bool kEnableAudio = true;
377 rtp_sender_.reset(new RTPSender(
378 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
379 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
380 nullptr, &retransmission_rate_limiter_, nullptr, false));
381 rtp_sender_->SetTimestampOffset(0);
382 rtp_sender_->SetSSRC(kSsrc);
383
384 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
385 // Padding on audio stream allowed regardless of marker in the last packet.
386 audio_packet->SetMarker(false);
387 audio_packet->SetPayloadType(kPayload);
388 rtp_sender_->AssignSequenceNumber(audio_packet.get());
389
390 const size_t kPaddingSize = 59;
391 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
392 .WillOnce(testing::Return(true));
393 EXPECT_EQ(kPaddingSize,
394 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
395
396 // Requested padding size is too small, will send a larger one.
397 const size_t kMinPaddingSize = 50;
398 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
399 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200400 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
401 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100402}
403
minyue3a407ee2017-04-03 01:10:33 -0700404TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200405 constexpr size_t kPaddingSize = 100;
406 auto packet = rtp_sender_->AllocatePacket();
407 ASSERT_TRUE(packet);
408 packet->SetMarker(true);
409 packet->SetTimestamp(kTimestamp);
410
411 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800412 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200413
414 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700415 // Verify padding packet timestamp.
416 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200417}
418
minyue3a407ee2017-04-03 01:10:33 -0700419TEST_P(RtpSenderTestWithoutPacer,
420 TransportFeedbackObserverGetsCorrectByteCount) {
421 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
422 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
423 rtp_sender_.reset(new RTPSender(
424 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
425 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100426 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700427 rtp_sender_->SetSSRC(kSsrc);
428 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
429 kRtpExtensionTransportSequenceNumber,
430 kTransportSequenceNumberExtensionId));
431 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
432 .WillOnce(testing::Return(kTransportSequenceNumber));
433
434 const size_t expected_bytes =
435 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
436 kRtpOverheadBytesPerPacket
437 : sizeof(kPayloadData) + kGenericHeaderLength;
438
439 EXPECT_CALL(feedback_observer_,
440 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
441 expected_bytes, PacedPacketInfo()))
442 .Times(1);
443 EXPECT_CALL(mock_overhead_observer,
444 OnOverheadChanged(kRtpOverheadBytesPerPacket))
445 .Times(1);
446 SendGenericPayload();
447}
448
449TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200450 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800451 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
452 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100453 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800454 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100455 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
456 kRtpExtensionTransportSequenceNumber,
457 kTransportSequenceNumberExtensionId));
458
Stefan Holmerf5dca482016-01-27 12:58:51 +0100459 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
460 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700461 EXPECT_CALL(send_packet_observer_,
462 OnSendPacket(kTransportSequenceNumber, _, _))
463 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700464
465 EXPECT_CALL(feedback_observer_,
466 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
467 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200468 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700469
470 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100471
danilchap12ba1862016-10-26 02:41:55 -0700472 const auto& packet = transport_.last_sent_packet();
473 uint16_t transport_seq_no;
474 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
475 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200476 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
477}
478
479TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
480 rtp_sender_.reset(new RTPSender(
481 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
482 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
483 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
484 rtp_sender_->SetSSRC(kSsrc);
485
486 SendGenericPayload();
487
488 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100489}
490
minyue3a407ee2017-04-03 01:10:33 -0700491TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700492 SendGenericPayload();
493}
asapersson35151f32016-05-02 23:44:01 -0700494
minyue3a407ee2017-04-03 01:10:33 -0700495TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700496 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
497 kRtpExtensionTransportSequenceNumber,
498 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700499 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
500 .WillOnce(testing::Return(kTransportSequenceNumber));
501 EXPECT_CALL(send_packet_observer_,
502 OnSendPacket(kTransportSequenceNumber, _, _))
503 .Times(1);
504
505 SendGenericPayload();
506}
507
minyue3a407ee2017-04-03 01:10:33 -0700508TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800509 rtp_sender_.reset(new RTPSender(
510 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
511 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
512 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100513 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800514 rtp_sender_->SetSequenceNumber(kSeqNum);
515 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200516 rtp_sender_->SetStorePacketsStatus(true, 10);
517 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
518 kRtpExtensionTransportSequenceNumber,
519 kTransportSequenceNumberExtensionId));
520
brandtr9dfff292016-11-14 05:14:50 -0800521 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200522 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
523 .WillOnce(testing::Return(kTransportSequenceNumber));
524 EXPECT_CALL(send_packet_observer_,
525 OnSendPacket(kTransportSequenceNumber, _, _))
526 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700527 EXPECT_CALL(feedback_observer_,
528 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
529 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200530 .Times(1);
531
532 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800533 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
534 fake_clock_.TimeInMilliseconds(), false,
535 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200536
danilchap12ba1862016-10-26 02:41:55 -0700537 const auto& packet = transport_.last_sent_packet();
538 uint16_t transport_seq_no;
539 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
540 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200541 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200542}
543
Erik Språng7b52f102018-02-07 14:37:37 +0100544TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700545 rtp_sender_->SetStorePacketsStatus(true, 10);
546 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
547 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
548 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
549 auto packet = rtp_sender_->AllocatePacket();
550 packet->SetPayloadType(kPayload);
551 packet->SetMarker(true);
552 packet->SetTimestamp(kTimestamp);
553 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700554 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700555 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
556 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
557 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700558
559 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100560 {
561 EXPECT_CALL(
562 mock_paced_sender_,
563 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
564 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
565 kAllowRetransmission,
566 RtpPacketSender::kNormalPriority));
567 }
ilnik04f4d122017-06-19 07:18:55 -0700568 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100569 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
570 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700571 EXPECT_EQ(1, transport_.packets_sent());
572 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
573
danilchapce251812017-09-11 12:24:41 -0700574 VideoSendTiming video_timing;
575 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
576 &video_timing));
577 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100578}
ilnik04f4d122017-06-19 07:18:55 -0700579
Erik Språng7b52f102018-02-07 14:37:37 +0100580TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
581 SetUpRtpSender(true, true);
582 rtp_sender_->SetStorePacketsStatus(true, 10);
583 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
584 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
585 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
586 auto packet = rtp_sender_->AllocatePacket();
587 packet->SetPayloadType(kPayload);
588 packet->SetMarker(true);
589 packet->SetTimestamp(kTimestamp);
590 packet->set_capture_time_ms(capture_time_ms);
591 const uint16_t kPacerExitMs = 1234u;
592 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
593 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
594 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
595 size_t packet_size = packet->size();
596
597 const int kStoredTimeInMs = 100;
598 {
599 EXPECT_CALL(
600 mock_paced_sender_,
601 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
602 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
603 kAllowRetransmission,
604 RtpPacketSender::kNormalPriority));
605 }
ilnik04f4d122017-06-19 07:18:55 -0700606 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
607 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
608 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100609 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700610 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
611
Erik Språng7b52f102018-02-07 14:37:37 +0100612 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700613 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
614 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100615 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
616 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700617}
618
minyue3a407ee2017-04-03 01:10:33 -0700619TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200620 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800621 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200622 EXPECT_CALL(mock_rtc_event_log_,
623 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000624
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000625 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000626 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800627 kRtpExtensionTransmissionTimeOffset,
628 kTransmissionTimeOffsetExtensionId));
629 EXPECT_EQ(
630 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
631 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000632 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700633 auto packet =
634 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
635 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000636
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000637 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700638 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
639 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700640 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000641
danilchap12ba1862016-10-26 02:41:55 -0700642 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000643
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000644 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000645 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000646
brandtr9dfff292016-11-14 05:14:50 -0800647 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800648 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000649
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000650 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700651 EXPECT_EQ(1, transport_.packets_sent());
652 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
653
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000654 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700655 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000656
657 // Verify transmission time offset.
658 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000659 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000660 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000661 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000662}
663
minyue3a407ee2017-04-03 01:10:33 -0700664TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200665 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800666 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200667 EXPECT_CALL(mock_rtc_event_log_,
668 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000669
670 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000671 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800672 kRtpExtensionTransmissionTimeOffset,
673 kTransmissionTimeOffsetExtensionId));
674 EXPECT_EQ(
675 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
676 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000677 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700678 auto packet =
679 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
680 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000681
682 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700683 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
684 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700685 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000686
danilchap12ba1862016-10-26 02:41:55 -0700687 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000688
terelius5d332ac2016-01-14 14:37:39 -0800689 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800690 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000691
692 const int kStoredTimeInMs = 100;
693 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
694
danilchapb6f1fb52016-10-19 06:11:39 -0700695 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700696 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000697
brandtr9dfff292016-11-14 05:14:50 -0800698 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800699 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000700
701 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700702 EXPECT_EQ(1, transport_.packets_sent());
703 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000704
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000705 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700706 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000707
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000708 // Verify transmission time offset.
709 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000710 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000711 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
712 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
713}
714
715// This test sends 1 regular video packet, then 4 padding packets, and then
716// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700717TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000718 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800719 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800720 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200721 EXPECT_CALL(mock_rtc_event_log_,
722 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
723 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000724
725 uint16_t seq_num = kSeqNum;
726 uint32_t timestamp = kTimestamp;
727 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000728 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000729 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800730 kRtpExtensionTransmissionTimeOffset,
731 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000732 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800733 EXPECT_EQ(
734 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
735 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000736 rtp_header_len += 4; // 4 bytes extension.
737 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
738
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000739 webrtc::RTPHeader rtp_header;
740
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000741 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700742 auto packet =
743 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200744 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700745 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000746
747 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700748 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
749 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700750 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000751
752 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700753 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000754
755 const int kStoredTimeInMs = 100;
756 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800757 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800758 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000759 // Packet should now be sent. This test doesn't verify the regular video
760 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700761 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000762 timestamp += 90 * kStoredTimeInMs;
763
764 // Send padding 4 times, waiting 50 ms between each.
765 for (int i = 0; i < 4; ++i) {
766 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000767 const size_t kPaddingBytes = 100;
768 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000769 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800770 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800771 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000772
773 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700774 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000775 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700776 transport_.last_sent_packet().size());
777
778 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700779 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000780
Stefan Holmer586b19b2015-09-18 11:14:31 +0200781 // Verify sequence number and timestamp. The timestamp should be the same
782 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000783 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200784 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000785 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200786 int offset = timestamp - media_packet_timestamp;
787 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000788 uint64_t expected_send_time =
789 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
790 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
791 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
792 timestamp += 90 * kPaddingPeriodMs;
793 }
794
795 // Send a regular video packet again.
796 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700797 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
798 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000799
brandtr9dfff292016-11-14 05:14:50 -0800800 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
801 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800802
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000803 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700804 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
805 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700806 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000807
brandtr9dfff292016-11-14 05:14:50 -0800808 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800809 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000810 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700811 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
812 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
813 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000814
815 // Verify sequence number and timestamp.
816 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
817 EXPECT_EQ(timestamp, rtp_header.timestamp);
818 // Verify transmission time offset. This packet is sent without delay.
819 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
820 uint64_t expected_send_time =
821 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000822 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000823}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000824
minyue3a407ee2017-04-03 01:10:33 -0700825TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700826 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
827 kRtpExtensionTransportSequenceNumber,
828 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700829 rtp_sender_->SetStorePacketsStatus(true, 10);
830
831 EXPECT_CALL(send_packet_observer_,
832 OnSendPacket(kTransportSequenceNumber, _, _))
833 .Times(1);
834 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
835 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800836 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
837 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700838
839 SendGenericPayload(); // Packet passed to pacer.
840 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800841 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
842 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800843 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700844 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700845}
846
minyue3a407ee2017-04-03 01:10:33 -0700847TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700848 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
849 kRtpExtensionTransportSequenceNumber,
850 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700851 rtp_sender_->SetStorePacketsStatus(true, 10);
852
853 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
854 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
855 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800856 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
857 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700858
859 SendGenericPayload(); // Packet passed to pacer.
860 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800861 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
862 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800863 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700864 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200865 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700866}
867
minyue3a407ee2017-04-03 01:10:33 -0700868TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700869 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800870 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700871 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800872 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100873 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800874 rtp_sender_->SetSequenceNumber(kSeqNum);
875 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700876 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
877 kRtpExtensionTransportSequenceNumber,
878 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700879 rtp_sender_->SetSequenceNumber(kSeqNum);
880 rtp_sender_->SetStorePacketsStatus(true, 10);
881
882 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800883 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
884 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700885
886 SendGenericPayload(); // Packet passed to pacer.
887 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800888 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
889 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800890 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700891 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700892}
893
minyue3a407ee2017-04-03 01:10:33 -0700894TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000895 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800896 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700897 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800898 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100899 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000900 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800901 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800902 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000903
904 uint16_t seq_num = kSeqNum;
905 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000906 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800907 EXPECT_EQ(
908 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
909 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000910 rtp_header_len += 4; // 4 bytes extension.
911 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
912
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000913 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000914 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000915
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000916 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800917 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
918 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800919 // Expect all packets go through the pacer.
920 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800921 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800922 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200923 EXPECT_CALL(mock_rtc_event_log_,
924 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800925 .Times(kNumPayloadSizes);
926
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000927 // Send 10 packets of increasing size.
928 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
929 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700930 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000931 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800932 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800933 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000934 fake_clock_.AdvanceTimeMilliseconds(33);
935 }
terelius429c3452016-01-21 05:42:04 -0800936
Elad Alon4a87e1c2017-10-03 16:11:34 +0200937 EXPECT_CALL(mock_rtc_event_log_,
938 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800939 .Times(::testing::AtLeast(4));
940
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000941 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700942 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700943 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700944 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800945 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000946
Petter Strandmark26bc6692018-05-29 08:43:35 +0200947 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +0200948 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700949 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200950 .WillOnce(
951 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -0700952 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800953 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200954 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000955
Yves Gerey665174f2018-06-19 15:03:05 +0200956 EXPECT_CALL(transport, SendRtp(_,
957 kPayloadSizes[kNumPayloadSizes - 1] +
958 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -0700959 _))
pbos2d566682015-09-28 09:59:31 -0700960 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200961
962 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -0700963 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200964 .WillOnce(
965 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000966 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800967 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200968 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000969}
970
minyue3a407ee2017-04-03 01:10:33 -0700971TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000972 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
973 const uint8_t payload_type = 127;
974 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
975 0, 1500));
976 uint8_t payload[] = {47, 11, 32, 93, 89};
977
978 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200979 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -0700980 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
981 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200982 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000983
danilchap96c15872016-11-21 01:35:29 -0800984 auto sent_payload = transport_.last_sent_packet().payload();
985 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000986 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
987 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800988 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000989
990 // Send delta frame
991 payload[0] = 13;
992 payload[1] = 42;
993 payload[4] = 13;
994
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700995 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
996 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200997 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000998
danilchap96c15872016-11-21 01:35:29 -0800999 sent_payload = transport_.last_sent_packet().payload();
1000 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001001 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1002 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001003 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001004}
1005
minyue3a407ee2017-04-03 01:10:33 -07001006TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001007 constexpr int kMediaPayloadType = 127;
1008 constexpr int kFlexfecPayloadType = 118;
1009 constexpr uint32_t kMediaSsrc = 1234;
1010 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001011 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001012 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001013 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001014 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001015 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001016 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001017
1018 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001019 rtp_sender_.reset(new RTPSender(
1020 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1021 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1022 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001023 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001024 rtp_sender_->SetSSRC(kMediaSsrc);
1025 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001026 rtp_sender_->SetStorePacketsStatus(true, 10);
1027
1028 // Parameters selected to generate a single FEC packet per media packet.
1029 FecProtectionParams params;
1030 params.fec_rate = 15;
1031 params.max_fec_frames = 1;
1032 params.fec_mask_type = kFecMaskRandom;
1033 rtp_sender_->SetFecParameters(params, params);
1034
brandtr9dfff292016-11-14 05:14:50 -08001035 EXPECT_CALL(mock_paced_sender_,
1036 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1037 _, _, false));
1038 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001039 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001040 kFlexfecSsrc, _, _, _, false))
1041 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001042 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001043 EXPECT_CALL(mock_rtc_event_log_,
1044 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1045 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001046 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1047 fake_clock_.TimeInMilliseconds(),
1048 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001049 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1050 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001051 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001052 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001053 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1054 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001055 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001056 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001057 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1058 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1059 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1060 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001061}
1062
ilnik10894992017-06-21 08:23:19 -07001063// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1064// should be removed.
1065TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1066 constexpr int kMediaPayloadType = 127;
1067 constexpr int kFlexfecPayloadType = 118;
1068 constexpr uint32_t kMediaSsrc = 1234;
1069 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001070 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001071 const std::vector<RtpExtension> kNoRtpExtensions;
1072 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001073
ilnik10894992017-06-21 08:23:19 -07001074 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001075 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001076 nullptr /* rtp_state */, &fake_clock_);
1077
1078 // Reset |rtp_sender_| to use FlexFEC.
1079 rtp_sender_.reset(new RTPSender(
1080 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1081 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1082 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001083 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001084 rtp_sender_->SetSSRC(kMediaSsrc);
1085 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001086 rtp_sender_->SetStorePacketsStatus(true, 10);
1087
ilnike4350192017-06-29 02:27:44 -07001088 // Need extension to be registered for timing frames to be sent.
1089 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1090 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1091
ilnik10894992017-06-21 08:23:19 -07001092 // Parameters selected to generate a single FEC packet per media packet.
1093 FecProtectionParams params;
1094 params.fec_rate = 15;
1095 params.max_fec_frames = 1;
1096 params.fec_mask_type = kFecMaskRandom;
1097 rtp_sender_->SetFecParameters(params, params);
1098
1099 EXPECT_CALL(mock_paced_sender_,
1100 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1101 _, _, false));
1102 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1103 kFlexfecSsrc, _, _, _, false))
1104 .Times(0); // Not called because packet should not be protected.
1105
1106 const uint32_t kTimestamp = 1234;
1107 const uint8_t kPayloadType = 127;
1108 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1109 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1110 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1111 0, 1500));
1112 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001113 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001114 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1115 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001116 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1117 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001118
Elad Alon4a87e1c2017-10-03 16:11:34 +02001119 EXPECT_CALL(mock_rtc_event_log_,
1120 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1121 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001122 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1123 fake_clock_.TimeInMilliseconds(),
1124 false, PacedPacketInfo()));
1125 ASSERT_EQ(1, transport_.packets_sent());
1126 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1127 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1128 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1129 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1130
1131 // Now try to send not a timing frame.
1132 uint16_t flexfec_seq_num;
1133 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1134 kFlexfecSsrc, _, _, _, false))
1135 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1136 EXPECT_CALL(mock_paced_sender_,
1137 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1138 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001139 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001140 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1141 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001142 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1143 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001144
Elad Alon4a87e1c2017-10-03 16:11:34 +02001145 EXPECT_CALL(mock_rtc_event_log_,
1146 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1147 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001148 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1149 fake_clock_.TimeInMilliseconds(),
1150 false, PacedPacketInfo()));
1151 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1152 fake_clock_.TimeInMilliseconds(),
1153 false, PacedPacketInfo()));
1154 ASSERT_EQ(3, transport_.packets_sent());
1155 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1156 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1157 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1158 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1159 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1160 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1161 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1162 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1163}
1164
minyue3a407ee2017-04-03 01:10:33 -07001165TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001166 constexpr int kMediaPayloadType = 127;
1167 constexpr int kFlexfecPayloadType = 118;
1168 constexpr uint32_t kMediaSsrc = 1234;
1169 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001170 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001171 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001172 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001173 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001174 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001175 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001176
1177 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001178 rtp_sender_.reset(
1179 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1180 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1181 &mock_rtc_event_log_, &send_packet_observer_,
1182 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001183 rtp_sender_->SetSSRC(kMediaSsrc);
1184 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001185
1186 // Parameters selected to generate a single FEC packet per media packet.
1187 FecProtectionParams params;
1188 params.fec_rate = 15;
1189 params.max_fec_frames = 1;
1190 params.fec_mask_type = kFecMaskRandom;
1191 rtp_sender_->SetFecParameters(params, params);
1192
Elad Alon4a87e1c2017-10-03 16:11:34 +02001193 EXPECT_CALL(mock_rtc_event_log_,
1194 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1195 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001196 SendGenericPayload();
1197 ASSERT_EQ(2, transport_.packets_sent());
1198 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1199 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1200 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1201 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1202 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1203 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1204}
1205
Steve Anton296a0ce2018-03-22 15:17:27 -07001206// Test that the MID header extension is included on sent packets when
1207// configured.
1208TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1209 const char kMid[] = "mid";
1210
1211 // Register MID header extension and set the MID for the RTPSender.
1212 rtp_sender_->SetSendingMediaStatus(false);
1213 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1214 rtp_sender_->SetMid(kMid);
1215 rtp_sender_->SetSendingMediaStatus(true);
1216
1217 // Send a couple packets.
1218 SendGenericPayload();
1219 SendGenericPayload();
1220
1221 // Expect both packets to have the MID set.
1222 ASSERT_EQ(2u, transport_.sent_packets_.size());
1223 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1224 std::string mid;
1225 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1226 EXPECT_EQ(kMid, mid);
1227 }
1228}
1229
minyue3a407ee2017-04-03 01:10:33 -07001230TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001231 constexpr int kFlexfecPayloadType = 118;
1232 constexpr uint32_t kMediaSsrc = 1234;
1233 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001234 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001235 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001236 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001237 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001238 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001239 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001240
1241 // Reset |rtp_sender_| to use FlexFEC.
1242 rtp_sender_.reset(new RTPSender(
1243 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1244 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1245 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001246 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001247 rtp_sender_->SetSSRC(kMediaSsrc);
1248 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001249
1250 // Parameters selected to generate a single FEC packet per media packet.
1251 FecProtectionParams params;
1252 params.fec_rate = 15;
1253 params.max_fec_frames = 1;
1254 params.fec_mask_type = kFecMaskRandom;
1255 rtp_sender_->SetFecParameters(params, params);
1256
1257 constexpr size_t kNumMediaPackets = 10;
1258 constexpr size_t kNumFecPackets = kNumMediaPackets;
1259 constexpr int64_t kTimeBetweenPacketsMs = 10;
1260 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1261 .Times(kNumMediaPackets + kNumFecPackets);
1262 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1263 SendGenericPayload();
1264 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1265 }
1266 constexpr size_t kRtpHeaderLength = 12;
1267 constexpr size_t kFlexfecHeaderLength = 20;
1268 constexpr size_t kGenericCodecHeaderLength = 1;
1269 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1270 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1271 kGenericCodecHeaderLength + kPayloadLength;
1272 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1273 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1274 rtp_sender_->FecOverheadRate(), 500);
1275}
1276
minyue3a407ee2017-04-03 01:10:33 -07001277TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001278 class TestCallback : public FrameCountObserver {
1279 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001280 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001281 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001282
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001283 void FrameCountUpdated(const FrameCounts& frame_counts,
1284 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001285 ++num_calls_;
1286 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001287 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001288 }
1289
1290 uint32_t num_calls_;
1291 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001292 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001293 } callback;
1294
Erik Språng7b52f102018-02-07 14:37:37 +01001295 rtp_sender_.reset(new RTPSender(
1296 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1297 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1298 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001299 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001300 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1301 const uint8_t payload_type = 127;
1302 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1303 0, 1500));
1304 uint8_t payload[] = {47, 11, 32, 93, 89};
1305 rtp_sender_->SetStorePacketsStatus(true, 1);
1306 uint32_t ssrc = rtp_sender_->SSRC();
1307
terelius5d332ac2016-01-14 14:37:39 -08001308 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1309 .Times(::testing::AtLeast(2));
1310
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001311 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001312 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1313 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001314 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001315
1316 EXPECT_EQ(1U, callback.num_calls_);
1317 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001318 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1319 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001320
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001321 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1322 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001323 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001324
1325 EXPECT_EQ(2U, callback.num_calls_);
1326 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001327 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1328 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001329
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001330 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001331}
1332
minyue3a407ee2017-04-03 01:10:33 -07001333TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001334 class TestCallback : public BitrateStatisticsObserver {
1335 public:
sprangcd349d92016-07-13 09:11:28 -07001336 TestCallback()
1337 : BitrateStatisticsObserver(),
1338 num_calls_(0),
1339 ssrc_(0),
1340 total_bitrate_(0),
1341 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001342 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001343
sprangcd349d92016-07-13 09:11:28 -07001344 void Notify(uint32_t total_bitrate,
1345 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001346 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001347 ++num_calls_;
1348 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001349 total_bitrate_ = total_bitrate;
1350 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001351 }
1352
1353 uint32_t num_calls_;
1354 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001355 uint32_t total_bitrate_;
1356 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001357 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001358 rtp_sender_.reset(
1359 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1360 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1361 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001362 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001363
sprangcd349d92016-07-13 09:11:28 -07001364 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1365 // number of packets selected so that we fill (but don't overflow) the one
1366 // second averaging window.
1367 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001368 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001369 const uint32_t kNumPackets =
1370 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001371 // Overhead = 12 bytes RTP header + 1 byte generic header.
1372 const uint32_t kPacketOverhead = 13;
1373
1374 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1375 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001376 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1377 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001378 uint8_t payload[] = {47, 11, 32, 93, 89};
1379 rtp_sender_->SetStorePacketsStatus(true, 1);
1380 uint32_t ssrc = rtp_sender_->SSRC();
1381
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001382 // Initial process call so we get a new time window.
1383 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001384
1385 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001386 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001387 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001388 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1389 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001390 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001391 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1392 }
1393
1394 rtp_sender_->ProcessBitrate();
1395
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001396 // We get one call for every stats updated, thus two calls since both the
1397 // stream stats and the retransmit stats are updated once.
1398 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001399 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001400 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1401 // Bitrate measured over delta between last and first timestamp, plus one.
1402 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1403 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1404 const uint32_t kExpectedRateBps =
1405 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1406 kExpectedWindowMs;
1407 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001408
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001409 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001410}
1411
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001412class RtpSenderAudioTest : public RtpSenderTest {
1413 protected:
1414 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001415
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001416 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001417 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001418 rtp_sender_.reset(
1419 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1420 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1421 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001422 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001423 rtp_sender_->SetSequenceNumber(kSeqNum);
1424 }
1425};
1426
minyue3a407ee2017-04-03 01:10:33 -07001427TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001428 class TestCallback : public StreamDataCountersCallback {
1429 public:
danilchap162abd32015-12-10 02:39:40 -08001430 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001431 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001432
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001433 void DataCountersUpdated(const StreamDataCounters& counters,
1434 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001435 ssrc_ = ssrc;
1436 counters_ = counters;
1437 }
1438
1439 uint32_t ssrc_;
1440 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001441
1442 void MatchPacketCounter(const RtpPacketCounter& expected,
1443 const RtpPacketCounter& actual) {
1444 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1445 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1446 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1447 EXPECT_EQ(expected.packets, actual.packets);
1448 }
1449
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001450 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1451 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001452 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1453 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001454 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001455 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001456 } callback;
1457
1458 const uint8_t kRedPayloadType = 96;
1459 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001460 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1461 const uint8_t payload_type = 127;
1462 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1463 0, 1500));
1464 uint8_t payload[] = {47, 11, 32, 93, 89};
1465 rtp_sender_->SetStorePacketsStatus(true, 1);
1466 uint32_t ssrc = rtp_sender_->SSRC();
1467
1468 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1469
1470 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001471 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001472 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001473 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001474 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001475 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001476 expected.transmitted.payload_bytes = 6;
1477 expected.transmitted.header_bytes = 12;
1478 expected.transmitted.padding_bytes = 0;
1479 expected.transmitted.packets = 1;
1480 expected.retransmitted.payload_bytes = 0;
1481 expected.retransmitted.header_bytes = 0;
1482 expected.retransmitted.padding_bytes = 0;
1483 expected.retransmitted.packets = 0;
1484 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001485 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001486
1487 // Retransmit a frame.
1488 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001489 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001490 expected.transmitted.payload_bytes = 12;
1491 expected.transmitted.header_bytes = 24;
1492 expected.transmitted.packets = 2;
1493 expected.retransmitted.payload_bytes = 6;
1494 expected.retransmitted.header_bytes = 12;
1495 expected.retransmitted.padding_bytes = 0;
1496 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001497 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001498
1499 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001500 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001501 expected.transmitted.payload_bytes = 12;
1502 expected.transmitted.header_bytes = 36;
1503 expected.transmitted.padding_bytes = kMaxPaddingSize;
1504 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001505 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001506
brandtrf1bb4762016-11-07 03:05:06 -08001507 // Send ULPFEC.
1508 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001509 FecProtectionParams fec_params;
1510 fec_params.fec_mask_type = kFecMaskRandom;
1511 fec_params.fec_rate = 1;
1512 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001513 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001514 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001515 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001516 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001517 expected.transmitted.payload_bytes = 40;
1518 expected.transmitted.header_bytes = 60;
1519 expected.transmitted.packets = 5;
1520 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001521 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001522
sprang867fb522015-08-03 04:38:41 -07001523 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001524}
1525
minyue3a407ee2017-04-03 01:10:33 -07001526TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001527 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1528 const uint8_t payload_type = 127;
1529 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1530 0, 1500));
1531 uint8_t payload[] = {47, 11, 32, 93, 89};
1532
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001533 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001534 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001535 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001536 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001537
danilchap96c15872016-11-21 01:35:29 -08001538 auto sent_payload = transport_.last_sent_packet().payload();
1539 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001540}
1541
minyue3a407ee2017-04-03 01:10:33 -07001542TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001543 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001544 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1545 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001546
1547 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1548 const uint8_t payload_type = 127;
1549 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1550 0, 1500));
1551 uint8_t payload[] = {47, 11, 32, 93, 89};
1552
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001553 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001554 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001555 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001556 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001557
danilchap96c15872016-11-21 01:35:29 -08001558 auto sent_payload = transport_.last_sent_packet().payload();
1559 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001560 // Verify AudioLevel extension.
1561 bool voice_activity;
1562 uint8_t audio_level;
1563 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1564 &voice_activity, &audio_level));
1565 EXPECT_EQ(kAudioLevel, audio_level);
1566 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001567}
1568
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001569// As RFC4733, named telephone events are carried as part of the audio stream
1570// and must use the same sequence number and timestamp base as the regular
1571// audio channel.
1572// This test checks the marker bit for the first packet and the consequent
1573// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001574// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001575TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001576 const char* kDtmfPayloadName = "telephone-event";
1577 const uint32_t kPayloadFrequency = 8000;
1578 const uint8_t kPayloadType = 126;
1579 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1580 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001581 // For Telephone events, payload is not added to the registered payload list,
1582 // it will register only the payload used for audio stream.
1583 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001584 const char* kPayloadName = "payload_name";
1585 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1586 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001587 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1588 // DTMF event key=9, duration=500 and attenuationdB=10
1589 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1590 // During start, it takes the starting timestamp as last sent timestamp.
1591 // The duration is calculated as the difference of current and last sent
1592 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001593 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001594 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1595 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001596 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001597 // DTMF Sample Length is (Frequency/1000) * Duration.
1598 // So in this case, it is (8000/1000) * 500 = 4000.
1599 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001600 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001601 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001602 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001603
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001604 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001605 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001606
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001607 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001608 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001609 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001610 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001611 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001612}
1613
minyue3a407ee2017-04-03 01:10:33 -07001614TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001615 const char* kPayloadName = "GENERIC";
1616 const uint8_t kPayloadType = 127;
1617 rtp_sender_->SetSSRC(1234);
1618 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001619 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001620 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001621
danilchap162abd32015-12-10 02:39:40 -08001622 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1623 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001624 uint8_t payload[] = {47, 11, 32, 93, 89};
1625
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001626 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001627 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001628 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001629 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001630
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001631 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001632 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1633 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001634
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001635 StreamDataCounters rtp_stats;
1636 StreamDataCounters rtx_stats;
1637 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001638
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001639 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001640 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001641 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1642 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1643 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1644 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1645 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1646 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001647
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001648 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001649 rtp_stats.transmitted.payload_bytes +
1650 rtp_stats.transmitted.header_bytes +
1651 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001652 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001653 rtx_stats.transmitted.payload_bytes +
1654 rtx_stats.transmitted.header_bytes +
1655 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001656
danilchap162abd32015-12-10 02:39:40 -08001657 EXPECT_EQ(
1658 transport_.total_bytes_sent_,
1659 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001660}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001661
minyue3a407ee2017-04-03 01:10:33 -07001662TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001663 const int32_t kPacketSize = 1400;
1664 const int32_t kNumPackets = 30;
1665
sprangcd349d92016-07-13 09:11:28 -07001666 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1667
sprang38778b02015-09-29 09:48:22 -07001668 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001669 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001670 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001671 for (int32_t i = 0; i < kNumPackets; ++i) {
1672 sequence_numbers.push_back(kStartSequenceNumber + i);
1673 fake_clock_.AdvanceTimeMilliseconds(1);
1674 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1675 }
danilchap12ba1862016-10-26 02:41:55 -07001676 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001677
1678 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1679
1680 // Resending should work - brings the bandwidth up to the limit.
1681 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1682 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001683 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001684 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001685
sprangcd349d92016-07-13 09:11:28 -07001686 // Must be at least 5ms in between retransmission attempts.
1687 fake_clock_.AdvanceTimeMilliseconds(5);
1688
sprang38778b02015-09-29 09:48:22 -07001689 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001690 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001691 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001692}
1693
minyue3a407ee2017-04-03 01:10:33 -07001694TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001695 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001696 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1697 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001698
philipel1a4746a2018-07-09 15:52:29 +02001699 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001700 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001701 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001702 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001703 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001704
danilchapc1600c52016-10-26 03:33:11 -07001705 VideoRotation rotation;
1706 EXPECT_TRUE(
1707 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1708 EXPECT_EQ(kVideoRotation_0, rotation);
1709}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001710
ilnik04f4d122017-06-19 07:18:55 -07001711TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1712 uint8_t kFrame[kMaxPacketLength];
1713 const int64_t kPacketizationTimeMs = 100;
1714 const int64_t kEncodeStartDeltaMs = 10;
1715 const int64_t kEncodeFinishDeltaMs = 50;
1716 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1717 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1718
1719 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1720
philipel1a4746a2018-07-09 15:52:29 +02001721 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001722 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001723 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1724 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1725
1726 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001727 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001728 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001729 sizeof(kFrame), nullptr, &hdr,
1730 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001731 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001732 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1733 &timing));
1734 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1735 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1736 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1737}
1738
minyue3a407ee2017-04-03 01:10:33 -07001739TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001740 uint8_t kFrame[kMaxPacketLength];
1741 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1742 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1743
philipel1a4746a2018-07-09 15:52:29 +02001744 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001745 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001746 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001747 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001748 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001749
1750 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001751 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001752 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001753 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001754
1755 VideoRotation rotation;
1756 EXPECT_TRUE(
1757 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1758 EXPECT_EQ(kVideoRotation_0, rotation);
1759}
1760
minyue3a407ee2017-04-03 01:10:33 -07001761TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001762 uint8_t kFrame[kMaxPacketLength];
1763 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1764 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1765
philipel1a4746a2018-07-09 15:52:29 +02001766 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001767 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001768 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001769 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001770 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001771
spranga8ae6f22017-09-04 07:23:56 -07001772 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001773 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001774 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001775
1776 VideoRotation rotation;
1777 EXPECT_TRUE(
1778 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1779 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001780}
magjed71eb61c2016-09-08 03:24:58 -07001781
1782// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1783// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001784TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001785 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1786 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1787 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1788 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1789 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1790 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1791 const int flip_bit = 1 << 2;
1792 const int camera_bit = 1 << 3;
1793 EXPECT_EQ(kVideoRotation_0,
1794 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1795 EXPECT_EQ(kVideoRotation_90,
1796 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1797 EXPECT_EQ(kVideoRotation_180,
1798 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1799 EXPECT_EQ(kVideoRotation_270,
1800 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1801}
1802
spranga8ae6f22017-09-04 07:23:56 -07001803TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1804 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001805 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001806
1807 EXPECT_EQ(kDontRetransmit,
1808 rtp_sender_video_->GetStorageType(
1809 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1810 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1811 header, kRetransmitBaseLayer,
1812 kDefaultExpectedRetransmissionTimeMs));
1813 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1814 header, kRetransmitHigherLayers,
1815 kDefaultExpectedRetransmissionTimeMs));
1816 EXPECT_EQ(kAllowRetransmission,
1817 rtp_sender_video_->GetStorageType(
1818 header, kConditionallyRetransmitHigherLayers,
1819 kDefaultExpectedRetransmissionTimeMs));
1820 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1821 header, kRetransmitAllPackets,
1822 kDefaultExpectedRetransmissionTimeMs));
1823}
1824
1825TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1826 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001827 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1828 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001829 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001830
1831 EXPECT_EQ(kDontRetransmit,
1832 rtp_sender_video_->GetStorageType(
1833 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1834 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1835 header, kRetransmitBaseLayer,
1836 kDefaultExpectedRetransmissionTimeMs));
1837 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1838 header, kRetransmitHigherLayers,
1839 kDefaultExpectedRetransmissionTimeMs));
1840 EXPECT_EQ(kAllowRetransmission,
1841 rtp_sender_video_->GetStorageType(
1842 header, kConditionallyRetransmitHigherLayers,
1843 kDefaultExpectedRetransmissionTimeMs));
1844 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1845 header, kRetransmitAllPackets,
1846 kDefaultExpectedRetransmissionTimeMs));
1847}
1848
1849TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1850 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001851 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001852 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1853 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001854
1855 EXPECT_EQ(kDontRetransmit,
1856 rtp_sender_video_->GetStorageType(
1857 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1858 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1859 header, kRetransmitBaseLayer,
1860 kDefaultExpectedRetransmissionTimeMs));
1861 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1862 header, kRetransmitHigherLayers,
1863 kDefaultExpectedRetransmissionTimeMs));
1864 EXPECT_EQ(kAllowRetransmission,
1865 rtp_sender_video_->GetStorageType(
1866 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1867 kDefaultExpectedRetransmissionTimeMs));
1868 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1869 header, kConditionallyRetransmitHigherLayers,
1870 kDefaultExpectedRetransmissionTimeMs));
1871 EXPECT_EQ(
1872 kAllowRetransmission,
1873 rtp_sender_video_->GetStorageType(
1874 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1875 kDefaultExpectedRetransmissionTimeMs));
1876 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1877 header, kRetransmitAllPackets,
1878 kDefaultExpectedRetransmissionTimeMs));
1879}
1880
1881TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1882 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001883 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001884
Philip Eliassond52a1a62018-09-07 13:03:55 +00001885 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001886 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001887 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001888
1889 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1890 header, kRetransmitOff,
1891 kDefaultExpectedRetransmissionTimeMs));
1892 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1893 header, kRetransmitBaseLayer,
1894 kDefaultExpectedRetransmissionTimeMs));
1895 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1896 header, kRetransmitHigherLayers,
1897 kDefaultExpectedRetransmissionTimeMs));
1898 EXPECT_EQ(kAllowRetransmission,
1899 rtp_sender_video_->GetStorageType(
1900 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1901 kDefaultExpectedRetransmissionTimeMs));
1902 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1903 header, kRetransmitAllPackets,
1904 kDefaultExpectedRetransmissionTimeMs));
1905 }
1906}
1907
1908TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1909 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001910 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07001911
philipel29d88462018-08-08 14:26:00 +02001912 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07001913 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02001914 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001915
1916 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1917 header, kRetransmitOff,
1918 kDefaultExpectedRetransmissionTimeMs));
1919 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1920 header, kRetransmitBaseLayer,
1921 kDefaultExpectedRetransmissionTimeMs));
1922 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1923 header, kRetransmitHigherLayers,
1924 kDefaultExpectedRetransmissionTimeMs));
1925 EXPECT_EQ(kAllowRetransmission,
1926 rtp_sender_video_->GetStorageType(
1927 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1928 kDefaultExpectedRetransmissionTimeMs));
1929 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1930 header, kRetransmitAllPackets,
1931 kDefaultExpectedRetransmissionTimeMs));
1932 }
1933}
1934
1935TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1936 const int64_t kFrameIntervalMs = 33;
1937 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1938 const uint8_t kSettings =
1939 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1940
1941 // Insert VP8 frames for all temporal layers, but stop before the final index.
1942 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001943 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001944
1945 // Fill averaging window to prevent rounding errors.
1946 constexpr int kNumRepetitions =
1947 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1948 kFrameIntervalMs;
1949 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00001950 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001951 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001952 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07001953 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1954 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1955 }
1956
1957 // Since we're at the start of the pattern, the next expected frame in TL0 is
1958 // right now. We will wait at most one expected retransmission time before
1959 // acknowledging that it did not arrive, which means this frame and the next
1960 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00001961 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07001962 EXPECT_EQ(StorageType::kDontRetransmit,
1963 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1964 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1965 EXPECT_EQ(StorageType::kDontRetransmit,
1966 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1967 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1968
1969 // The TL0 frame did not arrive. So allow retransmission.
1970 EXPECT_EQ(StorageType::kAllowRetransmission,
1971 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1972 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1973
1974 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1975 // in three frames away. TL0 is still too far in the past. So, allow
1976 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00001977 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07001978 EXPECT_EQ(StorageType::kAllowRetransmission,
1979 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1980 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1981
1982 // Another TL2, next in TL1 is two frames away. Allow again.
1983 EXPECT_EQ(StorageType::kAllowRetransmission,
1984 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1985 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1986
1987 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1988 // for retransmission.
1989 EXPECT_EQ(StorageType::kDontRetransmit,
1990 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1991}
1992
1993TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1994 const int64_t kFrameIntervalMs = 200;
1995 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1996 const int32_t kSettings =
1997 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1998
1999 // Insert VP8 frames for all temporal layers, but stop before the final index.
2000 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002001 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002002
2003 // Fill averaging window to prevent rounding errors.
2004 constexpr int kNumRepetitions =
2005 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2006 kFrameIntervalMs;
2007 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002008 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002009 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002010 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002011
2012 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2013 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2014 }
2015
2016 // Since we're at the start of the pattern, the next expected frame will be
2017 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2018 // we don't store for retransmission because we expect a frame in a lower
2019 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2020 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002021 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002022 EXPECT_EQ(StorageType::kAllowRetransmission,
2023 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2024}
2025
philipelb3e42a42018-09-13 10:57:14 +02002026TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2027 const int64_t kFrameId = 100000;
2028 uint8_t kFrame[100];
2029 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2030 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2031
2032 RTPVideoHeader hdr;
2033 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2034 generic.frame_id = kFrameId;
2035 generic.temporal_index = 3;
2036 generic.spatial_index = 2;
2037 generic.higher_spatial_layers.push_back(4);
2038 generic.dependencies.push_back(kFrameId - 1);
2039 generic.dependencies.push_back(kFrameId - 500);
2040 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2041 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2042 &hdr, kDefaultExpectedRetransmissionTimeMs);
2043
2044 RtpGenericFrameDescriptor descriptor_wire;
2045 EXPECT_EQ(1U, transport_.sent_packets_.size());
2046 EXPECT_TRUE(
2047 transport_.last_sent_packet()
2048 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2049 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2050 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2051 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2052 uint8_t spatial_bitmask = 0x14;
2053 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2054}
2055
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002056TEST_P(RtpSenderVideoTest,
2057 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2058 const int64_t kFrameId = 100000;
2059 const size_t kFrameSize = 100;
2060 uint8_t kFrame[kFrameSize];
2061 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2062 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2063
2064 RTPVideoHeader hdr;
2065 hdr.codec = kVideoCodecVP8;
2066 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2067 vp8.pictureId = kFrameId % 0X7FFF;
2068 vp8.tl0PicIdx = 13;
2069 vp8.temporalIdx = 1;
2070 vp8.keyIdx = 2;
2071 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2072 generic.frame_id = kFrameId;
2073 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2074 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2075 &hdr, kDefaultExpectedRetransmissionTimeMs);
2076
2077 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2078 // Expect only minimal 1-byte vp8 descriptor was generated.
2079 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2080}
2081
minyue3a407ee2017-04-03 01:10:33 -07002082TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002083 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002084 rtp_sender_.reset(new RTPSender(
2085 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2086 nullptr, nullptr, nullptr, nullptr, nullptr,
2087 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002088 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002089
michaelt4da30442016-11-17 01:38:43 -08002090 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002091 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002092 SendGenericPayload();
2093
2094 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2095 kTransmissionTimeOffsetExtensionId);
2096
2097 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002098 // 12B + 8B = 20B
2099 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002100 SendGenericPayload();
2101}
2102
minyue3a407ee2017-04-03 01:10:33 -07002103TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002104 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002105 rtp_sender_.reset(new RTPSender(
2106 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2107 nullptr, nullptr, nullptr, nullptr, nullptr,
2108 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002109 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002110
2111 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002112 SendGenericPayload();
2113 SendGenericPayload();
2114}
2115
sprang168794c2017-07-06 04:38:06 -07002116TEST_P(RtpSenderTest, SendsKeepAlive) {
2117 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002118 rtp_sender_.reset(
2119 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2120 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2121 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002122 rtp_sender_->SetSequenceNumber(kSeqNum);
2123 rtp_sender_->SetTimestampOffset(0);
2124 rtp_sender_->SetSSRC(kSsrc);
2125
2126 const uint8_t kKeepalivePayloadType = 20;
2127 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2128
2129 EXPECT_CALL(transport, SendRtp(_, _, _))
2130 .WillOnce(
2131 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2132 const PacketOptions& options) {
2133 webrtc::RTPHeader rtp_header;
2134 RtpUtility::RtpHeaderParser parser(packet, len);
2135 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2136 EXPECT_FALSE(rtp_header.markerBit);
2137 EXPECT_EQ(0U, rtp_header.paddingLength);
2138 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2139 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2140 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2141 EXPECT_EQ(0u, len - rtp_header.headerLength);
2142 return true;
2143 }));
2144
2145 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2146 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2147}
2148
minyue3a407ee2017-04-03 01:10:33 -07002149INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2150 RtpSenderTest,
2151 ::testing::Bool());
2152INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2153 RtpSenderTestWithoutPacer,
2154 ::testing::Bool());
2155INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2156 RtpSenderVideoTest,
2157 ::testing::Bool());
2158INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2159 RtpSenderAudioTest,
2160 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002161} // namespace webrtc