blob: 3c7a6d2df5de209132e2deef4dcaeb27aafd9b71 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000070
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000071uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020072 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000073}
74
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000075class LoopbackTransportTest : public webrtc::Transport {
76 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020077 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070078 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
79 kTransmissionTimeOffsetExtensionId);
80 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
81 kAbsoluteSendTimeExtensionId);
82 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
83 kTransportSequenceNumberExtensionId);
84 receivers_extensions_.Register(kRtpExtensionVideoRotation,
85 kVideoRotationExtensionId);
86 receivers_extensions_.Register(kRtpExtensionAudioLevel,
87 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070088 receivers_extensions_.Register(kRtpExtensionVideoTiming,
89 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070090 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020091 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
92 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000093 }
danilchap12ba1862016-10-26 02:41:55 -070094
stefan1d8a5062015-10-02 03:39:33 -070095 bool SendRtp(const uint8_t* data,
96 size_t len,
97 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020098 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000099 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700100 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
101 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700102 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000103 }
danilchap162abd32015-12-10 02:39:40 -0800104 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700105 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
106 int packets_sent() { return sent_packets_.size(); }
107
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000108 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200109 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700110 std::vector<RtpPacketReceived> sent_packets_;
111
112 private:
113 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000114};
115
Elad Alon4a87e1c2017-10-03 16:11:34 +0200116MATCHER_P(SameRtcEventTypeAs, value, "") {
117 return value == arg->GetType();
118}
119
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000120} // namespace
121
sprangebbf8a82015-09-21 15:11:14 -0700122class MockRtpPacketSender : public RtpPacketSender {
123 public:
124 MockRtpPacketSender() {}
125 virtual ~MockRtpPacketSender() {}
126
Peter Boströme23e7372015-10-08 11:44:14 +0200127 MOCK_METHOD6(InsertPacket,
128 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700129 uint32_t ssrc,
130 uint16_t sequence_number,
131 int64_t capture_time_ms,
132 size_t bytes,
133 bool retransmission));
134};
135
Stefan Holmerf5dca482016-01-27 12:58:51 +0100136class MockTransportSequenceNumberAllocator
137 : public TransportSequenceNumberAllocator {
138 public:
139 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
140};
141
asapersson35151f32016-05-02 23:44:01 -0700142class MockSendPacketObserver : public SendPacketObserver {
143 public:
144 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
145};
146
Stefan Holmera246cfb2016-08-23 17:51:42 +0200147class MockTransportFeedbackObserver : public TransportFeedbackObserver {
148 public:
elad.alond12a8e12017-03-23 11:04:48 -0700149 MOCK_METHOD4(AddPacket,
150 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200151 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800152 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153};
154
minyue3a407ee2017-04-03 01:10:33 -0700155class MockOverheadObserver : public OverheadObserver {
156 public:
157 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
158};
159
160class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000161 protected:
162 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000163 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800164 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000165 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700166 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000167 rtp_sender_(),
168 payload_(kPayload),
169 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700170 kMarkerBit(true),
171 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
172 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000173
Erik Språng7b52f102018-02-07 14:37:37 +0100174 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200175
Erik Språng7b52f102018-02-07 14:37:37 +0100176 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700177 rtp_sender_.reset(new RTPSender(
178 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800179 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700180 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100181 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800182 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700183 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800184 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000185 }
186
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000187 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700188 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700189 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700190 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
191 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200192 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700193 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700194 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000195 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000196 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000197 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700198 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000199
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000200 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800201 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000202 }
203
204 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800205 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
206 }
207
208 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
209 bool marker_bit,
210 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000211 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000212 EXPECT_EQ(payload_, rtp_header.payloadType);
213 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
214 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
215 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800216 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000217 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000218 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000219
danilchapb6f1fb52016-10-19 06:11:39 -0700220 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
221 bool marker_bit,
222 uint32_t timestamp,
223 int64_t capture_time_ms) {
224 auto packet = rtp_sender_->AllocatePacket();
225 packet->SetPayloadType(payload_type);
226 packet->SetMarker(marker_bit);
227 packet->SetTimestamp(timestamp);
228 packet->set_capture_time_ms(capture_time_ms);
229 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
230 return packet;
231 }
232
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000233 void SendPacket(int64_t capture_time_ms, int payload_length) {
234 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700235 auto packet =
236 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
237 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000238
239 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700240 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
241 kAllowRetransmission,
242 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000243 }
asapersson35151f32016-05-02 23:44:01 -0700244
245 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700246 const uint32_t kTimestamp = 1234;
247 const uint8_t kPayloadType = 127;
248 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
249 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
250 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
251 0, 1500));
252
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200253 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700254 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200255 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200256 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700257 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700258 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000259};
260
Peter Boströme23e7372015-10-08 11:44:14 +0200261// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
262// default code path.
263class RtpSenderTestWithoutPacer : public RtpSenderTest {
264 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100265 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200266};
267
spranga8ae6f22017-09-04 07:23:56 -0700268class TestRtpSenderVideo : public RTPSenderVideo {
269 public:
270 TestRtpSenderVideo(Clock* clock,
271 RTPSender* rtp_sender,
272 FlexfecSender* flexfec_sender)
273 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
274 ~TestRtpSenderVideo() override {}
275
276 StorageType GetStorageType(const RTPVideoHeader& header,
277 int32_t retransmission_settings,
278 int64_t expected_retransmission_time_ms) {
279 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
280 retransmission_settings,
281 expected_retransmission_time_ms);
282 }
283};
284
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000285class RtpSenderVideoTest : public RtpSenderTest {
286 protected:
danilchap162abd32015-12-10 02:39:40 -0800287 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200288 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100289 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000290 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700291 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000292 }
spranga8ae6f22017-09-04 07:23:56 -0700293 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000294};
295
minyue3a407ee2017-04-03 01:10:33 -0700296TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200297 // Configure rtp_sender with csrc.
298 std::vector<uint32_t> csrcs;
299 csrcs.push_back(0x23456789);
300 rtp_sender_->SetCsrcs(csrcs);
301
302 auto packet = rtp_sender_->AllocatePacket();
303
304 ASSERT_TRUE(packet);
305 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
306 EXPECT_EQ(csrcs, packet->Csrcs());
307}
308
minyue3a407ee2017-04-03 01:10:33 -0700309TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200310 // Configure rtp_sender with extensions.
311 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
312 kRtpExtensionTransmissionTimeOffset,
313 kTransmissionTimeOffsetExtensionId));
314 ASSERT_EQ(
315 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
316 kAbsoluteSendTimeExtensionId));
317 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
318 kAudioLevelExtensionId));
319 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
320 kRtpExtensionTransportSequenceNumber,
321 kTransportSequenceNumberExtensionId));
322 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
323 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
324
325 auto packet = rtp_sender_->AllocatePacket();
326
327 ASSERT_TRUE(packet);
328 // Preallocate BWE extensions RtpSender set itself.
329 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
330 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
331 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
332 // Do not allocate media specific extensions.
333 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
334 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
335}
336
minyue3a407ee2017-04-03 01:10:33 -0700337TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200338 auto packet = rtp_sender_->AllocatePacket();
339 ASSERT_TRUE(packet);
340 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
341
342 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
343
344 EXPECT_EQ(sequence_number, packet->SequenceNumber());
345 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
346}
347
minyue3a407ee2017-04-03 01:10:33 -0700348TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200349 auto packet = rtp_sender_->AllocatePacket();
350 ASSERT_TRUE(packet);
351
352 rtp_sender_->SetSendingMediaStatus(false);
353 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
354}
355
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100356TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200357 constexpr size_t kPaddingSize = 100;
358 auto packet = rtp_sender_->AllocatePacket();
359 ASSERT_TRUE(packet);
360
philipel8aadd502017-02-23 02:56:13 -0800361 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200362 packet->SetMarker(false);
363 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100364 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800365 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200366
367 packet->SetMarker(true);
368 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
369 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800370 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200371}
372
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100373TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
374 MockTransport transport;
375 const bool kEnableAudio = true;
376 rtp_sender_.reset(new RTPSender(
377 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
378 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
379 nullptr, &retransmission_rate_limiter_, nullptr, false));
380 rtp_sender_->SetTimestampOffset(0);
381 rtp_sender_->SetSSRC(kSsrc);
382
383 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
384 // Padding on audio stream allowed regardless of marker in the last packet.
385 audio_packet->SetMarker(false);
386 audio_packet->SetPayloadType(kPayload);
387 rtp_sender_->AssignSequenceNumber(audio_packet.get());
388
389 const size_t kPaddingSize = 59;
390 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
391 .WillOnce(testing::Return(true));
392 EXPECT_EQ(kPaddingSize,
393 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
394
395 // Requested padding size is too small, will send a larger one.
396 const size_t kMinPaddingSize = 50;
397 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
398 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200399 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
400 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100401}
402
minyue3a407ee2017-04-03 01:10:33 -0700403TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200404 constexpr size_t kPaddingSize = 100;
405 auto packet = rtp_sender_->AllocatePacket();
406 ASSERT_TRUE(packet);
407 packet->SetMarker(true);
408 packet->SetTimestamp(kTimestamp);
409
410 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800411 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200412
413 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700414 // Verify padding packet timestamp.
415 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200416}
417
minyue3a407ee2017-04-03 01:10:33 -0700418TEST_P(RtpSenderTestWithoutPacer,
419 TransportFeedbackObserverGetsCorrectByteCount) {
420 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
421 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
422 rtp_sender_.reset(new RTPSender(
423 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
424 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100425 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700426 rtp_sender_->SetSSRC(kSsrc);
427 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
428 kRtpExtensionTransportSequenceNumber,
429 kTransportSequenceNumberExtensionId));
430 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
431 .WillOnce(testing::Return(kTransportSequenceNumber));
432
433 const size_t expected_bytes =
434 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
435 kRtpOverheadBytesPerPacket
436 : sizeof(kPayloadData) + kGenericHeaderLength;
437
438 EXPECT_CALL(feedback_observer_,
439 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
440 expected_bytes, PacedPacketInfo()))
441 .Times(1);
442 EXPECT_CALL(mock_overhead_observer,
443 OnOverheadChanged(kRtpOverheadBytesPerPacket))
444 .Times(1);
445 SendGenericPayload();
446}
447
448TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200449 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800450 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
451 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100452 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800453 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100454 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
455 kRtpExtensionTransportSequenceNumber,
456 kTransportSequenceNumberExtensionId));
457
Stefan Holmerf5dca482016-01-27 12:58:51 +0100458 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
459 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700460 EXPECT_CALL(send_packet_observer_,
461 OnSendPacket(kTransportSequenceNumber, _, _))
462 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700463
464 EXPECT_CALL(feedback_observer_,
465 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
466 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200467 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700468
469 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100470
danilchap12ba1862016-10-26 02:41:55 -0700471 const auto& packet = transport_.last_sent_packet();
472 uint16_t transport_seq_no;
473 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
474 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200475 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
476}
477
478TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
479 rtp_sender_.reset(new RTPSender(
480 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
481 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
482 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
483 rtp_sender_->SetSSRC(kSsrc);
484
485 SendGenericPayload();
486
487 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100488}
489
minyue3a407ee2017-04-03 01:10:33 -0700490TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700491 SendGenericPayload();
492}
asapersson35151f32016-05-02 23:44:01 -0700493
minyue3a407ee2017-04-03 01:10:33 -0700494TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700495 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
496 kRtpExtensionTransportSequenceNumber,
497 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700498 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
499 .WillOnce(testing::Return(kTransportSequenceNumber));
500 EXPECT_CALL(send_packet_observer_,
501 OnSendPacket(kTransportSequenceNumber, _, _))
502 .Times(1);
503
504 SendGenericPayload();
505}
506
minyue3a407ee2017-04-03 01:10:33 -0700507TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800508 rtp_sender_.reset(new RTPSender(
509 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
510 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
511 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100512 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800513 rtp_sender_->SetSequenceNumber(kSeqNum);
514 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200515 rtp_sender_->SetStorePacketsStatus(true, 10);
516 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
517 kRtpExtensionTransportSequenceNumber,
518 kTransportSequenceNumberExtensionId));
519
brandtr9dfff292016-11-14 05:14:50 -0800520 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200521 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
522 .WillOnce(testing::Return(kTransportSequenceNumber));
523 EXPECT_CALL(send_packet_observer_,
524 OnSendPacket(kTransportSequenceNumber, _, _))
525 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700526 EXPECT_CALL(feedback_observer_,
527 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
528 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200529 .Times(1);
530
531 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800532 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
533 fake_clock_.TimeInMilliseconds(), false,
534 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200535
danilchap12ba1862016-10-26 02:41:55 -0700536 const auto& packet = transport_.last_sent_packet();
537 uint16_t transport_seq_no;
538 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
539 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200540 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200541}
542
Erik Språng7b52f102018-02-07 14:37:37 +0100543TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700544 rtp_sender_->SetStorePacketsStatus(true, 10);
545 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
546 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
547 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
548 auto packet = rtp_sender_->AllocatePacket();
549 packet->SetPayloadType(kPayload);
550 packet->SetMarker(true);
551 packet->SetTimestamp(kTimestamp);
552 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700553 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700554 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
555 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
556 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700557
558 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100559 {
560 EXPECT_CALL(
561 mock_paced_sender_,
562 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
563 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
564 kAllowRetransmission,
565 RtpPacketSender::kNormalPriority));
566 }
ilnik04f4d122017-06-19 07:18:55 -0700567 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100568 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
569 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700570 EXPECT_EQ(1, transport_.packets_sent());
571 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
572
danilchapce251812017-09-11 12:24:41 -0700573 VideoSendTiming video_timing;
574 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
575 &video_timing));
576 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100577}
ilnik04f4d122017-06-19 07:18:55 -0700578
Erik Språng7b52f102018-02-07 14:37:37 +0100579TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
580 SetUpRtpSender(true, true);
581 rtp_sender_->SetStorePacketsStatus(true, 10);
582 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
583 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
584 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
585 auto packet = rtp_sender_->AllocatePacket();
586 packet->SetPayloadType(kPayload);
587 packet->SetMarker(true);
588 packet->SetTimestamp(kTimestamp);
589 packet->set_capture_time_ms(capture_time_ms);
590 const uint16_t kPacerExitMs = 1234u;
591 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
592 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
593 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
594 size_t packet_size = packet->size();
595
596 const int kStoredTimeInMs = 100;
597 {
598 EXPECT_CALL(
599 mock_paced_sender_,
600 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
601 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
602 kAllowRetransmission,
603 RtpPacketSender::kNormalPriority));
604 }
ilnik04f4d122017-06-19 07:18:55 -0700605 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
606 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
607 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100608 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700609 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
610
Erik Språng7b52f102018-02-07 14:37:37 +0100611 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700612 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
613 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100614 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
615 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700616}
617
minyue3a407ee2017-04-03 01:10:33 -0700618TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200619 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800620 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200621 EXPECT_CALL(mock_rtc_event_log_,
622 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000623
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000624 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000625 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800626 kRtpExtensionTransmissionTimeOffset,
627 kTransmissionTimeOffsetExtensionId));
628 EXPECT_EQ(
629 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
630 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000631 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700632 auto packet =
633 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
634 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000635
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000636 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700637 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
638 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700639 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000640
danilchap12ba1862016-10-26 02:41:55 -0700641 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000642
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000643 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000644 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000645
brandtr9dfff292016-11-14 05:14:50 -0800646 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800647 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000648
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000649 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700650 EXPECT_EQ(1, transport_.packets_sent());
651 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
652
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000653 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700654 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000655
656 // Verify transmission time offset.
657 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000658 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000659 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000660 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000661}
662
minyue3a407ee2017-04-03 01:10:33 -0700663TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200664 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800665 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200666 EXPECT_CALL(mock_rtc_event_log_,
667 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000668
669 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000670 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800671 kRtpExtensionTransmissionTimeOffset,
672 kTransmissionTimeOffsetExtensionId));
673 EXPECT_EQ(
674 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
675 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000676 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700677 auto packet =
678 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
679 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000680
681 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700682 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
683 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700684 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000685
danilchap12ba1862016-10-26 02:41:55 -0700686 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000687
terelius5d332ac2016-01-14 14:37:39 -0800688 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800689 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000690
691 const int kStoredTimeInMs = 100;
692 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
693
danilchapb6f1fb52016-10-19 06:11:39 -0700694 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700695 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000696
brandtr9dfff292016-11-14 05:14:50 -0800697 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800698 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000699
700 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700701 EXPECT_EQ(1, transport_.packets_sent());
702 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000703
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000704 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700705 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000706
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000707 // Verify transmission time offset.
708 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000709 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000710 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
711 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
712}
713
714// This test sends 1 regular video packet, then 4 padding packets, and then
715// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700716TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000717 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800718 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800719 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200720 EXPECT_CALL(mock_rtc_event_log_,
721 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
722 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000723
724 uint16_t seq_num = kSeqNum;
725 uint32_t timestamp = kTimestamp;
726 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000727 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000728 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800729 kRtpExtensionTransmissionTimeOffset,
730 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000731 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800732 EXPECT_EQ(
733 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
734 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000735 rtp_header_len += 4; // 4 bytes extension.
736 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
737
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000738 webrtc::RTPHeader rtp_header;
739
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000740 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700741 auto packet =
742 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200743 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700744 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000745
746 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700747 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
748 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700749 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000750
751 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700752 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000753
754 const int kStoredTimeInMs = 100;
755 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800756 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800757 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000758 // Packet should now be sent. This test doesn't verify the regular video
759 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700760 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000761 timestamp += 90 * kStoredTimeInMs;
762
763 // Send padding 4 times, waiting 50 ms between each.
764 for (int i = 0; i < 4; ++i) {
765 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000766 const size_t kPaddingBytes = 100;
767 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000768 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800769 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800770 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000771
772 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700773 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000774 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700775 transport_.last_sent_packet().size());
776
777 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700778 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000779
Stefan Holmer586b19b2015-09-18 11:14:31 +0200780 // Verify sequence number and timestamp. The timestamp should be the same
781 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000782 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200783 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000784 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200785 int offset = timestamp - media_packet_timestamp;
786 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000787 uint64_t expected_send_time =
788 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
789 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
790 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
791 timestamp += 90 * kPaddingPeriodMs;
792 }
793
794 // Send a regular video packet again.
795 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700796 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
797 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000798
brandtr9dfff292016-11-14 05:14:50 -0800799 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
800 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800801
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000802 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700803 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
804 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700805 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000806
brandtr9dfff292016-11-14 05:14:50 -0800807 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800808 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000809 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700810 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
811 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
812 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000813
814 // Verify sequence number and timestamp.
815 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
816 EXPECT_EQ(timestamp, rtp_header.timestamp);
817 // Verify transmission time offset. This packet is sent without delay.
818 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
819 uint64_t expected_send_time =
820 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000821 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000822}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000823
minyue3a407ee2017-04-03 01:10:33 -0700824TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700825 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
826 kRtpExtensionTransportSequenceNumber,
827 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700828 rtp_sender_->SetStorePacketsStatus(true, 10);
829
830 EXPECT_CALL(send_packet_observer_,
831 OnSendPacket(kTransportSequenceNumber, _, _))
832 .Times(1);
833 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
834 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800835 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
836 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700837
838 SendGenericPayload(); // Packet passed to pacer.
839 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800840 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
841 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800842 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700843 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700844}
845
minyue3a407ee2017-04-03 01:10:33 -0700846TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700847 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
848 kRtpExtensionTransportSequenceNumber,
849 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700850 rtp_sender_->SetStorePacketsStatus(true, 10);
851
852 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
853 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
854 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800855 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
856 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700857
858 SendGenericPayload(); // Packet passed to pacer.
859 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800860 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
861 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800862 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700863 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200864 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700865}
866
minyue3a407ee2017-04-03 01:10:33 -0700867TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700868 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800869 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700870 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800871 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100872 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800873 rtp_sender_->SetSequenceNumber(kSeqNum);
874 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700875 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
876 kRtpExtensionTransportSequenceNumber,
877 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700878 rtp_sender_->SetSequenceNumber(kSeqNum);
879 rtp_sender_->SetStorePacketsStatus(true, 10);
880
881 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800882 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
883 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700884
885 SendGenericPayload(); // Packet passed to pacer.
886 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800887 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
888 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800889 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700890 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700891}
892
minyue3a407ee2017-04-03 01:10:33 -0700893TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000894 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800895 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700896 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800897 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100898 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000899 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800900 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800901 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000902
903 uint16_t seq_num = kSeqNum;
904 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000905 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800906 EXPECT_EQ(
907 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
908 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000909 rtp_header_len += 4; // 4 bytes extension.
910 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
911
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000912 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000913 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000914
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000915 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800916 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
917 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800918 // Expect all packets go through the pacer.
919 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800920 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800921 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200922 EXPECT_CALL(mock_rtc_event_log_,
923 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800924 .Times(kNumPayloadSizes);
925
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000926 // Send 10 packets of increasing size.
927 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
928 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700929 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000930 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800931 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800932 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000933 fake_clock_.AdvanceTimeMilliseconds(33);
934 }
terelius429c3452016-01-21 05:42:04 -0800935
Elad Alon4a87e1c2017-10-03 16:11:34 +0200936 EXPECT_CALL(mock_rtc_event_log_,
937 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800938 .Times(::testing::AtLeast(4));
939
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000940 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700941 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700942 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700943 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800944 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000945
Petter Strandmark26bc6692018-05-29 08:43:35 +0200946 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +0200947 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700948 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200949 .WillOnce(
950 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -0700951 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800952 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200953 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000954
Yves Gerey665174f2018-06-19 15:03:05 +0200955 EXPECT_CALL(transport, SendRtp(_,
956 kPayloadSizes[kNumPayloadSizes - 1] +
957 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -0700958 _))
pbos2d566682015-09-28 09:59:31 -0700959 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200960
961 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -0700962 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200963 .WillOnce(
964 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000965 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800966 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200967 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000968}
969
minyue3a407ee2017-04-03 01:10:33 -0700970TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000971 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
972 const uint8_t payload_type = 127;
973 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
974 0, 1500));
975 uint8_t payload[] = {47, 11, 32, 93, 89};
976
977 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200978 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -0700979 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
980 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200981 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000982
danilchap96c15872016-11-21 01:35:29 -0800983 auto sent_payload = transport_.last_sent_packet().payload();
984 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000985 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
986 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800987 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000988
989 // Send delta frame
990 payload[0] = 13;
991 payload[1] = 42;
992 payload[4] = 13;
993
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700994 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
995 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200996 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000997
danilchap96c15872016-11-21 01:35:29 -0800998 sent_payload = transport_.last_sent_packet().payload();
999 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001000 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1001 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001002 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001003}
1004
minyue3a407ee2017-04-03 01:10:33 -07001005TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001006 constexpr int kMediaPayloadType = 127;
1007 constexpr int kFlexfecPayloadType = 118;
1008 constexpr uint32_t kMediaSsrc = 1234;
1009 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001010 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001011 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001012 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001013 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001014 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001015 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001016
1017 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001018 rtp_sender_.reset(new RTPSender(
1019 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1020 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1021 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001022 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001023 rtp_sender_->SetSSRC(kMediaSsrc);
1024 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001025 rtp_sender_->SetStorePacketsStatus(true, 10);
1026
1027 // Parameters selected to generate a single FEC packet per media packet.
1028 FecProtectionParams params;
1029 params.fec_rate = 15;
1030 params.max_fec_frames = 1;
1031 params.fec_mask_type = kFecMaskRandom;
1032 rtp_sender_->SetFecParameters(params, params);
1033
brandtr9dfff292016-11-14 05:14:50 -08001034 EXPECT_CALL(mock_paced_sender_,
1035 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1036 _, _, false));
1037 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001038 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001039 kFlexfecSsrc, _, _, _, false))
1040 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001041 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001042 EXPECT_CALL(mock_rtc_event_log_,
1043 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1044 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001045 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1046 fake_clock_.TimeInMilliseconds(),
1047 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001048 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1049 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001050 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001051 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001052 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1053 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001054 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001055 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001056 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1057 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1058 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1059 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001060}
1061
ilnik10894992017-06-21 08:23:19 -07001062// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1063// should be removed.
1064TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1065 constexpr int kMediaPayloadType = 127;
1066 constexpr int kFlexfecPayloadType = 118;
1067 constexpr uint32_t kMediaSsrc = 1234;
1068 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001069 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001070 const std::vector<RtpExtension> kNoRtpExtensions;
1071 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001072
ilnik10894992017-06-21 08:23:19 -07001073 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001074 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001075 nullptr /* rtp_state */, &fake_clock_);
1076
1077 // Reset |rtp_sender_| to use FlexFEC.
1078 rtp_sender_.reset(new RTPSender(
1079 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1080 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1081 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001082 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001083 rtp_sender_->SetSSRC(kMediaSsrc);
1084 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001085 rtp_sender_->SetStorePacketsStatus(true, 10);
1086
ilnike4350192017-06-29 02:27:44 -07001087 // Need extension to be registered for timing frames to be sent.
1088 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1089 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1090
ilnik10894992017-06-21 08:23:19 -07001091 // Parameters selected to generate a single FEC packet per media packet.
1092 FecProtectionParams params;
1093 params.fec_rate = 15;
1094 params.max_fec_frames = 1;
1095 params.fec_mask_type = kFecMaskRandom;
1096 rtp_sender_->SetFecParameters(params, params);
1097
1098 EXPECT_CALL(mock_paced_sender_,
1099 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1100 _, _, false));
1101 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1102 kFlexfecSsrc, _, _, _, false))
1103 .Times(0); // Not called because packet should not be protected.
1104
1105 const uint32_t kTimestamp = 1234;
1106 const uint8_t kPayloadType = 127;
1107 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1108 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1109 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1110 0, 1500));
1111 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001112 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001113 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1114 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001115 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1116 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001117
Elad Alon4a87e1c2017-10-03 16:11:34 +02001118 EXPECT_CALL(mock_rtc_event_log_,
1119 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1120 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001121 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1122 fake_clock_.TimeInMilliseconds(),
1123 false, PacedPacketInfo()));
1124 ASSERT_EQ(1, transport_.packets_sent());
1125 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1126 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1127 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1128 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1129
1130 // Now try to send not a timing frame.
1131 uint16_t flexfec_seq_num;
1132 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1133 kFlexfecSsrc, _, _, _, false))
1134 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1135 EXPECT_CALL(mock_paced_sender_,
1136 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1137 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001138 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001139 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1140 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001141 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1142 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001143
Elad Alon4a87e1c2017-10-03 16:11:34 +02001144 EXPECT_CALL(mock_rtc_event_log_,
1145 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1146 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001147 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1148 fake_clock_.TimeInMilliseconds(),
1149 false, PacedPacketInfo()));
1150 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1151 fake_clock_.TimeInMilliseconds(),
1152 false, PacedPacketInfo()));
1153 ASSERT_EQ(3, transport_.packets_sent());
1154 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1155 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1156 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1157 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1158 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1159 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1160 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1161 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1162}
1163
minyue3a407ee2017-04-03 01:10:33 -07001164TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001165 constexpr int kMediaPayloadType = 127;
1166 constexpr int kFlexfecPayloadType = 118;
1167 constexpr uint32_t kMediaSsrc = 1234;
1168 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001169 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001170 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001171 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001172 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001173 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001174 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001175
1176 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001177 rtp_sender_.reset(
1178 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1179 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1180 &mock_rtc_event_log_, &send_packet_observer_,
1181 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001182 rtp_sender_->SetSSRC(kMediaSsrc);
1183 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001184
1185 // Parameters selected to generate a single FEC packet per media packet.
1186 FecProtectionParams params;
1187 params.fec_rate = 15;
1188 params.max_fec_frames = 1;
1189 params.fec_mask_type = kFecMaskRandom;
1190 rtp_sender_->SetFecParameters(params, params);
1191
Elad Alon4a87e1c2017-10-03 16:11:34 +02001192 EXPECT_CALL(mock_rtc_event_log_,
1193 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1194 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001195 SendGenericPayload();
1196 ASSERT_EQ(2, transport_.packets_sent());
1197 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1198 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1199 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1200 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1201 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1202 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1203}
1204
Steve Anton296a0ce2018-03-22 15:17:27 -07001205// Test that the MID header extension is included on sent packets when
1206// configured.
1207TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1208 const char kMid[] = "mid";
1209
1210 // Register MID header extension and set the MID for the RTPSender.
1211 rtp_sender_->SetSendingMediaStatus(false);
1212 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1213 rtp_sender_->SetMid(kMid);
1214 rtp_sender_->SetSendingMediaStatus(true);
1215
1216 // Send a couple packets.
1217 SendGenericPayload();
1218 SendGenericPayload();
1219
1220 // Expect both packets to have the MID set.
1221 ASSERT_EQ(2u, transport_.sent_packets_.size());
1222 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1223 std::string mid;
1224 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1225 EXPECT_EQ(kMid, mid);
1226 }
1227}
1228
minyue3a407ee2017-04-03 01:10:33 -07001229TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001230 constexpr int kFlexfecPayloadType = 118;
1231 constexpr uint32_t kMediaSsrc = 1234;
1232 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001233 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001234 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001235 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001236 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001237 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001238 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001239
1240 // Reset |rtp_sender_| to use FlexFEC.
1241 rtp_sender_.reset(new RTPSender(
1242 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1243 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1244 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001245 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001246 rtp_sender_->SetSSRC(kMediaSsrc);
1247 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001248
1249 // Parameters selected to generate a single FEC packet per media packet.
1250 FecProtectionParams params;
1251 params.fec_rate = 15;
1252 params.max_fec_frames = 1;
1253 params.fec_mask_type = kFecMaskRandom;
1254 rtp_sender_->SetFecParameters(params, params);
1255
1256 constexpr size_t kNumMediaPackets = 10;
1257 constexpr size_t kNumFecPackets = kNumMediaPackets;
1258 constexpr int64_t kTimeBetweenPacketsMs = 10;
1259 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1260 .Times(kNumMediaPackets + kNumFecPackets);
1261 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1262 SendGenericPayload();
1263 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1264 }
1265 constexpr size_t kRtpHeaderLength = 12;
1266 constexpr size_t kFlexfecHeaderLength = 20;
1267 constexpr size_t kGenericCodecHeaderLength = 1;
1268 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1269 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1270 kGenericCodecHeaderLength + kPayloadLength;
1271 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1272 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1273 rtp_sender_->FecOverheadRate(), 500);
1274}
1275
minyue3a407ee2017-04-03 01:10:33 -07001276TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001277 class TestCallback : public FrameCountObserver {
1278 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001279 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001280 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001281
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001282 void FrameCountUpdated(const FrameCounts& frame_counts,
1283 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001284 ++num_calls_;
1285 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001286 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001287 }
1288
1289 uint32_t num_calls_;
1290 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001291 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001292 } callback;
1293
Erik Språng7b52f102018-02-07 14:37:37 +01001294 rtp_sender_.reset(new RTPSender(
1295 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1296 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1297 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001298 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001299 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1300 const uint8_t payload_type = 127;
1301 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1302 0, 1500));
1303 uint8_t payload[] = {47, 11, 32, 93, 89};
1304 rtp_sender_->SetStorePacketsStatus(true, 1);
1305 uint32_t ssrc = rtp_sender_->SSRC();
1306
terelius5d332ac2016-01-14 14:37:39 -08001307 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1308 .Times(::testing::AtLeast(2));
1309
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001310 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001311 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1312 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001313 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001314
1315 EXPECT_EQ(1U, callback.num_calls_);
1316 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001317 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1318 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001319
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001320 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1321 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001322 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001323
1324 EXPECT_EQ(2U, callback.num_calls_);
1325 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001326 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1327 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001328
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001329 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001330}
1331
minyue3a407ee2017-04-03 01:10:33 -07001332TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001333 class TestCallback : public BitrateStatisticsObserver {
1334 public:
sprangcd349d92016-07-13 09:11:28 -07001335 TestCallback()
1336 : BitrateStatisticsObserver(),
1337 num_calls_(0),
1338 ssrc_(0),
1339 total_bitrate_(0),
1340 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001341 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001342
sprangcd349d92016-07-13 09:11:28 -07001343 void Notify(uint32_t total_bitrate,
1344 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001345 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001346 ++num_calls_;
1347 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001348 total_bitrate_ = total_bitrate;
1349 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001350 }
1351
1352 uint32_t num_calls_;
1353 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001354 uint32_t total_bitrate_;
1355 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001356 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001357 rtp_sender_.reset(
1358 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1359 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1360 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001361 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001362
sprangcd349d92016-07-13 09:11:28 -07001363 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1364 // number of packets selected so that we fill (but don't overflow) the one
1365 // second averaging window.
1366 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001367 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001368 const uint32_t kNumPackets =
1369 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001370 // Overhead = 12 bytes RTP header + 1 byte generic header.
1371 const uint32_t kPacketOverhead = 13;
1372
1373 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1374 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001375 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1376 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001377 uint8_t payload[] = {47, 11, 32, 93, 89};
1378 rtp_sender_->SetStorePacketsStatus(true, 1);
1379 uint32_t ssrc = rtp_sender_->SSRC();
1380
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001381 // Initial process call so we get a new time window.
1382 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001383
1384 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001385 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001386 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001387 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1388 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001389 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001390 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1391 }
1392
1393 rtp_sender_->ProcessBitrate();
1394
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001395 // We get one call for every stats updated, thus two calls since both the
1396 // stream stats and the retransmit stats are updated once.
1397 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001398 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001399 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1400 // Bitrate measured over delta between last and first timestamp, plus one.
1401 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1402 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1403 const uint32_t kExpectedRateBps =
1404 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1405 kExpectedWindowMs;
1406 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001407
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001408 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001409}
1410
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001411class RtpSenderAudioTest : public RtpSenderTest {
1412 protected:
1413 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001414
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001415 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001416 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001417 rtp_sender_.reset(
1418 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1419 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1420 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001421 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001422 rtp_sender_->SetSequenceNumber(kSeqNum);
1423 }
1424};
1425
minyue3a407ee2017-04-03 01:10:33 -07001426TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001427 class TestCallback : public StreamDataCountersCallback {
1428 public:
danilchap162abd32015-12-10 02:39:40 -08001429 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001430 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001431
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001432 void DataCountersUpdated(const StreamDataCounters& counters,
1433 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001434 ssrc_ = ssrc;
1435 counters_ = counters;
1436 }
1437
1438 uint32_t ssrc_;
1439 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001440
1441 void MatchPacketCounter(const RtpPacketCounter& expected,
1442 const RtpPacketCounter& actual) {
1443 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1444 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1445 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1446 EXPECT_EQ(expected.packets, actual.packets);
1447 }
1448
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001449 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1450 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001451 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1452 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001453 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001454 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001455 } callback;
1456
1457 const uint8_t kRedPayloadType = 96;
1458 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001459 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1460 const uint8_t payload_type = 127;
1461 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1462 0, 1500));
1463 uint8_t payload[] = {47, 11, 32, 93, 89};
1464 rtp_sender_->SetStorePacketsStatus(true, 1);
1465 uint32_t ssrc = rtp_sender_->SSRC();
1466
1467 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1468
1469 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001470 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001471 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001472 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001473 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001474 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001475 expected.transmitted.payload_bytes = 6;
1476 expected.transmitted.header_bytes = 12;
1477 expected.transmitted.padding_bytes = 0;
1478 expected.transmitted.packets = 1;
1479 expected.retransmitted.payload_bytes = 0;
1480 expected.retransmitted.header_bytes = 0;
1481 expected.retransmitted.padding_bytes = 0;
1482 expected.retransmitted.packets = 0;
1483 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001484 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001485
1486 // Retransmit a frame.
1487 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001488 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001489 expected.transmitted.payload_bytes = 12;
1490 expected.transmitted.header_bytes = 24;
1491 expected.transmitted.packets = 2;
1492 expected.retransmitted.payload_bytes = 6;
1493 expected.retransmitted.header_bytes = 12;
1494 expected.retransmitted.padding_bytes = 0;
1495 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001496 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001497
1498 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001499 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001500 expected.transmitted.payload_bytes = 12;
1501 expected.transmitted.header_bytes = 36;
1502 expected.transmitted.padding_bytes = kMaxPaddingSize;
1503 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001504 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001505
brandtrf1bb4762016-11-07 03:05:06 -08001506 // Send ULPFEC.
1507 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001508 FecProtectionParams fec_params;
1509 fec_params.fec_mask_type = kFecMaskRandom;
1510 fec_params.fec_rate = 1;
1511 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001512 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001513 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001514 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001515 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001516 expected.transmitted.payload_bytes = 40;
1517 expected.transmitted.header_bytes = 60;
1518 expected.transmitted.packets = 5;
1519 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001520 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001521
sprang867fb522015-08-03 04:38:41 -07001522 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001523}
1524
minyue3a407ee2017-04-03 01:10:33 -07001525TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001526 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1527 const uint8_t payload_type = 127;
1528 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1529 0, 1500));
1530 uint8_t payload[] = {47, 11, 32, 93, 89};
1531
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001532 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001533 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001534 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001535 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001536
danilchap96c15872016-11-21 01:35:29 -08001537 auto sent_payload = transport_.last_sent_packet().payload();
1538 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001539}
1540
minyue3a407ee2017-04-03 01:10:33 -07001541TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001542 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001543 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1544 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001545
1546 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1547 const uint8_t payload_type = 127;
1548 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1549 0, 1500));
1550 uint8_t payload[] = {47, 11, 32, 93, 89};
1551
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001552 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001553 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001554 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001555 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001556
danilchap96c15872016-11-21 01:35:29 -08001557 auto sent_payload = transport_.last_sent_packet().payload();
1558 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001559 // Verify AudioLevel extension.
1560 bool voice_activity;
1561 uint8_t audio_level;
1562 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1563 &voice_activity, &audio_level));
1564 EXPECT_EQ(kAudioLevel, audio_level);
1565 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001566}
1567
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001568// As RFC4733, named telephone events are carried as part of the audio stream
1569// and must use the same sequence number and timestamp base as the regular
1570// audio channel.
1571// This test checks the marker bit for the first packet and the consequent
1572// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001573// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001574TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001575 const char* kDtmfPayloadName = "telephone-event";
1576 const uint32_t kPayloadFrequency = 8000;
1577 const uint8_t kPayloadType = 126;
1578 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1579 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001580 // For Telephone events, payload is not added to the registered payload list,
1581 // it will register only the payload used for audio stream.
1582 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001583 const char* kPayloadName = "payload_name";
1584 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1585 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001586 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1587 // DTMF event key=9, duration=500 and attenuationdB=10
1588 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1589 // During start, it takes the starting timestamp as last sent timestamp.
1590 // The duration is calculated as the difference of current and last sent
1591 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001592 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001593 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1594 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001595 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001596 // DTMF Sample Length is (Frequency/1000) * Duration.
1597 // So in this case, it is (8000/1000) * 500 = 4000.
1598 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001599 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001600 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001601 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001602
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001603 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001604 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001605
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001606 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001607 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001608 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001609 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001610 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001611}
1612
minyue3a407ee2017-04-03 01:10:33 -07001613TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001614 const char* kPayloadName = "GENERIC";
1615 const uint8_t kPayloadType = 127;
1616 rtp_sender_->SetSSRC(1234);
1617 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001618 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001619 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001620
danilchap162abd32015-12-10 02:39:40 -08001621 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1622 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001623 uint8_t payload[] = {47, 11, 32, 93, 89};
1624
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001625 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001626 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001627 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001628 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001629
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001630 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001631 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1632 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001633
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001634 StreamDataCounters rtp_stats;
1635 StreamDataCounters rtx_stats;
1636 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001637
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001638 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001639 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001640 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1641 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1642 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1643 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1644 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1645 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001646
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001647 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001648 rtp_stats.transmitted.payload_bytes +
1649 rtp_stats.transmitted.header_bytes +
1650 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001651 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001652 rtx_stats.transmitted.payload_bytes +
1653 rtx_stats.transmitted.header_bytes +
1654 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001655
danilchap162abd32015-12-10 02:39:40 -08001656 EXPECT_EQ(
1657 transport_.total_bytes_sent_,
1658 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001659}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001660
minyue3a407ee2017-04-03 01:10:33 -07001661TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001662 const int32_t kPacketSize = 1400;
1663 const int32_t kNumPackets = 30;
1664
sprangcd349d92016-07-13 09:11:28 -07001665 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1666
sprang38778b02015-09-29 09:48:22 -07001667 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001668 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001669 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001670 for (int32_t i = 0; i < kNumPackets; ++i) {
1671 sequence_numbers.push_back(kStartSequenceNumber + i);
1672 fake_clock_.AdvanceTimeMilliseconds(1);
1673 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1674 }
danilchap12ba1862016-10-26 02:41:55 -07001675 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001676
1677 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1678
1679 // Resending should work - brings the bandwidth up to the limit.
1680 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1681 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001682 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001683 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001684
sprangcd349d92016-07-13 09:11:28 -07001685 // Must be at least 5ms in between retransmission attempts.
1686 fake_clock_.AdvanceTimeMilliseconds(5);
1687
sprang38778b02015-09-29 09:48:22 -07001688 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001689 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001690 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001691}
1692
minyue3a407ee2017-04-03 01:10:33 -07001693TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001694 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001695 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1696 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001697
philipel1a4746a2018-07-09 15:52:29 +02001698 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001699 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001700 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001701 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001702 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001703
danilchapc1600c52016-10-26 03:33:11 -07001704 VideoRotation rotation;
1705 EXPECT_TRUE(
1706 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1707 EXPECT_EQ(kVideoRotation_0, rotation);
1708}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001709
ilnik04f4d122017-06-19 07:18:55 -07001710TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1711 uint8_t kFrame[kMaxPacketLength];
1712 const int64_t kPacketizationTimeMs = 100;
1713 const int64_t kEncodeStartDeltaMs = 10;
1714 const int64_t kEncodeFinishDeltaMs = 50;
1715 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1716 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1717
1718 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1719
philipel1a4746a2018-07-09 15:52:29 +02001720 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001721 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001722 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1723 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1724
1725 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001726 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001727 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001728 sizeof(kFrame), nullptr, &hdr,
1729 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001730 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001731 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1732 &timing));
1733 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1734 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1735 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1736}
1737
minyue3a407ee2017-04-03 01:10:33 -07001738TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001739 uint8_t kFrame[kMaxPacketLength];
1740 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1741 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1742
philipel1a4746a2018-07-09 15:52:29 +02001743 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001744 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001745 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001746 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001747 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001748
1749 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001750 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001751 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001752 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001753
1754 VideoRotation rotation;
1755 EXPECT_TRUE(
1756 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1757 EXPECT_EQ(kVideoRotation_0, rotation);
1758}
1759
minyue3a407ee2017-04-03 01:10:33 -07001760TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001761 uint8_t kFrame[kMaxPacketLength];
1762 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1763 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1764
philipel1a4746a2018-07-09 15:52:29 +02001765 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001766 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001767 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001768 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001769 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001770
spranga8ae6f22017-09-04 07:23:56 -07001771 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001772 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001773 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001774
1775 VideoRotation rotation;
1776 EXPECT_TRUE(
1777 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1778 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001779}
magjed71eb61c2016-09-08 03:24:58 -07001780
1781// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1782// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001783TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001784 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1785 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1786 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1787 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1788 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1789 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1790 const int flip_bit = 1 << 2;
1791 const int camera_bit = 1 << 3;
1792 EXPECT_EQ(kVideoRotation_0,
1793 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1794 EXPECT_EQ(kVideoRotation_90,
1795 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1796 EXPECT_EQ(kVideoRotation_180,
1797 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1798 EXPECT_EQ(kVideoRotation_270,
1799 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1800}
1801
spranga8ae6f22017-09-04 07:23:56 -07001802TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1803 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001804 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001805
1806 EXPECT_EQ(kDontRetransmit,
1807 rtp_sender_video_->GetStorageType(
1808 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1809 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1810 header, kRetransmitBaseLayer,
1811 kDefaultExpectedRetransmissionTimeMs));
1812 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1813 header, kRetransmitHigherLayers,
1814 kDefaultExpectedRetransmissionTimeMs));
1815 EXPECT_EQ(kAllowRetransmission,
1816 rtp_sender_video_->GetStorageType(
1817 header, kConditionallyRetransmitHigherLayers,
1818 kDefaultExpectedRetransmissionTimeMs));
1819 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1820 header, kRetransmitAllPackets,
1821 kDefaultExpectedRetransmissionTimeMs));
1822}
1823
1824TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1825 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001826 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1827 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001828 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001829
1830 EXPECT_EQ(kDontRetransmit,
1831 rtp_sender_video_->GetStorageType(
1832 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1833 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1834 header, kRetransmitBaseLayer,
1835 kDefaultExpectedRetransmissionTimeMs));
1836 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1837 header, kRetransmitHigherLayers,
1838 kDefaultExpectedRetransmissionTimeMs));
1839 EXPECT_EQ(kAllowRetransmission,
1840 rtp_sender_video_->GetStorageType(
1841 header, kConditionallyRetransmitHigherLayers,
1842 kDefaultExpectedRetransmissionTimeMs));
1843 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1844 header, kRetransmitAllPackets,
1845 kDefaultExpectedRetransmissionTimeMs));
1846}
1847
1848TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1849 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001850 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001851 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1852 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001853
1854 EXPECT_EQ(kDontRetransmit,
1855 rtp_sender_video_->GetStorageType(
1856 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1857 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1858 header, kRetransmitBaseLayer,
1859 kDefaultExpectedRetransmissionTimeMs));
1860 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1861 header, kRetransmitHigherLayers,
1862 kDefaultExpectedRetransmissionTimeMs));
1863 EXPECT_EQ(kAllowRetransmission,
1864 rtp_sender_video_->GetStorageType(
1865 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1866 kDefaultExpectedRetransmissionTimeMs));
1867 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1868 header, kConditionallyRetransmitHigherLayers,
1869 kDefaultExpectedRetransmissionTimeMs));
1870 EXPECT_EQ(
1871 kAllowRetransmission,
1872 rtp_sender_video_->GetStorageType(
1873 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1874 kDefaultExpectedRetransmissionTimeMs));
1875 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1876 header, kRetransmitAllPackets,
1877 kDefaultExpectedRetransmissionTimeMs));
1878}
1879
1880TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1881 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001882 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001883
Philip Eliassond52a1a62018-09-07 13:03:55 +00001884 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001885 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001886 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001887
1888 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1889 header, kRetransmitOff,
1890 kDefaultExpectedRetransmissionTimeMs));
1891 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1892 header, kRetransmitBaseLayer,
1893 kDefaultExpectedRetransmissionTimeMs));
1894 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1895 header, kRetransmitHigherLayers,
1896 kDefaultExpectedRetransmissionTimeMs));
1897 EXPECT_EQ(kAllowRetransmission,
1898 rtp_sender_video_->GetStorageType(
1899 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1900 kDefaultExpectedRetransmissionTimeMs));
1901 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1902 header, kRetransmitAllPackets,
1903 kDefaultExpectedRetransmissionTimeMs));
1904 }
1905}
1906
1907TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1908 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001909 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07001910
philipel29d88462018-08-08 14:26:00 +02001911 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07001912 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02001913 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001914
1915 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1916 header, kRetransmitOff,
1917 kDefaultExpectedRetransmissionTimeMs));
1918 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1919 header, kRetransmitBaseLayer,
1920 kDefaultExpectedRetransmissionTimeMs));
1921 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1922 header, kRetransmitHigherLayers,
1923 kDefaultExpectedRetransmissionTimeMs));
1924 EXPECT_EQ(kAllowRetransmission,
1925 rtp_sender_video_->GetStorageType(
1926 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1927 kDefaultExpectedRetransmissionTimeMs));
1928 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1929 header, kRetransmitAllPackets,
1930 kDefaultExpectedRetransmissionTimeMs));
1931 }
1932}
1933
1934TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1935 const int64_t kFrameIntervalMs = 33;
1936 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1937 const uint8_t kSettings =
1938 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1939
1940 // Insert VP8 frames for all temporal layers, but stop before the final index.
1941 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001942 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001943
1944 // Fill averaging window to prevent rounding errors.
1945 constexpr int kNumRepetitions =
1946 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1947 kFrameIntervalMs;
1948 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00001949 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001950 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001951 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07001952 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1953 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1954 }
1955
1956 // Since we're at the start of the pattern, the next expected frame in TL0 is
1957 // right now. We will wait at most one expected retransmission time before
1958 // acknowledging that it did not arrive, which means this frame and the next
1959 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00001960 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07001961 EXPECT_EQ(StorageType::kDontRetransmit,
1962 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1963 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1964 EXPECT_EQ(StorageType::kDontRetransmit,
1965 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1966 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1967
1968 // The TL0 frame did not arrive. So allow retransmission.
1969 EXPECT_EQ(StorageType::kAllowRetransmission,
1970 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1971 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1972
1973 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1974 // in three frames away. TL0 is still too far in the past. So, allow
1975 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00001976 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07001977 EXPECT_EQ(StorageType::kAllowRetransmission,
1978 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1979 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1980
1981 // Another TL2, next in TL1 is two frames away. Allow again.
1982 EXPECT_EQ(StorageType::kAllowRetransmission,
1983 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1984 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1985
1986 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1987 // for retransmission.
1988 EXPECT_EQ(StorageType::kDontRetransmit,
1989 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1990}
1991
1992TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1993 const int64_t kFrameIntervalMs = 200;
1994 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1995 const int32_t kSettings =
1996 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1997
1998 // Insert VP8 frames for all temporal layers, but stop before the final index.
1999 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002000 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002001
2002 // Fill averaging window to prevent rounding errors.
2003 constexpr int kNumRepetitions =
2004 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2005 kFrameIntervalMs;
2006 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002007 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002008 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002009 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002010
2011 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2012 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2013 }
2014
2015 // Since we're at the start of the pattern, the next expected frame will be
2016 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2017 // we don't store for retransmission because we expect a frame in a lower
2018 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2019 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002020 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002021 EXPECT_EQ(StorageType::kAllowRetransmission,
2022 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2023}
2024
philipelb3e42a42018-09-13 10:57:14 +02002025TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2026 const int64_t kFrameId = 100000;
2027 uint8_t kFrame[100];
2028 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2029 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2030
2031 RTPVideoHeader hdr;
2032 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2033 generic.frame_id = kFrameId;
2034 generic.temporal_index = 3;
2035 generic.spatial_index = 2;
2036 generic.higher_spatial_layers.push_back(4);
2037 generic.dependencies.push_back(kFrameId - 1);
2038 generic.dependencies.push_back(kFrameId - 500);
2039 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2040 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2041 &hdr, kDefaultExpectedRetransmissionTimeMs);
2042
2043 RtpGenericFrameDescriptor descriptor_wire;
2044 EXPECT_EQ(1U, transport_.sent_packets_.size());
2045 EXPECT_TRUE(
2046 transport_.last_sent_packet()
2047 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2048 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2049 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2050 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2051 uint8_t spatial_bitmask = 0x14;
2052 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2053}
2054
minyue3a407ee2017-04-03 01:10:33 -07002055TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002056 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002057 rtp_sender_.reset(new RTPSender(
2058 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2059 nullptr, nullptr, nullptr, nullptr, nullptr,
2060 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002061 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002062
michaelt4da30442016-11-17 01:38:43 -08002063 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002064 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002065 SendGenericPayload();
2066
2067 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2068 kTransmissionTimeOffsetExtensionId);
2069
2070 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002071 // 12B + 8B = 20B
2072 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002073 SendGenericPayload();
2074}
2075
minyue3a407ee2017-04-03 01:10:33 -07002076TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002077 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002078 rtp_sender_.reset(new RTPSender(
2079 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2080 nullptr, nullptr, nullptr, nullptr, nullptr,
2081 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002082 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002083
2084 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002085 SendGenericPayload();
2086 SendGenericPayload();
2087}
2088
sprang168794c2017-07-06 04:38:06 -07002089TEST_P(RtpSenderTest, SendsKeepAlive) {
2090 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002091 rtp_sender_.reset(
2092 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2093 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2094 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002095 rtp_sender_->SetSequenceNumber(kSeqNum);
2096 rtp_sender_->SetTimestampOffset(0);
2097 rtp_sender_->SetSSRC(kSsrc);
2098
2099 const uint8_t kKeepalivePayloadType = 20;
2100 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2101
2102 EXPECT_CALL(transport, SendRtp(_, _, _))
2103 .WillOnce(
2104 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2105 const PacketOptions& options) {
2106 webrtc::RTPHeader rtp_header;
2107 RtpUtility::RtpHeaderParser parser(packet, len);
2108 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2109 EXPECT_FALSE(rtp_header.markerBit);
2110 EXPECT_EQ(0U, rtp_header.paddingLength);
2111 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2112 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2113 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2114 EXPECT_EQ(0u, len - rtp_header.headerLength);
2115 return true;
2116 }));
2117
2118 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2119 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2120}
2121
minyue3a407ee2017-04-03 01:10:33 -07002122INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2123 RtpSenderTest,
2124 ::testing::Bool());
2125INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2126 RtpSenderTestWithoutPacer,
2127 ::testing::Bool());
2128INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2129 RtpSenderVideoTest,
2130 ::testing::Bool());
2131INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2132 RtpSenderAudioTest,
2133 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002134} // namespace webrtc