blob: 9622680e923de5e337ac44629ad0ba282fb1c962 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
24#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
25#include "modules/rtp_rtcp/source/rtp_packet_received.h"
26#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
27#include "modules/rtp_rtcp/source/rtp_sender.h"
28#include "modules/rtp_rtcp/source/rtp_sender_video.h"
29#include "modules/rtp_rtcp/source/rtp_utility.h"
30#include "rtc_base/arraysize.h"
31#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "rtc_base/rate_limiter.h"
33#include "test/field_trial.h"
34#include "test/gmock.h"
35#include "test/gtest.h"
36#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000037
38namespace webrtc {
39
andrew@webrtc.org8a442592011-12-16 21:24:30 +000040namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000041const int kTransmissionTimeOffsetExtensionId = 1;
42const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000043const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070044const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070045const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000046const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080047const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const uint32_t kTimestamp = 10;
49const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080050const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000051const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000052const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000053const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevelExtensionId = 9;
55const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000056const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000057const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000058const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020059const size_t kGenericHeaderLength = 1;
60const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070061const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062
Danil Chapovalov5e57b172016-09-02 19:15:59 +020063using ::testing::_;
64using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070065using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000066
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000067uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020068 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000069}
70
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000071class LoopbackTransportTest : public webrtc::Transport {
72 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020073 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070074 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
75 kTransmissionTimeOffsetExtensionId);
76 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
77 kAbsoluteSendTimeExtensionId);
78 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
79 kTransportSequenceNumberExtensionId);
80 receivers_extensions_.Register(kRtpExtensionVideoRotation,
81 kVideoRotationExtensionId);
82 receivers_extensions_.Register(kRtpExtensionAudioLevel,
83 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070084 receivers_extensions_.Register(kRtpExtensionVideoTiming,
85 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070086 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000087 }
danilchap12ba1862016-10-26 02:41:55 -070088
stefan1d8a5062015-10-02 03:39:33 -070089 bool SendRtp(const uint8_t* data,
90 size_t len,
91 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020092 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000093 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070094 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
95 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070096 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000097 }
danilchap162abd32015-12-10 02:39:40 -080098 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -070099 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
100 int packets_sent() { return sent_packets_.size(); }
101
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000102 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200103 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700104 std::vector<RtpPacketReceived> sent_packets_;
105
106 private:
107 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000108};
109
Elad Alon4a87e1c2017-10-03 16:11:34 +0200110MATCHER_P(SameRtcEventTypeAs, value, "") {
111 return value == arg->GetType();
112}
113
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000114} // namespace
115
sprangebbf8a82015-09-21 15:11:14 -0700116class MockRtpPacketSender : public RtpPacketSender {
117 public:
118 MockRtpPacketSender() {}
119 virtual ~MockRtpPacketSender() {}
120
Peter Boströme23e7372015-10-08 11:44:14 +0200121 MOCK_METHOD6(InsertPacket,
122 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700123 uint32_t ssrc,
124 uint16_t sequence_number,
125 int64_t capture_time_ms,
126 size_t bytes,
127 bool retransmission));
128};
129
Stefan Holmerf5dca482016-01-27 12:58:51 +0100130class MockTransportSequenceNumberAllocator
131 : public TransportSequenceNumberAllocator {
132 public:
133 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
134};
135
asapersson35151f32016-05-02 23:44:01 -0700136class MockSendPacketObserver : public SendPacketObserver {
137 public:
138 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
139};
140
Stefan Holmera246cfb2016-08-23 17:51:42 +0200141class MockTransportFeedbackObserver : public TransportFeedbackObserver {
142 public:
elad.alond12a8e12017-03-23 11:04:48 -0700143 MOCK_METHOD4(AddPacket,
144 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200145 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800146 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200147};
148
minyue3a407ee2017-04-03 01:10:33 -0700149class MockOverheadObserver : public OverheadObserver {
150 public:
151 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
152};
153
154class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000155 protected:
156 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000157 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800158 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000159 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700160 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000161 rtp_sender_(),
162 payload_(kPayload),
163 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700164 kMarkerBit(true),
165 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
166 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000167
Erik Språng7b52f102018-02-07 14:37:37 +0100168 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200169
Erik Språng7b52f102018-02-07 14:37:37 +0100170 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700171 rtp_sender_.reset(new RTPSender(
172 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800173 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700174 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100175 &retransmission_rate_limiter_, nullptr, populate_network2));
brandtr9dfff292016-11-14 05:14:50 -0800176 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700177 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800178 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179 }
180
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000181 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700182 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700183 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700184 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
185 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200186 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700187 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700188 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000189 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000190 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000191 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700192 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000193
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000194 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800195 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000196 }
197
198 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800199 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
200 }
201
202 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
203 bool marker_bit,
204 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000205 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000206 EXPECT_EQ(payload_, rtp_header.payloadType);
207 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
208 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
209 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800210 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000211 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000212 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000213
danilchapb6f1fb52016-10-19 06:11:39 -0700214 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
215 bool marker_bit,
216 uint32_t timestamp,
217 int64_t capture_time_ms) {
218 auto packet = rtp_sender_->AllocatePacket();
219 packet->SetPayloadType(payload_type);
220 packet->SetMarker(marker_bit);
221 packet->SetTimestamp(timestamp);
222 packet->set_capture_time_ms(capture_time_ms);
223 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
224 return packet;
225 }
226
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000227 void SendPacket(int64_t capture_time_ms, int payload_length) {
228 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700229 auto packet =
230 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
231 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000232
233 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700234 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
235 kAllowRetransmission,
236 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000237 }
asapersson35151f32016-05-02 23:44:01 -0700238
239 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700240 const uint32_t kTimestamp = 1234;
241 const uint8_t kPayloadType = 127;
242 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
243 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
244 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
245 0, 1500));
246
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700247 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200248 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700249 sizeof(kPayloadData), nullptr, nullptr, nullptr,
250 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700251 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000252};
253
Peter Boströme23e7372015-10-08 11:44:14 +0200254// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
255// default code path.
256class RtpSenderTestWithoutPacer : public RtpSenderTest {
257 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100258 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200259};
260
spranga8ae6f22017-09-04 07:23:56 -0700261class TestRtpSenderVideo : public RTPSenderVideo {
262 public:
263 TestRtpSenderVideo(Clock* clock,
264 RTPSender* rtp_sender,
265 FlexfecSender* flexfec_sender)
266 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
267 ~TestRtpSenderVideo() override {}
268
269 StorageType GetStorageType(const RTPVideoHeader& header,
270 int32_t retransmission_settings,
271 int64_t expected_retransmission_time_ms) {
272 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
273 retransmission_settings,
274 expected_retransmission_time_ms);
275 }
276};
277
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000278class RtpSenderVideoTest : public RtpSenderTest {
279 protected:
danilchap162abd32015-12-10 02:39:40 -0800280 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200281 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100282 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000283 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700284 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000285 }
spranga8ae6f22017-09-04 07:23:56 -0700286 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000287};
288
minyue3a407ee2017-04-03 01:10:33 -0700289TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200290 // Configure rtp_sender with csrc.
291 std::vector<uint32_t> csrcs;
292 csrcs.push_back(0x23456789);
293 rtp_sender_->SetCsrcs(csrcs);
294
295 auto packet = rtp_sender_->AllocatePacket();
296
297 ASSERT_TRUE(packet);
298 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
299 EXPECT_EQ(csrcs, packet->Csrcs());
300}
301
minyue3a407ee2017-04-03 01:10:33 -0700302TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200303 // Configure rtp_sender with extensions.
304 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
305 kRtpExtensionTransmissionTimeOffset,
306 kTransmissionTimeOffsetExtensionId));
307 ASSERT_EQ(
308 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
309 kAbsoluteSendTimeExtensionId));
310 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
311 kAudioLevelExtensionId));
312 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
313 kRtpExtensionTransportSequenceNumber,
314 kTransportSequenceNumberExtensionId));
315 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
316 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
317
318 auto packet = rtp_sender_->AllocatePacket();
319
320 ASSERT_TRUE(packet);
321 // Preallocate BWE extensions RtpSender set itself.
322 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
323 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
324 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
325 // Do not allocate media specific extensions.
326 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
327 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
328}
329
minyue3a407ee2017-04-03 01:10:33 -0700330TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200331 auto packet = rtp_sender_->AllocatePacket();
332 ASSERT_TRUE(packet);
333 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
334
335 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
336
337 EXPECT_EQ(sequence_number, packet->SequenceNumber());
338 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
339}
340
minyue3a407ee2017-04-03 01:10:33 -0700341TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200342 auto packet = rtp_sender_->AllocatePacket();
343 ASSERT_TRUE(packet);
344
345 rtp_sender_->SetSendingMediaStatus(false);
346 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
347}
348
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100349TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200350 constexpr size_t kPaddingSize = 100;
351 auto packet = rtp_sender_->AllocatePacket();
352 ASSERT_TRUE(packet);
353
philipel8aadd502017-02-23 02:56:13 -0800354 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200355 packet->SetMarker(false);
356 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100357 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800358 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200359
360 packet->SetMarker(true);
361 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
362 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800363 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364}
365
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100366TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
367 MockTransport transport;
368 const bool kEnableAudio = true;
369 rtp_sender_.reset(new RTPSender(
370 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
371 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
372 nullptr, &retransmission_rate_limiter_, nullptr, false));
373 rtp_sender_->SetTimestampOffset(0);
374 rtp_sender_->SetSSRC(kSsrc);
375
376 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
377 // Padding on audio stream allowed regardless of marker in the last packet.
378 audio_packet->SetMarker(false);
379 audio_packet->SetPayloadType(kPayload);
380 rtp_sender_->AssignSequenceNumber(audio_packet.get());
381
382 const size_t kPaddingSize = 59;
383 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
384 .WillOnce(testing::Return(true));
385 EXPECT_EQ(kPaddingSize,
386 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
387
388 // Requested padding size is too small, will send a larger one.
389 const size_t kMinPaddingSize = 50;
390 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
391 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200392 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
393 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100394}
395
minyue3a407ee2017-04-03 01:10:33 -0700396TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200397 constexpr size_t kPaddingSize = 100;
398 auto packet = rtp_sender_->AllocatePacket();
399 ASSERT_TRUE(packet);
400 packet->SetMarker(true);
401 packet->SetTimestamp(kTimestamp);
402
403 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800404 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200405
406 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700407 // Verify padding packet timestamp.
408 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200409}
410
minyue3a407ee2017-04-03 01:10:33 -0700411TEST_P(RtpSenderTestWithoutPacer,
412 TransportFeedbackObserverGetsCorrectByteCount) {
413 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
414 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
415 rtp_sender_.reset(new RTPSender(
416 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
417 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100418 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700419 rtp_sender_->SetSSRC(kSsrc);
420 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
421 kRtpExtensionTransportSequenceNumber,
422 kTransportSequenceNumberExtensionId));
423 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
424 .WillOnce(testing::Return(kTransportSequenceNumber));
425
426 const size_t expected_bytes =
427 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
428 kRtpOverheadBytesPerPacket
429 : sizeof(kPayloadData) + kGenericHeaderLength;
430
431 EXPECT_CALL(feedback_observer_,
432 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
433 expected_bytes, PacedPacketInfo()))
434 .Times(1);
435 EXPECT_CALL(mock_overhead_observer,
436 OnOverheadChanged(kRtpOverheadBytesPerPacket))
437 .Times(1);
438 SendGenericPayload();
439}
440
441TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200442 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800443 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
444 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100445 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800446 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100447 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
448 kRtpExtensionTransportSequenceNumber,
449 kTransportSequenceNumberExtensionId));
450
Stefan Holmerf5dca482016-01-27 12:58:51 +0100451 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
452 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700453 EXPECT_CALL(send_packet_observer_,
454 OnSendPacket(kTransportSequenceNumber, _, _))
455 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700456
457 EXPECT_CALL(feedback_observer_,
458 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
459 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200460 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700461
462 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100463
danilchap12ba1862016-10-26 02:41:55 -0700464 const auto& packet = transport_.last_sent_packet();
465 uint16_t transport_seq_no;
466 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
467 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200468 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
469}
470
471TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
472 rtp_sender_.reset(new RTPSender(
473 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
474 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
475 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
476 rtp_sender_->SetSSRC(kSsrc);
477
478 SendGenericPayload();
479
480 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100481}
482
minyue3a407ee2017-04-03 01:10:33 -0700483TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700484 SendGenericPayload();
485}
asapersson35151f32016-05-02 23:44:01 -0700486
minyue3a407ee2017-04-03 01:10:33 -0700487TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700488 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
489 kRtpExtensionTransportSequenceNumber,
490 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700491 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
492 .WillOnce(testing::Return(kTransportSequenceNumber));
493 EXPECT_CALL(send_packet_observer_,
494 OnSendPacket(kTransportSequenceNumber, _, _))
495 .Times(1);
496
497 SendGenericPayload();
498}
499
minyue3a407ee2017-04-03 01:10:33 -0700500TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800501 rtp_sender_.reset(new RTPSender(
502 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
503 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
504 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100505 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800506 rtp_sender_->SetSequenceNumber(kSeqNum);
507 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200508 rtp_sender_->SetStorePacketsStatus(true, 10);
509 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
510 kRtpExtensionTransportSequenceNumber,
511 kTransportSequenceNumberExtensionId));
512
brandtr9dfff292016-11-14 05:14:50 -0800513 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200514 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
515 .WillOnce(testing::Return(kTransportSequenceNumber));
516 EXPECT_CALL(send_packet_observer_,
517 OnSendPacket(kTransportSequenceNumber, _, _))
518 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700519 EXPECT_CALL(feedback_observer_,
520 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
521 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200522 .Times(1);
523
524 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800525 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
526 fake_clock_.TimeInMilliseconds(), false,
527 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200528
danilchap12ba1862016-10-26 02:41:55 -0700529 const auto& packet = transport_.last_sent_packet();
530 uint16_t transport_seq_no;
531 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
532 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200533 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200534}
535
Erik Språng7b52f102018-02-07 14:37:37 +0100536TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700537 rtp_sender_->SetStorePacketsStatus(true, 10);
538 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
539 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
540 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
541 auto packet = rtp_sender_->AllocatePacket();
542 packet->SetPayloadType(kPayload);
543 packet->SetMarker(true);
544 packet->SetTimestamp(kTimestamp);
545 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700546 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700547 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
548 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
549 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700550
551 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100552 {
553 EXPECT_CALL(
554 mock_paced_sender_,
555 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
556 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
557 kAllowRetransmission,
558 RtpPacketSender::kNormalPriority));
559 }
ilnik04f4d122017-06-19 07:18:55 -0700560 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100561 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
562 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700563 EXPECT_EQ(1, transport_.packets_sent());
564 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
565
danilchapce251812017-09-11 12:24:41 -0700566 VideoSendTiming video_timing;
567 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
568 &video_timing));
569 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100570}
ilnik04f4d122017-06-19 07:18:55 -0700571
Erik Språng7b52f102018-02-07 14:37:37 +0100572TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
573 SetUpRtpSender(true, true);
574 rtp_sender_->SetStorePacketsStatus(true, 10);
575 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
576 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
577 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
578 auto packet = rtp_sender_->AllocatePacket();
579 packet->SetPayloadType(kPayload);
580 packet->SetMarker(true);
581 packet->SetTimestamp(kTimestamp);
582 packet->set_capture_time_ms(capture_time_ms);
583 const uint16_t kPacerExitMs = 1234u;
584 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
585 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
586 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
587 size_t packet_size = packet->size();
588
589 const int kStoredTimeInMs = 100;
590 {
591 EXPECT_CALL(
592 mock_paced_sender_,
593 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
594 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
595 kAllowRetransmission,
596 RtpPacketSender::kNormalPriority));
597 }
ilnik04f4d122017-06-19 07:18:55 -0700598 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
599 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
600 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100601 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700602 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
603
Erik Språng7b52f102018-02-07 14:37:37 +0100604 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700605 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
606 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100607 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
608 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700609}
610
minyue3a407ee2017-04-03 01:10:33 -0700611TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200612 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800613 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200614 EXPECT_CALL(mock_rtc_event_log_,
615 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000616
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000617 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000618 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800619 kRtpExtensionTransmissionTimeOffset,
620 kTransmissionTimeOffsetExtensionId));
621 EXPECT_EQ(
622 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
623 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000624 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700625 auto packet =
626 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
627 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000628
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000629 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700630 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
631 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700632 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000633
danilchap12ba1862016-10-26 02:41:55 -0700634 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000635
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000636 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000637 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000638
brandtr9dfff292016-11-14 05:14:50 -0800639 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800640 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000641
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000642 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700643 EXPECT_EQ(1, transport_.packets_sent());
644 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
645
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000646 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700647 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000648
649 // Verify transmission time offset.
650 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000651 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000652 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000653 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000654}
655
minyue3a407ee2017-04-03 01:10:33 -0700656TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200657 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800658 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200659 EXPECT_CALL(mock_rtc_event_log_,
660 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000661
662 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000663 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800664 kRtpExtensionTransmissionTimeOffset,
665 kTransmissionTimeOffsetExtensionId));
666 EXPECT_EQ(
667 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
668 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000669 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700670 auto packet =
671 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
672 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000673
674 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700675 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
676 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700677 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000678
danilchap12ba1862016-10-26 02:41:55 -0700679 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000680
terelius5d332ac2016-01-14 14:37:39 -0800681 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800682 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000683
684 const int kStoredTimeInMs = 100;
685 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
686
danilchapb6f1fb52016-10-19 06:11:39 -0700687 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700688 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000689
brandtr9dfff292016-11-14 05:14:50 -0800690 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800691 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000692
693 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700694 EXPECT_EQ(1, transport_.packets_sent());
695 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000696
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000697 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700698 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000699
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000700 // Verify transmission time offset.
701 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000702 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000703 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
704 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
705}
706
707// This test sends 1 regular video packet, then 4 padding packets, and then
708// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700709TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000710 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800711 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800712 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200713 EXPECT_CALL(mock_rtc_event_log_,
714 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
715 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000716
717 uint16_t seq_num = kSeqNum;
718 uint32_t timestamp = kTimestamp;
719 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000720 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000721 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800722 kRtpExtensionTransmissionTimeOffset,
723 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000724 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800725 EXPECT_EQ(
726 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
727 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000728 rtp_header_len += 4; // 4 bytes extension.
729 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
730
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000731 webrtc::RTPHeader rtp_header;
732
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000733 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700734 auto packet =
735 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200736 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700737 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000738
739 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700740 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
741 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700742 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000743
744 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700745 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000746
747 const int kStoredTimeInMs = 100;
748 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800749 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800750 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000751 // Packet should now be sent. This test doesn't verify the regular video
752 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700753 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000754 timestamp += 90 * kStoredTimeInMs;
755
756 // Send padding 4 times, waiting 50 ms between each.
757 for (int i = 0; i < 4; ++i) {
758 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000759 const size_t kPaddingBytes = 100;
760 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000761 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800762 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800763 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000764
765 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700766 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000767 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700768 transport_.last_sent_packet().size());
769
770 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700771 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000772
Stefan Holmer586b19b2015-09-18 11:14:31 +0200773 // Verify sequence number and timestamp. The timestamp should be the same
774 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000775 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200776 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000777 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200778 int offset = timestamp - media_packet_timestamp;
779 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000780 uint64_t expected_send_time =
781 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
782 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
783 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
784 timestamp += 90 * kPaddingPeriodMs;
785 }
786
787 // Send a regular video packet again.
788 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700789 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
790 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000791
brandtr9dfff292016-11-14 05:14:50 -0800792 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
793 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800794
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000795 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700796 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
797 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700798 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000799
brandtr9dfff292016-11-14 05:14:50 -0800800 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800801 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000802 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700803 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
804 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
805 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000806
807 // Verify sequence number and timestamp.
808 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
809 EXPECT_EQ(timestamp, rtp_header.timestamp);
810 // Verify transmission time offset. This packet is sent without delay.
811 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
812 uint64_t expected_send_time =
813 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000814 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000815}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000816
minyue3a407ee2017-04-03 01:10:33 -0700817TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700818 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
819 kRtpExtensionTransportSequenceNumber,
820 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700821 rtp_sender_->SetStorePacketsStatus(true, 10);
822
823 EXPECT_CALL(send_packet_observer_,
824 OnSendPacket(kTransportSequenceNumber, _, _))
825 .Times(1);
826 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
827 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800828 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
829 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700830
831 SendGenericPayload(); // Packet passed to pacer.
832 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800833 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
834 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800835 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700836 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700837}
838
minyue3a407ee2017-04-03 01:10:33 -0700839TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700840 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
841 kRtpExtensionTransportSequenceNumber,
842 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700843 rtp_sender_->SetStorePacketsStatus(true, 10);
844
845 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
846 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
847 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800848 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
849 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700850
851 SendGenericPayload(); // Packet passed to pacer.
852 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800853 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
854 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800855 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700856 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200857 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700858}
859
minyue3a407ee2017-04-03 01:10:33 -0700860TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700861 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800862 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700863 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800864 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100865 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800866 rtp_sender_->SetSequenceNumber(kSeqNum);
867 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700868 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
869 kRtpExtensionTransportSequenceNumber,
870 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700871 rtp_sender_->SetSequenceNumber(kSeqNum);
872 rtp_sender_->SetStorePacketsStatus(true, 10);
873
874 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800875 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
876 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700877
878 SendGenericPayload(); // Packet passed to pacer.
879 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800880 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
881 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800882 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700883 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700884}
885
minyue3a407ee2017-04-03 01:10:33 -0700886TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000887 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800888 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700889 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800890 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100891 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000892 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800893 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800894 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000895
896 uint16_t seq_num = kSeqNum;
897 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000898 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800899 EXPECT_EQ(
900 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
901 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000902 rtp_header_len += 4; // 4 bytes extension.
903 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
904
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000905 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000906 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000907
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000908 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800909 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
910 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800911 // Expect all packets go through the pacer.
912 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800913 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800914 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200915 EXPECT_CALL(mock_rtc_event_log_,
916 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800917 .Times(kNumPayloadSizes);
918
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000919 // Send 10 packets of increasing size.
920 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
921 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700922 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000923 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800924 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800925 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000926 fake_clock_.AdvanceTimeMilliseconds(33);
927 }
terelius429c3452016-01-21 05:42:04 -0800928
Elad Alon4a87e1c2017-10-03 16:11:34 +0200929 EXPECT_CALL(mock_rtc_event_log_,
930 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800931 .Times(::testing::AtLeast(4));
932
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000933 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700934 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700935 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700936 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800937 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000938
Petter Strandmark26bc6692018-05-29 08:43:35 +0200939 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +0200940 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700941 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200942 .WillOnce(
943 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -0700944 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800945 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200946 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000947
Yves Gerey665174f2018-06-19 15:03:05 +0200948 EXPECT_CALL(transport, SendRtp(_,
949 kPayloadSizes[kNumPayloadSizes - 1] +
950 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -0700951 _))
pbos2d566682015-09-28 09:59:31 -0700952 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200953
954 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -0700955 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +0200956 .WillOnce(
957 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000958 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800959 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200960 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000961}
962
minyue3a407ee2017-04-03 01:10:33 -0700963TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000964 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
965 const uint8_t payload_type = 127;
966 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
967 0, 1500));
968 uint8_t payload[] = {47, 11, 32, 93, 89};
969
970 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700971 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
972 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
973 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000974
danilchap96c15872016-11-21 01:35:29 -0800975 auto sent_payload = transport_.last_sent_packet().payload();
976 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000977 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
978 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800979 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000980
981 // Send delta frame
982 payload[0] = 13;
983 payload[1] = 42;
984 payload[4] = 13;
985
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700986 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
987 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700988 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000989
danilchap96c15872016-11-21 01:35:29 -0800990 sent_payload = transport_.last_sent_packet().payload();
991 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000992 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
993 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800994 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000995}
996
minyue3a407ee2017-04-03 01:10:33 -0700997TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800998 constexpr int kMediaPayloadType = 127;
999 constexpr int kFlexfecPayloadType = 118;
1000 constexpr uint32_t kMediaSsrc = 1234;
1001 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001002 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001003 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001004 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001005 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001006 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001007 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001008
1009 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001010 rtp_sender_.reset(new RTPSender(
1011 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1012 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1013 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001014 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001015 rtp_sender_->SetSSRC(kMediaSsrc);
1016 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001017 rtp_sender_->SetStorePacketsStatus(true, 10);
1018
1019 // Parameters selected to generate a single FEC packet per media packet.
1020 FecProtectionParams params;
1021 params.fec_rate = 15;
1022 params.max_fec_frames = 1;
1023 params.fec_mask_type = kFecMaskRandom;
1024 rtp_sender_->SetFecParameters(params, params);
1025
brandtr9dfff292016-11-14 05:14:50 -08001026 EXPECT_CALL(mock_paced_sender_,
1027 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1028 _, _, false));
1029 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001030 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001031 kFlexfecSsrc, _, _, _, false))
1032 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001033 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001034 EXPECT_CALL(mock_rtc_event_log_,
1035 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1036 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001037 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1038 fake_clock_.TimeInMilliseconds(),
1039 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001040 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1041 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001042 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001043 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001044 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1045 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001046 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001047 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001048 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1049 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1050 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1051 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001052}
1053
ilnik10894992017-06-21 08:23:19 -07001054// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1055// should be removed.
1056TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1057 constexpr int kMediaPayloadType = 127;
1058 constexpr int kFlexfecPayloadType = 118;
1059 constexpr uint32_t kMediaSsrc = 1234;
1060 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001061 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001062 const std::vector<RtpExtension> kNoRtpExtensions;
1063 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001064
ilnik10894992017-06-21 08:23:19 -07001065 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001066 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001067 nullptr /* rtp_state */, &fake_clock_);
1068
1069 // Reset |rtp_sender_| to use FlexFEC.
1070 rtp_sender_.reset(new RTPSender(
1071 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1072 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1073 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001074 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001075 rtp_sender_->SetSSRC(kMediaSsrc);
1076 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001077 rtp_sender_->SetStorePacketsStatus(true, 10);
1078
ilnike4350192017-06-29 02:27:44 -07001079 // Need extension to be registered for timing frames to be sent.
1080 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1081 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1082
ilnik10894992017-06-21 08:23:19 -07001083 // Parameters selected to generate a single FEC packet per media packet.
1084 FecProtectionParams params;
1085 params.fec_rate = 15;
1086 params.max_fec_frames = 1;
1087 params.fec_mask_type = kFecMaskRandom;
1088 rtp_sender_->SetFecParameters(params, params);
1089
1090 EXPECT_CALL(mock_paced_sender_,
1091 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1092 _, _, false));
1093 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1094 kFlexfecSsrc, _, _, _, false))
1095 .Times(0); // Not called because packet should not be protected.
1096
1097 const uint32_t kTimestamp = 1234;
1098 const uint8_t kPayloadType = 127;
1099 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1100 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1101 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1102 0, 1500));
1103 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001104 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001105 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1106 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001107 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1108 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001109
Elad Alon4a87e1c2017-10-03 16:11:34 +02001110 EXPECT_CALL(mock_rtc_event_log_,
1111 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1112 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001113 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1114 fake_clock_.TimeInMilliseconds(),
1115 false, PacedPacketInfo()));
1116 ASSERT_EQ(1, transport_.packets_sent());
1117 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1118 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1119 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1120 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1121
1122 // Now try to send not a timing frame.
1123 uint16_t flexfec_seq_num;
1124 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1125 kFlexfecSsrc, _, _, _, false))
1126 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1127 EXPECT_CALL(mock_paced_sender_,
1128 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1129 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001130 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001131 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1132 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001133 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1134 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001135
Elad Alon4a87e1c2017-10-03 16:11:34 +02001136 EXPECT_CALL(mock_rtc_event_log_,
1137 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1138 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001139 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1140 fake_clock_.TimeInMilliseconds(),
1141 false, PacedPacketInfo()));
1142 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1143 fake_clock_.TimeInMilliseconds(),
1144 false, PacedPacketInfo()));
1145 ASSERT_EQ(3, transport_.packets_sent());
1146 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1147 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1148 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1149 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1150 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1151 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1152 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1153 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1154}
1155
minyue3a407ee2017-04-03 01:10:33 -07001156TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001157 constexpr int kMediaPayloadType = 127;
1158 constexpr int kFlexfecPayloadType = 118;
1159 constexpr uint32_t kMediaSsrc = 1234;
1160 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001161 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001162 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001163 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001164 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001165 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001166 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001167
1168 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001169 rtp_sender_.reset(
1170 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1171 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1172 &mock_rtc_event_log_, &send_packet_observer_,
1173 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001174 rtp_sender_->SetSSRC(kMediaSsrc);
1175 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001176
1177 // Parameters selected to generate a single FEC packet per media packet.
1178 FecProtectionParams params;
1179 params.fec_rate = 15;
1180 params.max_fec_frames = 1;
1181 params.fec_mask_type = kFecMaskRandom;
1182 rtp_sender_->SetFecParameters(params, params);
1183
Elad Alon4a87e1c2017-10-03 16:11:34 +02001184 EXPECT_CALL(mock_rtc_event_log_,
1185 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1186 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001187 SendGenericPayload();
1188 ASSERT_EQ(2, transport_.packets_sent());
1189 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1190 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1191 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1192 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1193 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1194 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1195}
1196
Steve Anton296a0ce2018-03-22 15:17:27 -07001197// Test that the MID header extension is included on sent packets when
1198// configured.
1199TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1200 const char kMid[] = "mid";
1201
1202 // Register MID header extension and set the MID for the RTPSender.
1203 rtp_sender_->SetSendingMediaStatus(false);
1204 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1205 rtp_sender_->SetMid(kMid);
1206 rtp_sender_->SetSendingMediaStatus(true);
1207
1208 // Send a couple packets.
1209 SendGenericPayload();
1210 SendGenericPayload();
1211
1212 // Expect both packets to have the MID set.
1213 ASSERT_EQ(2u, transport_.sent_packets_.size());
1214 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1215 std::string mid;
1216 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1217 EXPECT_EQ(kMid, mid);
1218 }
1219}
1220
minyue3a407ee2017-04-03 01:10:33 -07001221TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001222 constexpr int kFlexfecPayloadType = 118;
1223 constexpr uint32_t kMediaSsrc = 1234;
1224 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001225 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001226 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001227 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001228 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001229 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001230 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001231
1232 // Reset |rtp_sender_| to use FlexFEC.
1233 rtp_sender_.reset(new RTPSender(
1234 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1235 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1236 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001237 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001238 rtp_sender_->SetSSRC(kMediaSsrc);
1239 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001240
1241 // Parameters selected to generate a single FEC packet per media packet.
1242 FecProtectionParams params;
1243 params.fec_rate = 15;
1244 params.max_fec_frames = 1;
1245 params.fec_mask_type = kFecMaskRandom;
1246 rtp_sender_->SetFecParameters(params, params);
1247
1248 constexpr size_t kNumMediaPackets = 10;
1249 constexpr size_t kNumFecPackets = kNumMediaPackets;
1250 constexpr int64_t kTimeBetweenPacketsMs = 10;
1251 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1252 .Times(kNumMediaPackets + kNumFecPackets);
1253 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1254 SendGenericPayload();
1255 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1256 }
1257 constexpr size_t kRtpHeaderLength = 12;
1258 constexpr size_t kFlexfecHeaderLength = 20;
1259 constexpr size_t kGenericCodecHeaderLength = 1;
1260 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1261 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1262 kGenericCodecHeaderLength + kPayloadLength;
1263 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1264 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1265 rtp_sender_->FecOverheadRate(), 500);
1266}
1267
minyue3a407ee2017-04-03 01:10:33 -07001268TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001269 class TestCallback : public FrameCountObserver {
1270 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001271 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001272 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001273
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001274 void FrameCountUpdated(const FrameCounts& frame_counts,
1275 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001276 ++num_calls_;
1277 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001278 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001279 }
1280
1281 uint32_t num_calls_;
1282 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001283 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001284 } callback;
1285
Erik Språng7b52f102018-02-07 14:37:37 +01001286 rtp_sender_.reset(new RTPSender(
1287 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1288 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1289 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001290 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001291 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1292 const uint8_t payload_type = 127;
1293 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1294 0, 1500));
1295 uint8_t payload[] = {47, 11, 32, 93, 89};
1296 rtp_sender_->SetStorePacketsStatus(true, 1);
1297 uint32_t ssrc = rtp_sender_->SSRC();
1298
terelius5d332ac2016-01-14 14:37:39 -08001299 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1300 .Times(::testing::AtLeast(2));
1301
spranga8ae6f22017-09-04 07:23:56 -07001302 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1303 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1304 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001305
1306 EXPECT_EQ(1U, callback.num_calls_);
1307 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001308 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1309 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001310
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001311 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1312 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001313 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001314
1315 EXPECT_EQ(2U, callback.num_calls_);
1316 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001317 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1318 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001319
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001320 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001321}
1322
minyue3a407ee2017-04-03 01:10:33 -07001323TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001324 class TestCallback : public BitrateStatisticsObserver {
1325 public:
sprangcd349d92016-07-13 09:11:28 -07001326 TestCallback()
1327 : BitrateStatisticsObserver(),
1328 num_calls_(0),
1329 ssrc_(0),
1330 total_bitrate_(0),
1331 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001332 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001333
sprangcd349d92016-07-13 09:11:28 -07001334 void Notify(uint32_t total_bitrate,
1335 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001336 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001337 ++num_calls_;
1338 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001339 total_bitrate_ = total_bitrate;
1340 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001341 }
1342
1343 uint32_t num_calls_;
1344 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001345 uint32_t total_bitrate_;
1346 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001347 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001348 rtp_sender_.reset(
1349 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1350 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1351 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001352 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001353
sprangcd349d92016-07-13 09:11:28 -07001354 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1355 // number of packets selected so that we fill (but don't overflow) the one
1356 // second averaging window.
1357 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001358 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001359 const uint32_t kNumPackets =
1360 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001361 // Overhead = 12 bytes RTP header + 1 byte generic header.
1362 const uint32_t kPacketOverhead = 13;
1363
1364 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1365 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001366 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1367 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001368 uint8_t payload[] = {47, 11, 32, 93, 89};
1369 rtp_sender_->SetStorePacketsStatus(true, 1);
1370 uint32_t ssrc = rtp_sender_->SSRC();
1371
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001372 // Initial process call so we get a new time window.
1373 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001374
1375 // Send a few frames.
1376 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001377 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1378 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001379 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001380 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1381 }
1382
1383 rtp_sender_->ProcessBitrate();
1384
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001385 // We get one call for every stats updated, thus two calls since both the
1386 // stream stats and the retransmit stats are updated once.
1387 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001388 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001389 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1390 // Bitrate measured over delta between last and first timestamp, plus one.
1391 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1392 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1393 const uint32_t kExpectedRateBps =
1394 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1395 kExpectedWindowMs;
1396 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001397
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001398 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001399}
1400
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001401class RtpSenderAudioTest : public RtpSenderTest {
1402 protected:
1403 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001404
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001405 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001406 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001407 rtp_sender_.reset(
1408 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1409 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1410 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001411 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001412 rtp_sender_->SetSequenceNumber(kSeqNum);
1413 }
1414};
1415
minyue3a407ee2017-04-03 01:10:33 -07001416TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001417 class TestCallback : public StreamDataCountersCallback {
1418 public:
danilchap162abd32015-12-10 02:39:40 -08001419 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001420 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001421
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001422 void DataCountersUpdated(const StreamDataCounters& counters,
1423 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001424 ssrc_ = ssrc;
1425 counters_ = counters;
1426 }
1427
1428 uint32_t ssrc_;
1429 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001430
1431 void MatchPacketCounter(const RtpPacketCounter& expected,
1432 const RtpPacketCounter& actual) {
1433 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1434 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1435 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1436 EXPECT_EQ(expected.packets, actual.packets);
1437 }
1438
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001439 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1440 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001441 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1442 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001443 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001444 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001445 } callback;
1446
1447 const uint8_t kRedPayloadType = 96;
1448 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001449 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1450 const uint8_t payload_type = 127;
1451 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1452 0, 1500));
1453 uint8_t payload[] = {47, 11, 32, 93, 89};
1454 rtp_sender_->SetStorePacketsStatus(true, 1);
1455 uint32_t ssrc = rtp_sender_->SSRC();
1456
1457 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1458
1459 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001460 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001461 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1462 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001463 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001464 expected.transmitted.payload_bytes = 6;
1465 expected.transmitted.header_bytes = 12;
1466 expected.transmitted.padding_bytes = 0;
1467 expected.transmitted.packets = 1;
1468 expected.retransmitted.payload_bytes = 0;
1469 expected.retransmitted.header_bytes = 0;
1470 expected.retransmitted.padding_bytes = 0;
1471 expected.retransmitted.packets = 0;
1472 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001473 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001474
1475 // Retransmit a frame.
1476 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001477 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001478 expected.transmitted.payload_bytes = 12;
1479 expected.transmitted.header_bytes = 24;
1480 expected.transmitted.packets = 2;
1481 expected.retransmitted.payload_bytes = 6;
1482 expected.retransmitted.header_bytes = 12;
1483 expected.retransmitted.padding_bytes = 0;
1484 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001485 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001486
1487 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001488 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001489 expected.transmitted.payload_bytes = 12;
1490 expected.transmitted.header_bytes = 36;
1491 expected.transmitted.padding_bytes = kMaxPaddingSize;
1492 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001493 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001494
brandtrf1bb4762016-11-07 03:05:06 -08001495 // Send ULPFEC.
1496 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001497 FecProtectionParams fec_params;
1498 fec_params.fec_mask_type = kFecMaskRandom;
1499 fec_params.fec_rate = 1;
1500 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001501 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001502 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001503 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1504 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001505 expected.transmitted.payload_bytes = 40;
1506 expected.transmitted.header_bytes = 60;
1507 expected.transmitted.packets = 5;
1508 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001509 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001510
sprang867fb522015-08-03 04:38:41 -07001511 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001512}
1513
minyue3a407ee2017-04-03 01:10:33 -07001514TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001515 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1516 const uint8_t payload_type = 127;
1517 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1518 0, 1500));
1519 uint8_t payload[] = {47, 11, 32, 93, 89};
1520
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001521 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001522 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1523 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001524
danilchap96c15872016-11-21 01:35:29 -08001525 auto sent_payload = transport_.last_sent_packet().payload();
1526 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001527}
1528
minyue3a407ee2017-04-03 01:10:33 -07001529TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001530 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001531 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1532 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001533
1534 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1535 const uint8_t payload_type = 127;
1536 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1537 0, 1500));
1538 uint8_t payload[] = {47, 11, 32, 93, 89};
1539
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001540 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001541 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1542 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001543
danilchap96c15872016-11-21 01:35:29 -08001544 auto sent_payload = transport_.last_sent_packet().payload();
1545 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001546 // Verify AudioLevel extension.
1547 bool voice_activity;
1548 uint8_t audio_level;
1549 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1550 &voice_activity, &audio_level));
1551 EXPECT_EQ(kAudioLevel, audio_level);
1552 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001553}
1554
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001555// As RFC4733, named telephone events are carried as part of the audio stream
1556// and must use the same sequence number and timestamp base as the regular
1557// audio channel.
1558// This test checks the marker bit for the first packet and the consequent
1559// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001560// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001561TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001562 const char* kDtmfPayloadName = "telephone-event";
1563 const uint32_t kPayloadFrequency = 8000;
1564 const uint8_t kPayloadType = 126;
1565 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1566 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001567 // For Telephone events, payload is not added to the registered payload list,
1568 // it will register only the payload used for audio stream.
1569 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001570 const char* kPayloadName = "payload_name";
1571 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1572 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001573 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1574 // DTMF event key=9, duration=500 and attenuationdB=10
1575 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1576 // During start, it takes the starting timestamp as last sent timestamp.
1577 // The duration is calculated as the difference of current and last sent
1578 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001579 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1580 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1581 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001582 // DTMF Sample Length is (Frequency/1000) * Duration.
1583 // So in this case, it is (8000/1000) * 500 = 4000.
1584 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001585 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001586 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1587 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001588
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001589 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001590 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001591
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001592 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001593 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1594 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001595 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001596 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001597}
1598
minyue3a407ee2017-04-03 01:10:33 -07001599TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001600 const char* kPayloadName = "GENERIC";
1601 const uint8_t kPayloadType = 127;
1602 rtp_sender_->SetSSRC(1234);
1603 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001604 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001605 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001606
danilchap162abd32015-12-10 02:39:40 -08001607 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1608 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001609 uint8_t payload[] = {47, 11, 32, 93, 89};
1610
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001611 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001612 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1613 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001614
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001615 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001616 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1617 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001618
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001619 StreamDataCounters rtp_stats;
1620 StreamDataCounters rtx_stats;
1621 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001622
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001623 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001624 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001625 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1626 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1627 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1628 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1629 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1630 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001631
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001632 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001633 rtp_stats.transmitted.payload_bytes +
1634 rtp_stats.transmitted.header_bytes +
1635 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001636 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001637 rtx_stats.transmitted.payload_bytes +
1638 rtx_stats.transmitted.header_bytes +
1639 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001640
danilchap162abd32015-12-10 02:39:40 -08001641 EXPECT_EQ(
1642 transport_.total_bytes_sent_,
1643 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001644}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001645
minyue3a407ee2017-04-03 01:10:33 -07001646TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001647 const int32_t kPacketSize = 1400;
1648 const int32_t kNumPackets = 30;
1649
sprangcd349d92016-07-13 09:11:28 -07001650 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1651
sprang38778b02015-09-29 09:48:22 -07001652 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001653 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001654 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001655 for (int32_t i = 0; i < kNumPackets; ++i) {
1656 sequence_numbers.push_back(kStartSequenceNumber + i);
1657 fake_clock_.AdvanceTimeMilliseconds(1);
1658 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1659 }
danilchap12ba1862016-10-26 02:41:55 -07001660 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001661
1662 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1663
1664 // Resending should work - brings the bandwidth up to the limit.
1665 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1666 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001667 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001668 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001669
sprangcd349d92016-07-13 09:11:28 -07001670 // Must be at least 5ms in between retransmission attempts.
1671 fake_clock_.AdvanceTimeMilliseconds(5);
1672
sprang38778b02015-09-29 09:48:22 -07001673 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001674 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001675 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001676}
1677
minyue3a407ee2017-04-03 01:10:33 -07001678TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001679 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001680 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1681 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001682
philipel1a4746a2018-07-09 15:52:29 +02001683 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001684 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001685 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001686 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001687 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001688
danilchapc1600c52016-10-26 03:33:11 -07001689 VideoRotation rotation;
1690 EXPECT_TRUE(
1691 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1692 EXPECT_EQ(kVideoRotation_0, rotation);
1693}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001694
ilnik04f4d122017-06-19 07:18:55 -07001695TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1696 uint8_t kFrame[kMaxPacketLength];
1697 const int64_t kPacketizationTimeMs = 100;
1698 const int64_t kEncodeStartDeltaMs = 10;
1699 const int64_t kEncodeFinishDeltaMs = 50;
1700 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1701 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1702
1703 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1704
philipel1a4746a2018-07-09 15:52:29 +02001705 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001706 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001707 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1708 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1709
1710 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001711 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001712 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001713 sizeof(kFrame), nullptr, &hdr,
1714 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001715 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001716 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1717 &timing));
1718 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1719 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1720 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1721}
1722
minyue3a407ee2017-04-03 01:10:33 -07001723TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001724 uint8_t kFrame[kMaxPacketLength];
1725 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1726 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1727
philipel1a4746a2018-07-09 15:52:29 +02001728 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001729 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001730 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001731 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001732 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001733
1734 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001735 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001736 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001737 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001738
1739 VideoRotation rotation;
1740 EXPECT_TRUE(
1741 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1742 EXPECT_EQ(kVideoRotation_0, rotation);
1743}
1744
minyue3a407ee2017-04-03 01:10:33 -07001745TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001746 uint8_t kFrame[kMaxPacketLength];
1747 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1748 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1749
philipel1a4746a2018-07-09 15:52:29 +02001750 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001751 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001752 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001753 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001754 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001755
spranga8ae6f22017-09-04 07:23:56 -07001756 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001757 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001758 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001759
1760 VideoRotation rotation;
1761 EXPECT_TRUE(
1762 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1763 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001764}
magjed71eb61c2016-09-08 03:24:58 -07001765
1766// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1767// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001768TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001769 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1770 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1771 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1772 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1773 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1774 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1775 const int flip_bit = 1 << 2;
1776 const int camera_bit = 1 << 3;
1777 EXPECT_EQ(kVideoRotation_0,
1778 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1779 EXPECT_EQ(kVideoRotation_90,
1780 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1781 EXPECT_EQ(kVideoRotation_180,
1782 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1783 EXPECT_EQ(kVideoRotation_270,
1784 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1785}
1786
spranga8ae6f22017-09-04 07:23:56 -07001787TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1788 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001789 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001790
1791 EXPECT_EQ(kDontRetransmit,
1792 rtp_sender_video_->GetStorageType(
1793 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1794 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1795 header, kRetransmitBaseLayer,
1796 kDefaultExpectedRetransmissionTimeMs));
1797 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1798 header, kRetransmitHigherLayers,
1799 kDefaultExpectedRetransmissionTimeMs));
1800 EXPECT_EQ(kAllowRetransmission,
1801 rtp_sender_video_->GetStorageType(
1802 header, kConditionallyRetransmitHigherLayers,
1803 kDefaultExpectedRetransmissionTimeMs));
1804 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1805 header, kRetransmitAllPackets,
1806 kDefaultExpectedRetransmissionTimeMs));
1807}
1808
1809TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1810 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001811 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1812 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001813 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001814
1815 EXPECT_EQ(kDontRetransmit,
1816 rtp_sender_video_->GetStorageType(
1817 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1818 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1819 header, kRetransmitBaseLayer,
1820 kDefaultExpectedRetransmissionTimeMs));
1821 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1822 header, kRetransmitHigherLayers,
1823 kDefaultExpectedRetransmissionTimeMs));
1824 EXPECT_EQ(kAllowRetransmission,
1825 rtp_sender_video_->GetStorageType(
1826 header, kConditionallyRetransmitHigherLayers,
1827 kDefaultExpectedRetransmissionTimeMs));
1828 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1829 header, kRetransmitAllPackets,
1830 kDefaultExpectedRetransmissionTimeMs));
1831}
1832
1833TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1834 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001835 header.codec = kVideoCodecVP8;
philipel5ab67a52018-07-05 12:27:04 +02001836 header.vp8().temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001837
1838 EXPECT_EQ(kDontRetransmit,
1839 rtp_sender_video_->GetStorageType(
1840 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1841 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1842 header, kRetransmitBaseLayer,
1843 kDefaultExpectedRetransmissionTimeMs));
1844 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1845 header, kRetransmitHigherLayers,
1846 kDefaultExpectedRetransmissionTimeMs));
1847 EXPECT_EQ(kAllowRetransmission,
1848 rtp_sender_video_->GetStorageType(
1849 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1850 kDefaultExpectedRetransmissionTimeMs));
1851 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1852 header, kConditionallyRetransmitHigherLayers,
1853 kDefaultExpectedRetransmissionTimeMs));
1854 EXPECT_EQ(
1855 kAllowRetransmission,
1856 rtp_sender_video_->GetStorageType(
1857 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1858 kDefaultExpectedRetransmissionTimeMs));
1859 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1860 header, kRetransmitAllPackets,
1861 kDefaultExpectedRetransmissionTimeMs));
1862}
1863
1864TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1865 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001866 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001867
1868 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel5ab67a52018-07-05 12:27:04 +02001869 header.vp8().temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001870
1871 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1872 header, kRetransmitOff,
1873 kDefaultExpectedRetransmissionTimeMs));
1874 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1875 header, kRetransmitBaseLayer,
1876 kDefaultExpectedRetransmissionTimeMs));
1877 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1878 header, kRetransmitHigherLayers,
1879 kDefaultExpectedRetransmissionTimeMs));
1880 EXPECT_EQ(kAllowRetransmission,
1881 rtp_sender_video_->GetStorageType(
1882 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1883 kDefaultExpectedRetransmissionTimeMs));
1884 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1885 header, kRetransmitAllPackets,
1886 kDefaultExpectedRetransmissionTimeMs));
1887 }
1888}
1889
1890TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1891 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001892 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07001893
philipel29d88462018-08-08 14:26:00 +02001894 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07001895 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02001896 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07001897
1898 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1899 header, kRetransmitOff,
1900 kDefaultExpectedRetransmissionTimeMs));
1901 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1902 header, kRetransmitBaseLayer,
1903 kDefaultExpectedRetransmissionTimeMs));
1904 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1905 header, kRetransmitHigherLayers,
1906 kDefaultExpectedRetransmissionTimeMs));
1907 EXPECT_EQ(kAllowRetransmission,
1908 rtp_sender_video_->GetStorageType(
1909 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1910 kDefaultExpectedRetransmissionTimeMs));
1911 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1912 header, kRetransmitAllPackets,
1913 kDefaultExpectedRetransmissionTimeMs));
1914 }
1915}
1916
1917TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1918 const int64_t kFrameIntervalMs = 33;
1919 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1920 const uint8_t kSettings =
1921 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1922
1923 // Insert VP8 frames for all temporal layers, but stop before the final index.
1924 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001925 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001926
1927 // Fill averaging window to prevent rounding errors.
1928 constexpr int kNumRepetitions =
1929 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1930 kFrameIntervalMs;
1931 constexpr int kPattern[] = {0, 2, 1, 2};
1932 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
philipel5ab67a52018-07-05 12:27:04 +02001933 header.vp8().temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07001934 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1935 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1936 }
1937
1938 // Since we're at the start of the pattern, the next expected frame in TL0 is
1939 // right now. We will wait at most one expected retransmission time before
1940 // acknowledging that it did not arrive, which means this frame and the next
1941 // will not be retransmitted.
philipel5ab67a52018-07-05 12:27:04 +02001942 header.vp8().temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07001943 EXPECT_EQ(StorageType::kDontRetransmit,
1944 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1945 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1946 EXPECT_EQ(StorageType::kDontRetransmit,
1947 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1948 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1949
1950 // The TL0 frame did not arrive. So allow retransmission.
1951 EXPECT_EQ(StorageType::kAllowRetransmission,
1952 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1953 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1954
1955 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1956 // in three frames away. TL0 is still too far in the past. So, allow
1957 // retransmission.
philipel5ab67a52018-07-05 12:27:04 +02001958 header.vp8().temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07001959 EXPECT_EQ(StorageType::kAllowRetransmission,
1960 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1961 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1962
1963 // Another TL2, next in TL1 is two frames away. Allow again.
1964 EXPECT_EQ(StorageType::kAllowRetransmission,
1965 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1966 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1967
1968 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1969 // for retransmission.
1970 EXPECT_EQ(StorageType::kDontRetransmit,
1971 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1972}
1973
1974TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1975 const int64_t kFrameIntervalMs = 200;
1976 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1977 const int32_t kSettings =
1978 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1979
1980 // Insert VP8 frames for all temporal layers, but stop before the final index.
1981 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001982 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001983
1984 // Fill averaging window to prevent rounding errors.
1985 constexpr int kNumRepetitions =
1986 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1987 kFrameIntervalMs;
1988 constexpr int kPattern[] = {0, 2, 2, 2};
1989 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
philipel5ab67a52018-07-05 12:27:04 +02001990 header.vp8().temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07001991
1992 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1993 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1994 }
1995
1996 // Since we're at the start of the pattern, the next expected frame will be
1997 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1998 // we don't store for retransmission because we expect a frame in a lower
1999 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2000 // so allow retransmission anyway.
philipel5ab67a52018-07-05 12:27:04 +02002001 header.vp8().temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002002 EXPECT_EQ(StorageType::kAllowRetransmission,
2003 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2004}
2005
minyue3a407ee2017-04-03 01:10:33 -07002006TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002007 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002008 rtp_sender_.reset(new RTPSender(
2009 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2010 nullptr, nullptr, nullptr, nullptr, nullptr,
2011 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002012 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002013
michaelt4da30442016-11-17 01:38:43 -08002014 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002015 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002016 SendGenericPayload();
2017
2018 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2019 kTransmissionTimeOffsetExtensionId);
2020
2021 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002022 // 12B + 8B = 20B
2023 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002024 SendGenericPayload();
2025}
2026
minyue3a407ee2017-04-03 01:10:33 -07002027TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002028 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01002029 rtp_sender_.reset(new RTPSender(
2030 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
2031 nullptr, nullptr, nullptr, nullptr, nullptr,
2032 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08002033 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002034
2035 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002036 SendGenericPayload();
2037 SendGenericPayload();
2038}
2039
sprang168794c2017-07-06 04:38:06 -07002040TEST_P(RtpSenderTest, SendsKeepAlive) {
2041 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01002042 rtp_sender_.reset(
2043 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
2044 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
2045 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002046 rtp_sender_->SetSequenceNumber(kSeqNum);
2047 rtp_sender_->SetTimestampOffset(0);
2048 rtp_sender_->SetSSRC(kSsrc);
2049
2050 const uint8_t kKeepalivePayloadType = 20;
2051 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2052
2053 EXPECT_CALL(transport, SendRtp(_, _, _))
2054 .WillOnce(
2055 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2056 const PacketOptions& options) {
2057 webrtc::RTPHeader rtp_header;
2058 RtpUtility::RtpHeaderParser parser(packet, len);
2059 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2060 EXPECT_FALSE(rtp_header.markerBit);
2061 EXPECT_EQ(0U, rtp_header.paddingLength);
2062 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2063 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2064 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2065 EXPECT_EQ(0u, len - rtp_header.headerLength);
2066 return true;
2067 }));
2068
2069 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2070 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2071}
2072
minyue3a407ee2017-04-03 01:10:33 -07002073INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2074 RtpSenderTest,
2075 ::testing::Bool());
2076INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2077 RtpSenderTestWithoutPacer,
2078 ::testing::Bool());
2079INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2080 RtpSenderVideoTest,
2081 ::testing::Bool());
2082INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2083 RtpSenderAudioTest,
2084 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002085} // namespace webrtc