blob: 460e4af143b418b07b440ed456340d6f77e00fac [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Ryan Cui9b651632011-05-11 11:38:58 -070016import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070017import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080018import functools
Dale Curtis2975c432011-05-03 17:25:20 -070019import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070020import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070021import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070022import sys
Peter Ammon811f6702014-06-12 15:45:38 -070023import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080024import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070025
Ryan Cui1562fb82011-05-09 11:01:31 -070026from errors import (VerifyException, HookFailure, PrintErrorForProject,
27 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070028
Mike Frysinger6850d512018-05-21 12:12:14 -040029# If repo imports us, the __name__ will be __builtin__, and the cwd will be in
30# the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be in
31# that directory, so add it to our path. This works whether we're running the
32# repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a completely
33# different tree.
34if __name__ == '__builtin__':
35 sys.path.insert(0, os.getcwd())
36
37# If we're run directly, we'll find chromite relative to the repohooks dir in
38# $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
39if __name__ == '__main__':
David Jamesc3b68b32013-04-03 09:17:03 -070040 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
41
Mike Frysinger66142932014-12-18 14:55:57 -050042from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080043from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070044from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050045from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070046from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070047from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040048from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070049
Vadim Bendebury2b62d742014-06-22 13:14:51 -070050PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070051
52COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050053 # C++ and friends
54 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
55 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
56 # Scripts
57 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
58 # No extension at all, note that ALL CAPS files are black listed in
59 # COMMON_EXCLUDED_LIST below.
60 r"(^|.*[\\\/])[^.]+$",
61 # Other
62 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070063 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070064]
65
Ryan Cui1562fb82011-05-09 11:01:31 -070066
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050069 r".*/Manifest$",
70 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070071
Daniel Erate3ea3fc2015-02-13 15:27:52 -070072 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040073 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040074 r"^profiles/.*$",
75
C Shapiro8f90e9b2017-06-28 09:54:50 -060076 # Ignore config files in ebuild setup.
77 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
78 r"^chromeos-base/chromeos-bsp.*/files/.*",
79
Daniel Erate3ea3fc2015-02-13 15:27:52 -070080 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050081 r".*\.min\.js",
82 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050083
84 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070085 r".*/licenses/.*",
Alex Klein619c0912019-01-30 17:13:23 -070086
87 # Exclude generated python protobuf files.
88 r".*_pb2\.py$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070089]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070090
Ken Turnerd07564b2018-02-08 17:57:59 +110091LICENSE_EXCLUDED_PATHS = [
92 r".*/OWNERS$",
93]
Ryan Cui1562fb82011-05-09 11:01:31 -070094
Ryan Cui9b651632011-05-11 11:38:58 -070095_CONFIG_FILE = 'PRESUBMIT.cfg'
96
97
Daniel Erate3ea3fc2015-02-13 15:27:52 -070098# File containing wildcards, one per line, matching files that should be
99# excluded from presubmit checks. Lines beginning with '#' are ignored.
100_IGNORE_FILE = '.presubmitignore'
101
102
Doug Anderson44a644f2011-11-02 10:37:37 -0700103# Exceptions
104
105
106class BadInvocation(Exception):
107 """An Exception indicating a bad invocation of the program."""
108 pass
109
110
Ryan Cui1562fb82011-05-09 11:01:31 -0700111# General Helpers
112
Sean Paulba01d402011-05-05 11:36:23 -0400113
Alex Deymo643ac4c2015-09-03 10:40:50 -0700114Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
115
116
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700117# pylint: disable=redefined-builtin
118def _run_command(cmd, cwd=None, input=None,
119 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700120 """Executes the passed in command and returns raw stdout output.
121
122 Args:
123 cmd: The command to run; should be a list of strings.
124 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700125 input: The data to pipe into this command through stdin. If a file object
126 or file descriptor, stdin will be connected directly to that.
127 redirect_stderr: Redirect stderr away from console.
128 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700129
130 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700131 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700132 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700133 return cros_build_lib.RunCommand(cmd=cmd,
134 cwd=cwd,
135 print_cmd=False,
136 input=input,
137 stdout_to_pipe=True,
138 redirect_stderr=redirect_stderr,
139 combine_stdout_stderr=combine_stdout_stderr,
140 error_code_ok=True).output
141# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700142
Ryan Cui1562fb82011-05-09 11:01:31 -0700143
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700144def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700145 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700146 if __name__ == '__main__':
147 # Works when file is run on its own (__file__ is defined)...
148 return os.path.abspath(os.path.dirname(__file__))
149 else:
150 # We need to do this when we're run through repo. Since repo executes
151 # us with execfile(), we don't get __file__ defined.
152 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
153 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700154
Ryan Cui1562fb82011-05-09 11:01:31 -0700155
Ryan Cuiec4d6332011-05-02 14:15:25 -0700156def _match_regex_list(subject, expressions):
157 """Try to match a list of regular expressions to a string.
158
159 Args:
160 subject: The string to match regexes on
161 expressions: A list of regular expressions to check for matches with.
162
163 Returns:
164 Whether the passed in subject matches any of the passed in regexes.
165 """
166 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500167 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700168 return True
169 return False
170
Ryan Cui1562fb82011-05-09 11:01:31 -0700171
Mike Frysingerae409522014-02-01 03:16:11 -0500172def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700173 """Filter out files based on the conditions passed in.
174
175 Args:
176 files: list of filepaths to filter
177 include_list: list of regex that when matched with a file path will cause it
178 to be added to the output list unless the file is also matched with a
179 regex in the exclude_list.
180 exclude_list: list of regex that when matched with a file will prevent it
181 from being added to the output list, even if it is also matched with a
182 regex in the include_list.
183
184 Returns:
185 A list of filepaths that contain files matched in the include_list and not
186 in the exclude_list.
187 """
188 filtered = []
189 for f in files:
190 if (_match_regex_list(f, include_list) and
191 not _match_regex_list(f, exclude_list)):
192 filtered.append(f)
193 return filtered
194
Ryan Cuiec4d6332011-05-02 14:15:25 -0700195
196# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
198
Ryan Cui4725d952011-05-05 15:41:19 -0700199def _get_upstream_branch():
200 """Returns the upstream tracking branch of the current branch.
201
202 Raises:
203 Error if there is no tracking branch
204 """
205 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
206 current_branch = current_branch.replace('refs/heads/', '')
207 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700208 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700209
210 cfg_option = 'branch.' + current_branch + '.%s'
211 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
212 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
213 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700214 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700215
216 return full_upstream.replace('heads', 'remotes/' + remote)
217
Ryan Cui1562fb82011-05-09 11:01:31 -0700218
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700219def _get_patch(commit):
220 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700221 if commit == PRE_SUBMIT:
222 return _run_command(['git', 'diff', '--cached', 'HEAD'])
223 else:
224 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700225
Ryan Cui1562fb82011-05-09 11:01:31 -0700226
Jon Salz98255932012-08-18 14:48:02 +0800227def _try_utf8_decode(data):
228 """Attempts to decode a string as UTF-8.
229
230 Returns:
231 The decoded Unicode object, or the original string if parsing fails.
232 """
233 try:
234 return unicode(data, 'utf-8', 'strict')
235 except UnicodeDecodeError:
236 return data
237
238
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500239def _get_file_content(path, commit):
240 """Returns the content of a file at a specific commit.
241
242 We can't rely on the file as it exists in the filesystem as people might be
243 uploading a series of changes which modifies the file multiple times.
244
245 Note: The "content" of a symlink is just the target. So if you're expecting
246 a full file, you should check that first. One way to detect is that the
247 content will not have any newlines.
248 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700249 if commit == PRE_SUBMIT:
250 return _run_command(['git', 'diff', 'HEAD', path])
251 else:
Mike Frysingerd0523442018-01-03 17:05:29 -0500252 # Make sure people don't accidentally pass in full paths which will never
253 # work. You need to use relative=True with _get_affected_files.
254 if path.startswith('/'):
255 raise ValueError('_get_file_content must be called with relative paths: '
256 + path)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700257 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500258
259
Mike Frysingerae409522014-02-01 03:16:11 -0500260def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700261 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700262 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800263 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
264 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700265 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800266 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
267 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700268 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700269
270 new_lines = []
271 line_num = 0
272 for line in output.splitlines():
273 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
274 if m:
275 line_num = int(m.groups(1)[0])
276 continue
277 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800278 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700279 if not line.startswith('-'):
280 line_num += 1
281 return new_lines
282
Ryan Cui1562fb82011-05-09 11:01:31 -0700283
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700284def _get_ignore_wildcards(directory, cache):
285 """Get wildcards listed in a directory's _IGNORE_FILE.
286
287 Args:
288 directory: A string containing a directory path.
289 cache: A dictionary (opaque to caller) caching previously-read wildcards.
290
291 Returns:
292 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
293 wasn't present.
294 """
295 # In the cache, keys are directories and values are lists of wildcards from
296 # _IGNORE_FILE within those directories (and empty if no file was present).
297 if directory not in cache:
298 wildcards = []
299 dotfile_path = os.path.join(directory, _IGNORE_FILE)
300 if os.path.exists(dotfile_path):
301 # TODO(derat): Consider using _get_file_content() to get the file as of
302 # this commit instead of the on-disk version. This may have a noticeable
303 # performance impact, as each call to _get_file_content() runs git.
304 with open(dotfile_path, 'r') as dotfile:
305 for line in dotfile.readlines():
306 line = line.strip()
307 if line.startswith('#'):
308 continue
309 if line.endswith('/'):
310 line += '*'
311 wildcards.append(line)
312 cache[directory] = wildcards
313
314 return cache[directory]
315
316
317def _path_is_ignored(path, cache):
318 """Check whether a path is ignored by _IGNORE_FILE.
319
320 Args:
321 path: A string containing a path.
322 cache: A dictionary (opaque to caller) caching previously-read wildcards.
323
324 Returns:
325 True if a file named _IGNORE_FILE in one of the passed-in path's parent
326 directories contains a wildcard matching the path.
327 """
328 # Skip ignore files.
329 if os.path.basename(path) == _IGNORE_FILE:
330 return True
331
332 path = os.path.abspath(path)
333 base = os.getcwd()
334
335 prefix = os.path.dirname(path)
336 while prefix.startswith(base):
337 rel_path = path[len(prefix) + 1:]
338 for wildcard in _get_ignore_wildcards(prefix, cache):
339 if fnmatch.fnmatch(rel_path, wildcard):
340 return True
341 prefix = os.path.dirname(prefix)
342
343 return False
344
345
Mike Frysinger292b45d2014-11-25 01:17:10 -0500346def _get_affected_files(commit, include_deletes=False, relative=False,
347 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700348 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700349 """Returns list of file paths that were modified/added, excluding symlinks.
350
351 Args:
352 commit: The commit
353 include_deletes: If true, we'll include deleted files in the result
354 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500355 include_symlinks: If true, we'll include symlinks in the result
356 include_adds: If true, we'll include new files in the result
357 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700358 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700359
360 Returns:
361 A list of modified/added (and perhaps deleted) files
362 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500363 if not relative and full_details:
364 raise ValueError('full_details only supports relative paths currently')
365
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700366 if commit == PRE_SUBMIT:
367 return _run_command(['git', 'diff-index', '--cached',
368 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500369
370 path = os.getcwd()
371 files = git.RawDiff(path, '%s^!' % commit)
372
373 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374 if not include_symlinks:
375 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500376
377 if not include_deletes:
378 files = [x for x in files if x.status != 'D']
379
Mike Frysinger292b45d2014-11-25 01:17:10 -0500380 if not include_adds:
381 files = [x for x in files if x.status != 'A']
382
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700383 if use_ignore_files:
384 cache = {}
385 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
386 files = [x for x in files if not is_ignored(x)]
387
Mike Frysinger292b45d2014-11-25 01:17:10 -0500388 if full_details:
389 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500390 return files
391 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500392 # Caller only cares about filenames.
393 files = [x.dst_file if x.dst_file else x.src_file for x in files]
394 if relative:
395 return files
396 else:
397 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700398
399
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700400def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700401 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700402 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700403 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700404
Ryan Cui1562fb82011-05-09 11:01:31 -0700405
Ryan Cuiec4d6332011-05-02 14:15:25 -0700406def _get_commit_desc(commit):
407 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700408 if commit == PRE_SUBMIT:
409 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400410 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700411
412
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800413def _check_lines_in_diff(commit, files, check_callable, error_description):
414 """Checks given file for errors via the given check.
415
416 This is a convenience function for common per-line checks. It goes through all
417 files and returns a HookFailure with the error description listing all the
418 failures.
419
420 Args:
421 commit: The commit we're working on.
422 files: The files to check.
423 check_callable: A callable that takes a line and returns True if this line
424 _fails_ the check.
425 error_description: A string describing the error.
426 """
427 errors = []
428 for afile in files:
429 for line_num, line in _get_file_diff(afile, commit):
430 if check_callable(line):
431 errors.append('%s, line %s' % (afile, line_num))
432 if errors:
433 return HookFailure(error_description, errors)
434
435
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900436def _parse_common_inclusion_options(options):
437 """Parses common hook options for including/excluding files.
438
439 Args:
440 options: Option string list.
441
442 Returns:
443 (included, excluded) where each one is a list of regex strings.
444 """
445 parser = argparse.ArgumentParser()
446 parser.add_argument('--exclude_regex', action='append')
447 parser.add_argument('--include_regex', action='append')
448 opts = parser.parse_args(options)
449 included = opts.include_regex or []
450 excluded = opts.exclude_regex or []
451 return included, excluded
452
453
Ryan Cuiec4d6332011-05-02 14:15:25 -0700454# Common Hooks
455
Ryan Cui1562fb82011-05-09 11:01:31 -0700456
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900457def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500458 """Checks there are no lines longer than MAX_LEN in any of the text files."""
459
Ryan Cuiec4d6332011-05-02 14:15:25 -0700460 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800461 SKIP_REGEXP = re.compile('|'.join([
462 r'https?://',
Maksim Ivanov3f677b92018-06-05 16:10:24 +0200463 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700464
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900465 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700466 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900467 included + COMMON_INCLUDED_PATHS,
468 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700469
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900470 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700471 for afile in files:
472 for line_num, line in _get_file_diff(afile, commit):
473 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500474 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800475 continue
476
477 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
478 if len(errors) == 5: # Just show the first 5 errors.
479 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700480
481 if errors:
482 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700483 return HookFailure(msg, errors)
484
Ryan Cuiec4d6332011-05-02 14:15:25 -0700485
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900486def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700487 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900488 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700489 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900490 included + COMMON_INCLUDED_PATHS,
491 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800492 return _check_lines_in_diff(commit, files,
493 lambda line: line.rstrip() != line,
494 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700495
Ryan Cuiec4d6332011-05-02 14:15:25 -0700496
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700498 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400499 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
500 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700501 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700502 r".*\.ebuild$",
503 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500504 r".*/[M|m]akefile$",
505 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700506 ]
507
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900508 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700509 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900510 included + COMMON_INCLUDED_PATHS,
511 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800512 return _check_lines_in_diff(commit, files,
513 lambda line: '\t' in line,
514 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800516
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900517def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800518 """Checks that indents use tabs only."""
519 TABS_REQUIRED_PATHS = [
520 r".*\.ebuild$",
521 r".*\.eclass$",
522 ]
523 LEADING_SPACE_RE = re.compile('[\t]* ')
524
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900525 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800526 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900527 included + TABS_REQUIRED_PATHS,
528 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800529 return _check_lines_in_diff(
530 commit, files,
531 lambda line: LEADING_SPACE_RE.match(line) is not None,
532 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700533
Ryan Cuiec4d6332011-05-02 14:15:25 -0700534
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700535def _check_gofmt(_project, commit):
536 """Checks that Go files are formatted with gofmt."""
537 errors = []
538 files = _filter_files(_get_affected_files(commit, relative=True),
539 [r'\.go$'])
540
541 for gofile in files:
542 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700543 output = _run_command(cmd=['gofmt', '-l'], input=contents,
544 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700545 if output:
546 errors.append(gofile)
547 if errors:
548 return HookFailure('Files not formatted with gofmt:', errors)
549
550
Mike Frysingerae409522014-02-01 03:16:11 -0500551def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700553 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700555 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700556 msg = 'Changelist description needs TEST field (after first line)'
557 return HookFailure(msg)
558
Ryan Cuiec4d6332011-05-02 14:15:25 -0700559
Mike Frysingerae409522014-02-01 03:16:11 -0500560def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700561 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
562 msg = 'Changelist has invalid CQ-DEPEND target.'
563 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
564 try:
565 patch.GetPaladinDeps(_get_commit_desc(commit))
566 except ValueError as ex:
567 return HookFailure(msg, [example, str(ex)])
568
569
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800570def _check_change_is_contribution(_project, commit):
571 """Check that the change is a contribution."""
572 NO_CONTRIB = 'not a contribution'
573 if NO_CONTRIB in _get_commit_desc(commit).lower():
574 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
575 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
576 return HookFailure(msg)
577
578
Alex Deymo643ac4c2015-09-03 10:40:50 -0700579def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700580 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700581 OLD_BUG_RE = r'\nBUG=.*chromium-os'
582 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
583 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
584 'the chromium tracker in your BUG= line now.')
585 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700586
Alex Deymo643ac4c2015-09-03 10:40:50 -0700587 # Android internal and external projects use "Bug: " to track bugs in
588 # buganizer.
589 BUG_COLON_REMOTES = (
590 'aosp',
591 'goog',
592 )
593 if project.remote in BUG_COLON_REMOTES:
594 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
595 if not re.search(BUG_RE, _get_commit_desc(commit)):
596 msg = ('Changelist description needs BUG field (after first line):\n'
597 'Bug: 9999 (for buganizer)\n'
598 'BUG=None')
599 return HookFailure(msg)
600 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400601 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700602 if not re.search(BUG_RE, _get_commit_desc(commit)):
603 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700604 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700605 'BUG=b:9999 (for buganizer)\n'
606 'BUG=None')
607 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700608
Ryan Cuiec4d6332011-05-02 14:15:25 -0700609
Mike Frysinger292b45d2014-11-25 01:17:10 -0500610def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700611 """Check that we're not missing a revbump of an ebuild in the given commit.
612
613 If the given commit touches files in a directory that has ebuilds somewhere
614 up the directory hierarchy, it's very likely that we need an ebuild revbump
615 in order for those changes to take effect.
616
617 It's not totally trivial to detect a revbump, so at least detect that an
618 ebuild with a revision number in it was touched. This should handle the
619 common case where we use a symlink to do the revbump.
620
621 TODO: it would be nice to enhance this hook to:
622 * Handle cases where people revbump with a slightly different syntax. I see
623 one ebuild (puppy) that revbumps with _pN. This is a false positive.
624 * Catches cases where people aren't using symlinks for revbumps. If they
625 edit a revisioned file directly (and are expected to rename it for revbump)
626 we'll miss that. Perhaps we could detect that the file touched is a
627 symlink?
628
629 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
630 still better off than without this check.
631
632 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700633 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700634 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500635 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700636
637 Returns:
638 A HookFailure or None.
639 """
Mike Frysinger011af942014-01-17 16:12:22 -0500640 # If this is the portage-stable overlay, then ignore the check. It's rare
641 # that we're doing anything other than importing files from upstream, so
642 # forcing a rev bump makes no sense.
643 whitelist = (
644 'chromiumos/overlays/portage-stable',
645 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700646 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500647 return None
648
Mike Frysinger292b45d2014-11-25 01:17:10 -0500649 def FinalName(obj):
650 # If the file is being deleted, then the dst_file is not set.
651 if obj.dst_file is None:
652 return obj.src_file
653 else:
654 return obj.dst_file
655
656 affected_path_objs = _get_affected_files(
657 commit, include_deletes=True, include_symlinks=True, relative=True,
658 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700659
660 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700661 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500662 affected_path_objs = [x for x in affected_path_objs
663 if os.path.basename(FinalName(x)) not in whitelist]
664 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700665 return None
666
667 # If we've touched any file named with a -rN.ebuild then we'll say we're
668 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500669 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
670 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700671 if touched_revved_ebuild:
672 return None
673
Mike Frysinger292b45d2014-11-25 01:17:10 -0500674 # If we're creating new ebuilds from scratch, then we don't need an uprev.
675 # Find all the dirs that new ebuilds and ignore their files/.
676 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
677 if FinalName(x).endswith('.ebuild') and x.status == 'A']
678 affected_path_objs = [obj for obj in affected_path_objs
679 if not any(FinalName(obj).startswith(x)
680 for x in ebuild_dirs)]
681 if not affected_path_objs:
682 return
683
Doug Anderson42b8a052013-06-26 10:45:36 -0700684 # We want to examine the current contents of all directories that are parents
685 # of files that were touched (up to the top of the project).
686 #
687 # ...note: we use the current directory contents even though it may have
688 # changed since the commit we're looking at. This is just a heuristic after
689 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500690 if project_top is None:
691 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700692 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500693 for obj in affected_path_objs:
694 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700695 while os.path.exists(path) and not os.path.samefile(path, project_top):
696 dirs_to_check.add(path)
697 path = os.path.dirname(path)
698
699 # Look through each directory. If it's got an ebuild in it then we'll
700 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800701 affected_paths = set(os.path.join(project_top, FinalName(x))
702 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700703 for dir_path in dirs_to_check:
704 contents = os.listdir(dir_path)
705 ebuilds = [os.path.join(dir_path, path)
706 for path in contents if path.endswith('.ebuild')]
707 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
708
C Shapiroae157ae2017-09-18 16:24:03 -0600709 affected_paths_under_9999_ebuilds = set()
710 for affected_path in affected_paths:
711 for ebuild_9999 in ebuilds_9999:
712 ebuild_dir = os.path.dirname(ebuild_9999)
713 if affected_path.startswith(ebuild_dir):
714 affected_paths_under_9999_ebuilds.add(affected_path)
715
716 # If every file changed exists under a 9999 ebuild, then skip
717 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
718 continue
719
Doug Anderson42b8a052013-06-26 10:45:36 -0700720 # If the -9999.ebuild file was touched the bot will uprev for us.
721 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500722 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700723 continue
724
725 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500726 return HookFailure('Changelist probably needs a revbump of an ebuild, '
727 'or a -r1.ebuild symlink if this is a new ebuild:\n'
728 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700729
730 return None
731
732
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500733def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500734 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500735
736 We want to get away from older EAPI's as it makes life confusing and they
737 have less builtin error checking.
738
739 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700740 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500741 commit: The commit to look at
742
743 Returns:
744 A HookFailure or None.
745 """
746 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500747 # that we're doing anything other than importing files from upstream, and
748 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500749 whitelist = (
750 'chromiumos/overlays/portage-stable',
751 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700752 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500753 return None
754
Mike Frysinger948284a2018-02-01 15:22:56 -0500755 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500756
757 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
758
759 ebuilds_re = [r'\.ebuild$']
760 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
761 ebuilds_re)
762 bad_ebuilds = []
763
764 for ebuild in ebuilds:
765 # If the ebuild does not specify an EAPI, it defaults to 0.
766 eapi = '0'
767
768 lines = _get_file_content(ebuild, commit).splitlines()
769 if len(lines) == 1:
770 # This is most likely a symlink, so skip it entirely.
771 continue
772
773 for line in lines:
774 m = get_eapi.match(line)
775 if m:
776 # Once we hit the first EAPI line in this ebuild, stop processing.
777 # The spec requires that there only be one and it be first, so
778 # checking all possible values is pointless. We also assume that
779 # it's "the" EAPI line and not something in the middle of a heredoc.
780 eapi = m.group(1)
781 break
782
783 if eapi in BAD_EAPIS:
784 bad_ebuilds.append((ebuild, eapi))
785
786 if bad_ebuilds:
787 # pylint: disable=C0301
788 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
789 # pylint: enable=C0301
790 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500791 'These ebuilds are using old EAPIs. If these are imported from\n'
792 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500793 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500794 '\t%s\n'
795 'See this guide for more details:\n%s\n' %
796 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
797
798
Mike Frysinger89bdb852014-02-01 05:26:26 -0500799def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500800 """Make sure we use the new style KEYWORDS when possible in ebuilds.
801
802 If an ebuild generally does not care about the arch it is running on, then
803 ebuilds should flag it with one of:
804 KEYWORDS="*" # A stable ebuild.
805 KEYWORDS="~*" # An unstable ebuild.
806 KEYWORDS="-* ..." # Is known to only work on specific arches.
807
808 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700809 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500810 commit: The commit to look at
811
812 Returns:
813 A HookFailure or None.
814 """
815 WHITELIST = set(('*', '-*', '~*'))
816
817 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
818
Mike Frysinger89bdb852014-02-01 05:26:26 -0500819 ebuilds_re = [r'\.ebuild$']
820 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
821 ebuilds_re)
822
Mike Frysinger8d42d742014-09-22 15:50:21 -0400823 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500824 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400825 # We get the full content rather than a diff as the latter does not work
826 # on new files (like when adding new ebuilds).
827 lines = _get_file_content(ebuild, commit).splitlines()
828 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500829 m = get_keywords.match(line)
830 if m:
831 keywords = set(m.group(1).split())
832 if not keywords or WHITELIST - keywords != WHITELIST:
833 continue
834
Mike Frysinger8d42d742014-09-22 15:50:21 -0400835 bad_ebuilds.append(ebuild)
836
837 if bad_ebuilds:
838 return HookFailure(
839 '%s\n'
840 'Please update KEYWORDS to use a glob:\n'
841 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
842 ' KEYWORDS="*"\n'
843 'If the ebuild should be marked unstable (normal for '
844 'cros-workon / 9999 ebuilds):\n'
845 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400846 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400847 'then use -* like so:\n'
848 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500849
850
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800851def _check_ebuild_licenses(_project, commit):
852 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800853 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800854 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
855
856 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800857 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800858
859 for ebuild in touched_ebuilds:
860 # Skip virutal packages.
861 if ebuild.split('/')[-3] == 'virtual':
862 continue
863
Alex Kleinb5953522018-08-03 11:44:21 -0600864 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
865 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
866
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800867 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800868 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -0600869 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
870 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800871 except ValueError as e:
872 return HookFailure(e.message, [ebuild])
873
874 # Also ignore licenses ending with '?'
875 for license_type in [x for x in license_types
876 if x not in LICENSES_IGNORE and not x.endswith('?')]:
877 try:
Alex Kleinb5953522018-08-03 11:44:21 -0600878 licenses_lib.Licensing.FindLicenseType(license_type,
879 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800880 except AssertionError as e:
881 return HookFailure(e.message, [ebuild])
882
883
Mike Frysingercd363c82014-02-01 05:20:18 -0500884def _check_ebuild_virtual_pv(project, commit):
885 """Enforce the virtual PV policies."""
886 # If this is the portage-stable overlay, then ignore the check.
887 # We want to import virtuals as-is from upstream Gentoo.
888 whitelist = (
889 'chromiumos/overlays/portage-stable',
890 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700891 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500892 return None
893
894 # We assume the repo name is the same as the dir name on disk.
895 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700896 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500897
898 is_variant = lambda x: x.startswith('overlay-variant-')
899 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700900 is_baseboard = lambda x: x.startswith('baseboard-')
901 is_chipset = lambda x: x.startswith('chipset-')
902 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -0500903 is_private = lambda x: x.endswith('-private')
904
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700905 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
906 is_baseboard(x) or is_project(x))
907
Mike Frysingercd363c82014-02-01 05:20:18 -0500908 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
909
910 ebuilds_re = [r'\.ebuild$']
911 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
912 ebuilds_re)
913 bad_ebuilds = []
914
915 for ebuild in ebuilds:
916 m = get_pv.match(ebuild)
917 if m:
918 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700919 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700920 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500921
922 pv = m.group(3).split('-', 1)[0]
923
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800924 # Virtual versions >= 4 are special cases used above the standard
925 # versioning structure, e.g. if one has a board inheriting a board.
926 if float(pv) >= 4:
927 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -0500928 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700929 if is_private(overlay):
930 want_pv = '3.5' if is_variant(overlay) else '3'
931 elif is_board(overlay):
932 want_pv = '2.5' if is_variant(overlay) else '2'
933 elif is_baseboard(overlay):
934 want_pv = '1.9'
935 elif is_chipset(overlay):
936 want_pv = '1.8'
937 elif is_project(overlay):
938 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -0500939 else:
940 want_pv = '1'
941
942 if pv != want_pv:
943 bad_ebuilds.append((ebuild, pv, want_pv))
944
945 if bad_ebuilds:
946 # pylint: disable=C0301
947 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
948 # pylint: enable=C0301
949 return HookFailure(
950 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
951 '\t%s\n'
952 'If this is an upstream Gentoo virtual, then you may ignore this\n'
953 'check (and re-run w/--no-verify). Otherwise, please see this\n'
954 'page for more details:\n%s\n' %
955 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
956 for x in bad_ebuilds]), url))
957
958
Daniel Erat9d203ff2015-02-17 10:12:21 -0700959def _check_portage_make_use_var(_project, commit):
960 """Verify that $USE is set correctly in make.conf and make.defaults."""
961 files = _filter_files(_get_affected_files(commit, relative=True),
962 [r'(^|/)make.(conf|defaults)$'])
963
964 errors = []
965 for path in files:
966 basename = os.path.basename(path)
967
968 # Has a USE= line already been encountered in this file?
969 saw_use = False
970
971 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
972 if not line.startswith('USE='):
973 continue
974
975 preserves_use = '${USE}' in line or '$USE' in line
976
977 if (basename == 'make.conf' or
978 (basename == 'make.defaults' and saw_use)) and not preserves_use:
979 errors.append('%s:%d: missing ${USE}' % (path, i))
980 elif basename == 'make.defaults' and not saw_use and preserves_use:
981 errors.append('%s:%d: ${USE} referenced in initial declaration' %
982 (path, i))
983
984 saw_use = True
985
986 if errors:
987 return HookFailure(
988 'One or more Portage make files appear to set USE incorrectly.\n'
989 '\n'
990 'All USE assignments in make.conf and all assignments after the\n'
991 'initial declaration in make.defaults should contain "${USE}" to\n'
992 'preserve previously-set flags.\n'
993 '\n'
994 'The initial USE declaration in make.defaults should not contain\n'
995 '"${USE}".\n',
996 errors)
997
998
Mike Frysingerae409522014-02-01 03:16:11 -0500999def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001000 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001001 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001002 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001003 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001004 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001005 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001006
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001007 # S-o-b tags always allowed to follow Change-ID.
1008 allowed_tags = ['Signed-off-by']
1009
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001010 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001011 cherry_pick_marker = 'cherry picked from commit'
1012
1013 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001014 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001015 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1016 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001017 end = end[:-1]
1018
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001019 # Note that descriptions could have multiple cherry pick markers.
1020 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001021
1022 if [x for x in end if not re.search(tag_search, x)]:
1023 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1024 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001025
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001026
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001027def _check_commit_message_style(_project, commit):
1028 """Verify that the commit message matches our style.
1029
1030 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1031 commit hooks.
1032 """
1033 desc = _get_commit_desc(commit)
1034
1035 # The first line should be by itself.
1036 lines = desc.splitlines()
1037 if len(lines) > 1 and lines[1]:
1038 return HookFailure('The second line of the commit message must be blank.')
1039
1040 # The first line should be one sentence.
1041 if '. ' in lines[0]:
1042 return HookFailure('The first line cannot be more than one sentence.')
1043
1044 # The first line cannot be too long.
1045 MAX_FIRST_LINE_LEN = 100
1046 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1047 return HookFailure('The first line must be less than %i chars.' %
1048 MAX_FIRST_LINE_LEN)
1049
1050
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001051def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001052 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001053
Mike Frysinger98638102014-08-28 00:15:08 -04001054 Should be following the spec:
1055 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1056 """
1057 # For older years, be a bit more flexible as our policy says leave them be.
1058 LICENSE_HEADER = (
Brian Norris68838dd2018-09-26 18:30:24 -07001059 r'.*Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001060 r'All rights reserved\.' r'\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001061 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001062 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001063 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001064 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001065 )
1066 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1067
1068 # For newer years, be stricter.
1069 COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001070 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001071 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001072 )
1073 copyright_re = re.compile(COPYRIGHT_LINE)
1074
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001075 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001076
Mike Frysinger98638102014-08-28 00:15:08 -04001077 bad_files = []
1078 bad_copyright_files = []
Ken Turnerd07564b2018-02-08 17:57:59 +11001079 files = _filter_files(
1080 _get_affected_files(commit, relative=True),
1081 included + COMMON_INCLUDED_PATHS,
1082 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001083
1084 for f in files:
1085 contents = _get_file_content(f, commit)
1086 if not contents:
1087 # Ignore empty files.
1088 continue
1089
1090 if not license_re.search(contents):
1091 bad_files.append(f)
1092 elif copyright_re.search(contents):
1093 bad_copyright_files.append(f)
1094
1095 if bad_files:
1096 msg = '%s:\n%s\n%s' % (
1097 'License must match', license_re.pattern,
1098 'Found a bad header in these files:')
1099 return HookFailure(msg, bad_files)
1100
1101 if bad_copyright_files:
1102 msg = 'Do not use (c) in copyright headers in new files:'
1103 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001104
1105
Amin Hassani391efa92018-01-26 17:58:05 -08001106def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001107 """Verifies the AOSP license/copyright header.
1108
1109 AOSP uses the Apache2 License:
1110 https://source.android.com/source/licenses.html
1111 """
1112 LICENSE_HEADER = (
1113 r"""^[#/\*]*
1114[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1115[#/\*]* ?
1116[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1117[#/\*]* ?you may not use this file except in compliance with the License\.
1118[#/\*]* ?You may obtain a copy of the License at
1119[#/\*]* ?
1120[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1121[#/\*]* ?
1122[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1123[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1124[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1125 r"""implied\.
1126[#/\*]* ?See the License for the specific language governing permissions and
1127[#/\*]* ?limitations under the License\.
1128[#/\*]*$
1129"""
1130 )
1131 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1132
Amin Hassani391efa92018-01-26 17:58:05 -08001133 included, excluded = _parse_common_inclusion_options(options)
1134
Ken Turnerd07564b2018-02-08 17:57:59 +11001135 files = _filter_files(
1136 _get_affected_files(commit, relative=True),
1137 included + COMMON_INCLUDED_PATHS,
1138 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001139
1140 bad_files = []
1141 for f in files:
1142 contents = _get_file_content(f, commit)
1143 if not contents:
1144 # Ignore empty files.
1145 continue
1146
1147 if not license_re.search(contents):
1148 bad_files.append(f)
1149
1150 if bad_files:
1151 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1152 license_re.pattern)
1153 return HookFailure(msg, bad_files)
1154
1155
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001156def _check_layout_conf(_project, commit):
1157 """Verifies the metadata/layout.conf file."""
1158 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001159 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001160 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001161 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001162
Mike Frysinger94a670c2014-09-19 12:46:26 -04001163 # Handle multiple overlays in a single commit (like the public tree).
1164 for f in _get_affected_files(commit, relative=True):
1165 if f.endswith(repo_name):
1166 repo_names.append(f)
1167 elif f.endswith(layout_path):
1168 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001169
1170 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001171 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001172 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001173 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001174
Mike Frysinger94a670c2014-09-19 12:46:26 -04001175 # Gather all the errors in one pass so we show one full message.
1176 all_errors = {}
1177 for layout_path in layout_paths:
1178 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001179
Mike Frysinger94a670c2014-09-19 12:46:26 -04001180 # Make sure the config file is sorted.
1181 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1182 if x and x[0] != '#']
1183 if sorted(data) != data:
1184 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001185
Mike Frysinger94a670c2014-09-19 12:46:26 -04001186 # Require people to set specific values all the time.
1187 settings = (
1188 # TODO: Enable this for everyone. http://crbug.com/408038
1189 #('fast caching', 'cache-format = md5-dict'),
1190 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001191 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1192 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001193 )
1194 for reason, line in settings:
1195 if line not in data:
1196 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001197
Mike Frysinger94a670c2014-09-19 12:46:26 -04001198 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001199 if 'use-manifests = strict' not in data:
1200 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001201
Mike Frysinger94a670c2014-09-19 12:46:26 -04001202 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001203 for line in data:
1204 if line.startswith('repo-name = '):
1205 break
1206 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001207 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001208
Mike Frysinger94a670c2014-09-19 12:46:26 -04001209 # Summarize all the errors we saw (if any).
1210 lines = ''
1211 for layout_path, errors in all_errors.items():
1212 if errors:
1213 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1214 if lines:
1215 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1216 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001217
1218
Ryan Cuiec4d6332011-05-02 14:15:25 -07001219# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001220
Ryan Cui1562fb82011-05-09 11:01:31 -07001221
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001222def _check_clang_format(_project, commit, options=()):
1223 """Runs clang-format on the given project"""
1224 hooks_dir = _get_hooks_dir()
1225 options = list(options)
1226 if commit == PRE_SUBMIT:
1227 options.append('--commit=HEAD')
1228 else:
1229 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001230 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001231 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1232 print_cmd=False,
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001233 stdout_to_pipe=True,
1234 combine_stdout_stderr=True,
1235 error_code_ok=True)
1236 if cmd_result.returncode:
1237 return HookFailure('clang-format.py errors/warnings\n\n' +
1238 cmd_result.output)
1239
1240
Mike Frysingerae409522014-02-01 03:16:11 -05001241def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001242 """Runs checkpatch.pl on the given project"""
1243 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001244 options = list(options)
1245 if commit == PRE_SUBMIT:
1246 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1247 # this case.
1248 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001249 # Always ignore the check for the MAINTAINERS file. We do not track that
1250 # information on that file in our source trees, so let's suppress the
1251 # warning.
1252 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001253 # Do not complain about the Change-Id: fields, since we use Gerrit.
1254 # Upstream does not want those lines (since they do not use Gerrit), but
1255 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001256 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001257 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001258 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1259 print_cmd=False,
1260 input=_get_patch(commit),
1261 stdout_to_pipe=True,
1262 combine_stdout_stderr=True,
1263 error_code_ok=True)
1264 if cmd_result.returncode:
1265 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001266
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001267
Brian Norris23c62e92018-11-14 12:25:51 -08001268def _run_kerneldoc(_project, commit, options=()):
1269 """Runs kernel-doc validator on the given project"""
1270 included, excluded = _parse_common_inclusion_options(options)
1271 files = _filter_files(_get_affected_files(commit, relative=True),
1272 included, excluded)
1273 if files:
1274 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001275 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Brian Norris23c62e92018-11-14 12:25:51 -08001276 output = _run_command(cmd=cmd, combine_stdout_stderr=True)
1277 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001278 return HookFailure('kernel-doc errors/warnings:',
1279 items=output.splitlines())
Brian Norris23c62e92018-11-14 12:25:51 -08001280
1281
Mike Frysingerae409522014-02-01 03:16:11 -05001282def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001283 """Makes sure kernel config changes are not mixed with code changes"""
1284 files = _get_affected_files(commit)
1285 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1286 return HookFailure('Changes to chromeos/config/ and regular files must '
1287 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001288
Mike Frysingerae409522014-02-01 03:16:11 -05001289
1290def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001291 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001292 ret = []
1293
1294 files = _filter_files(_get_affected_files(commit, relative=True),
1295 [r'.*\.json$'])
1296 for f in files:
1297 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001298 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001299 json.loads(data)
1300 except Exception as e:
1301 ret.append('%s: Invalid JSON: %s' % (f, e))
1302
1303 if ret:
1304 return HookFailure('\n'.join(ret))
Dale Curtis2975c432011-05-03 17:25:20 -07001305
1306
Mike Frysingerae409522014-02-01 03:16:11 -05001307def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001308 """Make sure Manifest files only have comments & DIST lines."""
1309 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001310
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001311 manifests = _filter_files(_get_affected_files(commit, relative=True),
1312 [r'.*/Manifest$'])
1313 for path in manifests:
1314 data = _get_file_content(path, commit)
1315
1316 # Disallow blank files.
1317 if not data.strip():
1318 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001319 continue
1320
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001321 # Make sure the last newline isn't omitted.
1322 if data[-1] != '\n':
1323 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001324
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001325 # Do not allow leading or trailing blank lines.
1326 lines = data.splitlines()
1327 if not lines[0]:
1328 ret.append('%s: delete leading blank lines' % (path,))
1329 if not lines[-1]:
1330 ret.append('%s: delete trailing blank lines' % (path,))
1331
1332 for line in lines:
1333 # Disallow leading/trailing whitespace.
1334 if line != line.strip():
1335 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1336
1337 # Allow blank lines & comments.
1338 line = line.split('#', 1)[0]
1339 if not line:
1340 continue
1341
1342 # All other linse should start with DIST.
1343 if not line.startswith('DIST '):
1344 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1345 break
1346
1347 if ret:
1348 return HookFailure('\n'.join(ret))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001349
1350
Mike Frysingerae409522014-02-01 03:16:11 -05001351def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001352 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001353 if commit == PRE_SUBMIT:
1354 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001355 BRANCH_RE = r'\nBRANCH=\S+'
1356
1357 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1358 msg = ('Changelist description needs BRANCH field (after first line)\n'
1359 'E.g. BRANCH=none or BRANCH=link,snow')
1360 return HookFailure(msg)
1361
1362
Mike Frysingerae409522014-02-01 03:16:11 -05001363def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001364 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001365 if commit == PRE_SUBMIT:
1366 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001367 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1368
1369 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1370 msg = ('Changelist description needs Signed-off-by: field\n'
1371 'E.g. Signed-off-by: My Name <me@chromium.org>')
1372 return HookFailure(msg)
1373
1374
Aviv Keshet5ac59522017-01-31 14:28:27 -08001375def _check_cq_ini_well_formed(_project, commit):
1376 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1377 pattern = '.*' + constants.CQ_CONFIG_FILENAME
Mike Frysingerd0523442018-01-03 17:05:29 -05001378 files = _filter_files(_get_affected_files(commit, relative=True), (pattern,))
Aviv Keshet5ac59522017-01-31 14:28:27 -08001379
1380 # TODO(akeshet): Check not only that the file is parseable, but that all the
1381 # pre-cq configs it requests are existing ones.
1382 for f in files:
1383 try:
1384 parser = ConfigParser.SafeConfigParser()
1385 # Prior to python3, ConfigParser has no read_string method, so we must
1386 # pass it either a file path or file like object. And we must use
1387 # _get_file_content to fetch file contents to ensure we are examining the
1388 # commit diff, rather than whatever's on disk.
1389 contents = _get_file_content(f, commit)
1390 parser.readfp(StringIO.StringIO(contents))
1391 except ConfigParser.Error as e:
1392 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1393 (f, e))
1394 return HookFailure(msg)
1395
1396
Jon Salz3ee59de2012-08-18 13:54:22 +08001397def _run_project_hook_script(script, project, commit):
1398 """Runs a project hook script.
1399
1400 The script is run with the following environment variables set:
1401 PRESUBMIT_PROJECT: The affected project
1402 PRESUBMIT_COMMIT: The affected commit
1403 PRESUBMIT_FILES: A newline-separated list of affected files
1404
1405 The script is considered to fail if the exit code is non-zero. It should
1406 write an error message to stdout.
1407 """
1408 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001409 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001410 env['PRESUBMIT_COMMIT'] = commit
1411
1412 # Put affected files in an environment variable
1413 files = _get_affected_files(commit)
1414 env['PRESUBMIT_FILES'] = '\n'.join(files)
1415
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001416 cmd_result = cros_build_lib.RunCommand(cmd=script,
1417 env=env,
1418 shell=True,
1419 print_cmd=False,
1420 input=os.devnull,
1421 stdout_to_pipe=True,
1422 combine_stdout_stderr=True,
1423 error_code_ok=True)
1424 if cmd_result.returncode:
1425 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001426 if stdout:
1427 stdout = re.sub('(?m)^', ' ', stdout)
1428 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001429 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001430 ':\n' + stdout if stdout else ''))
1431
1432
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001433def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001434 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001435
Brian Norris77608e12018-04-06 10:38:43 -07001436 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001437 prefix = os.path.commonprefix(files)
1438 prefix = os.path.dirname(prefix)
1439
1440 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001441 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001442 return
1443
1444 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001445
1446 # The common files may all be within a subdirectory of the main project
1447 # directory, so walk up the tree until we find an alias file.
1448 # _get_affected_files() should return relative paths, but check against '/' to
1449 # ensure that this loop terminates even if it receives an absolute path.
1450 while prefix and prefix != '/':
1451 alias_file = os.path.join(prefix, '.project_alias')
1452
1453 # If an alias exists, use it.
1454 if os.path.isfile(alias_file):
1455 project_name = osutils.ReadFile(alias_file).strip()
1456
1457 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001458
1459 if not _get_commit_desc(commit).startswith(project_name + ': '):
1460 return HookFailure('The commit title for changes affecting only %s'
1461 ' should start with \"%s: \"'
1462 % (project_name, project_name))
1463
1464
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001465def _check_filepath_chartype(_project, commit):
1466 """Checks that FilePath::CharType stuff is not used."""
1467
1468 FILEPATH_REGEXP = re.compile('|'.join(
1469 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001470 r'(?:base::)?FilePath::FromUTF8Unsafe',
1471 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001472 r'FILE_PATH_LITERAL']))
1473 files = _filter_files(_get_affected_files(commit, relative=True),
1474 [r'.*\.(cc|h)$'])
1475
1476 errors = []
1477 for afile in files:
1478 for line_num, line in _get_file_diff(afile, commit):
1479 m = re.search(FILEPATH_REGEXP, line)
1480 if m:
1481 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1482
1483 if errors:
1484 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1485 return HookFailure(msg, errors)
1486
1487
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001488def _check_exec_files(_project, commit):
1489 """Make +x bits on files."""
1490 # List of files that should never be +x.
1491 NO_EXEC = (
1492 'ChangeLog*',
1493 'COPYING',
1494 'make.conf',
1495 'make.defaults',
1496 'Manifest',
1497 'OWNERS',
1498 'package.use',
1499 'package.keywords',
1500 'package.mask',
1501 'parent',
1502 'README',
1503 'TODO',
1504 '.gitignore',
1505 '*.[achly]',
1506 '*.[ch]xx',
1507 '*.boto',
1508 '*.cc',
1509 '*.cfg',
1510 '*.conf',
1511 '*.config',
1512 '*.cpp',
1513 '*.css',
1514 '*.ebuild',
1515 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001516 '*.gn',
1517 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001518 '*.gyp',
1519 '*.gypi',
1520 '*.htm',
1521 '*.html',
1522 '*.ini',
1523 '*.js',
1524 '*.json',
1525 '*.md',
1526 '*.mk',
1527 '*.patch',
1528 '*.policy',
1529 '*.proto',
1530 '*.raw',
1531 '*.rules',
1532 '*.service',
1533 '*.target',
1534 '*.txt',
1535 '*.xml',
1536 '*.yaml',
1537 )
1538
1539 def FinalName(obj):
1540 # If the file is being deleted, then the dst_file is not set.
1541 if obj.dst_file is None:
1542 return obj.src_file
1543 else:
1544 return obj.dst_file
1545
1546 bad_files = []
1547 files = _get_affected_files(commit, relative=True, full_details=True)
1548 for f in files:
1549 mode = int(f.dst_mode, 8)
1550 if not mode & 0o111:
1551 continue
1552 name = FinalName(f)
1553 for no_exec in NO_EXEC:
1554 if fnmatch.fnmatch(name, no_exec):
1555 bad_files.append(name)
1556 break
1557
1558 if bad_files:
1559 return HookFailure('These files should not be executable. '
1560 'Please `chmod -x` them.', bad_files)
1561
1562
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001563# Base
1564
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001565# A list of hooks which are not project specific and check patch description
1566# (as opposed to patch body).
1567_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001568 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001569 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001570 _check_change_has_test_field,
1571 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001572 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001573 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001574]
1575
1576
1577# A list of hooks that are not project-specific
1578_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001579 _check_cq_ini_well_formed,
1580 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001581 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001582 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001583 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001584 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001585 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001586 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001587 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001588 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001589 _check_no_long_lines,
1590 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001591 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001592 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001593 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001594]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001595
Ryan Cui1562fb82011-05-09 11:01:31 -07001596
Ryan Cui9b651632011-05-11 11:38:58 -07001597# A dictionary of project-specific hooks(callbacks), indexed by project name.
1598# dict[project] = [callback1, callback2]
1599_PROJECT_SPECIFIC_HOOKS = {
Mike Frysingeraf891292015-03-25 19:46:53 -04001600 "chromiumos/third_party/kernel": [_kernel_configcheck],
1601 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001602}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001603
Ryan Cui1562fb82011-05-09 11:01:31 -07001604
Ryan Cui9b651632011-05-11 11:38:58 -07001605# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001606# that the flag controls (value).
1607_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001608 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001609 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001610 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001611 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001612 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001613 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001614 'cros_license_check': _check_cros_license,
1615 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001616 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001617 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001618 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001619 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001620 'bug_field_check': _check_change_has_bug_field,
1621 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001622 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001623 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001624 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001625 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001626}
1627
1628
Mike Frysinger3554bc92015-03-11 04:59:21 -04001629def _get_override_hooks(config):
1630 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001631
1632 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001633
1634 Args:
1635 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001636 """
1637 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001638 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001639 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001640 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001641
Mike Frysinger3554bc92015-03-11 04:59:21 -04001642 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001643 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001644
1645 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001646 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001647 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001648 if flag not in valid_keys:
1649 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1650 (flag, _CONFIG_FILE))
1651
Ryan Cui9b651632011-05-11 11:38:58 -07001652 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001653 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001654 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001655 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1656 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001657 if enabled:
1658 enable_flags.append(flag)
1659 else:
1660 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001661
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001662 # See if this hook has custom options.
1663 if enabled:
1664 try:
1665 options = config.get(SECTION_OPTIONS, flag)
1666 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001667 hooks[flag].__name__ = flag
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001668 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1669 pass
1670
1671 enabled_hooks = set(hooks[x] for x in enable_flags)
1672 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001673 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001674
1675
Jon Salz3ee59de2012-08-18 13:54:22 +08001676def _get_project_hook_scripts(config):
1677 """Returns a list of project-specific hook scripts.
1678
1679 Args:
1680 config: A ConfigParser for the project's config file.
1681 """
1682 SECTION = 'Hook Scripts'
1683 if not config.has_section(SECTION):
1684 return []
1685
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001686 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001687
1688
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001689def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001690 """Returns a list of hooks that need to be run for a project.
1691
1692 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001693
1694 Args:
1695 project: A string, name of the project.
1696 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001697 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001698 config = ConfigParser.RawConfigParser()
1699 try:
1700 config.read(_CONFIG_FILE)
1701 except ConfigParser.Error:
1702 # Just use an empty config file
1703 config = ConfigParser.RawConfigParser()
1704
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001705 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001706 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001707 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001708 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001709
Mike Frysinger3554bc92015-03-11 04:59:21 -04001710 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001711 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1712
1713 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1714 # override, keep the override only. Note that the override may end up being
1715 # a functools.partial, in which case we need to extract the .func to compare
1716 # it to the common hooks.
1717 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1718 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1719
1720 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001721
1722 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001723 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1724 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001725
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001726 for name, script in _get_project_hook_scripts(config):
1727 func = functools.partial(_run_project_hook_script, script)
1728 func.__name__ = name
1729 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001730
Ryan Cui9b651632011-05-11 11:38:58 -07001731 return hooks
1732
1733
Alex Deymo643ac4c2015-09-03 10:40:50 -07001734def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001735 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001736 """For each project run its project specific hook from the hooks dictionary.
1737
1738 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001739 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001740 proj_dir: If non-None, this is the directory the project is in. If None,
1741 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001742 commit_list: A list of commits to run hooks against. If None or empty list
1743 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001744 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001745
1746 Returns:
1747 Boolean value of whether any errors were ecountered while running the hooks.
1748 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001749 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001750 proj_dirs = _run_command(
1751 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001752 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001753 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001754 print('Please specify a valid project.', file=sys.stderr)
1755 return True
1756 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001757 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001758 file=sys.stderr)
1759 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1760 return True
1761 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001762
Ryan Cuiec4d6332011-05-02 14:15:25 -07001763 pwd = os.getcwd()
1764 # hooks assume they are run from the root of the project
1765 os.chdir(proj_dir)
1766
Alex Deymo643ac4c2015-09-03 10:40:50 -07001767 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1768 '--symbolic-full-name', '@{u}']).strip()
1769 if not remote_branch:
1770 print('Your project %s doesn\'t track any remote repo.' % project_name,
1771 file=sys.stderr)
1772 remote = None
1773 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10001774 branch_items = remote_branch.split('/', 1)
1775 if len(branch_items) != 2:
1776 PrintErrorForProject(
1777 project_name,
1778 HookFailure(
1779 'Cannot get remote and branch name (%s)' % remote_branch))
1780 os.chdir(pwd)
1781 return True
1782 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07001783
1784 project = Project(name=project_name, dir=proj_dir, remote=remote)
1785
Doug Anderson14749562013-06-26 13:38:29 -07001786 if not commit_list:
1787 try:
1788 commit_list = _get_commits()
1789 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001790 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001791 os.chdir(pwd)
1792 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001793
Alex Deymo643ac4c2015-09-03 10:40:50 -07001794 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001795 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001796 commit_count = len(commit_list)
1797 for i, commit in enumerate(commit_list):
Ryan Cui1562fb82011-05-09 11:01:31 -07001798 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001799 for hook in hooks:
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001800 output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' %
1801 (i + 1, commit_count, commit, hook.__name__))
1802 print(output, end='\r')
1803 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001804 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001805 print(' ' * len(output), end='\r')
1806 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001807 if hook_error:
1808 error_list.append(hook_error)
1809 error_found = True
1810 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001811 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001812 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001813
Ryan Cuiec4d6332011-05-02 14:15:25 -07001814 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001815 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001816
Mike Frysingerae409522014-02-01 03:16:11 -05001817
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001818# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001819
Ryan Cui1562fb82011-05-09 11:01:31 -07001820
Mike Frysingerae409522014-02-01 03:16:11 -05001821def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001822 """Main function invoked directly by repo.
1823
1824 This function will exit directly upon error so that repo doesn't print some
1825 obscure error message.
1826
1827 Args:
1828 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001829 worktree_list: A list of directories. It should be the same length as
1830 project_list, so that each entry in project_list matches with a directory
1831 in worktree_list. If None, we will attempt to calculate the directories
1832 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001833 kwargs: Leave this here for forward-compatibility.
1834 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001835 found_error = False
David James2edd9002013-10-11 14:09:19 -07001836 if not worktree_list:
1837 worktree_list = [None] * len(project_list)
1838 for project, worktree in zip(project_list, worktree_list):
1839 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001840 found_error = True
1841
Mike Frysingerae409522014-02-01 03:16:11 -05001842 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001843 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001844 '- To disable some source style checks, and for other hints, see '
1845 '<checkout_dir>/src/repohooks/README\n'
1846 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001847 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001848 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001849
Ryan Cui1562fb82011-05-09 11:01:31 -07001850
Doug Anderson44a644f2011-11-02 10:37:37 -07001851def _identify_project(path):
1852 """Identify the repo project associated with the given path.
1853
1854 Returns:
1855 A string indicating what project is associated with the path passed in or
1856 a blank string upon failure.
1857 """
1858 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001859 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001860
1861
Mike Frysinger55f85b52014-12-18 14:45:21 -05001862def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001863 """Run hooks directly (outside of the context of repo).
1864
Doug Anderson44a644f2011-11-02 10:37:37 -07001865 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001866 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001867
1868 Returns:
1869 0 if no pre-upload failures, 1 if failures.
1870
1871 Raises:
1872 BadInvocation: On some types of invocation errors.
1873 """
Mike Frysinger66142932014-12-18 14:55:57 -05001874 parser = commandline.ArgumentParser(description=__doc__)
1875 parser.add_argument('--dir', default=None,
1876 help='The directory that the project lives in. If not '
1877 'specified, use the git project root based on the cwd.')
1878 parser.add_argument('--project', default=None,
1879 help='The project repo path; this can affect how the '
1880 'hooks get run, since some hooks are project-specific. '
1881 'For chromite this is chromiumos/chromite. If not '
1882 'specified, the repo tool will be used to figure this '
1883 'out based on the dir.')
1884 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08001885 help='Rerun hooks on old commits since some point '
1886 'in the past. The argument could be a date (should '
1887 'match git log\'s concept of a date, e.g. 2012-06-20), '
1888 'or a SHA1, or just a number of commits to check (from 1 '
1889 'to 99). This option is mutually exclusive with '
1890 '--pre-submit.')
Mike Frysinger66142932014-12-18 14:55:57 -05001891 parser.add_argument('--pre-submit', action="store_true",
1892 help='Run the check against the pending commit. '
1893 'This option should be used at the \'git commit\' '
1894 'phase as opposed to \'repo upload\'. This option '
1895 'is mutually exclusive with --rerun-since.')
1896 parser.add_argument('commits', nargs='*',
1897 help='Check specific commits')
1898 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001899
Doug Anderson14749562013-06-26 13:38:29 -07001900 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001901 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001902 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001903 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001904
Vadim Bendebury75447b92018-01-10 12:06:01 -08001905 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
1906 # This must be the number of commits to check. We don't expect the user
1907 # to want to check more than 99 commits.
1908 limit = '-n%s' % opts.rerun_since
1909 elif git.IsSHA1(opts.rerun_since, False):
1910 limit = '%s..' % opts.rerun_since
1911 else:
1912 # This better be a date.
1913 limit = '--since=%s' % opts.rerun_since
1914 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07001915 all_commits = _run_command(cmd).splitlines()
1916 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1917
1918 # Eliminate chrome-bot commits but keep ordering the same...
1919 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001920 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001921
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001922 if opts.pre_submit:
1923 raise BadInvocation('rerun-since and pre-submit can not be '
1924 'used together')
1925 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001926 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001927 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001928 ' '.join(opts.commits))
1929 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001930
1931 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1932 # project from CWD
1933 if opts.dir is None:
1934 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001935 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001936 if not git_dir:
1937 raise BadInvocation('The current directory is not part of a git project.')
1938 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1939 elif not os.path.isdir(opts.dir):
1940 raise BadInvocation('Invalid dir: %s' % opts.dir)
1941 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1942 raise BadInvocation('Not a git directory: %s' % opts.dir)
1943
1944 # Identify the project if it wasn't specified; this _requires_ the repo
1945 # tool to be installed and for the project to be part of a repo checkout.
1946 if not opts.project:
1947 opts.project = _identify_project(opts.dir)
1948 if not opts.project:
1949 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1950
Doug Anderson14749562013-06-26 13:38:29 -07001951 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001952 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001953 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001954 if found_error:
1955 return 1
1956 return 0
1957
1958
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001959if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001960 sys.exit(direct_main(sys.argv[1:]))