blob: 643b1ebdcb1a1d1b75be070cb8ccee5fab1bccc7 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040033import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000034import sys # Parts exposed through API.
35import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040036import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000037import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000038import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000040import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000042import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000043from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000044
45# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000046import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070048import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000049import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000050import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020051import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040069 self.stdin = kwargs.get('stdin', None)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000070 self.kwargs = kwargs
Edward Lesmes8e282792018-04-03 18:50:29 -040071 self.kwargs['stdout'] = subprocess.PIPE
72 self.kwargs['stderr'] = subprocess.STDOUT
73 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.message = message
75 self.info = None
76
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000077
Edward Lesmes8e282792018-04-03 18:50:29 -040078# Adapted from
79# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
80#
81# An object that catches SIGINT sent to the Python process and notices
82# if processes passed to wait() die by SIGINT (we need to look for
83# both of those cases, because pressing Ctrl+C can result in either
84# the main process or one of the subprocesses getting the signal).
85#
86# Before a SIGINT is seen, wait(p) will simply call p.wait() and
87# return the result. Once a SIGINT has been seen (in the main process
88# or a subprocess, including the one the current call is waiting for),
89# wait(p) will call p.terminate() and raise ProcessWasInterrupted.
90class SigintHandler(object):
91 class ProcessWasInterrupted(Exception):
92 pass
93
94 sigint_returncodes = {-signal.SIGINT, # Unix
95 -1073741510, # Windows
96 }
97 def __init__(self):
98 self.__lock = threading.Lock()
99 self.__processes = set()
100 self.__got_sigint = False
101 signal.signal(signal.SIGINT, lambda signal_num, frame: self.interrupt())
102
103 def __on_sigint(self):
104 self.__got_sigint = True
105 while self.__processes:
106 try:
107 self.__processes.pop().terminate()
108 except OSError:
109 pass
110
111 def interrupt(self):
112 with self.__lock:
113 self.__on_sigint()
114
115 def got_sigint(self):
116 with self.__lock:
117 return self.__got_sigint
118
119 def wait(self, p, stdin):
120 with self.__lock:
121 if self.__got_sigint:
122 p.terminate()
123 self.__processes.add(p)
124 stdout, stderr = p.communicate(stdin)
125 code = p.returncode
126 with self.__lock:
127 self.__processes.discard(p)
128 if code in self.sigint_returncodes:
129 self.__on_sigint()
130 if self.__got_sigint:
131 raise self.ProcessWasInterrupted
132 return stdout, stderr
133
134sigint_handler = SigintHandler()
135
136
137class ThreadPool(object):
138 def __init__(self, pool_size=None):
139 self._pool_size = pool_size or multiprocessing.cpu_count()
140 self._messages = []
141 self._messages_lock = threading.Lock()
142 self._tests = []
143 self._tests_lock = threading.Lock()
144 self._nonparallel_tests = []
145
146 def CallCommand(self, test):
147 """Runs an external program.
148
149 This function converts invocation of .py files and invocations of "python"
150 to vpython invocations.
151 """
152 vpython = 'vpython.bat' if sys.platform == 'win32' else 'vpython'
153
154 cmd = test.cmd
155 if cmd[0] == 'python':
156 cmd = list(cmd)
157 cmd[0] = vpython
158 elif cmd[0].endswith('.py'):
159 cmd = [vpython] + cmd
160
161 try:
162 start = time.time()
163 p = subprocess.Popen(cmd, **test.kwargs)
164 stdout, _ = sigint_handler.wait(p, test.stdin)
165 duration = time.time() - start
166 except OSError as e:
167 duration = time.time() - start
168 return test.message(
169 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
170 if p.returncode != 0:
171 return test.message(
172 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
173 if test.info:
174 return test.info('%s (%4.2fs)' % (test.name, duration))
175
176 def AddTests(self, tests, parallel=True):
177 if parallel:
178 self._tests.extend(tests)
179 else:
180 self._nonparallel_tests.extend(tests)
181
182 def RunAsync(self):
183 self._messages = []
184
185 def _WorkerFn():
186 while True:
187 test = None
188 with self._tests_lock:
189 if not self._tests:
190 break
191 test = self._tests.pop()
192 result = self.CallCommand(test)
193 if result:
194 with self._messages_lock:
195 self._messages.append(result)
196
197 def _StartDaemon():
198 t = threading.Thread(target=_WorkerFn)
199 t.daemon = True
200 t.start()
201 return t
202
203 while self._nonparallel_tests:
204 test = self._nonparallel_tests.pop()
205 result = self.CallCommand(test)
206 if result:
207 self._messages.append(result)
208
209 if self._tests:
210 threads = [_StartDaemon() for _ in range(self._pool_size)]
211 for worker in threads:
212 worker.join()
213
214 return self._messages
215
216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000217def normpath(path):
218 '''Version of os.path.normpath that also changes backward slashes to
219 forward slashes when not running on Windows.
220 '''
221 # This is safe to always do because the Windows version of os.path.normpath
222 # will replace forward slashes with backward slashes.
223 path = path.replace(os.sep, '/')
224 return os.path.normpath(path)
225
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000226
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000227def _RightHandSideLinesImpl(affected_files):
228 """Implements RightHandSideLines for InputApi and GclChange."""
229 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000230 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000231 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000232 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000233
234
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000235class PresubmitOutput(object):
236 def __init__(self, input_stream=None, output_stream=None):
237 self.input_stream = input_stream
238 self.output_stream = output_stream
239 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800240 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000241 self.written_output = []
242 self.error_count = 0
243
244 def prompt_yes_no(self, prompt_string):
245 self.write(prompt_string)
246 if self.input_stream:
247 response = self.input_stream.readline().strip().lower()
248 if response not in ('y', 'yes'):
249 self.fail()
250 else:
251 self.fail()
252
253 def fail(self):
254 self.error_count += 1
255
256 def should_continue(self):
257 return not self.error_count
258
259 def write(self, s):
260 self.written_output.append(s)
261 if self.output_stream:
262 self.output_stream.write(s)
263
264 def getvalue(self):
265 return ''.join(self.written_output)
266
267
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000268# Top level object so multiprocessing can pickle
269# Public access through OutputApi object.
270class _PresubmitResult(object):
271 """Base class for result objects."""
272 fatal = False
273 should_prompt = False
274
275 def __init__(self, message, items=None, long_text=''):
276 """
277 message: A short one-line message to indicate errors.
278 items: A list of short strings to indicate where errors occurred.
279 long_text: multi-line text output, e.g. from another tool
280 """
281 self._message = message
282 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000283 self._long_text = long_text.rstrip()
284
285 def handle(self, output):
286 output.write(self._message)
287 output.write('\n')
288 for index, item in enumerate(self._items):
289 output.write(' ')
290 # Write separately in case it's unicode.
291 output.write(str(item))
292 if index < len(self._items) - 1:
293 output.write(' \\')
294 output.write('\n')
295 if self._long_text:
296 output.write('\n***************\n')
297 # Write separately in case it's unicode.
298 output.write(self._long_text)
299 output.write('\n***************\n')
300 if self.fatal:
301 output.fail()
302
303
304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306class _PresubmitError(_PresubmitResult):
307 """A hard presubmit error."""
308 fatal = True
309
310
311# Top level object so multiprocessing can pickle
312# Public access through OutputApi object.
313class _PresubmitPromptWarning(_PresubmitResult):
314 """An warning that prompts the user if they want to continue."""
315 should_prompt = True
316
317
318# Top level object so multiprocessing can pickle
319# Public access through OutputApi object.
320class _PresubmitNotifyResult(_PresubmitResult):
321 """Just print something to the screen -- but it's not even a warning."""
322 pass
323
324
325# Top level object so multiprocessing can pickle
326# Public access through OutputApi object.
327class _MailTextResult(_PresubmitResult):
328 """A warning that should be included in the review request email."""
329 def __init__(self, *args, **kwargs):
330 super(_MailTextResult, self).__init__()
331 raise NotImplementedError()
332
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000333class GerritAccessor(object):
334 """Limited Gerrit functionality for canned presubmit checks to work.
335
336 To avoid excessive Gerrit calls, caches the results.
337 """
338
339 def __init__(self, host):
340 self.host = host
341 self.cache = {}
342
343 def _FetchChangeDetail(self, issue):
344 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100345 try:
346 return gerrit_util.GetChangeDetail(
347 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700348 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100349 except gerrit_util.GerritError as e:
350 if e.http_status == 404:
351 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
352 'no credentials to fetch issue details' % issue)
353 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000354
355 def GetChangeInfo(self, issue):
356 """Returns labels and all revisions (patchsets) for this issue.
357
358 The result is a dictionary according to Gerrit REST Api.
359 https://gerrit-review.googlesource.com/Documentation/rest-api.html
360
361 However, API isn't very clear what's inside, so see tests for example.
362 """
363 assert issue
364 cache_key = int(issue)
365 if cache_key not in self.cache:
366 self.cache[cache_key] = self._FetchChangeDetail(issue)
367 return self.cache[cache_key]
368
369 def GetChangeDescription(self, issue, patchset=None):
370 """If patchset is none, fetches current patchset."""
371 info = self.GetChangeInfo(issue)
372 # info is a reference to cache. We'll modify it here adding description to
373 # it to the right patchset, if it is not yet there.
374
375 # Find revision info for the patchset we want.
376 if patchset is not None:
377 for rev, rev_info in info['revisions'].iteritems():
378 if str(rev_info['_number']) == str(patchset):
379 break
380 else:
381 raise Exception('patchset %s doesn\'t exist in issue %s' % (
382 patchset, issue))
383 else:
384 rev = info['current_revision']
385 rev_info = info['revisions'][rev]
386
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100387 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000388
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800389 def GetDestRef(self, issue):
390 ref = self.GetChangeInfo(issue)['branch']
391 if not ref.startswith('refs/'):
392 # NOTE: it is possible to create 'refs/x' branch,
393 # aka 'refs/heads/refs/x'. However, this is ill-advised.
394 ref = 'refs/heads/%s' % ref
395 return ref
396
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 def GetChangeOwner(self, issue):
398 return self.GetChangeInfo(issue)['owner']['email']
399
400 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700401 changeinfo = self.GetChangeInfo(issue)
402 if approving_only:
403 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
404 values = labelinfo.get('values', {}).keys()
405 try:
406 max_value = max(int(v) for v in values)
407 reviewers = [r for r in labelinfo.get('all', [])
408 if r.get('value', 0) == max_value]
409 except ValueError: # values is the empty list
410 reviewers = []
411 else:
412 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
413 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000415
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000416class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000417 """An instance of OutputApi gets passed to presubmit scripts so that they
418 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000420 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000421 PresubmitError = _PresubmitError
422 PresubmitPromptWarning = _PresubmitPromptWarning
423 PresubmitNotifyResult = _PresubmitNotifyResult
424 MailTextResult = _MailTextResult
425
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000426 def __init__(self, is_committing):
427 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800428 self.more_cc = []
429
430 def AppendCC(self, cc):
431 """Appends a user to cc for this change."""
432 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000433
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000434 def PresubmitPromptOrNotify(self, *args, **kwargs):
435 """Warn the user when uploading, but only notify if committing."""
436 if self.is_committing:
437 return self.PresubmitNotifyResult(*args, **kwargs)
438 return self.PresubmitPromptWarning(*args, **kwargs)
439
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800440 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
441 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
442
443 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
444 keeping it alphabetically sorted. Returns the results that should be
445 returned from the PostUploadHook.
446
447 Args:
448 cl: The git_cl.Changelist object.
449 bots_to_include: A list of strings of bots to include, in the form
450 "master:slave".
451 message: A message to be printed in the case that
452 CQ_INCLUDE_TRYBOTS was updated.
453 """
454 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700455 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
456
457 prior_bots = []
458 if cl.IsGerrit():
459 trybot_footers = git_footers.parse_footers(description).get(
460 git_footers.normalize_name('Cq-Include-Trybots'), [])
461 for f in trybot_footers:
462 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800463 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700464 trybot_tags = include_re.finditer(description)
465 for t in trybot_tags:
466 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
467
468 if set(prior_bots) >= set(bots_to_include):
469 return []
470 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
471
472 if cl.IsGerrit():
473 description = git_footers.remove_footer(
474 description, 'Cq-Include-Trybots')
475 description = git_footers.add_footer(
476 description, 'Cq-Include-Trybots', all_bots,
477 before_keys=['Change-Id'])
478 else:
479 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
480 m = include_re.search(description)
481 if m:
482 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700483 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700484 description = '%s\n%s\n' % (description, new_include_trybots)
485
486 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800487 return [self.PresubmitNotifyResult(message)]
488
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
490class InputApi(object):
491 """An instance of this object is passed to presubmit scripts so they can
492 know stuff about the change they're looking at.
493 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000494 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800495 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000496
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # File extensions that are considered source files from a style guide
498 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000499 #
500 # Files without an extension aren't included in the list. If you want to
501 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
502 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000503 DEFAULT_WHITE_LIST = (
504 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000505 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
506 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000508 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000510 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000511 )
512
513 # Path regexp that should be excluded from being considered containing source
514 # files. Don't modify this list from a presubmit script!
515 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000516 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000517 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000518 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
519 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # Output directories (just in case)
521 r".*\bDebug[\\\/].*",
522 r".*\bRelease[\\\/].*",
523 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000524 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000525 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000526 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000527 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000528 r"(|.*[\\\/])\.git[\\\/].*",
529 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000530 # There is no point in processing a patch file.
531 r".+\.diff$",
532 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000533 )
534
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000535 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400536 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000537 """Builds an InputApi object.
538
539 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000540 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000541 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000542 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000543 gerrit_obj: provides basic Gerrit codereview functionality.
544 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400545 parallel: if true, all tests reported via input_api.RunTests for all
546 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000547 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000548 # Version number of the presubmit_support script.
549 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000551 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000552 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000553 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000554
Edward Lesmes8e282792018-04-03 18:50:29 -0400555 self.parallel = parallel
556 self.thread_pool = thread_pool or ThreadPool()
557
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000558 # We expose various modules and functions as attributes of the input_api
559 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900560 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000561 self.basename = os.path.basename
562 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000563 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000564 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700565 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000566 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000567 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000568 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000569 self.os_listdir = os.listdir
570 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000571 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000572 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.pickle = pickle
574 self.marshal = marshal
575 self.re = re
576 self.subprocess = subprocess
577 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000578 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000579 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000580 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000581 self.urllib2 = urllib2
582
Robert Iannucci50258932018-03-19 10:30:59 -0700583 self.is_windows = sys.platform == 'win32'
584
585 # Set python_executable to 'python'. This is interpreted in CallCommand to
586 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
587 # to automatically pick up that repo's .vpython file, instead of inheriting
588 # the one in depot_tools.
589 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000590 self.environ = os.environ
591
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000592 # InputApi.platform is the platform you're currently running on.
593 self.platform = sys.platform
594
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000595 self.cpu_count = multiprocessing.cpu_count()
596
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000598 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599
600 # We carry the canned checks so presubmit scripts can easily use them.
601 self.canned_checks = presubmit_canned_checks
602
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100603 # Temporary files we must manually remove at the end of a run.
604 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200605
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000606 # TODO(dpranke): figure out a list of all approved owners for a repo
607 # in order to be able to handle wildcard OWNERS files?
608 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200609 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200610 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000611 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000612 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000613
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000614 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000615 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800617 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000619 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000620 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
621 for (a, b, header) in cpplint._re_pattern_templates
622 ]
623
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624 def PresubmitLocalPath(self):
625 """Returns the local path of the presubmit script currently being run.
626
627 This is useful if you don't want to hard-code absolute paths in the
628 presubmit script. For example, It can be used to find another file
629 relative to the PRESUBMIT.py script, so the whole tree can be branched and
630 the presubmit script still works, without editing its content.
631 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000632 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633
agable0b65e732016-11-22 09:25:46 -0800634 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 """Same as input_api.change.AffectedFiles() except only lists files
636 (and optionally directories) in the same directory as the current presubmit
637 script, or subdirectories thereof.
638 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000639 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 if len(dir_with_slash) == 1:
641 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000642
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000643 return filter(
644 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800645 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
agable0b65e732016-11-22 09:25:46 -0800647 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800649 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000650 logging.debug("LocalPaths: %s", paths)
651 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652
agable0b65e732016-11-22 09:25:46 -0800653 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000654 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800655 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656
John Budorick16162372018-04-18 10:39:53 -0700657 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800658 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659 in the same directory as the current presubmit script, or subdirectories
660 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000662 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800663 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000664 " is deprecated and ignored" % str(include_deletes),
665 category=DeprecationWarning,
666 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800667 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -0700668 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800669
670 def AffectedTextFiles(self, include_deletes=None):
671 """An alias to AffectedTestableFiles for backwards compatibility."""
672 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673
maruel@chromium.org3410d912009-06-09 20:56:16 +0000674 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
675 """Filters out files that aren't considered "source file".
676
677 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
678 and InputApi.DEFAULT_BLACK_LIST is used respectively.
679
680 The lists will be compiled as regular expression and
681 AffectedFile.LocalPath() needs to pass both list.
682
683 Note: Copy-paste this function to suit your needs or use a lambda function.
684 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000685 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000686 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000687 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000688 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000689 return True
690 return False
691 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
692 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
693
694 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800695 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000696
697 If source_file is None, InputApi.FilterSourceFile() is used.
698 """
699 if not source_file:
700 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800701 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000702
703 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """An iterator over all text lines in "new" version of changed files.
705
706 Only lists lines from new or modified text files in the change that are
707 contained by the directory of the currently executing presubmit script.
708
709 This is useful for doing line-by-line regex checks, like checking for
710 trailing whitespace.
711
712 Yields:
713 a 3 tuple:
714 the AffectedFile instance of the current file;
715 integer line number (1-based); and
716 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000717
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000718 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000719 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000720 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000721 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000723 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000724 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000725
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000726 Deny reading anything outside the repository.
727 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000728 if isinstance(file_item, AffectedFile):
729 file_item = file_item.AbsoluteLocalPath()
730 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000731 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000732 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000733
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100734 def CreateTemporaryFile(self, **kwargs):
735 """Returns a named temporary file that must be removed with a call to
736 RemoveTemporaryFiles().
737
738 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
739 except for |delete|, which is always set to False.
740
741 Presubmit checks that need to create a temporary file and pass it for
742 reading should use this function instead of NamedTemporaryFile(), as
743 Windows fails to open a file that is already open for writing.
744
745 with input_api.CreateTemporaryFile() as f:
746 f.write('xyz')
747 f.close()
748 input_api.subprocess.check_output(['script-that', '--reads-from',
749 f.name])
750
751
752 Note that callers of CreateTemporaryFile() should not worry about removing
753 any temporary file; this is done transparently by the presubmit handling
754 code.
755 """
756 if 'delete' in kwargs:
757 # Prevent users from passing |delete|; we take care of file deletion
758 # ourselves and this prevents unintuitive error messages when we pass
759 # delete=False and 'delete' is also in kwargs.
760 raise TypeError('CreateTemporaryFile() does not take a "delete" '
761 'argument, file deletion is handled automatically by '
762 'the same presubmit_support code that creates InputApi '
763 'objects.')
764 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
765 self._named_temporary_files.append(temp_file.name)
766 return temp_file
767
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000768 @property
769 def tbr(self):
770 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400771 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000772
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000773 def RunTests(self, tests_mix, parallel=True):
Edward Lesmes8e282792018-04-03 18:50:29 -0400774 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
775 # will run all tests once all PRESUBMIT files are processed.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000776 tests = []
777 msgs = []
778 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400779 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000780 msgs.append(t)
781 else:
782 assert issubclass(t.message, _PresubmitResult)
783 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000784 if self.verbose:
785 t.info = _PresubmitNotifyResult
Edward Lesmes8e282792018-04-03 18:50:29 -0400786 t.kwargs['cwd'] = self.PresubmitLocalPath()
787 self.thread_pool.AddTests(tests, parallel)
788 if not self.parallel:
789 msgs.extend(self.thread_pool.RunAsync())
790 return msgs
scottmg86099d72016-09-01 09:16:51 -0700791
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000792
nick@chromium.orgff526192013-06-10 19:30:26 +0000793class _DiffCache(object):
794 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000795 def __init__(self, upstream=None):
796 """Stores the upstream revision against which all diffs will be computed."""
797 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000798
799 def GetDiff(self, path, local_root):
800 """Get the diff for a particular path."""
801 raise NotImplementedError()
802
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700803 def GetOldContents(self, path, local_root):
804 """Get the old version for a particular path."""
805 raise NotImplementedError()
806
nick@chromium.orgff526192013-06-10 19:30:26 +0000807
nick@chromium.orgff526192013-06-10 19:30:26 +0000808class _GitDiffCache(_DiffCache):
809 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000810 def __init__(self, upstream):
811 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000812 self._diffs_by_file = None
813
814 def GetDiff(self, path, local_root):
815 if not self._diffs_by_file:
816 # Compute a single diff for all files and parse the output; should
817 # with git this is much faster than computing one diff for each file.
818 diffs = {}
819
820 # Don't specify any filenames below, because there are command line length
821 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000822 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
823 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000824
825 # This regex matches the path twice, separated by a space. Note that
826 # filename itself may contain spaces.
827 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
828 current_diff = []
829 keep_line_endings = True
830 for x in unified_diff.splitlines(keep_line_endings):
831 match = file_marker.match(x)
832 if match:
833 # Marks the start of a new per-file section.
834 diffs[match.group('filename')] = current_diff = [x]
835 elif x.startswith('diff --git'):
836 raise PresubmitFailure('Unexpected diff line: %s' % x)
837 else:
838 current_diff.append(x)
839
840 self._diffs_by_file = dict(
841 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
842
843 if path not in self._diffs_by_file:
844 raise PresubmitFailure(
845 'Unified diff did not contain entry for file %s' % path)
846
847 return self._diffs_by_file[path]
848
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700849 def GetOldContents(self, path, local_root):
850 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
851
nick@chromium.orgff526192013-06-10 19:30:26 +0000852
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000853class AffectedFile(object):
854 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000855
856 DIFF_CACHE = _DiffCache
857
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000858 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800859 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000860 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000861 self._path = path
862 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000863 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000864 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000865 self._cached_changed_contents = None
866 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000867 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700868 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000869
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000870 def LocalPath(self):
871 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400872
873 This should be used for error messages but not for accessing files,
874 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
875 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000876 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000877 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878
879 def AbsoluteLocalPath(self):
880 """Returns the absolute path of this file on the local disk.
881 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000882 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000884 def Action(self):
885 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000886 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887
agable0b65e732016-11-22 09:25:46 -0800888 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000889 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000890
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000891 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000892 raise NotImplementedError() # Implement when needed
893
agable0b65e732016-11-22 09:25:46 -0800894 def IsTextFile(self):
895 """An alias to IsTestableFile for backwards compatibility."""
896 return self.IsTestableFile()
897
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700898 def OldContents(self):
899 """Returns an iterator over the lines in the old version of file.
900
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700901 The old version is the file before any modifications in the user's
902 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700903
904 Contents will be empty if the file is a directory or does not exist.
905 Note: The carriage returns (LF or CR) are stripped off.
906 """
907 return self._diff_cache.GetOldContents(self.LocalPath(),
908 self._local_root).splitlines()
909
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000910 def NewContents(self):
911 """Returns an iterator over the lines in the new version of file.
912
913 The new version is the file in the user's workspace, i.e. the "right hand
914 side".
915
916 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000917 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000918 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000919 if self._cached_new_contents is None:
920 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800921 try:
922 self._cached_new_contents = gclient_utils.FileRead(
923 self.AbsoluteLocalPath(), 'rU').splitlines()
924 except IOError:
925 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000926 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000927
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000928 def ChangedContents(self):
929 """Returns a list of tuples (line number, line text) of all new lines.
930
931 This relies on the scm diff output describing each changed code section
932 with a line of the form
933
934 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
935 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000936 if self._cached_changed_contents is not None:
937 return self._cached_changed_contents[:]
938 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000939 line_num = 0
940
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000941 for line in self.GenerateScmDiff().splitlines():
942 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
943 if m:
944 line_num = int(m.groups(1)[0])
945 continue
946 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000947 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000948 if not line.startswith('-'):
949 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000950 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000951
maruel@chromium.org5de13972009-06-10 18:16:06 +0000952 def __str__(self):
953 return self.LocalPath()
954
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000955 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000956 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000957
maruel@chromium.org58407af2011-04-12 23:15:57 +0000958
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000959class GitAffectedFile(AffectedFile):
960 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000961 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800962 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000963
nick@chromium.orgff526192013-06-10 19:30:26 +0000964 DIFF_CACHE = _GitDiffCache
965
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000966 def __init__(self, *args, **kwargs):
967 AffectedFile.__init__(self, *args, **kwargs)
968 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800969 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000970
agable0b65e732016-11-22 09:25:46 -0800971 def IsTestableFile(self):
972 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000973 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800974 # A deleted file is not testable.
975 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000976 else:
agable0b65e732016-11-22 09:25:46 -0800977 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
978 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000979
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000980
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000981class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000982 """Describe a change.
983
984 Used directly by the presubmit scripts to query the current change being
985 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000986
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000987 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000988 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000989 self.KEY: equivalent to tags['KEY']
990 """
991
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000992 _AFFECTED_FILES = AffectedFile
993
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000994 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000995 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000996 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000997 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998
maruel@chromium.org58407af2011-04-12 23:15:57 +0000999 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001000 self, name, description, local_root, files, issue, patchset, author,
1001 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001002 if files is None:
1003 files = []
1004 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001005 # Convert root into an absolute path.
1006 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001007 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001008 self.issue = issue
1009 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001010 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001011
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001012 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001013 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001014 self._description_without_tags = ''
1015 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016
maruel@chromium.orge085d812011-10-10 19:49:15 +00001017 assert all(
1018 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1019
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001020 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001021 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001022 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1023 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001024 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001025
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001026 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001028 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001029
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030 def DescriptionText(self):
1031 """Returns the user-entered changelist description, minus tags.
1032
1033 Any line in the user-provided description starting with e.g. "FOO="
1034 (whitespace permitted before and around) is considered a tag line. Such
1035 lines are stripped out of the description this function returns.
1036 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001037 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001038
1039 def FullDescriptionText(self):
1040 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001041 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001042
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001043 def SetDescriptionText(self, description):
1044 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001045
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001046 Also updates the list of tags."""
1047 self._full_description = description
1048
1049 # From the description text, build up a dictionary of key/value pairs
1050 # plus the description minus all key/value or "tag" lines.
1051 description_without_tags = []
1052 self.tags = {}
1053 for line in self._full_description.splitlines():
1054 m = self.TAG_LINE_RE.match(line)
1055 if m:
1056 self.tags[m.group('key')] = m.group('value')
1057 else:
1058 description_without_tags.append(line)
1059
1060 # Change back to text and remove whitespace at end.
1061 self._description_without_tags = (
1062 '\n'.join(description_without_tags).rstrip())
1063
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001064 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001065 """Returns the repository (checkout) root directory for this change,
1066 as an absolute path.
1067 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001068 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001069
1070 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001071 """Return tags directly as attributes on the object."""
1072 if not re.match(r"^[A-Z_]*$", attr):
1073 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001074 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001075
Aaron Gablefc03e672017-05-15 14:09:42 -07001076 def BugsFromDescription(self):
1077 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001078 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
1079 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
1080 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001081
1082 def ReviewersFromDescription(self):
1083 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001084 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1085 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1086 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001087
1088 def TBRsFromDescription(self):
1089 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001090 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1091 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1092 # determined by self-CR+1s.
1093 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1094 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001095
1096 # TODO(agable): Delete these once we're sure they're unused.
1097 @property
1098 def BUG(self):
1099 return ','.join(self.BugsFromDescription())
1100 @property
1101 def R(self):
1102 return ','.join(self.ReviewersFromDescription())
1103 @property
1104 def TBR(self):
1105 return ','.join(self.TBRsFromDescription())
1106
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001107 def AllFiles(self, root=None):
1108 """List all files under source control in the repo."""
1109 raise NotImplementedError()
1110
agable0b65e732016-11-22 09:25:46 -08001111 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001112 """Returns a list of AffectedFile instances for all files in the change.
1113
1114 Args:
1115 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001116 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001117
1118 Returns:
1119 [AffectedFile(path, action), AffectedFile(path, action)]
1120 """
agable0b65e732016-11-22 09:25:46 -08001121 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001122
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001123 if include_deletes:
1124 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -07001125 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001126
John Budorick16162372018-04-18 10:39:53 -07001127 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001128 """Return a list of the existing text files in a change."""
1129 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001130 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001131 " is deprecated and ignored" % str(include_deletes),
1132 category=DeprecationWarning,
1133 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -08001134 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -07001135 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001136
agable0b65e732016-11-22 09:25:46 -08001137 def AffectedTextFiles(self, include_deletes=None):
1138 """An alias to AffectedTestableFiles for backwards compatibility."""
1139 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001140
agable0b65e732016-11-22 09:25:46 -08001141 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001142 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001143 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144
agable0b65e732016-11-22 09:25:46 -08001145 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001147 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001148
1149 def RightHandSideLines(self):
1150 """An iterator over all text lines in "new" version of changed files.
1151
1152 Lists lines from new or modified text files in the change.
1153
1154 This is useful for doing line-by-line regex checks, like checking for
1155 trailing whitespace.
1156
1157 Yields:
1158 a 3 tuple:
1159 the AffectedFile instance of the current file;
1160 integer line number (1-based); and
1161 the contents of the line as a string.
1162 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001163 return _RightHandSideLinesImpl(
1164 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001165 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001166
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001167 def OriginalOwnersFiles(self):
1168 """A map from path names of affected OWNERS files to their old content."""
1169 def owners_file_filter(f):
1170 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1171 files = self.AffectedFiles(file_filter=owners_file_filter)
1172 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1173
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001174
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001175class GitChange(Change):
1176 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001177 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001178
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001179 def AllFiles(self, root=None):
1180 """List all files under source control in the repo."""
1181 root = root or self.RepositoryRoot()
1182 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001183 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1184 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001185
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001186
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001187def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001188 """Finds all presubmit files that apply to a given set of source files.
1189
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001190 If inherit-review-settings-ok is present right under root, looks for
1191 PRESUBMIT.py in directories enclosing root.
1192
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001193 Args:
1194 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001195 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001196
1197 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001198 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001199 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001200 files = [normpath(os.path.join(root, f)) for f in files]
1201
1202 # List all the individual directories containing files.
1203 directories = set([os.path.dirname(f) for f in files])
1204
1205 # Ignore root if inherit-review-settings-ok is present.
1206 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1207 root = None
1208
1209 # Collect all unique directories that may contain PRESUBMIT.py.
1210 candidates = set()
1211 for directory in directories:
1212 while True:
1213 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001214 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001215 candidates.add(directory)
1216 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001217 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001218 parent_dir = os.path.dirname(directory)
1219 if parent_dir == directory:
1220 # We hit the system root directory.
1221 break
1222 directory = parent_dir
1223
1224 # Look for PRESUBMIT.py in all candidate directories.
1225 results = []
1226 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001227 try:
1228 for f in os.listdir(directory):
1229 p = os.path.join(directory, f)
1230 if os.path.isfile(p) and re.match(
1231 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1232 results.append(p)
1233 except OSError:
1234 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001235
tobiasjs2836bcf2016-08-16 04:08:16 -07001236 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001237 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001238
1239
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001240class GetTryMastersExecuter(object):
1241 @staticmethod
1242 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1243 """Executes GetPreferredTryMasters() from a single presubmit script.
1244
1245 Args:
1246 script_text: The text of the presubmit script.
1247 presubmit_path: Project script to run.
1248 project: Project name to pass to presubmit script for bot selection.
1249
1250 Return:
1251 A map of try masters to map of builders to set of tests.
1252 """
1253 context = {}
1254 try:
1255 exec script_text in context
1256 except Exception, e:
1257 raise PresubmitFailure('"%s" had an exception.\n%s'
1258 % (presubmit_path, e))
1259
1260 function_name = 'GetPreferredTryMasters'
1261 if function_name not in context:
1262 return {}
1263 get_preferred_try_masters = context[function_name]
1264 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1265 raise PresubmitFailure(
1266 'Expected function "GetPreferredTryMasters" to take two arguments.')
1267 return get_preferred_try_masters(project, change)
1268
1269
rmistry@google.com5626a922015-02-26 14:03:30 +00001270class GetPostUploadExecuter(object):
1271 @staticmethod
1272 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1273 """Executes PostUploadHook() from a single presubmit script.
1274
1275 Args:
1276 script_text: The text of the presubmit script.
1277 presubmit_path: Project script to run.
1278 cl: The Changelist object.
1279 change: The Change object.
1280
1281 Return:
1282 A list of results objects.
1283 """
1284 context = {}
1285 try:
1286 exec script_text in context
1287 except Exception, e:
1288 raise PresubmitFailure('"%s" had an exception.\n%s'
1289 % (presubmit_path, e))
1290
1291 function_name = 'PostUploadHook'
1292 if function_name not in context:
1293 return {}
1294 post_upload_hook = context[function_name]
1295 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1296 raise PresubmitFailure(
1297 'Expected function "PostUploadHook" to take three arguments.')
1298 return post_upload_hook(cl, change, OutputApi(False))
1299
1300
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001301def _MergeMasters(masters1, masters2):
1302 """Merges two master maps. Merges also the tests of each builder."""
1303 result = {}
1304 for (master, builders) in itertools.chain(masters1.iteritems(),
1305 masters2.iteritems()):
1306 new_builders = result.setdefault(master, {})
1307 for (builder, tests) in builders.iteritems():
1308 new_builders.setdefault(builder, set([])).update(tests)
1309 return result
1310
1311
1312def DoGetTryMasters(change,
1313 changed_files,
1314 repository_root,
1315 default_presubmit,
1316 project,
1317 verbose,
1318 output_stream):
1319 """Get the list of try masters from the presubmit scripts.
1320
1321 Args:
1322 changed_files: List of modified files.
1323 repository_root: The repository root.
1324 default_presubmit: A default presubmit script to execute in any case.
1325 project: Optional name of a project used in selecting trybots.
1326 verbose: Prints debug info.
1327 output_stream: A stream to write debug output to.
1328
1329 Return:
1330 Map of try masters to map of builders to set of tests.
1331 """
1332 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1333 if not presubmit_files and verbose:
1334 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1335 results = {}
1336 executer = GetTryMastersExecuter()
1337
1338 if default_presubmit:
1339 if verbose:
1340 output_stream.write("Running default presubmit script.\n")
1341 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1342 results = _MergeMasters(results, executer.ExecPresubmitScript(
1343 default_presubmit, fake_path, project, change))
1344 for filename in presubmit_files:
1345 filename = os.path.abspath(filename)
1346 if verbose:
1347 output_stream.write("Running %s\n" % filename)
1348 # Accept CRLF presubmit script.
1349 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1350 results = _MergeMasters(results, executer.ExecPresubmitScript(
1351 presubmit_script, filename, project, change))
1352
1353 # Make sets to lists again for later JSON serialization.
1354 for builders in results.itervalues():
1355 for builder in builders:
1356 builders[builder] = list(builders[builder])
1357
1358 if results and verbose:
1359 output_stream.write('%s\n' % str(results))
1360 return results
1361
1362
rmistry@google.com5626a922015-02-26 14:03:30 +00001363def DoPostUploadExecuter(change,
1364 cl,
1365 repository_root,
1366 verbose,
1367 output_stream):
1368 """Execute the post upload hook.
1369
1370 Args:
1371 change: The Change object.
1372 cl: The Changelist object.
1373 repository_root: The repository root.
1374 verbose: Prints debug info.
1375 output_stream: A stream to write debug output to.
1376 """
1377 presubmit_files = ListRelevantPresubmitFiles(
1378 change.LocalPaths(), repository_root)
1379 if not presubmit_files and verbose:
1380 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1381 results = []
1382 executer = GetPostUploadExecuter()
1383 # The root presubmit file should be executed after the ones in subdirectories.
1384 # i.e. the specific post upload hooks should run before the general ones.
1385 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1386 presubmit_files.reverse()
1387
1388 for filename in presubmit_files:
1389 filename = os.path.abspath(filename)
1390 if verbose:
1391 output_stream.write("Running %s\n" % filename)
1392 # Accept CRLF presubmit script.
1393 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1394 results.extend(executer.ExecPresubmitScript(
1395 presubmit_script, filename, cl, change))
1396 output_stream.write('\n')
1397 if results:
1398 output_stream.write('** Post Upload Hook Messages **\n')
1399 for result in results:
1400 result.handle(output_stream)
1401 output_stream.write('\n')
1402
1403 return results
1404
1405
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001406class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001407 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001408 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001409 """
1410 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001411 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001412 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001413 gerrit_obj: provides basic Gerrit codereview functionality.
1414 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001415 parallel: if true, all tests reported via input_api.RunTests for all
1416 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001417 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001418 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001419 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001420 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001421 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001422 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001423 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001424 self.thread_pool = thread_pool
1425 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001426
1427 def ExecPresubmitScript(self, script_text, presubmit_path):
1428 """Executes a single presubmit script.
1429
1430 Args:
1431 script_text: The text of the presubmit script.
1432 presubmit_path: The path to the presubmit file (this will be reported via
1433 input_api.PresubmitLocalPath()).
1434
1435 Return:
1436 A list of result objects, empty if no problems.
1437 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001438
chase@chromium.org8e416c82009-10-06 04:30:44 +00001439 # Change to the presubmit file's directory to support local imports.
1440 main_path = os.getcwd()
1441 os.chdir(os.path.dirname(presubmit_path))
1442
1443 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001444 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001445 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001446 dry_run=self.dry_run, thread_pool=self.thread_pool,
1447 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001448 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001449 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001450 try:
1451 exec script_text in context
1452 except Exception, e:
1453 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001454
1455 # These function names must change if we make substantial changes to
1456 # the presubmit API that are not backwards compatible.
1457 if self.committing:
1458 function_name = 'CheckChangeOnCommit'
1459 else:
1460 function_name = 'CheckChangeOnUpload'
1461 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001462 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001463 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001464 logging.debug('Running %s in %s', function_name, presubmit_path)
1465 result = eval(function_name + '(*__args)', context)
1466 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001467 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001468 finally:
1469 map(os.remove, input_api._named_temporary_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001470 if not (isinstance(result, types.TupleType) or
1471 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001472 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473 'Presubmit functions must return a tuple or list')
1474 for item in result:
1475 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001476 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001477 'All presubmit results must be of types derived from '
1478 'output_api.PresubmitResult')
1479 else:
1480 result = () # no error since the script doesn't care about current event.
1481
chase@chromium.org8e416c82009-10-06 04:30:44 +00001482 # Return the process to the original working directory.
1483 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001484 return result
1485
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001486def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001487 committing,
1488 verbose,
1489 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001490 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001491 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001492 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001493 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001494 dry_run=None,
1495 parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001496 """Runs all presubmit checks that apply to the files in the change.
1497
1498 This finds all PRESUBMIT.py files in directories enclosing the files in the
1499 change (up to the repository root) and calls the relevant entrypoint function
1500 depending on whether the change is being committed or uploaded.
1501
1502 Prints errors, warnings and notifications. Prompts the user for warnings
1503 when needed.
1504
1505 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001506 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001507 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001508 verbose: Prints debug info.
1509 output_stream: A stream to write output from presubmit tests to.
1510 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001511 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001512 may_prompt: Enable (y/n) questions on warning or error. If False,
1513 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001514 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001515 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001516 parallel: if true, all tests specified by input_api.RunTests in all
1517 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001519 Warning:
1520 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1521 SHOULD be sys.stdin.
1522
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001524 A PresubmitOutput object. Use output.should_continue() to figure out
1525 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001526 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001527 old_environ = os.environ
1528 try:
1529 # Make sure python subprocesses won't generate .pyc files.
1530 os.environ = os.environ.copy()
1531 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001533 output = PresubmitOutput(input_stream, output_stream)
1534 if committing:
1535 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001536 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001537 output.write("Running presubmit upload checks ...\n")
1538 start_time = time.time()
1539 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001540 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001541 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001542 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001543 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001544 thread_pool = ThreadPool()
Aaron Gable668c1d82018-04-03 10:19:16 -07001545 executer = PresubmitExecuter(change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001546 gerrit_obj, dry_run, thread_pool)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001547 if default_presubmit:
1548 if verbose:
1549 output.write("Running default presubmit script.\n")
1550 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1551 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1552 for filename in presubmit_files:
1553 filename = os.path.abspath(filename)
1554 if verbose:
1555 output.write("Running %s\n" % filename)
1556 # Accept CRLF presubmit script.
1557 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1558 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001559
Edward Lesmes8e282792018-04-03 18:50:29 -04001560 results += thread_pool.RunAsync()
1561
Daniel Cheng7227d212017-11-17 08:12:37 -08001562 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001563 errors = []
1564 notifications = []
1565 warnings = []
1566 for result in results:
1567 if result.fatal:
1568 errors.append(result)
1569 elif result.should_prompt:
1570 warnings.append(result)
1571 else:
1572 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001573
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001574 output.write('\n')
1575 for name, items in (('Messages', notifications),
1576 ('Warnings', warnings),
1577 ('ERRORS', errors)):
1578 if items:
1579 output.write('** Presubmit %s **\n' % name)
1580 for item in items:
1581 item.handle(output)
1582 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001583
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001584 total_time = time.time() - start_time
1585 if total_time > 1.0:
1586 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001587
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001588 if errors:
1589 output.fail()
1590 elif warnings:
1591 output.write('There were presubmit warnings. ')
1592 if may_prompt:
1593 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1594 else:
1595 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001596
1597 global _ASKED_FOR_FEEDBACK
1598 # Ask for feedback one time out of 5.
1599 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001600 output.write(
1601 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1602 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1603 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001604 _ASKED_FOR_FEEDBACK = True
1605 return output
1606 finally:
1607 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001608
1609
1610def ScanSubDirs(mask, recursive):
1611 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001612 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001613
1614 results = []
1615 for root, dirs, files in os.walk('.'):
1616 if '.svn' in dirs:
1617 dirs.remove('.svn')
1618 if '.git' in dirs:
1619 dirs.remove('.git')
1620 for name in files:
1621 if fnmatch.fnmatch(name, mask):
1622 results.append(os.path.join(root, name))
1623 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001624
1625
1626def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001627 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001628 files = []
1629 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001630 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001631 return files
1632
1633
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001634def load_files(options, args):
1635 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001636 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001637 if args:
1638 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001639 change_scm = scm.determine_scm(options.root)
1640 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001641 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001642 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001643 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001644 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001645 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001646 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001647 if not files:
1648 return None, None
1649 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001650 return change_class, files
1651
1652
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001653@contextlib.contextmanager
1654def canned_check_filter(method_names):
1655 filtered = {}
1656 try:
1657 for method_name in method_names:
1658 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001659 logging.warn('Skipping unknown "canned" check %s' % method_name)
1660 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001661 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1662 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1663 yield
1664 finally:
1665 for name, method in filtered.iteritems():
1666 setattr(presubmit_canned_checks, name, method)
1667
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001668
sbc@chromium.org013731e2015-02-26 18:28:43 +00001669def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001670 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001671 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001672 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001673 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001674 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1675 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001676 parser.add_option("-r", "--recursive", action="store_true",
1677 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001678 parser.add_option("-v", "--verbose", action="count", default=0,
1679 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001680 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001681 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001682 parser.add_option("--description", default='')
1683 parser.add_option("--issue", type='int', default=0)
1684 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001685 parser.add_option("--root", default=os.getcwd(),
1686 help="Search for PRESUBMIT.py up to this directory. "
1687 "If inherit-review-settings-ok is present in this "
1688 "directory, parent directories up to the root file "
1689 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001690 parser.add_option("--upstream",
1691 help="Git only: the base ref or upstream branch against "
1692 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001693 parser.add_option("--default_presubmit")
1694 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001695 parser.add_option("--skip_canned", action='append', default=[],
1696 help="A list of checks to skip which appear in "
1697 "presubmit_canned_checks. Can be provided multiple times "
1698 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001699 parser.add_option("--dry_run", action='store_true',
1700 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001701 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001702 parser.add_option("--gerrit_fetch", action='store_true',
1703 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001704 parser.add_option('--parallel', action='store_true',
1705 help='Run all tests specified by input_api.RunTests in all '
1706 'PRESUBMIT files in parallel.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001707
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001708 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001709
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001710 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001711 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001712 elif options.verbose:
1713 logging.basicConfig(level=logging.INFO)
1714 else:
1715 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001716
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001717 change_class, files = load_files(options, args)
1718 if not change_class:
1719 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001720 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001721
Aaron Gable668c1d82018-04-03 10:19:16 -07001722 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001723 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001724 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001725 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1726 options.author = gerrit_obj.GetChangeOwner(options.issue)
1727 options.description = gerrit_obj.GetChangeDescription(options.issue,
1728 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001729 logging.info('Got author: "%s"', options.author)
1730 logging.info('Got description: """\n%s\n"""', options.description)
1731
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001732 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001733 with canned_check_filter(options.skip_canned):
1734 results = DoPresubmitChecks(
1735 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001736 options.description,
1737 options.root,
1738 files,
1739 options.issue,
1740 options.patchset,
1741 options.author,
1742 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001743 options.commit,
1744 options.verbose,
1745 sys.stdout,
1746 sys.stdin,
1747 options.default_presubmit,
1748 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001749 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001750 options.dry_run,
1751 options.parallel)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001752 return not results.should_continue()
1753 except PresubmitFailure, e:
1754 print >> sys.stderr, e
1755 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001756 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001757
1758
1759if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001760 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001761 try:
1762 sys.exit(main())
1763 except KeyboardInterrupt:
1764 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001765 sys.exit(2)