blob: 7e80e27095325bdf8a0f758d89ba611b8ca2633b [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020041#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020042#include "rtc_base/arraysize.h"
43#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020044#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/stringutils.h"
46#include "test/field_trial.h"
47#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000048
Tommi85959932018-02-07 19:26:06 +010049using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010050using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070051using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010052using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070053
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000054namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000055static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000056
noahricd10a68e2015-07-10 11:27:55 -070057static const uint8_t kRedRtxPayloadType = 125;
58
Niels Möller6557d0c2018-04-11 15:18:34 +020059static const uint32_t kTimeout = 5000U;
60static const uint32_t kDefaultReceiveSsrc = 0;
61static const uint32_t kSsrc = 1234u;
62static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
63static const int kVideoWidth = 640;
64static const int kVideoHeight = 360;
65static const int kFramerate = 30;
66
Peter Boström0c4e06b2015-10-07 12:23:21 +020067static const uint32_t kSsrcs1[] = {1};
68static const uint32_t kSsrcs3[] = {1, 2, 3};
69static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080070static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080072static const uint32_t kDefaultRecvSsrc = 0;
73
pbos@webrtc.org3c107582014-07-20 15:27:35 +000074static const char kUnsupportedExtensionName[] =
75 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000076
magjed509e4fe2016-11-18 01:34:11 -080077cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
78 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020079 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080080}
81
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000082void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
83 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
84 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
85 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
86 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080090 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
93}
94
magjed725e4842016-11-16 00:48:13 -080095// Return true if any codec in |codecs| is an RTX codec with associated payload
96// type |payload_type|.
97bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
98 int payload_type) {
99 for (const cricket::VideoCodec& codec : codecs) {
100 int associated_payload_type;
101 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
102 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
103 &associated_payload_type) &&
104 associated_payload_type == payload_type) {
105 return true;
106 }
107 }
108 return false;
109}
110
nisseca5706d2017-09-11 02:32:16 -0700111// TODO(nisse): Duplicated in call.cc.
112const int* FindKeyByValue(const std::map<int, int>& m, int v) {
113 for (const auto& kv : m) {
114 if (kv.second == v)
115 return &kv.first;
116 }
117 return nullptr;
118}
119
Yves Gerey665174f2018-06-19 15:03:05 +0200120bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
121 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700122 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
123 payload_type) != nullptr;
124}
125
126// Check that there's an Rtx payload type for each decoder.
127bool VerifyRtxReceiveAssociations(
128 const webrtc::VideoReceiveStream::Config& config) {
129 for (const auto& decoder : config.decoders) {
130 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
131 return false;
132 }
133 return true;
134}
135
brandtrffc61182016-11-28 06:02:22 -0800136rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700137 int width,
138 int height) {
139 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
140 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800141 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700142 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000143}
144
Shao Changbine62202f2015-04-21 20:24:50 +0800145void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
146 const std::map<int, int>& rtx_types) {
147 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200148 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800149 EXPECT_TRUE(it != rtx_types.end() &&
150 it->second == config.rtp.rtx.payload_type);
151
brandtrb5f2c3f2016-10-04 23:28:39 -0700152 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
153 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800154 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 }
157}
kthelgason2bc68642017-02-07 07:02:22 -0800158
159cricket::MediaConfig GetMediaConfig() {
160 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100161 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800162 return media_config;
163}
nisse26e3abb2017-08-25 04:44:25 -0700164
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200165// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
166int GetMaxDefaultBitrateBps(size_t width, size_t height) {
167 if (width * height <= 320 * 240) {
168 return 600000;
169 } else if (width * height <= 640 * 480) {
170 return 1700000;
171 } else if (width * height <= 960 * 540) {
172 return 2000000;
173 } else {
174 return 2500000;
175 }
176}
177
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000178} // namespace
179
Yves Gerey665174f2018-06-19 15:03:05 +0200180#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200181 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200182 EXPECT_EQ((w), renderer_.width()); \
183 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200184 EXPECT_EQ(0, renderer_.errors());
185
Yves Gerey665174f2018-06-19 15:03:05 +0200186#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200187 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200188 EXPECT_EQ((w), (r).width()); \
189 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200190 EXPECT_EQ(0, (r).errors());
191
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000192namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700193class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000194 public:
eladalonf1841382017-06-12 01:16:46 -0700195 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
196 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700197 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700198 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200199 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
200 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200201 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200202 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200203 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200204 decoder_factory_)) {}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205
206 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200207 void AssignDefaultAptRtxTypes();
208 void AssignDefaultCodec();
209
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100210 // Find the index of the codec in the engine with the given name. The codec
211 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100212 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100213
magjed509e4fe2016-11-18 01:34:11 -0800214 // Find the codec in the engine with the given name. The codec must be
215 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100216 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800217
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200218 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000219
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200220 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000221 const std::vector<VideoCodec>& codecs);
222
Peter Boströme4499152016-02-05 11:13:28 +0100223 void TestExtendedEncoderOveruse(bool use_external_encoder);
224
stefanc1aeaf02015-10-15 07:26:07 -0700225 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700226 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700227 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000228 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800229 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200230 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
231 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700232 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000233 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800234 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000235};
236
eladalonf1841382017-06-12 01:16:46 -0700237TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200238 encoder_factory_->AddSupportedVideoCodecType("VP8");
239 AssignDefaultCodec();
240
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000241 std::vector<VideoCodec> engine_codecs = engine_.codecs();
242 for (size_t i = 0; i < engine_codecs.size(); ++i) {
243 if (engine_codecs[i].name != kRtxCodecName)
244 continue;
245 int associated_payload_type;
246 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000247 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000248 EXPECT_EQ(default_codec_.id, associated_payload_type);
249 return;
250 }
251 FAIL() << "No RTX codec found among default codecs.";
252}
253
eladalonf1841382017-06-12 01:16:46 -0700254TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100255 RtpCapabilities capabilities = engine_.GetCapabilities();
256 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700257 for (const RtpExtension& extension : capabilities.header_extensions) {
258 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
259 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000260 return;
261 }
262 }
263 FAIL() << "Timestamp offset extension not in header-extension list.";
264}
265
eladalonf1841382017-06-12 01:16:46 -0700266TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100267 RtpCapabilities capabilities = engine_.GetCapabilities();
268 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700269 for (const RtpExtension& extension : capabilities.header_extensions) {
270 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
271 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000272 return;
273 }
274 }
275 FAIL() << "Absolute Sender Time extension not in header-extension list.";
276}
277
eladalonf1841382017-06-12 01:16:46 -0700278TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100279 RtpCapabilities capabilities = engine_.GetCapabilities();
280 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700281 for (const RtpExtension& extension : capabilities.header_extensions) {
282 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
283 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700284 return;
285 }
286 }
287 FAIL() << "Transport sequence number extension not in header-extension list.";
288}
289
eladalonf1841382017-06-12 01:16:46 -0700290TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100291 RtpCapabilities capabilities = engine_.GetCapabilities();
292 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700293 for (const RtpExtension& extension : capabilities.header_extensions) {
294 if (extension.uri == RtpExtension::kVideoRotationUri) {
295 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700296 return;
297 }
298 }
299 FAIL() << "Video Rotation extension not in header-extension list.";
300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700303 // Allocate the capturer first to prevent early destruction before channel's
304 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100305 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700306
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200307 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700308
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200309 std::unique_ptr<VideoMediaChannel> channel(
310 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700311 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
312
313 // Add CVO extension.
314 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800315 cricket::VideoSendParameters parameters;
316 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200317 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700318 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200319 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700320
321 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200322 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700323
324 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700325 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700326
327 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200328 parameters.extensions.clear();
329 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700330 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700331}
332
eladalonf1841382017-06-12 01:16:46 -0700333TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
perkj91e1c152016-03-02 05:34:00 -0800334 // Allocate the capturer first to prevent early destruction before channel's
335 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100336 FakeVideoCapturerWithTaskQueue capturer;
perkj91e1c152016-03-02 05:34:00 -0800337
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200338 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800339
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200340 std::unique_ptr<VideoMediaChannel> channel(
341 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800342 // Add CVO extension.
343 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800344 cricket::VideoSendParameters parameters;
345 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800346 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700347 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800348 EXPECT_TRUE(channel->SetSendParameters(parameters));
349 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
350
351 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200352 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
perkj91e1c152016-03-02 05:34:00 -0800353
354 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700355 EXPECT_FALSE(capturer.apply_rotation());
perkj91e1c152016-03-02 05:34:00 -0800356}
357
eladalonf1841382017-06-12 01:16:46 -0700358TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Tommi85959932018-02-07 19:26:06 +0100359 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700360
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200361 encoder_factory_->AddSupportedVideoCodecType("VP8");
362 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200364 std::unique_ptr<VideoMediaChannel> channel(
365 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
367
368 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200369 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
perkjcaafdba2016-03-20 07:34:29 -0700371 // Verify capturer has turned on applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700372 EXPECT_TRUE(capturer.apply_rotation());
perkjcaafdba2016-03-20 07:34:29 -0700373
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700374 // Add CVO extension.
375 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800376 cricket::VideoSendParameters parameters;
377 parameters.codecs.push_back(GetEngineCodec("VP8"));
378 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200379 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700380 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700381 // Also remove the first codec to trigger a codec change as well.
382 parameters.codecs.erase(parameters.codecs.begin());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200383 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700384
385 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700386 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700387
388 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200389 parameters.extensions.clear();
390 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700391 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392}
393
eladalonf1841382017-06-12 01:16:46 -0700394TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200395 encoder_factory_->AddSupportedVideoCodecType("VP8");
396
kwiberg686a8ef2016-02-26 03:00:35 -0800397 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800398 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000399
400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
401
402 EXPECT_FALSE(channel->SetSend(true))
403 << "Channel should not start without codecs.";
404 EXPECT_TRUE(channel->SetSend(false))
405 << "Channel should be stoppable even without set codecs.";
406}
407
eladalonf1841382017-06-12 01:16:46 -0700408TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
410
kwiberg686a8ef2016-02-26 03:00:35 -0800411 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800412 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000413 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
414 VideoMediaInfo info;
415 channel->GetStats(&info);
416}
417
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200418TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200419 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000420
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200421 std::unique_ptr<VideoMediaChannel> channel(
422 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800423 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000424
425 EXPECT_TRUE(
426 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200427 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000428 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100429 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200430 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000431 EXPECT_EQ(cricket::CS_RUNNING,
432 capturer.Start(capturer.GetSupportedFormats()->front()));
433 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100434 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200435 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
436 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000437 kTimeout);
438
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200439 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100440 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000441
442 // Setting codecs of the same type should not reallocate any encoders
443 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800444 cricket::VideoSendParameters parameters;
445 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200446 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200447 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000448
449 // Remove stream previously added to free the external encoder instance.
450 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200451 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000452}
453
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200454// Test that when an encoder factory supports H264, we add an RTX
455// codec for it.
456// TODO(deadbeef): This test should be updated if/when we start
457// adding RTX codecs for unrecognized codec names.
458TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800459 using webrtc::H264::ProfileLevelIdToString;
460 using webrtc::H264::ProfileLevelId;
461 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200462 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
463 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800464 *ProfileLevelIdToString(
465 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200466 webrtc::SdpVideoFormat h264_constrained_high("H264");
467 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800468 *ProfileLevelIdToString(
469 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200470 webrtc::SdpVideoFormat h264_high("H264");
471 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800472 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
473
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200474 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
475 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
476 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700477
magjed725e4842016-11-16 00:48:13 -0800478 // First figure out what payload types the test codecs got assigned.
479 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800480 // Now search for RTX codecs for them. Expect that they all have associated
481 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800482 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200483 codecs,
484 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
485 ->id));
magjed725e4842016-11-16 00:48:13 -0800486 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200487 codecs,
488 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
489 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800490 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200491 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700492}
493
Peter Boström12996152016-05-14 02:03:18 +0200494#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700495TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200496 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100497
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200498 std::unique_ptr<VideoMediaChannel> channel(
499 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100500
501 EXPECT_TRUE(
502 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
503}
Peter Boström12996152016-05-14 02:03:18 +0200504#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100505
eladalonf1841382017-06-12 01:16:46 -0700506TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200507 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100508 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200509 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200510 std::unique_ptr<VideoMediaChannel> channel(
511 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700512
513 EXPECT_TRUE(
514 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
515
Tommi85959932018-02-07 19:26:06 +0100516 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200517 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700518 capturer.Start(cricket::VideoFormat(1280, 720,
519 cricket::VideoFormat::FpsToInterval(60),
520 cricket::FOURCC_I420));
521 channel->SetSend(true);
522
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200523 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700524
525 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700526 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700527 for (int i = 0; i < 10; i++) {
528 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700529 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700530 int64_t interval = timestamp - last_timestamp;
531
532 // Precision changes from nanosecond to millisecond.
533 // Allow error to be no more than 1.
534 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
535
536 last_timestamp = timestamp;
537 }
538
539 capturer.Start(cricket::VideoFormat(1280, 720,
540 cricket::VideoFormat::FpsToInterval(30),
541 cricket::FOURCC_I420));
542
543 EXPECT_TRUE(capturer.CaptureFrame());
544 last_timestamp = stream->GetLastTimestamp();
545 for (int i = 0; i < 10; i++) {
546 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700547 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700548 int64_t interval = timestamp - last_timestamp;
549
550 // Precision changes from nanosecond to millisecond.
551 // Allow error to be no more than 1.
552 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
553
554 last_timestamp = timestamp;
555 }
556
557 // Remove stream previously added to free the external encoder instance.
558 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
559}
560
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200561void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
562 std::vector<VideoCodec> engine_codecs = engine_.codecs();
563 RTC_DCHECK(!engine_codecs.empty());
564 for (const cricket::VideoCodec& codec : engine_codecs) {
565 if (codec.name == "rtx") {
566 int associated_payload_type;
567 if (codec.GetParam(kCodecParamAssociatedPayloadType,
568 &associated_payload_type)) {
569 default_apt_rtx_types_[associated_payload_type] = codec.id;
570 }
571 }
572 }
573}
574
575void WebRtcVideoEngineTest::AssignDefaultCodec() {
576 std::vector<VideoCodec> engine_codecs = engine_.codecs();
577 RTC_DCHECK(!engine_codecs.empty());
578 bool codec_set = false;
579 for (const cricket::VideoCodec& codec : engine_codecs) {
580 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
581 codec.name != "ulpfec") {
582 default_codec_ = codec;
583 codec_set = true;
584 }
585 }
586
587 RTC_DCHECK(codec_set);
588}
589
Oleh Prypina40f8242017-12-21 13:32:23 +0100590size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
591 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100592 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
593 for (size_t i = 0; i < codecs.size(); ++i) {
594 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200595 if (!CodecNamesEq(name, engine_codec.name))
596 continue;
597 // The tests only use H264 Constrained Baseline. Make sure we don't return
598 // an internal H264 codec from the engine with a different H264 profile.
599 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200600 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200601 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
602 if (profile_level_id->profile !=
603 webrtc::H264::kProfileConstrainedBaseline) {
604 continue;
605 }
606 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100607 return i;
magjed509e4fe2016-11-18 01:34:11 -0800608 }
609 // This point should never be reached.
610 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100611 return -1;
612}
613
614cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
615 const std::string& name) const {
616 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800617}
618
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200619VideoMediaChannel*
620WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000621 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800622 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200623 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800624 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200625 for (const webrtc::SdpVideoFormat& format :
626 encoder_factory_->GetSupportedFormats()) {
627 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
628 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
629 engine_codec) == parameters.codecs.end()) {
630 parameters.codecs.push_back(engine_codec);
631 }
632 }
magjed509e4fe2016-11-18 01:34:11 -0800633
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200634 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000635
636 return channel;
637}
638
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200639VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000640 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000641 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800642 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200643 cricket::VideoRecvParameters parameters;
644 parameters.codecs = codecs;
645 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000646
647 return channel;
648}
649
eladalonf1841382017-06-12 01:16:46 -0700650TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200651 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000652
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200653 std::unique_ptr<VideoMediaChannel> channel(
654 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000655
Peter Boström0c4e06b2015-10-07 12:23:21 +0200656 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000657
Yves Gerey665174f2018-06-19 15:03:05 +0200658 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000659 EXPECT_TRUE(channel->SetSend(true));
660
Tommi85959932018-02-07 19:26:06 +0100661 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200662 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000663 EXPECT_EQ(cricket::CS_RUNNING,
664 capturer.Start(capturer.GetSupportedFormats()->front()));
665 EXPECT_TRUE(capturer.CaptureFrame());
666
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200667 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000668
669 // Verify that encoders are configured for simulcast through adapter
670 // (increasing resolution and only configured to send one stream each).
671 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200672 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
673 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000674 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200675 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000676 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
677 EXPECT_GT(codec_settings.width, prev_width);
678 prev_width = codec_settings.width;
679 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000680
Niels Möllerff40b142018-04-09 08:49:14 +0200681 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000682
683 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200684 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000685}
686
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200687TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
688 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200689 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
Niels Möller4db138e2018-04-19 09:04:13 +0200691 // Set capturer.
692 FakeVideoCapturerWithTaskQueue capturer;
693 EXPECT_EQ(cricket::CS_RUNNING,
694 capturer.Start(capturer.GetSupportedFormats()->front()));
695
Anders Carlsson67537952018-05-03 11:28:29 +0200696 std::unique_ptr<VideoMediaChannel> channel(
697 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
698 cricket::VideoSendParameters parameters;
699 parameters.codecs.push_back(GetEngineCodec("H264"));
700 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000701
702 EXPECT_TRUE(
703 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200704 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
705 // Sending one frame will have allocate the encoder.
706 EXPECT_TRUE(capturer.CaptureFrame());
707
708 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000709
Anders Carlsson67537952018-05-03 11:28:29 +0200710 cricket::VideoSendParameters new_parameters;
711 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
712 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200713
714 // Sending one frame will switch encoder.
715 EXPECT_TRUE(capturer.CaptureFrame());
716
Anders Carlsson8a150d92018-05-14 12:40:04 +0200717 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000718}
719
eladalonf1841382017-06-12 01:16:46 -0700720TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000721 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 encoder_factory_->AddSupportedVideoCodecType("VP8");
723 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000724
kwiberg686a8ef2016-02-26 03:00:35 -0800725 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800726 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800727 cricket::VideoSendParameters parameters;
728 parameters.codecs.push_back(GetEngineCodec("VP8"));
729 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000730
Peter Boström0c4e06b2015-10-07 12:23:21 +0200731 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000732
Yves Gerey665174f2018-06-19 15:03:05 +0200733 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000734 EXPECT_TRUE(channel->SetSend(true));
735
736 // Send a fake frame, or else the media engine will configure the simulcast
737 // encoder adapter at a low-enough size that it'll only create a single
738 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100739 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200740 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000741 EXPECT_EQ(cricket::CS_RUNNING,
742 capturer.Start(capturer.GetSupportedFormats()->front()));
743 EXPECT_TRUE(capturer.CaptureFrame());
744
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200745 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
746 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000747 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200748 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000749
750 channel.reset();
751 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200752 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000753}
754
eladalonf1841382017-06-12 01:16:46 -0700755TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000756 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200757 encoder_factory_->AddSupportedVideoCodecType("VP8");
758 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000759
kwiberg686a8ef2016-02-26 03:00:35 -0800760 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800761 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800762 cricket::VideoSendParameters parameters;
763 parameters.codecs.push_back(GetEngineCodec("H264"));
764 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000765
766 EXPECT_TRUE(
767 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100768
769 // Send a frame of 720p. This should trigger a "real" encoder initialization.
770 cricket::VideoFormat format(
771 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100772 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200773 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100774 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
775 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200776 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
777 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200778 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200780 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000781
782 channel.reset();
783 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000785}
786
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200787TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
788 webrtc::test::ScopedFieldTrials override_field_trials_(
789 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200790 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700791
Anders Carlsson67537952018-05-03 11:28:29 +0200792 std::unique_ptr<VideoMediaChannel> channel(
793 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
794 cricket::VideoSendParameters parameters;
795 parameters.codecs.push_back(GetEngineCodec("H264"));
796 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700797
Peter Boström0c4e06b2015-10-07 12:23:21 +0200798 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700799 EXPECT_TRUE(
800 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100801
802 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700803 cricket::VideoFormat format(
804 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100805 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200806 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100807 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
808 EXPECT_TRUE(capturer.CaptureFrame());
809
Niels Möller4db138e2018-04-19 09:04:13 +0200810 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 ASSERT_EQ(1u, encoder_factory_->encoders().size());
812 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
813 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700814 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200815 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200816 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700817}
818
brandtrffc61182016-11-28 06:02:22 -0800819// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700820// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800821//
822// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700823TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800824 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200825 encoder_factory_->AddSupportedVideoCodecType("VP8");
826
brandtrffc61182016-11-28 06:02:22 -0800827 auto is_flexfec = [](const VideoCodec& codec) {
828 if (codec.name == "flexfec-03")
829 return true;
830 return false;
831 };
832
833 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800834 const std::vector<VideoCodec> codecs_before = engine_.codecs();
835 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
836 codecs_before.end(), is_flexfec));
837
838 // FlexFEC is active with field trial.
839 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800840 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800841 const std::vector<VideoCodec> codecs_after = engine_.codecs();
842 EXPECT_NE(codecs_after.end(),
843 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
844}
845
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200846// Test that codecs are added in the order they are reported from the factory.
847TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
848 encoder_factory_->AddSupportedVideoCodecType("VP8");
849 const char* kFakeCodecName = "FakeCodec";
850 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000851
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200852 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100853 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200854 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
855 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000856}
857
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200858// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800859// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200860TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100861 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
862 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100863
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100864 // Set up external encoder factory with first codec, and initialize engine.
865 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
866
brandtrffc61182016-11-28 06:02:22 -0800867 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800868
869 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100870 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800871 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
872 EXPECT_EQ(codecs_before.size() + 1, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100873
874 // Check that both fake codecs are present and that the second fake codec
875 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100876 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
877 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100878 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800879}
880
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200881TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
882 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200883 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200884 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800885 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000886
kwiberg686a8ef2016-02-26 03:00:35 -0800887 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200888 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000889
890 EXPECT_TRUE(
891 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200892 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000893
894 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200895 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200896 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000897
898 // Remove stream previously added to free the external decoder instance.
899 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200900 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000901}
902
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200903// Verifies that we can set up decoders.
904TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000905 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
906 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
907 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
908 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200909 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200910 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000911 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800912 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000913
kwiberg686a8ef2016-02-26 03:00:35 -0800914 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000916
917 EXPECT_TRUE(
918 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200919 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000920}
921
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200922TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
923 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
924 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
925 WebRtcVideoEngine engine(std::move(encoder_factory),
926 std::move(decoder_factory));
927 EXPECT_EQ(0u, engine.codecs().size());
928}
929
930TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
931 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700932 webrtc::MockVideoEncoderFactory* encoder_factory =
933 new webrtc::MockVideoEncoderFactory();
934 webrtc::MockVideoDecoderFactory* decoder_factory =
935 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200936 WebRtcVideoEngine engine(
937 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
938 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
939 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
940 EXPECT_EQ(0u, engine.codecs().size());
941 EXPECT_CALL(*encoder_factory, Die());
942 EXPECT_CALL(*decoder_factory, Die());
943}
944
945// Test full behavior in the video engine when video codec factories of the new
946// type are injected supporting the single codec Vp8. Check the returned codecs
947// from the engine and that we will create a Vp8 encoder and decoder using the
948// new factories.
949TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
950 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700951 webrtc::MockVideoEncoderFactory* encoder_factory =
952 new webrtc::MockVideoEncoderFactory();
953 webrtc::MockVideoDecoderFactory* decoder_factory =
954 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200955 WebRtcVideoEngine engine(
956 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
957 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
958 const webrtc::SdpVideoFormat vp8_format("VP8");
959 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
960 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
961 .WillRepeatedly(testing::Return(supported_formats));
962
963 // Verify the codecs from the engine.
964 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100965 // Verify default codecs has been added correctly.
966 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200967 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100968
969 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200970 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100971 int vp8_associated_payload;
972 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
973 &vp8_associated_payload));
974 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
975
976 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
977
978 // RTX codec for RED.
979 EXPECT_EQ("rtx", engine_codecs.at(3).name);
980 int red_associated_payload;
981 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
982 &red_associated_payload));
983 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
984
985 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
986
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200987 int associated_payload_type;
988 EXPECT_TRUE(engine_codecs.at(1).GetParam(
989 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
990 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
991 // Verify default parameters has been added to the VP8 codec.
992 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
993
994 // Mock encoder creation. |engine| take ownership of the encoder.
995 webrtc::VideoEncoderFactory::CodecInfo codec_info;
996 codec_info.is_hardware_accelerated = false;
997 codec_info.has_internal_source = false;
998 const webrtc::SdpVideoFormat format("VP8");
999 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1000 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001001 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001002 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001003 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001004 .WillOnce(
1005 ::testing::DoAll(::testing::InvokeWithoutArgs(
1006 [&encoder_created]() { encoder_created.Set(); }),
1007 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008
1009 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001010 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001011 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1012 .WillOnce(testing::Return(decoder));
1013
1014 // Create a call.
1015 webrtc::RtcEventLogNullImpl event_log;
1016 std::unique_ptr<webrtc::Call> call(
1017 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1018
1019 // Create send channel.
1020 const int send_ssrc = 123;
1021 std::unique_ptr<VideoMediaChannel> send_channel(
1022 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1023 cricket::VideoSendParameters send_parameters;
1024 send_parameters.codecs.push_back(engine_codecs.at(0));
1025 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1026 send_channel->OnReadyToSend(true);
1027 EXPECT_TRUE(
1028 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1029 EXPECT_TRUE(send_channel->SetSend(true));
1030
Niels Möller4db138e2018-04-19 09:04:13 +02001031 // Set capturer.
1032 FakeVideoCapturerWithTaskQueue capturer;
1033 EXPECT_EQ(cricket::CS_RUNNING,
1034 capturer.Start(capturer.GetSupportedFormats()->front()));
1035 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1036 // Sending one frame will allocate the encoder.
1037 EXPECT_TRUE(capturer.CaptureFrame());
1038 encoder_created.Wait(kTimeout);
1039
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001040 // Create recv channel.
1041 const int recv_ssrc = 321;
1042 std::unique_ptr<VideoMediaChannel> recv_channel(
1043 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1044 cricket::VideoRecvParameters recv_parameters;
1045 recv_parameters.codecs.push_back(engine_codecs.at(0));
1046 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1047 EXPECT_TRUE(recv_channel->AddRecvStream(
1048 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1049
1050 // Remove streams previously added to free the encoder and decoder instance.
1051 EXPECT_CALL(*encoder_factory, Die());
1052 EXPECT_CALL(*decoder_factory, Die());
1053 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1054 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1055}
1056
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001057// Test behavior when decoder factory fails to create a decoder (returns null).
1058TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1059 // |engine| take ownership of the factories.
1060 webrtc::MockVideoEncoderFactory* encoder_factory =
1061 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1062 webrtc::MockVideoDecoderFactory* decoder_factory =
1063 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1064 WebRtcVideoEngine engine(
1065 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1066 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1067 const webrtc::SdpVideoFormat vp8_format("VP8");
1068 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1069 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1070 .WillRepeatedly(testing::Return(supported_formats));
1071
1072 // Decoder creation fails.
1073 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1074 .WillOnce(testing::Return(nullptr));
1075
1076 // Create a call.
1077 webrtc::RtcEventLogNullImpl event_log;
1078 std::unique_ptr<webrtc::Call> call(
1079 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1080
1081 // Create recv channel.
1082 const int recv_ssrc = 321;
1083 std::unique_ptr<VideoMediaChannel> recv_channel(
1084 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1085 cricket::VideoRecvParameters recv_parameters;
1086 recv_parameters.codecs.push_back(engine.codecs().front());
1087 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1088 EXPECT_TRUE(recv_channel->AddRecvStream(
1089 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1090
1091 // Remove streams previously added to free the encoder and decoder instance.
1092 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1093}
1094
eladalonf1841382017-06-12 01:16:46 -07001095TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001096 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001097 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001098 std::unique_ptr<VideoMediaChannel> channel(
1099 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001100 ASSERT_TRUE(
1101 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1102 cricket::VideoCodec codec = GetEngineCodec("VP8");
1103 cricket::VideoSendParameters parameters;
1104 parameters.codecs.push_back(codec);
1105 channel->OnReadyToSend(true);
1106 channel->SetSend(true);
1107 ASSERT_TRUE(channel->SetSendParameters(parameters));
1108
Tommi85959932018-02-07 19:26:06 +01001109 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001110 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001111 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001112
1113 EXPECT_EQ(cricket::CS_RUNNING,
1114 capturer.Start(capturer.GetSupportedFormats()->front()));
1115 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001116 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001117 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001118 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001119
Niels Möllerff40b142018-04-09 08:49:14 +02001120 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001121 EXPECT_TRUE(capturer.CaptureFrame());
1122 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001123 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001124
1125 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001126 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001127 EXPECT_TRUE(capturer.CaptureFrame());
1128 // Change to screen content, recreate encoder. For the simulcast encoder
1129 // adapter case, this will result in two calls since InitEncode triggers a
1130 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001131 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001132 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001133 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001134
Niels Möllerff40b142018-04-09 08:49:14 +02001135 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001136 EXPECT_TRUE(capturer.CaptureFrame());
1137 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001138 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001139
1140 options.is_screencast.emplace(false);
1141 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001142 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001143 // Change back to regular video content, update encoder. Also change
1144 // a non |is_screencast| option just to verify it doesn't affect recreation.
1145 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001146 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001147 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001148 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001149
1150 // Remove stream previously added to free the external encoder instance.
1151 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001152 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001153}
1154
Niels Möller6557d0c2018-04-11 15:18:34 +02001155class WebRtcVideoChannelBaseTest : public testing::Test {
1156 protected:
1157 WebRtcVideoChannelBaseTest()
1158 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001159 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1160 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001161
1162 virtual void SetUp() {
1163 cricket::MediaConfig media_config;
1164 // Disabling cpu overuse detection actually disables quality scaling too; it
1165 // implies DegradationPreference kMaintainResolution. Automatic scaling
1166 // needs to be disabled, otherwise, tests which check the size of received
1167 // frames become flaky.
1168 media_config.video.enable_cpu_adaptation = false;
1169 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1170 cricket::VideoOptions()));
1171 channel_->OnReadyToSend(true);
1172 EXPECT_TRUE(channel_.get() != NULL);
1173 network_interface_.SetDestination(channel_.get());
1174 channel_->SetInterface(&network_interface_);
1175 cricket::VideoRecvParameters parameters;
1176 parameters.codecs = engine_.codecs();
1177 channel_->SetRecvParameters(parameters);
1178 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1179 video_capturer_.reset(CreateFakeVideoCapturer());
1180 cricket::VideoFormat format(640, 480,
1181 cricket::VideoFormat::FpsToInterval(kFramerate),
1182 cricket::FOURCC_I420);
1183 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001184 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001185 }
1186
1187 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1188 return new cricket::FakeVideoCapturerWithTaskQueue();
1189 }
1190
1191 // Utility method to setup an additional stream to send and receive video.
1192 // Used to test send and recv between two streams.
1193 void SetUpSecondStream() {
1194 SetUpSecondStreamWithNoRecv();
1195 // Setup recv for second stream.
1196 EXPECT_TRUE(channel_->AddRecvStream(
1197 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1198 // Make the second renderer available for use by a new stream.
1199 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1200 }
1201 // Setup an additional stream just to send video. Defer add recv stream.
1202 // This is required if you want to test unsignalled recv of video rtp packets.
1203 void SetUpSecondStreamWithNoRecv() {
1204 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001205 EXPECT_TRUE(
1206 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001207 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001208 EXPECT_FALSE(
1209 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001210 EXPECT_TRUE(channel_->AddSendStream(
1211 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1212 // We dont add recv for the second stream.
1213
1214 // Setup the receive and renderer for second stream after send.
1215 video_capturer_2_.reset(CreateFakeVideoCapturer());
1216 cricket::VideoFormat format(640, 480,
1217 cricket::VideoFormat::FpsToInterval(kFramerate),
1218 cricket::FOURCC_I420);
1219 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1220
Yves Gerey665174f2018-06-19 15:03:05 +02001221 EXPECT_TRUE(
1222 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001223 }
Yves Gerey665174f2018-06-19 15:03:05 +02001224 virtual void TearDown() { channel_.reset(); }
1225 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001226
1227 bool SetOneCodec(const cricket::VideoCodec& codec) {
1228 cricket::VideoFormat capture_format(
1229 kVideoWidth, kVideoHeight,
1230 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1231
1232 if (video_capturer_) {
1233 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1234 }
1235 if (video_capturer_2_) {
1236 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1237 }
1238
1239 bool sending = channel_->sending();
1240 bool success = SetSend(false);
1241 if (success) {
1242 cricket::VideoSendParameters parameters;
1243 parameters.codecs.push_back(codec);
1244 success = channel_->SetSendParameters(parameters);
1245 }
1246 if (success) {
1247 success = SetSend(sending);
1248 }
1249 return success;
1250 }
Yves Gerey665174f2018-06-19 15:03:05 +02001251 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001252 bool SendFrame() {
1253 if (video_capturer_2_) {
1254 video_capturer_2_->CaptureFrame();
1255 }
1256 return video_capturer_.get() && video_capturer_->CaptureFrame();
1257 }
1258 bool WaitAndSendFrame(int wait_ms) {
1259 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1260 ret &= SendFrame();
1261 return ret;
1262 }
Yves Gerey665174f2018-06-19 15:03:05 +02001263 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001264 int NumRtpBytes(uint32_t ssrc) {
1265 return network_interface_.NumRtpBytes(ssrc);
1266 }
Yves Gerey665174f2018-06-19 15:03:05 +02001267 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001268 int NumRtpPackets(uint32_t ssrc) {
1269 return network_interface_.NumRtpPackets(ssrc);
1270 }
Yves Gerey665174f2018-06-19 15:03:05 +02001271 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001272 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1273 return network_interface_.GetRtpPacket(index);
1274 }
1275 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001276 webrtc::RTPHeader header;
1277 EXPECT_TRUE(ParseRtpPacket(p, &header));
1278 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001279 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001280
Niels Möller6557d0c2018-04-11 15:18:34 +02001281 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001282 webrtc::RTPHeader* header) {
1283 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1284 webrtc::RtpHeaderParser::Create());
1285 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001286 }
1287
1288 // Tests that we can send and receive frames.
1289 void SendAndReceive(const cricket::VideoCodec& codec) {
1290 EXPECT_TRUE(SetOneCodec(codec));
1291 EXPECT_TRUE(SetSend(true));
1292 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1293 EXPECT_EQ(0, renderer_.num_rendered_frames());
1294 EXPECT_TRUE(SendFrame());
1295 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1296 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1297 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1298 }
1299
1300 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001301 int duration_sec,
1302 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001303 EXPECT_TRUE(SetOneCodec(codec));
1304 EXPECT_TRUE(SetSend(true));
1305 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1306 EXPECT_EQ(0, renderer_.num_rendered_frames());
1307 for (int i = 0; i < duration_sec; ++i) {
1308 for (int frame = 1; frame <= fps; ++frame) {
1309 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1310 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1311 }
1312 }
1313 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1314 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1315 }
1316
Niels Möller6557d0c2018-04-11 15:18:34 +02001317 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1318 cricket::VideoMediaInfo info;
1319 EXPECT_TRUE(channel_->GetStats(&info));
1320 return info.senders[i];
1321 }
1322
1323 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1324 cricket::VideoMediaInfo info;
1325 EXPECT_TRUE(channel_->GetStats(&info));
1326 return info.receivers[i];
1327 }
1328
1329 // Two streams one channel tests.
1330
1331 // Tests that we can send and receive frames.
1332 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1333 SetUpSecondStream();
1334 // Test sending and receiving on first stream.
1335 SendAndReceive(codec);
1336 // Test sending and receiving on second stream.
1337 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1338 EXPECT_GT(NumRtpPackets(), 0);
1339 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1340 }
1341
1342 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1343 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1344 if (CodecNamesEq(name, engine_codec.name))
1345 return engine_codec;
1346 }
1347 // This point should never be reached.
1348 ADD_FAILURE() << "Unrecognized codec name: " << name;
1349 return cricket::VideoCodec();
1350 }
1351
1352 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1353
1354 cricket::StreamParams DefaultSendStreamParams() {
1355 return cricket::StreamParams::CreateLegacy(kSsrc);
1356 }
1357
1358 webrtc::RtcEventLogNullImpl event_log_;
1359 const std::unique_ptr<webrtc::Call> call_;
1360 WebRtcVideoEngine engine_;
1361 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1362 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1363 std::unique_ptr<WebRtcVideoChannel> channel_;
1364 cricket::FakeNetworkInterface network_interface_;
1365 cricket::FakeVideoRenderer renderer_;
1366
1367 // Used by test cases where 2 streams are run on the same channel.
1368 cricket::FakeVideoRenderer renderer2_;
1369};
1370
1371// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001372TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001373 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001374 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001375 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1376 EXPECT_FALSE(channel_->sending());
1377 EXPECT_TRUE(SetSend(true));
1378 EXPECT_TRUE(channel_->sending());
1379 EXPECT_TRUE(SendFrame());
1380 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1381 EXPECT_TRUE(SetSend(false));
1382 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001383}
Niels Möller6557d0c2018-04-11 15:18:34 +02001384
1385// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001386TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 EXPECT_FALSE(channel_->sending());
1388 EXPECT_FALSE(SetSend(true));
1389 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001390}
Niels Möller6557d0c2018-04-11 15:18:34 +02001391
1392// Test that we properly set the send and recv buffer sizes by the time
1393// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001394TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1396 EXPECT_TRUE(SetSend(true));
1397 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1398 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001399}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001400
Niels Möller6557d0c2018-04-11 15:18:34 +02001401// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001402TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001403 const int kDurationSec = 3;
1404 const int kFps = 10;
1405 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1406
1407 cricket::VideoMediaInfo info;
1408 EXPECT_TRUE(channel_->GetStats(&info));
1409
1410 ASSERT_EQ(1U, info.senders.size());
1411 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1412 // For webrtc, bytes_sent does not include the RTP header length.
1413 EXPECT_GT(info.senders[0].bytes_sent, 0);
1414 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1415 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1416 ASSERT_TRUE(info.senders[0].codec_payload_type);
1417 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1418 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1419 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1420 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1421 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1422 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1423 EXPECT_GT(info.senders[0].framerate_input, 0);
1424 EXPECT_GT(info.senders[0].framerate_sent, 0);
1425
1426 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1427 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1428 info.send_codecs[DefaultCodec().id]);
1429
1430 ASSERT_EQ(1U, info.receivers.size());
1431 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1432 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1433 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1434 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1435 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1436 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1437 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1438 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1439 EXPECT_EQ(0, info.receivers[0].packets_lost);
1440 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1441 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1442 EXPECT_EQ(0, info.receivers[0].firs_sent);
1443 EXPECT_EQ(0, info.receivers[0].plis_sent);
1444 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1445 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1446 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1447 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1448 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1449 EXPECT_GT(info.receivers[0].framerate_output, 0);
1450
1451 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1452 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1453 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001454}
Niels Möller6557d0c2018-04-11 15:18:34 +02001455
1456// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001457TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001458 cricket::FakeVideoRenderer renderer1, renderer2;
1459 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1460 cricket::VideoSendParameters parameters;
1461 parameters.codecs.push_back(DefaultCodec());
1462 parameters.conference_mode = true;
1463 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1464 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001465 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1466 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001467 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1468 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1469 EXPECT_EQ(0, renderer1.num_rendered_frames());
1470 EXPECT_EQ(0, renderer2.num_rendered_frames());
1471 std::vector<uint32_t> ssrcs;
1472 ssrcs.push_back(1);
1473 ssrcs.push_back(2);
1474 network_interface_.SetConferenceMode(true, ssrcs);
1475 EXPECT_TRUE(SendFrame());
1476 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1477 kTimeout);
1478 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1479 kTimeout);
1480
1481 EXPECT_TRUE(channel_->SetSend(false));
1482
1483 cricket::VideoMediaInfo info;
1484 EXPECT_TRUE(channel_->GetStats(&info));
1485 ASSERT_EQ(1U, info.senders.size());
1486 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1487 // For webrtc, bytes_sent does not include the RTP header length.
1488 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1489 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1490 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1491 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1492
1493 ASSERT_EQ(2U, info.receivers.size());
1494 for (size_t i = 0; i < info.receivers.size(); ++i) {
1495 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1496 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1497 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001498 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1500 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1501 }
srtee0c2eea2017-12-15 17:44:33 +01001502}
Niels Möller6557d0c2018-04-11 15:18:34 +02001503
1504// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001505TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001506 // Normal setup; note that we set the SSRC explicitly to ensure that
1507 // it will come first in the senders map.
1508 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1509 cricket::VideoSendParameters parameters;
1510 parameters.codecs.push_back(DefaultCodec());
1511 parameters.conference_mode = true;
1512 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001513 EXPECT_TRUE(
1514 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1516 EXPECT_TRUE(SetSend(true));
1517 EXPECT_TRUE(SendFrame());
1518 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1519 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1520
1521 // Add an additional capturer, and hook up a renderer to receive it.
1522 cricket::FakeVideoRenderer renderer2;
1523 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1524 CreateFakeVideoCapturer());
1525 const int kTestWidth = 160;
1526 const int kTestHeight = 120;
1527 cricket::VideoFormat format(kTestWidth, kTestHeight,
1528 cricket::VideoFormat::FpsToInterval(5),
1529 cricket::FOURCC_I420);
1530 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001531 EXPECT_TRUE(
1532 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001533 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001534 EXPECT_TRUE(
1535 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001536 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1537 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001538 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1539 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001540
1541 // Get stats, and make sure they are correct for two senders. We wait until
1542 // the number of expected packets have been sent to avoid races where we
1543 // check stats before it has been updated.
1544 cricket::VideoMediaInfo info;
1545 for (uint32_t i = 0; i < kTimeout; ++i) {
1546 rtc::Thread::Current()->ProcessMessages(1);
1547 EXPECT_TRUE(channel_->GetStats(&info));
1548 ASSERT_EQ(2U, info.senders.size());
1549 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1550 NumRtpPackets()) {
1551 // Stats have been updated for both sent frames, expectations can be
1552 // checked now.
1553 break;
1554 }
1555 }
1556 EXPECT_EQ(NumRtpPackets(),
1557 info.senders[0].packets_sent + info.senders[1].packets_sent)
1558 << "Timed out while waiting for packet counts for all sent packets.";
1559 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1560 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1561 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1562 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1563 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1564 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1565 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1566 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1567 // The capturer must be unregistered here as it runs out of it's scope next.
1568 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001569}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001570
Niels Möller6557d0c2018-04-11 15:18:34 +02001571// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001572TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001573 cricket::VideoSendParameters parameters;
1574 parameters.codecs.push_back(DefaultCodec());
1575 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1576 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1577 parameters.max_bandwidth_bps = 128 * 1024;
1578 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001579}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001580
Niels Möller6557d0c2018-04-11 15:18:34 +02001581// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001582TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001583 EXPECT_TRUE(SetDefaultCodec());
1584 EXPECT_TRUE(SetSend(true));
1585 EXPECT_TRUE(SendFrame());
1586 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001587 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001588 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001589 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1590 EXPECT_EQ(kSsrc, header.ssrc);
1591
Niels Möller6557d0c2018-04-11 15:18:34 +02001592 // Packets are being paced out, so these can mismatch between the first and
1593 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001594 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1595 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001596 EXPECT_EQ(1, NumSentSsrcs());
1597 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1598 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001599}
Niels Möller6557d0c2018-04-11 15:18:34 +02001600
1601// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001602TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001603 // Remove stream added in Setup.
1604 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1605 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001607 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1608 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001609 EXPECT_TRUE(SetSend(true));
1610 EXPECT_TRUE(WaitAndSendFrame(0));
1611 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001612 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001613 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001614 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1615 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 // Packets are being paced out, so these can mismatch between the first and
1617 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001618 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1619 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001620 EXPECT_EQ(1, NumSentSsrcs());
1621 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1622 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001623}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001624
Niels Möller6557d0c2018-04-11 15:18:34 +02001625// Test that we can set the default video renderer before and after
1626// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001627TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001628 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1629 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001630
1631 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1632 rtc::SetBE32(packet1.data() + 8, kSsrc);
1633 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1634 EXPECT_TRUE(SetDefaultCodec());
1635 EXPECT_TRUE(SetSend(true));
1636 EXPECT_EQ(0, renderer_.num_rendered_frames());
1637 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1638 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1639 EXPECT_TRUE(SendFrame());
1640 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001641}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001642
Niels Möller6557d0c2018-04-11 15:18:34 +02001643// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001644TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001645 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1646 EXPECT_TRUE(SetSend(true));
1647 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1648 EXPECT_TRUE(SendFrame());
1649 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1650 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001651 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001652 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001653 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1654 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001655 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1656 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001657
1658 // Remove the send stream that was added during Setup.
1659 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1660 int rtp_packets = NumRtpPackets();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001663 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1664 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001665 EXPECT_EQ(rtp_packets, NumRtpPackets());
1666 // Wait 30ms to guarantee the engine does not drop the frame.
1667 EXPECT_TRUE(WaitAndSendFrame(30));
1668 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1669
1670 last_packet = NumRtpPackets() - 1;
1671 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001672 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1673 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001674}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001675
Niels Möller6557d0c2018-04-11 15:18:34 +02001676// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001677TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001678 cricket::FakeVideoRenderer renderer1, renderer2;
1679 EXPECT_TRUE(SetDefaultCodec());
1680 cricket::VideoSendParameters parameters;
1681 parameters.codecs.push_back(DefaultCodec());
1682 parameters.conference_mode = true;
1683 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1684 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001685 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1686 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1688 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1689 EXPECT_EQ(0, renderer1.num_rendered_frames());
1690 EXPECT_EQ(0, renderer2.num_rendered_frames());
1691 std::vector<uint32_t> ssrcs;
1692 ssrcs.push_back(1);
1693 ssrcs.push_back(2);
1694 network_interface_.SetConferenceMode(true, ssrcs);
1695 EXPECT_TRUE(SendFrame());
1696 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1697 kTimeout);
1698 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1699 kTimeout);
1700
1701 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1702 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1703 EXPECT_EQ(kVideoWidth, renderer1.width());
1704 EXPECT_EQ(kVideoHeight, renderer1.height());
1705 EXPECT_EQ(kVideoWidth, renderer2.width());
1706 EXPECT_EQ(kVideoHeight, renderer2.height());
1707 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1708 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001709}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001710
Niels Möller6557d0c2018-04-11 15:18:34 +02001711// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001712TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001713 using cricket::VideoCodec;
1714 using cricket::VideoOptions;
1715 using cricket::VideoFormat;
1716 using cricket::FOURCC_I420;
1717
1718 VideoCodec codec = DefaultCodec();
1719 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1720 EXPECT_TRUE(SetOneCodec(codec));
1721 EXPECT_TRUE(SetSend(true));
1722 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1723 EXPECT_EQ(0, renderer_.num_rendered_frames());
1724 EXPECT_TRUE(SendFrame());
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1727 CreateFakeVideoCapturer());
1728
1729 // TODO(nisse): This testcase fails if we don't configure
1730 // screencast. It's unclear why, I see nothing obvious in this
1731 // test which is related to screencast logic.
1732 VideoOptions video_options;
1733 video_options.is_screencast = true;
1734 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1735
1736 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1737 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1738 // All capturers start generating frames with the same timestamp. ViE does
1739 // not allow the same timestamp to be used. Capture one frame before
1740 // associating the capturer with the channel.
1741 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1742
1743 int captured_frames = 1;
1744 for (int iterations = 0; iterations < 2; ++iterations) {
1745 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1746 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1747 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1748 ++captured_frames;
1749 // Wait until frame of right size is captured.
1750 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001751 format.width == renderer_.width() &&
1752 format.height == renderer_.height() &&
1753 !renderer_.black_frame(),
1754 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1756 EXPECT_EQ(format.width, renderer_.width());
1757 EXPECT_EQ(format.height, renderer_.height());
1758 captured_frames = renderer_.num_rendered_frames() + 1;
1759 EXPECT_FALSE(renderer_.black_frame());
1760 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1761 // Make sure a black frame is generated within the specified timeout.
1762 // The black frame should be the resolution of the previous frame to
1763 // prevent expensive encoder reconfigurations.
1764 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001765 format.width == renderer_.width() &&
1766 format.height == renderer_.height() &&
1767 renderer_.black_frame(),
1768 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1770 EXPECT_EQ(format.width, renderer_.width());
1771 EXPECT_EQ(format.height, renderer_.height());
1772 EXPECT_TRUE(renderer_.black_frame());
1773
1774 // The black frame has the same timestamp as the next frame since it's
1775 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1776 // not render a frame with the same timestamp so capture another frame
1777 // with the frame capturer to increment the next frame's timestamp.
1778 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1779 }
srtee0c2eea2017-12-15 17:44:33 +01001780}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001781
Niels Möller6557d0c2018-04-11 15:18:34 +02001782// Tests that if SetVideoSend is called with a NULL capturer after the
1783// capturer was already removed, the application doesn't crash (and no black
1784// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1787 EXPECT_TRUE(SetSend(true));
1788 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1789 EXPECT_EQ(0, renderer_.num_rendered_frames());
1790 EXPECT_TRUE(SendFrame());
1791 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1792 // Wait for one frame so they don't get dropped because we send frames too
1793 // tightly.
1794 rtc::Thread::Current()->ProcessMessages(30);
1795 // Remove the capturer.
1796 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1797
1798 // No capturer was added, so this SetVideoSend shouldn't do anything.
1799 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1800 rtc::Thread::Current()->ProcessMessages(300);
1801 // Verify no more frames were sent.
1802 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001803}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001804
Niels Möller6557d0c2018-04-11 15:18:34 +02001805// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001806TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001807 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1808 // interval time to avoid that.
1809 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1810 // interval time to avoid that.
1811 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001812 EXPECT_TRUE(
1813 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001814 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1815 cricket::VideoFormat capture_format(
1816 kVideoWidth, kVideoHeight,
1817 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1818 // Set up additional stream 1.
1819 cricket::FakeVideoRenderer renderer1;
1820 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001821 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001823 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001824 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1825 CreateFakeVideoCapturer());
1826 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1827 // Set up additional stream 2.
1828 cricket::FakeVideoRenderer renderer2;
1829 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001830 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001831 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001832 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1834 CreateFakeVideoCapturer());
1835 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1836 // State for all the streams.
1837 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1838 // A limitation in the lmi implementation requires that SetVideoSend() is
1839 // called after SetOneCodec().
1840 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1841 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1842 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1843 EXPECT_TRUE(SetSend(true));
1844 // Test capturer associated with engine.
1845 const int kTestWidth = 160;
1846 const int kTestHeight = 120;
1847 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001848 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1849 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001850 // Capture a frame with additional capturer2, frames should be received
1851 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001852 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1853 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001854 // Successfully remove the capturer.
1855 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1856 // The capturers must be unregistered here as it runs out of it's scope
1857 // next.
1858 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1859 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001860}
Niels Möller6557d0c2018-04-11 15:18:34 +02001861
1862// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001863TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001864 // Remove the send stream that was added during Setup.
1865 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1866
1867 cricket::StreamParams empty;
1868 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001869 EXPECT_TRUE(
1870 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001871}
Niels Möller6557d0c2018-04-11 15:18:34 +02001872
1873// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001874TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001875 // Remove stream added in Setup. I.e. remove stream corresponding to default
1876 // channel.
1877 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001878 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001879 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1880 EXPECT_TRUE(channel_->AddSendStream(
1881 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1882 }
1883 // Delete one of the non default channel streams, let the destructor delete
1884 // the remaining ones.
1885 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1886 // Stream should already be deleted.
1887 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001888}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001889
eladalonf1841382017-06-12 01:16:46 -07001890TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001891 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001892}
1893
eladalonf1841382017-06-12 01:16:46 -07001894TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001895 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001896}
1897
eladalonf1841382017-06-12 01:16:46 -07001898TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001899 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001900}
1901
eladalonf1841382017-06-12 01:16:46 -07001902TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001903 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1904 // bitrates. This currently happens at <250k, and two streams sharing 300k
1905 // initially will use QVGA instead of VGA.
1906 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1907 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001908 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001909 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001910 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001911}
1912
eladalonf1841382017-06-12 01:16:46 -07001913class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001914 public:
eladalonf1841382017-06-12 01:16:46 -07001915 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1916 explicit WebRtcVideoChannelTest(const char* field_trials)
1917 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001918 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001919 encoder_factory_->AddSupportedVideoCodecType("VP8");
1920 encoder_factory_->AddSupportedVideoCodecType("VP9");
1921#if defined(WEBRTC_USE_H264)
1922 encoder_factory_->AddSupportedVideoCodecType("H264");
1923#endif
1924
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001925 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08001926 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
1927 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08001928 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001929 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001930 send_parameters_.codecs = engine_.codecs();
1931 recv_parameters_.codecs = engine_.codecs();
1932 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001933 }
1934
1935 protected:
1936 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001937 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001938 }
1939
1940 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001941 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001942 EXPECT_TRUE(channel_->AddSendStream(sp));
1943 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001944 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001945 EXPECT_EQ(num_streams + 1, streams.size());
1946 return streams[streams.size() - 1];
1947 }
1948
1949 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001950 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001951 }
1952
1953 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001954 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001955 }
1956
1957 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001958 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001959 EXPECT_TRUE(channel_->AddRecvStream(sp));
1960 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001961 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001962 EXPECT_EQ(num_streams + 1, streams.size());
1963 return streams[streams.size() - 1];
1964 }
1965
pbos@webrtc.org00873182014-11-25 14:03:34 +00001966 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
1967 int expected_min_bitrate_bps,
1968 const char* start_bitrate_kbps,
1969 int expected_start_bitrate_bps,
1970 const char* max_bitrate_kbps,
1971 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001972 ExpectSetBitrateParameters(expected_min_bitrate_bps,
1973 expected_start_bitrate_bps,
1974 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001975 auto& codecs = send_parameters_.codecs;
1976 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08001977 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00001978 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
1979 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
1980 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001981 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001982 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001983
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001984 void ExpectSetBitrateParameters(int min_bitrate_bps,
1985 int start_bitrate_bps,
1986 int max_bitrate_bps) {
1987 EXPECT_CALL(
1988 *fake_call_->GetMockTransportControllerSend(),
1989 SetSdpBitrateParameters(AllOf(
1990 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
1991 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
1992 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
1993 }
1994
1995 void ExpectSetMaxBitrate(int max_bitrate_bps) {
1996 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
1997 SetSdpBitrateParameters(Field(
1998 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001999 }
2000
isheriff6f8d6862016-05-26 11:24:55 -07002001 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002002 // Enable extension.
2003 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002004 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002005 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002006 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002007 FakeVideoSendStream* send_stream =
2008 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2009
2010 // Verify the send extension id.
2011 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2012 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002013 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002014 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002015 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002016 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2017 // receivers.
2018 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2019 ->GetConfig()
2020 .rtp.extensions.empty());
2021
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002022 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002023 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002024 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2025 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002026 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2027
2028 // Verify that adding receive RTP header extensions adds them for existing
2029 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002030 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002031 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002032 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2033 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002034 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002035 }
2036
isheriff6f8d6862016-05-26 11:24:55 -07002037 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002038 // Enable extension.
2039 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002040 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002041 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002042 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002043
2044 FakeVideoReceiveStream* recv_stream =
2045 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2046
2047 // Verify the recv extension id.
2048 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2049 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002050 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002051 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002052 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002053
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002054 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2055 // senders.
2056 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2057 ->GetConfig()
2058 .rtp.extensions.empty());
2059
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002060 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002061 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002062 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2063 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002064 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2065
2066 // Verify that adding receive RTP header extensions adds them for existing
2067 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002068 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002069 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002070 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2071 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002072 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002073 }
2074
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002075 void TestExtensionFilter(const std::vector<std::string>& extensions,
2076 const std::string& expected_extension) {
2077 cricket::VideoSendParameters parameters = send_parameters_;
2078 int expected_id = -1;
2079 int id = 1;
2080 for (const std::string& extension : extensions) {
2081 if (extension == expected_extension)
2082 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002083 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002084 }
2085 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2086 FakeVideoSendStream* send_stream =
2087 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2088
2089 // Verify that only one of them has been set, and that it is the one with
2090 // highest priority (transport sequence number).
2091 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2092 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2093 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002094 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002095 }
2096
asapersson3c81a1a2017-06-14 05:52:21 -07002097 void TestDegradationPreference(bool resolution_scaling_enabled,
2098 bool fps_scaling_enabled);
2099
Erik Språngefbde372015-04-29 16:21:28 +02002100 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002101 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002102 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2103 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002104
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002105 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002106 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002107 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002108 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002109 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002110 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002111 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002112 // Options only take effect on the next frame.
2113 EXPECT_TRUE(capturer->CaptureFrame());
2114
Erik Språng143cec12015-04-28 10:01:41 +02002115 return fake_call_->GetVideoSendStreams().back();
2116 }
2117
Peter Boström2feafdb2015-09-09 14:32:14 +02002118 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2119 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002120 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002121 std::vector<uint32_t> ssrcs;
2122 std::vector<uint32_t> rtx_ssrcs;
2123 uint32_t num_streams = enabled ? 3 : 1;
2124 for (uint32_t i = 0; i < num_streams; ++i) {
2125 uint32_t ssrc = last_ssrc_ + i;
2126 ssrcs.push_back(ssrc);
2127 if (with_rtx) {
2128 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2129 }
Erik Språng143cec12015-04-28 10:01:41 +02002130 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002131 if (with_rtx) {
2132 return AddSendStream(
2133 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2134 }
2135 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002136 }
2137
perkjfa10b552016-10-02 23:45:26 -07002138 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002139 std::vector<FakeVideoSendStream*> streams =
2140 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002141 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002142 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002143 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002144 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002145 }
2146
perkjfa10b552016-10-02 23:45:26 -07002147 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002148 int stream_max,
2149 int expected_encoder_bitrate) {
2150 VideoSendParameters limited_send_params = send_parameters_;
2151 limited_send_params.max_bandwidth_bps = global_max;
2152 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002153 webrtc::RtpParameters parameters =
2154 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002155 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002156 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002157 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002158 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002159 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002160 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002161 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002162 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002163 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002164 }
2165
Åsa Persson55659812018-06-18 17:51:32 +02002166 // Values from kSimulcastConfigs in simulcast.cc.
2167 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2168 std::vector<webrtc::VideoStream> layers(3);
2169 layers[0].min_bitrate_bps = 30000;
2170 layers[0].target_bitrate_bps = 150000;
2171 layers[0].max_bitrate_bps = 200000;
2172 layers[1].min_bitrate_bps = 150000;
2173 layers[1].target_bitrate_bps = 500000;
2174 layers[1].max_bitrate_bps = 700000;
2175 layers[2].min_bitrate_bps = 600000;
2176 layers[2].target_bitrate_bps = 2500000;
2177 layers[2].max_bitrate_bps = 2500000;
2178 return layers;
2179 }
2180
kwiberg686a8ef2016-02-26 03:00:35 -08002181 std::unique_ptr<FakeCall> fake_call_;
2182 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002183 cricket::VideoSendParameters send_parameters_;
2184 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002185 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002186};
2187
eladalonf1841382017-06-12 01:16:46 -07002188TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002189 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002190 const std::string kSyncLabel = "AvSyncLabel";
2191
2192 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002193 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002194 EXPECT_TRUE(channel_->AddRecvStream(sp));
2195
Mirko Bonadeif859e552018-05-30 15:31:29 +02002196 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002197 EXPECT_EQ(kSyncLabel,
2198 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2199 << "SyncGroup should be set based on sync_label";
2200}
2201
eladalonf1841382017-06-12 01:16:46 -07002202TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002203 cricket::VideoSendParameters parameters;
2204 parameters.codecs = engine_.codecs();
2205 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002206 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002207 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002208 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002209
2210 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002211 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2212 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002213 FakeVideoSendStream* send_stream = AddSendStream(
2214 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2215
2216 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2217 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2218 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2219
2220 // Receiver side.
2221 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2222 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002223 EXPECT_FALSE(
2224 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002225 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002226 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002227 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002228 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002229 << "RTX should be mapped for the RED payload type";
2230
brandtr14742122017-01-27 04:53:07 -08002231 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002232}
2233
eladalonf1841382017-06-12 01:16:46 -07002234TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002235 // Setup one channel with an associated RTX stream.
2236 cricket::StreamParams params =
2237 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2238 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2239 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002240 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002241
2242 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2243 << "RTX should be mapped for all decoders/payload types.";
2244 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002245 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002246 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002247}
2248
eladalonf1841382017-06-12 01:16:46 -07002249TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002250 // Setup one channel without an associated RTX stream.
2251 cricket::StreamParams params =
2252 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2253 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002254 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002255}
2256
eladalonf1841382017-06-12 01:16:46 -07002257TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002258 FakeVideoSendStream* send_stream =
2259 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2260 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2261
2262 FakeVideoReceiveStream* recv_stream =
2263 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2264 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002265}
2266
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002267// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002268TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002269 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002270}
isheriff6f8d6862016-05-26 11:24:55 -07002271
eladalonf1841382017-06-12 01:16:46 -07002272TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002273 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002274}
2275
2276// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002277TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002278 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002279}
isheriff6f8d6862016-05-26 11:24:55 -07002280
eladalonf1841382017-06-12 01:16:46 -07002281TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002282 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002283}
2284
eladalonf1841382017-06-12 01:16:46 -07002285TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002286 // Enable three redundant extensions.
2287 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002288 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2289 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2290 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2291 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002292}
2293
eladalonf1841382017-06-12 01:16:46 -07002294TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002295 // Enable two redundant extensions.
2296 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002297 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2298 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2299 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002300}
2301
stefanc1aeaf02015-10-15 07:26:07 -07002302// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002303TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002304 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002305}
eladalonf1841382017-06-12 01:16:46 -07002306TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002307 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002308}
2309
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002310// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002311TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002312 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002313}
eladalonf1841382017-06-12 01:16:46 -07002314TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002315 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002316}
2317
eladalonf1841382017-06-12 01:16:46 -07002318TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002319 const int kAbsSendTimeId = 1;
2320 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002321 send_parameters_.extensions.push_back(
2322 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2323 send_parameters_.extensions.push_back(
2324 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002325
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002326 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002327 FakeVideoSendStream* send_stream =
2328 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2329
2330 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002331 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002332
2333 // Setting the same extensions (even if in different order) shouldn't
2334 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002335 std::reverse(send_parameters_.extensions.begin(),
2336 send_parameters_.extensions.end());
2337 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002338
2339 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2340
2341 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002342 send_parameters_.extensions.resize(1);
2343 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002344
2345 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2346}
2347
eladalonf1841382017-06-12 01:16:46 -07002348TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002349 const int kTOffsetId = 1;
2350 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002351 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002352 recv_parameters_.extensions.push_back(
2353 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2354 recv_parameters_.extensions.push_back(
2355 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2356 recv_parameters_.extensions.push_back(
2357 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002358
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002359 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002360 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002361 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2362
2363 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002364 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002365
2366 // Setting the same extensions (even if in different order) shouldn't
2367 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002368 std::reverse(recv_parameters_.extensions.begin(),
2369 recv_parameters_.extensions.end());
2370 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002371
2372 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2373
2374 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002375 recv_parameters_.extensions.resize(1);
2376 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002377
2378 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2379}
2380
eladalonf1841382017-06-12 01:16:46 -07002381TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002382 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002383 const int kUnsupportedId = 1;
2384 const int kTOffsetId = 2;
2385
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002386 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002387 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002388 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002389 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002390 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002391 FakeVideoSendStream* send_stream =
2392 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2393
2394 // Only timestamp offset extension is set to send stream,
2395 // unsupported rtp extension is ignored.
2396 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002397 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2398 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002399}
2400
eladalonf1841382017-06-12 01:16:46 -07002401TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002402 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002403 const int kUnsupportedId = 1;
2404 const int kTOffsetId = 2;
2405
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002406 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002407 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002408 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002409 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002410 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002411 FakeVideoReceiveStream* recv_stream =
2412 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2413
2414 // Only timestamp offset extension is set to receive stream,
2415 // unsupported rtp extension is ignored.
2416 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002417 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2418 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002419}
2420
eladalonf1841382017-06-12 01:16:46 -07002421TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002422 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002423 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 send_parameters_.extensions.push_back(
2425 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002427 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2428 }
2429}
2430
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002432 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002433 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002434 recv_parameters_.extensions.push_back(
2435 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002436 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002437 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2438 }
2439}
2440
eladalonf1841382017-06-12 01:16:46 -07002441TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002442 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002443 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002444 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002445 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002446 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002447 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002448
2449 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002450 send_parameters_.extensions.clear();
2451 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002452 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002453 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2454 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002455}
2456
eladalonf1841382017-06-12 01:16:46 -07002457TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002458 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002459 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002460 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002461 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002462 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002463 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002464
2465 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002466 recv_parameters_.extensions.clear();
2467 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002468 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002469 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2470 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002471}
2472
eladalonf1841382017-06-12 01:16:46 -07002473TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002474 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002475 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002476}
2477
eladalonf1841382017-06-12 01:16:46 -07002478TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002479 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002480 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002481}
2482
eladalonf1841382017-06-12 01:16:46 -07002483TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002484 FakeVideoReceiveStream* stream = AddRecvStream();
2485 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002486}
2487
eladalonf1841382017-06-12 01:16:46 -07002488TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002489 FakeVideoReceiveStream* stream = AddRecvStream();
2490 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2491}
2492
eladalonf1841382017-06-12 01:16:46 -07002493TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002494 FakeVideoReceiveStream* stream = AddRecvStream();
2495 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2496
Peter Boström126c03e2015-05-11 12:48:12 +02002497 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002498 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002499 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002500 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2501 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002502 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002503 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2504
2505 // Verify that REMB is turned on when setting default codecs since the
2506 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002507 parameters.codecs = engine_.codecs();
2508 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002509 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002510 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002511}
2512
eladalonf1841382017-06-12 01:16:46 -07002513TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002514 FakeVideoReceiveStream* stream = AddRecvStream();
2515 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2516
2517 // Verify that transport cc feedback is turned off when send(!) codecs without
2518 // transport cc feedback are set.
2519 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002520 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002521 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2522 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2523 stream = fake_call_->GetVideoReceiveStreams()[0];
2524 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2525
2526 // Verify that transport cc feedback is turned on when setting default codecs
2527 // since the default codecs have transport cc feedback enabled.
2528 parameters.codecs = engine_.codecs();
2529 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2530 stream = fake_call_->GetVideoReceiveStreams()[0];
2531 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2532}
2533
eladalonf1841382017-06-12 01:16:46 -07002534TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002535 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002536 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2537
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002538 cricket::VideoSendParameters parameters;
2539 parameters.codecs = engine_.codecs();
2540 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002541 EXPECT_TRUE(channel_->SetSend(true));
2542
2543 // Send side.
2544 FakeVideoSendStream* send_stream =
2545 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2546 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2547
2548 // Receiver side.
2549 FakeVideoReceiveStream* recv_stream =
2550 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2551 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2552
2553 // Nack history size should match between sender and receiver.
2554 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2555 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002556}
2557
eladalonf1841382017-06-12 01:16:46 -07002558TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002559 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002560 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002561
2562 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2563 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2564
2565 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002566 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002567 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2569 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002570 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2571 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2572 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002573 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2574
Peter Boström67c9df72015-05-11 14:34:58 +02002575 // Verify that NACK is turned on when setting default codecs since the
2576 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002577 parameters.codecs = engine_.codecs();
2578 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002579 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2580 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2581 send_stream = fake_call_->GetVideoSendStreams()[0];
2582 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002583}
2584
Peter Boströme7ba0862016-03-12 00:02:28 +01002585// This test verifies that new frame sizes reconfigures encoders even though not
2586// (yet) sending. The purpose of this is to permit encoding as quickly as
2587// possible once we start sending. Likely the frames being input are from the
2588// same source that will be sent later, which just means that we're ready
2589// earlier.
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002591 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002592 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002593 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2594 channel_->SetSend(false);
2595
2596 FakeVideoSendStream* stream = AddSendStream();
2597
perkjfa10b552016-10-02 23:45:26 -07002598 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002599 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002600 EXPECT_EQ(0u, streams[0].width);
2601 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002602
Tommi85959932018-02-07 19:26:06 +01002603 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002604 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002605 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2606 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002607 EXPECT_TRUE(capturer.CaptureFrame());
2608
2609 // Frame entered, should be reconfigured to new dimensions.
2610 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002611 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2612 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2613 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002614
Niels Möllerff40b142018-04-09 08:49:14 +02002615 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002616}
2617
eladalonf1841382017-06-12 01:16:46 -07002618TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002619 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002620 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 cricket::VideoSendParameters parameters;
2622 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002624 AddSendStream();
2625
Tommi85959932018-02-07 19:26:06 +01002626 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002627 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002628 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002629 EXPECT_TRUE(
2630 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002631 cricket::VideoFormat capture_format_hd =
2632 capturer.GetSupportedFormats()->front();
2633 EXPECT_EQ(1280, capture_format_hd.width);
2634 EXPECT_EQ(720, capture_format_hd.height);
2635 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2636
2637 EXPECT_TRUE(channel_->SetSend(true));
2638
2639 EXPECT_TRUE(capturer.CaptureFrame());
2640 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2641 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2642
2643 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2644
2645 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002646 webrtc::VideoEncoderConfig encoder_config =
2647 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002648 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002649 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002650 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002651 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2652 streams.front().width);
2653 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2654 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002655 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2656 << "Non-screenshare shouldn't use min-transmit bitrate.";
2657
Niels Möllerff40b142018-04-09 08:49:14 +02002658 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002659 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002660 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002661 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002662 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002663 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002664 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002665 // Send stream recreated after option change.
2666 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2667 send_stream = fake_call_->GetVideoSendStreams().front();
2668 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002669
2670 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002671 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002672 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002673 encoder_config.content_type);
2674 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2675 encoder_config.min_transmit_bitrate_bps);
2676
perkjfa10b552016-10-02 23:45:26 -07002677 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002678 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2679 streams.front().width);
2680 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2681 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002682 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002683 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002684}
2685
eladalonf1841382017-06-12 01:16:46 -07002686TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002687 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002688 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002689 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002690 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002691
2692 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002693 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002694 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002695 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002696 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002697 cricket::VideoFormat capture_format_hd =
2698 capturer.GetSupportedFormats()->front();
2699 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2700
2701 EXPECT_TRUE(channel_->SetSend(true));
2702
2703 EXPECT_TRUE(capturer.CaptureFrame());
2704 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2705 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2706
perkj26091b12016-09-01 01:17:40 -07002707 webrtc::VideoEncoderConfig encoder_config =
2708 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002709
2710 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002711 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002712 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002713 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002714
2715 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2716 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002717 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002718 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002719 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002720
Niels Möllerff40b142018-04-09 08:49:14 +02002721 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002722}
2723
eladalonf1841382017-06-12 01:16:46 -07002724TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002725 FakeVideoSendStream* stream = AddSendStream();
2726 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2727}
2728
eladalonf1841382017-06-12 01:16:46 -07002729TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002730 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002731 media_config.video.suspend_below_min_bitrate = true;
2732
2733 channel_.reset(
2734 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002735 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002736
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002737 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002738
2739 FakeVideoSendStream* stream = AddSendStream();
2740 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2741
nisse0db023a2016-03-01 04:29:59 -08002742 media_config.video.suspend_below_min_bitrate = false;
2743 channel_.reset(
2744 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002745 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002746
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002747 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002748
nisse0db023a2016-03-01 04:29:59 -08002749 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002750 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2751}
2752
eladalonf1841382017-06-12 01:16:46 -07002753TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002754 FakeVideoSendStream* stream = AddSendStream();
2755 webrtc::VideoCodecVP8 vp8_settings;
2756 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2757 EXPECT_TRUE(vp8_settings.denoisingOn);
2758}
2759
eladalonf1841382017-06-12 01:16:46 -07002760TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002761 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002762 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002763 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002764
Peter Boström2feafdb2015-09-09 14:32:14 +02002765 // Single-stream settings should apply with RTX as well (verifies that we
2766 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2767 // both RTX and regular SSRCs).
2768 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002769
Tommi85959932018-02-07 19:26:06 +01002770 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002771 EXPECT_EQ(cricket::CS_RUNNING,
2772 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002773 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002774 channel_->SetSend(true);
2775
2776 EXPECT_TRUE(capturer.CaptureFrame());
2777
pbos4cba4eb2015-10-26 11:18:18 -07002778 webrtc::VideoCodecVP8 vp8_settings;
2779 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2780 EXPECT_TRUE(vp8_settings.denoisingOn)
2781 << "VP8 denoising should be on by default.";
2782
nisse05103312016-03-16 02:22:50 -07002783 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002784
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002785 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2786 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002787 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2788 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002789
nisse05103312016-03-16 02:22:50 -07002790 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002791
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002792 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2793 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002794 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2795 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2796
Niels Möllerff40b142018-04-09 08:49:14 +02002797 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002798 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002799 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002800 channel_->SetSend(true);
2801 EXPECT_TRUE(capturer.CaptureFrame());
2802
Mirko Bonadeif859e552018-05-30 15:31:29 +02002803 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002804 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2805 // Autmatic resize off when using simulcast.
2806 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2807 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2808
2809 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002810 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002811 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002813
nisse05103312016-03-16 02:22:50 -07002814 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002815
Mirko Bonadeif859e552018-05-30 15:31:29 +02002816 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002817 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2818 EXPECT_FALSE(vp8_settings.denoisingOn);
2819 // Resizing and frame dropping always off for screen sharing.
2820 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2821 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2822
nisse05103312016-03-16 02:22:50 -07002823 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002824
2825 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2826 EXPECT_FALSE(vp8_settings.denoisingOn);
2827 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2828 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2829
Niels Möllerff40b142018-04-09 08:49:14 +02002830 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002831}
2832
deadbeef119760a2016-04-04 11:43:27 -07002833// Test that setting the same options doesn't result in the encoder being
2834// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002835TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002836 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002837 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002838
perkjfa10b552016-10-02 23:45:26 -07002839 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002840 EXPECT_EQ(cricket::CS_RUNNING,
2841 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002842 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002843 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002844 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2845 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2846
Niels Möllerff40b142018-04-09 08:49:14 +02002847 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2848 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002849 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002850 // Expect 1 reconfigurations at this point from the initial configuration.
2851 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002852
2853 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002854 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002855 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2856
2857 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002858 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002859 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002860 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2861
Niels Möllerff40b142018-04-09 08:49:14 +02002862 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002863}
2864
eladalonf1841382017-06-12 01:16:46 -07002865class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002866 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002867 Vp9SettingsTest() : Vp9SettingsTest("") {}
2868 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002869 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002870 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002871 }
2872 virtual ~Vp9SettingsTest() {}
2873
2874 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002875 void TearDown() override {
2876 // Remove references to encoder_factory_ since this will be destroyed
2877 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002878 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002879 }
Erik Språng143cec12015-04-28 10:01:41 +02002880};
2881
2882TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002883 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002884 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002885 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002886
Peter Boström2feafdb2015-09-09 14:32:14 +02002887 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002888
Tommi85959932018-02-07 19:26:06 +01002889 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002890 EXPECT_EQ(cricket::CS_RUNNING,
2891 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002892 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002893 channel_->SetSend(true);
2894
2895 EXPECT_TRUE(capturer.CaptureFrame());
2896
pbos4cba4eb2015-10-26 11:18:18 -07002897 webrtc::VideoCodecVP9 vp9_settings;
2898 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002899 EXPECT_TRUE(vp9_settings.denoisingOn)
2900 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002901
nisse05103312016-03-16 02:22:50 -07002902 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002903
Erik Språng143cec12015-04-28 10:01:41 +02002904 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2905 EXPECT_FALSE(vp9_settings.denoisingOn);
2906 // Frame dropping always on for real time video.
2907 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2908
nisse05103312016-03-16 02:22:50 -07002909 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002910
2911 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2912 EXPECT_TRUE(vp9_settings.denoisingOn);
2913 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2914
2915 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07002916 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002917 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002918 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002919
nisse05103312016-03-16 02:22:50 -07002920 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002921
2922 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2923 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002924 // Frame dropping always on for screen sharing.
2925 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002926
nisse05103312016-03-16 02:22:50 -07002927 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002928
2929 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2930 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002931 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002932
Niels Möllerff40b142018-04-09 08:49:14 +02002933 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002934}
2935
Sergey Silkinf18072e2018-03-14 10:35:35 +01002936TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
2937 cricket::VideoSendParameters parameters;
2938 parameters.codecs.push_back(GetEngineCodec("VP9"));
2939 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2940
2941 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
2942
2943 FakeVideoSendStream* stream =
2944 AddSendStream(CreateSimStreamParams("cname", ssrcs));
2945
2946 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2947 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
2948
2949 FakeVideoCapturerWithTaskQueue capturer;
2950 EXPECT_EQ(cricket::CS_RUNNING,
2951 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002952 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002953 channel_->SetSend(true);
2954
2955 EXPECT_TRUE(capturer.CaptureFrame());
2956
2957 webrtc::VideoCodecVP9 vp9_settings;
2958 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2959
2960 const size_t kNumSpatialLayers = ssrcs.size();
2961 const size_t kNumTemporalLayers = 3;
2962 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
2963 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
2964
Niels Möllerff40b142018-04-09 08:49:14 +02002965 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002966}
2967
asaperssonc5dabdd2016-03-21 04:15:50 -07002968class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
2969 public:
brandtr468da7c2016-11-22 02:16:47 -08002970 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07002971 : Vp9SettingsTest(field_trials) {}
2972
2973 protected:
2974 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
2975 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002976 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07002977 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2978
2979 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
2980
Tommi85959932018-02-07 19:26:06 +01002981 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07002982 EXPECT_EQ(cricket::CS_RUNNING,
2983 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07002985 channel_->SetSend(true);
2986
2987 EXPECT_TRUE(capturer.CaptureFrame());
2988
2989 webrtc::VideoCodecVP9 vp9_settings;
2990 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2991 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
2992 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
2993
Niels Möllerff40b142018-04-09 08:49:14 +02002994 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07002995 }
2996};
2997
2998class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
2999 public:
3000 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3001};
3002
3003TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3004 const int kNumSpatialLayers = 1;
3005 const int kNumTemporalLayers = 1;
3006 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3007}
3008
3009class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3010 public:
3011 Vp9SettingsTestWithInvalidFlag()
3012 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3013};
3014
3015TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3016 const int kNumSpatialLayers = 1;
3017 const int kNumTemporalLayers = 1;
3018 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3019}
3020
3021class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3022 public:
3023 Vp9SettingsTestWith2SL3TLFlag()
3024 : Vp9SettingsTestWithFieldTrial(
3025 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3026};
3027
3028TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3029 const int kNumSpatialLayers = 2;
3030 const int kNumTemporalLayers = 3;
3031 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3032}
3033
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003034TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3035 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3036 ASSERT_EQ(1u, streams.size());
3037 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3038}
3039
3040TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3041 webrtc::test::ScopedFieldTrials override_field_trials_(
3042 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3043 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3044 ASSERT_EQ(1u, streams.size());
3045 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3046}
3047
asapersson3c81a1a2017-06-14 05:52:21 -07003048TEST_F(WebRtcVideoChannelTest,
3049 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3050 webrtc::test::ScopedFieldTrials override_field_trials_(
3051 "WebRTC-Video-BalancedDegradation/Disabled/");
3052 const bool kResolutionScalingEnabled = true;
3053 const bool kFpsScalingEnabled = false;
3054 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3055}
3056
3057TEST_F(WebRtcVideoChannelTest,
3058 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3059 webrtc::test::ScopedFieldTrials override_field_trials_(
3060 "WebRTC-Video-BalancedDegradation/Enabled/");
3061 const bool kResolutionScalingEnabled = true;
3062 const bool kFpsScalingEnabled = true;
3063 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3064}
3065
eladalonf1841382017-06-12 01:16:46 -07003066TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003067 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003068}
3069
eladalonf1841382017-06-12 01:16:46 -07003070TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003071 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003072}
3073
eladalonf1841382017-06-12 01:16:46 -07003074TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003075 TestCpuAdaptation(true, true);
3076}
3077
eladalonf1841382017-06-12 01:16:46 -07003078TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003079 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003080 cricket::VideoSendParameters parameters;
3081 parameters.codecs.push_back(codec);
3082
kthelgason2bc68642017-02-07 07:02:22 -08003083 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003084 channel_.reset(
3085 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003086 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003087 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3088
3089 AddSendStream();
3090
Tommi85959932018-02-07 19:26:06 +01003091 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003092 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003093 ASSERT_EQ(cricket::CS_RUNNING,
3094 capturer.Start(capturer.GetSupportedFormats()->front()));
3095 ASSERT_TRUE(channel_->SetSend(true));
3096
3097 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3098 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003099
Niels Möllera6cc0f92018-02-12 17:14:55 +01003100 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003101 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3102 EXPECT_EQ(1280, send_stream->GetLastWidth());
3103 EXPECT_EQ(720, send_stream->GetLastHeight());
3104
3105 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003106 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003107 wants.max_pixel_count =
3108 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003109 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003110 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003111 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3112 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3113 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3114
3115 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003116 wants.max_pixel_count =
3117 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003118 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003119 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003120 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3121 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3122 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3123
3124 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003125 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003126 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003127 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3128 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3129
3130 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003131 int current_pixel_count =
3132 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3133 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3134 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003135 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003136 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003137 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003138 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003139 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003140 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003141 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3142 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3143
sprang84a37592017-02-10 07:04:27 -08003144 // Trigger underuse again, should go back up to full resolution.
3145 current_pixel_count =
3146 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003147 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003148 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003149 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003150 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003151 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003152 EXPECT_EQ(1284, send_stream->GetLastWidth());
3153 EXPECT_EQ(724, send_stream->GetLastHeight());
3154
Niels Möllerff40b142018-04-09 08:49:14 +02003155 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003156}
3157
eladalonf1841382017-06-12 01:16:46 -07003158TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003159 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003160 cricket::VideoSendParameters parameters;
3161 parameters.codecs.push_back(codec);
3162
kthelgason2bc68642017-02-07 07:02:22 -08003163 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003164 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003165 channel_.reset(
3166 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003167 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003168 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3169
3170 AddSendStream();
3171
Tommi85959932018-02-07 19:26:06 +01003172 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003173 ASSERT_EQ(cricket::CS_RUNNING,
3174 capturer.Start(capturer.GetSupportedFormats()->front()));
3175 ASSERT_TRUE(channel_->SetSend(true));
3176 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003177 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003178 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003179
3180 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3181 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003182
Niels Möllera6cc0f92018-02-12 17:14:55 +01003183 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003184 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3185 EXPECT_EQ(1280, send_stream->GetLastWidth());
3186 EXPECT_EQ(720, send_stream->GetLastHeight());
3187
3188 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003189 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003190 wants.max_pixel_count =
3191 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003192 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003193 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003194 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3195 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3196 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3197
3198 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003199 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003200 ASSERT_EQ(cricket::CS_RUNNING,
3201 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003202 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003203 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003204 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003205 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003206 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3207 send_stream = fake_call_->GetVideoSendStreams().front();
3208 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003209 EXPECT_EQ(1284, send_stream->GetLastWidth());
3210 EXPECT_EQ(724, send_stream->GetLastHeight());
3211
3212 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003213 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003214 send_stream = fake_call_->GetVideoSendStreams().front();
3215 // We have a new fake send stream, so it doesn't remember the old sink wants.
3216 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003217 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003218 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003219 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003220 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3221 send_stream = fake_call_->GetVideoSendStreams().front();
3222 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003223 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3224 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3225
Niels Möllerff40b142018-04-09 08:49:14 +02003226 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003227}
3228
asapersson3c81a1a2017-06-14 05:52:21 -07003229// TODO(asapersson): Remove this test when the balanced field trial is removed.
3230void WebRtcVideoChannelTest::TestDegradationPreference(
3231 bool resolution_scaling_enabled,
3232 bool fps_scaling_enabled) {
3233 cricket::VideoCodec codec = GetEngineCodec("VP8");
3234 cricket::VideoSendParameters parameters;
3235 parameters.codecs.push_back(codec);
3236
3237 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003238 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003239 channel_.reset(
3240 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3241 channel_->OnReadyToSend(true);
3242
3243 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3244
3245 AddSendStream();
3246
Tommi85959932018-02-07 19:26:06 +01003247 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003248 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003249 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003250 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3251 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3252
3253 EXPECT_TRUE(channel_->SetSend(true));
3254
3255 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3256 EXPECT_EQ(resolution_scaling_enabled,
3257 send_stream->resolution_scaling_enabled());
3258 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3259
Niels Möllerff40b142018-04-09 08:49:14 +02003260 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003261}
3262
eladalonf1841382017-06-12 01:16:46 -07003263void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3264 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003265 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003266 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003267 cricket::VideoSendParameters parameters;
3268 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003269
kthelgason2bc68642017-02-07 07:02:22 -08003270 MediaConfig media_config = GetMediaConfig();
3271 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003272 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003273 }
nisse51542be2016-02-12 02:27:06 -08003274 channel_.reset(
3275 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003276 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003277
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003278 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003279
3280 AddSendStream();
3281
Tommi85959932018-02-07 19:26:06 +01003282 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003283 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003284 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003285 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003286 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003287 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003288 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003289
3290 EXPECT_TRUE(channel_->SetSend(true));
3291
solenberge5269742015-09-08 05:13:22 -07003292 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003293
sprangc5d62e22017-04-02 23:53:04 -07003294 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003295 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003296 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3297 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003298
3299 EXPECT_TRUE(capturer.CaptureFrame());
3300 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3301
perkj26752742016-10-24 01:21:16 -07003302 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3303 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003304
Niels Möllerff40b142018-04-09 08:49:14 +02003305 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003306 return;
3307 }
3308
sprangc5d62e22017-04-02 23:53:04 -07003309 if (is_screenshare) {
3310 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3311 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3312 } else {
3313 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3314 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3315 }
3316
perkj803d97f2016-11-01 11:45:46 -07003317 // Trigger overuse.
3318 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3319
3320 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003321 if (is_screenshare) {
3322 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3323 } else {
3324 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3325 }
perkj803d97f2016-11-01 11:45:46 -07003326 send_stream->InjectVideoSinkWants(wants);
3327
sprangc5d62e22017-04-02 23:53:04 -07003328 for (int i = 0; i < kDefaultFps; ++i)
3329 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003330
sprangc5d62e22017-04-02 23:53:04 -07003331 if (is_screenshare) {
3332 // Drops every third frame.
3333 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3334 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3335 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3336 } else {
3337 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3338 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3339 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3340 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003341
3342 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003343 int last_pixel_count =
3344 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003345 if (is_screenshare) {
3346 wants.max_framerate_fps = kDefaultFps;
3347 } else {
3348 wants.max_pixel_count = last_pixel_count * 4;
3349 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3350 }
perkj803d97f2016-11-01 11:45:46 -07003351 send_stream->InjectVideoSinkWants(wants);
3352
sprangc5d62e22017-04-02 23:53:04 -07003353 for (int i = 0; i < kDefaultFps; ++i)
3354 EXPECT_TRUE(capturer.CaptureFrame());
3355
3356 if (is_screenshare) {
3357 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3358 send_stream->GetNumberOfSwappedFrames());
3359 } else {
3360 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3361 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003362
perkj26752742016-10-24 01:21:16 -07003363 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3364 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003365
Niels Möllerff40b142018-04-09 08:49:14 +02003366 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003367}
3368
eladalonf1841382017-06-12 01:16:46 -07003369TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003370 // Start at last timestamp to verify that wraparounds are estimated correctly.
3371 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3372 static const int64_t kInitialNtpTimeMs = 1247891230;
3373 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003374 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003375
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003376 FakeVideoReceiveStream* stream = AddRecvStream();
3377 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003378 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003379
nisse64ec8f82016-09-27 00:17:25 -07003380 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3381 kInitialTimestamp, 0,
3382 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003383 // Initial NTP time is not available on the first frame, but should still be
3384 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003385 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003386
3387 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003388
3389 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3390 // triggers a constant-overflow warning, hence we're calculating it explicitly
3391 // here.
3392 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3393 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003394 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003395
3396 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003397
3398 // Verify that NTP time has been correctly deduced.
3399 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003400 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003401 ASSERT_EQ(1u, info.receivers.size());
3402 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003403}
3404
eladalonf1841382017-06-12 01:16:46 -07003405TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003406 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003407 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003408
3409 VideoCodec codec;
3410 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003411 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003412
3413 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003414 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3415 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003416 FakeVideoSendStream* stream = AddSendStream(
3417 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003418 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003419
3420 // Make sure NACK and FEC are enabled on the correct payload types.
3421 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003422 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3423 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003424
3425 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3426 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003427 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003428 // TODO(juberti): Check RTCP, PLI, TMMBR.
3429}
3430
brandtr31bd2242017-05-19 05:47:46 -07003431// The following four tests ensures that FlexFEC is not activated by default
3432// when the field trials are not enabled.
3433// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3434// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003435TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003436 FakeVideoSendStream* stream = AddSendStream();
3437 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3438
brandtr3d200bd2017-01-16 06:59:19 -08003439 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003440 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3441 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003442}
3443
eladalonf1841382017-06-12 01:16:46 -07003444TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003445 FakeVideoSendStream* stream = AddSendStream(
3446 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3447 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3448
brandtr3d200bd2017-01-16 06:59:19 -08003449 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003450 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3451 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3452}
3453
Yves Gerey665174f2018-06-19 15:03:05 +02003454TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003455 AddRecvStream();
3456
3457 const std::vector<FakeFlexfecReceiveStream*>& streams =
3458 fake_call_->GetFlexfecReceiveStreams();
3459 EXPECT_TRUE(streams.empty());
3460}
3461
eladalonf1841382017-06-12 01:16:46 -07003462TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003463 AddRecvStream(
3464 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3465
3466 const std::vector<FakeFlexfecReceiveStream*>& streams =
3467 fake_call_->GetFlexfecReceiveStreams();
3468 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003469}
3470
3471// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3472// tests that use this test fixture into the corresponding "non-field trial"
3473// tests.
eladalonf1841382017-06-12 01:16:46 -07003474class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003475 public:
eladalonf1841382017-06-12 01:16:46 -07003476 WebRtcVideoChannelFlexfecRecvTest()
3477 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003478};
3479
eladalonf1841382017-06-12 01:16:46 -07003480TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003481 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3482 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3483 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3484}
3485
eladalonf1841382017-06-12 01:16:46 -07003486TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003487 AddRecvStream();
3488
3489 const std::vector<FakeFlexfecReceiveStream*>& streams =
3490 fake_call_->GetFlexfecReceiveStreams();
3491 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003492
3493 const std::vector<FakeVideoReceiveStream*>& video_streams =
3494 fake_call_->GetVideoReceiveStreams();
3495 ASSERT_EQ(1U, video_streams.size());
3496 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3497 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3498 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003499}
3500
eladalonf1841382017-06-12 01:16:46 -07003501TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003502 AddRecvStream(
3503 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3504
3505 const std::vector<FakeFlexfecReceiveStream*>& streams =
3506 fake_call_->GetFlexfecReceiveStreams();
3507 ASSERT_EQ(1U, streams.size());
3508 const FakeFlexfecReceiveStream* stream = streams.front();
3509 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3510 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3511 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3512 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3513 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003514
3515 const std::vector<FakeVideoReceiveStream*>& video_streams =
3516 fake_call_->GetVideoReceiveStreams();
3517 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003518 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3519 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003520 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003521 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003522 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003523}
3524
eladalonf1841382017-06-12 01:16:46 -07003525TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003526 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3527 cricket::VideoRecvParameters recv_parameters;
3528 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3529 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3530
3531 AddRecvStream(
3532 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3533 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003534 const std::vector<FakeVideoReceiveStream*>& video_streams =
3535 fake_call_->GetVideoReceiveStreams();
3536 ASSERT_EQ(1U, video_streams.size());
3537 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3538 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3539 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003540
3541 // Enable FlexFEC.
3542 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3543 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3544 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3545 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3546 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3547 << "Enabling FlexFEC should not create VideoReceiveStream.";
3548 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3549 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003550 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3551 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003552}
3553
eladalonf1841382017-06-12 01:16:46 -07003554TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003555 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3556 cricket::VideoRecvParameters recv_parameters;
3557 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3558 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3559 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3560
3561 AddRecvStream(
3562 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3563 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003564 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003565 const std::vector<FakeVideoReceiveStream*>& video_streams =
3566 fake_call_->GetVideoReceiveStreams();
3567 ASSERT_EQ(1U, video_streams.size());
3568 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3569 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3570 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003571
3572 // Disable FlexFEC.
3573 recv_parameters.codecs.clear();
3574 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3575 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3576 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3577 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3578 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3579 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3580 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3581 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003582 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3583 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003584}
3585
brandtr31bd2242017-05-19 05:47:46 -07003586// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3587// tests that use this test fixture into the corresponding "non-field trial"
3588// tests.
eladalonf1841382017-06-12 01:16:46 -07003589class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003590 public:
eladalonf1841382017-06-12 01:16:46 -07003591 WebRtcVideoChannelFlexfecSendRecvTest()
3592 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003593 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3594 }
3595};
3596
Yves Gerey665174f2018-06-19 15:03:05 +02003597TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003598 FakeVideoSendStream* stream = AddSendStream();
3599 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3600
brandtr3d200bd2017-01-16 06:59:19 -08003601 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3602 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3603 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003604}
3605
eladalonf1841382017-06-12 01:16:46 -07003606TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003607 FakeVideoSendStream* stream = AddSendStream(
3608 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3609 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3610
brandtr3d200bd2017-01-16 06:59:19 -08003611 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3612 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3613 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3614 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003615}
3616
eladalonf1841382017-06-12 01:16:46 -07003617TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003618 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003619 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003620 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003621
3622 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003623 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003624
brandtrb5f2c3f2016-10-04 23:28:39 -07003625 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3626 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003627}
3628
eladalonf1841382017-06-12 01:16:46 -07003629TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003630 cricket::VideoSendParameters parameters;
3631 parameters.codecs.push_back(GetEngineCodec("VP8"));
3632 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3633
3634 FakeVideoSendStream* stream = AddSendStream();
3635 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3636
brandtr3d200bd2017-01-16 06:59:19 -08003637 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003638}
3639
eladalonf1841382017-06-12 01:16:46 -07003640TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003641 AddRecvStream(
3642 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003643
3644 cricket::VideoRecvParameters recv_parameters;
3645 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3646 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3647 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003648
3649 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3650 fake_call_->GetFlexfecReceiveStreams();
3651 ASSERT_EQ(1U, flexfec_streams.size());
3652 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3653 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3654 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003655 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003656 flexfec_stream_config.payload_type);
3657 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3658 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3659 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3660 const std::vector<FakeVideoReceiveStream*>& video_streams =
3661 fake_call_->GetVideoReceiveStreams();
3662 const FakeVideoReceiveStream* video_stream = video_streams.front();
3663 const webrtc::VideoReceiveStream::Config& video_stream_config =
3664 video_stream->GetConfig();
3665 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3666 flexfec_stream_config.local_ssrc);
3667 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3668 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3669 flexfec_stream_config.rtcp_send_transport);
3670 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3671 // spec-compliant way.
3672 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3673 flexfec_stream_config.transport_cc);
3674 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3675 EXPECT_EQ(video_stream_config.rtp.extensions,
3676 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003677}
3678
brandtr31bd2242017-05-19 05:47:46 -07003679// We should not send FlexFEC, even if we advertise it, unless the right
3680// field trial is set.
3681// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003682TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003683 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3684 cricket::VideoSendParameters parameters;
3685 parameters.codecs.push_back(GetEngineCodec("VP8"));
3686 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3687 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3688
3689 FakeVideoSendStream* stream = AddSendStream();
3690 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3691
3692 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003693 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003694 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003698 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3699 cricket::VideoSendParameters parameters;
3700 parameters.codecs.push_back(GetEngineCodec("VP8"));
3701 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3702 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3703
3704 FakeVideoSendStream* stream = AddSendStream(
3705 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3706 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3707
3708 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003709 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003710 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3711}
3712
eladalonf1841382017-06-12 01:16:46 -07003713TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003714 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003715 const int kUnusedPayloadType = 127;
3716 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3717
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003718 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003719 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003720 parameters.codecs.push_back(rtx_codec);
3721 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003722 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003723}
3724
eladalonf1841382017-06-12 01:16:46 -07003725TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003726 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003727 const int kUnusedPayloadType1 = 126;
3728 const int kUnusedPayloadType2 = 127;
3729 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3730 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3731 {
3732 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3733 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3734 cricket::VideoSendParameters parameters;
3735 parameters.codecs.push_back(GetEngineCodec("VP8"));
3736 parameters.codecs.push_back(rtx_codec);
3737 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3738 }
3739 {
3740 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3741 kUnusedPayloadType1, kUnusedPayloadType2);
3742 cricket::VideoSendParameters parameters;
3743 parameters.codecs.push_back(GetEngineCodec("VP8"));
3744 parameters.codecs.push_back(rtx_codec);
3745 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3746 << "RTX without matching video codec should be rejected.";
3747 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003748}
3749
eladalonf1841382017-06-12 01:16:46 -07003750TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003751 const int kUnusedPayloadType1 = 126;
3752 const int kUnusedPayloadType2 = 127;
3753 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3754 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3755
3756 // SSRCs for RTX.
3757 cricket::StreamParams params =
3758 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3759 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3760 AddSendStream(params);
3761
3762 // Original payload type for RTX.
3763 cricket::VideoSendParameters parameters;
3764 parameters.codecs.push_back(GetEngineCodec("VP8"));
3765 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3766 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3767 parameters.codecs.push_back(rtx_codec);
3768 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3769 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3770 const webrtc::VideoSendStream::Config& config_before =
3771 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3772 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3773 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3774 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3775
3776 // Change payload type for RTX.
3777 parameters.codecs[1].id = kUnusedPayloadType2;
3778 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3779 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3780 const webrtc::VideoSendStream::Config& config_after =
3781 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3782 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3783 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3784 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3785}
3786
eladalonf1841382017-06-12 01:16:46 -07003787TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003788 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003789 parameters.codecs.push_back(GetEngineCodec("VP8"));
3790 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003791 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003792
3793 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003794 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003795
magjed509e4fe2016-11-18 01:34:11 -08003796 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003797
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003798 parameters.codecs.pop_back();
3799 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003800 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003801 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003802 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003803 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003804 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3805}
3806
eladalonf1841382017-06-12 01:16:46 -07003807TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003808 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003809 cricket::VideoSendParameters parameters;
3810 parameters.codecs.push_back(GetEngineCodec("VP8"));
3811 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3812 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3813
3814 FakeVideoSendStream* stream = AddSendStream(
3815 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3816 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3817
brandtr3d200bd2017-01-16 06:59:19 -08003818 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3819 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003820 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3821 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3822
3823 parameters.codecs.pop_back();
3824 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3825 stream = fake_call_->GetVideoSendStreams()[0];
3826 ASSERT_TRUE(stream != nullptr);
3827 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003828 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003829 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003830}
3831
eladalonf1841382017-06-12 01:16:46 -07003832TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003833 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003834 cricket::VideoCodec codec(100, "VP8");
3835 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3836 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003837
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003838 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003839 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003840
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003841 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003842 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003843 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003844
3845 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003846 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003847
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003848 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003849 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3850 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003851 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003852 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003853 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003854 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003855}
3856
eladalonf1841382017-06-12 01:16:46 -07003857TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003858 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3859 200000);
3860}
3861
eladalonf1841382017-06-12 01:16:46 -07003862TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003863 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3864 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3865 ASSERT_EQ(1u, streams.size());
3866 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3867}
3868
eladalonf1841382017-06-12 01:16:46 -07003869TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003870 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003871 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003872}
3873
eladalonf1841382017-06-12 01:16:46 -07003874TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003875 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003876}
3877
eladalonf1841382017-06-12 01:16:46 -07003878TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003879 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3880 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3881 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003882}
3883
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003884// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3885// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003886TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003887 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3888 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3889 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3890 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003891 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003892 ExpectSetBitrateParameters(100000, 200000, 400000);
3893 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3894 // Since the codec isn't changing, start_bitrate_bps should be -1.
3895 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003896
3897 // Decrease max_bandwidth_bps.
3898 send_parameters_.max_bandwidth_bps = 350000;
3899 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003900
3901 // Now try again with the values flipped around.
3902 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3903 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003904 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003905 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003906
3907 // If we change the codec max, max_bandwidth_bps should still apply.
3908 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003909 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003910 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003911}
3912
Yves Gerey665174f2018-06-19 15:03:05 +02003913TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003914 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3915 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003916 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003917 // Setting max bitrate should keep previous min bitrate.
3918 // Setting max bitrate should not reset start bitrate.
3919 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003920 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003921}
3922
eladalonf1841382017-06-12 01:16:46 -07003923TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003924 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003925 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003926 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003927 // -1 means to disable max bitrate (set infinite).
3928 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003929 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003930 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003931}
3932
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003934 send_parameters_.max_bandwidth_bps = 99999;
3935 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003936 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003937 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003938 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3939 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3940 stream->GetVideoStreams()[0].max_bitrate_bps);
3941
3942 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003943 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003944 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3945 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003946 stream->GetVideoStreams()[0].max_bitrate_bps);
3947}
3948
Åsa Persson55659812018-06-18 17:51:32 +02003949TEST_F(WebRtcVideoChannelTest,
3950 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
3951 send_parameters_.max_bandwidth_bps = 99999;
3952 FakeVideoSendStream* stream = AddSendStream();
3953 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3954 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3955 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3956 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3957 stream->GetVideoStreams()[0].max_bitrate_bps);
3958
3959 // Get and set the rtp encoding parameters.
3960 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3961 EXPECT_EQ(1u, parameters.encodings.size());
3962
3963 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
3964 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3965 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3966 stream->GetVideoStreams()[0].max_bitrate_bps);
3967
3968 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
3969 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3970 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3971 stream->GetVideoStreams()[0].max_bitrate_bps);
3972}
3973
eladalonf1841382017-06-12 01:16:46 -07003974TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003975 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003976 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003977 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003978 channel_->SetSend(true);
3979
3980 FakeVideoSendStream* stream = AddSendStream();
3981
Tommi85959932018-02-07 19:26:06 +01003982 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01003984 EXPECT_EQ(cricket::CS_RUNNING,
3985 capturer.Start(capturer.GetSupportedFormats()->front()));
3986
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003987 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
3988 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
3989 EXPECT_GT(initial_max_bitrate_bps, 0);
3990
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003991 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
3992 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01003993 // Insert a frame to update the encoder config.
3994 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003995 streams = stream->GetVideoStreams();
3996 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02003997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004001 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004002 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004003 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004004 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004005 channel_->SetSend(true);
4006
4007 FakeVideoSendStream* stream = AddSendStream(
4008 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4009
4010 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004011 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004012 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004013 EXPECT_EQ(cricket::CS_RUNNING,
4014 capturer.Start(capturer.GetSupportedFormats()->front()));
4015 EXPECT_TRUE(capturer.CaptureFrame());
4016
4017 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4018 ASSERT_GT(streams.size(), 1u)
4019 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004020 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004021 EXPECT_GT(initial_max_bitrate_bps, 0);
4022
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004023 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4024 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004025 // Insert a frame to update the encoder config.
4026 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004027 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004028 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004029 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4030
Niels Möllerff40b142018-04-09 08:49:14 +02004031 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004032}
4033
eladalonf1841382017-06-12 01:16:46 -07004034TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004035 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004036 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004037 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004038 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4039 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004040 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004041 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004042
4043 VideoCodec codec;
4044 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4045 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4046}
4047
eladalonf1841382017-06-12 01:16:46 -07004048TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004049 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004050 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004051 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004052 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004053 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004054 parameters.codecs[0].id = kIncorrectPayloads[i];
4055 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004056 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004057 }
4058}
4059
eladalonf1841382017-06-12 01:16:46 -07004060TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004061 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004062 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004063 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004064 parameters.codecs[0].id = payload_type;
4065 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004066 << "Payload type '" << payload_type << "' rejected.";
4067 }
4068}
4069
deadbeef67cf2c12016-04-13 10:07:16 -07004070// Test that setting the a different set of codecs but with an identical front
4071// codec doesn't result in the stream being recreated.
4072// This may happen when a subsequent negotiation includes fewer codecs, as a
4073// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004074TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004075 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4076 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004077 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4078 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004079 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4080
4081 AddSendStream();
4082 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4083
4084 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004085 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004086 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4087 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4088}
4089
eladalonf1841382017-06-12 01:16:46 -07004090TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004091 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004092 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004093 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004094}
4095
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004096// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004098 const int kUnusedPayloadType1 = 126;
4099 const int kUnusedPayloadType2 = 127;
4100 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4101 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4102
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004103 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004104 parameters.codecs.push_back(GetEngineCodec("VP8"));
4105 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004106 parameters.codecs.push_back(rtx_codec);
4107 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004108 << "RTX codec without associated payload should be rejected.";
4109
magjed509e4fe2016-11-18 01:34:11 -08004110 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004111 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004112 << "RTX codec with invalid associated payload type should be rejected.";
4113
magjed509e4fe2016-11-18 01:34:11 -08004114 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004115 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004116
magjed509e4fe2016-11-18 01:34:11 -08004117 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004118 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004119 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004120
Yves Gerey665174f2018-06-19 15:03:05 +02004121 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4122 << "RTX codec with another RTX as associated payload type should be "
4123 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004124}
4125
eladalonf1841382017-06-12 01:16:46 -07004126TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004127 const int kUnusedPayloadType1 = 126;
4128 const int kUnusedPayloadType2 = 127;
4129 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4130 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4131
4132 // SSRCs for RTX.
4133 cricket::StreamParams params =
4134 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4135 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4136 AddRecvStream(params);
4137
4138 // Original payload type for RTX.
4139 cricket::VideoRecvParameters parameters;
4140 parameters.codecs.push_back(GetEngineCodec("VP8"));
4141 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4142 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4143 parameters.codecs.push_back(rtx_codec);
4144 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4145 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4146 const webrtc::VideoReceiveStream::Config& config_before =
4147 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004148 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4149 const int* payload_type_before = FindKeyByValue(
4150 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4151 ASSERT_NE(payload_type_before, nullptr);
4152 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004153 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4154
4155 // Change payload type for RTX.
4156 parameters.codecs[1].id = kUnusedPayloadType2;
4157 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4158 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4159 const webrtc::VideoReceiveStream::Config& config_after =
4160 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004161 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4162 const int* payload_type_after = FindKeyByValue(
4163 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4164 ASSERT_NE(payload_type_after, nullptr);
4165 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004166 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4167}
4168
eladalonf1841382017-06-12 01:16:46 -07004169TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004170 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004171 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004172 parameters.codecs[0].id = 99;
4173 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004174}
4175
eladalonf1841382017-06-12 01:16:46 -07004176TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004177 cricket::VideoRecvParameters parameters;
4178 parameters.codecs = engine_.codecs();
4179 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004180
4181 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004182 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004183 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
4184 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004185}
4186
eladalonf1841382017-06-12 01:16:46 -07004187TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004189 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004190 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004191 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004192}
4193
eladalonf1841382017-06-12 01:16:46 -07004194TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004195 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004196 parameters.codecs.push_back(GetEngineCodec("VP8"));
4197 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004198 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004199}
4200
eladalonf1841382017-06-12 01:16:46 -07004201TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004202 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004203 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4204 send_parameters.codecs.push_back(GetEngineCodec("red"));
4205 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004207
4208 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004209
magjed509e4fe2016-11-18 01:34:11 -08004210 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004211 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004212
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004214 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004215 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004216 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004217 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004218 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004219 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4220}
4221
eladalonf1841382017-06-12 01:16:46 -07004222TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004223 AddRecvStream(
4224 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004225 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004226 fake_call_->GetFlexfecReceiveStreams();
4227
4228 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004229 const FakeFlexfecReceiveStream* stream = streams.front();
4230 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4231 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4232 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4233 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004234
4235 cricket::VideoRecvParameters recv_parameters;
4236 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4237 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4238 EXPECT_TRUE(streams.empty())
4239 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004240}
4241
eladalonf1841382017-06-12 01:16:46 -07004242TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004243 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004244 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004245 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004246
4247 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004248 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4249 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4250 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004251 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4252 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004253 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004254 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004255 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004256 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004257
4258 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004259 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4260 send_parameters.codecs.push_back(GetEngineCodec("red"));
4261 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004262 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4263 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004264 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004265 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004266 << "ULPFEC should be enabled on the receive stream.";
4267}
4268
eladalonf1841382017-06-12 01:16:46 -07004269TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004270 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004271 AddRecvStream(
4272 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004273 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004274 fake_call_->GetFlexfecReceiveStreams();
4275
4276 cricket::VideoRecvParameters recv_parameters;
4277 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4278 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4279 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4280 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004281 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004282 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004283 stream_with_recv_params->GetConfig().payload_type);
4284 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004285 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004286 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004287 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004288 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004289
4290 cricket::VideoSendParameters send_parameters;
4291 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4292 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4293 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4294 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004295 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004296 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004297 stream_with_send_params->GetConfig().payload_type);
4298 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004299 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004300 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004301 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004302 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004303}
4304
eladalonf1841382017-06-12 01:16:46 -07004305TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004306 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004307 parameters.codecs.push_back(GetEngineCodec("VP8"));
4308 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004309 parameters.codecs[1].id = parameters.codecs[0].id;
4310 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004311}
4312
eladalonf1841382017-06-12 01:16:46 -07004313TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004314 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004315 cricket::VideoRecvParameters parameters;
4316 parameters.codecs.push_back(GetEngineCodec("VP8"));
4317 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4318 parameters.codecs[1].id = parameters.codecs[0].id;
4319 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4320}
4321
eladalonf1841382017-06-12 01:16:46 -07004322TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004323 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004324 parameters.codecs.push_back(GetEngineCodec("VP8"));
4325 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004326 parameters.codecs[1].id = parameters.codecs[0].id;
4327 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004328}
4329
eladalonf1841382017-06-12 01:16:46 -07004330TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004331 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004332 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004333 parameters.codecs.push_back(GetEngineCodec("VP8"));
4334 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004335 parameters.codecs[1].id += 1;
4336 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004337}
4338
deadbeef67cf2c12016-04-13 10:07:16 -07004339// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004340// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004341TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004342 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004343 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004344 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4345 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004346 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004347
4348 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4349 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4350
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004351 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004352 parameters2.codecs.push_back(GetEngineCodec("red"));
4353 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004354 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004355 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4356}
4357
eladalonf1841382017-06-12 01:16:46 -07004358TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004359 EXPECT_FALSE(AddSendStream()->IsSending());
4360}
4361
eladalonf1841382017-06-12 01:16:46 -07004362TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004363 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004364}
4365
eladalonf1841382017-06-12 01:16:46 -07004366TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004367 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004368 EXPECT_FALSE(stream->IsSending());
4369
4370 // false->true
4371 EXPECT_TRUE(channel_->SetSend(true));
4372 EXPECT_TRUE(stream->IsSending());
4373 // true->true
4374 EXPECT_TRUE(channel_->SetSend(true));
4375 EXPECT_TRUE(stream->IsSending());
4376 // true->false
4377 EXPECT_TRUE(channel_->SetSend(false));
4378 EXPECT_FALSE(stream->IsSending());
4379 // false->false
4380 EXPECT_TRUE(channel_->SetSend(false));
4381 EXPECT_FALSE(stream->IsSending());
4382
4383 EXPECT_TRUE(channel_->SetSend(true));
4384 FakeVideoSendStream* new_stream = AddSendStream();
4385 EXPECT_TRUE(new_stream->IsSending())
4386 << "Send stream created after SetSend(true) not sending initially.";
4387}
4388
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004389// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004391 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004392 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004393 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004394 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004395
4396 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4397 channel->SetInterface(network_interface.get());
4398 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004399 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004400
4401 config.enable_dscp = true;
4402 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4403 channel->SetInterface(network_interface.get());
4404 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4405
4406 // Verify that setting the option to false resets the
4407 // DiffServCodePoint.
4408 config.enable_dscp = false;
4409 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4410 channel->SetInterface(network_interface.get());
4411 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004412}
4413
deadbeef13871492015-12-09 12:37:51 -08004414// This test verifies that the RTCP reduced size mode is properly applied to
4415// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004416TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004417 // Create stream, expecting that default mode is "compound".
4418 FakeVideoSendStream* stream1 = AddSendStream();
4419 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004420 webrtc::RtpParameters rtp_parameters =
4421 channel_->GetRtpSendParameters(last_ssrc_);
4422 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004423
4424 // Now enable reduced size mode.
4425 send_parameters_.rtcp.reduced_size = true;
4426 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4427 stream1 = fake_call_->GetVideoSendStreams()[0];
4428 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004429 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4430 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004431
4432 // Create a new stream and ensure it picks up the reduced size mode.
4433 FakeVideoSendStream* stream2 = AddSendStream();
4434 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4435}
4436
4437// This test verifies that the RTCP reduced size mode is properly applied to
4438// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004439TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004440 // Create stream, expecting that default mode is "compound".
4441 FakeVideoReceiveStream* stream1 = AddRecvStream();
4442 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4443
4444 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004445 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4446 // the reduced_size flag should come from that.
4447 send_parameters_.rtcp.reduced_size = true;
4448 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004449 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4450 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4451
4452 // Create a new stream and ensure it picks up the reduced size mode.
4453 FakeVideoReceiveStream* stream2 = AddRecvStream();
4454 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4455}
4456
eladalonf1841382017-06-12 01:16:46 -07004457TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004458 EXPECT_EQ(webrtc::kNetworkUp,
4459 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4460 EXPECT_EQ(webrtc::kNetworkUp,
4461 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004462
4463 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004464 EXPECT_EQ(webrtc::kNetworkDown,
4465 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4466 EXPECT_EQ(webrtc::kNetworkUp,
4467 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004468
4469 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004470 EXPECT_EQ(webrtc::kNetworkUp,
4471 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4472 EXPECT_EQ(webrtc::kNetworkUp,
4473 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004474}
4475
eladalonf1841382017-06-12 01:16:46 -07004476TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004477 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004478 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004479 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004480
4481 AddSendStream();
4482
4483 cricket::VideoMediaInfo info;
4484 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004485 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004486}
4487
eladalonf1841382017-06-12 01:16:46 -07004488TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004489 FakeVideoSendStream* stream = AddSendStream();
4490 webrtc::VideoSendStream::Stats stats;
4491 stats.encoder_implementation_name = "encoder_implementation_name";
4492 stream->SetStats(stats);
4493
4494 cricket::VideoMediaInfo info;
4495 ASSERT_TRUE(channel_->GetStats(&info));
4496 EXPECT_EQ(stats.encoder_implementation_name,
4497 info.senders[0].encoder_implementation_name);
4498}
4499
eladalonf1841382017-06-12 01:16:46 -07004500TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004501 FakeVideoSendStream* stream = AddSendStream();
4502 webrtc::VideoSendStream::Stats stats;
4503 stats.avg_encode_time_ms = 13;
4504 stats.encode_usage_percent = 42;
4505 stream->SetStats(stats);
4506
4507 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004508 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004509 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4510 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4511}
4512
eladalonf1841382017-06-12 01:16:46 -07004513TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004514 FakeVideoSendStream* stream = AddSendStream();
4515 webrtc::VideoSendStream::Stats stats;
4516 stats.frames_encoded = 13;
4517 stream->SetStats(stats);
4518
4519 cricket::VideoMediaInfo info;
4520 ASSERT_TRUE(channel_->GetStats(&info));
4521 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4522}
4523
eladalonf1841382017-06-12 01:16:46 -07004524TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004525 FakeVideoSendStream* stream = AddSendStream();
4526 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004527 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004528 stream->SetStats(stats);
4529
4530 cricket::VideoMediaInfo info;
4531 ASSERT_TRUE(channel_->GetStats(&info));
4532 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4533}
4534
eladalonf1841382017-06-12 01:16:46 -07004535TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004536 FakeVideoSendStream* stream = AddSendStream();
4537 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004538 stats.substreams[17].width = 123;
4539 stats.substreams[17].height = 40;
4540 stats.substreams[42].width = 80;
4541 stats.substreams[42].height = 31;
4542 stats.substreams[11].width = 20;
4543 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004544 stream->SetStats(stats);
4545
4546 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004547 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004548 ASSERT_EQ(1u, info.senders.size());
4549 EXPECT_EQ(123, info.senders[0].send_frame_width);
4550 EXPECT_EQ(90, info.senders[0].send_frame_height);
4551}
4552
eladalonf1841382017-06-12 01:16:46 -07004553TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004554 FakeVideoSendStream* stream = AddSendStream();
4555 webrtc::VideoSendStream::Stats stats;
4556 stats.number_of_cpu_adapt_changes = 2;
4557 stats.cpu_limited_resolution = true;
4558 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004559
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004560 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004561 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004562 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004563 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004564 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004565}
4566
eladalonf1841382017-06-12 01:16:46 -07004567TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004568 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004569 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004570 stats.number_of_cpu_adapt_changes = 2;
4571 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004572 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004573 stream->SetStats(stats);
4574
4575 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004576 EXPECT_TRUE(channel_->GetStats(&info));
4577 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004578 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4579 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004580 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004581 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004582}
4583
eladalonf1841382017-06-12 01:16:46 -07004584TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004585 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4586 FakeVideoSendStream* stream = AddSendStream();
4587 webrtc::VideoSendStream::Stats stats;
4588 stats.bw_limited_resolution = true;
4589 stream->SetStats(stats);
4590
4591 cricket::VideoMediaInfo info;
4592 EXPECT_TRUE(channel_->GetStats(&info));
4593 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004594 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004595 info.senders[0].adapt_reason);
4596}
4597
Yves Gerey665174f2018-06-19 15:03:05 +02004598TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004599 FakeVideoSendStream* stream = AddSendStream();
4600 webrtc::VideoSendStream::Stats stats;
4601 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4602 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4603 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4604
4605 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4606 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4607 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4608
4609 stream->SetStats(stats);
4610
4611 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004612 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004613 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4614 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4615 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4616}
4617
eladalonf1841382017-06-12 01:16:46 -07004618TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004619 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4620 FakeVideoReceiveStream* stream = AddRecvStream();
4621 webrtc::VideoReceiveStream::Stats stats;
4622 stats.rtcp_packet_type_counts.fir_packets = 2;
4623 stats.rtcp_packet_type_counts.nack_packets = 3;
4624 stats.rtcp_packet_type_counts.pli_packets = 4;
4625 stream->SetStats(stats);
4626
4627 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004628 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004629 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004630 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004631 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004632 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004633 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004634 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004635}
4636
eladalonf1841382017-06-12 01:16:46 -07004637TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004638 FakeVideoReceiveStream* stream = AddRecvStream();
4639 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004640 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004641 stats.decode_ms = 2;
4642 stats.max_decode_ms = 3;
4643 stats.current_delay_ms = 4;
4644 stats.target_delay_ms = 5;
4645 stats.jitter_buffer_ms = 6;
4646 stats.min_playout_delay_ms = 7;
4647 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004648 stats.width = 9;
4649 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004650 stats.frame_counts.key_frames = 11;
4651 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004652 stats.frames_rendered = 13;
4653 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004654 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004655 stream->SetStats(stats);
4656
4657 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004658 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004659 EXPECT_EQ(stats.decoder_implementation_name,
4660 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004661 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4662 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4663 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4664 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4665 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4666 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4667 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004668 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4669 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004670 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4671 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004672 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004673 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004674 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004675 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004676}
4677
eladalonf1841382017-06-12 01:16:46 -07004678TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004679 FakeVideoReceiveStream* stream = AddRecvStream();
4680 webrtc::VideoReceiveStream::Stats stats;
4681 stats.rtp_stats.transmitted.payload_bytes = 2;
4682 stats.rtp_stats.transmitted.header_bytes = 3;
4683 stats.rtp_stats.transmitted.padding_bytes = 4;
4684 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004685 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004686 stats.rtcp_stats.fraction_lost = 7;
4687 stream->SetStats(stats);
4688
4689 cricket::VideoMediaInfo info;
4690 ASSERT_TRUE(channel_->GetStats(&info));
4691 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4692 stats.rtp_stats.transmitted.header_bytes +
4693 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004694 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004695 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004696 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004697 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004698 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004699 info.receivers[0].fraction_lost);
4700}
4701
eladalonf1841382017-06-12 01:16:46 -07004702TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004703 AddSendStream();
4704 AddSendStream();
4705 webrtc::Call::Stats stats;
4706 stats.rtt_ms = 123;
4707 fake_call_->SetStats(stats);
4708
4709 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004710 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004711 ASSERT_EQ(2u, info.senders.size());
4712 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4713 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004717 FakeVideoSendStream* stream = AddSendStream();
4718 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004719 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004720 stats.media_bitrate_bps = 123;
4721 stats.substreams[17].total_bitrate_bps = 1;
4722 stats.substreams[17].retransmit_bitrate_bps = 2;
4723 stats.substreams[42].total_bitrate_bps = 3;
4724 stats.substreams[42].retransmit_bitrate_bps = 4;
4725 stream->SetStats(stats);
4726
4727 FakeVideoSendStream* stream2 = AddSendStream();
4728 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004729 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004730 stats2.media_bitrate_bps = 321;
4731 stats2.substreams[13].total_bitrate_bps = 5;
4732 stats2.substreams[13].retransmit_bitrate_bps = 6;
4733 stats2.substreams[21].total_bitrate_bps = 7;
4734 stats2.substreams[21].retransmit_bitrate_bps = 8;
4735 stream2->SetStats(stats2);
4736
4737 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004738 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004739 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004740 BandwidthEstimationInfo bwe_info;
4741 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004742 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4743 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4744 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4745 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004746 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004747 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004748 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004749 bwe_info.actual_enc_bitrate);
4750 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004751 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004752 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004753 << "Bandwidth stats should take all streams into account.";
4754}
4755
eladalonf1841382017-06-12 01:16:46 -07004756TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004757 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004758
Peter Boström0c4e06b2015-10-07 12:23:21 +02004759 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4760 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004761
4762 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4763 const size_t kDataLength = 12;
4764 uint8_t data[kDataLength];
4765 memset(data, 0, sizeof(data));
4766 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004767 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004768 rtc::PacketTime packet_time;
4769 channel_->OnPacketReceived(&packet, packet_time);
4770
4771 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4772 << "No default receive stream created.";
4773 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004774 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004775 << "Default receive stream should not have configured RTX";
4776
4777 EXPECT_TRUE(channel_->AddRecvStream(
4778 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4779 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004780 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004781 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004782 EXPECT_FALSE(
4783 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004784 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004785 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004786 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004787 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004788 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004789 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004790}
4791
eladalonf1841382017-06-12 01:16:46 -07004792TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004793 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004794
Peter Boström0c4e06b2015-10-07 12:23:21 +02004795 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4796 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004797
4798 StreamParams sp =
4799 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4800 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4801
4802 EXPECT_FALSE(channel_->AddSendStream(sp));
4803 EXPECT_FALSE(channel_->AddRecvStream(sp));
4804}
4805
eladalonf1841382017-06-12 01:16:46 -07004806TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004807 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004808
Peter Boström0c4e06b2015-10-07 12:23:21 +02004809 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4810 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004811
4812 StreamParams sp =
4813 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4814
4815 EXPECT_TRUE(channel_->AddSendStream(sp));
4816 EXPECT_TRUE(channel_->AddRecvStream(sp));
4817
4818 // The RTX SSRC is already used in previous streams, using it should fail.
4819 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4820 EXPECT_FALSE(channel_->AddSendStream(sp));
4821 EXPECT_FALSE(channel_->AddRecvStream(sp));
4822
4823 // After removing the original stream this should be fine to add (makes sure
4824 // that RTX ssrcs are not forever taken).
4825 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4826 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4827 EXPECT_TRUE(channel_->AddSendStream(sp));
4828 EXPECT_TRUE(channel_->AddRecvStream(sp));
4829}
4830
eladalonf1841382017-06-12 01:16:46 -07004831TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004832 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004833 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4834 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004835 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004836
Peter Boströmd6f4c252015-03-26 16:23:04 +01004837 StreamParams sp =
4838 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4839
4840 EXPECT_TRUE(channel_->AddSendStream(sp));
4841 EXPECT_TRUE(channel_->AddRecvStream(sp));
4842
4843 // One of the SSRCs is already used in previous streams, using it should fail.
4844 sp = cricket::CreateSimStreamParams("cname",
4845 MAKE_VECTOR(kOverlappingStreamSsrcs));
4846 EXPECT_FALSE(channel_->AddSendStream(sp));
4847 EXPECT_FALSE(channel_->AddRecvStream(sp));
4848
4849 // After removing the original stream this should be fine to add (makes sure
4850 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004851 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4852 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004853 EXPECT_TRUE(channel_->AddSendStream(sp));
4854 EXPECT_TRUE(channel_->AddRecvStream(sp));
4855}
4856
eladalonf1841382017-06-12 01:16:46 -07004857TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004858 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004859
4860 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4861 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4862
4863 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4864 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4865
4866 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4867
4868 static const uint32_t kReceiverSsrcs[] = {3};
4869 static const uint32_t kReceiverRtxSsrcs[] = {2};
4870
4871 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4872 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4873 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4874
4875 cricket::VideoMediaInfo info;
4876 ASSERT_TRUE(channel_->GetStats(&info));
4877
4878 ASSERT_EQ(1u, info.senders.size());
4879 ASSERT_EQ(1u, info.receivers.size());
4880
4881 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4882 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4883 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4884}
4885
eladalonf1841382017-06-12 01:16:46 -07004886TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004887 FakeVideoReceiveStream* stream = AddRecvStream();
4888 webrtc::VideoReceiveStream::Stats stats;
4889 cricket::VideoMediaInfo info;
4890
4891 // Report no codec name before receiving.
4892 stream->SetStats(stats);
4893 ASSERT_TRUE(channel_->GetStats(&info));
4894 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4895
4896 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004897 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004898 stream->SetStats(stats);
4899 ASSERT_TRUE(channel_->GetStats(&info));
4900 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4901
4902 // Report no codec name for unknown playload types.
4903 stats.current_payload_type = 3;
4904 stream->SetStats(stats);
4905 ASSERT_TRUE(channel_->GetStats(&info));
4906 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4907}
4908
Seth Hampson5897a6e2018-04-03 11:16:33 -07004909// Tests that when we add a stream without SSRCs, but contains a stream_id
4910// that it is stored and its stream id is later used when the first packet
4911// arrives to properly create a receive stream with a sync label.
4912TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4913 const char kSyncLabel[] = "sync_label";
4914 cricket::StreamParams unsignaled_stream;
4915 unsignaled_stream.set_stream_ids({kSyncLabel});
4916 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4917 // The stream shouldn't have been created at this point because it doesn't
4918 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004919 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004920
4921 // Create and deliver packet.
4922 const size_t kDataLength = 12;
4923 uint8_t data[kDataLength];
4924 memset(data, 0, sizeof(data));
4925 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4926 rtc::CopyOnWriteBuffer packet(data, kDataLength);
4927 rtc::PacketTime packet_time;
4928 channel_->OnPacketReceived(&packet, packet_time);
4929
4930 // The stream should now be created with the appropriate sync label.
4931 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4932 EXPECT_EQ(kSyncLabel,
4933 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4934
4935 // Removing the unsignaled stream should clear the cache. This time when
4936 // a default video receive stream is created it won't have a sync_group.
4937 ASSERT_TRUE(channel_->RemoveRecvStream(0));
4938 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
4939 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4940
4941 channel_->OnPacketReceived(&packet, packet_time);
4942 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4943 EXPECT_TRUE(
4944 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
4945}
4946
eladalonf1841382017-06-12 01:16:46 -07004947void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07004948 uint8_t payload_type,
4949 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08004950 // kRedRtxPayloadType must currently be unused.
4951 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
4952
noahricd10a68e2015-07-10 11:27:55 -07004953 // Add a RED RTX codec.
4954 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08004955 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004956 recv_parameters_.codecs.push_back(red_rtx_codec);
4957 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07004958
4959 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4960 const size_t kDataLength = 12;
4961 uint8_t data[kDataLength];
4962 memset(data, 0, sizeof(data));
4963
4964 rtc::Set8(data, 1, payload_type);
4965 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07004966 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07004967 rtc::PacketTime packet_time;
4968 channel_->OnPacketReceived(&packet, packet_time);
4969
4970 if (expect_created_receive_stream) {
4971 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4972 << "Should have created a receive stream for payload type: "
4973 << payload_type;
4974 } else {
4975 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
4976 << "Shouldn't have created a receive stream for payload type: "
4977 << payload_type;
4978 }
4979}
4980
eladalonf1841382017-06-12 01:16:46 -07004981TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004982 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
4983 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004984}
4985
eladalonf1841382017-06-12 01:16:46 -07004986TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004987 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
4988 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004989}
4990
eladalonf1841382017-06-12 01:16:46 -07004991TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02004992 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08004993 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
4994 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
4995 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
4996 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004997}
4998
eladalonf1841382017-06-12 01:16:46 -07004999TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005000 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5001 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005002}
5003
eladalonf1841382017-06-12 01:16:46 -07005004TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005005 FlexfecPacketDoesntCreateUnsignalledStream) {
5006 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5007 false /* expect_created_receive_stream */);
5008}
5009
eladalonf1841382017-06-12 01:16:46 -07005010TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005011 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5012 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005013}
5014
mzanaty8a855d62017-02-17 15:46:43 -08005015// Test that receiving any unsignalled SSRC works even if it changes.
5016// The first unsignalled SSRC received will create a default receive stream.
5017// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005018TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005019 // Allow receiving VP8, VP9, H264 (if enabled).
5020 cricket::VideoRecvParameters parameters;
5021 parameters.codecs.push_back(GetEngineCodec("VP8"));
5022 parameters.codecs.push_back(GetEngineCodec("VP9"));
5023
5024#if defined(WEBRTC_USE_H264)
5025 cricket::VideoCodec H264codec(126, "H264");
5026 parameters.codecs.push_back(H264codec);
5027#endif
5028
5029 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5030 // No receive streams yet.
5031 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5032 cricket::FakeVideoRenderer renderer;
5033 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5034
5035 // Receive VP8 packet on first SSRC.
5036 uint8_t data[kMinRtpPacketLen];
5037 cricket::RtpHeader rtpHeader;
5038 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5039 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005040 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005041 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5042 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5043 rtc::PacketTime packet_time;
5044 channel_->OnPacketReceived(&packet, packet_time);
5045 // VP8 packet should create default receive stream.
5046 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005047 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005048 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5049 // Verify that the receive stream sinks to a renderer.
5050 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5051 webrtc::kVideoRotation_0);
5052 recv_stream->InjectFrame(video_frame);
5053 EXPECT_EQ(1, renderer.num_rendered_frames());
5054
5055 // Receive VP9 packet on second SSRC.
5056 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005057 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005058 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5059 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5060 channel_->OnPacketReceived(&packet2, packet_time);
5061 // VP9 packet should replace the default receive SSRC.
5062 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5063 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5064 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5065 // Verify that the receive stream sinks to a renderer.
5066 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005067 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005068 recv_stream->InjectFrame(video_frame2);
5069 EXPECT_EQ(2, renderer.num_rendered_frames());
5070
5071#if defined(WEBRTC_USE_H264)
5072 // Receive H264 packet on third SSRC.
5073 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005074 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005075 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5076 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5077 channel_->OnPacketReceived(&packet3, packet_time);
5078 // H264 packet should replace the default receive SSRC.
5079 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5080 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5081 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5082 // Verify that the receive stream sinks to a renderer.
5083 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005084 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005085 recv_stream->InjectFrame(video_frame3);
5086 EXPECT_EQ(3, renderer.num_rendered_frames());
5087#endif
5088}
5089
brandtr0dc57ea2017-05-29 23:33:31 -07005090// This test verifies that when a new default stream is created for a new
5091// unsignaled SSRC, the new stream does not overwrite any old stream that had
5092// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005093TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005094 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5095 cricket::VideoRecvParameters parameters;
5096 parameters.codecs.push_back(GetEngineCodec("VP8"));
5097 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5098
5099 // No streams signaled and no packets received, so we should not have any
5100 // stream objects created yet.
5101 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5102
5103 // Receive packet on an unsignaled SSRC.
5104 uint8_t data[kMinRtpPacketLen];
5105 cricket::RtpHeader rtp_header;
5106 rtp_header.payload_type = GetEngineCodec("VP8").id;
5107 rtp_header.seq_num = rtp_header.timestamp = 0;
5108 rtp_header.ssrc = kSsrcs3[0];
5109 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5110 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5111 rtc::PacketTime packet_time;
5112 channel_->OnPacketReceived(&packet, packet_time);
5113 // Default receive stream should be created.
5114 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5115 FakeVideoReceiveStream* recv_stream0 =
5116 fake_call_->GetVideoReceiveStreams()[0];
5117 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5118
5119 // Signal the SSRC.
5120 EXPECT_TRUE(
5121 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5122 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5123 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5124 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5125
5126 // Receive packet on a different unsignaled SSRC.
5127 rtp_header.ssrc = kSsrcs3[1];
5128 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5129 packet.SetData(data, sizeof(data));
5130 channel_->OnPacketReceived(&packet, packet_time);
5131 // New default receive stream should be created, but old stream should remain.
5132 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5133 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5134 FakeVideoReceiveStream* recv_stream1 =
5135 fake_call_->GetVideoReceiveStreams()[1];
5136 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5137}
5138
Seth Hampson7c682e02018-05-04 16:28:15 -07005139TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005140 AddSendStream();
5141
Tommi85959932018-02-07 19:26:06 +01005142 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005143 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005144 cricket::VideoFormat capture_format_hd =
5145 capturer.GetSupportedFormats()->front();
5146 EXPECT_EQ(1280, capture_format_hd.width);
5147 EXPECT_EQ(720, capture_format_hd.height);
5148 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5149 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005150 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005151
perkjfa10b552016-10-02 23:45:26 -07005152 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005153 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005154
5155 // TODO(skvlad): Resolve the inconsistency between the interpretation
5156 // of the global bitrate limit for audio and video:
5157 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5158 // max_bandwidth_bps = -1 - remove the bandwidth limit
5159 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005160 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005161
perkjfa10b552016-10-02 23:45:26 -07005162 SetAndExpectMaxBitrate(1000, 0, 1000);
5163 SetAndExpectMaxBitrate(1000, 800, 800);
5164 SetAndExpectMaxBitrate(600, 800, 600);
5165 SetAndExpectMaxBitrate(0, 800, 800);
5166 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005167
Niels Möllerff40b142018-04-09 08:49:14 +02005168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005169}
5170
eladalonf1841382017-06-12 01:16:46 -07005171TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005172 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005173 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005174 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005175
5176 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005177 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005178 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005179}
5180
eladalonf1841382017-06-12 01:16:46 -07005181TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005182 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005183 FakeVideoSendStream* stream = AddSendStream();
5184
Seth Hampson7c682e02018-05-04 16:28:15 -07005185 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5186 EXPECT_EQ(1UL, parameters.encodings.size());
5187 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5188 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5189
5190 // Note that this is testing the behavior of the FakeVideoSendStream, which
5191 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5192 // we are just testing the behavior of
5193 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005194 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5195 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005196
5197 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5198 // by this amount.
5199 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5200 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5201 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5202 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5203
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005204 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5205 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5206 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5207}
5208
5209TEST_F(WebRtcVideoChannelTest,
5210 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5211 FakeVideoSendStream* stream = AddSendStream();
5212
5213 // Note that this is testing the behavior of the FakeVideoSendStream, which
5214 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5215 // we are just testing the behavior of
5216 // EncoderStreamFactory::CreateEncoderStreams.
5217 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5218 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5219
5220 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5221 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5222 EXPECT_EQ(1UL, parameters.encodings.size());
5223 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5224 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5225
5226 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5227 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5228 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5229}
5230
5231TEST_F(WebRtcVideoChannelTest,
5232 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5233 send_parameters_.max_bandwidth_bps = 99999;
5234 FakeVideoSendStream* stream = AddSendStream();
5235 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5236 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5237 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5238 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5239 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5240 stream->GetVideoStreams()[0].max_bitrate_bps);
5241
5242 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5243 // adjusted down.
5244 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5245 EXPECT_EQ(1UL, parameters.encodings.size());
5246 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5247 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5248 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5249 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5250 stream->GetVideoStreams()[0].min_bitrate_bps);
5251 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5252 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005253}
5254
5255TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005256 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005257 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005258 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005259 // Two or more encodings should result in failure.
5260 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005261 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005262 // Zero encodings should also fail.
5263 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005264 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005265}
5266
Zach Stein3ca452b2018-01-18 10:01:24 -08005267TEST_F(WebRtcVideoChannelTest,
5268 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5269 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5270 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5271 AddSendStream(sp);
5272
5273 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5274
5275 // Additional encodings should result in failure.
5276 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005277 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005278 // Zero encodings should also fail.
5279 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005280 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005281}
5282
deadbeeffb2aced2017-01-06 23:05:37 -08005283// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005284TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005285 AddSendStream();
5286 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005287 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005288 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005289}
5290
Seth Hampson24722b32017-12-22 09:36:42 -08005291// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5292// a value <= 0, setting the parameters returns false.
5293TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5294 AddSendStream();
5295 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5296 EXPECT_EQ(1UL, parameters.encodings.size());
5297 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5298 parameters.encodings[0].bitrate_priority);
5299
5300 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005301 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005302 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005303 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005304}
5305
5306// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5307// properly on the VideoChannel and propogates down to the video encoder.
5308TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5309 AddSendStream();
5310 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5311 EXPECT_EQ(1UL, parameters.encodings.size());
5312 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5313 parameters.encodings[0].bitrate_priority);
5314
5315 // Change the value and set it on the VideoChannel.
5316 double new_bitrate_priority = 2.0;
5317 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005318 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005319
5320 // Verify that the encoding parameters bitrate_priority is set for the
5321 // VideoChannel.
5322 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5323 EXPECT_EQ(1UL, parameters.encodings.size());
5324 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5325
5326 // Verify that the new value propagated down to the encoder.
5327 std::vector<FakeVideoSendStream*> video_send_streams =
5328 fake_call_->GetVideoSendStreams();
5329 EXPECT_EQ(1UL, video_send_streams.size());
5330 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5331 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5332 // appropriately.
5333 EXPECT_EQ(new_bitrate_priority,
5334 video_send_stream->GetEncoderConfig().bitrate_priority);
5335 // Check that the vector of VideoStreams also was propagated correctly. Note
5336 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5337 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005338 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005339 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5340}
5341
5342// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5343// VideoChannel and the value propogates to the video encoder with all simulcast
5344// streams.
5345TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5346 // Create the stream params with multiple ssrcs for simulcast.
5347 const int kNumSimulcastStreams = 3;
5348 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5349 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5350 AddSendStream(stream_params);
5351 uint32_t primary_ssrc = stream_params.first_ssrc();
5352
Tommi85959932018-02-07 19:26:06 +01005353 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5354 // frame. This creates multiple VideoStreams for all simulcast layers when
5355 // reconfiguring, and allows us to test this behavior.
5356 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005357 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005358 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005359 EXPECT_EQ(cricket::CS_RUNNING,
5360 capturer.Start(cricket::VideoFormat(
5361 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5362 cricket::FOURCC_I420)));
5363 channel_->SetSend(true);
5364 EXPECT_TRUE(capturer.CaptureFrame());
5365 // Get and set the rtp encoding parameters.
5366 webrtc::RtpParameters parameters =
5367 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005368 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5369 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005370 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5371 parameters.encodings[0].bitrate_priority);
5372 // Change the value and set it on the VideoChannel.
5373 double new_bitrate_priority = 2.0;
5374 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005375 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005376
5377 // Verify that the encoding parameters priority is set on the VideoChannel.
5378 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005379 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5380 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005381 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5382
5383 // Verify that the new value propagated down to the encoder.
5384 std::vector<FakeVideoSendStream*> video_send_streams =
5385 fake_call_->GetVideoSendStreams();
5386 EXPECT_EQ(1UL, video_send_streams.size());
5387 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5388 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5389 // appropriately.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005390 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
Seth Hampson24722b32017-12-22 09:36:42 -08005391 video_send_stream->GetEncoderConfig().number_of_streams);
5392 EXPECT_EQ(new_bitrate_priority,
5393 video_send_stream->GetEncoderConfig().bitrate_priority);
5394 // Check that the vector of VideoStreams also propagated correctly. The
5395 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5396 // these are created appropriately for the simulcast case.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005397 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5398 video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005399 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005400 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5401 // Since we are only setting bitrate priority per-sender, the other
5402 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005403 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005404 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005405 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005406 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005407 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005408}
5409
Åsa Persson55659812018-06-18 17:51:32 +02005410TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5411 const size_t kNumSimulcastStreams = 3;
5412 SetUpSimulcast(true, false);
5413
5414 // Get and set the rtp encoding parameters.
5415 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5416 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5417 for (const auto& encoding : parameters.encodings) {
5418 EXPECT_FALSE(encoding.min_bitrate_bps);
5419 EXPECT_FALSE(encoding.max_bitrate_bps);
5420 }
5421
5422 // Change the value and set it on the VideoChannel.
5423 parameters.encodings[0].min_bitrate_bps = 100000;
5424 parameters.encodings[0].max_bitrate_bps = 200000;
5425 parameters.encodings[1].min_bitrate_bps = 300000;
5426 parameters.encodings[1].max_bitrate_bps = 400000;
5427 parameters.encodings[2].min_bitrate_bps = 500000;
5428 parameters.encodings[2].max_bitrate_bps = 600000;
5429 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5430
5431 // Verify that the bitrates are set on the VideoChannel.
5432 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5434 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5435 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5436 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5437 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5438 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5439 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5440}
5441
5442TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5443 const size_t kNumSimulcastStreams = 3;
5444 SetUpSimulcast(true, false);
5445
5446 // Get and set the rtp encoding parameters.
5447 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5448 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5449
5450 // Max bitrate lower than min bitrate should fail.
5451 parameters.encodings[2].min_bitrate_bps = 100000;
5452 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5453 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5454 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5455}
5456
5457// Test that min and max bitrate values set via RtpParameters are correctly
5458// propagated to the underlying encoder, and that the target is set to 3/4 of
5459// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5460// that are used if no min/max are specified).
5461TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5462 const size_t kNumSimulcastStreams = 3;
5463 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5464
5465 // Send a full size frame so all simulcast layers are used when reconfiguring.
5466 FakeVideoCapturerWithTaskQueue capturer;
5467 VideoOptions options;
5468 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5469 EXPECT_EQ(cricket::CS_RUNNING,
5470 capturer.Start(capturer.GetSupportedFormats()->front()));
5471 channel_->SetSend(true);
5472 EXPECT_TRUE(capturer.CaptureFrame());
5473
5474 // Get and set the rtp encoding parameters.
5475 // Change the value and set it on the VideoChannel.
5476 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5477 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5478 parameters.encodings[0].min_bitrate_bps = 100000;
5479 parameters.encodings[0].max_bitrate_bps = 200000;
5480 parameters.encodings[1].min_bitrate_bps = 300000;
5481 parameters.encodings[1].max_bitrate_bps = 400000;
5482 parameters.encodings[2].min_bitrate_bps = 500000;
5483 parameters.encodings[2].max_bitrate_bps = 600000;
5484 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5485
5486 // Verify that the new value propagated down to the encoder.
5487 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5488 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5489 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5490 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5491 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5492 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5493 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5494 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5495 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5496 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5497 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5498
5499 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5500 // VideoStreams are created appropriately for the simulcast case.
5501 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5502 // Target bitrate: 200000 * 3 / 4 = 150000.
5503 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5504 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5505 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5506 // Target bitrate: 400000 * 3 / 4 = 300000.
5507 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5508 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5509 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5510 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5511 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5512 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5513 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5514
5515 // No parameter changed, encoder should not be reconfigured.
5516 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5517 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5518
5519 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5520}
5521
5522// Test to only specify the min or max bitrate value for a layer via
5523// RtpParameters. The unspecified min/max and target value should be set to the
5524// simulcast default that is used if no min/max are specified.
5525TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5526 const size_t kNumSimulcastStreams = 3;
5527 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5528 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5529
5530 // Send a full size frame so all simulcast layers are used when reconfiguring.
5531 FakeVideoCapturerWithTaskQueue capturer;
5532 VideoOptions options;
5533 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5534 EXPECT_EQ(cricket::CS_RUNNING,
5535 capturer.Start(capturer.GetSupportedFormats()->front()));
5536 channel_->SetSend(true);
5537 EXPECT_TRUE(capturer.CaptureFrame());
5538
5539 // Get and set the rtp encoding parameters.
5540 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5541 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5542
5543 // Change the value and set it on the VideoChannel.
5544 // Layer 0: only configure min bitrate.
5545 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5546 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5547 // Layer 1: only configure max bitrate.
5548 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5549 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5550 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5551
5552 // Verify that the new value propagated down to the encoder.
5553 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5554 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5555 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5556 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5557 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5558 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5559 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5560 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5561 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5562 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5563
5564 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5565 // VideoStreams are created appropriately for the simulcast case.
5566 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5567 // Layer 0: min configured bitrate should overwrite min default.
5568 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5569 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5570 stream->GetVideoStreams()[0].target_bitrate_bps);
5571 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5572 stream->GetVideoStreams()[0].max_bitrate_bps);
5573 // Layer 1: max configured bitrate should overwrite max default.
5574 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5575 stream->GetVideoStreams()[1].min_bitrate_bps);
5576 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5577 stream->GetVideoStreams()[1].target_bitrate_bps);
5578 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5579 // Layer 2: min and max bitrate not configured, default expected.
5580 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5581 stream->GetVideoStreams()[2].min_bitrate_bps);
5582 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5583 stream->GetVideoStreams()[2].target_bitrate_bps);
5584 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5585 stream->GetVideoStreams()[2].max_bitrate_bps);
5586
5587 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5588}
5589
5590// Test that specifying the min (or max) bitrate value for a layer via
5591// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5592// unspecified values accordingly.
5593TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5594 const size_t kNumSimulcastStreams = 3;
5595 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5596 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5597
5598 // Send a full size frame so all simulcast layers are used when reconfiguring.
5599 FakeVideoCapturerWithTaskQueue capturer;
5600 VideoOptions options;
5601 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5602 EXPECT_EQ(cricket::CS_RUNNING,
5603 capturer.Start(capturer.GetSupportedFormats()->front()));
5604 channel_->SetSend(true);
5605 EXPECT_TRUE(capturer.CaptureFrame());
5606
5607 // Get and set the rtp encoding parameters.
5608 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5609 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5610
5611 // Change the value and set it on the VideoChannel.
5612 // For layer 0, set the min bitrate above the default max.
5613 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
5614 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5615 // For layer 1, set the max bitrate below the default min.
5616 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
5617 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5618 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5619
5620 // Verify that the new value propagated down to the encoder.
5621 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5622 // VideoStreams are created appropriately for the simulcast case.
5623 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5624 // Layer 0: Min bitrate above default max (target/max should be adjusted).
5625 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5626 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
5627 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
5628 // Layer 1: Max bitrate below default min (min/target should be adjusted).
5629 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
5630 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
5631 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5632 // Layer 2: min and max bitrate not configured, default expected.
5633 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5634 stream->GetVideoStreams()[2].min_bitrate_bps);
5635 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5636 stream->GetVideoStreams()[2].target_bitrate_bps);
5637 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5638 stream->GetVideoStreams()[2].max_bitrate_bps);
5639
5640 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5641}
5642
5643TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
5644 const size_t kNumSimulcastStreams = 3;
5645 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5646 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5647
5648 // Send a full size frame so all simulcast layers are used when reconfiguring.
5649 FakeVideoCapturerWithTaskQueue capturer;
5650 VideoOptions options;
5651 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5652 EXPECT_EQ(cricket::CS_RUNNING,
5653 capturer.Start(capturer.GetSupportedFormats()->front()));
5654 channel_->SetSend(true);
5655 EXPECT_TRUE(capturer.CaptureFrame());
5656
5657 // Set max bitrate for all but the highest layer.
5658 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5659 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5660 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
5661 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
5662 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5663
5664 // Set max bandwidth equal to total max bitrate.
5665 send_parameters_.max_bandwidth_bps =
5666 GetTotalMaxBitrateBps(stream->GetVideoStreams());
5667 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5668 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5669
5670 // No bitrate above the total max to give to the highest layer.
5671 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5672 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5673 stream->GetVideoStreams()[2].max_bitrate_bps);
5674
5675 // Set max bandwidth above the total max bitrate.
5676 send_parameters_.max_bandwidth_bps =
5677 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5678 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5679 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5680
5681 // The highest layer has no max bitrate set -> the bitrate above the total
5682 // max should be given to the highest layer.
5683 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5684 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5685 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
5686 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
5687 stream->GetVideoStreams()[2].max_bitrate_bps);
5688
5689 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5690}
5691
5692TEST_F(WebRtcVideoChannelTest,
5693 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
5694 const size_t kNumSimulcastStreams = 3;
5695 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5696 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
5697 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5698
5699 // Send a full size frame so all simulcast layers are used when reconfiguring.
5700 FakeVideoCapturerWithTaskQueue capturer;
5701 VideoOptions options;
5702 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5703 EXPECT_EQ(cricket::CS_RUNNING,
5704 capturer.Start(capturer.GetSupportedFormats()->front()));
5705 channel_->SetSend(true);
5706 EXPECT_TRUE(capturer.CaptureFrame());
5707
5708 // Set max bitrate for the highest layer.
5709 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5710 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5711 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
5712 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5713
5714 // Set max bandwidth above the total max bitrate.
5715 send_parameters_.max_bandwidth_bps =
5716 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5717 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5718 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5719
5720 // The highest layer has the max bitrate set -> the bitrate above the total
5721 // max should not be given to the highest layer.
5722 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5723 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
5724 stream->GetVideoStreams()[2].max_bitrate_bps);
5725
5726 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5727}
5728
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005729// Test that min and max bitrate values set via RtpParameters are correctly
5730// propagated to the underlying encoder for a single stream.
5731TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
5732 FakeVideoSendStream* stream = AddSendStream();
5733 EXPECT_TRUE(channel_->SetSend(true));
5734 EXPECT_TRUE(stream->IsSending());
5735
5736 // Set min and max bitrate.
5737 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5738 EXPECT_EQ(1u, parameters.encodings.size());
5739 parameters.encodings[0].min_bitrate_bps = 80000;
5740 parameters.encodings[0].max_bitrate_bps = 150000;
5741 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5742
5743 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5744 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5745 EXPECT_EQ(1u, encoder_config.number_of_streams);
5746 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5747 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5748 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5749
5750 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5751 // VideoStreams are created appropriately.
5752 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5753 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
5754 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5755 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
5756}
5757
5758// Test the default min and max bitrate value are correctly propagated to the
5759// underlying encoder for a single stream (when the values are not set via
5760// RtpParameters).
5761TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
5762 FakeVideoSendStream* stream = AddSendStream();
5763 EXPECT_TRUE(channel_->SetSend(true));
5764 EXPECT_TRUE(stream->IsSending());
5765
5766 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5767 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5768 EXPECT_EQ(1u, encoder_config.number_of_streams);
5769 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5770 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
5771 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5772
5773 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5774 // VideoStreams are created appropriately.
5775 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5776 EXPECT_EQ(cricket::kMinVideoBitrateBps,
5777 stream->GetVideoStreams()[0].min_bitrate_bps);
5778 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
5779 stream->GetVideoStreams()[0].min_bitrate_bps);
5780 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
5781 stream->GetVideoStreams()[0].target_bitrate_bps);
5782}
5783
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005784// Test that a stream will not be sending if its encoding is made inactive
5785// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08005786TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07005787 FakeVideoSendStream* stream = AddSendStream();
5788 EXPECT_TRUE(channel_->SetSend(true));
5789 EXPECT_TRUE(stream->IsSending());
5790
5791 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005792 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07005793 ASSERT_EQ(1u, parameters.encodings.size());
5794 ASSERT_TRUE(parameters.encodings[0].active);
5795 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08005796 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005797 EXPECT_FALSE(stream->IsSending());
5798
5799 // Now change it back to active and verify we resume sending.
5800 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08005801 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005802 EXPECT_TRUE(stream->IsSending());
5803}
5804
Seth Hampson8234ead2018-02-02 15:16:24 -08005805// Tests that when active is updated for any simulcast layer then the send
5806// stream's sending state will be updated and it will be reconfigured with the
5807// new appropriate active simulcast streams.
5808TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
5809 // Create the stream params with multiple ssrcs for simulcast.
5810 const int kNumSimulcastStreams = 3;
5811 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5812 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5813 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
5814 uint32_t primary_ssrc = stream_params.first_ssrc();
5815
Tommi85959932018-02-07 19:26:06 +01005816 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5817 // frame. This allows us to test that ReconfigureEncoder is called
5818 // appropriately.
5819 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08005820 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005821 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08005822 EXPECT_EQ(cricket::CS_RUNNING,
5823 capturer.Start(cricket::VideoFormat(
5824 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5825 cricket::FOURCC_I420)));
5826 channel_->SetSend(true);
5827 EXPECT_TRUE(capturer.CaptureFrame());
5828
5829 // Check that all encodings are initially active.
5830 webrtc::RtpParameters parameters =
5831 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005832 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5833 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005834 EXPECT_TRUE(parameters.encodings[0].active);
5835 EXPECT_TRUE(parameters.encodings[1].active);
5836 EXPECT_TRUE(parameters.encodings[2].active);
5837 EXPECT_TRUE(fake_video_send_stream->IsSending());
5838
5839 // Only turn on only the middle stream.
5840 parameters.encodings[0].active = false;
5841 parameters.encodings[1].active = true;
5842 parameters.encodings[2].active = false;
5843 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5844 // Verify that the active fields are set on the VideoChannel.
5845 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005846 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5847 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005848 EXPECT_FALSE(parameters.encodings[0].active);
5849 EXPECT_TRUE(parameters.encodings[1].active);
5850 EXPECT_FALSE(parameters.encodings[2].active);
5851 // Check that the VideoSendStream is updated appropriately. This means its
5852 // send state was updated and it was reconfigured.
5853 EXPECT_TRUE(fake_video_send_stream->IsSending());
5854 std::vector<webrtc::VideoStream> simulcast_streams =
5855 fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005856 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5857 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005858 EXPECT_FALSE(simulcast_streams[0].active);
5859 EXPECT_TRUE(simulcast_streams[1].active);
5860 EXPECT_FALSE(simulcast_streams[2].active);
5861
5862 // Turn off all streams.
5863 parameters.encodings[0].active = false;
5864 parameters.encodings[1].active = false;
5865 parameters.encodings[2].active = false;
5866 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5867 // Verify that the active fields are set on the VideoChannel.
5868 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005869 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5870 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005871 EXPECT_FALSE(parameters.encodings[0].active);
5872 EXPECT_FALSE(parameters.encodings[1].active);
5873 EXPECT_FALSE(parameters.encodings[2].active);
5874 // Check that the VideoSendStream is off.
5875 EXPECT_FALSE(fake_video_send_stream->IsSending());
5876 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005877 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5878 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005879 EXPECT_FALSE(simulcast_streams[0].active);
5880 EXPECT_FALSE(simulcast_streams[1].active);
5881 EXPECT_FALSE(simulcast_streams[2].active);
5882
Niels Möllerff40b142018-04-09 08:49:14 +02005883 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08005884}
5885
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005886// Test that if a stream is reconfigured (due to a codec change or other
5887// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07005888TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005889 InactiveStreamDoesntStartSendingWhenReconfigured) {
5890 // Set an initial codec list, which will be modified later.
5891 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08005892 parameters1.codecs.push_back(GetEngineCodec("VP8"));
5893 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005894 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
5895
5896 FakeVideoSendStream* stream = AddSendStream();
5897 EXPECT_TRUE(channel_->SetSend(true));
5898 EXPECT_TRUE(stream->IsSending());
5899
5900 // Get current parameters and change "active" to false.
5901 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5902 ASSERT_EQ(1u, parameters.encodings.size());
5903 ASSERT_TRUE(parameters.encodings[0].active);
5904 parameters.encodings[0].active = false;
5905 EXPECT_EQ(1u, GetFakeSendStreams().size());
5906 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08005907 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005908 EXPECT_FALSE(stream->IsSending());
5909
5910 // Reorder the codec list, causing the stream to be reconfigured.
5911 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08005912 parameters2.codecs.push_back(GetEngineCodec("VP9"));
5913 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005914 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
5915 auto new_streams = GetFakeSendStreams();
5916 // Assert that a new underlying stream was created due to the codec change.
5917 // Otherwise, this test isn't testing what it set out to test.
5918 EXPECT_EQ(1u, GetFakeSendStreams().size());
5919 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
5920
5921 // Verify that we still are not sending anything, due to the inactive
5922 // encoding.
5923 EXPECT_FALSE(new_streams[0]->IsSending());
5924}
5925
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005926// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07005927TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005928 AddSendStream();
5929 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005930 parameters.codecs.push_back(GetEngineCodec("VP8"));
5931 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005932 EXPECT_TRUE(channel_->SetSendParameters(parameters));
5933
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005934 webrtc::RtpParameters rtp_parameters =
5935 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005936 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08005937 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
5938 rtp_parameters.codecs[0]);
5939 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
5940 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005941}
5942
Florent Castellidacec712018-05-24 16:24:21 +02005943// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
5944TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
5945 StreamParams params = StreamParams::CreateLegacy(kSsrc);
5946 params.cname = "rtcpcname";
5947 AddSendStream(params);
5948
5949 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
5950 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
5951}
5952
deadbeeffb2aced2017-01-06 23:05:37 -08005953// Test that RtpParameters for send stream has one encoding and it has
5954// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07005955TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08005956 AddSendStream();
5957
5958 webrtc::RtpParameters rtp_parameters =
5959 channel_->GetRtpSendParameters(last_ssrc_);
5960 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01005961 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08005962}
5963
Florent Castelliabe301f2018-06-12 18:33:49 +02005964TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
5965 AddSendStream();
5966
5967 webrtc::RtpParameters rtp_parameters =
5968 channel_->GetRtpSendParameters(last_ssrc_);
5969 rtp_parameters.header_extensions.emplace_back();
5970
5971 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
5972
5973 webrtc::RTCError result =
5974 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5975 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
5976}
5977
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005978// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07005979TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005980 AddSendStream();
5981 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005982 parameters.codecs.push_back(GetEngineCodec("VP8"));
5983 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005984 EXPECT_TRUE(channel_->SetSendParameters(parameters));
5985
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005986 webrtc::RtpParameters initial_params =
5987 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005988
5989 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08005990 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005991
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005992 // ... And this shouldn't change the params returned by GetRtpSendParameters.
5993 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
5994}
5995
5996// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07005997TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005998 AddRecvStream();
5999 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006000 parameters.codecs.push_back(GetEngineCodec("VP8"));
6001 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006002 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6003
6004 webrtc::RtpParameters rtp_parameters =
6005 channel_->GetRtpReceiveParameters(last_ssrc_);
6006 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006007 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6008 rtp_parameters.codecs[0]);
6009 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6010 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006011}
6012
johan073ece42016-08-26 02:59:47 -07006013#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006014TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006015#else
eladalonf1841382017-06-12 01:16:46 -07006016TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006017#endif
johan3859c892016-08-05 09:19:25 -07006018 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006019 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006020 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006021 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006022 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006023 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006024 parameters.codecs.push_back(kH264sprop2);
6025 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6026
6027 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6028 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6029 webrtc::RtpParameters rtp_parameters =
6030 channel_->GetRtpReceiveParameters(last_ssrc_);
6031 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6032 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6033 ASSERT_EQ(2u, cfg.decoders.size());
6034 EXPECT_EQ(101, cfg.decoders[0].payload_type);
6035 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006036 const auto it0 =
6037 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
6038 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
6039 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006040
6041 EXPECT_EQ(102, cfg.decoders[1].payload_type);
6042 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006043 const auto it1 =
6044 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
6045 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
6046 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006047}
6048
sakal1fd95952016-06-22 00:46:15 -07006049// Test that RtpParameters for receive stream has one encoding and it has
6050// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006051TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006052 AddRecvStream();
6053
6054 webrtc::RtpParameters rtp_parameters =
6055 channel_->GetRtpReceiveParameters(last_ssrc_);
6056 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006057 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006058}
6059
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006060// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006061TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006062 AddRecvStream();
6063 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006064 parameters.codecs.push_back(GetEngineCodec("VP8"));
6065 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006066 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6067
6068 webrtc::RtpParameters initial_params =
6069 channel_->GetRtpReceiveParameters(last_ssrc_);
6070
6071 // We should be able to set the params we just got.
6072 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6073
6074 // ... And this shouldn't change the params returned by
6075 // GetRtpReceiveParameters.
6076 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006077}
6078
deadbeef3bc15102017-04-20 19:25:07 -07006079// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6080// aren't signaled. It should always return an empty "RtpEncodingParameters",
6081// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006082TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006083 // Call necessary methods to configure receiving a default stream as
6084 // soon as it arrives.
6085 cricket::VideoRecvParameters parameters;
6086 parameters.codecs.push_back(GetEngineCodec("VP8"));
6087 parameters.codecs.push_back(GetEngineCodec("VP9"));
6088 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6089
6090 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6091 // stream. Should return nothing.
6092 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6093
6094 // Set a sink for an unsignaled stream.
6095 cricket::FakeVideoRenderer renderer;
6096 // Value of "0" means "unsignaled stream".
6097 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6098
6099 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6100 // in this method means "unsignaled stream".
6101 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6102 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6103 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6104
6105 // Receive VP8 packet.
6106 uint8_t data[kMinRtpPacketLen];
6107 cricket::RtpHeader rtpHeader;
6108 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6109 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6110 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6111 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6112 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6113 rtc::PacketTime packet_time;
6114 channel_->OnPacketReceived(&packet, packet_time);
6115
6116 // The |ssrc| member should still be unset.
6117 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6118 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6119 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6120}
6121
eladalonf1841382017-06-12 01:16:46 -07006122void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006123 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006124 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006125
6126 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006127 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006128 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006129 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006130
6131 if (receiver_first) {
6132 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6133 std::vector<FakeVideoReceiveStream*> receive_streams =
6134 fake_call_->GetVideoReceiveStreams();
6135 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006136 // Default local SSRC when we have no sender.
6137 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6138 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006139 }
6140 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6141 if (!receiver_first)
6142 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6143 std::vector<FakeVideoReceiveStream*> receive_streams =
6144 fake_call_->GetVideoReceiveStreams();
6145 ASSERT_EQ(1u, receive_streams.size());
6146 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006147
6148 // Removing first sender should fall back to another (in this case the second)
6149 // local send stream's SSRC.
6150 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6151 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006152 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006153 ASSERT_EQ(1u, receive_streams.size());
6154 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6155
6156 // Removing the last sender should fall back to default local SSRC.
6157 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006158 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006159 ASSERT_EQ(1u, receive_streams.size());
6160 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6161 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006162}
6163
eladalonf1841382017-06-12 01:16:46 -07006164TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006165 TestReceiverLocalSsrcConfiguration(false);
6166}
6167
eladalonf1841382017-06-12 01:16:46 -07006168TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006169 TestReceiverLocalSsrcConfiguration(true);
6170}
6171
eladalonf1841382017-06-12 01:16:46 -07006172class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006173 public:
eladalonf1841382017-06-12 01:16:46 -07006174 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006175 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006176 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6177 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006178 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006179 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006180 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006181 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006182 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006183
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006184 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006185 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006186 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006187 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006188 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006189 last_ssrc_ = 123;
6190 }
6191
6192 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006193 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006194 int capture_width,
6195 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006196 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006197 size_t expected_num_streams,
6198 bool screenshare,
6199 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006200 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006201 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006202 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006203 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006204
Peter Boström0c4e06b2015-10-07 12:23:21 +02006205 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006206 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006207 ssrcs.resize(num_configured_streams);
6208
sprangf24a0642017-02-28 13:23:26 -08006209 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006210 // Send a full-size frame to trigger a stream reconfiguration to use all
6211 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006212 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006213 VideoOptions options;
6214 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006215 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006216 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006217 // Fetch the latest stream since SetVideoSend() may recreate it if the
6218 // screen content setting is changed.
6219 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006220 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006221 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006222 cricket::VideoFormat::FpsToInterval(30),
6223 cricket::FOURCC_I420)));
6224 channel_->SetSend(true);
6225 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006226
Zach Stein3ca452b2018-01-18 10:01:24 -08006227 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6228 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6229
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006230 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6231 ASSERT_EQ(expected_num_streams, video_streams.size());
6232
sprang429600d2017-01-26 06:12:26 -08006233 std::vector<webrtc::VideoStream> expected_streams;
6234 if (conference_mode) {
6235 expected_streams = GetSimulcastConfig(
6236 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006237 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006238 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006239 if (screenshare) {
6240 for (const webrtc::VideoStream& stream : expected_streams) {
6241 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006242 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6243 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006244 }
6245 }
sprang429600d2017-01-26 06:12:26 -08006246 } else {
6247 webrtc::VideoStream stream;
6248 stream.width = capture_width;
6249 stream.height = capture_height;
6250 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006251 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006252 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006253 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006254 stream.max_qp = kDefaultQpMax;
6255 expected_streams.push_back(stream);
6256 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006257
6258 ASSERT_EQ(expected_streams.size(), video_streams.size());
6259
6260 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006261 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006262 for (size_t i = 0; i < num_streams; ++i) {
6263 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6264 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6265
6266 EXPECT_GT(video_streams[i].max_framerate, 0);
6267 EXPECT_EQ(expected_streams[i].max_framerate,
6268 video_streams[i].max_framerate);
6269
6270 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6271 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6272 video_streams[i].min_bitrate_bps);
6273
6274 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6275 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6276 video_streams[i].target_bitrate_bps);
6277
6278 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6279 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6280 video_streams[i].max_bitrate_bps);
6281
6282 EXPECT_GT(video_streams[i].max_qp, 0);
6283 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6284
Sergey Silkina796a7e2018-03-01 15:11:29 +01006285 EXPECT_EQ(conference_mode,
6286 expected_streams[i].num_temporal_layers.has_value());
6287
6288 if (conference_mode) {
6289 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6290 video_streams[i].num_temporal_layers);
6291 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006292
6293 if (i == num_streams - 1) {
6294 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6295 } else {
6296 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6297 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006298 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006299
Niels Möllerff40b142018-04-09 08:49:14 +02006300 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006301 }
6302
6303 FakeVideoSendStream* AddSendStream() {
6304 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6305 }
6306
6307 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006308 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006309 EXPECT_TRUE(channel_->AddSendStream(sp));
6310 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006311 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006312 EXPECT_EQ(num_streams + 1, streams.size());
6313 return streams[streams.size() - 1];
6314 }
6315
6316 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006317 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006318 }
6319
6320 FakeVideoReceiveStream* AddRecvStream() {
6321 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6322 }
6323
6324 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006325 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006326 EXPECT_TRUE(channel_->AddRecvStream(sp));
6327 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006328 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006329 EXPECT_EQ(num_streams + 1, streams.size());
6330 return streams[streams.size() - 1];
6331 }
6332
skvlad11a9cbf2016-10-07 11:53:05 -07006333 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006334 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006335 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6336 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006337 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006338 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006339 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006340};
6341
eladalonf1841382017-06-12 01:16:46 -07006342TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006343 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6344 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006345}
6346
eladalonf1841382017-06-12 01:16:46 -07006347TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006348 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6349 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006350}
6351
6352// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006353TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006354 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6355 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006356}
sprang429600d2017-01-26 06:12:26 -08006357
eladalonf1841382017-06-12 01:16:46 -07006358TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006359 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6360 false);
6361}
6362
eladalonf1841382017-06-12 01:16:46 -07006363TEST_F(WebRtcVideoChannelSimulcastTest,
sprang429600d2017-01-26 06:12:26 -08006364 SetSendCodecsForConferenceModeScreenshare) {
6365 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6366 true);
6367}
6368
eladalonf1841382017-06-12 01:16:46 -07006369TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006370 webrtc::test::ScopedFieldTrials override_field_trials_(
6371 "WebRTC-SimulcastScreenshare/Enabled/");
6372 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6373 true);
6374}
6375
eladalonf1841382017-06-12 01:16:46 -07006376TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006377 NoSimulcastScreenshareWithoutConference) {
6378 webrtc::test::ScopedFieldTrials override_field_trials_(
6379 "WebRTC-SimulcastScreenshare/Enabled/");
6380 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6381 false);
6382}
6383
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006384} // namespace cricket