blob: c8464770679024cbfee03d54291b374e5161f06a [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020020#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010021#include "api/video/encoded_image.h"
22#include "api/video/video_timing.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020023#include "modules/video_coding/include/video_coding_defines.h"
24#include "modules/video_coding/jitter_estimator.h"
25#include "modules/video_coding/timing.h"
26#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "rtc_base/trace_event.h"
31#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020032#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020033
34namespace webrtc {
35namespace video_coding {
36
37namespace {
philipele0b2f152016-09-28 10:23:49 +020038// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010039constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020040
philipele0b2f152016-09-28 10:23:49 +020041// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010042constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070043
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010044// The time it's allowed for a frame to be late to its rendering prediction and
45// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010046constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010047
philipel65e1f942017-07-24 08:26:53 -070048constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020049} // namespace
50
philipelbe7a9e52016-05-19 12:19:35 +020051FrameBuffer::FrameBuffer(Clock* clock,
52 VCMJitterEstimator* jitter_estimator,
philipela45102f2017-02-22 05:30:39 -080053 VCMTiming* timing,
54 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010055 : decoded_frames_history_(kMaxFramesHistory),
56 clock_(clock),
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020057 callback_queue_(nullptr),
philipelbe7a9e52016-05-19 12:19:35 +020058 jitter_estimator_(jitter_estimator),
59 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020060 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070061 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080062 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070063 stats_callback_(stats_callback),
Elad Alone4b50232019-01-14 18:56:14 +010064 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs),
65 add_rtt_to_playout_delay_(
Henrik Boströmc680c4a2019-04-03 10:27:36 +000066 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay")) {}
philipel266f0a42016-11-28 08:49:07 -080067
philipela45102f2017-02-22 05:30:39 -080068FrameBuffer::~FrameBuffer() {}
philipelbe7a9e52016-05-19 12:19:35 +020069
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020070void FrameBuffer::NextFrame(
71 int64_t max_wait_time_ms,
72 bool keyframe_required,
73 rtc::TaskQueue* callback_queue,
74 std::function<void(std::unique_ptr<EncodedFrame>, ReturnReason)> handler) {
75 RTC_DCHECK_RUN_ON(callback_queue);
76 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
77 int64_t latest_return_time_ms =
78 clock_->TimeInMilliseconds() + max_wait_time_ms;
79 rtc::CritScope lock(&crit_);
80 if (stopped_) {
81 return;
82 }
83 latest_return_time_ms_ = latest_return_time_ms;
84 keyframe_required_ = keyframe_required;
85 frame_handler_ = handler;
86 callback_queue_ = callback_queue;
87 StartWaitForNextFrameOnQueue();
88}
89
90void FrameBuffer::StartWaitForNextFrameOnQueue() {
91 RTC_DCHECK(callback_queue_);
92 RTC_DCHECK(!callback_task_.Running());
93 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
94 callback_task_ = RepeatingTaskHandle::DelayedStart(
95 callback_queue_->Get(), TimeDelta::ms(wait_ms), [this] {
96 // If this task has not been cancelled, we did not get any new frames
97 // while waiting. Continue with frame delivery.
98 rtc::CritScope lock(&crit_);
99 if (!frames_to_decode_.empty()) {
100 // We have frames, deliver!
101 frame_handler_(absl::WrapUnique(GetNextFrame()), kFrameFound);
102 CancelCallback();
103 return TimeDelta::Zero(); // Ignored.
104 } else if (clock_->TimeInMilliseconds() >= latest_return_time_ms_) {
105 // We have timed out, signal this and stop repeating.
106 frame_handler_(nullptr, kTimeout);
107 CancelCallback();
108 return TimeDelta::Zero(); // Ignored.
109 } else {
110 // If there's no frames to decode and there is still time left, it
111 // means that the frame buffer was cleared between creation and
112 // execution of this task. Continue waiting for the remaining time.
113 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
114 return TimeDelta::ms(wait_ms);
115 }
116 });
117}
118
philipel75562822016-09-05 10:57:41 +0200119FrameBuffer::ReturnReason FrameBuffer::NextFrame(
120 int64_t max_wait_time_ms,
philipele7c891f2018-02-22 14:35:06 +0100121 std::unique_ptr<EncodedFrame>* frame_out,
philipel3042c2d2017-08-18 04:55:02 -0700122 bool keyframe_required) {
tommidb23ea62017-03-03 07:21:18 -0800123 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
philipel1c056252017-01-31 09:53:12 -0800124 int64_t latest_return_time_ms =
125 clock_->TimeInMilliseconds() + max_wait_time_ms;
philipel504c47d2016-06-30 17:33:02 +0200126 int64_t wait_ms = max_wait_time_ms;
philipel29f730e2017-03-15 08:10:08 -0700127 int64_t now_ms = 0;
philipele0b2f152016-09-28 10:23:49 +0200128
129 do {
philipel29f730e2017-03-15 08:10:08 -0700130 now_ms = clock_->TimeInMilliseconds();
philipel504c47d2016-06-30 17:33:02 +0200131 {
132 rtc::CritScope lock(&crit_);
tommi0a735642017-03-14 06:23:57 -0700133 new_continuous_frame_event_.Reset();
philipel29f730e2017-03-15 08:10:08 -0700134 if (stopped_)
135 return kStopped;
136
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200137 keyframe_required_ = keyframe_required;
138 latest_return_time_ms_ = latest_return_time_ms;
139 wait_ms = FindNextFrame(now_ms);
140 }
tommi0a735642017-03-14 06:23:57 -0700141 } while (new_continuous_frame_event_.Wait(wait_ms));
philipele0b2f152016-09-28 10:23:49 +0200142
philipel29f730e2017-03-15 08:10:08 -0700143 {
144 rtc::CritScope lock(&crit_);
philipele0b2f152016-09-28 10:23:49 +0200145
Ilya Nikolaevskiyfdfe1c92019-01-18 13:33:38 +0100146 if (!frames_to_decode_.empty()) {
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200147 frame_out->reset(GetNextFrame());
philipel29f730e2017-03-15 08:10:08 -0700148 return kFrameFound;
philipelbe7a9e52016-05-19 12:19:35 +0200149 }
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200150 }
tommi0a735642017-03-14 06:23:57 -0700151
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200152 if (latest_return_time_ms - clock_->TimeInMilliseconds() > 0) {
philipel1c056252017-01-31 09:53:12 -0800153 // If |next_frame_it_ == frames_.end()| and there is still time left, it
154 // means that the frame buffer was cleared as the thread in this function
155 // was waiting to acquire |crit_| in order to return. Wait for the
156 // remaining time and then return.
157 return NextFrame(latest_return_time_ms - now_ms, frame_out);
philipelbe7a9e52016-05-19 12:19:35 +0200158 }
tommi0a735642017-03-14 06:23:57 -0700159 return kTimeout;
philipelbe7a9e52016-05-19 12:19:35 +0200160}
161
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200162int64_t FrameBuffer::FindNextFrame(int64_t now_ms) {
163 int64_t wait_ms = latest_return_time_ms_ - now_ms;
164 frames_to_decode_.clear();
165
166 // |last_continuous_frame_| may be empty below, but nullopt is smaller
167 // than everything else and loop will immediately terminate as expected.
168 for (auto frame_it = frames_.begin();
169 frame_it != frames_.end() && frame_it->first <= last_continuous_frame_;
170 ++frame_it) {
171 if (!frame_it->second.continuous ||
172 frame_it->second.num_missing_decodable > 0) {
173 continue;
174 }
175
176 EncodedFrame* frame = frame_it->second.frame.get();
177
178 if (keyframe_required_ && !frame->is_keyframe())
179 continue;
180
181 auto last_decoded_frame_timestamp =
182 decoded_frames_history_.GetLastDecodedFrameTimestamp();
183
184 // TODO(https://bugs.webrtc.org/9974): consider removing this check
185 // as it may make a stream undecodable after a very long delay between
186 // frames.
187 if (last_decoded_frame_timestamp &&
188 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
189 continue;
190 }
191
192 // Only ever return all parts of a superframe. Therefore skip this
193 // frame if it's not a beginning of a superframe.
194 if (frame->inter_layer_predicted) {
195 continue;
196 }
197
198 // Gather all remaining frames for the same superframe.
199 std::vector<FrameMap::iterator> current_superframe;
200 current_superframe.push_back(frame_it);
201 bool last_layer_completed = frame_it->second.frame->is_last_spatial_layer;
202 FrameMap::iterator next_frame_it = frame_it;
203 while (true) {
204 ++next_frame_it;
205 if (next_frame_it == frames_.end() ||
206 next_frame_it->first.picture_id != frame->id.picture_id ||
207 !next_frame_it->second.continuous) {
208 break;
209 }
210 // Check if the next frame has some undecoded references other than
211 // the previous frame in the same superframe.
212 size_t num_allowed_undecoded_refs =
213 (next_frame_it->second.frame->inter_layer_predicted) ? 1 : 0;
214 if (next_frame_it->second.num_missing_decodable >
215 num_allowed_undecoded_refs) {
216 break;
217 }
218 // All frames in the superframe should have the same timestamp.
219 if (frame->Timestamp() != next_frame_it->second.frame->Timestamp()) {
220 RTC_LOG(LS_WARNING) << "Frames in a single superframe have different"
221 " timestamps. Skipping undecodable superframe.";
222 break;
223 }
224 current_superframe.push_back(next_frame_it);
225 last_layer_completed = next_frame_it->second.frame->is_last_spatial_layer;
226 }
227 // Check if the current superframe is complete.
228 // TODO(bugs.webrtc.org/10064): consider returning all available to
229 // decode frames even if the superframe is not complete yet.
230 if (!last_layer_completed) {
231 continue;
232 }
233
234 frames_to_decode_ = std::move(current_superframe);
235
236 if (frame->RenderTime() == -1) {
237 frame->SetRenderTime(timing_->RenderTimeMs(frame->Timestamp(), now_ms));
238 }
239 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
240
241 // This will cause the frame buffer to prefer high framerate rather
242 // than high resolution in the case of the decoder not decoding fast
243 // enough and the stream has multiple spatial and temporal layers.
244 // For multiple temporal layers it may cause non-base layer frames to be
245 // skipped if they are late.
246 if (wait_ms < -kMaxAllowedFrameDelayMs)
247 continue;
248
249 break;
250 }
251 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms_ - now_ms);
252 wait_ms = std::max<int64_t>(wait_ms, 0);
253 return wait_ms;
254}
255
256EncodedFrame* FrameBuffer::GetNextFrame() {
257 int64_t now_ms = clock_->TimeInMilliseconds();
258 // TODO(ilnik): remove |frames_out| use frames_to_decode_ directly.
259 std::vector<EncodedFrame*> frames_out;
260
261 RTC_DCHECK(!frames_to_decode_.empty());
262 bool superframe_delayed_by_retransmission = false;
263 size_t superframe_size = 0;
264 EncodedFrame* first_frame = frames_to_decode_[0]->second.frame.get();
265 int64_t render_time_ms = first_frame->RenderTime();
266 int64_t receive_time_ms = first_frame->ReceivedTime();
267 // Gracefully handle bad RTP timestamps and render time issues.
268 if (HasBadRenderTiming(*first_frame, now_ms)) {
269 jitter_estimator_->Reset();
270 timing_->Reset();
271 render_time_ms = timing_->RenderTimeMs(first_frame->Timestamp(), now_ms);
272 }
273
274 for (FrameMap::iterator& frame_it : frames_to_decode_) {
275 RTC_DCHECK(frame_it != frames_.end());
276 EncodedFrame* frame = frame_it->second.frame.release();
277
278 frame->SetRenderTime(render_time_ms);
279
280 superframe_delayed_by_retransmission |= frame->delayed_by_retransmission();
281 receive_time_ms = std::max(receive_time_ms, frame->ReceivedTime());
282 superframe_size += frame->size();
283
284 PropagateDecodability(frame_it->second);
285 decoded_frames_history_.InsertDecoded(frame_it->first, frame->Timestamp());
286
287 // Remove decoded frame and all undecoded frames before it.
288 frames_.erase(frames_.begin(), ++frame_it);
289
290 frames_out.push_back(frame);
291 }
292
293 if (!superframe_delayed_by_retransmission) {
294 int64_t frame_delay;
295
296 if (inter_frame_delay_.CalculateDelay(first_frame->Timestamp(),
297 &frame_delay, receive_time_ms)) {
298 jitter_estimator_->UpdateEstimate(frame_delay, superframe_size);
299 }
300
301 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
302 if (RttMultExperiment::RttMultEnabled()) {
303 rtt_mult = RttMultExperiment::GetRttMultValue();
304 }
305 timing_->SetJitterDelay(jitter_estimator_->GetJitterEstimate(rtt_mult));
306 timing_->UpdateCurrentDelay(render_time_ms, now_ms);
307 } else {
308 if (RttMultExperiment::RttMultEnabled() || add_rtt_to_playout_delay_)
309 jitter_estimator_->FrameNacked();
310 }
311
312 UpdateJitterDelay();
313 UpdateTimingFrameInfo();
314
315 if (frames_out.size() == 1) {
316 return frames_out[0];
317 } else {
318 return CombineAndDeleteFrames(frames_out);
319 }
320}
321
philipele7c891f2018-02-22 14:35:06 +0100322bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
323 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700324 // Assume that render timing errors are due to changes in the video stream.
325 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200326 // Zero render time means render immediately.
327 if (render_time_ms == 0) {
328 return false;
329 }
stefan95e97542017-05-23 09:52:18 -0700330 if (render_time_ms < 0) {
331 return true;
332 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200333 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700334 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
335 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100336 RTC_LOG(LS_WARNING)
337 << "A frame about to be decoded is out of the configured "
338 << "delay bounds (" << frame_delay << " > " << kMaxVideoDelayMs
339 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700340 return true;
341 }
342 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100343 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
344 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700345 return true;
346 }
347 return false;
348}
349
philipel4f6cd6a2016-08-03 10:59:32 +0200350void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800351 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000352 rtc::CritScope lock(&crit_);
353 protection_mode_ = mode;
philipel4f6cd6a2016-08-03 10:59:32 +0200354}
355
philipel504c47d2016-06-30 17:33:02 +0200356void FrameBuffer::Start() {
tommidb23ea62017-03-03 07:21:18 -0800357 TRACE_EVENT0("webrtc", "FrameBuffer::Start");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000358 rtc::CritScope lock(&crit_);
359 stopped_ = false;
philipel504c47d2016-06-30 17:33:02 +0200360}
361
362void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800363 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000364 rtc::CritScope lock(&crit_);
365 stopped_ = true;
366 new_continuous_frame_event_.Set();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200367 CancelCallback();
philipel504c47d2016-06-30 17:33:02 +0200368}
369
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100370void FrameBuffer::Clear() {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000371 rtc::CritScope lock(&crit_);
372 ClearFramesAndHistory();
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100373}
374
philipele21be1d2017-09-25 06:37:12 -0700375void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000376 rtc::CritScope lock(&crit_);
377 jitter_estimator_->UpdateRtt(rtt_ms);
philipele21be1d2017-09-25 06:37:12 -0700378}
379
philipele7c891f2018-02-22 14:35:06 +0100380bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel112adf92017-06-15 09:06:21 -0700381 for (size_t i = 0; i < frame.num_references; ++i) {
Philip Eliasson1f850a62019-03-19 12:15:00 +0000382 if (frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700383 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700384
philipel112adf92017-06-15 09:06:21 -0700385 for (size_t j = i + 1; j < frame.num_references; ++j) {
386 if (frame.references[i] == frame.references[j])
387 return false;
388 }
389 }
390
philipel0fa82a62018-03-19 15:34:53 +0100391 if (frame.inter_layer_predicted && frame.id.spatial_layer == 0)
philipel112adf92017-06-15 09:06:21 -0700392 return false;
393
394 return true;
395}
396
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200397void FrameBuffer::CancelCallback() {
398 frame_handler_ = {};
399 callback_task_.Stop();
400 callback_queue_ = nullptr;
401}
402
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100403bool FrameBuffer::IsCompleteSuperFrame(const EncodedFrame& frame) {
404 if (frame.inter_layer_predicted) {
405 // Check that all previous spatial layers are already inserted.
406 VideoLayerFrameId id = frame.id;
407 RTC_DCHECK_GT(id.spatial_layer, 0);
408 --id.spatial_layer;
409 FrameMap::iterator prev_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200410 if (prev_frame == frames_.end() || !prev_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100411 return false;
412 while (prev_frame->second.frame->inter_layer_predicted) {
Ilya Nikolaevskiyf87a7df2019-04-09 19:23:36 +0200413 if (prev_frame == frames_.begin())
414 return false;
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100415 --prev_frame;
416 --id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200417 if (!prev_frame->second.frame ||
418 prev_frame->first.picture_id != id.picture_id ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100419 prev_frame->first.spatial_layer != id.spatial_layer) {
420 return false;
421 }
422 }
423 }
424
425 if (!frame.is_last_spatial_layer) {
426 // Check that all following spatial layers are already inserted.
427 VideoLayerFrameId id = frame.id;
428 ++id.spatial_layer;
429 FrameMap::iterator next_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200430 if (next_frame == frames_.end() || !next_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100431 return false;
432 while (!next_frame->second.frame->is_last_spatial_layer) {
433 ++next_frame;
434 ++id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200435 if (next_frame == frames_.end() || !next_frame->second.frame ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100436 next_frame->first.picture_id != id.picture_id ||
437 next_frame->first.spatial_layer != id.spatial_layer) {
438 return false;
439 }
440 }
441 }
442
443 return true;
444}
445
philipele7c891f2018-02-22 14:35:06 +0100446int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800447 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200448 RTC_DCHECK(frame);
tommi0a735642017-03-14 06:23:57 -0700449
450 rtc::CritScope lock(&crit_);
philipel29f730e2017-03-15 08:10:08 -0700451
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100452 if (stats_callback_ && IsCompleteSuperFrame(*frame)) {
453 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
454 frame->contentType());
455 }
456 const VideoLayerFrameId& id = frame->id;
457
philipel1610f942017-12-12 13:58:31 +0100458 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100459 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200460
philipel112adf92017-06-15 09:06:21 -0700461 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100462 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100463 << id.picture_id << ":"
464 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100465 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700466 return last_continuous_picture_id;
467 }
468
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100469 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100470 if (frame->is_keyframe()) {
471 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100472 << id.picture_id << ":"
473 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100474 << ") but buffer is full, clearing"
475 << " buffer and inserting the frame.";
476 ClearFramesAndHistory();
477 } else {
478 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100479 << id.picture_id << ":"
480 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100481 << ") could not be inserted due to the frame "
482 << "buffer being full, dropping frame.";
483 return last_continuous_picture_id;
484 }
philipele0b2f152016-09-28 10:23:49 +0200485 }
486
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100487 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
488 auto last_decoded_frame_timestamp =
489 decoded_frames_history_.GetLastDecodedFrameTimestamp();
490 if (last_decoded_frame && id <= *last_decoded_frame) {
491 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700492 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800493 // If this frame has a newer timestamp but an earlier picture id then we
494 // assume there has been a jump in the picture id due to some encoder
495 // reconfiguration or some other reason. Even though this is not according
496 // to spec we can still continue to decode from this frame if it is a
497 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100498 RTC_LOG(LS_WARNING)
499 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800500 ClearFramesAndHistory();
501 last_continuous_picture_id = -1;
502 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100503 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100504 << id.picture_id << ":"
505 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100506 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100507 << last_decoded_frame->picture_id << ":"
508 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100509 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800510 return last_continuous_picture_id;
511 }
philipele0b2f152016-09-28 10:23:49 +0200512 }
513
philipel146a48b2017-04-20 04:04:38 -0700514 // Test if inserting this frame would cause the order of the frames to become
515 // ambiguous (covering more than half the interval of 2^16). This can happen
516 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100517 if (!frames_.empty() && id < frames_.begin()->first &&
518 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100519 RTC_LOG(LS_WARNING)
520 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700521 ClearFramesAndHistory();
522 last_continuous_picture_id = -1;
523 }
524
philipel0fa82a62018-03-19 15:34:53 +0100525 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200526
philipel93e451b2016-10-06 12:25:13 +0200527 if (info->second.frame) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100528 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100529 << id.picture_id << ":"
530 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100531 << ") already inserted, dropping frame.";
philipele0b2f152016-09-28 10:23:49 +0200532 return last_continuous_picture_id;
533 }
534
philipel93e451b2016-10-06 12:25:13 +0200535 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
536 return last_continuous_picture_id;
Ruslan Burakov493a6502019-02-27 15:32:48 +0100537
538 if (!frame->delayed_by_retransmission())
539 timing_->IncomingTimestamp(frame->Timestamp(), frame->ReceivedTime());
philipel0a9f6de2018-02-28 11:29:47 +0100540
philipele0b2f152016-09-28 10:23:49 +0200541 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200542
543 if (info->second.num_missing_continuous == 0) {
544 info->second.continuous = true;
545 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100546 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200547
548 // Since we now have new continuous frames there might be a better frame
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200549 // to return from NextFrame.
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000550 new_continuous_frame_event_.Set();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200551
552 if (callback_queue_) {
553 callback_queue_->PostTask([this] {
554 rtc::CritScope lock(&crit_);
555 if (!callback_task_.Running())
556 return;
557 RTC_CHECK(frame_handler_);
558 callback_task_.Stop();
559 StartWaitForNextFrameOnQueue();
560 });
561 }
philipele0b2f152016-09-28 10:23:49 +0200562 }
563
564 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200565}
566
philipele0b2f152016-09-28 10:23:49 +0200567void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800568 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200569 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200570
571 std::queue<FrameMap::iterator> continuous_frames;
572 continuous_frames.push(start);
573
574 // A simple BFS to traverse continuous frames.
575 while (!continuous_frames.empty()) {
576 auto frame = continuous_frames.front();
577 continuous_frames.pop();
578
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100579 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
580 last_continuous_frame_ = frame->first;
581 }
philipele0b2f152016-09-28 10:23:49 +0200582
583 // Loop through all dependent frames, and if that frame no longer has
584 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100585 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200586 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700587 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200588
philipel112adf92017-06-15 09:06:21 -0700589 // TODO(philipel): Look into why we've seen this happen.
590 if (frame_ref != frames_.end()) {
591 --frame_ref->second.num_missing_continuous;
592 if (frame_ref->second.num_missing_continuous == 0) {
593 frame_ref->second.continuous = true;
594 continuous_frames.push(frame_ref);
595 }
philipele0b2f152016-09-28 10:23:49 +0200596 }
597 }
598 }
599}
600
601void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800602 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100603 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200604 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200605 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700606 // TODO(philipel): Look into why we've seen this happen.
607 if (ref_info != frames_.end()) {
608 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
609 --ref_info->second.num_missing_decodable;
610 }
philipele0b2f152016-09-28 10:23:49 +0200611 }
612}
613
philipele7c891f2018-02-22 14:35:06 +0100614bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200615 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800616 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100617 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200618
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100619 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
620 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200621
philipel798b2822018-06-11 13:10:14 +0200622 // In this function we determine how many missing dependencies this |frame|
623 // has to become continuous/decodable. If a frame that this |frame| depend
624 // on has already been decoded then we can ignore that dependency since it has
625 // already been fulfilled.
626 //
627 // For all other frames we will register a backwards reference to this |frame|
628 // so that |num_missing_continuous| and |num_missing_decodable| can be
629 // decremented as frames become continuous/are decoded.
630 struct Dependency {
631 VideoLayerFrameId id;
632 bool continuous;
633 };
634 std::vector<Dependency> not_yet_fulfilled_dependencies;
635
636 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200637 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100638 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200639 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100640 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200641 // Was that frame decoded? If not, this |frame| will never become
642 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100643 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700644 int64_t now_ms = clock_->TimeInMilliseconds();
645 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100646 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100647 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
648 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700649 << ") depends on a non-decoded frame more previous than"
650 << " the last decoded frame, dropping frame.";
651 last_log_non_decoded_ms_ = now_ms;
652 }
philipele0b2f152016-09-28 10:23:49 +0200653 return false;
654 }
philipele0b2f152016-09-28 10:23:49 +0200655 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100656 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200657 bool ref_continuous =
658 ref_info != frames_.end() && ref_info->second.continuous;
659 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200660 }
philipelbe7a9e52016-05-19 12:19:35 +0200661 }
662
philipel798b2822018-06-11 13:10:14 +0200663 // Does |frame| depend on the lower spatial layer?
philipelbe7a9e52016-05-19 12:19:35 +0200664 if (frame.inter_layer_predicted) {
philipel0fa82a62018-03-19 15:34:53 +0100665 VideoLayerFrameId ref_key(frame.id.picture_id, frame.id.spatial_layer - 1);
philipel798b2822018-06-11 13:10:14 +0200666 auto ref_info = frames_.find(ref_key);
philipele0b2f152016-09-28 10:23:49 +0200667
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100668 bool lower_layer_decoded =
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100669 last_decoded_frame && *last_decoded_frame == ref_key;
philipel798b2822018-06-11 13:10:14 +0200670 bool lower_layer_continuous =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100671 lower_layer_decoded ||
672 (ref_info != frames_.end() && ref_info->second.continuous);
philipel798b2822018-06-11 13:10:14 +0200673
674 if (!lower_layer_continuous || !lower_layer_decoded) {
675 not_yet_fulfilled_dependencies.push_back(
676 {ref_key, lower_layer_continuous});
philipele0b2f152016-09-28 10:23:49 +0200677 }
philipelbe7a9e52016-05-19 12:19:35 +0200678 }
679
philipel798b2822018-06-11 13:10:14 +0200680 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
681 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
682
683 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
684 if (dep.continuous)
685 --info->second.num_missing_continuous;
686
Elad Alon69321dd2019-01-10 15:02:54 +0100687 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200688 }
philipel93e451b2016-10-06 12:25:13 +0200689
philipelbe7a9e52016-05-19 12:19:35 +0200690 return true;
691}
692
philipelbe742702016-11-30 01:31:40 -0800693void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800694 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800695 if (!stats_callback_)
696 return;
philipelbe742702016-11-30 01:31:40 -0800697
philipela45102f2017-02-22 05:30:39 -0800698 int decode_ms;
699 int max_decode_ms;
700 int current_delay_ms;
701 int target_delay_ms;
702 int jitter_buffer_ms;
703 int min_playout_delay_ms;
704 int render_delay_ms;
705 if (timing_->GetTimings(&decode_ms, &max_decode_ms, &current_delay_ms,
706 &target_delay_ms, &jitter_buffer_ms,
707 &min_playout_delay_ms, &render_delay_ms)) {
708 stats_callback_->OnFrameBufferTimingsUpdated(
709 decode_ms, max_decode_ms, current_delay_ms, target_delay_ms,
710 jitter_buffer_ms, min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800711 }
philipel266f0a42016-11-28 08:49:07 -0800712}
713
ilnik2edc6842017-07-06 03:06:50 -0700714void FrameBuffer::UpdateTimingFrameInfo() {
715 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200716 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100717 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700718 stats_callback_->OnTimingFrameInfoUpdated(*info);
719}
720
philipelfcc60062017-01-18 05:35:20 -0800721void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700722 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
philipelfcc60062017-01-18 05:35:20 -0800723 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100724 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100725 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100726 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800727}
728
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100729EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
730 const std::vector<EncodedFrame*>& frames) const {
731 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100732 EncodedFrame* first_frame = frames[0];
733 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100734 size_t total_length = 0;
735 for (size_t i = 0; i < frames.size(); ++i) {
736 total_length += frames[i]->size();
737 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100738 first_frame->VerifyAndAllocate(total_length);
739
740 // Spatial index of combined frame is set equal to spatial index of its top
741 // spatial layer.
742 first_frame->SetSpatialIndex(last_frame->id.spatial_layer);
743 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
744
745 first_frame->video_timing_mutable()->network2_timestamp_ms =
746 last_frame->video_timing().network2_timestamp_ms;
747 first_frame->video_timing_mutable()->receive_finish_ms =
748 last_frame->video_timing().receive_finish_ms;
749
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100750 // Append all remaining frames to the first one.
Niels Möller9c843902019-01-11 10:21:35 +0100751 uint8_t* buffer = first_frame->data() + first_frame->size();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100752 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100753 EncodedFrame* next_frame = frames[i];
Niels Möller9c843902019-01-11 10:21:35 +0100754 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100755 buffer += next_frame->size();
756 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100757 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100758 first_frame->set_size(total_length);
759 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100760}
761
Niels Möllerbe682d42018-03-27 08:31:45 +0200762FrameBuffer::FrameInfo::FrameInfo() = default;
763FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
764FrameBuffer::FrameInfo::~FrameInfo() = default;
765
philipelbe7a9e52016-05-19 12:19:35 +0200766} // namespace video_coding
767} // namespace webrtc