blob: 3192866a9333a66ac8d25f1b25e867ce6270e5a5 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020041#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020042#include "rtc_base/arraysize.h"
43#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020044#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/stringutils.h"
46#include "test/field_trial.h"
47#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000048
Tommi85959932018-02-07 19:26:06 +010049using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010050using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070051using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010052using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070053
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000054namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000055static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000056
noahricd10a68e2015-07-10 11:27:55 -070057static const uint8_t kRedRtxPayloadType = 125;
58
Niels Möller6557d0c2018-04-11 15:18:34 +020059static const uint32_t kTimeout = 5000U;
60static const uint32_t kDefaultReceiveSsrc = 0;
61static const uint32_t kSsrc = 1234u;
62static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
63static const int kVideoWidth = 640;
64static const int kVideoHeight = 360;
65static const int kFramerate = 30;
66
Peter Boström0c4e06b2015-10-07 12:23:21 +020067static const uint32_t kSsrcs1[] = {1};
68static const uint32_t kSsrcs3[] = {1, 2, 3};
69static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080070static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080072static const uint32_t kDefaultRecvSsrc = 0;
73
pbos@webrtc.org3c107582014-07-20 15:27:35 +000074static const char kUnsupportedExtensionName[] =
75 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000076
magjed509e4fe2016-11-18 01:34:11 -080077cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
78 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020079 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080080}
81
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000082void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
83 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
84 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
85 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
86 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080090 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
93}
94
magjed725e4842016-11-16 00:48:13 -080095// Return true if any codec in |codecs| is an RTX codec with associated payload
96// type |payload_type|.
97bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
98 int payload_type) {
99 for (const cricket::VideoCodec& codec : codecs) {
100 int associated_payload_type;
101 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
102 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
103 &associated_payload_type) &&
104 associated_payload_type == payload_type) {
105 return true;
106 }
107 }
108 return false;
109}
110
nisseca5706d2017-09-11 02:32:16 -0700111// TODO(nisse): Duplicated in call.cc.
112const int* FindKeyByValue(const std::map<int, int>& m, int v) {
113 for (const auto& kv : m) {
114 if (kv.second == v)
115 return &kv.first;
116 }
117 return nullptr;
118}
119
Yves Gerey665174f2018-06-19 15:03:05 +0200120bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
121 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700122 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
123 payload_type) != nullptr;
124}
125
126// Check that there's an Rtx payload type for each decoder.
127bool VerifyRtxReceiveAssociations(
128 const webrtc::VideoReceiveStream::Config& config) {
129 for (const auto& decoder : config.decoders) {
130 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
131 return false;
132 }
133 return true;
134}
135
brandtrffc61182016-11-28 06:02:22 -0800136rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700137 int width,
138 int height) {
139 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
140 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800141 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700142 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000143}
144
Shao Changbine62202f2015-04-21 20:24:50 +0800145void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
146 const std::map<int, int>& rtx_types) {
147 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200148 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800149 EXPECT_TRUE(it != rtx_types.end() &&
150 it->second == config.rtp.rtx.payload_type);
151
brandtrb5f2c3f2016-10-04 23:28:39 -0700152 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
153 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800154 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 }
157}
kthelgason2bc68642017-02-07 07:02:22 -0800158
159cricket::MediaConfig GetMediaConfig() {
160 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100161 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800162 return media_config;
163}
nisse26e3abb2017-08-25 04:44:25 -0700164
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200165// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
166int GetMaxDefaultBitrateBps(size_t width, size_t height) {
167 if (width * height <= 320 * 240) {
168 return 600000;
169 } else if (width * height <= 640 * 480) {
170 return 1700000;
171 } else if (width * height <= 960 * 540) {
172 return 2000000;
173 } else {
174 return 2500000;
175 }
176}
177
Niels Möller731a2c22018-07-30 15:08:07 +0200178class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
179 public:
180 MOCK_METHOD2(AddOrUpdateSink,
181 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
182 const rtc::VideoSinkWants& wants));
183 MOCK_METHOD1(RemoveSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
185};
186
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000187} // namespace
188
Yves Gerey665174f2018-06-19 15:03:05 +0200189#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200190 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200191 EXPECT_EQ((w), renderer_.width()); \
192 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ(0, renderer_.errors());
194
Yves Gerey665174f2018-06-19 15:03:05 +0200195#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200197 EXPECT_EQ((w), (r).width()); \
198 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ(0, (r).errors());
200
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000201namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700202class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000203 public:
eladalonf1841382017-06-12 01:16:46 -0700204 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
205 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700206 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700207 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200208 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
209 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200210 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200212 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200213 decoder_factory_)) {}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000214
215 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200216 void AssignDefaultAptRtxTypes();
217 void AssignDefaultCodec();
218
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100219 // Find the index of the codec in the engine with the given name. The codec
220 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100221 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100222
magjed509e4fe2016-11-18 01:34:11 -0800223 // Find the codec in the engine with the given name. The codec must be
224 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100225 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800226
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200227 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000228
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200229 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000230 const std::vector<VideoCodec>& codecs);
231
Peter Boströme4499152016-02-05 11:13:28 +0100232 void TestExtendedEncoderOveruse(bool use_external_encoder);
233
stefanc1aeaf02015-10-15 07:26:07 -0700234 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700235 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700236 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000237 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800238 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
240 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700241 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000242 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800243 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000244};
245
eladalonf1841382017-06-12 01:16:46 -0700246TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200247 encoder_factory_->AddSupportedVideoCodecType("VP8");
248 AssignDefaultCodec();
249
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000250 std::vector<VideoCodec> engine_codecs = engine_.codecs();
251 for (size_t i = 0; i < engine_codecs.size(); ++i) {
252 if (engine_codecs[i].name != kRtxCodecName)
253 continue;
254 int associated_payload_type;
255 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000256 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000257 EXPECT_EQ(default_codec_.id, associated_payload_type);
258 return;
259 }
260 FAIL() << "No RTX codec found among default codecs.";
261}
262
eladalonf1841382017-06-12 01:16:46 -0700263TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100264 RtpCapabilities capabilities = engine_.GetCapabilities();
265 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700266 for (const RtpExtension& extension : capabilities.header_extensions) {
267 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
268 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000269 return;
270 }
271 }
272 FAIL() << "Timestamp offset extension not in header-extension list.";
273}
274
eladalonf1841382017-06-12 01:16:46 -0700275TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100276 RtpCapabilities capabilities = engine_.GetCapabilities();
277 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700278 for (const RtpExtension& extension : capabilities.header_extensions) {
279 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
280 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000281 return;
282 }
283 }
284 FAIL() << "Absolute Sender Time extension not in header-extension list.";
285}
286
eladalonf1841382017-06-12 01:16:46 -0700287TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100288 RtpCapabilities capabilities = engine_.GetCapabilities();
289 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700290 for (const RtpExtension& extension : capabilities.header_extensions) {
291 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
292 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700293 return;
294 }
295 }
296 FAIL() << "Transport sequence number extension not in header-extension list.";
297}
298
eladalonf1841382017-06-12 01:16:46 -0700299TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100300 RtpCapabilities capabilities = engine_.GetCapabilities();
301 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700302 for (const RtpExtension& extension : capabilities.header_extensions) {
303 if (extension.uri == RtpExtension::kVideoRotationUri) {
304 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700305 return;
306 }
307 }
308 FAIL() << "Video Rotation extension not in header-extension list.";
309}
310
eladalonf1841382017-06-12 01:16:46 -0700311TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200312 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700313 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200314 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200316 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700317
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200318 std::unique_ptr<VideoMediaChannel> channel(
319 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700320 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
321
322 // Add CVO extension.
323 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800324 cricket::VideoSendParameters parameters;
325 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200326 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700327 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200328 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700329
Niels Möller731a2c22018-07-30 15:08:07 +0200330 EXPECT_CALL(
331 video_source,
332 AddOrUpdateSink(testing::_,
333 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700334 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200335 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700336
337 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200338 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700339
340 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200341 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200342 EXPECT_CALL(
343 video_source,
344 AddOrUpdateSink(testing::_,
345 Field(&rtc::VideoSinkWants::rotation_applied, true)));
346
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200347 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
eladalonf1841382017-06-12 01:16:46 -0700350TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200351 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800352 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200353 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800354
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200355 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800356
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200357 std::unique_ptr<VideoMediaChannel> channel(
358 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800359 // Add CVO extension.
360 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800361 cricket::VideoSendParameters parameters;
362 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800363 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700364 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800365 EXPECT_TRUE(channel->SetSendParameters(parameters));
366 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
367
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Set source.
369 EXPECT_CALL(
370 video_source,
371 AddOrUpdateSink(testing::_,
372 Field(&rtc::VideoSinkWants::rotation_applied, false)));
373 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800374}
375
eladalonf1841382017-06-12 01:16:46 -0700376TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200377 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200379 encoder_factory_->AddSupportedVideoCodecType("VP8");
380 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700381
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200382 std::unique_ptr<VideoMediaChannel> channel(
383 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700384 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
385
386 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200387 EXPECT_CALL(
388 video_source,
389 AddOrUpdateSink(testing::_,
390 Field(&rtc::VideoSinkWants::rotation_applied, true)));
391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
perkjcaafdba2016-03-20 07:34:29 -0700393 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200394 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700395
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700396 // Add CVO extension.
397 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800398 cricket::VideoSendParameters parameters;
399 parameters.codecs.push_back(GetEngineCodec("VP8"));
400 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700402 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700403 // Also remove the first codec to trigger a codec change as well.
404 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200405 EXPECT_CALL(
406 video_source,
407 AddOrUpdateSink(testing::_,
408 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200409 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410
411 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200412 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700413
414 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200415 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200416 EXPECT_CALL(
417 video_source,
418 AddOrUpdateSink(testing::_,
419 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200420 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421}
422
eladalonf1841382017-06-12 01:16:46 -0700423TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200424 encoder_factory_->AddSupportedVideoCodecType("VP8");
425
kwiberg686a8ef2016-02-26 03:00:35 -0800426 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800427 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000428
429 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
430
431 EXPECT_FALSE(channel->SetSend(true))
432 << "Channel should not start without codecs.";
433 EXPECT_TRUE(channel->SetSend(false))
434 << "Channel should be stoppable even without set codecs.";
435}
436
eladalonf1841382017-06-12 01:16:46 -0700437TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 encoder_factory_->AddSupportedVideoCodecType("VP8");
439
kwiberg686a8ef2016-02-26 03:00:35 -0800440 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800441 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000442 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
443 VideoMediaInfo info;
444 channel->GetStats(&info);
445}
446
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200447TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200448 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000449
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200450 std::unique_ptr<VideoMediaChannel> channel(
451 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800452 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000453
454 EXPECT_TRUE(
455 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200456 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000457 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100458 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200459 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000460 EXPECT_EQ(cricket::CS_RUNNING,
461 capturer.Start(capturer.GetSupportedFormats()->front()));
462 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100463 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200464 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
465 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000466 kTimeout);
467
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200468 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100469 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000470
471 // Setting codecs of the same type should not reallocate any encoders
472 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800473 cricket::VideoSendParameters parameters;
474 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200475 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200476 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000477
478 // Remove stream previously added to free the external encoder instance.
479 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200480 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000481}
482
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200483// Test that when an encoder factory supports H264, we add an RTX
484// codec for it.
485// TODO(deadbeef): This test should be updated if/when we start
486// adding RTX codecs for unrecognized codec names.
487TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800488 using webrtc::H264::ProfileLevelIdToString;
489 using webrtc::H264::ProfileLevelId;
490 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200491 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
492 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800493 *ProfileLevelIdToString(
494 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200495 webrtc::SdpVideoFormat h264_constrained_high("H264");
496 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800497 *ProfileLevelIdToString(
498 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200499 webrtc::SdpVideoFormat h264_high("H264");
500 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800501 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
502
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200503 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
504 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
505 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700506
magjed725e4842016-11-16 00:48:13 -0800507 // First figure out what payload types the test codecs got assigned.
508 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800509 // Now search for RTX codecs for them. Expect that they all have associated
510 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800511 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200512 codecs,
513 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
514 ->id));
magjed725e4842016-11-16 00:48:13 -0800515 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200516 codecs,
517 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
518 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800519 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200520 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700521}
522
Peter Boström12996152016-05-14 02:03:18 +0200523#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700524TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200525 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100526
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200527 std::unique_ptr<VideoMediaChannel> channel(
528 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100529
530 EXPECT_TRUE(
531 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
532}
Peter Boström12996152016-05-14 02:03:18 +0200533#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100534
eladalonf1841382017-06-12 01:16:46 -0700535TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200536 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100537 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200538 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200539 std::unique_ptr<VideoMediaChannel> channel(
540 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700541
542 EXPECT_TRUE(
543 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
544
Tommi85959932018-02-07 19:26:06 +0100545 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200546 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700547 capturer.Start(cricket::VideoFormat(1280, 720,
548 cricket::VideoFormat::FpsToInterval(60),
549 cricket::FOURCC_I420));
550 channel->SetSend(true);
551
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200552 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700553
554 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700555 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700556 for (int i = 0; i < 10; i++) {
557 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700558 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700559 int64_t interval = timestamp - last_timestamp;
560
561 // Precision changes from nanosecond to millisecond.
562 // Allow error to be no more than 1.
563 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
564
565 last_timestamp = timestamp;
566 }
567
568 capturer.Start(cricket::VideoFormat(1280, 720,
569 cricket::VideoFormat::FpsToInterval(30),
570 cricket::FOURCC_I420));
571
572 EXPECT_TRUE(capturer.CaptureFrame());
573 last_timestamp = stream->GetLastTimestamp();
574 for (int i = 0; i < 10; i++) {
575 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700576 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700577 int64_t interval = timestamp - last_timestamp;
578
579 // Precision changes from nanosecond to millisecond.
580 // Allow error to be no more than 1.
581 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
582
583 last_timestamp = timestamp;
584 }
585
586 // Remove stream previously added to free the external encoder instance.
587 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
588}
589
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200590void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
591 std::vector<VideoCodec> engine_codecs = engine_.codecs();
592 RTC_DCHECK(!engine_codecs.empty());
593 for (const cricket::VideoCodec& codec : engine_codecs) {
594 if (codec.name == "rtx") {
595 int associated_payload_type;
596 if (codec.GetParam(kCodecParamAssociatedPayloadType,
597 &associated_payload_type)) {
598 default_apt_rtx_types_[associated_payload_type] = codec.id;
599 }
600 }
601 }
602}
603
604void WebRtcVideoEngineTest::AssignDefaultCodec() {
605 std::vector<VideoCodec> engine_codecs = engine_.codecs();
606 RTC_DCHECK(!engine_codecs.empty());
607 bool codec_set = false;
608 for (const cricket::VideoCodec& codec : engine_codecs) {
609 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
610 codec.name != "ulpfec") {
611 default_codec_ = codec;
612 codec_set = true;
613 }
614 }
615
616 RTC_DCHECK(codec_set);
617}
618
Oleh Prypina40f8242017-12-21 13:32:23 +0100619size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
620 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100621 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
622 for (size_t i = 0; i < codecs.size(); ++i) {
623 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200624 if (!CodecNamesEq(name, engine_codec.name))
625 continue;
626 // The tests only use H264 Constrained Baseline. Make sure we don't return
627 // an internal H264 codec from the engine with a different H264 profile.
628 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200629 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200630 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
631 if (profile_level_id->profile !=
632 webrtc::H264::kProfileConstrainedBaseline) {
633 continue;
634 }
635 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100636 return i;
magjed509e4fe2016-11-18 01:34:11 -0800637 }
638 // This point should never be reached.
639 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100640 return -1;
641}
642
643cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
644 const std::string& name) const {
645 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800646}
647
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200648VideoMediaChannel*
649WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000650 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800651 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200652 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800653 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200654 for (const webrtc::SdpVideoFormat& format :
655 encoder_factory_->GetSupportedFormats()) {
656 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
657 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
658 engine_codec) == parameters.codecs.end()) {
659 parameters.codecs.push_back(engine_codec);
660 }
661 }
magjed509e4fe2016-11-18 01:34:11 -0800662
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200663 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000664
665 return channel;
666}
667
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200668VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000669 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000670 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800671 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200672 cricket::VideoRecvParameters parameters;
673 parameters.codecs = codecs;
674 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000675
676 return channel;
677}
678
eladalonf1841382017-06-12 01:16:46 -0700679TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200680 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000681
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200682 std::unique_ptr<VideoMediaChannel> channel(
683 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000684
Peter Boström0c4e06b2015-10-07 12:23:21 +0200685 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000686
Yves Gerey665174f2018-06-19 15:03:05 +0200687 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000688 EXPECT_TRUE(channel->SetSend(true));
689
Tommi85959932018-02-07 19:26:06 +0100690 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200691 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000692 EXPECT_EQ(cricket::CS_RUNNING,
693 capturer.Start(capturer.GetSupportedFormats()->front()));
694 EXPECT_TRUE(capturer.CaptureFrame());
695
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200696 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000697
698 // Verify that encoders are configured for simulcast through adapter
699 // (increasing resolution and only configured to send one stream each).
700 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200701 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
702 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000703 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200704 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000705 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
706 EXPECT_GT(codec_settings.width, prev_width);
707 prev_width = codec_settings.width;
708 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000709
Niels Möllerff40b142018-04-09 08:49:14 +0200710 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000711
712 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200713 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714}
715
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200716TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
717 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200718 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000719
Niels Möller4db138e2018-04-19 09:04:13 +0200720 // Set capturer.
721 FakeVideoCapturerWithTaskQueue capturer;
722 EXPECT_EQ(cricket::CS_RUNNING,
723 capturer.Start(capturer.GetSupportedFormats()->front()));
724
Anders Carlsson67537952018-05-03 11:28:29 +0200725 std::unique_ptr<VideoMediaChannel> channel(
726 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
727 cricket::VideoSendParameters parameters;
728 parameters.codecs.push_back(GetEngineCodec("H264"));
729 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000730
731 EXPECT_TRUE(
732 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200733 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
734 // Sending one frame will have allocate the encoder.
735 EXPECT_TRUE(capturer.CaptureFrame());
736
737 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000738
Anders Carlsson67537952018-05-03 11:28:29 +0200739 cricket::VideoSendParameters new_parameters;
740 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
741 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200742
743 // Sending one frame will switch encoder.
744 EXPECT_TRUE(capturer.CaptureFrame());
745
Anders Carlsson8a150d92018-05-14 12:40:04 +0200746 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000747}
748
eladalonf1841382017-06-12 01:16:46 -0700749TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000750 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
752 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000753
kwiberg686a8ef2016-02-26 03:00:35 -0800754 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800755 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800756 cricket::VideoSendParameters parameters;
757 parameters.codecs.push_back(GetEngineCodec("VP8"));
758 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000759
Peter Boström0c4e06b2015-10-07 12:23:21 +0200760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000761
Yves Gerey665174f2018-06-19 15:03:05 +0200762 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000763 EXPECT_TRUE(channel->SetSend(true));
764
765 // Send a fake frame, or else the media engine will configure the simulcast
766 // encoder adapter at a low-enough size that it'll only create a single
767 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100768 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200769 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000770 EXPECT_EQ(cricket::CS_RUNNING,
771 capturer.Start(capturer.GetSupportedFormats()->front()));
772 EXPECT_TRUE(capturer.CaptureFrame());
773
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200774 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
775 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000778
779 channel.reset();
780 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782}
783
eladalonf1841382017-06-12 01:16:46 -0700784TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200786 encoder_factory_->AddSupportedVideoCodecType("VP8");
787 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
kwiberg686a8ef2016-02-26 03:00:35 -0800789 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800790 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800791 cricket::VideoSendParameters parameters;
792 parameters.codecs.push_back(GetEngineCodec("H264"));
793 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000794
795 EXPECT_TRUE(
796 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100797
798 // Send a frame of 720p. This should trigger a "real" encoder initialization.
799 cricket::VideoFormat format(
800 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100801 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200802 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100803 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
804 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200805 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
806 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200809 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810
811 channel.reset();
812 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200813 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000814}
815
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200816TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
817 webrtc::test::ScopedFieldTrials override_field_trials_(
818 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200819 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700820
Anders Carlsson67537952018-05-03 11:28:29 +0200821 std::unique_ptr<VideoMediaChannel> channel(
822 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
823 cricket::VideoSendParameters parameters;
824 parameters.codecs.push_back(GetEngineCodec("H264"));
825 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700826
Peter Boström0c4e06b2015-10-07 12:23:21 +0200827 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700828 EXPECT_TRUE(
829 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100830
831 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700832 cricket::VideoFormat format(
833 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100834 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200835 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100836 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
837 EXPECT_TRUE(capturer.CaptureFrame());
838
Niels Möller4db138e2018-04-19 09:04:13 +0200839 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200840 ASSERT_EQ(1u, encoder_factory_->encoders().size());
841 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
842 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700843 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200844 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200845 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700846}
847
brandtrffc61182016-11-28 06:02:22 -0800848// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700849// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800850//
851// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700852TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800853 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200854 encoder_factory_->AddSupportedVideoCodecType("VP8");
855
brandtrffc61182016-11-28 06:02:22 -0800856 auto is_flexfec = [](const VideoCodec& codec) {
857 if (codec.name == "flexfec-03")
858 return true;
859 return false;
860 };
861
862 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800863 const std::vector<VideoCodec> codecs_before = engine_.codecs();
864 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
865 codecs_before.end(), is_flexfec));
866
867 // FlexFEC is active with field trial.
868 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800869 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800870 const std::vector<VideoCodec> codecs_after = engine_.codecs();
871 EXPECT_NE(codecs_after.end(),
872 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
873}
874
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200875// Test that codecs are added in the order they are reported from the factory.
876TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
877 encoder_factory_->AddSupportedVideoCodecType("VP8");
878 const char* kFakeCodecName = "FakeCodec";
879 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000880
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200881 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100882 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
884 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000885}
886
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200887// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800888// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200889TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100890 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
891 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100892
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100893 // Set up external encoder factory with first codec, and initialize engine.
894 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
895
brandtrffc61182016-11-28 06:02:22 -0800896 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800897
898 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100899 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800900 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200901 // The codec itself and RTX should have been added.
902 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100903
904 // Check that both fake codecs are present and that the second fake codec
905 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100906 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
907 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100908 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800909}
910
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200911TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
912 const char* kFakeCodecName = "FakeCodec";
913 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
914
915 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
916 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
917}
918
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
920 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200921 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200922 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800923 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000924
kwiberg686a8ef2016-02-26 03:00:35 -0800925 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200926 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000927
928 EXPECT_TRUE(
929 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200930 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000931
932 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200933 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200934 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000935
936 // Remove stream previously added to free the external decoder instance.
937 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200938 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000939}
940
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200941// Verifies that we can set up decoders.
942TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000943 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
944 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
945 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
946 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200947 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200948 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000949 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800950 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000951
kwiberg686a8ef2016-02-26 03:00:35 -0800952 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200953 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000954
955 EXPECT_TRUE(
956 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200957 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000958}
959
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200960TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
961 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
962 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
963 WebRtcVideoEngine engine(std::move(encoder_factory),
964 std::move(decoder_factory));
965 EXPECT_EQ(0u, engine.codecs().size());
966}
967
968TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
969 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700970 webrtc::MockVideoEncoderFactory* encoder_factory =
971 new webrtc::MockVideoEncoderFactory();
972 webrtc::MockVideoDecoderFactory* decoder_factory =
973 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200974 WebRtcVideoEngine engine(
975 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
976 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
977 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
978 EXPECT_EQ(0u, engine.codecs().size());
979 EXPECT_CALL(*encoder_factory, Die());
980 EXPECT_CALL(*decoder_factory, Die());
981}
982
983// Test full behavior in the video engine when video codec factories of the new
984// type are injected supporting the single codec Vp8. Check the returned codecs
985// from the engine and that we will create a Vp8 encoder and decoder using the
986// new factories.
987TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
988 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700989 webrtc::MockVideoEncoderFactory* encoder_factory =
990 new webrtc::MockVideoEncoderFactory();
991 webrtc::MockVideoDecoderFactory* decoder_factory =
992 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200993 WebRtcVideoEngine engine(
994 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
995 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
996 const webrtc::SdpVideoFormat vp8_format("VP8");
997 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
998 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
999 .WillRepeatedly(testing::Return(supported_formats));
1000
1001 // Verify the codecs from the engine.
1002 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001003 // Verify default codecs has been added correctly.
1004 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001005 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001006
1007 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001009 int vp8_associated_payload;
1010 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1011 &vp8_associated_payload));
1012 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1013
1014 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1015
1016 // RTX codec for RED.
1017 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1018 int red_associated_payload;
1019 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1020 &red_associated_payload));
1021 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1022
1023 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1024
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001025 int associated_payload_type;
1026 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1027 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1028 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1029 // Verify default parameters has been added to the VP8 codec.
1030 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1031
1032 // Mock encoder creation. |engine| take ownership of the encoder.
1033 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1034 codec_info.is_hardware_accelerated = false;
1035 codec_info.has_internal_source = false;
1036 const webrtc::SdpVideoFormat format("VP8");
1037 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1038 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001039 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001040 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001042 .WillOnce(
1043 ::testing::DoAll(::testing::InvokeWithoutArgs(
1044 [&encoder_created]() { encoder_created.Set(); }),
1045 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001046
1047 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001048 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001049 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1050 .WillOnce(testing::Return(decoder));
1051
1052 // Create a call.
1053 webrtc::RtcEventLogNullImpl event_log;
1054 std::unique_ptr<webrtc::Call> call(
1055 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1056
1057 // Create send channel.
1058 const int send_ssrc = 123;
1059 std::unique_ptr<VideoMediaChannel> send_channel(
1060 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1061 cricket::VideoSendParameters send_parameters;
1062 send_parameters.codecs.push_back(engine_codecs.at(0));
1063 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1064 send_channel->OnReadyToSend(true);
1065 EXPECT_TRUE(
1066 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1067 EXPECT_TRUE(send_channel->SetSend(true));
1068
Niels Möller4db138e2018-04-19 09:04:13 +02001069 // Set capturer.
1070 FakeVideoCapturerWithTaskQueue capturer;
1071 EXPECT_EQ(cricket::CS_RUNNING,
1072 capturer.Start(capturer.GetSupportedFormats()->front()));
1073 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1074 // Sending one frame will allocate the encoder.
1075 EXPECT_TRUE(capturer.CaptureFrame());
1076 encoder_created.Wait(kTimeout);
1077
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001078 // Create recv channel.
1079 const int recv_ssrc = 321;
1080 std::unique_ptr<VideoMediaChannel> recv_channel(
1081 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1082 cricket::VideoRecvParameters recv_parameters;
1083 recv_parameters.codecs.push_back(engine_codecs.at(0));
1084 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1085 EXPECT_TRUE(recv_channel->AddRecvStream(
1086 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1087
1088 // Remove streams previously added to free the encoder and decoder instance.
1089 EXPECT_CALL(*encoder_factory, Die());
1090 EXPECT_CALL(*decoder_factory, Die());
1091 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1092 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1093}
1094
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001095// Test behavior when decoder factory fails to create a decoder (returns null).
1096TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1097 // |engine| take ownership of the factories.
1098 webrtc::MockVideoEncoderFactory* encoder_factory =
1099 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1100 webrtc::MockVideoDecoderFactory* decoder_factory =
1101 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1102 WebRtcVideoEngine engine(
1103 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1104 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1105 const webrtc::SdpVideoFormat vp8_format("VP8");
1106 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1107 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1108 .WillRepeatedly(testing::Return(supported_formats));
1109
1110 // Decoder creation fails.
1111 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1112 .WillOnce(testing::Return(nullptr));
1113
1114 // Create a call.
1115 webrtc::RtcEventLogNullImpl event_log;
1116 std::unique_ptr<webrtc::Call> call(
1117 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1118
1119 // Create recv channel.
1120 const int recv_ssrc = 321;
1121 std::unique_ptr<VideoMediaChannel> recv_channel(
1122 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1123 cricket::VideoRecvParameters recv_parameters;
1124 recv_parameters.codecs.push_back(engine.codecs().front());
1125 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1126 EXPECT_TRUE(recv_channel->AddRecvStream(
1127 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1128
1129 // Remove streams previously added to free the encoder and decoder instance.
1130 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1131}
1132
eladalonf1841382017-06-12 01:16:46 -07001133TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001134 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001135 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001136 std::unique_ptr<VideoMediaChannel> channel(
1137 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001138 ASSERT_TRUE(
1139 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1140 cricket::VideoCodec codec = GetEngineCodec("VP8");
1141 cricket::VideoSendParameters parameters;
1142 parameters.codecs.push_back(codec);
1143 channel->OnReadyToSend(true);
1144 channel->SetSend(true);
1145 ASSERT_TRUE(channel->SetSendParameters(parameters));
1146
Tommi85959932018-02-07 19:26:06 +01001147 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001148 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001149 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001150
1151 EXPECT_EQ(cricket::CS_RUNNING,
1152 capturer.Start(capturer.GetSupportedFormats()->front()));
1153 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001154 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001155 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001156 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001157
Niels Möllerff40b142018-04-09 08:49:14 +02001158 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001159 EXPECT_TRUE(capturer.CaptureFrame());
1160 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001161 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001162
1163 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001164 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001165 EXPECT_TRUE(capturer.CaptureFrame());
1166 // Change to screen content, recreate encoder. For the simulcast encoder
1167 // adapter case, this will result in two calls since InitEncode triggers a
1168 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001169 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001170 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001171 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001172
Niels Möllerff40b142018-04-09 08:49:14 +02001173 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001174 EXPECT_TRUE(capturer.CaptureFrame());
1175 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001176 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001177
1178 options.is_screencast.emplace(false);
1179 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001180 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001181 // Change back to regular video content, update encoder. Also change
1182 // a non |is_screencast| option just to verify it doesn't affect recreation.
1183 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001184 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001185 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001186 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001187
1188 // Remove stream previously added to free the external encoder instance.
1189 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001190 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001191}
1192
Niels Möller6557d0c2018-04-11 15:18:34 +02001193class WebRtcVideoChannelBaseTest : public testing::Test {
1194 protected:
1195 WebRtcVideoChannelBaseTest()
1196 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001197 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1198 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001199
1200 virtual void SetUp() {
1201 cricket::MediaConfig media_config;
1202 // Disabling cpu overuse detection actually disables quality scaling too; it
1203 // implies DegradationPreference kMaintainResolution. Automatic scaling
1204 // needs to be disabled, otherwise, tests which check the size of received
1205 // frames become flaky.
1206 media_config.video.enable_cpu_adaptation = false;
1207 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1208 cricket::VideoOptions()));
1209 channel_->OnReadyToSend(true);
1210 EXPECT_TRUE(channel_.get() != NULL);
1211 network_interface_.SetDestination(channel_.get());
1212 channel_->SetInterface(&network_interface_);
1213 cricket::VideoRecvParameters parameters;
1214 parameters.codecs = engine_.codecs();
1215 channel_->SetRecvParameters(parameters);
1216 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1217 video_capturer_.reset(CreateFakeVideoCapturer());
1218 cricket::VideoFormat format(640, 480,
1219 cricket::VideoFormat::FpsToInterval(kFramerate),
1220 cricket::FOURCC_I420);
1221 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001222 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001223 }
1224
1225 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1226 return new cricket::FakeVideoCapturerWithTaskQueue();
1227 }
1228
1229 // Utility method to setup an additional stream to send and receive video.
1230 // Used to test send and recv between two streams.
1231 void SetUpSecondStream() {
1232 SetUpSecondStreamWithNoRecv();
1233 // Setup recv for second stream.
1234 EXPECT_TRUE(channel_->AddRecvStream(
1235 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1236 // Make the second renderer available for use by a new stream.
1237 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1238 }
1239 // Setup an additional stream just to send video. Defer add recv stream.
1240 // This is required if you want to test unsignalled recv of video rtp packets.
1241 void SetUpSecondStreamWithNoRecv() {
1242 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001243 EXPECT_TRUE(
1244 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001245 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001246 EXPECT_FALSE(
1247 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001248 EXPECT_TRUE(channel_->AddSendStream(
1249 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1250 // We dont add recv for the second stream.
1251
1252 // Setup the receive and renderer for second stream after send.
1253 video_capturer_2_.reset(CreateFakeVideoCapturer());
1254 cricket::VideoFormat format(640, 480,
1255 cricket::VideoFormat::FpsToInterval(kFramerate),
1256 cricket::FOURCC_I420);
1257 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1258
Yves Gerey665174f2018-06-19 15:03:05 +02001259 EXPECT_TRUE(
1260 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001261 }
Yves Gerey665174f2018-06-19 15:03:05 +02001262 virtual void TearDown() { channel_.reset(); }
1263 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001264
1265 bool SetOneCodec(const cricket::VideoCodec& codec) {
1266 cricket::VideoFormat capture_format(
1267 kVideoWidth, kVideoHeight,
1268 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1269
1270 if (video_capturer_) {
1271 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1272 }
1273 if (video_capturer_2_) {
1274 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1275 }
1276
1277 bool sending = channel_->sending();
1278 bool success = SetSend(false);
1279 if (success) {
1280 cricket::VideoSendParameters parameters;
1281 parameters.codecs.push_back(codec);
1282 success = channel_->SetSendParameters(parameters);
1283 }
1284 if (success) {
1285 success = SetSend(sending);
1286 }
1287 return success;
1288 }
Yves Gerey665174f2018-06-19 15:03:05 +02001289 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001290 bool SendFrame() {
1291 if (video_capturer_2_) {
1292 video_capturer_2_->CaptureFrame();
1293 }
1294 return video_capturer_.get() && video_capturer_->CaptureFrame();
1295 }
1296 bool WaitAndSendFrame(int wait_ms) {
1297 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1298 ret &= SendFrame();
1299 return ret;
1300 }
Yves Gerey665174f2018-06-19 15:03:05 +02001301 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001302 int NumRtpBytes(uint32_t ssrc) {
1303 return network_interface_.NumRtpBytes(ssrc);
1304 }
Yves Gerey665174f2018-06-19 15:03:05 +02001305 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001306 int NumRtpPackets(uint32_t ssrc) {
1307 return network_interface_.NumRtpPackets(ssrc);
1308 }
Yves Gerey665174f2018-06-19 15:03:05 +02001309 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001310 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1311 return network_interface_.GetRtpPacket(index);
1312 }
1313 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001314 webrtc::RTPHeader header;
1315 EXPECT_TRUE(ParseRtpPacket(p, &header));
1316 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001317 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001318
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001320 webrtc::RTPHeader* header) {
1321 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1322 webrtc::RtpHeaderParser::Create());
1323 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001324 }
1325
1326 // Tests that we can send and receive frames.
1327 void SendAndReceive(const cricket::VideoCodec& codec) {
1328 EXPECT_TRUE(SetOneCodec(codec));
1329 EXPECT_TRUE(SetSend(true));
1330 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1331 EXPECT_EQ(0, renderer_.num_rendered_frames());
1332 EXPECT_TRUE(SendFrame());
1333 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1334 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1335 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1336 }
1337
1338 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001339 int duration_sec,
1340 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001341 EXPECT_TRUE(SetOneCodec(codec));
1342 EXPECT_TRUE(SetSend(true));
1343 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1344 EXPECT_EQ(0, renderer_.num_rendered_frames());
1345 for (int i = 0; i < duration_sec; ++i) {
1346 for (int frame = 1; frame <= fps; ++frame) {
1347 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1348 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1349 }
1350 }
1351 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1352 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1353 }
1354
Niels Möller6557d0c2018-04-11 15:18:34 +02001355 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1356 cricket::VideoMediaInfo info;
1357 EXPECT_TRUE(channel_->GetStats(&info));
1358 return info.senders[i];
1359 }
1360
1361 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1362 cricket::VideoMediaInfo info;
1363 EXPECT_TRUE(channel_->GetStats(&info));
1364 return info.receivers[i];
1365 }
1366
1367 // Two streams one channel tests.
1368
1369 // Tests that we can send and receive frames.
1370 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1371 SetUpSecondStream();
1372 // Test sending and receiving on first stream.
1373 SendAndReceive(codec);
1374 // Test sending and receiving on second stream.
1375 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1376 EXPECT_GT(NumRtpPackets(), 0);
1377 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1378 }
1379
1380 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1381 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1382 if (CodecNamesEq(name, engine_codec.name))
1383 return engine_codec;
1384 }
1385 // This point should never be reached.
1386 ADD_FAILURE() << "Unrecognized codec name: " << name;
1387 return cricket::VideoCodec();
1388 }
1389
1390 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1391
1392 cricket::StreamParams DefaultSendStreamParams() {
1393 return cricket::StreamParams::CreateLegacy(kSsrc);
1394 }
1395
1396 webrtc::RtcEventLogNullImpl event_log_;
1397 const std::unique_ptr<webrtc::Call> call_;
1398 WebRtcVideoEngine engine_;
1399 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1400 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1401 std::unique_ptr<WebRtcVideoChannel> channel_;
1402 cricket::FakeNetworkInterface network_interface_;
1403 cricket::FakeVideoRenderer renderer_;
1404
1405 // Used by test cases where 2 streams are run on the same channel.
1406 cricket::FakeVideoRenderer renderer2_;
1407};
1408
1409// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001410TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001411 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001412 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001413 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1414 EXPECT_FALSE(channel_->sending());
1415 EXPECT_TRUE(SetSend(true));
1416 EXPECT_TRUE(channel_->sending());
1417 EXPECT_TRUE(SendFrame());
1418 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1419 EXPECT_TRUE(SetSend(false));
1420 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001421}
Niels Möller6557d0c2018-04-11 15:18:34 +02001422
1423// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001424TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001425 EXPECT_FALSE(channel_->sending());
1426 EXPECT_FALSE(SetSend(true));
1427 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001428}
Niels Möller6557d0c2018-04-11 15:18:34 +02001429
1430// Test that we properly set the send and recv buffer sizes by the time
1431// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001432TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001433 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1434 EXPECT_TRUE(SetSend(true));
1435 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1436 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001437}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001438
Erik Språng820ebd02018-08-20 17:14:25 +02001439// Test that we properly set the send and recv buffer sizes when overriding
1440// via field trials.
1441TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1442 // Set field trial to override the default recv buffer size, and then re-run
1443 // setup where the interface is created and configured.
1444 const int kCustomRecvBufferSize = 123456;
1445 webrtc::test::ScopedFieldTrials field_trial(
1446 "WebRTC-IncreasedReceivebuffers/123456/");
1447 SetUp();
1448
1449 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1450 EXPECT_TRUE(SetSend(true));
1451 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1452 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1453}
1454
1455// Test that we properly set the send and recv buffer sizes when overriding
1456// via field trials with suffix.
1457TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1458 // Set field trial to override the default recv buffer size, and then re-run
1459 // setup where the interface is created and configured.
1460 const int kCustomRecvBufferSize = 123456;
1461 webrtc::test::ScopedFieldTrials field_trial(
1462 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1463 SetUp();
1464
1465 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1466 EXPECT_TRUE(SetSend(true));
1467 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1468 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1469}
1470
1471// Test that we properly set the send and recv buffer sizes when overriding
1472// via field trials that don't make any sense.
1473TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1474 // Set bogus field trial values to override the default recv buffer size, and
1475 // then re-run setup where the interface is created and configured. The
1476 // default value should still be used.
1477
1478 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1479 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1480 field_trial_string += group;
1481 field_trial_string += "/";
1482 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1483 SetUp();
1484
1485 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1486 EXPECT_TRUE(SetSend(true));
1487 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1488 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1489 }
1490}
1491
Niels Möller6557d0c2018-04-11 15:18:34 +02001492// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 const int kDurationSec = 3;
1495 const int kFps = 10;
1496 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1497
1498 cricket::VideoMediaInfo info;
1499 EXPECT_TRUE(channel_->GetStats(&info));
1500
1501 ASSERT_EQ(1U, info.senders.size());
1502 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1503 // For webrtc, bytes_sent does not include the RTP header length.
1504 EXPECT_GT(info.senders[0].bytes_sent, 0);
1505 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1506 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1507 ASSERT_TRUE(info.senders[0].codec_payload_type);
1508 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1509 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1510 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1511 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1512 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1513 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1514 EXPECT_GT(info.senders[0].framerate_input, 0);
1515 EXPECT_GT(info.senders[0].framerate_sent, 0);
1516
1517 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1518 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1519 info.send_codecs[DefaultCodec().id]);
1520
1521 ASSERT_EQ(1U, info.receivers.size());
1522 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1523 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1524 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1525 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1526 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1527 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1528 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1529 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1530 EXPECT_EQ(0, info.receivers[0].packets_lost);
1531 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1532 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1533 EXPECT_EQ(0, info.receivers[0].firs_sent);
1534 EXPECT_EQ(0, info.receivers[0].plis_sent);
1535 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1536 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1537 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1538 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1539 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1540 EXPECT_GT(info.receivers[0].framerate_output, 0);
1541
1542 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1543 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1544 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001545}
Niels Möller6557d0c2018-04-11 15:18:34 +02001546
1547// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001548TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001549 cricket::FakeVideoRenderer renderer1, renderer2;
1550 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1551 cricket::VideoSendParameters parameters;
1552 parameters.codecs.push_back(DefaultCodec());
1553 parameters.conference_mode = true;
1554 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1555 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001556 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1557 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001558 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1559 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1560 EXPECT_EQ(0, renderer1.num_rendered_frames());
1561 EXPECT_EQ(0, renderer2.num_rendered_frames());
1562 std::vector<uint32_t> ssrcs;
1563 ssrcs.push_back(1);
1564 ssrcs.push_back(2);
1565 network_interface_.SetConferenceMode(true, ssrcs);
1566 EXPECT_TRUE(SendFrame());
1567 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1568 kTimeout);
1569 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1570 kTimeout);
1571
1572 EXPECT_TRUE(channel_->SetSend(false));
1573
1574 cricket::VideoMediaInfo info;
1575 EXPECT_TRUE(channel_->GetStats(&info));
1576 ASSERT_EQ(1U, info.senders.size());
1577 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1578 // For webrtc, bytes_sent does not include the RTP header length.
1579 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1580 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1581 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1582 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1583
1584 ASSERT_EQ(2U, info.receivers.size());
1585 for (size_t i = 0; i < info.receivers.size(); ++i) {
1586 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1587 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1588 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001589 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001590 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1591 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1592 }
srtee0c2eea2017-12-15 17:44:33 +01001593}
Niels Möller6557d0c2018-04-11 15:18:34 +02001594
1595// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001596TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001597 // Normal setup; note that we set the SSRC explicitly to ensure that
1598 // it will come first in the senders map.
1599 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1600 cricket::VideoSendParameters parameters;
1601 parameters.codecs.push_back(DefaultCodec());
1602 parameters.conference_mode = true;
1603 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001604 EXPECT_TRUE(
1605 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1607 EXPECT_TRUE(SetSend(true));
1608 EXPECT_TRUE(SendFrame());
1609 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1610 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1611
1612 // Add an additional capturer, and hook up a renderer to receive it.
1613 cricket::FakeVideoRenderer renderer2;
1614 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1615 CreateFakeVideoCapturer());
1616 const int kTestWidth = 160;
1617 const int kTestHeight = 120;
1618 cricket::VideoFormat format(kTestWidth, kTestHeight,
1619 cricket::VideoFormat::FpsToInterval(5),
1620 cricket::FOURCC_I420);
1621 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001622 EXPECT_TRUE(
1623 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001624 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001625 EXPECT_TRUE(
1626 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001627 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1628 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001629 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1630 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001631
1632 // Get stats, and make sure they are correct for two senders. We wait until
1633 // the number of expected packets have been sent to avoid races where we
1634 // check stats before it has been updated.
1635 cricket::VideoMediaInfo info;
1636 for (uint32_t i = 0; i < kTimeout; ++i) {
1637 rtc::Thread::Current()->ProcessMessages(1);
1638 EXPECT_TRUE(channel_->GetStats(&info));
1639 ASSERT_EQ(2U, info.senders.size());
1640 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1641 NumRtpPackets()) {
1642 // Stats have been updated for both sent frames, expectations can be
1643 // checked now.
1644 break;
1645 }
1646 }
1647 EXPECT_EQ(NumRtpPackets(),
1648 info.senders[0].packets_sent + info.senders[1].packets_sent)
1649 << "Timed out while waiting for packet counts for all sent packets.";
1650 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1651 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1652 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1653 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1654 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1655 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1656 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1657 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1658 // The capturer must be unregistered here as it runs out of it's scope next.
1659 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001660}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001663TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 parameters.max_bandwidth_bps = 128 * 1024;
1669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001670}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001671
Niels Möller6557d0c2018-04-11 15:18:34 +02001672// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001673TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001674 EXPECT_TRUE(SetDefaultCodec());
1675 EXPECT_TRUE(SetSend(true));
1676 EXPECT_TRUE(SendFrame());
1677 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001678 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001679 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001680 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1681 EXPECT_EQ(kSsrc, header.ssrc);
1682
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 // Packets are being paced out, so these can mismatch between the first and
1684 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001685 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1686 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 EXPECT_EQ(1, NumSentSsrcs());
1688 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1689 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001690}
Niels Möller6557d0c2018-04-11 15:18:34 +02001691
1692// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001693TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 // Remove stream added in Setup.
1695 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1696 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001698 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1699 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_TRUE(SetSend(true));
1701 EXPECT_TRUE(WaitAndSendFrame(0));
1702 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001705 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1706 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001707 // Packets are being paced out, so these can mismatch between the first and
1708 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001709 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1710 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 EXPECT_EQ(1, NumSentSsrcs());
1712 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1713 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001714}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001715
Niels Möller6557d0c2018-04-11 15:18:34 +02001716// Test that we can set the default video renderer before and after
1717// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001718TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001719 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1720 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001721
1722 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1723 rtc::SetBE32(packet1.data() + 8, kSsrc);
1724 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1725 EXPECT_TRUE(SetDefaultCodec());
1726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_EQ(0, renderer_.num_rendered_frames());
1728 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1729 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1730 EXPECT_TRUE(SendFrame());
1731 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001732}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001735TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1737 EXPECT_TRUE(SetSend(true));
1738 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1739 EXPECT_TRUE(SendFrame());
1740 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1741 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001742 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001744 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1745 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001746 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1747 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001748
1749 // Remove the send stream that was added during Setup.
1750 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1751 int rtp_packets = NumRtpPackets();
1752
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001754 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1755 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_EQ(rtp_packets, NumRtpPackets());
1757 // Wait 30ms to guarantee the engine does not drop the frame.
1758 EXPECT_TRUE(WaitAndSendFrame(30));
1759 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1760
1761 last_packet = NumRtpPackets() - 1;
1762 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001765}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001766
Niels Möller6557d0c2018-04-11 15:18:34 +02001767// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001768TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 cricket::FakeVideoRenderer renderer1, renderer2;
1770 EXPECT_TRUE(SetDefaultCodec());
1771 cricket::VideoSendParameters parameters;
1772 parameters.codecs.push_back(DefaultCodec());
1773 parameters.conference_mode = true;
1774 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1775 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001776 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1777 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1779 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1780 EXPECT_EQ(0, renderer1.num_rendered_frames());
1781 EXPECT_EQ(0, renderer2.num_rendered_frames());
1782 std::vector<uint32_t> ssrcs;
1783 ssrcs.push_back(1);
1784 ssrcs.push_back(2);
1785 network_interface_.SetConferenceMode(true, ssrcs);
1786 EXPECT_TRUE(SendFrame());
1787 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1788 kTimeout);
1789 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1790 kTimeout);
1791
1792 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1793 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1794 EXPECT_EQ(kVideoWidth, renderer1.width());
1795 EXPECT_EQ(kVideoHeight, renderer1.height());
1796 EXPECT_EQ(kVideoWidth, renderer2.width());
1797 EXPECT_EQ(kVideoHeight, renderer2.height());
1798 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1799 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001800}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001801
Niels Möller6557d0c2018-04-11 15:18:34 +02001802// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001803TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 using cricket::VideoCodec;
1805 using cricket::VideoOptions;
1806 using cricket::VideoFormat;
1807 using cricket::FOURCC_I420;
1808
1809 VideoCodec codec = DefaultCodec();
1810 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1811 EXPECT_TRUE(SetOneCodec(codec));
1812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1814 EXPECT_EQ(0, renderer_.num_rendered_frames());
1815 EXPECT_TRUE(SendFrame());
1816 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1817 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1818 CreateFakeVideoCapturer());
1819
1820 // TODO(nisse): This testcase fails if we don't configure
1821 // screencast. It's unclear why, I see nothing obvious in this
1822 // test which is related to screencast logic.
1823 VideoOptions video_options;
1824 video_options.is_screencast = true;
1825 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1826
1827 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1828 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1829 // All capturers start generating frames with the same timestamp. ViE does
1830 // not allow the same timestamp to be used. Capture one frame before
1831 // associating the capturer with the channel.
1832 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1833
1834 int captured_frames = 1;
1835 for (int iterations = 0; iterations < 2; ++iterations) {
1836 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1837 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1838 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1839 ++captured_frames;
1840 // Wait until frame of right size is captured.
1841 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001842 format.width == renderer_.width() &&
1843 format.height == renderer_.height() &&
1844 !renderer_.black_frame(),
1845 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001846 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1847 EXPECT_EQ(format.width, renderer_.width());
1848 EXPECT_EQ(format.height, renderer_.height());
1849 captured_frames = renderer_.num_rendered_frames() + 1;
1850 EXPECT_FALSE(renderer_.black_frame());
1851 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1852 // Make sure a black frame is generated within the specified timeout.
1853 // The black frame should be the resolution of the previous frame to
1854 // prevent expensive encoder reconfigurations.
1855 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001856 format.width == renderer_.width() &&
1857 format.height == renderer_.height() &&
1858 renderer_.black_frame(),
1859 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1861 EXPECT_EQ(format.width, renderer_.width());
1862 EXPECT_EQ(format.height, renderer_.height());
1863 EXPECT_TRUE(renderer_.black_frame());
1864
1865 // The black frame has the same timestamp as the next frame since it's
1866 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1867 // not render a frame with the same timestamp so capture another frame
1868 // with the frame capturer to increment the next frame's timestamp.
1869 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1870 }
srtee0c2eea2017-12-15 17:44:33 +01001871}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001872
Niels Möller6557d0c2018-04-11 15:18:34 +02001873// Tests that if SetVideoSend is called with a NULL capturer after the
1874// capturer was already removed, the application doesn't crash (and no black
1875// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001876TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001877 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1878 EXPECT_TRUE(SetSend(true));
1879 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1880 EXPECT_EQ(0, renderer_.num_rendered_frames());
1881 EXPECT_TRUE(SendFrame());
1882 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1883 // Wait for one frame so they don't get dropped because we send frames too
1884 // tightly.
1885 rtc::Thread::Current()->ProcessMessages(30);
1886 // Remove the capturer.
1887 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1888
1889 // No capturer was added, so this SetVideoSend shouldn't do anything.
1890 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1891 rtc::Thread::Current()->ProcessMessages(300);
1892 // Verify no more frames were sent.
1893 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001894}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001895
Niels Möller6557d0c2018-04-11 15:18:34 +02001896// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001897TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1899 // interval time to avoid that.
1900 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1901 // interval time to avoid that.
1902 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001903 EXPECT_TRUE(
1904 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001905 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1906 cricket::VideoFormat capture_format(
1907 kVideoWidth, kVideoHeight,
1908 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1909 // Set up additional stream 1.
1910 cricket::FakeVideoRenderer renderer1;
1911 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001912 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001914 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1916 CreateFakeVideoCapturer());
1917 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1918 // Set up additional stream 2.
1919 cricket::FakeVideoRenderer renderer2;
1920 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001923 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001924 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1925 CreateFakeVideoCapturer());
1926 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1927 // State for all the streams.
1928 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1929 // A limitation in the lmi implementation requires that SetVideoSend() is
1930 // called after SetOneCodec().
1931 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1932 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1933 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1934 EXPECT_TRUE(SetSend(true));
1935 // Test capturer associated with engine.
1936 const int kTestWidth = 160;
1937 const int kTestHeight = 120;
1938 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1940 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 // Capture a frame with additional capturer2, frames should be received
1942 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001943 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1944 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 // Successfully remove the capturer.
1946 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1947 // The capturers must be unregistered here as it runs out of it's scope
1948 // next.
1949 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1950 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001951}
Niels Möller6557d0c2018-04-11 15:18:34 +02001952
1953// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001954TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001955 // Remove the send stream that was added during Setup.
1956 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1957
1958 cricket::StreamParams empty;
1959 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001960 EXPECT_TRUE(
1961 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001962}
Niels Möller6557d0c2018-04-11 15:18:34 +02001963
1964// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001965TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 // Remove stream added in Setup. I.e. remove stream corresponding to default
1967 // channel.
1968 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001969 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001970 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1971 EXPECT_TRUE(channel_->AddSendStream(
1972 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1973 }
1974 // Delete one of the non default channel streams, let the destructor delete
1975 // the remaining ones.
1976 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1977 // Stream should already be deleted.
1978 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001979}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001980
eladalonf1841382017-06-12 01:16:46 -07001981TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001982 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001983}
1984
eladalonf1841382017-06-12 01:16:46 -07001985TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001986 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001987}
1988
eladalonf1841382017-06-12 01:16:46 -07001989TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001990 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001991}
1992
eladalonf1841382017-06-12 01:16:46 -07001993TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001994 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1995 // bitrates. This currently happens at <250k, and two streams sharing 300k
1996 // initially will use QVGA instead of VGA.
1997 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1998 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001999 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002000 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002001 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002002}
2003
eladalonf1841382017-06-12 01:16:46 -07002004class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002005 public:
eladalonf1841382017-06-12 01:16:46 -07002006 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2007 explicit WebRtcVideoChannelTest(const char* field_trials)
2008 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002009 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002010 encoder_factory_->AddSupportedVideoCodecType("VP8");
2011 encoder_factory_->AddSupportedVideoCodecType("VP9");
2012#if defined(WEBRTC_USE_H264)
2013 encoder_factory_->AddSupportedVideoCodecType("H264");
2014#endif
2015
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002016 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002017 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
2018 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002019 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002021 send_parameters_.codecs = engine_.codecs();
2022 recv_parameters_.codecs = engine_.codecs();
2023 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002024 }
2025
2026 protected:
2027 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002028 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002029 }
2030
2031 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002032 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002033 EXPECT_TRUE(channel_->AddSendStream(sp));
2034 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002035 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002036 EXPECT_EQ(num_streams + 1, streams.size());
2037 return streams[streams.size() - 1];
2038 }
2039
2040 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002041 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002042 }
2043
2044 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002045 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002046 }
2047
2048 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002049 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002050 EXPECT_TRUE(channel_->AddRecvStream(sp));
2051 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002052 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002053 EXPECT_EQ(num_streams + 1, streams.size());
2054 return streams[streams.size() - 1];
2055 }
2056
pbos@webrtc.org00873182014-11-25 14:03:34 +00002057 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2058 int expected_min_bitrate_bps,
2059 const char* start_bitrate_kbps,
2060 int expected_start_bitrate_bps,
2061 const char* max_bitrate_kbps,
2062 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002063 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2064 expected_start_bitrate_bps,
2065 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002066 auto& codecs = send_parameters_.codecs;
2067 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002068 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002069 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2070 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2071 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002072 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002073 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002074
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002075 void ExpectSetBitrateParameters(int min_bitrate_bps,
2076 int start_bitrate_bps,
2077 int max_bitrate_bps) {
2078 EXPECT_CALL(
2079 *fake_call_->GetMockTransportControllerSend(),
2080 SetSdpBitrateParameters(AllOf(
2081 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2082 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2083 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2084 }
2085
2086 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2087 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2088 SetSdpBitrateParameters(Field(
2089 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002090 }
2091
isheriff6f8d6862016-05-26 11:24:55 -07002092 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002093 // Enable extension.
2094 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002095 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002096 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002097 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002098 FakeVideoSendStream* send_stream =
2099 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2100
2101 // Verify the send extension id.
2102 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2103 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002104 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002105 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002106 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002107 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2108 // receivers.
2109 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2110 ->GetConfig()
2111 .rtp.extensions.empty());
2112
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002113 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002114 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002115 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2116 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002117 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2118
2119 // Verify that adding receive RTP header extensions adds them for existing
2120 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002121 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002122 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002123 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2124 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002125 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002126 }
2127
isheriff6f8d6862016-05-26 11:24:55 -07002128 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002129 // Enable extension.
2130 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002131 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002132 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002133 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134
2135 FakeVideoReceiveStream* recv_stream =
2136 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2137
2138 // Verify the recv extension id.
2139 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2140 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002141 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002142 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002143 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002144
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002145 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2146 // senders.
2147 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2148 ->GetConfig()
2149 .rtp.extensions.empty());
2150
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002151 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002152 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002153 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2154 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002155 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2156
2157 // Verify that adding receive RTP header extensions adds them for existing
2158 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002160 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002161 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2162 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002163 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002164 }
2165
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002166 void TestExtensionFilter(const std::vector<std::string>& extensions,
2167 const std::string& expected_extension) {
2168 cricket::VideoSendParameters parameters = send_parameters_;
2169 int expected_id = -1;
2170 int id = 1;
2171 for (const std::string& extension : extensions) {
2172 if (extension == expected_extension)
2173 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002174 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002175 }
2176 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2177 FakeVideoSendStream* send_stream =
2178 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2179
2180 // Verify that only one of them has been set, and that it is the one with
2181 // highest priority (transport sequence number).
2182 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2183 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2184 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002185 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002186 }
2187
asapersson3c81a1a2017-06-14 05:52:21 -07002188 void TestDegradationPreference(bool resolution_scaling_enabled,
2189 bool fps_scaling_enabled);
2190
Erik Språngefbde372015-04-29 16:21:28 +02002191 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002192 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002193 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2194 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002195
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002197 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002198 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002199 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002200 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002201 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002202 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002203 // Options only take effect on the next frame.
2204 EXPECT_TRUE(capturer->CaptureFrame());
2205
Erik Språng143cec12015-04-28 10:01:41 +02002206 return fake_call_->GetVideoSendStreams().back();
2207 }
2208
Peter Boström2feafdb2015-09-09 14:32:14 +02002209 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2210 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002211 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002212 std::vector<uint32_t> ssrcs;
2213 std::vector<uint32_t> rtx_ssrcs;
2214 uint32_t num_streams = enabled ? 3 : 1;
2215 for (uint32_t i = 0; i < num_streams; ++i) {
2216 uint32_t ssrc = last_ssrc_ + i;
2217 ssrcs.push_back(ssrc);
2218 if (with_rtx) {
2219 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2220 }
Erik Språng143cec12015-04-28 10:01:41 +02002221 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002222 if (with_rtx) {
2223 return AddSendStream(
2224 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2225 }
2226 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002227 }
2228
perkjfa10b552016-10-02 23:45:26 -07002229 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002230 std::vector<FakeVideoSendStream*> streams =
2231 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002232 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002233 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002234 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002235 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002236 }
2237
perkjfa10b552016-10-02 23:45:26 -07002238 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002239 int stream_max,
2240 int expected_encoder_bitrate) {
2241 VideoSendParameters limited_send_params = send_parameters_;
2242 limited_send_params.max_bandwidth_bps = global_max;
2243 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002244 webrtc::RtpParameters parameters =
2245 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002246 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002247 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002248 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002249 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002250 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002251 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002252 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002253 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002254 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002255 }
2256
Åsa Persson55659812018-06-18 17:51:32 +02002257 // Values from kSimulcastConfigs in simulcast.cc.
2258 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2259 std::vector<webrtc::VideoStream> layers(3);
2260 layers[0].min_bitrate_bps = 30000;
2261 layers[0].target_bitrate_bps = 150000;
2262 layers[0].max_bitrate_bps = 200000;
2263 layers[1].min_bitrate_bps = 150000;
2264 layers[1].target_bitrate_bps = 500000;
2265 layers[1].max_bitrate_bps = 700000;
2266 layers[2].min_bitrate_bps = 600000;
2267 layers[2].target_bitrate_bps = 2500000;
2268 layers[2].max_bitrate_bps = 2500000;
2269 return layers;
2270 }
2271
kwiberg686a8ef2016-02-26 03:00:35 -08002272 std::unique_ptr<FakeCall> fake_call_;
2273 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002274 cricket::VideoSendParameters send_parameters_;
2275 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002276 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002277};
2278
eladalonf1841382017-06-12 01:16:46 -07002279TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002280 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002281 const std::string kSyncLabel = "AvSyncLabel";
2282
2283 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002284 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002285 EXPECT_TRUE(channel_->AddRecvStream(sp));
2286
Mirko Bonadeif859e552018-05-30 15:31:29 +02002287 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002288 EXPECT_EQ(kSyncLabel,
2289 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2290 << "SyncGroup should be set based on sync_label";
2291}
2292
eladalonf1841382017-06-12 01:16:46 -07002293TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 cricket::VideoSendParameters parameters;
2295 parameters.codecs = engine_.codecs();
2296 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002297 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002298 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002299 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002300
2301 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002302 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2303 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002304 FakeVideoSendStream* send_stream = AddSendStream(
2305 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2306
2307 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2308 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2309 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2310
2311 // Receiver side.
2312 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2313 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002314 EXPECT_FALSE(
2315 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002316 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002317 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002318 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002319 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002320 << "RTX should be mapped for the RED payload type";
2321
brandtr14742122017-01-27 04:53:07 -08002322 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002323}
2324
eladalonf1841382017-06-12 01:16:46 -07002325TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002326 // Setup one channel with an associated RTX stream.
2327 cricket::StreamParams params =
2328 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2329 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2330 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002331 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002332
2333 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2334 << "RTX should be mapped for all decoders/payload types.";
2335 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002336 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002337 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002338}
2339
eladalonf1841382017-06-12 01:16:46 -07002340TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002341 // Setup one channel without an associated RTX stream.
2342 cricket::StreamParams params =
2343 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2344 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002345 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346}
2347
eladalonf1841382017-06-12 01:16:46 -07002348TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002349 FakeVideoSendStream* send_stream =
2350 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2351 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2352
2353 FakeVideoReceiveStream* recv_stream =
2354 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2355 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002356}
2357
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002358// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002359TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002360 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002361}
isheriff6f8d6862016-05-26 11:24:55 -07002362
eladalonf1841382017-06-12 01:16:46 -07002363TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002364 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002365}
2366
2367// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002368TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002369 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002370}
isheriff6f8d6862016-05-26 11:24:55 -07002371
eladalonf1841382017-06-12 01:16:46 -07002372TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002373 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002374}
2375
eladalonf1841382017-06-12 01:16:46 -07002376TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002377 // Enable three redundant extensions.
2378 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002379 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2380 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2381 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2382 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002383}
2384
eladalonf1841382017-06-12 01:16:46 -07002385TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002386 // Enable two redundant extensions.
2387 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002388 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2389 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2390 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002391}
2392
stefanc1aeaf02015-10-15 07:26:07 -07002393// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002394TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002395 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002396}
eladalonf1841382017-06-12 01:16:46 -07002397TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002398 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002399}
2400
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002401// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002402TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002403 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002404}
eladalonf1841382017-06-12 01:16:46 -07002405TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002406 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002407}
2408
eladalonf1841382017-06-12 01:16:46 -07002409TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002410 const int kAbsSendTimeId = 1;
2411 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002412 send_parameters_.extensions.push_back(
2413 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2414 send_parameters_.extensions.push_back(
2415 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002416
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002417 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002418 FakeVideoSendStream* send_stream =
2419 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2420
2421 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002422 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002423
2424 // Setting the same extensions (even if in different order) shouldn't
2425 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 std::reverse(send_parameters_.extensions.begin(),
2427 send_parameters_.extensions.end());
2428 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002429
2430 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2431
2432 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002433 send_parameters_.extensions.resize(1);
2434 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002435
2436 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2437}
2438
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002440 const int kTOffsetId = 1;
2441 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002442 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002443 recv_parameters_.extensions.push_back(
2444 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2445 recv_parameters_.extensions.push_back(
2446 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2447 recv_parameters_.extensions.push_back(
2448 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002449
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002450 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002451 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002452 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2453
2454 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002455 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002456
2457 // Setting the same extensions (even if in different order) shouldn't
2458 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002459 std::reverse(recv_parameters_.extensions.begin(),
2460 recv_parameters_.extensions.end());
2461 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002462
2463 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2464
2465 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002466 recv_parameters_.extensions.resize(1);
2467 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002468
2469 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2470}
2471
eladalonf1841382017-06-12 01:16:46 -07002472TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002473 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002474 const int kUnsupportedId = 1;
2475 const int kTOffsetId = 2;
2476
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002477 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002478 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002479 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002480 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002482 FakeVideoSendStream* send_stream =
2483 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2484
2485 // Only timestamp offset extension is set to send stream,
2486 // unsupported rtp extension is ignored.
2487 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002488 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2489 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002490}
2491
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002493 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002494 const int kUnsupportedId = 1;
2495 const int kTOffsetId = 2;
2496
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002497 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002498 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002499 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002500 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002501 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002502 FakeVideoReceiveStream* recv_stream =
2503 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2504
2505 // Only timestamp offset extension is set to receive stream,
2506 // unsupported rtp extension is ignored.
2507 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002508 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2509 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002510}
2511
eladalonf1841382017-06-12 01:16:46 -07002512TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002513 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002514 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002515 send_parameters_.extensions.push_back(
2516 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002518 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2519 }
2520}
2521
eladalonf1841382017-06-12 01:16:46 -07002522TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002523 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002524 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002525 recv_parameters_.extensions.push_back(
2526 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002527 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002528 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2529 }
2530}
2531
eladalonf1841382017-06-12 01:16:46 -07002532TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002533 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002534 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002535 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002536 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002537 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002538 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002539
2540 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002541 send_parameters_.extensions.clear();
2542 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002543 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2545 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002546}
2547
eladalonf1841382017-06-12 01:16:46 -07002548TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002549 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002550 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002553 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002554 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002555
2556 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 recv_parameters_.extensions.clear();
2558 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002559 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2561 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002565 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002566 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002567}
2568
eladalonf1841382017-06-12 01:16:46 -07002569TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002570 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002571 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002572}
2573
eladalonf1841382017-06-12 01:16:46 -07002574TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002575 FakeVideoReceiveStream* stream = AddRecvStream();
2576 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002577}
2578
eladalonf1841382017-06-12 01:16:46 -07002579TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002580 FakeVideoReceiveStream* stream = AddRecvStream();
2581 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2582}
2583
eladalonf1841382017-06-12 01:16:46 -07002584TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002585 FakeVideoReceiveStream* stream = AddRecvStream();
2586 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2587
Peter Boström126c03e2015-05-11 12:48:12 +02002588 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002590 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2592 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002593 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002594 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2595
2596 // Verify that REMB is turned on when setting default codecs since the
2597 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 parameters.codecs = engine_.codecs();
2599 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002600 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002601 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002605 FakeVideoReceiveStream* stream = AddRecvStream();
2606 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2607
2608 // Verify that transport cc feedback is turned off when send(!) codecs without
2609 // transport cc feedback are set.
2610 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002611 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002612 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2613 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2614 stream = fake_call_->GetVideoReceiveStreams()[0];
2615 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2616
2617 // Verify that transport cc feedback is turned on when setting default codecs
2618 // since the default codecs have transport cc feedback enabled.
2619 parameters.codecs = engine_.codecs();
2620 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2621 stream = fake_call_->GetVideoReceiveStreams()[0];
2622 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002626 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002627 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2628
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002629 cricket::VideoSendParameters parameters;
2630 parameters.codecs = engine_.codecs();
2631 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002632 EXPECT_TRUE(channel_->SetSend(true));
2633
2634 // Send side.
2635 FakeVideoSendStream* send_stream =
2636 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2637 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2638
2639 // Receiver side.
2640 FakeVideoReceiveStream* recv_stream =
2641 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2642 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2643
2644 // Nack history size should match between sender and receiver.
2645 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2646 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002647}
2648
eladalonf1841382017-06-12 01:16:46 -07002649TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002650 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002651 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002652
2653 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2654 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2655
2656 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002657 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002658 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002659 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2660 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002661 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2662 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2663 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002664 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2665
Peter Boström67c9df72015-05-11 14:34:58 +02002666 // Verify that NACK is turned on when setting default codecs since the
2667 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002668 parameters.codecs = engine_.codecs();
2669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002670 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2671 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2672 send_stream = fake_call_->GetVideoSendStreams()[0];
2673 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002674}
2675
Peter Boströme7ba0862016-03-12 00:02:28 +01002676// This test verifies that new frame sizes reconfigures encoders even though not
2677// (yet) sending. The purpose of this is to permit encoding as quickly as
2678// possible once we start sending. Likely the frames being input are from the
2679// same source that will be sent later, which just means that we're ready
2680// earlier.
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002683 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002684 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2685 channel_->SetSend(false);
2686
2687 FakeVideoSendStream* stream = AddSendStream();
2688
perkjfa10b552016-10-02 23:45:26 -07002689 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002690 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002691 EXPECT_EQ(0u, streams[0].width);
2692 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002693
Tommi85959932018-02-07 19:26:06 +01002694 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002695 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002696 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2697 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002698 EXPECT_TRUE(capturer.CaptureFrame());
2699
2700 // Frame entered, should be reconfigured to new dimensions.
2701 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002702 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2703 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2704 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002705
Niels Möllerff40b142018-04-09 08:49:14 +02002706 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002707}
2708
eladalonf1841382017-06-12 01:16:46 -07002709TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002710 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002711 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002712 cricket::VideoSendParameters parameters;
2713 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002714 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002715 AddSendStream();
2716
Tommi85959932018-02-07 19:26:06 +01002717 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002718 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002719 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002720 EXPECT_TRUE(
2721 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002722 cricket::VideoFormat capture_format_hd =
2723 capturer.GetSupportedFormats()->front();
2724 EXPECT_EQ(1280, capture_format_hd.width);
2725 EXPECT_EQ(720, capture_format_hd.height);
2726 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2727
2728 EXPECT_TRUE(channel_->SetSend(true));
2729
2730 EXPECT_TRUE(capturer.CaptureFrame());
2731 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2732 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2733
2734 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2735
2736 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002737 webrtc::VideoEncoderConfig encoder_config =
2738 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002739 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002740 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002741 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002742 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2743 streams.front().width);
2744 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2745 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002746 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2747 << "Non-screenshare shouldn't use min-transmit bitrate.";
2748
Niels Möllerff40b142018-04-09 08:49:14 +02002749 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002750 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002751 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002752 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002753 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002754 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002755 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002756 // Send stream recreated after option change.
2757 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2758 send_stream = fake_call_->GetVideoSendStreams().front();
2759 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002760
2761 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002762 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002763 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002764 encoder_config.content_type);
2765 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2766 encoder_config.min_transmit_bitrate_bps);
2767
perkjfa10b552016-10-02 23:45:26 -07002768 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002769 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2770 streams.front().width);
2771 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2772 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002773 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002774 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002775}
2776
eladalonf1841382017-06-12 01:16:46 -07002777TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002778 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002779 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002780 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002781 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002782
2783 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002784 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002785 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002786 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002787 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002788 cricket::VideoFormat capture_format_hd =
2789 capturer.GetSupportedFormats()->front();
2790 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2791
2792 EXPECT_TRUE(channel_->SetSend(true));
2793
2794 EXPECT_TRUE(capturer.CaptureFrame());
2795 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2796 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2797
perkj26091b12016-09-01 01:17:40 -07002798 webrtc::VideoEncoderConfig encoder_config =
2799 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002800
2801 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002802 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002803 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002804 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002805
2806 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2807 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002808 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002809 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002810 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811
Niels Möllerff40b142018-04-09 08:49:14 +02002812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002813}
2814
eladalonf1841382017-06-12 01:16:46 -07002815TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002816 FakeVideoSendStream* stream = AddSendStream();
2817 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2818}
2819
eladalonf1841382017-06-12 01:16:46 -07002820TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002821 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002822 media_config.video.suspend_below_min_bitrate = true;
2823
2824 channel_.reset(
2825 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002826 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002827
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002828 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002829
2830 FakeVideoSendStream* stream = AddSendStream();
2831 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2832
nisse0db023a2016-03-01 04:29:59 -08002833 media_config.video.suspend_below_min_bitrate = false;
2834 channel_.reset(
2835 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002836 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002837
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002838 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002839
nisse0db023a2016-03-01 04:29:59 -08002840 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002841 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2842}
2843
eladalonf1841382017-06-12 01:16:46 -07002844TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002845 FakeVideoSendStream* stream = AddSendStream();
2846 webrtc::VideoCodecVP8 vp8_settings;
2847 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2848 EXPECT_TRUE(vp8_settings.denoisingOn);
2849}
2850
eladalonf1841382017-06-12 01:16:46 -07002851TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002852 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002853 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002854 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002855
Peter Boström2feafdb2015-09-09 14:32:14 +02002856 // Single-stream settings should apply with RTX as well (verifies that we
2857 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2858 // both RTX and regular SSRCs).
2859 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002860
Tommi85959932018-02-07 19:26:06 +01002861 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002862 EXPECT_EQ(cricket::CS_RUNNING,
2863 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002864 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002865 channel_->SetSend(true);
2866
2867 EXPECT_TRUE(capturer.CaptureFrame());
2868
pbos4cba4eb2015-10-26 11:18:18 -07002869 webrtc::VideoCodecVP8 vp8_settings;
2870 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2871 EXPECT_TRUE(vp8_settings.denoisingOn)
2872 << "VP8 denoising should be on by default.";
2873
nisse05103312016-03-16 02:22:50 -07002874 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002875
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002876 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2877 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002878 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2879 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002880
nisse05103312016-03-16 02:22:50 -07002881 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002882
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002883 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2884 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002885 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2886 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2887
Niels Möllerff40b142018-04-09 08:49:14 +02002888 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002889 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002890 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002891 channel_->SetSend(true);
2892 EXPECT_TRUE(capturer.CaptureFrame());
2893
Mirko Bonadeif859e552018-05-30 15:31:29 +02002894 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002895 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2896 // Autmatic resize off when using simulcast.
2897 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2898 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2899
2900 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002901 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002902 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002903 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002904
nisse05103312016-03-16 02:22:50 -07002905 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002906
Mirko Bonadeif859e552018-05-30 15:31:29 +02002907 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002908 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2909 EXPECT_FALSE(vp8_settings.denoisingOn);
2910 // Resizing and frame dropping always off for screen sharing.
2911 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2912 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2913
nisse05103312016-03-16 02:22:50 -07002914 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002915
2916 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2917 EXPECT_FALSE(vp8_settings.denoisingOn);
2918 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2919 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2920
Niels Möllerff40b142018-04-09 08:49:14 +02002921 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002922}
2923
deadbeef119760a2016-04-04 11:43:27 -07002924// Test that setting the same options doesn't result in the encoder being
2925// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002926TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002927 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002928 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002929
perkjfa10b552016-10-02 23:45:26 -07002930 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002931 EXPECT_EQ(cricket::CS_RUNNING,
2932 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002933 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002934 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002935 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2936 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2937
Niels Möllerff40b142018-04-09 08:49:14 +02002938 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002940 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002941 // Expect 1 reconfigurations at this point from the initial configuration.
2942 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002943
2944 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002945 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002946 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2947
2948 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002949 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002950 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002951 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2952
Niels Möllerff40b142018-04-09 08:49:14 +02002953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002954}
2955
eladalonf1841382017-06-12 01:16:46 -07002956class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002957 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002958 Vp9SettingsTest() : Vp9SettingsTest("") {}
2959 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002960 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002961 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002962 }
2963 virtual ~Vp9SettingsTest() {}
2964
2965 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002966 void TearDown() override {
2967 // Remove references to encoder_factory_ since this will be destroyed
2968 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002969 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002970 }
Erik Språng143cec12015-04-28 10:01:41 +02002971};
2972
2973TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002974 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002975 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002976 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002977
Peter Boström2feafdb2015-09-09 14:32:14 +02002978 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002979
Tommi85959932018-02-07 19:26:06 +01002980 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002981 EXPECT_EQ(cricket::CS_RUNNING,
2982 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002984 channel_->SetSend(true);
2985
2986 EXPECT_TRUE(capturer.CaptureFrame());
2987
pbos4cba4eb2015-10-26 11:18:18 -07002988 webrtc::VideoCodecVP9 vp9_settings;
2989 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002990 EXPECT_TRUE(vp9_settings.denoisingOn)
2991 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002992
nisse05103312016-03-16 02:22:50 -07002993 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002994
Erik Språng143cec12015-04-28 10:01:41 +02002995 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2996 EXPECT_FALSE(vp9_settings.denoisingOn);
2997 // Frame dropping always on for real time video.
2998 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2999
nisse05103312016-03-16 02:22:50 -07003000 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003001
3002 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3003 EXPECT_TRUE(vp9_settings.denoisingOn);
3004 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3005
3006 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003007 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003008 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003010
nisse05103312016-03-16 02:22:50 -07003011 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003012
3013 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3014 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003015 // Frame dropping always on for screen sharing.
3016 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003017
nisse05103312016-03-16 02:22:50 -07003018 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003019
3020 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3021 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003022 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003023
Niels Möllerff40b142018-04-09 08:49:14 +02003024 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003025}
3026
Sergey Silkinf18072e2018-03-14 10:35:35 +01003027TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3028 cricket::VideoSendParameters parameters;
3029 parameters.codecs.push_back(GetEngineCodec("VP9"));
3030 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3031
3032 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3033
3034 FakeVideoSendStream* stream =
3035 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3036
3037 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3038 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3039
3040 FakeVideoCapturerWithTaskQueue capturer;
3041 EXPECT_EQ(cricket::CS_RUNNING,
3042 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003043 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003044 channel_->SetSend(true);
3045
3046 EXPECT_TRUE(capturer.CaptureFrame());
3047
3048 webrtc::VideoCodecVP9 vp9_settings;
3049 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3050
3051 const size_t kNumSpatialLayers = ssrcs.size();
3052 const size_t kNumTemporalLayers = 3;
3053 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3054 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3055
Niels Möllerff40b142018-04-09 08:49:14 +02003056 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003057}
3058
asaperssonc5dabdd2016-03-21 04:15:50 -07003059class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3060 public:
brandtr468da7c2016-11-22 02:16:47 -08003061 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003062 : Vp9SettingsTest(field_trials) {}
3063
3064 protected:
3065 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3066 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003067 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003068 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3069
3070 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3071
Tommi85959932018-02-07 19:26:06 +01003072 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003073 EXPECT_EQ(cricket::CS_RUNNING,
3074 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003075 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003076 channel_->SetSend(true);
3077
3078 EXPECT_TRUE(capturer.CaptureFrame());
3079
3080 webrtc::VideoCodecVP9 vp9_settings;
3081 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3082 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3083 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3084
Niels Möllerff40b142018-04-09 08:49:14 +02003085 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003086 }
3087};
3088
3089class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3090 public:
3091 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3092};
3093
3094TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3095 const int kNumSpatialLayers = 1;
3096 const int kNumTemporalLayers = 1;
3097 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3098}
3099
3100class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3101 public:
3102 Vp9SettingsTestWithInvalidFlag()
3103 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3104};
3105
3106TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3107 const int kNumSpatialLayers = 1;
3108 const int kNumTemporalLayers = 1;
3109 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3110}
3111
3112class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3113 public:
3114 Vp9SettingsTestWith2SL3TLFlag()
3115 : Vp9SettingsTestWithFieldTrial(
3116 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3117};
3118
3119TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3120 const int kNumSpatialLayers = 2;
3121 const int kNumTemporalLayers = 3;
3122 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3123}
3124
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003125TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3126 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3127 ASSERT_EQ(1u, streams.size());
3128 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3129}
3130
3131TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3132 webrtc::test::ScopedFieldTrials override_field_trials_(
3133 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3134 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3135 ASSERT_EQ(1u, streams.size());
3136 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3137}
3138
asapersson3c81a1a2017-06-14 05:52:21 -07003139TEST_F(WebRtcVideoChannelTest,
3140 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3141 webrtc::test::ScopedFieldTrials override_field_trials_(
3142 "WebRTC-Video-BalancedDegradation/Disabled/");
3143 const bool kResolutionScalingEnabled = true;
3144 const bool kFpsScalingEnabled = false;
3145 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3146}
3147
3148TEST_F(WebRtcVideoChannelTest,
3149 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3150 webrtc::test::ScopedFieldTrials override_field_trials_(
3151 "WebRTC-Video-BalancedDegradation/Enabled/");
3152 const bool kResolutionScalingEnabled = true;
3153 const bool kFpsScalingEnabled = true;
3154 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3155}
3156
eladalonf1841382017-06-12 01:16:46 -07003157TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003158 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003159}
3160
eladalonf1841382017-06-12 01:16:46 -07003161TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003162 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003163}
3164
eladalonf1841382017-06-12 01:16:46 -07003165TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003166 TestCpuAdaptation(true, true);
3167}
3168
eladalonf1841382017-06-12 01:16:46 -07003169TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003170 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003171 cricket::VideoSendParameters parameters;
3172 parameters.codecs.push_back(codec);
3173
kthelgason2bc68642017-02-07 07:02:22 -08003174 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003175 channel_.reset(
3176 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003177 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003178 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3179
3180 AddSendStream();
3181
Tommi85959932018-02-07 19:26:06 +01003182 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003183 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003184 ASSERT_EQ(cricket::CS_RUNNING,
3185 capturer.Start(capturer.GetSupportedFormats()->front()));
3186 ASSERT_TRUE(channel_->SetSend(true));
3187
3188 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3189 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003190
Niels Möllera6cc0f92018-02-12 17:14:55 +01003191 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003192 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3193 EXPECT_EQ(1280, send_stream->GetLastWidth());
3194 EXPECT_EQ(720, send_stream->GetLastHeight());
3195
3196 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003197 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003198 wants.max_pixel_count =
3199 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003200 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003201 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003202 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3203 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3204 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3205
3206 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003207 wants.max_pixel_count =
3208 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003209 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003210 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003211 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3212 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3213 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3214
3215 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003216 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003217 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003218 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3219 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3220
3221 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003222 int current_pixel_count =
3223 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3224 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3225 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003226 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003227 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003228 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003229 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003230 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003231 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003232 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3233 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3234
sprang84a37592017-02-10 07:04:27 -08003235 // Trigger underuse again, should go back up to full resolution.
3236 current_pixel_count =
3237 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003238 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003239 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003240 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003241 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003242 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003243 EXPECT_EQ(1284, send_stream->GetLastWidth());
3244 EXPECT_EQ(724, send_stream->GetLastHeight());
3245
Niels Möllerff40b142018-04-09 08:49:14 +02003246 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003247}
3248
eladalonf1841382017-06-12 01:16:46 -07003249TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003250 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003251 cricket::VideoSendParameters parameters;
3252 parameters.codecs.push_back(codec);
3253
kthelgason2bc68642017-02-07 07:02:22 -08003254 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003255 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003256 channel_.reset(
3257 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003258 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003259 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3260
3261 AddSendStream();
3262
Tommi85959932018-02-07 19:26:06 +01003263 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003264 ASSERT_EQ(cricket::CS_RUNNING,
3265 capturer.Start(capturer.GetSupportedFormats()->front()));
3266 ASSERT_TRUE(channel_->SetSend(true));
3267 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003268 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003269 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003270
3271 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3272 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003273
Niels Möllera6cc0f92018-02-12 17:14:55 +01003274 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003275 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3276 EXPECT_EQ(1280, send_stream->GetLastWidth());
3277 EXPECT_EQ(720, send_stream->GetLastHeight());
3278
3279 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003280 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003281 wants.max_pixel_count =
3282 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003283 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003284 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003285 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3286 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3287 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3288
3289 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003290 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003291 ASSERT_EQ(cricket::CS_RUNNING,
3292 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003293 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003294 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003295 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003296 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003297 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3298 send_stream = fake_call_->GetVideoSendStreams().front();
3299 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003300 EXPECT_EQ(1284, send_stream->GetLastWidth());
3301 EXPECT_EQ(724, send_stream->GetLastHeight());
3302
3303 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003304 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003305 send_stream = fake_call_->GetVideoSendStreams().front();
3306 // We have a new fake send stream, so it doesn't remember the old sink wants.
3307 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003308 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003309 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003310 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003311 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3312 send_stream = fake_call_->GetVideoSendStreams().front();
3313 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003314 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3315 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3316
Niels Möllerff40b142018-04-09 08:49:14 +02003317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003318}
3319
asapersson3c81a1a2017-06-14 05:52:21 -07003320// TODO(asapersson): Remove this test when the balanced field trial is removed.
3321void WebRtcVideoChannelTest::TestDegradationPreference(
3322 bool resolution_scaling_enabled,
3323 bool fps_scaling_enabled) {
3324 cricket::VideoCodec codec = GetEngineCodec("VP8");
3325 cricket::VideoSendParameters parameters;
3326 parameters.codecs.push_back(codec);
3327
3328 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003329 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003330 channel_.reset(
3331 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3332 channel_->OnReadyToSend(true);
3333
3334 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3335
3336 AddSendStream();
3337
Tommi85959932018-02-07 19:26:06 +01003338 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003339 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003340 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003341 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3342 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3343
3344 EXPECT_TRUE(channel_->SetSend(true));
3345
3346 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3347 EXPECT_EQ(resolution_scaling_enabled,
3348 send_stream->resolution_scaling_enabled());
3349 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3350
Niels Möllerff40b142018-04-09 08:49:14 +02003351 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003352}
3353
eladalonf1841382017-06-12 01:16:46 -07003354void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3355 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003356 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003357 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003358 cricket::VideoSendParameters parameters;
3359 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003360
kthelgason2bc68642017-02-07 07:02:22 -08003361 MediaConfig media_config = GetMediaConfig();
3362 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003363 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003364 }
nisse51542be2016-02-12 02:27:06 -08003365 channel_.reset(
3366 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003367 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003368
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003369 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003370
3371 AddSendStream();
3372
Tommi85959932018-02-07 19:26:06 +01003373 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003374 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003375 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003376 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003377 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003378 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003379 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003380
3381 EXPECT_TRUE(channel_->SetSend(true));
3382
solenberge5269742015-09-08 05:13:22 -07003383 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003384
sprangc5d62e22017-04-02 23:53:04 -07003385 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003386 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003387 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3388 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003389
3390 EXPECT_TRUE(capturer.CaptureFrame());
3391 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3392
perkj26752742016-10-24 01:21:16 -07003393 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3394 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003395
Niels Möllerff40b142018-04-09 08:49:14 +02003396 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003397 return;
3398 }
3399
sprangc5d62e22017-04-02 23:53:04 -07003400 if (is_screenshare) {
3401 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3402 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3403 } else {
3404 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3405 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3406 }
3407
perkj803d97f2016-11-01 11:45:46 -07003408 // Trigger overuse.
3409 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3410
3411 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003412 if (is_screenshare) {
3413 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3414 } else {
3415 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3416 }
perkj803d97f2016-11-01 11:45:46 -07003417 send_stream->InjectVideoSinkWants(wants);
3418
sprangc5d62e22017-04-02 23:53:04 -07003419 for (int i = 0; i < kDefaultFps; ++i)
3420 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003421
sprangc5d62e22017-04-02 23:53:04 -07003422 if (is_screenshare) {
3423 // Drops every third frame.
3424 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3425 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3426 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3427 } else {
3428 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3429 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3430 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3431 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003432
3433 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003434 int last_pixel_count =
3435 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003436 if (is_screenshare) {
3437 wants.max_framerate_fps = kDefaultFps;
3438 } else {
3439 wants.max_pixel_count = last_pixel_count * 4;
3440 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3441 }
perkj803d97f2016-11-01 11:45:46 -07003442 send_stream->InjectVideoSinkWants(wants);
3443
sprangc5d62e22017-04-02 23:53:04 -07003444 for (int i = 0; i < kDefaultFps; ++i)
3445 EXPECT_TRUE(capturer.CaptureFrame());
3446
3447 if (is_screenshare) {
3448 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3449 send_stream->GetNumberOfSwappedFrames());
3450 } else {
3451 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3452 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003453
perkj26752742016-10-24 01:21:16 -07003454 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3455 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003456
Niels Möllerff40b142018-04-09 08:49:14 +02003457 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003458}
3459
eladalonf1841382017-06-12 01:16:46 -07003460TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003461 // Start at last timestamp to verify that wraparounds are estimated correctly.
3462 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3463 static const int64_t kInitialNtpTimeMs = 1247891230;
3464 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003465 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003466
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003467 FakeVideoReceiveStream* stream = AddRecvStream();
3468 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003469 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003470
nisse64ec8f82016-09-27 00:17:25 -07003471 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3472 kInitialTimestamp, 0,
3473 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003474 // Initial NTP time is not available on the first frame, but should still be
3475 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003476 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003477
3478 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003479
3480 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3481 // triggers a constant-overflow warning, hence we're calculating it explicitly
3482 // here.
3483 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3484 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003485 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003486
3487 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003488
3489 // Verify that NTP time has been correctly deduced.
3490 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003491 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003492 ASSERT_EQ(1u, info.receivers.size());
3493 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003494}
3495
eladalonf1841382017-06-12 01:16:46 -07003496TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003497 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003498 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003499
3500 VideoCodec codec;
3501 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003502 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003503
3504 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003505 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3506 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003507 FakeVideoSendStream* stream = AddSendStream(
3508 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003509 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003510
3511 // Make sure NACK and FEC are enabled on the correct payload types.
3512 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003513 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3514 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003515
3516 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3517 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003518 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003519 // TODO(juberti): Check RTCP, PLI, TMMBR.
3520}
3521
brandtr31bd2242017-05-19 05:47:46 -07003522// The following four tests ensures that FlexFEC is not activated by default
3523// when the field trials are not enabled.
3524// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3525// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003526TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003527 FakeVideoSendStream* stream = AddSendStream();
3528 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3529
brandtr3d200bd2017-01-16 06:59:19 -08003530 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003531 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3532 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003533}
3534
eladalonf1841382017-06-12 01:16:46 -07003535TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003536 FakeVideoSendStream* stream = AddSendStream(
3537 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3538 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3539
brandtr3d200bd2017-01-16 06:59:19 -08003540 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003541 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3542 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3543}
3544
Yves Gerey665174f2018-06-19 15:03:05 +02003545TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003546 AddRecvStream();
3547
3548 const std::vector<FakeFlexfecReceiveStream*>& streams =
3549 fake_call_->GetFlexfecReceiveStreams();
3550 EXPECT_TRUE(streams.empty());
3551}
3552
eladalonf1841382017-06-12 01:16:46 -07003553TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003554 AddRecvStream(
3555 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3556
3557 const std::vector<FakeFlexfecReceiveStream*>& streams =
3558 fake_call_->GetFlexfecReceiveStreams();
3559 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003560}
3561
3562// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3563// tests that use this test fixture into the corresponding "non-field trial"
3564// tests.
eladalonf1841382017-06-12 01:16:46 -07003565class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003566 public:
eladalonf1841382017-06-12 01:16:46 -07003567 WebRtcVideoChannelFlexfecRecvTest()
3568 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003569};
3570
eladalonf1841382017-06-12 01:16:46 -07003571TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003572 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3573 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3574 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3575}
3576
eladalonf1841382017-06-12 01:16:46 -07003577TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003578 AddRecvStream();
3579
3580 const std::vector<FakeFlexfecReceiveStream*>& streams =
3581 fake_call_->GetFlexfecReceiveStreams();
3582 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003583
3584 const std::vector<FakeVideoReceiveStream*>& video_streams =
3585 fake_call_->GetVideoReceiveStreams();
3586 ASSERT_EQ(1U, video_streams.size());
3587 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3588 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3589 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003590}
3591
eladalonf1841382017-06-12 01:16:46 -07003592TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003593 AddRecvStream(
3594 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3595
3596 const std::vector<FakeFlexfecReceiveStream*>& streams =
3597 fake_call_->GetFlexfecReceiveStreams();
3598 ASSERT_EQ(1U, streams.size());
3599 const FakeFlexfecReceiveStream* stream = streams.front();
3600 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3601 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3602 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3603 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3604 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003605
3606 const std::vector<FakeVideoReceiveStream*>& video_streams =
3607 fake_call_->GetVideoReceiveStreams();
3608 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003609 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3610 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003611 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003612 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003613 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003614}
3615
eladalonf1841382017-06-12 01:16:46 -07003616TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003617 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3618 cricket::VideoRecvParameters recv_parameters;
3619 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3620 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3621
3622 AddRecvStream(
3623 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3624 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003625 const std::vector<FakeVideoReceiveStream*>& video_streams =
3626 fake_call_->GetVideoReceiveStreams();
3627 ASSERT_EQ(1U, video_streams.size());
3628 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3629 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3630 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003631
3632 // Enable FlexFEC.
3633 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3634 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3635 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3636 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3637 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3638 << "Enabling FlexFEC should not create VideoReceiveStream.";
3639 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3640 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003641 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3642 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003643}
3644
eladalonf1841382017-06-12 01:16:46 -07003645TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003646 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3647 cricket::VideoRecvParameters recv_parameters;
3648 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3649 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3650 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3651
3652 AddRecvStream(
3653 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3654 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003655 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003656 const std::vector<FakeVideoReceiveStream*>& video_streams =
3657 fake_call_->GetVideoReceiveStreams();
3658 ASSERT_EQ(1U, video_streams.size());
3659 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3660 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3661 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003662
3663 // Disable FlexFEC.
3664 recv_parameters.codecs.clear();
3665 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3666 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3667 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3668 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3669 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3670 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3671 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3672 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003673 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3674 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003675}
3676
brandtr31bd2242017-05-19 05:47:46 -07003677// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3678// tests that use this test fixture into the corresponding "non-field trial"
3679// tests.
eladalonf1841382017-06-12 01:16:46 -07003680class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003681 public:
eladalonf1841382017-06-12 01:16:46 -07003682 WebRtcVideoChannelFlexfecSendRecvTest()
3683 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003684 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3685 }
3686};
3687
Yves Gerey665174f2018-06-19 15:03:05 +02003688TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003689 FakeVideoSendStream* stream = AddSendStream();
3690 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3691
brandtr3d200bd2017-01-16 06:59:19 -08003692 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3693 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3694 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003698 FakeVideoSendStream* stream = AddSendStream(
3699 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3700 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3701
brandtr3d200bd2017-01-16 06:59:19 -08003702 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3703 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3704 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3705 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003706}
3707
eladalonf1841382017-06-12 01:16:46 -07003708TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003709 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003710 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003711 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003712
3713 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003714 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003715
brandtrb5f2c3f2016-10-04 23:28:39 -07003716 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3717 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003718}
3719
eladalonf1841382017-06-12 01:16:46 -07003720TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003721 cricket::VideoSendParameters parameters;
3722 parameters.codecs.push_back(GetEngineCodec("VP8"));
3723 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3724
3725 FakeVideoSendStream* stream = AddSendStream();
3726 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3727
brandtr3d200bd2017-01-16 06:59:19 -08003728 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003729}
3730
eladalonf1841382017-06-12 01:16:46 -07003731TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003732 AddRecvStream(
3733 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003734
3735 cricket::VideoRecvParameters recv_parameters;
3736 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3737 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3738 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003739
3740 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3741 fake_call_->GetFlexfecReceiveStreams();
3742 ASSERT_EQ(1U, flexfec_streams.size());
3743 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3744 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3745 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003746 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003747 flexfec_stream_config.payload_type);
3748 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3749 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3750 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3751 const std::vector<FakeVideoReceiveStream*>& video_streams =
3752 fake_call_->GetVideoReceiveStreams();
3753 const FakeVideoReceiveStream* video_stream = video_streams.front();
3754 const webrtc::VideoReceiveStream::Config& video_stream_config =
3755 video_stream->GetConfig();
3756 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3757 flexfec_stream_config.local_ssrc);
3758 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3759 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3760 flexfec_stream_config.rtcp_send_transport);
3761 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3762 // spec-compliant way.
3763 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3764 flexfec_stream_config.transport_cc);
3765 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3766 EXPECT_EQ(video_stream_config.rtp.extensions,
3767 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003768}
3769
brandtr31bd2242017-05-19 05:47:46 -07003770// We should not send FlexFEC, even if we advertise it, unless the right
3771// field trial is set.
3772// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003773TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003774 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3775 cricket::VideoSendParameters parameters;
3776 parameters.codecs.push_back(GetEngineCodec("VP8"));
3777 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3778 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3779
3780 FakeVideoSendStream* stream = AddSendStream();
3781 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3782
3783 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003784 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003785 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3786}
3787
eladalonf1841382017-06-12 01:16:46 -07003788TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003789 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3790 cricket::VideoSendParameters parameters;
3791 parameters.codecs.push_back(GetEngineCodec("VP8"));
3792 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3793 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3794
3795 FakeVideoSendStream* stream = AddSendStream(
3796 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3797 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3798
3799 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003800 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003801 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3802}
3803
eladalonf1841382017-06-12 01:16:46 -07003804TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003805 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003806 const int kUnusedPayloadType = 127;
3807 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3808
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003809 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003810 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003811 parameters.codecs.push_back(rtx_codec);
3812 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003813 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003814}
3815
eladalonf1841382017-06-12 01:16:46 -07003816TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003817 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003818 const int kUnusedPayloadType1 = 126;
3819 const int kUnusedPayloadType2 = 127;
3820 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3821 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3822 {
3823 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3824 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3825 cricket::VideoSendParameters parameters;
3826 parameters.codecs.push_back(GetEngineCodec("VP8"));
3827 parameters.codecs.push_back(rtx_codec);
3828 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3829 }
3830 {
3831 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3832 kUnusedPayloadType1, kUnusedPayloadType2);
3833 cricket::VideoSendParameters parameters;
3834 parameters.codecs.push_back(GetEngineCodec("VP8"));
3835 parameters.codecs.push_back(rtx_codec);
3836 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3837 << "RTX without matching video codec should be rejected.";
3838 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003839}
3840
eladalonf1841382017-06-12 01:16:46 -07003841TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003842 const int kUnusedPayloadType1 = 126;
3843 const int kUnusedPayloadType2 = 127;
3844 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3845 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3846
3847 // SSRCs for RTX.
3848 cricket::StreamParams params =
3849 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3850 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3851 AddSendStream(params);
3852
3853 // Original payload type for RTX.
3854 cricket::VideoSendParameters parameters;
3855 parameters.codecs.push_back(GetEngineCodec("VP8"));
3856 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3857 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3858 parameters.codecs.push_back(rtx_codec);
3859 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3860 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3861 const webrtc::VideoSendStream::Config& config_before =
3862 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3863 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3864 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3865 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3866
3867 // Change payload type for RTX.
3868 parameters.codecs[1].id = kUnusedPayloadType2;
3869 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3870 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3871 const webrtc::VideoSendStream::Config& config_after =
3872 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3873 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3874 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3875 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3876}
3877
eladalonf1841382017-06-12 01:16:46 -07003878TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003879 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003880 parameters.codecs.push_back(GetEngineCodec("VP8"));
3881 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003883
3884 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003885 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003886
magjed509e4fe2016-11-18 01:34:11 -08003887 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003888
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003889 parameters.codecs.pop_back();
3890 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003891 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003892 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003893 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003894 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003895 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3896}
3897
eladalonf1841382017-06-12 01:16:46 -07003898TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003899 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003900 cricket::VideoSendParameters parameters;
3901 parameters.codecs.push_back(GetEngineCodec("VP8"));
3902 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3903 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3904
3905 FakeVideoSendStream* stream = AddSendStream(
3906 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3907 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3908
brandtr3d200bd2017-01-16 06:59:19 -08003909 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3910 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003911 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3912 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3913
3914 parameters.codecs.pop_back();
3915 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3916 stream = fake_call_->GetVideoSendStreams()[0];
3917 ASSERT_TRUE(stream != nullptr);
3918 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003919 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003920 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003921}
3922
eladalonf1841382017-06-12 01:16:46 -07003923TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003924 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003925 cricket::VideoCodec codec(100, "VP8");
3926 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3927 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003928
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003929 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003930 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003931
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003932 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003933 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003934 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003935
3936 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003937 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003938
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003939 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003940 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3941 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003942 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003943 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003944 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003945 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003946}
3947
eladalonf1841382017-06-12 01:16:46 -07003948TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003949 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3950 200000);
3951}
3952
eladalonf1841382017-06-12 01:16:46 -07003953TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003954 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3955 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3956 ASSERT_EQ(1u, streams.size());
3957 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3958}
3959
eladalonf1841382017-06-12 01:16:46 -07003960TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003961 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003962 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003963}
3964
eladalonf1841382017-06-12 01:16:46 -07003965TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003966 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003967}
3968
eladalonf1841382017-06-12 01:16:46 -07003969TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003970 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3971 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3972 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003973}
3974
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003975// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3976// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003977TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003978 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3979 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3980 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3981 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003982 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003983 ExpectSetBitrateParameters(100000, 200000, 400000);
3984 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3985 // Since the codec isn't changing, start_bitrate_bps should be -1.
3986 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003987
3988 // Decrease max_bandwidth_bps.
3989 send_parameters_.max_bandwidth_bps = 350000;
3990 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003991
3992 // Now try again with the values flipped around.
3993 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3994 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003995 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003996 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003997
3998 // If we change the codec max, max_bandwidth_bps should still apply.
3999 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004000 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004001 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004002}
4003
Yves Gerey665174f2018-06-19 15:03:05 +02004004TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004005 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4006 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004007 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004008 // Setting max bitrate should keep previous min bitrate.
4009 // Setting max bitrate should not reset start bitrate.
4010 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004011 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004012}
4013
eladalonf1841382017-06-12 01:16:46 -07004014TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004015 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004016 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004017 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004018 // -1 means to disable max bitrate (set infinite).
4019 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004020 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004021 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004022}
4023
eladalonf1841382017-06-12 01:16:46 -07004024TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004025 send_parameters_.max_bandwidth_bps = 99999;
4026 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004027 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004028 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004029 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4030 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4031 stream->GetVideoStreams()[0].max_bitrate_bps);
4032
4033 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004034 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004035 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4036 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004037 stream->GetVideoStreams()[0].max_bitrate_bps);
4038}
4039
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004040// Tests that when the codec specific max bitrate and VideoSendParameters
4041// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4042// appropriately.
4043TEST_F(WebRtcVideoChannelTest,
4044 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4045 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4046 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4047 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4048 send_parameters_.max_bandwidth_bps = -1;
4049 AddSendStream();
4050 ExpectSetMaxBitrate(300000);
4051 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4052
4053 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4054 ASSERT_EQ(1u, video_send_streams.size());
4055 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4056 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4057 // First the max bitrate is set based upon the codec param.
4058 EXPECT_EQ(300000,
4059 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4060
4061 // The VideoSendParameters max bitrate overrides the codec's.
4062 send_parameters_.max_bandwidth_bps = 500000;
4063 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4064 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4065 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4066 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4067}
4068
4069// Tests that when the codec specific max bitrate and RtpParameters
4070// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4071// appropriately.
4072TEST_F(WebRtcVideoChannelTest,
4073 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4074 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4075 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4076 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4077 send_parameters_.max_bandwidth_bps = -1;
4078 AddSendStream();
4079 ExpectSetMaxBitrate(300000);
4080 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4081
4082 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4083 ASSERT_EQ(1u, video_send_streams.size());
4084 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4085 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4086 // First the max bitrate is set based upon the codec param.
4087 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4088
4089 // The RtpParameter max bitrate overrides the codec's.
4090 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4091 ASSERT_EQ(1u, parameters.encodings.size());
4092 parameters.encodings[0].max_bitrate_bps = 500000;
4093 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4094 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4095 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4096 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4097}
4098
Åsa Persson55659812018-06-18 17:51:32 +02004099TEST_F(WebRtcVideoChannelTest,
4100 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4101 send_parameters_.max_bandwidth_bps = 99999;
4102 FakeVideoSendStream* stream = AddSendStream();
4103 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4104 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4105 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4106 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4107 stream->GetVideoStreams()[0].max_bitrate_bps);
4108
4109 // Get and set the rtp encoding parameters.
4110 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4111 EXPECT_EQ(1u, parameters.encodings.size());
4112
4113 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4114 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4115 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4116 stream->GetVideoStreams()[0].max_bitrate_bps);
4117
4118 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4119 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4120 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4121 stream->GetVideoStreams()[0].max_bitrate_bps);
4122}
4123
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004125 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004126 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004127 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004128 channel_->SetSend(true);
4129
4130 FakeVideoSendStream* stream = AddSendStream();
4131
Tommi85959932018-02-07 19:26:06 +01004132 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004133 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004134 EXPECT_EQ(cricket::CS_RUNNING,
4135 capturer.Start(capturer.GetSupportedFormats()->front()));
4136
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004137 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4138 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4139 EXPECT_GT(initial_max_bitrate_bps, 0);
4140
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004141 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4142 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004143 // Insert a frame to update the encoder config.
4144 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004145 streams = stream->GetVideoStreams();
4146 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004147 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004148}
4149
eladalonf1841382017-06-12 01:16:46 -07004150TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004151 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004152 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004153 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004154 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004155 channel_->SetSend(true);
4156
4157 FakeVideoSendStream* stream = AddSendStream(
4158 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4159
4160 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004161 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004162 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004163 EXPECT_EQ(cricket::CS_RUNNING,
4164 capturer.Start(capturer.GetSupportedFormats()->front()));
4165 EXPECT_TRUE(capturer.CaptureFrame());
4166
4167 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4168 ASSERT_GT(streams.size(), 1u)
4169 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004170 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004171 EXPECT_GT(initial_max_bitrate_bps, 0);
4172
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004173 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4174 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004175 // Insert a frame to update the encoder config.
4176 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004177 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004178 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004179 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4180
Niels Möllerff40b142018-04-09 08:49:14 +02004181 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004182}
4183
eladalonf1841382017-06-12 01:16:46 -07004184TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004185 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004186 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004187 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4189 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004190 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004191 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004192
4193 VideoCodec codec;
4194 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4195 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4196}
4197
eladalonf1841382017-06-12 01:16:46 -07004198TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004199 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004200 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004201 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004202 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004203 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004204 parameters.codecs[0].id = kIncorrectPayloads[i];
4205 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004206 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004207 }
4208}
4209
eladalonf1841382017-06-12 01:16:46 -07004210TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004211 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004212 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004213 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004214 parameters.codecs[0].id = payload_type;
4215 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004216 << "Payload type '" << payload_type << "' rejected.";
4217 }
4218}
4219
deadbeef67cf2c12016-04-13 10:07:16 -07004220// Test that setting the a different set of codecs but with an identical front
4221// codec doesn't result in the stream being recreated.
4222// This may happen when a subsequent negotiation includes fewer codecs, as a
4223// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004224TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004225 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4226 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004227 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4228 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004229 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4230
4231 AddSendStream();
4232 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4233
4234 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004235 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004236 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4237 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4238}
4239
eladalonf1841382017-06-12 01:16:46 -07004240TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004241 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004242 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004244}
4245
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004246// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004247TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004248 const int kUnusedPayloadType1 = 126;
4249 const int kUnusedPayloadType2 = 127;
4250 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4251 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4252
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004254 parameters.codecs.push_back(GetEngineCodec("VP8"));
4255 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 parameters.codecs.push_back(rtx_codec);
4257 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004258 << "RTX codec without associated payload should be rejected.";
4259
magjed509e4fe2016-11-18 01:34:11 -08004260 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004261 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004262 << "RTX codec with invalid associated payload type should be rejected.";
4263
magjed509e4fe2016-11-18 01:34:11 -08004264 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004266
magjed509e4fe2016-11-18 01:34:11 -08004267 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004268 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004269 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004270
Yves Gerey665174f2018-06-19 15:03:05 +02004271 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4272 << "RTX codec with another RTX as associated payload type should be "
4273 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004274}
4275
eladalonf1841382017-06-12 01:16:46 -07004276TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004277 const int kUnusedPayloadType1 = 126;
4278 const int kUnusedPayloadType2 = 127;
4279 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4280 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4281
4282 // SSRCs for RTX.
4283 cricket::StreamParams params =
4284 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4285 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4286 AddRecvStream(params);
4287
4288 // Original payload type for RTX.
4289 cricket::VideoRecvParameters parameters;
4290 parameters.codecs.push_back(GetEngineCodec("VP8"));
4291 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4292 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4293 parameters.codecs.push_back(rtx_codec);
4294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4295 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4296 const webrtc::VideoReceiveStream::Config& config_before =
4297 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004298 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4299 const int* payload_type_before = FindKeyByValue(
4300 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4301 ASSERT_NE(payload_type_before, nullptr);
4302 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004303 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4304
4305 // Change payload type for RTX.
4306 parameters.codecs[1].id = kUnusedPayloadType2;
4307 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4308 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4309 const webrtc::VideoReceiveStream::Config& config_after =
4310 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004311 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4312 const int* payload_type_after = FindKeyByValue(
4313 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4314 ASSERT_NE(payload_type_after, nullptr);
4315 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004316 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4317}
4318
eladalonf1841382017-06-12 01:16:46 -07004319TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004321 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004322 parameters.codecs[0].id = 99;
4323 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004324}
4325
eladalonf1841382017-06-12 01:16:46 -07004326TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004327 cricket::VideoRecvParameters parameters;
4328 parameters.codecs = engine_.codecs();
4329 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004330
4331 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004332 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004333 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
4334 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004335}
4336
eladalonf1841382017-06-12 01:16:46 -07004337TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004338 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004339 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004340 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004341 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004342}
4343
eladalonf1841382017-06-12 01:16:46 -07004344TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004345 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004346 parameters.codecs.push_back(GetEngineCodec("VP8"));
4347 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004348 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004349}
4350
eladalonf1841382017-06-12 01:16:46 -07004351TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004352 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004353 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4354 send_parameters.codecs.push_back(GetEngineCodec("red"));
4355 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004356 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004357
4358 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004359
magjed509e4fe2016-11-18 01:34:11 -08004360 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004361 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004362
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004363 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004364 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004366 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004367 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004368 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004369 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4370}
4371
eladalonf1841382017-06-12 01:16:46 -07004372TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004373 AddRecvStream(
4374 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004375 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004376 fake_call_->GetFlexfecReceiveStreams();
4377
4378 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004379 const FakeFlexfecReceiveStream* stream = streams.front();
4380 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4381 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4382 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4383 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004384
4385 cricket::VideoRecvParameters recv_parameters;
4386 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4387 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4388 EXPECT_TRUE(streams.empty())
4389 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004390}
4391
eladalonf1841382017-06-12 01:16:46 -07004392TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004393 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004394 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004395 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004396
4397 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4399 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4400 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004401 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4402 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004403 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004404 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004405 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004406 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004407
4408 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004409 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4410 send_parameters.codecs.push_back(GetEngineCodec("red"));
4411 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004412 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4413 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004414 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004415 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004416 << "ULPFEC should be enabled on the receive stream.";
4417}
4418
eladalonf1841382017-06-12 01:16:46 -07004419TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004420 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004421 AddRecvStream(
4422 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004423 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004424 fake_call_->GetFlexfecReceiveStreams();
4425
4426 cricket::VideoRecvParameters recv_parameters;
4427 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4428 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4429 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4430 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004431 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004432 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004433 stream_with_recv_params->GetConfig().payload_type);
4434 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004435 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004436 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004437 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004438 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004439
4440 cricket::VideoSendParameters send_parameters;
4441 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4442 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4443 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4444 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004445 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004446 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004447 stream_with_send_params->GetConfig().payload_type);
4448 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004449 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004450 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004451 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004452 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004453}
4454
eladalonf1841382017-06-12 01:16:46 -07004455TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004456 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004457 parameters.codecs.push_back(GetEngineCodec("VP8"));
4458 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004459 parameters.codecs[1].id = parameters.codecs[0].id;
4460 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004461}
4462
eladalonf1841382017-06-12 01:16:46 -07004463TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004464 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004465 cricket::VideoRecvParameters parameters;
4466 parameters.codecs.push_back(GetEngineCodec("VP8"));
4467 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4468 parameters.codecs[1].id = parameters.codecs[0].id;
4469 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4470}
4471
eladalonf1841382017-06-12 01:16:46 -07004472TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004473 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004474 parameters.codecs.push_back(GetEngineCodec("VP8"));
4475 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004476 parameters.codecs[1].id = parameters.codecs[0].id;
4477 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004478}
4479
eladalonf1841382017-06-12 01:16:46 -07004480TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004481 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004482 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004483 parameters.codecs.push_back(GetEngineCodec("VP8"));
4484 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004485 parameters.codecs[1].id += 1;
4486 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004487}
4488
deadbeef67cf2c12016-04-13 10:07:16 -07004489// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004490// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004491TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004492 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004493 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004494 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4495 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004496 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004497
4498 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4499 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4500
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004501 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004502 parameters2.codecs.push_back(GetEngineCodec("red"));
4503 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004504 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004505 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4506}
4507
eladalonf1841382017-06-12 01:16:46 -07004508TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004509 EXPECT_FALSE(AddSendStream()->IsSending());
4510}
4511
eladalonf1841382017-06-12 01:16:46 -07004512TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004513 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004514}
4515
eladalonf1841382017-06-12 01:16:46 -07004516TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004517 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004518 EXPECT_FALSE(stream->IsSending());
4519
4520 // false->true
4521 EXPECT_TRUE(channel_->SetSend(true));
4522 EXPECT_TRUE(stream->IsSending());
4523 // true->true
4524 EXPECT_TRUE(channel_->SetSend(true));
4525 EXPECT_TRUE(stream->IsSending());
4526 // true->false
4527 EXPECT_TRUE(channel_->SetSend(false));
4528 EXPECT_FALSE(stream->IsSending());
4529 // false->false
4530 EXPECT_TRUE(channel_->SetSend(false));
4531 EXPECT_FALSE(stream->IsSending());
4532
4533 EXPECT_TRUE(channel_->SetSend(true));
4534 FakeVideoSendStream* new_stream = AddSendStream();
4535 EXPECT_TRUE(new_stream->IsSending())
4536 << "Send stream created after SetSend(true) not sending initially.";
4537}
4538
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004539// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004540TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004541 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004542 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004543 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004544 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004545
4546 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4547 channel->SetInterface(network_interface.get());
4548 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004549 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004550
4551 config.enable_dscp = true;
4552 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4553 channel->SetInterface(network_interface.get());
4554 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4555
4556 // Verify that setting the option to false resets the
4557 // DiffServCodePoint.
4558 config.enable_dscp = false;
4559 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4560 channel->SetInterface(network_interface.get());
4561 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004562}
4563
deadbeef13871492015-12-09 12:37:51 -08004564// This test verifies that the RTCP reduced size mode is properly applied to
4565// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004566TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004567 // Create stream, expecting that default mode is "compound".
4568 FakeVideoSendStream* stream1 = AddSendStream();
4569 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004570 webrtc::RtpParameters rtp_parameters =
4571 channel_->GetRtpSendParameters(last_ssrc_);
4572 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004573
4574 // Now enable reduced size mode.
4575 send_parameters_.rtcp.reduced_size = true;
4576 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4577 stream1 = fake_call_->GetVideoSendStreams()[0];
4578 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004579 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4580 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004581
4582 // Create a new stream and ensure it picks up the reduced size mode.
4583 FakeVideoSendStream* stream2 = AddSendStream();
4584 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4585}
4586
4587// This test verifies that the RTCP reduced size mode is properly applied to
4588// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004589TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004590 // Create stream, expecting that default mode is "compound".
4591 FakeVideoReceiveStream* stream1 = AddRecvStream();
4592 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4593
4594 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004595 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4596 // the reduced_size flag should come from that.
4597 send_parameters_.rtcp.reduced_size = true;
4598 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004599 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4600 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4601
4602 // Create a new stream and ensure it picks up the reduced size mode.
4603 FakeVideoReceiveStream* stream2 = AddRecvStream();
4604 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4605}
4606
eladalonf1841382017-06-12 01:16:46 -07004607TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004608 EXPECT_EQ(webrtc::kNetworkUp,
4609 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4610 EXPECT_EQ(webrtc::kNetworkUp,
4611 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004612
4613 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004614 EXPECT_EQ(webrtc::kNetworkDown,
4615 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4616 EXPECT_EQ(webrtc::kNetworkUp,
4617 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004618
4619 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004620 EXPECT_EQ(webrtc::kNetworkUp,
4621 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4622 EXPECT_EQ(webrtc::kNetworkUp,
4623 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004624}
4625
eladalonf1841382017-06-12 01:16:46 -07004626TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004627 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004628 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004629 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004630
4631 AddSendStream();
4632
4633 cricket::VideoMediaInfo info;
4634 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004635 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004636}
4637
eladalonf1841382017-06-12 01:16:46 -07004638TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004639 FakeVideoSendStream* stream = AddSendStream();
4640 webrtc::VideoSendStream::Stats stats;
4641 stats.encoder_implementation_name = "encoder_implementation_name";
4642 stream->SetStats(stats);
4643
4644 cricket::VideoMediaInfo info;
4645 ASSERT_TRUE(channel_->GetStats(&info));
4646 EXPECT_EQ(stats.encoder_implementation_name,
4647 info.senders[0].encoder_implementation_name);
4648}
4649
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004651 FakeVideoSendStream* stream = AddSendStream();
4652 webrtc::VideoSendStream::Stats stats;
4653 stats.avg_encode_time_ms = 13;
4654 stats.encode_usage_percent = 42;
4655 stream->SetStats(stats);
4656
4657 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004658 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004659 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4660 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4661}
4662
eladalonf1841382017-06-12 01:16:46 -07004663TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004664 FakeVideoSendStream* stream = AddSendStream();
4665 webrtc::VideoSendStream::Stats stats;
4666 stats.frames_encoded = 13;
4667 stream->SetStats(stats);
4668
4669 cricket::VideoMediaInfo info;
4670 ASSERT_TRUE(channel_->GetStats(&info));
4671 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4672}
4673
eladalonf1841382017-06-12 01:16:46 -07004674TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004675 FakeVideoSendStream* stream = AddSendStream();
4676 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004677 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004678 stream->SetStats(stats);
4679
4680 cricket::VideoMediaInfo info;
4681 ASSERT_TRUE(channel_->GetStats(&info));
4682 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4683}
4684
eladalonf1841382017-06-12 01:16:46 -07004685TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004686 FakeVideoSendStream* stream = AddSendStream();
4687 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004688 stats.substreams[17].width = 123;
4689 stats.substreams[17].height = 40;
4690 stats.substreams[42].width = 80;
4691 stats.substreams[42].height = 31;
4692 stats.substreams[11].width = 20;
4693 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004694 stream->SetStats(stats);
4695
4696 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004697 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004698 ASSERT_EQ(1u, info.senders.size());
4699 EXPECT_EQ(123, info.senders[0].send_frame_width);
4700 EXPECT_EQ(90, info.senders[0].send_frame_height);
4701}
4702
eladalonf1841382017-06-12 01:16:46 -07004703TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004704 FakeVideoSendStream* stream = AddSendStream();
4705 webrtc::VideoSendStream::Stats stats;
4706 stats.number_of_cpu_adapt_changes = 2;
4707 stats.cpu_limited_resolution = true;
4708 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004709
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004710 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004711 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004712 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004713 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004714 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004715}
4716
eladalonf1841382017-06-12 01:16:46 -07004717TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004718 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004719 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004720 stats.number_of_cpu_adapt_changes = 2;
4721 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004722 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004723 stream->SetStats(stats);
4724
4725 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004726 EXPECT_TRUE(channel_->GetStats(&info));
4727 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004728 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4729 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004730 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004731 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004735 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4736 FakeVideoSendStream* stream = AddSendStream();
4737 webrtc::VideoSendStream::Stats stats;
4738 stats.bw_limited_resolution = true;
4739 stream->SetStats(stats);
4740
4741 cricket::VideoMediaInfo info;
4742 EXPECT_TRUE(channel_->GetStats(&info));
4743 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004744 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004745 info.senders[0].adapt_reason);
4746}
4747
Yves Gerey665174f2018-06-19 15:03:05 +02004748TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004749 FakeVideoSendStream* stream = AddSendStream();
4750 webrtc::VideoSendStream::Stats stats;
4751 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4752 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4753 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4754
4755 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4756 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4757 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4758
4759 stream->SetStats(stats);
4760
4761 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004762 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004763 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4764 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4765 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4766}
4767
eladalonf1841382017-06-12 01:16:46 -07004768TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004769 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4770 FakeVideoReceiveStream* stream = AddRecvStream();
4771 webrtc::VideoReceiveStream::Stats stats;
4772 stats.rtcp_packet_type_counts.fir_packets = 2;
4773 stats.rtcp_packet_type_counts.nack_packets = 3;
4774 stats.rtcp_packet_type_counts.pli_packets = 4;
4775 stream->SetStats(stats);
4776
4777 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004778 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004779 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004780 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004781 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004782 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004783 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004784 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004785}
4786
eladalonf1841382017-06-12 01:16:46 -07004787TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004788 FakeVideoReceiveStream* stream = AddRecvStream();
4789 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004790 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004791 stats.decode_ms = 2;
4792 stats.max_decode_ms = 3;
4793 stats.current_delay_ms = 4;
4794 stats.target_delay_ms = 5;
4795 stats.jitter_buffer_ms = 6;
4796 stats.min_playout_delay_ms = 7;
4797 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004798 stats.width = 9;
4799 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004800 stats.frame_counts.key_frames = 11;
4801 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004802 stats.frames_rendered = 13;
4803 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004804 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004805 stream->SetStats(stats);
4806
4807 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004808 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004809 EXPECT_EQ(stats.decoder_implementation_name,
4810 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004811 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4812 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4813 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4814 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4815 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4816 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4817 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004818 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4819 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004820 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4821 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004822 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004823 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004824 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004825 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004826}
4827
eladalonf1841382017-06-12 01:16:46 -07004828TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004829 FakeVideoReceiveStream* stream = AddRecvStream();
4830 webrtc::VideoReceiveStream::Stats stats;
4831 stats.rtp_stats.transmitted.payload_bytes = 2;
4832 stats.rtp_stats.transmitted.header_bytes = 3;
4833 stats.rtp_stats.transmitted.padding_bytes = 4;
4834 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004835 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004836 stats.rtcp_stats.fraction_lost = 7;
4837 stream->SetStats(stats);
4838
4839 cricket::VideoMediaInfo info;
4840 ASSERT_TRUE(channel_->GetStats(&info));
4841 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4842 stats.rtp_stats.transmitted.header_bytes +
4843 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004844 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004845 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004846 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004847 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004848 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004849 info.receivers[0].fraction_lost);
4850}
4851
eladalonf1841382017-06-12 01:16:46 -07004852TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004853 AddSendStream();
4854 AddSendStream();
4855 webrtc::Call::Stats stats;
4856 stats.rtt_ms = 123;
4857 fake_call_->SetStats(stats);
4858
4859 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004860 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004861 ASSERT_EQ(2u, info.senders.size());
4862 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4863 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4864}
4865
eladalonf1841382017-06-12 01:16:46 -07004866TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004867 FakeVideoSendStream* stream = AddSendStream();
4868 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004869 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004870 stats.media_bitrate_bps = 123;
4871 stats.substreams[17].total_bitrate_bps = 1;
4872 stats.substreams[17].retransmit_bitrate_bps = 2;
4873 stats.substreams[42].total_bitrate_bps = 3;
4874 stats.substreams[42].retransmit_bitrate_bps = 4;
4875 stream->SetStats(stats);
4876
4877 FakeVideoSendStream* stream2 = AddSendStream();
4878 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004879 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004880 stats2.media_bitrate_bps = 321;
4881 stats2.substreams[13].total_bitrate_bps = 5;
4882 stats2.substreams[13].retransmit_bitrate_bps = 6;
4883 stats2.substreams[21].total_bitrate_bps = 7;
4884 stats2.substreams[21].retransmit_bitrate_bps = 8;
4885 stream2->SetStats(stats2);
4886
4887 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004888 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004889 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004890 BandwidthEstimationInfo bwe_info;
4891 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004892 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4893 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4894 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4895 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004896 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004897 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004898 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004899 bwe_info.actual_enc_bitrate);
4900 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004901 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004902 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004903 << "Bandwidth stats should take all streams into account.";
4904}
4905
eladalonf1841382017-06-12 01:16:46 -07004906TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004907 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004908
Peter Boström0c4e06b2015-10-07 12:23:21 +02004909 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4910 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004911
4912 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4913 const size_t kDataLength = 12;
4914 uint8_t data[kDataLength];
4915 memset(data, 0, sizeof(data));
4916 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004917 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004918 rtc::PacketTime packet_time;
4919 channel_->OnPacketReceived(&packet, packet_time);
4920
4921 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4922 << "No default receive stream created.";
4923 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004924 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004925 << "Default receive stream should not have configured RTX";
4926
4927 EXPECT_TRUE(channel_->AddRecvStream(
4928 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4929 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004930 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004931 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004932 EXPECT_FALSE(
4933 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004934 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004935 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004936 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004937 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004938 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004939 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004940}
4941
eladalonf1841382017-06-12 01:16:46 -07004942TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004943 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004944
Peter Boström0c4e06b2015-10-07 12:23:21 +02004945 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4946 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004947
4948 StreamParams sp =
4949 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4950 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4951
4952 EXPECT_FALSE(channel_->AddSendStream(sp));
4953 EXPECT_FALSE(channel_->AddRecvStream(sp));
4954}
4955
eladalonf1841382017-06-12 01:16:46 -07004956TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004957 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004958
Peter Boström0c4e06b2015-10-07 12:23:21 +02004959 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4960 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004961
4962 StreamParams sp =
4963 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4964
4965 EXPECT_TRUE(channel_->AddSendStream(sp));
4966 EXPECT_TRUE(channel_->AddRecvStream(sp));
4967
4968 // The RTX SSRC is already used in previous streams, using it should fail.
4969 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4970 EXPECT_FALSE(channel_->AddSendStream(sp));
4971 EXPECT_FALSE(channel_->AddRecvStream(sp));
4972
4973 // After removing the original stream this should be fine to add (makes sure
4974 // that RTX ssrcs are not forever taken).
4975 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4976 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4977 EXPECT_TRUE(channel_->AddSendStream(sp));
4978 EXPECT_TRUE(channel_->AddRecvStream(sp));
4979}
4980
eladalonf1841382017-06-12 01:16:46 -07004981TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004982 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004983 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4984 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004985 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004986
Peter Boströmd6f4c252015-03-26 16:23:04 +01004987 StreamParams sp =
4988 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4989
4990 EXPECT_TRUE(channel_->AddSendStream(sp));
4991 EXPECT_TRUE(channel_->AddRecvStream(sp));
4992
4993 // One of the SSRCs is already used in previous streams, using it should fail.
4994 sp = cricket::CreateSimStreamParams("cname",
4995 MAKE_VECTOR(kOverlappingStreamSsrcs));
4996 EXPECT_FALSE(channel_->AddSendStream(sp));
4997 EXPECT_FALSE(channel_->AddRecvStream(sp));
4998
4999 // After removing the original stream this should be fine to add (makes sure
5000 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005001 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5002 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005003 EXPECT_TRUE(channel_->AddSendStream(sp));
5004 EXPECT_TRUE(channel_->AddRecvStream(sp));
5005}
5006
eladalonf1841382017-06-12 01:16:46 -07005007TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005008 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005009
5010 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5011 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5012
5013 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5014 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5015
5016 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5017
5018 static const uint32_t kReceiverSsrcs[] = {3};
5019 static const uint32_t kReceiverRtxSsrcs[] = {2};
5020
5021 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5022 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5023 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5024
5025 cricket::VideoMediaInfo info;
5026 ASSERT_TRUE(channel_->GetStats(&info));
5027
5028 ASSERT_EQ(1u, info.senders.size());
5029 ASSERT_EQ(1u, info.receivers.size());
5030
5031 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5032 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5033 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5034}
5035
eladalonf1841382017-06-12 01:16:46 -07005036TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005037 FakeVideoReceiveStream* stream = AddRecvStream();
5038 webrtc::VideoReceiveStream::Stats stats;
5039 cricket::VideoMediaInfo info;
5040
5041 // Report no codec name before receiving.
5042 stream->SetStats(stats);
5043 ASSERT_TRUE(channel_->GetStats(&info));
5044 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5045
5046 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005047 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005048 stream->SetStats(stats);
5049 ASSERT_TRUE(channel_->GetStats(&info));
5050 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5051
5052 // Report no codec name for unknown playload types.
5053 stats.current_payload_type = 3;
5054 stream->SetStats(stats);
5055 ASSERT_TRUE(channel_->GetStats(&info));
5056 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5057}
5058
Seth Hampson5897a6e2018-04-03 11:16:33 -07005059// Tests that when we add a stream without SSRCs, but contains a stream_id
5060// that it is stored and its stream id is later used when the first packet
5061// arrives to properly create a receive stream with a sync label.
5062TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5063 const char kSyncLabel[] = "sync_label";
5064 cricket::StreamParams unsignaled_stream;
5065 unsignaled_stream.set_stream_ids({kSyncLabel});
5066 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5067 // The stream shouldn't have been created at this point because it doesn't
5068 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005069 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005070
5071 // Create and deliver packet.
5072 const size_t kDataLength = 12;
5073 uint8_t data[kDataLength];
5074 memset(data, 0, sizeof(data));
5075 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5076 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5077 rtc::PacketTime packet_time;
5078 channel_->OnPacketReceived(&packet, packet_time);
5079
5080 // The stream should now be created with the appropriate sync label.
5081 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5082 EXPECT_EQ(kSyncLabel,
5083 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5084
5085 // Removing the unsignaled stream should clear the cache. This time when
5086 // a default video receive stream is created it won't have a sync_group.
5087 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5088 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5089 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5090
5091 channel_->OnPacketReceived(&packet, packet_time);
5092 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5093 EXPECT_TRUE(
5094 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5095}
5096
eladalonf1841382017-06-12 01:16:46 -07005097void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005098 uint8_t payload_type,
5099 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005100 // kRedRtxPayloadType must currently be unused.
5101 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5102
noahricd10a68e2015-07-10 11:27:55 -07005103 // Add a RED RTX codec.
5104 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005105 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005106 recv_parameters_.codecs.push_back(red_rtx_codec);
5107 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005108
5109 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5110 const size_t kDataLength = 12;
5111 uint8_t data[kDataLength];
5112 memset(data, 0, sizeof(data));
5113
5114 rtc::Set8(data, 1, payload_type);
5115 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005116 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005117 rtc::PacketTime packet_time;
5118 channel_->OnPacketReceived(&packet, packet_time);
5119
5120 if (expect_created_receive_stream) {
5121 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5122 << "Should have created a receive stream for payload type: "
5123 << payload_type;
5124 } else {
5125 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5126 << "Shouldn't have created a receive stream for payload type: "
5127 << payload_type;
5128 }
5129}
5130
eladalonf1841382017-06-12 01:16:46 -07005131TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005132 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5133 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005134}
5135
eladalonf1841382017-06-12 01:16:46 -07005136TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005137 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5138 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005139}
5140
eladalonf1841382017-06-12 01:16:46 -07005141TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005142 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005143 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5144 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5145 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5146 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005147}
5148
eladalonf1841382017-06-12 01:16:46 -07005149TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005150 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5151 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005152}
5153
eladalonf1841382017-06-12 01:16:46 -07005154TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005155 FlexfecPacketDoesntCreateUnsignalledStream) {
5156 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5157 false /* expect_created_receive_stream */);
5158}
5159
eladalonf1841382017-06-12 01:16:46 -07005160TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005161 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5162 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005163}
5164
mzanaty8a855d62017-02-17 15:46:43 -08005165// Test that receiving any unsignalled SSRC works even if it changes.
5166// The first unsignalled SSRC received will create a default receive stream.
5167// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005168TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005169 // Allow receiving VP8, VP9, H264 (if enabled).
5170 cricket::VideoRecvParameters parameters;
5171 parameters.codecs.push_back(GetEngineCodec("VP8"));
5172 parameters.codecs.push_back(GetEngineCodec("VP9"));
5173
5174#if defined(WEBRTC_USE_H264)
5175 cricket::VideoCodec H264codec(126, "H264");
5176 parameters.codecs.push_back(H264codec);
5177#endif
5178
5179 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5180 // No receive streams yet.
5181 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5182 cricket::FakeVideoRenderer renderer;
5183 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5184
5185 // Receive VP8 packet on first SSRC.
5186 uint8_t data[kMinRtpPacketLen];
5187 cricket::RtpHeader rtpHeader;
5188 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5189 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005190 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005191 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5192 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5193 rtc::PacketTime packet_time;
5194 channel_->OnPacketReceived(&packet, packet_time);
5195 // VP8 packet should create default receive stream.
5196 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005197 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005198 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5199 // Verify that the receive stream sinks to a renderer.
5200 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5201 webrtc::kVideoRotation_0);
5202 recv_stream->InjectFrame(video_frame);
5203 EXPECT_EQ(1, renderer.num_rendered_frames());
5204
5205 // Receive VP9 packet on second SSRC.
5206 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005207 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005208 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5209 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5210 channel_->OnPacketReceived(&packet2, packet_time);
5211 // VP9 packet should replace the default receive SSRC.
5212 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5213 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5214 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5215 // Verify that the receive stream sinks to a renderer.
5216 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005217 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005218 recv_stream->InjectFrame(video_frame2);
5219 EXPECT_EQ(2, renderer.num_rendered_frames());
5220
5221#if defined(WEBRTC_USE_H264)
5222 // Receive H264 packet on third SSRC.
5223 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005224 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005225 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5226 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5227 channel_->OnPacketReceived(&packet3, packet_time);
5228 // H264 packet should replace the default receive SSRC.
5229 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5230 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5231 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5232 // Verify that the receive stream sinks to a renderer.
5233 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005234 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005235 recv_stream->InjectFrame(video_frame3);
5236 EXPECT_EQ(3, renderer.num_rendered_frames());
5237#endif
5238}
5239
brandtr0dc57ea2017-05-29 23:33:31 -07005240// This test verifies that when a new default stream is created for a new
5241// unsignaled SSRC, the new stream does not overwrite any old stream that had
5242// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005243TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005244 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5245 cricket::VideoRecvParameters parameters;
5246 parameters.codecs.push_back(GetEngineCodec("VP8"));
5247 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5248
5249 // No streams signaled and no packets received, so we should not have any
5250 // stream objects created yet.
5251 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5252
5253 // Receive packet on an unsignaled SSRC.
5254 uint8_t data[kMinRtpPacketLen];
5255 cricket::RtpHeader rtp_header;
5256 rtp_header.payload_type = GetEngineCodec("VP8").id;
5257 rtp_header.seq_num = rtp_header.timestamp = 0;
5258 rtp_header.ssrc = kSsrcs3[0];
5259 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5260 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5261 rtc::PacketTime packet_time;
5262 channel_->OnPacketReceived(&packet, packet_time);
5263 // Default receive stream should be created.
5264 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5265 FakeVideoReceiveStream* recv_stream0 =
5266 fake_call_->GetVideoReceiveStreams()[0];
5267 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5268
5269 // Signal the SSRC.
5270 EXPECT_TRUE(
5271 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5272 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5273 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5274 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5275
5276 // Receive packet on a different unsignaled SSRC.
5277 rtp_header.ssrc = kSsrcs3[1];
5278 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5279 packet.SetData(data, sizeof(data));
5280 channel_->OnPacketReceived(&packet, packet_time);
5281 // New default receive stream should be created, but old stream should remain.
5282 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5283 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5284 FakeVideoReceiveStream* recv_stream1 =
5285 fake_call_->GetVideoReceiveStreams()[1];
5286 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5287}
5288
Seth Hampson7c682e02018-05-04 16:28:15 -07005289TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005290 AddSendStream();
5291
Tommi85959932018-02-07 19:26:06 +01005292 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005293 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005294 cricket::VideoFormat capture_format_hd =
5295 capturer.GetSupportedFormats()->front();
5296 EXPECT_EQ(1280, capture_format_hd.width);
5297 EXPECT_EQ(720, capture_format_hd.height);
5298 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5299 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005300 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005301
perkjfa10b552016-10-02 23:45:26 -07005302 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005303 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005304
5305 // TODO(skvlad): Resolve the inconsistency between the interpretation
5306 // of the global bitrate limit for audio and video:
5307 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5308 // max_bandwidth_bps = -1 - remove the bandwidth limit
5309 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005310 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005311
perkjfa10b552016-10-02 23:45:26 -07005312 SetAndExpectMaxBitrate(1000, 0, 1000);
5313 SetAndExpectMaxBitrate(1000, 800, 800);
5314 SetAndExpectMaxBitrate(600, 800, 600);
5315 SetAndExpectMaxBitrate(0, 800, 800);
5316 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005317
Niels Möllerff40b142018-04-09 08:49:14 +02005318 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005319}
5320
eladalonf1841382017-06-12 01:16:46 -07005321TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005322 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005323 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005324 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005325
5326 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005327 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005328 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005329}
5330
eladalonf1841382017-06-12 01:16:46 -07005331TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005332 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005333 FakeVideoSendStream* stream = AddSendStream();
5334
Seth Hampson7c682e02018-05-04 16:28:15 -07005335 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5336 EXPECT_EQ(1UL, parameters.encodings.size());
5337 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5338 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5339
5340 // Note that this is testing the behavior of the FakeVideoSendStream, which
5341 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5342 // we are just testing the behavior of
5343 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005344 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5345 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005346
5347 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5348 // by this amount.
5349 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5350 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5351 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5352 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5353
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005354 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5355 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5356 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5357}
5358
5359TEST_F(WebRtcVideoChannelTest,
5360 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5361 FakeVideoSendStream* stream = AddSendStream();
5362
5363 // Note that this is testing the behavior of the FakeVideoSendStream, which
5364 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5365 // we are just testing the behavior of
5366 // EncoderStreamFactory::CreateEncoderStreams.
5367 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5368 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5369
5370 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5371 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5372 EXPECT_EQ(1UL, parameters.encodings.size());
5373 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5374 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5375
5376 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5377 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5378 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5379}
5380
5381TEST_F(WebRtcVideoChannelTest,
5382 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5383 send_parameters_.max_bandwidth_bps = 99999;
5384 FakeVideoSendStream* stream = AddSendStream();
5385 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5386 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5387 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5388 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5389 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5390 stream->GetVideoStreams()[0].max_bitrate_bps);
5391
5392 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5393 // adjusted down.
5394 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5395 EXPECT_EQ(1UL, parameters.encodings.size());
5396 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5397 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5398 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5399 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5400 stream->GetVideoStreams()[0].min_bitrate_bps);
5401 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5402 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005403}
5404
5405TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005406 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005407 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005408 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005409 // Two or more encodings should result in failure.
5410 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005411 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005412 // Zero encodings should also fail.
5413 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005414 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005415}
5416
Zach Stein3ca452b2018-01-18 10:01:24 -08005417TEST_F(WebRtcVideoChannelTest,
5418 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5419 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5420 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5421 AddSendStream(sp);
5422
5423 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5424
5425 // Additional encodings should result in failure.
5426 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005427 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005428 // Zero encodings should also fail.
5429 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005430 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005431}
5432
deadbeeffb2aced2017-01-06 23:05:37 -08005433// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005434TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005435 AddSendStream();
5436 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005437 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005438 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005439}
5440
Seth Hampson24722b32017-12-22 09:36:42 -08005441// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5442// a value <= 0, setting the parameters returns false.
5443TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5444 AddSendStream();
5445 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5446 EXPECT_EQ(1UL, parameters.encodings.size());
5447 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5448 parameters.encodings[0].bitrate_priority);
5449
5450 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005451 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005452 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005453 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005454}
5455
5456// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5457// properly on the VideoChannel and propogates down to the video encoder.
5458TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5459 AddSendStream();
5460 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5461 EXPECT_EQ(1UL, parameters.encodings.size());
5462 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5463 parameters.encodings[0].bitrate_priority);
5464
5465 // Change the value and set it on the VideoChannel.
5466 double new_bitrate_priority = 2.0;
5467 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005468 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005469
5470 // Verify that the encoding parameters bitrate_priority is set for the
5471 // VideoChannel.
5472 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5473 EXPECT_EQ(1UL, parameters.encodings.size());
5474 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5475
5476 // Verify that the new value propagated down to the encoder.
5477 std::vector<FakeVideoSendStream*> video_send_streams =
5478 fake_call_->GetVideoSendStreams();
5479 EXPECT_EQ(1UL, video_send_streams.size());
5480 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5481 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5482 // appropriately.
5483 EXPECT_EQ(new_bitrate_priority,
5484 video_send_stream->GetEncoderConfig().bitrate_priority);
5485 // Check that the vector of VideoStreams also was propagated correctly. Note
5486 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5487 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005488 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005489 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5490}
5491
5492// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5493// VideoChannel and the value propogates to the video encoder with all simulcast
5494// streams.
5495TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5496 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005497 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005498 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5499 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5500 AddSendStream(stream_params);
5501 uint32_t primary_ssrc = stream_params.first_ssrc();
5502
Tommi85959932018-02-07 19:26:06 +01005503 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5504 // frame. This creates multiple VideoStreams for all simulcast layers when
5505 // reconfiguring, and allows us to test this behavior.
5506 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005507 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005508 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005509 EXPECT_EQ(cricket::CS_RUNNING,
5510 capturer.Start(cricket::VideoFormat(
5511 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5512 cricket::FOURCC_I420)));
5513 channel_->SetSend(true);
5514 EXPECT_TRUE(capturer.CaptureFrame());
5515 // Get and set the rtp encoding parameters.
5516 webrtc::RtpParameters parameters =
5517 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005518 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005519 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5520 parameters.encodings[0].bitrate_priority);
5521 // Change the value and set it on the VideoChannel.
5522 double new_bitrate_priority = 2.0;
5523 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005524 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005525
5526 // Verify that the encoding parameters priority is set on the VideoChannel.
5527 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005528 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005529 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5530
5531 // Verify that the new value propagated down to the encoder.
5532 std::vector<FakeVideoSendStream*> video_send_streams =
5533 fake_call_->GetVideoSendStreams();
5534 EXPECT_EQ(1UL, video_send_streams.size());
5535 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5536 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5537 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005538 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005539 video_send_stream->GetEncoderConfig().number_of_streams);
5540 EXPECT_EQ(new_bitrate_priority,
5541 video_send_stream->GetEncoderConfig().bitrate_priority);
5542 // Check that the vector of VideoStreams also propagated correctly. The
5543 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5544 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005545 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005546 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005547 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5548 // Since we are only setting bitrate priority per-sender, the other
5549 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005550 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005551 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005552 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005553 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005554 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005555}
5556
Åsa Persson55659812018-06-18 17:51:32 +02005557TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5558 const size_t kNumSimulcastStreams = 3;
5559 SetUpSimulcast(true, false);
5560
5561 // Get and set the rtp encoding parameters.
5562 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5563 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5564 for (const auto& encoding : parameters.encodings) {
5565 EXPECT_FALSE(encoding.min_bitrate_bps);
5566 EXPECT_FALSE(encoding.max_bitrate_bps);
5567 }
5568
5569 // Change the value and set it on the VideoChannel.
5570 parameters.encodings[0].min_bitrate_bps = 100000;
5571 parameters.encodings[0].max_bitrate_bps = 200000;
5572 parameters.encodings[1].min_bitrate_bps = 300000;
5573 parameters.encodings[1].max_bitrate_bps = 400000;
5574 parameters.encodings[2].min_bitrate_bps = 500000;
5575 parameters.encodings[2].max_bitrate_bps = 600000;
5576 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5577
5578 // Verify that the bitrates are set on the VideoChannel.
5579 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5580 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5581 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5582 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5583 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5584 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5585 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5586 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5587}
5588
5589TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5590 const size_t kNumSimulcastStreams = 3;
5591 SetUpSimulcast(true, false);
5592
5593 // Get and set the rtp encoding parameters.
5594 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5595 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5596
5597 // Max bitrate lower than min bitrate should fail.
5598 parameters.encodings[2].min_bitrate_bps = 100000;
5599 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5600 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5601 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5602}
5603
5604// Test that min and max bitrate values set via RtpParameters are correctly
5605// propagated to the underlying encoder, and that the target is set to 3/4 of
5606// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5607// that are used if no min/max are specified).
5608TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5609 const size_t kNumSimulcastStreams = 3;
5610 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5611
5612 // Send a full size frame so all simulcast layers are used when reconfiguring.
5613 FakeVideoCapturerWithTaskQueue capturer;
5614 VideoOptions options;
5615 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5616 EXPECT_EQ(cricket::CS_RUNNING,
5617 capturer.Start(capturer.GetSupportedFormats()->front()));
5618 channel_->SetSend(true);
5619 EXPECT_TRUE(capturer.CaptureFrame());
5620
5621 // Get and set the rtp encoding parameters.
5622 // Change the value and set it on the VideoChannel.
5623 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5624 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5625 parameters.encodings[0].min_bitrate_bps = 100000;
5626 parameters.encodings[0].max_bitrate_bps = 200000;
5627 parameters.encodings[1].min_bitrate_bps = 300000;
5628 parameters.encodings[1].max_bitrate_bps = 400000;
5629 parameters.encodings[2].min_bitrate_bps = 500000;
5630 parameters.encodings[2].max_bitrate_bps = 600000;
5631 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5632
5633 // Verify that the new value propagated down to the encoder.
5634 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5635 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5636 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5637 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5638 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5639 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5640 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5641 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5642 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5643 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5644 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5645
5646 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5647 // VideoStreams are created appropriately for the simulcast case.
5648 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5649 // Target bitrate: 200000 * 3 / 4 = 150000.
5650 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5651 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5652 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5653 // Target bitrate: 400000 * 3 / 4 = 300000.
5654 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5655 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5656 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5657 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5658 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5659 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5660 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5661
5662 // No parameter changed, encoder should not be reconfigured.
5663 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5664 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5665
5666 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5667}
5668
5669// Test to only specify the min or max bitrate value for a layer via
5670// RtpParameters. The unspecified min/max and target value should be set to the
5671// simulcast default that is used if no min/max are specified.
5672TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5673 const size_t kNumSimulcastStreams = 3;
5674 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5675 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5676
5677 // Send a full size frame so all simulcast layers are used when reconfiguring.
5678 FakeVideoCapturerWithTaskQueue capturer;
5679 VideoOptions options;
5680 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5681 EXPECT_EQ(cricket::CS_RUNNING,
5682 capturer.Start(capturer.GetSupportedFormats()->front()));
5683 channel_->SetSend(true);
5684 EXPECT_TRUE(capturer.CaptureFrame());
5685
5686 // Get and set the rtp encoding parameters.
5687 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5688 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5689
5690 // Change the value and set it on the VideoChannel.
5691 // Layer 0: only configure min bitrate.
5692 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5693 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5694 // Layer 1: only configure max bitrate.
5695 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5696 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5697 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5698
5699 // Verify that the new value propagated down to the encoder.
5700 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5701 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5702 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5703 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5704 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5705 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5706 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5707 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5708 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5709 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5710
5711 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5712 // VideoStreams are created appropriately for the simulcast case.
5713 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5714 // Layer 0: min configured bitrate should overwrite min default.
5715 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5716 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5717 stream->GetVideoStreams()[0].target_bitrate_bps);
5718 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5719 stream->GetVideoStreams()[0].max_bitrate_bps);
5720 // Layer 1: max configured bitrate should overwrite max default.
5721 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5722 stream->GetVideoStreams()[1].min_bitrate_bps);
5723 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5724 stream->GetVideoStreams()[1].target_bitrate_bps);
5725 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5726 // Layer 2: min and max bitrate not configured, default expected.
5727 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5728 stream->GetVideoStreams()[2].min_bitrate_bps);
5729 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5730 stream->GetVideoStreams()[2].target_bitrate_bps);
5731 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5732 stream->GetVideoStreams()[2].max_bitrate_bps);
5733
5734 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5735}
5736
5737// Test that specifying the min (or max) bitrate value for a layer via
5738// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5739// unspecified values accordingly.
5740TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5741 const size_t kNumSimulcastStreams = 3;
5742 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5743 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5744
5745 // Send a full size frame so all simulcast layers are used when reconfiguring.
5746 FakeVideoCapturerWithTaskQueue capturer;
5747 VideoOptions options;
5748 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5749 EXPECT_EQ(cricket::CS_RUNNING,
5750 capturer.Start(capturer.GetSupportedFormats()->front()));
5751 channel_->SetSend(true);
5752 EXPECT_TRUE(capturer.CaptureFrame());
5753
5754 // Get and set the rtp encoding parameters.
5755 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5756 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5757
5758 // Change the value and set it on the VideoChannel.
5759 // For layer 0, set the min bitrate above the default max.
5760 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
5761 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5762 // For layer 1, set the max bitrate below the default min.
5763 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
5764 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5765 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5766
5767 // Verify that the new value propagated down to the encoder.
5768 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5769 // VideoStreams are created appropriately for the simulcast case.
5770 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5771 // Layer 0: Min bitrate above default max (target/max should be adjusted).
5772 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5773 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
5774 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
5775 // Layer 1: Max bitrate below default min (min/target should be adjusted).
5776 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
5777 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
5778 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5779 // Layer 2: min and max bitrate not configured, default expected.
5780 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5781 stream->GetVideoStreams()[2].min_bitrate_bps);
5782 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5783 stream->GetVideoStreams()[2].target_bitrate_bps);
5784 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5785 stream->GetVideoStreams()[2].max_bitrate_bps);
5786
5787 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5788}
5789
5790TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
5791 const size_t kNumSimulcastStreams = 3;
5792 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5793 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5794
5795 // Send a full size frame so all simulcast layers are used when reconfiguring.
5796 FakeVideoCapturerWithTaskQueue capturer;
5797 VideoOptions options;
5798 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5799 EXPECT_EQ(cricket::CS_RUNNING,
5800 capturer.Start(capturer.GetSupportedFormats()->front()));
5801 channel_->SetSend(true);
5802 EXPECT_TRUE(capturer.CaptureFrame());
5803
5804 // Set max bitrate for all but the highest layer.
5805 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5806 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5807 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
5808 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
5809 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5810
5811 // Set max bandwidth equal to total max bitrate.
5812 send_parameters_.max_bandwidth_bps =
5813 GetTotalMaxBitrateBps(stream->GetVideoStreams());
5814 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5815 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5816
5817 // No bitrate above the total max to give to the highest layer.
5818 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5819 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5820 stream->GetVideoStreams()[2].max_bitrate_bps);
5821
5822 // Set max bandwidth above the total max bitrate.
5823 send_parameters_.max_bandwidth_bps =
5824 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5825 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5826 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5827
5828 // The highest layer has no max bitrate set -> the bitrate above the total
5829 // max should be given to the highest layer.
5830 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5831 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5832 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
5833 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
5834 stream->GetVideoStreams()[2].max_bitrate_bps);
5835
5836 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5837}
5838
5839TEST_F(WebRtcVideoChannelTest,
5840 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
5841 const size_t kNumSimulcastStreams = 3;
5842 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5843 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
5844 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5845
5846 // Send a full size frame so all simulcast layers are used when reconfiguring.
5847 FakeVideoCapturerWithTaskQueue capturer;
5848 VideoOptions options;
5849 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5850 EXPECT_EQ(cricket::CS_RUNNING,
5851 capturer.Start(capturer.GetSupportedFormats()->front()));
5852 channel_->SetSend(true);
5853 EXPECT_TRUE(capturer.CaptureFrame());
5854
5855 // Set max bitrate for the highest layer.
5856 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5857 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5858 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
5859 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5860
5861 // Set max bandwidth above the total max bitrate.
5862 send_parameters_.max_bandwidth_bps =
5863 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5864 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5865 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5866
5867 // The highest layer has the max bitrate set -> the bitrate above the total
5868 // max should not be given to the highest layer.
5869 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5870 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
5871 stream->GetVideoStreams()[2].max_bitrate_bps);
5872
5873 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5874}
5875
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005876// Test that min and max bitrate values set via RtpParameters are correctly
5877// propagated to the underlying encoder for a single stream.
5878TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
5879 FakeVideoSendStream* stream = AddSendStream();
5880 EXPECT_TRUE(channel_->SetSend(true));
5881 EXPECT_TRUE(stream->IsSending());
5882
5883 // Set min and max bitrate.
5884 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5885 EXPECT_EQ(1u, parameters.encodings.size());
5886 parameters.encodings[0].min_bitrate_bps = 80000;
5887 parameters.encodings[0].max_bitrate_bps = 150000;
5888 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5889
5890 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5891 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5892 EXPECT_EQ(1u, encoder_config.number_of_streams);
5893 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5894 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5895 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5896
5897 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5898 // VideoStreams are created appropriately.
5899 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5900 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
5901 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5902 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
5903}
5904
5905// Test the default min and max bitrate value are correctly propagated to the
5906// underlying encoder for a single stream (when the values are not set via
5907// RtpParameters).
5908TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
5909 FakeVideoSendStream* stream = AddSendStream();
5910 EXPECT_TRUE(channel_->SetSend(true));
5911 EXPECT_TRUE(stream->IsSending());
5912
5913 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5914 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5915 EXPECT_EQ(1u, encoder_config.number_of_streams);
5916 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5917 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
5918 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5919
5920 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5921 // VideoStreams are created appropriately.
5922 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5923 EXPECT_EQ(cricket::kMinVideoBitrateBps,
5924 stream->GetVideoStreams()[0].min_bitrate_bps);
5925 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
5926 stream->GetVideoStreams()[0].min_bitrate_bps);
5927 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
5928 stream->GetVideoStreams()[0].target_bitrate_bps);
5929}
5930
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005931// Test that a stream will not be sending if its encoding is made inactive
5932// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08005933TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07005934 FakeVideoSendStream* stream = AddSendStream();
5935 EXPECT_TRUE(channel_->SetSend(true));
5936 EXPECT_TRUE(stream->IsSending());
5937
5938 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005939 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07005940 ASSERT_EQ(1u, parameters.encodings.size());
5941 ASSERT_TRUE(parameters.encodings[0].active);
5942 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08005943 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005944 EXPECT_FALSE(stream->IsSending());
5945
5946 // Now change it back to active and verify we resume sending.
5947 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08005948 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005949 EXPECT_TRUE(stream->IsSending());
5950}
5951
Seth Hampson8234ead2018-02-02 15:16:24 -08005952// Tests that when active is updated for any simulcast layer then the send
5953// stream's sending state will be updated and it will be reconfigured with the
5954// new appropriate active simulcast streams.
5955TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
5956 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005957 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08005958 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5959 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5960 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
5961 uint32_t primary_ssrc = stream_params.first_ssrc();
5962
Tommi85959932018-02-07 19:26:06 +01005963 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5964 // frame. This allows us to test that ReconfigureEncoder is called
5965 // appropriately.
5966 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08005967 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005968 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08005969 EXPECT_EQ(cricket::CS_RUNNING,
5970 capturer.Start(cricket::VideoFormat(
5971 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5972 cricket::FOURCC_I420)));
5973 channel_->SetSend(true);
5974 EXPECT_TRUE(capturer.CaptureFrame());
5975
5976 // Check that all encodings are initially active.
5977 webrtc::RtpParameters parameters =
5978 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005979 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005980 EXPECT_TRUE(parameters.encodings[0].active);
5981 EXPECT_TRUE(parameters.encodings[1].active);
5982 EXPECT_TRUE(parameters.encodings[2].active);
5983 EXPECT_TRUE(fake_video_send_stream->IsSending());
5984
5985 // Only turn on only the middle stream.
5986 parameters.encodings[0].active = false;
5987 parameters.encodings[1].active = true;
5988 parameters.encodings[2].active = false;
5989 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5990 // Verify that the active fields are set on the VideoChannel.
5991 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005992 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005993 EXPECT_FALSE(parameters.encodings[0].active);
5994 EXPECT_TRUE(parameters.encodings[1].active);
5995 EXPECT_FALSE(parameters.encodings[2].active);
5996 // Check that the VideoSendStream is updated appropriately. This means its
5997 // send state was updated and it was reconfigured.
5998 EXPECT_TRUE(fake_video_send_stream->IsSending());
5999 std::vector<webrtc::VideoStream> simulcast_streams =
6000 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006001 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006002 EXPECT_FALSE(simulcast_streams[0].active);
6003 EXPECT_TRUE(simulcast_streams[1].active);
6004 EXPECT_FALSE(simulcast_streams[2].active);
6005
6006 // Turn off all streams.
6007 parameters.encodings[0].active = false;
6008 parameters.encodings[1].active = false;
6009 parameters.encodings[2].active = false;
6010 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6011 // Verify that the active fields are set on the VideoChannel.
6012 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006013 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006014 EXPECT_FALSE(parameters.encodings[0].active);
6015 EXPECT_FALSE(parameters.encodings[1].active);
6016 EXPECT_FALSE(parameters.encodings[2].active);
6017 // Check that the VideoSendStream is off.
6018 EXPECT_FALSE(fake_video_send_stream->IsSending());
6019 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006020 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006021 EXPECT_FALSE(simulcast_streams[0].active);
6022 EXPECT_FALSE(simulcast_streams[1].active);
6023 EXPECT_FALSE(simulcast_streams[2].active);
6024
Niels Möllerff40b142018-04-09 08:49:14 +02006025 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006026}
6027
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006028// Test that if a stream is reconfigured (due to a codec change or other
6029// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006030TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006031 InactiveStreamDoesntStartSendingWhenReconfigured) {
6032 // Set an initial codec list, which will be modified later.
6033 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006034 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6035 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006036 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6037
6038 FakeVideoSendStream* stream = AddSendStream();
6039 EXPECT_TRUE(channel_->SetSend(true));
6040 EXPECT_TRUE(stream->IsSending());
6041
6042 // Get current parameters and change "active" to false.
6043 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6044 ASSERT_EQ(1u, parameters.encodings.size());
6045 ASSERT_TRUE(parameters.encodings[0].active);
6046 parameters.encodings[0].active = false;
6047 EXPECT_EQ(1u, GetFakeSendStreams().size());
6048 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006049 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006050 EXPECT_FALSE(stream->IsSending());
6051
6052 // Reorder the codec list, causing the stream to be reconfigured.
6053 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006054 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6055 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006056 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6057 auto new_streams = GetFakeSendStreams();
6058 // Assert that a new underlying stream was created due to the codec change.
6059 // Otherwise, this test isn't testing what it set out to test.
6060 EXPECT_EQ(1u, GetFakeSendStreams().size());
6061 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6062
6063 // Verify that we still are not sending anything, due to the inactive
6064 // encoding.
6065 EXPECT_FALSE(new_streams[0]->IsSending());
6066}
6067
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006068// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006069TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006070 AddSendStream();
6071 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006072 parameters.codecs.push_back(GetEngineCodec("VP8"));
6073 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006074 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6075
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006076 webrtc::RtpParameters rtp_parameters =
6077 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006078 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006079 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6080 rtp_parameters.codecs[0]);
6081 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6082 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006083}
6084
Florent Castellidacec712018-05-24 16:24:21 +02006085// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6086TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6087 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6088 params.cname = "rtcpcname";
6089 AddSendStream(params);
6090
6091 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6092 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6093}
6094
deadbeeffb2aced2017-01-06 23:05:37 -08006095// Test that RtpParameters for send stream has one encoding and it has
6096// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006097TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006098 AddSendStream();
6099
6100 webrtc::RtpParameters rtp_parameters =
6101 channel_->GetRtpSendParameters(last_ssrc_);
6102 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006103 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006104}
6105
Florent Castelliabe301f2018-06-12 18:33:49 +02006106TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6107 AddSendStream();
6108
6109 webrtc::RtpParameters rtp_parameters =
6110 channel_->GetRtpSendParameters(last_ssrc_);
6111 rtp_parameters.header_extensions.emplace_back();
6112
6113 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6114
6115 webrtc::RTCError result =
6116 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6117 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6118}
6119
Florent Castelli87b3c512018-07-18 16:00:28 +02006120TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6121 AddSendStream();
6122
6123 FakeVideoCapturerWithTaskQueue capturer;
6124 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6125
6126 webrtc::RtpParameters rtp_parameters =
6127 channel_->GetRtpSendParameters(last_ssrc_);
6128 EXPECT_EQ(rtp_parameters.degradation_preference,
6129 webrtc::DegradationPreference::BALANCED);
6130 rtp_parameters.degradation_preference =
6131 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6132
6133 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6134
6135 webrtc::RtpParameters updated_rtp_parameters =
6136 channel_->GetRtpSendParameters(last_ssrc_);
6137 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6138 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6139
6140 // Remove the source since it will be destroyed before the channel
6141 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6142}
6143
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006144// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006145TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006146 AddSendStream();
6147 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006148 parameters.codecs.push_back(GetEngineCodec("VP8"));
6149 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006150 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6151
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006152 webrtc::RtpParameters initial_params =
6153 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006154
6155 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006156 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006157
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006158 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6159 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6160}
6161
6162// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006163TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006164 AddRecvStream();
6165 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006166 parameters.codecs.push_back(GetEngineCodec("VP8"));
6167 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006168 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6169
6170 webrtc::RtpParameters rtp_parameters =
6171 channel_->GetRtpReceiveParameters(last_ssrc_);
6172 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006173 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6174 rtp_parameters.codecs[0]);
6175 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6176 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006177}
6178
johan073ece42016-08-26 02:59:47 -07006179#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006180TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006181#else
eladalonf1841382017-06-12 01:16:46 -07006182TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006183#endif
johan3859c892016-08-05 09:19:25 -07006184 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006185 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006186 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006187 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006188 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006189 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006190 parameters.codecs.push_back(kH264sprop2);
6191 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6192
6193 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6194 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6195 webrtc::RtpParameters rtp_parameters =
6196 channel_->GetRtpReceiveParameters(last_ssrc_);
6197 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6198 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6199 ASSERT_EQ(2u, cfg.decoders.size());
6200 EXPECT_EQ(101, cfg.decoders[0].payload_type);
6201 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006202 const auto it0 =
6203 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
6204 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
6205 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006206
6207 EXPECT_EQ(102, cfg.decoders[1].payload_type);
6208 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006209 const auto it1 =
6210 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
6211 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
6212 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006213}
6214
sakal1fd95952016-06-22 00:46:15 -07006215// Test that RtpParameters for receive stream has one encoding and it has
6216// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006217TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006218 AddRecvStream();
6219
6220 webrtc::RtpParameters rtp_parameters =
6221 channel_->GetRtpReceiveParameters(last_ssrc_);
6222 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006223 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006224}
6225
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006226// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006227TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006228 AddRecvStream();
6229 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006230 parameters.codecs.push_back(GetEngineCodec("VP8"));
6231 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006232 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6233
6234 webrtc::RtpParameters initial_params =
6235 channel_->GetRtpReceiveParameters(last_ssrc_);
6236
6237 // We should be able to set the params we just got.
6238 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6239
6240 // ... And this shouldn't change the params returned by
6241 // GetRtpReceiveParameters.
6242 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006243}
6244
deadbeef3bc15102017-04-20 19:25:07 -07006245// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6246// aren't signaled. It should always return an empty "RtpEncodingParameters",
6247// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006248TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006249 // Call necessary methods to configure receiving a default stream as
6250 // soon as it arrives.
6251 cricket::VideoRecvParameters parameters;
6252 parameters.codecs.push_back(GetEngineCodec("VP8"));
6253 parameters.codecs.push_back(GetEngineCodec("VP9"));
6254 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6255
6256 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6257 // stream. Should return nothing.
6258 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6259
6260 // Set a sink for an unsignaled stream.
6261 cricket::FakeVideoRenderer renderer;
6262 // Value of "0" means "unsignaled stream".
6263 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6264
6265 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6266 // in this method means "unsignaled stream".
6267 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6268 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6269 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6270
6271 // Receive VP8 packet.
6272 uint8_t data[kMinRtpPacketLen];
6273 cricket::RtpHeader rtpHeader;
6274 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6275 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6276 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6277 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6278 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6279 rtc::PacketTime packet_time;
6280 channel_->OnPacketReceived(&packet, packet_time);
6281
6282 // The |ssrc| member should still be unset.
6283 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6284 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6285 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6286}
6287
eladalonf1841382017-06-12 01:16:46 -07006288void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006289 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006290 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006291
6292 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006293 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006294 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006295 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006296
6297 if (receiver_first) {
6298 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6299 std::vector<FakeVideoReceiveStream*> receive_streams =
6300 fake_call_->GetVideoReceiveStreams();
6301 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006302 // Default local SSRC when we have no sender.
6303 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6304 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006305 }
6306 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6307 if (!receiver_first)
6308 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6309 std::vector<FakeVideoReceiveStream*> receive_streams =
6310 fake_call_->GetVideoReceiveStreams();
6311 ASSERT_EQ(1u, receive_streams.size());
6312 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006313
6314 // Removing first sender should fall back to another (in this case the second)
6315 // local send stream's SSRC.
6316 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6317 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006318 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006319 ASSERT_EQ(1u, receive_streams.size());
6320 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6321
6322 // Removing the last sender should fall back to default local SSRC.
6323 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006324 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006325 ASSERT_EQ(1u, receive_streams.size());
6326 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6327 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006328}
6329
eladalonf1841382017-06-12 01:16:46 -07006330TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006331 TestReceiverLocalSsrcConfiguration(false);
6332}
6333
eladalonf1841382017-06-12 01:16:46 -07006334TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006335 TestReceiverLocalSsrcConfiguration(true);
6336}
6337
eladalonf1841382017-06-12 01:16:46 -07006338class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006339 public:
eladalonf1841382017-06-12 01:16:46 -07006340 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006341 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006342 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6343 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006344 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006345 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006346 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006347 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006348 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006349
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006350 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006351 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006352 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006353 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006354 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006355 last_ssrc_ = 123;
6356 }
6357
6358 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006359 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006360 int capture_width,
6361 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006362 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006363 size_t expected_num_streams,
6364 bool screenshare,
6365 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006366 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006367 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006368 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006369 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006370
Peter Boström0c4e06b2015-10-07 12:23:21 +02006371 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006372 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006373 ssrcs.resize(num_configured_streams);
6374
sprangf24a0642017-02-28 13:23:26 -08006375 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006376 // Send a full-size frame to trigger a stream reconfiguration to use all
6377 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006378 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006379 VideoOptions options;
6380 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006381 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006382 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006383 // Fetch the latest stream since SetVideoSend() may recreate it if the
6384 // screen content setting is changed.
6385 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006386 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006387 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006388 cricket::VideoFormat::FpsToInterval(30),
6389 cricket::FOURCC_I420)));
6390 channel_->SetSend(true);
6391 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006392
Zach Stein3ca452b2018-01-18 10:01:24 -08006393 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6394 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6395
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006396 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6397 ASSERT_EQ(expected_num_streams, video_streams.size());
6398
sprang429600d2017-01-26 06:12:26 -08006399 std::vector<webrtc::VideoStream> expected_streams;
6400 if (conference_mode) {
6401 expected_streams = GetSimulcastConfig(
6402 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006403 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006404 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006405 if (screenshare) {
6406 for (const webrtc::VideoStream& stream : expected_streams) {
6407 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006408 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6409 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006410 }
6411 }
sprang429600d2017-01-26 06:12:26 -08006412 } else {
6413 webrtc::VideoStream stream;
6414 stream.width = capture_width;
6415 stream.height = capture_height;
6416 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006417 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006418 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006419 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006420 stream.max_qp = kDefaultQpMax;
6421 expected_streams.push_back(stream);
6422 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006423
6424 ASSERT_EQ(expected_streams.size(), video_streams.size());
6425
6426 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006427 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006428 for (size_t i = 0; i < num_streams; ++i) {
6429 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6430 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6431
6432 EXPECT_GT(video_streams[i].max_framerate, 0);
6433 EXPECT_EQ(expected_streams[i].max_framerate,
6434 video_streams[i].max_framerate);
6435
6436 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6437 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6438 video_streams[i].min_bitrate_bps);
6439
6440 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6441 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6442 video_streams[i].target_bitrate_bps);
6443
6444 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6445 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6446 video_streams[i].max_bitrate_bps);
6447
6448 EXPECT_GT(video_streams[i].max_qp, 0);
6449 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6450
Sergey Silkina796a7e2018-03-01 15:11:29 +01006451 EXPECT_EQ(conference_mode,
6452 expected_streams[i].num_temporal_layers.has_value());
6453
6454 if (conference_mode) {
6455 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6456 video_streams[i].num_temporal_layers);
6457 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006458
6459 if (i == num_streams - 1) {
6460 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6461 } else {
6462 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6463 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006464 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006465
Niels Möllerff40b142018-04-09 08:49:14 +02006466 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006467 }
6468
6469 FakeVideoSendStream* AddSendStream() {
6470 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6471 }
6472
6473 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006474 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006475 EXPECT_TRUE(channel_->AddSendStream(sp));
6476 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006477 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006478 EXPECT_EQ(num_streams + 1, streams.size());
6479 return streams[streams.size() - 1];
6480 }
6481
6482 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006483 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006484 }
6485
6486 FakeVideoReceiveStream* AddRecvStream() {
6487 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6488 }
6489
6490 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006491 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006492 EXPECT_TRUE(channel_->AddRecvStream(sp));
6493 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006494 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006495 EXPECT_EQ(num_streams + 1, streams.size());
6496 return streams[streams.size() - 1];
6497 }
6498
skvlad11a9cbf2016-10-07 11:53:05 -07006499 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006500 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006501 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6502 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006503 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006504 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006505 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006506};
6507
eladalonf1841382017-06-12 01:16:46 -07006508TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006509 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6510 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006511}
6512
eladalonf1841382017-06-12 01:16:46 -07006513TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006514 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6515 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006516}
6517
6518// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006519TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006520 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6521 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006522}
sprang429600d2017-01-26 06:12:26 -08006523
eladalonf1841382017-06-12 01:16:46 -07006524TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006525 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6526 true);
6527}
6528
eladalonf1841382017-06-12 01:16:46 -07006529TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006530 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006531 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6532 false);
6533}
6534
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006535} // namespace cricket