Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Harald Alvestrand | c24a218 | 2022-02-23 13:44:59 +0000 | [diff] [blame] | 11 | #include <stddef.h> |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame] | 12 | |
Harald Alvestrand | c24a218 | 2022-02-23 13:44:59 +0000 | [diff] [blame] | 13 | #include <cstdint> |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 14 | #include <memory> |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 15 | #include <string> |
| 16 | #include <utility> |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 17 | #include <vector> |
| 18 | |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 19 | #include "absl/types/optional.h" |
| 20 | #include "api/audio/audio_mixer.h" |
Karl Wiberg | 1b0eae3 | 2017-10-17 14:48:54 +0200 | [diff] [blame] | 21 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 22 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Mirko Bonadei | 2ff3f49 | 2018-11-22 09:00:13 +0100 | [diff] [blame] | 23 | #include "api/create_peerconnection_factory.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 24 | #include "api/jsep.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 25 | #include "api/media_stream_interface.h" |
| 26 | #include "api/media_types.h" |
| 27 | #include "api/peer_connection_interface.h" |
| 28 | #include "api/rtc_error.h" |
| 29 | #include "api/rtp_parameters.h" |
| 30 | #include "api/rtp_receiver_interface.h" |
| 31 | #include "api/rtp_sender_interface.h" |
Harald Alvestrand | c24a218 | 2022-02-23 13:44:59 +0000 | [diff] [blame] | 32 | #include "api/rtp_transceiver_direction.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 33 | #include "api/rtp_transceiver_interface.h" |
Mirko Bonadei | d970807 | 2019-01-25 20:26:48 +0100 | [diff] [blame] | 34 | #include "api/scoped_refptr.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 35 | #include "api/set_remote_description_observer_interface.h" |
| 36 | #include "api/uma_metrics.h" |
Anders Carlsson | 6753795 | 2018-05-03 11:28:29 +0200 | [diff] [blame] | 37 | #include "api/video_codecs/builtin_video_decoder_factory.h" |
| 38 | #include "api/video_codecs/builtin_video_encoder_factory.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 39 | #include "media/base/stream_params.h" |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 40 | #include "modules/audio_device/include/audio_device.h" |
| 41 | #include "modules/audio_processing/include/audio_processing.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 42 | #include "p2p/base/port_allocator.h" |
| 43 | #include "pc/media_session.h" |
| 44 | #include "pc/peer_connection_wrapper.h" |
| 45 | #include "pc/sdp_utils.h" |
| 46 | #include "pc/session_description.h" |
| 47 | #include "pc/test/fake_audio_capture_module.h" |
| 48 | #include "pc/test/mock_peer_connection_observers.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 49 | #include "rtc_base/checks.h" |
| 50 | #include "rtc_base/gunit.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 51 | #include "rtc_base/ref_counted_object.h" |
| 52 | #include "rtc_base/rtc_certificate_generator.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 53 | #include "rtc_base/thread.h" |
Mirko Bonadei | 17f4878 | 2018-09-28 08:51:10 +0200 | [diff] [blame] | 54 | #include "system_wrappers/include/metrics.h" |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 55 | #include "test/gmock.h" |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 56 | #include "test/gtest.h" |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 57 | |
| 58 | // This file contains tests for RTP Media API-related behavior of |
Artem Titov | cfea218 | 2021-08-10 01:22:31 +0200 | [diff] [blame] | 59 | // `webrtc::PeerConnection`, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 60 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 61 | namespace webrtc { |
| 62 | |
| 63 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 64 | using ::testing::ElementsAre; |
Steve Anton | c1e6e86 | 2019-03-04 14:43:44 -0800 | [diff] [blame] | 65 | using ::testing::Pair; |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 66 | using ::testing::UnorderedElementsAre; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 67 | using ::testing::Values; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 68 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 69 | const uint32_t kDefaultTimeout = 10000u; |
| 70 | |
| 71 | template <typename MethodFunctor> |
Niels Möller | 9dde120 | 2022-03-21 10:36:32 +0100 | [diff] [blame] | 72 | class OnSuccessObserver : public webrtc::SetRemoteDescriptionObserverInterface { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 73 | public: |
| 74 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 75 | : on_success_(std::move(on_success)) {} |
| 76 | |
| 77 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 78 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 79 | RTC_CHECK(error.ok()); |
| 80 | on_success_(); |
| 81 | } |
| 82 | |
| 83 | private: |
| 84 | MethodFunctor on_success_; |
| 85 | }; |
| 86 | |
Mirko Bonadei | 6a489f2 | 2019-04-09 15:11:12 +0200 | [diff] [blame] | 87 | class PeerConnectionRtpBaseTest : public ::testing::Test { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 88 | public: |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 89 | explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics) |
| 90 | : sdp_semantics_(sdp_semantics), |
| 91 | pc_factory_( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 92 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 93 | rtc::Thread::Current(), |
| 94 | rtc::Thread::Current(), |
| 95 | FakeAudioCaptureModule::Create(), |
| 96 | CreateBuiltinAudioEncoderFactory(), |
| 97 | CreateBuiltinAudioDecoderFactory(), |
Anders Carlsson | 6753795 | 2018-05-03 11:28:29 +0200 | [diff] [blame] | 98 | CreateBuiltinVideoEncoderFactory(), |
| 99 | CreateBuiltinVideoDecoderFactory(), |
| 100 | nullptr /* audio_mixer */, |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame] | 101 | nullptr /* audio_processing */)) { |
| 102 | webrtc::metrics::Reset(); |
| 103 | } |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 104 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 105 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 106 | return CreatePeerConnection(RTCConfiguration()); |
| 107 | } |
| 108 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 109 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() { |
| 110 | RTCConfiguration config; |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 111 | config.sdp_semantics = SdpSemantics::kPlanB_DEPRECATED; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 112 | return CreatePeerConnectionInternal(config); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 113 | } |
| 114 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 115 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 116 | RTCConfiguration config; |
| 117 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 118 | return CreatePeerConnectionInternal(config); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 119 | } |
| 120 | |
| 121 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 122 | const RTCConfiguration& config) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 123 | RTCConfiguration modified_config = config; |
| 124 | modified_config.sdp_semantics = sdp_semantics_; |
| 125 | return CreatePeerConnectionInternal(modified_config); |
| 126 | } |
| 127 | |
| 128 | protected: |
| 129 | const SdpSemantics sdp_semantics_; |
| 130 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
| 131 | |
| 132 | private: |
| 133 | // Private so that tests don't accidentally bypass the SdpSemantics |
| 134 | // adjustment. |
| 135 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal( |
| 136 | const RTCConfiguration& config) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 137 | auto observer = std::make_unique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 138 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 139 | observer.get()); |
Yves Gerey | 4e93329 | 2018-10-31 15:36:05 +0100 | [diff] [blame] | 140 | EXPECT_TRUE(pc.get()); |
| 141 | observer->SetPeerConnectionInterface(pc.get()); |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 142 | return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc, |
| 143 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 144 | } |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 145 | }; |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 146 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 147 | class PeerConnectionRtpTest |
| 148 | : public PeerConnectionRtpBaseTest, |
| 149 | public ::testing::WithParamInterface<SdpSemantics> { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 150 | protected: |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 151 | PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {} |
| 152 | }; |
| 153 | |
| 154 | class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest { |
| 155 | protected: |
| 156 | PeerConnectionRtpTestPlanB() |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 157 | : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB_DEPRECATED) {} |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 158 | }; |
| 159 | |
| 160 | class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest { |
| 161 | protected: |
| 162 | PeerConnectionRtpTestUnifiedPlan() |
| 163 | : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {} |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 164 | |
| 165 | // Helper to emulate an SFU that rejects an offered media section |
| 166 | // in answer. |
| 167 | bool ExchangeOfferAnswerWhereRemoteStopsTransceiver( |
| 168 | PeerConnectionWrapper* caller, |
| 169 | PeerConnectionWrapper* callee, |
| 170 | size_t mid_to_stop) { |
| 171 | auto offer = caller->CreateOffer(); |
| 172 | caller->SetLocalDescription(CloneSessionDescription(offer.get())); |
| 173 | callee->SetRemoteDescription(std::move(offer)); |
| 174 | EXPECT_LT(mid_to_stop, callee->pc()->GetTransceivers().size()); |
| 175 | // Must use StopInternal in order to do instant reject. |
| 176 | callee->pc()->GetTransceivers()[mid_to_stop]->StopInternal(); |
| 177 | auto answer = callee->CreateAnswer(); |
| 178 | EXPECT_TRUE(answer); |
| 179 | bool set_local_answer = |
| 180 | callee->SetLocalDescription(CloneSessionDescription(answer.get())); |
| 181 | EXPECT_TRUE(set_local_answer); |
| 182 | bool set_remote_answer = caller->SetRemoteDescription(std::move(answer)); |
| 183 | EXPECT_TRUE(set_remote_answer); |
| 184 | return set_remote_answer; |
| 185 | } |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 186 | }; |
| 187 | |
Artem Titov | cfea218 | 2021-08-10 01:22:31 +0200 | [diff] [blame] | 188 | // These tests cover `webrtc::PeerConnectionObserver` callbacks firing upon |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 189 | // setting the remote description. |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 190 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 191 | TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 192 | auto caller = CreatePeerConnection(); |
| 193 | auto callee = CreatePeerConnection(); |
| 194 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 195 | ASSERT_TRUE(caller->AddAudioTrack("audio_track")); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 196 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 197 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 198 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 199 | const auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 200 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 201 | |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 202 | if (sdp_semantics_ == SdpSemantics::kPlanB_DEPRECATED) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 203 | // Since we are not supporting the no stream case with Plan B, there should |
| 204 | // be a generated stream, even though we didn't set one with AddTrack. |
| 205 | ASSERT_EQ(1u, add_track_event.streams.size()); |
| 206 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 207 | } else { |
| 208 | EXPECT_EQ(0u, add_track_event.streams.size()); |
| 209 | } |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 210 | } |
| 211 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 212 | TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 213 | auto caller = CreatePeerConnection(); |
| 214 | auto callee = CreatePeerConnection(); |
| 215 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 216 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 217 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 218 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 219 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 220 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 221 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 222 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->id()); |
Henrik Boström | 9e6fd2b | 2017-11-21 13:41:51 +0100 | [diff] [blame] | 223 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 224 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 225 | } |
| 226 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 227 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 228 | auto caller = CreatePeerConnection(); |
| 229 | auto callee = CreatePeerConnection(); |
| 230 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 231 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 232 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 233 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 234 | ASSERT_TRUE( |
| 235 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
| 236 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 237 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 238 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 239 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 240 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 241 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 242 | callee->observer()->remove_track_events_); |
| 243 | } |
| 244 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 245 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 246 | auto caller = CreatePeerConnection(); |
| 247 | auto callee = CreatePeerConnection(); |
| 248 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 249 | auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 250 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 251 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 252 | ASSERT_TRUE( |
| 253 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
| 254 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 255 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 256 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 257 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 258 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 259 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 260 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 261 | EXPECT_EQ(0u, callee->observer()->remote_streams()->count()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 262 | } |
| 263 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 264 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 265 | auto caller = CreatePeerConnection(); |
| 266 | auto callee = CreatePeerConnection(); |
| 267 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 268 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 269 | auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId}); |
| 270 | auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 271 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 272 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 273 | ASSERT_TRUE( |
| 274 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 275 | |
| 276 | // Remove "audio_track1". |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 277 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender1).ok()); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 278 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 279 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 280 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 281 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 282 | callee->observer()->add_track_events_[0].receiver}, |
| 283 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 284 | ASSERT_EQ(1u, callee->observer()->remote_streams()->count()); |
| 285 | ASSERT_TRUE( |
| 286 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 287 | |
| 288 | // Remove "audio_track2". |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 289 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender2).ok()); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 290 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 291 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 292 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 293 | callee->observer()->remove_track_events_); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 294 | EXPECT_EQ(0u, callee->observer()->remote_streams()->count()); |
Henrik Boström | 933d8b0 | 2017-10-10 10:05:16 -0700 | [diff] [blame] | 295 | } |
| 296 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 297 | // Tests the edge case that if a stream ID changes for a given track that both |
| 298 | // OnRemoveTrack and OnAddTrack is fired. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 299 | TEST_F(PeerConnectionRtpTestPlanB, |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 300 | RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) { |
| 301 | auto caller = CreatePeerConnection(); |
| 302 | auto callee = CreatePeerConnection(); |
| 303 | |
| 304 | const char kStreamId1[] = "stream1"; |
| 305 | const char kStreamId2[] = "stream2"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 306 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 307 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 308 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 309 | |
| 310 | // Change the stream ID of the sender in the session description. |
| 311 | auto offer = caller->CreateOfferAndSetAsLocal(); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 312 | auto* audio_desc = |
| 313 | cricket::GetFirstAudioContentDescription(offer->description()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 314 | ASSERT_EQ(audio_desc->mutable_streams().size(), 1u); |
| 315 | audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2}); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 316 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 317 | |
| 318 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
| 319 | EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(), |
| 320 | kStreamId2); |
| 321 | ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u); |
| 322 | EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(), |
| 323 | kStreamId1); |
| 324 | } |
| 325 | |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 326 | // Tests that setting a remote description with sending transceivers will fire |
| 327 | // the OnTrack callback for each transceiver and setting a remote description |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 328 | // with receive only transceivers will not call OnTrack. One transceiver is |
| 329 | // created without any stream_ids, while the other is created with multiple |
| 330 | // stream_ids. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 331 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) { |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 332 | const std::string kStreamId1 = "video_stream1"; |
| 333 | const std::string kStreamId2 = "video_stream2"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 334 | auto caller = CreatePeerConnection(); |
| 335 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 336 | |
| 337 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 338 | RtpTransceiverInit video_transceiver_init; |
| 339 | video_transceiver_init.stream_ids = {kStreamId1, kStreamId2}; |
| 340 | auto video_transceiver = |
| 341 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 342 | |
| 343 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 344 | |
| 345 | ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 346 | ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 347 | EXPECT_EQ(audio_transceiver->mid(), |
| 348 | callee->pc()->GetTransceivers()[0]->mid()); |
| 349 | EXPECT_EQ(video_transceiver->mid(), |
| 350 | callee->pc()->GetTransceivers()[1]->mid()); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 351 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams = |
| 352 | callee->pc()->GetTransceivers()[0]->receiver()->streams(); |
| 353 | std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams = |
| 354 | callee->pc()->GetTransceivers()[1]->receiver()->streams(); |
| 355 | ASSERT_EQ(0u, audio_streams.size()); |
| 356 | ASSERT_EQ(2u, video_streams.size()); |
| 357 | EXPECT_EQ(kStreamId1, video_streams[0]->id()); |
| 358 | EXPECT_EQ(kStreamId2, video_streams[1]->id()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 359 | } |
| 360 | |
| 361 | // Test that doing additional offer/answer exchanges with no changes to tracks |
| 362 | // will cause no additional OnTrack calls after the tracks have been negotiated. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 363 | TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) { |
| 364 | auto caller = CreatePeerConnection(); |
| 365 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 366 | |
| 367 | caller->AddAudioTrack("audio"); |
| 368 | callee->AddAudioTrack("audio"); |
| 369 | |
| 370 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 371 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 372 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 373 | |
| 374 | // If caller reoffers with no changes expect no additional OnTrack calls. |
| 375 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 376 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 377 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 378 | |
| 379 | // Also if callee reoffers with no changes expect no additional OnTrack calls. |
| 380 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 381 | EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size()); |
| 382 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 383 | } |
| 384 | |
| 385 | // Test that OnTrack is called when the transceiver direction changes to send |
| 386 | // the track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 387 | TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) { |
| 388 | auto caller = CreatePeerConnection(); |
| 389 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 390 | |
| 391 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 392 | EXPECT_TRUE( |
| 393 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive) |
| 394 | .ok()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 395 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 396 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 397 | EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size()); |
| 398 | |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 399 | EXPECT_TRUE( |
| 400 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendOnly) |
| 401 | .ok()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 402 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 403 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 404 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 405 | |
| 406 | // If the direction changes but it is still receiving on the remote side, then |
| 407 | // OnTrack should not be fired again. |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 408 | EXPECT_TRUE( |
| 409 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv) |
| 410 | .ok()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 411 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 412 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 413 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 414 | } |
| 415 | |
| 416 | // Test that OnTrack is called twice when a sendrecv call is started, the callee |
| 417 | // changes the direction to inactive, then changes it back to sendrecv. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 418 | TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) { |
| 419 | auto caller = CreatePeerConnection(); |
| 420 | auto callee = CreatePeerConnection(); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 421 | |
| 422 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 423 | |
| 424 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 425 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 426 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 427 | |
| 428 | // Put the call on hold by no longer receiving the track. |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 429 | EXPECT_TRUE(callee->pc() |
| 430 | ->GetTransceivers()[0] |
| 431 | ->SetDirectionWithError(RtpTransceiverDirection::kInactive) |
| 432 | .ok()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 433 | |
| 434 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 435 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 436 | EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 437 | |
| 438 | // Resume the call by changing the direction to recvonly. This should call |
| 439 | // OnTrack again on the callee side. |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 440 | EXPECT_TRUE(callee->pc() |
| 441 | ->GetTransceivers()[0] |
| 442 | ->SetDirectionWithError(RtpTransceiverDirection::kRecvOnly) |
| 443 | .ok()); |
Steve Anton | 8b815cd | 2018-02-16 16:14:42 -0800 | [diff] [blame] | 444 | |
| 445 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 446 | EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size()); |
| 447 | EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size()); |
| 448 | } |
| 449 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 450 | // Test that setting a remote offer twice with no answer in the middle results |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 451 | // in OnAddTrack being fired only once. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 452 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 453 | ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 454 | auto caller = CreatePeerConnection(); |
| 455 | auto callee = CreatePeerConnection(); |
| 456 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 457 | caller->AddAudioTrack("audio_track", {}); |
| 458 | |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 459 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 460 | ASSERT_EQ(1u, callee->observer()->add_track_events_.size()); |
| 461 | |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 462 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 463 | EXPECT_EQ(1u, callee->observer()->add_track_events_.size()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 464 | } |
| 465 | |
| 466 | // Test that setting a remote offer twice with no answer in the middle and the |
| 467 | // track being removed between the two offers results in OnAddTrack being called |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 468 | // once the first time and OnRemoveTrack being called once the second time. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 469 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 470 | ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 471 | auto caller = CreatePeerConnection(); |
| 472 | auto callee = CreatePeerConnection(); |
| 473 | |
| 474 | auto sender = caller->AddAudioTrack("audio_track", {}); |
| 475 | |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 476 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 477 | ASSERT_EQ(1u, callee->observer()->add_track_events_.size()); |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 478 | EXPECT_EQ(0u, callee->observer()->remove_track_events_.size()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 479 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 480 | caller->pc()->RemoveTrackOrError(sender); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 481 | |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 482 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 483 | EXPECT_EQ(1u, callee->observer()->add_track_events_.size()); |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 484 | EXPECT_EQ(1u, callee->observer()->remove_track_events_.size()); |
| 485 | } |
| 486 | |
| 487 | // Test that changing the direction from receiving to not receiving between |
| 488 | // setting the remote offer and creating / setting the local answer results in |
| 489 | // a remove track event when SetLocalDescription is called. |
| 490 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 491 | ChangeDirectionInAnswerResultsInRemoveTrackEvent) { |
| 492 | auto caller = CreatePeerConnection(); |
| 493 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 494 | auto callee = CreatePeerConnection(); |
| 495 | callee->AddAudioTrack("audio_track", {}); |
| 496 | |
| 497 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 498 | EXPECT_EQ(1u, callee->observer()->add_track_events_.size()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 499 | EXPECT_EQ(0u, callee->observer()->remove_track_events_.size()); |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 500 | |
| 501 | auto callee_transceiver = callee->pc()->GetTransceivers()[0]; |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 502 | EXPECT_TRUE(callee_transceiver |
| 503 | ->SetDirectionWithError(RtpTransceiverDirection::kSendOnly) |
| 504 | .ok()); |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 505 | |
| 506 | ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer())); |
| 507 | EXPECT_EQ(1u, callee->observer()->add_track_events_.size()); |
| 508 | EXPECT_EQ(1u, callee->observer()->remove_track_events_.size()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 509 | } |
| 510 | |
Henrik Boström | afa07dd | 2018-12-20 11:06:02 +0100 | [diff] [blame] | 511 | TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) { |
| 512 | auto caller = CreatePeerConnection(); |
| 513 | caller->AddAudioTrack("audio_track", {"stream1"}); |
| 514 | auto callee = CreatePeerConnection(); |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 515 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | afa07dd | 2018-12-20 11:06:02 +0100 | [diff] [blame] | 516 | |
| 517 | ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size()); |
| 518 | auto transceiver = callee->observer()->on_track_transceivers_[0]; |
| 519 | ASSERT_EQ(1u, transceiver->receiver()->streams().size()); |
| 520 | EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id()); |
| 521 | |
Amit Hilbuch | ae3df54 | 2019-01-07 12:13:08 -0800 | [diff] [blame] | 522 | ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal()); |
Henrik Boström | afa07dd | 2018-12-20 11:06:02 +0100 | [diff] [blame] | 523 | |
| 524 | // Change the stream ID in the offer. |
Guido Urdaneta | 1ff16c8 | 2019-05-20 19:31:53 +0200 | [diff] [blame] | 525 | caller->pc()->GetSenders()[0]->SetStreams({"stream2"}); |
| 526 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | afa07dd | 2018-12-20 11:06:02 +0100 | [diff] [blame] | 527 | ASSERT_EQ(1u, transceiver->receiver()->streams().size()); |
| 528 | EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id()); |
| 529 | } |
| 530 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 531 | // These tests examine the state of the peer connection as a result of |
| 532 | // performing SetRemoteDescription(). |
| 533 | |
| 534 | TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) { |
| 535 | auto caller = CreatePeerConnection(); |
| 536 | auto callee = CreatePeerConnection(); |
| 537 | |
| 538 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 539 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 540 | |
| 541 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 542 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 543 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 544 | |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 545 | if (sdp_semantics_ == SdpSemantics::kPlanB_DEPRECATED) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 546 | // Since we are not supporting the no stream case with Plan B, there should |
| 547 | // be a generated stream, even though we didn't set one with AddTrack. |
| 548 | ASSERT_EQ(1u, receiver_added->streams().size()); |
| 549 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 550 | } else { |
| 551 | EXPECT_EQ(0u, receiver_added->streams().size()); |
| 552 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 553 | } |
| 554 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 555 | TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 556 | auto caller = CreatePeerConnection(); |
| 557 | auto callee = CreatePeerConnection(); |
| 558 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 559 | ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"})); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 560 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 561 | |
| 562 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 563 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 564 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 565 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
Seth Hampson | 13b8bad | 2018-03-13 16:05:28 -0700 | [diff] [blame] | 566 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 567 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 568 | } |
| 569 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 570 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 571 | auto caller = CreatePeerConnection(); |
| 572 | auto callee = CreatePeerConnection(); |
| 573 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 574 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 575 | ASSERT_TRUE(sender); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 576 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 577 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 578 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 579 | auto receiver = callee->pc()->GetReceivers()[0]; |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 580 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 581 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 582 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 583 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 584 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 585 | // inactive. |
| 586 | ASSERT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 587 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 588 | callee->pc()->GetTransceivers()[0]->current_direction()); |
| 589 | } else { |
| 590 | // With Plan B the receiver is removed. |
| 591 | ASSERT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 592 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 593 | } |
| 594 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 595 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 596 | auto caller = CreatePeerConnection(); |
| 597 | auto callee = CreatePeerConnection(); |
| 598 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 599 | auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 600 | ASSERT_TRUE(sender); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 601 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 602 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 603 | auto receiver = callee->pc()->GetReceivers()[0]; |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 604 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 605 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 606 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 607 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 608 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 609 | // inactive. |
| 610 | EXPECT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 611 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 612 | callee->pc()->GetTransceivers()[0]->current_direction()); |
| 613 | } else { |
| 614 | // With Plan B the receiver is removed. |
| 615 | EXPECT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 616 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 617 | } |
| 618 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 619 | TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 620 | auto caller = CreatePeerConnection(); |
| 621 | auto callee = CreatePeerConnection(); |
| 622 | |
Seth Hampson | 845e878 | 2018-03-02 11:34:10 -0800 | [diff] [blame] | 623 | const char kSharedStreamId[] = "shared_audio_stream"; |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 624 | auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId}); |
| 625 | auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId}); |
| 626 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 627 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 628 | |
| 629 | // Remove "audio_track1". |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 630 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender1).ok()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 631 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 632 | |
| 633 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 634 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 635 | // inactive. |
| 636 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
| 637 | auto transceiver = callee->pc()->GetTransceivers()[0]; |
| 638 | EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id()); |
| 639 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 640 | transceiver->current_direction()); |
| 641 | } else { |
| 642 | // With Plan B the receiver is removed. |
| 643 | ASSERT_EQ(1u, callee->pc()->GetReceivers().size()); |
| 644 | EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id()); |
| 645 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 646 | |
| 647 | // Remove "audio_track2". |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 648 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender2).ok()); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 649 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 650 | |
| 651 | if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) { |
| 652 | // With Unified Plan the receiver stays but the transceiver transitions to |
| 653 | // inactive. |
| 654 | ASSERT_EQ(2u, callee->pc()->GetReceivers().size()); |
| 655 | auto transceiver = callee->pc()->GetTransceivers()[1]; |
| 656 | EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id()); |
| 657 | EXPECT_EQ(RtpTransceiverDirection::kInactive, |
| 658 | transceiver->current_direction()); |
| 659 | } else { |
| 660 | // With Plan B the receiver is removed. |
| 661 | ASSERT_EQ(0u, callee->pc()->GetReceivers().size()); |
| 662 | } |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 663 | } |
| 664 | |
Florent Castelli | abe301f | 2018-06-12 18:33:49 +0200 | [diff] [blame] | 665 | TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) { |
| 666 | auto caller = CreatePeerConnection(); |
| 667 | auto callee = CreatePeerConnection(); |
| 668 | auto sender = caller->AddAudioTrack("audio_track"); |
| 669 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 670 | |
| 671 | ASSERT_GT(caller->pc()->GetSenders().size(), 0u); |
| 672 | EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u); |
| 673 | |
| 674 | ASSERT_GT(callee->pc()->GetReceivers().size(), 0u); |
| 675 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 676 | EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u); |
| 677 | } |
| 678 | |
| 679 | TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) { |
| 680 | auto caller = CreatePeerConnection(); |
| 681 | auto callee = CreatePeerConnection(); |
| 682 | auto sender = caller->AddVideoTrack("video_track"); |
| 683 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 684 | |
| 685 | ASSERT_GT(caller->pc()->GetSenders().size(), 0u); |
| 686 | EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u); |
| 687 | |
| 688 | ASSERT_GT(callee->pc()->GetReceivers().size(), 0u); |
| 689 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 690 | EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u); |
| 691 | } |
| 692 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 693 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 694 | // calls and examine the state of the peer connection inside the callbacks to |
| 695 | // ensure that the second call does not occur prematurely, contaminating the |
| 696 | // state of the peer connection of the first callback. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 697 | TEST_F(PeerConnectionRtpTestPlanB, |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 698 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 699 | auto caller = CreatePeerConnection(); |
| 700 | auto callee = CreatePeerConnection(); |
| 701 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 702 | // Create SDP for adding a track and for removing it. This will be used in the |
| 703 | // first and second SetRemoteDescription() calls. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 704 | auto sender = caller->AddAudioTrack("audio_track", {}); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 705 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 706 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 707 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 708 | |
| 709 | // In the first SetRemoteDescription() callback, check that we have a |
| 710 | // receiver for the track. |
| 711 | auto pc = callee->pc(); |
| 712 | bool srd1_callback_called = false; |
| 713 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 714 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 715 | srd1_callback_called = true; |
| 716 | }; |
| 717 | |
| 718 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 719 | // been removed. |
| 720 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 721 | // Instead, the transceiver owning the receiver will become inactive. |
| 722 | // https://crbug.com/webrtc/7600 |
| 723 | bool srd2_callback_called = false; |
| 724 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 725 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 726 | srd2_callback_called = true; |
| 727 | }; |
| 728 | |
| 729 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 730 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 731 | // effects of the second SetRemoteDescription() call must not have happened by |
| 732 | // the time the first callback is invoked. If it has then the receiver that is |
| 733 | // added as a result of the first SetRemoteDescription() call will already |
| 734 | // have been removed as a result of the second SetRemoteDescription() call |
| 735 | // when the first callback is invoked. |
| 736 | callee->pc()->SetRemoteDescription( |
| 737 | std::move(srd1_sdp), |
Niels Möller | e7cc883 | 2022-01-04 15:20:03 +0100 | [diff] [blame] | 738 | rtc::make_ref_counted<OnSuccessObserver<decltype(srd1_callback)>>( |
| 739 | srd1_callback)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 740 | callee->pc()->SetRemoteDescription( |
| 741 | std::move(srd2_sdp), |
Niels Möller | e7cc883 | 2022-01-04 15:20:03 +0100 | [diff] [blame] | 742 | rtc::make_ref_counted<OnSuccessObserver<decltype(srd2_callback)>>( |
| 743 | srd2_callback)); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 744 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 745 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 746 | } |
| 747 | |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 748 | // Tests that a remote track is created with the signaled MSIDs when they are |
| 749 | // communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc |
| 750 | // lines). |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 751 | TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) { |
| 752 | auto caller = CreatePeerConnection(); |
| 753 | auto callee = CreatePeerConnection(); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 754 | const char kStreamId1[] = "stream1"; |
| 755 | const char kStreamId2[] = "stream2"; |
| 756 | caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 757 | {kStreamId1, kStreamId2}); |
| 758 | |
| 759 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 760 | // Munge the offer to take out everything but the stream_ids. |
| 761 | auto contents = offer->description()->contents(); |
| 762 | ASSERT_TRUE(!contents.empty()); |
| 763 | ASSERT_TRUE(!contents[0].media_description()->streams().empty()); |
| 764 | std::vector<std::string> stream_ids = |
| 765 | contents[0].media_description()->streams()[0].stream_ids(); |
| 766 | contents[0].media_description()->mutable_streams().clear(); |
| 767 | cricket::StreamParams new_stream; |
| 768 | new_stream.set_stream_ids(stream_ids); |
| 769 | contents[0].media_description()->AddStream(new_stream); |
| 770 | |
| 771 | // Set the remote description and verify that the streams were added to the |
| 772 | // receiver correctly. |
| 773 | ASSERT_TRUE( |
| 774 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
| 775 | auto receivers = callee->pc()->GetReceivers(); |
| 776 | ASSERT_EQ(receivers.size(), 1u); |
| 777 | ASSERT_EQ(receivers[0]->streams().size(), 2u); |
| 778 | EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1); |
| 779 | EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2); |
| 780 | } |
Henrik Boström | c335b0e | 2021-04-08 07:25:38 +0200 | [diff] [blame] | 781 | TEST_F(PeerConnectionRtpTestUnifiedPlan, TracksDoNotEndWhenSsrcChanges) { |
| 782 | constexpr uint32_t kFirstMungedSsrc = 1337u; |
| 783 | |
| 784 | auto caller = CreatePeerConnection(); |
| 785 | auto callee = CreatePeerConnection(); |
| 786 | |
| 787 | // Caller offers to receive audio and video. |
| 788 | RtpTransceiverInit init; |
| 789 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 790 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 791 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); |
| 792 | |
| 793 | // Callee wants to send audio and video tracks. |
| 794 | callee->AddTrack(callee->CreateAudioTrack("audio_track"), {}); |
| 795 | callee->AddTrack(callee->CreateVideoTrack("video_track"), {}); |
| 796 | |
| 797 | // Do inittial offer/answer exchange. |
| 798 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
| 799 | ASSERT_TRUE( |
| 800 | caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal())); |
| 801 | ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u); |
| 802 | ASSERT_EQ(caller->pc()->GetReceivers().size(), 2u); |
| 803 | |
| 804 | // Do a follow-up offer/answer exchange where the SSRCs are modified. |
| 805 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
| 806 | auto answer = callee->CreateAnswer(); |
| 807 | auto& contents = answer->description()->contents(); |
| 808 | ASSERT_TRUE(!contents.empty()); |
| 809 | for (size_t i = 0; i < contents.size(); ++i) { |
| 810 | auto& mutable_streams = contents[i].media_description()->mutable_streams(); |
| 811 | ASSERT_EQ(mutable_streams.size(), 1u); |
| 812 | mutable_streams[0].ssrcs = {kFirstMungedSsrc + static_cast<uint32_t>(i)}; |
| 813 | } |
| 814 | ASSERT_TRUE( |
| 815 | callee->SetLocalDescription(CloneSessionDescription(answer.get()))); |
| 816 | ASSERT_TRUE( |
| 817 | caller->SetRemoteDescription(CloneSessionDescription(answer.get()))); |
| 818 | |
| 819 | // No furher track events should fire because we never changed direction, only |
| 820 | // SSRCs. |
| 821 | ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u); |
| 822 | // We should have the same number of receivers as before. |
| 823 | auto receivers = caller->pc()->GetReceivers(); |
| 824 | ASSERT_EQ(receivers.size(), 2u); |
| 825 | // The tracks are still alive. |
| 826 | EXPECT_EQ(receivers[0]->track()->state(), |
| 827 | MediaStreamTrackInterface::TrackState::kLive); |
| 828 | EXPECT_EQ(receivers[1]->track()->state(), |
| 829 | MediaStreamTrackInterface::TrackState::kLive); |
| 830 | } |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 831 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 832 | // Tests that with Unified Plan if the the stream id changes for a track when |
| 833 | // when setting a new remote description, that the media stream is updated |
| 834 | // appropriately for the receiver. |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 835 | // TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix |
| 836 | // test. |
| 837 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 838 | DISABLED_RemoteStreamIdChangesUpdatesReceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 839 | auto caller = CreatePeerConnection(); |
| 840 | auto callee = CreatePeerConnection(); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 841 | |
| 842 | const char kStreamId1[] = "stream1"; |
| 843 | const char kStreamId2[] = "stream2"; |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 844 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
Seth Hampson | 5897a6e | 2018-04-03 11:16:33 -0700 | [diff] [blame] | 845 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 846 | EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 847 | |
| 848 | // Change the stream id of the sender in the session description. |
| 849 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 850 | auto contents = offer->description()->contents(); |
| 851 | ASSERT_EQ(contents.size(), 1u); |
| 852 | ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u); |
| 853 | contents[0].media_description()->mutable_streams()[0].set_stream_ids( |
| 854 | {kStreamId2}); |
| 855 | |
Steve Anton | 0f5400a | 2018-07-17 14:25:36 -0700 | [diff] [blame] | 856 | // Set the remote description and verify that the stream was updated |
| 857 | // properly. |
| 858 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 859 | auto receivers = callee->pc()->GetReceivers(); |
| 860 | ASSERT_EQ(receivers.size(), 1u); |
| 861 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 862 | EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2); |
| 863 | } |
| 864 | |
| 865 | // This tests a regression caught by a downstream client, that occured when |
| 866 | // applying a remote description with a SessionDescription object that |
| 867 | // contained StreamParams that didn't have ids. Although there were multiple |
| 868 | // remote audio senders, FindSenderInfo didn't find them as unique, because |
| 869 | // it looked up by StreamParam.id, which none had. This meant only one |
| 870 | // AudioRtpReceiver was created, as opposed to one for each remote sender. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 871 | TEST_F(PeerConnectionRtpTestPlanB, |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 872 | MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) { |
| 873 | auto caller = CreatePeerConnection(); |
| 874 | auto callee = CreatePeerConnection(); |
| 875 | |
| 876 | const char kStreamId1[] = "stream1"; |
| 877 | const char kStreamId2[] = "stream2"; |
| 878 | caller->AddAudioTrack("audio_track1", {kStreamId1}); |
| 879 | caller->AddAudioTrack("audio_track2", {kStreamId2}); |
| 880 | |
| 881 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 882 | auto mutable_streams = |
| 883 | cricket::GetFirstAudioContentDescription(offer->description()) |
| 884 | ->mutable_streams(); |
| 885 | ASSERT_EQ(mutable_streams.size(), 2u); |
| 886 | // Clear the IDs in the StreamParams. |
| 887 | mutable_streams[0].id.clear(); |
| 888 | mutable_streams[1].id.clear(); |
| 889 | ASSERT_TRUE( |
| 890 | callee->SetRemoteDescription(CloneSessionDescription(offer.get()))); |
| 891 | |
| 892 | auto receivers = callee->pc()->GetReceivers(); |
| 893 | ASSERT_EQ(receivers.size(), 2u); |
| 894 | ASSERT_EQ(receivers[0]->streams().size(), 1u); |
| 895 | EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id()); |
| 896 | ASSERT_EQ(receivers[1]->streams().size(), 1u); |
| 897 | EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id()); |
| 898 | } |
| 899 | |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 900 | // Tests for the legacy SetRemoteDescription() function signature. |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 901 | |
| 902 | // Sanity test making sure the callback is invoked. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 903 | TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 904 | auto caller = CreatePeerConnection(); |
| 905 | auto callee = CreatePeerConnection(); |
| 906 | |
| 907 | std::string error; |
| 908 | ASSERT_TRUE( |
| 909 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 910 | } |
| 911 | |
| 912 | // Verifies legacy behavior: The observer is not called if if the peer |
| 913 | // connection is destroyed because the asynchronous callback is executed in the |
| 914 | // peer connection's message handler. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 915 | TEST_P(PeerConnectionRtpTest, |
| 916 | LegacyObserverNotCalledIfPeerConnectionDereferenced) { |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 917 | auto caller = CreatePeerConnection(); |
| 918 | auto callee = CreatePeerConnection(); |
| 919 | |
| 920 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
Tommi | 87f7090 | 2021-04-27 14:43:08 +0200 | [diff] [blame] | 921 | rtc::make_ref_counted<webrtc::MockSetSessionDescriptionObserver>(); |
Henrik Boström | 3163867 | 2017-11-23 17:48:32 +0100 | [diff] [blame] | 922 | |
| 923 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 924 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 925 | callee = nullptr; |
| 926 | rtc::Thread::Current()->ProcessMessages(0); |
| 927 | EXPECT_FALSE(observer->called()); |
| 928 | } |
| 929 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 930 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 931 | |
| 932 | // Test that by default there are no transceivers with Unified Plan. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 933 | TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) { |
| 934 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 935 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 936 | } |
| 937 | |
| 938 | // Test that a transceiver created with the audio kind has the correct initial |
| 939 | // properties. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 940 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 941 | AddTransceiverHasCorrectInitProperties) { |
| 942 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 943 | |
| 944 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Danil Chapovalov | 66cadcc | 2018-06-19 16:47:43 +0200 | [diff] [blame] | 945 | EXPECT_EQ(absl::nullopt, transceiver->mid()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 946 | EXPECT_FALSE(transceiver->stopped()); |
| 947 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
Danil Chapovalov | 66cadcc | 2018-06-19 16:47:43 +0200 | [diff] [blame] | 948 | EXPECT_EQ(absl::nullopt, transceiver->current_direction()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 949 | } |
| 950 | |
| 951 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 952 | // and audio receiver with the receiver having a live audio track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 953 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 954 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 955 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 956 | |
| 957 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 958 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 959 | |
| 960 | ASSERT_TRUE(transceiver->sender()); |
| 961 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 962 | |
| 963 | ASSERT_TRUE(transceiver->receiver()); |
| 964 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 965 | |
| 966 | auto track = transceiver->receiver()->track(); |
| 967 | ASSERT_TRUE(track); |
| 968 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 969 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 970 | } |
| 971 | |
| 972 | // Test that adding a transceiver with the video kind creates an video sender |
| 973 | // and video receiver with the receiver having a live video track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 974 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 975 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 976 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 977 | |
| 978 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
Steve Anton | 6947025 | 2018-02-09 11:43:08 -0800 | [diff] [blame] | 979 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type()); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 980 | |
| 981 | ASSERT_TRUE(transceiver->sender()); |
| 982 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 983 | |
| 984 | ASSERT_TRUE(transceiver->receiver()); |
| 985 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 986 | |
| 987 | auto track = transceiver->receiver()->track(); |
| 988 | ASSERT_TRUE(track); |
| 989 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 990 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 991 | } |
| 992 | |
| 993 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 994 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 995 | // transceiver's receiver shows in GetReceivers(). |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 996 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) { |
| 997 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 998 | |
| 999 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1000 | EXPECT_EQ( |
| 1001 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 1002 | caller->pc()->GetTransceivers()); |
| 1003 | EXPECT_EQ( |
| 1004 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 1005 | transceiver->sender()}, |
| 1006 | caller->pc()->GetSenders()); |
| 1007 | EXPECT_EQ( |
| 1008 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 1009 | transceiver->receiver()}, |
| 1010 | caller->pc()->GetReceivers()); |
| 1011 | } |
| 1012 | |
| 1013 | // Test that the direction passed in through the AddTransceiver init parameter |
| 1014 | // is set in the returned transceiver. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1015 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1016 | AddTransceiverWithDirectionIsReflected) { |
| 1017 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1018 | |
| 1019 | RtpTransceiverInit init; |
| 1020 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 1021 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 1022 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 1023 | } |
| 1024 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1025 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 1026 | // its sender's track set to the passed-in track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1027 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1028 | AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 1029 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1030 | |
| 1031 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 1032 | auto transceiver = caller->AddTransceiver(audio_track); |
| 1033 | |
| 1034 | auto sender = transceiver->sender(); |
| 1035 | ASSERT_TRUE(sender->track()); |
| 1036 | EXPECT_EQ(audio_track, sender->track()); |
| 1037 | |
| 1038 | auto receiver = transceiver->receiver(); |
| 1039 | ASSERT_TRUE(receiver->track()); |
| 1040 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 1041 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 1042 | receiver->track()->state()); |
| 1043 | } |
| 1044 | |
| 1045 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 1046 | // transceivers, senders with the same track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1047 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1048 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1049 | auto caller = CreatePeerConnection(); |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 1050 | |
| 1051 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 1052 | |
| 1053 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 1054 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 1055 | |
| 1056 | EXPECT_NE(transceiver1, transceiver2); |
| 1057 | |
| 1058 | auto sender1 = transceiver1->sender(); |
| 1059 | auto sender2 = transceiver2->sender(); |
| 1060 | EXPECT_NE(sender1, sender2); |
| 1061 | EXPECT_EQ(audio_track, sender1->track()); |
| 1062 | EXPECT_EQ(audio_track, sender2->track()); |
| 1063 | |
| 1064 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 1065 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 1066 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 1067 | UnorderedElementsAre(sender1, sender2)); |
| 1068 | } |
| 1069 | |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 1070 | // RtpTransceiver error handling tests. |
| 1071 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1072 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1073 | AddTransceiverWithInvalidKindReturnsError) { |
| 1074 | auto caller = CreatePeerConnection(); |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 1075 | |
| 1076 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 1077 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 1078 | } |
| 1079 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1080 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1081 | CanClosePeerConnectionWithoutCrashing) { |
| 1082 | auto caller = CreatePeerConnection(); |
Steve Anton | 3fe1b15 | 2017-12-12 10:20:08 -0800 | [diff] [blame] | 1083 | |
| 1084 | caller->pc()->Close(); |
| 1085 | } |
| 1086 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1087 | // Unified Plan AddTrack tests. |
| 1088 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1089 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 1090 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1091 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) { |
| 1092 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1093 | |
| 1094 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1095 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1096 | ASSERT_TRUE(sender); |
| 1097 | |
| 1098 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 1099 | EXPECT_EQ(audio_track, sender->track()); |
| 1100 | } |
| 1101 | |
| 1102 | // Test that adding a video track creates a new video RtpSender with the given |
| 1103 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1104 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) { |
| 1105 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1106 | |
| 1107 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1108 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1109 | ASSERT_TRUE(sender); |
| 1110 | |
| 1111 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 1112 | EXPECT_EQ(video_track, sender->track()); |
| 1113 | } |
| 1114 | |
| 1115 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 1116 | // with the sender that AddTrack returns and in the sendrecv direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1117 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) { |
| 1118 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1119 | |
| 1120 | auto sender = caller->AddAudioTrack("a"); |
| 1121 | ASSERT_TRUE(sender); |
| 1122 | |
| 1123 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1124 | ASSERT_EQ(1u, transceivers.size()); |
| 1125 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 1126 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 1127 | } |
| 1128 | |
| 1129 | // Test that if a transceiver of the same type but no track had been added to |
| 1130 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 1131 | // is the transceiver's sender and the sender's track is the newly-added track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1132 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) { |
| 1133 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1134 | |
| 1135 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1136 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1137 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1138 | ASSERT_TRUE(sender); |
| 1139 | |
| 1140 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1141 | ASSERT_EQ(1u, transceivers.size()); |
| 1142 | EXPECT_EQ(transceiver, transceivers[0]); |
| 1143 | EXPECT_EQ(sender, transceiver->sender()); |
| 1144 | EXPECT_EQ(audio_track, sender->track()); |
| 1145 | } |
| 1146 | |
| 1147 | // Test that adding two tracks to a new PeerConnection creates two |
| 1148 | // RtpTransceivers in the same order. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1149 | TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) { |
| 1150 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1151 | |
| 1152 | auto sender1 = caller->AddAudioTrack("a"); |
| 1153 | auto sender2 = caller->AddVideoTrack("v"); |
| 1154 | ASSERT_TRUE(sender2); |
| 1155 | |
| 1156 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1157 | ASSERT_EQ(2u, transceivers.size()); |
| 1158 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 1159 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 1160 | } |
| 1161 | |
| 1162 | // Test that if there are multiple transceivers with no sending track then a |
| 1163 | // later call to AddTrack will use the one of the same type as the newly-added |
| 1164 | // track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1165 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) { |
| 1166 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1167 | |
| 1168 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1169 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 1170 | auto sender = caller->AddVideoTrack("v"); |
| 1171 | |
| 1172 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 1173 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 1174 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 1175 | } |
| 1176 | |
| 1177 | // Test that if the only transceivers that do not have a sending track have a |
| 1178 | // different type from the added track, then AddTrack will create a new |
| 1179 | // transceiver for the track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1180 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1181 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1182 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1183 | |
| 1184 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1185 | auto sender = caller->AddVideoTrack("v"); |
| 1186 | |
| 1187 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1188 | ASSERT_EQ(2u, transceivers.size()); |
| 1189 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 1190 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 1191 | } |
| 1192 | |
| 1193 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 1194 | // are available. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1195 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1196 | AddTrackReusesFirstMatchingTransceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1197 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1198 | |
| 1199 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1200 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1201 | auto sender = caller->AddAudioTrack("a"); |
| 1202 | |
| 1203 | auto transceivers = caller->pc()->GetTransceivers(); |
| 1204 | ASSERT_EQ(2u, transceivers.size()); |
| 1205 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 1206 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 1207 | } |
| 1208 | |
| 1209 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 1210 | // direction from inactive to sendonly. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1211 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1212 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1213 | auto caller = CreatePeerConnection(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1214 | auto callee = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1215 | |
| 1216 | RtpTransceiverInit init; |
| 1217 | init.direction = RtpTransceiverDirection::kInactive; |
| 1218 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1219 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1220 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1221 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1222 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1223 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1224 | caller->observer()->clear_latest_negotiation_needed_event(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1225 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1226 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1227 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1228 | |
| 1229 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 1230 | } |
| 1231 | |
| 1232 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 1233 | // direction from recvonly to sendrecv. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1234 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1235 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1236 | auto caller = CreatePeerConnection(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1237 | auto callee = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1238 | |
| 1239 | RtpTransceiverInit init; |
| 1240 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 1241 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1242 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1243 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1244 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1245 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1246 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1247 | caller->observer()->clear_latest_negotiation_needed_event(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1248 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1249 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1250 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1251 | |
| 1252 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 1253 | } |
| 1254 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1255 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) { |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 1256 | const std::string kTrackId = "audio_track"; |
| 1257 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1258 | auto caller = CreatePeerConnection(); |
Steve Anton | 02ee47c | 2018-01-10 16:26:06 -0800 | [diff] [blame] | 1259 | |
| 1260 | auto audio_track = caller->CreateAudioTrack(kTrackId); |
| 1261 | auto sender = caller->AddTrack(audio_track); |
| 1262 | |
| 1263 | EXPECT_EQ(kTrackId, sender->id()); |
| 1264 | } |
| 1265 | |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1266 | // Unified Plan AddTrack error handling. |
| 1267 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1268 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) { |
| 1269 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1270 | |
| 1271 | auto audio_track = caller->CreateAudioTrack("a"); |
| 1272 | caller->pc()->Close(); |
| 1273 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1274 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1275 | caller->observer()->clear_latest_negotiation_needed_event(); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1276 | auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>()); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1277 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1278 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1279 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1280 | } |
| 1281 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1282 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) { |
| 1283 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1284 | |
| 1285 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1286 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1287 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1288 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1289 | caller->observer()->clear_latest_negotiation_needed_event(); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1290 | auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>()); |
Steve Anton | 2d6c76a | 2018-01-05 17:10:52 -0800 | [diff] [blame] | 1291 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1292 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1293 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1294 | } |
| 1295 | |
| 1296 | // Unified Plan RemoveTrack tests. |
| 1297 | |
| 1298 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 1299 | // clears the sender's track. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1300 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) { |
| 1301 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1302 | |
| 1303 | auto sender = caller->AddAudioTrack("a"); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1304 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1305 | |
| 1306 | EXPECT_FALSE(sender->track()); |
| 1307 | } |
| 1308 | |
| 1309 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1310 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1311 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1312 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1313 | auto caller = CreatePeerConnection(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1314 | auto callee = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1315 | |
| 1316 | RtpTransceiverInit init; |
| 1317 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 1318 | auto transceiver = |
| 1319 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1320 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1321 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1322 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1323 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1324 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1325 | caller->observer()->clear_latest_negotiation_needed_event(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1326 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1327 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(transceiver->sender()).ok()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1328 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1329 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1330 | |
| 1331 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1332 | } |
| 1333 | |
| 1334 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 1335 | // in the sendonly direction changes the transceiver's direction to inactive. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1336 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1337 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1338 | auto caller = CreatePeerConnection(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1339 | auto callee = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1340 | |
| 1341 | RtpTransceiverInit init; |
| 1342 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 1343 | auto transceiver = |
| 1344 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1345 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1346 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1347 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1348 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1349 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1350 | caller->observer()->clear_latest_negotiation_needed_event(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1351 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1352 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(transceiver->sender()).ok()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1353 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1354 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1355 | |
| 1356 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 1357 | } |
| 1358 | |
| 1359 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 1360 | // no change in state. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1361 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 1362 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1363 | |
| 1364 | auto sender = caller->AddAudioTrack("a"); |
| 1365 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 1366 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 1367 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1368 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1369 | caller->observer()->clear_latest_negotiation_needed_event(); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1370 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1371 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1372 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1373 | |
| 1374 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 1375 | } |
| 1376 | |
| 1377 | // Unified Plan RemoveTrack error handling. |
| 1378 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1379 | TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) { |
| 1380 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1381 | |
| 1382 | auto sender = caller->AddAudioTrack("a"); |
| 1383 | caller->pc()->Close(); |
| 1384 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1385 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1386 | caller->observer()->clear_latest_negotiation_needed_event(); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1387 | EXPECT_FALSE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1388 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1389 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1390 | } |
| 1391 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1392 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1393 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1394 | auto caller = CreatePeerConnection(); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1395 | |
| 1396 | auto sender = caller->AddAudioTrack("a"); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1397 | ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1398 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1399 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1400 | caller->observer()->clear_latest_negotiation_needed_event(); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1401 | EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1402 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1403 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | f9381f0 | 2017-12-14 10:23:57 -0800 | [diff] [blame] | 1404 | } |
| 1405 | |
Steve Anton | 60b6c1d | 2018-06-13 11:32:27 -0700 | [diff] [blame] | 1406 | // Test that setting offers that add/remove/add a track repeatedly without |
| 1407 | // setting the appropriate answer in between works. |
| 1408 | // These are regression tests for bugs.webrtc.org/9401 |
| 1409 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) { |
| 1410 | auto caller = CreatePeerConnection(); |
| 1411 | |
| 1412 | auto sender1 = caller->AddAudioTrack("audio1"); |
| 1413 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1414 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1415 | caller->pc()->RemoveTrackOrError(sender1); |
Steve Anton | 60b6c1d | 2018-06-13 11:32:27 -0700 | [diff] [blame] | 1416 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1417 | |
| 1418 | // This will re-use the transceiver created by the first AddTrack. |
| 1419 | auto sender2 = caller->AddAudioTrack("audio2"); |
| 1420 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1421 | |
| 1422 | EXPECT_EQ(1u, caller->pc()->GetTransceivers().size()); |
| 1423 | EXPECT_EQ(sender1, sender2); |
| 1424 | } |
| 1425 | TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) { |
| 1426 | auto caller = CreatePeerConnection(); |
| 1427 | |
| 1428 | auto sender1 = caller->AddVideoTrack("video1"); |
| 1429 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1430 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1431 | caller->pc()->RemoveTrackOrError(sender1); |
Steve Anton | 60b6c1d | 2018-06-13 11:32:27 -0700 | [diff] [blame] | 1432 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1433 | |
| 1434 | // This will re-use the transceiver created by the first AddTrack. |
| 1435 | auto sender2 = caller->AddVideoTrack("video2"); |
| 1436 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1437 | |
| 1438 | EXPECT_EQ(1u, caller->pc()->GetTransceivers().size()); |
| 1439 | EXPECT_EQ(sender1, sender2); |
| 1440 | } |
| 1441 | |
Steve Anton | 0756373 | 2018-06-26 11:13:50 -0700 | [diff] [blame] | 1442 | // Test that CreateOffer succeeds if two tracks with the same label are added. |
| 1443 | TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) { |
| 1444 | auto caller = CreatePeerConnection(); |
| 1445 | |
| 1446 | auto audio_sender = caller->AddAudioTrack("track", {}); |
| 1447 | auto video_sender = caller->AddVideoTrack("track", {}); |
| 1448 | |
| 1449 | EXPECT_TRUE(caller->CreateOffer()); |
| 1450 | |
| 1451 | EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id()); |
| 1452 | EXPECT_NE(audio_sender->id(), video_sender->id()); |
| 1453 | } |
| 1454 | |
| 1455 | // Test that CreateAnswer succeeds if two tracks with the same label are added. |
| 1456 | TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) { |
| 1457 | auto caller = CreatePeerConnection(); |
| 1458 | auto callee = CreatePeerConnection(); |
| 1459 | |
| 1460 | RtpTransceiverInit recvonly; |
| 1461 | recvonly.direction = RtpTransceiverDirection::kRecvOnly; |
| 1462 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly); |
| 1463 | caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly); |
| 1464 | |
| 1465 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
| 1466 | |
| 1467 | auto audio_sender = callee->AddAudioTrack("track", {}); |
| 1468 | auto video_sender = callee->AddVideoTrack("track", {}); |
| 1469 | |
| 1470 | EXPECT_TRUE(callee->CreateAnswer()); |
| 1471 | |
| 1472 | EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id()); |
| 1473 | EXPECT_NE(audio_sender->id(), video_sender->id()); |
| 1474 | } |
| 1475 | |
| 1476 | // Test that calling AddTrack, RemoveTrack and AddTrack again creates a second |
| 1477 | // m= section with a random sender id (different from the first, now rejected, |
| 1478 | // m= section). |
| 1479 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1480 | AddRemoveAddTrackGeneratesNewSenderId) { |
| 1481 | auto caller = CreatePeerConnection(); |
| 1482 | auto callee = CreatePeerConnection(); |
| 1483 | |
| 1484 | auto track = caller->CreateVideoTrack("video"); |
| 1485 | auto sender1 = caller->AddTrack(track); |
| 1486 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1487 | |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1488 | caller->pc()->RemoveTrackOrError(sender1); |
Steve Anton | 0756373 | 2018-06-26 11:13:50 -0700 | [diff] [blame] | 1489 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1490 | |
| 1491 | auto sender2 = caller->AddTrack(track); |
| 1492 | |
| 1493 | EXPECT_NE(sender1, sender2); |
| 1494 | EXPECT_NE(sender1->id(), sender2->id()); |
| 1495 | std::string sender2_id = sender2->id(); |
| 1496 | |
| 1497 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1498 | |
| 1499 | // The sender's ID should not change after negotiation. |
| 1500 | EXPECT_EQ(sender2_id, sender2->id()); |
| 1501 | } |
| 1502 | |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1503 | // Test that OnRenegotiationNeeded is fired if SetDirection is called on an |
| 1504 | // active RtpTransceiver with a new direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1505 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1506 | RenegotiationNeededAfterTransceiverSetDirection) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1507 | auto caller = CreatePeerConnection(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1508 | auto callee = CreatePeerConnection(); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1509 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1510 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1511 | |
| 1512 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1513 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1514 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1515 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1516 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1517 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1518 | caller->observer()->clear_latest_negotiation_needed_event(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 1519 | |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 1520 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1521 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 1522 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1523 | } |
| 1524 | |
| 1525 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on an |
| 1526 | // active RtpTransceiver with current direction. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1527 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1528 | NoRenegotiationNeededAfterTransceiverSetSameDirection) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1529 | auto caller = CreatePeerConnection(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1530 | |
| 1531 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1532 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1533 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1534 | caller->observer()->clear_latest_negotiation_needed_event(); |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 1535 | transceiver->SetDirectionWithError(transceiver->direction()); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1536 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1537 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1538 | } |
| 1539 | |
| 1540 | // Test that OnRenegotiationNeeded is not fired if SetDirection is called on a |
| 1541 | // stopped RtpTransceiver. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1542 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1543 | NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1544 | auto caller = CreatePeerConnection(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1545 | |
| 1546 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 1547 | transceiver->StopInternal(); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1548 | |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1549 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 1550 | caller->observer()->clear_latest_negotiation_needed_event(); |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 1551 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 1552 | EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed()); |
| 1553 | EXPECT_FALSE(caller->observer()->has_negotiation_needed_event()); |
Steve Anton | 52d8677 | 2018-02-20 15:48:12 -0800 | [diff] [blame] | 1554 | } |
| 1555 | |
Harald Alvestrand | 6060df5 | 2020-08-11 09:54:02 +0200 | [diff] [blame] | 1556 | // Test that currentDirection returnes "stopped" if the transceiver was stopped. |
| 1557 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1558 | CheckStoppedCurrentDirectionOnStoppedTransceiver) { |
| 1559 | auto caller = CreatePeerConnection(); |
| 1560 | |
| 1561 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1562 | transceiver->StopInternal(); |
| 1563 | |
| 1564 | EXPECT_TRUE(transceiver->stopping()); |
| 1565 | EXPECT_TRUE(transceiver->stopped()); |
| 1566 | EXPECT_EQ(RtpTransceiverDirection::kStopped, |
| 1567 | transceiver->current_direction()); |
| 1568 | } |
| 1569 | |
| 1570 | // Test that InvalidState is thrown on a stopping transceiver. |
| 1571 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1572 | CheckForInvalidStateOnStoppingTransceiver) { |
| 1573 | auto caller = CreatePeerConnection(); |
| 1574 | |
| 1575 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1576 | transceiver->StopStandard(); |
| 1577 | |
| 1578 | EXPECT_TRUE(transceiver->stopping()); |
| 1579 | EXPECT_FALSE(transceiver->stopped()); |
| 1580 | EXPECT_EQ( |
| 1581 | RTCErrorType::INVALID_STATE, |
| 1582 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive) |
| 1583 | .type()); |
| 1584 | } |
| 1585 | |
| 1586 | // Test that InvalidState is thrown on a stopped transceiver. |
| 1587 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1588 | CheckForInvalidStateOnStoppedTransceiver) { |
| 1589 | auto caller = CreatePeerConnection(); |
| 1590 | |
| 1591 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1592 | transceiver->StopInternal(); |
| 1593 | |
| 1594 | EXPECT_TRUE(transceiver->stopping()); |
| 1595 | EXPECT_TRUE(transceiver->stopped()); |
| 1596 | EXPECT_EQ( |
| 1597 | RTCErrorType::INVALID_STATE, |
| 1598 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive) |
| 1599 | .type()); |
| 1600 | } |
| 1601 | |
| 1602 | // Test that TypeError is thrown if the direction is set to "stopped". |
| 1603 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1604 | CheckForTypeErrorForStoppedOnTransceiver) { |
| 1605 | auto caller = CreatePeerConnection(); |
| 1606 | |
| 1607 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1608 | EXPECT_EQ( |
| 1609 | RTCErrorType::INVALID_PARAMETER, |
| 1610 | transceiver->SetDirectionWithError(RtpTransceiverDirection::kStopped) |
| 1611 | .type()); |
| 1612 | } |
| 1613 | |
Harald Alvestrand | 198cd73 | 2020-09-16 12:41:23 +0000 | [diff] [blame] | 1614 | // Test that you can do createOffer/setLocalDescription with a stopped |
| 1615 | // media section. |
| 1616 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1617 | SetLocalDescriptionWithStoppedMediaSection) { |
| 1618 | auto caller = CreatePeerConnection(); |
| 1619 | auto callee = CreatePeerConnection(); |
| 1620 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1621 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1622 | callee->pc()->GetTransceivers()[0]->StopStandard(); |
| 1623 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 1624 | EXPECT_EQ(RtpTransceiverDirection::kStopped, |
| 1625 | transceiver->current_direction()); |
| 1626 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1627 | } |
| 1628 | |
Harald Alvestrand | 936f1af | 2020-09-22 07:41:50 +0000 | [diff] [blame] | 1629 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1630 | StopAndNegotiateCausesTransceiverToDisappear) { |
| 1631 | auto caller = CreatePeerConnection(); |
| 1632 | auto callee = CreatePeerConnection(); |
| 1633 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 1634 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1635 | callee->pc()->GetTransceivers()[0]->StopStandard(); |
| 1636 | ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get())); |
| 1637 | EXPECT_EQ(RtpTransceiverDirection::kStopped, |
| 1638 | transceiver->current_direction()); |
| 1639 | EXPECT_EQ(0U, caller->pc()->GetTransceivers().size()); |
| 1640 | EXPECT_EQ(0U, callee->pc()->GetTransceivers().size()); |
| 1641 | EXPECT_EQ(0U, caller->pc()->GetSenders().size()); |
| 1642 | EXPECT_EQ(0U, callee->pc()->GetSenders().size()); |
| 1643 | EXPECT_EQ(0U, caller->pc()->GetReceivers().size()); |
| 1644 | EXPECT_EQ(0U, callee->pc()->GetReceivers().size()); |
| 1645 | } |
| 1646 | |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 1647 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1648 | SetLocalDescriptionWorksAfterRepeatedAddRemove) { |
| 1649 | auto caller = CreatePeerConnection(); |
| 1650 | auto callee = CreatePeerConnection(); |
| 1651 | auto video_track = caller->CreateVideoTrack("v"); |
| 1652 | auto track = caller->CreateAudioTrack("a"); |
| 1653 | caller->AddTransceiver(video_track); |
| 1654 | auto transceiver = caller->AddTransceiver(track); |
| 1655 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1656 | caller->pc()->RemoveTrackOrError(transceiver->sender()); |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 1657 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1658 | caller->AddTrack(track); |
| 1659 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1660 | caller->pc()->RemoveTrackOrError(transceiver->sender()); |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 1661 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1662 | } |
| 1663 | |
| 1664 | // This is a repro of Chromium bug https://crbug.com/1134686 |
| 1665 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1666 | SetLocalDescriptionWorksAfterRepeatedAddRemoveWithRemoteReject) { |
| 1667 | auto caller = CreatePeerConnection(); |
| 1668 | auto callee = CreatePeerConnection(); |
| 1669 | auto video_track = caller->CreateVideoTrack("v"); |
| 1670 | auto track = caller->CreateAudioTrack("a"); |
| 1671 | caller->AddTransceiver(video_track); |
| 1672 | auto transceiver = caller->AddTransceiver(track); |
| 1673 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1674 | caller->pc()->RemoveTrackOrError(transceiver->sender()); |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 1675 | ExchangeOfferAnswerWhereRemoteStopsTransceiver(caller.get(), callee.get(), 1); |
| 1676 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1677 | caller->AddTrack(track); |
| 1678 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Harald Alvestrand | 93dd763 | 2022-01-19 12:28:45 +0000 | [diff] [blame] | 1679 | caller->pc()->RemoveTrackOrError(transceiver->sender()); |
Harald Alvestrand | 09bd9ba | 2020-10-09 08:13:30 +0000 | [diff] [blame] | 1680 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1681 | } |
| 1682 | |
Florent Castelli | 892acf0 | 2018-10-01 22:47:20 +0200 | [diff] [blame] | 1683 | // Test that AddTransceiver fails if trying to use unimplemented RTP encoding |
| 1684 | // parameters with the send_encodings parameters. |
| 1685 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 1686 | CheckForUnsupportedEncodingParameters) { |
| 1687 | auto caller = CreatePeerConnection(); |
| 1688 | |
| 1689 | RtpTransceiverInit init; |
| 1690 | init.send_encodings.emplace_back(); |
| 1691 | |
| 1692 | auto default_send_encodings = init.send_encodings; |
| 1693 | |
Henrik Grunell | e1301a8 | 2018-12-13 12:13:22 +0000 | [diff] [blame] | 1694 | // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx, |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 1695 | // ptime, scale_framerate_down_by, dependency_rids. |
Florent Castelli | 892acf0 | 2018-10-01 22:47:20 +0200 | [diff] [blame] | 1696 | init.send_encodings[0].ssrc = 1; |
| 1697 | EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER, |
| 1698 | caller->pc() |
| 1699 | ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init) |
| 1700 | .error() |
| 1701 | .type()); |
| 1702 | init.send_encodings = default_send_encodings; |
Florent Castelli | 892acf0 | 2018-10-01 22:47:20 +0200 | [diff] [blame] | 1703 | } |
| 1704 | |
Florent Castelli | c1a0bcb | 2019-01-29 14:26:48 +0100 | [diff] [blame] | 1705 | // Test that AddTransceiver fails if trying to use invalid RTP encoding |
| 1706 | // parameters with the send_encodings parameters. |
| 1707 | TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) { |
| 1708 | auto caller = CreatePeerConnection(); |
| 1709 | |
| 1710 | RtpTransceiverInit init; |
| 1711 | init.send_encodings.emplace_back(); |
| 1712 | |
| 1713 | auto default_send_encodings = init.send_encodings; |
| 1714 | |
| 1715 | init.send_encodings[0].scale_resolution_down_by = 0.5; |
| 1716 | EXPECT_EQ(RTCErrorType::INVALID_RANGE, |
| 1717 | caller->pc() |
| 1718 | ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init) |
| 1719 | .error() |
| 1720 | .type()); |
| 1721 | init.send_encodings = default_send_encodings; |
| 1722 | |
| 1723 | init.send_encodings[0].bitrate_priority = 0; |
| 1724 | EXPECT_EQ(RTCErrorType::INVALID_RANGE, |
| 1725 | caller->pc() |
| 1726 | ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init) |
| 1727 | .error() |
| 1728 | .type()); |
| 1729 | init.send_encodings = default_send_encodings; |
| 1730 | |
| 1731 | init.send_encodings[0].min_bitrate_bps = 200000; |
| 1732 | init.send_encodings[0].max_bitrate_bps = 100000; |
| 1733 | EXPECT_EQ(RTCErrorType::INVALID_RANGE, |
| 1734 | caller->pc() |
| 1735 | ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init) |
| 1736 | .error() |
| 1737 | .type()); |
| 1738 | init.send_encodings = default_send_encodings; |
| 1739 | |
| 1740 | init.send_encodings[0].num_temporal_layers = 0; |
| 1741 | EXPECT_EQ(RTCErrorType::INVALID_RANGE, |
| 1742 | caller->pc() |
| 1743 | ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init) |
| 1744 | .error() |
| 1745 | .type()); |
| 1746 | init.send_encodings = default_send_encodings; |
| 1747 | |
| 1748 | init.send_encodings[0].num_temporal_layers = 5; |
| 1749 | EXPECT_EQ(RTCErrorType::INVALID_RANGE, |
| 1750 | caller->pc() |
| 1751 | ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init) |
| 1752 | .error() |
| 1753 | .type()); |
| 1754 | init.send_encodings = default_send_encodings; |
| 1755 | } |
| 1756 | |
Florent Castelli | 892acf0 | 2018-10-01 22:47:20 +0200 | [diff] [blame] | 1757 | // Test that AddTransceiver transfers the send_encodings to the sender and they |
| 1758 | // are retained after SetLocalDescription(). |
| 1759 | TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) { |
| 1760 | auto caller = CreatePeerConnection(); |
| 1761 | |
| 1762 | RtpTransceiverInit init; |
| 1763 | init.send_encodings.emplace_back(); |
| 1764 | init.send_encodings[0].active = false; |
| 1765 | init.send_encodings[0].max_bitrate_bps = 180000; |
| 1766 | |
| 1767 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 1768 | ASSERT_TRUE(result.ok()); |
| 1769 | |
| 1770 | auto init_send_encodings = result.value()->sender()->init_send_encodings(); |
| 1771 | EXPECT_FALSE(init_send_encodings[0].active); |
| 1772 | EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000); |
| 1773 | |
| 1774 | auto parameters = result.value()->sender()->GetParameters(); |
| 1775 | EXPECT_FALSE(parameters.encodings[0].active); |
| 1776 | EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000); |
| 1777 | |
| 1778 | ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer())); |
| 1779 | |
| 1780 | parameters = result.value()->sender()->GetParameters(); |
| 1781 | EXPECT_FALSE(parameters.encodings[0].active); |
| 1782 | EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000); |
| 1783 | } |
| 1784 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1785 | // Test MSID signaling between Unified Plan and Plan B endpoints. There are two |
| 1786 | // options for this kind of signaling: media section based (a=msid) and ssrc |
| 1787 | // based (a=ssrc MSID). While JSEP only specifies media section MSID signaling, |
| 1788 | // we want to ensure compatibility with older Plan B endpoints that might expect |
| 1789 | // ssrc based MSID signaling. Thus we test here that Unified Plan offers both |
| 1790 | // types but answers with the same type as the offer. |
| 1791 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1792 | class PeerConnectionMsidSignalingTest |
| 1793 | : public PeerConnectionRtpTestUnifiedPlan {}; |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1794 | |
| 1795 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) { |
| 1796 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1797 | caller->AddAudioTrack("caller_audio"); |
| 1798 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1799 | callee->AddAudioTrack("callee_audio"); |
| 1800 | |
| 1801 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1802 | |
| 1803 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1804 | auto* offer = callee->pc()->remote_description(); |
| 1805 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1806 | cricket::kMsidSignalingSsrcAttribute), |
| 1807 | offer->description()->msid_signaling()); |
| 1808 | |
| 1809 | // Answer should have had only a=msid lines. |
| 1810 | auto* answer = caller->pc()->remote_description(); |
| 1811 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1812 | answer->description()->msid_signaling()); |
Harald Alvestrand | 5dbb586 | 2018-02-13 23:48:00 +0100 | [diff] [blame] | 1813 | // Check that this is counted correctly |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1814 | EXPECT_METRIC_THAT( |
| 1815 | metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"), |
| 1816 | ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2))); |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1817 | } |
| 1818 | |
| 1819 | TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) { |
| 1820 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1821 | caller->AddAudioTrack("caller_audio"); |
| 1822 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1823 | callee->AddAudioTrack("callee_audio"); |
| 1824 | |
| 1825 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1826 | |
| 1827 | // Offer should have only a=ssrc MSID lines. |
| 1828 | auto* offer = callee->pc()->remote_description(); |
| 1829 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1830 | offer->description()->msid_signaling()); |
| 1831 | |
| 1832 | // Answer should have only a=ssrc MSID lines to match the offer. |
| 1833 | auto* answer = caller->pc()->remote_description(); |
| 1834 | EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute, |
| 1835 | answer->description()->msid_signaling()); |
| 1836 | } |
| 1837 | |
Seth Hampson | 5b4f075 | 2018-04-02 16:31:36 -0700 | [diff] [blame] | 1838 | // This tests that a Plan B endpoint appropriately sets the remote description |
| 1839 | // from a Unified Plan offer. When the Unified Plan offer contains a=msid lines |
| 1840 | // that signal no stream ids or multiple stream ids we expect that the Plan B |
| 1841 | // endpoint always has exactly one media stream per track. |
| 1842 | TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) { |
| 1843 | const std::string kStreamId1 = "audio_stream_1"; |
| 1844 | const std::string kStreamId2 = "audio_stream_2"; |
| 1845 | |
| 1846 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1847 | caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2}); |
| 1848 | caller->AddVideoTrack("caller_video", {}); |
| 1849 | auto callee = CreatePeerConnectionWithPlanB(); |
| 1850 | callee->AddAudioTrack("callee_audio"); |
| 1851 | caller->AddVideoTrack("callee_video"); |
| 1852 | |
| 1853 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
| 1854 | |
| 1855 | // Offer should have had both a=msid and a=ssrc MSID lines. |
| 1856 | auto* offer = callee->pc()->remote_description(); |
| 1857 | EXPECT_EQ((cricket::kMsidSignalingMediaSection | |
| 1858 | cricket::kMsidSignalingSsrcAttribute), |
| 1859 | offer->description()->msid_signaling()); |
| 1860 | |
| 1861 | // Callee should always have 1 stream for all of it's receivers. |
| 1862 | const auto& track_events = callee->observer()->add_track_events_; |
| 1863 | ASSERT_EQ(2u, track_events.size()); |
| 1864 | ASSERT_EQ(1u, track_events[0].streams.size()); |
| 1865 | EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id()); |
| 1866 | ASSERT_EQ(1u, track_events[1].streams.size()); |
| 1867 | // This autogenerated a stream id for the empty one signalled. |
| 1868 | EXPECT_FALSE(track_events[1].streams[0]->id().empty()); |
| 1869 | } |
| 1870 | |
Steve Anton | e831b8c | 2018-02-01 12:22:16 -0800 | [diff] [blame] | 1871 | TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) { |
| 1872 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1873 | caller->AddAudioTrack("caller_audio"); |
| 1874 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1875 | callee->AddAudioTrack("callee_audio"); |
| 1876 | |
| 1877 | auto offer = caller->CreateOffer(); |
| 1878 | // Simulate a pure Unified Plan offerer by setting the MSID signaling to media |
| 1879 | // section only. |
| 1880 | offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection); |
| 1881 | |
| 1882 | ASSERT_TRUE( |
| 1883 | caller->SetLocalDescription(CloneSessionDescription(offer.get()))); |
| 1884 | ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer))); |
| 1885 | |
| 1886 | // Answer should have only a=msid to match the offer. |
| 1887 | auto answer = callee->CreateAnswer(); |
| 1888 | EXPECT_EQ(cricket::kMsidSignalingMediaSection, |
| 1889 | answer->description()->msid_signaling()); |
| 1890 | } |
| 1891 | |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1892 | // Test that the correct UMA metrics are reported for simple/complex SDP. |
| 1893 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1894 | class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {}; |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1895 | |
Mirko Bonadei | 5eb43b4 | 2021-01-18 13:24:40 +0100 | [diff] [blame] | 1896 | #ifdef WEBRTC_HAVE_SCTP |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1897 | TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) { |
| 1898 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1899 | caller->CreateDataChannel("dc"); |
| 1900 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1901 | |
| 1902 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame] | 1903 | // Note that only the callee does ReportSdpFormatReceived. |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1904 | EXPECT_METRIC_THAT( |
| 1905 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"), |
| 1906 | ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1))); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1907 | } |
Mirko Bonadei | 5eb43b4 | 2021-01-18 13:24:40 +0100 | [diff] [blame] | 1908 | #endif // WEBRTC_HAVE_SCTP |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1909 | |
| 1910 | TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) { |
| 1911 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1912 | caller->AddAudioTrack("audio"); |
| 1913 | caller->AddVideoTrack("video"); |
| 1914 | auto callee = CreatePeerConnectionWithPlanB(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1915 | |
| 1916 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame] | 1917 | // Note that only the callee does ReportSdpFormatReceived. |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1918 | EXPECT_METRIC_THAT( |
| 1919 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"), |
| 1920 | ElementsAre(Pair(kSdpFormatReceivedSimple, 1))); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1921 | } |
| 1922 | |
| 1923 | TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) { |
| 1924 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1925 | caller->AddVideoTrack("video"); // Video only. |
| 1926 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1927 | |
| 1928 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Steve Anton | c1e6e86 | 2019-03-04 14:43:44 -0800 | [diff] [blame] | 1929 | // Note that only the callee does ReportSdpFormatReceived. |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1930 | EXPECT_METRIC_THAT( |
| 1931 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"), |
| 1932 | ElementsAre(Pair(kSdpFormatReceivedSimple, 1))); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1933 | } |
| 1934 | |
| 1935 | TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) { |
| 1936 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 1937 | caller->AddAudioTrack("audio1"); |
| 1938 | caller->AddAudioTrack("audio2"); |
| 1939 | caller->AddVideoTrack("video"); |
| 1940 | auto callee = CreatePeerConnectionWithPlanB(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1941 | |
| 1942 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame] | 1943 | // Note that only the callee does ReportSdpFormatReceived. |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1944 | EXPECT_METRIC_THAT( |
| 1945 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"), |
| 1946 | ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1))); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1947 | } |
| 1948 | |
| 1949 | TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) { |
| 1950 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1951 | caller->AddVideoTrack("video1"); |
| 1952 | caller->AddVideoTrack("video2"); |
| 1953 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1954 | |
Steve Anton | ba42e99 | 2018-04-09 14:10:01 -0700 | [diff] [blame] | 1955 | // This fails since Unified Plan cannot set a session description with |
| 1956 | // multiple "Plan B tracks" in the same media section. But we still expect the |
| 1957 | // SDP Format to be recorded. |
| 1958 | ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer())); |
Qingsi Wang | 7fc821d | 2018-07-12 12:54:53 -0700 | [diff] [blame] | 1959 | // Note that only the callee does ReportSdpFormatReceived. |
Ying Wang | ef3998f | 2019-12-09 13:06:53 +0100 | [diff] [blame] | 1960 | EXPECT_METRIC_THAT( |
| 1961 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"), |
| 1962 | ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1))); |
Steve Anton | 8e20f17 | 2018-03-06 10:55:04 -0800 | [diff] [blame] | 1963 | } |
| 1964 | |
Philipp Hancke | b8ca2a1 | 2020-10-07 12:47:10 +0200 | [diff] [blame] | 1965 | TEST_F(SdpFormatReceivedTest, AnswerIsReported) { |
| 1966 | auto caller = CreatePeerConnectionWithPlanB(); |
| 1967 | caller->AddAudioTrack("audio"); |
| 1968 | caller->AddVideoTrack("video"); |
| 1969 | auto callee = CreatePeerConnectionWithUnifiedPlan(); |
| 1970 | |
| 1971 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
| 1972 | ASSERT_TRUE(caller->SetRemoteDescription(callee->CreateAnswer())); |
| 1973 | EXPECT_METRIC_THAT( |
| 1974 | metrics::Samples("WebRTC.PeerConnection.SdpFormatReceivedAnswer"), |
| 1975 | ElementsAre(Pair(kSdpFormatReceivedSimple, 1))); |
| 1976 | } |
| 1977 | |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1978 | // Sender setups in a call. |
| 1979 | |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1980 | TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) { |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 1981 | auto caller = CreatePeerConnection(); |
| 1982 | auto callee = CreatePeerConnection(); |
| 1983 | |
| 1984 | auto track = caller->CreateAudioTrack("audio_track"); |
| 1985 | auto sender1 = caller->AddTrack(track); |
| 1986 | ASSERT_TRUE(sender1); |
| 1987 | // We need to temporarily reset the track for the subsequent AddTrack() to |
| 1988 | // succeed. |
| 1989 | EXPECT_TRUE(sender1->SetTrack(nullptr)); |
| 1990 | auto sender2 = caller->AddTrack(track); |
| 1991 | EXPECT_TRUE(sender2); |
| 1992 | EXPECT_TRUE(sender1->SetTrack(track)); |
| 1993 | |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 1994 | if (sdp_semantics_ == SdpSemantics::kPlanB_DEPRECATED) { |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1995 | // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should |
Artem Titov | cfea218 | 2021-08-10 01:22:31 +0200 | [diff] [blame] | 1996 | // return true, and doing `callee->SetRemoteDescription()` should work. |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 1997 | EXPECT_FALSE(caller->CreateOfferAndSetAsLocal()); |
| 1998 | } else { |
| 1999 | EXPECT_TRUE(caller->CreateOfferAndSetAsLocal()); |
| 2000 | } |
Henrik Boström | 91d039b | 2018-01-11 17:43:30 +0100 | [diff] [blame] | 2001 | } |
| 2002 | |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 2003 | // This test exercises the code path that fires a NegotiationNeeded |
| 2004 | // notification when the stream IDs of the local description differ from |
Guido Urdaneta | 1ff16c8 | 2019-05-20 19:31:53 +0200 | [diff] [blame] | 2005 | // the ones in the transceiver. |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 2006 | TEST_F(PeerConnectionRtpTestUnifiedPlan, |
| 2007 | ChangeAssociatedStreamsTriggersRenegotiation) { |
| 2008 | auto caller = CreatePeerConnection(); |
| 2009 | auto callee = CreatePeerConnection(); |
| 2010 | |
| 2011 | RtpTransceiverInit init; |
| 2012 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 2013 | auto transceiver = |
| 2014 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 2015 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 2016 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 2017 | |
| 2018 | ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get())); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 2019 | caller->observer()->clear_legacy_renegotiation_needed(); |
| 2020 | caller->observer()->clear_latest_negotiation_needed_event(); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 2021 | |
Guido Urdaneta | 1ff16c8 | 2019-05-20 19:31:53 +0200 | [diff] [blame] | 2022 | transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"}); |
Henrik Boström | e574a31 | 2020-08-25 10:20:11 +0200 | [diff] [blame] | 2023 | EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed()); |
| 2024 | EXPECT_TRUE(caller->observer()->has_negotiation_needed_event()); |
Guido Urdaneta | 1ff16c8 | 2019-05-20 19:31:53 +0200 | [diff] [blame] | 2025 | |
| 2026 | ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); |
| 2027 | auto callee_streams = callee->pc()->GetReceivers()[0]->streams(); |
| 2028 | ASSERT_EQ(3u, callee_streams.size()); |
| 2029 | EXPECT_EQ("stream3", callee_streams[0]->id()); |
| 2030 | EXPECT_EQ("stream4", callee_streams[1]->id()); |
| 2031 | EXPECT_EQ("stream5", callee_streams[2]->id()); |
Guido Urdaneta | 70c2db1 | 2019-04-16 12:24:14 +0200 | [diff] [blame] | 2032 | } |
| 2033 | |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2034 | INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest, |
| 2035 | PeerConnectionRtpTest, |
Florent Castelli | 15a38de | 2022-04-06 00:38:21 +0200 | [diff] [blame^] | 2036 | Values(SdpSemantics::kPlanB_DEPRECATED, |
Mirko Bonadei | c84f661 | 2019-01-31 12:20:57 +0100 | [diff] [blame] | 2037 | SdpSemantics::kUnifiedPlan)); |
Steve Anton | 3172c03 | 2018-05-03 15:30:18 -0700 | [diff] [blame] | 2038 | |
Steve Anton | 9158ef6 | 2017-11-27 13:01:52 -0800 | [diff] [blame] | 2039 | } // namespace webrtc |