blob: 7098470baaeee98d0e74a6fc7074a87611f9596b [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020015#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010017#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070018#include "api/jsep.h"
19#include "api/mediastreaminterface.h"
20#include "api/peerconnectioninterface.h"
Yves Gerey2e00abc2018-10-05 15:39:24 +020021#include "api/umametrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
Seth Hampson5b4f0752018-04-02 16:31:36 -070024#include "pc/mediasession.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "pc/mediastream.h"
26#include "pc/mediastreamtrack.h"
27#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080028#include "pc/sdputils.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070029#include "pc/test/fakeaudiocapturemodule.h"
30#include "pc/test/mockpeerconnectionobservers.h"
31#include "rtc_base/checks.h"
32#include "rtc_base/gunit.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070033#include "rtc_base/refcountedobject.h"
34#include "rtc_base/scoped_ref_ptr.h"
35#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020036#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080037#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070038
39// This file contains tests for RTP Media API-related behavior of
40// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
41
Steve Anton9158ef62017-11-27 13:01:52 -080042namespace webrtc {
43
44using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
45using ::testing::ElementsAre;
46using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070047using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070048
Henrik Boström31638672017-11-23 17:48:32 +010049const uint32_t kDefaultTimeout = 10000u;
50
51template <typename MethodFunctor>
52class OnSuccessObserver : public rtc::RefCountedObject<
53 webrtc::SetRemoteDescriptionObserverInterface> {
54 public:
55 explicit OnSuccessObserver(MethodFunctor on_success)
56 : on_success_(std::move(on_success)) {}
57
58 // webrtc::SetRemoteDescriptionObserverInterface implementation.
59 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
60 RTC_CHECK(error.ok());
61 on_success_();
62 }
63
64 private:
65 MethodFunctor on_success_;
66};
67
Steve Anton3172c032018-05-03 15:30:18 -070068class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070069 public:
Steve Anton3172c032018-05-03 15:30:18 -070070 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
71 : sdp_semantics_(sdp_semantics),
72 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080073 CreatePeerConnectionFactory(rtc::Thread::Current(),
74 rtc::Thread::Current(),
75 rtc::Thread::Current(),
76 FakeAudioCaptureModule::Create(),
77 CreateBuiltinAudioEncoderFactory(),
78 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +020079 CreateBuiltinVideoEncoderFactory(),
80 CreateBuiltinVideoDecoderFactory(),
81 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -070082 nullptr /* audio_processing */)) {
83 webrtc::metrics::Reset();
84 }
Henrik Boström933d8b02017-10-10 10:05:16 -070085
Steve Anton9158ef62017-11-27 13:01:52 -080086 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
87 return CreatePeerConnection(RTCConfiguration());
88 }
89
Steve Antone831b8c2018-02-01 12:22:16 -080090 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
91 RTCConfiguration config;
92 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -070093 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -080094 }
95
Steve Anton9158ef62017-11-27 13:01:52 -080096 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
97 RTCConfiguration config;
98 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -070099 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800100 }
101
102 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
103 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700104 RTCConfiguration modified_config = config;
105 modified_config.sdp_semantics = sdp_semantics_;
106 return CreatePeerConnectionInternal(modified_config);
107 }
108
109 protected:
110 const SdpSemantics sdp_semantics_;
111 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
112
113 private:
114 // Private so that tests don't accidentally bypass the SdpSemantics
115 // adjustment.
116 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
117 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200118 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700119 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
120 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100121 EXPECT_TRUE(pc.get());
122 observer->SetPeerConnectionInterface(pc.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200123 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
124 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700125 }
Steve Anton3172c032018-05-03 15:30:18 -0700126};
Henrik Boström933d8b02017-10-10 10:05:16 -0700127
Steve Anton3172c032018-05-03 15:30:18 -0700128class PeerConnectionRtpTest
129 : public PeerConnectionRtpBaseTest,
130 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700131 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700132 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
133};
134
135class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
136 protected:
137 PeerConnectionRtpTestPlanB()
138 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
139};
140
141class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
142 protected:
143 PeerConnectionRtpTestUnifiedPlan()
144 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700145};
146
Henrik Boström31638672017-11-23 17:48:32 +0100147// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
148// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100149
Steve Anton3172c032018-05-03 15:30:18 -0700150TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700151 auto caller = CreatePeerConnection();
152 auto callee = CreatePeerConnection();
153
Steve Anton3172c032018-05-03 15:30:18 -0700154 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700155 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700156
Henrik Boström31638672017-11-23 17:48:32 +0100157 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700158 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100159 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700160
161 if (sdp_semantics_ == SdpSemantics::kPlanB) {
162 // Since we are not supporting the no stream case with Plan B, there should
163 // be a generated stream, even though we didn't set one with AddTrack.
164 ASSERT_EQ(1u, add_track_event.streams.size());
165 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
166 } else {
167 EXPECT_EQ(0u, add_track_event.streams.size());
168 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700169}
170
Steve Anton3172c032018-05-03 15:30:18 -0700171TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700172 auto caller = CreatePeerConnection();
173 auto callee = CreatePeerConnection();
174
Steve Anton3172c032018-05-03 15:30:18 -0700175 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700176 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700177
Henrik Boström31638672017-11-23 17:48:32 +0100178 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100179 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100180 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700181 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100182 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
183 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700184}
185
Steve Anton3172c032018-05-03 15:30:18 -0700186TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700187 auto caller = CreatePeerConnection();
188 auto callee = CreatePeerConnection();
189
Steve Anton3172c032018-05-03 15:30:18 -0700190 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700191 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100192 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700193 ASSERT_TRUE(
194 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
195
Henrik Boström933d8b02017-10-10 10:05:16 -0700196 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700197 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700198
Henrik Boström31638672017-11-23 17:48:32 +0100199 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700200 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
201 callee->observer()->remove_track_events_);
202}
203
Steve Anton3172c032018-05-03 15:30:18 -0700204TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700205 auto caller = CreatePeerConnection();
206 auto callee = CreatePeerConnection();
207
Steve Anton3172c032018-05-03 15:30:18 -0700208 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700209 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100210 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700211 ASSERT_TRUE(
212 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
213
Henrik Boström933d8b02017-10-10 10:05:16 -0700214 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700215 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700216
Henrik Boström31638672017-11-23 17:48:32 +0100217 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700218 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
219 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700220 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700221}
222
Steve Anton3172c032018-05-03 15:30:18 -0700223TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700224 auto caller = CreatePeerConnection();
225 auto callee = CreatePeerConnection();
226
Seth Hampson845e8782018-03-02 11:34:10 -0800227 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700228 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
229 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700230 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100231 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700232 ASSERT_TRUE(
233 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700234
235 // Remove "audio_track1".
236 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700237 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100238 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700239 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800240 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700241 callee->observer()->add_track_events_[0].receiver},
242 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700243 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
244 ASSERT_TRUE(
245 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700246
247 // Remove "audio_track2".
248 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700249 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100250 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700251 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
252 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700253 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700254}
255
Seth Hampson5b4f0752018-04-02 16:31:36 -0700256// Tests the edge case that if a stream ID changes for a given track that both
257// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700258TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700259 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
260 auto caller = CreatePeerConnection();
261 auto callee = CreatePeerConnection();
262
263 const char kStreamId1[] = "stream1";
264 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700265 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700266 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700267 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
268
269 // Change the stream ID of the sender in the session description.
270 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700271 auto* audio_desc =
272 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700273 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
274 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700275 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700276
277 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
278 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
279 kStreamId2);
280 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
281 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
282 kStreamId1);
283}
284
Steve Anton8b815cd2018-02-16 16:14:42 -0800285// Tests that setting a remote description with sending transceivers will fire
286// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700287// with receive only transceivers will not call OnTrack. One transceiver is
288// created without any stream_ids, while the other is created with multiple
289// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700290TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700291 const std::string kStreamId1 = "video_stream1";
292 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700293 auto caller = CreatePeerConnection();
294 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800295
296 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700297 RtpTransceiverInit video_transceiver_init;
298 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
299 auto video_transceiver =
300 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800301
302 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
303
304 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
305 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
306 EXPECT_EQ(audio_transceiver->mid(),
307 callee->pc()->GetTransceivers()[0]->mid());
308 EXPECT_EQ(video_transceiver->mid(),
309 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700310 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
311 callee->pc()->GetTransceivers()[0]->receiver()->streams();
312 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
313 callee->pc()->GetTransceivers()[1]->receiver()->streams();
314 ASSERT_EQ(0u, audio_streams.size());
315 ASSERT_EQ(2u, video_streams.size());
316 EXPECT_EQ(kStreamId1, video_streams[0]->id());
317 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800318}
319
320// Test that doing additional offer/answer exchanges with no changes to tracks
321// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700322TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
323 auto caller = CreatePeerConnection();
324 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800325
326 caller->AddAudioTrack("audio");
327 callee->AddAudioTrack("audio");
328
329 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
330 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
331 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
332
333 // If caller reoffers with no changes expect no additional OnTrack calls.
334 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
335 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
336 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
337
338 // Also if callee reoffers with no changes expect no additional OnTrack calls.
339 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
340 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
341 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
342}
343
344// Test that OnTrack is called when the transceiver direction changes to send
345// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700346TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
347 auto caller = CreatePeerConnection();
348 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800349
350 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
351 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
352 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
353 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
354 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
355
356 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
357 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
358 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
359 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
360
361 // If the direction changes but it is still receiving on the remote side, then
362 // OnTrack should not be fired again.
363 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
364 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
365 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
366 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
367}
368
369// Test that OnTrack is called twice when a sendrecv call is started, the callee
370// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700371TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
372 auto caller = CreatePeerConnection();
373 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800374
375 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
376
377 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
378 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
379 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
380
381 // Put the call on hold by no longer receiving the track.
382 callee->pc()->GetTransceivers()[0]->SetDirection(
383 RtpTransceiverDirection::kInactive);
384
385 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
386 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
387 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
388
389 // Resume the call by changing the direction to recvonly. This should call
390 // OnTrack again on the callee side.
391 callee->pc()->GetTransceivers()[0]->SetDirection(
392 RtpTransceiverDirection::kRecvOnly);
393
394 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
395 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
396 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
397}
398
Steve Anton3172c032018-05-03 15:30:18 -0700399// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700400// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700401TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700402 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100403 auto caller = CreatePeerConnection();
404 auto callee = CreatePeerConnection();
405
Steve Anton3172c032018-05-03 15:30:18 -0700406 caller->AddAudioTrack("audio_track", {});
407
408 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
409 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
410
411 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700412 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700413}
414
415// Test that setting a remote offer twice with no answer in the middle and the
416// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700417// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700418TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700419 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700420 auto caller = CreatePeerConnection();
421 auto callee = CreatePeerConnection();
422
423 auto sender = caller->AddAudioTrack("audio_track", {});
424
425 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
426 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700427 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700428
429 caller->pc()->RemoveTrack(sender);
430
431 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
432 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700433 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
434}
435
436// Test that changing the direction from receiving to not receiving between
437// setting the remote offer and creating / setting the local answer results in
438// a remove track event when SetLocalDescription is called.
439TEST_F(PeerConnectionRtpTestUnifiedPlan,
440 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
441 auto caller = CreatePeerConnection();
442 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
443 auto callee = CreatePeerConnection();
444 callee->AddAudioTrack("audio_track", {});
445
446 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
447 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700448 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700449
450 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
451 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
452
453 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
454 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
455 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700456}
457
458// These tests examine the state of the peer connection as a result of
459// performing SetRemoteDescription().
460
461TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
462 auto caller = CreatePeerConnection();
463 auto callee = CreatePeerConnection();
464
465 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700466 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100467
468 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
469 auto receiver_added = callee->pc()->GetReceivers()[0];
470 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700471
472 if (sdp_semantics_ == SdpSemantics::kPlanB) {
473 // Since we are not supporting the no stream case with Plan B, there should
474 // be a generated stream, even though we didn't set one with AddTrack.
475 ASSERT_EQ(1u, receiver_added->streams().size());
476 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
477 } else {
478 EXPECT_EQ(0u, receiver_added->streams().size());
479 }
Henrik Boström31638672017-11-23 17:48:32 +0100480}
481
Steve Anton3172c032018-05-03 15:30:18 -0700482TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100483 auto caller = CreatePeerConnection();
484 auto callee = CreatePeerConnection();
485
Steve Anton3172c032018-05-03 15:30:18 -0700486 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700487 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100488
489 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
490 auto receiver_added = callee->pc()->GetReceivers()[0];
491 EXPECT_EQ("audio_track", receiver_added->track()->id());
492 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700493 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100494 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
495}
496
Steve Anton3172c032018-05-03 15:30:18 -0700497TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100498 auto caller = CreatePeerConnection();
499 auto callee = CreatePeerConnection();
500
Steve Anton3172c032018-05-03 15:30:18 -0700501 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100502 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700503 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
504
Henrik Boström31638672017-11-23 17:48:32 +0100505 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
506 auto receiver = callee->pc()->GetReceivers()[0];
507 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700508 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100509
Steve Anton3172c032018-05-03 15:30:18 -0700510 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
511 // With Unified Plan the receiver stays but the transceiver transitions to
512 // inactive.
513 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
514 EXPECT_EQ(RtpTransceiverDirection::kInactive,
515 callee->pc()->GetTransceivers()[0]->current_direction());
516 } else {
517 // With Plan B the receiver is removed.
518 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
519 }
Henrik Boström31638672017-11-23 17:48:32 +0100520}
521
Steve Anton3172c032018-05-03 15:30:18 -0700522TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100523 auto caller = CreatePeerConnection();
524 auto callee = CreatePeerConnection();
525
Steve Anton3172c032018-05-03 15:30:18 -0700526 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100527 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700528 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100529 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
530 auto receiver = callee->pc()->GetReceivers()[0];
531 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700532 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100533
Steve Anton3172c032018-05-03 15:30:18 -0700534 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
535 // With Unified Plan the receiver stays but the transceiver transitions to
536 // inactive.
537 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
538 EXPECT_EQ(RtpTransceiverDirection::kInactive,
539 callee->pc()->GetTransceivers()[0]->current_direction());
540 } else {
541 // With Plan B the receiver is removed.
542 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
543 }
Henrik Boström31638672017-11-23 17:48:32 +0100544}
545
Steve Anton3172c032018-05-03 15:30:18 -0700546TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100547 auto caller = CreatePeerConnection();
548 auto callee = CreatePeerConnection();
549
Seth Hampson845e8782018-03-02 11:34:10 -0800550 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700551 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
552 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
553 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
554 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100555
556 // Remove "audio_track1".
557 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700558 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
559
560 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
561 // With Unified Plan the receiver stays but the transceiver transitions to
562 // inactive.
563 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
564 auto transceiver = callee->pc()->GetTransceivers()[0];
565 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
566 EXPECT_EQ(RtpTransceiverDirection::kInactive,
567 transceiver->current_direction());
568 } else {
569 // With Plan B the receiver is removed.
570 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
571 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
572 }
Henrik Boström31638672017-11-23 17:48:32 +0100573
574 // Remove "audio_track2".
575 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700576 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
577
578 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
579 // With Unified Plan the receiver stays but the transceiver transitions to
580 // inactive.
581 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
582 auto transceiver = callee->pc()->GetTransceivers()[1];
583 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
584 EXPECT_EQ(RtpTransceiverDirection::kInactive,
585 transceiver->current_direction());
586 } else {
587 // With Plan B the receiver is removed.
588 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
589 }
Henrik Boström31638672017-11-23 17:48:32 +0100590}
591
Florent Castelliabe301f2018-06-12 18:33:49 +0200592TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
593 auto caller = CreatePeerConnection();
594 auto callee = CreatePeerConnection();
595 auto sender = caller->AddAudioTrack("audio_track");
596 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
597
598 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
599 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
600
601 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
602 auto receiver = callee->pc()->GetReceivers()[0];
603 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
604}
605
606TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
607 auto caller = CreatePeerConnection();
608 auto callee = CreatePeerConnection();
609 auto sender = caller->AddVideoTrack("video_track");
610 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
611
612 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
613 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
614
615 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
616 auto receiver = callee->pc()->GetReceivers()[0];
617 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
618}
619
Henrik Boström31638672017-11-23 17:48:32 +0100620// Invokes SetRemoteDescription() twice in a row without synchronizing the two
621// calls and examine the state of the peer connection inside the callbacks to
622// ensure that the second call does not occur prematurely, contaminating the
623// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700624TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100625 StatesCorrelateWithSetRemoteDescriptionCall) {
626 auto caller = CreatePeerConnection();
627 auto callee = CreatePeerConnection();
628
Henrik Boström31638672017-11-23 17:48:32 +0100629 // Create SDP for adding a track and for removing it. This will be used in the
630 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700631 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100632 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
633 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
634 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
635
636 // In the first SetRemoteDescription() callback, check that we have a
637 // receiver for the track.
638 auto pc = callee->pc();
639 bool srd1_callback_called = false;
640 auto srd1_callback = [&srd1_callback_called, &pc]() {
641 EXPECT_EQ(pc->GetReceivers().size(), 1u);
642 srd1_callback_called = true;
643 };
644
645 // In the second SetRemoteDescription() callback, check that the receiver has
646 // been removed.
647 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
648 // Instead, the transceiver owning the receiver will become inactive.
649 // https://crbug.com/webrtc/7600
650 bool srd2_callback_called = false;
651 auto srd2_callback = [&srd2_callback_called, &pc]() {
652 EXPECT_TRUE(pc->GetReceivers().empty());
653 srd2_callback_called = true;
654 };
655
656 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
657 // calls. The callbacks verify that the two calls are synchronized, as in, the
658 // effects of the second SetRemoteDescription() call must not have happened by
659 // the time the first callback is invoked. If it has then the receiver that is
660 // added as a result of the first SetRemoteDescription() call will already
661 // have been removed as a result of the second SetRemoteDescription() call
662 // when the first callback is invoked.
663 callee->pc()->SetRemoteDescription(
664 std::move(srd1_sdp),
665 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
666 callee->pc()->SetRemoteDescription(
667 std::move(srd2_sdp),
668 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
669 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
670 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
671}
672
Seth Hampson5897a6e2018-04-03 11:16:33 -0700673// Tests that a remote track is created with the signaled MSIDs when they are
674// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
675// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700676TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
677 auto caller = CreatePeerConnection();
678 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700679 const char kStreamId1[] = "stream1";
680 const char kStreamId2[] = "stream2";
681 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
682 {kStreamId1, kStreamId2});
683
684 auto offer = caller->CreateOfferAndSetAsLocal();
685 // Munge the offer to take out everything but the stream_ids.
686 auto contents = offer->description()->contents();
687 ASSERT_TRUE(!contents.empty());
688 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
689 std::vector<std::string> stream_ids =
690 contents[0].media_description()->streams()[0].stream_ids();
691 contents[0].media_description()->mutable_streams().clear();
692 cricket::StreamParams new_stream;
693 new_stream.set_stream_ids(stream_ids);
694 contents[0].media_description()->AddStream(new_stream);
695
696 // Set the remote description and verify that the streams were added to the
697 // receiver correctly.
698 ASSERT_TRUE(
699 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
700 auto receivers = callee->pc()->GetReceivers();
701 ASSERT_EQ(receivers.size(), 1u);
702 ASSERT_EQ(receivers[0]->streams().size(), 2u);
703 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
704 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
705}
706
Seth Hampson5b4f0752018-04-02 16:31:36 -0700707// Tests that with Unified Plan if the the stream id changes for a track when
708// when setting a new remote description, that the media stream is updated
709// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700710// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
711// test.
712TEST_F(PeerConnectionRtpTestUnifiedPlan,
713 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700714 auto caller = CreatePeerConnection();
715 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700716
717 const char kStreamId1[] = "stream1";
718 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700719 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700720 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700721 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
722
723 // Change the stream id of the sender in the session description.
724 auto offer = caller->CreateOfferAndSetAsLocal();
725 auto contents = offer->description()->contents();
726 ASSERT_EQ(contents.size(), 1u);
727 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
728 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
729 {kStreamId2});
730
Steve Anton0f5400a2018-07-17 14:25:36 -0700731 // Set the remote description and verify that the stream was updated
732 // properly.
733 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700734 auto receivers = callee->pc()->GetReceivers();
735 ASSERT_EQ(receivers.size(), 1u);
736 ASSERT_EQ(receivers[0]->streams().size(), 1u);
737 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
738}
739
740// This tests a regression caught by a downstream client, that occured when
741// applying a remote description with a SessionDescription object that
742// contained StreamParams that didn't have ids. Although there were multiple
743// remote audio senders, FindSenderInfo didn't find them as unique, because
744// it looked up by StreamParam.id, which none had. This meant only one
745// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700746TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700747 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
748 auto caller = CreatePeerConnection();
749 auto callee = CreatePeerConnection();
750
751 const char kStreamId1[] = "stream1";
752 const char kStreamId2[] = "stream2";
753 caller->AddAudioTrack("audio_track1", {kStreamId1});
754 caller->AddAudioTrack("audio_track2", {kStreamId2});
755
756 auto offer = caller->CreateOfferAndSetAsLocal();
757 auto mutable_streams =
758 cricket::GetFirstAudioContentDescription(offer->description())
759 ->mutable_streams();
760 ASSERT_EQ(mutable_streams.size(), 2u);
761 // Clear the IDs in the StreamParams.
762 mutable_streams[0].id.clear();
763 mutable_streams[1].id.clear();
764 ASSERT_TRUE(
765 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
766
767 auto receivers = callee->pc()->GetReceivers();
768 ASSERT_EQ(receivers.size(), 2u);
769 ASSERT_EQ(receivers[0]->streams().size(), 1u);
770 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
771 ASSERT_EQ(receivers[1]->streams().size(), 1u);
772 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
773}
774
Henrik Boström31638672017-11-23 17:48:32 +0100775// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100776
777// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700778TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100779 auto caller = CreatePeerConnection();
780 auto callee = CreatePeerConnection();
781
782 std::string error;
783 ASSERT_TRUE(
784 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
785}
786
787// Verifies legacy behavior: The observer is not called if if the peer
788// connection is destroyed because the asynchronous callback is executed in the
789// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700790TEST_P(PeerConnectionRtpTest,
791 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100792 auto caller = CreatePeerConnection();
793 auto callee = CreatePeerConnection();
794
795 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
796 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
797
798 auto offer = caller->CreateOfferAndSetAsLocal();
799 callee->pc()->SetRemoteDescription(observer, offer.release());
800 callee = nullptr;
801 rtc::Thread::Current()->ProcessMessages(0);
802 EXPECT_FALSE(observer->called());
803}
804
Steve Antonf9381f02017-12-14 10:23:57 -0800805// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800806
807// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700808TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
809 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800810 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
811}
812
813// Test that a transceiver created with the audio kind has the correct initial
814// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700815TEST_F(PeerConnectionRtpTestUnifiedPlan,
816 AddTransceiverHasCorrectInitProperties) {
817 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800818
819 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200820 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800821 EXPECT_FALSE(transceiver->stopped());
822 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200823 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800824}
825
826// Test that adding a transceiver with the audio kind creates an audio sender
827// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700828TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800829 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700830 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800831
832 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800833 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800834
835 ASSERT_TRUE(transceiver->sender());
836 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
837
838 ASSERT_TRUE(transceiver->receiver());
839 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
840
841 auto track = transceiver->receiver()->track();
842 ASSERT_TRUE(track);
843 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
844 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
845}
846
847// Test that adding a transceiver with the video kind creates an video sender
848// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700849TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800850 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700851 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800852
853 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800854 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800855
856 ASSERT_TRUE(transceiver->sender());
857 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
858
859 ASSERT_TRUE(transceiver->receiver());
860 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
861
862 auto track = transceiver->receiver()->track();
863 ASSERT_TRUE(track);
864 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
865 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
866}
867
868// Test that after a call to AddTransceiver, the transceiver shows in
869// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
870// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700871TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
872 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800873
874 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
875 EXPECT_EQ(
876 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
877 caller->pc()->GetTransceivers());
878 EXPECT_EQ(
879 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
880 transceiver->sender()},
881 caller->pc()->GetSenders());
882 EXPECT_EQ(
883 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
884 transceiver->receiver()},
885 caller->pc()->GetReceivers());
886}
887
888// Test that the direction passed in through the AddTransceiver init parameter
889// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700890TEST_F(PeerConnectionRtpTestUnifiedPlan,
891 AddTransceiverWithDirectionIsReflected) {
892 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800893
894 RtpTransceiverInit init;
895 init.direction = RtpTransceiverDirection::kSendOnly;
896 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
897 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
898}
899
Steve Anton9158ef62017-11-27 13:01:52 -0800900// Test that calling AddTransceiver with a track creates a transceiver which has
901// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700902TEST_F(PeerConnectionRtpTestUnifiedPlan,
903 AddTransceiverWithTrackCreatesSenderWithTrack) {
904 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800905
906 auto audio_track = caller->CreateAudioTrack("audio track");
907 auto transceiver = caller->AddTransceiver(audio_track);
908
909 auto sender = transceiver->sender();
910 ASSERT_TRUE(sender->track());
911 EXPECT_EQ(audio_track, sender->track());
912
913 auto receiver = transceiver->receiver();
914 ASSERT_TRUE(receiver->track());
915 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
916 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
917 receiver->track()->state());
918}
919
920// Test that calling AddTransceiver twice with the same track creates distinct
921// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700922TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800923 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700924 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800925
926 auto audio_track = caller->CreateAudioTrack("audio track");
927
928 auto transceiver1 = caller->AddTransceiver(audio_track);
929 auto transceiver2 = caller->AddTransceiver(audio_track);
930
931 EXPECT_NE(transceiver1, transceiver2);
932
933 auto sender1 = transceiver1->sender();
934 auto sender2 = transceiver2->sender();
935 EXPECT_NE(sender1, sender2);
936 EXPECT_EQ(audio_track, sender1->track());
937 EXPECT_EQ(audio_track, sender2->track());
938
939 EXPECT_THAT(caller->pc()->GetTransceivers(),
940 UnorderedElementsAre(transceiver1, transceiver2));
941 EXPECT_THAT(caller->pc()->GetSenders(),
942 UnorderedElementsAre(sender1, sender2));
943}
944
Steve Anton3fe1b152017-12-12 10:20:08 -0800945// RtpTransceiver error handling tests.
946
Steve Anton3172c032018-05-03 15:30:18 -0700947TEST_F(PeerConnectionRtpTestUnifiedPlan,
948 AddTransceiverWithInvalidKindReturnsError) {
949 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800950
951 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
952 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
953}
954
Steve Anton3172c032018-05-03 15:30:18 -0700955TEST_F(PeerConnectionRtpTestUnifiedPlan,
956 CanClosePeerConnectionWithoutCrashing) {
957 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800958
959 caller->pc()->Close();
960}
961
Steve Antonf9381f02017-12-14 10:23:57 -0800962// Unified Plan AddTrack tests.
963
Steve Antonf9381f02017-12-14 10:23:57 -0800964// Test that adding an audio track creates a new audio RtpSender with the given
965// track.
Steve Anton3172c032018-05-03 15:30:18 -0700966TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
967 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800968
969 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800970 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800971 ASSERT_TRUE(sender);
972
973 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
974 EXPECT_EQ(audio_track, sender->track());
975}
976
977// Test that adding a video track creates a new video RtpSender with the given
978// track.
Steve Anton3172c032018-05-03 15:30:18 -0700979TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
980 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800981
982 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800983 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800984 ASSERT_TRUE(sender);
985
986 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
987 EXPECT_EQ(video_track, sender->track());
988}
989
990// Test that adding a track to a new PeerConnection creates an RtpTransceiver
991// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -0700992TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
993 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800994
995 auto sender = caller->AddAudioTrack("a");
996 ASSERT_TRUE(sender);
997
998 auto transceivers = caller->pc()->GetTransceivers();
999 ASSERT_EQ(1u, transceivers.size());
1000 EXPECT_EQ(sender, transceivers[0]->sender());
1001 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1002}
1003
1004// Test that if a transceiver of the same type but no track had been added to
1005// the PeerConnection and later a call to AddTrack is made, the resulting sender
1006// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001007TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1008 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001009
1010 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1011 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001012 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001013 ASSERT_TRUE(sender);
1014
1015 auto transceivers = caller->pc()->GetTransceivers();
1016 ASSERT_EQ(1u, transceivers.size());
1017 EXPECT_EQ(transceiver, transceivers[0]);
1018 EXPECT_EQ(sender, transceiver->sender());
1019 EXPECT_EQ(audio_track, sender->track());
1020}
1021
1022// Test that adding two tracks to a new PeerConnection creates two
1023// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001024TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1025 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001026
1027 auto sender1 = caller->AddAudioTrack("a");
1028 auto sender2 = caller->AddVideoTrack("v");
1029 ASSERT_TRUE(sender2);
1030
1031 auto transceivers = caller->pc()->GetTransceivers();
1032 ASSERT_EQ(2u, transceivers.size());
1033 EXPECT_EQ(sender1, transceivers[0]->sender());
1034 EXPECT_EQ(sender2, transceivers[1]->sender());
1035}
1036
1037// Test that if there are multiple transceivers with no sending track then a
1038// later call to AddTrack will use the one of the same type as the newly-added
1039// track.
Steve Anton3172c032018-05-03 15:30:18 -07001040TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1041 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001042
1043 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1044 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1045 auto sender = caller->AddVideoTrack("v");
1046
1047 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1048 EXPECT_NE(sender, audio_transceiver->sender());
1049 EXPECT_EQ(sender, video_transceiver->sender());
1050}
1051
1052// Test that if the only transceivers that do not have a sending track have a
1053// different type from the added track, then AddTrack will create a new
1054// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001055TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001056 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001057 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001058
1059 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1060 auto sender = caller->AddVideoTrack("v");
1061
1062 auto transceivers = caller->pc()->GetTransceivers();
1063 ASSERT_EQ(2u, transceivers.size());
1064 EXPECT_NE(sender, transceivers[0]->sender());
1065 EXPECT_EQ(sender, transceivers[1]->sender());
1066}
1067
1068// Test that the first available transceiver is reused by AddTrack when multiple
1069// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001070TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001071 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001072 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001073
1074 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1075 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1076 auto sender = caller->AddAudioTrack("a");
1077
1078 auto transceivers = caller->pc()->GetTransceivers();
1079 ASSERT_EQ(2u, transceivers.size());
1080 EXPECT_EQ(sender, transceivers[0]->sender());
1081 EXPECT_NE(sender, transceivers[1]->sender());
1082}
1083
1084// Test that a call to AddTrack that reuses a transceiver will change the
1085// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001086TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001087 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001088 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001089
1090 RtpTransceiverInit init;
1091 init.direction = RtpTransceiverDirection::kInactive;
1092 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1093
1094 caller->observer()->clear_negotiation_needed();
1095 ASSERT_TRUE(caller->AddAudioTrack("a"));
1096 EXPECT_TRUE(caller->observer()->negotiation_needed());
1097
1098 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1099}
1100
1101// Test that a call to AddTrack that reuses a transceiver will change the
1102// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001103TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001104 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001105 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001106
1107 RtpTransceiverInit init;
1108 init.direction = RtpTransceiverDirection::kRecvOnly;
1109 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1110
1111 caller->observer()->clear_negotiation_needed();
1112 ASSERT_TRUE(caller->AddAudioTrack("a"));
1113 EXPECT_TRUE(caller->observer()->negotiation_needed());
1114
1115 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1116}
1117
Steve Anton3172c032018-05-03 15:30:18 -07001118TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001119 const std::string kTrackId = "audio_track";
1120
Steve Anton3172c032018-05-03 15:30:18 -07001121 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001122
1123 auto audio_track = caller->CreateAudioTrack(kTrackId);
1124 auto sender = caller->AddTrack(audio_track);
1125
1126 EXPECT_EQ(kTrackId, sender->id());
1127}
1128
Steve Antonf9381f02017-12-14 10:23:57 -08001129// Unified Plan AddTrack error handling.
1130
Steve Anton3172c032018-05-03 15:30:18 -07001131TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1132 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001133
1134 auto audio_track = caller->CreateAudioTrack("a");
1135 caller->pc()->Close();
1136
1137 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001138 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001139 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001140 EXPECT_FALSE(caller->observer()->negotiation_needed());
1141}
1142
Steve Anton3172c032018-05-03 15:30:18 -07001143TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1144 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001145
1146 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001147 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001148
1149 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001150 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001151 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001152 EXPECT_FALSE(caller->observer()->negotiation_needed());
1153}
1154
1155// Unified Plan RemoveTrack tests.
1156
1157// Test that calling RemoveTrack on a sender with a previously-added track
1158// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001159TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1160 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001161
1162 auto sender = caller->AddAudioTrack("a");
1163 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1164
1165 EXPECT_FALSE(sender->track());
1166}
1167
1168// Test that calling RemoveTrack on a sender where the transceiver is configured
1169// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001170TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001171 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001172 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001173
1174 RtpTransceiverInit init;
1175 init.direction = RtpTransceiverDirection::kSendRecv;
1176 auto transceiver =
1177 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1178
1179 caller->observer()->clear_negotiation_needed();
1180 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1181 EXPECT_TRUE(caller->observer()->negotiation_needed());
1182
1183 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1184 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1185}
1186
1187// Test that calling RemoveTrack on a sender where the transceiver is configured
1188// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001189TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001190 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001191 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001192
1193 RtpTransceiverInit init;
1194 init.direction = RtpTransceiverDirection::kSendOnly;
1195 auto transceiver =
1196 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1197
1198 caller->observer()->clear_negotiation_needed();
1199 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1200 EXPECT_TRUE(caller->observer()->negotiation_needed());
1201
1202 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1203}
1204
1205// Test that calling RemoveTrack with a sender that has a null track results in
1206// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001207TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1208 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001209
1210 auto sender = caller->AddAudioTrack("a");
1211 auto transceiver = caller->pc()->GetTransceivers()[0];
1212 ASSERT_TRUE(sender->SetTrack(nullptr));
1213
1214 caller->observer()->clear_negotiation_needed();
1215 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1216 EXPECT_FALSE(caller->observer()->negotiation_needed());
1217
1218 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1219}
1220
1221// Unified Plan RemoveTrack error handling.
1222
Steve Anton3172c032018-05-03 15:30:18 -07001223TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1224 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001225
1226 auto sender = caller->AddAudioTrack("a");
1227 caller->pc()->Close();
1228
1229 caller->observer()->clear_negotiation_needed();
1230 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1231 EXPECT_FALSE(caller->observer()->negotiation_needed());
1232}
1233
Steve Anton3172c032018-05-03 15:30:18 -07001234TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001235 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001236 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001237
1238 auto sender = caller->AddAudioTrack("a");
1239 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1240
1241 caller->observer()->clear_negotiation_needed();
1242 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1243 EXPECT_FALSE(caller->observer()->negotiation_needed());
1244}
1245
Steve Anton60b6c1d2018-06-13 11:32:27 -07001246// Test that setting offers that add/remove/add a track repeatedly without
1247// setting the appropriate answer in between works.
1248// These are regression tests for bugs.webrtc.org/9401
1249TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1250 auto caller = CreatePeerConnection();
1251
1252 auto sender1 = caller->AddAudioTrack("audio1");
1253 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1254
1255 caller->pc()->RemoveTrack(sender1);
1256 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1257
1258 // This will re-use the transceiver created by the first AddTrack.
1259 auto sender2 = caller->AddAudioTrack("audio2");
1260 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1261
1262 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1263 EXPECT_EQ(sender1, sender2);
1264}
1265TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1266 auto caller = CreatePeerConnection();
1267
1268 auto sender1 = caller->AddVideoTrack("video1");
1269 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1270
1271 caller->pc()->RemoveTrack(sender1);
1272 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1273
1274 // This will re-use the transceiver created by the first AddTrack.
1275 auto sender2 = caller->AddVideoTrack("video2");
1276 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1277
1278 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1279 EXPECT_EQ(sender1, sender2);
1280}
1281
Steve Anton07563732018-06-26 11:13:50 -07001282// Test that CreateOffer succeeds if two tracks with the same label are added.
1283TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1284 auto caller = CreatePeerConnection();
1285
1286 auto audio_sender = caller->AddAudioTrack("track", {});
1287 auto video_sender = caller->AddVideoTrack("track", {});
1288
1289 EXPECT_TRUE(caller->CreateOffer());
1290
1291 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1292 EXPECT_NE(audio_sender->id(), video_sender->id());
1293}
1294
1295// Test that CreateAnswer succeeds if two tracks with the same label are added.
1296TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1297 auto caller = CreatePeerConnection();
1298 auto callee = CreatePeerConnection();
1299
1300 RtpTransceiverInit recvonly;
1301 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1302 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1303 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1304
1305 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1306
1307 auto audio_sender = callee->AddAudioTrack("track", {});
1308 auto video_sender = callee->AddVideoTrack("track", {});
1309
1310 EXPECT_TRUE(callee->CreateAnswer());
1311
1312 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1313 EXPECT_NE(audio_sender->id(), video_sender->id());
1314}
1315
1316// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1317// m= section with a random sender id (different from the first, now rejected,
1318// m= section).
1319TEST_F(PeerConnectionRtpTestUnifiedPlan,
1320 AddRemoveAddTrackGeneratesNewSenderId) {
1321 auto caller = CreatePeerConnection();
1322 auto callee = CreatePeerConnection();
1323
1324 auto track = caller->CreateVideoTrack("video");
1325 auto sender1 = caller->AddTrack(track);
1326 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1327
1328 caller->pc()->RemoveTrack(sender1);
1329 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1330
1331 auto sender2 = caller->AddTrack(track);
1332
1333 EXPECT_NE(sender1, sender2);
1334 EXPECT_NE(sender1->id(), sender2->id());
1335 std::string sender2_id = sender2->id();
1336
1337 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1338
1339 // The sender's ID should not change after negotiation.
1340 EXPECT_EQ(sender2_id, sender2->id());
1341}
1342
Steve Anton52d86772018-02-20 15:48:12 -08001343// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1344// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001345TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001346 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001347 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001348
1349 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1350
1351 caller->observer()->clear_negotiation_needed();
1352 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1353 EXPECT_TRUE(caller->observer()->negotiation_needed());
1354}
1355
1356// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1357// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001358TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001359 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001360 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001361
1362 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1363
1364 caller->observer()->clear_negotiation_needed();
1365 transceiver->SetDirection(transceiver->direction());
1366 EXPECT_FALSE(caller->observer()->negotiation_needed());
1367}
1368
1369// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1370// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001371TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001372 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001373 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001374
1375 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1376 transceiver->Stop();
1377
1378 caller->observer()->clear_negotiation_needed();
1379 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1380 EXPECT_FALSE(caller->observer()->negotiation_needed());
1381}
1382
Florent Castelli892acf02018-10-01 22:47:20 +02001383// Test that AddTransceiver fails if trying to use simulcast using
1384// send_encodings as it isn't currently supported.
1385TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForUnsupportedSimulcast) {
1386 auto caller = CreatePeerConnection();
1387
1388 RtpTransceiverInit init;
1389 init.send_encodings.emplace_back();
1390 init.send_encodings.emplace_back();
1391 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
1392 EXPECT_EQ(result.error().type(), RTCErrorType::UNSUPPORTED_PARAMETER);
1393}
1394
1395// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1396// parameters with the send_encodings parameters.
1397TEST_F(PeerConnectionRtpTestUnifiedPlan,
1398 CheckForUnsupportedEncodingParameters) {
1399 auto caller = CreatePeerConnection();
1400
1401 RtpTransceiverInit init;
1402 init.send_encodings.emplace_back();
1403
1404 auto default_send_encodings = init.send_encodings;
1405
1406 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
1407 // ptime, scale_resolution_down_by, scale_framerate_down_by, rid,
1408 // dependency_rids.
1409 init.send_encodings[0].ssrc = 1;
1410 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1411 caller->pc()
1412 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1413 .error()
1414 .type());
1415 init.send_encodings = default_send_encodings;
1416
1417 init.send_encodings[0].codec_payload_type = 1;
1418 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1419 caller->pc()
1420 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1421 .error()
1422 .type());
1423 init.send_encodings = default_send_encodings;
1424
1425 init.send_encodings[0].fec = RtpFecParameters();
1426 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1427 caller->pc()
1428 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1429 .error()
1430 .type());
1431 init.send_encodings = default_send_encodings;
1432
1433 init.send_encodings[0].rtx = RtpRtxParameters();
1434 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1435 caller->pc()
1436 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1437 .error()
1438 .type());
1439 init.send_encodings = default_send_encodings;
1440
1441 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1442 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1443 caller->pc()
1444 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1445 .error()
1446 .type());
1447 init.send_encodings = default_send_encodings;
1448
1449 init.send_encodings[0].ptime = 1;
1450 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1451 caller->pc()
1452 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1453 .error()
1454 .type());
1455 init.send_encodings = default_send_encodings;
1456
1457 init.send_encodings[0].scale_resolution_down_by = 2.0;
1458 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1459 caller->pc()
1460 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1461 .error()
1462 .type());
1463 init.send_encodings = default_send_encodings;
1464
1465 init.send_encodings[0].rid = "dummy_rid";
1466 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1467 caller->pc()
1468 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1469 .error()
1470 .type());
1471 init.send_encodings = default_send_encodings;
1472
1473 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1474 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1475 caller->pc()
1476 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1477 .error()
1478 .type());
1479}
1480
1481// Test that AddTransceiver transfers the send_encodings to the sender and they
1482// are retained after SetLocalDescription().
1483TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1484 auto caller = CreatePeerConnection();
1485
1486 RtpTransceiverInit init;
1487 init.send_encodings.emplace_back();
1488 init.send_encodings[0].active = false;
1489 init.send_encodings[0].max_bitrate_bps = 180000;
1490
1491 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1492 ASSERT_TRUE(result.ok());
1493
1494 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1495 EXPECT_FALSE(init_send_encodings[0].active);
1496 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1497
1498 auto parameters = result.value()->sender()->GetParameters();
1499 EXPECT_FALSE(parameters.encodings[0].active);
1500 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1501
1502 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1503
1504 parameters = result.value()->sender()->GetParameters();
1505 EXPECT_FALSE(parameters.encodings[0].active);
1506 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1507}
1508
Steve Antone831b8c2018-02-01 12:22:16 -08001509// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1510// options for this kind of signaling: media section based (a=msid) and ssrc
1511// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1512// we want to ensure compatibility with older Plan B endpoints that might expect
1513// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1514// types but answers with the same type as the offer.
1515
Steve Anton3172c032018-05-03 15:30:18 -07001516class PeerConnectionMsidSignalingTest
1517 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001518
1519TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1520 auto caller = CreatePeerConnectionWithUnifiedPlan();
1521 caller->AddAudioTrack("caller_audio");
1522 auto callee = CreatePeerConnectionWithUnifiedPlan();
1523 callee->AddAudioTrack("callee_audio");
1524
1525 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1526
1527 // Offer should have had both a=msid and a=ssrc MSID lines.
1528 auto* offer = callee->pc()->remote_description();
1529 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1530 cricket::kMsidSignalingSsrcAttribute),
1531 offer->description()->msid_signaling());
1532
1533 // Answer should have had only a=msid lines.
1534 auto* answer = caller->pc()->remote_description();
1535 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1536 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001537 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001538 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1539 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1540 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1541 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1542 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001543}
1544
1545TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1546 auto caller = CreatePeerConnectionWithPlanB();
1547 caller->AddAudioTrack("caller_audio");
1548 auto callee = CreatePeerConnectionWithUnifiedPlan();
1549 callee->AddAudioTrack("callee_audio");
1550
1551 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1552
1553 // Offer should have only a=ssrc MSID lines.
1554 auto* offer = callee->pc()->remote_description();
1555 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1556 offer->description()->msid_signaling());
1557
1558 // Answer should have only a=ssrc MSID lines to match the offer.
1559 auto* answer = caller->pc()->remote_description();
1560 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1561 answer->description()->msid_signaling());
1562}
1563
Seth Hampson5b4f0752018-04-02 16:31:36 -07001564// This tests that a Plan B endpoint appropriately sets the remote description
1565// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1566// that signal no stream ids or multiple stream ids we expect that the Plan B
1567// endpoint always has exactly one media stream per track.
1568TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1569 const std::string kStreamId1 = "audio_stream_1";
1570 const std::string kStreamId2 = "audio_stream_2";
1571
1572 auto caller = CreatePeerConnectionWithUnifiedPlan();
1573 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1574 caller->AddVideoTrack("caller_video", {});
1575 auto callee = CreatePeerConnectionWithPlanB();
1576 callee->AddAudioTrack("callee_audio");
1577 caller->AddVideoTrack("callee_video");
1578
1579 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1580
1581 // Offer should have had both a=msid and a=ssrc MSID lines.
1582 auto* offer = callee->pc()->remote_description();
1583 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1584 cricket::kMsidSignalingSsrcAttribute),
1585 offer->description()->msid_signaling());
1586
1587 // Callee should always have 1 stream for all of it's receivers.
1588 const auto& track_events = callee->observer()->add_track_events_;
1589 ASSERT_EQ(2u, track_events.size());
1590 ASSERT_EQ(1u, track_events[0].streams.size());
1591 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1592 ASSERT_EQ(1u, track_events[1].streams.size());
1593 // This autogenerated a stream id for the empty one signalled.
1594 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1595}
1596
Steve Antone831b8c2018-02-01 12:22:16 -08001597TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1598 auto caller = CreatePeerConnectionWithUnifiedPlan();
1599 caller->AddAudioTrack("caller_audio");
1600 auto callee = CreatePeerConnectionWithUnifiedPlan();
1601 callee->AddAudioTrack("callee_audio");
1602
1603 auto offer = caller->CreateOffer();
1604 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1605 // section only.
1606 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1607
1608 ASSERT_TRUE(
1609 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1610 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1611
1612 // Answer should have only a=msid to match the offer.
1613 auto answer = callee->CreateAnswer();
1614 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1615 answer->description()->msid_signaling());
1616}
1617
Steve Anton8e20f172018-03-06 10:55:04 -08001618// Test that the correct UMA metrics are reported for simple/complex SDP.
1619
Steve Anton3172c032018-05-03 15:30:18 -07001620class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001621
1622#ifdef HAVE_SCTP
1623TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1624 auto caller = CreatePeerConnectionWithUnifiedPlan();
1625 caller->CreateDataChannel("dc");
1626 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001627
1628 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001629 // Note that only the callee does ReportSdpFormatReceived.
1630 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1631 "WebRTC.PeerConnection.SdpFormatReceived"));
1632 EXPECT_EQ(
1633 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1634 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001635}
1636#endif // HAVE_SCTP
1637
1638TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1639 auto caller = CreatePeerConnectionWithUnifiedPlan();
1640 caller->AddAudioTrack("audio");
1641 caller->AddVideoTrack("video");
1642 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001643
1644 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001645 // Note that only the callee does ReportSdpFormatReceived.
1646 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1647 "WebRTC.PeerConnection.SdpFormatReceived"));
1648 EXPECT_EQ(
1649 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1650 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001651}
1652
1653TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1654 auto caller = CreatePeerConnectionWithPlanB();
1655 caller->AddVideoTrack("video"); // Video only.
1656 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001657
1658 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1659
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001660 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1661 "WebRTC.PeerConnection.SdpFormatReceived"));
1662 EXPECT_EQ(
1663 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1664 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001665}
1666
1667TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1668 auto caller = CreatePeerConnectionWithUnifiedPlan();
1669 caller->AddAudioTrack("audio1");
1670 caller->AddAudioTrack("audio2");
1671 caller->AddVideoTrack("video");
1672 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001673
1674 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001675 // Note that only the callee does ReportSdpFormatReceived.
1676 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1677 "WebRTC.PeerConnection.SdpFormatReceived"));
1678 EXPECT_EQ(
1679 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1680 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001681}
1682
1683TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1684 auto caller = CreatePeerConnectionWithPlanB();
1685 caller->AddVideoTrack("video1");
1686 caller->AddVideoTrack("video2");
1687 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001688
Steve Antonba42e992018-04-09 14:10:01 -07001689 // This fails since Unified Plan cannot set a session description with
1690 // multiple "Plan B tracks" in the same media section. But we still expect the
1691 // SDP Format to be recorded.
1692 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001693 // Note that only the callee does ReportSdpFormatReceived.
1694 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1695 "WebRTC.PeerConnection.SdpFormatReceived"));
1696 EXPECT_EQ(
1697 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1698 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001699}
1700
Henrik Boström91d039b2018-01-11 17:43:30 +01001701// Sender setups in a call.
1702
Steve Anton3172c032018-05-03 15:30:18 -07001703TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001704 auto caller = CreatePeerConnection();
1705 auto callee = CreatePeerConnection();
1706
1707 auto track = caller->CreateAudioTrack("audio_track");
1708 auto sender1 = caller->AddTrack(track);
1709 ASSERT_TRUE(sender1);
1710 // We need to temporarily reset the track for the subsequent AddTrack() to
1711 // succeed.
1712 EXPECT_TRUE(sender1->SetTrack(nullptr));
1713 auto sender2 = caller->AddTrack(track);
1714 EXPECT_TRUE(sender2);
1715 EXPECT_TRUE(sender1->SetTrack(track));
1716
Steve Anton3172c032018-05-03 15:30:18 -07001717 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1718 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1719 // return true, and doing |callee->SetRemoteDescription()| should work.
1720 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1721 } else {
1722 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1723 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001724}
1725
Steve Anton3172c032018-05-03 15:30:18 -07001726INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1727 PeerConnectionRtpTest,
1728 Values(SdpSemantics::kPlanB,
1729 SdpSemantics::kUnifiedPlan));
1730
Steve Anton9158ef62017-11-27 13:01:52 -08001731} // namespace webrtc