blob: f19388fe4b2e70739f0777c1f984355adbbdb709 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg1b0eae32017-10-17 14:48:54 +020014#include "api/audio_codecs/builtin_audio_decoder_factory.h"
15#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include "api/jsep.h"
17#include "api/mediastreaminterface.h"
18#include "api/peerconnectioninterface.h"
19#include "pc/mediastream.h"
20#include "pc/mediastreamtrack.h"
21#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080022#include "pc/sdputils.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070023#include "pc/test/fakeaudiocapturemodule.h"
24#include "pc/test/mockpeerconnectionobservers.h"
25#include "rtc_base/checks.h"
26#include "rtc_base/gunit.h"
27#include "rtc_base/ptr_util.h"
28#include "rtc_base/refcountedobject.h"
29#include "rtc_base/scoped_ref_ptr.h"
30#include "rtc_base/thread.h"
Steve Anton9158ef62017-11-27 13:01:52 -080031#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070032
33// This file contains tests for RTP Media API-related behavior of
34// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
35
Steve Anton9158ef62017-11-27 13:01:52 -080036namespace webrtc {
37
38using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
39using ::testing::ElementsAre;
40using ::testing::UnorderedElementsAre;
Henrik Boström933d8b02017-10-10 10:05:16 -070041
Henrik Boström31638672017-11-23 17:48:32 +010042const uint32_t kDefaultTimeout = 10000u;
43
44template <typename MethodFunctor>
45class OnSuccessObserver : public rtc::RefCountedObject<
46 webrtc::SetRemoteDescriptionObserverInterface> {
47 public:
48 explicit OnSuccessObserver(MethodFunctor on_success)
49 : on_success_(std::move(on_success)) {}
50
51 // webrtc::SetRemoteDescriptionObserverInterface implementation.
52 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
53 RTC_CHECK(error.ok());
54 on_success_();
55 }
56
57 private:
58 MethodFunctor on_success_;
59};
60
Henrik Boström933d8b02017-10-10 10:05:16 -070061class PeerConnectionRtpTest : public testing::Test {
62 public:
63 PeerConnectionRtpTest()
Steve Anton9158ef62017-11-27 13:01:52 -080064 : pc_factory_(
65 CreatePeerConnectionFactory(rtc::Thread::Current(),
66 rtc::Thread::Current(),
67 rtc::Thread::Current(),
68 FakeAudioCaptureModule::Create(),
69 CreateBuiltinAudioEncoderFactory(),
70 CreateBuiltinAudioDecoderFactory(),
71 nullptr,
72 nullptr)) {}
Henrik Boström933d8b02017-10-10 10:05:16 -070073
Steve Anton9158ef62017-11-27 13:01:52 -080074 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
75 return CreatePeerConnection(RTCConfiguration());
76 }
77
Steve Antone831b8c2018-02-01 12:22:16 -080078 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
79 RTCConfiguration config;
80 config.sdp_semantics = SdpSemantics::kPlanB;
81 return CreatePeerConnection(config);
82 }
83
Steve Anton9158ef62017-11-27 13:01:52 -080084 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
85 RTCConfiguration config;
86 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
87 return CreatePeerConnection(config);
88 }
89
90 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
91 const RTCConfiguration& config) {
92 auto observer = rtc::MakeUnique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -070093 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
94 observer.get());
Steve Anton9158ef62017-11-27 13:01:52 -080095 return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc,
96 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -070097 }
98
99 protected:
Steve Anton9158ef62017-11-27 13:01:52 -0800100 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
Henrik Boström933d8b02017-10-10 10:05:16 -0700101};
102
Henrik Boström31638672017-11-23 17:48:32 +0100103// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
104// setting the remote description.
105class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {};
106
107TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700108 auto caller = CreatePeerConnection();
109 auto callee = CreatePeerConnection();
110
Steve Anton2d6c76a2018-01-05 17:10:52 -0800111 ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track")));
Henrik Boström31638672017-11-23 17:48:32 +0100112 ASSERT_TRUE(
113 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
114 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700115
Henrik Boström31638672017-11-23 17:48:32 +0100116 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
117 // TODO(hbos): When "no stream" is handled correctly we would expect
Henrik Boström933d8b02017-10-10 10:05:16 -0700118 // |add_track_events_[0].streams| to be empty. https://crbug.com/webrtc/7933
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100119 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100120 ASSERT_EQ(add_track_event.streams.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100121 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
122 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700123}
124
Henrik Boström31638672017-11-23 17:48:32 +0100125TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700126 auto caller = CreatePeerConnection();
127 auto callee = CreatePeerConnection();
128
Steve Anton2d6c76a2018-01-05 17:10:52 -0800129 ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"),
130 {"audio_stream"}));
Henrik Boström31638672017-11-23 17:48:32 +0100131 ASSERT_TRUE(
132 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
133 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700134
Henrik Boström31638672017-11-23 17:48:32 +0100135 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100136 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100137 ASSERT_EQ(add_track_event.streams.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100138 EXPECT_EQ("audio_stream", add_track_event.streams[0]->label());
139 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
140 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700141}
142
Henrik Boström31638672017-11-23 17:48:32 +0100143TEST_F(PeerConnectionRtpCallbacksTest,
144 RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700145 auto caller = CreatePeerConnection();
146 auto callee = CreatePeerConnection();
147
Steve Anton2d6c76a2018-01-05 17:10:52 -0800148 auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {});
Henrik Boström31638672017-11-23 17:48:32 +0100149 ASSERT_TRUE(
150 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
151 static_cast<webrtc::RTCError*>(nullptr)));
152 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700153 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boström31638672017-11-23 17:48:32 +0100154 ASSERT_TRUE(
155 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
156 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700157
Henrik Boström31638672017-11-23 17:48:32 +0100158 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700159 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
160 callee->observer()->remove_track_events_);
161}
162
Henrik Boström31638672017-11-23 17:48:32 +0100163TEST_F(PeerConnectionRtpCallbacksTest,
164 RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700165 auto caller = CreatePeerConnection();
166 auto callee = CreatePeerConnection();
167
Steve Anton2d6c76a2018-01-05 17:10:52 -0800168 auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"),
169 {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100170 ASSERT_TRUE(
171 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
172 static_cast<webrtc::RTCError*>(nullptr)));
173 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700174 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boström31638672017-11-23 17:48:32 +0100175 ASSERT_TRUE(
176 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
177 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700178
Henrik Boström31638672017-11-23 17:48:32 +0100179 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700180 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
181 callee->observer()->remove_track_events_);
182}
183
Henrik Boström31638672017-11-23 17:48:32 +0100184TEST_F(PeerConnectionRtpCallbacksTest,
185 RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700186 auto caller = CreatePeerConnection();
187 auto callee = CreatePeerConnection();
188
Steve Anton2d6c76a2018-01-05 17:10:52 -0800189 const char kSharedStreamLabel[] = "shared_audio_stream";
190 auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
191 {kSharedStreamLabel});
192 auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"),
193 {kSharedStreamLabel});
Henrik Boström31638672017-11-23 17:48:32 +0100194 ASSERT_TRUE(
195 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
196 static_cast<webrtc::RTCError*>(nullptr)));
Henrik Boström933d8b02017-10-10 10:05:16 -0700197
Henrik Boström31638672017-11-23 17:48:32 +0100198 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700199
200 // Remove "audio_track1".
201 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Henrik Boström31638672017-11-23 17:48:32 +0100202 ASSERT_TRUE(
203 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
204 static_cast<webrtc::RTCError*>(nullptr)));
205 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700206 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800207 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700208 callee->observer()->add_track_events_[0].receiver},
209 callee->observer()->remove_track_events_);
210
211 // Remove "audio_track2".
212 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Henrik Boström31638672017-11-23 17:48:32 +0100213 ASSERT_TRUE(
214 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
215 static_cast<webrtc::RTCError*>(nullptr)));
216 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700217 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
218 callee->observer()->remove_track_events_);
219}
220
Henrik Boström31638672017-11-23 17:48:32 +0100221// These tests examine the state of the peer connection as a result of
222// performing SetRemoteDescription().
223class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {};
224
225TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) {
226 auto caller = CreatePeerConnection();
227 auto callee = CreatePeerConnection();
228
Steve Anton2d6c76a2018-01-05 17:10:52 -0800229 ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}));
Henrik Boström31638672017-11-23 17:48:32 +0100230 ASSERT_TRUE(
231 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
232 static_cast<webrtc::RTCError*>(nullptr)));
233
234 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
235 auto receiver_added = callee->pc()->GetReceivers()[0];
236 EXPECT_EQ("audio_track", receiver_added->track()->id());
237 // TODO(hbos): When "no stream" is handled correctly we would expect
238 // |receiver_added->streams()| to be empty. https://crbug.com/webrtc/7933
239 EXPECT_EQ(receiver_added->streams().size(), 1u);
240 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
241}
242
243TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) {
244 auto caller = CreatePeerConnection();
245 auto callee = CreatePeerConnection();
246
Steve Anton2d6c76a2018-01-05 17:10:52 -0800247 ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"),
248 {"audio_stream"}));
Henrik Boström31638672017-11-23 17:48:32 +0100249 ASSERT_TRUE(
250 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
251 static_cast<webrtc::RTCError*>(nullptr)));
252
253 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
254 auto receiver_added = callee->pc()->GetReceivers()[0];
255 EXPECT_EQ("audio_track", receiver_added->track()->id());
256 EXPECT_EQ(receiver_added->streams().size(), 1u);
257 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->label());
258 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
259}
260
261TEST_F(PeerConnectionRtpObserverTest,
262 RemoveSenderWithoutStreamRemovesReceiver) {
263 auto caller = CreatePeerConnection();
264 auto callee = CreatePeerConnection();
265
Steve Anton2d6c76a2018-01-05 17:10:52 -0800266 auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {});
Henrik Boström31638672017-11-23 17:48:32 +0100267 ASSERT_TRUE(sender);
268 ASSERT_TRUE(
269 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
270 static_cast<webrtc::RTCError*>(nullptr)));
271 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
272 auto receiver = callee->pc()->GetReceivers()[0];
273 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
274 ASSERT_TRUE(
275 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
276 static_cast<webrtc::RTCError*>(nullptr)));
277
278 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
279 // Instead, the transceiver owning the receiver will become inactive.
280 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
281}
282
283TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) {
284 auto caller = CreatePeerConnection();
285 auto callee = CreatePeerConnection();
286
Steve Anton2d6c76a2018-01-05 17:10:52 -0800287 auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"),
288 {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100289 ASSERT_TRUE(sender);
290 ASSERT_TRUE(
291 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
292 static_cast<webrtc::RTCError*>(nullptr)));
293 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
294 auto receiver = callee->pc()->GetReceivers()[0];
295 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
296 ASSERT_TRUE(
297 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
298 static_cast<webrtc::RTCError*>(nullptr)));
299
300 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
301 // Instead, the transceiver owning the receiver will become inactive.
302 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
303}
304
305TEST_F(PeerConnectionRtpObserverTest,
306 RemoveSenderWithSharedStreamRemovesReceiver) {
307 auto caller = CreatePeerConnection();
308 auto callee = CreatePeerConnection();
309
Steve Anton2d6c76a2018-01-05 17:10:52 -0800310 const char kSharedStreamLabel[] = "shared_audio_stream";
311 auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
312 {kSharedStreamLabel});
313 auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"),
314 {kSharedStreamLabel});
Henrik Boström31638672017-11-23 17:48:32 +0100315 ASSERT_TRUE(
316 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
317 static_cast<webrtc::RTCError*>(nullptr)));
318
319 ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u);
320 rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1;
321 rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2;
322 if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") {
323 receiver1 = callee->pc()->GetReceivers()[0];
324 receiver2 = callee->pc()->GetReceivers()[1];
325 } else {
326 receiver1 = callee->pc()->GetReceivers()[1];
327 receiver2 = callee->pc()->GetReceivers()[0];
328 }
329 EXPECT_EQ("audio_track1", receiver1->track()->id());
330 EXPECT_EQ("audio_track2", receiver2->track()->id());
331
332 // Remove "audio_track1".
333 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
334 ASSERT_TRUE(
335 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
336 static_cast<webrtc::RTCError*>(nullptr)));
337 // Only |receiver2| should remain.
338 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
339 // Instead, the transceiver owning the receiver will become inactive.
340 EXPECT_EQ(
341 std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2},
342 callee->pc()->GetReceivers());
343
344 // Remove "audio_track2".
345 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
346 ASSERT_TRUE(
347 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(),
348 static_cast<webrtc::RTCError*>(nullptr)));
349 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
350 // Instead, the transceiver owning the receiver will become inactive.
351 EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u);
352}
353
354// Invokes SetRemoteDescription() twice in a row without synchronizing the two
355// calls and examine the state of the peer connection inside the callbacks to
356// ensure that the second call does not occur prematurely, contaminating the
357// state of the peer connection of the first callback.
358TEST_F(PeerConnectionRtpObserverTest,
359 StatesCorrelateWithSetRemoteDescriptionCall) {
360 auto caller = CreatePeerConnection();
361 auto callee = CreatePeerConnection();
362
Henrik Boström31638672017-11-23 17:48:32 +0100363 // Create SDP for adding a track and for removing it. This will be used in the
364 // first and second SetRemoteDescription() calls.
Steve Anton2d6c76a2018-01-05 17:10:52 -0800365 auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {});
Henrik Boström31638672017-11-23 17:48:32 +0100366 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
367 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
368 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
369
370 // In the first SetRemoteDescription() callback, check that we have a
371 // receiver for the track.
372 auto pc = callee->pc();
373 bool srd1_callback_called = false;
374 auto srd1_callback = [&srd1_callback_called, &pc]() {
375 EXPECT_EQ(pc->GetReceivers().size(), 1u);
376 srd1_callback_called = true;
377 };
378
379 // In the second SetRemoteDescription() callback, check that the receiver has
380 // been removed.
381 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
382 // Instead, the transceiver owning the receiver will become inactive.
383 // https://crbug.com/webrtc/7600
384 bool srd2_callback_called = false;
385 auto srd2_callback = [&srd2_callback_called, &pc]() {
386 EXPECT_TRUE(pc->GetReceivers().empty());
387 srd2_callback_called = true;
388 };
389
390 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
391 // calls. The callbacks verify that the two calls are synchronized, as in, the
392 // effects of the second SetRemoteDescription() call must not have happened by
393 // the time the first callback is invoked. If it has then the receiver that is
394 // added as a result of the first SetRemoteDescription() call will already
395 // have been removed as a result of the second SetRemoteDescription() call
396 // when the first callback is invoked.
397 callee->pc()->SetRemoteDescription(
398 std::move(srd1_sdp),
399 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
400 callee->pc()->SetRemoteDescription(
401 std::move(srd2_sdp),
402 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
403 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
404 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
405}
406
407// Tests for the legacy SetRemoteDescription() function signature.
408class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {};
409
410// Sanity test making sure the callback is invoked.
411TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) {
412 auto caller = CreatePeerConnection();
413 auto callee = CreatePeerConnection();
414
415 std::string error;
416 ASSERT_TRUE(
417 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
418}
419
420// Verifies legacy behavior: The observer is not called if if the peer
421// connection is destroyed because the asynchronous callback is executed in the
422// peer connection's message handler.
423TEST_F(PeerConnectionRtpLegacyObserverTest,
424 ObserverNotCalledIfPeerConnectionDereferenced) {
425 auto caller = CreatePeerConnection();
426 auto callee = CreatePeerConnection();
427
428 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
429 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
430
431 auto offer = caller->CreateOfferAndSetAsLocal();
432 callee->pc()->SetRemoteDescription(observer, offer.release());
433 callee = nullptr;
434 rtc::Thread::Current()->ProcessMessages(0);
435 EXPECT_FALSE(observer->called());
436}
437
Steve Antonf9381f02017-12-14 10:23:57 -0800438// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800439
440// Test that by default there are no transceivers with Unified Plan.
441TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) {
442 auto caller = CreatePeerConnectionWithUnifiedPlan();
443 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
444}
445
446// Test that a transceiver created with the audio kind has the correct initial
447// properties.
448TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) {
449 auto caller = CreatePeerConnectionWithUnifiedPlan();
450
451 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
452 EXPECT_EQ(rtc::nullopt, transceiver->mid());
453 EXPECT_FALSE(transceiver->stopped());
454 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
455 EXPECT_EQ(rtc::nullopt, transceiver->current_direction());
456}
457
458// Test that adding a transceiver with the audio kind creates an audio sender
459// and audio receiver with the receiver having a live audio track.
460TEST_F(PeerConnectionRtpTest,
461 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
462 auto caller = CreatePeerConnectionWithUnifiedPlan();
463
464 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
465
466 ASSERT_TRUE(transceiver->sender());
467 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
468
469 ASSERT_TRUE(transceiver->receiver());
470 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
471
472 auto track = transceiver->receiver()->track();
473 ASSERT_TRUE(track);
474 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
475 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
476}
477
478// Test that adding a transceiver with the video kind creates an video sender
479// and video receiver with the receiver having a live video track.
480TEST_F(PeerConnectionRtpTest,
481 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
482 auto caller = CreatePeerConnectionWithUnifiedPlan();
483
484 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
485
486 ASSERT_TRUE(transceiver->sender());
487 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
488
489 ASSERT_TRUE(transceiver->receiver());
490 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
491
492 auto track = transceiver->receiver()->track();
493 ASSERT_TRUE(track);
494 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
495 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
496}
497
498// Test that after a call to AddTransceiver, the transceiver shows in
499// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
500// transceiver's receiver shows in GetReceivers().
501TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) {
502 auto caller = CreatePeerConnectionWithUnifiedPlan();
503
504 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
505 EXPECT_EQ(
506 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
507 caller->pc()->GetTransceivers());
508 EXPECT_EQ(
509 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
510 transceiver->sender()},
511 caller->pc()->GetSenders());
512 EXPECT_EQ(
513 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
514 transceiver->receiver()},
515 caller->pc()->GetReceivers());
516}
517
518// Test that the direction passed in through the AddTransceiver init parameter
519// is set in the returned transceiver.
520TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) {
521 auto caller = CreatePeerConnectionWithUnifiedPlan();
522
523 RtpTransceiverInit init;
524 init.direction = RtpTransceiverDirection::kSendOnly;
525 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
526 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
527}
528
Steve Anton9158ef62017-11-27 13:01:52 -0800529// Test that calling AddTransceiver with a track creates a transceiver which has
530// its sender's track set to the passed-in track.
531TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) {
532 auto caller = CreatePeerConnectionWithUnifiedPlan();
533
534 auto audio_track = caller->CreateAudioTrack("audio track");
535 auto transceiver = caller->AddTransceiver(audio_track);
536
537 auto sender = transceiver->sender();
538 ASSERT_TRUE(sender->track());
539 EXPECT_EQ(audio_track, sender->track());
540
541 auto receiver = transceiver->receiver();
542 ASSERT_TRUE(receiver->track());
543 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
544 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
545 receiver->track()->state());
546}
547
548// Test that calling AddTransceiver twice with the same track creates distinct
549// transceivers, senders with the same track.
550TEST_F(PeerConnectionRtpTest,
551 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
552 auto caller = CreatePeerConnectionWithUnifiedPlan();
553
554 auto audio_track = caller->CreateAudioTrack("audio track");
555
556 auto transceiver1 = caller->AddTransceiver(audio_track);
557 auto transceiver2 = caller->AddTransceiver(audio_track);
558
559 EXPECT_NE(transceiver1, transceiver2);
560
561 auto sender1 = transceiver1->sender();
562 auto sender2 = transceiver2->sender();
563 EXPECT_NE(sender1, sender2);
564 EXPECT_EQ(audio_track, sender1->track());
565 EXPECT_EQ(audio_track, sender2->track());
566
567 EXPECT_THAT(caller->pc()->GetTransceivers(),
568 UnorderedElementsAre(transceiver1, transceiver2));
569 EXPECT_THAT(caller->pc()->GetSenders(),
570 UnorderedElementsAre(sender1, sender2));
571}
572
Steve Anton3fe1b152017-12-12 10:20:08 -0800573// RtpTransceiver error handling tests.
574
575TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) {
576 auto caller = CreatePeerConnectionWithUnifiedPlan();
577
578 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
579 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
580}
581
582TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) {
583 auto caller = CreatePeerConnectionWithUnifiedPlan();
584
585 caller->pc()->Close();
586}
587
Steve Antonf9381f02017-12-14 10:23:57 -0800588// Unified Plan AddTrack tests.
589
590class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {};
591
592// Test that adding an audio track creates a new audio RtpSender with the given
593// track.
594TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) {
595 auto caller = CreatePeerConnectionWithUnifiedPlan();
596
597 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800598 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800599 ASSERT_TRUE(sender);
600
601 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
602 EXPECT_EQ(audio_track, sender->track());
603}
604
605// Test that adding a video track creates a new video RtpSender with the given
606// track.
607TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) {
608 auto caller = CreatePeerConnectionWithUnifiedPlan();
609
610 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800611 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800612 ASSERT_TRUE(sender);
613
614 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
615 EXPECT_EQ(video_track, sender->track());
616}
617
618// Test that adding a track to a new PeerConnection creates an RtpTransceiver
619// with the sender that AddTrack returns and in the sendrecv direction.
620TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) {
621 auto caller = CreatePeerConnectionWithUnifiedPlan();
622
623 auto sender = caller->AddAudioTrack("a");
624 ASSERT_TRUE(sender);
625
626 auto transceivers = caller->pc()->GetTransceivers();
627 ASSERT_EQ(1u, transceivers.size());
628 EXPECT_EQ(sender, transceivers[0]->sender());
629 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
630}
631
632// Test that if a transceiver of the same type but no track had been added to
633// the PeerConnection and later a call to AddTrack is made, the resulting sender
634// is the transceiver's sender and the sender's track is the newly-added track.
635TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) {
636 auto caller = CreatePeerConnectionWithUnifiedPlan();
637
638 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
639 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800640 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800641 ASSERT_TRUE(sender);
642
643 auto transceivers = caller->pc()->GetTransceivers();
644 ASSERT_EQ(1u, transceivers.size());
645 EXPECT_EQ(transceiver, transceivers[0]);
646 EXPECT_EQ(sender, transceiver->sender());
647 EXPECT_EQ(audio_track, sender->track());
648}
649
650// Test that adding two tracks to a new PeerConnection creates two
651// RtpTransceivers in the same order.
652TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) {
653 auto caller = CreatePeerConnectionWithUnifiedPlan();
654
655 auto sender1 = caller->AddAudioTrack("a");
656 auto sender2 = caller->AddVideoTrack("v");
657 ASSERT_TRUE(sender2);
658
659 auto transceivers = caller->pc()->GetTransceivers();
660 ASSERT_EQ(2u, transceivers.size());
661 EXPECT_EQ(sender1, transceivers[0]->sender());
662 EXPECT_EQ(sender2, transceivers[1]->sender());
663}
664
665// Test that if there are multiple transceivers with no sending track then a
666// later call to AddTrack will use the one of the same type as the newly-added
667// track.
668TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) {
669 auto caller = CreatePeerConnectionWithUnifiedPlan();
670
671 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
672 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
673 auto sender = caller->AddVideoTrack("v");
674
675 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
676 EXPECT_NE(sender, audio_transceiver->sender());
677 EXPECT_EQ(sender, video_transceiver->sender());
678}
679
680// Test that if the only transceivers that do not have a sending track have a
681// different type from the added track, then AddTrack will create a new
682// transceiver for the track.
683TEST_F(PeerConnectionRtpUnifiedPlanTest,
684 AddTrackDoesNotReuseTransceiverOfWrongType) {
685 auto caller = CreatePeerConnectionWithUnifiedPlan();
686
687 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
688 auto sender = caller->AddVideoTrack("v");
689
690 auto transceivers = caller->pc()->GetTransceivers();
691 ASSERT_EQ(2u, transceivers.size());
692 EXPECT_NE(sender, transceivers[0]->sender());
693 EXPECT_EQ(sender, transceivers[1]->sender());
694}
695
696// Test that the first available transceiver is reused by AddTrack when multiple
697// are available.
698TEST_F(PeerConnectionRtpUnifiedPlanTest,
699 AddTrackReusesFirstMatchingTransceiver) {
700 auto caller = CreatePeerConnectionWithUnifiedPlan();
701
702 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
703 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
704 auto sender = caller->AddAudioTrack("a");
705
706 auto transceivers = caller->pc()->GetTransceivers();
707 ASSERT_EQ(2u, transceivers.size());
708 EXPECT_EQ(sender, transceivers[0]->sender());
709 EXPECT_NE(sender, transceivers[1]->sender());
710}
711
712// Test that a call to AddTrack that reuses a transceiver will change the
713// direction from inactive to sendonly.
714TEST_F(PeerConnectionRtpUnifiedPlanTest,
715 AddTrackChangesDirectionFromInactiveToSendOnly) {
716 auto caller = CreatePeerConnectionWithUnifiedPlan();
717
718 RtpTransceiverInit init;
719 init.direction = RtpTransceiverDirection::kInactive;
720 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
721
722 caller->observer()->clear_negotiation_needed();
723 ASSERT_TRUE(caller->AddAudioTrack("a"));
724 EXPECT_TRUE(caller->observer()->negotiation_needed());
725
726 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
727}
728
729// Test that a call to AddTrack that reuses a transceiver will change the
730// direction from recvonly to sendrecv.
731TEST_F(PeerConnectionRtpUnifiedPlanTest,
732 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
733 auto caller = CreatePeerConnectionWithUnifiedPlan();
734
735 RtpTransceiverInit init;
736 init.direction = RtpTransceiverDirection::kRecvOnly;
737 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
738
739 caller->observer()->clear_negotiation_needed();
740 ASSERT_TRUE(caller->AddAudioTrack("a"));
741 EXPECT_TRUE(caller->observer()->negotiation_needed());
742
743 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
744}
745
Steve Anton02ee47c2018-01-10 16:26:06 -0800746TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackCreatesSenderWithTrackId) {
747 const std::string kTrackId = "audio_track";
748
749 auto caller = CreatePeerConnectionWithUnifiedPlan();
750
751 auto audio_track = caller->CreateAudioTrack(kTrackId);
752 auto sender = caller->AddTrack(audio_track);
753
754 EXPECT_EQ(kTrackId, sender->id());
755}
756
Steve Antonf9381f02017-12-14 10:23:57 -0800757// Unified Plan AddTrack error handling.
758
759TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) {
760 auto caller = CreatePeerConnectionWithUnifiedPlan();
761
762 auto audio_track = caller->CreateAudioTrack("a");
763 caller->pc()->Close();
764
765 caller->observer()->clear_negotiation_needed();
Steve Anton2d6c76a2018-01-05 17:10:52 -0800766 auto result = caller->pc()
767 ->AddTrack(audio_track, std::vector<std::string>());
768 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -0800769 EXPECT_FALSE(caller->observer()->negotiation_needed());
770}
771
772TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) {
773 auto caller = CreatePeerConnectionWithUnifiedPlan();
774
775 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800776 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -0800777
778 caller->observer()->clear_negotiation_needed();
Steve Anton2d6c76a2018-01-05 17:10:52 -0800779 auto result = caller->pc()
780 ->AddTrack(audio_track, std::vector<std::string>());
781 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -0800782 EXPECT_FALSE(caller->observer()->negotiation_needed());
783}
784
785// Unified Plan RemoveTrack tests.
786
787// Test that calling RemoveTrack on a sender with a previously-added track
788// clears the sender's track.
789TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) {
790 auto caller = CreatePeerConnectionWithUnifiedPlan();
791
792 auto sender = caller->AddAudioTrack("a");
793 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
794
795 EXPECT_FALSE(sender->track());
796}
797
798// Test that calling RemoveTrack on a sender where the transceiver is configured
799// in the sendrecv direction changes the transceiver's direction to recvonly.
800TEST_F(PeerConnectionRtpUnifiedPlanTest,
801 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
802 auto caller = CreatePeerConnectionWithUnifiedPlan();
803
804 RtpTransceiverInit init;
805 init.direction = RtpTransceiverDirection::kSendRecv;
806 auto transceiver =
807 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
808
809 caller->observer()->clear_negotiation_needed();
810 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
811 EXPECT_TRUE(caller->observer()->negotiation_needed());
812
813 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
814 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
815}
816
817// Test that calling RemoveTrack on a sender where the transceiver is configured
818// in the sendonly direction changes the transceiver's direction to inactive.
819TEST_F(PeerConnectionRtpUnifiedPlanTest,
820 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
821 auto caller = CreatePeerConnectionWithUnifiedPlan();
822
823 RtpTransceiverInit init;
824 init.direction = RtpTransceiverDirection::kSendOnly;
825 auto transceiver =
826 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
827
828 caller->observer()->clear_negotiation_needed();
829 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
830 EXPECT_TRUE(caller->observer()->negotiation_needed());
831
832 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
833}
834
835// Test that calling RemoveTrack with a sender that has a null track results in
836// no change in state.
837TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) {
838 auto caller = CreatePeerConnectionWithUnifiedPlan();
839
840 auto sender = caller->AddAudioTrack("a");
841 auto transceiver = caller->pc()->GetTransceivers()[0];
842 ASSERT_TRUE(sender->SetTrack(nullptr));
843
844 caller->observer()->clear_negotiation_needed();
845 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
846 EXPECT_FALSE(caller->observer()->negotiation_needed());
847
848 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
849}
850
851// Unified Plan RemoveTrack error handling.
852
853TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) {
854 auto caller = CreatePeerConnectionWithUnifiedPlan();
855
856 auto sender = caller->AddAudioTrack("a");
857 caller->pc()->Close();
858
859 caller->observer()->clear_negotiation_needed();
860 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
861 EXPECT_FALSE(caller->observer()->negotiation_needed());
862}
863
864TEST_F(PeerConnectionRtpUnifiedPlanTest,
865 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
866 auto caller = CreatePeerConnectionWithUnifiedPlan();
867
868 auto sender = caller->AddAudioTrack("a");
869 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
870
871 caller->observer()->clear_negotiation_needed();
872 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
873 EXPECT_FALSE(caller->observer()->negotiation_needed());
874}
875
Steve Antone831b8c2018-02-01 12:22:16 -0800876// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
877// options for this kind of signaling: media section based (a=msid) and ssrc
878// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
879// we want to ensure compatibility with older Plan B endpoints that might expect
880// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
881// types but answers with the same type as the offer.
882
883class PeerConnectionMsidSignalingTest : public PeerConnectionRtpTest {};
884
885TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
886 auto caller = CreatePeerConnectionWithUnifiedPlan();
887 caller->AddAudioTrack("caller_audio");
888 auto callee = CreatePeerConnectionWithUnifiedPlan();
889 callee->AddAudioTrack("callee_audio");
890
891 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
892
893 // Offer should have had both a=msid and a=ssrc MSID lines.
894 auto* offer = callee->pc()->remote_description();
895 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
896 cricket::kMsidSignalingSsrcAttribute),
897 offer->description()->msid_signaling());
898
899 // Answer should have had only a=msid lines.
900 auto* answer = caller->pc()->remote_description();
901 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
902 answer->description()->msid_signaling());
903}
904
905TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
906 auto caller = CreatePeerConnectionWithPlanB();
907 caller->AddAudioTrack("caller_audio");
908 auto callee = CreatePeerConnectionWithUnifiedPlan();
909 callee->AddAudioTrack("callee_audio");
910
911 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
912
913 // Offer should have only a=ssrc MSID lines.
914 auto* offer = callee->pc()->remote_description();
915 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
916 offer->description()->msid_signaling());
917
918 // Answer should have only a=ssrc MSID lines to match the offer.
919 auto* answer = caller->pc()->remote_description();
920 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
921 answer->description()->msid_signaling());
922}
923
924TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
925 auto caller = CreatePeerConnectionWithUnifiedPlan();
926 caller->AddAudioTrack("caller_audio");
927 auto callee = CreatePeerConnectionWithUnifiedPlan();
928 callee->AddAudioTrack("callee_audio");
929
930 auto offer = caller->CreateOffer();
931 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
932 // section only.
933 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
934
935 ASSERT_TRUE(
936 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
937 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
938
939 // Answer should have only a=msid to match the offer.
940 auto answer = callee->CreateAnswer();
941 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
942 answer->description()->msid_signaling());
943}
944
Henrik Boström91d039b2018-01-11 17:43:30 +0100945// Sender setups in a call.
946
947class PeerConnectionSenderTest : public PeerConnectionRtpTest {};
948
949TEST_F(PeerConnectionSenderTest, CreateTwoSendersWithSameTrack) {
950 auto caller = CreatePeerConnection();
951 auto callee = CreatePeerConnection();
952
953 auto track = caller->CreateAudioTrack("audio_track");
954 auto sender1 = caller->AddTrack(track);
955 ASSERT_TRUE(sender1);
956 // We need to temporarily reset the track for the subsequent AddTrack() to
957 // succeed.
958 EXPECT_TRUE(sender1->SetTrack(nullptr));
959 auto sender2 = caller->AddTrack(track);
960 EXPECT_TRUE(sender2);
961 EXPECT_TRUE(sender1->SetTrack(track));
962
963 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
964 // return true, and doing |callee->SetRemoteDescription()| should work.
965 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
966}
967
Steve Anton9158ef62017-11-27 13:01:52 -0800968} // namespace webrtc