blob: 9fac70c4979e84b3a3f1415cf6e65edbf644336c [file] [log] [blame]
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001/* Copyright (c) 2015-2017 The Khronos Group Inc.
2 * Copyright (c) 2015-2017 Valve Corporation
3 * Copyright (c) 2015-2017 LunarG, Inc.
4 * Copyright (C) 2015-2017 Google Inc.
5 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
19 */
20
21#define NOMINMAX
John Zulauf0fe5bfe2018-05-23 09:36:00 -060022#define VALIDATION_ERROR_MAP_IMPL
Mark Lobodzinskid4950072017-08-01 13:02:20 -060023
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060053#if defined __ANDROID__
54#include <android/log.h>
Mark Lobodzinski88529492018-04-01 10:38:15 -060055#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "PARAMETER_VALIDATION", __VA_ARGS__))
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -060056#else
57#define LOGCONSOLE(...) \
58 { \
59 printf(__VA_ARGS__); \
60 printf("\n"); \
61 }
62#endif
63
Mark Lobodzinskid4950072017-08-01 13:02:20 -060064namespace parameter_validation {
65
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060066extern std::unordered_map<std::string, void *> custom_functions;
67
Mark Lobodzinskid4950072017-08-01 13:02:20 -060068extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
69 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
70extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
71extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
72 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
73extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
74extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
75 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
76extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
77 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator,
79 VkDebugReportCallbackEXT *pMsgCallback);
80extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
81 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070082extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
83 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
84 const VkAllocationCallbacks *pAllocator,
85 VkDebugUtilsMessengerEXT *pMessenger);
86extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
87 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060088extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
89 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010090extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
91 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
92extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
93 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060094
95// TODO : This can be much smarter, using separate locks for separate global data
96std::mutex global_lock;
97
98static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
99std::unordered_map<void *, layer_data *> layer_data_map;
100std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
101
102void InitializeManualParameterValidationFunctionPointers(void);
103
104static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700105 layer_debug_report_actions(instance_data->report_data, instance_data->logging_callback, pAllocator,
106 "lunarg_parameter_validation");
107 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
108 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600109}
110
Mark Young6ba8abe2017-11-09 10:37:04 -0700111static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
112 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600113
114static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700115 "VK_LAYER_LUNARG_parameter_validation",
116 VK_LAYER_API_VERSION,
117 1,
118 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600119};
120
121static const int MaxParamCheckerStringLength = 256;
122
John Zulauf71968502017-10-26 13:51:15 -0600123template <typename T>
124static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
125 // Using only < for generality and || for early abort
126 return !((value < min) || (max < value));
127}
128
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600129static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600130 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 bool skip = false;
132
133 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
134
135 if (result == VK_STRING_ERROR_NONE) {
136 return skip;
137 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600138 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
139 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600141 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
142 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600143 }
144 return skip;
145}
146
147static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600148 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600149 bool skip = false;
150
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600151 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
152 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600153 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600154 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
155 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600156 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600157 skip |=
158 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600159 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600160 "%s: %s (= %" PRIu32
161 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
162 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 }
164
165 return skip;
166}
167
168static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600169 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
170 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600171 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600172 if (queue_families) {
173 std::unordered_set<uint32_t> set;
174 for (uint32_t i = 0; i < queue_family_count; ++i) {
175 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
176
177 if (set.count(queue_families[i])) {
178 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600179 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600180 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
181 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600182 } else {
183 set.insert(queue_families[i]);
184 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600185 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600186 }
187 }
188 }
189 return skip;
190}
191
John Zulauf620755c2018-04-16 11:00:43 -0600192static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
193 bool skip = false;
194 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
195 if (api_version_nopatch != effective_api_version) {
196 if (api_version_nopatch < VK_API_VERSION_1_0) {
197 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600198 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600199 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
200 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
201 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
202 } else {
203 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600204 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600205 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
206 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
207 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
208 }
209 }
210 return skip;
211}
212
213template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600214static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
215 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600216 bool skip = false;
217 if (!extension_name) {
218 return skip; // Robust to invalid char *
219 }
220 auto info = ExtensionState::get_info(extension_name);
221
222 if (!info.state) {
223 return skip; // Unknown extensions cannot be checked so report OK
224 }
225
Pat Brown3eddb062018-09-05 14:07:37 -0400226 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600227 std::vector<const char *> missing;
228 for (const auto &req : info.requires) {
229 if (!(extensions.*(req.enabled))) {
230 missing.push_back(req.name);
231 }
232 }
233
234 // Report any missing requirements
235 if (missing.size()) {
236 std::string missing_joined_list = string_join(", ", missing);
237 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400238 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
239 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600240 }
241 return skip;
242}
243
244bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
245 bool skip = false;
246 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600247 skip |=
248 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
249 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600250 }
251
252 return skip;
253}
254
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600255VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600256 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600257 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
258
259 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
260 assert(chain_info != nullptr);
261 assert(chain_info->u.pLayerInfo != nullptr);
262
263 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
264 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
265 if (fpCreateInstance == NULL) {
266 return VK_ERROR_INITIALIZATION_FAILED;
267 }
268
269 // Advance the link info for the next element on the chain
270 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
271
272 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
273
274 if (result == VK_SUCCESS) {
275 InitializeManualParameterValidationFunctionPointers();
276 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
277 assert(my_instance_data != nullptr);
278
279 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
280 my_instance_data->instance = *pInstance;
281 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700282 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
283 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600284
285 // Look for one or more debug report create info structures
286 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700287 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
288 &my_instance_data->tmp_messenger_create_infos,
289 &my_instance_data->tmp_debug_messengers)) {
290 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600291 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700292 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
293 my_instance_data->tmp_messenger_create_infos,
294 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600295 // Failure of setting up one or more of the callback.
296 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700297 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
298 my_instance_data->tmp_debug_messengers);
299 my_instance_data->num_tmp_debug_messengers = 0;
300 }
301 }
302 }
303 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
304 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
305 if (my_instance_data->num_tmp_report_callbacks > 0) {
306 // Setup the temporary callback(s) here to catch early issues:
307 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
308 my_instance_data->tmp_report_create_infos,
309 my_instance_data->tmp_report_callbacks)) {
310 // Failure of setting up one or more of the callback.
311 // Therefore, clean up and don't use those callbacks:
312 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
313 my_instance_data->tmp_report_callbacks);
314 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600315 }
316 }
317 }
318
319 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600320 // Note: From the spec--
321 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
322 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
323 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
324 ? pCreateInfo->pApplicationInfo->apiVersion
325 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600326
John Zulauf1909e6a2018-09-05 11:43:11 -0600327 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600328
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600329 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
330 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600331 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600332 validate_instance_extensions(my_instance_data, pCreateInfo);
333
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600334 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
335
336 if (pCreateInfo->pApplicationInfo) {
337 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600338 validate_string(
339 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
340 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600341 }
342
343 if (pCreateInfo->pApplicationInfo->pEngineName) {
344 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600345 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600346 }
347 }
348
349 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700350 if (my_instance_data->num_tmp_debug_messengers > 0) {
351 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
352 my_instance_data->tmp_debug_messengers);
353 }
354 if (my_instance_data->num_tmp_report_callbacks > 0) {
355 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
356 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600357 }
358 }
359
360 return result;
361}
362
363VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
364 // Grab the key before the instance is destroyed.
365 dispatch_key key = get_dispatch_key(instance);
366 bool skip = false;
367 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
368
369 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
370 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700371 if (instance_data->num_tmp_debug_messengers > 0) {
372 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
373 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
374 callback_setup = true;
375 }
376 }
377 if (instance_data->num_tmp_report_callbacks > 0) {
378 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
379 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600380 callback_setup = true;
381 }
382 }
383
384 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
385
386 // Disable and cleanup the temporary callback(s):
387 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700388 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
389 instance_data->tmp_debug_messengers);
390 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
391 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600392 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700393 if (instance_data->num_tmp_debug_messengers > 0) {
394 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
395 instance_data->num_tmp_debug_messengers = 0;
396 }
397 if (instance_data->num_tmp_report_callbacks > 0) {
398 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
399 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600400 }
401
402 if (!skip) {
403 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
404
405 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700406 while (instance_data->logging_messenger.size() > 0) {
407 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
408 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
409 instance_data->logging_messenger.pop_back();
410 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600411 while (instance_data->logging_callback.size() > 0) {
412 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700413 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600414 instance_data->logging_callback.pop_back();
415 }
416
Mark Young6ba8abe2017-11-09 10:37:04 -0700417 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600418 }
419
420 FreeLayerDataPtr(key, instance_layer_data_map);
421}
422
423VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
424 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
425 const VkAllocationCallbacks *pAllocator,
426 VkDebugReportCallbackEXT *pMsgCallback) {
427 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
428 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
429
430 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
431 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
432 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700433 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
434 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
435 if (VK_SUCCESS != result) {
436 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600438 }
439 return result;
440}
441
442VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
443 const VkAllocationCallbacks *pAllocator) {
444 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
445 if (!skip) {
446 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
447 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700448 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
449 }
450}
451
452VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
453 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
454 const VkAllocationCallbacks *pAllocator,
455 VkDebugUtilsMessengerEXT *pMessenger) {
456 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
457 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
458
459 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
460 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
461 if (VK_SUCCESS == result) {
462 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
463 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
464 if (VK_SUCCESS != result) {
465 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
466 }
467 }
468 return result;
469}
470
471VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
472 const VkAllocationCallbacks *pAllocator) {
473 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
474 if (!skip) {
475 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
476 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
477 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600478 }
479}
480
John Zulauf620755c2018-04-16 11:00:43 -0600481template <typename ExtensionState>
482static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
483 if (!extension_name) return false; // null strings specify nothing
484 auto info = ExtensionState::get_info(extension_name);
485 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
486 return state;
487}
488
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600489static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600490 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600491 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600492 bool maint1 = false;
493 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600494
495 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
496 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
497 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600498 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600499 }
500 }
501
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600502 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600503 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
504 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
505
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600506 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
507 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600510 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
511 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600512 }
513 }
514
515 if (maint1 && negative_viewport) {
516 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600517 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600518 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600519 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600520 }
521
522 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
523 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600524 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
525 if (features2) {
526 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
527 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600528 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600529 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
530 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600531 }
532 }
533
534 // Validate pCreateInfo->pQueueCreateInfos
535 if (pCreateInfo->pQueueCreateInfos) {
536 std::unordered_set<uint32_t> set;
537
538 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
539 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
540 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
541 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600542 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600543 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600544 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700545 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600546 "index value.",
547 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600548 } else if (set.count(requested_queue_family)) {
549 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600550 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600551 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600552 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600553 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
554 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 } else {
556 set.insert(requested_queue_family);
557 }
558
559 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
560 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
561 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
562 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
563 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600564 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600565 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600566 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600567 "] (=%f) is not between 0 and 1 (inclusive).",
568 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600569 }
570 }
571 }
572 }
573 }
574
575 return skip;
576}
577
578VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
579 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
580 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
581
582 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
583 bool skip = false;
584 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
585 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600586
587 // Query and save physical device limits for this device, needed for validation
588 VkPhysicalDeviceProperties device_properties = {};
589 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
590
John Zulauf1909e6a2018-09-05 11:43:11 -0600591 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
592 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600593 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600594 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600595
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600596 std::unique_lock<std::mutex> lock(global_lock);
597
598 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
599
John Zulauf620755c2018-04-16 11:00:43 -0600600 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600601
602 if (!skip) {
603 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
604 assert(chain_info != nullptr);
605 assert(chain_info->u.pLayerInfo != nullptr);
606
607 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
608 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
609 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
610 if (fpCreateDevice == NULL) {
611 return VK_ERROR_INITIALIZATION_FAILED;
612 }
613
614 // Advance the link info for the next element on the chain
615 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
616
617 lock.unlock();
618
619 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
620
621 lock.lock();
622
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623 if (result == VK_SUCCESS) {
624 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
625 assert(my_device_data != nullptr);
626
Mark Young6ba8abe2017-11-09 10:37:04 -0700627 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600628 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
629
John Zulauf620755c2018-04-16 11:00:43 -0600630 my_device_data->api_version = api_version;
631 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632
633 // Store createdevice data
634 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
635 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
636 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
637 pCreateInfo->pQueueCreateInfos[i].queueCount));
638 }
639 }
640
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600641 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
642 my_device_data->physical_device = physicalDevice;
643 my_device_data->device = *pDevice;
644
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500645 if (my_device_data->extensions.vk_nv_shading_rate_image) {
646 // Get the needed shading rate image limits
647 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
648 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
649 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
650 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
651 }
652
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600653 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600654 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
655 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
656 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600657 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
658 if (features2) {
659 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600660 }
661 }
662 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700663 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600664 } else {
665 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
666 }
667 }
668 }
669
670 return result;
671}
672
673VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
674 dispatch_key key = get_dispatch_key(device);
675 bool skip = false;
676 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
677 {
678 std::unique_lock<std::mutex> lock(global_lock);
679 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
680 }
681
682 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700683 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600684 device_data->dispatch_table.DestroyDevice(device, pAllocator);
685 }
686 FreeLayerDataPtr(key, layer_data_map);
687}
688
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600689bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
690 bool skip = false;
691 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
692
Dave Houlton413a6782018-05-22 13:01:54 -0600693 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
694 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600695 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
696 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
697 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600698 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600699 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700700 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600701 ") when the device was created (i.e. is not less than %" PRIu32 ").",
702 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600703 }
704 return skip;
705}
706
707VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
708 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
709 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
710 bool skip = false;
711 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
712 std::unique_lock<std::mutex> lock(global_lock);
713
714 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600715 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600716
717 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
718
719 lock.unlock();
720 if (!skip) {
721 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
722 }
723 return result;
724}
725
726VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
727 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
728 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
729 bool skip = false;
730 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
731
732 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
733
734 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
735 if (pCreateInfo != nullptr) {
736 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
737 // VkQueryPipelineStatisticFlagBits values
738 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
739 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
740 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600741 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700742 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
743 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600744 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600745 }
746 }
747 if (!skip) {
748 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
749 }
750 return result;
751}
752
Petr Krause91f7a12017-12-14 20:57:36 +0100753VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
754 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
755 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
756 bool skip = false;
757 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
758
759 {
760 std::unique_lock<std::mutex> lock(global_lock);
761 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
762
Dave Houltonb3bbec72018-01-17 10:13:33 -0700763 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
764 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100765 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
766 if (custom_func != nullptr) {
767 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
768 }
769 }
770
771 if (!skip) {
772 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
773
774 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
775 if (result == VK_SUCCESS) {
776 std::unique_lock<std::mutex> lock(global_lock);
777 const auto renderPass = *pRenderPass;
778 auto &renderpass_state = device_data->renderpasses_states[renderPass];
779
780 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
781 bool uses_color = false;
782 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
783 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
784
785 bool uses_depthstencil = false;
786 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
787 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
788 uses_depthstencil = true;
789
790 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
791 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
792 }
793 }
794 }
795 return result;
796}
797
798VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
799 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
800 bool skip = false;
801
802 {
803 std::unique_lock<std::mutex> lock(global_lock);
804 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
805
Dave Houltonb3bbec72018-01-17 10:13:33 -0700806 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
807 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100808 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
809 if (custom_func != nullptr) {
810 skip |= custom_func(device, renderPass, pAllocator);
811 }
812 }
813
814 if (!skip) {
815 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
816
817 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
818 {
819 std::unique_lock<std::mutex> lock(global_lock);
820 device_data->renderpasses_states.erase(renderPass);
821 }
822 }
823}
824
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600825bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
826 VkBuffer *pBuffer) {
827 bool skip = false;
828 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
829 debug_report_data *report_data = device_data->report_data;
830
Mark Lobodzinski88529492018-04-01 10:38:15 -0600831 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100832
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600833 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600834 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600835
836 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
837 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
838 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
839 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600840 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600841 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600842 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600843 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600844 }
845
846 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
847 // queueFamilyIndexCount uint32_t values
848 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600849 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600850 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600851 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
852 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600853 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600854 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600855 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600856 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
857 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600858 }
859 }
860
861 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
862 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
863 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
864 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600865 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600866 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600868 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600869 }
870 }
871
872 return skip;
873}
874
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600875bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
876 VkImage *pImage) {
877 bool skip = false;
878 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
879 debug_report_data *report_data = device_data->report_data;
880
Mark Lobodzinski88529492018-04-01 10:38:15 -0600881 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100882
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600883 if (pCreateInfo != nullptr) {
884 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
885 FormatIsCompressed_ETC2_EAC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600886 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
887 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600888 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionETC2 feature is "
889 "not enabled: neither ETC2 nor EAC formats can be used to create images.",
890 string_VkFormat(pCreateInfo->format));
891 }
892
893 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
894 FormatIsCompressed_ASTC_LDR(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600895 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
896 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700897 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionASTC_LDR feature "
898 "is not enabled: ASTC formats cannot be used to create images.",
899 string_VkFormat(pCreateInfo->format));
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600900 }
901
902 if ((device_data->physical_device_features.textureCompressionBC == false) && FormatIsCompressed_BC(pCreateInfo->format)) {
Dave Houlton413a6782018-05-22 13:01:54 -0600903 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
904 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -0700905 "vkCreateImage(): Attempting to create VkImage with format %s. The textureCompressionBC feature is not "
906 "enabled: BC compressed formats cannot be used to create images.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600907 string_VkFormat(pCreateInfo->format));
908 }
909
910 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
911 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
912 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
913 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600914 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600915 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600916 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600917 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600918 }
919
920 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
921 // queueFamilyIndexCount uint32_t values
922 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600923 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600924 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600925 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
926 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600927 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600928 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600929 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
930 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
931 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600932 }
933 }
934
Dave Houlton413a6782018-05-22 13:01:54 -0600935 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
936 "VUID-VkImageCreateInfo-extent-00944", log_misc);
937 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
938 "VUID-VkImageCreateInfo-extent-00945", log_misc);
939 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
940 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600941
Dave Houlton413a6782018-05-22 13:01:54 -0600942 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
943 log_misc);
944 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
945 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600946
Dave Houlton130c0212018-01-29 13:39:56 -0700947 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700948 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
949 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
950 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600951 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
952 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600953 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
954 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700955 }
956
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600957 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100958 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
959 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600960 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600961 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700962 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600963 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600964 }
965
966 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100967 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
968 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600969 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600970 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600971 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
972 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
973 ") are not equal.",
974 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100975 }
976
977 if (pCreateInfo->arrayLayers < 6) {
978 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600979 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100980 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600981 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
982 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100983 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600984 }
985
986 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600987 skip |=
988 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600989 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600990 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600991 }
992 }
993
Dave Houlton130c0212018-01-29 13:39:56 -0700994 // 3D image may have only 1 layer
995 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600996 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600998 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700999 }
1000
1001 // If multi-sample, validate type, usage, tiling and mip levels.
1002 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1003 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1004 (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) || (pCreateInfo->mipLevels != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001005 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001006 "VUID-VkImageCreateInfo-samples-00962",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001007 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001008 }
1009
1010 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1011 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1012 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1013 // At least one of the legal attachment bits must be set
1014 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001015 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001016 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001017 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001018 }
1019 // No flags other than the legal attachment bits may be set
1020 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1021 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001022 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001023 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001024 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001025 }
1026 }
1027
Jeff Bolzef40fec2018-09-01 22:04:34 -05001028 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001029 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001030 // Max mip levels is different for corner-sampled images vs normal images.
1031 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV)
1032 ? (uint32_t)(ceil(log2(maxDim)))
1033 : (uint32_t)(floor(log2(maxDim)) + 1);
1034 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001035 skip |=
1036 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1037 "VUID-VkImageCreateInfo-mipLevels-00958",
1038 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1039 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001040 }
1041
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001042 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1043 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1044 "VUID-VkImageCreateInfo-flags-00950",
1045 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1046 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1047 }
1048
Petr Krausb6f97802018-03-13 12:31:39 +01001049 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1050 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001051 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001052 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001053 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001054 }
1055
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001056 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1057 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1058 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1059 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001060 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001061 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001062 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001063 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001064 }
1065
1066 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1067 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1068 // Linear tiling is unsupported
1069 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001070 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1071 kVUID_PVError_InvalidUsage,
1072 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1073 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001074 }
1075
1076 // Sparse 1D image isn't valid
1077 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001078 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001079 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001080 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001081 }
1082
1083 // Sparse 2D image when device doesn't support it
1084 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1085 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001086 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001087 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001088 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001089 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001090 }
1091
1092 // Sparse 3D image when device doesn't support it
1093 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1094 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001095 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001096 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001097 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001098 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001099 }
1100
1101 // Multi-sample 2D image when device doesn't support it
1102 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1103 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1104 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001105 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001106 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001107 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001108 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001109 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1110 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001111 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001112 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001113 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001114 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001115 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1116 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001117 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001118 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001119 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001120 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001121 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1122 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001123 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001124 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001125 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001126 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001127 }
1128 }
1129 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001130
Jeff Bolz9af91c52018-09-01 21:53:57 -05001131 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1132 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1133 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1134 "VUID-VkImageCreateInfo-imageType-02082",
1135 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1136 "imageType must be VK_IMAGE_TYPE_2D.");
1137 }
1138 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1139 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1140 "VUID-VkImageCreateInfo-samples-02083",
1141 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1142 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1143 }
1144 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1145 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1146 "VUID-VkImageCreateInfo-tiling-02084",
1147 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1148 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1149 }
1150 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001151
1152 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
1153 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D &&
1154 pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
1155 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1156 "VUID-VkImageCreateInfo-flags-02050",
1157 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1158 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1159 }
1160
1161 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
1162 FormatIsDepthOrStencil(pCreateInfo->format)) {
1163 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1164 "VUID-VkImageCreateInfo-flags-02051",
1165 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1166 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1167 "not be a depth/stencil format.");
1168 }
1169
1170 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D &&
1171 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
1172 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1173 "VUID-VkImageCreateInfo-flags-02052",
1174 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1175 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1176 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001177 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Jeff Bolzef40fec2018-09-01 22:04:34 -05001178 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
1179 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1180 "VUID-VkImageCreateInfo-flags-02053",
1181 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1182 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1183 "must be greater than 1.");
1184
1185 }
1186 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001187 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001188
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001189 return skip;
1190}
1191
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001192bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1193 VkImageView *pView) {
1194 bool skip = false;
1195 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1196 debug_report_data *report_data = device_data->report_data;
1197
1198 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001199 // Validate chained VkImageViewUsageCreateInfo struct, if present
1200 if (nullptr != pCreateInfo->pNext) {
1201 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1202 if (chained_ivuci_struct) {
1203 if (0 == chained_ivuci_struct->usage) {
1204 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001205 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001206 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001207 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1208 std::stringstream ss;
1209 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1210 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1211 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001212 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001213 }
1214 }
1215 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001216 }
1217 return skip;
1218}
1219
Petr Krausb3fcdb42018-01-09 22:09:09 +01001220bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1221 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1222 bool skip = false;
1223 debug_report_data *report_data = device_data->report_data;
1224
1225 // Note: for numerical correctness
1226 // - float comparisons should expect NaN (comparison always false).
1227 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1228
1229 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001230 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001231 if (v1_f <= 0.0f) return true;
1232
1233 float intpart;
1234 const float fract = modff(v1_f, &intpart);
1235
1236 assert(std::numeric_limits<float>::radix == 2);
1237 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1238 if (intpart >= u32_max_plus1) return false;
1239
1240 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1241 if (v1_u32 < v2_u32)
1242 return true;
1243 else if (v1_u32 == v2_u32 && fract == 0.0f)
1244 return true;
1245 else
1246 return false;
1247 };
1248
1249 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1250 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1251 return (v1_f <= v2_f);
1252 };
1253
1254 // width
1255 bool width_healthy = true;
1256 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1257
1258 if (!(viewport.width > 0.0f)) {
1259 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001260 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001261 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001262 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1263 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001264 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001265 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1266 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001267 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001268 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001269 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001270 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1271 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001272 }
1273
1274 // height
1275 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001276 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1277 device_data->extensions.vk_khr_maintenance1 ||
1278 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001279 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1280
1281 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1282 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001283 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001284 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001285 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1286 height_healthy = false;
1287
Dave Houlton413a6782018-05-22 13:01:54 -06001288 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001289 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1290 ").",
1291 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001292 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1293 height_healthy = false;
1294
1295 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001296 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001297 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001298 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1299 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001300 }
1301
1302 // x
1303 bool x_healthy = true;
1304 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1305 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001306 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001307 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1308 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001309 }
1310
1311 // x + width
1312 if (x_healthy && width_healthy) {
1313 const float right_bound = viewport.x + viewport.width;
1314 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001315 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001316 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001317 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1318 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1319 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001320 }
1321 }
1322
1323 // y
1324 bool y_healthy = true;
1325 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1326 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001327 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001328 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1329 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001330 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1331 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001332 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001333 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1334 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001335 }
1336
1337 // y + height
1338 if (y_healthy && height_healthy) {
1339 const float boundary = viewport.y + viewport.height;
1340
1341 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001342 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001343 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1344 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1345 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001346 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1347 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001348 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001349 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1350 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001351 }
1352 }
1353
1354 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1355 // minDepth
1356 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001357 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001358
Petr Krausb3fcdb42018-01-09 22:09:09 +01001359 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001360 "[0.0, 1.0] range.",
1361 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001362 }
1363
1364 // maxDepth
1365 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001366 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001367
Petr Krausb3fcdb42018-01-09 22:09:09 +01001368 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001369 "[0.0, 1.0] range.",
1370 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 }
1372 }
1373
1374 return skip;
1375}
1376
Jeff Bolz9af91c52018-09-01 21:53:57 -05001377struct SampleOrderInfo
1378{
1379 VkShadingRatePaletteEntryNV shadingRate;
1380 uint32_t width;
1381 uint32_t height;
1382};
1383
1384// All palette entries with more than one pixel per fragment
1385static SampleOrderInfo sampleOrderInfos[] =
1386{
1387 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1388 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1389 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1390 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1391 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1392 { VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
1393};
1394
1395bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order)
1396{
1397 bool skip = false;
1398 debug_report_data *report_data = device_data->report_data;
1399
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001400 SampleOrderInfo *sampleOrderInfo = nullptr;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001401 uint32_t infoIdx = 0;
1402 for (; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
1403 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001404 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001405 break;
1406 }
1407 }
1408
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001409 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1411 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1412 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1413 "that generates fragments with more than one pixel.");
1414 return skip;
1415 }
1416
1417 if (order->sampleCount == 0 ||
1418 (order->sampleCount & (order->sampleCount - 1)) ||
1419 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1420 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1421 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
1422 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32 ") must "
1423 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1424 "is set in framebufferNoAttachmentsSampleCounts.",
1425 order->sampleCount);
1426 }
1427
Jeff Bolz9af91c52018-09-01 21:53:57 -05001428 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1429 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1430 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
1431 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1432 "be equal to the product of sampleCount (=%" PRIu32 "), the fragment width for shadingRate "
1433 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1434 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1435 }
1436
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001437 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
1438 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1439 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1440 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32 ") must "
1441 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1442 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001443 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001444
1445 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001446 // the first width*height*sampleCount bits to all be set. Note: There is no
1447 // guarantee that 64 bits is enough, but practically it's unlikely for an
1448 // implementation to support more than 32 bits for samplemask.
Jeff Bolz9af91c52018-09-01 21:53:57 -05001449 uint64_t sampleLocationsMask = 0;
1450 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1451 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1452 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1453 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1454 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1455 "pixelX must be less than the width (in pixels) of the fragment.");
1456 }
1457 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1458 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1459 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1460 "pixelY must be less than the height (in pixels) of the fragment.");
1461 }
1462 if (sampleLoc->sample >= order->sampleCount) {
1463 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1464 "VUID-VkCoarseSampleLocationNV-sample-02080",
1465 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1466 }
1467 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1468 sampleLocationsMask |= 1ULL << idx;
1469 }
1470
1471 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1472 if (sampleLocationsMask != expectedMask) {
1473 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1474 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1475 "The array pSampleLocations must contain exactly one entry for "
1476 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
1477 }
1478
1479 return skip;
1480}
1481
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001482bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1483 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1484 VkPipeline *pPipelines) {
1485 bool skip = false;
1486 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1487 debug_report_data *report_data = device_data->report_data;
1488
1489 if (pCreateInfos != nullptr) {
1490 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001491 bool has_dynamic_viewport = false;
1492 bool has_dynamic_scissor = false;
1493 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001494 bool has_dynamic_viewport_w_scaling_nv = false;
1495 bool has_dynamic_discard_rectangle_ext = false;
1496 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001497 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001498 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001499 if (pCreateInfos[i].pDynamicState != nullptr) {
1500 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1501 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1502 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1503 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1504 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1505 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001506 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1507 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1508 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001509 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001510 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001511 }
1512 }
1513
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001514 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1515 if (pCreateInfos[i].pVertexInputState != nullptr) {
1516 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001517
1518 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1519 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1520 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1521 "vkCreateGraphicsPipelines: pararameter "
1522 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1523 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1524 i, vertex_input_state->vertexBindingDescriptionCount,
1525 device_data->device_limits.maxVertexInputBindings);
1526 }
1527
1528 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1529 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1530 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1531 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001532 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001533 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1534 i, vertex_input_state->vertexBindingDescriptionCount,
1535 device_data->device_limits.maxVertexInputAttributes);
1536 }
1537
1538 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001539 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1540 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001541 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1542 if (binding_it != vertex_bindings.cend()) {
1543 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1544 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1545 "vkCreateGraphicsPipelines: parameter "
1546 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1547 "(%" PRIu32 ") is not distinct.",
1548 i, d, vertex_bind_desc.binding);
1549 }
1550 vertex_bindings.insert(vertex_bind_desc.binding);
1551
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001552 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1553 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001554 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001555 "vkCreateGraphicsPipelines: parameter "
1556 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001557 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1558 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001559 }
1560
1561 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1562 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001563 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001564 "vkCreateGraphicsPipelines: parameter "
1565 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001566 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1567 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001568 }
1569 }
1570
Peter Kohautc7d9d392018-07-15 00:34:07 +02001571 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001572 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1573 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001574 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1575 if (location_it != attribute_locations.cend()) {
1576 skip |= log_msg(
1577 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1578 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1579 "vkCreateGraphicsPipelines: parameter "
1580 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1581 i, d, vertex_attrib_desc.location);
1582 }
1583 attribute_locations.insert(vertex_attrib_desc.location);
1584
1585 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1586 if (binding_it == vertex_bindings.cend()) {
1587 skip |= log_msg(
1588 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1589 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1590 "vkCreateGraphicsPipelines: parameter "
1591 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1592 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1593 i, d, vertex_attrib_desc.binding, i);
1594 }
1595
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001596 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1597 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001598 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001599 "vkCreateGraphicsPipelines: parameter "
1600 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001601 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1602 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001603 }
1604
1605 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1606 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001607 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001608 "vkCreateGraphicsPipelines: parameter "
1609 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001610 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1611 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001612 }
1613
1614 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001615 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001616 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001617 "vkCreateGraphicsPipelines: parameter "
1618 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1619 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1620 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001621 }
1622 }
1623 }
1624
1625 if (pCreateInfos[i].pStages != nullptr) {
1626 bool has_control = false;
1627 bool has_eval = false;
1628
1629 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1630 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1631 has_control = true;
1632 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1633 has_eval = true;
1634 }
1635 }
1636
1637 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1638 if (has_control && has_eval) {
1639 if (pCreateInfos[i].pTessellationState == nullptr) {
1640 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001641 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001642 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1643 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001644 "pCreateInfos[%d].pTessellationState must not be NULL.",
1645 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001646 } else {
1647 skip |= validate_struct_pnext(
1648 report_data, "vkCreateGraphicsPipelines",
1649 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001650 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1651 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001652
1653 skip |= validate_reserved_flags(
1654 report_data, "vkCreateGraphicsPipelines",
1655 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001656 pCreateInfos[i].pTessellationState->flags,
1657 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001658
1659 if (pCreateInfos[i].pTessellationState->sType !=
1660 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1661 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001662 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001663 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001664 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1665 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001666 }
1667
1668 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1669 pCreateInfos[i].pTessellationState->patchControlPoints >
1670 device_data->device_limits.maxTessellationPatchSize) {
1671 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001672 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001673 "vkCreateGraphicsPipelines: invalid parameter "
1674 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001675 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001676 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001677 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001678 }
1679 }
1680 }
1681 }
1682
1683 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1684 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1685 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1686 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001687 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001688 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001689 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1690 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001691 "].pViewportState (=NULL) is not a valid pointer.",
1692 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001693 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001694 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1695
1696 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1697 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001698 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001699 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001700 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1701 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001702 }
1703
Petr Krausa6103552017-11-16 21:21:58 +01001704 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1705 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001706 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1707 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001708 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1709 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001710 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001711 skip |= validate_struct_pnext(
1712 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001713 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001714 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001715 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1716 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001717 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001718 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1719 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001720
1721 skip |= validate_reserved_flags(
1722 report_data, "vkCreateGraphicsPipelines",
1723 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001724 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001725
Jeff Bolz3e71f782018-08-29 23:15:45 -05001726 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001727 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
1728 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001729
Petr Krausa6103552017-11-16 21:21:58 +01001730 if (!device_data->physical_device_features.multiViewport) {
1731 if (viewport_state.viewportCount != 1) {
1732 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001733 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001734 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1735 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001736 ") is not 1.",
1737 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001738 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001739
Petr Krausa6103552017-11-16 21:21:58 +01001740 if (viewport_state.scissorCount != 1) {
1741 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001742 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001743 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1744 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001745 ") is not 1.",
1746 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001747 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001748
1749 if (exclusive_scissor_struct &&
1750 (exclusive_scissor_struct->exclusiveScissorCount != 0 && exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1751 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1752 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1753 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001754 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
Jeff Bolz3e71f782018-08-29 23:15:45 -05001755 ") is not 1.",
1756 i, exclusive_scissor_struct->exclusiveScissorCount);
1757
1758 }
1759
Jeff Bolz9af91c52018-09-01 21:53:57 -05001760 if (shading_rate_image_struct &&
1761 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1762 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1763 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1764 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1765 "disabled, but pCreateInfos[%" PRIu32 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001766 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001767 i, shading_rate_image_struct->viewportCount);
1768
1769 }
1770
Petr Krausa6103552017-11-16 21:21:58 +01001771 } else { // multiViewport enabled
1772 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001773 skip |= log_msg(
1774 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001775 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001776 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001777 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1778 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001779 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001780 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1781 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001782 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1783 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001784 }
Petr Krausa6103552017-11-16 21:21:58 +01001785
1786 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001787 skip |= log_msg(
1788 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001789 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001790 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001791 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1792 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001793 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001794 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1795 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001796 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1797 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001798 }
1799 }
1800
Jeff Bolz3e71f782018-08-29 23:15:45 -05001801 if (exclusive_scissor_struct &&
1802 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
1803 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1804 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1805 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1806 "] exclusiveScissorCount (=%" PRIu32
1807 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1808 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
1809 }
1810
Jeff Bolz9af91c52018-09-01 21:53:57 -05001811 if (shading_rate_image_struct &&
1812 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
1813 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1814 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1815 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1816 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1817 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1818 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
1819 }
1820
Petr Krausa6103552017-11-16 21:21:58 +01001821 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001822 skip |=
1823 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001824 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001825 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1826 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1827 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001828 }
1829
Jeff Bolz3e71f782018-08-29 23:15:45 -05001830 if (exclusive_scissor_struct &&
1831 exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1832 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
1833 skip |=
1834 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1835 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1836 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1837 ") must be zero or identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1838 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
1839 }
1840
Jeff Bolz9af91c52018-09-01 21:53:57 -05001841 if (shading_rate_image_struct &&
1842 shading_rate_image_struct->shadingRateImageEnable &&
1843 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
1844 skip |=
1845 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1846 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1847 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32 "] "
1848 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1849 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1850 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
1851 }
1852
Petr Krausa6103552017-11-16 21:21:58 +01001853 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1854 skip |= log_msg(
1855 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001856 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001857 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1858 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001859 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1860 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001861 }
1862
1863 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1864 skip |= log_msg(
1865 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001866 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001867 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1868 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001869 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1870 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001871 }
1872
Jeff Bolz3e71f782018-08-29 23:15:45 -05001873 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
1874 exclusive_scissor_struct->exclusiveScissorCount > 0 && exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1875 skip |= log_msg(
1876 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1877 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1878 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1879 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but pCreateInfos[%" PRIu32
1880 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1881 i, i);
1882 }
1883
Jeff Bolz9af91c52018-09-01 21:53:57 -05001884 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
1885 shading_rate_image_struct->viewportCount > 0 && shading_rate_image_struct->pShadingRatePalettes == nullptr) {
1886 skip |= log_msg(
1887 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1888 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1889 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
1890 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), but pCreateInfos[%" PRIu32
1891 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
1892 i, i);
1893 }
1894
Petr Krausb3fcdb42018-01-09 22:09:09 +01001895 // validate the VkViewports
1896 if (!has_dynamic_viewport && viewport_state.pViewports) {
1897 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1898 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1899 const char fn_name[] = "vkCreateGraphicsPipelines";
1900 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1901 std::to_string(viewport_i) + "]";
1902 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1903 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1904 }
1905 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001906
1907 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1908 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001909 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001910 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001911 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001912 "VK_NV_clip_space_w_scaling extension is not enabled.",
1913 i);
1914 }
1915
1916 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1917 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001918 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001919 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001920 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001921 "VK_EXT_discard_rectangles extension is not enabled.",
1922 i);
1923 }
1924
1925 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1926 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001927 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001928 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001929 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001930 "VK_EXT_sample_locations extension is not enabled.",
1931 i);
1932 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001933
1934 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1935 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1936 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1937 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1938 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1939 "VK_NV_scissor_exclusive extension is not enabled.",
1940 i);
1941 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001942
1943 if (coarse_sample_order_struct &&
1944 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1945 coarse_sample_order_struct->customSampleOrderCount != 0) {
1946 skip |=
1947 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1948 VK_NULL_HANDLE, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1949 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] "
1950 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1951 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1952 i);
1953 }
1954
1955 if (coarse_sample_order_struct) {
1956 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
1957 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
1958 }
1959 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001960 }
1961
1962 if (pCreateInfos[i].pMultisampleState == nullptr) {
1963 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001964 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001965 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001966 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1967 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001968 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001969 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1970 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1971 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001972 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001973 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001974 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001975 skip |= validate_struct_pnext(
1976 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001977 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1978 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001979 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001980
1981 skip |= validate_reserved_flags(
1982 report_data, "vkCreateGraphicsPipelines",
1983 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001984 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001985
1986 skip |= validate_bool32(
1987 report_data, "vkCreateGraphicsPipelines",
1988 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1989 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1990
1991 skip |= validate_array(
1992 report_data, "vkCreateGraphicsPipelines",
1993 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1994 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001995 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001996 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997
1998 skip |= validate_bool32(
1999 report_data, "vkCreateGraphicsPipelines",
2000 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2001 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2002
2003 skip |= validate_bool32(
2004 report_data, "vkCreateGraphicsPipelines",
2005 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2006 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2007
2008 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2009 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002010 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002011 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2012 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2013 i);
2014 }
John Zulauf7acac592017-11-06 11:15:53 -07002015 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2016 if (!device_data->physical_device_features.sampleRateShading) {
2017 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002018 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002019 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002020 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2021 i);
John Zulauf7acac592017-11-06 11:15:53 -07002022 }
2023 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2024 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2025 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2026 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002027 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002028 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002029 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002030 }
2031 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002032 }
2033
Petr Krause91f7a12017-12-14 20:57:36 +01002034 bool uses_color_attachment = false;
2035 bool uses_depthstencil_attachment = false;
2036 {
2037 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2038 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2039 const auto &subpasses_uses = subpasses_uses_it->second;
2040 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2041 uses_color_attachment = true;
2042 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2043 uses_depthstencil_attachment = true;
2044 }
2045 }
2046
2047 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002048 skip |= validate_struct_pnext(
2049 report_data, "vkCreateGraphicsPipelines",
2050 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002051 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2052 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002053
2054 skip |= validate_reserved_flags(
2055 report_data, "vkCreateGraphicsPipelines",
2056 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002057 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002058
2059 skip |= validate_bool32(
2060 report_data, "vkCreateGraphicsPipelines",
2061 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2062 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2063
2064 skip |= validate_bool32(
2065 report_data, "vkCreateGraphicsPipelines",
2066 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2067 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2068
2069 skip |= validate_ranged_enum(
2070 report_data, "vkCreateGraphicsPipelines",
2071 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2072 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002073 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002074
2075 skip |= validate_bool32(
2076 report_data, "vkCreateGraphicsPipelines",
2077 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2078 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2079
2080 skip |= validate_bool32(
2081 report_data, "vkCreateGraphicsPipelines",
2082 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2083 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2084
2085 skip |= validate_ranged_enum(
2086 report_data, "vkCreateGraphicsPipelines",
2087 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2088 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002089 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002090
2091 skip |= validate_ranged_enum(
2092 report_data, "vkCreateGraphicsPipelines",
2093 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2094 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002095 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002096
2097 skip |= validate_ranged_enum(
2098 report_data, "vkCreateGraphicsPipelines",
2099 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2100 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002101 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002102
2103 skip |= validate_ranged_enum(
2104 report_data, "vkCreateGraphicsPipelines",
2105 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2106 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002107 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002108
2109 skip |= validate_ranged_enum(
2110 report_data, "vkCreateGraphicsPipelines",
2111 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2112 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002113 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002114
2115 skip |= validate_ranged_enum(
2116 report_data, "vkCreateGraphicsPipelines",
2117 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2118 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002119 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120
2121 skip |= validate_ranged_enum(
2122 report_data, "vkCreateGraphicsPipelines",
2123 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2124 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002125 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002126
2127 skip |= validate_ranged_enum(
2128 report_data, "vkCreateGraphicsPipelines",
2129 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2130 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002131 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002132
2133 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2134 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002135 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002136 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2137 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2138 i);
2139 }
2140 }
2141
Petr Krause91f7a12017-12-14 20:57:36 +01002142 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002143 skip |= validate_struct_pnext(
2144 report_data, "vkCreateGraphicsPipelines",
2145 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002146 pCreateInfos[i].pColorBlendState->pNext, 0, NULL, GeneratedHeaderVersion,
2147 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002148
2149 skip |= validate_reserved_flags(
2150 report_data, "vkCreateGraphicsPipelines",
2151 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002152 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002153
2154 skip |= validate_bool32(
2155 report_data, "vkCreateGraphicsPipelines",
2156 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2157 pCreateInfos[i].pColorBlendState->logicOpEnable);
2158
2159 skip |= validate_array(
2160 report_data, "vkCreateGraphicsPipelines",
2161 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2162 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002163 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002164 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002165
2166 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2167 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2168 ++attachmentIndex) {
2169 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2170 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2171 ParameterName::IndexVector{i, attachmentIndex}),
2172 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2173
2174 skip |= validate_ranged_enum(
2175 report_data, "vkCreateGraphicsPipelines",
2176 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2177 ParameterName::IndexVector{i, attachmentIndex}),
2178 "VkBlendFactor", AllVkBlendFactorEnums,
2179 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002180 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002181
2182 skip |= validate_ranged_enum(
2183 report_data, "vkCreateGraphicsPipelines",
2184 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2185 ParameterName::IndexVector{i, attachmentIndex}),
2186 "VkBlendFactor", AllVkBlendFactorEnums,
2187 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002188 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002189
2190 skip |= validate_ranged_enum(
2191 report_data, "vkCreateGraphicsPipelines",
2192 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2193 ParameterName::IndexVector{i, attachmentIndex}),
2194 "VkBlendOp", AllVkBlendOpEnums,
2195 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002196 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002197
2198 skip |= validate_ranged_enum(
2199 report_data, "vkCreateGraphicsPipelines",
2200 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2201 ParameterName::IndexVector{i, attachmentIndex}),
2202 "VkBlendFactor", AllVkBlendFactorEnums,
2203 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002204 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002205
2206 skip |= validate_ranged_enum(
2207 report_data, "vkCreateGraphicsPipelines",
2208 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2209 ParameterName::IndexVector{i, attachmentIndex}),
2210 "VkBlendFactor", AllVkBlendFactorEnums,
2211 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002212 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002213
2214 skip |= validate_ranged_enum(
2215 report_data, "vkCreateGraphicsPipelines",
2216 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2217 ParameterName::IndexVector{i, attachmentIndex}),
2218 "VkBlendOp", AllVkBlendOpEnums,
2219 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002220 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002221
2222 skip |=
2223 validate_flags(report_data, "vkCreateGraphicsPipelines",
2224 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2225 ParameterName::IndexVector{i, attachmentIndex}),
2226 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2227 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002228 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002229 }
2230 }
2231
2232 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2233 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002234 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002235 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2236 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2237 i);
2238 }
2239
2240 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2241 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2242 skip |= validate_ranged_enum(
2243 report_data, "vkCreateGraphicsPipelines",
2244 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002245 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2246 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002247 }
2248 }
2249 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002250
Petr Kraus9752aae2017-11-24 03:05:50 +01002251 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2252 if (pCreateInfos[i].basePipelineIndex != -1) {
2253 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002254 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002255 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002256 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2257 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002258 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002259 }
2260 }
2261
Petr Kraus9752aae2017-11-24 03:05:50 +01002262 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2263 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002264 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002265 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002266 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2267 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002268 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002269 }
2270 }
2271 }
2272
Petr Kraus9752aae2017-11-24 03:05:50 +01002273 if (pCreateInfos[i].pRasterizationState) {
2274 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002275 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002276 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002277 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002278 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2279 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2280 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002281 }
Petr Kraus299ba622017-11-24 03:09:03 +01002282
2283 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2284 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002285 skip |=
2286 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2287 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2288 "The line width state is static (pCreateInfos[%" PRIu32
2289 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2290 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2291 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2292 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002293 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002294 }
2295
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002296 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2297 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2298 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002299 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002300 }
2301 }
2302 }
2303
2304 return skip;
2305}
2306
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002307bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2308 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2309 VkPipeline *pPipelines) {
2310 bool skip = false;
2311 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2312
2313 for (uint32_t i = 0; i < createInfoCount; i++) {
2314 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2315 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002316 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002317 }
2318
2319 return skip;
2320}
2321
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002322bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2323 VkSampler *pSampler) {
2324 bool skip = false;
2325 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2326 debug_report_data *report_data = device_data->report_data;
2327
2328 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002329 const auto &features = device_data->physical_device_features;
2330 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002331
John Zulauf71968502017-10-26 13:51:15 -06002332 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2333 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002334 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002335 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002336 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002337 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002338 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002339 }
2340
2341 // Anistropy cannot be enabled in sampler unless enabled as a feature
2342 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002343 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002344 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002345 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2346 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002347 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002348 }
John Zulauf71968502017-10-26 13:51:15 -06002349
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002350 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2351 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2352 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2353 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2354 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2355 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2356 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2357 }
2358 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2359 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2360 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2361 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2362 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2363 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2364 }
2365 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2366 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2367 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2368 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2369 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2370 pCreateInfo->minLod, pCreateInfo->maxLod);
2371 }
2372 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2373 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2374 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2375 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2376 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2377 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2378 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2379 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2380 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2381 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2382 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2383 }
2384 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002385 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002386 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002387 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002388 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002389 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002390 if (pCreateInfo->compareEnable == VK_TRUE) {
2391 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2392 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2393 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2394 "not both be VK_TRUE.");
2395 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002396 }
2397
2398 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2399 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002400 skip |=
2401 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2402 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002403 }
2404
2405 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2406 // valid VkBorderColor value
2407 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2408 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2409 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2410 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002411 AllVkBorderColorEnums, pCreateInfo->borderColor,
2412 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002413 }
2414
2415 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2416 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2417 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2418 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2419 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2420 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002421 skip |=
2422 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2423 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2424 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2425 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426 }
John Zulauf275805c2017-10-26 15:34:49 -06002427
2428 // Checks for the IMG cubic filtering extension
2429 if (device_data->extensions.vk_img_filter_cubic) {
2430 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2431 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002432 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002433 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002434 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002435 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002436 }
2437 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002438 }
2439
2440 return skip;
2441}
2442
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002443bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2444 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2445 bool skip = false;
2446 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2447 debug_report_data *report_data = device_data->report_data;
2448
2449 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2450 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2451 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2452 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2453 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2454 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2455 // valid VkSampler handles
2456 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2457 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2458 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2459 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2460 ++descriptor_index) {
2461 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2462 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002463 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002464 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002465 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002466 i, descriptor_index);
2467 }
2468 }
2469 }
2470
2471 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2472 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2473 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002474 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002475 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002476 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2477 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002478 "values.",
2479 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002480 }
2481 }
2482 }
2483 }
2484
2485 return skip;
2486}
2487
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002488bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2489 const VkDescriptorSet *pDescriptorSets) {
2490 bool skip = false;
2491 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2492 debug_report_data *report_data = device_data->report_data;
2493
2494 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2495 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2496 // validate_array()
2497 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002498 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002499 return skip;
2500}
2501
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002502bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2503 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2504 bool skip = false;
2505 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2506 debug_report_data *report_data = device_data->report_data;
2507
2508 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2509 if (pDescriptorWrites != NULL) {
2510 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2511 // descriptorCount must be greater than 0
2512 if (pDescriptorWrites[i].descriptorCount == 0) {
2513 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002514 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002515 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002516 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002517 }
2518
2519 // dstSet must be a valid VkDescriptorSet handle
2520 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2521 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2522 pDescriptorWrites[i].dstSet);
2523
2524 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2525 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2526 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2527 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2528 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2529 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2530 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2531 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2532 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2533 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002534 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002535 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2536 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2537 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002538 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2539 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002540 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2541 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2542 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2543 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2544 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2545 ++descriptor_index) {
2546 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2547 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2548 ParameterName::IndexVector{i, descriptor_index}),
2549 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2550 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2551 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2552 ParameterName::IndexVector{i, descriptor_index}),
2553 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002554 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555 }
2556 }
2557 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2558 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2559 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2560 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2561 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2562 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2563 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2564 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2565 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002566 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002567 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2568 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2569 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002570 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2571 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002572 } else {
2573 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2574 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2575 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2576 ParameterName::IndexVector{i, descriptorIndex}),
2577 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2578 }
2579 }
2580 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2581 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2582 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2583 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2584 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2585 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002586 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002587 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2588 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002589 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2590 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002591 } else {
2592 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2593 ++descriptor_index) {
2594 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2595 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2596 ParameterName::IndexVector{i, descriptor_index}),
2597 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2598 }
2599 }
2600 }
2601
2602 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2603 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2604 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2605 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2606 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2607 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002608 skip |=
2609 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002610 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2611 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002612 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2613 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2614 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002615 }
2616 }
2617 }
2618 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2619 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2620 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2621 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2622 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2623 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002624 skip |=
2625 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002626 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2627 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002628 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2629 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2630 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002631 }
2632 }
2633 }
2634 }
2635 }
2636 }
2637 return skip;
2638}
2639
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002640bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2641 VkRenderPass *pRenderPass) {
2642 bool skip = false;
2643 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2644 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
2645
2646 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2647 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2648 std::stringstream ss;
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002649 ss << "vkCreateRenderPass: pCreateInfo->pAttachments[" << i << "].format is VK_FORMAT_UNDEFINED. ";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002650 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002651 "VUID-VkAttachmentDescription-format-parameter", "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002652 }
2653 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2654 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
2655 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002656 "VUID-VkAttachmentDescription-finalLayout-00843",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002657 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002658 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2659 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002660 }
2661 }
2662
2663 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2664 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
2665 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002666 "VUID-VkSubpassDescription-colorAttachmentCount-00845",
2667 "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002668 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002669 }
2670 }
2671 return skip;
2672}
2673
2674bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2675 const VkCommandBuffer *pCommandBuffers) {
2676 bool skip = false;
2677 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2678 debug_report_data *report_data = device_data->report_data;
2679
2680 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2681 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2682 // validate_array()
2683 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002684 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002685 return skip;
2686}
2687
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002688bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2689 bool skip = false;
2690 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2691 debug_report_data *report_data = device_data->report_data;
2692 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2693
2694 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2695 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2696 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2697 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002698 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2699 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002700
2701 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002702 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2703 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2704 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002705
2706 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2707 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2708
2709 // TODO: This only needs to be validated when the inherited queries feature is enabled
2710 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2711 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2712
2713 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2714 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2715 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002716 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002717 }
2718
2719 if (pInfo != NULL) {
2720 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2721 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002722 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002723 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002724 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002725 }
2726 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2727 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2728 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002729 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002730 }
2731 }
2732
2733 return skip;
2734}
2735
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002736bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2737 const VkViewport *pViewports) {
2738 bool skip = false;
2739 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2740
Petr Krausd55e77c2018-01-09 22:09:25 +01002741 if (!device_data->physical_device_features.multiViewport) {
2742 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002743 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002744 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002745 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2746 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002747 }
2748 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002749 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002750 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002751 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2752 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002753 }
2754 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002755 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002756 if (sum > device_data->device_limits.maxViewports) {
2757 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002758 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002759 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002760 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2761 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002762 }
2763 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002764
2765 if (pViewports) {
2766 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2767 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2768 const char fn_name[] = "vkCmdSetViewport";
2769 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2770 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2771 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2772 }
2773 }
2774
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002775 return skip;
2776}
2777
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2779 bool skip = false;
2780 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2781 debug_report_data *report_data = device_data->report_data;
2782
Petr Kraus6260f0a2018-02-27 21:15:55 +01002783 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002784 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002785 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002786 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002787 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2788 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002789 }
2790 if (scissorCount > 1) {
2791 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002792 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002793 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2794 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002795 }
2796 } else { // multiViewport enabled
2797 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2798 if (sum > device_data->device_limits.maxViewports) {
2799 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002800 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002801 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002802 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2803 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002804 }
2805 }
2806
Petr Kraus6260f0a2018-02-27 21:15:55 +01002807 if (pScissors) {
2808 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2809 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002810
Petr Kraus6260f0a2018-02-27 21:15:55 +01002811 if (scissor.offset.x < 0) {
2812 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002813 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002814 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2815 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002816 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002817
Petr Kraus6260f0a2018-02-27 21:15:55 +01002818 if (scissor.offset.y < 0) {
2819 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002820 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002821 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2822 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002823 }
2824
2825 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2826 if (x_sum > INT32_MAX) {
2827 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002828 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002829 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002830 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2831 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002832 }
2833
2834 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2835 if (y_sum > INT32_MAX) {
2836 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002837 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002838 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002839 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2840 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002841 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002842 }
2843 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002844
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002845 return skip;
2846}
2847
Petr Kraus299ba622017-11-24 03:09:03 +01002848bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2849 bool skip = false;
2850 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2851 debug_report_data *report_data = device_data->report_data;
2852
2853 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2854 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002855 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002856 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002857 }
2858
2859 return skip;
2860}
2861
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002862bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2863 uint32_t firstInstance) {
2864 bool skip = false;
2865 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2866 if (vertexCount == 0) {
2867 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2868 // this an error or leave as is.
2869 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002870 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002871 }
2872
2873 if (instanceCount == 0) {
2874 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2875 // this an error or leave as is.
2876 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002877 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002878 }
2879 return skip;
2880}
2881
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002882bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2883 bool skip = false;
2884 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2885
2886 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2887 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002888 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002889 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2890 }
2891 return skip;
2892}
2893
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002894bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2895 uint32_t stride) {
2896 bool skip = false;
2897 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2898 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002899 skip |=
2900 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2901 kVUID_PVError_DeviceFeature,
2902 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002903 }
2904 return skip;
2905}
2906
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002907bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2908 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2909 bool skip = false;
2910 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2911
Dave Houltonf5217612018-02-02 16:18:52 -07002912 VkImageAspectFlags legal_aspect_flags =
2913 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2914 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2915 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2916 }
2917
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002918 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002919 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002921 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002922 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002923 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002924 }
Dave Houltonf5217612018-02-02 16:18:52 -07002925 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002926 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002927 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002928 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002929 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002930 }
2931 }
2932 return skip;
2933}
2934
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002935bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2936 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2937 bool skip = false;
2938 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2939
Dave Houltonf5217612018-02-02 16:18:52 -07002940 VkImageAspectFlags legal_aspect_flags =
2941 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2942 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2943 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2944 }
2945
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002946 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002947 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002948 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002949 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002950 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002951 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2952 }
Dave Houltonf5217612018-02-02 16:18:52 -07002953 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002954 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002955 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002956 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002957 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2958 }
2959 }
2960 return skip;
2961}
2962
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002963bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
2964 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2965 bool skip = false;
2966 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2967
Dave Houltonf5217612018-02-02 16:18:52 -07002968 VkImageAspectFlags legal_aspect_flags =
2969 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2970 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2971 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2972 }
2973
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002974 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002975 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002976 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002977 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002978 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2979 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002980 }
2981 }
2982 return skip;
2983}
2984
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002985bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
2986 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
2987 bool skip = false;
2988 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2989
Dave Houltonf5217612018-02-02 16:18:52 -07002990 VkImageAspectFlags legal_aspect_flags =
2991 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2992 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2993 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2994 }
2995
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002996 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002997 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002998 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002999 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003000 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3001 "enumerator");
3002 }
3003 }
3004 return skip;
3005}
3006
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003007bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3008 const void *pData) {
3009 bool skip = false;
3010 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3011
3012 if (dstOffset & 3) {
3013 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003014 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003015 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3016 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003017 }
3018
3019 if ((dataSize <= 0) || (dataSize > 65536)) {
3020 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003021 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003023 "), must be greater than zero and less than or equal to 65536.",
3024 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003025 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003026 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003027 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003028 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003029 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003030 }
3031 return skip;
3032}
3033
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003034bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3035 uint32_t data) {
3036 bool skip = false;
3037 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3038
3039 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003040 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003041 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003042 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003043 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003044 }
3045
3046 if (size != VK_WHOLE_SIZE) {
3047 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003048 skip |=
3049 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003050 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003051 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003052 } else if (size & 3) {
3053 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003054 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003055 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003056 }
3057 }
3058 return skip;
3059}
3060
3061VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3062 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3063}
3064
3065VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3066 VkLayerProperties *pProperties) {
3067 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3068}
3069
3070VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3071 VkExtensionProperties *pProperties) {
3072 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3073 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3074
3075 return VK_ERROR_LAYER_NOT_PRESENT;
3076}
3077
3078VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3079 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3080 // Parameter_validation does not have any physical device extensions
3081 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3082 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3083
3084 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003085 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3086 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3087 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003088 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3089
3090 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3091}
3092
3093static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3094 if (!flag) {
3095 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003096 kVUID_PVError_ExtensionNotEnabled,
3097 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3098 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003099 }
3100
3101 return false;
3102}
3103
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003104bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3105 VkSwapchainKHR *pSwapchain) {
3106 bool skip = false;
3107 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3108 debug_report_data *report_data = device_data->report_data;
3109
Mark Lobodzinski88529492018-04-01 10:38:15 -06003110 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003111 "vkCreateSwapchainKHR"};
3112
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003113 if (pCreateInfo != nullptr) {
3114 if ((device_data->physical_device_features.textureCompressionETC2 == false) &&
3115 FormatIsCompressed_ETC2_EAC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003116 skip |= log_msg(
3117 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_PVError_DeviceFeature,
3118 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The textureCompressionETC2 "
3119 "feature is not enabled: neither ETC2 nor EAC formats can be used to create images.",
3120 string_VkFormat(pCreateInfo->imageFormat));
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003121 }
3122
3123 if ((device_data->physical_device_features.textureCompressionASTC_LDR == false) &&
3124 FormatIsCompressed_ASTC_LDR(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003125 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3126 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003127 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3128 "textureCompressionASTC_LDR feature is not enabled: ASTC formats cannot be used to create images.",
3129 string_VkFormat(pCreateInfo->imageFormat));
3130 }
3131
3132 if ((device_data->physical_device_features.textureCompressionBC == false) &&
3133 FormatIsCompressed_BC(pCreateInfo->imageFormat)) {
Dave Houlton413a6782018-05-22 13:01:54 -06003134 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
3135 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003136 "vkCreateSwapchainKHR(): Attempting to create swapchain VkImage with format %s. The "
3137 "textureCompressionBC feature is not enabled: BC compressed formats cannot be used to create images.",
3138 string_VkFormat(pCreateInfo->imageFormat));
3139 }
3140
3141 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3142 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3143 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3144 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003145 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003146 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003147 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003148 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003149 }
3150
3151 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3152 // queueFamilyIndexCount uint32_t values
3153 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003154 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003155 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003156 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3157 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003158 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003159 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003160 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003161 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3162 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003163 }
3164 }
3165
Dave Houlton413a6782018-05-22 13:01:54 -06003166 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3167 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003168 }
3169
3170 return skip;
3171}
3172
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003173bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3174 bool skip = false;
3175 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3176
3177 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003178 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3179 if (present_regions) {
3180 // TODO: This and all other pNext extension dependencies should be added to code-generation
3181 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3182 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3183 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3184 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003185 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003186 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3187 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003188 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3189 }
Dave Houlton413a6782018-05-22 13:01:54 -06003190 skip |=
3191 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3192 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003193 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003194 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003195 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003196 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3197 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003198 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003199 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003200 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003201 }
3202 }
3203
3204 return skip;
3205}
3206
3207#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003208bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3209 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3210 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3211 bool skip = false;
3212
3213 if (pCreateInfo->hwnd == nullptr) {
3214 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003215 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3216 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003217 }
3218
3219 return skip;
3220}
3221#endif // VK_USE_PLATFORM_WIN32_KHR
3222
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003223bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3224 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3225 if (pNameInfo->pObjectName) {
3226 device_data->report_data->debugObjectNameMap->insert(
3227 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3228 } else {
3229 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3230 }
3231 return false;
3232}
3233
Petr Krausc8655be2017-09-27 18:56:51 +02003234bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3235 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3236 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3237 bool skip = false;
3238
3239 if (pCreateInfo) {
3240 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003241 skip |=
3242 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3243 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3244 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003245 }
3246
3247 if (pCreateInfo->pPoolSizes) {
3248 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3249 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3250 skip |= log_msg(
3251 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003252 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003253 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003254 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003255 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3256 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
3257 skip |= log_msg(
3258 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3259 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-type-02218",
3260 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3261 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.", i, i);
3262 }
Petr Krausc8655be2017-09-27 18:56:51 +02003263 }
3264 }
3265 }
3266
3267 return skip;
3268}
3269
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003270bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3271 bool skip = false;
3272 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3273
3274 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003275 skip |=
3276 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003277 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003278 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3279 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003280 }
3281
3282 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003283 skip |=
3284 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003285 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003286 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3287 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003288 }
3289
3290 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003291 skip |=
3292 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003293 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003294 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3295 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003296 }
3297
3298 return skip;
3299}
3300
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003301bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003302 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3303 bool skip = false;
3304 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3305
3306 // Paired if {} else if {} tests used to avoid any possible uint underflow
3307 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3308 if (baseGroupX >= limit) {
3309 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003310 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003311 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003312 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3313 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003314 } else if (groupCountX > (limit - baseGroupX)) {
3315 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003316 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003317 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003318 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3319 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003320 }
3321
3322 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3323 if (baseGroupY >= limit) {
3324 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003325 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003326 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003327 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3328 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003329 } else if (groupCountY > (limit - baseGroupY)) {
3330 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003331 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003332 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003333 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3334 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003335 }
3336
3337 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3338 if (baseGroupZ >= limit) {
3339 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003340 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003341 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003342 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3343 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003344 } else if (groupCountZ > (limit - baseGroupZ)) {
3345 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003346 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003347 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003348 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3349 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003350 }
3351
3352 return skip;
3353}
3354
Jeff Bolz3e71f782018-08-29 23:15:45 -05003355bool pv_vkCmdSetExclusiveScissorNV(
3356 VkCommandBuffer commandBuffer,
3357 uint32_t firstExclusiveScissor,
3358 uint32_t exclusiveScissorCount,
3359 const VkRect2D* pExclusiveScissors)
3360{
3361 bool skip = false;
3362
3363 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3364 debug_report_data *report_data = device_data->report_data;
3365
3366 if (!device_data->physical_device_features.multiViewport) {
3367 if (firstExclusiveScissor != 0) {
3368 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3369 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3370 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32 ") is not 0.",
3371 firstExclusiveScissor);
3372 }
3373 if (exclusiveScissorCount > 1) {
3374 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3375 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3376 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32 ") is not 1.",
3377 exclusiveScissorCount);
3378 }
3379 } else { // multiViewport enabled
3380 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3381 if (sum > device_data->device_limits.maxViewports) {
3382 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3383 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3384 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3385 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3386 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3387 }
3388 }
3389
3390 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3391 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3392 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3393 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3394 firstExclusiveScissor, device_data->device_limits.maxViewports);
3395 }
3396
3397 if (pExclusiveScissors) {
3398 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3399 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3400
3401 if (scissor.offset.x < 0) {
3402 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3403 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3404 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
3405 scissor.offset.x);
3406 }
3407
3408 if (scissor.offset.y < 0) {
3409 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3410 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3411 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
3412 scissor.offset.y);
3413 }
3414
3415 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3416 if (x_sum > INT32_MAX) {
3417 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3418 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3419 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3420 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3421 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3422 }
3423
3424 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3425 if (y_sum > INT32_MAX) {
3426 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3427 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3428 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3429 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3430 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3431 }
3432 }
3433 }
3434
3435 return skip;
3436}
3437
Jeff Bolz9af91c52018-09-01 21:53:57 -05003438bool pv_vkCmdSetViewportShadingRatePaletteNV(
3439 VkCommandBuffer commandBuffer,
3440 uint32_t firstViewport,
3441 uint32_t viewportCount,
3442 const VkShadingRatePaletteNV* pShadingRatePalettes)
3443{
3444 bool skip = false;
3445
3446 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3447 debug_report_data *report_data = device_data->report_data;
3448
3449 if (!device_data->physical_device_features.multiViewport) {
3450 if (firstViewport != 0) {
3451 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3452 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3453 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
3454 firstViewport);
3455 }
3456 if (viewportCount > 1) {
3457 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3458 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3459 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
3460 viewportCount);
3461 }
3462 }
3463
3464 if (firstViewport >= device_data->device_limits.maxViewports) {
3465 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3466 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3467 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3468 firstViewport, device_data->device_limits.maxViewports);
3469 }
3470
3471 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3472 if (sum > device_data->device_limits.maxViewports) {
3473 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3474 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3475 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3476 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3477 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3478 }
3479
3480 return skip;
3481}
3482
3483
3484bool pv_vkCmdSetCoarseSampleOrderNV(
3485 VkCommandBuffer commandBuffer,
3486 VkCoarseSampleOrderTypeNV sampleOrderType,
3487 uint32_t customSampleOrderCount,
3488 const VkCoarseSampleOrderCustomNV* pCustomSampleOrders)
3489{
3490 bool skip = false;
3491
3492 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3493 debug_report_data *report_data = device_data->report_data;
3494
3495 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
3496 customSampleOrderCount != 0) {
3497 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3498 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3499 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3500 "customSampleOrderCount must be 0.");
3501 }
3502
3503 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3504 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3505 }
3506
3507 return skip;
3508}
3509
3510
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003511VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003512 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3513 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3514 return nullptr;
3515 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003516 const auto item = name_to_funcptr_map.find(funcName);
3517 if (item != name_to_funcptr_map.end()) {
3518 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3519 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003520 const auto &table = device_data->dispatch_table;
3521 if (!table.GetDeviceProcAddr) return nullptr;
3522 return table.GetDeviceProcAddr(device, funcName);
3523}
3524
3525VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3526 const auto item = name_to_funcptr_map.find(funcName);
3527 if (item != name_to_funcptr_map.end()) {
3528 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3529 }
3530
3531 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3532 auto &table = instance_data->dispatch_table;
3533 if (!table.GetInstanceProcAddr) return nullptr;
3534 return table.GetInstanceProcAddr(instance, funcName);
3535}
3536
3537VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3538 assert(instance);
3539 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3540
3541 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3542 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3543}
3544
3545// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3546// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003547void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003548 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3549 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3550 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3551 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3552 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3553 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3554 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3555 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3556 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3557 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3558 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
3559 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3560 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3561 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003562 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003563 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3564 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3565 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3566 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3567 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3568 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3569 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3570 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3571 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3572 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3573 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3574 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3575 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003576 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003577 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003578 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3579 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003580}
3581
3582} // namespace parameter_validation
3583
3584VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3585 VkExtensionProperties *pProperties) {
3586 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3587}
3588
3589VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3590 VkLayerProperties *pProperties) {
3591 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3592}
3593
3594VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3595 VkLayerProperties *pProperties) {
3596 // the layer command handles VK_NULL_HANDLE just fine internally
3597 assert(physicalDevice == VK_NULL_HANDLE);
3598 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3599}
3600
3601VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3602 const char *pLayerName, uint32_t *pCount,
3603 VkExtensionProperties *pProperties) {
3604 // the layer command handles VK_NULL_HANDLE just fine internally
3605 assert(physicalDevice == VK_NULL_HANDLE);
3606 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3607}
3608
3609VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3610 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3611}
3612
3613VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3614 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3615}
3616
3617VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3618 const char *funcName) {
3619 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3620}
3621
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003622VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3623vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003624 assert(pVersionStruct != NULL);
3625 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3626
3627 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3628 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3629 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3630 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3631 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3632 }
3633
3634 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3635 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3636 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3637 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3638 }
3639
3640 return VK_SUCCESS;
3641}