blob: dbd852638af954824207b1a3ef99134e78c1ea8b [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Vadim Bendebury2b62d742014-06-22 13:14:51 -070054PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070055
Mike Frysingered9b2a02019-12-12 18:52:32 -050056
57# Link to commit message documentation for users.
58DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
59 '/contributing.md#commit-messages')
60
61
Ryan Cuiec4d6332011-05-02 14:15:25 -070062COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050063 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040064 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
65 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050066 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040067 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050068 # No extension at all, note that ALL CAPS files are black listed in
69 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040070 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
73 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
74 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070075]
76
Ryan Cui1562fb82011-05-09 11:01:31 -070077
Ryan Cuiec4d6332011-05-02 14:15:25 -070078COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070079 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040080 r'.*/Manifest$',
81 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070082
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'(^|.*/)overlay-.*/profiles/.*',
85 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040086
C Shapiro8f90e9b2017-06-28 09:54:50 -060087 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
89 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060090
Daniel Erate3ea3fc2015-02-13 15:27:52 -070091 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'.*\.min\.js',
93 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050094
95 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -070097
Mike Frysinger13650402019-07-31 14:31:46 -040098 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040099 r'.*_pb2\.py$',
100 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700101]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700102
Ken Turnerd07564b2018-02-08 17:57:59 +1100103LICENSE_EXCLUDED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'^(.*/)?OWNERS$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100105]
Ryan Cui1562fb82011-05-09 11:01:31 -0700106
Ryan Cui9b651632011-05-11 11:38:58 -0700107_CONFIG_FILE = 'PRESUBMIT.cfg'
108
109
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700110# File containing wildcards, one per line, matching files that should be
111# excluded from presubmit checks. Lines beginning with '#' are ignored.
112_IGNORE_FILE = '.presubmitignore'
113
Cheng Yuehb707c522020-01-02 14:06:59 +0800114
115TEST_FIELD_RE = r'\nTEST=\S+'
116
Doug Anderson44a644f2011-11-02 10:37:37 -0700117# Exceptions
118
119
120class BadInvocation(Exception):
121 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700122
123
Ryan Cui1562fb82011-05-09 11:01:31 -0700124# General Helpers
125
Sean Paulba01d402011-05-05 11:36:23 -0400126
Mike Frysingerb2496652019-09-12 23:35:46 -0400127class Cache(object):
128 """General helper for caching git content."""
129
130 def __init__(self):
131 self._cache = {}
132
133 def get_subcache(self, scope):
134 return self._cache.setdefault(scope, {})
135
136 def clear(self):
137 self._cache.clear()
138
139CACHE = Cache()
140
141
Alex Deymo643ac4c2015-09-03 10:40:50 -0700142Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
143
144
Mike Frysinger526a5f82019-09-13 18:05:30 -0400145def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700146 """Executes the passed in command and returns raw stdout output.
147
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400148 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 Args:
151 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700153
154 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700155 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700156 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400157 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400158 kwargs.setdefault('stdout', True)
159 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500160 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400161 # NB: We decode this directly rather than through kwargs as our tests rely
162 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400163 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700164
Ryan Cui1562fb82011-05-09 11:01:31 -0700165
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700166def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700167 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700168 if __name__ == '__main__':
169 # Works when file is run on its own (__file__ is defined)...
170 return os.path.abspath(os.path.dirname(__file__))
171 else:
172 # We need to do this when we're run through repo. Since repo executes
173 # us with execfile(), we don't get __file__ defined.
174 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
175 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700176
Ryan Cui1562fb82011-05-09 11:01:31 -0700177
Ryan Cuiec4d6332011-05-02 14:15:25 -0700178def _match_regex_list(subject, expressions):
179 """Try to match a list of regular expressions to a string.
180
181 Args:
182 subject: The string to match regexes on
183 expressions: A list of regular expressions to check for matches with.
184
185 Returns:
186 Whether the passed in subject matches any of the passed in regexes.
187 """
188 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500189 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700190 return True
191 return False
192
Ryan Cui1562fb82011-05-09 11:01:31 -0700193
Mike Frysingerae409522014-02-01 03:16:11 -0500194def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700195 """Filter out files based on the conditions passed in.
196
197 Args:
198 files: list of filepaths to filter
199 include_list: list of regex that when matched with a file path will cause it
200 to be added to the output list unless the file is also matched with a
201 regex in the exclude_list.
202 exclude_list: list of regex that when matched with a file will prevent it
203 from being added to the output list, even if it is also matched with a
204 regex in the include_list.
205
206 Returns:
207 A list of filepaths that contain files matched in the include_list and not
208 in the exclude_list.
209 """
210 filtered = []
211 for f in files:
212 if (_match_regex_list(f, include_list) and
213 not _match_regex_list(f, exclude_list)):
214 filtered.append(f)
215 return filtered
216
Ryan Cuiec4d6332011-05-02 14:15:25 -0700217
218# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700219
220
Ryan Cui4725d952011-05-05 15:41:19 -0700221def _get_upstream_branch():
222 """Returns the upstream tracking branch of the current branch.
223
224 Raises:
225 Error if there is no tracking branch
226 """
227 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
228 current_branch = current_branch.replace('refs/heads/', '')
229 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700230 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700231
232 cfg_option = 'branch.' + current_branch + '.%s'
233 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
234 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
235 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700236 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700237
238 return full_upstream.replace('heads', 'remotes/' + remote)
239
Ryan Cui1562fb82011-05-09 11:01:31 -0700240
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700241def _get_patch(commit):
242 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700243 if commit == PRE_SUBMIT:
244 return _run_command(['git', 'diff', '--cached', 'HEAD'])
245 else:
246 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700247
Ryan Cui1562fb82011-05-09 11:01:31 -0700248
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500249def _get_file_content(path, commit):
250 """Returns the content of a file at a specific commit.
251
252 We can't rely on the file as it exists in the filesystem as people might be
253 uploading a series of changes which modifies the file multiple times.
254
255 Note: The "content" of a symlink is just the target. So if you're expecting
256 a full file, you should check that first. One way to detect is that the
257 content will not have any newlines.
258 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400259 # Make sure people don't accidentally pass in full paths which will never
260 # work. You need to use relative=True with _get_affected_files.
261 if path.startswith('/'):
262 raise ValueError('_get_file_content must be called with relative paths: %s'
263 % (path,))
264
265 # {<commit>: {<path1>: <content>, <path2>: <content>}}
266 cache = CACHE.get_subcache('get_file_content')
267 if path in cache:
268 return cache[path]
269
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700270 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400271 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700272 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400273 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
274 cache[path] = content
275 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500276
277
Mike Frysingerae409522014-02-01 03:16:11 -0500278def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700279 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400280 # {<commit>: {<path1>: <content>, <path2>: <content>}}
281 cache = CACHE.get_subcache('get_file_diff')
282 if path in cache:
283 return cache[path]
284
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700285 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800286 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
287 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700288 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800289 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
290 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700291 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700292
293 new_lines = []
294 line_num = 0
295 for line in output.splitlines():
296 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
297 if m:
298 line_num = int(m.groups(1)[0])
299 continue
300 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400301 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302 if not line.startswith('-'):
303 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400304 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700305 return new_lines
306
Ryan Cui1562fb82011-05-09 11:01:31 -0700307
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700308def _get_ignore_wildcards(directory, cache):
309 """Get wildcards listed in a directory's _IGNORE_FILE.
310
311 Args:
312 directory: A string containing a directory path.
313 cache: A dictionary (opaque to caller) caching previously-read wildcards.
314
315 Returns:
316 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
317 wasn't present.
318 """
319 # In the cache, keys are directories and values are lists of wildcards from
320 # _IGNORE_FILE within those directories (and empty if no file was present).
321 if directory not in cache:
322 wildcards = []
323 dotfile_path = os.path.join(directory, _IGNORE_FILE)
324 if os.path.exists(dotfile_path):
325 # TODO(derat): Consider using _get_file_content() to get the file as of
326 # this commit instead of the on-disk version. This may have a noticeable
327 # performance impact, as each call to _get_file_content() runs git.
328 with open(dotfile_path, 'r') as dotfile:
329 for line in dotfile.readlines():
330 line = line.strip()
331 if line.startswith('#'):
332 continue
333 if line.endswith('/'):
334 line += '*'
335 wildcards.append(line)
336 cache[directory] = wildcards
337
338 return cache[directory]
339
340
341def _path_is_ignored(path, cache):
342 """Check whether a path is ignored by _IGNORE_FILE.
343
344 Args:
345 path: A string containing a path.
346 cache: A dictionary (opaque to caller) caching previously-read wildcards.
347
348 Returns:
349 True if a file named _IGNORE_FILE in one of the passed-in path's parent
350 directories contains a wildcard matching the path.
351 """
352 # Skip ignore files.
353 if os.path.basename(path) == _IGNORE_FILE:
354 return True
355
356 path = os.path.abspath(path)
357 base = os.getcwd()
358
359 prefix = os.path.dirname(path)
360 while prefix.startswith(base):
361 rel_path = path[len(prefix) + 1:]
362 for wildcard in _get_ignore_wildcards(prefix, cache):
363 if fnmatch.fnmatch(rel_path, wildcard):
364 return True
365 prefix = os.path.dirname(prefix)
366
367 return False
368
369
Mike Frysinger292b45d2014-11-25 01:17:10 -0500370def _get_affected_files(commit, include_deletes=False, relative=False,
371 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700372 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700373 """Returns list of file paths that were modified/added, excluding symlinks.
374
375 Args:
376 commit: The commit
377 include_deletes: If true, we'll include deleted files in the result
378 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500379 include_symlinks: If true, we'll include symlinks in the result
380 include_adds: If true, we'll include new files in the result
381 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700382 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700383
384 Returns:
385 A list of modified/added (and perhaps deleted) files
386 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500387 if not relative and full_details:
388 raise ValueError('full_details only supports relative paths currently')
389
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700390 if commit == PRE_SUBMIT:
391 return _run_command(['git', 'diff-index', '--cached',
392 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500393
394 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400395 # {<commit>: {<path1>: <content>, <path2>: <content>}}
396 cache = CACHE.get_subcache('get_affected_files')
397 if path not in cache:
398 cache[path] = git.RawDiff(path, '%s^!' % commit)
399 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500400
401 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500402 if not include_symlinks:
403 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 if not include_deletes:
406 files = [x for x in files if x.status != 'D']
407
Mike Frysinger292b45d2014-11-25 01:17:10 -0500408 if not include_adds:
409 files = [x for x in files if x.status != 'A']
410
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700411 if use_ignore_files:
412 cache = {}
413 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
414 files = [x for x in files if not is_ignored(x)]
415
Mike Frysinger292b45d2014-11-25 01:17:10 -0500416 if full_details:
417 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500418 return files
419 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 # Caller only cares about filenames.
421 files = [x.dst_file if x.dst_file else x.src_file for x in files]
422 if relative:
423 return files
424 else:
425 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700426
427
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700428def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700429 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400430 cmd = ['git', 'log', '--no-merges', '--format=%H',
431 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700432 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700433
Ryan Cui1562fb82011-05-09 11:01:31 -0700434
Ryan Cuiec4d6332011-05-02 14:15:25 -0700435def _get_commit_desc(commit):
436 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700437 if commit == PRE_SUBMIT:
438 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400439
440 # {<commit>: <content>}
441 cache = CACHE.get_subcache('get_commit_desc')
442 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500443 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400444 commit + '^!'])
445 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700446
447
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800448def _check_lines_in_diff(commit, files, check_callable, error_description):
449 """Checks given file for errors via the given check.
450
451 This is a convenience function for common per-line checks. It goes through all
452 files and returns a HookFailure with the error description listing all the
453 failures.
454
455 Args:
456 commit: The commit we're working on.
457 files: The files to check.
458 check_callable: A callable that takes a line and returns True if this line
459 _fails_ the check.
460 error_description: A string describing the error.
461 """
462 errors = []
463 for afile in files:
464 for line_num, line in _get_file_diff(afile, commit):
465 if check_callable(line):
466 errors.append('%s, line %s' % (afile, line_num))
467 if errors:
468 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400469 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800470
471
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900472def _parse_common_inclusion_options(options):
473 """Parses common hook options for including/excluding files.
474
475 Args:
476 options: Option string list.
477
478 Returns:
479 (included, excluded) where each one is a list of regex strings.
480 """
481 parser = argparse.ArgumentParser()
482 parser.add_argument('--exclude_regex', action='append')
483 parser.add_argument('--include_regex', action='append')
484 opts = parser.parse_args(options)
485 included = opts.include_regex or []
486 excluded = opts.exclude_regex or []
487 return included, excluded
488
489
Ryan Cuiec4d6332011-05-02 14:15:25 -0700490# Common Hooks
491
Ryan Cui1562fb82011-05-09 11:01:31 -0700492
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900493def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500494 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900495 LONG_LINE_OK_PATHS = [
496 # Go has no line length limit.
497 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400498 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900499 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500500
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900501 DEFAULT_MAX_LENGTHS = [
502 # Java's line length limit is 100 chars.
503 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
504 (r'.*\.java$', 100),
505 ]
506
Ryan Cuiec4d6332011-05-02 14:15:25 -0700507 MAX_LEN = 80
508
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900509 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700510 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900511 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900512 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700513
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900514 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700516 skip_regexps = (
517 r'https?://',
518 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
519 )
520
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900521 max_len = MAX_LEN
522
523 for expr, length in DEFAULT_MAX_LENGTHS:
524 if re.search(expr, afile):
525 max_len = length
526 break
527
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700528 if os.path.basename(afile).startswith('OWNERS'):
529 # File paths can get long, and there's no way to break them up into
530 # multiple lines.
531 skip_regexps += (
532 r'^include\b',
533 r'file:',
534 )
535
536 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700537 for line_num, line in _get_file_diff(afile, commit):
538 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900539 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800540 continue
541
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900542 errors.append('%s, line %s, %s chars, over %s chars' %
543 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800544 if len(errors) == 5: # Just show the first 5 errors.
545 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700546
547 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900548 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700549 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400550 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700551
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900553def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900555 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900557 included + COMMON_INCLUDED_PATHS,
558 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800559 return _check_lines_in_diff(commit, files,
560 lambda line: line.rstrip() != line,
561 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700562
Ryan Cuiec4d6332011-05-02 14:15:25 -0700563
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900564def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700565 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400566 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
567 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700568 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400569 r'.*\.ebuild$',
570 r'.*\.eclass$',
571 r'.*\.go$',
572 r'.*/[M|m]akefile$',
573 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 ]
575
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900576 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700577 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900578 included + COMMON_INCLUDED_PATHS,
579 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800580 return _check_lines_in_diff(commit, files,
581 lambda line: '\t' in line,
582 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800584
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900585def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800586 """Checks that indents use tabs only."""
587 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400588 r'.*\.ebuild$',
589 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800590 ]
591 LEADING_SPACE_RE = re.compile('[\t]* ')
592
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900595 included + TABS_REQUIRED_PATHS,
596 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800597 return _check_lines_in_diff(
598 commit, files,
599 lambda line: LEADING_SPACE_RE.match(line) is not None,
600 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700601
Ryan Cuiec4d6332011-05-02 14:15:25 -0700602
LaMont Jones872fe762020-02-10 15:36:14 -0700603def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700604 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700605 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700606 errors = []
607 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700608 included + [r'\.go$'],
609 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700610
611 for gofile in files:
612 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400613 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500614 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700615 if output:
616 errors.append(gofile)
617 if errors:
618 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400619 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700620
621
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600622def _check_rustfmt(_project, commit):
623 """Checks that Rust files are formatted with rustfmt."""
624 errors = []
625 files = _filter_files(_get_affected_files(commit, relative=True),
626 [r'\.rs$'])
627
628 for rustfile in files:
629 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400630 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500631 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600632 if output != contents:
633 errors.append(rustfile)
634 if errors:
635 return HookFailure('Files not formatted with rustfmt: '
636 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400637 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600638
639
Mike Frysingerae409522014-02-01 03:16:11 -0500640def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700641 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500642 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700643
Cheng Yuehb707c522020-01-02 14:06:59 +0800644 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500645 msg = ('Changelist description needs TEST field (after first line)\n%s' %
646 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700647 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400648 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700649
Ryan Cuiec4d6332011-05-02 14:15:25 -0700650
Mike Frysingerae409522014-02-01 03:16:11 -0500651def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600652 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700653 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600654 msg = 'Changelist has invalid Cq-Depend target.'
655 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700656 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700657 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700658 except ValueError as ex:
659 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700660 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500661 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700662 paragraphs = desc.split('\n\n')
663 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500664 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
665 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700666 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500667
668 # We no longer support CQ-DEPEND= lines.
669 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
670 return HookFailure(
671 'CQ-DEPEND= is no longer supported. Please see:\n'
672 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
673 'contributing.md#CQ-DEPEND')
674
Mike Frysinger8cf80812019-09-16 23:49:29 -0400675 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700676
677
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800678def _check_change_is_contribution(_project, commit):
679 """Check that the change is a contribution."""
680 NO_CONTRIB = 'not a contribution'
681 if NO_CONTRIB in _get_commit_desc(commit).lower():
682 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
683 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
684 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400685 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800686
687
Alex Deymo643ac4c2015-09-03 10:40:50 -0700688def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700689 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500690 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
691
David James5c0073d2013-04-03 08:48:52 -0700692 OLD_BUG_RE = r'\nBUG=.*chromium-os'
693 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
694 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
695 'the chromium tracker in your BUG= line now.')
696 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700697
Alex Deymo643ac4c2015-09-03 10:40:50 -0700698 # Android internal and external projects use "Bug: " to track bugs in
699 # buganizer.
700 BUG_COLON_REMOTES = (
701 'aosp',
702 'goog',
703 )
704 if project.remote in BUG_COLON_REMOTES:
705 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
706 if not re.search(BUG_RE, _get_commit_desc(commit)):
707 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500708 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700709 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500710 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700711 return HookFailure(msg)
712 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400713 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700714 if not re.search(BUG_RE, _get_commit_desc(commit)):
715 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500716 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700717 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700718 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500719 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700720 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700721
Cheng Yuehb707c522020-01-02 14:06:59 +0800722 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
723
724 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
725 msg = ('The BUG field must come before the TEST field.\n%s' %
726 (SEE_ALSO,))
727 return HookFailure(msg)
728
Mike Frysinger8cf80812019-09-16 23:49:29 -0400729 return None
730
Ryan Cuiec4d6332011-05-02 14:15:25 -0700731
Jack Neus8edbf642019-07-10 16:08:31 -0600732def _check_change_no_include_oem(project, commit):
733 """Check that the change does not reference OEMs."""
734 ALLOWLIST = {
735 'chromiumos/platform/ec',
736 # Used by unit tests.
737 'project',
738 }
739 if project.name not in ALLOWLIST:
740 return None
741
Mike Frysingerbb34a222019-07-31 14:40:46 -0400742 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600743 'Reviewed-on',
744 'Reviewed-by',
745 'Signed-off-by',
746 'Commit-Ready',
747 'Tested-by',
748 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600749 'Acked-by',
750 'Modified-by',
751 'CC',
752 'Suggested-by',
753 'Reported-by',
754 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700755 'Cq-Cl-Tag',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400756 }
Jack Neus8edbf642019-07-10 16:08:31 -0600757
758 # Ignore tags, which could reasonably contain OEM names
759 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600760 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400761 x for x in _get_commit_desc(commit).splitlines()
762 if ':' not in x or x.split(':', 1)[0] not in TAGS)
763
Jack Neus8edbf642019-07-10 16:08:31 -0600764 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
765
766 # Exercise caution when expanding these lists. Adding a name
767 # could indicate a new relationship with a company!
768 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
769 ODMS = [
770 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
771 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
772 ]
773
774 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
775 # Construct regex
776 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
777 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400778 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600779 # If there's a match, throw an error.
780 error_msg = ('Changelist description contains the name of an'
781 ' %s: "%s".' % (name_type, '","'.join(matches)))
782 return HookFailure(error_msg)
783
Mike Frysinger8cf80812019-09-16 23:49:29 -0400784 return None
785
Jack Neus8edbf642019-07-10 16:08:31 -0600786
Mike Frysinger292b45d2014-11-25 01:17:10 -0500787def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700788 """Check that we're not missing a revbump of an ebuild in the given commit.
789
790 If the given commit touches files in a directory that has ebuilds somewhere
791 up the directory hierarchy, it's very likely that we need an ebuild revbump
792 in order for those changes to take effect.
793
794 It's not totally trivial to detect a revbump, so at least detect that an
795 ebuild with a revision number in it was touched. This should handle the
796 common case where we use a symlink to do the revbump.
797
798 TODO: it would be nice to enhance this hook to:
799 * Handle cases where people revbump with a slightly different syntax. I see
800 one ebuild (puppy) that revbumps with _pN. This is a false positive.
801 * Catches cases where people aren't using symlinks for revbumps. If they
802 edit a revisioned file directly (and are expected to rename it for revbump)
803 we'll miss that. Perhaps we could detect that the file touched is a
804 symlink?
805
806 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
807 still better off than without this check.
808
809 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700810 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700811 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500812 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700813
814 Returns:
815 A HookFailure or None.
816 """
Mike Frysinger011af942014-01-17 16:12:22 -0500817 # If this is the portage-stable overlay, then ignore the check. It's rare
818 # that we're doing anything other than importing files from upstream, so
819 # forcing a rev bump makes no sense.
820 whitelist = (
821 'chromiumos/overlays/portage-stable',
822 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700823 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500824 return None
825
Mike Frysinger292b45d2014-11-25 01:17:10 -0500826 def FinalName(obj):
827 # If the file is being deleted, then the dst_file is not set.
828 if obj.dst_file is None:
829 return obj.src_file
830 else:
831 return obj.dst_file
832
833 affected_path_objs = _get_affected_files(
834 commit, include_deletes=True, include_symlinks=True, relative=True,
835 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700836
837 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500838 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500839 affected_path_objs = [x for x in affected_path_objs
840 if os.path.basename(FinalName(x)) not in whitelist]
841 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700842 return None
843
844 # If we've touched any file named with a -rN.ebuild then we'll say we're
845 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500846 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
847 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700848 if touched_revved_ebuild:
849 return None
850
Mike Frysinger292b45d2014-11-25 01:17:10 -0500851 # If we're creating new ebuilds from scratch, then we don't need an uprev.
852 # Find all the dirs that new ebuilds and ignore their files/.
853 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
854 if FinalName(x).endswith('.ebuild') and x.status == 'A']
855 affected_path_objs = [obj for obj in affected_path_objs
856 if not any(FinalName(obj).startswith(x)
857 for x in ebuild_dirs)]
858 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400859 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500860
Doug Anderson42b8a052013-06-26 10:45:36 -0700861 # We want to examine the current contents of all directories that are parents
862 # of files that were touched (up to the top of the project).
863 #
864 # ...note: we use the current directory contents even though it may have
865 # changed since the commit we're looking at. This is just a heuristic after
866 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500867 if project_top is None:
868 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700869 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500870 for obj in affected_path_objs:
871 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700872 while os.path.exists(path) and not os.path.samefile(path, project_top):
873 dirs_to_check.add(path)
874 path = os.path.dirname(path)
875
876 # Look through each directory. If it's got an ebuild in it then we'll
877 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800878 affected_paths = set(os.path.join(project_top, FinalName(x))
879 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700880 for dir_path in dirs_to_check:
881 contents = os.listdir(dir_path)
882 ebuilds = [os.path.join(dir_path, path)
883 for path in contents if path.endswith('.ebuild')]
884 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
885
C Shapiroae157ae2017-09-18 16:24:03 -0600886 affected_paths_under_9999_ebuilds = set()
887 for affected_path in affected_paths:
888 for ebuild_9999 in ebuilds_9999:
889 ebuild_dir = os.path.dirname(ebuild_9999)
890 if affected_path.startswith(ebuild_dir):
891 affected_paths_under_9999_ebuilds.add(affected_path)
892
893 # If every file changed exists under a 9999 ebuild, then skip
894 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
895 continue
896
Doug Anderson42b8a052013-06-26 10:45:36 -0700897 # If the -9999.ebuild file was touched the bot will uprev for us.
898 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500899 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700900 continue
901
902 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500903 return HookFailure('Changelist probably needs a revbump of an ebuild, '
904 'or a -r1.ebuild symlink if this is a new ebuild:\n'
905 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700906
907 return None
908
909
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500910def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500911 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500912
913 We want to get away from older EAPI's as it makes life confusing and they
914 have less builtin error checking.
915
916 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700917 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500918 commit: The commit to look at
919
920 Returns:
921 A HookFailure or None.
922 """
923 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500924 # that we're doing anything other than importing files from upstream, and
925 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500926 whitelist = (
927 'chromiumos/overlays/portage-stable',
928 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700929 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500930 return None
931
Mike Frysinger948284a2018-02-01 15:22:56 -0500932 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500933
934 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
935
936 ebuilds_re = [r'\.ebuild$']
937 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
938 ebuilds_re)
939 bad_ebuilds = []
940
941 for ebuild in ebuilds:
942 # If the ebuild does not specify an EAPI, it defaults to 0.
943 eapi = '0'
944
945 lines = _get_file_content(ebuild, commit).splitlines()
946 if len(lines) == 1:
947 # This is most likely a symlink, so skip it entirely.
948 continue
949
950 for line in lines:
951 m = get_eapi.match(line)
952 if m:
953 # Once we hit the first EAPI line in this ebuild, stop processing.
954 # The spec requires that there only be one and it be first, so
955 # checking all possible values is pointless. We also assume that
956 # it's "the" EAPI line and not something in the middle of a heredoc.
957 eapi = m.group(1)
958 break
959
960 if eapi in BAD_EAPIS:
961 bad_ebuilds.append((ebuild, eapi))
962
963 if bad_ebuilds:
964 # pylint: disable=C0301
965 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
966 # pylint: enable=C0301
967 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500968 'These ebuilds are using old EAPIs. If these are imported from\n'
969 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500970 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500971 '\t%s\n'
972 'See this guide for more details:\n%s\n' %
973 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
974
Mike Frysinger8cf80812019-09-16 23:49:29 -0400975 return None
976
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500977
Mike Frysinger89bdb852014-02-01 05:26:26 -0500978def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500979 """Make sure we use the new style KEYWORDS when possible in ebuilds.
980
981 If an ebuild generally does not care about the arch it is running on, then
982 ebuilds should flag it with one of:
983 KEYWORDS="*" # A stable ebuild.
984 KEYWORDS="~*" # An unstable ebuild.
985 KEYWORDS="-* ..." # Is known to only work on specific arches.
986
987 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700988 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500989 commit: The commit to look at
990
991 Returns:
992 A HookFailure or None.
993 """
994 WHITELIST = set(('*', '-*', '~*'))
995
996 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
997
Mike Frysinger89bdb852014-02-01 05:26:26 -0500998 ebuilds_re = [r'\.ebuild$']
999 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1000 ebuilds_re)
1001
Mike Frysinger8d42d742014-09-22 15:50:21 -04001002 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001003 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001004 # We get the full content rather than a diff as the latter does not work
1005 # on new files (like when adding new ebuilds).
1006 lines = _get_file_content(ebuild, commit).splitlines()
1007 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001008 m = get_keywords.match(line)
1009 if m:
1010 keywords = set(m.group(1).split())
1011 if not keywords or WHITELIST - keywords != WHITELIST:
1012 continue
1013
Mike Frysinger8d42d742014-09-22 15:50:21 -04001014 bad_ebuilds.append(ebuild)
1015
1016 if bad_ebuilds:
1017 return HookFailure(
1018 '%s\n'
1019 'Please update KEYWORDS to use a glob:\n'
1020 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1021 ' KEYWORDS="*"\n'
1022 'If the ebuild should be marked unstable (normal for '
1023 'cros-workon / 9999 ebuilds):\n'
1024 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001025 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001026 'then use -* like so:\n'
1027 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001028
Mike Frysinger8cf80812019-09-16 23:49:29 -04001029 return None
1030
Mike Frysingerc51ece72014-01-17 16:23:40 -05001031
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001032def _check_ebuild_licenses(_project, commit):
1033 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001034 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001035 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1036
1037 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001038 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001039
1040 for ebuild in touched_ebuilds:
1041 # Skip virutal packages.
1042 if ebuild.split('/')[-3] == 'virtual':
1043 continue
1044
Alex Kleinb5953522018-08-03 11:44:21 -06001045 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1046 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1047
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001048 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001049 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001050 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1051 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001052 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001053 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001054
1055 # Also ignore licenses ending with '?'
1056 for license_type in [x for x in license_types
1057 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1058 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001059 licenses_lib.Licensing.FindLicenseType(license_type,
1060 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001061 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001062 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001063
Mike Frysinger8cf80812019-09-16 23:49:29 -04001064 return None
1065
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001066
Mike Frysingercd363c82014-02-01 05:20:18 -05001067def _check_ebuild_virtual_pv(project, commit):
1068 """Enforce the virtual PV policies."""
1069 # If this is the portage-stable overlay, then ignore the check.
1070 # We want to import virtuals as-is from upstream Gentoo.
1071 whitelist = (
1072 'chromiumos/overlays/portage-stable',
1073 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001074 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001075 return None
1076
1077 # We assume the repo name is the same as the dir name on disk.
1078 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001079 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001080
1081 is_variant = lambda x: x.startswith('overlay-variant-')
1082 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001083 is_baseboard = lambda x: x.startswith('baseboard-')
1084 is_chipset = lambda x: x.startswith('chipset-')
1085 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001086 is_private = lambda x: x.endswith('-private')
1087
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001088 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1089 is_baseboard(x) or is_project(x))
1090
Mike Frysingercd363c82014-02-01 05:20:18 -05001091 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1092
1093 ebuilds_re = [r'\.ebuild$']
1094 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1095 ebuilds_re)
1096 bad_ebuilds = []
1097
1098 for ebuild in ebuilds:
1099 m = get_pv.match(ebuild)
1100 if m:
1101 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001102 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001103 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001104
1105 pv = m.group(3).split('-', 1)[0]
1106
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001107 # Virtual versions >= 4 are special cases used above the standard
1108 # versioning structure, e.g. if one has a board inheriting a board.
1109 if float(pv) >= 4:
1110 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001111 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001112 if is_private(overlay):
1113 want_pv = '3.5' if is_variant(overlay) else '3'
1114 elif is_board(overlay):
1115 want_pv = '2.5' if is_variant(overlay) else '2'
1116 elif is_baseboard(overlay):
1117 want_pv = '1.9'
1118 elif is_chipset(overlay):
1119 want_pv = '1.8'
1120 elif is_project(overlay):
1121 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001122 else:
1123 want_pv = '1'
1124
1125 if pv != want_pv:
1126 bad_ebuilds.append((ebuild, pv, want_pv))
1127
1128 if bad_ebuilds:
1129 # pylint: disable=C0301
1130 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1131 # pylint: enable=C0301
1132 return HookFailure(
1133 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1134 '\t%s\n'
1135 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1136 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1137 'page for more details:\n%s\n' %
1138 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1139 for x in bad_ebuilds]), url))
1140
Mike Frysinger8cf80812019-09-16 23:49:29 -04001141 return None
1142
Mike Frysingercd363c82014-02-01 05:20:18 -05001143
Daniel Erat9d203ff2015-02-17 10:12:21 -07001144def _check_portage_make_use_var(_project, commit):
1145 """Verify that $USE is set correctly in make.conf and make.defaults."""
1146 files = _filter_files(_get_affected_files(commit, relative=True),
1147 [r'(^|/)make.(conf|defaults)$'])
1148
1149 errors = []
1150 for path in files:
1151 basename = os.path.basename(path)
1152
1153 # Has a USE= line already been encountered in this file?
1154 saw_use = False
1155
1156 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1157 if not line.startswith('USE='):
1158 continue
1159
1160 preserves_use = '${USE}' in line or '$USE' in line
1161
1162 if (basename == 'make.conf' or
1163 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1164 errors.append('%s:%d: missing ${USE}' % (path, i))
1165 elif basename == 'make.defaults' and not saw_use and preserves_use:
1166 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1167 (path, i))
1168
1169 saw_use = True
1170
1171 if errors:
1172 return HookFailure(
1173 'One or more Portage make files appear to set USE incorrectly.\n'
1174 '\n'
1175 'All USE assignments in make.conf and all assignments after the\n'
1176 'initial declaration in make.defaults should contain "${USE}" to\n'
1177 'preserve previously-set flags.\n'
1178 '\n'
1179 'The initial USE declaration in make.defaults should not contain\n'
1180 '"${USE}".\n',
1181 errors)
1182
Mike Frysinger8cf80812019-09-16 23:49:29 -04001183 return None
1184
Daniel Erat9d203ff2015-02-17 10:12:21 -07001185
Mike Frysingerae409522014-02-01 03:16:11 -05001186def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001187 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001188 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001189 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001190 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001191 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001192 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001193
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001194 # S-o-b tags always allowed to follow Change-ID.
LaMont Jones237f3ef2020-01-22 10:40:52 -07001195 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001196
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001197 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001198 cherry_pick_marker = 'cherry picked from commit'
1199
1200 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001201 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001202 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1203 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001204 end = end[:-1]
1205
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001206 # Note that descriptions could have multiple cherry pick markers.
1207 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001208
1209 if [x for x in end if not re.search(tag_search, x)]:
1210 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1211 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001212
Mike Frysinger8cf80812019-09-16 23:49:29 -04001213 return None
1214
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001215
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001216def _check_commit_message_style(_project, commit):
1217 """Verify that the commit message matches our style.
1218
1219 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1220 commit hooks.
1221 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001222 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001223
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001224 desc = _get_commit_desc(commit)
1225
1226 # The first line should be by itself.
1227 lines = desc.splitlines()
1228 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001229 return HookFailure('The second line of the commit message must be blank.'
1230 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001231
1232 # The first line should be one sentence.
1233 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001234 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1235 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001236
1237 # The first line cannot be too long.
1238 MAX_FIRST_LINE_LEN = 100
1239 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001240 return HookFailure('The first line must be less than %i chars.\n%s' %
1241 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001242
Mike Frysinger8cf80812019-09-16 23:49:29 -04001243 return None
1244
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001245
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001246def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001247 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001248
Mike Frysinger98638102014-08-28 00:15:08 -04001249 Should be following the spec:
1250 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1251 """
1252 # For older years, be a bit more flexible as our policy says leave them be.
1253 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001254 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1255 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001256 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001257 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001258 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001259 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001260 )
1261 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1262
1263 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001264 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001265 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001266 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001267 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001268 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001269
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001270 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001271
Mike Frysinger98638102014-08-28 00:15:08 -04001272 bad_files = []
1273 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001274 bad_year_files = []
1275
Ken Turnerd07564b2018-02-08 17:57:59 +11001276 files = _filter_files(
1277 _get_affected_files(commit, relative=True),
1278 included + COMMON_INCLUDED_PATHS,
1279 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001280 existing_files = set(_get_affected_files(commit, relative=True,
1281 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001282
Keigo Oka7e880ac2019-07-03 15:03:43 +09001283 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001284 for f in files:
1285 contents = _get_file_content(f, commit)
1286 if not contents:
1287 # Ignore empty files.
1288 continue
1289
Keigo Oka7e880ac2019-07-03 15:03:43 +09001290 m = license_re.search(contents)
1291 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001292 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001293 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001294 bad_copyright_files.append(f)
1295
Keigo Oka7e880ac2019-07-03 15:03:43 +09001296 if m and f not in existing_files:
1297 year = m.group(1)
1298 if year != current_year:
1299 bad_year_files.append(f)
1300
1301 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001302 if bad_files:
1303 msg = '%s:\n%s\n%s' % (
1304 'License must match', license_re.pattern,
1305 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001306 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001307 if bad_copyright_files:
1308 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001309 errors.append(HookFailure(msg, bad_copyright_files))
1310 if bad_year_files:
1311 msg = 'Use current year (%s) in copyright headers in new files:' % (
1312 current_year)
1313 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001314
Keigo Oka7e880ac2019-07-03 15:03:43 +09001315 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001316
Mike Frysinger8cf80812019-09-16 23:49:29 -04001317
Amin Hassani391efa92018-01-26 17:58:05 -08001318def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001319 """Verifies the AOSP license/copyright header.
1320
1321 AOSP uses the Apache2 License:
1322 https://source.android.com/source/licenses.html
1323 """
1324 LICENSE_HEADER = (
1325 r"""^[#/\*]*
1326[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1327[#/\*]* ?
1328[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1329[#/\*]* ?you may not use this file except in compliance with the License\.
1330[#/\*]* ?You may obtain a copy of the License at
1331[#/\*]* ?
1332[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1333[#/\*]* ?
1334[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1335[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1336[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1337 r"""implied\.
1338[#/\*]* ?See the License for the specific language governing permissions and
1339[#/\*]* ?limitations under the License\.
1340[#/\*]*$
1341"""
1342 )
1343 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1344
Amin Hassani391efa92018-01-26 17:58:05 -08001345 included, excluded = _parse_common_inclusion_options(options)
1346
Ken Turnerd07564b2018-02-08 17:57:59 +11001347 files = _filter_files(
1348 _get_affected_files(commit, relative=True),
1349 included + COMMON_INCLUDED_PATHS,
1350 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001351
1352 bad_files = []
1353 for f in files:
1354 contents = _get_file_content(f, commit)
1355 if not contents:
1356 # Ignore empty files.
1357 continue
1358
1359 if not license_re.search(contents):
1360 bad_files.append(f)
1361
1362 if bad_files:
1363 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1364 license_re.pattern)
1365 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001366 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001367
1368
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001369def _check_layout_conf(_project, commit):
1370 """Verifies the metadata/layout.conf file."""
1371 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001372 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001373 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001374 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001375
Mike Frysinger94a670c2014-09-19 12:46:26 -04001376 # Handle multiple overlays in a single commit (like the public tree).
1377 for f in _get_affected_files(commit, relative=True):
1378 if f.endswith(repo_name):
1379 repo_names.append(f)
1380 elif f.endswith(layout_path):
1381 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001382
1383 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001384 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001385 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001386 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001387
Mike Frysinger94a670c2014-09-19 12:46:26 -04001388 # Gather all the errors in one pass so we show one full message.
1389 all_errors = {}
1390 for layout_path in layout_paths:
1391 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001392
Mike Frysinger94a670c2014-09-19 12:46:26 -04001393 # Make sure the config file is sorted.
1394 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1395 if x and x[0] != '#']
1396 if sorted(data) != data:
1397 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001398
Mike Frysinger94a670c2014-09-19 12:46:26 -04001399 # Require people to set specific values all the time.
1400 settings = (
1401 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001402 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001403 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001404 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1405 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001406 )
1407 for reason, line in settings:
1408 if line not in data:
1409 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001410
Mike Frysinger94a670c2014-09-19 12:46:26 -04001411 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001412 if 'use-manifests = strict' not in data:
1413 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001414
Mike Frysinger94a670c2014-09-19 12:46:26 -04001415 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001416 for line in data:
1417 if line.startswith('repo-name = '):
1418 break
1419 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001420 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001421
Mike Frysinger94a670c2014-09-19 12:46:26 -04001422 # Summarize all the errors we saw (if any).
1423 lines = ''
1424 for layout_path, errors in all_errors.items():
1425 if errors:
1426 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1427 if lines:
1428 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1429 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001430
Mike Frysinger8cf80812019-09-16 23:49:29 -04001431 return None
1432
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001433
Keigo Oka4a09bd92019-05-07 14:01:00 +09001434def _check_no_new_gyp(_project, commit):
1435 """Verifies no project starts to use GYP."""
1436 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001437 'chromeos/ap',
1438 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001439 'chromeos/ap/security',
1440 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001441 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001442 'chromeos/platform/drivefs-google3',
1443 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001444 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001445 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001446 'weave/libweave',
1447 ]
1448 if _project.name in whitelist:
1449 return None
1450
1451 gypfiles = _filter_files(
1452 _get_affected_files(commit, include_symlinks=True, relative=True),
1453 [r'\.gyp$'])
1454
1455 if gypfiles:
1456 return HookFailure('GYP is deprecated and not allowed in a new project:',
1457 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001458 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001459
1460
Ryan Cuiec4d6332011-05-02 14:15:25 -07001461# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001462
Ryan Cui1562fb82011-05-09 11:01:31 -07001463
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001464def _check_clang_format(_project, commit, options=()):
1465 """Runs clang-format on the given project"""
1466 hooks_dir = _get_hooks_dir()
1467 options = list(options)
1468 if commit == PRE_SUBMIT:
1469 options.append('--commit=HEAD')
1470 else:
1471 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001472 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001473 cmd_result = cros_build_lib.run(cmd,
1474 print_cmd=False,
1475 stdout=True,
1476 encoding='utf-8',
1477 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001478 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001479 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001480 if cmd_result.returncode:
1481 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001482 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001483 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001484
1485
Mike Frysingerae409522014-02-01 03:16:11 -05001486def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001487 """Runs checkpatch.pl on the given project"""
1488 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001489 options = list(options)
1490 if commit == PRE_SUBMIT:
1491 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1492 # this case.
1493 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001494 # Always ignore the check for the MAINTAINERS file. We do not track that
1495 # information on that file in our source trees, so let's suppress the
1496 # warning.
1497 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001498 # Do not complain about the Change-Id: fields, since we use Gerrit.
1499 # Upstream does not want those lines (since they do not use Gerrit), but
1500 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001501 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001502 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001503 cmd_result = cros_build_lib.run(
1504 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001505 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001506 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001507 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001508 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001509 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001510
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001511
Brian Norris23c62e92018-11-14 12:25:51 -08001512def _run_kerneldoc(_project, commit, options=()):
1513 """Runs kernel-doc validator on the given project"""
1514 included, excluded = _parse_common_inclusion_options(options)
1515 files = _filter_files(_get_affected_files(commit, relative=True),
1516 included, excluded)
1517 if files:
1518 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001519 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001520 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001521 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001522 return HookFailure('kernel-doc errors/warnings:',
1523 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001524 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001525
1526
Mike Frysingerae409522014-02-01 03:16:11 -05001527def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001528 """Makes sure kernel config changes are not mixed with code changes"""
1529 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001530 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001531 return HookFailure('Changes to chromeos/config/ and regular files must '
1532 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001533 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001534
Mike Frysingerae409522014-02-01 03:16:11 -05001535
1536def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001537 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001538 ret = []
1539
1540 files = _filter_files(_get_affected_files(commit, relative=True),
1541 [r'.*\.json$'])
1542 for f in files:
1543 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001544 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001545 json.loads(data)
1546 except Exception as e:
1547 ret.append('%s: Invalid JSON: %s' % (f, e))
1548
1549 if ret:
1550 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001551 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001552
1553
Mike Frysingerae409522014-02-01 03:16:11 -05001554def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001555 """Make sure Manifest files only have comments & DIST lines."""
1556 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001557
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001558 manifests = _filter_files(_get_affected_files(commit, relative=True),
1559 [r'.*/Manifest$'])
1560 for path in manifests:
1561 data = _get_file_content(path, commit)
1562
1563 # Disallow blank files.
1564 if not data.strip():
1565 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001566 continue
1567
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001568 # Make sure the last newline isn't omitted.
1569 if data[-1] != '\n':
1570 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001571
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001572 # Do not allow leading or trailing blank lines.
1573 lines = data.splitlines()
1574 if not lines[0]:
1575 ret.append('%s: delete leading blank lines' % (path,))
1576 if not lines[-1]:
1577 ret.append('%s: delete trailing blank lines' % (path,))
1578
1579 for line in lines:
1580 # Disallow leading/trailing whitespace.
1581 if line != line.strip():
1582 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1583
1584 # Allow blank lines & comments.
1585 line = line.split('#', 1)[0]
1586 if not line:
1587 continue
1588
1589 # All other linse should start with DIST.
1590 if not line.startswith('DIST '):
1591 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1592 break
1593
1594 if ret:
1595 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001596 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001597
1598
Mike Frysingerae409522014-02-01 03:16:11 -05001599def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001600 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001601 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001602 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001603 BRANCH_RE = r'\nBRANCH=\S+'
1604
1605 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1606 msg = ('Changelist description needs BRANCH field (after first line)\n'
1607 'E.g. BRANCH=none or BRANCH=link,snow')
1608 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001609 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001610
1611
Mike Frysinger45334bd2019-11-04 10:42:33 -05001612def _check_change_has_no_branch_field(_project, commit):
1613 """Verify 'BRANCH=' field does not exist in the commit message."""
1614 if commit == PRE_SUBMIT:
1615 return None
1616 BRANCH_RE = r'\nBRANCH=\S+'
1617
1618 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1619 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1620 return HookFailure(msg)
1621 return None
1622
1623
Mike Frysingerae409522014-02-01 03:16:11 -05001624def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001625 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001626 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001627 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001628 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1629
1630 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1631 msg = ('Changelist description needs Signed-off-by: field\n'
1632 'E.g. Signed-off-by: My Name <me@chromium.org>')
1633 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001634 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001635
1636
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001637def _check_change_has_no_signoff_field(_project, commit):
1638 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1639 if commit == PRE_SUBMIT:
1640 return None
1641 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1642
1643 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1644 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1645 return HookFailure(msg)
1646 return None
1647
1648
Jon Salz3ee59de2012-08-18 13:54:22 +08001649def _run_project_hook_script(script, project, commit):
1650 """Runs a project hook script.
1651
1652 The script is run with the following environment variables set:
1653 PRESUBMIT_PROJECT: The affected project
1654 PRESUBMIT_COMMIT: The affected commit
1655 PRESUBMIT_FILES: A newline-separated list of affected files
1656
1657 The script is considered to fail if the exit code is non-zero. It should
1658 write an error message to stdout.
1659 """
1660 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001661 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001662 env['PRESUBMIT_COMMIT'] = commit
1663
1664 # Put affected files in an environment variable
1665 files = _get_affected_files(commit)
1666 env['PRESUBMIT_FILES'] = '\n'.join(files)
1667
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001668 cmd_result = cros_build_lib.run(cmd=script,
1669 env=env,
1670 shell=True,
1671 print_cmd=False,
1672 input=os.devnull,
1673 stdout=True,
1674 encoding='utf-8',
1675 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001676 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001677 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001678 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001679 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001680 if stdout:
1681 stdout = re.sub('(?m)^', ' ', stdout)
1682 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001683 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001684 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001685 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001686
1687
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001688def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001689 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001690
Brian Norris77608e12018-04-06 10:38:43 -07001691 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001692 prefix = os.path.commonprefix(files)
1693 prefix = os.path.dirname(prefix)
1694
1695 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001696 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001697 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001698
1699 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001700
1701 # The common files may all be within a subdirectory of the main project
1702 # directory, so walk up the tree until we find an alias file.
1703 # _get_affected_files() should return relative paths, but check against '/' to
1704 # ensure that this loop terminates even if it receives an absolute path.
1705 while prefix and prefix != '/':
1706 alias_file = os.path.join(prefix, '.project_alias')
1707
1708 # If an alias exists, use it.
1709 if os.path.isfile(alias_file):
1710 project_name = osutils.ReadFile(alias_file).strip()
1711
1712 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001713
1714 if not _get_commit_desc(commit).startswith(project_name + ': '):
1715 return HookFailure('The commit title for changes affecting only %s'
1716 ' should start with \"%s: \"'
1717 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001718 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001719
1720
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001721def _check_filepath_chartype(_project, commit):
1722 """Checks that FilePath::CharType stuff is not used."""
1723
1724 FILEPATH_REGEXP = re.compile('|'.join(
1725 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001726 r'(?:base::)?FilePath::FromUTF8Unsafe',
1727 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001728 r'FILE_PATH_LITERAL']))
1729 files = _filter_files(_get_affected_files(commit, relative=True),
1730 [r'.*\.(cc|h)$'])
1731
1732 errors = []
1733 for afile in files:
1734 for line_num, line in _get_file_diff(afile, commit):
1735 m = re.search(FILEPATH_REGEXP, line)
1736 if m:
1737 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1738
1739 if errors:
1740 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1741 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001742 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001743
1744
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001745def _check_exec_files(_project, commit):
1746 """Make +x bits on files."""
1747 # List of files that should never be +x.
1748 NO_EXEC = (
1749 'ChangeLog*',
1750 'COPYING',
1751 'make.conf',
1752 'make.defaults',
1753 'Manifest',
1754 'OWNERS',
1755 'package.use',
1756 'package.keywords',
1757 'package.mask',
1758 'parent',
1759 'README',
1760 'TODO',
1761 '.gitignore',
1762 '*.[achly]',
1763 '*.[ch]xx',
1764 '*.boto',
1765 '*.cc',
1766 '*.cfg',
1767 '*.conf',
1768 '*.config',
1769 '*.cpp',
1770 '*.css',
1771 '*.ebuild',
1772 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001773 '*.gn',
1774 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001775 '*.gyp',
1776 '*.gypi',
1777 '*.htm',
1778 '*.html',
1779 '*.ini',
1780 '*.js',
1781 '*.json',
1782 '*.md',
1783 '*.mk',
1784 '*.patch',
1785 '*.policy',
1786 '*.proto',
1787 '*.raw',
1788 '*.rules',
1789 '*.service',
1790 '*.target',
1791 '*.txt',
1792 '*.xml',
1793 '*.yaml',
1794 )
1795
1796 def FinalName(obj):
1797 # If the file is being deleted, then the dst_file is not set.
1798 if obj.dst_file is None:
1799 return obj.src_file
1800 else:
1801 return obj.dst_file
1802
1803 bad_files = []
1804 files = _get_affected_files(commit, relative=True, full_details=True)
1805 for f in files:
1806 mode = int(f.dst_mode, 8)
1807 if not mode & 0o111:
1808 continue
1809 name = FinalName(f)
1810 for no_exec in NO_EXEC:
1811 if fnmatch.fnmatch(name, no_exec):
1812 bad_files.append(name)
1813 break
1814
1815 if bad_files:
1816 return HookFailure('These files should not be executable. '
1817 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001818 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001819
1820
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001821# Base
1822
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001823# A list of hooks which are not project specific and check patch description
1824# (as opposed to patch body).
1825_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001826 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001827 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001828 _check_change_has_test_field,
1829 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001830 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001831 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001832 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001833]
1834
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001835# A list of hooks that are not project-specific
1836_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001837 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001838 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001839 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001840 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001841 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001842 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001843 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001844 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001845 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001846 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001847 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001848 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001849 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001850 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001851 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001852 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001853]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001854
Ryan Cui1562fb82011-05-09 11:01:31 -07001855
Ryan Cui9b651632011-05-11 11:38:58 -07001856# A dictionary of project-specific hooks(callbacks), indexed by project name.
1857# dict[project] = [callback1, callback2]
1858_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001859 'chromiumos/third_party/kernel': [_kernel_configcheck],
1860 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001861}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001862
Ryan Cui1562fb82011-05-09 11:01:31 -07001863
Ryan Cui9b651632011-05-11 11:38:58 -07001864# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001865# that the flag controls (value).
1866_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001867 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001868 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001869 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001870 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001871 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001872 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001873 'cros_license_check': _check_cros_license,
1874 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07001875 'gofmt_check': _check_gofmt,
Ryan Cui9b651632011-05-11 11:38:58 -07001876 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001877 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001878 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001879 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001880 'bug_field_check': _check_change_has_bug_field,
1881 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001882 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001883 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001884 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001885 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001886}
1887
1888
Mike Frysinger3554bc92015-03-11 04:59:21 -04001889def _get_override_hooks(config):
1890 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001891
1892 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001893
1894 Args:
1895 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001896 """
1897 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001898 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001899
Mike Frysinger56e8de02019-07-31 14:40:14 -04001900 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001901 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001902 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001903
1904 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001905 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001906 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001907 if flag not in valid_keys:
1908 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1909 (flag, _CONFIG_FILE))
1910
Ryan Cui9b651632011-05-11 11:38:58 -07001911 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001912 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001913 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001914 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1915 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001916 if enabled:
1917 enable_flags.append(flag)
1918 else:
1919 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001920
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001921 # See if this hook has custom options.
1922 if enabled:
1923 try:
1924 options = config.get(SECTION_OPTIONS, flag)
1925 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001926 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001927 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001928 pass
1929
1930 enabled_hooks = set(hooks[x] for x in enable_flags)
1931 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001932
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001933 if _check_change_has_signoff_field not in enabled_hooks:
1934 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001935 if _check_change_has_branch_field not in enabled_hooks:
1936 enabled_hooks.add(_check_change_has_no_branch_field)
1937
Mike Frysinger3554bc92015-03-11 04:59:21 -04001938 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001939
1940
Jon Salz3ee59de2012-08-18 13:54:22 +08001941def _get_project_hook_scripts(config):
1942 """Returns a list of project-specific hook scripts.
1943
1944 Args:
1945 config: A ConfigParser for the project's config file.
1946 """
1947 SECTION = 'Hook Scripts'
1948 if not config.has_section(SECTION):
1949 return []
1950
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001951 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001952
1953
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001954def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001955 """Returns a list of hooks that need to be run for a project.
1956
1957 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001958
1959 Args:
1960 project: A string, name of the project.
1961 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001962 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001963 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001964 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001965 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001966 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001967 else:
1968 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001969
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001970 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001971 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001972 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001973 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001974
Mike Frysinger3554bc92015-03-11 04:59:21 -04001975 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001976 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1977
1978 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1979 # override, keep the override only. Note that the override may end up being
1980 # a functools.partial, in which case we need to extract the .func to compare
1981 # it to the common hooks.
1982 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1983 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1984
1985 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001986
1987 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001988 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1989 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001990
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001991 for name, script in _get_project_hook_scripts(config):
1992 func = functools.partial(_run_project_hook_script, script)
1993 func.__name__ = name
1994 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001995
Ryan Cui9b651632011-05-11 11:38:58 -07001996 return hooks
1997
1998
Alex Deymo643ac4c2015-09-03 10:40:50 -07001999def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002000 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07002001 """For each project run its project specific hook from the hooks dictionary.
2002
2003 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002004 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002005 proj_dir: If non-None, this is the directory the project is in. If None,
2006 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002007 commit_list: A list of commits to run hooks against. If None or empty list
2008 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002009 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002010
2011 Returns:
2012 Boolean value of whether any errors were ecountered while running the hooks.
2013 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002014 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002015 proj_dirs = _run_command(
2016 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002017 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002018 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002019 print('Please specify a valid project.', file=sys.stderr)
2020 return True
2021 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002022 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002023 file=sys.stderr)
2024 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2025 return True
2026 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002027
Ryan Cuiec4d6332011-05-02 14:15:25 -07002028 pwd = os.getcwd()
2029 # hooks assume they are run from the root of the project
2030 os.chdir(proj_dir)
2031
Mike Frysingered1b95a2019-12-12 19:04:51 -05002032 color = terminal.Color()
2033
Alex Deymo643ac4c2015-09-03 10:40:50 -07002034 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2035 '--symbolic-full-name', '@{u}']).strip()
2036 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002037 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002038 file=sys.stderr)
2039 remote = None
2040 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002041 branch_items = remote_branch.split('/', 1)
2042 if len(branch_items) != 2:
2043 PrintErrorForProject(
2044 project_name,
2045 HookFailure(
2046 'Cannot get remote and branch name (%s)' % remote_branch))
2047 os.chdir(pwd)
2048 return True
2049 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002050
2051 project = Project(name=project_name, dir=proj_dir, remote=remote)
2052
Doug Anderson14749562013-06-26 13:38:29 -07002053 if not commit_list:
2054 try:
2055 commit_list = _get_commits()
2056 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002057 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002058 os.chdir(pwd)
2059 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002060
Alex Deymo643ac4c2015-09-03 10:40:50 -07002061 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002062 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002063 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002064 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002065 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002066 CACHE.clear()
2067
Mike Frysingered1b95a2019-12-12 19:04:51 -05002068 desc = _get_commit_desc(commit)
2069 print('[%s %i/%i %s] %s' %
2070 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2071 desc.splitlines()[0]))
2072
Mike Frysingerb99b3772019-08-17 14:19:44 -04002073 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002074 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2075 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2076 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002077 print(output, end='\r')
2078 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002079 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002080 print(' ' * len(output), end='\r')
2081 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002082 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002083 if not isinstance(hook_error, list):
2084 hook_error = [hook_error]
2085 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002086 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002087
Ryan Cuiec4d6332011-05-02 14:15:25 -07002088 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002089 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002090
Mike Frysingerae409522014-02-01 03:16:11 -05002091
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002092# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002093
Ryan Cui1562fb82011-05-09 11:01:31 -07002094
Mike Frysingerae409522014-02-01 03:16:11 -05002095def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002096 """Main function invoked directly by repo.
2097
2098 This function will exit directly upon error so that repo doesn't print some
2099 obscure error message.
2100
2101 Args:
2102 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002103 worktree_list: A list of directories. It should be the same length as
2104 project_list, so that each entry in project_list matches with a directory
2105 in worktree_list. If None, we will attempt to calculate the directories
2106 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002107 kwargs: Leave this here for forward-compatibility.
2108 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002109 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002110 found_error = False
David James2edd9002013-10-11 14:09:19 -07002111 if not worktree_list:
2112 worktree_list = [None] * len(project_list)
2113 for project, worktree in zip(project_list, worktree_list):
2114 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002115 found_error = True
2116
Mike Frysingered1b95a2019-12-12 19:04:51 -05002117 end_time = datetime.datetime.now()
2118 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002119 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002120 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002121 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002122 '<checkout_dir>/src/repohooks/README.md\n'
2123 "- To upload only current project, run 'repo upload .'" %
2124 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002125 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002126 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002127 else:
2128 msg = ('[%s] repohooks passed in %s' %
2129 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2130 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002131
Ryan Cui1562fb82011-05-09 11:01:31 -07002132
Doug Anderson44a644f2011-11-02 10:37:37 -07002133def _identify_project(path):
2134 """Identify the repo project associated with the given path.
2135
2136 Returns:
2137 A string indicating what project is associated with the path passed in or
2138 a blank string upon failure.
2139 """
2140 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002141 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002142
2143
Mike Frysinger55f85b52014-12-18 14:45:21 -05002144def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002145 """Run hooks directly (outside of the context of repo).
2146
Doug Anderson44a644f2011-11-02 10:37:37 -07002147 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002148 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002149
2150 Returns:
2151 0 if no pre-upload failures, 1 if failures.
2152
2153 Raises:
2154 BadInvocation: On some types of invocation errors.
2155 """
Mike Frysinger66142932014-12-18 14:55:57 -05002156 parser = commandline.ArgumentParser(description=__doc__)
2157 parser.add_argument('--dir', default=None,
2158 help='The directory that the project lives in. If not '
2159 'specified, use the git project root based on the cwd.')
2160 parser.add_argument('--project', default=None,
2161 help='The project repo path; this can affect how the '
2162 'hooks get run, since some hooks are project-specific. '
2163 'For chromite this is chromiumos/chromite. If not '
2164 'specified, the repo tool will be used to figure this '
2165 'out based on the dir.')
2166 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002167 help='Rerun hooks on old commits since some point '
2168 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002169 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002170 'or a SHA1, or just a number of commits to check (from 1 '
2171 'to 99). This option is mutually exclusive with '
2172 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002173 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002174 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002175 "This option should be used at the 'git commit' "
2176 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002177 'is mutually exclusive with --rerun-since.')
2178 parser.add_argument('commits', nargs='*',
2179 help='Check specific commits')
2180 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002181
Doug Anderson14749562013-06-26 13:38:29 -07002182 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002183 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002184 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002185 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002186
Vadim Bendebury75447b92018-01-10 12:06:01 -08002187 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2188 # This must be the number of commits to check. We don't expect the user
2189 # to want to check more than 99 commits.
2190 limit = '-n%s' % opts.rerun_since
2191 elif git.IsSHA1(opts.rerun_since, False):
2192 limit = '%s..' % opts.rerun_since
2193 else:
2194 # This better be a date.
2195 limit = '--since=%s' % opts.rerun_since
2196 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002197 all_commits = _run_command(cmd).splitlines()
2198 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2199
2200 # Eliminate chrome-bot commits but keep ordering the same...
2201 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002202 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002203
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002204 if opts.pre_submit:
2205 raise BadInvocation('rerun-since and pre-submit can not be '
2206 'used together')
2207 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002208 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002209 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002210 ' '.join(opts.commits))
2211 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002212
2213 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2214 # project from CWD
2215 if opts.dir is None:
2216 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002217 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002218 if not git_dir:
2219 raise BadInvocation('The current directory is not part of a git project.')
2220 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2221 elif not os.path.isdir(opts.dir):
2222 raise BadInvocation('Invalid dir: %s' % opts.dir)
2223 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2224 raise BadInvocation('Not a git directory: %s' % opts.dir)
2225
2226 # Identify the project if it wasn't specified; this _requires_ the repo
2227 # tool to be installed and for the project to be part of a repo checkout.
2228 if not opts.project:
2229 opts.project = _identify_project(opts.dir)
2230 if not opts.project:
2231 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2232
Doug Anderson14749562013-06-26 13:38:29 -07002233 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002234 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002235 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002236 if found_error:
2237 return 1
2238 return 0
2239
2240
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002241if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002242 sys.exit(direct_main(sys.argv[1:]))