blob: d65946d3dc0b523a375dd4b52cecc72a4d26aead [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Vadim Bendebury2b62d742014-06-22 13:14:51 -070054PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070055
Mike Frysingered9b2a02019-12-12 18:52:32 -050056
57# Link to commit message documentation for users.
58DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
59 '/contributing.md#commit-messages')
60
61
Ryan Cuiec4d6332011-05-02 14:15:25 -070062COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050063 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040064 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
65 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050066 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040067 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050068 # No extension at all, note that ALL CAPS files are black listed in
69 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040070 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
73 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
74 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070075]
76
Ryan Cui1562fb82011-05-09 11:01:31 -070077
Ryan Cuiec4d6332011-05-02 14:15:25 -070078COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070079 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040080 r'.*/Manifest$',
81 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070082
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'(^|.*/)overlay-.*/profiles/.*',
85 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040086
C Shapiro8f90e9b2017-06-28 09:54:50 -060087 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
89 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060090
Daniel Erate3ea3fc2015-02-13 15:27:52 -070091 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'.*\.min\.js',
93 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050094
95 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -070097
Mike Frysinger13650402019-07-31 14:31:46 -040098 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040099 r'.*_pb2\.py$',
100 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700101]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700102
Ken Turnerd07564b2018-02-08 17:57:59 +1100103LICENSE_EXCLUDED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'^(.*/)?OWNERS$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100105]
Ryan Cui1562fb82011-05-09 11:01:31 -0700106
Ryan Cui9b651632011-05-11 11:38:58 -0700107_CONFIG_FILE = 'PRESUBMIT.cfg'
108
109
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700110# File containing wildcards, one per line, matching files that should be
111# excluded from presubmit checks. Lines beginning with '#' are ignored.
112_IGNORE_FILE = '.presubmitignore'
113
Doug Anderson44a644f2011-11-02 10:37:37 -0700114# Exceptions
115
116
117class BadInvocation(Exception):
118 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700119
120
Ryan Cui1562fb82011-05-09 11:01:31 -0700121# General Helpers
122
Sean Paulba01d402011-05-05 11:36:23 -0400123
Mike Frysingerb2496652019-09-12 23:35:46 -0400124class Cache(object):
125 """General helper for caching git content."""
126
127 def __init__(self):
128 self._cache = {}
129
130 def get_subcache(self, scope):
131 return self._cache.setdefault(scope, {})
132
133 def clear(self):
134 self._cache.clear()
135
136CACHE = Cache()
137
138
Alex Deymo643ac4c2015-09-03 10:40:50 -0700139Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
140
141
Mike Frysinger526a5f82019-09-13 18:05:30 -0400142def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700143 """Executes the passed in command and returns raw stdout output.
144
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400145 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400146
Doug Anderson44a644f2011-11-02 10:37:37 -0700147 Args:
148 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400149 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700150
151 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700152 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700153 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400154 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400155 kwargs.setdefault('stdout', True)
156 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500157 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400158 # NB: We decode this directly rather than through kwargs as our tests rely
159 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400160 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700161
Ryan Cui1562fb82011-05-09 11:01:31 -0700162
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700163def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700164 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700165 if __name__ == '__main__':
166 # Works when file is run on its own (__file__ is defined)...
167 return os.path.abspath(os.path.dirname(__file__))
168 else:
169 # We need to do this when we're run through repo. Since repo executes
170 # us with execfile(), we don't get __file__ defined.
171 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
172 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700173
Ryan Cui1562fb82011-05-09 11:01:31 -0700174
Ryan Cuiec4d6332011-05-02 14:15:25 -0700175def _match_regex_list(subject, expressions):
176 """Try to match a list of regular expressions to a string.
177
178 Args:
179 subject: The string to match regexes on
180 expressions: A list of regular expressions to check for matches with.
181
182 Returns:
183 Whether the passed in subject matches any of the passed in regexes.
184 """
185 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500186 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700187 return True
188 return False
189
Ryan Cui1562fb82011-05-09 11:01:31 -0700190
Mike Frysingerae409522014-02-01 03:16:11 -0500191def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700192 """Filter out files based on the conditions passed in.
193
194 Args:
195 files: list of filepaths to filter
196 include_list: list of regex that when matched with a file path will cause it
197 to be added to the output list unless the file is also matched with a
198 regex in the exclude_list.
199 exclude_list: list of regex that when matched with a file will prevent it
200 from being added to the output list, even if it is also matched with a
201 regex in the include_list.
202
203 Returns:
204 A list of filepaths that contain files matched in the include_list and not
205 in the exclude_list.
206 """
207 filtered = []
208 for f in files:
209 if (_match_regex_list(f, include_list) and
210 not _match_regex_list(f, exclude_list)):
211 filtered.append(f)
212 return filtered
213
Ryan Cuiec4d6332011-05-02 14:15:25 -0700214
215# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700216
217
Ryan Cui4725d952011-05-05 15:41:19 -0700218def _get_upstream_branch():
219 """Returns the upstream tracking branch of the current branch.
220
221 Raises:
222 Error if there is no tracking branch
223 """
224 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
225 current_branch = current_branch.replace('refs/heads/', '')
226 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700227 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700228
229 cfg_option = 'branch.' + current_branch + '.%s'
230 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
231 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
232 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700233 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700234
235 return full_upstream.replace('heads', 'remotes/' + remote)
236
Ryan Cui1562fb82011-05-09 11:01:31 -0700237
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700238def _get_patch(commit):
239 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700240 if commit == PRE_SUBMIT:
241 return _run_command(['git', 'diff', '--cached', 'HEAD'])
242 else:
243 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700244
Ryan Cui1562fb82011-05-09 11:01:31 -0700245
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500246def _get_file_content(path, commit):
247 """Returns the content of a file at a specific commit.
248
249 We can't rely on the file as it exists in the filesystem as people might be
250 uploading a series of changes which modifies the file multiple times.
251
252 Note: The "content" of a symlink is just the target. So if you're expecting
253 a full file, you should check that first. One way to detect is that the
254 content will not have any newlines.
255 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400256 # Make sure people don't accidentally pass in full paths which will never
257 # work. You need to use relative=True with _get_affected_files.
258 if path.startswith('/'):
259 raise ValueError('_get_file_content must be called with relative paths: %s'
260 % (path,))
261
262 # {<commit>: {<path1>: <content>, <path2>: <content>}}
263 cache = CACHE.get_subcache('get_file_content')
264 if path in cache:
265 return cache[path]
266
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700267 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400268 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700269 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400270 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
271 cache[path] = content
272 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500273
274
Mike Frysingerae409522014-02-01 03:16:11 -0500275def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700276 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 # {<commit>: {<path1>: <content>, <path2>: <content>}}
278 cache = CACHE.get_subcache('get_file_diff')
279 if path in cache:
280 return cache[path]
281
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700282 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800283 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
284 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700285 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800286 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
287 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700288 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700289
290 new_lines = []
291 line_num = 0
292 for line in output.splitlines():
293 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
294 if m:
295 line_num = int(m.groups(1)[0])
296 continue
297 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400298 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700299 if not line.startswith('-'):
300 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400301 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302 return new_lines
303
Ryan Cui1562fb82011-05-09 11:01:31 -0700304
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700305def _get_ignore_wildcards(directory, cache):
306 """Get wildcards listed in a directory's _IGNORE_FILE.
307
308 Args:
309 directory: A string containing a directory path.
310 cache: A dictionary (opaque to caller) caching previously-read wildcards.
311
312 Returns:
313 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
314 wasn't present.
315 """
316 # In the cache, keys are directories and values are lists of wildcards from
317 # _IGNORE_FILE within those directories (and empty if no file was present).
318 if directory not in cache:
319 wildcards = []
320 dotfile_path = os.path.join(directory, _IGNORE_FILE)
321 if os.path.exists(dotfile_path):
322 # TODO(derat): Consider using _get_file_content() to get the file as of
323 # this commit instead of the on-disk version. This may have a noticeable
324 # performance impact, as each call to _get_file_content() runs git.
325 with open(dotfile_path, 'r') as dotfile:
326 for line in dotfile.readlines():
327 line = line.strip()
328 if line.startswith('#'):
329 continue
330 if line.endswith('/'):
331 line += '*'
332 wildcards.append(line)
333 cache[directory] = wildcards
334
335 return cache[directory]
336
337
338def _path_is_ignored(path, cache):
339 """Check whether a path is ignored by _IGNORE_FILE.
340
341 Args:
342 path: A string containing a path.
343 cache: A dictionary (opaque to caller) caching previously-read wildcards.
344
345 Returns:
346 True if a file named _IGNORE_FILE in one of the passed-in path's parent
347 directories contains a wildcard matching the path.
348 """
349 # Skip ignore files.
350 if os.path.basename(path) == _IGNORE_FILE:
351 return True
352
353 path = os.path.abspath(path)
354 base = os.getcwd()
355
356 prefix = os.path.dirname(path)
357 while prefix.startswith(base):
358 rel_path = path[len(prefix) + 1:]
359 for wildcard in _get_ignore_wildcards(prefix, cache):
360 if fnmatch.fnmatch(rel_path, wildcard):
361 return True
362 prefix = os.path.dirname(prefix)
363
364 return False
365
366
Mike Frysinger292b45d2014-11-25 01:17:10 -0500367def _get_affected_files(commit, include_deletes=False, relative=False,
368 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700369 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700370 """Returns list of file paths that were modified/added, excluding symlinks.
371
372 Args:
373 commit: The commit
374 include_deletes: If true, we'll include deleted files in the result
375 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500376 include_symlinks: If true, we'll include symlinks in the result
377 include_adds: If true, we'll include new files in the result
378 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700379 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700380
381 Returns:
382 A list of modified/added (and perhaps deleted) files
383 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500384 if not relative and full_details:
385 raise ValueError('full_details only supports relative paths currently')
386
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700387 if commit == PRE_SUBMIT:
388 return _run_command(['git', 'diff-index', '--cached',
389 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500390
391 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400392 # {<commit>: {<path1>: <content>, <path2>: <content>}}
393 cache = CACHE.get_subcache('get_affected_files')
394 if path not in cache:
395 cache[path] = git.RawDiff(path, '%s^!' % commit)
396 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500399 if not include_symlinks:
400 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500401
402 if not include_deletes:
403 files = [x for x in files if x.status != 'D']
404
Mike Frysinger292b45d2014-11-25 01:17:10 -0500405 if not include_adds:
406 files = [x for x in files if x.status != 'A']
407
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700408 if use_ignore_files:
409 cache = {}
410 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
411 files = [x for x in files if not is_ignored(x)]
412
Mike Frysinger292b45d2014-11-25 01:17:10 -0500413 if full_details:
414 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500415 return files
416 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500417 # Caller only cares about filenames.
418 files = [x.dst_file if x.dst_file else x.src_file for x in files]
419 if relative:
420 return files
421 else:
422 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700423
424
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700425def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700426 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400427 cmd = ['git', 'log', '--no-merges', '--format=%H',
428 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700429 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700430
Ryan Cui1562fb82011-05-09 11:01:31 -0700431
Ryan Cuiec4d6332011-05-02 14:15:25 -0700432def _get_commit_desc(commit):
433 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700434 if commit == PRE_SUBMIT:
435 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400436
437 # {<commit>: <content>}
438 cache = CACHE.get_subcache('get_commit_desc')
439 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500440 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400441 commit + '^!'])
442 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700443
444
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800445def _check_lines_in_diff(commit, files, check_callable, error_description):
446 """Checks given file for errors via the given check.
447
448 This is a convenience function for common per-line checks. It goes through all
449 files and returns a HookFailure with the error description listing all the
450 failures.
451
452 Args:
453 commit: The commit we're working on.
454 files: The files to check.
455 check_callable: A callable that takes a line and returns True if this line
456 _fails_ the check.
457 error_description: A string describing the error.
458 """
459 errors = []
460 for afile in files:
461 for line_num, line in _get_file_diff(afile, commit):
462 if check_callable(line):
463 errors.append('%s, line %s' % (afile, line_num))
464 if errors:
465 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400466 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800467
468
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900469def _parse_common_inclusion_options(options):
470 """Parses common hook options for including/excluding files.
471
472 Args:
473 options: Option string list.
474
475 Returns:
476 (included, excluded) where each one is a list of regex strings.
477 """
478 parser = argparse.ArgumentParser()
479 parser.add_argument('--exclude_regex', action='append')
480 parser.add_argument('--include_regex', action='append')
481 opts = parser.parse_args(options)
482 included = opts.include_regex or []
483 excluded = opts.exclude_regex or []
484 return included, excluded
485
486
Ryan Cuiec4d6332011-05-02 14:15:25 -0700487# Common Hooks
488
Ryan Cui1562fb82011-05-09 11:01:31 -0700489
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900490def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500491 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900492 LONG_LINE_OK_PATHS = [
493 # Go has no line length limit.
494 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400495 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900496 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500497
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900498 DEFAULT_MAX_LENGTHS = [
499 # Java's line length limit is 100 chars.
500 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
501 (r'.*\.java$', 100),
502 ]
503
Ryan Cuiec4d6332011-05-02 14:15:25 -0700504 MAX_LEN = 80
505
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900506 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700507 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900508 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900509 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700510
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900511 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700512 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700513 skip_regexps = (
514 r'https?://',
515 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
516 )
517
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900518 max_len = MAX_LEN
519
520 for expr, length in DEFAULT_MAX_LENGTHS:
521 if re.search(expr, afile):
522 max_len = length
523 break
524
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700525 if os.path.basename(afile).startswith('OWNERS'):
526 # File paths can get long, and there's no way to break them up into
527 # multiple lines.
528 skip_regexps += (
529 r'^include\b',
530 r'file:',
531 )
532
533 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700534 for line_num, line in _get_file_diff(afile, commit):
535 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900536 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800537 continue
538
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900539 errors.append('%s, line %s, %s chars, over %s chars' %
540 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800541 if len(errors) == 5: # Just show the first 5 errors.
542 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700543
544 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900545 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700546 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400547 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700548
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900550def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700551 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900552 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700553 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900554 included + COMMON_INCLUDED_PATHS,
555 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800556 return _check_lines_in_diff(commit, files,
557 lambda line: line.rstrip() != line,
558 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700559
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700562 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400563 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
564 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700565 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400566 r'.*\.ebuild$',
567 r'.*\.eclass$',
568 r'.*\.go$',
569 r'.*/[M|m]akefile$',
570 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 ]
572
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900575 included + COMMON_INCLUDED_PATHS,
576 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800577 return _check_lines_in_diff(commit, files,
578 lambda line: '\t' in line,
579 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800581
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900582def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800583 """Checks that indents use tabs only."""
584 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400585 r'.*\.ebuild$',
586 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800587 ]
588 LEADING_SPACE_RE = re.compile('[\t]* ')
589
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900590 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800591 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900592 included + TABS_REQUIRED_PATHS,
593 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 return _check_lines_in_diff(
595 commit, files,
596 lambda line: LEADING_SPACE_RE.match(line) is not None,
597 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700598
Ryan Cuiec4d6332011-05-02 14:15:25 -0700599
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700600def _check_gofmt(_project, commit):
601 """Checks that Go files are formatted with gofmt."""
602 errors = []
603 files = _filter_files(_get_affected_files(commit, relative=True),
604 [r'\.go$'])
605
606 for gofile in files:
607 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400608 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500609 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700610 if output:
611 errors.append(gofile)
612 if errors:
613 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400614 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700615
616
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600617def _check_rustfmt(_project, commit):
618 """Checks that Rust files are formatted with rustfmt."""
619 errors = []
620 files = _filter_files(_get_affected_files(commit, relative=True),
621 [r'\.rs$'])
622
623 for rustfile in files:
624 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400625 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500626 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600627 if output != contents:
628 errors.append(rustfile)
629 if errors:
630 return HookFailure('Files not formatted with rustfmt: '
631 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400632 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600633
634
Mike Frysingerae409522014-02-01 03:16:11 -0500635def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700636 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500637 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
David McMahon8f6553e2011-06-10 15:46:36 -0700638 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700639
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700640 if not re.search(TEST_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500641 msg = ('Changelist description needs TEST field (after first line)\n%s' %
642 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700643 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400644 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700645
Ryan Cuiec4d6332011-05-02 14:15:25 -0700646
Mike Frysingerae409522014-02-01 03:16:11 -0500647def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600648 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700649 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600650 msg = 'Changelist has invalid Cq-Depend target.'
651 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700652 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700653 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700654 except ValueError as ex:
655 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700656 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500657 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700658 paragraphs = desc.split('\n\n')
659 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500660 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
661 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700662 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500663
664 # We no longer support CQ-DEPEND= lines.
665 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
666 return HookFailure(
667 'CQ-DEPEND= is no longer supported. Please see:\n'
668 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
669 'contributing.md#CQ-DEPEND')
670
Mike Frysinger8cf80812019-09-16 23:49:29 -0400671 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700672
673
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800674def _check_change_is_contribution(_project, commit):
675 """Check that the change is a contribution."""
676 NO_CONTRIB = 'not a contribution'
677 if NO_CONTRIB in _get_commit_desc(commit).lower():
678 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
679 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
680 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400681 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800682
683
Alex Deymo643ac4c2015-09-03 10:40:50 -0700684def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700685 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500686 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
687
David James5c0073d2013-04-03 08:48:52 -0700688 OLD_BUG_RE = r'\nBUG=.*chromium-os'
689 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
690 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
691 'the chromium tracker in your BUG= line now.')
692 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700693
Alex Deymo643ac4c2015-09-03 10:40:50 -0700694 # Android internal and external projects use "Bug: " to track bugs in
695 # buganizer.
696 BUG_COLON_REMOTES = (
697 'aosp',
698 'goog',
699 )
700 if project.remote in BUG_COLON_REMOTES:
701 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
702 if not re.search(BUG_RE, _get_commit_desc(commit)):
703 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500704 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700705 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500706 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700707 return HookFailure(msg)
708 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400709 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700710 if not re.search(BUG_RE, _get_commit_desc(commit)):
711 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500712 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700713 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700714 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500715 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700716 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700717
Mike Frysinger8cf80812019-09-16 23:49:29 -0400718 return None
719
Ryan Cuiec4d6332011-05-02 14:15:25 -0700720
Jack Neus8edbf642019-07-10 16:08:31 -0600721def _check_change_no_include_oem(project, commit):
722 """Check that the change does not reference OEMs."""
723 ALLOWLIST = {
724 'chromiumos/platform/ec',
725 # Used by unit tests.
726 'project',
727 }
728 if project.name not in ALLOWLIST:
729 return None
730
Mike Frysingerbb34a222019-07-31 14:40:46 -0400731 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600732 'Reviewed-on',
733 'Reviewed-by',
734 'Signed-off-by',
735 'Commit-Ready',
736 'Tested-by',
737 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600738 'Acked-by',
739 'Modified-by',
740 'CC',
741 'Suggested-by',
742 'Reported-by',
743 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700744 'Cq-Cl-Tag',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400745 }
Jack Neus8edbf642019-07-10 16:08:31 -0600746
747 # Ignore tags, which could reasonably contain OEM names
748 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600749 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400750 x for x in _get_commit_desc(commit).splitlines()
751 if ':' not in x or x.split(':', 1)[0] not in TAGS)
752
Jack Neus8edbf642019-07-10 16:08:31 -0600753 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
754
755 # Exercise caution when expanding these lists. Adding a name
756 # could indicate a new relationship with a company!
757 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
758 ODMS = [
759 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
760 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
761 ]
762
763 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
764 # Construct regex
765 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
766 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400767 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600768 # If there's a match, throw an error.
769 error_msg = ('Changelist description contains the name of an'
770 ' %s: "%s".' % (name_type, '","'.join(matches)))
771 return HookFailure(error_msg)
772
Mike Frysinger8cf80812019-09-16 23:49:29 -0400773 return None
774
Jack Neus8edbf642019-07-10 16:08:31 -0600775
Mike Frysinger292b45d2014-11-25 01:17:10 -0500776def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700777 """Check that we're not missing a revbump of an ebuild in the given commit.
778
779 If the given commit touches files in a directory that has ebuilds somewhere
780 up the directory hierarchy, it's very likely that we need an ebuild revbump
781 in order for those changes to take effect.
782
783 It's not totally trivial to detect a revbump, so at least detect that an
784 ebuild with a revision number in it was touched. This should handle the
785 common case where we use a symlink to do the revbump.
786
787 TODO: it would be nice to enhance this hook to:
788 * Handle cases where people revbump with a slightly different syntax. I see
789 one ebuild (puppy) that revbumps with _pN. This is a false positive.
790 * Catches cases where people aren't using symlinks for revbumps. If they
791 edit a revisioned file directly (and are expected to rename it for revbump)
792 we'll miss that. Perhaps we could detect that the file touched is a
793 symlink?
794
795 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
796 still better off than without this check.
797
798 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700799 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700800 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500801 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700802
803 Returns:
804 A HookFailure or None.
805 """
Mike Frysinger011af942014-01-17 16:12:22 -0500806 # If this is the portage-stable overlay, then ignore the check. It's rare
807 # that we're doing anything other than importing files from upstream, so
808 # forcing a rev bump makes no sense.
809 whitelist = (
810 'chromiumos/overlays/portage-stable',
811 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700812 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500813 return None
814
Mike Frysinger292b45d2014-11-25 01:17:10 -0500815 def FinalName(obj):
816 # If the file is being deleted, then the dst_file is not set.
817 if obj.dst_file is None:
818 return obj.src_file
819 else:
820 return obj.dst_file
821
822 affected_path_objs = _get_affected_files(
823 commit, include_deletes=True, include_symlinks=True, relative=True,
824 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700825
826 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500827 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500828 affected_path_objs = [x for x in affected_path_objs
829 if os.path.basename(FinalName(x)) not in whitelist]
830 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700831 return None
832
833 # If we've touched any file named with a -rN.ebuild then we'll say we're
834 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500835 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
836 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700837 if touched_revved_ebuild:
838 return None
839
Mike Frysinger292b45d2014-11-25 01:17:10 -0500840 # If we're creating new ebuilds from scratch, then we don't need an uprev.
841 # Find all the dirs that new ebuilds and ignore their files/.
842 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
843 if FinalName(x).endswith('.ebuild') and x.status == 'A']
844 affected_path_objs = [obj for obj in affected_path_objs
845 if not any(FinalName(obj).startswith(x)
846 for x in ebuild_dirs)]
847 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400848 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500849
Doug Anderson42b8a052013-06-26 10:45:36 -0700850 # We want to examine the current contents of all directories that are parents
851 # of files that were touched (up to the top of the project).
852 #
853 # ...note: we use the current directory contents even though it may have
854 # changed since the commit we're looking at. This is just a heuristic after
855 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500856 if project_top is None:
857 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700858 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500859 for obj in affected_path_objs:
860 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700861 while os.path.exists(path) and not os.path.samefile(path, project_top):
862 dirs_to_check.add(path)
863 path = os.path.dirname(path)
864
865 # Look through each directory. If it's got an ebuild in it then we'll
866 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800867 affected_paths = set(os.path.join(project_top, FinalName(x))
868 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700869 for dir_path in dirs_to_check:
870 contents = os.listdir(dir_path)
871 ebuilds = [os.path.join(dir_path, path)
872 for path in contents if path.endswith('.ebuild')]
873 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
874
C Shapiroae157ae2017-09-18 16:24:03 -0600875 affected_paths_under_9999_ebuilds = set()
876 for affected_path in affected_paths:
877 for ebuild_9999 in ebuilds_9999:
878 ebuild_dir = os.path.dirname(ebuild_9999)
879 if affected_path.startswith(ebuild_dir):
880 affected_paths_under_9999_ebuilds.add(affected_path)
881
882 # If every file changed exists under a 9999 ebuild, then skip
883 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
884 continue
885
Doug Anderson42b8a052013-06-26 10:45:36 -0700886 # If the -9999.ebuild file was touched the bot will uprev for us.
887 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500888 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700889 continue
890
891 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500892 return HookFailure('Changelist probably needs a revbump of an ebuild, '
893 'or a -r1.ebuild symlink if this is a new ebuild:\n'
894 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700895
896 return None
897
898
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500899def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500900 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500901
902 We want to get away from older EAPI's as it makes life confusing and they
903 have less builtin error checking.
904
905 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700906 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500907 commit: The commit to look at
908
909 Returns:
910 A HookFailure or None.
911 """
912 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500913 # that we're doing anything other than importing files from upstream, and
914 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500915 whitelist = (
916 'chromiumos/overlays/portage-stable',
917 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700918 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500919 return None
920
Mike Frysinger948284a2018-02-01 15:22:56 -0500921 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500922
923 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
924
925 ebuilds_re = [r'\.ebuild$']
926 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
927 ebuilds_re)
928 bad_ebuilds = []
929
930 for ebuild in ebuilds:
931 # If the ebuild does not specify an EAPI, it defaults to 0.
932 eapi = '0'
933
934 lines = _get_file_content(ebuild, commit).splitlines()
935 if len(lines) == 1:
936 # This is most likely a symlink, so skip it entirely.
937 continue
938
939 for line in lines:
940 m = get_eapi.match(line)
941 if m:
942 # Once we hit the first EAPI line in this ebuild, stop processing.
943 # The spec requires that there only be one and it be first, so
944 # checking all possible values is pointless. We also assume that
945 # it's "the" EAPI line and not something in the middle of a heredoc.
946 eapi = m.group(1)
947 break
948
949 if eapi in BAD_EAPIS:
950 bad_ebuilds.append((ebuild, eapi))
951
952 if bad_ebuilds:
953 # pylint: disable=C0301
954 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
955 # pylint: enable=C0301
956 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500957 'These ebuilds are using old EAPIs. If these are imported from\n'
958 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500959 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500960 '\t%s\n'
961 'See this guide for more details:\n%s\n' %
962 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
963
Mike Frysinger8cf80812019-09-16 23:49:29 -0400964 return None
965
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500966
Mike Frysinger89bdb852014-02-01 05:26:26 -0500967def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500968 """Make sure we use the new style KEYWORDS when possible in ebuilds.
969
970 If an ebuild generally does not care about the arch it is running on, then
971 ebuilds should flag it with one of:
972 KEYWORDS="*" # A stable ebuild.
973 KEYWORDS="~*" # An unstable ebuild.
974 KEYWORDS="-* ..." # Is known to only work on specific arches.
975
976 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700977 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500978 commit: The commit to look at
979
980 Returns:
981 A HookFailure or None.
982 """
983 WHITELIST = set(('*', '-*', '~*'))
984
985 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
986
Mike Frysinger89bdb852014-02-01 05:26:26 -0500987 ebuilds_re = [r'\.ebuild$']
988 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
989 ebuilds_re)
990
Mike Frysinger8d42d742014-09-22 15:50:21 -0400991 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500992 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400993 # We get the full content rather than a diff as the latter does not work
994 # on new files (like when adding new ebuilds).
995 lines = _get_file_content(ebuild, commit).splitlines()
996 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500997 m = get_keywords.match(line)
998 if m:
999 keywords = set(m.group(1).split())
1000 if not keywords or WHITELIST - keywords != WHITELIST:
1001 continue
1002
Mike Frysinger8d42d742014-09-22 15:50:21 -04001003 bad_ebuilds.append(ebuild)
1004
1005 if bad_ebuilds:
1006 return HookFailure(
1007 '%s\n'
1008 'Please update KEYWORDS to use a glob:\n'
1009 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1010 ' KEYWORDS="*"\n'
1011 'If the ebuild should be marked unstable (normal for '
1012 'cros-workon / 9999 ebuilds):\n'
1013 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001014 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001015 'then use -* like so:\n'
1016 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001017
Mike Frysinger8cf80812019-09-16 23:49:29 -04001018 return None
1019
Mike Frysingerc51ece72014-01-17 16:23:40 -05001020
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001021def _check_ebuild_licenses(_project, commit):
1022 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001023 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001024 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1025
1026 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001027 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001028
1029 for ebuild in touched_ebuilds:
1030 # Skip virutal packages.
1031 if ebuild.split('/')[-3] == 'virtual':
1032 continue
1033
Alex Kleinb5953522018-08-03 11:44:21 -06001034 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1035 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1036
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001037 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001038 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001039 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1040 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001041 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001042 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001043
1044 # Also ignore licenses ending with '?'
1045 for license_type in [x for x in license_types
1046 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1047 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001048 licenses_lib.Licensing.FindLicenseType(license_type,
1049 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001050 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001051 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001052
Mike Frysinger8cf80812019-09-16 23:49:29 -04001053 return None
1054
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001055
Mike Frysingercd363c82014-02-01 05:20:18 -05001056def _check_ebuild_virtual_pv(project, commit):
1057 """Enforce the virtual PV policies."""
1058 # If this is the portage-stable overlay, then ignore the check.
1059 # We want to import virtuals as-is from upstream Gentoo.
1060 whitelist = (
1061 'chromiumos/overlays/portage-stable',
1062 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001063 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001064 return None
1065
1066 # We assume the repo name is the same as the dir name on disk.
1067 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001068 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001069
1070 is_variant = lambda x: x.startswith('overlay-variant-')
1071 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001072 is_baseboard = lambda x: x.startswith('baseboard-')
1073 is_chipset = lambda x: x.startswith('chipset-')
1074 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001075 is_private = lambda x: x.endswith('-private')
1076
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001077 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1078 is_baseboard(x) or is_project(x))
1079
Mike Frysingercd363c82014-02-01 05:20:18 -05001080 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1081
1082 ebuilds_re = [r'\.ebuild$']
1083 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1084 ebuilds_re)
1085 bad_ebuilds = []
1086
1087 for ebuild in ebuilds:
1088 m = get_pv.match(ebuild)
1089 if m:
1090 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001091 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001092 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001093
1094 pv = m.group(3).split('-', 1)[0]
1095
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001096 # Virtual versions >= 4 are special cases used above the standard
1097 # versioning structure, e.g. if one has a board inheriting a board.
1098 if float(pv) >= 4:
1099 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001100 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001101 if is_private(overlay):
1102 want_pv = '3.5' if is_variant(overlay) else '3'
1103 elif is_board(overlay):
1104 want_pv = '2.5' if is_variant(overlay) else '2'
1105 elif is_baseboard(overlay):
1106 want_pv = '1.9'
1107 elif is_chipset(overlay):
1108 want_pv = '1.8'
1109 elif is_project(overlay):
1110 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001111 else:
1112 want_pv = '1'
1113
1114 if pv != want_pv:
1115 bad_ebuilds.append((ebuild, pv, want_pv))
1116
1117 if bad_ebuilds:
1118 # pylint: disable=C0301
1119 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1120 # pylint: enable=C0301
1121 return HookFailure(
1122 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1123 '\t%s\n'
1124 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1125 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1126 'page for more details:\n%s\n' %
1127 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1128 for x in bad_ebuilds]), url))
1129
Mike Frysinger8cf80812019-09-16 23:49:29 -04001130 return None
1131
Mike Frysingercd363c82014-02-01 05:20:18 -05001132
Daniel Erat9d203ff2015-02-17 10:12:21 -07001133def _check_portage_make_use_var(_project, commit):
1134 """Verify that $USE is set correctly in make.conf and make.defaults."""
1135 files = _filter_files(_get_affected_files(commit, relative=True),
1136 [r'(^|/)make.(conf|defaults)$'])
1137
1138 errors = []
1139 for path in files:
1140 basename = os.path.basename(path)
1141
1142 # Has a USE= line already been encountered in this file?
1143 saw_use = False
1144
1145 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1146 if not line.startswith('USE='):
1147 continue
1148
1149 preserves_use = '${USE}' in line or '$USE' in line
1150
1151 if (basename == 'make.conf' or
1152 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1153 errors.append('%s:%d: missing ${USE}' % (path, i))
1154 elif basename == 'make.defaults' and not saw_use and preserves_use:
1155 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1156 (path, i))
1157
1158 saw_use = True
1159
1160 if errors:
1161 return HookFailure(
1162 'One or more Portage make files appear to set USE incorrectly.\n'
1163 '\n'
1164 'All USE assignments in make.conf and all assignments after the\n'
1165 'initial declaration in make.defaults should contain "${USE}" to\n'
1166 'preserve previously-set flags.\n'
1167 '\n'
1168 'The initial USE declaration in make.defaults should not contain\n'
1169 '"${USE}".\n',
1170 errors)
1171
Mike Frysinger8cf80812019-09-16 23:49:29 -04001172 return None
1173
Daniel Erat9d203ff2015-02-17 10:12:21 -07001174
Mike Frysingerae409522014-02-01 03:16:11 -05001175def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001176 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001177 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001178 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001179 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001180 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001181 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001182
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001183 # S-o-b tags always allowed to follow Change-ID.
LaMont Jones237f3ef2020-01-22 10:40:52 -07001184 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001185
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001186 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001187 cherry_pick_marker = 'cherry picked from commit'
1188
1189 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001190 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001191 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1192 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001193 end = end[:-1]
1194
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001195 # Note that descriptions could have multiple cherry pick markers.
1196 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001197
1198 if [x for x in end if not re.search(tag_search, x)]:
1199 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1200 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001201
Mike Frysinger8cf80812019-09-16 23:49:29 -04001202 return None
1203
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001204
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001205def _check_commit_message_style(_project, commit):
1206 """Verify that the commit message matches our style.
1207
1208 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1209 commit hooks.
1210 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001211 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001212
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001213 desc = _get_commit_desc(commit)
1214
1215 # The first line should be by itself.
1216 lines = desc.splitlines()
1217 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001218 return HookFailure('The second line of the commit message must be blank.'
1219 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001220
1221 # The first line should be one sentence.
1222 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001223 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1224 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001225
1226 # The first line cannot be too long.
1227 MAX_FIRST_LINE_LEN = 100
1228 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001229 return HookFailure('The first line must be less than %i chars.\n%s' %
1230 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001231
Mike Frysinger8cf80812019-09-16 23:49:29 -04001232 return None
1233
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001234
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001235def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001236 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001237
Mike Frysinger98638102014-08-28 00:15:08 -04001238 Should be following the spec:
1239 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1240 """
1241 # For older years, be a bit more flexible as our policy says leave them be.
1242 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001243 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1244 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001245 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001246 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001247 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001248 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001249 )
1250 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1251
1252 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001253 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001254 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001255 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001256 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001257 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001258
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001259 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001260
Mike Frysinger98638102014-08-28 00:15:08 -04001261 bad_files = []
1262 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001263 bad_year_files = []
1264
Ken Turnerd07564b2018-02-08 17:57:59 +11001265 files = _filter_files(
1266 _get_affected_files(commit, relative=True),
1267 included + COMMON_INCLUDED_PATHS,
1268 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001269 existing_files = set(_get_affected_files(commit, relative=True,
1270 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001271
Keigo Oka7e880ac2019-07-03 15:03:43 +09001272 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001273 for f in files:
1274 contents = _get_file_content(f, commit)
1275 if not contents:
1276 # Ignore empty files.
1277 continue
1278
Keigo Oka7e880ac2019-07-03 15:03:43 +09001279 m = license_re.search(contents)
1280 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001281 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001282 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001283 bad_copyright_files.append(f)
1284
Keigo Oka7e880ac2019-07-03 15:03:43 +09001285 if m and f not in existing_files:
1286 year = m.group(1)
1287 if year != current_year:
1288 bad_year_files.append(f)
1289
1290 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001291 if bad_files:
1292 msg = '%s:\n%s\n%s' % (
1293 'License must match', license_re.pattern,
1294 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001295 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001296 if bad_copyright_files:
1297 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001298 errors.append(HookFailure(msg, bad_copyright_files))
1299 if bad_year_files:
1300 msg = 'Use current year (%s) in copyright headers in new files:' % (
1301 current_year)
1302 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001303
Keigo Oka7e880ac2019-07-03 15:03:43 +09001304 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001305
Mike Frysinger8cf80812019-09-16 23:49:29 -04001306
Amin Hassani391efa92018-01-26 17:58:05 -08001307def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001308 """Verifies the AOSP license/copyright header.
1309
1310 AOSP uses the Apache2 License:
1311 https://source.android.com/source/licenses.html
1312 """
1313 LICENSE_HEADER = (
1314 r"""^[#/\*]*
1315[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1316[#/\*]* ?
1317[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1318[#/\*]* ?you may not use this file except in compliance with the License\.
1319[#/\*]* ?You may obtain a copy of the License at
1320[#/\*]* ?
1321[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1322[#/\*]* ?
1323[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1324[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1325[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1326 r"""implied\.
1327[#/\*]* ?See the License for the specific language governing permissions and
1328[#/\*]* ?limitations under the License\.
1329[#/\*]*$
1330"""
1331 )
1332 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1333
Amin Hassani391efa92018-01-26 17:58:05 -08001334 included, excluded = _parse_common_inclusion_options(options)
1335
Ken Turnerd07564b2018-02-08 17:57:59 +11001336 files = _filter_files(
1337 _get_affected_files(commit, relative=True),
1338 included + COMMON_INCLUDED_PATHS,
1339 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001340
1341 bad_files = []
1342 for f in files:
1343 contents = _get_file_content(f, commit)
1344 if not contents:
1345 # Ignore empty files.
1346 continue
1347
1348 if not license_re.search(contents):
1349 bad_files.append(f)
1350
1351 if bad_files:
1352 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1353 license_re.pattern)
1354 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001355 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001356
1357
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001358def _check_layout_conf(_project, commit):
1359 """Verifies the metadata/layout.conf file."""
1360 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001361 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001362 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001363 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001364
Mike Frysinger94a670c2014-09-19 12:46:26 -04001365 # Handle multiple overlays in a single commit (like the public tree).
1366 for f in _get_affected_files(commit, relative=True):
1367 if f.endswith(repo_name):
1368 repo_names.append(f)
1369 elif f.endswith(layout_path):
1370 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001371
1372 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001373 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001374 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001375 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001376
Mike Frysinger94a670c2014-09-19 12:46:26 -04001377 # Gather all the errors in one pass so we show one full message.
1378 all_errors = {}
1379 for layout_path in layout_paths:
1380 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001381
Mike Frysinger94a670c2014-09-19 12:46:26 -04001382 # Make sure the config file is sorted.
1383 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1384 if x and x[0] != '#']
1385 if sorted(data) != data:
1386 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001387
Mike Frysinger94a670c2014-09-19 12:46:26 -04001388 # Require people to set specific values all the time.
1389 settings = (
1390 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001391 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001392 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001393 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1394 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001395 )
1396 for reason, line in settings:
1397 if line not in data:
1398 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001399
Mike Frysinger94a670c2014-09-19 12:46:26 -04001400 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001401 if 'use-manifests = strict' not in data:
1402 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001403
Mike Frysinger94a670c2014-09-19 12:46:26 -04001404 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001405 for line in data:
1406 if line.startswith('repo-name = '):
1407 break
1408 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001409 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001410
Mike Frysinger94a670c2014-09-19 12:46:26 -04001411 # Summarize all the errors we saw (if any).
1412 lines = ''
1413 for layout_path, errors in all_errors.items():
1414 if errors:
1415 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1416 if lines:
1417 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1418 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001419
Mike Frysinger8cf80812019-09-16 23:49:29 -04001420 return None
1421
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001422
Keigo Oka4a09bd92019-05-07 14:01:00 +09001423def _check_no_new_gyp(_project, commit):
1424 """Verifies no project starts to use GYP."""
1425 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001426 'chromeos/ap',
1427 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001428 'chromeos/ap/security',
1429 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001430 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001431 'chromeos/platform/drivefs-google3',
1432 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001433 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001434 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001435 'weave/libweave',
1436 ]
1437 if _project.name in whitelist:
1438 return None
1439
1440 gypfiles = _filter_files(
1441 _get_affected_files(commit, include_symlinks=True, relative=True),
1442 [r'\.gyp$'])
1443
1444 if gypfiles:
1445 return HookFailure('GYP is deprecated and not allowed in a new project:',
1446 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001447 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001448
1449
Ryan Cuiec4d6332011-05-02 14:15:25 -07001450# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001451
Ryan Cui1562fb82011-05-09 11:01:31 -07001452
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001453def _check_clang_format(_project, commit, options=()):
1454 """Runs clang-format on the given project"""
1455 hooks_dir = _get_hooks_dir()
1456 options = list(options)
1457 if commit == PRE_SUBMIT:
1458 options.append('--commit=HEAD')
1459 else:
1460 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001461 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001462 cmd_result = cros_build_lib.run(cmd,
1463 print_cmd=False,
1464 stdout=True,
1465 encoding='utf-8',
1466 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001467 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001468 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001469 if cmd_result.returncode:
1470 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001471 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001472 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001473
1474
Mike Frysingerae409522014-02-01 03:16:11 -05001475def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001476 """Runs checkpatch.pl on the given project"""
1477 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001478 options = list(options)
1479 if commit == PRE_SUBMIT:
1480 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1481 # this case.
1482 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001483 # Always ignore the check for the MAINTAINERS file. We do not track that
1484 # information on that file in our source trees, so let's suppress the
1485 # warning.
1486 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001487 # Do not complain about the Change-Id: fields, since we use Gerrit.
1488 # Upstream does not want those lines (since they do not use Gerrit), but
1489 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001490 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001491 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001492 cmd_result = cros_build_lib.run(
1493 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001494 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001495 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001496 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001497 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001498 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001499
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001500
Brian Norris23c62e92018-11-14 12:25:51 -08001501def _run_kerneldoc(_project, commit, options=()):
1502 """Runs kernel-doc validator on the given project"""
1503 included, excluded = _parse_common_inclusion_options(options)
1504 files = _filter_files(_get_affected_files(commit, relative=True),
1505 included, excluded)
1506 if files:
1507 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001508 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001509 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001510 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001511 return HookFailure('kernel-doc errors/warnings:',
1512 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001513 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001514
1515
Mike Frysingerae409522014-02-01 03:16:11 -05001516def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001517 """Makes sure kernel config changes are not mixed with code changes"""
1518 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001519 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001520 return HookFailure('Changes to chromeos/config/ and regular files must '
1521 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001522 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001523
Mike Frysingerae409522014-02-01 03:16:11 -05001524
1525def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001526 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001527 ret = []
1528
1529 files = _filter_files(_get_affected_files(commit, relative=True),
1530 [r'.*\.json$'])
1531 for f in files:
1532 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001533 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001534 json.loads(data)
1535 except Exception as e:
1536 ret.append('%s: Invalid JSON: %s' % (f, e))
1537
1538 if ret:
1539 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001540 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001541
1542
Mike Frysingerae409522014-02-01 03:16:11 -05001543def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001544 """Make sure Manifest files only have comments & DIST lines."""
1545 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001546
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001547 manifests = _filter_files(_get_affected_files(commit, relative=True),
1548 [r'.*/Manifest$'])
1549 for path in manifests:
1550 data = _get_file_content(path, commit)
1551
1552 # Disallow blank files.
1553 if not data.strip():
1554 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001555 continue
1556
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001557 # Make sure the last newline isn't omitted.
1558 if data[-1] != '\n':
1559 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001560
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001561 # Do not allow leading or trailing blank lines.
1562 lines = data.splitlines()
1563 if not lines[0]:
1564 ret.append('%s: delete leading blank lines' % (path,))
1565 if not lines[-1]:
1566 ret.append('%s: delete trailing blank lines' % (path,))
1567
1568 for line in lines:
1569 # Disallow leading/trailing whitespace.
1570 if line != line.strip():
1571 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1572
1573 # Allow blank lines & comments.
1574 line = line.split('#', 1)[0]
1575 if not line:
1576 continue
1577
1578 # All other linse should start with DIST.
1579 if not line.startswith('DIST '):
1580 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1581 break
1582
1583 if ret:
1584 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001585 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001586
1587
Mike Frysingerae409522014-02-01 03:16:11 -05001588def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001589 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001590 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001591 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001592 BRANCH_RE = r'\nBRANCH=\S+'
1593
1594 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1595 msg = ('Changelist description needs BRANCH field (after first line)\n'
1596 'E.g. BRANCH=none or BRANCH=link,snow')
1597 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001598 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001599
1600
Mike Frysinger45334bd2019-11-04 10:42:33 -05001601def _check_change_has_no_branch_field(_project, commit):
1602 """Verify 'BRANCH=' field does not exist in the commit message."""
1603 if commit == PRE_SUBMIT:
1604 return None
1605 BRANCH_RE = r'\nBRANCH=\S+'
1606
1607 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1608 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1609 return HookFailure(msg)
1610 return None
1611
1612
Mike Frysingerae409522014-02-01 03:16:11 -05001613def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001614 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001615 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001616 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001617 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1618
1619 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1620 msg = ('Changelist description needs Signed-off-by: field\n'
1621 'E.g. Signed-off-by: My Name <me@chromium.org>')
1622 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001623 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001624
1625
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001626def _check_change_has_no_signoff_field(_project, commit):
1627 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1628 if commit == PRE_SUBMIT:
1629 return None
1630 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1631
1632 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1633 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1634 return HookFailure(msg)
1635 return None
1636
1637
Jon Salz3ee59de2012-08-18 13:54:22 +08001638def _run_project_hook_script(script, project, commit):
1639 """Runs a project hook script.
1640
1641 The script is run with the following environment variables set:
1642 PRESUBMIT_PROJECT: The affected project
1643 PRESUBMIT_COMMIT: The affected commit
1644 PRESUBMIT_FILES: A newline-separated list of affected files
1645
1646 The script is considered to fail if the exit code is non-zero. It should
1647 write an error message to stdout.
1648 """
1649 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001650 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001651 env['PRESUBMIT_COMMIT'] = commit
1652
1653 # Put affected files in an environment variable
1654 files = _get_affected_files(commit)
1655 env['PRESUBMIT_FILES'] = '\n'.join(files)
1656
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001657 cmd_result = cros_build_lib.run(cmd=script,
1658 env=env,
1659 shell=True,
1660 print_cmd=False,
1661 input=os.devnull,
1662 stdout=True,
1663 encoding='utf-8',
1664 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001665 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001666 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001667 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001668 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001669 if stdout:
1670 stdout = re.sub('(?m)^', ' ', stdout)
1671 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001672 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001673 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001674 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001675
1676
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001677def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001678 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001679
Brian Norris77608e12018-04-06 10:38:43 -07001680 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001681 prefix = os.path.commonprefix(files)
1682 prefix = os.path.dirname(prefix)
1683
1684 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001685 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001686 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001687
1688 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001689
1690 # The common files may all be within a subdirectory of the main project
1691 # directory, so walk up the tree until we find an alias file.
1692 # _get_affected_files() should return relative paths, but check against '/' to
1693 # ensure that this loop terminates even if it receives an absolute path.
1694 while prefix and prefix != '/':
1695 alias_file = os.path.join(prefix, '.project_alias')
1696
1697 # If an alias exists, use it.
1698 if os.path.isfile(alias_file):
1699 project_name = osutils.ReadFile(alias_file).strip()
1700
1701 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001702
1703 if not _get_commit_desc(commit).startswith(project_name + ': '):
1704 return HookFailure('The commit title for changes affecting only %s'
1705 ' should start with \"%s: \"'
1706 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001707 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001708
1709
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001710def _check_filepath_chartype(_project, commit):
1711 """Checks that FilePath::CharType stuff is not used."""
1712
1713 FILEPATH_REGEXP = re.compile('|'.join(
1714 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001715 r'(?:base::)?FilePath::FromUTF8Unsafe',
1716 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001717 r'FILE_PATH_LITERAL']))
1718 files = _filter_files(_get_affected_files(commit, relative=True),
1719 [r'.*\.(cc|h)$'])
1720
1721 errors = []
1722 for afile in files:
1723 for line_num, line in _get_file_diff(afile, commit):
1724 m = re.search(FILEPATH_REGEXP, line)
1725 if m:
1726 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1727
1728 if errors:
1729 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1730 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001731 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001732
1733
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001734def _check_exec_files(_project, commit):
1735 """Make +x bits on files."""
1736 # List of files that should never be +x.
1737 NO_EXEC = (
1738 'ChangeLog*',
1739 'COPYING',
1740 'make.conf',
1741 'make.defaults',
1742 'Manifest',
1743 'OWNERS',
1744 'package.use',
1745 'package.keywords',
1746 'package.mask',
1747 'parent',
1748 'README',
1749 'TODO',
1750 '.gitignore',
1751 '*.[achly]',
1752 '*.[ch]xx',
1753 '*.boto',
1754 '*.cc',
1755 '*.cfg',
1756 '*.conf',
1757 '*.config',
1758 '*.cpp',
1759 '*.css',
1760 '*.ebuild',
1761 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001762 '*.gn',
1763 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001764 '*.gyp',
1765 '*.gypi',
1766 '*.htm',
1767 '*.html',
1768 '*.ini',
1769 '*.js',
1770 '*.json',
1771 '*.md',
1772 '*.mk',
1773 '*.patch',
1774 '*.policy',
1775 '*.proto',
1776 '*.raw',
1777 '*.rules',
1778 '*.service',
1779 '*.target',
1780 '*.txt',
1781 '*.xml',
1782 '*.yaml',
1783 )
1784
1785 def FinalName(obj):
1786 # If the file is being deleted, then the dst_file is not set.
1787 if obj.dst_file is None:
1788 return obj.src_file
1789 else:
1790 return obj.dst_file
1791
1792 bad_files = []
1793 files = _get_affected_files(commit, relative=True, full_details=True)
1794 for f in files:
1795 mode = int(f.dst_mode, 8)
1796 if not mode & 0o111:
1797 continue
1798 name = FinalName(f)
1799 for no_exec in NO_EXEC:
1800 if fnmatch.fnmatch(name, no_exec):
1801 bad_files.append(name)
1802 break
1803
1804 if bad_files:
1805 return HookFailure('These files should not be executable. '
1806 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001807 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001808
1809
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001810# Base
1811
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001812# A list of hooks which are not project specific and check patch description
1813# (as opposed to patch body).
1814_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001815 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001816 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001817 _check_change_has_test_field,
1818 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001819 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001820 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001821 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001822]
1823
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001824# A list of hooks that are not project-specific
1825_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001826 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001827 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001828 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001829 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001830 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001831 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001832 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001833 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001834 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001835 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001836 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001837 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001838 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001839 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001840 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001841 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001842]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001843
Ryan Cui1562fb82011-05-09 11:01:31 -07001844
Ryan Cui9b651632011-05-11 11:38:58 -07001845# A dictionary of project-specific hooks(callbacks), indexed by project name.
1846# dict[project] = [callback1, callback2]
1847_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001848 'chromiumos/third_party/kernel': [_kernel_configcheck],
1849 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001850}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001851
Ryan Cui1562fb82011-05-09 11:01:31 -07001852
Ryan Cui9b651632011-05-11 11:38:58 -07001853# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001854# that the flag controls (value).
1855_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001856 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001857 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001858 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001859 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001860 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001861 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001862 'cros_license_check': _check_cros_license,
1863 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001864 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001865 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001866 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001867 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001868 'bug_field_check': _check_change_has_bug_field,
1869 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001870 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001871 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001872 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001873 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001874}
1875
1876
Mike Frysinger3554bc92015-03-11 04:59:21 -04001877def _get_override_hooks(config):
1878 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001879
1880 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001881
1882 Args:
1883 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001884 """
1885 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001886 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001887 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001888 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001889
Mike Frysinger56e8de02019-07-31 14:40:14 -04001890 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001891 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001892
1893 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001894 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001895 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001896 if flag not in valid_keys:
1897 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1898 (flag, _CONFIG_FILE))
1899
Ryan Cui9b651632011-05-11 11:38:58 -07001900 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001901 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001902 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001903 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1904 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001905 if enabled:
1906 enable_flags.append(flag)
1907 else:
1908 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001909
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001910 # See if this hook has custom options.
1911 if enabled:
1912 try:
1913 options = config.get(SECTION_OPTIONS, flag)
1914 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001915 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001916 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001917 pass
1918
1919 enabled_hooks = set(hooks[x] for x in enable_flags)
1920 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001921
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001922 if _check_change_has_signoff_field not in enabled_hooks:
1923 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001924 if _check_change_has_branch_field not in enabled_hooks:
1925 enabled_hooks.add(_check_change_has_no_branch_field)
1926
Mike Frysinger3554bc92015-03-11 04:59:21 -04001927 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001928
1929
Jon Salz3ee59de2012-08-18 13:54:22 +08001930def _get_project_hook_scripts(config):
1931 """Returns a list of project-specific hook scripts.
1932
1933 Args:
1934 config: A ConfigParser for the project's config file.
1935 """
1936 SECTION = 'Hook Scripts'
1937 if not config.has_section(SECTION):
1938 return []
1939
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001940 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001941
1942
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001943def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001944 """Returns a list of hooks that need to be run for a project.
1945
1946 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001947
1948 Args:
1949 project: A string, name of the project.
1950 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001951 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001952 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001953 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001954 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001955 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001956 else:
1957 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001958
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001959 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001960 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001961 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001962 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001963
Mike Frysinger3554bc92015-03-11 04:59:21 -04001964 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001965 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1966
1967 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1968 # override, keep the override only. Note that the override may end up being
1969 # a functools.partial, in which case we need to extract the .func to compare
1970 # it to the common hooks.
1971 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1972 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1973
1974 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001975
1976 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001977 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1978 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001979
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001980 for name, script in _get_project_hook_scripts(config):
1981 func = functools.partial(_run_project_hook_script, script)
1982 func.__name__ = name
1983 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001984
Ryan Cui9b651632011-05-11 11:38:58 -07001985 return hooks
1986
1987
Alex Deymo643ac4c2015-09-03 10:40:50 -07001988def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001989 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001990 """For each project run its project specific hook from the hooks dictionary.
1991
1992 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001993 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001994 proj_dir: If non-None, this is the directory the project is in. If None,
1995 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001996 commit_list: A list of commits to run hooks against. If None or empty list
1997 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001998 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001999
2000 Returns:
2001 Boolean value of whether any errors were ecountered while running the hooks.
2002 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002003 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002004 proj_dirs = _run_command(
2005 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002006 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002007 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002008 print('Please specify a valid project.', file=sys.stderr)
2009 return True
2010 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002011 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002012 file=sys.stderr)
2013 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2014 return True
2015 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002016
Ryan Cuiec4d6332011-05-02 14:15:25 -07002017 pwd = os.getcwd()
2018 # hooks assume they are run from the root of the project
2019 os.chdir(proj_dir)
2020
Mike Frysingered1b95a2019-12-12 19:04:51 -05002021 color = terminal.Color()
2022
Alex Deymo643ac4c2015-09-03 10:40:50 -07002023 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2024 '--symbolic-full-name', '@{u}']).strip()
2025 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002026 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002027 file=sys.stderr)
2028 remote = None
2029 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002030 branch_items = remote_branch.split('/', 1)
2031 if len(branch_items) != 2:
2032 PrintErrorForProject(
2033 project_name,
2034 HookFailure(
2035 'Cannot get remote and branch name (%s)' % remote_branch))
2036 os.chdir(pwd)
2037 return True
2038 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002039
2040 project = Project(name=project_name, dir=proj_dir, remote=remote)
2041
Doug Anderson14749562013-06-26 13:38:29 -07002042 if not commit_list:
2043 try:
2044 commit_list = _get_commits()
2045 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002046 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002047 os.chdir(pwd)
2048 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002049
Alex Deymo643ac4c2015-09-03 10:40:50 -07002050 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002051 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002052 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002053 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002054 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002055 CACHE.clear()
2056
Mike Frysingered1b95a2019-12-12 19:04:51 -05002057 desc = _get_commit_desc(commit)
2058 print('[%s %i/%i %s] %s' %
2059 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2060 desc.splitlines()[0]))
2061
Mike Frysingerb99b3772019-08-17 14:19:44 -04002062 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002063 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2064 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2065 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002066 print(output, end='\r')
2067 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002068 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002069 print(' ' * len(output), end='\r')
2070 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002071 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002072 if not isinstance(hook_error, list):
2073 hook_error = [hook_error]
2074 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002075 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002076
Ryan Cuiec4d6332011-05-02 14:15:25 -07002077 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002078 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002079
Mike Frysingerae409522014-02-01 03:16:11 -05002080
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002081# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002082
Ryan Cui1562fb82011-05-09 11:01:31 -07002083
Mike Frysingerae409522014-02-01 03:16:11 -05002084def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002085 """Main function invoked directly by repo.
2086
2087 This function will exit directly upon error so that repo doesn't print some
2088 obscure error message.
2089
2090 Args:
2091 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002092 worktree_list: A list of directories. It should be the same length as
2093 project_list, so that each entry in project_list matches with a directory
2094 in worktree_list. If None, we will attempt to calculate the directories
2095 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002096 kwargs: Leave this here for forward-compatibility.
2097 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002098 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002099 found_error = False
David James2edd9002013-10-11 14:09:19 -07002100 if not worktree_list:
2101 worktree_list = [None] * len(project_list)
2102 for project, worktree in zip(project_list, worktree_list):
2103 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002104 found_error = True
2105
Mike Frysingered1b95a2019-12-12 19:04:51 -05002106 end_time = datetime.datetime.now()
2107 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002108 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002109 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002110 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002111 '<checkout_dir>/src/repohooks/README.md\n'
2112 "- To upload only current project, run 'repo upload .'" %
2113 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002114 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002115 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002116 else:
2117 msg = ('[%s] repohooks passed in %s' %
2118 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2119 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002120
Ryan Cui1562fb82011-05-09 11:01:31 -07002121
Doug Anderson44a644f2011-11-02 10:37:37 -07002122def _identify_project(path):
2123 """Identify the repo project associated with the given path.
2124
2125 Returns:
2126 A string indicating what project is associated with the path passed in or
2127 a blank string upon failure.
2128 """
2129 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002130 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002131
2132
Mike Frysinger55f85b52014-12-18 14:45:21 -05002133def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002134 """Run hooks directly (outside of the context of repo).
2135
Doug Anderson44a644f2011-11-02 10:37:37 -07002136 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002137 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002138
2139 Returns:
2140 0 if no pre-upload failures, 1 if failures.
2141
2142 Raises:
2143 BadInvocation: On some types of invocation errors.
2144 """
Mike Frysinger66142932014-12-18 14:55:57 -05002145 parser = commandline.ArgumentParser(description=__doc__)
2146 parser.add_argument('--dir', default=None,
2147 help='The directory that the project lives in. If not '
2148 'specified, use the git project root based on the cwd.')
2149 parser.add_argument('--project', default=None,
2150 help='The project repo path; this can affect how the '
2151 'hooks get run, since some hooks are project-specific. '
2152 'For chromite this is chromiumos/chromite. If not '
2153 'specified, the repo tool will be used to figure this '
2154 'out based on the dir.')
2155 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002156 help='Rerun hooks on old commits since some point '
2157 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002158 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002159 'or a SHA1, or just a number of commits to check (from 1 '
2160 'to 99). This option is mutually exclusive with '
2161 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002162 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002163 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002164 "This option should be used at the 'git commit' "
2165 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002166 'is mutually exclusive with --rerun-since.')
2167 parser.add_argument('commits', nargs='*',
2168 help='Check specific commits')
2169 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002170
Doug Anderson14749562013-06-26 13:38:29 -07002171 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002172 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002173 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002174 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002175
Vadim Bendebury75447b92018-01-10 12:06:01 -08002176 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2177 # This must be the number of commits to check. We don't expect the user
2178 # to want to check more than 99 commits.
2179 limit = '-n%s' % opts.rerun_since
2180 elif git.IsSHA1(opts.rerun_since, False):
2181 limit = '%s..' % opts.rerun_since
2182 else:
2183 # This better be a date.
2184 limit = '--since=%s' % opts.rerun_since
2185 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002186 all_commits = _run_command(cmd).splitlines()
2187 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2188
2189 # Eliminate chrome-bot commits but keep ordering the same...
2190 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002191 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002192
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002193 if opts.pre_submit:
2194 raise BadInvocation('rerun-since and pre-submit can not be '
2195 'used together')
2196 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002197 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002198 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002199 ' '.join(opts.commits))
2200 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002201
2202 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2203 # project from CWD
2204 if opts.dir is None:
2205 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002206 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002207 if not git_dir:
2208 raise BadInvocation('The current directory is not part of a git project.')
2209 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2210 elif not os.path.isdir(opts.dir):
2211 raise BadInvocation('Invalid dir: %s' % opts.dir)
2212 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2213 raise BadInvocation('Not a git directory: %s' % opts.dir)
2214
2215 # Identify the project if it wasn't specified; this _requires_ the repo
2216 # tool to be installed and for the project to be part of a repo checkout.
2217 if not opts.project:
2218 opts.project = _identify_project(opts.dir)
2219 if not opts.project:
2220 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2221
Doug Anderson14749562013-06-26 13:38:29 -07002222 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002223 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002224 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002225 if found_error:
2226 return 1
2227 return 0
2228
2229
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002230if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002231 sys.exit(direct_main(sys.argv[1:]))