blob: a2ab3328ba76d2ac481640a5446aadc3690d69c2 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Vadim Bendebury2b62d742014-06-22 13:14:51 -070054PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070055
Mike Frysingered9b2a02019-12-12 18:52:32 -050056
57# Link to commit message documentation for users.
58DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
59 '/contributing.md#commit-messages')
60
61
Ryan Cuiec4d6332011-05-02 14:15:25 -070062COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050063 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040064 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
65 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050066 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040067 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050068 # No extension at all, note that ALL CAPS files are black listed in
69 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040070 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
73 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
74 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070075]
76
Ryan Cui1562fb82011-05-09 11:01:31 -070077
Ryan Cuiec4d6332011-05-02 14:15:25 -070078COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070079 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040080 r'.*/Manifest$',
81 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070082
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'(^|.*/)overlay-.*/profiles/.*',
85 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040086
C Shapiro8f90e9b2017-06-28 09:54:50 -060087 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
89 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060090
Daniel Erate3ea3fc2015-02-13 15:27:52 -070091 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'.*\.min\.js',
93 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050094
95 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -070097
Mike Frysinger13650402019-07-31 14:31:46 -040098 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040099 r'.*_pb2\.py$',
100 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700101]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700102
Ken Turnerd07564b2018-02-08 17:57:59 +1100103LICENSE_EXCLUDED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'^(.*/)?OWNERS$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100105]
Ryan Cui1562fb82011-05-09 11:01:31 -0700106
Ryan Cui9b651632011-05-11 11:38:58 -0700107_CONFIG_FILE = 'PRESUBMIT.cfg'
108
109
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700110# File containing wildcards, one per line, matching files that should be
111# excluded from presubmit checks. Lines beginning with '#' are ignored.
112_IGNORE_FILE = '.presubmitignore'
113
Doug Anderson44a644f2011-11-02 10:37:37 -0700114# Exceptions
115
116
117class BadInvocation(Exception):
118 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700119
120
Ryan Cui1562fb82011-05-09 11:01:31 -0700121# General Helpers
122
Sean Paulba01d402011-05-05 11:36:23 -0400123
Mike Frysingerb2496652019-09-12 23:35:46 -0400124class Cache(object):
125 """General helper for caching git content."""
126
127 def __init__(self):
128 self._cache = {}
129
130 def get_subcache(self, scope):
131 return self._cache.setdefault(scope, {})
132
133 def clear(self):
134 self._cache.clear()
135
136CACHE = Cache()
137
138
Alex Deymo643ac4c2015-09-03 10:40:50 -0700139Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
140
141
Mike Frysinger526a5f82019-09-13 18:05:30 -0400142def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700143 """Executes the passed in command and returns raw stdout output.
144
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400145 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400146
Doug Anderson44a644f2011-11-02 10:37:37 -0700147 Args:
148 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400149 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700150
151 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700152 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700153 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400154 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400155 kwargs.setdefault('stdout', True)
156 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500157 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400158 # NB: We decode this directly rather than through kwargs as our tests rely
159 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400160 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700161
Ryan Cui1562fb82011-05-09 11:01:31 -0700162
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700163def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700164 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700165 if __name__ == '__main__':
166 # Works when file is run on its own (__file__ is defined)...
167 return os.path.abspath(os.path.dirname(__file__))
168 else:
169 # We need to do this when we're run through repo. Since repo executes
170 # us with execfile(), we don't get __file__ defined.
171 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
172 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700173
Ryan Cui1562fb82011-05-09 11:01:31 -0700174
Ryan Cuiec4d6332011-05-02 14:15:25 -0700175def _match_regex_list(subject, expressions):
176 """Try to match a list of regular expressions to a string.
177
178 Args:
179 subject: The string to match regexes on
180 expressions: A list of regular expressions to check for matches with.
181
182 Returns:
183 Whether the passed in subject matches any of the passed in regexes.
184 """
185 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500186 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700187 return True
188 return False
189
Ryan Cui1562fb82011-05-09 11:01:31 -0700190
Mike Frysingerae409522014-02-01 03:16:11 -0500191def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700192 """Filter out files based on the conditions passed in.
193
194 Args:
195 files: list of filepaths to filter
196 include_list: list of regex that when matched with a file path will cause it
197 to be added to the output list unless the file is also matched with a
198 regex in the exclude_list.
199 exclude_list: list of regex that when matched with a file will prevent it
200 from being added to the output list, even if it is also matched with a
201 regex in the include_list.
202
203 Returns:
204 A list of filepaths that contain files matched in the include_list and not
205 in the exclude_list.
206 """
207 filtered = []
208 for f in files:
209 if (_match_regex_list(f, include_list) and
210 not _match_regex_list(f, exclude_list)):
211 filtered.append(f)
212 return filtered
213
Ryan Cuiec4d6332011-05-02 14:15:25 -0700214
215# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700216
217
Ryan Cui4725d952011-05-05 15:41:19 -0700218def _get_upstream_branch():
219 """Returns the upstream tracking branch of the current branch.
220
221 Raises:
222 Error if there is no tracking branch
223 """
224 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
225 current_branch = current_branch.replace('refs/heads/', '')
226 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700227 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700228
229 cfg_option = 'branch.' + current_branch + '.%s'
230 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
231 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
232 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700233 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700234
235 return full_upstream.replace('heads', 'remotes/' + remote)
236
Ryan Cui1562fb82011-05-09 11:01:31 -0700237
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700238def _get_patch(commit):
239 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700240 if commit == PRE_SUBMIT:
241 return _run_command(['git', 'diff', '--cached', 'HEAD'])
242 else:
243 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700244
Ryan Cui1562fb82011-05-09 11:01:31 -0700245
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500246def _get_file_content(path, commit):
247 """Returns the content of a file at a specific commit.
248
249 We can't rely on the file as it exists in the filesystem as people might be
250 uploading a series of changes which modifies the file multiple times.
251
252 Note: The "content" of a symlink is just the target. So if you're expecting
253 a full file, you should check that first. One way to detect is that the
254 content will not have any newlines.
255 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400256 # Make sure people don't accidentally pass in full paths which will never
257 # work. You need to use relative=True with _get_affected_files.
258 if path.startswith('/'):
259 raise ValueError('_get_file_content must be called with relative paths: %s'
260 % (path,))
261
262 # {<commit>: {<path1>: <content>, <path2>: <content>}}
263 cache = CACHE.get_subcache('get_file_content')
264 if path in cache:
265 return cache[path]
266
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700267 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400268 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700269 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400270 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
271 cache[path] = content
272 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500273
274
Mike Frysingerae409522014-02-01 03:16:11 -0500275def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700276 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 # {<commit>: {<path1>: <content>, <path2>: <content>}}
278 cache = CACHE.get_subcache('get_file_diff')
279 if path in cache:
280 return cache[path]
281
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700282 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800283 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
284 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700285 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800286 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
287 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700288 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700289
290 new_lines = []
291 line_num = 0
292 for line in output.splitlines():
293 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
294 if m:
295 line_num = int(m.groups(1)[0])
296 continue
297 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400298 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700299 if not line.startswith('-'):
300 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400301 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302 return new_lines
303
Ryan Cui1562fb82011-05-09 11:01:31 -0700304
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700305def _get_ignore_wildcards(directory, cache):
306 """Get wildcards listed in a directory's _IGNORE_FILE.
307
308 Args:
309 directory: A string containing a directory path.
310 cache: A dictionary (opaque to caller) caching previously-read wildcards.
311
312 Returns:
313 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
314 wasn't present.
315 """
316 # In the cache, keys are directories and values are lists of wildcards from
317 # _IGNORE_FILE within those directories (and empty if no file was present).
318 if directory not in cache:
319 wildcards = []
320 dotfile_path = os.path.join(directory, _IGNORE_FILE)
321 if os.path.exists(dotfile_path):
322 # TODO(derat): Consider using _get_file_content() to get the file as of
323 # this commit instead of the on-disk version. This may have a noticeable
324 # performance impact, as each call to _get_file_content() runs git.
325 with open(dotfile_path, 'r') as dotfile:
326 for line in dotfile.readlines():
327 line = line.strip()
328 if line.startswith('#'):
329 continue
330 if line.endswith('/'):
331 line += '*'
332 wildcards.append(line)
333 cache[directory] = wildcards
334
335 return cache[directory]
336
337
338def _path_is_ignored(path, cache):
339 """Check whether a path is ignored by _IGNORE_FILE.
340
341 Args:
342 path: A string containing a path.
343 cache: A dictionary (opaque to caller) caching previously-read wildcards.
344
345 Returns:
346 True if a file named _IGNORE_FILE in one of the passed-in path's parent
347 directories contains a wildcard matching the path.
348 """
349 # Skip ignore files.
350 if os.path.basename(path) == _IGNORE_FILE:
351 return True
352
353 path = os.path.abspath(path)
354 base = os.getcwd()
355
356 prefix = os.path.dirname(path)
357 while prefix.startswith(base):
358 rel_path = path[len(prefix) + 1:]
359 for wildcard in _get_ignore_wildcards(prefix, cache):
360 if fnmatch.fnmatch(rel_path, wildcard):
361 return True
362 prefix = os.path.dirname(prefix)
363
364 return False
365
366
Mike Frysinger292b45d2014-11-25 01:17:10 -0500367def _get_affected_files(commit, include_deletes=False, relative=False,
368 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700369 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700370 """Returns list of file paths that were modified/added, excluding symlinks.
371
372 Args:
373 commit: The commit
374 include_deletes: If true, we'll include deleted files in the result
375 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500376 include_symlinks: If true, we'll include symlinks in the result
377 include_adds: If true, we'll include new files in the result
378 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700379 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700380
381 Returns:
382 A list of modified/added (and perhaps deleted) files
383 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500384 if not relative and full_details:
385 raise ValueError('full_details only supports relative paths currently')
386
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700387 if commit == PRE_SUBMIT:
388 return _run_command(['git', 'diff-index', '--cached',
389 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500390
391 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400392 # {<commit>: {<path1>: <content>, <path2>: <content>}}
393 cache = CACHE.get_subcache('get_affected_files')
394 if path not in cache:
395 cache[path] = git.RawDiff(path, '%s^!' % commit)
396 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500399 if not include_symlinks:
400 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500401
402 if not include_deletes:
403 files = [x for x in files if x.status != 'D']
404
Mike Frysinger292b45d2014-11-25 01:17:10 -0500405 if not include_adds:
406 files = [x for x in files if x.status != 'A']
407
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700408 if use_ignore_files:
409 cache = {}
410 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
411 files = [x for x in files if not is_ignored(x)]
412
Mike Frysinger292b45d2014-11-25 01:17:10 -0500413 if full_details:
414 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500415 return files
416 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500417 # Caller only cares about filenames.
418 files = [x.dst_file if x.dst_file else x.src_file for x in files]
419 if relative:
420 return files
421 else:
422 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700423
424
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700425def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700426 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400427 cmd = ['git', 'log', '--no-merges', '--format=%H',
428 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700429 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700430
Ryan Cui1562fb82011-05-09 11:01:31 -0700431
Ryan Cuiec4d6332011-05-02 14:15:25 -0700432def _get_commit_desc(commit):
433 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700434 if commit == PRE_SUBMIT:
435 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400436
437 # {<commit>: <content>}
438 cache = CACHE.get_subcache('get_commit_desc')
439 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500440 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400441 commit + '^!'])
442 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700443
444
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800445def _check_lines_in_diff(commit, files, check_callable, error_description):
446 """Checks given file for errors via the given check.
447
448 This is a convenience function for common per-line checks. It goes through all
449 files and returns a HookFailure with the error description listing all the
450 failures.
451
452 Args:
453 commit: The commit we're working on.
454 files: The files to check.
455 check_callable: A callable that takes a line and returns True if this line
456 _fails_ the check.
457 error_description: A string describing the error.
458 """
459 errors = []
460 for afile in files:
461 for line_num, line in _get_file_diff(afile, commit):
462 if check_callable(line):
463 errors.append('%s, line %s' % (afile, line_num))
464 if errors:
465 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400466 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800467
468
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900469def _parse_common_inclusion_options(options):
470 """Parses common hook options for including/excluding files.
471
472 Args:
473 options: Option string list.
474
475 Returns:
476 (included, excluded) where each one is a list of regex strings.
477 """
478 parser = argparse.ArgumentParser()
479 parser.add_argument('--exclude_regex', action='append')
480 parser.add_argument('--include_regex', action='append')
481 opts = parser.parse_args(options)
482 included = opts.include_regex or []
483 excluded = opts.exclude_regex or []
484 return included, excluded
485
486
Ryan Cuiec4d6332011-05-02 14:15:25 -0700487# Common Hooks
488
Ryan Cui1562fb82011-05-09 11:01:31 -0700489
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900490def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500491 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900492 LONG_LINE_OK_PATHS = [
493 # Go has no line length limit.
494 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400495 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900496 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500497
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900498 DEFAULT_MAX_LENGTHS = [
499 # Java's line length limit is 100 chars.
500 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
501 (r'.*\.java$', 100),
502 ]
503
Ryan Cuiec4d6332011-05-02 14:15:25 -0700504 MAX_LEN = 80
505
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900506 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700507 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900508 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900509 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700510
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900511 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700512 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700513 skip_regexps = (
514 r'https?://',
515 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
516 )
517
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900518 max_len = MAX_LEN
519
520 for expr, length in DEFAULT_MAX_LENGTHS:
521 if re.search(expr, afile):
522 max_len = length
523 break
524
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700525 if os.path.basename(afile).startswith('OWNERS'):
526 # File paths can get long, and there's no way to break them up into
527 # multiple lines.
528 skip_regexps += (
529 r'^include\b',
530 r'file:',
531 )
532
533 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700534 for line_num, line in _get_file_diff(afile, commit):
535 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900536 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800537 continue
538
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900539 errors.append('%s, line %s, %s chars, over %s chars' %
540 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800541 if len(errors) == 5: # Just show the first 5 errors.
542 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700543
544 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900545 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700546 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400547 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700548
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900550def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700551 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900552 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700553 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900554 included + COMMON_INCLUDED_PATHS,
555 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800556 return _check_lines_in_diff(commit, files,
557 lambda line: line.rstrip() != line,
558 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700559
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700562 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400563 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
564 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700565 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400566 r'.*\.ebuild$',
567 r'.*\.eclass$',
568 r'.*\.go$',
569 r'.*/[M|m]akefile$',
570 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 ]
572
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900575 included + COMMON_INCLUDED_PATHS,
576 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800577 return _check_lines_in_diff(commit, files,
578 lambda line: '\t' in line,
579 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800581
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900582def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800583 """Checks that indents use tabs only."""
584 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400585 r'.*\.ebuild$',
586 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800587 ]
588 LEADING_SPACE_RE = re.compile('[\t]* ')
589
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900590 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800591 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900592 included + TABS_REQUIRED_PATHS,
593 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 return _check_lines_in_diff(
595 commit, files,
596 lambda line: LEADING_SPACE_RE.match(line) is not None,
597 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700598
Ryan Cuiec4d6332011-05-02 14:15:25 -0700599
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700600def _check_gofmt(_project, commit):
601 """Checks that Go files are formatted with gofmt."""
602 errors = []
603 files = _filter_files(_get_affected_files(commit, relative=True),
604 [r'\.go$'])
605
606 for gofile in files:
607 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400608 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500609 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700610 if output:
611 errors.append(gofile)
612 if errors:
613 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400614 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700615
616
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600617def _check_rustfmt(_project, commit):
618 """Checks that Rust files are formatted with rustfmt."""
619 errors = []
620 files = _filter_files(_get_affected_files(commit, relative=True),
621 [r'\.rs$'])
622
623 for rustfile in files:
624 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400625 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500626 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600627 if output != contents:
628 errors.append(rustfile)
629 if errors:
630 return HookFailure('Files not formatted with rustfmt: '
631 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400632 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600633
634
Mike Frysingerae409522014-02-01 03:16:11 -0500635def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700636 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500637 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
David McMahon8f6553e2011-06-10 15:46:36 -0700638 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700639
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700640 if not re.search(TEST_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500641 msg = ('Changelist description needs TEST field (after first line)\n%s' %
642 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700643 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400644 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700645
Ryan Cuiec4d6332011-05-02 14:15:25 -0700646
Mike Frysingerae409522014-02-01 03:16:11 -0500647def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600648 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700649 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600650 msg = 'Changelist has invalid Cq-Depend target.'
651 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700652 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700653 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700654 except ValueError as ex:
655 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700656 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500657 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700658 paragraphs = desc.split('\n\n')
659 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500660 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
661 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700662 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500663
664 # We no longer support CQ-DEPEND= lines.
665 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
666 return HookFailure(
667 'CQ-DEPEND= is no longer supported. Please see:\n'
668 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
669 'contributing.md#CQ-DEPEND')
670
Mike Frysinger8cf80812019-09-16 23:49:29 -0400671 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700672
673
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800674def _check_change_is_contribution(_project, commit):
675 """Check that the change is a contribution."""
676 NO_CONTRIB = 'not a contribution'
677 if NO_CONTRIB in _get_commit_desc(commit).lower():
678 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
679 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
680 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400681 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800682
683
Alex Deymo643ac4c2015-09-03 10:40:50 -0700684def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700685 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500686 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
687
David James5c0073d2013-04-03 08:48:52 -0700688 OLD_BUG_RE = r'\nBUG=.*chromium-os'
689 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
690 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
691 'the chromium tracker in your BUG= line now.')
692 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700693
Alex Deymo643ac4c2015-09-03 10:40:50 -0700694 # Android internal and external projects use "Bug: " to track bugs in
695 # buganizer.
696 BUG_COLON_REMOTES = (
697 'aosp',
698 'goog',
699 )
700 if project.remote in BUG_COLON_REMOTES:
701 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
702 if not re.search(BUG_RE, _get_commit_desc(commit)):
703 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500704 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700705 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500706 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700707 return HookFailure(msg)
708 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400709 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700710 if not re.search(BUG_RE, _get_commit_desc(commit)):
711 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500712 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700713 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700714 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500715 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700716 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700717
Mike Frysinger8cf80812019-09-16 23:49:29 -0400718 return None
719
Ryan Cuiec4d6332011-05-02 14:15:25 -0700720
Jack Neus8edbf642019-07-10 16:08:31 -0600721def _check_change_no_include_oem(project, commit):
722 """Check that the change does not reference OEMs."""
723 ALLOWLIST = {
724 'chromiumos/platform/ec',
725 # Used by unit tests.
726 'project',
727 }
728 if project.name not in ALLOWLIST:
729 return None
730
Mike Frysingerbb34a222019-07-31 14:40:46 -0400731 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600732 'Reviewed-on',
733 'Reviewed-by',
734 'Signed-off-by',
735 'Commit-Ready',
736 'Tested-by',
737 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600738 'Acked-by',
739 'Modified-by',
740 'CC',
741 'Suggested-by',
742 'Reported-by',
743 'Acked-for-chrome-by',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400744 }
Jack Neus8edbf642019-07-10 16:08:31 -0600745
746 # Ignore tags, which could reasonably contain OEM names
747 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600748 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400749 x for x in _get_commit_desc(commit).splitlines()
750 if ':' not in x or x.split(':', 1)[0] not in TAGS)
751
Jack Neus8edbf642019-07-10 16:08:31 -0600752 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
753
754 # Exercise caution when expanding these lists. Adding a name
755 # could indicate a new relationship with a company!
756 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
757 ODMS = [
758 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
759 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
760 ]
761
762 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
763 # Construct regex
764 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
765 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400766 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600767 # If there's a match, throw an error.
768 error_msg = ('Changelist description contains the name of an'
769 ' %s: "%s".' % (name_type, '","'.join(matches)))
770 return HookFailure(error_msg)
771
Mike Frysinger8cf80812019-09-16 23:49:29 -0400772 return None
773
Jack Neus8edbf642019-07-10 16:08:31 -0600774
Mike Frysinger292b45d2014-11-25 01:17:10 -0500775def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700776 """Check that we're not missing a revbump of an ebuild in the given commit.
777
778 If the given commit touches files in a directory that has ebuilds somewhere
779 up the directory hierarchy, it's very likely that we need an ebuild revbump
780 in order for those changes to take effect.
781
782 It's not totally trivial to detect a revbump, so at least detect that an
783 ebuild with a revision number in it was touched. This should handle the
784 common case where we use a symlink to do the revbump.
785
786 TODO: it would be nice to enhance this hook to:
787 * Handle cases where people revbump with a slightly different syntax. I see
788 one ebuild (puppy) that revbumps with _pN. This is a false positive.
789 * Catches cases where people aren't using symlinks for revbumps. If they
790 edit a revisioned file directly (and are expected to rename it for revbump)
791 we'll miss that. Perhaps we could detect that the file touched is a
792 symlink?
793
794 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
795 still better off than without this check.
796
797 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700798 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700799 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500800 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700801
802 Returns:
803 A HookFailure or None.
804 """
Mike Frysinger011af942014-01-17 16:12:22 -0500805 # If this is the portage-stable overlay, then ignore the check. It's rare
806 # that we're doing anything other than importing files from upstream, so
807 # forcing a rev bump makes no sense.
808 whitelist = (
809 'chromiumos/overlays/portage-stable',
810 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700811 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500812 return None
813
Mike Frysinger292b45d2014-11-25 01:17:10 -0500814 def FinalName(obj):
815 # If the file is being deleted, then the dst_file is not set.
816 if obj.dst_file is None:
817 return obj.src_file
818 else:
819 return obj.dst_file
820
821 affected_path_objs = _get_affected_files(
822 commit, include_deletes=True, include_symlinks=True, relative=True,
823 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700824
825 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500826 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500827 affected_path_objs = [x for x in affected_path_objs
828 if os.path.basename(FinalName(x)) not in whitelist]
829 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700830 return None
831
832 # If we've touched any file named with a -rN.ebuild then we'll say we're
833 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500834 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
835 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700836 if touched_revved_ebuild:
837 return None
838
Mike Frysinger292b45d2014-11-25 01:17:10 -0500839 # If we're creating new ebuilds from scratch, then we don't need an uprev.
840 # Find all the dirs that new ebuilds and ignore their files/.
841 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
842 if FinalName(x).endswith('.ebuild') and x.status == 'A']
843 affected_path_objs = [obj for obj in affected_path_objs
844 if not any(FinalName(obj).startswith(x)
845 for x in ebuild_dirs)]
846 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400847 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500848
Doug Anderson42b8a052013-06-26 10:45:36 -0700849 # We want to examine the current contents of all directories that are parents
850 # of files that were touched (up to the top of the project).
851 #
852 # ...note: we use the current directory contents even though it may have
853 # changed since the commit we're looking at. This is just a heuristic after
854 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500855 if project_top is None:
856 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700857 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500858 for obj in affected_path_objs:
859 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700860 while os.path.exists(path) and not os.path.samefile(path, project_top):
861 dirs_to_check.add(path)
862 path = os.path.dirname(path)
863
864 # Look through each directory. If it's got an ebuild in it then we'll
865 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800866 affected_paths = set(os.path.join(project_top, FinalName(x))
867 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700868 for dir_path in dirs_to_check:
869 contents = os.listdir(dir_path)
870 ebuilds = [os.path.join(dir_path, path)
871 for path in contents if path.endswith('.ebuild')]
872 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
873
C Shapiroae157ae2017-09-18 16:24:03 -0600874 affected_paths_under_9999_ebuilds = set()
875 for affected_path in affected_paths:
876 for ebuild_9999 in ebuilds_9999:
877 ebuild_dir = os.path.dirname(ebuild_9999)
878 if affected_path.startswith(ebuild_dir):
879 affected_paths_under_9999_ebuilds.add(affected_path)
880
881 # If every file changed exists under a 9999 ebuild, then skip
882 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
883 continue
884
Doug Anderson42b8a052013-06-26 10:45:36 -0700885 # If the -9999.ebuild file was touched the bot will uprev for us.
886 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500887 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700888 continue
889
890 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500891 return HookFailure('Changelist probably needs a revbump of an ebuild, '
892 'or a -r1.ebuild symlink if this is a new ebuild:\n'
893 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700894
895 return None
896
897
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500898def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500899 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500900
901 We want to get away from older EAPI's as it makes life confusing and they
902 have less builtin error checking.
903
904 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700905 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500906 commit: The commit to look at
907
908 Returns:
909 A HookFailure or None.
910 """
911 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500912 # that we're doing anything other than importing files from upstream, and
913 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500914 whitelist = (
915 'chromiumos/overlays/portage-stable',
916 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700917 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500918 return None
919
Mike Frysinger948284a2018-02-01 15:22:56 -0500920 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500921
922 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
923
924 ebuilds_re = [r'\.ebuild$']
925 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
926 ebuilds_re)
927 bad_ebuilds = []
928
929 for ebuild in ebuilds:
930 # If the ebuild does not specify an EAPI, it defaults to 0.
931 eapi = '0'
932
933 lines = _get_file_content(ebuild, commit).splitlines()
934 if len(lines) == 1:
935 # This is most likely a symlink, so skip it entirely.
936 continue
937
938 for line in lines:
939 m = get_eapi.match(line)
940 if m:
941 # Once we hit the first EAPI line in this ebuild, stop processing.
942 # The spec requires that there only be one and it be first, so
943 # checking all possible values is pointless. We also assume that
944 # it's "the" EAPI line and not something in the middle of a heredoc.
945 eapi = m.group(1)
946 break
947
948 if eapi in BAD_EAPIS:
949 bad_ebuilds.append((ebuild, eapi))
950
951 if bad_ebuilds:
952 # pylint: disable=C0301
953 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
954 # pylint: enable=C0301
955 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500956 'These ebuilds are using old EAPIs. If these are imported from\n'
957 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500958 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500959 '\t%s\n'
960 'See this guide for more details:\n%s\n' %
961 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
962
Mike Frysinger8cf80812019-09-16 23:49:29 -0400963 return None
964
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500965
Mike Frysinger89bdb852014-02-01 05:26:26 -0500966def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500967 """Make sure we use the new style KEYWORDS when possible in ebuilds.
968
969 If an ebuild generally does not care about the arch it is running on, then
970 ebuilds should flag it with one of:
971 KEYWORDS="*" # A stable ebuild.
972 KEYWORDS="~*" # An unstable ebuild.
973 KEYWORDS="-* ..." # Is known to only work on specific arches.
974
975 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700976 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500977 commit: The commit to look at
978
979 Returns:
980 A HookFailure or None.
981 """
982 WHITELIST = set(('*', '-*', '~*'))
983
984 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
985
Mike Frysinger89bdb852014-02-01 05:26:26 -0500986 ebuilds_re = [r'\.ebuild$']
987 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
988 ebuilds_re)
989
Mike Frysinger8d42d742014-09-22 15:50:21 -0400990 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500991 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400992 # We get the full content rather than a diff as the latter does not work
993 # on new files (like when adding new ebuilds).
994 lines = _get_file_content(ebuild, commit).splitlines()
995 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500996 m = get_keywords.match(line)
997 if m:
998 keywords = set(m.group(1).split())
999 if not keywords or WHITELIST - keywords != WHITELIST:
1000 continue
1001
Mike Frysinger8d42d742014-09-22 15:50:21 -04001002 bad_ebuilds.append(ebuild)
1003
1004 if bad_ebuilds:
1005 return HookFailure(
1006 '%s\n'
1007 'Please update KEYWORDS to use a glob:\n'
1008 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1009 ' KEYWORDS="*"\n'
1010 'If the ebuild should be marked unstable (normal for '
1011 'cros-workon / 9999 ebuilds):\n'
1012 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001013 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001014 'then use -* like so:\n'
1015 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001016
Mike Frysinger8cf80812019-09-16 23:49:29 -04001017 return None
1018
Mike Frysingerc51ece72014-01-17 16:23:40 -05001019
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001020def _check_ebuild_licenses(_project, commit):
1021 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001022 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001023 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1024
1025 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001026 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001027
1028 for ebuild in touched_ebuilds:
1029 # Skip virutal packages.
1030 if ebuild.split('/')[-3] == 'virtual':
1031 continue
1032
Alex Kleinb5953522018-08-03 11:44:21 -06001033 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1034 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1035
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001036 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001037 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001038 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1039 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001040 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001041 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001042
1043 # Also ignore licenses ending with '?'
1044 for license_type in [x for x in license_types
1045 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1046 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001047 licenses_lib.Licensing.FindLicenseType(license_type,
1048 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001049 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001050 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001051
Mike Frysinger8cf80812019-09-16 23:49:29 -04001052 return None
1053
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001054
Mike Frysingercd363c82014-02-01 05:20:18 -05001055def _check_ebuild_virtual_pv(project, commit):
1056 """Enforce the virtual PV policies."""
1057 # If this is the portage-stable overlay, then ignore the check.
1058 # We want to import virtuals as-is from upstream Gentoo.
1059 whitelist = (
1060 'chromiumos/overlays/portage-stable',
1061 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001062 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001063 return None
1064
1065 # We assume the repo name is the same as the dir name on disk.
1066 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001067 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001068
1069 is_variant = lambda x: x.startswith('overlay-variant-')
1070 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001071 is_baseboard = lambda x: x.startswith('baseboard-')
1072 is_chipset = lambda x: x.startswith('chipset-')
1073 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001074 is_private = lambda x: x.endswith('-private')
1075
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001076 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1077 is_baseboard(x) or is_project(x))
1078
Mike Frysingercd363c82014-02-01 05:20:18 -05001079 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1080
1081 ebuilds_re = [r'\.ebuild$']
1082 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1083 ebuilds_re)
1084 bad_ebuilds = []
1085
1086 for ebuild in ebuilds:
1087 m = get_pv.match(ebuild)
1088 if m:
1089 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001090 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001091 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001092
1093 pv = m.group(3).split('-', 1)[0]
1094
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001095 # Virtual versions >= 4 are special cases used above the standard
1096 # versioning structure, e.g. if one has a board inheriting a board.
1097 if float(pv) >= 4:
1098 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001099 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001100 if is_private(overlay):
1101 want_pv = '3.5' if is_variant(overlay) else '3'
1102 elif is_board(overlay):
1103 want_pv = '2.5' if is_variant(overlay) else '2'
1104 elif is_baseboard(overlay):
1105 want_pv = '1.9'
1106 elif is_chipset(overlay):
1107 want_pv = '1.8'
1108 elif is_project(overlay):
1109 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001110 else:
1111 want_pv = '1'
1112
1113 if pv != want_pv:
1114 bad_ebuilds.append((ebuild, pv, want_pv))
1115
1116 if bad_ebuilds:
1117 # pylint: disable=C0301
1118 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1119 # pylint: enable=C0301
1120 return HookFailure(
1121 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1122 '\t%s\n'
1123 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1124 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1125 'page for more details:\n%s\n' %
1126 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1127 for x in bad_ebuilds]), url))
1128
Mike Frysinger8cf80812019-09-16 23:49:29 -04001129 return None
1130
Mike Frysingercd363c82014-02-01 05:20:18 -05001131
Daniel Erat9d203ff2015-02-17 10:12:21 -07001132def _check_portage_make_use_var(_project, commit):
1133 """Verify that $USE is set correctly in make.conf and make.defaults."""
1134 files = _filter_files(_get_affected_files(commit, relative=True),
1135 [r'(^|/)make.(conf|defaults)$'])
1136
1137 errors = []
1138 for path in files:
1139 basename = os.path.basename(path)
1140
1141 # Has a USE= line already been encountered in this file?
1142 saw_use = False
1143
1144 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1145 if not line.startswith('USE='):
1146 continue
1147
1148 preserves_use = '${USE}' in line or '$USE' in line
1149
1150 if (basename == 'make.conf' or
1151 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1152 errors.append('%s:%d: missing ${USE}' % (path, i))
1153 elif basename == 'make.defaults' and not saw_use and preserves_use:
1154 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1155 (path, i))
1156
1157 saw_use = True
1158
1159 if errors:
1160 return HookFailure(
1161 'One or more Portage make files appear to set USE incorrectly.\n'
1162 '\n'
1163 'All USE assignments in make.conf and all assignments after the\n'
1164 'initial declaration in make.defaults should contain "${USE}" to\n'
1165 'preserve previously-set flags.\n'
1166 '\n'
1167 'The initial USE declaration in make.defaults should not contain\n'
1168 '"${USE}".\n',
1169 errors)
1170
Mike Frysinger8cf80812019-09-16 23:49:29 -04001171 return None
1172
Daniel Erat9d203ff2015-02-17 10:12:21 -07001173
Mike Frysingerae409522014-02-01 03:16:11 -05001174def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001175 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001176 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001177 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001178 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001179 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001180 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001181
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001182 # S-o-b tags always allowed to follow Change-ID.
1183 allowed_tags = ['Signed-off-by']
1184
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001185 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001186 cherry_pick_marker = 'cherry picked from commit'
1187
1188 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001189 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001190 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1191 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001192 end = end[:-1]
1193
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001194 # Note that descriptions could have multiple cherry pick markers.
1195 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001196
1197 if [x for x in end if not re.search(tag_search, x)]:
1198 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1199 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001200
Mike Frysinger8cf80812019-09-16 23:49:29 -04001201 return None
1202
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001203
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001204def _check_commit_message_style(_project, commit):
1205 """Verify that the commit message matches our style.
1206
1207 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1208 commit hooks.
1209 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001210 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001211
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001212 desc = _get_commit_desc(commit)
1213
1214 # The first line should be by itself.
1215 lines = desc.splitlines()
1216 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001217 return HookFailure('The second line of the commit message must be blank.'
1218 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001219
1220 # The first line should be one sentence.
1221 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001222 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1223 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001224
1225 # The first line cannot be too long.
1226 MAX_FIRST_LINE_LEN = 100
1227 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001228 return HookFailure('The first line must be less than %i chars.\n%s' %
1229 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001230
Mike Frysinger8cf80812019-09-16 23:49:29 -04001231 return None
1232
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001233
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001234def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001235 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001236
Mike Frysinger98638102014-08-28 00:15:08 -04001237 Should be following the spec:
1238 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1239 """
1240 # For older years, be a bit more flexible as our policy says leave them be.
1241 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001242 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1243 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001244 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001245 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001246 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001247 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001248 )
1249 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1250
1251 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001252 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001253 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001254 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001255 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001256 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001257
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001258 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001259
Mike Frysinger98638102014-08-28 00:15:08 -04001260 bad_files = []
1261 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001262 bad_year_files = []
1263
Ken Turnerd07564b2018-02-08 17:57:59 +11001264 files = _filter_files(
1265 _get_affected_files(commit, relative=True),
1266 included + COMMON_INCLUDED_PATHS,
1267 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001268 existing_files = set(_get_affected_files(commit, relative=True,
1269 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001270
Keigo Oka7e880ac2019-07-03 15:03:43 +09001271 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001272 for f in files:
1273 contents = _get_file_content(f, commit)
1274 if not contents:
1275 # Ignore empty files.
1276 continue
1277
Keigo Oka7e880ac2019-07-03 15:03:43 +09001278 m = license_re.search(contents)
1279 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001280 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001281 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001282 bad_copyright_files.append(f)
1283
Keigo Oka7e880ac2019-07-03 15:03:43 +09001284 if m and f not in existing_files:
1285 year = m.group(1)
1286 if year != current_year:
1287 bad_year_files.append(f)
1288
1289 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001290 if bad_files:
1291 msg = '%s:\n%s\n%s' % (
1292 'License must match', license_re.pattern,
1293 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001294 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001295 if bad_copyright_files:
1296 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001297 errors.append(HookFailure(msg, bad_copyright_files))
1298 if bad_year_files:
1299 msg = 'Use current year (%s) in copyright headers in new files:' % (
1300 current_year)
1301 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001302
Keigo Oka7e880ac2019-07-03 15:03:43 +09001303 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001304
Mike Frysinger8cf80812019-09-16 23:49:29 -04001305
Amin Hassani391efa92018-01-26 17:58:05 -08001306def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001307 """Verifies the AOSP license/copyright header.
1308
1309 AOSP uses the Apache2 License:
1310 https://source.android.com/source/licenses.html
1311 """
1312 LICENSE_HEADER = (
1313 r"""^[#/\*]*
1314[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1315[#/\*]* ?
1316[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1317[#/\*]* ?you may not use this file except in compliance with the License\.
1318[#/\*]* ?You may obtain a copy of the License at
1319[#/\*]* ?
1320[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1321[#/\*]* ?
1322[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1323[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1324[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1325 r"""implied\.
1326[#/\*]* ?See the License for the specific language governing permissions and
1327[#/\*]* ?limitations under the License\.
1328[#/\*]*$
1329"""
1330 )
1331 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1332
Amin Hassani391efa92018-01-26 17:58:05 -08001333 included, excluded = _parse_common_inclusion_options(options)
1334
Ken Turnerd07564b2018-02-08 17:57:59 +11001335 files = _filter_files(
1336 _get_affected_files(commit, relative=True),
1337 included + COMMON_INCLUDED_PATHS,
1338 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001339
1340 bad_files = []
1341 for f in files:
1342 contents = _get_file_content(f, commit)
1343 if not contents:
1344 # Ignore empty files.
1345 continue
1346
1347 if not license_re.search(contents):
1348 bad_files.append(f)
1349
1350 if bad_files:
1351 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1352 license_re.pattern)
1353 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001354 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001355
1356
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001357def _check_layout_conf(_project, commit):
1358 """Verifies the metadata/layout.conf file."""
1359 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001360 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001361 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001362 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001363
Mike Frysinger94a670c2014-09-19 12:46:26 -04001364 # Handle multiple overlays in a single commit (like the public tree).
1365 for f in _get_affected_files(commit, relative=True):
1366 if f.endswith(repo_name):
1367 repo_names.append(f)
1368 elif f.endswith(layout_path):
1369 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001370
1371 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001372 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001373 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001374 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001375
Mike Frysinger94a670c2014-09-19 12:46:26 -04001376 # Gather all the errors in one pass so we show one full message.
1377 all_errors = {}
1378 for layout_path in layout_paths:
1379 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001380
Mike Frysinger94a670c2014-09-19 12:46:26 -04001381 # Make sure the config file is sorted.
1382 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1383 if x and x[0] != '#']
1384 if sorted(data) != data:
1385 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001386
Mike Frysinger94a670c2014-09-19 12:46:26 -04001387 # Require people to set specific values all the time.
1388 settings = (
1389 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001390 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001391 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001392 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1393 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001394 )
1395 for reason, line in settings:
1396 if line not in data:
1397 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001398
Mike Frysinger94a670c2014-09-19 12:46:26 -04001399 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001400 if 'use-manifests = strict' not in data:
1401 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001402
Mike Frysinger94a670c2014-09-19 12:46:26 -04001403 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001404 for line in data:
1405 if line.startswith('repo-name = '):
1406 break
1407 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001408 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001409
Mike Frysinger94a670c2014-09-19 12:46:26 -04001410 # Summarize all the errors we saw (if any).
1411 lines = ''
1412 for layout_path, errors in all_errors.items():
1413 if errors:
1414 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1415 if lines:
1416 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1417 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001418
Mike Frysinger8cf80812019-09-16 23:49:29 -04001419 return None
1420
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001421
Keigo Oka4a09bd92019-05-07 14:01:00 +09001422def _check_no_new_gyp(_project, commit):
1423 """Verifies no project starts to use GYP."""
1424 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001425 'chromeos/ap',
1426 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001427 'chromeos/ap/security',
1428 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001429 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001430 'chromeos/platform/drivefs-google3',
1431 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001432 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001433 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001434 'weave/libweave',
1435 ]
1436 if _project.name in whitelist:
1437 return None
1438
1439 gypfiles = _filter_files(
1440 _get_affected_files(commit, include_symlinks=True, relative=True),
1441 [r'\.gyp$'])
1442
1443 if gypfiles:
1444 return HookFailure('GYP is deprecated and not allowed in a new project:',
1445 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001446 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001447
1448
Ryan Cuiec4d6332011-05-02 14:15:25 -07001449# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001450
Ryan Cui1562fb82011-05-09 11:01:31 -07001451
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001452def _check_clang_format(_project, commit, options=()):
1453 """Runs clang-format on the given project"""
1454 hooks_dir = _get_hooks_dir()
1455 options = list(options)
1456 if commit == PRE_SUBMIT:
1457 options.append('--commit=HEAD')
1458 else:
1459 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001460 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001461 cmd_result = cros_build_lib.run(cmd,
1462 print_cmd=False,
1463 stdout=True,
1464 encoding='utf-8',
1465 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001466 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001467 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001468 if cmd_result.returncode:
1469 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001470 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001471 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001472
1473
Mike Frysingerae409522014-02-01 03:16:11 -05001474def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001475 """Runs checkpatch.pl on the given project"""
1476 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001477 options = list(options)
1478 if commit == PRE_SUBMIT:
1479 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1480 # this case.
1481 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001482 # Always ignore the check for the MAINTAINERS file. We do not track that
1483 # information on that file in our source trees, so let's suppress the
1484 # warning.
1485 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001486 # Do not complain about the Change-Id: fields, since we use Gerrit.
1487 # Upstream does not want those lines (since they do not use Gerrit), but
1488 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001489 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001490 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001491 cmd_result = cros_build_lib.run(
1492 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001493 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001494 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001495 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001496 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001497 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001498
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001499
Brian Norris23c62e92018-11-14 12:25:51 -08001500def _run_kerneldoc(_project, commit, options=()):
1501 """Runs kernel-doc validator on the given project"""
1502 included, excluded = _parse_common_inclusion_options(options)
1503 files = _filter_files(_get_affected_files(commit, relative=True),
1504 included, excluded)
1505 if files:
1506 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001507 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001508 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001509 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001510 return HookFailure('kernel-doc errors/warnings:',
1511 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001512 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001513
1514
Mike Frysingerae409522014-02-01 03:16:11 -05001515def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001516 """Makes sure kernel config changes are not mixed with code changes"""
1517 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001518 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001519 return HookFailure('Changes to chromeos/config/ and regular files must '
1520 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001521 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001522
Mike Frysingerae409522014-02-01 03:16:11 -05001523
1524def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001525 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001526 ret = []
1527
1528 files = _filter_files(_get_affected_files(commit, relative=True),
1529 [r'.*\.json$'])
1530 for f in files:
1531 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001532 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001533 json.loads(data)
1534 except Exception as e:
1535 ret.append('%s: Invalid JSON: %s' % (f, e))
1536
1537 if ret:
1538 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001539 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001540
1541
Mike Frysingerae409522014-02-01 03:16:11 -05001542def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001543 """Make sure Manifest files only have comments & DIST lines."""
1544 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001545
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001546 manifests = _filter_files(_get_affected_files(commit, relative=True),
1547 [r'.*/Manifest$'])
1548 for path in manifests:
1549 data = _get_file_content(path, commit)
1550
1551 # Disallow blank files.
1552 if not data.strip():
1553 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001554 continue
1555
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001556 # Make sure the last newline isn't omitted.
1557 if data[-1] != '\n':
1558 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001559
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001560 # Do not allow leading or trailing blank lines.
1561 lines = data.splitlines()
1562 if not lines[0]:
1563 ret.append('%s: delete leading blank lines' % (path,))
1564 if not lines[-1]:
1565 ret.append('%s: delete trailing blank lines' % (path,))
1566
1567 for line in lines:
1568 # Disallow leading/trailing whitespace.
1569 if line != line.strip():
1570 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1571
1572 # Allow blank lines & comments.
1573 line = line.split('#', 1)[0]
1574 if not line:
1575 continue
1576
1577 # All other linse should start with DIST.
1578 if not line.startswith('DIST '):
1579 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1580 break
1581
1582 if ret:
1583 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001584 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001585
1586
Mike Frysingerae409522014-02-01 03:16:11 -05001587def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001588 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001589 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001590 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001591 BRANCH_RE = r'\nBRANCH=\S+'
1592
1593 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1594 msg = ('Changelist description needs BRANCH field (after first line)\n'
1595 'E.g. BRANCH=none or BRANCH=link,snow')
1596 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001597 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001598
1599
Mike Frysinger45334bd2019-11-04 10:42:33 -05001600def _check_change_has_no_branch_field(_project, commit):
1601 """Verify 'BRANCH=' field does not exist in the commit message."""
1602 if commit == PRE_SUBMIT:
1603 return None
1604 BRANCH_RE = r'\nBRANCH=\S+'
1605
1606 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1607 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1608 return HookFailure(msg)
1609 return None
1610
1611
Mike Frysingerae409522014-02-01 03:16:11 -05001612def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001613 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001614 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001615 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001616 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1617
1618 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1619 msg = ('Changelist description needs Signed-off-by: field\n'
1620 'E.g. Signed-off-by: My Name <me@chromium.org>')
1621 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001622 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001623
1624
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001625def _check_change_has_no_signoff_field(_project, commit):
1626 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1627 if commit == PRE_SUBMIT:
1628 return None
1629 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1630
1631 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1632 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1633 return HookFailure(msg)
1634 return None
1635
1636
Jon Salz3ee59de2012-08-18 13:54:22 +08001637def _run_project_hook_script(script, project, commit):
1638 """Runs a project hook script.
1639
1640 The script is run with the following environment variables set:
1641 PRESUBMIT_PROJECT: The affected project
1642 PRESUBMIT_COMMIT: The affected commit
1643 PRESUBMIT_FILES: A newline-separated list of affected files
1644
1645 The script is considered to fail if the exit code is non-zero. It should
1646 write an error message to stdout.
1647 """
1648 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001649 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001650 env['PRESUBMIT_COMMIT'] = commit
1651
1652 # Put affected files in an environment variable
1653 files = _get_affected_files(commit)
1654 env['PRESUBMIT_FILES'] = '\n'.join(files)
1655
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001656 cmd_result = cros_build_lib.run(cmd=script,
1657 env=env,
1658 shell=True,
1659 print_cmd=False,
1660 input=os.devnull,
1661 stdout=True,
1662 encoding='utf-8',
1663 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001664 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001665 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001666 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001667 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001668 if stdout:
1669 stdout = re.sub('(?m)^', ' ', stdout)
1670 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001671 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001672 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001673 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001674
1675
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001676def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001677 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001678
Brian Norris77608e12018-04-06 10:38:43 -07001679 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001680 prefix = os.path.commonprefix(files)
1681 prefix = os.path.dirname(prefix)
1682
1683 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001684 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001685 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001686
1687 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001688
1689 # The common files may all be within a subdirectory of the main project
1690 # directory, so walk up the tree until we find an alias file.
1691 # _get_affected_files() should return relative paths, but check against '/' to
1692 # ensure that this loop terminates even if it receives an absolute path.
1693 while prefix and prefix != '/':
1694 alias_file = os.path.join(prefix, '.project_alias')
1695
1696 # If an alias exists, use it.
1697 if os.path.isfile(alias_file):
1698 project_name = osutils.ReadFile(alias_file).strip()
1699
1700 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001701
1702 if not _get_commit_desc(commit).startswith(project_name + ': '):
1703 return HookFailure('The commit title for changes affecting only %s'
1704 ' should start with \"%s: \"'
1705 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001706 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001707
1708
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001709def _check_filepath_chartype(_project, commit):
1710 """Checks that FilePath::CharType stuff is not used."""
1711
1712 FILEPATH_REGEXP = re.compile('|'.join(
1713 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001714 r'(?:base::)?FilePath::FromUTF8Unsafe',
1715 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001716 r'FILE_PATH_LITERAL']))
1717 files = _filter_files(_get_affected_files(commit, relative=True),
1718 [r'.*\.(cc|h)$'])
1719
1720 errors = []
1721 for afile in files:
1722 for line_num, line in _get_file_diff(afile, commit):
1723 m = re.search(FILEPATH_REGEXP, line)
1724 if m:
1725 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1726
1727 if errors:
1728 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1729 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001730 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001731
1732
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001733def _check_exec_files(_project, commit):
1734 """Make +x bits on files."""
1735 # List of files that should never be +x.
1736 NO_EXEC = (
1737 'ChangeLog*',
1738 'COPYING',
1739 'make.conf',
1740 'make.defaults',
1741 'Manifest',
1742 'OWNERS',
1743 'package.use',
1744 'package.keywords',
1745 'package.mask',
1746 'parent',
1747 'README',
1748 'TODO',
1749 '.gitignore',
1750 '*.[achly]',
1751 '*.[ch]xx',
1752 '*.boto',
1753 '*.cc',
1754 '*.cfg',
1755 '*.conf',
1756 '*.config',
1757 '*.cpp',
1758 '*.css',
1759 '*.ebuild',
1760 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001761 '*.gn',
1762 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001763 '*.gyp',
1764 '*.gypi',
1765 '*.htm',
1766 '*.html',
1767 '*.ini',
1768 '*.js',
1769 '*.json',
1770 '*.md',
1771 '*.mk',
1772 '*.patch',
1773 '*.policy',
1774 '*.proto',
1775 '*.raw',
1776 '*.rules',
1777 '*.service',
1778 '*.target',
1779 '*.txt',
1780 '*.xml',
1781 '*.yaml',
1782 )
1783
1784 def FinalName(obj):
1785 # If the file is being deleted, then the dst_file is not set.
1786 if obj.dst_file is None:
1787 return obj.src_file
1788 else:
1789 return obj.dst_file
1790
1791 bad_files = []
1792 files = _get_affected_files(commit, relative=True, full_details=True)
1793 for f in files:
1794 mode = int(f.dst_mode, 8)
1795 if not mode & 0o111:
1796 continue
1797 name = FinalName(f)
1798 for no_exec in NO_EXEC:
1799 if fnmatch.fnmatch(name, no_exec):
1800 bad_files.append(name)
1801 break
1802
1803 if bad_files:
1804 return HookFailure('These files should not be executable. '
1805 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001806 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001807
1808
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001809# Base
1810
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001811# A list of hooks which are not project specific and check patch description
1812# (as opposed to patch body).
1813_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001814 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001815 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001816 _check_change_has_test_field,
1817 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001818 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001819 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001820 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001821]
1822
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001823# A list of hooks that are not project-specific
1824_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001825 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001826 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001827 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001828 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001829 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001830 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001831 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001832 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001833 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001834 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001835 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001836 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001837 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001838 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001839 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001840 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001841]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001842
Ryan Cui1562fb82011-05-09 11:01:31 -07001843
Ryan Cui9b651632011-05-11 11:38:58 -07001844# A dictionary of project-specific hooks(callbacks), indexed by project name.
1845# dict[project] = [callback1, callback2]
1846_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001847 'chromiumos/third_party/kernel': [_kernel_configcheck],
1848 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001849}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001850
Ryan Cui1562fb82011-05-09 11:01:31 -07001851
Ryan Cui9b651632011-05-11 11:38:58 -07001852# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001853# that the flag controls (value).
1854_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001855 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001856 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001857 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001858 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001859 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001860 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001861 'cros_license_check': _check_cros_license,
1862 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001863 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001864 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001865 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001866 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001867 'bug_field_check': _check_change_has_bug_field,
1868 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001869 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001870 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001871 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001872 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001873}
1874
1875
Mike Frysinger3554bc92015-03-11 04:59:21 -04001876def _get_override_hooks(config):
1877 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001878
1879 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001880
1881 Args:
1882 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001883 """
1884 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001885 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001886 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001887 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001888
Mike Frysinger56e8de02019-07-31 14:40:14 -04001889 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001890 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001891
1892 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001893 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001894 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001895 if flag not in valid_keys:
1896 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1897 (flag, _CONFIG_FILE))
1898
Ryan Cui9b651632011-05-11 11:38:58 -07001899 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001900 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001901 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001902 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1903 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001904 if enabled:
1905 enable_flags.append(flag)
1906 else:
1907 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001908
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001909 # See if this hook has custom options.
1910 if enabled:
1911 try:
1912 options = config.get(SECTION_OPTIONS, flag)
1913 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001914 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001915 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001916 pass
1917
1918 enabled_hooks = set(hooks[x] for x in enable_flags)
1919 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001920
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001921 if _check_change_has_signoff_field not in enabled_hooks:
1922 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001923 if _check_change_has_branch_field not in enabled_hooks:
1924 enabled_hooks.add(_check_change_has_no_branch_field)
1925
Mike Frysinger3554bc92015-03-11 04:59:21 -04001926 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001927
1928
Jon Salz3ee59de2012-08-18 13:54:22 +08001929def _get_project_hook_scripts(config):
1930 """Returns a list of project-specific hook scripts.
1931
1932 Args:
1933 config: A ConfigParser for the project's config file.
1934 """
1935 SECTION = 'Hook Scripts'
1936 if not config.has_section(SECTION):
1937 return []
1938
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001939 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001940
1941
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001942def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001943 """Returns a list of hooks that need to be run for a project.
1944
1945 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001946
1947 Args:
1948 project: A string, name of the project.
1949 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001950 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001951 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001952 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001953 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001954 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001955 else:
1956 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001957
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001958 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001959 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001960 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001961 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001962
Mike Frysinger3554bc92015-03-11 04:59:21 -04001963 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001964 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1965
1966 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1967 # override, keep the override only. Note that the override may end up being
1968 # a functools.partial, in which case we need to extract the .func to compare
1969 # it to the common hooks.
1970 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1971 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1972
1973 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001974
1975 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001976 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1977 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001978
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001979 for name, script in _get_project_hook_scripts(config):
1980 func = functools.partial(_run_project_hook_script, script)
1981 func.__name__ = name
1982 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001983
Ryan Cui9b651632011-05-11 11:38:58 -07001984 return hooks
1985
1986
Alex Deymo643ac4c2015-09-03 10:40:50 -07001987def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001988 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001989 """For each project run its project specific hook from the hooks dictionary.
1990
1991 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001992 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001993 proj_dir: If non-None, this is the directory the project is in. If None,
1994 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001995 commit_list: A list of commits to run hooks against. If None or empty list
1996 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001997 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001998
1999 Returns:
2000 Boolean value of whether any errors were ecountered while running the hooks.
2001 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002002 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002003 proj_dirs = _run_command(
2004 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002005 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002006 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002007 print('Please specify a valid project.', file=sys.stderr)
2008 return True
2009 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002010 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002011 file=sys.stderr)
2012 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2013 return True
2014 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002015
Ryan Cuiec4d6332011-05-02 14:15:25 -07002016 pwd = os.getcwd()
2017 # hooks assume they are run from the root of the project
2018 os.chdir(proj_dir)
2019
Mike Frysingered1b95a2019-12-12 19:04:51 -05002020 color = terminal.Color()
2021
Alex Deymo643ac4c2015-09-03 10:40:50 -07002022 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2023 '--symbolic-full-name', '@{u}']).strip()
2024 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002025 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002026 file=sys.stderr)
2027 remote = None
2028 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002029 branch_items = remote_branch.split('/', 1)
2030 if len(branch_items) != 2:
2031 PrintErrorForProject(
2032 project_name,
2033 HookFailure(
2034 'Cannot get remote and branch name (%s)' % remote_branch))
2035 os.chdir(pwd)
2036 return True
2037 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002038
2039 project = Project(name=project_name, dir=proj_dir, remote=remote)
2040
Doug Anderson14749562013-06-26 13:38:29 -07002041 if not commit_list:
2042 try:
2043 commit_list = _get_commits()
2044 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002045 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002046 os.chdir(pwd)
2047 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002048
Alex Deymo643ac4c2015-09-03 10:40:50 -07002049 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002050 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002051 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002052 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002053 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002054 CACHE.clear()
2055
Mike Frysingered1b95a2019-12-12 19:04:51 -05002056 desc = _get_commit_desc(commit)
2057 print('[%s %i/%i %s] %s' %
2058 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2059 desc.splitlines()[0]))
2060
Mike Frysingerb99b3772019-08-17 14:19:44 -04002061 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002062 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2063 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2064 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002065 print(output, end='\r')
2066 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002067 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002068 print(' ' * len(output), end='\r')
2069 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002070 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002071 if not isinstance(hook_error, list):
2072 hook_error = [hook_error]
2073 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002074 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002075
Ryan Cuiec4d6332011-05-02 14:15:25 -07002076 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002077 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002078
Mike Frysingerae409522014-02-01 03:16:11 -05002079
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002080# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002081
Ryan Cui1562fb82011-05-09 11:01:31 -07002082
Mike Frysingerae409522014-02-01 03:16:11 -05002083def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002084 """Main function invoked directly by repo.
2085
2086 This function will exit directly upon error so that repo doesn't print some
2087 obscure error message.
2088
2089 Args:
2090 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002091 worktree_list: A list of directories. It should be the same length as
2092 project_list, so that each entry in project_list matches with a directory
2093 in worktree_list. If None, we will attempt to calculate the directories
2094 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002095 kwargs: Leave this here for forward-compatibility.
2096 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002097 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002098 found_error = False
David James2edd9002013-10-11 14:09:19 -07002099 if not worktree_list:
2100 worktree_list = [None] * len(project_list)
2101 for project, worktree in zip(project_list, worktree_list):
2102 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002103 found_error = True
2104
Mike Frysingered1b95a2019-12-12 19:04:51 -05002105 end_time = datetime.datetime.now()
2106 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002107 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002108 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002109 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002110 '<checkout_dir>/src/repohooks/README.md\n'
2111 "- To upload only current project, run 'repo upload .'" %
2112 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002113 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002114 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002115 else:
2116 msg = ('[%s] repohooks passed in %s' %
2117 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2118 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002119
Ryan Cui1562fb82011-05-09 11:01:31 -07002120
Doug Anderson44a644f2011-11-02 10:37:37 -07002121def _identify_project(path):
2122 """Identify the repo project associated with the given path.
2123
2124 Returns:
2125 A string indicating what project is associated with the path passed in or
2126 a blank string upon failure.
2127 """
2128 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002129 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002130
2131
Mike Frysinger55f85b52014-12-18 14:45:21 -05002132def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002133 """Run hooks directly (outside of the context of repo).
2134
Doug Anderson44a644f2011-11-02 10:37:37 -07002135 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002136 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002137
2138 Returns:
2139 0 if no pre-upload failures, 1 if failures.
2140
2141 Raises:
2142 BadInvocation: On some types of invocation errors.
2143 """
Mike Frysinger66142932014-12-18 14:55:57 -05002144 parser = commandline.ArgumentParser(description=__doc__)
2145 parser.add_argument('--dir', default=None,
2146 help='The directory that the project lives in. If not '
2147 'specified, use the git project root based on the cwd.')
2148 parser.add_argument('--project', default=None,
2149 help='The project repo path; this can affect how the '
2150 'hooks get run, since some hooks are project-specific. '
2151 'For chromite this is chromiumos/chromite. If not '
2152 'specified, the repo tool will be used to figure this '
2153 'out based on the dir.')
2154 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002155 help='Rerun hooks on old commits since some point '
2156 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002157 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002158 'or a SHA1, or just a number of commits to check (from 1 '
2159 'to 99). This option is mutually exclusive with '
2160 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002161 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002162 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002163 "This option should be used at the 'git commit' "
2164 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002165 'is mutually exclusive with --rerun-since.')
2166 parser.add_argument('commits', nargs='*',
2167 help='Check specific commits')
2168 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002169
Doug Anderson14749562013-06-26 13:38:29 -07002170 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002171 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002172 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002173 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002174
Vadim Bendebury75447b92018-01-10 12:06:01 -08002175 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2176 # This must be the number of commits to check. We don't expect the user
2177 # to want to check more than 99 commits.
2178 limit = '-n%s' % opts.rerun_since
2179 elif git.IsSHA1(opts.rerun_since, False):
2180 limit = '%s..' % opts.rerun_since
2181 else:
2182 # This better be a date.
2183 limit = '--since=%s' % opts.rerun_since
2184 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002185 all_commits = _run_command(cmd).splitlines()
2186 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2187
2188 # Eliminate chrome-bot commits but keep ordering the same...
2189 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002190 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002191
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002192 if opts.pre_submit:
2193 raise BadInvocation('rerun-since and pre-submit can not be '
2194 'used together')
2195 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002196 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002197 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002198 ' '.join(opts.commits))
2199 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002200
2201 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2202 # project from CWD
2203 if opts.dir is None:
2204 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002205 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002206 if not git_dir:
2207 raise BadInvocation('The current directory is not part of a git project.')
2208 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2209 elif not os.path.isdir(opts.dir):
2210 raise BadInvocation('Invalid dir: %s' % opts.dir)
2211 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2212 raise BadInvocation('Not a git directory: %s' % opts.dir)
2213
2214 # Identify the project if it wasn't specified; this _requires_ the repo
2215 # tool to be installed and for the project to be part of a repo checkout.
2216 if not opts.project:
2217 opts.project = _identify_project(opts.dir)
2218 if not opts.project:
2219 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2220
Doug Anderson14749562013-06-26 13:38:29 -07002221 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002222 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002223 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002224 if found_error:
2225 return 1
2226 return 0
2227
2228
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002229if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002230 sys.exit(direct_main(sys.argv[1:]))