Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 1 | #!/usr/bin/env python2 |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2 | # -*- coding: utf-8 -*- |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 3 | # Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 7 | """Presubmit checks to run when doing `repo upload`. |
| 8 | |
| 9 | You can add new checks by adding a functions to the HOOKS constants. |
| 10 | """ |
| 11 | |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 12 | from __future__ import print_function |
| 13 | |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame^] | 14 | # TODO(crbug.com/960636): Remove pylint disable after linter is fixed. |
| 15 | import argparse # pylint: disable=import-error |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 16 | import collections |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 17 | import ConfigParser |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 18 | import fnmatch |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 19 | import functools |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 20 | import json |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 21 | import os |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 22 | import re |
Mandeep Singh Baines | a7ffa4b | 2011-05-03 11:37:02 -0700 | [diff] [blame] | 23 | import sys |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 24 | import stat |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 25 | import StringIO |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 26 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 27 | from errors import (VerifyException, HookFailure, PrintErrorForProject, |
| 28 | PrintErrorsForCommit) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 29 | |
Mike Frysinger | 6850d51 | 2018-05-21 12:12:14 -0400 | [diff] [blame] | 30 | # If repo imports us, the __name__ will be __builtin__, and the cwd will be in |
| 31 | # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be in |
| 32 | # that directory, so add it to our path. This works whether we're running the |
| 33 | # repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a completely |
| 34 | # different tree. |
| 35 | if __name__ == '__builtin__': |
| 36 | sys.path.insert(0, os.getcwd()) |
| 37 | |
| 38 | # If we're run directly, we'll find chromite relative to the repohooks dir in |
| 39 | # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs. |
| 40 | if __name__ == '__main__': |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 41 | sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..')) |
| 42 | |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 43 | from chromite.lib import commandline |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 44 | from chromite.lib import constants |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 45 | from chromite.lib import cros_build_lib |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 46 | from chromite.lib import git |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 47 | from chromite.lib import osutils |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 48 | from chromite.lib import patch |
Mike Frysinger | 2ec70ed | 2014-08-17 19:28:34 -0400 | [diff] [blame] | 49 | from chromite.licensing import licenses_lib |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 50 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 51 | PRE_SUBMIT = 'pre-submit' |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 52 | |
| 53 | COMMON_INCLUDED_PATHS = [ |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 54 | # C++ and friends |
| 55 | r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$", |
| 56 | r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$", |
| 57 | # Scripts |
| 58 | r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$", |
| 59 | # No extension at all, note that ALL CAPS files are black listed in |
| 60 | # COMMON_EXCLUDED_LIST below. |
| 61 | r"(^|.*[\\\/])[^.]+$", |
| 62 | # Other |
| 63 | r".*\.java$", r".*\.mk$", r".*\.am$", |
Brian Norris | fdbac8e | 2016-06-16 11:09:05 -0700 | [diff] [blame] | 64 | r".*\.policy$", r".*\.conf$", |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 65 | ] |
| 66 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 67 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 68 | COMMON_EXCLUDED_PATHS = [ |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 69 | # For ebuild trees, ignore any caches and manifest data. |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 70 | r".*/Manifest$", |
| 71 | r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$", |
Doug Anderson | 5bfb679 | 2011-10-25 16:45:41 -0700 | [diff] [blame] | 72 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 73 | # Ignore profiles data (like overlay-tegra2/profiles). |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 74 | r"(^|.*/)overlay-.*/profiles/.*", |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 75 | r"^profiles/.*$", |
| 76 | |
C Shapiro | 8f90e9b | 2017-06-28 09:54:50 -0600 | [diff] [blame] | 77 | # Ignore config files in ebuild setup. |
| 78 | r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*", |
| 79 | r"^chromeos-base/chromeos-bsp.*/files/.*", |
| 80 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 81 | # Ignore minified js and jquery. |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 82 | r".*\.min\.js", |
| 83 | r".*jquery.*\.js", |
Mike Frysinger | 33a458d | 2014-03-03 17:00:51 -0500 | [diff] [blame] | 84 | |
| 85 | # Ignore license files as the content is often taken verbatim. |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 86 | r".*/licenses/.*", |
Alex Klein | 619c091 | 2019-01-30 17:13:23 -0700 | [diff] [blame] | 87 | |
| 88 | # Exclude generated python protobuf files. |
| 89 | r".*_pb2\.py$", |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 90 | ] |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 91 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 92 | LICENSE_EXCLUDED_PATHS = [ |
Chris McDonald | 7b63c8e | 2019-04-25 10:27:27 -0600 | [diff] [blame] | 93 | r"^(.*/)?OWNERS$", |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 94 | ] |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 95 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 96 | _CONFIG_FILE = 'PRESUBMIT.cfg' |
| 97 | |
| 98 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 99 | # File containing wildcards, one per line, matching files that should be |
| 100 | # excluded from presubmit checks. Lines beginning with '#' are ignored. |
| 101 | _IGNORE_FILE = '.presubmitignore' |
| 102 | |
| 103 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 104 | # Exceptions |
| 105 | |
| 106 | |
| 107 | class BadInvocation(Exception): |
| 108 | """An Exception indicating a bad invocation of the program.""" |
| 109 | pass |
| 110 | |
| 111 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 112 | # General Helpers |
| 113 | |
Sean Paul | ba01d40 | 2011-05-05 11:36:23 -0400 | [diff] [blame] | 114 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 115 | Project = collections.namedtuple('Project', ['name', 'dir', 'remote']) |
| 116 | |
| 117 | |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 118 | # pylint: disable=redefined-builtin |
| 119 | def _run_command(cmd, cwd=None, input=None, |
| 120 | redirect_stderr=False, combine_stdout_stderr=False): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 121 | """Executes the passed in command and returns raw stdout output. |
| 122 | |
| 123 | Args: |
| 124 | cmd: The command to run; should be a list of strings. |
| 125 | cwd: The directory to switch to for running the command. |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 126 | input: The data to pipe into this command through stdin. If a file object |
| 127 | or file descriptor, stdin will be connected directly to that. |
| 128 | redirect_stderr: Redirect stderr away from console. |
| 129 | combine_stdout_stderr: Combines stdout and stderr streams into stdout. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 130 | |
| 131 | Returns: |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 132 | The stdout from the process (discards stderr and returncode). |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 133 | """ |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 134 | return cros_build_lib.RunCommand(cmd=cmd, |
| 135 | cwd=cwd, |
| 136 | print_cmd=False, |
| 137 | input=input, |
| 138 | stdout_to_pipe=True, |
| 139 | redirect_stderr=redirect_stderr, |
| 140 | combine_stdout_stderr=combine_stdout_stderr, |
| 141 | error_code_ok=True).output |
| 142 | # pylint: enable=redefined-builtin |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 143 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 144 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 145 | def _get_hooks_dir(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 146 | """Returns the absolute path to the repohooks directory.""" |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 147 | if __name__ == '__main__': |
| 148 | # Works when file is run on its own (__file__ is defined)... |
| 149 | return os.path.abspath(os.path.dirname(__file__)) |
| 150 | else: |
| 151 | # We need to do this when we're run through repo. Since repo executes |
| 152 | # us with execfile(), we don't get __file__ defined. |
| 153 | cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd'] |
| 154 | return _run_command(cmd).strip() |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 155 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 156 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 157 | def _match_regex_list(subject, expressions): |
| 158 | """Try to match a list of regular expressions to a string. |
| 159 | |
| 160 | Args: |
| 161 | subject: The string to match regexes on |
| 162 | expressions: A list of regular expressions to check for matches with. |
| 163 | |
| 164 | Returns: |
| 165 | Whether the passed in subject matches any of the passed in regexes. |
| 166 | """ |
| 167 | for expr in expressions: |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 168 | if re.search(expr, subject): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 169 | return True |
| 170 | return False |
| 171 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 172 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 173 | def _filter_files(files, include_list, exclude_list=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 174 | """Filter out files based on the conditions passed in. |
| 175 | |
| 176 | Args: |
| 177 | files: list of filepaths to filter |
| 178 | include_list: list of regex that when matched with a file path will cause it |
| 179 | to be added to the output list unless the file is also matched with a |
| 180 | regex in the exclude_list. |
| 181 | exclude_list: list of regex that when matched with a file will prevent it |
| 182 | from being added to the output list, even if it is also matched with a |
| 183 | regex in the include_list. |
| 184 | |
| 185 | Returns: |
| 186 | A list of filepaths that contain files matched in the include_list and not |
| 187 | in the exclude_list. |
| 188 | """ |
| 189 | filtered = [] |
| 190 | for f in files: |
| 191 | if (_match_regex_list(f, include_list) and |
| 192 | not _match_regex_list(f, exclude_list)): |
| 193 | filtered.append(f) |
| 194 | return filtered |
| 195 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 196 | |
| 197 | # Git Helpers |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 198 | |
| 199 | |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 200 | def _get_upstream_branch(): |
| 201 | """Returns the upstream tracking branch of the current branch. |
| 202 | |
| 203 | Raises: |
| 204 | Error if there is no tracking branch |
| 205 | """ |
| 206 | current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip() |
| 207 | current_branch = current_branch.replace('refs/heads/', '') |
| 208 | if not current_branch: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 209 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 210 | |
| 211 | cfg_option = 'branch.' + current_branch + '.%s' |
| 212 | full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip() |
| 213 | remote = _run_command(['git', 'config', cfg_option % 'remote']).strip() |
| 214 | if not remote or not full_upstream: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 215 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 216 | |
| 217 | return full_upstream.replace('heads', 'remotes/' + remote) |
| 218 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 219 | |
Che-Liang Chiou | 5ce2d7b | 2013-03-22 18:47:55 -0700 | [diff] [blame] | 220 | def _get_patch(commit): |
| 221 | """Returns the patch for this commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 222 | if commit == PRE_SUBMIT: |
| 223 | return _run_command(['git', 'diff', '--cached', 'HEAD']) |
| 224 | else: |
| 225 | return _run_command(['git', 'format-patch', '--stdout', '-1', commit]) |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 226 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 227 | |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 228 | def _try_utf8_decode(data): |
| 229 | """Attempts to decode a string as UTF-8. |
| 230 | |
| 231 | Returns: |
| 232 | The decoded Unicode object, or the original string if parsing fails. |
| 233 | """ |
| 234 | try: |
| 235 | return unicode(data, 'utf-8', 'strict') |
| 236 | except UnicodeDecodeError: |
| 237 | return data |
| 238 | |
| 239 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 240 | def _get_file_content(path, commit): |
| 241 | """Returns the content of a file at a specific commit. |
| 242 | |
| 243 | We can't rely on the file as it exists in the filesystem as people might be |
| 244 | uploading a series of changes which modifies the file multiple times. |
| 245 | |
| 246 | Note: The "content" of a symlink is just the target. So if you're expecting |
| 247 | a full file, you should check that first. One way to detect is that the |
| 248 | content will not have any newlines. |
| 249 | """ |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 250 | if commit == PRE_SUBMIT: |
| 251 | return _run_command(['git', 'diff', 'HEAD', path]) |
| 252 | else: |
Mike Frysinger | d052344 | 2018-01-03 17:05:29 -0500 | [diff] [blame] | 253 | # Make sure people don't accidentally pass in full paths which will never |
| 254 | # work. You need to use relative=True with _get_affected_files. |
| 255 | if path.startswith('/'): |
| 256 | raise ValueError('_get_file_content must be called with relative paths: ' |
| 257 | + path) |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 258 | return _run_command(['git', 'show', '%s:%s' % (commit, path)]) |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 259 | |
| 260 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 261 | def _get_file_diff(path, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 262 | """Returns a list of (linenum, lines) tuples that the commit touched.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 263 | if commit == PRE_SUBMIT: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 264 | command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD', |
| 265 | path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 266 | else: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 267 | command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit, |
| 268 | path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 269 | output = _run_command(command) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 270 | |
| 271 | new_lines = [] |
| 272 | line_num = 0 |
| 273 | for line in output.splitlines(): |
| 274 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 275 | if m: |
| 276 | line_num = int(m.groups(1)[0]) |
| 277 | continue |
| 278 | if line.startswith('+') and not line.startswith('++'): |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 279 | new_lines.append((line_num, _try_utf8_decode(line[1:]))) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 280 | if not line.startswith('-'): |
| 281 | line_num += 1 |
| 282 | return new_lines |
| 283 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 284 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 285 | def _get_ignore_wildcards(directory, cache): |
| 286 | """Get wildcards listed in a directory's _IGNORE_FILE. |
| 287 | |
| 288 | Args: |
| 289 | directory: A string containing a directory path. |
| 290 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 291 | |
| 292 | Returns: |
| 293 | A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE |
| 294 | wasn't present. |
| 295 | """ |
| 296 | # In the cache, keys are directories and values are lists of wildcards from |
| 297 | # _IGNORE_FILE within those directories (and empty if no file was present). |
| 298 | if directory not in cache: |
| 299 | wildcards = [] |
| 300 | dotfile_path = os.path.join(directory, _IGNORE_FILE) |
| 301 | if os.path.exists(dotfile_path): |
| 302 | # TODO(derat): Consider using _get_file_content() to get the file as of |
| 303 | # this commit instead of the on-disk version. This may have a noticeable |
| 304 | # performance impact, as each call to _get_file_content() runs git. |
| 305 | with open(dotfile_path, 'r') as dotfile: |
| 306 | for line in dotfile.readlines(): |
| 307 | line = line.strip() |
| 308 | if line.startswith('#'): |
| 309 | continue |
| 310 | if line.endswith('/'): |
| 311 | line += '*' |
| 312 | wildcards.append(line) |
| 313 | cache[directory] = wildcards |
| 314 | |
| 315 | return cache[directory] |
| 316 | |
| 317 | |
| 318 | def _path_is_ignored(path, cache): |
| 319 | """Check whether a path is ignored by _IGNORE_FILE. |
| 320 | |
| 321 | Args: |
| 322 | path: A string containing a path. |
| 323 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 324 | |
| 325 | Returns: |
| 326 | True if a file named _IGNORE_FILE in one of the passed-in path's parent |
| 327 | directories contains a wildcard matching the path. |
| 328 | """ |
| 329 | # Skip ignore files. |
| 330 | if os.path.basename(path) == _IGNORE_FILE: |
| 331 | return True |
| 332 | |
| 333 | path = os.path.abspath(path) |
| 334 | base = os.getcwd() |
| 335 | |
| 336 | prefix = os.path.dirname(path) |
| 337 | while prefix.startswith(base): |
| 338 | rel_path = path[len(prefix) + 1:] |
| 339 | for wildcard in _get_ignore_wildcards(prefix, cache): |
| 340 | if fnmatch.fnmatch(rel_path, wildcard): |
| 341 | return True |
| 342 | prefix = os.path.dirname(prefix) |
| 343 | |
| 344 | return False |
| 345 | |
| 346 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 347 | def _get_affected_files(commit, include_deletes=False, relative=False, |
| 348 | include_symlinks=False, include_adds=True, |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 349 | full_details=False, use_ignore_files=True): |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 350 | """Returns list of file paths that were modified/added, excluding symlinks. |
| 351 | |
| 352 | Args: |
| 353 | commit: The commit |
| 354 | include_deletes: If true, we'll include deleted files in the result |
| 355 | relative: Whether to return relative or full paths to files |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 356 | include_symlinks: If true, we'll include symlinks in the result |
| 357 | include_adds: If true, we'll include new files in the result |
| 358 | full_details: If False, return filenames, else return structured results. |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 359 | use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files. |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 360 | |
| 361 | Returns: |
| 362 | A list of modified/added (and perhaps deleted) files |
| 363 | """ |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 364 | if not relative and full_details: |
| 365 | raise ValueError('full_details only supports relative paths currently') |
| 366 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 367 | if commit == PRE_SUBMIT: |
| 368 | return _run_command(['git', 'diff-index', '--cached', |
| 369 | '--name-only', 'HEAD']).split() |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 370 | |
| 371 | path = os.getcwd() |
| 372 | files = git.RawDiff(path, '%s^!' % commit) |
| 373 | |
| 374 | # Filter out symlinks. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 375 | if not include_symlinks: |
| 376 | files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))] |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 377 | |
| 378 | if not include_deletes: |
| 379 | files = [x for x in files if x.status != 'D'] |
| 380 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 381 | if not include_adds: |
| 382 | files = [x for x in files if x.status != 'A'] |
| 383 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 384 | if use_ignore_files: |
| 385 | cache = {} |
| 386 | is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache) |
| 387 | files = [x for x in files if not is_ignored(x)] |
| 388 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 389 | if full_details: |
| 390 | # Caller wants the raw objects to parse status/etc... themselves. |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 391 | return files |
| 392 | else: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 393 | # Caller only cares about filenames. |
| 394 | files = [x.dst_file if x.dst_file else x.src_file for x in files] |
| 395 | if relative: |
| 396 | return files |
| 397 | else: |
| 398 | return [os.path.join(path, x) for x in files] |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 399 | |
| 400 | |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 401 | def _get_commits(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 402 | """Returns a list of commits for this review.""" |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 403 | cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H'] |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 404 | return _run_command(cmd).split() |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 405 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 406 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 407 | def _get_commit_desc(commit): |
| 408 | """Returns the full commit message of a commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 409 | if commit == PRE_SUBMIT: |
| 410 | return '' |
Sean Paul | 23a2c58 | 2011-05-06 13:10:44 -0400 | [diff] [blame] | 411 | return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!']) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 412 | |
| 413 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 414 | def _check_lines_in_diff(commit, files, check_callable, error_description): |
| 415 | """Checks given file for errors via the given check. |
| 416 | |
| 417 | This is a convenience function for common per-line checks. It goes through all |
| 418 | files and returns a HookFailure with the error description listing all the |
| 419 | failures. |
| 420 | |
| 421 | Args: |
| 422 | commit: The commit we're working on. |
| 423 | files: The files to check. |
| 424 | check_callable: A callable that takes a line and returns True if this line |
| 425 | _fails_ the check. |
| 426 | error_description: A string describing the error. |
| 427 | """ |
| 428 | errors = [] |
| 429 | for afile in files: |
| 430 | for line_num, line in _get_file_diff(afile, commit): |
| 431 | if check_callable(line): |
| 432 | errors.append('%s, line %s' % (afile, line_num)) |
| 433 | if errors: |
| 434 | return HookFailure(error_description, errors) |
| 435 | |
| 436 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 437 | def _parse_common_inclusion_options(options): |
| 438 | """Parses common hook options for including/excluding files. |
| 439 | |
| 440 | Args: |
| 441 | options: Option string list. |
| 442 | |
| 443 | Returns: |
| 444 | (included, excluded) where each one is a list of regex strings. |
| 445 | """ |
| 446 | parser = argparse.ArgumentParser() |
| 447 | parser.add_argument('--exclude_regex', action='append') |
| 448 | parser.add_argument('--include_regex', action='append') |
| 449 | opts = parser.parse_args(options) |
| 450 | included = opts.include_regex or [] |
| 451 | excluded = opts.exclude_regex or [] |
| 452 | return included, excluded |
| 453 | |
| 454 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 455 | # Common Hooks |
| 456 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 457 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 458 | def _check_no_long_lines(_project, commit, options=()): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 459 | """Checks there are no lines longer than MAX_LEN in any of the text files.""" |
| 460 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 461 | MAX_LEN = 80 |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 462 | SKIP_REGEXP = re.compile('|'.join([ |
| 463 | r'https?://', |
Maksim Ivanov | 3f677b9 | 2018-06-05 16:10:24 +0200 | [diff] [blame] | 464 | r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b'])) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 465 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 466 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 467 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 468 | included + COMMON_INCLUDED_PATHS, |
| 469 | excluded + COMMON_EXCLUDED_PATHS) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 470 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 471 | errors = [] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 472 | for afile in files: |
| 473 | for line_num, line in _get_file_diff(afile, commit): |
| 474 | # Allow certain lines to exceed the maxlen rule. |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 475 | if len(line) <= MAX_LEN or SKIP_REGEXP.search(line): |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 476 | continue |
| 477 | |
| 478 | errors.append('%s, line %s, %s chars' % (afile, line_num, len(line))) |
| 479 | if len(errors) == 5: # Just show the first 5 errors. |
| 480 | break |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 481 | |
| 482 | if errors: |
| 483 | msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 484 | return HookFailure(msg, errors) |
| 485 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 486 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 487 | def _check_no_stray_whitespace(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 488 | """Checks that there is no stray whitespace at source lines end.""" |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 489 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 490 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 491 | included + COMMON_INCLUDED_PATHS, |
| 492 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 493 | return _check_lines_in_diff(commit, files, |
| 494 | lambda line: line.rstrip() != line, |
| 495 | 'Found line ending with white space in:') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 496 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 497 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 498 | def _check_no_tabs(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 499 | """Checks there are no unexpanded tabs.""" |
Mike Frysinger | cd13451 | 2017-10-26 04:36:33 -0400 | [diff] [blame] | 500 | # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead. |
| 501 | # We only whitelist known specific filetypes here that show up in all repos. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 502 | TAB_OK_PATHS = [ |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 503 | r".*\.ebuild$", |
| 504 | r".*\.eclass$", |
Elly Jones | 5ab3419 | 2011-11-15 14:57:06 -0500 | [diff] [blame] | 505 | r".*/[M|m]akefile$", |
| 506 | r".*\.mk$" |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 507 | ] |
| 508 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 509 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 510 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 511 | included + COMMON_INCLUDED_PATHS, |
| 512 | excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 513 | return _check_lines_in_diff(commit, files, |
| 514 | lambda line: '\t' in line, |
| 515 | 'Found a tab character in:') |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 516 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 517 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 518 | def _check_tabbed_indents(_project, commit, options=()): |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 519 | """Checks that indents use tabs only.""" |
| 520 | TABS_REQUIRED_PATHS = [ |
| 521 | r".*\.ebuild$", |
| 522 | r".*\.eclass$", |
| 523 | ] |
| 524 | LEADING_SPACE_RE = re.compile('[\t]* ') |
| 525 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 526 | included, excluded = _parse_common_inclusion_options(options) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 527 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 528 | included + TABS_REQUIRED_PATHS, |
| 529 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 530 | return _check_lines_in_diff( |
| 531 | commit, files, |
| 532 | lambda line: LEADING_SPACE_RE.match(line) is not None, |
| 533 | 'Found a space in indentation (must be all tabs):') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 534 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 535 | |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 536 | def _check_gofmt(_project, commit): |
| 537 | """Checks that Go files are formatted with gofmt.""" |
| 538 | errors = [] |
| 539 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 540 | [r'\.go$']) |
| 541 | |
| 542 | for gofile in files: |
| 543 | contents = _get_file_content(gofile, commit) |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 544 | output = _run_command(cmd=['gofmt', '-l'], input=contents, |
| 545 | combine_stdout_stderr=True) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 546 | if output: |
| 547 | errors.append(gofile) |
| 548 | if errors: |
| 549 | return HookFailure('Files not formatted with gofmt:', errors) |
| 550 | |
| 551 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 552 | def _check_change_has_test_field(_project, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 553 | """Check for a non-empty 'TEST=' field in the commit message.""" |
David McMahon | 8f6553e | 2011-06-10 15:46:36 -0700 | [diff] [blame] | 554 | TEST_RE = r'\nTEST=\S+' |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 555 | |
Mandeep Singh Baines | 96a53be | 2011-05-03 11:10:25 -0700 | [diff] [blame] | 556 | if not re.search(TEST_RE, _get_commit_desc(commit)): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 557 | msg = 'Changelist description needs TEST field (after first line)' |
| 558 | return HookFailure(msg) |
| 559 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 560 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 561 | def _check_change_has_valid_cq_depend(_project, commit): |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 562 | """Check for a correctly formatted CQ-DEPEND field in the commit message.""" |
| 563 | msg = 'Changelist has invalid CQ-DEPEND target.' |
| 564 | example = 'Example: CQ-DEPEND=CL:1234, CL:2345' |
| 565 | try: |
| 566 | patch.GetPaladinDeps(_get_commit_desc(commit)) |
| 567 | except ValueError as ex: |
| 568 | return HookFailure(msg, [example, str(ex)]) |
| 569 | |
| 570 | |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 571 | def _check_change_is_contribution(_project, commit): |
| 572 | """Check that the change is a contribution.""" |
| 573 | NO_CONTRIB = 'not a contribution' |
| 574 | if NO_CONTRIB in _get_commit_desc(commit).lower(): |
| 575 | msg = ('Changelist is not a contribution, this cannot be accepted.\n' |
| 576 | 'Please remove the "%s" text from the commit message.') % NO_CONTRIB |
| 577 | return HookFailure(msg) |
| 578 | |
| 579 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 580 | def _check_change_has_bug_field(project, commit): |
David McMahon | 8f6553e | 2011-06-10 15:46:36 -0700 | [diff] [blame] | 581 | """Check for a correctly formatted 'BUG=' field in the commit message.""" |
David James | 5c0073d | 2013-04-03 08:48:52 -0700 | [diff] [blame] | 582 | OLD_BUG_RE = r'\nBUG=.*chromium-os' |
| 583 | if re.search(OLD_BUG_RE, _get_commit_desc(commit)): |
| 584 | msg = ('The chromium-os bug tracker is now deprecated. Please use\n' |
| 585 | 'the chromium tracker in your BUG= line now.') |
| 586 | return HookFailure(msg) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 587 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 588 | # Android internal and external projects use "Bug: " to track bugs in |
| 589 | # buganizer. |
| 590 | BUG_COLON_REMOTES = ( |
| 591 | 'aosp', |
| 592 | 'goog', |
| 593 | ) |
| 594 | if project.remote in BUG_COLON_REMOTES: |
| 595 | BUG_RE = r'\nBug: ?([Nn]one|\d+)' |
| 596 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 597 | msg = ('Changelist description needs BUG field (after first line):\n' |
| 598 | 'Bug: 9999 (for buganizer)\n' |
| 599 | 'BUG=None') |
| 600 | return HookFailure(msg) |
| 601 | else: |
Jorge Lucangeli Obes | dce214e | 2017-10-25 15:04:39 -0400 | [diff] [blame] | 602 | BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 603 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 604 | msg = ('Changelist description needs BUG field (after first line):\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 605 | 'BUG=chromium:9999 (for public tracker)\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 606 | 'BUG=b:9999 (for buganizer)\n' |
| 607 | 'BUG=None') |
| 608 | return HookFailure(msg) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 609 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 610 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 611 | def _check_for_uprev(project, commit, project_top=None): |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 612 | """Check that we're not missing a revbump of an ebuild in the given commit. |
| 613 | |
| 614 | If the given commit touches files in a directory that has ebuilds somewhere |
| 615 | up the directory hierarchy, it's very likely that we need an ebuild revbump |
| 616 | in order for those changes to take effect. |
| 617 | |
| 618 | It's not totally trivial to detect a revbump, so at least detect that an |
| 619 | ebuild with a revision number in it was touched. This should handle the |
| 620 | common case where we use a symlink to do the revbump. |
| 621 | |
| 622 | TODO: it would be nice to enhance this hook to: |
| 623 | * Handle cases where people revbump with a slightly different syntax. I see |
| 624 | one ebuild (puppy) that revbumps with _pN. This is a false positive. |
| 625 | * Catches cases where people aren't using symlinks for revbumps. If they |
| 626 | edit a revisioned file directly (and are expected to rename it for revbump) |
| 627 | we'll miss that. Perhaps we could detect that the file touched is a |
| 628 | symlink? |
| 629 | |
| 630 | If a project doesn't use symlinks we'll potentially miss a revbump, but we're |
| 631 | still better off than without this check. |
| 632 | |
| 633 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 634 | project: The Project to look at |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 635 | commit: The commit to look at |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 636 | project_top: Top dir to process commits in |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 637 | |
| 638 | Returns: |
| 639 | A HookFailure or None. |
| 640 | """ |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 641 | # If this is the portage-stable overlay, then ignore the check. It's rare |
| 642 | # that we're doing anything other than importing files from upstream, so |
| 643 | # forcing a rev bump makes no sense. |
| 644 | whitelist = ( |
| 645 | 'chromiumos/overlays/portage-stable', |
| 646 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 647 | if project.name in whitelist: |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 648 | return None |
| 649 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 650 | def FinalName(obj): |
| 651 | # If the file is being deleted, then the dst_file is not set. |
| 652 | if obj.dst_file is None: |
| 653 | return obj.src_file |
| 654 | else: |
| 655 | return obj.dst_file |
| 656 | |
| 657 | affected_path_objs = _get_affected_files( |
| 658 | commit, include_deletes=True, include_symlinks=True, relative=True, |
| 659 | full_details=True) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 660 | |
| 661 | # Don't yell about changes to whitelisted files... |
Aviv Keshet | 272f2e5 | 2016-04-25 14:49:44 -0700 | [diff] [blame] | 662 | whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini') |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 663 | affected_path_objs = [x for x in affected_path_objs |
| 664 | if os.path.basename(FinalName(x)) not in whitelist] |
| 665 | if not affected_path_objs: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 666 | return None |
| 667 | |
| 668 | # If we've touched any file named with a -rN.ebuild then we'll say we're |
| 669 | # OK right away. See TODO above about enhancing this. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 670 | touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x)) |
| 671 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 672 | if touched_revved_ebuild: |
| 673 | return None |
| 674 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 675 | # If we're creating new ebuilds from scratch, then we don't need an uprev. |
| 676 | # Find all the dirs that new ebuilds and ignore their files/. |
| 677 | ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs |
| 678 | if FinalName(x).endswith('.ebuild') and x.status == 'A'] |
| 679 | affected_path_objs = [obj for obj in affected_path_objs |
| 680 | if not any(FinalName(obj).startswith(x) |
| 681 | for x in ebuild_dirs)] |
| 682 | if not affected_path_objs: |
| 683 | return |
| 684 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 685 | # We want to examine the current contents of all directories that are parents |
| 686 | # of files that were touched (up to the top of the project). |
| 687 | # |
| 688 | # ...note: we use the current directory contents even though it may have |
| 689 | # changed since the commit we're looking at. This is just a heuristic after |
| 690 | # all. Worst case we don't flag a missing revbump. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 691 | if project_top is None: |
| 692 | project_top = os.getcwd() |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 693 | dirs_to_check = set([project_top]) |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 694 | for obj in affected_path_objs: |
| 695 | path = os.path.join(project_top, os.path.dirname(FinalName(obj))) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 696 | while os.path.exists(path) and not os.path.samefile(path, project_top): |
| 697 | dirs_to_check.add(path) |
| 698 | path = os.path.dirname(path) |
| 699 | |
| 700 | # Look through each directory. If it's got an ebuild in it then we'll |
| 701 | # consider this as a case when we need a revbump. |
Gwendal Grignou | a3086c3 | 2014-12-09 11:17:22 -0800 | [diff] [blame] | 702 | affected_paths = set(os.path.join(project_top, FinalName(x)) |
| 703 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 704 | for dir_path in dirs_to_check: |
| 705 | contents = os.listdir(dir_path) |
| 706 | ebuilds = [os.path.join(dir_path, path) |
| 707 | for path in contents if path.endswith('.ebuild')] |
| 708 | ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')] |
| 709 | |
C Shapiro | ae157ae | 2017-09-18 16:24:03 -0600 | [diff] [blame] | 710 | affected_paths_under_9999_ebuilds = set() |
| 711 | for affected_path in affected_paths: |
| 712 | for ebuild_9999 in ebuilds_9999: |
| 713 | ebuild_dir = os.path.dirname(ebuild_9999) |
| 714 | if affected_path.startswith(ebuild_dir): |
| 715 | affected_paths_under_9999_ebuilds.add(affected_path) |
| 716 | |
| 717 | # If every file changed exists under a 9999 ebuild, then skip |
| 718 | if len(affected_paths_under_9999_ebuilds) == len(affected_paths): |
| 719 | continue |
| 720 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 721 | # If the -9999.ebuild file was touched the bot will uprev for us. |
| 722 | # ...we'll use a simple intersection here as a heuristic... |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 723 | if set(ebuilds_9999) & affected_paths: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 724 | continue |
| 725 | |
| 726 | if ebuilds: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 727 | return HookFailure('Changelist probably needs a revbump of an ebuild, ' |
| 728 | 'or a -r1.ebuild symlink if this is a new ebuild:\n' |
| 729 | '%s' % dir_path) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 730 | |
| 731 | return None |
| 732 | |
| 733 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 734 | def _check_ebuild_eapi(project, commit): |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 735 | """Make sure we have people use EAPI=5 or newer with custom ebuilds. |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 736 | |
| 737 | We want to get away from older EAPI's as it makes life confusing and they |
| 738 | have less builtin error checking. |
| 739 | |
| 740 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 741 | project: The Project to look at |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 742 | commit: The commit to look at |
| 743 | |
| 744 | Returns: |
| 745 | A HookFailure or None. |
| 746 | """ |
| 747 | # If this is the portage-stable overlay, then ignore the check. It's rare |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 748 | # that we're doing anything other than importing files from upstream, and |
| 749 | # we shouldn't be rewriting things fundamentally anyways. |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 750 | whitelist = ( |
| 751 | 'chromiumos/overlays/portage-stable', |
| 752 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 753 | if project.name in whitelist: |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 754 | return None |
| 755 | |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 756 | BAD_EAPIS = ('0', '1', '2', '3', '4') |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 757 | |
| 758 | get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)') |
| 759 | |
| 760 | ebuilds_re = [r'\.ebuild$'] |
| 761 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 762 | ebuilds_re) |
| 763 | bad_ebuilds = [] |
| 764 | |
| 765 | for ebuild in ebuilds: |
| 766 | # If the ebuild does not specify an EAPI, it defaults to 0. |
| 767 | eapi = '0' |
| 768 | |
| 769 | lines = _get_file_content(ebuild, commit).splitlines() |
| 770 | if len(lines) == 1: |
| 771 | # This is most likely a symlink, so skip it entirely. |
| 772 | continue |
| 773 | |
| 774 | for line in lines: |
| 775 | m = get_eapi.match(line) |
| 776 | if m: |
| 777 | # Once we hit the first EAPI line in this ebuild, stop processing. |
| 778 | # The spec requires that there only be one and it be first, so |
| 779 | # checking all possible values is pointless. We also assume that |
| 780 | # it's "the" EAPI line and not something in the middle of a heredoc. |
| 781 | eapi = m.group(1) |
| 782 | break |
| 783 | |
| 784 | if eapi in BAD_EAPIS: |
| 785 | bad_ebuilds.append((ebuild, eapi)) |
| 786 | |
| 787 | if bad_ebuilds: |
| 788 | # pylint: disable=C0301 |
| 789 | url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis' |
| 790 | # pylint: enable=C0301 |
| 791 | return HookFailure( |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 792 | 'These ebuilds are using old EAPIs. If these are imported from\n' |
| 793 | 'Gentoo, then you may ignore and upload once with the --no-verify\n' |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 794 | 'flag. Otherwise, please update to 5 or newer.\n' |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 795 | '\t%s\n' |
| 796 | 'See this guide for more details:\n%s\n' % |
| 797 | ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url)) |
| 798 | |
| 799 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 800 | def _check_ebuild_keywords(_project, commit): |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 801 | """Make sure we use the new style KEYWORDS when possible in ebuilds. |
| 802 | |
| 803 | If an ebuild generally does not care about the arch it is running on, then |
| 804 | ebuilds should flag it with one of: |
| 805 | KEYWORDS="*" # A stable ebuild. |
| 806 | KEYWORDS="~*" # An unstable ebuild. |
| 807 | KEYWORDS="-* ..." # Is known to only work on specific arches. |
| 808 | |
| 809 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 810 | project: The Project to look at |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 811 | commit: The commit to look at |
| 812 | |
| 813 | Returns: |
| 814 | A HookFailure or None. |
| 815 | """ |
| 816 | WHITELIST = set(('*', '-*', '~*')) |
| 817 | |
| 818 | get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"') |
| 819 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 820 | ebuilds_re = [r'\.ebuild$'] |
| 821 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 822 | ebuilds_re) |
| 823 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 824 | bad_ebuilds = [] |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 825 | for ebuild in ebuilds: |
Mike Frysinger | 5c9e58d | 2014-09-09 03:32:50 -0400 | [diff] [blame] | 826 | # We get the full content rather than a diff as the latter does not work |
| 827 | # on new files (like when adding new ebuilds). |
| 828 | lines = _get_file_content(ebuild, commit).splitlines() |
| 829 | for line in lines: |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 830 | m = get_keywords.match(line) |
| 831 | if m: |
| 832 | keywords = set(m.group(1).split()) |
| 833 | if not keywords or WHITELIST - keywords != WHITELIST: |
| 834 | continue |
| 835 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 836 | bad_ebuilds.append(ebuild) |
| 837 | |
| 838 | if bad_ebuilds: |
| 839 | return HookFailure( |
| 840 | '%s\n' |
| 841 | 'Please update KEYWORDS to use a glob:\n' |
| 842 | 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n' |
| 843 | ' KEYWORDS="*"\n' |
| 844 | 'If the ebuild should be marked unstable (normal for ' |
| 845 | 'cros-workon / 9999 ebuilds):\n' |
| 846 | ' KEYWORDS="~*"\n' |
Mike Frysinger | de8efea | 2015-05-17 03:42:26 -0400 | [diff] [blame] | 847 | 'If the ebuild needs to be marked for only specific arches, ' |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 848 | 'then use -* like so:\n' |
| 849 | ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds)) |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 850 | |
| 851 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 852 | def _check_ebuild_licenses(_project, commit): |
| 853 | """Check if the LICENSE field in the ebuild is correct.""" |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 854 | affected_paths = _get_affected_files(commit, relative=True) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 855 | touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')] |
| 856 | |
| 857 | # A list of licenses to ignore for now. |
Yu-Ju Hong | c0963fa | 2014-03-03 12:36:52 -0800 | [diff] [blame] | 858 | LICENSES_IGNORE = ['||', '(', ')'] |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 859 | |
| 860 | for ebuild in touched_ebuilds: |
| 861 | # Skip virutal packages. |
| 862 | if ebuild.split('/')[-3] == 'virtual': |
| 863 | continue |
| 864 | |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 865 | # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay |
| 866 | overlay_path = os.sep.join(ebuild.split(os.sep)[:-3]) |
| 867 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 868 | try: |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 869 | ebuild_content = _get_file_content(ebuild, commit) |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 870 | license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content, |
| 871 | overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 872 | except ValueError as e: |
| 873 | return HookFailure(e.message, [ebuild]) |
| 874 | |
| 875 | # Also ignore licenses ending with '?' |
| 876 | for license_type in [x for x in license_types |
| 877 | if x not in LICENSES_IGNORE and not x.endswith('?')]: |
| 878 | try: |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 879 | licenses_lib.Licensing.FindLicenseType(license_type, |
| 880 | overlay_path=overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 881 | except AssertionError as e: |
| 882 | return HookFailure(e.message, [ebuild]) |
| 883 | |
| 884 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 885 | def _check_ebuild_virtual_pv(project, commit): |
| 886 | """Enforce the virtual PV policies.""" |
| 887 | # If this is the portage-stable overlay, then ignore the check. |
| 888 | # We want to import virtuals as-is from upstream Gentoo. |
| 889 | whitelist = ( |
| 890 | 'chromiumos/overlays/portage-stable', |
| 891 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 892 | if project.name in whitelist: |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 893 | return None |
| 894 | |
| 895 | # We assume the repo name is the same as the dir name on disk. |
| 896 | # It would be dumb to not have them match though. |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 897 | project_base = os.path.basename(project.name) |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 898 | |
| 899 | is_variant = lambda x: x.startswith('overlay-variant-') |
| 900 | is_board = lambda x: x.startswith('overlay-') |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 901 | is_baseboard = lambda x: x.startswith('baseboard-') |
| 902 | is_chipset = lambda x: x.startswith('chipset-') |
| 903 | is_project = lambda x: x.startswith('project-') |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 904 | is_private = lambda x: x.endswith('-private') |
| 905 | |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 906 | is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or |
| 907 | is_baseboard(x) or is_project(x)) |
| 908 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 909 | get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$') |
| 910 | |
| 911 | ebuilds_re = [r'\.ebuild$'] |
| 912 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 913 | ebuilds_re) |
| 914 | bad_ebuilds = [] |
| 915 | |
| 916 | for ebuild in ebuilds: |
| 917 | m = get_pv.match(ebuild) |
| 918 | if m: |
| 919 | overlay = m.group(1) |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 920 | if not overlay or not is_special_overlay(overlay): |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 921 | overlay = project_base |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 922 | |
| 923 | pv = m.group(3).split('-', 1)[0] |
| 924 | |
Bernie Thompson | e5ee182 | 2016-01-12 14:22:23 -0800 | [diff] [blame] | 925 | # Virtual versions >= 4 are special cases used above the standard |
| 926 | # versioning structure, e.g. if one has a board inheriting a board. |
| 927 | if float(pv) >= 4: |
| 928 | want_pv = pv |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 929 | elif is_board(overlay): |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 930 | if is_private(overlay): |
| 931 | want_pv = '3.5' if is_variant(overlay) else '3' |
| 932 | elif is_board(overlay): |
| 933 | want_pv = '2.5' if is_variant(overlay) else '2' |
| 934 | elif is_baseboard(overlay): |
| 935 | want_pv = '1.9' |
| 936 | elif is_chipset(overlay): |
| 937 | want_pv = '1.8' |
| 938 | elif is_project(overlay): |
| 939 | want_pv = '1.7' if is_private(overlay) else '1.5' |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 940 | else: |
| 941 | want_pv = '1' |
| 942 | |
| 943 | if pv != want_pv: |
| 944 | bad_ebuilds.append((ebuild, pv, want_pv)) |
| 945 | |
| 946 | if bad_ebuilds: |
| 947 | # pylint: disable=C0301 |
| 948 | url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management' |
| 949 | # pylint: enable=C0301 |
| 950 | return HookFailure( |
| 951 | 'These virtuals have incorrect package versions (PVs). Please adjust:\n' |
| 952 | '\t%s\n' |
| 953 | 'If this is an upstream Gentoo virtual, then you may ignore this\n' |
| 954 | 'check (and re-run w/--no-verify). Otherwise, please see this\n' |
| 955 | 'page for more details:\n%s\n' % |
| 956 | ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x |
| 957 | for x in bad_ebuilds]), url)) |
| 958 | |
| 959 | |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 960 | def _check_portage_make_use_var(_project, commit): |
| 961 | """Verify that $USE is set correctly in make.conf and make.defaults.""" |
| 962 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 963 | [r'(^|/)make.(conf|defaults)$']) |
| 964 | |
| 965 | errors = [] |
| 966 | for path in files: |
| 967 | basename = os.path.basename(path) |
| 968 | |
| 969 | # Has a USE= line already been encountered in this file? |
| 970 | saw_use = False |
| 971 | |
| 972 | for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1): |
| 973 | if not line.startswith('USE='): |
| 974 | continue |
| 975 | |
| 976 | preserves_use = '${USE}' in line or '$USE' in line |
| 977 | |
| 978 | if (basename == 'make.conf' or |
| 979 | (basename == 'make.defaults' and saw_use)) and not preserves_use: |
| 980 | errors.append('%s:%d: missing ${USE}' % (path, i)) |
| 981 | elif basename == 'make.defaults' and not saw_use and preserves_use: |
| 982 | errors.append('%s:%d: ${USE} referenced in initial declaration' % |
| 983 | (path, i)) |
| 984 | |
| 985 | saw_use = True |
| 986 | |
| 987 | if errors: |
| 988 | return HookFailure( |
| 989 | 'One or more Portage make files appear to set USE incorrectly.\n' |
| 990 | '\n' |
| 991 | 'All USE assignments in make.conf and all assignments after the\n' |
| 992 | 'initial declaration in make.defaults should contain "${USE}" to\n' |
| 993 | 'preserve previously-set flags.\n' |
| 994 | '\n' |
| 995 | 'The initial USE declaration in make.defaults should not contain\n' |
| 996 | '"${USE}".\n', |
| 997 | errors) |
| 998 | |
| 999 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1000 | def _check_change_has_proper_changeid(_project, commit): |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1001 | """Verify that Change-ID is present in last paragraph of commit message.""" |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1002 | CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n' |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1003 | desc = _get_commit_desc(commit) |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1004 | m = re.search(CHANGE_ID_RE, desc) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1005 | if not m: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1006 | return HookFailure('Last paragraph of description must include Change-Id.') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1007 | |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1008 | # S-o-b tags always allowed to follow Change-ID. |
| 1009 | allowed_tags = ['Signed-off-by'] |
| 1010 | |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1011 | end = desc[m.end():].strip().splitlines() |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1012 | cherry_pick_marker = 'cherry picked from commit' |
| 1013 | |
| 1014 | if end and cherry_pick_marker in end[-1]: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1015 | # Cherry picked patches allow more tags in the last paragraph. |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1016 | allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by', |
| 1017 | 'Reviewed-on', 'Tested-by'] |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1018 | end = end[:-1] |
| 1019 | |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1020 | # Note that descriptions could have multiple cherry pick markers. |
| 1021 | tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker) |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1022 | |
| 1023 | if [x for x in end if not re.search(tag_search, x)]: |
| 1024 | return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' % |
| 1025 | ':", "'.join(allowed_tags)) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1026 | |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1027 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1028 | def _check_commit_message_style(_project, commit): |
| 1029 | """Verify that the commit message matches our style. |
| 1030 | |
| 1031 | We do not check for BUG=/TEST=/etc... lines here as that is handled by other |
| 1032 | commit hooks. |
| 1033 | """ |
| 1034 | desc = _get_commit_desc(commit) |
| 1035 | |
| 1036 | # The first line should be by itself. |
| 1037 | lines = desc.splitlines() |
| 1038 | if len(lines) > 1 and lines[1]: |
| 1039 | return HookFailure('The second line of the commit message must be blank.') |
| 1040 | |
| 1041 | # The first line should be one sentence. |
| 1042 | if '. ' in lines[0]: |
| 1043 | return HookFailure('The first line cannot be more than one sentence.') |
| 1044 | |
| 1045 | # The first line cannot be too long. |
| 1046 | MAX_FIRST_LINE_LEN = 100 |
| 1047 | if len(lines[0]) > MAX_FIRST_LINE_LEN: |
| 1048 | return HookFailure('The first line must be less than %i chars.' % |
| 1049 | MAX_FIRST_LINE_LEN) |
| 1050 | |
| 1051 | |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1052 | def _check_cros_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1053 | """Verifies the Chromium OS license/copyright header. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1054 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1055 | Should be following the spec: |
| 1056 | http://dev.chromium.org/developers/coding-style#TOC-File-headers |
| 1057 | """ |
| 1058 | # For older years, be a bit more flexible as our policy says leave them be. |
| 1059 | LICENSE_HEADER = ( |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1060 | r'.*Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1061 | r'All rights reserved\.' r'\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1062 | r'.*Use of this source code is governed by a BSD-style license that can ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1063 | r'be\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1064 | r'.*found in the LICENSE file\.' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1065 | r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1066 | ) |
| 1067 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1068 | |
| 1069 | # For newer years, be stricter. |
| 1070 | COPYRIGHT_LINE = ( |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1071 | r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1072 | r'All rights reserved\.' r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1073 | ) |
| 1074 | copyright_re = re.compile(COPYRIGHT_LINE) |
| 1075 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 1076 | included, excluded = _parse_common_inclusion_options(options) |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1077 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1078 | bad_files = [] |
| 1079 | bad_copyright_files = [] |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1080 | files = _filter_files( |
| 1081 | _get_affected_files(commit, relative=True), |
| 1082 | included + COMMON_INCLUDED_PATHS, |
| 1083 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1084 | |
| 1085 | for f in files: |
| 1086 | contents = _get_file_content(f, commit) |
| 1087 | if not contents: |
| 1088 | # Ignore empty files. |
| 1089 | continue |
| 1090 | |
| 1091 | if not license_re.search(contents): |
| 1092 | bad_files.append(f) |
| 1093 | elif copyright_re.search(contents): |
| 1094 | bad_copyright_files.append(f) |
| 1095 | |
| 1096 | if bad_files: |
| 1097 | msg = '%s:\n%s\n%s' % ( |
| 1098 | 'License must match', license_re.pattern, |
| 1099 | 'Found a bad header in these files:') |
| 1100 | return HookFailure(msg, bad_files) |
| 1101 | |
| 1102 | if bad_copyright_files: |
| 1103 | msg = 'Do not use (c) in copyright headers in new files:' |
| 1104 | return HookFailure(msg, bad_copyright_files) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1105 | |
| 1106 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1107 | def _check_aosp_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1108 | """Verifies the AOSP license/copyright header. |
| 1109 | |
| 1110 | AOSP uses the Apache2 License: |
| 1111 | https://source.android.com/source/licenses.html |
| 1112 | """ |
| 1113 | LICENSE_HEADER = ( |
| 1114 | r"""^[#/\*]* |
| 1115 | [#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project |
| 1116 | [#/\*]* ? |
| 1117 | [#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\); |
| 1118 | [#/\*]* ?you may not use this file except in compliance with the License\. |
| 1119 | [#/\*]* ?You may obtain a copy of the License at |
| 1120 | [#/\*]* ? |
| 1121 | [#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0 |
| 1122 | [#/\*]* ? |
| 1123 | [#/\*]* ?Unless required by applicable law or agreed to in writing, software |
| 1124 | [#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS, |
| 1125 | [#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """ |
| 1126 | r"""implied\. |
| 1127 | [#/\*]* ?See the License for the specific language governing permissions and |
| 1128 | [#/\*]* ?limitations under the License\. |
| 1129 | [#/\*]*$ |
| 1130 | """ |
| 1131 | ) |
| 1132 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1133 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1134 | included, excluded = _parse_common_inclusion_options(options) |
| 1135 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1136 | files = _filter_files( |
| 1137 | _get_affected_files(commit, relative=True), |
| 1138 | included + COMMON_INCLUDED_PATHS, |
| 1139 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1140 | |
| 1141 | bad_files = [] |
| 1142 | for f in files: |
| 1143 | contents = _get_file_content(f, commit) |
| 1144 | if not contents: |
| 1145 | # Ignore empty files. |
| 1146 | continue |
| 1147 | |
| 1148 | if not license_re.search(contents): |
| 1149 | bad_files.append(f) |
| 1150 | |
| 1151 | if bad_files: |
| 1152 | msg = ('License must match:\n%s\nFound a bad header in these files:' % |
| 1153 | license_re.pattern) |
| 1154 | return HookFailure(msg, bad_files) |
| 1155 | |
| 1156 | |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1157 | def _check_layout_conf(_project, commit): |
| 1158 | """Verifies the metadata/layout.conf file.""" |
| 1159 | repo_name = 'profiles/repo_name' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1160 | repo_names = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1161 | layout_path = 'metadata/layout.conf' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1162 | layout_paths = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1163 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1164 | # Handle multiple overlays in a single commit (like the public tree). |
| 1165 | for f in _get_affected_files(commit, relative=True): |
| 1166 | if f.endswith(repo_name): |
| 1167 | repo_names.append(f) |
| 1168 | elif f.endswith(layout_path): |
| 1169 | layout_paths.append(f) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1170 | |
| 1171 | # Disallow new repos with the repo_name file. |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1172 | if repo_names: |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1173 | return HookFailure('%s: use "repo-name" in %s instead' % |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1174 | (repo_names, layout_path)) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1175 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1176 | # Gather all the errors in one pass so we show one full message. |
| 1177 | all_errors = {} |
| 1178 | for layout_path in layout_paths: |
| 1179 | all_errors[layout_path] = errors = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1180 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1181 | # Make sure the config file is sorted. |
| 1182 | data = [x for x in _get_file_content(layout_path, commit).splitlines() |
| 1183 | if x and x[0] != '#'] |
| 1184 | if sorted(data) != data: |
| 1185 | errors += ['keep lines sorted'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1186 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1187 | # Require people to set specific values all the time. |
| 1188 | settings = ( |
| 1189 | # TODO: Enable this for everyone. http://crbug.com/408038 |
| 1190 | #('fast caching', 'cache-format = md5-dict'), |
| 1191 | ('fast manifests', 'thin-manifests = true'), |
Mike Frysinger | d773452 | 2015-02-26 16:12:43 -0500 | [diff] [blame] | 1192 | ('extra features', 'profile-formats = portage-2 profile-default-eapi'), |
| 1193 | ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'), |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1194 | ) |
| 1195 | for reason, line in settings: |
| 1196 | if line not in data: |
| 1197 | errors += ['enable %s with: %s' % (reason, line)] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1198 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1199 | # Require one of these settings. |
Mike Frysinger | 5fae62d | 2015-11-11 20:12:15 -0500 | [diff] [blame] | 1200 | if 'use-manifests = strict' not in data: |
| 1201 | errors += ['enable file checking with: use-manifests = strict'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1202 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1203 | # Require repo-name to be set. |
Mike Frysinger | 324cf68 | 2014-09-22 15:52:50 -0400 | [diff] [blame] | 1204 | for line in data: |
| 1205 | if line.startswith('repo-name = '): |
| 1206 | break |
| 1207 | else: |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1208 | errors += ['set the board name with: repo-name = $BOARD'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1209 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1210 | # Summarize all the errors we saw (if any). |
| 1211 | lines = '' |
| 1212 | for layout_path, errors in all_errors.items(): |
| 1213 | if errors: |
| 1214 | lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors) |
| 1215 | if lines: |
| 1216 | lines = 'See the portage(5) man page for layout.conf details' + lines + '\n' |
| 1217 | return HookFailure(lines) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1218 | |
| 1219 | |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame^] | 1220 | def _check_no_new_gyp(_project, commit): |
| 1221 | """Verifies no project starts to use GYP.""" |
| 1222 | whitelist = [ |
| 1223 | 'aosp/platform/system/update_engine', |
| 1224 | 'chromeos/ap', |
| 1225 | 'chromeos/ap-daemons', |
| 1226 | 'chromeos/platform/actions', |
| 1227 | 'chromeos/platform/arc-oemcrypto', |
| 1228 | 'chromeos/platform/drivefs', |
| 1229 | 'chromeos/platform/drivefs-google3', |
| 1230 | 'chromeos/platform/experimental-touch-fw', |
| 1231 | 'chromeos/platform/gdisp', |
| 1232 | 'chromeos/platform/nest-nn', |
| 1233 | 'chromeos/platform/whisper', |
| 1234 | 'chromeos/thermald', |
| 1235 | 'chromeos/vendor/fibocom-firmware', |
| 1236 | 'chromiumos/platform/cfm-device-monitor', |
| 1237 | 'chromiumos/platform/google-breakpad', |
| 1238 | 'chromiumos/platform2', |
| 1239 | 'chromiumos/third_party/atrusctl', |
| 1240 | 'chromiumos/third_party/virtual-usb-printer', |
| 1241 | 'weave/libweave', |
| 1242 | ] |
| 1243 | if _project.name in whitelist: |
| 1244 | return None |
| 1245 | |
| 1246 | gypfiles = _filter_files( |
| 1247 | _get_affected_files(commit, include_symlinks=True, relative=True), |
| 1248 | [r'\.gyp$']) |
| 1249 | |
| 1250 | if gypfiles: |
| 1251 | return HookFailure('GYP is deprecated and not allowed in a new project:', |
| 1252 | gypfiles) |
| 1253 | |
| 1254 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1255 | # Project-specific hooks |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1256 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1257 | |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1258 | def _check_clang_format(_project, commit, options=()): |
| 1259 | """Runs clang-format on the given project""" |
| 1260 | hooks_dir = _get_hooks_dir() |
| 1261 | options = list(options) |
| 1262 | if commit == PRE_SUBMIT: |
| 1263 | options.append('--commit=HEAD') |
| 1264 | else: |
| 1265 | options.extend(['--commit', commit]) |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1266 | cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1267 | cmd_result = cros_build_lib.RunCommand(cmd=cmd, |
| 1268 | print_cmd=False, |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1269 | stdout_to_pipe=True, |
| 1270 | combine_stdout_stderr=True, |
| 1271 | error_code_ok=True) |
| 1272 | if cmd_result.returncode: |
| 1273 | return HookFailure('clang-format.py errors/warnings\n\n' + |
| 1274 | cmd_result.output) |
| 1275 | |
| 1276 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1277 | def _run_checkpatch(_project, commit, options=()): |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1278 | """Runs checkpatch.pl on the given project""" |
| 1279 | hooks_dir = _get_hooks_dir() |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1280 | options = list(options) |
| 1281 | if commit == PRE_SUBMIT: |
| 1282 | # The --ignore option must be present and include 'MISSING_SIGN_OFF' in |
| 1283 | # this case. |
| 1284 | options.append('--ignore=MISSING_SIGN_OFF') |
Filipe Brandenburger | 28d48d6 | 2015-10-07 09:48:54 -0700 | [diff] [blame] | 1285 | # Always ignore the check for the MAINTAINERS file. We do not track that |
| 1286 | # information on that file in our source trees, so let's suppress the |
| 1287 | # warning. |
| 1288 | options.append('--ignore=FILE_PATH_CHANGES') |
Filipe Brandenburger | ce97832 | 2015-10-09 10:04:15 -0700 | [diff] [blame] | 1289 | # Do not complain about the Change-Id: fields, since we use Gerrit. |
| 1290 | # Upstream does not want those lines (since they do not use Gerrit), but |
| 1291 | # we always do, so disable the check globally. |
Daisuke Nojiri | 4844f89 | 2015-10-08 09:54:33 -0700 | [diff] [blame] | 1292 | options.append('--ignore=GERRIT_CHANGE_ID') |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1293 | cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-'] |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1294 | cmd_result = cros_build_lib.RunCommand(cmd=cmd, |
| 1295 | print_cmd=False, |
| 1296 | input=_get_patch(commit), |
| 1297 | stdout_to_pipe=True, |
| 1298 | combine_stdout_stderr=True, |
| 1299 | error_code_ok=True) |
| 1300 | if cmd_result.returncode: |
| 1301 | return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1302 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1303 | |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1304 | def _run_kerneldoc(_project, commit, options=()): |
| 1305 | """Runs kernel-doc validator on the given project""" |
| 1306 | included, excluded = _parse_common_inclusion_options(options) |
| 1307 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1308 | included, excluded) |
| 1309 | if files: |
| 1310 | hooks_dir = _get_hooks_dir() |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1311 | cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1312 | output = _run_command(cmd=cmd, combine_stdout_stderr=True) |
| 1313 | if output: |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1314 | return HookFailure('kernel-doc errors/warnings:', |
| 1315 | items=output.splitlines()) |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1316 | |
| 1317 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1318 | def _kernel_configcheck(_project, commit): |
Olof Johansson | a96810f | 2012-09-04 16:20:03 -0700 | [diff] [blame] | 1319 | """Makes sure kernel config changes are not mixed with code changes""" |
| 1320 | files = _get_affected_files(commit) |
| 1321 | if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]: |
| 1322 | return HookFailure('Changes to chromeos/config/ and regular files must ' |
| 1323 | 'be in separate commits:\n%s' % '\n'.join(files)) |
Anton Staaf | 815d685 | 2011-08-22 10:08:45 -0700 | [diff] [blame] | 1324 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1325 | |
| 1326 | def _run_json_check(_project, commit): |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1327 | """Checks that all JSON files are syntactically valid.""" |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1328 | ret = [] |
| 1329 | |
| 1330 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1331 | [r'.*\.json$']) |
| 1332 | for f in files: |
| 1333 | data = _get_file_content(f, commit) |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1334 | try: |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1335 | json.loads(data) |
| 1336 | except Exception as e: |
| 1337 | ret.append('%s: Invalid JSON: %s' % (f, e)) |
| 1338 | |
| 1339 | if ret: |
| 1340 | return HookFailure('\n'.join(ret)) |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1341 | |
| 1342 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1343 | def _check_manifests(_project, commit): |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1344 | """Make sure Manifest files only have comments & DIST lines.""" |
| 1345 | ret = [] |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1346 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1347 | manifests = _filter_files(_get_affected_files(commit, relative=True), |
| 1348 | [r'.*/Manifest$']) |
| 1349 | for path in manifests: |
| 1350 | data = _get_file_content(path, commit) |
| 1351 | |
| 1352 | # Disallow blank files. |
| 1353 | if not data.strip(): |
| 1354 | ret.append('%s: delete empty file' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1355 | continue |
| 1356 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1357 | # Make sure the last newline isn't omitted. |
| 1358 | if data[-1] != '\n': |
| 1359 | ret.append('%s: missing trailing newline' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1360 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1361 | # Do not allow leading or trailing blank lines. |
| 1362 | lines = data.splitlines() |
| 1363 | if not lines[0]: |
| 1364 | ret.append('%s: delete leading blank lines' % (path,)) |
| 1365 | if not lines[-1]: |
| 1366 | ret.append('%s: delete trailing blank lines' % (path,)) |
| 1367 | |
| 1368 | for line in lines: |
| 1369 | # Disallow leading/trailing whitespace. |
| 1370 | if line != line.strip(): |
| 1371 | ret.append('%s: remove leading/trailing whitespace: %s' % (path, line)) |
| 1372 | |
| 1373 | # Allow blank lines & comments. |
| 1374 | line = line.split('#', 1)[0] |
| 1375 | if not line: |
| 1376 | continue |
| 1377 | |
| 1378 | # All other linse should start with DIST. |
| 1379 | if not line.startswith('DIST '): |
| 1380 | ret.append('%s: remove non-DIST lines: %s' % (path, line)) |
| 1381 | break |
| 1382 | |
| 1383 | if ret: |
| 1384 | return HookFailure('\n'.join(ret)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1385 | |
| 1386 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1387 | def _check_change_has_branch_field(_project, commit): |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1388 | """Check for a non-empty 'BRANCH=' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1389 | if commit == PRE_SUBMIT: |
| 1390 | return |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1391 | BRANCH_RE = r'\nBRANCH=\S+' |
| 1392 | |
| 1393 | if not re.search(BRANCH_RE, _get_commit_desc(commit)): |
| 1394 | msg = ('Changelist description needs BRANCH field (after first line)\n' |
| 1395 | 'E.g. BRANCH=none or BRANCH=link,snow') |
| 1396 | return HookFailure(msg) |
| 1397 | |
| 1398 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1399 | def _check_change_has_signoff_field(_project, commit): |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1400 | """Check for a non-empty 'Signed-off-by:' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1401 | if commit == PRE_SUBMIT: |
| 1402 | return |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1403 | SIGNOFF_RE = r'\nSigned-off-by: \S+' |
| 1404 | |
| 1405 | if not re.search(SIGNOFF_RE, _get_commit_desc(commit)): |
| 1406 | msg = ('Changelist description needs Signed-off-by: field\n' |
| 1407 | 'E.g. Signed-off-by: My Name <me@chromium.org>') |
| 1408 | return HookFailure(msg) |
| 1409 | |
| 1410 | |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1411 | def _check_cq_ini_well_formed(_project, commit): |
| 1412 | """Check that any modified COMMIT-QUEUE.ini files are well formed.""" |
| 1413 | pattern = '.*' + constants.CQ_CONFIG_FILENAME |
Mike Frysinger | d052344 | 2018-01-03 17:05:29 -0500 | [diff] [blame] | 1414 | files = _filter_files(_get_affected_files(commit, relative=True), (pattern,)) |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1415 | |
| 1416 | # TODO(akeshet): Check not only that the file is parseable, but that all the |
| 1417 | # pre-cq configs it requests are existing ones. |
| 1418 | for f in files: |
| 1419 | try: |
| 1420 | parser = ConfigParser.SafeConfigParser() |
| 1421 | # Prior to python3, ConfigParser has no read_string method, so we must |
| 1422 | # pass it either a file path or file like object. And we must use |
| 1423 | # _get_file_content to fetch file contents to ensure we are examining the |
| 1424 | # commit diff, rather than whatever's on disk. |
| 1425 | contents = _get_file_content(f, commit) |
| 1426 | parser.readfp(StringIO.StringIO(contents)) |
| 1427 | except ConfigParser.Error as e: |
| 1428 | msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' % |
| 1429 | (f, e)) |
| 1430 | return HookFailure(msg) |
| 1431 | |
| 1432 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1433 | def _run_project_hook_script(script, project, commit): |
| 1434 | """Runs a project hook script. |
| 1435 | |
| 1436 | The script is run with the following environment variables set: |
| 1437 | PRESUBMIT_PROJECT: The affected project |
| 1438 | PRESUBMIT_COMMIT: The affected commit |
| 1439 | PRESUBMIT_FILES: A newline-separated list of affected files |
| 1440 | |
| 1441 | The script is considered to fail if the exit code is non-zero. It should |
| 1442 | write an error message to stdout. |
| 1443 | """ |
| 1444 | env = dict(os.environ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1445 | env['PRESUBMIT_PROJECT'] = project.name |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1446 | env['PRESUBMIT_COMMIT'] = commit |
| 1447 | |
| 1448 | # Put affected files in an environment variable |
| 1449 | files = _get_affected_files(commit) |
| 1450 | env['PRESUBMIT_FILES'] = '\n'.join(files) |
| 1451 | |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1452 | cmd_result = cros_build_lib.RunCommand(cmd=script, |
| 1453 | env=env, |
| 1454 | shell=True, |
| 1455 | print_cmd=False, |
| 1456 | input=os.devnull, |
| 1457 | stdout_to_pipe=True, |
| 1458 | combine_stdout_stderr=True, |
| 1459 | error_code_ok=True) |
| 1460 | if cmd_result.returncode: |
| 1461 | stdout = cmd_result.output |
Jon Salz | 7b618af | 2012-08-31 06:03:16 +0800 | [diff] [blame] | 1462 | if stdout: |
| 1463 | stdout = re.sub('(?m)^', ' ', stdout) |
| 1464 | return HookFailure('Hook script "%s" failed with code %d%s' % |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1465 | (script, cmd_result.returncode, |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1466 | ':\n' + stdout if stdout else '')) |
| 1467 | |
| 1468 | |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1469 | def _check_project_prefix(_project, commit): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1470 | """Require the commit message have a project specific prefix as needed.""" |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1471 | |
Brian Norris | 77608e1 | 2018-04-06 10:38:43 -0700 | [diff] [blame] | 1472 | files = _get_affected_files(commit, include_deletes=True, relative=True) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1473 | prefix = os.path.commonprefix(files) |
| 1474 | prefix = os.path.dirname(prefix) |
| 1475 | |
| 1476 | # If there is no common prefix, the CL span multiple projects. |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1477 | if not prefix: |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1478 | return |
| 1479 | |
| 1480 | project_name = prefix.split('/')[0] |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1481 | |
| 1482 | # The common files may all be within a subdirectory of the main project |
| 1483 | # directory, so walk up the tree until we find an alias file. |
| 1484 | # _get_affected_files() should return relative paths, but check against '/' to |
| 1485 | # ensure that this loop terminates even if it receives an absolute path. |
| 1486 | while prefix and prefix != '/': |
| 1487 | alias_file = os.path.join(prefix, '.project_alias') |
| 1488 | |
| 1489 | # If an alias exists, use it. |
| 1490 | if os.path.isfile(alias_file): |
| 1491 | project_name = osutils.ReadFile(alias_file).strip() |
| 1492 | |
| 1493 | prefix = os.path.dirname(prefix) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1494 | |
| 1495 | if not _get_commit_desc(commit).startswith(project_name + ': '): |
| 1496 | return HookFailure('The commit title for changes affecting only %s' |
| 1497 | ' should start with \"%s: \"' |
| 1498 | % (project_name, project_name)) |
| 1499 | |
| 1500 | |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1501 | def _check_filepath_chartype(_project, commit): |
| 1502 | """Checks that FilePath::CharType stuff is not used.""" |
| 1503 | |
| 1504 | FILEPATH_REGEXP = re.compile('|'.join( |
| 1505 | [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type', |
Satoru Takabayashi | 4ca3792 | 2018-08-08 10:16:38 +0900 | [diff] [blame] | 1506 | r'(?:base::)?FilePath::FromUTF8Unsafe', |
| 1507 | r'AsUTF8Unsafe', |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1508 | r'FILE_PATH_LITERAL'])) |
| 1509 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1510 | [r'.*\.(cc|h)$']) |
| 1511 | |
| 1512 | errors = [] |
| 1513 | for afile in files: |
| 1514 | for line_num, line in _get_file_diff(afile, commit): |
| 1515 | m = re.search(FILEPATH_REGEXP, line) |
| 1516 | if m: |
| 1517 | errors.append('%s, line %s has %s' % (afile, line_num, m.group(0))) |
| 1518 | |
| 1519 | if errors: |
| 1520 | msg = 'Please assume FilePath::CharType is char (crbug.com/870621):' |
| 1521 | return HookFailure(msg, errors) |
| 1522 | |
| 1523 | |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1524 | def _check_exec_files(_project, commit): |
| 1525 | """Make +x bits on files.""" |
| 1526 | # List of files that should never be +x. |
| 1527 | NO_EXEC = ( |
| 1528 | 'ChangeLog*', |
| 1529 | 'COPYING', |
| 1530 | 'make.conf', |
| 1531 | 'make.defaults', |
| 1532 | 'Manifest', |
| 1533 | 'OWNERS', |
| 1534 | 'package.use', |
| 1535 | 'package.keywords', |
| 1536 | 'package.mask', |
| 1537 | 'parent', |
| 1538 | 'README', |
| 1539 | 'TODO', |
| 1540 | '.gitignore', |
| 1541 | '*.[achly]', |
| 1542 | '*.[ch]xx', |
| 1543 | '*.boto', |
| 1544 | '*.cc', |
| 1545 | '*.cfg', |
| 1546 | '*.conf', |
| 1547 | '*.config', |
| 1548 | '*.cpp', |
| 1549 | '*.css', |
| 1550 | '*.ebuild', |
| 1551 | '*.eclass', |
Tatsuhisa Yamaguchi | 3b05363 | 2019-01-10 14:45:14 +0900 | [diff] [blame] | 1552 | '*.gn', |
| 1553 | '*.gni', |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1554 | '*.gyp', |
| 1555 | '*.gypi', |
| 1556 | '*.htm', |
| 1557 | '*.html', |
| 1558 | '*.ini', |
| 1559 | '*.js', |
| 1560 | '*.json', |
| 1561 | '*.md', |
| 1562 | '*.mk', |
| 1563 | '*.patch', |
| 1564 | '*.policy', |
| 1565 | '*.proto', |
| 1566 | '*.raw', |
| 1567 | '*.rules', |
| 1568 | '*.service', |
| 1569 | '*.target', |
| 1570 | '*.txt', |
| 1571 | '*.xml', |
| 1572 | '*.yaml', |
| 1573 | ) |
| 1574 | |
| 1575 | def FinalName(obj): |
| 1576 | # If the file is being deleted, then the dst_file is not set. |
| 1577 | if obj.dst_file is None: |
| 1578 | return obj.src_file |
| 1579 | else: |
| 1580 | return obj.dst_file |
| 1581 | |
| 1582 | bad_files = [] |
| 1583 | files = _get_affected_files(commit, relative=True, full_details=True) |
| 1584 | for f in files: |
| 1585 | mode = int(f.dst_mode, 8) |
| 1586 | if not mode & 0o111: |
| 1587 | continue |
| 1588 | name = FinalName(f) |
| 1589 | for no_exec in NO_EXEC: |
| 1590 | if fnmatch.fnmatch(name, no_exec): |
| 1591 | bad_files.append(name) |
| 1592 | break |
| 1593 | |
| 1594 | if bad_files: |
| 1595 | return HookFailure('These files should not be executable. ' |
| 1596 | 'Please `chmod -x` them.', bad_files) |
| 1597 | |
| 1598 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1599 | # Base |
| 1600 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1601 | # A list of hooks which are not project specific and check patch description |
| 1602 | # (as opposed to patch body). |
| 1603 | _PATCH_DESCRIPTION_HOOKS = [ |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1604 | _check_change_has_bug_field, |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 1605 | _check_change_has_valid_cq_depend, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1606 | _check_change_has_test_field, |
| 1607 | _check_change_has_proper_changeid, |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1608 | _check_commit_message_style, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 1609 | _check_change_is_contribution, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1610 | ] |
| 1611 | |
| 1612 | |
| 1613 | # A list of hooks that are not project-specific |
| 1614 | _COMMON_HOOKS = [ |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1615 | _check_cq_ini_well_formed, |
| 1616 | _check_cros_license, |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1617 | _check_ebuild_eapi, |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 1618 | _check_ebuild_keywords, |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1619 | _check_ebuild_licenses, |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1620 | _check_ebuild_virtual_pv, |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1621 | _check_exec_files, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1622 | _check_for_uprev, |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 1623 | _check_gofmt, |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1624 | _check_layout_conf, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1625 | _check_no_long_lines, |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame^] | 1626 | _check_no_new_gyp, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1627 | _check_no_stray_whitespace, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1628 | _check_no_tabs, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1629 | _check_portage_make_use_var, |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1630 | _check_tabbed_indents, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1631 | ] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1632 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1633 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1634 | # A dictionary of project-specific hooks(callbacks), indexed by project name. |
| 1635 | # dict[project] = [callback1, callback2] |
| 1636 | _PROJECT_SPECIFIC_HOOKS = { |
Mike Frysinger | af89129 | 2015-03-25 19:46:53 -0400 | [diff] [blame] | 1637 | "chromiumos/third_party/kernel": [_kernel_configcheck], |
| 1638 | "chromiumos/third_party/kernel-next": [_kernel_configcheck], |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1639 | } |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1640 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1641 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1642 | # A dictionary of flags (keys) that can appear in the config file, and the hook |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1643 | # that the flag controls (value). |
| 1644 | _HOOK_FLAGS = { |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1645 | 'clang_format_check': _check_clang_format, |
Mike Frysinger | a7642f5 | 2015-03-25 18:31:42 -0400 | [diff] [blame] | 1646 | 'checkpatch_check': _run_checkpatch, |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1647 | 'kerneldoc_check': _run_kerneldoc, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1648 | 'stray_whitespace_check': _check_no_stray_whitespace, |
Mike Frysinger | ff6c7d6 | 2015-03-24 13:49:46 -0400 | [diff] [blame] | 1649 | 'json_check': _run_json_check, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1650 | 'long_line_check': _check_no_long_lines, |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1651 | 'cros_license_check': _check_cros_license, |
| 1652 | 'aosp_license_check': _check_aosp_license, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1653 | 'tab_check': _check_no_tabs, |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 1654 | 'tabbed_indent_required_check': _check_tabbed_indents, |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1655 | 'branch_check': _check_change_has_branch_field, |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1656 | 'signoff_check': _check_change_has_signoff_field, |
Josh Triplett | 0e8fc7f | 2014-04-23 16:00:00 -0700 | [diff] [blame] | 1657 | 'bug_field_check': _check_change_has_bug_field, |
| 1658 | 'test_field_check': _check_change_has_test_field, |
Steve Fung | 49ec7e9 | 2015-03-23 16:07:12 -0700 | [diff] [blame] | 1659 | 'manifest_check': _check_manifests, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 1660 | 'contribution_check': _check_change_is_contribution, |
Mike Frysinger | 47bd125 | 2018-06-11 12:12:20 -0400 | [diff] [blame] | 1661 | 'project_prefix_check': _check_project_prefix, |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1662 | 'filepath_chartype_check': _check_filepath_chartype, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1663 | } |
| 1664 | |
| 1665 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1666 | def _get_override_hooks(config): |
| 1667 | """Returns a set of hooks controlled by the current project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1668 | |
| 1669 | Expects to be called within the project root. |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1670 | |
| 1671 | Args: |
| 1672 | config: A ConfigParser for the project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1673 | """ |
| 1674 | SECTION = 'Hook Overrides' |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1675 | SECTION_OPTIONS = 'Hook Overrides Options' |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1676 | if not config.has_section(SECTION): |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1677 | return set(), set() |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1678 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1679 | valid_keys = set(_HOOK_FLAGS.iterkeys()) |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1680 | hooks = _HOOK_FLAGS.copy() |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1681 | |
| 1682 | enable_flags = [] |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1683 | disable_flags = [] |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1684 | for flag in config.options(SECTION): |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1685 | if flag not in valid_keys: |
| 1686 | raise ValueError('Error: unknown key "%s" in hook section of "%s"' % |
| 1687 | (flag, _CONFIG_FILE)) |
| 1688 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1689 | try: |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1690 | enabled = config.getboolean(SECTION, flag) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1691 | except ValueError as e: |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1692 | raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' % |
| 1693 | (flag, _CONFIG_FILE, e)) |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1694 | if enabled: |
| 1695 | enable_flags.append(flag) |
| 1696 | else: |
| 1697 | disable_flags.append(flag) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1698 | |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1699 | # See if this hook has custom options. |
| 1700 | if enabled: |
| 1701 | try: |
| 1702 | options = config.get(SECTION_OPTIONS, flag) |
| 1703 | hooks[flag] = functools.partial(hooks[flag], options=options.split()) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1704 | hooks[flag].__name__ = flag |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1705 | except (ConfigParser.NoOptionError, ConfigParser.NoSectionError): |
| 1706 | pass |
| 1707 | |
| 1708 | enabled_hooks = set(hooks[x] for x in enable_flags) |
| 1709 | disabled_hooks = set(hooks[x] for x in disable_flags) |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1710 | return enabled_hooks, disabled_hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1711 | |
| 1712 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1713 | def _get_project_hook_scripts(config): |
| 1714 | """Returns a list of project-specific hook scripts. |
| 1715 | |
| 1716 | Args: |
| 1717 | config: A ConfigParser for the project's config file. |
| 1718 | """ |
| 1719 | SECTION = 'Hook Scripts' |
| 1720 | if not config.has_section(SECTION): |
| 1721 | return [] |
| 1722 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1723 | return config.items(SECTION) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1724 | |
| 1725 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1726 | def _get_project_hooks(project, presubmit): |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1727 | """Returns a list of hooks that need to be run for a project. |
| 1728 | |
| 1729 | Expects to be called from within the project root. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1730 | |
| 1731 | Args: |
| 1732 | project: A string, name of the project. |
| 1733 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1734 | """ |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1735 | config = ConfigParser.RawConfigParser() |
| 1736 | try: |
| 1737 | config.read(_CONFIG_FILE) |
| 1738 | except ConfigParser.Error: |
| 1739 | # Just use an empty config file |
| 1740 | config = ConfigParser.RawConfigParser() |
| 1741 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1742 | if presubmit: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1743 | hooks = _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1744 | else: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1745 | hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1746 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1747 | enabled_hooks, disabled_hooks = _get_override_hooks(config) |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1748 | hooks = [hook for hook in hooks if hook not in disabled_hooks] |
| 1749 | |
| 1750 | # If a list is both in _COMMON_HOOKS and also enabled explicitly through an |
| 1751 | # override, keep the override only. Note that the override may end up being |
| 1752 | # a functools.partial, in which case we need to extract the .func to compare |
| 1753 | # it to the common hooks. |
| 1754 | unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks] |
| 1755 | hooks = [hook for hook in hooks if hook not in unwrapped_hooks] |
| 1756 | |
| 1757 | hooks = list(enabled_hooks) + hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1758 | |
| 1759 | if project in _PROJECT_SPECIFIC_HOOKS: |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1760 | hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project] |
| 1761 | if hook not in disabled_hooks) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1762 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1763 | for name, script in _get_project_hook_scripts(config): |
| 1764 | func = functools.partial(_run_project_hook_script, script) |
| 1765 | func.__name__ = name |
| 1766 | hooks.append(func) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1767 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1768 | return hooks |
| 1769 | |
| 1770 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1771 | def _run_project_hooks(project_name, proj_dir=None, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1772 | commit_list=None, presubmit=False): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1773 | """For each project run its project specific hook from the hooks dictionary. |
| 1774 | |
| 1775 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1776 | project_name: The name of project to run hooks for. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1777 | proj_dir: If non-None, this is the directory the project is in. If None, |
| 1778 | we'll ask repo. |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1779 | commit_list: A list of commits to run hooks against. If None or empty list |
| 1780 | then we'll automatically get the list of commits that would be uploaded. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1781 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1782 | |
| 1783 | Returns: |
| 1784 | Boolean value of whether any errors were ecountered while running the hooks. |
| 1785 | """ |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1786 | if proj_dir is None: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1787 | proj_dirs = _run_command( |
| 1788 | ['repo', 'forall', project_name, '-c', 'pwd']).split() |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 1789 | if len(proj_dirs) == 0: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1790 | print('%s cannot be found.' % project_name, file=sys.stderr) |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 1791 | print('Please specify a valid project.', file=sys.stderr) |
| 1792 | return True |
| 1793 | if len(proj_dirs) > 1: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1794 | print('%s is associated with multiple directories.' % project_name, |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 1795 | file=sys.stderr) |
| 1796 | print('Please specify a directory to help disambiguate.', file=sys.stderr) |
| 1797 | return True |
| 1798 | proj_dir = proj_dirs[0] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1799 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1800 | pwd = os.getcwd() |
| 1801 | # hooks assume they are run from the root of the project |
| 1802 | os.chdir(proj_dir) |
| 1803 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1804 | remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref', |
| 1805 | '--symbolic-full-name', '@{u}']).strip() |
| 1806 | if not remote_branch: |
| 1807 | print('Your project %s doesn\'t track any remote repo.' % project_name, |
| 1808 | file=sys.stderr) |
| 1809 | remote = None |
| 1810 | else: |
Josh Pratt | 15d13ab | 2018-08-13 11:52:48 +1000 | [diff] [blame] | 1811 | branch_items = remote_branch.split('/', 1) |
| 1812 | if len(branch_items) != 2: |
| 1813 | PrintErrorForProject( |
| 1814 | project_name, |
| 1815 | HookFailure( |
| 1816 | 'Cannot get remote and branch name (%s)' % remote_branch)) |
| 1817 | os.chdir(pwd) |
| 1818 | return True |
| 1819 | remote, _branch = branch_items |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1820 | |
| 1821 | project = Project(name=project_name, dir=proj_dir, remote=remote) |
| 1822 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1823 | if not commit_list: |
| 1824 | try: |
| 1825 | commit_list = _get_commits() |
| 1826 | except VerifyException as e: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1827 | PrintErrorForProject(project.name, HookFailure(str(e))) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1828 | os.chdir(pwd) |
| 1829 | return True |
Ryan Cui | fa55df5 | 2011-05-06 11:16:55 -0700 | [diff] [blame] | 1830 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1831 | hooks = _get_project_hooks(project.name, presubmit) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1832 | error_found = False |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1833 | commit_count = len(commit_list) |
| 1834 | for i, commit in enumerate(commit_list): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1835 | error_list = [] |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1836 | for hook in hooks: |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1837 | output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' % |
| 1838 | (i + 1, commit_count, commit, hook.__name__)) |
| 1839 | print(output, end='\r') |
| 1840 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1841 | hook_error = hook(project, commit) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1842 | print(' ' * len(output), end='\r') |
| 1843 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1844 | if hook_error: |
| 1845 | error_list.append(hook_error) |
| 1846 | error_found = True |
| 1847 | if error_list: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1848 | PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit), |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1849 | error_list) |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 1850 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1851 | os.chdir(pwd) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1852 | return error_found |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1853 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1854 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1855 | # Main |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 1856 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1857 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1858 | def main(project_list, worktree_list=None, **_kwargs): |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 1859 | """Main function invoked directly by repo. |
| 1860 | |
| 1861 | This function will exit directly upon error so that repo doesn't print some |
| 1862 | obscure error message. |
| 1863 | |
| 1864 | Args: |
| 1865 | project_list: List of projects to run on. |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 1866 | worktree_list: A list of directories. It should be the same length as |
| 1867 | project_list, so that each entry in project_list matches with a directory |
| 1868 | in worktree_list. If None, we will attempt to calculate the directories |
| 1869 | automatically. |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 1870 | kwargs: Leave this here for forward-compatibility. |
| 1871 | """ |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1872 | found_error = False |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 1873 | if not worktree_list: |
| 1874 | worktree_list = [None] * len(project_list) |
| 1875 | for project, worktree in zip(project_list, worktree_list): |
| 1876 | if _run_project_hooks(project, proj_dir=worktree): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1877 | found_error = True |
| 1878 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1879 | if found_error: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1880 | msg = ('Preupload failed due to errors in project(s). HINTS:\n' |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1881 | '- To disable some source style checks, and for other hints, see ' |
| 1882 | '<checkout_dir>/src/repohooks/README\n' |
| 1883 | '- To upload only current project, run \'repo upload .\'') |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 1884 | print(msg, file=sys.stderr) |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 1885 | sys.exit(1) |
Anush Elangovan | 63afad7 | 2011-03-23 00:41:27 -0700 | [diff] [blame] | 1886 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1887 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1888 | def _identify_project(path): |
| 1889 | """Identify the repo project associated with the given path. |
| 1890 | |
| 1891 | Returns: |
| 1892 | A string indicating what project is associated with the path passed in or |
| 1893 | a blank string upon failure. |
| 1894 | """ |
| 1895 | return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'], |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1896 | redirect_stderr=True, cwd=path).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1897 | |
| 1898 | |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1899 | def direct_main(argv): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1900 | """Run hooks directly (outside of the context of repo). |
| 1901 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1902 | Args: |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1903 | argv: The command line args to process |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1904 | |
| 1905 | Returns: |
| 1906 | 0 if no pre-upload failures, 1 if failures. |
| 1907 | |
| 1908 | Raises: |
| 1909 | BadInvocation: On some types of invocation errors. |
| 1910 | """ |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1911 | parser = commandline.ArgumentParser(description=__doc__) |
| 1912 | parser.add_argument('--dir', default=None, |
| 1913 | help='The directory that the project lives in. If not ' |
| 1914 | 'specified, use the git project root based on the cwd.') |
| 1915 | parser.add_argument('--project', default=None, |
| 1916 | help='The project repo path; this can affect how the ' |
| 1917 | 'hooks get run, since some hooks are project-specific. ' |
| 1918 | 'For chromite this is chromiumos/chromite. If not ' |
| 1919 | 'specified, the repo tool will be used to figure this ' |
| 1920 | 'out based on the dir.') |
| 1921 | parser.add_argument('--rerun-since', default=None, |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 1922 | help='Rerun hooks on old commits since some point ' |
| 1923 | 'in the past. The argument could be a date (should ' |
| 1924 | 'match git log\'s concept of a date, e.g. 2012-06-20), ' |
| 1925 | 'or a SHA1, or just a number of commits to check (from 1 ' |
| 1926 | 'to 99). This option is mutually exclusive with ' |
| 1927 | '--pre-submit.') |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1928 | parser.add_argument('--pre-submit', action="store_true", |
| 1929 | help='Run the check against the pending commit. ' |
| 1930 | 'This option should be used at the \'git commit\' ' |
| 1931 | 'phase as opposed to \'repo upload\'. This option ' |
| 1932 | 'is mutually exclusive with --rerun-since.') |
| 1933 | parser.add_argument('commits', nargs='*', |
| 1934 | help='Check specific commits') |
| 1935 | opts = parser.parse_args(argv) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1936 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1937 | if opts.rerun_since: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1938 | if opts.commits: |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1939 | raise BadInvocation('Can\'t pass commits and use rerun-since: %s' % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1940 | ' '.join(opts.commits)) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1941 | |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 1942 | if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit(): |
| 1943 | # This must be the number of commits to check. We don't expect the user |
| 1944 | # to want to check more than 99 commits. |
| 1945 | limit = '-n%s' % opts.rerun_since |
| 1946 | elif git.IsSHA1(opts.rerun_since, False): |
| 1947 | limit = '%s..' % opts.rerun_since |
| 1948 | else: |
| 1949 | # This better be a date. |
| 1950 | limit = '--since=%s' % opts.rerun_since |
| 1951 | cmd = ['git', 'log', limit, '--pretty=%H'] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1952 | all_commits = _run_command(cmd).splitlines() |
| 1953 | bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines() |
| 1954 | |
| 1955 | # Eliminate chrome-bot commits but keep ordering the same... |
| 1956 | bot_commits = set(bot_commits) |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1957 | opts.commits = [c for c in all_commits if c not in bot_commits] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1958 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1959 | if opts.pre_submit: |
| 1960 | raise BadInvocation('rerun-since and pre-submit can not be ' |
| 1961 | 'used together') |
| 1962 | if opts.pre_submit: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1963 | if opts.commits: |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1964 | raise BadInvocation('Can\'t pass commits and use pre-submit: %s' % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1965 | ' '.join(opts.commits)) |
| 1966 | opts.commits = [PRE_SUBMIT,] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1967 | |
| 1968 | # Check/normlaize git dir; if unspecified, we'll use the root of the git |
| 1969 | # project from CWD |
| 1970 | if opts.dir is None: |
| 1971 | git_dir = _run_command(['git', 'rev-parse', '--git-dir'], |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1972 | redirect_stderr=True).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1973 | if not git_dir: |
| 1974 | raise BadInvocation('The current directory is not part of a git project.') |
| 1975 | opts.dir = os.path.dirname(os.path.abspath(git_dir)) |
| 1976 | elif not os.path.isdir(opts.dir): |
| 1977 | raise BadInvocation('Invalid dir: %s' % opts.dir) |
| 1978 | elif not os.path.isdir(os.path.join(opts.dir, '.git')): |
| 1979 | raise BadInvocation('Not a git directory: %s' % opts.dir) |
| 1980 | |
| 1981 | # Identify the project if it wasn't specified; this _requires_ the repo |
| 1982 | # tool to be installed and for the project to be part of a repo checkout. |
| 1983 | if not opts.project: |
| 1984 | opts.project = _identify_project(opts.dir) |
| 1985 | if not opts.project: |
| 1986 | raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir) |
| 1987 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 1988 | found_error = _run_project_hooks(opts.project, proj_dir=opts.dir, |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 1989 | commit_list=opts.commits, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1990 | presubmit=opts.pre_submit) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 1991 | if found_error: |
| 1992 | return 1 |
| 1993 | return 0 |
| 1994 | |
| 1995 | |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 1996 | if __name__ == '__main__': |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1997 | sys.exit(direct_main(sys.argv[1:])) |