blob: 0625d895f3c92f804fcc7c7783185a3123964ee8 [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Oka4a09bd92019-05-07 14:01:00 +090014# TODO(crbug.com/960636): Remove pylint disable after linter is fixed.
15import argparse # pylint: disable=import-error
Alex Deymo643ac4c2015-09-03 10:40:50 -070016import collections
Ryan Cui9b651632011-05-11 11:38:58 -070017import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080025import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger6850d512018-05-21 12:12:14 -040030# If repo imports us, the __name__ will be __builtin__, and the cwd will be in
31# the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be in
32# that directory, so add it to our path. This works whether we're running the
33# repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a completely
34# different tree.
35if __name__ == '__builtin__':
36 sys.path.insert(0, os.getcwd())
37
38# If we're run directly, we'll find chromite relative to the repohooks dir in
39# $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
40if __name__ == '__main__':
David Jamesc3b68b32013-04-03 09:17:03 -070041 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
42
Mike Frysinger66142932014-12-18 14:55:57 -050043from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080044from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070045from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050046from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070047from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070048from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040049from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070050
Vadim Bendebury2b62d742014-06-22 13:14:51 -070051PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070052
53COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050054 # C++ and friends
55 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
56 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
57 # Scripts
58 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
59 # No extension at all, note that ALL CAPS files are black listed in
60 # COMMON_EXCLUDED_LIST below.
61 r"(^|.*[\\\/])[^.]+$",
62 # Other
63 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070064 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070065]
66
Ryan Cui1562fb82011-05-09 11:01:31 -070067
Ryan Cuiec4d6332011-05-02 14:15:25 -070068COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070069 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050070 r".*/Manifest$",
71 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070072
Daniel Erate3ea3fc2015-02-13 15:27:52 -070073 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040074 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040075 r"^profiles/.*$",
76
C Shapiro8f90e9b2017-06-28 09:54:50 -060077 # Ignore config files in ebuild setup.
78 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
79 r"^chromeos-base/chromeos-bsp.*/files/.*",
80
Daniel Erate3ea3fc2015-02-13 15:27:52 -070081 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050082 r".*\.min\.js",
83 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050084
85 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070086 r".*/licenses/.*",
Alex Klein619c0912019-01-30 17:13:23 -070087
88 # Exclude generated python protobuf files.
89 r".*_pb2\.py$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070090]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070091
Ken Turnerd07564b2018-02-08 17:57:59 +110092LICENSE_EXCLUDED_PATHS = [
Chris McDonald7b63c8e2019-04-25 10:27:27 -060093 r"^(.*/)?OWNERS$",
Ken Turnerd07564b2018-02-08 17:57:59 +110094]
Ryan Cui1562fb82011-05-09 11:01:31 -070095
Ryan Cui9b651632011-05-11 11:38:58 -070096_CONFIG_FILE = 'PRESUBMIT.cfg'
97
98
Daniel Erate3ea3fc2015-02-13 15:27:52 -070099# File containing wildcards, one per line, matching files that should be
100# excluded from presubmit checks. Lines beginning with '#' are ignored.
101_IGNORE_FILE = '.presubmitignore'
102
103
Doug Anderson44a644f2011-11-02 10:37:37 -0700104# Exceptions
105
106
107class BadInvocation(Exception):
108 """An Exception indicating a bad invocation of the program."""
109 pass
110
111
Ryan Cui1562fb82011-05-09 11:01:31 -0700112# General Helpers
113
Sean Paulba01d402011-05-05 11:36:23 -0400114
Alex Deymo643ac4c2015-09-03 10:40:50 -0700115Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
116
117
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700118# pylint: disable=redefined-builtin
119def _run_command(cmd, cwd=None, input=None,
120 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700121 """Executes the passed in command and returns raw stdout output.
122
123 Args:
124 cmd: The command to run; should be a list of strings.
125 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700126 input: The data to pipe into this command through stdin. If a file object
127 or file descriptor, stdin will be connected directly to that.
128 redirect_stderr: Redirect stderr away from console.
129 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700130
131 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700132 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700133 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700134 return cros_build_lib.RunCommand(cmd=cmd,
135 cwd=cwd,
136 print_cmd=False,
137 input=input,
138 stdout_to_pipe=True,
139 redirect_stderr=redirect_stderr,
140 combine_stdout_stderr=combine_stdout_stderr,
141 error_code_ok=True).output
142# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700143
Ryan Cui1562fb82011-05-09 11:01:31 -0700144
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700145def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700146 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700147 if __name__ == '__main__':
148 # Works when file is run on its own (__file__ is defined)...
149 return os.path.abspath(os.path.dirname(__file__))
150 else:
151 # We need to do this when we're run through repo. Since repo executes
152 # us with execfile(), we don't get __file__ defined.
153 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
154 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700155
Ryan Cui1562fb82011-05-09 11:01:31 -0700156
Ryan Cuiec4d6332011-05-02 14:15:25 -0700157def _match_regex_list(subject, expressions):
158 """Try to match a list of regular expressions to a string.
159
160 Args:
161 subject: The string to match regexes on
162 expressions: A list of regular expressions to check for matches with.
163
164 Returns:
165 Whether the passed in subject matches any of the passed in regexes.
166 """
167 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500168 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700169 return True
170 return False
171
Ryan Cui1562fb82011-05-09 11:01:31 -0700172
Mike Frysingerae409522014-02-01 03:16:11 -0500173def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700174 """Filter out files based on the conditions passed in.
175
176 Args:
177 files: list of filepaths to filter
178 include_list: list of regex that when matched with a file path will cause it
179 to be added to the output list unless the file is also matched with a
180 regex in the exclude_list.
181 exclude_list: list of regex that when matched with a file will prevent it
182 from being added to the output list, even if it is also matched with a
183 regex in the include_list.
184
185 Returns:
186 A list of filepaths that contain files matched in the include_list and not
187 in the exclude_list.
188 """
189 filtered = []
190 for f in files:
191 if (_match_regex_list(f, include_list) and
192 not _match_regex_list(f, exclude_list)):
193 filtered.append(f)
194 return filtered
195
Ryan Cuiec4d6332011-05-02 14:15:25 -0700196
197# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700198
199
Ryan Cui4725d952011-05-05 15:41:19 -0700200def _get_upstream_branch():
201 """Returns the upstream tracking branch of the current branch.
202
203 Raises:
204 Error if there is no tracking branch
205 """
206 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
207 current_branch = current_branch.replace('refs/heads/', '')
208 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700209 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700210
211 cfg_option = 'branch.' + current_branch + '.%s'
212 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
213 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
214 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700215 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700216
217 return full_upstream.replace('heads', 'remotes/' + remote)
218
Ryan Cui1562fb82011-05-09 11:01:31 -0700219
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700220def _get_patch(commit):
221 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700222 if commit == PRE_SUBMIT:
223 return _run_command(['git', 'diff', '--cached', 'HEAD'])
224 else:
225 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700226
Ryan Cui1562fb82011-05-09 11:01:31 -0700227
Jon Salz98255932012-08-18 14:48:02 +0800228def _try_utf8_decode(data):
229 """Attempts to decode a string as UTF-8.
230
231 Returns:
232 The decoded Unicode object, or the original string if parsing fails.
233 """
234 try:
235 return unicode(data, 'utf-8', 'strict')
236 except UnicodeDecodeError:
237 return data
238
239
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500240def _get_file_content(path, commit):
241 """Returns the content of a file at a specific commit.
242
243 We can't rely on the file as it exists in the filesystem as people might be
244 uploading a series of changes which modifies the file multiple times.
245
246 Note: The "content" of a symlink is just the target. So if you're expecting
247 a full file, you should check that first. One way to detect is that the
248 content will not have any newlines.
249 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700250 if commit == PRE_SUBMIT:
251 return _run_command(['git', 'diff', 'HEAD', path])
252 else:
Mike Frysingerd0523442018-01-03 17:05:29 -0500253 # Make sure people don't accidentally pass in full paths which will never
254 # work. You need to use relative=True with _get_affected_files.
255 if path.startswith('/'):
256 raise ValueError('_get_file_content must be called with relative paths: '
257 + path)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700258 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500259
260
Mike Frysingerae409522014-02-01 03:16:11 -0500261def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700262 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700263 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800264 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
265 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700266 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800267 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
268 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700269 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700270
271 new_lines = []
272 line_num = 0
273 for line in output.splitlines():
274 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
275 if m:
276 line_num = int(m.groups(1)[0])
277 continue
278 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800279 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700280 if not line.startswith('-'):
281 line_num += 1
282 return new_lines
283
Ryan Cui1562fb82011-05-09 11:01:31 -0700284
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700285def _get_ignore_wildcards(directory, cache):
286 """Get wildcards listed in a directory's _IGNORE_FILE.
287
288 Args:
289 directory: A string containing a directory path.
290 cache: A dictionary (opaque to caller) caching previously-read wildcards.
291
292 Returns:
293 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
294 wasn't present.
295 """
296 # In the cache, keys are directories and values are lists of wildcards from
297 # _IGNORE_FILE within those directories (and empty if no file was present).
298 if directory not in cache:
299 wildcards = []
300 dotfile_path = os.path.join(directory, _IGNORE_FILE)
301 if os.path.exists(dotfile_path):
302 # TODO(derat): Consider using _get_file_content() to get the file as of
303 # this commit instead of the on-disk version. This may have a noticeable
304 # performance impact, as each call to _get_file_content() runs git.
305 with open(dotfile_path, 'r') as dotfile:
306 for line in dotfile.readlines():
307 line = line.strip()
308 if line.startswith('#'):
309 continue
310 if line.endswith('/'):
311 line += '*'
312 wildcards.append(line)
313 cache[directory] = wildcards
314
315 return cache[directory]
316
317
318def _path_is_ignored(path, cache):
319 """Check whether a path is ignored by _IGNORE_FILE.
320
321 Args:
322 path: A string containing a path.
323 cache: A dictionary (opaque to caller) caching previously-read wildcards.
324
325 Returns:
326 True if a file named _IGNORE_FILE in one of the passed-in path's parent
327 directories contains a wildcard matching the path.
328 """
329 # Skip ignore files.
330 if os.path.basename(path) == _IGNORE_FILE:
331 return True
332
333 path = os.path.abspath(path)
334 base = os.getcwd()
335
336 prefix = os.path.dirname(path)
337 while prefix.startswith(base):
338 rel_path = path[len(prefix) + 1:]
339 for wildcard in _get_ignore_wildcards(prefix, cache):
340 if fnmatch.fnmatch(rel_path, wildcard):
341 return True
342 prefix = os.path.dirname(prefix)
343
344 return False
345
346
Mike Frysinger292b45d2014-11-25 01:17:10 -0500347def _get_affected_files(commit, include_deletes=False, relative=False,
348 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700349 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700350 """Returns list of file paths that were modified/added, excluding symlinks.
351
352 Args:
353 commit: The commit
354 include_deletes: If true, we'll include deleted files in the result
355 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500356 include_symlinks: If true, we'll include symlinks in the result
357 include_adds: If true, we'll include new files in the result
358 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700359 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700360
361 Returns:
362 A list of modified/added (and perhaps deleted) files
363 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500364 if not relative and full_details:
365 raise ValueError('full_details only supports relative paths currently')
366
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700367 if commit == PRE_SUBMIT:
368 return _run_command(['git', 'diff-index', '--cached',
369 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500370
371 path = os.getcwd()
372 files = git.RawDiff(path, '%s^!' % commit)
373
374 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500375 if not include_symlinks:
376 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500377
378 if not include_deletes:
379 files = [x for x in files if x.status != 'D']
380
Mike Frysinger292b45d2014-11-25 01:17:10 -0500381 if not include_adds:
382 files = [x for x in files if x.status != 'A']
383
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700384 if use_ignore_files:
385 cache = {}
386 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
387 files = [x for x in files if not is_ignored(x)]
388
Mike Frysinger292b45d2014-11-25 01:17:10 -0500389 if full_details:
390 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500391 return files
392 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500393 # Caller only cares about filenames.
394 files = [x.dst_file if x.dst_file else x.src_file for x in files]
395 if relative:
396 return files
397 else:
398 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700399
400
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700401def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700402 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700403 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700404 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700405
Ryan Cui1562fb82011-05-09 11:01:31 -0700406
Ryan Cuiec4d6332011-05-02 14:15:25 -0700407def _get_commit_desc(commit):
408 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700409 if commit == PRE_SUBMIT:
410 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400411 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700412
413
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800414def _check_lines_in_diff(commit, files, check_callable, error_description):
415 """Checks given file for errors via the given check.
416
417 This is a convenience function for common per-line checks. It goes through all
418 files and returns a HookFailure with the error description listing all the
419 failures.
420
421 Args:
422 commit: The commit we're working on.
423 files: The files to check.
424 check_callable: A callable that takes a line and returns True if this line
425 _fails_ the check.
426 error_description: A string describing the error.
427 """
428 errors = []
429 for afile in files:
430 for line_num, line in _get_file_diff(afile, commit):
431 if check_callable(line):
432 errors.append('%s, line %s' % (afile, line_num))
433 if errors:
434 return HookFailure(error_description, errors)
435
436
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900437def _parse_common_inclusion_options(options):
438 """Parses common hook options for including/excluding files.
439
440 Args:
441 options: Option string list.
442
443 Returns:
444 (included, excluded) where each one is a list of regex strings.
445 """
446 parser = argparse.ArgumentParser()
447 parser.add_argument('--exclude_regex', action='append')
448 parser.add_argument('--include_regex', action='append')
449 opts = parser.parse_args(options)
450 included = opts.include_regex or []
451 excluded = opts.exclude_regex or []
452 return included, excluded
453
454
Ryan Cuiec4d6332011-05-02 14:15:25 -0700455# Common Hooks
456
Ryan Cui1562fb82011-05-09 11:01:31 -0700457
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900458def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500459 """Checks there are no lines longer than MAX_LEN in any of the text files."""
460
Ryan Cuiec4d6332011-05-02 14:15:25 -0700461 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800462 SKIP_REGEXP = re.compile('|'.join([
463 r'https?://',
Maksim Ivanov3f677b92018-06-05 16:10:24 +0200464 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700465
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900466 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700467 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900468 included + COMMON_INCLUDED_PATHS,
469 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700470
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900471 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700472 for afile in files:
473 for line_num, line in _get_file_diff(afile, commit):
474 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500475 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800476 continue
477
478 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
479 if len(errors) == 5: # Just show the first 5 errors.
480 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700481
482 if errors:
483 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700484 return HookFailure(msg, errors)
485
Ryan Cuiec4d6332011-05-02 14:15:25 -0700486
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900487def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700488 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900489 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700490 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900491 included + COMMON_INCLUDED_PATHS,
492 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800493 return _check_lines_in_diff(commit, files,
494 lambda line: line.rstrip() != line,
495 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700496
Ryan Cuiec4d6332011-05-02 14:15:25 -0700497
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900498def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700499 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400500 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
501 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700502 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700503 r".*\.ebuild$",
504 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500505 r".*/[M|m]akefile$",
506 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700507 ]
508
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900509 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700510 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900511 included + COMMON_INCLUDED_PATHS,
512 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800513 return _check_lines_in_diff(commit, files,
514 lambda line: '\t' in line,
515 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700516
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800517
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900518def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800519 """Checks that indents use tabs only."""
520 TABS_REQUIRED_PATHS = [
521 r".*\.ebuild$",
522 r".*\.eclass$",
523 ]
524 LEADING_SPACE_RE = re.compile('[\t]* ')
525
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800527 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900528 included + TABS_REQUIRED_PATHS,
529 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800530 return _check_lines_in_diff(
531 commit, files,
532 lambda line: LEADING_SPACE_RE.match(line) is not None,
533 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700534
Ryan Cuiec4d6332011-05-02 14:15:25 -0700535
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700536def _check_gofmt(_project, commit):
537 """Checks that Go files are formatted with gofmt."""
538 errors = []
539 files = _filter_files(_get_affected_files(commit, relative=True),
540 [r'\.go$'])
541
542 for gofile in files:
543 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700544 output = _run_command(cmd=['gofmt', '-l'], input=contents,
545 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700546 if output:
547 errors.append(gofile)
548 if errors:
549 return HookFailure('Files not formatted with gofmt:', errors)
550
551
Mike Frysingerae409522014-02-01 03:16:11 -0500552def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700553 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700554 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700555
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700556 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700557 msg = 'Changelist description needs TEST field (after first line)'
558 return HookFailure(msg)
559
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560
Mike Frysingerae409522014-02-01 03:16:11 -0500561def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700562 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
563 msg = 'Changelist has invalid CQ-DEPEND target.'
564 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
565 try:
566 patch.GetPaladinDeps(_get_commit_desc(commit))
567 except ValueError as ex:
568 return HookFailure(msg, [example, str(ex)])
569
570
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800571def _check_change_is_contribution(_project, commit):
572 """Check that the change is a contribution."""
573 NO_CONTRIB = 'not a contribution'
574 if NO_CONTRIB in _get_commit_desc(commit).lower():
575 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
576 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
577 return HookFailure(msg)
578
579
Alex Deymo643ac4c2015-09-03 10:40:50 -0700580def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700581 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700582 OLD_BUG_RE = r'\nBUG=.*chromium-os'
583 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
584 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
585 'the chromium tracker in your BUG= line now.')
586 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700587
Alex Deymo643ac4c2015-09-03 10:40:50 -0700588 # Android internal and external projects use "Bug: " to track bugs in
589 # buganizer.
590 BUG_COLON_REMOTES = (
591 'aosp',
592 'goog',
593 )
594 if project.remote in BUG_COLON_REMOTES:
595 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
596 if not re.search(BUG_RE, _get_commit_desc(commit)):
597 msg = ('Changelist description needs BUG field (after first line):\n'
598 'Bug: 9999 (for buganizer)\n'
599 'BUG=None')
600 return HookFailure(msg)
601 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400602 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700603 if not re.search(BUG_RE, _get_commit_desc(commit)):
604 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700605 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700606 'BUG=b:9999 (for buganizer)\n'
607 'BUG=None')
608 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700609
Ryan Cuiec4d6332011-05-02 14:15:25 -0700610
Mike Frysinger292b45d2014-11-25 01:17:10 -0500611def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700612 """Check that we're not missing a revbump of an ebuild in the given commit.
613
614 If the given commit touches files in a directory that has ebuilds somewhere
615 up the directory hierarchy, it's very likely that we need an ebuild revbump
616 in order for those changes to take effect.
617
618 It's not totally trivial to detect a revbump, so at least detect that an
619 ebuild with a revision number in it was touched. This should handle the
620 common case where we use a symlink to do the revbump.
621
622 TODO: it would be nice to enhance this hook to:
623 * Handle cases where people revbump with a slightly different syntax. I see
624 one ebuild (puppy) that revbumps with _pN. This is a false positive.
625 * Catches cases where people aren't using symlinks for revbumps. If they
626 edit a revisioned file directly (and are expected to rename it for revbump)
627 we'll miss that. Perhaps we could detect that the file touched is a
628 symlink?
629
630 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
631 still better off than without this check.
632
633 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700634 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700635 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500636 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700637
638 Returns:
639 A HookFailure or None.
640 """
Mike Frysinger011af942014-01-17 16:12:22 -0500641 # If this is the portage-stable overlay, then ignore the check. It's rare
642 # that we're doing anything other than importing files from upstream, so
643 # forcing a rev bump makes no sense.
644 whitelist = (
645 'chromiumos/overlays/portage-stable',
646 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700647 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500648 return None
649
Mike Frysinger292b45d2014-11-25 01:17:10 -0500650 def FinalName(obj):
651 # If the file is being deleted, then the dst_file is not set.
652 if obj.dst_file is None:
653 return obj.src_file
654 else:
655 return obj.dst_file
656
657 affected_path_objs = _get_affected_files(
658 commit, include_deletes=True, include_symlinks=True, relative=True,
659 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700660
661 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700662 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500663 affected_path_objs = [x for x in affected_path_objs
664 if os.path.basename(FinalName(x)) not in whitelist]
665 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700666 return None
667
668 # If we've touched any file named with a -rN.ebuild then we'll say we're
669 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500670 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
671 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700672 if touched_revved_ebuild:
673 return None
674
Mike Frysinger292b45d2014-11-25 01:17:10 -0500675 # If we're creating new ebuilds from scratch, then we don't need an uprev.
676 # Find all the dirs that new ebuilds and ignore their files/.
677 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
678 if FinalName(x).endswith('.ebuild') and x.status == 'A']
679 affected_path_objs = [obj for obj in affected_path_objs
680 if not any(FinalName(obj).startswith(x)
681 for x in ebuild_dirs)]
682 if not affected_path_objs:
683 return
684
Doug Anderson42b8a052013-06-26 10:45:36 -0700685 # We want to examine the current contents of all directories that are parents
686 # of files that were touched (up to the top of the project).
687 #
688 # ...note: we use the current directory contents even though it may have
689 # changed since the commit we're looking at. This is just a heuristic after
690 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500691 if project_top is None:
692 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700693 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500694 for obj in affected_path_objs:
695 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700696 while os.path.exists(path) and not os.path.samefile(path, project_top):
697 dirs_to_check.add(path)
698 path = os.path.dirname(path)
699
700 # Look through each directory. If it's got an ebuild in it then we'll
701 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800702 affected_paths = set(os.path.join(project_top, FinalName(x))
703 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700704 for dir_path in dirs_to_check:
705 contents = os.listdir(dir_path)
706 ebuilds = [os.path.join(dir_path, path)
707 for path in contents if path.endswith('.ebuild')]
708 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
709
C Shapiroae157ae2017-09-18 16:24:03 -0600710 affected_paths_under_9999_ebuilds = set()
711 for affected_path in affected_paths:
712 for ebuild_9999 in ebuilds_9999:
713 ebuild_dir = os.path.dirname(ebuild_9999)
714 if affected_path.startswith(ebuild_dir):
715 affected_paths_under_9999_ebuilds.add(affected_path)
716
717 # If every file changed exists under a 9999 ebuild, then skip
718 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
719 continue
720
Doug Anderson42b8a052013-06-26 10:45:36 -0700721 # If the -9999.ebuild file was touched the bot will uprev for us.
722 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500723 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700724 continue
725
726 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500727 return HookFailure('Changelist probably needs a revbump of an ebuild, '
728 'or a -r1.ebuild symlink if this is a new ebuild:\n'
729 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700730
731 return None
732
733
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500734def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500735 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500736
737 We want to get away from older EAPI's as it makes life confusing and they
738 have less builtin error checking.
739
740 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700741 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500742 commit: The commit to look at
743
744 Returns:
745 A HookFailure or None.
746 """
747 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500748 # that we're doing anything other than importing files from upstream, and
749 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500750 whitelist = (
751 'chromiumos/overlays/portage-stable',
752 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700753 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500754 return None
755
Mike Frysinger948284a2018-02-01 15:22:56 -0500756 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500757
758 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
759
760 ebuilds_re = [r'\.ebuild$']
761 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
762 ebuilds_re)
763 bad_ebuilds = []
764
765 for ebuild in ebuilds:
766 # If the ebuild does not specify an EAPI, it defaults to 0.
767 eapi = '0'
768
769 lines = _get_file_content(ebuild, commit).splitlines()
770 if len(lines) == 1:
771 # This is most likely a symlink, so skip it entirely.
772 continue
773
774 for line in lines:
775 m = get_eapi.match(line)
776 if m:
777 # Once we hit the first EAPI line in this ebuild, stop processing.
778 # The spec requires that there only be one and it be first, so
779 # checking all possible values is pointless. We also assume that
780 # it's "the" EAPI line and not something in the middle of a heredoc.
781 eapi = m.group(1)
782 break
783
784 if eapi in BAD_EAPIS:
785 bad_ebuilds.append((ebuild, eapi))
786
787 if bad_ebuilds:
788 # pylint: disable=C0301
789 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
790 # pylint: enable=C0301
791 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500792 'These ebuilds are using old EAPIs. If these are imported from\n'
793 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500794 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500795 '\t%s\n'
796 'See this guide for more details:\n%s\n' %
797 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
798
799
Mike Frysinger89bdb852014-02-01 05:26:26 -0500800def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500801 """Make sure we use the new style KEYWORDS when possible in ebuilds.
802
803 If an ebuild generally does not care about the arch it is running on, then
804 ebuilds should flag it with one of:
805 KEYWORDS="*" # A stable ebuild.
806 KEYWORDS="~*" # An unstable ebuild.
807 KEYWORDS="-* ..." # Is known to only work on specific arches.
808
809 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700810 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500811 commit: The commit to look at
812
813 Returns:
814 A HookFailure or None.
815 """
816 WHITELIST = set(('*', '-*', '~*'))
817
818 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
819
Mike Frysinger89bdb852014-02-01 05:26:26 -0500820 ebuilds_re = [r'\.ebuild$']
821 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
822 ebuilds_re)
823
Mike Frysinger8d42d742014-09-22 15:50:21 -0400824 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500825 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400826 # We get the full content rather than a diff as the latter does not work
827 # on new files (like when adding new ebuilds).
828 lines = _get_file_content(ebuild, commit).splitlines()
829 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500830 m = get_keywords.match(line)
831 if m:
832 keywords = set(m.group(1).split())
833 if not keywords or WHITELIST - keywords != WHITELIST:
834 continue
835
Mike Frysinger8d42d742014-09-22 15:50:21 -0400836 bad_ebuilds.append(ebuild)
837
838 if bad_ebuilds:
839 return HookFailure(
840 '%s\n'
841 'Please update KEYWORDS to use a glob:\n'
842 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
843 ' KEYWORDS="*"\n'
844 'If the ebuild should be marked unstable (normal for '
845 'cros-workon / 9999 ebuilds):\n'
846 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400847 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400848 'then use -* like so:\n'
849 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500850
851
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800852def _check_ebuild_licenses(_project, commit):
853 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800854 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800855 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
856
857 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800858 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800859
860 for ebuild in touched_ebuilds:
861 # Skip virutal packages.
862 if ebuild.split('/')[-3] == 'virtual':
863 continue
864
Alex Kleinb5953522018-08-03 11:44:21 -0600865 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
866 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
867
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800868 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800869 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -0600870 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
871 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800872 except ValueError as e:
873 return HookFailure(e.message, [ebuild])
874
875 # Also ignore licenses ending with '?'
876 for license_type in [x for x in license_types
877 if x not in LICENSES_IGNORE and not x.endswith('?')]:
878 try:
Alex Kleinb5953522018-08-03 11:44:21 -0600879 licenses_lib.Licensing.FindLicenseType(license_type,
880 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800881 except AssertionError as e:
882 return HookFailure(e.message, [ebuild])
883
884
Mike Frysingercd363c82014-02-01 05:20:18 -0500885def _check_ebuild_virtual_pv(project, commit):
886 """Enforce the virtual PV policies."""
887 # If this is the portage-stable overlay, then ignore the check.
888 # We want to import virtuals as-is from upstream Gentoo.
889 whitelist = (
890 'chromiumos/overlays/portage-stable',
891 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700892 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500893 return None
894
895 # We assume the repo name is the same as the dir name on disk.
896 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700897 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500898
899 is_variant = lambda x: x.startswith('overlay-variant-')
900 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700901 is_baseboard = lambda x: x.startswith('baseboard-')
902 is_chipset = lambda x: x.startswith('chipset-')
903 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -0500904 is_private = lambda x: x.endswith('-private')
905
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700906 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
907 is_baseboard(x) or is_project(x))
908
Mike Frysingercd363c82014-02-01 05:20:18 -0500909 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
910
911 ebuilds_re = [r'\.ebuild$']
912 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
913 ebuilds_re)
914 bad_ebuilds = []
915
916 for ebuild in ebuilds:
917 m = get_pv.match(ebuild)
918 if m:
919 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700920 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700921 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500922
923 pv = m.group(3).split('-', 1)[0]
924
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800925 # Virtual versions >= 4 are special cases used above the standard
926 # versioning structure, e.g. if one has a board inheriting a board.
927 if float(pv) >= 4:
928 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -0500929 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700930 if is_private(overlay):
931 want_pv = '3.5' if is_variant(overlay) else '3'
932 elif is_board(overlay):
933 want_pv = '2.5' if is_variant(overlay) else '2'
934 elif is_baseboard(overlay):
935 want_pv = '1.9'
936 elif is_chipset(overlay):
937 want_pv = '1.8'
938 elif is_project(overlay):
939 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -0500940 else:
941 want_pv = '1'
942
943 if pv != want_pv:
944 bad_ebuilds.append((ebuild, pv, want_pv))
945
946 if bad_ebuilds:
947 # pylint: disable=C0301
948 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
949 # pylint: enable=C0301
950 return HookFailure(
951 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
952 '\t%s\n'
953 'If this is an upstream Gentoo virtual, then you may ignore this\n'
954 'check (and re-run w/--no-verify). Otherwise, please see this\n'
955 'page for more details:\n%s\n' %
956 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
957 for x in bad_ebuilds]), url))
958
959
Daniel Erat9d203ff2015-02-17 10:12:21 -0700960def _check_portage_make_use_var(_project, commit):
961 """Verify that $USE is set correctly in make.conf and make.defaults."""
962 files = _filter_files(_get_affected_files(commit, relative=True),
963 [r'(^|/)make.(conf|defaults)$'])
964
965 errors = []
966 for path in files:
967 basename = os.path.basename(path)
968
969 # Has a USE= line already been encountered in this file?
970 saw_use = False
971
972 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
973 if not line.startswith('USE='):
974 continue
975
976 preserves_use = '${USE}' in line or '$USE' in line
977
978 if (basename == 'make.conf' or
979 (basename == 'make.defaults' and saw_use)) and not preserves_use:
980 errors.append('%s:%d: missing ${USE}' % (path, i))
981 elif basename == 'make.defaults' and not saw_use and preserves_use:
982 errors.append('%s:%d: ${USE} referenced in initial declaration' %
983 (path, i))
984
985 saw_use = True
986
987 if errors:
988 return HookFailure(
989 'One or more Portage make files appear to set USE incorrectly.\n'
990 '\n'
991 'All USE assignments in make.conf and all assignments after the\n'
992 'initial declaration in make.defaults should contain "${USE}" to\n'
993 'preserve previously-set flags.\n'
994 '\n'
995 'The initial USE declaration in make.defaults should not contain\n'
996 '"${USE}".\n',
997 errors)
998
999
Mike Frysingerae409522014-02-01 03:16:11 -05001000def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001001 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001002 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001003 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001004 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001005 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001006 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001007
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001008 # S-o-b tags always allowed to follow Change-ID.
1009 allowed_tags = ['Signed-off-by']
1010
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001011 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001012 cherry_pick_marker = 'cherry picked from commit'
1013
1014 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001015 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001016 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1017 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001018 end = end[:-1]
1019
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001020 # Note that descriptions could have multiple cherry pick markers.
1021 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001022
1023 if [x for x in end if not re.search(tag_search, x)]:
1024 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1025 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001026
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001027
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001028def _check_commit_message_style(_project, commit):
1029 """Verify that the commit message matches our style.
1030
1031 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1032 commit hooks.
1033 """
1034 desc = _get_commit_desc(commit)
1035
1036 # The first line should be by itself.
1037 lines = desc.splitlines()
1038 if len(lines) > 1 and lines[1]:
1039 return HookFailure('The second line of the commit message must be blank.')
1040
1041 # The first line should be one sentence.
1042 if '. ' in lines[0]:
1043 return HookFailure('The first line cannot be more than one sentence.')
1044
1045 # The first line cannot be too long.
1046 MAX_FIRST_LINE_LEN = 100
1047 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1048 return HookFailure('The first line must be less than %i chars.' %
1049 MAX_FIRST_LINE_LEN)
1050
1051
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001052def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001053 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001054
Mike Frysinger98638102014-08-28 00:15:08 -04001055 Should be following the spec:
1056 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1057 """
1058 # For older years, be a bit more flexible as our policy says leave them be.
1059 LICENSE_HEADER = (
Brian Norris68838dd2018-09-26 18:30:24 -07001060 r'.*Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001061 r'All rights reserved\.' r'\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001062 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001063 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001064 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001065 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001066 )
1067 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1068
1069 # For newer years, be stricter.
1070 COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001071 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001072 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001073 )
1074 copyright_re = re.compile(COPYRIGHT_LINE)
1075
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001076 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001077
Mike Frysinger98638102014-08-28 00:15:08 -04001078 bad_files = []
1079 bad_copyright_files = []
Ken Turnerd07564b2018-02-08 17:57:59 +11001080 files = _filter_files(
1081 _get_affected_files(commit, relative=True),
1082 included + COMMON_INCLUDED_PATHS,
1083 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001084
1085 for f in files:
1086 contents = _get_file_content(f, commit)
1087 if not contents:
1088 # Ignore empty files.
1089 continue
1090
1091 if not license_re.search(contents):
1092 bad_files.append(f)
1093 elif copyright_re.search(contents):
1094 bad_copyright_files.append(f)
1095
1096 if bad_files:
1097 msg = '%s:\n%s\n%s' % (
1098 'License must match', license_re.pattern,
1099 'Found a bad header in these files:')
1100 return HookFailure(msg, bad_files)
1101
1102 if bad_copyright_files:
1103 msg = 'Do not use (c) in copyright headers in new files:'
1104 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001105
1106
Amin Hassani391efa92018-01-26 17:58:05 -08001107def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001108 """Verifies the AOSP license/copyright header.
1109
1110 AOSP uses the Apache2 License:
1111 https://source.android.com/source/licenses.html
1112 """
1113 LICENSE_HEADER = (
1114 r"""^[#/\*]*
1115[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1116[#/\*]* ?
1117[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1118[#/\*]* ?you may not use this file except in compliance with the License\.
1119[#/\*]* ?You may obtain a copy of the License at
1120[#/\*]* ?
1121[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1122[#/\*]* ?
1123[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1124[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1125[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1126 r"""implied\.
1127[#/\*]* ?See the License for the specific language governing permissions and
1128[#/\*]* ?limitations under the License\.
1129[#/\*]*$
1130"""
1131 )
1132 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1133
Amin Hassani391efa92018-01-26 17:58:05 -08001134 included, excluded = _parse_common_inclusion_options(options)
1135
Ken Turnerd07564b2018-02-08 17:57:59 +11001136 files = _filter_files(
1137 _get_affected_files(commit, relative=True),
1138 included + COMMON_INCLUDED_PATHS,
1139 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001140
1141 bad_files = []
1142 for f in files:
1143 contents = _get_file_content(f, commit)
1144 if not contents:
1145 # Ignore empty files.
1146 continue
1147
1148 if not license_re.search(contents):
1149 bad_files.append(f)
1150
1151 if bad_files:
1152 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1153 license_re.pattern)
1154 return HookFailure(msg, bad_files)
1155
1156
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001157def _check_layout_conf(_project, commit):
1158 """Verifies the metadata/layout.conf file."""
1159 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001160 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001161 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001162 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001163
Mike Frysinger94a670c2014-09-19 12:46:26 -04001164 # Handle multiple overlays in a single commit (like the public tree).
1165 for f in _get_affected_files(commit, relative=True):
1166 if f.endswith(repo_name):
1167 repo_names.append(f)
1168 elif f.endswith(layout_path):
1169 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001170
1171 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001172 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001173 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001174 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001175
Mike Frysinger94a670c2014-09-19 12:46:26 -04001176 # Gather all the errors in one pass so we show one full message.
1177 all_errors = {}
1178 for layout_path in layout_paths:
1179 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001180
Mike Frysinger94a670c2014-09-19 12:46:26 -04001181 # Make sure the config file is sorted.
1182 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1183 if x and x[0] != '#']
1184 if sorted(data) != data:
1185 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001186
Mike Frysinger94a670c2014-09-19 12:46:26 -04001187 # Require people to set specific values all the time.
1188 settings = (
1189 # TODO: Enable this for everyone. http://crbug.com/408038
1190 #('fast caching', 'cache-format = md5-dict'),
1191 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001192 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1193 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001194 )
1195 for reason, line in settings:
1196 if line not in data:
1197 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001198
Mike Frysinger94a670c2014-09-19 12:46:26 -04001199 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001200 if 'use-manifests = strict' not in data:
1201 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001202
Mike Frysinger94a670c2014-09-19 12:46:26 -04001203 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001204 for line in data:
1205 if line.startswith('repo-name = '):
1206 break
1207 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001208 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001209
Mike Frysinger94a670c2014-09-19 12:46:26 -04001210 # Summarize all the errors we saw (if any).
1211 lines = ''
1212 for layout_path, errors in all_errors.items():
1213 if errors:
1214 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1215 if lines:
1216 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1217 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001218
1219
Keigo Oka4a09bd92019-05-07 14:01:00 +09001220def _check_no_new_gyp(_project, commit):
1221 """Verifies no project starts to use GYP."""
1222 whitelist = [
1223 'aosp/platform/system/update_engine',
1224 'chromeos/ap',
1225 'chromeos/ap-daemons',
1226 'chromeos/platform/actions',
1227 'chromeos/platform/arc-oemcrypto',
1228 'chromeos/platform/drivefs',
1229 'chromeos/platform/drivefs-google3',
1230 'chromeos/platform/experimental-touch-fw',
1231 'chromeos/platform/gdisp',
1232 'chromeos/platform/nest-nn',
1233 'chromeos/platform/whisper',
1234 'chromeos/thermald',
1235 'chromeos/vendor/fibocom-firmware',
1236 'chromiumos/platform/cfm-device-monitor',
1237 'chromiumos/platform/google-breakpad',
1238 'chromiumos/platform2',
1239 'chromiumos/third_party/atrusctl',
1240 'chromiumos/third_party/virtual-usb-printer',
1241 'weave/libweave',
1242 ]
1243 if _project.name in whitelist:
1244 return None
1245
1246 gypfiles = _filter_files(
1247 _get_affected_files(commit, include_symlinks=True, relative=True),
1248 [r'\.gyp$'])
1249
1250 if gypfiles:
1251 return HookFailure('GYP is deprecated and not allowed in a new project:',
1252 gypfiles)
1253
1254
Ryan Cuiec4d6332011-05-02 14:15:25 -07001255# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001256
Ryan Cui1562fb82011-05-09 11:01:31 -07001257
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001258def _check_clang_format(_project, commit, options=()):
1259 """Runs clang-format on the given project"""
1260 hooks_dir = _get_hooks_dir()
1261 options = list(options)
1262 if commit == PRE_SUBMIT:
1263 options.append('--commit=HEAD')
1264 else:
1265 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001266 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001267 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1268 print_cmd=False,
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001269 stdout_to_pipe=True,
1270 combine_stdout_stderr=True,
1271 error_code_ok=True)
1272 if cmd_result.returncode:
1273 return HookFailure('clang-format.py errors/warnings\n\n' +
1274 cmd_result.output)
1275
1276
Mike Frysingerae409522014-02-01 03:16:11 -05001277def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001278 """Runs checkpatch.pl on the given project"""
1279 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001280 options = list(options)
1281 if commit == PRE_SUBMIT:
1282 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1283 # this case.
1284 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001285 # Always ignore the check for the MAINTAINERS file. We do not track that
1286 # information on that file in our source trees, so let's suppress the
1287 # warning.
1288 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001289 # Do not complain about the Change-Id: fields, since we use Gerrit.
1290 # Upstream does not want those lines (since they do not use Gerrit), but
1291 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001292 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001293 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001294 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1295 print_cmd=False,
1296 input=_get_patch(commit),
1297 stdout_to_pipe=True,
1298 combine_stdout_stderr=True,
1299 error_code_ok=True)
1300 if cmd_result.returncode:
1301 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001302
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001303
Brian Norris23c62e92018-11-14 12:25:51 -08001304def _run_kerneldoc(_project, commit, options=()):
1305 """Runs kernel-doc validator on the given project"""
1306 included, excluded = _parse_common_inclusion_options(options)
1307 files = _filter_files(_get_affected_files(commit, relative=True),
1308 included, excluded)
1309 if files:
1310 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001311 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Brian Norris23c62e92018-11-14 12:25:51 -08001312 output = _run_command(cmd=cmd, combine_stdout_stderr=True)
1313 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001314 return HookFailure('kernel-doc errors/warnings:',
1315 items=output.splitlines())
Brian Norris23c62e92018-11-14 12:25:51 -08001316
1317
Mike Frysingerae409522014-02-01 03:16:11 -05001318def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001319 """Makes sure kernel config changes are not mixed with code changes"""
1320 files = _get_affected_files(commit)
1321 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1322 return HookFailure('Changes to chromeos/config/ and regular files must '
1323 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001324
Mike Frysingerae409522014-02-01 03:16:11 -05001325
1326def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001327 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001328 ret = []
1329
1330 files = _filter_files(_get_affected_files(commit, relative=True),
1331 [r'.*\.json$'])
1332 for f in files:
1333 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001334 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001335 json.loads(data)
1336 except Exception as e:
1337 ret.append('%s: Invalid JSON: %s' % (f, e))
1338
1339 if ret:
1340 return HookFailure('\n'.join(ret))
Dale Curtis2975c432011-05-03 17:25:20 -07001341
1342
Mike Frysingerae409522014-02-01 03:16:11 -05001343def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001344 """Make sure Manifest files only have comments & DIST lines."""
1345 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001346
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001347 manifests = _filter_files(_get_affected_files(commit, relative=True),
1348 [r'.*/Manifest$'])
1349 for path in manifests:
1350 data = _get_file_content(path, commit)
1351
1352 # Disallow blank files.
1353 if not data.strip():
1354 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001355 continue
1356
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001357 # Make sure the last newline isn't omitted.
1358 if data[-1] != '\n':
1359 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001360
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001361 # Do not allow leading or trailing blank lines.
1362 lines = data.splitlines()
1363 if not lines[0]:
1364 ret.append('%s: delete leading blank lines' % (path,))
1365 if not lines[-1]:
1366 ret.append('%s: delete trailing blank lines' % (path,))
1367
1368 for line in lines:
1369 # Disallow leading/trailing whitespace.
1370 if line != line.strip():
1371 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1372
1373 # Allow blank lines & comments.
1374 line = line.split('#', 1)[0]
1375 if not line:
1376 continue
1377
1378 # All other linse should start with DIST.
1379 if not line.startswith('DIST '):
1380 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1381 break
1382
1383 if ret:
1384 return HookFailure('\n'.join(ret))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001385
1386
Mike Frysingerae409522014-02-01 03:16:11 -05001387def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001388 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001389 if commit == PRE_SUBMIT:
1390 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001391 BRANCH_RE = r'\nBRANCH=\S+'
1392
1393 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1394 msg = ('Changelist description needs BRANCH field (after first line)\n'
1395 'E.g. BRANCH=none or BRANCH=link,snow')
1396 return HookFailure(msg)
1397
1398
Mike Frysingerae409522014-02-01 03:16:11 -05001399def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001400 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001401 if commit == PRE_SUBMIT:
1402 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001403 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1404
1405 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1406 msg = ('Changelist description needs Signed-off-by: field\n'
1407 'E.g. Signed-off-by: My Name <me@chromium.org>')
1408 return HookFailure(msg)
1409
1410
Aviv Keshet5ac59522017-01-31 14:28:27 -08001411def _check_cq_ini_well_formed(_project, commit):
1412 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1413 pattern = '.*' + constants.CQ_CONFIG_FILENAME
Mike Frysingerd0523442018-01-03 17:05:29 -05001414 files = _filter_files(_get_affected_files(commit, relative=True), (pattern,))
Aviv Keshet5ac59522017-01-31 14:28:27 -08001415
1416 # TODO(akeshet): Check not only that the file is parseable, but that all the
1417 # pre-cq configs it requests are existing ones.
1418 for f in files:
1419 try:
1420 parser = ConfigParser.SafeConfigParser()
1421 # Prior to python3, ConfigParser has no read_string method, so we must
1422 # pass it either a file path or file like object. And we must use
1423 # _get_file_content to fetch file contents to ensure we are examining the
1424 # commit diff, rather than whatever's on disk.
1425 contents = _get_file_content(f, commit)
1426 parser.readfp(StringIO.StringIO(contents))
1427 except ConfigParser.Error as e:
1428 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1429 (f, e))
1430 return HookFailure(msg)
1431
1432
Jon Salz3ee59de2012-08-18 13:54:22 +08001433def _run_project_hook_script(script, project, commit):
1434 """Runs a project hook script.
1435
1436 The script is run with the following environment variables set:
1437 PRESUBMIT_PROJECT: The affected project
1438 PRESUBMIT_COMMIT: The affected commit
1439 PRESUBMIT_FILES: A newline-separated list of affected files
1440
1441 The script is considered to fail if the exit code is non-zero. It should
1442 write an error message to stdout.
1443 """
1444 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001445 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001446 env['PRESUBMIT_COMMIT'] = commit
1447
1448 # Put affected files in an environment variable
1449 files = _get_affected_files(commit)
1450 env['PRESUBMIT_FILES'] = '\n'.join(files)
1451
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001452 cmd_result = cros_build_lib.RunCommand(cmd=script,
1453 env=env,
1454 shell=True,
1455 print_cmd=False,
1456 input=os.devnull,
1457 stdout_to_pipe=True,
1458 combine_stdout_stderr=True,
1459 error_code_ok=True)
1460 if cmd_result.returncode:
1461 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001462 if stdout:
1463 stdout = re.sub('(?m)^', ' ', stdout)
1464 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001465 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001466 ':\n' + stdout if stdout else ''))
1467
1468
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001469def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001470 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001471
Brian Norris77608e12018-04-06 10:38:43 -07001472 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001473 prefix = os.path.commonprefix(files)
1474 prefix = os.path.dirname(prefix)
1475
1476 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001477 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001478 return
1479
1480 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001481
1482 # The common files may all be within a subdirectory of the main project
1483 # directory, so walk up the tree until we find an alias file.
1484 # _get_affected_files() should return relative paths, but check against '/' to
1485 # ensure that this loop terminates even if it receives an absolute path.
1486 while prefix and prefix != '/':
1487 alias_file = os.path.join(prefix, '.project_alias')
1488
1489 # If an alias exists, use it.
1490 if os.path.isfile(alias_file):
1491 project_name = osutils.ReadFile(alias_file).strip()
1492
1493 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001494
1495 if not _get_commit_desc(commit).startswith(project_name + ': '):
1496 return HookFailure('The commit title for changes affecting only %s'
1497 ' should start with \"%s: \"'
1498 % (project_name, project_name))
1499
1500
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001501def _check_filepath_chartype(_project, commit):
1502 """Checks that FilePath::CharType stuff is not used."""
1503
1504 FILEPATH_REGEXP = re.compile('|'.join(
1505 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001506 r'(?:base::)?FilePath::FromUTF8Unsafe',
1507 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001508 r'FILE_PATH_LITERAL']))
1509 files = _filter_files(_get_affected_files(commit, relative=True),
1510 [r'.*\.(cc|h)$'])
1511
1512 errors = []
1513 for afile in files:
1514 for line_num, line in _get_file_diff(afile, commit):
1515 m = re.search(FILEPATH_REGEXP, line)
1516 if m:
1517 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1518
1519 if errors:
1520 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1521 return HookFailure(msg, errors)
1522
1523
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001524def _check_exec_files(_project, commit):
1525 """Make +x bits on files."""
1526 # List of files that should never be +x.
1527 NO_EXEC = (
1528 'ChangeLog*',
1529 'COPYING',
1530 'make.conf',
1531 'make.defaults',
1532 'Manifest',
1533 'OWNERS',
1534 'package.use',
1535 'package.keywords',
1536 'package.mask',
1537 'parent',
1538 'README',
1539 'TODO',
1540 '.gitignore',
1541 '*.[achly]',
1542 '*.[ch]xx',
1543 '*.boto',
1544 '*.cc',
1545 '*.cfg',
1546 '*.conf',
1547 '*.config',
1548 '*.cpp',
1549 '*.css',
1550 '*.ebuild',
1551 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001552 '*.gn',
1553 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001554 '*.gyp',
1555 '*.gypi',
1556 '*.htm',
1557 '*.html',
1558 '*.ini',
1559 '*.js',
1560 '*.json',
1561 '*.md',
1562 '*.mk',
1563 '*.patch',
1564 '*.policy',
1565 '*.proto',
1566 '*.raw',
1567 '*.rules',
1568 '*.service',
1569 '*.target',
1570 '*.txt',
1571 '*.xml',
1572 '*.yaml',
1573 )
1574
1575 def FinalName(obj):
1576 # If the file is being deleted, then the dst_file is not set.
1577 if obj.dst_file is None:
1578 return obj.src_file
1579 else:
1580 return obj.dst_file
1581
1582 bad_files = []
1583 files = _get_affected_files(commit, relative=True, full_details=True)
1584 for f in files:
1585 mode = int(f.dst_mode, 8)
1586 if not mode & 0o111:
1587 continue
1588 name = FinalName(f)
1589 for no_exec in NO_EXEC:
1590 if fnmatch.fnmatch(name, no_exec):
1591 bad_files.append(name)
1592 break
1593
1594 if bad_files:
1595 return HookFailure('These files should not be executable. '
1596 'Please `chmod -x` them.', bad_files)
1597
1598
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001599# Base
1600
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001601# A list of hooks which are not project specific and check patch description
1602# (as opposed to patch body).
1603_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001604 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001605 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001606 _check_change_has_test_field,
1607 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001608 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001609 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001610]
1611
1612
1613# A list of hooks that are not project-specific
1614_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001615 _check_cq_ini_well_formed,
1616 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001617 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001618 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001619 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001620 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001621 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001622 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001623 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001624 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001625 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001626 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001627 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001628 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001629 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001630 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001631]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001632
Ryan Cui1562fb82011-05-09 11:01:31 -07001633
Ryan Cui9b651632011-05-11 11:38:58 -07001634# A dictionary of project-specific hooks(callbacks), indexed by project name.
1635# dict[project] = [callback1, callback2]
1636_PROJECT_SPECIFIC_HOOKS = {
Mike Frysingeraf891292015-03-25 19:46:53 -04001637 "chromiumos/third_party/kernel": [_kernel_configcheck],
1638 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001639}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001640
Ryan Cui1562fb82011-05-09 11:01:31 -07001641
Ryan Cui9b651632011-05-11 11:38:58 -07001642# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001643# that the flag controls (value).
1644_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001645 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001646 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001647 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001648 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001649 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001650 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001651 'cros_license_check': _check_cros_license,
1652 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001653 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001654 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001655 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001656 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001657 'bug_field_check': _check_change_has_bug_field,
1658 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001659 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001660 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001661 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001662 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001663}
1664
1665
Mike Frysinger3554bc92015-03-11 04:59:21 -04001666def _get_override_hooks(config):
1667 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001668
1669 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001670
1671 Args:
1672 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001673 """
1674 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001675 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001676 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001677 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001678
Mike Frysinger3554bc92015-03-11 04:59:21 -04001679 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001680 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001681
1682 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001683 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001684 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001685 if flag not in valid_keys:
1686 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1687 (flag, _CONFIG_FILE))
1688
Ryan Cui9b651632011-05-11 11:38:58 -07001689 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001690 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001691 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001692 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1693 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001694 if enabled:
1695 enable_flags.append(flag)
1696 else:
1697 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001698
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001699 # See if this hook has custom options.
1700 if enabled:
1701 try:
1702 options = config.get(SECTION_OPTIONS, flag)
1703 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001704 hooks[flag].__name__ = flag
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001705 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1706 pass
1707
1708 enabled_hooks = set(hooks[x] for x in enable_flags)
1709 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001710 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001711
1712
Jon Salz3ee59de2012-08-18 13:54:22 +08001713def _get_project_hook_scripts(config):
1714 """Returns a list of project-specific hook scripts.
1715
1716 Args:
1717 config: A ConfigParser for the project's config file.
1718 """
1719 SECTION = 'Hook Scripts'
1720 if not config.has_section(SECTION):
1721 return []
1722
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001723 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001724
1725
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001726def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001727 """Returns a list of hooks that need to be run for a project.
1728
1729 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001730
1731 Args:
1732 project: A string, name of the project.
1733 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001734 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001735 config = ConfigParser.RawConfigParser()
1736 try:
1737 config.read(_CONFIG_FILE)
1738 except ConfigParser.Error:
1739 # Just use an empty config file
1740 config = ConfigParser.RawConfigParser()
1741
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001742 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001743 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001744 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001745 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001746
Mike Frysinger3554bc92015-03-11 04:59:21 -04001747 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001748 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1749
1750 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1751 # override, keep the override only. Note that the override may end up being
1752 # a functools.partial, in which case we need to extract the .func to compare
1753 # it to the common hooks.
1754 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1755 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1756
1757 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001758
1759 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001760 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1761 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001762
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001763 for name, script in _get_project_hook_scripts(config):
1764 func = functools.partial(_run_project_hook_script, script)
1765 func.__name__ = name
1766 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001767
Ryan Cui9b651632011-05-11 11:38:58 -07001768 return hooks
1769
1770
Alex Deymo643ac4c2015-09-03 10:40:50 -07001771def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001772 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001773 """For each project run its project specific hook from the hooks dictionary.
1774
1775 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001776 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001777 proj_dir: If non-None, this is the directory the project is in. If None,
1778 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001779 commit_list: A list of commits to run hooks against. If None or empty list
1780 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001781 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001782
1783 Returns:
1784 Boolean value of whether any errors were ecountered while running the hooks.
1785 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001786 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001787 proj_dirs = _run_command(
1788 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001789 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001790 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001791 print('Please specify a valid project.', file=sys.stderr)
1792 return True
1793 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001794 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001795 file=sys.stderr)
1796 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1797 return True
1798 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001799
Ryan Cuiec4d6332011-05-02 14:15:25 -07001800 pwd = os.getcwd()
1801 # hooks assume they are run from the root of the project
1802 os.chdir(proj_dir)
1803
Alex Deymo643ac4c2015-09-03 10:40:50 -07001804 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1805 '--symbolic-full-name', '@{u}']).strip()
1806 if not remote_branch:
1807 print('Your project %s doesn\'t track any remote repo.' % project_name,
1808 file=sys.stderr)
1809 remote = None
1810 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10001811 branch_items = remote_branch.split('/', 1)
1812 if len(branch_items) != 2:
1813 PrintErrorForProject(
1814 project_name,
1815 HookFailure(
1816 'Cannot get remote and branch name (%s)' % remote_branch))
1817 os.chdir(pwd)
1818 return True
1819 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07001820
1821 project = Project(name=project_name, dir=proj_dir, remote=remote)
1822
Doug Anderson14749562013-06-26 13:38:29 -07001823 if not commit_list:
1824 try:
1825 commit_list = _get_commits()
1826 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001827 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001828 os.chdir(pwd)
1829 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001830
Alex Deymo643ac4c2015-09-03 10:40:50 -07001831 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001832 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001833 commit_count = len(commit_list)
1834 for i, commit in enumerate(commit_list):
Ryan Cui1562fb82011-05-09 11:01:31 -07001835 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001836 for hook in hooks:
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001837 output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' %
1838 (i + 1, commit_count, commit, hook.__name__))
1839 print(output, end='\r')
1840 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001841 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001842 print(' ' * len(output), end='\r')
1843 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001844 if hook_error:
1845 error_list.append(hook_error)
1846 error_found = True
1847 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001848 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001849 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001850
Ryan Cuiec4d6332011-05-02 14:15:25 -07001851 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001852 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001853
Mike Frysingerae409522014-02-01 03:16:11 -05001854
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001855# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001856
Ryan Cui1562fb82011-05-09 11:01:31 -07001857
Mike Frysingerae409522014-02-01 03:16:11 -05001858def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001859 """Main function invoked directly by repo.
1860
1861 This function will exit directly upon error so that repo doesn't print some
1862 obscure error message.
1863
1864 Args:
1865 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001866 worktree_list: A list of directories. It should be the same length as
1867 project_list, so that each entry in project_list matches with a directory
1868 in worktree_list. If None, we will attempt to calculate the directories
1869 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001870 kwargs: Leave this here for forward-compatibility.
1871 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001872 found_error = False
David James2edd9002013-10-11 14:09:19 -07001873 if not worktree_list:
1874 worktree_list = [None] * len(project_list)
1875 for project, worktree in zip(project_list, worktree_list):
1876 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001877 found_error = True
1878
Mike Frysingerae409522014-02-01 03:16:11 -05001879 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001880 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001881 '- To disable some source style checks, and for other hints, see '
1882 '<checkout_dir>/src/repohooks/README\n'
1883 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001884 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001885 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001886
Ryan Cui1562fb82011-05-09 11:01:31 -07001887
Doug Anderson44a644f2011-11-02 10:37:37 -07001888def _identify_project(path):
1889 """Identify the repo project associated with the given path.
1890
1891 Returns:
1892 A string indicating what project is associated with the path passed in or
1893 a blank string upon failure.
1894 """
1895 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001896 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001897
1898
Mike Frysinger55f85b52014-12-18 14:45:21 -05001899def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001900 """Run hooks directly (outside of the context of repo).
1901
Doug Anderson44a644f2011-11-02 10:37:37 -07001902 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001903 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001904
1905 Returns:
1906 0 if no pre-upload failures, 1 if failures.
1907
1908 Raises:
1909 BadInvocation: On some types of invocation errors.
1910 """
Mike Frysinger66142932014-12-18 14:55:57 -05001911 parser = commandline.ArgumentParser(description=__doc__)
1912 parser.add_argument('--dir', default=None,
1913 help='The directory that the project lives in. If not '
1914 'specified, use the git project root based on the cwd.')
1915 parser.add_argument('--project', default=None,
1916 help='The project repo path; this can affect how the '
1917 'hooks get run, since some hooks are project-specific. '
1918 'For chromite this is chromiumos/chromite. If not '
1919 'specified, the repo tool will be used to figure this '
1920 'out based on the dir.')
1921 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08001922 help='Rerun hooks on old commits since some point '
1923 'in the past. The argument could be a date (should '
1924 'match git log\'s concept of a date, e.g. 2012-06-20), '
1925 'or a SHA1, or just a number of commits to check (from 1 '
1926 'to 99). This option is mutually exclusive with '
1927 '--pre-submit.')
Mike Frysinger66142932014-12-18 14:55:57 -05001928 parser.add_argument('--pre-submit', action="store_true",
1929 help='Run the check against the pending commit. '
1930 'This option should be used at the \'git commit\' '
1931 'phase as opposed to \'repo upload\'. This option '
1932 'is mutually exclusive with --rerun-since.')
1933 parser.add_argument('commits', nargs='*',
1934 help='Check specific commits')
1935 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001936
Doug Anderson14749562013-06-26 13:38:29 -07001937 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001938 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001939 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001940 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001941
Vadim Bendebury75447b92018-01-10 12:06:01 -08001942 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
1943 # This must be the number of commits to check. We don't expect the user
1944 # to want to check more than 99 commits.
1945 limit = '-n%s' % opts.rerun_since
1946 elif git.IsSHA1(opts.rerun_since, False):
1947 limit = '%s..' % opts.rerun_since
1948 else:
1949 # This better be a date.
1950 limit = '--since=%s' % opts.rerun_since
1951 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07001952 all_commits = _run_command(cmd).splitlines()
1953 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1954
1955 # Eliminate chrome-bot commits but keep ordering the same...
1956 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001957 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001958
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001959 if opts.pre_submit:
1960 raise BadInvocation('rerun-since and pre-submit can not be '
1961 'used together')
1962 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001963 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001964 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001965 ' '.join(opts.commits))
1966 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001967
1968 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1969 # project from CWD
1970 if opts.dir is None:
1971 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001972 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001973 if not git_dir:
1974 raise BadInvocation('The current directory is not part of a git project.')
1975 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1976 elif not os.path.isdir(opts.dir):
1977 raise BadInvocation('Invalid dir: %s' % opts.dir)
1978 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1979 raise BadInvocation('Not a git directory: %s' % opts.dir)
1980
1981 # Identify the project if it wasn't specified; this _requires_ the repo
1982 # tool to be installed and for the project to be part of a repo checkout.
1983 if not opts.project:
1984 opts.project = _identify_project(opts.dir)
1985 if not opts.project:
1986 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1987
Doug Anderson14749562013-06-26 13:38:29 -07001988 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001989 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001990 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001991 if found_error:
1992 return 1
1993 return 0
1994
1995
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001996if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001997 sys.exit(direct_main(sys.argv[1:]))