blob: 374b821b69b2f39fcae505ea642de520d9200738 [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Ryan Cui9b651632011-05-11 11:38:58 -070016import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070017import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080018import functools
Dale Curtis2975c432011-05-03 17:25:20 -070019import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070020import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070021import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070022import sys
Peter Ammon811f6702014-06-12 15:45:38 -070023import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080024import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070025
Ryan Cui1562fb82011-05-09 11:01:31 -070026from errors import (VerifyException, HookFailure, PrintErrorForProject,
27 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070028
Mike Frysinger6850d512018-05-21 12:12:14 -040029# If repo imports us, the __name__ will be __builtin__, and the cwd will be in
30# the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be in
31# that directory, so add it to our path. This works whether we're running the
32# repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a completely
33# different tree.
34if __name__ == '__builtin__':
35 sys.path.insert(0, os.getcwd())
36
37# If we're run directly, we'll find chromite relative to the repohooks dir in
38# $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
39if __name__ == '__main__':
David Jamesc3b68b32013-04-03 09:17:03 -070040 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
41
Mike Frysinger66142932014-12-18 14:55:57 -050042from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080043from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070044from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050045from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070046from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070047from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040048from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070049
Vadim Bendebury2b62d742014-06-22 13:14:51 -070050PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070051
52COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050053 # C++ and friends
54 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
55 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
56 # Scripts
57 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
58 # No extension at all, note that ALL CAPS files are black listed in
59 # COMMON_EXCLUDED_LIST below.
60 r"(^|.*[\\\/])[^.]+$",
61 # Other
62 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070063 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070064]
65
Ryan Cui1562fb82011-05-09 11:01:31 -070066
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050069 r".*/Manifest$",
70 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070071
Daniel Erate3ea3fc2015-02-13 15:27:52 -070072 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040073 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040074 r"^profiles/.*$",
75
C Shapiro8f90e9b2017-06-28 09:54:50 -060076 # Ignore config files in ebuild setup.
77 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
78 r"^chromeos-base/chromeos-bsp.*/files/.*",
79
Daniel Erate3ea3fc2015-02-13 15:27:52 -070080 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050081 r".*\.min\.js",
82 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050083
84 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070085 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070086]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070087
Ken Turnerd07564b2018-02-08 17:57:59 +110088LICENSE_EXCLUDED_PATHS = [
89 r".*/OWNERS$",
90]
Ryan Cui1562fb82011-05-09 11:01:31 -070091
Ryan Cui9b651632011-05-11 11:38:58 -070092_CONFIG_FILE = 'PRESUBMIT.cfg'
93
94
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095# File containing wildcards, one per line, matching files that should be
96# excluded from presubmit checks. Lines beginning with '#' are ignored.
97_IGNORE_FILE = '.presubmitignore'
98
99
Doug Anderson44a644f2011-11-02 10:37:37 -0700100# Exceptions
101
102
103class BadInvocation(Exception):
104 """An Exception indicating a bad invocation of the program."""
105 pass
106
107
Ryan Cui1562fb82011-05-09 11:01:31 -0700108# General Helpers
109
Sean Paulba01d402011-05-05 11:36:23 -0400110
Alex Deymo643ac4c2015-09-03 10:40:50 -0700111Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
112
113
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700114# pylint: disable=redefined-builtin
115def _run_command(cmd, cwd=None, input=None,
116 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700117 """Executes the passed in command and returns raw stdout output.
118
119 Args:
120 cmd: The command to run; should be a list of strings.
121 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700122 input: The data to pipe into this command through stdin. If a file object
123 or file descriptor, stdin will be connected directly to that.
124 redirect_stderr: Redirect stderr away from console.
125 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700128 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700129 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700130 return cros_build_lib.RunCommand(cmd=cmd,
131 cwd=cwd,
132 print_cmd=False,
133 input=input,
134 stdout_to_pipe=True,
135 redirect_stderr=redirect_stderr,
136 combine_stdout_stderr=combine_stdout_stderr,
137 error_code_ok=True).output
138# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700139
Ryan Cui1562fb82011-05-09 11:01:31 -0700140
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700141def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700142 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700143 if __name__ == '__main__':
144 # Works when file is run on its own (__file__ is defined)...
145 return os.path.abspath(os.path.dirname(__file__))
146 else:
147 # We need to do this when we're run through repo. Since repo executes
148 # us with execfile(), we don't get __file__ defined.
149 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
150 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700151
Ryan Cui1562fb82011-05-09 11:01:31 -0700152
Ryan Cuiec4d6332011-05-02 14:15:25 -0700153def _match_regex_list(subject, expressions):
154 """Try to match a list of regular expressions to a string.
155
156 Args:
157 subject: The string to match regexes on
158 expressions: A list of regular expressions to check for matches with.
159
160 Returns:
161 Whether the passed in subject matches any of the passed in regexes.
162 """
163 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500164 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700165 return True
166 return False
167
Ryan Cui1562fb82011-05-09 11:01:31 -0700168
Mike Frysingerae409522014-02-01 03:16:11 -0500169def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700170 """Filter out files based on the conditions passed in.
171
172 Args:
173 files: list of filepaths to filter
174 include_list: list of regex that when matched with a file path will cause it
175 to be added to the output list unless the file is also matched with a
176 regex in the exclude_list.
177 exclude_list: list of regex that when matched with a file will prevent it
178 from being added to the output list, even if it is also matched with a
179 regex in the include_list.
180
181 Returns:
182 A list of filepaths that contain files matched in the include_list and not
183 in the exclude_list.
184 """
185 filtered = []
186 for f in files:
187 if (_match_regex_list(f, include_list) and
188 not _match_regex_list(f, exclude_list)):
189 filtered.append(f)
190 return filtered
191
Ryan Cuiec4d6332011-05-02 14:15:25 -0700192
193# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700194
195
Ryan Cui4725d952011-05-05 15:41:19 -0700196def _get_upstream_branch():
197 """Returns the upstream tracking branch of the current branch.
198
199 Raises:
200 Error if there is no tracking branch
201 """
202 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
203 current_branch = current_branch.replace('refs/heads/', '')
204 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700205 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700206
207 cfg_option = 'branch.' + current_branch + '.%s'
208 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
209 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
210 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700211 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700212
213 return full_upstream.replace('heads', 'remotes/' + remote)
214
Ryan Cui1562fb82011-05-09 11:01:31 -0700215
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700216def _get_patch(commit):
217 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700218 if commit == PRE_SUBMIT:
219 return _run_command(['git', 'diff', '--cached', 'HEAD'])
220 else:
221 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700222
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
Jon Salz98255932012-08-18 14:48:02 +0800224def _try_utf8_decode(data):
225 """Attempts to decode a string as UTF-8.
226
227 Returns:
228 The decoded Unicode object, or the original string if parsing fails.
229 """
230 try:
231 return unicode(data, 'utf-8', 'strict')
232 except UnicodeDecodeError:
233 return data
234
235
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500236def _get_file_content(path, commit):
237 """Returns the content of a file at a specific commit.
238
239 We can't rely on the file as it exists in the filesystem as people might be
240 uploading a series of changes which modifies the file multiple times.
241
242 Note: The "content" of a symlink is just the target. So if you're expecting
243 a full file, you should check that first. One way to detect is that the
244 content will not have any newlines.
245 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700246 if commit == PRE_SUBMIT:
247 return _run_command(['git', 'diff', 'HEAD', path])
248 else:
Mike Frysingerd0523442018-01-03 17:05:29 -0500249 # Make sure people don't accidentally pass in full paths which will never
250 # work. You need to use relative=True with _get_affected_files.
251 if path.startswith('/'):
252 raise ValueError('_get_file_content must be called with relative paths: '
253 + path)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700254 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500255
256
Mike Frysingerae409522014-02-01 03:16:11 -0500257def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700258 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700259 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800260 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
261 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700262 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800263 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
264 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700265 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700266
267 new_lines = []
268 line_num = 0
269 for line in output.splitlines():
270 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
271 if m:
272 line_num = int(m.groups(1)[0])
273 continue
274 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800275 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700276 if not line.startswith('-'):
277 line_num += 1
278 return new_lines
279
Ryan Cui1562fb82011-05-09 11:01:31 -0700280
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700281def _get_ignore_wildcards(directory, cache):
282 """Get wildcards listed in a directory's _IGNORE_FILE.
283
284 Args:
285 directory: A string containing a directory path.
286 cache: A dictionary (opaque to caller) caching previously-read wildcards.
287
288 Returns:
289 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
290 wasn't present.
291 """
292 # In the cache, keys are directories and values are lists of wildcards from
293 # _IGNORE_FILE within those directories (and empty if no file was present).
294 if directory not in cache:
295 wildcards = []
296 dotfile_path = os.path.join(directory, _IGNORE_FILE)
297 if os.path.exists(dotfile_path):
298 # TODO(derat): Consider using _get_file_content() to get the file as of
299 # this commit instead of the on-disk version. This may have a noticeable
300 # performance impact, as each call to _get_file_content() runs git.
301 with open(dotfile_path, 'r') as dotfile:
302 for line in dotfile.readlines():
303 line = line.strip()
304 if line.startswith('#'):
305 continue
306 if line.endswith('/'):
307 line += '*'
308 wildcards.append(line)
309 cache[directory] = wildcards
310
311 return cache[directory]
312
313
314def _path_is_ignored(path, cache):
315 """Check whether a path is ignored by _IGNORE_FILE.
316
317 Args:
318 path: A string containing a path.
319 cache: A dictionary (opaque to caller) caching previously-read wildcards.
320
321 Returns:
322 True if a file named _IGNORE_FILE in one of the passed-in path's parent
323 directories contains a wildcard matching the path.
324 """
325 # Skip ignore files.
326 if os.path.basename(path) == _IGNORE_FILE:
327 return True
328
329 path = os.path.abspath(path)
330 base = os.getcwd()
331
332 prefix = os.path.dirname(path)
333 while prefix.startswith(base):
334 rel_path = path[len(prefix) + 1:]
335 for wildcard in _get_ignore_wildcards(prefix, cache):
336 if fnmatch.fnmatch(rel_path, wildcard):
337 return True
338 prefix = os.path.dirname(prefix)
339
340 return False
341
342
Mike Frysinger292b45d2014-11-25 01:17:10 -0500343def _get_affected_files(commit, include_deletes=False, relative=False,
344 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700345 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700346 """Returns list of file paths that were modified/added, excluding symlinks.
347
348 Args:
349 commit: The commit
350 include_deletes: If true, we'll include deleted files in the result
351 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500352 include_symlinks: If true, we'll include symlinks in the result
353 include_adds: If true, we'll include new files in the result
354 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700355 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700356
357 Returns:
358 A list of modified/added (and perhaps deleted) files
359 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500360 if not relative and full_details:
361 raise ValueError('full_details only supports relative paths currently')
362
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700363 if commit == PRE_SUBMIT:
364 return _run_command(['git', 'diff-index', '--cached',
365 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500366
367 path = os.getcwd()
368 files = git.RawDiff(path, '%s^!' % commit)
369
370 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500371 if not include_symlinks:
372 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500373
374 if not include_deletes:
375 files = [x for x in files if x.status != 'D']
376
Mike Frysinger292b45d2014-11-25 01:17:10 -0500377 if not include_adds:
378 files = [x for x in files if x.status != 'A']
379
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700380 if use_ignore_files:
381 cache = {}
382 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
383 files = [x for x in files if not is_ignored(x)]
384
Mike Frysinger292b45d2014-11-25 01:17:10 -0500385 if full_details:
386 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500387 return files
388 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500389 # Caller only cares about filenames.
390 files = [x.dst_file if x.dst_file else x.src_file for x in files]
391 if relative:
392 return files
393 else:
394 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700395
396
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700397def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700398 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700399 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700400 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700401
Ryan Cui1562fb82011-05-09 11:01:31 -0700402
Ryan Cuiec4d6332011-05-02 14:15:25 -0700403def _get_commit_desc(commit):
404 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700405 if commit == PRE_SUBMIT:
406 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400407 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700408
409
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800410def _check_lines_in_diff(commit, files, check_callable, error_description):
411 """Checks given file for errors via the given check.
412
413 This is a convenience function for common per-line checks. It goes through all
414 files and returns a HookFailure with the error description listing all the
415 failures.
416
417 Args:
418 commit: The commit we're working on.
419 files: The files to check.
420 check_callable: A callable that takes a line and returns True if this line
421 _fails_ the check.
422 error_description: A string describing the error.
423 """
424 errors = []
425 for afile in files:
426 for line_num, line in _get_file_diff(afile, commit):
427 if check_callable(line):
428 errors.append('%s, line %s' % (afile, line_num))
429 if errors:
430 return HookFailure(error_description, errors)
431
432
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900433def _parse_common_inclusion_options(options):
434 """Parses common hook options for including/excluding files.
435
436 Args:
437 options: Option string list.
438
439 Returns:
440 (included, excluded) where each one is a list of regex strings.
441 """
442 parser = argparse.ArgumentParser()
443 parser.add_argument('--exclude_regex', action='append')
444 parser.add_argument('--include_regex', action='append')
445 opts = parser.parse_args(options)
446 included = opts.include_regex or []
447 excluded = opts.exclude_regex or []
448 return included, excluded
449
450
Ryan Cuiec4d6332011-05-02 14:15:25 -0700451# Common Hooks
452
Ryan Cui1562fb82011-05-09 11:01:31 -0700453
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900454def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500455 """Checks there are no lines longer than MAX_LEN in any of the text files."""
456
Ryan Cuiec4d6332011-05-02 14:15:25 -0700457 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800458 SKIP_REGEXP = re.compile('|'.join([
459 r'https?://',
Maksim Ivanov3f677b92018-06-05 16:10:24 +0200460 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700461
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900462 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700463 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900464 included + COMMON_INCLUDED_PATHS,
465 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700466
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900467 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700468 for afile in files:
469 for line_num, line in _get_file_diff(afile, commit):
470 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500471 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800472 continue
473
474 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
475 if len(errors) == 5: # Just show the first 5 errors.
476 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700477
478 if errors:
479 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700480 return HookFailure(msg, errors)
481
Ryan Cuiec4d6332011-05-02 14:15:25 -0700482
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900483def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700484 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900485 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700486 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900487 included + COMMON_INCLUDED_PATHS,
488 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800489 return _check_lines_in_diff(commit, files,
490 lambda line: line.rstrip() != line,
491 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700492
Ryan Cuiec4d6332011-05-02 14:15:25 -0700493
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900494def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700495 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400496 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
497 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700498 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700499 r".*\.ebuild$",
500 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500501 r".*/[M|m]akefile$",
502 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700503 ]
504
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900505 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700506 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900507 included + COMMON_INCLUDED_PATHS,
508 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800509 return _check_lines_in_diff(commit, files,
510 lambda line: '\t' in line,
511 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700512
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800513
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900514def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800515 """Checks that indents use tabs only."""
516 TABS_REQUIRED_PATHS = [
517 r".*\.ebuild$",
518 r".*\.eclass$",
519 ]
520 LEADING_SPACE_RE = re.compile('[\t]* ')
521
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900522 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800523 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900524 included + TABS_REQUIRED_PATHS,
525 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800526 return _check_lines_in_diff(
527 commit, files,
528 lambda line: LEADING_SPACE_RE.match(line) is not None,
529 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700530
Ryan Cuiec4d6332011-05-02 14:15:25 -0700531
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700532def _check_gofmt(_project, commit):
533 """Checks that Go files are formatted with gofmt."""
534 errors = []
535 files = _filter_files(_get_affected_files(commit, relative=True),
536 [r'\.go$'])
537
538 for gofile in files:
539 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700540 output = _run_command(cmd=['gofmt', '-l'], input=contents,
541 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700542 if output:
543 errors.append(gofile)
544 if errors:
545 return HookFailure('Files not formatted with gofmt:', errors)
546
547
Mike Frysingerae409522014-02-01 03:16:11 -0500548def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700550 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700551
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700552 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700553 msg = 'Changelist description needs TEST field (after first line)'
554 return HookFailure(msg)
555
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556
Mike Frysingerae409522014-02-01 03:16:11 -0500557def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700558 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
559 msg = 'Changelist has invalid CQ-DEPEND target.'
560 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
561 try:
562 patch.GetPaladinDeps(_get_commit_desc(commit))
563 except ValueError as ex:
564 return HookFailure(msg, [example, str(ex)])
565
566
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800567def _check_change_is_contribution(_project, commit):
568 """Check that the change is a contribution."""
569 NO_CONTRIB = 'not a contribution'
570 if NO_CONTRIB in _get_commit_desc(commit).lower():
571 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
572 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
573 return HookFailure(msg)
574
575
Alex Deymo643ac4c2015-09-03 10:40:50 -0700576def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700577 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700578 OLD_BUG_RE = r'\nBUG=.*chromium-os'
579 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
580 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
581 'the chromium tracker in your BUG= line now.')
582 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583
Alex Deymo643ac4c2015-09-03 10:40:50 -0700584 # Android internal and external projects use "Bug: " to track bugs in
585 # buganizer.
586 BUG_COLON_REMOTES = (
587 'aosp',
588 'goog',
589 )
590 if project.remote in BUG_COLON_REMOTES:
591 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
592 if not re.search(BUG_RE, _get_commit_desc(commit)):
593 msg = ('Changelist description needs BUG field (after first line):\n'
594 'Bug: 9999 (for buganizer)\n'
595 'BUG=None')
596 return HookFailure(msg)
597 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400598 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700599 if not re.search(BUG_RE, _get_commit_desc(commit)):
600 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700601 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700602 'BUG=b:9999 (for buganizer)\n'
603 'BUG=None')
604 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700605
Ryan Cuiec4d6332011-05-02 14:15:25 -0700606
Mike Frysinger292b45d2014-11-25 01:17:10 -0500607def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700608 """Check that we're not missing a revbump of an ebuild in the given commit.
609
610 If the given commit touches files in a directory that has ebuilds somewhere
611 up the directory hierarchy, it's very likely that we need an ebuild revbump
612 in order for those changes to take effect.
613
614 It's not totally trivial to detect a revbump, so at least detect that an
615 ebuild with a revision number in it was touched. This should handle the
616 common case where we use a symlink to do the revbump.
617
618 TODO: it would be nice to enhance this hook to:
619 * Handle cases where people revbump with a slightly different syntax. I see
620 one ebuild (puppy) that revbumps with _pN. This is a false positive.
621 * Catches cases where people aren't using symlinks for revbumps. If they
622 edit a revisioned file directly (and are expected to rename it for revbump)
623 we'll miss that. Perhaps we could detect that the file touched is a
624 symlink?
625
626 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
627 still better off than without this check.
628
629 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700630 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700631 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500632 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700633
634 Returns:
635 A HookFailure or None.
636 """
Mike Frysinger011af942014-01-17 16:12:22 -0500637 # If this is the portage-stable overlay, then ignore the check. It's rare
638 # that we're doing anything other than importing files from upstream, so
639 # forcing a rev bump makes no sense.
640 whitelist = (
641 'chromiumos/overlays/portage-stable',
642 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700643 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500644 return None
645
Mike Frysinger292b45d2014-11-25 01:17:10 -0500646 def FinalName(obj):
647 # If the file is being deleted, then the dst_file is not set.
648 if obj.dst_file is None:
649 return obj.src_file
650 else:
651 return obj.dst_file
652
653 affected_path_objs = _get_affected_files(
654 commit, include_deletes=True, include_symlinks=True, relative=True,
655 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700656
657 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700658 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500659 affected_path_objs = [x for x in affected_path_objs
660 if os.path.basename(FinalName(x)) not in whitelist]
661 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700662 return None
663
664 # If we've touched any file named with a -rN.ebuild then we'll say we're
665 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500666 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
667 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700668 if touched_revved_ebuild:
669 return None
670
Mike Frysinger292b45d2014-11-25 01:17:10 -0500671 # If we're creating new ebuilds from scratch, then we don't need an uprev.
672 # Find all the dirs that new ebuilds and ignore their files/.
673 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
674 if FinalName(x).endswith('.ebuild') and x.status == 'A']
675 affected_path_objs = [obj for obj in affected_path_objs
676 if not any(FinalName(obj).startswith(x)
677 for x in ebuild_dirs)]
678 if not affected_path_objs:
679 return
680
Doug Anderson42b8a052013-06-26 10:45:36 -0700681 # We want to examine the current contents of all directories that are parents
682 # of files that were touched (up to the top of the project).
683 #
684 # ...note: we use the current directory contents even though it may have
685 # changed since the commit we're looking at. This is just a heuristic after
686 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500687 if project_top is None:
688 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700689 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500690 for obj in affected_path_objs:
691 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700692 while os.path.exists(path) and not os.path.samefile(path, project_top):
693 dirs_to_check.add(path)
694 path = os.path.dirname(path)
695
696 # Look through each directory. If it's got an ebuild in it then we'll
697 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800698 affected_paths = set(os.path.join(project_top, FinalName(x))
699 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700700 for dir_path in dirs_to_check:
701 contents = os.listdir(dir_path)
702 ebuilds = [os.path.join(dir_path, path)
703 for path in contents if path.endswith('.ebuild')]
704 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
705
C Shapiroae157ae2017-09-18 16:24:03 -0600706 affected_paths_under_9999_ebuilds = set()
707 for affected_path in affected_paths:
708 for ebuild_9999 in ebuilds_9999:
709 ebuild_dir = os.path.dirname(ebuild_9999)
710 if affected_path.startswith(ebuild_dir):
711 affected_paths_under_9999_ebuilds.add(affected_path)
712
713 # If every file changed exists under a 9999 ebuild, then skip
714 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
715 continue
716
Doug Anderson42b8a052013-06-26 10:45:36 -0700717 # If the -9999.ebuild file was touched the bot will uprev for us.
718 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500719 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700720 continue
721
722 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500723 return HookFailure('Changelist probably needs a revbump of an ebuild, '
724 'or a -r1.ebuild symlink if this is a new ebuild:\n'
725 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700726
727 return None
728
729
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500730def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500731 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500732
733 We want to get away from older EAPI's as it makes life confusing and they
734 have less builtin error checking.
735
736 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700737 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500738 commit: The commit to look at
739
740 Returns:
741 A HookFailure or None.
742 """
743 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500744 # that we're doing anything other than importing files from upstream, and
745 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500746 whitelist = (
747 'chromiumos/overlays/portage-stable',
748 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700749 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500750 return None
751
Mike Frysinger948284a2018-02-01 15:22:56 -0500752 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500753
754 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
755
756 ebuilds_re = [r'\.ebuild$']
757 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
758 ebuilds_re)
759 bad_ebuilds = []
760
761 for ebuild in ebuilds:
762 # If the ebuild does not specify an EAPI, it defaults to 0.
763 eapi = '0'
764
765 lines = _get_file_content(ebuild, commit).splitlines()
766 if len(lines) == 1:
767 # This is most likely a symlink, so skip it entirely.
768 continue
769
770 for line in lines:
771 m = get_eapi.match(line)
772 if m:
773 # Once we hit the first EAPI line in this ebuild, stop processing.
774 # The spec requires that there only be one and it be first, so
775 # checking all possible values is pointless. We also assume that
776 # it's "the" EAPI line and not something in the middle of a heredoc.
777 eapi = m.group(1)
778 break
779
780 if eapi in BAD_EAPIS:
781 bad_ebuilds.append((ebuild, eapi))
782
783 if bad_ebuilds:
784 # pylint: disable=C0301
785 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
786 # pylint: enable=C0301
787 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500788 'These ebuilds are using old EAPIs. If these are imported from\n'
789 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500790 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500791 '\t%s\n'
792 'See this guide for more details:\n%s\n' %
793 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
794
795
Mike Frysinger89bdb852014-02-01 05:26:26 -0500796def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500797 """Make sure we use the new style KEYWORDS when possible in ebuilds.
798
799 If an ebuild generally does not care about the arch it is running on, then
800 ebuilds should flag it with one of:
801 KEYWORDS="*" # A stable ebuild.
802 KEYWORDS="~*" # An unstable ebuild.
803 KEYWORDS="-* ..." # Is known to only work on specific arches.
804
805 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700806 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500807 commit: The commit to look at
808
809 Returns:
810 A HookFailure or None.
811 """
812 WHITELIST = set(('*', '-*', '~*'))
813
814 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
815
Mike Frysinger89bdb852014-02-01 05:26:26 -0500816 ebuilds_re = [r'\.ebuild$']
817 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
818 ebuilds_re)
819
Mike Frysinger8d42d742014-09-22 15:50:21 -0400820 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500821 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400822 # We get the full content rather than a diff as the latter does not work
823 # on new files (like when adding new ebuilds).
824 lines = _get_file_content(ebuild, commit).splitlines()
825 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500826 m = get_keywords.match(line)
827 if m:
828 keywords = set(m.group(1).split())
829 if not keywords or WHITELIST - keywords != WHITELIST:
830 continue
831
Mike Frysinger8d42d742014-09-22 15:50:21 -0400832 bad_ebuilds.append(ebuild)
833
834 if bad_ebuilds:
835 return HookFailure(
836 '%s\n'
837 'Please update KEYWORDS to use a glob:\n'
838 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
839 ' KEYWORDS="*"\n'
840 'If the ebuild should be marked unstable (normal for '
841 'cros-workon / 9999 ebuilds):\n'
842 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400843 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400844 'then use -* like so:\n'
845 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500846
847
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800848def _check_ebuild_licenses(_project, commit):
849 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800850 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800851 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
852
853 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800854 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800855
856 for ebuild in touched_ebuilds:
857 # Skip virutal packages.
858 if ebuild.split('/')[-3] == 'virtual':
859 continue
860
Alex Kleinb5953522018-08-03 11:44:21 -0600861 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
862 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
863
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800864 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800865 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -0600866 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
867 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800868 except ValueError as e:
869 return HookFailure(e.message, [ebuild])
870
871 # Also ignore licenses ending with '?'
872 for license_type in [x for x in license_types
873 if x not in LICENSES_IGNORE and not x.endswith('?')]:
874 try:
Alex Kleinb5953522018-08-03 11:44:21 -0600875 licenses_lib.Licensing.FindLicenseType(license_type,
876 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800877 except AssertionError as e:
878 return HookFailure(e.message, [ebuild])
879
880
Mike Frysingercd363c82014-02-01 05:20:18 -0500881def _check_ebuild_virtual_pv(project, commit):
882 """Enforce the virtual PV policies."""
883 # If this is the portage-stable overlay, then ignore the check.
884 # We want to import virtuals as-is from upstream Gentoo.
885 whitelist = (
886 'chromiumos/overlays/portage-stable',
887 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700888 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500889 return None
890
891 # We assume the repo name is the same as the dir name on disk.
892 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700893 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500894
895 is_variant = lambda x: x.startswith('overlay-variant-')
896 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700897 is_baseboard = lambda x: x.startswith('baseboard-')
898 is_chipset = lambda x: x.startswith('chipset-')
899 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -0500900 is_private = lambda x: x.endswith('-private')
901
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700902 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
903 is_baseboard(x) or is_project(x))
904
Mike Frysingercd363c82014-02-01 05:20:18 -0500905 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
906
907 ebuilds_re = [r'\.ebuild$']
908 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
909 ebuilds_re)
910 bad_ebuilds = []
911
912 for ebuild in ebuilds:
913 m = get_pv.match(ebuild)
914 if m:
915 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700916 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700917 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500918
919 pv = m.group(3).split('-', 1)[0]
920
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800921 # Virtual versions >= 4 are special cases used above the standard
922 # versioning structure, e.g. if one has a board inheriting a board.
923 if float(pv) >= 4:
924 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -0500925 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -0700926 if is_private(overlay):
927 want_pv = '3.5' if is_variant(overlay) else '3'
928 elif is_board(overlay):
929 want_pv = '2.5' if is_variant(overlay) else '2'
930 elif is_baseboard(overlay):
931 want_pv = '1.9'
932 elif is_chipset(overlay):
933 want_pv = '1.8'
934 elif is_project(overlay):
935 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -0500936 else:
937 want_pv = '1'
938
939 if pv != want_pv:
940 bad_ebuilds.append((ebuild, pv, want_pv))
941
942 if bad_ebuilds:
943 # pylint: disable=C0301
944 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
945 # pylint: enable=C0301
946 return HookFailure(
947 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
948 '\t%s\n'
949 'If this is an upstream Gentoo virtual, then you may ignore this\n'
950 'check (and re-run w/--no-verify). Otherwise, please see this\n'
951 'page for more details:\n%s\n' %
952 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
953 for x in bad_ebuilds]), url))
954
955
Daniel Erat9d203ff2015-02-17 10:12:21 -0700956def _check_portage_make_use_var(_project, commit):
957 """Verify that $USE is set correctly in make.conf and make.defaults."""
958 files = _filter_files(_get_affected_files(commit, relative=True),
959 [r'(^|/)make.(conf|defaults)$'])
960
961 errors = []
962 for path in files:
963 basename = os.path.basename(path)
964
965 # Has a USE= line already been encountered in this file?
966 saw_use = False
967
968 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
969 if not line.startswith('USE='):
970 continue
971
972 preserves_use = '${USE}' in line or '$USE' in line
973
974 if (basename == 'make.conf' or
975 (basename == 'make.defaults' and saw_use)) and not preserves_use:
976 errors.append('%s:%d: missing ${USE}' % (path, i))
977 elif basename == 'make.defaults' and not saw_use and preserves_use:
978 errors.append('%s:%d: ${USE} referenced in initial declaration' %
979 (path, i))
980
981 saw_use = True
982
983 if errors:
984 return HookFailure(
985 'One or more Portage make files appear to set USE incorrectly.\n'
986 '\n'
987 'All USE assignments in make.conf and all assignments after the\n'
988 'initial declaration in make.defaults should contain "${USE}" to\n'
989 'preserve previously-set flags.\n'
990 '\n'
991 'The initial USE declaration in make.defaults should not contain\n'
992 '"${USE}".\n',
993 errors)
994
995
Mike Frysingerae409522014-02-01 03:16:11 -0500996def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700997 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400998 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700999 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001000 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001001 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001002 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001003
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001004 # S-o-b tags always allowed to follow Change-ID.
1005 allowed_tags = ['Signed-off-by']
1006
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001007 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001008 cherry_pick_marker = 'cherry picked from commit'
1009
1010 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001011 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001012 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1013 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001014 end = end[:-1]
1015
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001016 # Note that descriptions could have multiple cherry pick markers.
1017 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001018
1019 if [x for x in end if not re.search(tag_search, x)]:
1020 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1021 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001022
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001023
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001024def _check_commit_message_style(_project, commit):
1025 """Verify that the commit message matches our style.
1026
1027 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1028 commit hooks.
1029 """
1030 desc = _get_commit_desc(commit)
1031
1032 # The first line should be by itself.
1033 lines = desc.splitlines()
1034 if len(lines) > 1 and lines[1]:
1035 return HookFailure('The second line of the commit message must be blank.')
1036
1037 # The first line should be one sentence.
1038 if '. ' in lines[0]:
1039 return HookFailure('The first line cannot be more than one sentence.')
1040
1041 # The first line cannot be too long.
1042 MAX_FIRST_LINE_LEN = 100
1043 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1044 return HookFailure('The first line must be less than %i chars.' %
1045 MAX_FIRST_LINE_LEN)
1046
1047
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001048def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001049 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001050
Mike Frysinger98638102014-08-28 00:15:08 -04001051 Should be following the spec:
1052 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1053 """
1054 # For older years, be a bit more flexible as our policy says leave them be.
1055 LICENSE_HEADER = (
1056 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001057 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001058 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001059 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001060 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001061 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001062 )
1063 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1064
1065 # For newer years, be stricter.
1066 COPYRIGHT_LINE = (
1067 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001068 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001069 )
1070 copyright_re = re.compile(COPYRIGHT_LINE)
1071
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001072 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001073
Mike Frysinger98638102014-08-28 00:15:08 -04001074 bad_files = []
1075 bad_copyright_files = []
Ken Turnerd07564b2018-02-08 17:57:59 +11001076 files = _filter_files(
1077 _get_affected_files(commit, relative=True),
1078 included + COMMON_INCLUDED_PATHS,
1079 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001080
1081 for f in files:
1082 contents = _get_file_content(f, commit)
1083 if not contents:
1084 # Ignore empty files.
1085 continue
1086
1087 if not license_re.search(contents):
1088 bad_files.append(f)
1089 elif copyright_re.search(contents):
1090 bad_copyright_files.append(f)
1091
1092 if bad_files:
1093 msg = '%s:\n%s\n%s' % (
1094 'License must match', license_re.pattern,
1095 'Found a bad header in these files:')
1096 return HookFailure(msg, bad_files)
1097
1098 if bad_copyright_files:
1099 msg = 'Do not use (c) in copyright headers in new files:'
1100 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001101
1102
Amin Hassani391efa92018-01-26 17:58:05 -08001103def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001104 """Verifies the AOSP license/copyright header.
1105
1106 AOSP uses the Apache2 License:
1107 https://source.android.com/source/licenses.html
1108 """
1109 LICENSE_HEADER = (
1110 r"""^[#/\*]*
1111[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1112[#/\*]* ?
1113[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1114[#/\*]* ?you may not use this file except in compliance with the License\.
1115[#/\*]* ?You may obtain a copy of the License at
1116[#/\*]* ?
1117[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1118[#/\*]* ?
1119[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1120[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1121[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1122 r"""implied\.
1123[#/\*]* ?See the License for the specific language governing permissions and
1124[#/\*]* ?limitations under the License\.
1125[#/\*]*$
1126"""
1127 )
1128 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1129
Amin Hassani391efa92018-01-26 17:58:05 -08001130 included, excluded = _parse_common_inclusion_options(options)
1131
Ken Turnerd07564b2018-02-08 17:57:59 +11001132 files = _filter_files(
1133 _get_affected_files(commit, relative=True),
1134 included + COMMON_INCLUDED_PATHS,
1135 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001136
1137 bad_files = []
1138 for f in files:
1139 contents = _get_file_content(f, commit)
1140 if not contents:
1141 # Ignore empty files.
1142 continue
1143
1144 if not license_re.search(contents):
1145 bad_files.append(f)
1146
1147 if bad_files:
1148 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1149 license_re.pattern)
1150 return HookFailure(msg, bad_files)
1151
1152
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001153def _check_layout_conf(_project, commit):
1154 """Verifies the metadata/layout.conf file."""
1155 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001156 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001157 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001158 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001159
Mike Frysinger94a670c2014-09-19 12:46:26 -04001160 # Handle multiple overlays in a single commit (like the public tree).
1161 for f in _get_affected_files(commit, relative=True):
1162 if f.endswith(repo_name):
1163 repo_names.append(f)
1164 elif f.endswith(layout_path):
1165 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001166
1167 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001168 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001169 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001170 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001171
Mike Frysinger94a670c2014-09-19 12:46:26 -04001172 # Gather all the errors in one pass so we show one full message.
1173 all_errors = {}
1174 for layout_path in layout_paths:
1175 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001176
Mike Frysinger94a670c2014-09-19 12:46:26 -04001177 # Make sure the config file is sorted.
1178 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1179 if x and x[0] != '#']
1180 if sorted(data) != data:
1181 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001182
Mike Frysinger94a670c2014-09-19 12:46:26 -04001183 # Require people to set specific values all the time.
1184 settings = (
1185 # TODO: Enable this for everyone. http://crbug.com/408038
1186 #('fast caching', 'cache-format = md5-dict'),
1187 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001188 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1189 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001190 )
1191 for reason, line in settings:
1192 if line not in data:
1193 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001194
Mike Frysinger94a670c2014-09-19 12:46:26 -04001195 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001196 if 'use-manifests = strict' not in data:
1197 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001198
Mike Frysinger94a670c2014-09-19 12:46:26 -04001199 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001200 for line in data:
1201 if line.startswith('repo-name = '):
1202 break
1203 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001204 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001205
Mike Frysinger94a670c2014-09-19 12:46:26 -04001206 # Summarize all the errors we saw (if any).
1207 lines = ''
1208 for layout_path, errors in all_errors.items():
1209 if errors:
1210 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1211 if lines:
1212 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1213 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001214
1215
Ryan Cuiec4d6332011-05-02 14:15:25 -07001216# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001217
Ryan Cui1562fb82011-05-09 11:01:31 -07001218
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001219def _check_clang_format(_project, commit, options=()):
1220 """Runs clang-format on the given project"""
1221 hooks_dir = _get_hooks_dir()
1222 options = list(options)
1223 if commit == PRE_SUBMIT:
1224 options.append('--commit=HEAD')
1225 else:
1226 options.extend(['--commit', commit])
1227 cmd = ['%s/clang-format.py' % hooks_dir] + options
1228 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1229 print_cmd=False,
1230 input=_get_patch(commit),
1231 stdout_to_pipe=True,
1232 combine_stdout_stderr=True,
1233 error_code_ok=True)
1234 if cmd_result.returncode:
1235 return HookFailure('clang-format.py errors/warnings\n\n' +
1236 cmd_result.output)
1237
1238
Mike Frysingerae409522014-02-01 03:16:11 -05001239def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001240 """Runs checkpatch.pl on the given project"""
1241 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001242 options = list(options)
1243 if commit == PRE_SUBMIT:
1244 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1245 # this case.
1246 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001247 # Always ignore the check for the MAINTAINERS file. We do not track that
1248 # information on that file in our source trees, so let's suppress the
1249 # warning.
1250 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001251 # Do not complain about the Change-Id: fields, since we use Gerrit.
1252 # Upstream does not want those lines (since they do not use Gerrit), but
1253 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001254 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001255 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001256 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1257 print_cmd=False,
1258 input=_get_patch(commit),
1259 stdout_to_pipe=True,
1260 combine_stdout_stderr=True,
1261 error_code_ok=True)
1262 if cmd_result.returncode:
1263 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001264
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001265
Mike Frysingerae409522014-02-01 03:16:11 -05001266def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001267 """Makes sure kernel config changes are not mixed with code changes"""
1268 files = _get_affected_files(commit)
1269 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1270 return HookFailure('Changes to chromeos/config/ and regular files must '
1271 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001272
Mike Frysingerae409522014-02-01 03:16:11 -05001273
1274def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001275 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001276 ret = []
1277
1278 files = _filter_files(_get_affected_files(commit, relative=True),
1279 [r'.*\.json$'])
1280 for f in files:
1281 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001282 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001283 json.loads(data)
1284 except Exception as e:
1285 ret.append('%s: Invalid JSON: %s' % (f, e))
1286
1287 if ret:
1288 return HookFailure('\n'.join(ret))
Dale Curtis2975c432011-05-03 17:25:20 -07001289
1290
Mike Frysingerae409522014-02-01 03:16:11 -05001291def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001292 """Make sure Manifest files only have comments & DIST lines."""
1293 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001294
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001295 manifests = _filter_files(_get_affected_files(commit, relative=True),
1296 [r'.*/Manifest$'])
1297 for path in manifests:
1298 data = _get_file_content(path, commit)
1299
1300 # Disallow blank files.
1301 if not data.strip():
1302 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001303 continue
1304
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001305 # Make sure the last newline isn't omitted.
1306 if data[-1] != '\n':
1307 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001308
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001309 # Do not allow leading or trailing blank lines.
1310 lines = data.splitlines()
1311 if not lines[0]:
1312 ret.append('%s: delete leading blank lines' % (path,))
1313 if not lines[-1]:
1314 ret.append('%s: delete trailing blank lines' % (path,))
1315
1316 for line in lines:
1317 # Disallow leading/trailing whitespace.
1318 if line != line.strip():
1319 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1320
1321 # Allow blank lines & comments.
1322 line = line.split('#', 1)[0]
1323 if not line:
1324 continue
1325
1326 # All other linse should start with DIST.
1327 if not line.startswith('DIST '):
1328 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1329 break
1330
1331 if ret:
1332 return HookFailure('\n'.join(ret))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001333
1334
Mike Frysingerae409522014-02-01 03:16:11 -05001335def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001336 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001337 if commit == PRE_SUBMIT:
1338 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001339 BRANCH_RE = r'\nBRANCH=\S+'
1340
1341 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1342 msg = ('Changelist description needs BRANCH field (after first line)\n'
1343 'E.g. BRANCH=none or BRANCH=link,snow')
1344 return HookFailure(msg)
1345
1346
Mike Frysingerae409522014-02-01 03:16:11 -05001347def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001348 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001349 if commit == PRE_SUBMIT:
1350 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001351 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1352
1353 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1354 msg = ('Changelist description needs Signed-off-by: field\n'
1355 'E.g. Signed-off-by: My Name <me@chromium.org>')
1356 return HookFailure(msg)
1357
1358
Aviv Keshet5ac59522017-01-31 14:28:27 -08001359def _check_cq_ini_well_formed(_project, commit):
1360 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1361 pattern = '.*' + constants.CQ_CONFIG_FILENAME
Mike Frysingerd0523442018-01-03 17:05:29 -05001362 files = _filter_files(_get_affected_files(commit, relative=True), (pattern,))
Aviv Keshet5ac59522017-01-31 14:28:27 -08001363
1364 # TODO(akeshet): Check not only that the file is parseable, but that all the
1365 # pre-cq configs it requests are existing ones.
1366 for f in files:
1367 try:
1368 parser = ConfigParser.SafeConfigParser()
1369 # Prior to python3, ConfigParser has no read_string method, so we must
1370 # pass it either a file path or file like object. And we must use
1371 # _get_file_content to fetch file contents to ensure we are examining the
1372 # commit diff, rather than whatever's on disk.
1373 contents = _get_file_content(f, commit)
1374 parser.readfp(StringIO.StringIO(contents))
1375 except ConfigParser.Error as e:
1376 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1377 (f, e))
1378 return HookFailure(msg)
1379
1380
Jon Salz3ee59de2012-08-18 13:54:22 +08001381def _run_project_hook_script(script, project, commit):
1382 """Runs a project hook script.
1383
1384 The script is run with the following environment variables set:
1385 PRESUBMIT_PROJECT: The affected project
1386 PRESUBMIT_COMMIT: The affected commit
1387 PRESUBMIT_FILES: A newline-separated list of affected files
1388
1389 The script is considered to fail if the exit code is non-zero. It should
1390 write an error message to stdout.
1391 """
1392 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001393 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001394 env['PRESUBMIT_COMMIT'] = commit
1395
1396 # Put affected files in an environment variable
1397 files = _get_affected_files(commit)
1398 env['PRESUBMIT_FILES'] = '\n'.join(files)
1399
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001400 cmd_result = cros_build_lib.RunCommand(cmd=script,
1401 env=env,
1402 shell=True,
1403 print_cmd=False,
1404 input=os.devnull,
1405 stdout_to_pipe=True,
1406 combine_stdout_stderr=True,
1407 error_code_ok=True)
1408 if cmd_result.returncode:
1409 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001410 if stdout:
1411 stdout = re.sub('(?m)^', ' ', stdout)
1412 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001413 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001414 ':\n' + stdout if stdout else ''))
1415
1416
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001417def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001418 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001419
Brian Norris77608e12018-04-06 10:38:43 -07001420 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001421 prefix = os.path.commonprefix(files)
1422 prefix = os.path.dirname(prefix)
1423
1424 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001425 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001426 return
1427
1428 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001429
1430 # The common files may all be within a subdirectory of the main project
1431 # directory, so walk up the tree until we find an alias file.
1432 # _get_affected_files() should return relative paths, but check against '/' to
1433 # ensure that this loop terminates even if it receives an absolute path.
1434 while prefix and prefix != '/':
1435 alias_file = os.path.join(prefix, '.project_alias')
1436
1437 # If an alias exists, use it.
1438 if os.path.isfile(alias_file):
1439 project_name = osutils.ReadFile(alias_file).strip()
1440
1441 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001442
1443 if not _get_commit_desc(commit).startswith(project_name + ': '):
1444 return HookFailure('The commit title for changes affecting only %s'
1445 ' should start with \"%s: \"'
1446 % (project_name, project_name))
1447
1448
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001449def _check_filepath_chartype(_project, commit):
1450 """Checks that FilePath::CharType stuff is not used."""
1451
1452 FILEPATH_REGEXP = re.compile('|'.join(
1453 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001454 r'(?:base::)?FilePath::FromUTF8Unsafe',
1455 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001456 r'FILE_PATH_LITERAL']))
1457 files = _filter_files(_get_affected_files(commit, relative=True),
1458 [r'.*\.(cc|h)$'])
1459
1460 errors = []
1461 for afile in files:
1462 for line_num, line in _get_file_diff(afile, commit):
1463 m = re.search(FILEPATH_REGEXP, line)
1464 if m:
1465 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1466
1467 if errors:
1468 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1469 return HookFailure(msg, errors)
1470
1471
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001472def _check_exec_files(_project, commit):
1473 """Make +x bits on files."""
1474 # List of files that should never be +x.
1475 NO_EXEC = (
1476 'ChangeLog*',
1477 'COPYING',
1478 'make.conf',
1479 'make.defaults',
1480 'Manifest',
1481 'OWNERS',
1482 'package.use',
1483 'package.keywords',
1484 'package.mask',
1485 'parent',
1486 'README',
1487 'TODO',
1488 '.gitignore',
1489 '*.[achly]',
1490 '*.[ch]xx',
1491 '*.boto',
1492 '*.cc',
1493 '*.cfg',
1494 '*.conf',
1495 '*.config',
1496 '*.cpp',
1497 '*.css',
1498 '*.ebuild',
1499 '*.eclass',
1500 '*.gyp',
1501 '*.gypi',
1502 '*.htm',
1503 '*.html',
1504 '*.ini',
1505 '*.js',
1506 '*.json',
1507 '*.md',
1508 '*.mk',
1509 '*.patch',
1510 '*.policy',
1511 '*.proto',
1512 '*.raw',
1513 '*.rules',
1514 '*.service',
1515 '*.target',
1516 '*.txt',
1517 '*.xml',
1518 '*.yaml',
1519 )
1520
1521 def FinalName(obj):
1522 # If the file is being deleted, then the dst_file is not set.
1523 if obj.dst_file is None:
1524 return obj.src_file
1525 else:
1526 return obj.dst_file
1527
1528 bad_files = []
1529 files = _get_affected_files(commit, relative=True, full_details=True)
1530 for f in files:
1531 mode = int(f.dst_mode, 8)
1532 if not mode & 0o111:
1533 continue
1534 name = FinalName(f)
1535 for no_exec in NO_EXEC:
1536 if fnmatch.fnmatch(name, no_exec):
1537 bad_files.append(name)
1538 break
1539
1540 if bad_files:
1541 return HookFailure('These files should not be executable. '
1542 'Please `chmod -x` them.', bad_files)
1543
1544
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001545# Base
1546
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001547# A list of hooks which are not project specific and check patch description
1548# (as opposed to patch body).
1549_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001550 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001551 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001552 _check_change_has_test_field,
1553 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001554 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001555 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001556]
1557
1558
1559# A list of hooks that are not project-specific
1560_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001561 _check_cq_ini_well_formed,
1562 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001563 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001564 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001565 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001566 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001567 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001568 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001569 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001570 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001571 _check_no_long_lines,
1572 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001573 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001574 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001575 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001576]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001577
Ryan Cui1562fb82011-05-09 11:01:31 -07001578
Ryan Cui9b651632011-05-11 11:38:58 -07001579# A dictionary of project-specific hooks(callbacks), indexed by project name.
1580# dict[project] = [callback1, callback2]
1581_PROJECT_SPECIFIC_HOOKS = {
Mike Frysingeraf891292015-03-25 19:46:53 -04001582 "chromiumos/third_party/kernel": [_kernel_configcheck],
1583 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001584}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001585
Ryan Cui1562fb82011-05-09 11:01:31 -07001586
Ryan Cui9b651632011-05-11 11:38:58 -07001587# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001588# that the flag controls (value).
1589_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001590 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001591 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001592 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001593 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001594 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001595 'cros_license_check': _check_cros_license,
1596 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001597 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001598 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001599 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001600 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001601 'bug_field_check': _check_change_has_bug_field,
1602 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001603 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001604 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001605 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001606 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001607}
1608
1609
Mike Frysinger3554bc92015-03-11 04:59:21 -04001610def _get_override_hooks(config):
1611 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001612
1613 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001614
1615 Args:
1616 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001617 """
1618 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001619 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001620 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001621 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001622
Mike Frysinger3554bc92015-03-11 04:59:21 -04001623 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001624 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001625
1626 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001627 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001628 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001629 if flag not in valid_keys:
1630 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1631 (flag, _CONFIG_FILE))
1632
Ryan Cui9b651632011-05-11 11:38:58 -07001633 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001634 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001635 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001636 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1637 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001638 if enabled:
1639 enable_flags.append(flag)
1640 else:
1641 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001642
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001643 # See if this hook has custom options.
1644 if enabled:
1645 try:
1646 options = config.get(SECTION_OPTIONS, flag)
1647 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001648 hooks[flag].__name__ = flag
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001649 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1650 pass
1651
1652 enabled_hooks = set(hooks[x] for x in enable_flags)
1653 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001654 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001655
1656
Jon Salz3ee59de2012-08-18 13:54:22 +08001657def _get_project_hook_scripts(config):
1658 """Returns a list of project-specific hook scripts.
1659
1660 Args:
1661 config: A ConfigParser for the project's config file.
1662 """
1663 SECTION = 'Hook Scripts'
1664 if not config.has_section(SECTION):
1665 return []
1666
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001667 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001668
1669
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001670def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001671 """Returns a list of hooks that need to be run for a project.
1672
1673 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001674
1675 Args:
1676 project: A string, name of the project.
1677 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001678 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001679 config = ConfigParser.RawConfigParser()
1680 try:
1681 config.read(_CONFIG_FILE)
1682 except ConfigParser.Error:
1683 # Just use an empty config file
1684 config = ConfigParser.RawConfigParser()
1685
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001686 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001687 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001688 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001689 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001690
Mike Frysinger3554bc92015-03-11 04:59:21 -04001691 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001692 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1693
1694 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1695 # override, keep the override only. Note that the override may end up being
1696 # a functools.partial, in which case we need to extract the .func to compare
1697 # it to the common hooks.
1698 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1699 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1700
1701 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001702
1703 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001704 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1705 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001706
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001707 for name, script in _get_project_hook_scripts(config):
1708 func = functools.partial(_run_project_hook_script, script)
1709 func.__name__ = name
1710 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001711
Ryan Cui9b651632011-05-11 11:38:58 -07001712 return hooks
1713
1714
Alex Deymo643ac4c2015-09-03 10:40:50 -07001715def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001716 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001717 """For each project run its project specific hook from the hooks dictionary.
1718
1719 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001720 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001721 proj_dir: If non-None, this is the directory the project is in. If None,
1722 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001723 commit_list: A list of commits to run hooks against. If None or empty list
1724 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001725 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001726
1727 Returns:
1728 Boolean value of whether any errors were ecountered while running the hooks.
1729 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001730 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001731 proj_dirs = _run_command(
1732 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001733 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001734 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001735 print('Please specify a valid project.', file=sys.stderr)
1736 return True
1737 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001738 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001739 file=sys.stderr)
1740 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1741 return True
1742 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001743
Ryan Cuiec4d6332011-05-02 14:15:25 -07001744 pwd = os.getcwd()
1745 # hooks assume they are run from the root of the project
1746 os.chdir(proj_dir)
1747
Alex Deymo643ac4c2015-09-03 10:40:50 -07001748 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1749 '--symbolic-full-name', '@{u}']).strip()
1750 if not remote_branch:
1751 print('Your project %s doesn\'t track any remote repo.' % project_name,
1752 file=sys.stderr)
1753 remote = None
1754 else:
1755 remote, _branch = remote_branch.split('/', 1)
1756
1757 project = Project(name=project_name, dir=proj_dir, remote=remote)
1758
Doug Anderson14749562013-06-26 13:38:29 -07001759 if not commit_list:
1760 try:
1761 commit_list = _get_commits()
1762 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001763 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001764 os.chdir(pwd)
1765 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001766
Alex Deymo643ac4c2015-09-03 10:40:50 -07001767 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001768 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001769 commit_count = len(commit_list)
1770 for i, commit in enumerate(commit_list):
Ryan Cui1562fb82011-05-09 11:01:31 -07001771 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001772 for hook in hooks:
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001773 output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' %
1774 (i + 1, commit_count, commit, hook.__name__))
1775 print(output, end='\r')
1776 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001777 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001778 print(' ' * len(output), end='\r')
1779 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001780 if hook_error:
1781 error_list.append(hook_error)
1782 error_found = True
1783 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001784 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001785 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001786
Ryan Cuiec4d6332011-05-02 14:15:25 -07001787 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001788 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001789
Mike Frysingerae409522014-02-01 03:16:11 -05001790
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001791# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001792
Ryan Cui1562fb82011-05-09 11:01:31 -07001793
Mike Frysingerae409522014-02-01 03:16:11 -05001794def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001795 """Main function invoked directly by repo.
1796
1797 This function will exit directly upon error so that repo doesn't print some
1798 obscure error message.
1799
1800 Args:
1801 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001802 worktree_list: A list of directories. It should be the same length as
1803 project_list, so that each entry in project_list matches with a directory
1804 in worktree_list. If None, we will attempt to calculate the directories
1805 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001806 kwargs: Leave this here for forward-compatibility.
1807 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001808 found_error = False
David James2edd9002013-10-11 14:09:19 -07001809 if not worktree_list:
1810 worktree_list = [None] * len(project_list)
1811 for project, worktree in zip(project_list, worktree_list):
1812 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001813 found_error = True
1814
Mike Frysingerae409522014-02-01 03:16:11 -05001815 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001816 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001817 '- To disable some source style checks, and for other hints, see '
1818 '<checkout_dir>/src/repohooks/README\n'
1819 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001820 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001821 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001822
Ryan Cui1562fb82011-05-09 11:01:31 -07001823
Doug Anderson44a644f2011-11-02 10:37:37 -07001824def _identify_project(path):
1825 """Identify the repo project associated with the given path.
1826
1827 Returns:
1828 A string indicating what project is associated with the path passed in or
1829 a blank string upon failure.
1830 """
1831 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001832 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001833
1834
Mike Frysinger55f85b52014-12-18 14:45:21 -05001835def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001836 """Run hooks directly (outside of the context of repo).
1837
Doug Anderson44a644f2011-11-02 10:37:37 -07001838 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001839 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001840
1841 Returns:
1842 0 if no pre-upload failures, 1 if failures.
1843
1844 Raises:
1845 BadInvocation: On some types of invocation errors.
1846 """
Mike Frysinger66142932014-12-18 14:55:57 -05001847 parser = commandline.ArgumentParser(description=__doc__)
1848 parser.add_argument('--dir', default=None,
1849 help='The directory that the project lives in. If not '
1850 'specified, use the git project root based on the cwd.')
1851 parser.add_argument('--project', default=None,
1852 help='The project repo path; this can affect how the '
1853 'hooks get run, since some hooks are project-specific. '
1854 'For chromite this is chromiumos/chromite. If not '
1855 'specified, the repo tool will be used to figure this '
1856 'out based on the dir.')
1857 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08001858 help='Rerun hooks on old commits since some point '
1859 'in the past. The argument could be a date (should '
1860 'match git log\'s concept of a date, e.g. 2012-06-20), '
1861 'or a SHA1, or just a number of commits to check (from 1 '
1862 'to 99). This option is mutually exclusive with '
1863 '--pre-submit.')
Mike Frysinger66142932014-12-18 14:55:57 -05001864 parser.add_argument('--pre-submit', action="store_true",
1865 help='Run the check against the pending commit. '
1866 'This option should be used at the \'git commit\' '
1867 'phase as opposed to \'repo upload\'. This option '
1868 'is mutually exclusive with --rerun-since.')
1869 parser.add_argument('commits', nargs='*',
1870 help='Check specific commits')
1871 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001872
Doug Anderson14749562013-06-26 13:38:29 -07001873 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001874 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001875 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001876 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001877
Vadim Bendebury75447b92018-01-10 12:06:01 -08001878 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
1879 # This must be the number of commits to check. We don't expect the user
1880 # to want to check more than 99 commits.
1881 limit = '-n%s' % opts.rerun_since
1882 elif git.IsSHA1(opts.rerun_since, False):
1883 limit = '%s..' % opts.rerun_since
1884 else:
1885 # This better be a date.
1886 limit = '--since=%s' % opts.rerun_since
1887 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07001888 all_commits = _run_command(cmd).splitlines()
1889 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1890
1891 # Eliminate chrome-bot commits but keep ordering the same...
1892 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001893 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001894
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001895 if opts.pre_submit:
1896 raise BadInvocation('rerun-since and pre-submit can not be '
1897 'used together')
1898 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001899 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001900 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001901 ' '.join(opts.commits))
1902 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001903
1904 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1905 # project from CWD
1906 if opts.dir is None:
1907 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001908 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001909 if not git_dir:
1910 raise BadInvocation('The current directory is not part of a git project.')
1911 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1912 elif not os.path.isdir(opts.dir):
1913 raise BadInvocation('Invalid dir: %s' % opts.dir)
1914 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1915 raise BadInvocation('Not a git directory: %s' % opts.dir)
1916
1917 # Identify the project if it wasn't specified; this _requires_ the repo
1918 # tool to be installed and for the project to be part of a repo checkout.
1919 if not opts.project:
1920 opts.project = _identify_project(opts.dir)
1921 if not opts.project:
1922 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1923
Doug Anderson14749562013-06-26 13:38:29 -07001924 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001925 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001926 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001927 if found_error:
1928 return 1
1929 return 0
1930
1931
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001932if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001933 sys.exit(direct_main(sys.argv[1:]))