blob: 97d4e52bdf7f7780e0040254d9ea4fb14d9d9246 [file] [log] [blame]
Kuang-che Wu6e4beca2018-06-27 17:45:02 +08001# -*- coding: utf-8 -*-
Kuang-che Wu88875db2017-07-20 10:47:53 +08002# Copyright 2017 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5"""Bisect command line interface."""
6
7from __future__ import print_function
8import argparse
9import datetime
Kuang-che Wu8b654092018-11-09 17:56:25 +080010import json
Kuang-che Wu88875db2017-07-20 10:47:53 +080011import logging
12import os
13import re
Kuang-che Wu443633f2019-02-27 00:58:33 +080014import signal
Kuang-che Wu88875db2017-07-20 10:47:53 +080015import textwrap
16import time
17
18from bisect_kit import common
Kuang-che Wu385279d2017-09-27 14:48:28 +080019from bisect_kit import configure
Kuang-che Wu88875db2017-07-20 10:47:53 +080020from bisect_kit import core
Kuang-che Wue121fae2018-11-09 16:18:39 +080021from bisect_kit import errors
Kuang-che Wu88875db2017-07-20 10:47:53 +080022from bisect_kit import strategy
23from bisect_kit import util
24
25logger = logging.getLogger(__name__)
26
Kuang-che Wu88875db2017-07-20 10:47:53 +080027DEFAULT_SESSION_NAME = 'default'
28DEFAULT_CONFIDENCE = 0.999
29
Kuang-che Wu0476d1f2019-03-04 19:27:01 +080030# Exit code of bisect eval script. These values are chosen compatible with 'git
31# bisect'.
32EXIT_CODE_OLD = 0
33EXIT_CODE_NEW = 1
34EXIT_CODE_SKIP = 125
35EXIT_CODE_FATAL = 128
36
Kuang-che Wu88875db2017-07-20 10:47:53 +080037
38class ArgTypeError(argparse.ArgumentTypeError):
39 """An error for argument validation failure.
40
41 This not only tells users the argument is wrong but also gives correct
42 example. The main purpose of this error is for argtype_multiplexer, which
43 cascades examples from multiple ArgTypeError.
44 """
45
46 def __init__(self, msg, example):
47 self.msg = msg
48 if isinstance(example, list):
49 self.example = example
50 else:
51 self.example = [example]
52 full_msg = '%s (example value: %s)' % (self.msg, ', '.join(self.example))
53 super(ArgTypeError, self).__init__(full_msg)
54
55
56def argtype_notempty(s):
57 """Validates argument is not an empty string.
58
59 Args:
60 s: string to validate.
61
62 Raises:
63 ArgTypeError if argument is empty string.
64 """
65 if not s:
66 msg = 'should not be empty'
67 raise ArgTypeError(msg, 'foo')
68 return s
69
70
71def argtype_int(s):
72 """Validate argument is a number.
73
74 Args:
75 s: string to validate.
76
77 Raises:
78 ArgTypeError if argument is not a number.
79 """
80 try:
81 return str(int(s))
82 except ValueError:
83 raise ArgTypeError('should be a number', '123')
84
85
Kuang-che Wu603cdad2019-01-18 21:32:55 +080086def argtype_re(pattern, example):
87 r"""Validate argument matches `pattern`.
88
89 Args:
90 pattern: regex pattern
91 example: example string which matches `pattern`
92
93 Returns:
94 A new argtype function which matches regex `pattern`
95 """
96 assert re.match(pattern, example)
97
98 def validate(s):
99 if re.match(pattern, s):
100 return s
101 if re.escape(pattern) == pattern:
102 raise ArgTypeError('should be "%s"' % pattern, pattern)
103 raise ArgTypeError('should match "%s"' % pattern,
104 '"%s" like %s' % (pattern, example))
105
106 return validate
107
108
Kuang-che Wu88875db2017-07-20 10:47:53 +0800109def argtype_multiplexer(*args):
110 r"""argtype multiplexer
111
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800112 This function takes a list of argtypes and creates a new function matching
113 them. Moreover, it gives error message with examples.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800114
Kuang-che Wubaaa4532018-08-15 17:08:10 +0800115 Examples:
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800116 >>> argtype = argtype_multiplexer(argtype_int,
117 argtype_re(r'^r\d+$', 'r123'))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800118 >>> argtype('123')
119 123
120 >>> argtype('r456')
121 r456
122 >>> argtype('hello')
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800123 ArgTypeError: Invalid argument (example value: 123, "r\d+$" like r123)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800124
125 Args:
126 *args: list of argtypes or regex pattern.
127
128 Returns:
129 A new argtype function which matches *args.
130 """
131
132 def validate(s):
133 examples = []
134 for t in args:
Kuang-che Wu88875db2017-07-20 10:47:53 +0800135 try:
136 return t(s)
137 except ArgTypeError as e:
138 examples += e.example
139
140 msg = 'Invalid argument'
141 raise ArgTypeError(msg, examples)
142
143 return validate
144
145
146def argtype_multiplier(argtype):
147 """A new argtype that supports multiplier suffix of the given argtype.
148
Kuang-che Wubaaa4532018-08-15 17:08:10 +0800149 Examples:
Kuang-che Wu88875db2017-07-20 10:47:53 +0800150 Supports the given argtype accepting "foo" as argument, this function
151 generates a new argtype function which accepts argument like "foo*3".
152
153 Returns:
154 A new argtype function which returns (arg, times) where arg is accepted
155 by input `argtype` and times is repeating count. Note that if multiplier is
156 omitted, "times" is 1.
157 """
158
159 def helper(s):
160 m = re.match(r'^(.+)\*(\d+)$', s)
161 try:
162 if m:
163 return argtype(m.group(1)), int(m.group(2))
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800164 return argtype(s), 1
Kuang-che Wu88875db2017-07-20 10:47:53 +0800165 except ArgTypeError as e:
166 # It should be okay to gives multiplier example only for the first one
167 # because it is just "example", no need to enumerate all possibilities.
168 raise ArgTypeError(e.msg, e.example + [e.example[0] + '*3'])
169
170 return helper
171
172
173def argtype_dir_path(s):
174 """Validate argument is an existing directory.
175
176 Args:
177 s: string to validate.
178
179 Raises:
180 ArgTypeError if the path is not a directory.
181 """
182 if not os.path.exists(s):
183 raise ArgTypeError('should be an existing directory', '/path/to/somewhere')
184 if not os.path.isdir(s):
185 raise ArgTypeError('should be a directory', '/path/to/somewhere')
186
187 # Normalize, trim trailing path separators.
188 if len(s) > 1 and s[-1] == os.path.sep:
189 s = s[:-1]
190 return s
191
192
193def _collect_bisect_result_values(values, line):
194 """Collect bisect result values from output line.
195
196 Args:
197 values: Collected values are appending to this list.
198 line: One line of output string.
199 """
200 m = re.match(r'^BISECT_RESULT_VALUES=(.+)', line)
201 if m:
202 try:
203 values.extend(map(float, m.group(1).split()))
204 except ValueError:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800205 raise errors.InternalError(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800206 'BISECT_RESULT_VALUES should be list of floats: %r' % m.group(1))
207
208
Kuang-che Wu88518882017-09-22 16:57:25 +0800209def check_executable(program):
210 """Checks whether a program is executable.
211
212 Args:
213 program: program path in question
214
215 Returns:
216 string as error message if `program` is not executable, or None otherwise.
217 It will return None if unable to determine as well.
218 """
219 returncode = util.call('which', program)
220 if returncode == 127: # No 'which' on this platform, skip the check.
221 return None
222 if returncode == 0: # is executable
223 return None
224
225 hint = ''
226 if not os.path.exists(program):
227 hint = 'Not in PATH?'
228 elif not os.path.isfile(program):
229 hint = 'Not a file'
230 elif not os.access(program, os.X_OK):
231 hint = 'Forgot to chmod +x?'
232 elif '/' not in program:
233 hint = 'Forgot to prepend "./" ?'
234 return '%r is not executable. %s' % (program, hint)
235
236
Kuang-che Wu443633f2019-02-27 00:58:33 +0800237def format_returncode(returncode):
238 if returncode < 0:
239 signum = -returncode
240 signame = 'Unknown'
241 for k, v in vars(signal).items():
242 if k.startswith('SIG') and '_' not in k and v == signum:
243 signame = k
244 return 'terminated by signal %d (%s)' % (signum, signame)
245
246 return 'exited with code %d' % returncode
247
248
Kuang-che Wu88875db2017-07-20 10:47:53 +0800249def do_evaluate(evaluate_cmd, domain, rev):
250 """Invokes evaluator command.
251
252 The `evaluate_cmd` can get the target revision from the environment variable
253 named 'BISECT_REV'.
254
255 The result is determined according to the exit code of evaluator:
256 0: 'old'
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800257 1..124, 126, 127: 'new'
Kuang-che Wu88875db2017-07-20 10:47:53 +0800258 125: 'skip'
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800259 128..255: fatal error
Kuang-che Wu88875db2017-07-20 10:47:53 +0800260 terminated by signal: fatal error
261
262 p.s. the definition of result is compatible with git-bisect(1).
263
264 It also extracts additional values from evaluate_cmd's stdout lines which
265 match the following format:
266 BISECT_RESULT_VALUES=<float>[, <float>]*
267
268 Args:
269 evaluate_cmd: evaluator command.
270 domain: a bisect_kit.core.Domain instance.
271 rev: version to evaluate.
272
273 Returns:
274 (result, values):
275 result is one of 'old', 'new', 'skip'.
276 values are additional collected values, like performance score.
277
278 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800279 errors.ExecutionFatalError if evaluator returned fatal error code.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800280 """
281 env = os.environ.copy()
282 env['BISECT_REV'] = rev
283 domain.setenv(env, rev)
284
285 values = []
286 p = util.Popen(
287 evaluate_cmd,
288 env=env,
289 stdout_callback=lambda line: _collect_bisect_result_values(values, line))
290 returncode = p.wait()
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800291 if returncode < 0 or returncode >= 128:
Kuang-che Wu443633f2019-02-27 00:58:33 +0800292 raise errors.ExecutionFatalError(
293 'eval failed: %s' % format_returncode(returncode))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800294
295 if returncode == 0:
296 return 'old', values
297 if returncode == 125:
298 return 'skip', values
299 return 'new', values
300
301
302def do_switch(switch_cmd, domain, rev):
303 """Invokes switcher command.
304
305 The `switch_cmd` can get the target revision from the environment variable
306 named 'BISECT_REV'.
307
308 The result is determined according to the exit code of switcher:
309 0: switch succeeded
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800310 1..127: 'skip'
311 128..255: fatal error
Kuang-che Wu88875db2017-07-20 10:47:53 +0800312 terminated by signal: fatal error
313
314 In other words, any non-fatal errors are considered as 'skip'.
315
316 Args:
317 switch_cmd: switcher command.
318 domain: a bisect_kit.core.Domain instance.
319 rev: version to switch.
320
321 Returns:
322 None if switch successfully, 'skip' otherwise.
323
324 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800325 errors.ExecutionFatalError if switcher returned fatal error code.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800326 """
327 env = os.environ.copy()
328 env['BISECT_REV'] = rev
329 domain.setenv(env, rev)
330
331 returncode = util.call(*switch_cmd, env=env)
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800332 if returncode < 0 or returncode >= 128:
Kuang-che Wu443633f2019-02-27 00:58:33 +0800333 raise errors.ExecutionFatalError(
334 'switch failed: %s' % format_returncode(returncode))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800335
336 if returncode != 0:
337 return 'skip'
338 return None
339
340
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800341class BisectorCommandLine(object):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800342 """Bisector command line interface.
343
344 The typical usage pattern:
345
346 if __name__ == '__main__':
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800347 BisectorCommandLine(CustomDomain).main()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800348
349 where CustomDomain is a derived class of core.BisectDomain. See
Kuang-che Wu02170592018-07-09 21:42:44 +0800350 bisect_list.py as example.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800351
352 If you need to control the bisector using python code, the easier way is
353 passing command line arguments to main() function. For example,
354 bisector = Bisector(CustomDomain)
355 bisector.main('init', '--old', '123', '--new', '456')
356 bisector.main('config', 'switch', 'true')
357 bisector.main('config', 'eval', 'true')
358 bisector.main('run')
359 """
360
361 def __init__(self, domain_cls):
362 self.domain_cls = domain_cls
363 self.domain = None
364 self.states = None
365 self.strategy = None
366
367 @property
368 def config(self):
369 return self.states.config
370
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800371 def _format_status(self, status):
372 if status in ('old', 'new'):
Kuang-che Wub6756d42019-01-25 12:19:55 +0800373 return '%s behavior' % status
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800374 return status
375
Kuang-che Wu8b654092018-11-09 17:56:25 +0800376 def _add_sample(self, rev, status, **kwargs):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800377 idx = self.states.rev2idx(rev)
Kuang-che Wu8b654092018-11-09 17:56:25 +0800378 self.states.add_sample(idx, status, **kwargs)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800379 self.strategy.update(idx, status)
380
381 def cmd_reset(self, _opts):
382 """Resets bisect session and clean up saved result."""
383 self.states.reset()
384
385 def cmd_init(self, opts):
386 """Initializes bisect session.
387
388 See init command's help message for more detail.
389 """
390 config, revlist = self.domain_cls.init(opts)
Kuang-che Wu42551dd2018-01-16 17:27:20 +0800391 logger.info('found %d revs to bisect', len(revlist))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800392 logger.debug('revlist %r', revlist)
393 if 'new' not in config:
394 config['new'] = opts.new
395 if 'old' not in config:
396 config['old'] = opts.old
397 assert len(revlist) >= 2
398 assert config['new'] in revlist
399 assert config['old'] in revlist
400 old_idx = revlist.index(config['old'])
401 new_idx = revlist.index(config['new'])
402 assert old_idx < new_idx
403
404 config.update(confidence=opts.confidence, noisy=opts.noisy)
405
406 self.states.init(config, revlist)
407 self.states.save()
408
409 def _switch_and_eval(self, rev, prev_rev=None):
410 """Switches and evaluates given version.
411
412 If current version equals to target, switch step will be skip.
413
414 Args:
415 rev: Target version.
416 prev_rev: Previous version.
417
418 Returns:
419 (step, status, values):
420 step: Last step executed ('switch' or 'eval').
421 status: Execution result ('old', 'new', or 'skip').
422 values: Collected values from eval step. None if last step is 'switch'.
423 """
Kuang-che Wu88875db2017-07-20 10:47:53 +0800424 if prev_rev != rev:
425 logger.debug('switch to rev=%s', rev)
426 t0 = time.time()
427 status = do_switch(self.config['switch'], self.domain, rev)
428 t1 = time.time()
429 if status == 'skip':
430 logger.debug('switch failed => skip')
431 return 'switch', status, None
432 self.states.data['stats']['switch_count'] += 1
433 self.states.data['stats']['switch_time'] += t1 - t0
434
435 logger.debug('eval rev=%s', rev)
436 t0 = time.time()
437 status, values = do_evaluate(self.config['eval'], self.domain, rev)
438 t1 = time.time()
439 if status == 'skip':
440 return 'eval', status, values
441 self.states.data['stats']['eval_count'] += 1
442 self.states.data['stats']['eval_time'] += t1 - t0
443
444 return 'eval', status, values
445
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800446 def _next_idx_iter(self, opts, force):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800447 if opts.revs:
448 for rev in opts.revs:
449 idx = self.states.rev2idx(rev)
450 logger.info('try idx=%d rev=%s (command line specified)', idx, rev)
451 yield idx, rev
452 if opts.once:
453 break
454 else:
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800455 while force or not self.strategy.is_done():
Kuang-che Wu88875db2017-07-20 10:47:53 +0800456 idx = self.strategy.next_idx()
457 rev = self.states.idx2rev(idx)
458 logger.info('try idx=%d rev=%s', idx, rev)
459 yield idx, rev
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800460 force = False
Kuang-che Wu88875db2017-07-20 10:47:53 +0800461 if opts.once:
462 break
463
464 def cmd_run(self, opts):
465 """Performs bisection.
466
467 See run command's help message for more detail.
468
469 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800470 errors.VerificationFailed: The bisection range is verified false. We
Kuang-che Wu88875db2017-07-20 10:47:53 +0800471 expect 'old' at the first rev and 'new' at last rev.
Kuang-che Wue121fae2018-11-09 16:18:39 +0800472 errors.UnableToProceed: Too many errors to narrow down further the
473 bisection range.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800474 """
Kuang-che Wu8b654092018-11-09 17:56:25 +0800475 # Set dummy values in case exception raised before loop.
476 idx, rev = -1, None
477 try:
478 assert self.config.get('switch')
479 assert self.config.get('eval')
480 self.strategy.rebuild()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800481
Kuang-che Wu8b654092018-11-09 17:56:25 +0800482 prev_rev = None
483 force = opts.force
484 for idx, rev in self._next_idx_iter(opts, force):
485 if not force:
486 # Bail out if bisection range is unlikely true in order to prevent
487 # wasting time. This is necessary because some configurations (say,
488 # confidence) may be changed before cmd_run() and thus the bisection
489 # range becomes not acceptable.
490 self.strategy.check_verification_range()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800491
Kuang-che Wu8b654092018-11-09 17:56:25 +0800492 step, status, values = self._switch_and_eval(rev, prev_rev=prev_rev)
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800493 logger.info('rev=%s status => %s', rev, self._format_status(status))
Kuang-che Wu8b654092018-11-09 17:56:25 +0800494 force = False
495
Kuang-che Wu978b65a2019-03-12 09:50:40 +0800496 self.states.add_sample(idx, status, values=values)
Kuang-che Wu8b654092018-11-09 17:56:25 +0800497 self.states.save()
498
499 # Bail out if bisection range is unlikely true.
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800500 self.strategy.check_verification_range()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800501
Kuang-che Wu978b65a2019-03-12 09:50:40 +0800502 self.strategy.update(idx, status)
Kuang-che Wu8b654092018-11-09 17:56:25 +0800503 self.strategy.show_summary()
504
505 if step == 'switch' and status == 'skip':
506 # Previous switch failed and thus the current version is unknown. Set
507 # it None, so next switch operation won't be bypassed (due to
508 # optimization).
509 prev_rev = None
510 else:
511 prev_rev = rev
512
513 logger.info('done')
514 old_idx, new_idx = self.strategy.get_range()
515 self.states.add_history('done')
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800516 self.states.save()
Kuang-che Wu8b654092018-11-09 17:56:25 +0800517 except Exception as e:
518 exception_name = e.__class__.__name__
519 self.states.add_history(
520 'failed', text='%s: %s' % (exception_name, e), index=idx, rev=rev)
521 self.states.save()
522 raise
523 finally:
Kuang-che Wu978b65a2019-03-12 09:50:40 +0800524 if rev and sum(self.strategy.prob) > 0:
Kuang-che Wu8b654092018-11-09 17:56:25 +0800525 # progress so far
526 old_idx, new_idx = self.strategy.get_range()
527 self.states.add_history(
528 'range',
529 old=self.states.idx2rev(old_idx),
530 new=self.states.idx2rev(new_idx))
531 self.states.save()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800532
533 def cmd_view(self, opts):
Kuang-che Wue80bb872018-11-15 19:45:25 +0800534 """Shows remaining candidates."""
Kuang-che Wu15874b62019-01-11 21:10:27 +0800535 try:
536 self.strategy.rebuild()
537 # Rebuild twice in order to re-estimate noise.
538 self.strategy.rebuild()
539 except errors.VerificationFailed:
540 # Do nothing, go ahead to show existing information anyway.
541 pass
Kuang-che Wue80bb872018-11-15 19:45:25 +0800542
543 old_idx, new_idx = self.strategy.get_range()
544 old, new = map(self.states.idx2rev, [old_idx, new_idx])
545 highlight_old_idx, highlight_new_idx = self.strategy.get_range(
546 self.strategy.confidence / 10.0)
547 summary = {
548 'rev_info': [vars(info).copy() for info in self.states.rev_info],
549 'current_range': (old, new),
550 'highlight_range':
551 map(self.states.idx2rev, [highlight_old_idx, highlight_new_idx]),
552 'prob':
553 self.strategy.prob,
554 'remaining_steps':
555 self.strategy.remaining_steps(),
556 }
557
558 if opts.verbose or opts.json:
559 interesting_indexes = set(range(len(summary['rev_info'])))
560 else:
561 interesting_indexes = set([old_idx, new_idx])
Kuang-che Wu15874b62019-01-11 21:10:27 +0800562 if self.strategy.prob:
563 for i, p in enumerate(self.strategy.prob):
564 if p > 0.05:
565 interesting_indexes.add(i)
Kuang-che Wue80bb872018-11-15 19:45:25 +0800566
567 self.domain.fill_candidate_summary(summary, interesting_indexes)
568
569 if opts.json:
570 print(json.dumps(summary, indent=2, sort_keys=True))
571 else:
572 self.show_summary(summary, interesting_indexes, verbose=opts.verbose)
573
574 def show_summary(self, summary, interesting_indexes, verbose=False):
575 old, new = summary['current_range']
576 old_idx, new_idx = map(self.states.data['revlist'].index, [old, new])
577
Kuang-che Wuaccf9202019-01-04 15:40:42 +0800578 for link in summary.get('links', []):
579 print('%s: %s' % (link['name'], link['url']))
580 if 'note' in link:
581 print(link['note'])
Kuang-che Wue80bb872018-11-15 19:45:25 +0800582
583 print('Range: (%s, %s], %s revs left' % (old, new, (new_idx - old_idx)))
Kuang-che Wua8c987f2019-01-18 14:26:43 +0800584 if summary.get('remaining_steps'):
Kuang-che Wue80bb872018-11-15 19:45:25 +0800585 print('(roughly %d steps)' % summary['remaining_steps'])
586
587 for i, rev_info in enumerate(summary['rev_info']):
588 if (not verbose and not old_idx <= i <= new_idx and
589 not rev_info['result_counter']):
590 continue
591
592 detail = []
Kuang-che Wu05e416e2019-02-21 12:33:52 +0800593 if self.strategy.is_noisy() and summary['prob']:
Kuang-che Wua8c987f2019-01-18 14:26:43 +0800594 detail.append('%.4f%%' % (summary['prob'][i] * 100))
Kuang-che Wue80bb872018-11-15 19:45:25 +0800595 if rev_info['result_counter']:
596 detail.append(str(rev_info['result_counter']))
597 values = sorted(rev_info['values'])
598 if len(values) == 1:
599 detail.append('%.3f' % values[0])
600 elif len(values) > 1:
601 detail.append('n=%d,avg=%.3f,median=%.3f,min=%.3f,max=%.3f' %
602 (len(values), sum(values) / len(values),
603 values[len(values) // 2], values[0], values[-1]))
604
605 print('[%d] %s\t%s' % (i, rev_info['rev'], ' '.join(detail)))
606 if i in interesting_indexes:
607 if 'comment' in rev_info:
608 print('\t%s' % rev_info['comment'])
609 for action in rev_info.get('actions', []):
610 if 'text' in action:
611 print('\t%s' % action['text'])
612 if 'link' in action:
613 print('\t%s' % action['link'])
Kuang-che Wu88875db2017-07-20 10:47:53 +0800614
615 def current_status(self, session=None, session_base=None):
616 """Gets current bisect status.
617
618 Returns:
619 A dict describing current status. It contains following items:
620 inited: True iff the session file is initialized (init command has been
621 invoked). If not, below items are omitted.
622 old: Start of current estimated range.
623 new: End of current estimated range.
Kuang-che Wu8b654092018-11-09 17:56:25 +0800624 verified: The bisect range is already verified.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800625 estimated_noise: New estimated noise.
626 done: True if bisection is done, otherwise False.
627 """
628 self._create_states(session=session, session_base=session_base)
629 if self.states.load():
630 self.strategy = strategy.NoisyBinarySearch(
631 self.states.rev_info,
632 self.states.rev2idx(self.config['old']),
633 self.states.rev2idx(self.config['new']),
634 confidence=self.config['confidence'],
635 observation=self.config['noisy'])
Kuang-che Wu15874b62019-01-11 21:10:27 +0800636 try:
637 self.strategy.rebuild()
638 except errors.VerificationFailed:
639 # Do nothing, go ahead to show existing information anyway.
640 pass
Kuang-che Wu88875db2017-07-20 10:47:53 +0800641 left, right = self.strategy.get_range()
642 estimated_noise = self.strategy.get_noise_observation()
643
644 result = dict(
645 inited=True,
646 old=self.states.idx2rev(left),
647 new=self.states.idx2rev(right),
Kuang-che Wu8b654092018-11-09 17:56:25 +0800648 verified=self.strategy.is_range_verified(),
Kuang-che Wudd7f6f02018-06-28 18:19:30 +0800649 estimated_noise=estimated_noise,
Kuang-che Wu88875db2017-07-20 10:47:53 +0800650 done=self.strategy.is_done())
651 else:
652 result = dict(inited=False)
653 return result
654
Kuang-che Wu8b654092018-11-09 17:56:25 +0800655 def cmd_log(self, opts):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800656 """Prints what has been done so far."""
Kuang-che Wu8b654092018-11-09 17:56:25 +0800657 history = []
Kuang-che Wu88875db2017-07-20 10:47:53 +0800658 for entry in self.states.data['history']:
Kuang-che Wu8b654092018-11-09 17:56:25 +0800659 if opts.before and entry['timestamp'] >= opts.before:
660 continue
661 if opts.after and entry['timestamp'] <= opts.after:
662 continue
663 history.append(entry)
664
665 if opts.json:
666 print(json.dumps(history, indent=2))
667 return
668
669 for entry in history:
670 entry_time = datetime.datetime.fromtimestamp(int(entry['timestamp']))
671 if entry.get('event', 'sample') == 'sample':
672 print('{datetime} {rev} {status} {values} {comment}'.format(
673 datetime=entry_time,
674 rev=entry['rev'],
675 status=entry['status'] + ('*%d' % entry['times']
676 if entry.get('times', 1) > 1 else ''),
677 values=entry.get('values', ''),
678 comment=entry.get('comment', '')))
679 else:
680 print('%s %r' % (entry_time, entry))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800681
682 def cmd_next(self, _opts):
683 """Prints next suggested rev to bisect."""
684 self.strategy.rebuild()
685 if self.strategy.is_done():
686 print('done')
687 return
688
689 idx = self.strategy.next_idx()
690 rev = self.states.idx2rev(idx)
691 print(rev)
692
693 def cmd_switch(self, opts):
694 """Switches to given rev without eval."""
695 assert self.config.get('switch')
696
697 self.strategy.rebuild()
698
699 if opts.rev == 'next':
700 idx = self.strategy.next_idx()
701 rev = self.states.idx2rev(idx)
702 else:
Kuang-che Wu752228c2018-09-05 13:54:22 +0800703 rev = self.domain_cls.intra_revtype(opts.rev)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800704 assert rev
705
706 logger.info('switch to %s', rev)
707 status = do_switch(self.config['switch'], self.domain, rev)
708 if status:
709 print('switch failed')
710
711 def _add_revs_status_helper(self, revs, status):
712 self.strategy.rebuild()
713 for rev, times in revs:
Kuang-che Wu8b654092018-11-09 17:56:25 +0800714 self._add_sample(rev, status, times=times, comment='manual')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800715 self.states.save()
716
717 def cmd_new(self, opts):
718 """Tells bisect engine the said revs have "new" behavior."""
719 logger.info('set [%s] as new', opts.revs)
720 self._add_revs_status_helper(opts.revs, 'new')
721
722 def cmd_old(self, opts):
723 """Tells bisect engine the said revs have "old" behavior."""
724 logger.info('set [%s] as old', opts.revs)
725 self._add_revs_status_helper(opts.revs, 'old')
726
727 def cmd_skip(self, opts):
728 """Tells bisect engine the said revs have "skip" behavior."""
729 logger.info('set [%s] as skip', opts.revs)
730 self._add_revs_status_helper(opts.revs, 'skip')
731
732 def _create_states(self, session=None, session_base=None):
733 if not session:
734 session = DEFAULT_SESSION_NAME
735 if not session_base:
Kuang-che Wu41e8b592018-09-25 17:01:30 +0800736 session_base = configure.get('SESSION_BASE', common.DEFAULT_SESSION_BASE)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800737
738 session_file = os.path.join(session_base, session, self.domain_cls.__name__)
739
740 if self.states:
741 assert self.states.session_file == session_file
742 else:
Kuang-che Wuc5781932018-10-05 00:30:19 +0800743 self.states = core.BisectStates(session_file)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800744
745 def cmd_config(self, opts):
746 """Configures additional setting.
747
748 See config command's help message for more detail.
749 """
750 self.states.load()
751 self.domain = self.domain_cls(self.states.config)
752 if not opts.value:
753 print(self.states.config[opts.key])
754 return
755
756 if opts.key in ['switch', 'eval']:
Kuang-che Wu88518882017-09-22 16:57:25 +0800757 result = check_executable(opts.value[0])
758 if result:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800759 raise errors.ArgumentError('%s command' % opts.key, result)
Kuang-che Wu88518882017-09-22 16:57:25 +0800760
Kuang-che Wu88875db2017-07-20 10:47:53 +0800761 self.states.config[opts.key] = opts.value
762
763 elif opts.key == 'confidence':
764 if len(opts.value) != 1:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800765 raise errors.ArgumentError(
766 'confidence value',
767 'expected 1 value, %d values given' % len(opts.value))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800768 try:
769 self.states.config[opts.key] = float(opts.value[0])
770 except ValueError:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800771 raise errors.ArgumentError('confidence value',
772 'invalid float value: %r' % opts.value[0])
Kuang-che Wu88875db2017-07-20 10:47:53 +0800773
774 elif opts.key == 'noisy':
775 if len(opts.value) != 1:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800776 raise errors.ArgumentError(
777 'noisy value',
778 'expected 1 value, %d values given' % len(opts.value))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800779 self.states.config[opts.key] = opts.value[0]
780
781 else:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800782 # unreachable
783 assert 0
Kuang-che Wu88875db2017-07-20 10:47:53 +0800784
785 self.states.save()
786
787 def create_argument_parser(self, prog):
Kuang-che Wub2376262017-11-20 18:05:24 +0800788 if self.domain_cls.help:
789 description = self.domain_cls.help
790 else:
791 description = 'Bisector for %s' % self.domain_cls.__name__
792 description += textwrap.dedent('''
793 When running switcher and evaluator, it will set BISECT_REV environment
794 variable, indicates current rev to switch/evaluate.
795 ''')
796
Kuang-che Wu88875db2017-07-20 10:47:53 +0800797 parser = argparse.ArgumentParser(
798 prog=prog,
799 formatter_class=argparse.RawDescriptionHelpFormatter,
Kuang-che Wub2376262017-11-20 18:05:24 +0800800 description=description)
Kuang-che Wu385279d2017-09-27 14:48:28 +0800801 common.add_common_arguments(parser)
802 parser.add_argument(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800803 '--session_base',
Kuang-che Wu41e8b592018-09-25 17:01:30 +0800804 default=configure.get('SESSION_BASE', common.DEFAULT_SESSION_BASE),
Kuang-che Wu88875db2017-07-20 10:47:53 +0800805 help='Directory to store sessions (default: %(default)r)')
806 parser.add_argument(
807 '--session',
808 default=DEFAULT_SESSION_NAME,
809 help='Session name (default: %(default)r)')
810 subparsers = parser.add_subparsers(
811 dest='command', title='commands', metavar='<command>')
812
813 parser_reset = subparsers.add_parser(
814 'reset', help='Reset bisect session and clean up saved result')
815 parser_reset.set_defaults(func=self.cmd_reset)
816
817 parser_init = subparsers.add_parser(
818 'init',
819 help='Initializes bisect session',
820 formatter_class=argparse.RawDescriptionHelpFormatter,
821 description=textwrap.dedent('''
822 Besides arguments for 'init' command, you also need to set 'switch'
823 and 'eval' command line via 'config' command.
824 $ bisector config switch <switch command and arguments>
825 $ bisector config eval <eval command and arguments>
826
827 The value of --noisy and --confidence could be changed by 'config'
828 command after 'init' as well.
829 '''))
830 parser_init.add_argument(
831 '--old',
832 required=True,
833 type=self.domain_cls.revtype,
834 help='Start of bisect range, which has old behavior')
835 parser_init.add_argument(
836 '--new',
837 required=True,
838 type=self.domain_cls.revtype,
839 help='End of bisect range, which has new behavior')
840 parser_init.add_argument(
841 '--noisy',
842 help='Enable noisy binary search and specify prior result. '
843 'For example, "old=1/10,new=2/3" means old fail rate is 1/10 '
844 'and new fail rate increased to 2/3. '
845 'Skip if not flaky, say, "new=2/3" means old is always good.')
846 parser_init.add_argument(
847 '--confidence',
848 type=float,
849 default=DEFAULT_CONFIDENCE,
850 help='Confidence level (default: %(default)r)')
851 parser_init.set_defaults(func=self.cmd_init)
852 self.domain_cls.add_init_arguments(parser_init)
853
854 parser_config = subparsers.add_parser(
855 'config', help='Configures additional setting')
856 parser_config.add_argument(
857 'key',
858 choices=['switch', 'eval', 'confidence', 'noisy'],
859 metavar='key',
860 help='What config to change. choices=[%(choices)s]')
861 parser_config.add_argument(
862 'value', nargs=argparse.REMAINDER, help='New value')
863 parser_config.set_defaults(func=self.cmd_config)
864
865 parser_run = subparsers.add_parser(
866 'run',
867 help='Performs bisection',
868 formatter_class=argparse.RawDescriptionHelpFormatter,
869 description=textwrap.dedent('''
870 This command does switch and eval to determine candidates having old or
871 new behavior.
872
873 By default, it attempts to try versions in binary search manner until
874 found the first version having new behavior.
875
876 If version numbers are specified on command line, it just tries those
877 versions and record the result.
878
879 Example:
880 Bisect automatically.
881 $ %(prog)s
882
883 Switch and run version "2.13" and "2.14" and then stop.
884 $ %(prog)s 2.13 2.14
885 '''))
886 parser_run.add_argument(
887 '-1', '--once', action='store_true', help='Only run one step')
888 parser_run.add_argument(
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800889 '--force',
890 action='store_true',
891 help="Run at least once even it's already done")
892 parser_run.add_argument(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800893 'revs',
894 nargs='*',
Kuang-che Wu752228c2018-09-05 13:54:22 +0800895 type=self.domain_cls.intra_revtype,
Kuang-che Wu88875db2017-07-20 10:47:53 +0800896 help='revs to switch+eval; '
897 'default is calculating automatically and run until done')
898 parser_run.set_defaults(func=self.cmd_run)
899
900 parser_switch = subparsers.add_parser(
901 'switch', help='Switch to given rev without eval')
902 parser_switch.add_argument(
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800903 'rev',
904 type=argtype_multiplexer(self.domain_cls.intra_revtype,
905 argtype_re('next', 'next')))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800906 parser_switch.set_defaults(func=self.cmd_switch)
907
908 parser_old = subparsers.add_parser(
909 'old', help='Tells bisect engine the said revs have "old" behavior')
910 parser_old.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800911 'revs',
912 nargs='+',
913 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800914 parser_old.set_defaults(func=self.cmd_old)
915
916 parser_new = subparsers.add_parser(
917 'new', help='Tells bisect engine the said revs have "new" behavior')
918 parser_new.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800919 'revs',
920 nargs='+',
921 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800922 parser_new.set_defaults(func=self.cmd_new)
923
924 parser_skip = subparsers.add_parser(
925 'skip', help='Tells bisect engine the said revs have "skip" behavior')
926 parser_skip.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800927 'revs',
928 nargs='+',
929 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800930 parser_skip.set_defaults(func=self.cmd_skip)
931
932 parser_view = subparsers.add_parser(
933 'view', help='Shows current progress and candidates')
Kuang-che Wue80bb872018-11-15 19:45:25 +0800934 parser_view.add_argument('--verbose', '-v', action='store_true')
935 parser_view.add_argument('--json', action='store_true')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800936 parser_view.set_defaults(func=self.cmd_view)
937
938 parser_log = subparsers.add_parser(
939 'log', help='Prints what has been done so far')
Kuang-che Wu8b654092018-11-09 17:56:25 +0800940 parser_log.add_argument('--before', type=float)
941 parser_log.add_argument('--after', type=float)
942 parser_log.add_argument(
943 '--json', action='store_true', help='Machine readable output')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800944 parser_log.set_defaults(func=self.cmd_log)
945
946 parser_next = subparsers.add_parser(
947 'next', help='Prints next suggested rev to bisect')
948 parser_next.set_defaults(func=self.cmd_next)
949
950 return parser
951
952 def main(self, *args, **kwargs):
953 """Command line main function.
954
955 Args:
956 *args: Command line arguments.
957 **kwargs: additional non command line arguments passed by script code.
958 {
959 'prog': Program name; optional.
960 }
961 """
Kuang-che Wu385279d2017-09-27 14:48:28 +0800962 common.init()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800963 parser = self.create_argument_parser(kwargs.get('prog'))
964 opts = parser.parse_args(args or None)
965 common.config_logging(opts)
966
967 self._create_states(session=opts.session, session_base=opts.session_base)
968 if opts.command not in ('init', 'reset', 'config'):
969 self.states.load()
970 self.domain = self.domain_cls(self.states.config)
971 self.strategy = strategy.NoisyBinarySearch(
972 self.states.rev_info,
973 self.states.rev2idx(self.config['old']),
974 self.states.rev2idx(self.config['new']),
975 confidence=self.config['confidence'],
976 observation=self.config['noisy'])
977
978 return opts.func(opts)