commit 752228c65bc18a5eca6fd006a4a9c337ca0596c8
author Kuang-che Wu <kcwu@chromium.org> Wed Sep 05 13:54:22 2018 +0800
committer chrome-bot <chrome-bot@chromium.org> Wed Sep 05 02:03:42 2018 -0700
tree 7958dbdc04ac3da690817a2cd11b041cf881e23e
parent 02df747e0d1b9f59be16b19f1a0500cddadc6e0f

bisect-kit: distinguish version format validation for intra versions

BUG=None
TEST=bisect chromeos local build, then ./bisect_cros_repo.py run <intra_rev>

Change-Id: Idef151fbaab30b0b353a22d03ff38fdf05811dc3
Reviewed-on: https://chromium-review.googlesource.com/1206250
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chi-Ngai Wan <cnwan@google.com>

bisect_kit/cli.py

diff --git a/bisect_kit/cli.py b/bisect_kit/cli.py
index 1bc4dd4..9515111 100644
--- a/bisect_kit/cli.py
+++ b/bisect_kit/cli.py
@@ -544,7 +544,7 @@
       idx = self.strategy.next_idx()
       rev = self.states.idx2rev(idx)
     else:
-      rev = self.domain_cls.revtype(opts.rev)
+      rev = self.domain_cls.intra_revtype(opts.rev)
     assert rev
 
     logger.info('switch to %s', rev)
@@ -733,7 +733,7 @@
     parser_run.add_argument(
         'revs',
         nargs='*',
-        type=self.domain_cls.revtype,
+        type=self.domain_cls.intra_revtype,
         help='revs to switch+eval; '
         'default is calculating automatically and run until done')
     parser_run.set_defaults(func=self.cmd_run)
@@ -741,25 +741,31 @@
     parser_switch = subparsers.add_parser(
         'switch', help='Switch to given rev without eval')
     parser_switch.add_argument(
-        'rev', type=argtype_multiplexer(self.domain_cls.revtype, 'next'))
+        'rev', type=argtype_multiplexer(self.domain_cls.intra_revtype, 'next'))
     parser_switch.set_defaults(func=self.cmd_switch)
 
     parser_old = subparsers.add_parser(
         'old', help='Tells bisect engine the said revs have "old" behavior')
     parser_old.add_argument(
-        'revs', nargs='+', type=argtype_multiplier(self.domain_cls.revtype))
+        'revs',
+        nargs='+',
+        type=argtype_multiplier(self.domain_cls.intra_revtype))
     parser_old.set_defaults(func=self.cmd_old)
 
     parser_new = subparsers.add_parser(
         'new', help='Tells bisect engine the said revs have "new" behavior')
     parser_new.add_argument(
-        'revs', nargs='+', type=argtype_multiplier(self.domain_cls.revtype))
+        'revs',
+        nargs='+',
+        type=argtype_multiplier(self.domain_cls.intra_revtype))
     parser_new.set_defaults(func=self.cmd_new)
 
     parser_skip = subparsers.add_parser(
         'skip', help='Tells bisect engine the said revs have "skip" behavior')
     parser_skip.add_argument(
-        'revs', nargs='+', type=argtype_multiplier(self.domain_cls.revtype))
+        'revs',
+        nargs='+',
+        type=argtype_multiplier(self.domain_cls.intra_revtype))
     parser_skip.set_defaults(func=self.cmd_skip)
 
     parser_view = subparsers.add_parser(