commit 385279d88c04b1053ab19726612edb816a66975e
author Kuang-che Wu <kcwu@chromium.org> Wed Sep 27 14:48:28 2017 +0800
committer Kuang-che Wu <kcwu@chromium.org> Tue Oct 24 13:41:20 2017 +0000
tree 85d6f35aea6e24baa81e6a74433a8b9a06ff94f9
parent 8851888906e22cb187ba0a55dde96a266d036275

bisect-kit: support config file and plugins

Besides command line arguments and environment variables, users can set
common options in config file.

The main purpose of plugin hook mechanism is for patching functions by
private implementations. For example, fetching build artifacts from
internal servers. This feature is necessary for my latter commits of
android bisector.

BUG=chromium:776314

Change-Id: I81e47398cfee591c5c810479d4824857599f5d53

bisect_kit/cli.py

diff --git a/bisect_kit/cli.py b/bisect_kit/cli.py
index 6b884c1..d70c8e4 100644
--- a/bisect_kit/cli.py
+++ b/bisect_kit/cli.py
@@ -14,6 +14,7 @@
 import time
 
 from bisect_kit import common
+from bisect_kit import configure
 from bisect_kit import core
 from bisect_kit import strategy
 from bisect_kit import util
@@ -577,8 +578,7 @@
     if not session:
       session = DEFAULT_SESSION_NAME
     if not session_base:
-      defaults = util.DefaultConfig()
-      session_base = defaults.get('SESSION_BASE', DEFAULT_SESSION_BASE)
+      session_base = configure.get('SESSION_BASE', DEFAULT_SESSION_BASE)
 
     session_file = os.path.join(session_base, session, self.domain_cls.__name__)
 
@@ -631,7 +631,6 @@
     self.states.save()
 
   def create_argument_parser(self, prog):
-    defaults = util.DefaultConfig()
     parser = argparse.ArgumentParser(
         prog=prog,
         formatter_class=argparse.RawDescriptionHelpFormatter,
@@ -641,11 +640,15 @@
         When running switcher and evaluator, it will set BISECT_REV environment
         variable, indicates current rev to switch/evaluate.
         ''' % self.domain_cls.__name__) + textwrap.dedent(self.domain_cls.help))
-    common.add_logging_arguments(parser, defaults)
+    common.add_common_arguments(parser)
+    parser.add_argument(
+        '--rc',
+        help='Specify config file to use. Otherwise searches default '
+        'locations. Use "none" to surpress config file searching.')
     parser.add_argument(
         '--session_base',
         type=argtype_dir_path,
-        default=defaults.get('SESSION_BASE', DEFAULT_SESSION_BASE),
+        default=configure.get('SESSION_BASE', DEFAULT_SESSION_BASE),
         help='Directory to store sessions (default: %(default)r)')
     parser.add_argument(
         '--session',
@@ -786,6 +789,7 @@
           'prog': Program name; optional.
         }
     """
+    common.init()
     parser = self.create_argument_parser(kwargs.get('prog'))
     opts = parser.parse_args(args or None)
     common.config_logging(opts)