blob: e929e314d67d2244a7cc884100c25216c9e0a8a9 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000019import fnmatch
20import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000043import gclient_utils
dpranke@chromium.org2a009622011-03-01 02:43:31 +000044import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000045import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000046import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000047import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000048import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049
50
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000051# Ask for feedback only once in program lifetime.
52_ASKED_FOR_FEEDBACK = False
53
54
maruel@chromium.org899e1c12011-04-07 17:03:18 +000055class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000056 pass
57
58
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000059class CommandData(object):
60 def __init__(self, name, cmd, kwargs, message):
61 self.name = name
62 self.cmd = cmd
63 self.kwargs = kwargs
64 self.message = message
65 self.info = None
66
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000067
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000068def normpath(path):
69 '''Version of os.path.normpath that also changes backward slashes to
70 forward slashes when not running on Windows.
71 '''
72 # This is safe to always do because the Windows version of os.path.normpath
73 # will replace forward slashes with backward slashes.
74 path = path.replace(os.sep, '/')
75 return os.path.normpath(path)
76
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000077
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000078def _RightHandSideLinesImpl(affected_files):
79 """Implements RightHandSideLines for InputApi and GclChange."""
80 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000081 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000082 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000083 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000084
85
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000086class PresubmitOutput(object):
87 def __init__(self, input_stream=None, output_stream=None):
88 self.input_stream = input_stream
89 self.output_stream = output_stream
90 self.reviewers = []
91 self.written_output = []
92 self.error_count = 0
93
94 def prompt_yes_no(self, prompt_string):
95 self.write(prompt_string)
96 if self.input_stream:
97 response = self.input_stream.readline().strip().lower()
98 if response not in ('y', 'yes'):
99 self.fail()
100 else:
101 self.fail()
102
103 def fail(self):
104 self.error_count += 1
105
106 def should_continue(self):
107 return not self.error_count
108
109 def write(self, s):
110 self.written_output.append(s)
111 if self.output_stream:
112 self.output_stream.write(s)
113
114 def getvalue(self):
115 return ''.join(self.written_output)
116
117
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000118# Top level object so multiprocessing can pickle
119# Public access through OutputApi object.
120class _PresubmitResult(object):
121 """Base class for result objects."""
122 fatal = False
123 should_prompt = False
124
125 def __init__(self, message, items=None, long_text=''):
126 """
127 message: A short one-line message to indicate errors.
128 items: A list of short strings to indicate where errors occurred.
129 long_text: multi-line text output, e.g. from another tool
130 """
131 self._message = message
132 self._items = items or []
133 if items:
134 self._items = items
135 self._long_text = long_text.rstrip()
136
137 def handle(self, output):
138 output.write(self._message)
139 output.write('\n')
140 for index, item in enumerate(self._items):
141 output.write(' ')
142 # Write separately in case it's unicode.
143 output.write(str(item))
144 if index < len(self._items) - 1:
145 output.write(' \\')
146 output.write('\n')
147 if self._long_text:
148 output.write('\n***************\n')
149 # Write separately in case it's unicode.
150 output.write(self._long_text)
151 output.write('\n***************\n')
152 if self.fatal:
153 output.fail()
154
155
156# Top level object so multiprocessing can pickle
157# Public access through OutputApi object.
158class _PresubmitAddReviewers(_PresubmitResult):
159 """Add some suggested reviewers to the change."""
160 def __init__(self, reviewers):
161 super(_PresubmitAddReviewers, self).__init__('')
162 self.reviewers = reviewers
163
164 def handle(self, output):
165 output.reviewers.extend(self.reviewers)
166
167
168# Top level object so multiprocessing can pickle
169# Public access through OutputApi object.
170class _PresubmitError(_PresubmitResult):
171 """A hard presubmit error."""
172 fatal = True
173
174
175# Top level object so multiprocessing can pickle
176# Public access through OutputApi object.
177class _PresubmitPromptWarning(_PresubmitResult):
178 """An warning that prompts the user if they want to continue."""
179 should_prompt = True
180
181
182# Top level object so multiprocessing can pickle
183# Public access through OutputApi object.
184class _PresubmitNotifyResult(_PresubmitResult):
185 """Just print something to the screen -- but it's not even a warning."""
186 pass
187
188
189# Top level object so multiprocessing can pickle
190# Public access through OutputApi object.
191class _MailTextResult(_PresubmitResult):
192 """A warning that should be included in the review request email."""
193 def __init__(self, *args, **kwargs):
194 super(_MailTextResult, self).__init__()
195 raise NotImplementedError()
196
197
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000198class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000199 """An instance of OutputApi gets passed to presubmit scripts so that they
200 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000201 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000202 PresubmitResult = _PresubmitResult
203 PresubmitAddReviewers = _PresubmitAddReviewers
204 PresubmitError = _PresubmitError
205 PresubmitPromptWarning = _PresubmitPromptWarning
206 PresubmitNotifyResult = _PresubmitNotifyResult
207 MailTextResult = _MailTextResult
208
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000209 def __init__(self, is_committing):
210 self.is_committing = is_committing
211
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000212 def PresubmitPromptOrNotify(self, *args, **kwargs):
213 """Warn the user when uploading, but only notify if committing."""
214 if self.is_committing:
215 return self.PresubmitNotifyResult(*args, **kwargs)
216 return self.PresubmitPromptWarning(*args, **kwargs)
217
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000218
219class InputApi(object):
220 """An instance of this object is passed to presubmit scripts so they can
221 know stuff about the change they're looking at.
222 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000223 # Method could be a function
224 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000225
maruel@chromium.org3410d912009-06-09 20:56:16 +0000226 # File extensions that are considered source files from a style guide
227 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000228 #
229 # Files without an extension aren't included in the list. If you want to
230 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
231 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000232 DEFAULT_WHITE_LIST = (
233 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000234 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
235 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000236 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000237 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000238 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000239 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000240 )
241
242 # Path regexp that should be excluded from being considered containing source
243 # files. Don't modify this list from a presubmit script!
244 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000245 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000246 r".*\bexperimental[\\\/].*",
247 r".*\bthird_party[\\\/].*",
248 # Output directories (just in case)
249 r".*\bDebug[\\\/].*",
250 r".*\bRelease[\\\/].*",
251 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000252 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000253 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000254 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000255 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000256 r"(|.*[\\\/])\.git[\\\/].*",
257 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000258 # There is no point in processing a patch file.
259 r".+\.diff$",
260 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000261 )
262
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000263 def __init__(self, change, presubmit_path, is_committing,
maruel@chromium.org239f4112011-06-03 20:08:23 +0000264 rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000265 """Builds an InputApi object.
266
267 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000268 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000270 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000271 rietveld_obj: rietveld.Rietveld client object
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000272 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000273 # Version number of the presubmit_support script.
274 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000275 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000276 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000277 self.rietveld = rietveld_obj
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000278 # TBD
279 self.host_url = 'http://codereview.chromium.org'
280 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000281 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000282
283 # We expose various modules and functions as attributes of the input_api
284 # so that presubmit scripts don't have to import them.
285 self.basename = os.path.basename
286 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000287 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000288 self.cStringIO = cStringIO
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000289 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000290 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000291 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000292 self.os_listdir = os.listdir
293 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000294 self.os_path = os.path
295 self.pickle = pickle
296 self.marshal = marshal
297 self.re = re
298 self.subprocess = subprocess
299 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000300 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000301 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000302 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000303 self.urllib2 = urllib2
304
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000305 # To easily fork python.
306 self.python_executable = sys.executable
307 self.environ = os.environ
308
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000309 # InputApi.platform is the platform you're currently running on.
310 self.platform = sys.platform
311
312 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000313 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000314
315 # We carry the canned checks so presubmit scripts can easily use them.
316 self.canned_checks = presubmit_canned_checks
317
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000318 # TODO(dpranke): figure out a list of all approved owners for a repo
319 # in order to be able to handle wildcard OWNERS files?
320 self.owners_db = owners.Database(change.RepositoryRoot(),
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000321 fopen=file, os_path=self.os_path, glob=self.glob)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000322 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000324
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000325 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000326 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000327 # Access to a protected member _XX of a client class
328 # pylint: disable=W0212
329 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000330 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000331 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
332 for (a, b, header) in cpplint._re_pattern_templates
333 ]
334
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000335 def PresubmitLocalPath(self):
336 """Returns the local path of the presubmit script currently being run.
337
338 This is useful if you don't want to hard-code absolute paths in the
339 presubmit script. For example, It can be used to find another file
340 relative to the PRESUBMIT.py script, so the whole tree can be branched and
341 the presubmit script still works, without editing its content.
342 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000343 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000344
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000345 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000346 """Translate a depot path to a local path (relative to client root).
347
348 Args:
349 Depot path as a string.
350
351 Returns:
352 The local path of the depot path under the user's current client, or None
353 if the file is not mapped.
354
355 Remember to check for the None case and show an appropriate error!
356 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000357 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
358 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000359
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000360 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000361 """Translate a local path to a depot path.
362
363 Args:
364 Local path (relative to current directory, or absolute) as a string.
365
366 Returns:
367 The depot path (SVN URL) of the file if mapped, otherwise None.
368 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000369 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
370 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000371
sail@chromium.org5538e022011-05-12 17:53:16 +0000372 def AffectedFiles(self, include_dirs=False, include_deletes=True,
373 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000374 """Same as input_api.change.AffectedFiles() except only lists files
375 (and optionally directories) in the same directory as the current presubmit
376 script, or subdirectories thereof.
377 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000378 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000379 if len(dir_with_slash) == 1:
380 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000381
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000382 return filter(
383 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000384 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000385
386 def LocalPaths(self, include_dirs=False):
387 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000388 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
389 logging.debug("LocalPaths: %s", paths)
390 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000391
392 def AbsoluteLocalPaths(self, include_dirs=False):
393 """Returns absolute local paths of input_api.AffectedFiles()."""
394 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
395
396 def ServerPaths(self, include_dirs=False):
397 """Returns server paths of input_api.AffectedFiles()."""
398 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
399
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000400 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000401 """Same as input_api.change.AffectedTextFiles() except only lists files
402 in the same directory as the current presubmit script, or subdirectories
403 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000405 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000406 warn("AffectedTextFiles(include_deletes=%s)"
407 " is deprecated and ignored" % str(include_deletes),
408 category=DeprecationWarning,
409 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000410 return filter(lambda x: x.IsTextFile(),
411 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000412
maruel@chromium.org3410d912009-06-09 20:56:16 +0000413 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
414 """Filters out files that aren't considered "source file".
415
416 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
417 and InputApi.DEFAULT_BLACK_LIST is used respectively.
418
419 The lists will be compiled as regular expression and
420 AffectedFile.LocalPath() needs to pass both list.
421
422 Note: Copy-paste this function to suit your needs or use a lambda function.
423 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000424 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000425 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000426 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000427 if self.re.match(item, local_path):
428 logging.debug("%s matched %s" % (item, local_path))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000429 return True
430 return False
431 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
432 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
433
434 def AffectedSourceFiles(self, source_file):
435 """Filter the list of AffectedTextFiles by the function source_file.
436
437 If source_file is None, InputApi.FilterSourceFile() is used.
438 """
439 if not source_file:
440 source_file = self.FilterSourceFile
441 return filter(source_file, self.AffectedTextFiles())
442
443 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000444 """An iterator over all text lines in "new" version of changed files.
445
446 Only lists lines from new or modified text files in the change that are
447 contained by the directory of the currently executing presubmit script.
448
449 This is useful for doing line-by-line regex checks, like checking for
450 trailing whitespace.
451
452 Yields:
453 a 3 tuple:
454 the AffectedFile instance of the current file;
455 integer line number (1-based); and
456 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000457
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000458 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000459 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000460 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000461 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000463 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000464 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000465
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000466 Deny reading anything outside the repository.
467 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000468 if isinstance(file_item, AffectedFile):
469 file_item = file_item.AbsoluteLocalPath()
470 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000471 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000472 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000473
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000474 @property
475 def tbr(self):
476 """Returns if a change is TBR'ed."""
477 return 'TBR' in self.change.tags
478
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000479 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000480 tests = []
481 msgs = []
482 for t in tests_mix:
483 if isinstance(t, OutputApi.PresubmitResult):
484 msgs.append(t)
485 else:
486 assert issubclass(t.message, _PresubmitResult)
487 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000488 if self.verbose:
489 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000490 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000491 pool = multiprocessing.Pool()
492 # async recipe works around multiprocessing bug handling Ctrl-C
493 msgs.extend(pool.map_async(CallCommand, tests).get(99999))
494 pool.close()
495 pool.join()
496 else:
497 msgs.extend(map(CallCommand, tests))
498 return [m for m in msgs if m]
499
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000500
nick@chromium.orgff526192013-06-10 19:30:26 +0000501class _DiffCache(object):
502 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000503 def __init__(self, upstream=None):
504 """Stores the upstream revision against which all diffs will be computed."""
505 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000506
507 def GetDiff(self, path, local_root):
508 """Get the diff for a particular path."""
509 raise NotImplementedError()
510
511
512class _SvnDiffCache(_DiffCache):
513 """DiffCache implementation for subversion."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000514 def __init__(self, *args, **kwargs):
515 super(_SvnDiffCache, self).__init__(*args, **kwargs)
nick@chromium.orgff526192013-06-10 19:30:26 +0000516 self._diffs_by_file = {}
517
518 def GetDiff(self, path, local_root):
519 if path not in self._diffs_by_file:
520 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
521 False, None)
522 return self._diffs_by_file[path]
523
524
525class _GitDiffCache(_DiffCache):
526 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000527 def __init__(self, upstream):
528 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000529 self._diffs_by_file = None
530
531 def GetDiff(self, path, local_root):
532 if not self._diffs_by_file:
533 # Compute a single diff for all files and parse the output; should
534 # with git this is much faster than computing one diff for each file.
535 diffs = {}
536
537 # Don't specify any filenames below, because there are command line length
538 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000539 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
540 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000541
542 # This regex matches the path twice, separated by a space. Note that
543 # filename itself may contain spaces.
544 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
545 current_diff = []
546 keep_line_endings = True
547 for x in unified_diff.splitlines(keep_line_endings):
548 match = file_marker.match(x)
549 if match:
550 # Marks the start of a new per-file section.
551 diffs[match.group('filename')] = current_diff = [x]
552 elif x.startswith('diff --git'):
553 raise PresubmitFailure('Unexpected diff line: %s' % x)
554 else:
555 current_diff.append(x)
556
557 self._diffs_by_file = dict(
558 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
559
560 if path not in self._diffs_by_file:
561 raise PresubmitFailure(
562 'Unified diff did not contain entry for file %s' % path)
563
564 return self._diffs_by_file[path]
565
566
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000567class AffectedFile(object):
568 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000569
570 DIFF_CACHE = _DiffCache
571
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000572 # Method could be a function
573 # pylint: disable=R0201
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000574 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000575 self._path = path
576 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000577 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000578 self._is_directory = None
579 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000580 self._cached_changed_contents = None
581 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000582 self._diff_cache = diff_cache
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000583 logging.debug('%s(%s)' % (self.__class__.__name__, self._path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000584
585 def ServerPath(self):
586 """Returns a path string that identifies the file in the SCM system.
587
588 Returns the empty string if the file does not exist in SCM.
589 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000590 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591
592 def LocalPath(self):
593 """Returns the path of this file on the local disk relative to client root.
594 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000595 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596
597 def AbsoluteLocalPath(self):
598 """Returns the absolute path of this file on the local disk.
599 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000600 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601
602 def IsDirectory(self):
603 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000604 if self._is_directory is None:
605 path = self.AbsoluteLocalPath()
606 self._is_directory = (os.path.exists(path) and
607 os.path.isdir(path))
608 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000609
610 def Action(self):
611 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000612 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
613 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000614 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000616 def Property(self, property_name):
617 """Returns the specified SCM property of this file, or None if no such
618 property.
619 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000620 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000621
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000622 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000623 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000624
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000625 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000626 raise NotImplementedError() # Implement when needed
627
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 def NewContents(self):
629 """Returns an iterator over the lines in the new version of file.
630
631 The new version is the file in the user's workspace, i.e. the "right hand
632 side".
633
634 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000635 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000637 if self._cached_new_contents is None:
638 self._cached_new_contents = []
639 if not self.IsDirectory():
640 try:
641 self._cached_new_contents = gclient_utils.FileRead(
642 self.AbsoluteLocalPath(), 'rU').splitlines()
643 except IOError:
644 pass # File not found? That's fine; maybe it was deleted.
645 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000647 def ChangedContents(self):
648 """Returns a list of tuples (line number, line text) of all new lines.
649
650 This relies on the scm diff output describing each changed code section
651 with a line of the form
652
653 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
654 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000655 if self._cached_changed_contents is not None:
656 return self._cached_changed_contents[:]
657 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000658 line_num = 0
659
660 if self.IsDirectory():
661 return []
662
663 for line in self.GenerateScmDiff().splitlines():
664 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
665 if m:
666 line_num = int(m.groups(1)[0])
667 continue
668 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000669 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000670 if not line.startswith('-'):
671 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000672 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000673
maruel@chromium.org5de13972009-06-10 18:16:06 +0000674 def __str__(self):
675 return self.LocalPath()
676
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000677 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000678 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000679
maruel@chromium.org58407af2011-04-12 23:15:57 +0000680
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000681class SvnAffectedFile(AffectedFile):
682 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000683 # Method 'NNN' is abstract in class 'NNN' but is not overridden
684 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000685
nick@chromium.orgff526192013-06-10 19:30:26 +0000686 DIFF_CACHE = _SvnDiffCache
687
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000688 def __init__(self, *args, **kwargs):
689 AffectedFile.__init__(self, *args, **kwargs)
690 self._server_path = None
691 self._is_text_file = None
692
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000693 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000694 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000695 self._server_path = scm.SVN.CaptureLocalInfo(
696 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000697 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000698
699 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000700 if self._is_directory is None:
701 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000702 if os.path.exists(path):
703 # Retrieve directly from the file system; it is much faster than
704 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000705 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000706 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000707 self._is_directory = scm.SVN.CaptureLocalInfo(
708 [self.LocalPath()], self._local_root
709 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000710 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000711
712 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000713 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000714 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000715 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000716 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000717
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000718 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000719 if self._is_text_file is None:
720 if self.Action() == 'D':
721 # A deleted file is not a text file.
722 self._is_text_file = False
723 elif self.IsDirectory():
724 self._is_text_file = False
725 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000726 mime_type = scm.SVN.GetFileProperty(
727 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000728 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
729 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000730
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000731
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000732class GitAffectedFile(AffectedFile):
733 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000734 # Method 'NNN' is abstract in class 'NNN' but is not overridden
735 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000736
nick@chromium.orgff526192013-06-10 19:30:26 +0000737 DIFF_CACHE = _GitDiffCache
738
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000739 def __init__(self, *args, **kwargs):
740 AffectedFile.__init__(self, *args, **kwargs)
741 self._server_path = None
742 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000743
744 def ServerPath(self):
745 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000746 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000747 return self._server_path
748
749 def IsDirectory(self):
750 if self._is_directory is None:
751 path = self.AbsoluteLocalPath()
752 if os.path.exists(path):
753 # Retrieve directly from the file system; it is much faster than
754 # querying subversion, especially on Windows.
755 self._is_directory = os.path.isdir(path)
756 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000757 self._is_directory = False
758 return self._is_directory
759
760 def Property(self, property_name):
761 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000762 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000763 return self._properties[property_name]
764
765 def IsTextFile(self):
766 if self._is_text_file is None:
767 if self.Action() == 'D':
768 # A deleted file is not a text file.
769 self._is_text_file = False
770 elif self.IsDirectory():
771 self._is_text_file = False
772 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000773 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
774 return self._is_text_file
775
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000776
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000777class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000778 """Describe a change.
779
780 Used directly by the presubmit scripts to query the current change being
781 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000782
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000783 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000784 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000785 self.KEY: equivalent to tags['KEY']
786 """
787
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000788 _AFFECTED_FILES = AffectedFile
789
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000790 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000791 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000792 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000793 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000794
maruel@chromium.org58407af2011-04-12 23:15:57 +0000795 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000796 self, name, description, local_root, files, issue, patchset, author,
797 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000798 if files is None:
799 files = []
800 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000801 # Convert root into an absolute path.
802 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000803 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000804 self.issue = issue
805 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000806 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000807
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000808 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000810 self._description_without_tags = ''
811 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000812
maruel@chromium.orge085d812011-10-10 19:49:15 +0000813 assert all(
814 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
815
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000816 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000817 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000818 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
819 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000820 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000821
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000822 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000823 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000824 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000825
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000826 def DescriptionText(self):
827 """Returns the user-entered changelist description, minus tags.
828
829 Any line in the user-provided description starting with e.g. "FOO="
830 (whitespace permitted before and around) is considered a tag line. Such
831 lines are stripped out of the description this function returns.
832 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000833 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000834
835 def FullDescriptionText(self):
836 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000837 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000838
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000839 def SetDescriptionText(self, description):
840 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000841
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000842 Also updates the list of tags."""
843 self._full_description = description
844
845 # From the description text, build up a dictionary of key/value pairs
846 # plus the description minus all key/value or "tag" lines.
847 description_without_tags = []
848 self.tags = {}
849 for line in self._full_description.splitlines():
850 m = self.TAG_LINE_RE.match(line)
851 if m:
852 self.tags[m.group('key')] = m.group('value')
853 else:
854 description_without_tags.append(line)
855
856 # Change back to text and remove whitespace at end.
857 self._description_without_tags = (
858 '\n'.join(description_without_tags).rstrip())
859
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000860 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000861 """Returns the repository (checkout) root directory for this change,
862 as an absolute path.
863 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000864 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865
866 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000867 """Return tags directly as attributes on the object."""
868 if not re.match(r"^[A-Z_]*$", attr):
869 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000870 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000872 def AllFiles(self, root=None):
873 """List all files under source control in the repo."""
874 raise NotImplementedError()
875
sail@chromium.org5538e022011-05-12 17:53:16 +0000876 def AffectedFiles(self, include_dirs=False, include_deletes=True,
877 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878 """Returns a list of AffectedFile instances for all files in the change.
879
880 Args:
881 include_deletes: If false, deleted files will be filtered out.
882 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000883 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000884
885 Returns:
886 [AffectedFile(path, action), AffectedFile(path, action)]
887 """
888 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000889 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000890 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000891 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000892
sail@chromium.org5538e022011-05-12 17:53:16 +0000893 affected = filter(file_filter, affected)
894
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000895 if include_deletes:
896 return affected
897 else:
898 return filter(lambda x: x.Action() != 'D', affected)
899
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000900 def AffectedTextFiles(self, include_deletes=None):
901 """Return a list of the existing text files in a change."""
902 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000903 warn("AffectedTextFiles(include_deletes=%s)"
904 " is deprecated and ignored" % str(include_deletes),
905 category=DeprecationWarning,
906 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000907 return filter(lambda x: x.IsTextFile(),
908 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000909
910 def LocalPaths(self, include_dirs=False):
911 """Convenience function."""
912 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
913
914 def AbsoluteLocalPaths(self, include_dirs=False):
915 """Convenience function."""
916 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
917
918 def ServerPaths(self, include_dirs=False):
919 """Convenience function."""
920 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
921
922 def RightHandSideLines(self):
923 """An iterator over all text lines in "new" version of changed files.
924
925 Lists lines from new or modified text files in the change.
926
927 This is useful for doing line-by-line regex checks, like checking for
928 trailing whitespace.
929
930 Yields:
931 a 3 tuple:
932 the AffectedFile instance of the current file;
933 integer line number (1-based); and
934 the contents of the line as a string.
935 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000936 return _RightHandSideLinesImpl(
937 x for x in self.AffectedFiles(include_deletes=False)
938 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000939
940
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000941class SvnChange(Change):
942 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000943 scm = 'svn'
944 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000945
946 def _GetChangeLists(self):
947 """Get all change lists."""
948 if self._changelists == None:
949 previous_cwd = os.getcwd()
950 os.chdir(self.RepositoryRoot())
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000951 # Need to import here to avoid circular dependency.
952 import gcl
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000953 self._changelists = gcl.GetModifiedFiles()
954 os.chdir(previous_cwd)
955 return self._changelists
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000956
957 def GetAllModifiedFiles(self):
958 """Get all modified files."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000959 changelists = self._GetChangeLists()
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000960 all_modified_files = []
961 for cl in changelists.values():
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000962 all_modified_files.extend(
963 [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000964 return all_modified_files
965
966 def GetModifiedFiles(self):
967 """Get modified files in the current CL."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000968 changelists = self._GetChangeLists()
969 return [os.path.join(self.RepositoryRoot(), f[1])
970 for f in changelists[self.Name()]]
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000971
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000972 def AllFiles(self, root=None):
973 """List all files under source control in the repo."""
974 root = root or self.RepositoryRoot()
975 return subprocess.check_output(
976 ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
977
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000978
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000979class GitChange(Change):
980 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000981 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000982
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000983 def AllFiles(self, root=None):
984 """List all files under source control in the repo."""
985 root = root or self.RepositoryRoot()
986 return subprocess.check_output(
987 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
988
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000989
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000990def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991 """Finds all presubmit files that apply to a given set of source files.
992
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000993 If inherit-review-settings-ok is present right under root, looks for
994 PRESUBMIT.py in directories enclosing root.
995
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000996 Args:
997 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000998 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000999
1000 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001001 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001002 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001003 files = [normpath(os.path.join(root, f)) for f in files]
1004
1005 # List all the individual directories containing files.
1006 directories = set([os.path.dirname(f) for f in files])
1007
1008 # Ignore root if inherit-review-settings-ok is present.
1009 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1010 root = None
1011
1012 # Collect all unique directories that may contain PRESUBMIT.py.
1013 candidates = set()
1014 for directory in directories:
1015 while True:
1016 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001018 candidates.add(directory)
1019 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001020 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001021 parent_dir = os.path.dirname(directory)
1022 if parent_dir == directory:
1023 # We hit the system root directory.
1024 break
1025 directory = parent_dir
1026
1027 # Look for PRESUBMIT.py in all candidate directories.
1028 results = []
1029 for directory in sorted(list(candidates)):
1030 p = os.path.join(directory, 'PRESUBMIT.py')
1031 if os.path.isfile(p):
1032 results.append(p)
1033
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001034 logging.debug('Presubmit files: %s' % ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001035 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001036
1037
thestig@chromium.orgde243452009-10-06 21:02:56 +00001038class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001039 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001040 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001041 """Executes GetPreferredTrySlaves() from a single presubmit script.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001042
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001043 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001044
1045 Args:
1046 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001047 presubmit_path: Project script to run.
1048 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001049
1050 Return:
1051 A list of try slaves.
1052 """
1053 context = {}
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001054 main_path = os.getcwd()
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001055 try:
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001056 os.chdir(os.path.dirname(presubmit_path))
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001057 exec script_text in context
1058 except Exception, e:
1059 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001060 finally:
1061 os.chdir(main_path)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001062
1063 function_name = 'GetPreferredTrySlaves'
1064 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001065 get_preferred_try_slaves = context[function_name]
1066 function_info = inspect.getargspec(get_preferred_try_slaves)
1067 if len(function_info[0]) == 1:
1068 result = get_preferred_try_slaves(project)
1069 elif len(function_info[0]) == 2:
1070 result = get_preferred_try_slaves(project, change)
1071 else:
1072 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001073 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001074 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001075 'Presubmit functions must return a list, got a %s instead: %s' %
1076 (type(result), str(result)))
1077 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001078 if isinstance(item, basestring):
1079 # Old-style ['bot'] format.
1080 botname = item
1081 elif isinstance(item, tuple):
1082 # New-style [('bot', set(['tests']))] format.
1083 botname = item[0]
1084 else:
1085 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1086 ' format.')
1087
1088 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001089 raise PresubmitFailure(
1090 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001091 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001092 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001093 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001094 else:
1095 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001096
1097 def valid_oldstyle(result):
1098 return all(isinstance(i, basestring) for i in result)
1099
1100 def valid_newstyle(result):
1101 return (all(isinstance(i, tuple) for i in result) and
1102 all(len(i) == 2 for i in result) and
1103 all(isinstance(i[0], basestring) for i in result) and
1104 all(isinstance(i[1], set) for i in result)
1105 )
1106
1107 # Ensure it's either all old-style or all new-style.
1108 if not valid_oldstyle(result) and not valid_newstyle(result):
1109 raise PresubmitFailure(
1110 'PRESUBMIT.py returned invalid trybot specification!')
1111
thestig@chromium.orgde243452009-10-06 21:02:56 +00001112 return result
1113
1114
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001115class GetTryMastersExecuter(object):
1116 @staticmethod
1117 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1118 """Executes GetPreferredTryMasters() from a single presubmit script.
1119
1120 Args:
1121 script_text: The text of the presubmit script.
1122 presubmit_path: Project script to run.
1123 project: Project name to pass to presubmit script for bot selection.
1124
1125 Return:
1126 A map of try masters to map of builders to set of tests.
1127 """
1128 context = {}
1129 try:
1130 exec script_text in context
1131 except Exception, e:
1132 raise PresubmitFailure('"%s" had an exception.\n%s'
1133 % (presubmit_path, e))
1134
1135 function_name = 'GetPreferredTryMasters'
1136 if function_name not in context:
1137 return {}
1138 get_preferred_try_masters = context[function_name]
1139 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1140 raise PresubmitFailure(
1141 'Expected function "GetPreferredTryMasters" to take two arguments.')
1142 return get_preferred_try_masters(project, change)
1143
1144
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001145def DoGetTrySlaves(change,
1146 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001147 repository_root,
1148 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001149 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001150 verbose,
1151 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001152 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001153
1154 Args:
1155 changed_files: List of modified files.
1156 repository_root: The repository root.
1157 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001158 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001159 verbose: Prints debug info.
1160 output_stream: A stream to write debug output to.
1161
1162 Return:
1163 List of try slaves
1164 """
1165 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1166 if not presubmit_files and verbose:
mdempsky@chromium.orgd59e7612014-03-05 19:55:56 +00001167 output_stream.write("Warning, no PRESUBMIT.py found.\n")
thestig@chromium.orgde243452009-10-06 21:02:56 +00001168 results = []
1169 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001170
thestig@chromium.orgde243452009-10-06 21:02:56 +00001171 if default_presubmit:
1172 if verbose:
1173 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001174 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001175 results.extend(executer.ExecPresubmitScript(
1176 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001177 for filename in presubmit_files:
1178 filename = os.path.abspath(filename)
1179 if verbose:
1180 output_stream.write("Running %s\n" % filename)
1181 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001182 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001183 results.extend(executer.ExecPresubmitScript(
1184 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001185
stip@chromium.org5ca27622013-12-18 17:44:58 +00001186
1187 slave_dict = {}
1188 old_style = filter(lambda x: isinstance(x, basestring), results)
1189 new_style = filter(lambda x: isinstance(x, tuple), results)
1190
1191 for result in new_style:
1192 slave_dict.setdefault(result[0], set()).update(result[1])
1193 slaves = list(slave_dict.items())
1194
1195 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001196
thestig@chromium.orgde243452009-10-06 21:02:56 +00001197 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001198 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001199 output_stream.write('\n')
1200 return slaves
1201
1202
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001203def _MergeMasters(masters1, masters2):
1204 """Merges two master maps. Merges also the tests of each builder."""
1205 result = {}
1206 for (master, builders) in itertools.chain(masters1.iteritems(),
1207 masters2.iteritems()):
1208 new_builders = result.setdefault(master, {})
1209 for (builder, tests) in builders.iteritems():
1210 new_builders.setdefault(builder, set([])).update(tests)
1211 return result
1212
1213
1214def DoGetTryMasters(change,
1215 changed_files,
1216 repository_root,
1217 default_presubmit,
1218 project,
1219 verbose,
1220 output_stream):
1221 """Get the list of try masters from the presubmit scripts.
1222
1223 Args:
1224 changed_files: List of modified files.
1225 repository_root: The repository root.
1226 default_presubmit: A default presubmit script to execute in any case.
1227 project: Optional name of a project used in selecting trybots.
1228 verbose: Prints debug info.
1229 output_stream: A stream to write debug output to.
1230
1231 Return:
1232 Map of try masters to map of builders to set of tests.
1233 """
1234 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1235 if not presubmit_files and verbose:
1236 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1237 results = {}
1238 executer = GetTryMastersExecuter()
1239
1240 if default_presubmit:
1241 if verbose:
1242 output_stream.write("Running default presubmit script.\n")
1243 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1244 results = _MergeMasters(results, executer.ExecPresubmitScript(
1245 default_presubmit, fake_path, project, change))
1246 for filename in presubmit_files:
1247 filename = os.path.abspath(filename)
1248 if verbose:
1249 output_stream.write("Running %s\n" % filename)
1250 # Accept CRLF presubmit script.
1251 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1252 results = _MergeMasters(results, executer.ExecPresubmitScript(
1253 presubmit_script, filename, project, change))
1254
1255 # Make sets to lists again for later JSON serialization.
1256 for builders in results.itervalues():
1257 for builder in builders:
1258 builders[builder] = list(builders[builder])
1259
1260 if results and verbose:
1261 output_stream.write('%s\n' % str(results))
1262 return results
1263
1264
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001265class PresubmitExecuter(object):
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001266 def __init__(self, change, committing, rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001267 """
1268 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001269 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001270 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001271 rietveld_obj: rietveld.Rietveld client object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001272 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001273 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001275 self.rietveld = rietveld_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001276 self.verbose = verbose
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001277
1278 def ExecPresubmitScript(self, script_text, presubmit_path):
1279 """Executes a single presubmit script.
1280
1281 Args:
1282 script_text: The text of the presubmit script.
1283 presubmit_path: The path to the presubmit file (this will be reported via
1284 input_api.PresubmitLocalPath()).
1285
1286 Return:
1287 A list of result objects, empty if no problems.
1288 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001289
1290 # Change to the presubmit file's directory to support local imports.
1291 main_path = os.getcwd()
1292 os.chdir(os.path.dirname(presubmit_path))
1293
1294 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001295 input_api = InputApi(self.change, presubmit_path, self.committing,
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001296 self.rietveld, self.verbose)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001298 try:
1299 exec script_text in context
1300 except Exception, e:
1301 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302
1303 # These function names must change if we make substantial changes to
1304 # the presubmit API that are not backwards compatible.
1305 if self.committing:
1306 function_name = 'CheckChangeOnCommit'
1307 else:
1308 function_name = 'CheckChangeOnUpload'
1309 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001310 context['__args'] = (input_api, OutputApi(self.committing))
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001311 logging.debug('Running %s in %s' % (function_name, presubmit_path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001312 result = eval(function_name + '(*__args)', context)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001313 logging.debug('Running %s done.' % function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001314 if not (isinstance(result, types.TupleType) or
1315 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001316 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001317 'Presubmit functions must return a tuple or list')
1318 for item in result:
1319 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001320 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001321 'All presubmit results must be of types derived from '
1322 'output_api.PresubmitResult')
1323 else:
1324 result = () # no error since the script doesn't care about current event.
1325
chase@chromium.org8e416c82009-10-06 04:30:44 +00001326 # Return the process to the original working directory.
1327 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001328 return result
1329
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001330
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001331def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001332 committing,
1333 verbose,
1334 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001335 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001336 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001337 may_prompt,
maruel@chromium.org239f4112011-06-03 20:08:23 +00001338 rietveld_obj):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001339 """Runs all presubmit checks that apply to the files in the change.
1340
1341 This finds all PRESUBMIT.py files in directories enclosing the files in the
1342 change (up to the repository root) and calls the relevant entrypoint function
1343 depending on whether the change is being committed or uploaded.
1344
1345 Prints errors, warnings and notifications. Prompts the user for warnings
1346 when needed.
1347
1348 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001349 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001350 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
1351 verbose: Prints debug info.
1352 output_stream: A stream to write output from presubmit tests to.
1353 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001354 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001355 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001356 rietveld_obj: rietveld.Rietveld object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001357
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001358 Warning:
1359 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1360 SHOULD be sys.stdin.
1361
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001362 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001363 A PresubmitOutput object. Use output.should_continue() to figure out
1364 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001365 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001366 old_environ = os.environ
1367 try:
1368 # Make sure python subprocesses won't generate .pyc files.
1369 os.environ = os.environ.copy()
1370 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001371
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001372 output = PresubmitOutput(input_stream, output_stream)
1373 if committing:
1374 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001375 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001376 output.write("Running presubmit upload checks ...\n")
1377 start_time = time.time()
1378 presubmit_files = ListRelevantPresubmitFiles(
1379 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1380 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001381 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001382 results = []
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001383 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001384 if default_presubmit:
1385 if verbose:
1386 output.write("Running default presubmit script.\n")
1387 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1388 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1389 for filename in presubmit_files:
1390 filename = os.path.abspath(filename)
1391 if verbose:
1392 output.write("Running %s\n" % filename)
1393 # Accept CRLF presubmit script.
1394 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1395 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001396
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001397 errors = []
1398 notifications = []
1399 warnings = []
1400 for result in results:
1401 if result.fatal:
1402 errors.append(result)
1403 elif result.should_prompt:
1404 warnings.append(result)
1405 else:
1406 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001407
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001408 output.write('\n')
1409 for name, items in (('Messages', notifications),
1410 ('Warnings', warnings),
1411 ('ERRORS', errors)):
1412 if items:
1413 output.write('** Presubmit %s **\n' % name)
1414 for item in items:
1415 item.handle(output)
1416 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001417
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001418 total_time = time.time() - start_time
1419 if total_time > 1.0:
1420 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001421
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001422 if not errors:
1423 if not warnings:
1424 output.write('Presubmit checks passed.\n')
1425 elif may_prompt:
1426 output.prompt_yes_no('There were presubmit warnings. '
1427 'Are you sure you wish to continue? (y/N): ')
1428 else:
1429 output.fail()
1430
1431 global _ASKED_FOR_FEEDBACK
1432 # Ask for feedback one time out of 5.
1433 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001434 output.write(
1435 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1436 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1437 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001438 _ASKED_FOR_FEEDBACK = True
1439 return output
1440 finally:
1441 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001442
1443
1444def ScanSubDirs(mask, recursive):
1445 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001446 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001447 else:
1448 results = []
1449 for root, dirs, files in os.walk('.'):
1450 if '.svn' in dirs:
1451 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001452 if '.git' in dirs:
1453 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001454 for name in files:
1455 if fnmatch.fnmatch(name, mask):
1456 results.append(os.path.join(root, name))
1457 return results
1458
1459
1460def ParseFiles(args, recursive):
maruel@chromium.org7444c502011-02-09 14:02:11 +00001461 logging.debug('Searching for %s' % args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001462 files = []
1463 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001464 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001465 return files
1466
1467
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001468def load_files(options, args):
1469 """Tries to determine the SCM."""
1470 change_scm = scm.determine_scm(options.root)
1471 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001472 if args:
1473 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001474 if change_scm == 'svn':
1475 change_class = SvnChange
1476 if not files:
1477 files = scm.SVN.CaptureStatus([], options.root)
1478 elif change_scm == 'git':
1479 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001480 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001481 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001482 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001483 else:
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001484 logging.info('Doesn\'t seem under source control. Got %d files' % len(args))
1485 if not files:
1486 return None, None
1487 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001488 return change_class, files
1489
1490
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001491class NonexistantCannedCheckFilter(Exception):
1492 pass
1493
1494
1495@contextlib.contextmanager
1496def canned_check_filter(method_names):
1497 filtered = {}
1498 try:
1499 for method_name in method_names:
1500 if not hasattr(presubmit_canned_checks, method_name):
1501 raise NonexistantCannedCheckFilter(method_name)
1502 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1503 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1504 yield
1505 finally:
1506 for name, method in filtered.iteritems():
1507 setattr(presubmit_canned_checks, name, method)
1508
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001509
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001510def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001511 """Runs an external program, potentially from a child process created by the
1512 multiprocessing module.
1513
1514 multiprocessing needs a top level function with a single argument.
1515 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001516 cmd_data.kwargs['stdout'] = subprocess.PIPE
1517 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1518 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001519 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001520 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001521 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001522 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001523 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001524 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001525 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1526 if code != 0:
1527 return cmd_data.message(
1528 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1529 if cmd_data.info:
1530 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001531
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001532
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001533def Main(argv):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001534 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001535 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001536 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001537 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001538 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1539 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001540 parser.add_option("-r", "--recursive", action="store_true",
1541 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001542 parser.add_option("-v", "--verbose", action="count", default=0,
1543 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001544 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001545 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001546 parser.add_option("--description", default='')
1547 parser.add_option("--issue", type='int', default=0)
1548 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001549 parser.add_option("--root", default=os.getcwd(),
1550 help="Search for PRESUBMIT.py up to this directory. "
1551 "If inherit-review-settings-ok is present in this "
1552 "directory, parent directories up to the root file "
1553 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001554 parser.add_option("--upstream",
1555 help="Git only: the base ref or upstream branch against "
1556 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001557 parser.add_option("--default_presubmit")
1558 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001559 parser.add_option("--skip_canned", action='append', default=[],
1560 help="A list of checks to skip which appear in "
1561 "presubmit_canned_checks. Can be provided multiple times "
1562 "to skip multiple canned checks.")
maruel@chromium.org239f4112011-06-03 20:08:23 +00001563 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1564 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
1565 parser.add_option("--rietveld_password", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001566 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1567 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001568 # These are for OAuth2 authentication for bots. See also apply_issue.py
1569 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1570 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1571
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001572 parser.add_option("--trybot-json",
1573 help="Output trybot information to the file specified.")
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001574 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001575
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001576 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001577 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001578 elif options.verbose:
1579 logging.basicConfig(level=logging.INFO)
1580 else:
1581 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001582
1583 if options.rietveld_email and options.rietveld_email_file:
1584 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1585 "can be passed to this program.")
1586 if options.rietveld_private_key_file and options.rietveld_password:
1587 parser.error("Only one of --rietveld_private_key_file or "
1588 "--rietveld_password can be passed to this program.")
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001589
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001590 if options.rietveld_email_file:
1591 with open(options.rietveld_email_file, "rb") as f:
1592 options.rietveld_email = f.read().strip()
1593
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001594 change_class, files = load_files(options, args)
1595 if not change_class:
1596 parser.error('For unversioned directory, <files> is not optional.')
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001597 logging.info('Found %d file(s).' % len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001598
maruel@chromium.org239f4112011-06-03 20:08:23 +00001599 rietveld_obj = None
1600 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001601 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001602 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001603 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1604 options.rietveld_url,
1605 options.rietveld_email,
1606 options.rietveld_private_key_file)
1607 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001608 rietveld_obj = rietveld.CachingRietveld(
1609 options.rietveld_url,
1610 options.rietveld_email,
1611 options.rietveld_password)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001612 if options.rietveld_fetch:
1613 assert options.issue
1614 props = rietveld_obj.get_issue_properties(options.issue, False)
1615 options.author = props['owner_email']
1616 options.description = props['description']
1617 logging.info('Got author: "%s"', options.author)
1618 logging.info('Got description: """\n%s\n"""', options.description)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001619 if options.trybot_json:
1620 with open(options.trybot_json, 'w') as f:
1621 # Python's sets aren't JSON-encodable, so we convert them to lists here.
1622 class SetEncoder(json.JSONEncoder):
1623 # pylint: disable=E0202
1624 def default(self, obj):
1625 if isinstance(obj, set):
1626 return sorted(obj)
1627 return json.JSONEncoder.default(self, obj)
1628 change = change_class(options.name,
1629 options.description,
1630 options.root,
1631 files,
1632 options.issue,
1633 options.patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001634 options.author,
1635 upstream=options.upstream)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001636 trybots = DoGetTrySlaves(
1637 change,
1638 change.LocalPaths(),
1639 change.RepositoryRoot(),
1640 None,
1641 None,
1642 options.verbose,
1643 sys.stdout)
1644 json.dump(trybots, f, cls=SetEncoder)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001645 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001646 with canned_check_filter(options.skip_canned):
1647 results = DoPresubmitChecks(
1648 change_class(options.name,
1649 options.description,
1650 options.root,
1651 files,
1652 options.issue,
1653 options.patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001654 options.author,
1655 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001656 options.commit,
1657 options.verbose,
1658 sys.stdout,
1659 sys.stdin,
1660 options.default_presubmit,
1661 options.may_prompt,
1662 rietveld_obj)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001663 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001664 except NonexistantCannedCheckFilter, e:
1665 print >> sys.stderr, (
1666 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1667 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001668 except PresubmitFailure, e:
1669 print >> sys.stderr, e
1670 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1671 print >> sys.stderr, 'If all fails, contact maruel@'
1672 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001673
1674
1675if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001676 fix_encoding.fix_encoding()
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001677 sys.exit(Main(None))