blob: 0abd4219102d630e55fcf0959c73dc8cf5193ad3 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000019import fnmatch
20import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000042import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000043import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000044import gclient_utils
dpranke@chromium.org2a009622011-03-01 02:43:31 +000045import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000046import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000047import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000048import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000049import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050
51
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000052# Ask for feedback only once in program lifetime.
53_ASKED_FOR_FEEDBACK = False
54
55
maruel@chromium.org899e1c12011-04-07 17:03:18 +000056class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000057 pass
58
59
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000060class CommandData(object):
61 def __init__(self, name, cmd, kwargs, message):
62 self.name = name
63 self.cmd = cmd
64 self.kwargs = kwargs
65 self.message = message
66 self.info = None
67
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000068
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000069def normpath(path):
70 '''Version of os.path.normpath that also changes backward slashes to
71 forward slashes when not running on Windows.
72 '''
73 # This is safe to always do because the Windows version of os.path.normpath
74 # will replace forward slashes with backward slashes.
75 path = path.replace(os.sep, '/')
76 return os.path.normpath(path)
77
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000078
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000079def _RightHandSideLinesImpl(affected_files):
80 """Implements RightHandSideLines for InputApi and GclChange."""
81 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000082 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000083 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000084 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000085
86
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000087class PresubmitOutput(object):
88 def __init__(self, input_stream=None, output_stream=None):
89 self.input_stream = input_stream
90 self.output_stream = output_stream
91 self.reviewers = []
92 self.written_output = []
93 self.error_count = 0
94
95 def prompt_yes_no(self, prompt_string):
96 self.write(prompt_string)
97 if self.input_stream:
98 response = self.input_stream.readline().strip().lower()
99 if response not in ('y', 'yes'):
100 self.fail()
101 else:
102 self.fail()
103
104 def fail(self):
105 self.error_count += 1
106
107 def should_continue(self):
108 return not self.error_count
109
110 def write(self, s):
111 self.written_output.append(s)
112 if self.output_stream:
113 self.output_stream.write(s)
114
115 def getvalue(self):
116 return ''.join(self.written_output)
117
118
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000119# Top level object so multiprocessing can pickle
120# Public access through OutputApi object.
121class _PresubmitResult(object):
122 """Base class for result objects."""
123 fatal = False
124 should_prompt = False
125
126 def __init__(self, message, items=None, long_text=''):
127 """
128 message: A short one-line message to indicate errors.
129 items: A list of short strings to indicate where errors occurred.
130 long_text: multi-line text output, e.g. from another tool
131 """
132 self._message = message
133 self._items = items or []
134 if items:
135 self._items = items
136 self._long_text = long_text.rstrip()
137
138 def handle(self, output):
139 output.write(self._message)
140 output.write('\n')
141 for index, item in enumerate(self._items):
142 output.write(' ')
143 # Write separately in case it's unicode.
144 output.write(str(item))
145 if index < len(self._items) - 1:
146 output.write(' \\')
147 output.write('\n')
148 if self._long_text:
149 output.write('\n***************\n')
150 # Write separately in case it's unicode.
151 output.write(self._long_text)
152 output.write('\n***************\n')
153 if self.fatal:
154 output.fail()
155
156
157# Top level object so multiprocessing can pickle
158# Public access through OutputApi object.
159class _PresubmitAddReviewers(_PresubmitResult):
160 """Add some suggested reviewers to the change."""
161 def __init__(self, reviewers):
162 super(_PresubmitAddReviewers, self).__init__('')
163 self.reviewers = reviewers
164
165 def handle(self, output):
166 output.reviewers.extend(self.reviewers)
167
168
169# Top level object so multiprocessing can pickle
170# Public access through OutputApi object.
171class _PresubmitError(_PresubmitResult):
172 """A hard presubmit error."""
173 fatal = True
174
175
176# Top level object so multiprocessing can pickle
177# Public access through OutputApi object.
178class _PresubmitPromptWarning(_PresubmitResult):
179 """An warning that prompts the user if they want to continue."""
180 should_prompt = True
181
182
183# Top level object so multiprocessing can pickle
184# Public access through OutputApi object.
185class _PresubmitNotifyResult(_PresubmitResult):
186 """Just print something to the screen -- but it's not even a warning."""
187 pass
188
189
190# Top level object so multiprocessing can pickle
191# Public access through OutputApi object.
192class _MailTextResult(_PresubmitResult):
193 """A warning that should be included in the review request email."""
194 def __init__(self, *args, **kwargs):
195 super(_MailTextResult, self).__init__()
196 raise NotImplementedError()
197
198
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000199class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000200 """An instance of OutputApi gets passed to presubmit scripts so that they
201 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000202 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000203 PresubmitResult = _PresubmitResult
204 PresubmitAddReviewers = _PresubmitAddReviewers
205 PresubmitError = _PresubmitError
206 PresubmitPromptWarning = _PresubmitPromptWarning
207 PresubmitNotifyResult = _PresubmitNotifyResult
208 MailTextResult = _MailTextResult
209
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000210 def __init__(self, is_committing):
211 self.is_committing = is_committing
212
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000213 def PresubmitPromptOrNotify(self, *args, **kwargs):
214 """Warn the user when uploading, but only notify if committing."""
215 if self.is_committing:
216 return self.PresubmitNotifyResult(*args, **kwargs)
217 return self.PresubmitPromptWarning(*args, **kwargs)
218
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000219
220class InputApi(object):
221 """An instance of this object is passed to presubmit scripts so they can
222 know stuff about the change they're looking at.
223 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000224 # Method could be a function
225 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000226
maruel@chromium.org3410d912009-06-09 20:56:16 +0000227 # File extensions that are considered source files from a style guide
228 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000229 #
230 # Files without an extension aren't included in the list. If you want to
231 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
232 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000233 DEFAULT_WHITE_LIST = (
234 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000235 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
236 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000237 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000238 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000239 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000240 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000241 )
242
243 # Path regexp that should be excluded from being considered containing source
244 # files. Don't modify this list from a presubmit script!
245 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000246 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000247 r".*\bexperimental[\\\/].*",
248 r".*\bthird_party[\\\/].*",
249 # Output directories (just in case)
250 r".*\bDebug[\\\/].*",
251 r".*\bRelease[\\\/].*",
252 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000253 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000254 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000255 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000256 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000257 r"(|.*[\\\/])\.git[\\\/].*",
258 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000259 # There is no point in processing a patch file.
260 r".+\.diff$",
261 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000262 )
263
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000264 def __init__(self, change, presubmit_path, is_committing,
maruel@chromium.org239f4112011-06-03 20:08:23 +0000265 rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000266 """Builds an InputApi object.
267
268 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000269 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000270 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000271 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000272 rietveld_obj: rietveld.Rietveld client object
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000273 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000274 # Version number of the presubmit_support script.
275 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000276 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000277 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000278 self.rietveld = rietveld_obj
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000279 # TBD
280 self.host_url = 'http://codereview.chromium.org'
281 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000282 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000283
284 # We expose various modules and functions as attributes of the input_api
285 # so that presubmit scripts don't have to import them.
286 self.basename = os.path.basename
287 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000288 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000289 self.cStringIO = cStringIO
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000290 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000291 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000292 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000293 self.os_listdir = os.listdir
294 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000295 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000296 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000297 self.pickle = pickle
298 self.marshal = marshal
299 self.re = re
300 self.subprocess = subprocess
301 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000302 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000303 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000304 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000305 self.urllib2 = urllib2
306
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000307 # To easily fork python.
308 self.python_executable = sys.executable
309 self.environ = os.environ
310
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000311 # InputApi.platform is the platform you're currently running on.
312 self.platform = sys.platform
313
314 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000315 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000316
317 # We carry the canned checks so presubmit scripts can easily use them.
318 self.canned_checks = presubmit_canned_checks
319
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000320 # TODO(dpranke): figure out a list of all approved owners for a repo
321 # in order to be able to handle wildcard OWNERS files?
322 self.owners_db = owners.Database(change.RepositoryRoot(),
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000323 fopen=file, os_path=self.os_path, glob=self.glob)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000324 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000326
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000327 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000328 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000329 # Access to a protected member _XX of a client class
330 # pylint: disable=W0212
331 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000332 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000333 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
334 for (a, b, header) in cpplint._re_pattern_templates
335 ]
336
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000337 def PresubmitLocalPath(self):
338 """Returns the local path of the presubmit script currently being run.
339
340 This is useful if you don't want to hard-code absolute paths in the
341 presubmit script. For example, It can be used to find another file
342 relative to the PRESUBMIT.py script, so the whole tree can be branched and
343 the presubmit script still works, without editing its content.
344 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000345 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000346
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000347 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000348 """Translate a depot path to a local path (relative to client root).
349
350 Args:
351 Depot path as a string.
352
353 Returns:
354 The local path of the depot path under the user's current client, or None
355 if the file is not mapped.
356
357 Remember to check for the None case and show an appropriate error!
358 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000359 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
360 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000361
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000362 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000363 """Translate a local path to a depot path.
364
365 Args:
366 Local path (relative to current directory, or absolute) as a string.
367
368 Returns:
369 The depot path (SVN URL) of the file if mapped, otherwise None.
370 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000371 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
372 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000373
sail@chromium.org5538e022011-05-12 17:53:16 +0000374 def AffectedFiles(self, include_dirs=False, include_deletes=True,
375 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000376 """Same as input_api.change.AffectedFiles() except only lists files
377 (and optionally directories) in the same directory as the current presubmit
378 script, or subdirectories thereof.
379 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000380 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000381 if len(dir_with_slash) == 1:
382 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000383
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000384 return filter(
385 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000386 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000387
388 def LocalPaths(self, include_dirs=False):
389 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000390 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
391 logging.debug("LocalPaths: %s", paths)
392 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000393
394 def AbsoluteLocalPaths(self, include_dirs=False):
395 """Returns absolute local paths of input_api.AffectedFiles()."""
396 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
397
398 def ServerPaths(self, include_dirs=False):
399 """Returns server paths of input_api.AffectedFiles()."""
400 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
401
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000402 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000403 """Same as input_api.change.AffectedTextFiles() except only lists files
404 in the same directory as the current presubmit script, or subdirectories
405 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000406 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000407 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000408 warn("AffectedTextFiles(include_deletes=%s)"
409 " is deprecated and ignored" % str(include_deletes),
410 category=DeprecationWarning,
411 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000412 return filter(lambda x: x.IsTextFile(),
413 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000414
maruel@chromium.org3410d912009-06-09 20:56:16 +0000415 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
416 """Filters out files that aren't considered "source file".
417
418 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
419 and InputApi.DEFAULT_BLACK_LIST is used respectively.
420
421 The lists will be compiled as regular expression and
422 AffectedFile.LocalPath() needs to pass both list.
423
424 Note: Copy-paste this function to suit your needs or use a lambda function.
425 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000426 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000427 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000428 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000429 if self.re.match(item, local_path):
430 logging.debug("%s matched %s" % (item, local_path))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000431 return True
432 return False
433 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
434 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
435
436 def AffectedSourceFiles(self, source_file):
437 """Filter the list of AffectedTextFiles by the function source_file.
438
439 If source_file is None, InputApi.FilterSourceFile() is used.
440 """
441 if not source_file:
442 source_file = self.FilterSourceFile
443 return filter(source_file, self.AffectedTextFiles())
444
445 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000446 """An iterator over all text lines in "new" version of changed files.
447
448 Only lists lines from new or modified text files in the change that are
449 contained by the directory of the currently executing presubmit script.
450
451 This is useful for doing line-by-line regex checks, like checking for
452 trailing whitespace.
453
454 Yields:
455 a 3 tuple:
456 the AffectedFile instance of the current file;
457 integer line number (1-based); and
458 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000459
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000460 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000462 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000463 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000464
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000465 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000466 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000467
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000468 Deny reading anything outside the repository.
469 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000470 if isinstance(file_item, AffectedFile):
471 file_item = file_item.AbsoluteLocalPath()
472 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000473 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000474 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000475
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000476 @property
477 def tbr(self):
478 """Returns if a change is TBR'ed."""
479 return 'TBR' in self.change.tags
480
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000481 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000482 tests = []
483 msgs = []
484 for t in tests_mix:
485 if isinstance(t, OutputApi.PresubmitResult):
486 msgs.append(t)
487 else:
488 assert issubclass(t.message, _PresubmitResult)
489 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000490 if self.verbose:
491 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000492 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000493 pool = multiprocessing.Pool()
494 # async recipe works around multiprocessing bug handling Ctrl-C
495 msgs.extend(pool.map_async(CallCommand, tests).get(99999))
496 pool.close()
497 pool.join()
498 else:
499 msgs.extend(map(CallCommand, tests))
500 return [m for m in msgs if m]
501
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000502
nick@chromium.orgff526192013-06-10 19:30:26 +0000503class _DiffCache(object):
504 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000505 def __init__(self, upstream=None):
506 """Stores the upstream revision against which all diffs will be computed."""
507 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000508
509 def GetDiff(self, path, local_root):
510 """Get the diff for a particular path."""
511 raise NotImplementedError()
512
513
514class _SvnDiffCache(_DiffCache):
515 """DiffCache implementation for subversion."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000516 def __init__(self, *args, **kwargs):
517 super(_SvnDiffCache, self).__init__(*args, **kwargs)
nick@chromium.orgff526192013-06-10 19:30:26 +0000518 self._diffs_by_file = {}
519
520 def GetDiff(self, path, local_root):
521 if path not in self._diffs_by_file:
522 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
523 False, None)
524 return self._diffs_by_file[path]
525
526
527class _GitDiffCache(_DiffCache):
528 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000529 def __init__(self, upstream):
530 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000531 self._diffs_by_file = None
532
533 def GetDiff(self, path, local_root):
534 if not self._diffs_by_file:
535 # Compute a single diff for all files and parse the output; should
536 # with git this is much faster than computing one diff for each file.
537 diffs = {}
538
539 # Don't specify any filenames below, because there are command line length
540 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000541 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
542 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000543
544 # This regex matches the path twice, separated by a space. Note that
545 # filename itself may contain spaces.
546 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
547 current_diff = []
548 keep_line_endings = True
549 for x in unified_diff.splitlines(keep_line_endings):
550 match = file_marker.match(x)
551 if match:
552 # Marks the start of a new per-file section.
553 diffs[match.group('filename')] = current_diff = [x]
554 elif x.startswith('diff --git'):
555 raise PresubmitFailure('Unexpected diff line: %s' % x)
556 else:
557 current_diff.append(x)
558
559 self._diffs_by_file = dict(
560 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
561
562 if path not in self._diffs_by_file:
563 raise PresubmitFailure(
564 'Unified diff did not contain entry for file %s' % path)
565
566 return self._diffs_by_file[path]
567
568
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000569class AffectedFile(object):
570 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000571
572 DIFF_CACHE = _DiffCache
573
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000574 # Method could be a function
575 # pylint: disable=R0201
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000576 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000577 self._path = path
578 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000579 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000580 self._is_directory = None
581 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000582 self._cached_changed_contents = None
583 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000584 self._diff_cache = diff_cache
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000585 logging.debug('%s(%s)' % (self.__class__.__name__, self._path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000586
587 def ServerPath(self):
588 """Returns a path string that identifies the file in the SCM system.
589
590 Returns the empty string if the file does not exist in SCM.
591 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000592 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593
594 def LocalPath(self):
595 """Returns the path of this file on the local disk relative to client root.
596 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000597 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598
599 def AbsoluteLocalPath(self):
600 """Returns the absolute path of this file on the local disk.
601 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000602 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603
604 def IsDirectory(self):
605 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000606 if self._is_directory is None:
607 path = self.AbsoluteLocalPath()
608 self._is_directory = (os.path.exists(path) and
609 os.path.isdir(path))
610 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611
612 def Action(self):
613 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000614 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
615 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000616 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000618 def Property(self, property_name):
619 """Returns the specified SCM property of this file, or None if no such
620 property.
621 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000622 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000623
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000624 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000625 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000626
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000627 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000628 raise NotImplementedError() # Implement when needed
629
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000630 def NewContents(self):
631 """Returns an iterator over the lines in the new version of file.
632
633 The new version is the file in the user's workspace, i.e. the "right hand
634 side".
635
636 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000637 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000638 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000639 if self._cached_new_contents is None:
640 self._cached_new_contents = []
641 if not self.IsDirectory():
642 try:
643 self._cached_new_contents = gclient_utils.FileRead(
644 self.AbsoluteLocalPath(), 'rU').splitlines()
645 except IOError:
646 pass # File not found? That's fine; maybe it was deleted.
647 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000649 def ChangedContents(self):
650 """Returns a list of tuples (line number, line text) of all new lines.
651
652 This relies on the scm diff output describing each changed code section
653 with a line of the form
654
655 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
656 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000657 if self._cached_changed_contents is not None:
658 return self._cached_changed_contents[:]
659 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000660 line_num = 0
661
662 if self.IsDirectory():
663 return []
664
665 for line in self.GenerateScmDiff().splitlines():
666 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
667 if m:
668 line_num = int(m.groups(1)[0])
669 continue
670 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000671 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000672 if not line.startswith('-'):
673 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000674 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000675
maruel@chromium.org5de13972009-06-10 18:16:06 +0000676 def __str__(self):
677 return self.LocalPath()
678
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000679 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000680 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000681
maruel@chromium.org58407af2011-04-12 23:15:57 +0000682
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000683class SvnAffectedFile(AffectedFile):
684 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000685 # Method 'NNN' is abstract in class 'NNN' but is not overridden
686 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000687
nick@chromium.orgff526192013-06-10 19:30:26 +0000688 DIFF_CACHE = _SvnDiffCache
689
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000690 def __init__(self, *args, **kwargs):
691 AffectedFile.__init__(self, *args, **kwargs)
692 self._server_path = None
693 self._is_text_file = None
694
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000695 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000696 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000697 self._server_path = scm.SVN.CaptureLocalInfo(
698 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000699 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000700
701 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000702 if self._is_directory is None:
703 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000704 if os.path.exists(path):
705 # Retrieve directly from the file system; it is much faster than
706 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000707 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000708 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000709 self._is_directory = scm.SVN.CaptureLocalInfo(
710 [self.LocalPath()], self._local_root
711 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000712 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000713
714 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000715 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000716 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000717 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000718 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000719
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000720 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000721 if self._is_text_file is None:
722 if self.Action() == 'D':
723 # A deleted file is not a text file.
724 self._is_text_file = False
725 elif self.IsDirectory():
726 self._is_text_file = False
727 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000728 mime_type = scm.SVN.GetFileProperty(
729 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000730 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
731 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000732
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000733
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000734class GitAffectedFile(AffectedFile):
735 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000736 # Method 'NNN' is abstract in class 'NNN' but is not overridden
737 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000738
nick@chromium.orgff526192013-06-10 19:30:26 +0000739 DIFF_CACHE = _GitDiffCache
740
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000741 def __init__(self, *args, **kwargs):
742 AffectedFile.__init__(self, *args, **kwargs)
743 self._server_path = None
744 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000745
746 def ServerPath(self):
747 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000748 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000749 return self._server_path
750
751 def IsDirectory(self):
752 if self._is_directory is None:
753 path = self.AbsoluteLocalPath()
754 if os.path.exists(path):
755 # Retrieve directly from the file system; it is much faster than
756 # querying subversion, especially on Windows.
757 self._is_directory = os.path.isdir(path)
758 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000759 self._is_directory = False
760 return self._is_directory
761
762 def Property(self, property_name):
763 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000764 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000765 return self._properties[property_name]
766
767 def IsTextFile(self):
768 if self._is_text_file is None:
769 if self.Action() == 'D':
770 # A deleted file is not a text file.
771 self._is_text_file = False
772 elif self.IsDirectory():
773 self._is_text_file = False
774 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000775 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
776 return self._is_text_file
777
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000778
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000779class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000780 """Describe a change.
781
782 Used directly by the presubmit scripts to query the current change being
783 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000784
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000785 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000786 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000787 self.KEY: equivalent to tags['KEY']
788 """
789
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000790 _AFFECTED_FILES = AffectedFile
791
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000792 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000793 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000794 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000795 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000796
maruel@chromium.org58407af2011-04-12 23:15:57 +0000797 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000798 self, name, description, local_root, files, issue, patchset, author,
799 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000800 if files is None:
801 files = []
802 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000803 # Convert root into an absolute path.
804 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000805 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000806 self.issue = issue
807 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000808 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000810 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000811 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000812 self._description_without_tags = ''
813 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814
maruel@chromium.orge085d812011-10-10 19:49:15 +0000815 assert all(
816 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
817
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000818 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000819 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000820 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
821 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000822 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000823
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000824 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000825 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000826 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000827
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000828 def DescriptionText(self):
829 """Returns the user-entered changelist description, minus tags.
830
831 Any line in the user-provided description starting with e.g. "FOO="
832 (whitespace permitted before and around) is considered a tag line. Such
833 lines are stripped out of the description this function returns.
834 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000835 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000836
837 def FullDescriptionText(self):
838 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000839 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000840
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000841 def SetDescriptionText(self, description):
842 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000843
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000844 Also updates the list of tags."""
845 self._full_description = description
846
847 # From the description text, build up a dictionary of key/value pairs
848 # plus the description minus all key/value or "tag" lines.
849 description_without_tags = []
850 self.tags = {}
851 for line in self._full_description.splitlines():
852 m = self.TAG_LINE_RE.match(line)
853 if m:
854 self.tags[m.group('key')] = m.group('value')
855 else:
856 description_without_tags.append(line)
857
858 # Change back to text and remove whitespace at end.
859 self._description_without_tags = (
860 '\n'.join(description_without_tags).rstrip())
861
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000862 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000863 """Returns the repository (checkout) root directory for this change,
864 as an absolute path.
865 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000866 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000867
868 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000869 """Return tags directly as attributes on the object."""
870 if not re.match(r"^[A-Z_]*$", attr):
871 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000872 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000873
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000874 def AllFiles(self, root=None):
875 """List all files under source control in the repo."""
876 raise NotImplementedError()
877
sail@chromium.org5538e022011-05-12 17:53:16 +0000878 def AffectedFiles(self, include_dirs=False, include_deletes=True,
879 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880 """Returns a list of AffectedFile instances for all files in the change.
881
882 Args:
883 include_deletes: If false, deleted files will be filtered out.
884 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000885 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886
887 Returns:
888 [AffectedFile(path, action), AffectedFile(path, action)]
889 """
890 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000891 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000892 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000893 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894
sail@chromium.org5538e022011-05-12 17:53:16 +0000895 affected = filter(file_filter, affected)
896
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000897 if include_deletes:
898 return affected
899 else:
900 return filter(lambda x: x.Action() != 'D', affected)
901
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000902 def AffectedTextFiles(self, include_deletes=None):
903 """Return a list of the existing text files in a change."""
904 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000905 warn("AffectedTextFiles(include_deletes=%s)"
906 " is deprecated and ignored" % str(include_deletes),
907 category=DeprecationWarning,
908 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000909 return filter(lambda x: x.IsTextFile(),
910 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000911
912 def LocalPaths(self, include_dirs=False):
913 """Convenience function."""
914 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
915
916 def AbsoluteLocalPaths(self, include_dirs=False):
917 """Convenience function."""
918 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
919
920 def ServerPaths(self, include_dirs=False):
921 """Convenience function."""
922 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
923
924 def RightHandSideLines(self):
925 """An iterator over all text lines in "new" version of changed files.
926
927 Lists lines from new or modified text files in the change.
928
929 This is useful for doing line-by-line regex checks, like checking for
930 trailing whitespace.
931
932 Yields:
933 a 3 tuple:
934 the AffectedFile instance of the current file;
935 integer line number (1-based); and
936 the contents of the line as a string.
937 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000938 return _RightHandSideLinesImpl(
939 x for x in self.AffectedFiles(include_deletes=False)
940 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000941
942
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000943class SvnChange(Change):
944 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000945 scm = 'svn'
946 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000947
948 def _GetChangeLists(self):
949 """Get all change lists."""
950 if self._changelists == None:
951 previous_cwd = os.getcwd()
952 os.chdir(self.RepositoryRoot())
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000953 # Need to import here to avoid circular dependency.
954 import gcl
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000955 self._changelists = gcl.GetModifiedFiles()
956 os.chdir(previous_cwd)
957 return self._changelists
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000958
959 def GetAllModifiedFiles(self):
960 """Get all modified files."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000961 changelists = self._GetChangeLists()
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000962 all_modified_files = []
963 for cl in changelists.values():
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000964 all_modified_files.extend(
965 [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000966 return all_modified_files
967
968 def GetModifiedFiles(self):
969 """Get modified files in the current CL."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000970 changelists = self._GetChangeLists()
971 return [os.path.join(self.RepositoryRoot(), f[1])
972 for f in changelists[self.Name()]]
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000973
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000974 def AllFiles(self, root=None):
975 """List all files under source control in the repo."""
976 root = root or self.RepositoryRoot()
977 return subprocess.check_output(
978 ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
979
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000980
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000981class GitChange(Change):
982 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000983 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000984
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000985 def AllFiles(self, root=None):
986 """List all files under source control in the repo."""
987 root = root or self.RepositoryRoot()
988 return subprocess.check_output(
989 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
990
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000991
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000992def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000993 """Finds all presubmit files that apply to a given set of source files.
994
maruel@chromium.orgb1901a62010-06-16 00:18:47 +0000995 If inherit-review-settings-ok is present right under root, looks for
996 PRESUBMIT.py in directories enclosing root.
997
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998 Args:
999 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001000 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001
1002 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001003 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001004 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001005 files = [normpath(os.path.join(root, f)) for f in files]
1006
1007 # List all the individual directories containing files.
1008 directories = set([os.path.dirname(f) for f in files])
1009
1010 # Ignore root if inherit-review-settings-ok is present.
1011 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1012 root = None
1013
1014 # Collect all unique directories that may contain PRESUBMIT.py.
1015 candidates = set()
1016 for directory in directories:
1017 while True:
1018 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001019 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001020 candidates.add(directory)
1021 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001022 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001023 parent_dir = os.path.dirname(directory)
1024 if parent_dir == directory:
1025 # We hit the system root directory.
1026 break
1027 directory = parent_dir
1028
1029 # Look for PRESUBMIT.py in all candidate directories.
1030 results = []
1031 for directory in sorted(list(candidates)):
1032 p = os.path.join(directory, 'PRESUBMIT.py')
1033 if os.path.isfile(p):
1034 results.append(p)
1035
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001036 logging.debug('Presubmit files: %s' % ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001037 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001038
1039
thestig@chromium.orgde243452009-10-06 21:02:56 +00001040class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001041 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001042 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001043 """Executes GetPreferredTrySlaves() from a single presubmit script.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001044
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001045 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001046
1047 Args:
1048 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001049 presubmit_path: Project script to run.
1050 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001051
1052 Return:
1053 A list of try slaves.
1054 """
1055 context = {}
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001056 main_path = os.getcwd()
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001057 try:
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001058 os.chdir(os.path.dirname(presubmit_path))
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001059 exec script_text in context
1060 except Exception, e:
1061 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001062 finally:
1063 os.chdir(main_path)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001064
1065 function_name = 'GetPreferredTrySlaves'
1066 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001067 get_preferred_try_slaves = context[function_name]
1068 function_info = inspect.getargspec(get_preferred_try_slaves)
1069 if len(function_info[0]) == 1:
1070 result = get_preferred_try_slaves(project)
1071 elif len(function_info[0]) == 2:
1072 result = get_preferred_try_slaves(project, change)
1073 else:
1074 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001075 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001076 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001077 'Presubmit functions must return a list, got a %s instead: %s' %
1078 (type(result), str(result)))
1079 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001080 if isinstance(item, basestring):
1081 # Old-style ['bot'] format.
1082 botname = item
1083 elif isinstance(item, tuple):
1084 # New-style [('bot', set(['tests']))] format.
1085 botname = item[0]
1086 else:
1087 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1088 ' format.')
1089
1090 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001091 raise PresubmitFailure(
1092 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001093 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001094 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001095 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001096 else:
1097 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001098
1099 def valid_oldstyle(result):
1100 return all(isinstance(i, basestring) for i in result)
1101
1102 def valid_newstyle(result):
1103 return (all(isinstance(i, tuple) for i in result) and
1104 all(len(i) == 2 for i in result) and
1105 all(isinstance(i[0], basestring) for i in result) and
1106 all(isinstance(i[1], set) for i in result)
1107 )
1108
1109 # Ensure it's either all old-style or all new-style.
1110 if not valid_oldstyle(result) and not valid_newstyle(result):
1111 raise PresubmitFailure(
1112 'PRESUBMIT.py returned invalid trybot specification!')
1113
thestig@chromium.orgde243452009-10-06 21:02:56 +00001114 return result
1115
1116
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001117class GetTryMastersExecuter(object):
1118 @staticmethod
1119 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1120 """Executes GetPreferredTryMasters() from a single presubmit script.
1121
1122 Args:
1123 script_text: The text of the presubmit script.
1124 presubmit_path: Project script to run.
1125 project: Project name to pass to presubmit script for bot selection.
1126
1127 Return:
1128 A map of try masters to map of builders to set of tests.
1129 """
1130 context = {}
1131 try:
1132 exec script_text in context
1133 except Exception, e:
1134 raise PresubmitFailure('"%s" had an exception.\n%s'
1135 % (presubmit_path, e))
1136
1137 function_name = 'GetPreferredTryMasters'
1138 if function_name not in context:
1139 return {}
1140 get_preferred_try_masters = context[function_name]
1141 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1142 raise PresubmitFailure(
1143 'Expected function "GetPreferredTryMasters" to take two arguments.')
1144 return get_preferred_try_masters(project, change)
1145
1146
rmistry@google.com5626a922015-02-26 14:03:30 +00001147class GetPostUploadExecuter(object):
1148 @staticmethod
1149 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1150 """Executes PostUploadHook() from a single presubmit script.
1151
1152 Args:
1153 script_text: The text of the presubmit script.
1154 presubmit_path: Project script to run.
1155 cl: The Changelist object.
1156 change: The Change object.
1157
1158 Return:
1159 A list of results objects.
1160 """
1161 context = {}
1162 try:
1163 exec script_text in context
1164 except Exception, e:
1165 raise PresubmitFailure('"%s" had an exception.\n%s'
1166 % (presubmit_path, e))
1167
1168 function_name = 'PostUploadHook'
1169 if function_name not in context:
1170 return {}
1171 post_upload_hook = context[function_name]
1172 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1173 raise PresubmitFailure(
1174 'Expected function "PostUploadHook" to take three arguments.')
1175 return post_upload_hook(cl, change, OutputApi(False))
1176
1177
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001178def DoGetTrySlaves(change,
1179 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001180 repository_root,
1181 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001182 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001183 verbose,
1184 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001185 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001186
1187 Args:
1188 changed_files: List of modified files.
1189 repository_root: The repository root.
1190 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001191 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001192 verbose: Prints debug info.
1193 output_stream: A stream to write debug output to.
1194
1195 Return:
1196 List of try slaves
1197 """
1198 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1199 if not presubmit_files and verbose:
mdempsky@chromium.orgd59e7612014-03-05 19:55:56 +00001200 output_stream.write("Warning, no PRESUBMIT.py found.\n")
thestig@chromium.orgde243452009-10-06 21:02:56 +00001201 results = []
1202 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001203
thestig@chromium.orgde243452009-10-06 21:02:56 +00001204 if default_presubmit:
1205 if verbose:
1206 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001207 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001208 results.extend(executer.ExecPresubmitScript(
1209 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001210 for filename in presubmit_files:
1211 filename = os.path.abspath(filename)
1212 if verbose:
1213 output_stream.write("Running %s\n" % filename)
1214 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001215 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001216 results.extend(executer.ExecPresubmitScript(
1217 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001218
stip@chromium.org5ca27622013-12-18 17:44:58 +00001219
1220 slave_dict = {}
1221 old_style = filter(lambda x: isinstance(x, basestring), results)
1222 new_style = filter(lambda x: isinstance(x, tuple), results)
1223
1224 for result in new_style:
1225 slave_dict.setdefault(result[0], set()).update(result[1])
1226 slaves = list(slave_dict.items())
1227
1228 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001229
thestig@chromium.orgde243452009-10-06 21:02:56 +00001230 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001231 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001232 output_stream.write('\n')
1233 return slaves
1234
1235
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001236def _MergeMasters(masters1, masters2):
1237 """Merges two master maps. Merges also the tests of each builder."""
1238 result = {}
1239 for (master, builders) in itertools.chain(masters1.iteritems(),
1240 masters2.iteritems()):
1241 new_builders = result.setdefault(master, {})
1242 for (builder, tests) in builders.iteritems():
1243 new_builders.setdefault(builder, set([])).update(tests)
1244 return result
1245
1246
1247def DoGetTryMasters(change,
1248 changed_files,
1249 repository_root,
1250 default_presubmit,
1251 project,
1252 verbose,
1253 output_stream):
1254 """Get the list of try masters from the presubmit scripts.
1255
1256 Args:
1257 changed_files: List of modified files.
1258 repository_root: The repository root.
1259 default_presubmit: A default presubmit script to execute in any case.
1260 project: Optional name of a project used in selecting trybots.
1261 verbose: Prints debug info.
1262 output_stream: A stream to write debug output to.
1263
1264 Return:
1265 Map of try masters to map of builders to set of tests.
1266 """
1267 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1268 if not presubmit_files and verbose:
1269 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1270 results = {}
1271 executer = GetTryMastersExecuter()
1272
1273 if default_presubmit:
1274 if verbose:
1275 output_stream.write("Running default presubmit script.\n")
1276 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1277 results = _MergeMasters(results, executer.ExecPresubmitScript(
1278 default_presubmit, fake_path, project, change))
1279 for filename in presubmit_files:
1280 filename = os.path.abspath(filename)
1281 if verbose:
1282 output_stream.write("Running %s\n" % filename)
1283 # Accept CRLF presubmit script.
1284 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1285 results = _MergeMasters(results, executer.ExecPresubmitScript(
1286 presubmit_script, filename, project, change))
1287
1288 # Make sets to lists again for later JSON serialization.
1289 for builders in results.itervalues():
1290 for builder in builders:
1291 builders[builder] = list(builders[builder])
1292
1293 if results and verbose:
1294 output_stream.write('%s\n' % str(results))
1295 return results
1296
1297
rmistry@google.com5626a922015-02-26 14:03:30 +00001298def DoPostUploadExecuter(change,
1299 cl,
1300 repository_root,
1301 verbose,
1302 output_stream):
1303 """Execute the post upload hook.
1304
1305 Args:
1306 change: The Change object.
1307 cl: The Changelist object.
1308 repository_root: The repository root.
1309 verbose: Prints debug info.
1310 output_stream: A stream to write debug output to.
1311 """
1312 presubmit_files = ListRelevantPresubmitFiles(
1313 change.LocalPaths(), repository_root)
1314 if not presubmit_files and verbose:
1315 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1316 results = []
1317 executer = GetPostUploadExecuter()
1318 # The root presubmit file should be executed after the ones in subdirectories.
1319 # i.e. the specific post upload hooks should run before the general ones.
1320 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1321 presubmit_files.reverse()
1322
1323 for filename in presubmit_files:
1324 filename = os.path.abspath(filename)
1325 if verbose:
1326 output_stream.write("Running %s\n" % filename)
1327 # Accept CRLF presubmit script.
1328 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1329 results.extend(executer.ExecPresubmitScript(
1330 presubmit_script, filename, cl, change))
1331 output_stream.write('\n')
1332 if results:
1333 output_stream.write('** Post Upload Hook Messages **\n')
1334 for result in results:
1335 result.handle(output_stream)
1336 output_stream.write('\n')
1337
1338 return results
1339
1340
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001341class PresubmitExecuter(object):
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001342 def __init__(self, change, committing, rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001343 """
1344 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001345 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001346 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001347 rietveld_obj: rietveld.Rietveld client object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001348 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001349 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001350 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001351 self.rietveld = rietveld_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001352 self.verbose = verbose
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001353
1354 def ExecPresubmitScript(self, script_text, presubmit_path):
1355 """Executes a single presubmit script.
1356
1357 Args:
1358 script_text: The text of the presubmit script.
1359 presubmit_path: The path to the presubmit file (this will be reported via
1360 input_api.PresubmitLocalPath()).
1361
1362 Return:
1363 A list of result objects, empty if no problems.
1364 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001365
chase@chromium.org8e416c82009-10-06 04:30:44 +00001366 # Change to the presubmit file's directory to support local imports.
1367 main_path = os.getcwd()
1368 os.chdir(os.path.dirname(presubmit_path))
1369
1370 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001371 input_api = InputApi(self.change, presubmit_path, self.committing,
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001372 self.rietveld, self.verbose)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001373 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001374 try:
1375 exec script_text in context
1376 except Exception, e:
1377 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001378
1379 # These function names must change if we make substantial changes to
1380 # the presubmit API that are not backwards compatible.
1381 if self.committing:
1382 function_name = 'CheckChangeOnCommit'
1383 else:
1384 function_name = 'CheckChangeOnUpload'
1385 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001386 context['__args'] = (input_api, OutputApi(self.committing))
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001387 logging.debug('Running %s in %s' % (function_name, presubmit_path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001388 result = eval(function_name + '(*__args)', context)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001389 logging.debug('Running %s done.' % function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001390 if not (isinstance(result, types.TupleType) or
1391 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001392 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001393 'Presubmit functions must return a tuple or list')
1394 for item in result:
1395 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001396 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001397 'All presubmit results must be of types derived from '
1398 'output_api.PresubmitResult')
1399 else:
1400 result = () # no error since the script doesn't care about current event.
1401
chase@chromium.org8e416c82009-10-06 04:30:44 +00001402 # Return the process to the original working directory.
1403 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001404 return result
1405
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001406
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001407def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001408 committing,
1409 verbose,
1410 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001411 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001412 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001413 may_prompt,
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001414 rietveld_obj):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001415 """Runs all presubmit checks that apply to the files in the change.
1416
1417 This finds all PRESUBMIT.py files in directories enclosing the files in the
1418 change (up to the repository root) and calls the relevant entrypoint function
1419 depending on whether the change is being committed or uploaded.
1420
1421 Prints errors, warnings and notifications. Prompts the user for warnings
1422 when needed.
1423
1424 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001425 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001426 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
1427 verbose: Prints debug info.
1428 output_stream: A stream to write output from presubmit tests to.
1429 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001430 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001431 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001432 rietveld_obj: rietveld.Rietveld object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001433
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001434 Warning:
1435 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1436 SHOULD be sys.stdin.
1437
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001438 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001439 A PresubmitOutput object. Use output.should_continue() to figure out
1440 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001441 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001442 old_environ = os.environ
1443 try:
1444 # Make sure python subprocesses won't generate .pyc files.
1445 os.environ = os.environ.copy()
1446 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001447
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001448 output = PresubmitOutput(input_stream, output_stream)
1449 if committing:
1450 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001451 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001452 output.write("Running presubmit upload checks ...\n")
1453 start_time = time.time()
1454 presubmit_files = ListRelevantPresubmitFiles(
1455 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1456 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001457 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001458 results = []
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001459 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001460 if default_presubmit:
1461 if verbose:
1462 output.write("Running default presubmit script.\n")
1463 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1464 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1465 for filename in presubmit_files:
1466 filename = os.path.abspath(filename)
1467 if verbose:
1468 output.write("Running %s\n" % filename)
1469 # Accept CRLF presubmit script.
1470 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1471 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001472
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001473 errors = []
1474 notifications = []
1475 warnings = []
1476 for result in results:
1477 if result.fatal:
1478 errors.append(result)
1479 elif result.should_prompt:
1480 warnings.append(result)
1481 else:
1482 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001483
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001484 output.write('\n')
1485 for name, items in (('Messages', notifications),
1486 ('Warnings', warnings),
1487 ('ERRORS', errors)):
1488 if items:
1489 output.write('** Presubmit %s **\n' % name)
1490 for item in items:
1491 item.handle(output)
1492 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001493
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001494 total_time = time.time() - start_time
1495 if total_time > 1.0:
1496 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001497
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001498 if not errors:
1499 if not warnings:
1500 output.write('Presubmit checks passed.\n')
1501 elif may_prompt:
1502 output.prompt_yes_no('There were presubmit warnings. '
1503 'Are you sure you wish to continue? (y/N): ')
1504 else:
1505 output.fail()
1506
1507 global _ASKED_FOR_FEEDBACK
1508 # Ask for feedback one time out of 5.
1509 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001510 output.write(
1511 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1512 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1513 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001514 _ASKED_FOR_FEEDBACK = True
1515 return output
1516 finally:
1517 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518
1519
1520def ScanSubDirs(mask, recursive):
1521 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001522 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523 else:
1524 results = []
1525 for root, dirs, files in os.walk('.'):
1526 if '.svn' in dirs:
1527 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001528 if '.git' in dirs:
1529 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001530 for name in files:
1531 if fnmatch.fnmatch(name, mask):
1532 results.append(os.path.join(root, name))
1533 return results
1534
1535
1536def ParseFiles(args, recursive):
maruel@chromium.org7444c502011-02-09 14:02:11 +00001537 logging.debug('Searching for %s' % args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538 files = []
1539 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001540 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541 return files
1542
1543
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001544def load_files(options, args):
1545 """Tries to determine the SCM."""
1546 change_scm = scm.determine_scm(options.root)
1547 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001548 if args:
1549 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001550 if change_scm == 'svn':
1551 change_class = SvnChange
1552 if not files:
1553 files = scm.SVN.CaptureStatus([], options.root)
1554 elif change_scm == 'git':
1555 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001556 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001557 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001558 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001559 else:
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001560 logging.info('Doesn\'t seem under source control. Got %d files' % len(args))
1561 if not files:
1562 return None, None
1563 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001564 return change_class, files
1565
1566
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001567class NonexistantCannedCheckFilter(Exception):
1568 pass
1569
1570
1571@contextlib.contextmanager
1572def canned_check_filter(method_names):
1573 filtered = {}
1574 try:
1575 for method_name in method_names:
1576 if not hasattr(presubmit_canned_checks, method_name):
1577 raise NonexistantCannedCheckFilter(method_name)
1578 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1579 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1580 yield
1581 finally:
1582 for name, method in filtered.iteritems():
1583 setattr(presubmit_canned_checks, name, method)
1584
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001585
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001586def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001587 """Runs an external program, potentially from a child process created by the
1588 multiprocessing module.
1589
1590 multiprocessing needs a top level function with a single argument.
1591 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001592 cmd_data.kwargs['stdout'] = subprocess.PIPE
1593 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1594 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001595 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001596 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001597 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001598 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001599 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001600 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001601 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1602 if code != 0:
1603 return cmd_data.message(
1604 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1605 if cmd_data.info:
1606 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001607
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001608
sbc@chromium.org013731e2015-02-26 18:28:43 +00001609def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001610 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001611 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001612 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001613 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001614 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1615 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001616 parser.add_option("-r", "--recursive", action="store_true",
1617 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001618 parser.add_option("-v", "--verbose", action="count", default=0,
1619 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001620 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001621 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001622 parser.add_option("--description", default='')
1623 parser.add_option("--issue", type='int', default=0)
1624 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001625 parser.add_option("--root", default=os.getcwd(),
1626 help="Search for PRESUBMIT.py up to this directory. "
1627 "If inherit-review-settings-ok is present in this "
1628 "directory, parent directories up to the root file "
1629 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001630 parser.add_option("--upstream",
1631 help="Git only: the base ref or upstream branch against "
1632 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001633 parser.add_option("--default_presubmit")
1634 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001635 parser.add_option("--skip_canned", action='append', default=[],
1636 help="A list of checks to skip which appear in "
1637 "presubmit_canned_checks. Can be provided multiple times "
1638 "to skip multiple canned checks.")
maruel@chromium.org239f4112011-06-03 20:08:23 +00001639 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1640 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001641 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1642 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001643 # These are for OAuth2 authentication for bots. See also apply_issue.py
1644 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1645 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1646
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001647 parser.add_option("--trybot-json",
1648 help="Output trybot information to the file specified.")
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001649 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001650 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001651 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001652
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001653 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001654 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001655 elif options.verbose:
1656 logging.basicConfig(level=logging.INFO)
1657 else:
1658 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001659
1660 if options.rietveld_email and options.rietveld_email_file:
1661 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1662 "can be passed to this program.")
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001663
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001664 if options.rietveld_email_file:
1665 with open(options.rietveld_email_file, "rb") as f:
1666 options.rietveld_email = f.read().strip()
1667
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001668 change_class, files = load_files(options, args)
1669 if not change_class:
1670 parser.error('For unversioned directory, <files> is not optional.')
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001671 logging.info('Found %d file(s).' % len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001672
maruel@chromium.org239f4112011-06-03 20:08:23 +00001673 rietveld_obj = None
1674 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001675 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001676 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001677 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1678 options.rietveld_url,
1679 options.rietveld_email,
1680 options.rietveld_private_key_file)
1681 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001682 rietveld_obj = rietveld.CachingRietveld(
1683 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001684 auth_config,
1685 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001686 if options.rietveld_fetch:
1687 assert options.issue
1688 props = rietveld_obj.get_issue_properties(options.issue, False)
1689 options.author = props['owner_email']
1690 options.description = props['description']
1691 logging.info('Got author: "%s"', options.author)
1692 logging.info('Got description: """\n%s\n"""', options.description)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001693 if options.trybot_json:
1694 with open(options.trybot_json, 'w') as f:
1695 # Python's sets aren't JSON-encodable, so we convert them to lists here.
1696 class SetEncoder(json.JSONEncoder):
1697 # pylint: disable=E0202
1698 def default(self, obj):
1699 if isinstance(obj, set):
1700 return sorted(obj)
1701 return json.JSONEncoder.default(self, obj)
1702 change = change_class(options.name,
1703 options.description,
1704 options.root,
1705 files,
1706 options.issue,
1707 options.patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001708 options.author,
1709 upstream=options.upstream)
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001710 trybots = DoGetTrySlaves(
1711 change,
1712 change.LocalPaths(),
1713 change.RepositoryRoot(),
1714 None,
1715 None,
1716 options.verbose,
1717 sys.stdout)
1718 json.dump(trybots, f, cls=SetEncoder)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001719 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001720 with canned_check_filter(options.skip_canned):
1721 results = DoPresubmitChecks(
1722 change_class(options.name,
1723 options.description,
1724 options.root,
1725 files,
1726 options.issue,
1727 options.patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001728 options.author,
1729 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001730 options.commit,
1731 options.verbose,
1732 sys.stdout,
1733 sys.stdin,
1734 options.default_presubmit,
1735 options.may_prompt,
1736 rietveld_obj)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001737 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001738 except NonexistantCannedCheckFilter, e:
1739 print >> sys.stderr, (
1740 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1741 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001742 except PresubmitFailure, e:
1743 print >> sys.stderr, e
1744 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1745 print >> sys.stderr, 'If all fails, contact maruel@'
1746 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001747
1748
1749if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001750 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001751 try:
1752 sys.exit(main())
1753 except KeyboardInterrupt:
1754 sys.stderr.write('interrupted\n')
1755 sys.exit(1)