chrisha@chromium.org | c920ad2 | 2012-02-02 18:26:04 +0000 | [diff] [blame] | 1 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """Top-level presubmit script for depot tools. |
| 6 | |
| 7 | See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 8 | details on the presubmit API built into depot_tools. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 9 | """ |
| 10 | |
dpranke@chromium.org | 627ea67 | 2011-03-11 23:29:03 +0000 | [diff] [blame] | 11 | |
maruel@chromium.org | d52417c | 2011-09-02 20:13:17 +0000 | [diff] [blame] | 12 | def CommonChecks(input_api, output_api, tests_to_black_list): |
maruel@chromium.org | 3c9f7ca | 2011-04-01 14:52:38 +0000 | [diff] [blame] | 13 | results = [] |
maruel@chromium.org | 3c9f7ca | 2011-04-01 14:52:38 +0000 | [diff] [blame] | 14 | results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) |
maruel@chromium.org | bf38a7e | 2010-12-14 18:15:54 +0000 | [diff] [blame] | 15 | black_list = list(input_api.DEFAULT_BLACK_LIST) + [ |
maruel@chromium.org | 5d0dc43 | 2011-01-03 02:40:37 +0000 | [diff] [blame] | 16 | r'^cpplint\.py$', |
asvitkine@chromium.org | 63c2c1d | 2011-09-07 21:41:55 +0000 | [diff] [blame] | 17 | r'^cpplint_chromium\.py$', |
bratell@opera.com | 154c36c | 2013-12-12 14:13:44 +0000 | [diff] [blame^] | 18 | r'^python[0-9]*_bin[\/\\].+', |
chrisha@chromium.org | c920ad2 | 2012-02-02 18:26:04 +0000 | [diff] [blame] | 19 | r'^site-packages-py[0-9]\.[0-9][\/\\].+', |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 20 | r'^svn_bin[\/\\].+', |
maruel@chromium.org | 0927b7e | 2011-11-11 16:06:22 +0000 | [diff] [blame] | 21 | r'^testing_support[\/\\]_rietveld[\/\\].+'] |
maruel@chromium.org | ff9a217 | 2012-04-24 16:55:32 +0000 | [diff] [blame] | 22 | disabled_warnings = [ |
| 23 | 'R0401', # Cyclic import |
| 24 | 'W0613', # Unused argument |
| 25 | ] |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 26 | results.extend(input_api.RunTests( |
| 27 | input_api.canned_checks.GetPylint( |
| 28 | input_api, |
| 29 | output_api, |
| 30 | white_list=[r'.*\.py$'], |
| 31 | black_list=black_list, |
| 32 | disabled_warnings=disabled_warnings) + |
| 33 | # TODO(maruel): Make sure at least one file is modified first. |
| 34 | # TODO(maruel): If only tests are modified, only run them. |
| 35 | input_api.canned_checks.GetUnitTestsInDirectory( |
| 36 | input_api, |
| 37 | output_api, |
| 38 | 'tests', |
| 39 | whitelist=[r'.*test\.py$'], |
| 40 | blacklist=tests_to_black_list))) |
maruel@chromium.org | 3c9f7ca | 2011-04-01 14:52:38 +0000 | [diff] [blame] | 41 | return results |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 42 | |
| 43 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 44 | def RunGitClTests(input_api, output_api): |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 45 | """Run all the shells scripts in the directory test. |
| 46 | """ |
maruel@chromium.org | c98c0c5 | 2011-04-06 13:39:43 +0000 | [diff] [blame] | 47 | if input_api.platform == 'win32': |
| 48 | # Skip for now as long as the test scripts are bash scripts. |
| 49 | return [] |
| 50 | |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 51 | # First loads a local Rietveld instance. |
| 52 | import sys |
| 53 | old_sys_path = sys.path |
| 54 | try: |
| 55 | sys.path = [input_api.PresubmitLocalPath()] + sys.path |
maruel@chromium.org | 0927b7e | 2011-11-11 16:06:22 +0000 | [diff] [blame] | 56 | from testing_support import local_rietveld |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 57 | server = local_rietveld.LocalRietveld() |
| 58 | finally: |
| 59 | sys.path = old_sys_path |
| 60 | |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 61 | results = [] |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 62 | try: |
| 63 | # Start a local rietveld instance to test against. |
| 64 | server.start_server() |
| 65 | test_path = input_api.os_path.abspath( |
| 66 | input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests')) |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 67 | for test in input_api.os_listdir(test_path): |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 68 | # test-lib.sh is not an actual test so it should not be run. The other |
| 69 | # tests are tests known to fail. |
| 70 | DISABLED_TESTS = ( |
| 71 | 'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh') |
| 72 | if test in DISABLED_TESTS or not test.endswith('.sh'): |
| 73 | continue |
| 74 | |
| 75 | print('Running %s' % test) |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 76 | try: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 77 | if input_api.verbose: |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 78 | input_api.subprocess.check_call( |
| 79 | [input_api.os_path.join(test_path, test)], cwd=test_path) |
| 80 | else: |
| 81 | input_api.subprocess.check_output( |
maruel@chromium.org | 87e6d33 | 2011-09-09 19:01:28 +0000 | [diff] [blame] | 82 | [input_api.os_path.join(test_path, test)], cwd=test_path, |
| 83 | stderr=input_api.subprocess.STDOUT) |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 84 | except (OSError, input_api.subprocess.CalledProcessError), e: |
| 85 | results.append(output_api.PresubmitError('%s failed\n%s' % (test, e))) |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 86 | except local_rietveld.Failure, e: |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 87 | results.append(output_api.PresubmitError('\n'.join(str(i) for i in e.args))) |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 88 | finally: |
| 89 | server.stop_server() |
maruel@chromium.org | ccbb781 | 2011-04-06 13:36:23 +0000 | [diff] [blame] | 90 | return results |
maruel@chromium.org | ce30ef7 | 2009-05-25 15:20:42 +0000 | [diff] [blame] | 91 | |
| 92 | |
maruel@chromium.org | e94aedc | 2010-12-13 21:11:30 +0000 | [diff] [blame] | 93 | def CheckChangeOnUpload(input_api, output_api): |
maruel@chromium.org | d52417c | 2011-09-02 20:13:17 +0000 | [diff] [blame] | 94 | # Do not run integration tests on upload since they are way too slow. |
| 95 | tests_to_black_list = [ |
| 96 | r'^checkout_test\.py$', |
| 97 | r'^gclient_smoketest\.py$', |
| 98 | r'^scm_unittest\.py$', |
ilevy@chromium.org | 5856562 | 2013-03-17 23:18:37 +0000 | [diff] [blame] | 99 | r'^subprocess2_test\.py$', |
maruel@chromium.org | d52417c | 2011-09-02 20:13:17 +0000 | [diff] [blame] | 100 | ] |
| 101 | return CommonChecks(input_api, output_api, tests_to_black_list) |
maruel@chromium.org | e94aedc | 2010-12-13 21:11:30 +0000 | [diff] [blame] | 102 | |
| 103 | |
maruel@chromium.org | ce30ef7 | 2009-05-25 15:20:42 +0000 | [diff] [blame] | 104 | def CheckChangeOnCommit(input_api, output_api): |
| 105 | output = [] |
maruel@chromium.org | d52417c | 2011-09-02 20:13:17 +0000 | [diff] [blame] | 106 | output.extend(CommonChecks(input_api, output_api, [])) |
maruel@chromium.org | e94aedc | 2010-12-13 21:11:30 +0000 | [diff] [blame] | 107 | output.extend(input_api.canned_checks.CheckDoNotSubmit( |
| 108 | input_api, |
| 109 | output_api)) |
maruel@chromium.org | d52417c | 2011-09-02 20:13:17 +0000 | [diff] [blame] | 110 | output.extend(RunGitClTests(input_api, output_api)) |
maruel@chromium.org | 7b305e8 | 2009-05-19 18:24:20 +0000 | [diff] [blame] | 111 | return output |