blob: 343320fbc90e2e15a26569f177ebd48244b0b172 [file] [log] [blame]
chase@chromium.orgb9a98322010-12-23 22:32:45 +00001# Copyright (c) 2010 The Chromium Authors. All rights reserved.
maruel@chromium.org3d235242009-05-15 12:40:48 +00002# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Top-level presubmit script for depot tools.
6
7See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8details on the presubmit API built into gcl.
9"""
10
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000011UNIT_TESTS = [
12 'tests.gcl_unittest',
maruel@chromium.orgad80e3b2010-09-09 14:18:28 +000013 'tests.gclient_scm_test',
maruel@chromium.org888b8352010-08-11 18:42:03 +000014 'tests.gclient_smoketest',
maruel@chromium.orgd5800f12009-11-12 20:03:43 +000015 'tests.gclient_utils_test',
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000016 'tests.presubmit_unittest',
maruel@chromium.orgd5800f12009-11-12 20:03:43 +000017 'tests.scm_unittest',
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000018 'tests.trychange_unittest',
nirnimesh@chromium.orgb82e4092009-06-18 14:24:08 +000019 'tests.watchlists_unittest',
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000020]
maruel@chromium.org3d235242009-05-15 12:40:48 +000021
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000022def CommonChecks(input_api, output_api):
maruel@chromium.org7b305e82009-05-19 18:24:20 +000023 output = []
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000024 # Verify that LocalPath() is local, e.g.:
25 # os.path.join(PresubmitLocalPath(), LocalPath()) == AbsoluteLocalPath()
26 for i in input_api.AffectedFiles():
27 if (input_api.os_path.join(input_api.PresubmitLocalPath(), i.LocalPath()) !=
28 i.AbsoluteLocalPath()):
29 output.append(output_api.PresubmitError('Path inconsistency'))
30 # Return right away because it needs to be fixed first.
31 return output
32
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000033 output.extend(input_api.canned_checks.RunPythonUnitTests(
34 input_api,
35 output_api,
36 UNIT_TESTS))
maruel@chromium.orgbbfc80f2010-06-22 17:55:15 +000037 output.extend(WasGitClUploadHookModified(input_api, output_api))
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000038
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000039 white_list = [r'.*\.py$', r'^git-try$']
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000040 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000041 r'^cpplint\.py$',
42 r'^git_cl[\/\\].*',
43 r'^git_cl_repo[\/\\].*',
44 r'^git_cl[\/\\]test[\/\\]rietveld.*']
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000045 output.extend(input_api.canned_checks.RunPylint(
46 input_api,
47 output_api,
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000048 white_list=white_list,
49 black_list=black_list))
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000050 return output
51
52
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000053def CheckChangeOnUpload(input_api, output_api):
54 return CommonChecks(input_api, output_api)
55
56
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000057def CheckChangeOnCommit(input_api, output_api):
58 output = []
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000059 output.extend(CommonChecks(input_api, output_api))
60 output.extend(input_api.canned_checks.CheckDoNotSubmit(
61 input_api,
62 output_api))
maruel@chromium.org7b305e82009-05-19 18:24:20 +000063 return output
maruel@chromium.orgbbfc80f2010-06-22 17:55:15 +000064
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000065
maruel@chromium.orgbbfc80f2010-06-22 17:55:15 +000066def WasGitClUploadHookModified(input_api, output_api):
67 for affected_file in input_api.AffectedSourceFiles(None):
68 if (input_api.os_path.basename(affected_file.LocalPath()) ==
69 'git-cl-upload-hook'):
70 return [output_api.PresubmitPromptWarning(
71 'Don\'t forget to fix git-cl to download the newest version of '
72 'git-cl-upload-hook')]
73 return []