blob: c09f69ad694e265e92833679235026831918f824 [file] [log] [blame]
maruel@chromium.org2a74d372011-03-29 19:05:50 +00001# Copyright (c) 2011 The Chromium Authors. All rights reserved.
maruel@chromium.org3d235242009-05-15 12:40:48 +00002# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Top-level presubmit script for depot tools.
6
7See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
maruel@chromium.org2a74d372011-03-29 19:05:50 +00008details on the presubmit API built into depot_tools.
maruel@chromium.org3d235242009-05-15 12:40:48 +00009"""
10
dpranke@chromium.org627ea672011-03-11 23:29:03 +000011
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000012def CommonChecks(input_api, output_api):
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000013 results = []
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000014
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000015 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000016 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000017 r'^cpplint\.py$',
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000018 r'^tests[\/\\]\w+?[\/\\].+']
19 results.extend(input_api.canned_checks.RunPylint(
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000020 input_api,
21 output_api,
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000022 white_list=[r'.*\.py$', r'^git-try$'],
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000023 black_list=black_list))
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000024
25 # TODO(maruel): Make sure at least one file is modified first.
26 # TODO(maruel): If only tests are modified, only run them.
27 verbose = False
28 results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
29 input_api,
30 output_api,
31 'tests',
32 whitelist=[r'.*test\.py$'],
33 verbose=verbose))
34 results.extend(RunGitClTests(input_api, output_api))
35 return results
maruel@chromium.org2a74d372011-03-29 19:05:50 +000036
37
38def RunGitClTests(input_api, output_api):
39 """Run all the shells scripts in the directory test.
40 """
41 # Not exposed from InputApi.
42 from os import listdir
43
44 # First loads a local Rietveld instance.
45 import sys
46 old_sys_path = sys.path
47 try:
48 sys.path = [input_api.PresubmitLocalPath()] + sys.path
49 from tests import local_rietveld # pylint: disable=W0403
50 server = local_rietveld.LocalRietveld()
51 finally:
52 sys.path = old_sys_path
53
54 # Set to True for testing.
55 verbose = False
56 if verbose:
57 stdout = None
58 stderr = None
59 else:
60 stdout = input_api.subprocess.PIPE
61 stderr = input_api.subprocess.STDOUT
62 output = []
63 try:
64 # Start a local rietveld instance to test against.
65 server.start_server()
66 test_path = input_api.os_path.abspath(
67 input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'))
68 for test in listdir(test_path):
69 # test-lib.sh is not an actual test so it should not be run. The other
70 # tests are tests known to fail.
71 DISABLED_TESTS = (
72 'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
73 if test in DISABLED_TESTS or not test.endswith('.sh'):
74 continue
75
76 print('Running %s' % test)
77 proc = input_api.subprocess.Popen(
78 [input_api.os_path.join(test_path, test)],
79 cwd=test_path,
80 stdout=stdout,
81 stderr=stderr)
82 proc.communicate()
83 if proc.returncode != 0:
84 output.append(output_api.PresubmitError('%s failed' % test))
85 except local_rietveld.Failure, e:
86 output.append(output_api.PresubmitError('\n'.join(str(i) for i in e.args)))
87 finally:
88 server.stop_server()
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000089 return output
90
91
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000092def CheckChangeOnUpload(input_api, output_api):
93 return CommonChecks(input_api, output_api)
94
95
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000096def CheckChangeOnCommit(input_api, output_api):
97 output = []
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000098 output.extend(CommonChecks(input_api, output_api))
99 output.extend(input_api.canned_checks.CheckDoNotSubmit(
100 input_api,
101 output_api))
maruel@chromium.org7b305e82009-05-19 18:24:20 +0000102 return output