blob: 30ef7a943a431b926a37fdf717dc934903f6e866 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
dcheng091b7db2016-06-16 01:27:51 -070019import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000020import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000039import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000040from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041
42# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000043import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000045import gclient_utils
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000049import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
53
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000054# Ask for feedback only once in program lifetime.
55_ASKED_FOR_FEEDBACK = False
56
57
maruel@chromium.org899e1c12011-04-07 17:03:18 +000058class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000059 pass
60
61
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000062class CommandData(object):
63 def __init__(self, name, cmd, kwargs, message):
64 self.name = name
65 self.cmd = cmd
66 self.kwargs = kwargs
67 self.message = message
68 self.info = None
69
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000070
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000071def normpath(path):
72 '''Version of os.path.normpath that also changes backward slashes to
73 forward slashes when not running on Windows.
74 '''
75 # This is safe to always do because the Windows version of os.path.normpath
76 # will replace forward slashes with backward slashes.
77 path = path.replace(os.sep, '/')
78 return os.path.normpath(path)
79
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000080
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000081def _RightHandSideLinesImpl(affected_files):
82 """Implements RightHandSideLines for InputApi and GclChange."""
83 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000084 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000085 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000086 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000087
88
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000089class PresubmitOutput(object):
90 def __init__(self, input_stream=None, output_stream=None):
91 self.input_stream = input_stream
92 self.output_stream = output_stream
93 self.reviewers = []
94 self.written_output = []
95 self.error_count = 0
96
97 def prompt_yes_no(self, prompt_string):
98 self.write(prompt_string)
99 if self.input_stream:
100 response = self.input_stream.readline().strip().lower()
101 if response not in ('y', 'yes'):
102 self.fail()
103 else:
104 self.fail()
105
106 def fail(self):
107 self.error_count += 1
108
109 def should_continue(self):
110 return not self.error_count
111
112 def write(self, s):
113 self.written_output.append(s)
114 if self.output_stream:
115 self.output_stream.write(s)
116
117 def getvalue(self):
118 return ''.join(self.written_output)
119
120
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000121# Top level object so multiprocessing can pickle
122# Public access through OutputApi object.
123class _PresubmitResult(object):
124 """Base class for result objects."""
125 fatal = False
126 should_prompt = False
127
128 def __init__(self, message, items=None, long_text=''):
129 """
130 message: A short one-line message to indicate errors.
131 items: A list of short strings to indicate where errors occurred.
132 long_text: multi-line text output, e.g. from another tool
133 """
134 self._message = message
135 self._items = items or []
136 if items:
137 self._items = items
138 self._long_text = long_text.rstrip()
139
140 def handle(self, output):
141 output.write(self._message)
142 output.write('\n')
143 for index, item in enumerate(self._items):
144 output.write(' ')
145 # Write separately in case it's unicode.
146 output.write(str(item))
147 if index < len(self._items) - 1:
148 output.write(' \\')
149 output.write('\n')
150 if self._long_text:
151 output.write('\n***************\n')
152 # Write separately in case it's unicode.
153 output.write(self._long_text)
154 output.write('\n***************\n')
155 if self.fatal:
156 output.fail()
157
158
159# Top level object so multiprocessing can pickle
160# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000161class _PresubmitError(_PresubmitResult):
162 """A hard presubmit error."""
163 fatal = True
164
165
166# Top level object so multiprocessing can pickle
167# Public access through OutputApi object.
168class _PresubmitPromptWarning(_PresubmitResult):
169 """An warning that prompts the user if they want to continue."""
170 should_prompt = True
171
172
173# Top level object so multiprocessing can pickle
174# Public access through OutputApi object.
175class _PresubmitNotifyResult(_PresubmitResult):
176 """Just print something to the screen -- but it's not even a warning."""
177 pass
178
179
180# Top level object so multiprocessing can pickle
181# Public access through OutputApi object.
182class _MailTextResult(_PresubmitResult):
183 """A warning that should be included in the review request email."""
184 def __init__(self, *args, **kwargs):
185 super(_MailTextResult, self).__init__()
186 raise NotImplementedError()
187
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000188class GerritAccessor(object):
189 """Limited Gerrit functionality for canned presubmit checks to work.
190
191 To avoid excessive Gerrit calls, caches the results.
192 """
193
194 def __init__(self, host):
195 self.host = host
196 self.cache = {}
197
198 def _FetchChangeDetail(self, issue):
199 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100200 try:
201 return gerrit_util.GetChangeDetail(
202 self.host, str(issue),
203 ['ALL_REVISIONS', 'DETAILED_LABELS'],
204 ignore_404=False)
205 except gerrit_util.GerritError as e:
206 if e.http_status == 404:
207 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
208 'no credentials to fetch issue details' % issue)
209 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000210
211 def GetChangeInfo(self, issue):
212 """Returns labels and all revisions (patchsets) for this issue.
213
214 The result is a dictionary according to Gerrit REST Api.
215 https://gerrit-review.googlesource.com/Documentation/rest-api.html
216
217 However, API isn't very clear what's inside, so see tests for example.
218 """
219 assert issue
220 cache_key = int(issue)
221 if cache_key not in self.cache:
222 self.cache[cache_key] = self._FetchChangeDetail(issue)
223 return self.cache[cache_key]
224
225 def GetChangeDescription(self, issue, patchset=None):
226 """If patchset is none, fetches current patchset."""
227 info = self.GetChangeInfo(issue)
228 # info is a reference to cache. We'll modify it here adding description to
229 # it to the right patchset, if it is not yet there.
230
231 # Find revision info for the patchset we want.
232 if patchset is not None:
233 for rev, rev_info in info['revisions'].iteritems():
234 if str(rev_info['_number']) == str(patchset):
235 break
236 else:
237 raise Exception('patchset %s doesn\'t exist in issue %s' % (
238 patchset, issue))
239 else:
240 rev = info['current_revision']
241 rev_info = info['revisions'][rev]
242
243 # Updates revision info, which is part of cached issue info.
244 if 'real_description' not in rev_info:
245 rev_info['real_description'] = (
246 gerrit_util.GetChangeDescriptionFromGitiles(
247 rev_info['fetch']['http']['url'], rev))
248 return rev_info['real_description']
249
250 def GetChangeOwner(self, issue):
251 return self.GetChangeInfo(issue)['owner']['email']
252
253 def GetChangeReviewers(self, issue, approving_only=True):
agable565adb52016-07-22 14:48:07 -0700254 cr = self.GetChangeInfo(issue)['labels']['Code-Review']
255 max_value = max(int(k) for k in cr['values'].keys())
256 return [r['email'] for r in cr['all']
257 if not approving_only or r.get('value', 0) == max_value]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000258
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000259
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000260class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000261 """An instance of OutputApi gets passed to presubmit scripts so that they
262 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000263 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000264 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000265 PresubmitError = _PresubmitError
266 PresubmitPromptWarning = _PresubmitPromptWarning
267 PresubmitNotifyResult = _PresubmitNotifyResult
268 MailTextResult = _MailTextResult
269
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000270 def __init__(self, is_committing):
271 self.is_committing = is_committing
272
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000273 def PresubmitPromptOrNotify(self, *args, **kwargs):
274 """Warn the user when uploading, but only notify if committing."""
275 if self.is_committing:
276 return self.PresubmitNotifyResult(*args, **kwargs)
277 return self.PresubmitPromptWarning(*args, **kwargs)
278
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000279
280class InputApi(object):
281 """An instance of this object is passed to presubmit scripts so they can
282 know stuff about the change they're looking at.
283 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000284 # Method could be a function
285 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000286
maruel@chromium.org3410d912009-06-09 20:56:16 +0000287 # File extensions that are considered source files from a style guide
288 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000289 #
290 # Files without an extension aren't included in the list. If you want to
291 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
292 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000293 DEFAULT_WHITE_LIST = (
294 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000295 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
296 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000297 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000298 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000299 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000300 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000301 )
302
303 # Path regexp that should be excluded from being considered containing source
304 # files. Don't modify this list from a presubmit script!
305 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000306 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000307 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000308 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
309 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000310 # Output directories (just in case)
311 r".*\bDebug[\\\/].*",
312 r".*\bRelease[\\\/].*",
313 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000314 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000315 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000316 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000317 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000318 r"(|.*[\\\/])\.git[\\\/].*",
319 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000320 # There is no point in processing a patch file.
321 r".+\.diff$",
322 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000323 )
324
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000325 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000326 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000327 """Builds an InputApi object.
328
329 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000330 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000331 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000332 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000333 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000334 gerrit_obj: provides basic Gerrit codereview functionality.
335 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000336 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000337 # Version number of the presubmit_support script.
338 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000339 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000340 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000341 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000342 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000343 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000344 # TBD
345 self.host_url = 'http://codereview.chromium.org'
346 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000347 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000348
349 # We expose various modules and functions as attributes of the input_api
350 # so that presubmit scripts don't have to import them.
351 self.basename = os.path.basename
352 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000353 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000354 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700355 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000356 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000357 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000358 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000359 self.os_listdir = os.listdir
360 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000361 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000362 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000363 self.pickle = pickle
364 self.marshal = marshal
365 self.re = re
366 self.subprocess = subprocess
367 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000368 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000369 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000370 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000371 self.urllib2 = urllib2
372
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000373 # To easily fork python.
374 self.python_executable = sys.executable
375 self.environ = os.environ
376
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000377 # InputApi.platform is the platform you're currently running on.
378 self.platform = sys.platform
379
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000380 self.cpu_count = multiprocessing.cpu_count()
381
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000382 # this is done here because in RunTests, the current working directory has
383 # changed, which causes Pool() to explode fantastically when run on windows
384 # (because it tries to load the __main__ module, which imports lots of
385 # things relative to the current working directory).
386 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
387
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000388 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000389 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000390
391 # We carry the canned checks so presubmit scripts can easily use them.
392 self.canned_checks = presubmit_canned_checks
393
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000394 # TODO(dpranke): figure out a list of all approved owners for a repo
395 # in order to be able to handle wildcard OWNERS files?
396 self.owners_db = owners.Database(change.RepositoryRoot(),
dtu944b6052016-07-14 14:48:21 -0700397 fopen=file, os_path=self.os_path)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000398 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000399 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000400
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000401 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000402 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000403 # Access to a protected member _XX of a client class
404 # pylint: disable=W0212
405 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000406 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000407 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
408 for (a, b, header) in cpplint._re_pattern_templates
409 ]
410
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000411 def PresubmitLocalPath(self):
412 """Returns the local path of the presubmit script currently being run.
413
414 This is useful if you don't want to hard-code absolute paths in the
415 presubmit script. For example, It can be used to find another file
416 relative to the PRESUBMIT.py script, so the whole tree can be branched and
417 the presubmit script still works, without editing its content.
418 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000419 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000420
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000421 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000422 """Translate a depot path to a local path (relative to client root).
423
424 Args:
425 Depot path as a string.
426
427 Returns:
428 The local path of the depot path under the user's current client, or None
429 if the file is not mapped.
430
431 Remember to check for the None case and show an appropriate error!
432 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000433 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
434 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000435
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000436 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000437 """Translate a local path to a depot path.
438
439 Args:
440 Local path (relative to current directory, or absolute) as a string.
441
442 Returns:
443 The depot path (SVN URL) of the file if mapped, otherwise None.
444 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000445 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
446 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000447
sail@chromium.org5538e022011-05-12 17:53:16 +0000448 def AffectedFiles(self, include_dirs=False, include_deletes=True,
449 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000450 """Same as input_api.change.AffectedFiles() except only lists files
451 (and optionally directories) in the same directory as the current presubmit
452 script, or subdirectories thereof.
453 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000454 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000455 if len(dir_with_slash) == 1:
456 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000457
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000458 return filter(
459 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000460 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461
462 def LocalPaths(self, include_dirs=False):
463 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000464 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
465 logging.debug("LocalPaths: %s", paths)
466 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000467
468 def AbsoluteLocalPaths(self, include_dirs=False):
469 """Returns absolute local paths of input_api.AffectedFiles()."""
470 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
471
472 def ServerPaths(self, include_dirs=False):
473 """Returns server paths of input_api.AffectedFiles()."""
474 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
475
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000476 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000477 """Same as input_api.change.AffectedTextFiles() except only lists files
478 in the same directory as the current presubmit script, or subdirectories
479 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000480 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000481 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000482 warn("AffectedTextFiles(include_deletes=%s)"
483 " is deprecated and ignored" % str(include_deletes),
484 category=DeprecationWarning,
485 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000486 return filter(lambda x: x.IsTextFile(),
487 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000488
maruel@chromium.org3410d912009-06-09 20:56:16 +0000489 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
490 """Filters out files that aren't considered "source file".
491
492 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
493 and InputApi.DEFAULT_BLACK_LIST is used respectively.
494
495 The lists will be compiled as regular expression and
496 AffectedFile.LocalPath() needs to pass both list.
497
498 Note: Copy-paste this function to suit your needs or use a lambda function.
499 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000500 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000501 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000502 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000503 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000504 return True
505 return False
506 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
507 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
508
509 def AffectedSourceFiles(self, source_file):
510 """Filter the list of AffectedTextFiles by the function source_file.
511
512 If source_file is None, InputApi.FilterSourceFile() is used.
513 """
514 if not source_file:
515 source_file = self.FilterSourceFile
516 return filter(source_file, self.AffectedTextFiles())
517
518 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519 """An iterator over all text lines in "new" version of changed files.
520
521 Only lists lines from new or modified text files in the change that are
522 contained by the directory of the currently executing presubmit script.
523
524 This is useful for doing line-by-line regex checks, like checking for
525 trailing whitespace.
526
527 Yields:
528 a 3 tuple:
529 the AffectedFile instance of the current file;
530 integer line number (1-based); and
531 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000532
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000533 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000534 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000535 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000536 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000537
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000538 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000539 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000540
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000541 Deny reading anything outside the repository.
542 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000543 if isinstance(file_item, AffectedFile):
544 file_item = file_item.AbsoluteLocalPath()
545 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000546 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000547 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000548
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000549 @property
550 def tbr(self):
551 """Returns if a change is TBR'ed."""
552 return 'TBR' in self.change.tags
553
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000554 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000555 tests = []
556 msgs = []
557 for t in tests_mix:
558 if isinstance(t, OutputApi.PresubmitResult):
559 msgs.append(t)
560 else:
561 assert issubclass(t.message, _PresubmitResult)
562 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000563 if self.verbose:
564 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000565 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000566 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000567 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000568 else:
569 msgs.extend(map(CallCommand, tests))
570 return [m for m in msgs if m]
571
scottmg86099d72016-09-01 09:16:51 -0700572 def ShutdownPool(self):
573 self._run_tests_pool.close()
574 self._run_tests_pool.join()
575 self._run_tests_pool = None
576
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000577
nick@chromium.orgff526192013-06-10 19:30:26 +0000578class _DiffCache(object):
579 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000580 def __init__(self, upstream=None):
581 """Stores the upstream revision against which all diffs will be computed."""
582 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000583
584 def GetDiff(self, path, local_root):
585 """Get the diff for a particular path."""
586 raise NotImplementedError()
587
588
589class _SvnDiffCache(_DiffCache):
590 """DiffCache implementation for subversion."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000591 def __init__(self, *args, **kwargs):
592 super(_SvnDiffCache, self).__init__(*args, **kwargs)
nick@chromium.orgff526192013-06-10 19:30:26 +0000593 self._diffs_by_file = {}
594
595 def GetDiff(self, path, local_root):
596 if path not in self._diffs_by_file:
597 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
598 False, None)
599 return self._diffs_by_file[path]
600
601
602class _GitDiffCache(_DiffCache):
603 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000604 def __init__(self, upstream):
605 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000606 self._diffs_by_file = None
607
608 def GetDiff(self, path, local_root):
609 if not self._diffs_by_file:
610 # Compute a single diff for all files and parse the output; should
611 # with git this is much faster than computing one diff for each file.
612 diffs = {}
613
614 # Don't specify any filenames below, because there are command line length
615 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000616 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
617 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000618
619 # This regex matches the path twice, separated by a space. Note that
620 # filename itself may contain spaces.
621 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
622 current_diff = []
623 keep_line_endings = True
624 for x in unified_diff.splitlines(keep_line_endings):
625 match = file_marker.match(x)
626 if match:
627 # Marks the start of a new per-file section.
628 diffs[match.group('filename')] = current_diff = [x]
629 elif x.startswith('diff --git'):
630 raise PresubmitFailure('Unexpected diff line: %s' % x)
631 else:
632 current_diff.append(x)
633
634 self._diffs_by_file = dict(
635 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
636
637 if path not in self._diffs_by_file:
638 raise PresubmitFailure(
639 'Unified diff did not contain entry for file %s' % path)
640
641 return self._diffs_by_file[path]
642
643
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000644class AffectedFile(object):
645 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000646
647 DIFF_CACHE = _DiffCache
648
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000649 # Method could be a function
650 # pylint: disable=R0201
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000651 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000652 self._path = path
653 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000654 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000655 self._is_directory = None
656 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000657 self._cached_changed_contents = None
658 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000659 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700660 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661
662 def ServerPath(self):
663 """Returns a path string that identifies the file in the SCM system.
664
665 Returns the empty string if the file does not exist in SCM.
666 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000667 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000668
669 def LocalPath(self):
670 """Returns the path of this file on the local disk relative to client root.
671 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000672 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673
674 def AbsoluteLocalPath(self):
675 """Returns the absolute path of this file on the local disk.
676 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000677 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000678
679 def IsDirectory(self):
680 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000681 if self._is_directory is None:
682 path = self.AbsoluteLocalPath()
683 self._is_directory = (os.path.exists(path) and
684 os.path.isdir(path))
685 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000686
687 def Action(self):
688 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000689 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
690 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000691 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000692
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000693 def Property(self, property_name):
694 """Returns the specified SCM property of this file, or None if no such
695 property.
696 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000697 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000698
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000699 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000700 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000701
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000702 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000703 raise NotImplementedError() # Implement when needed
704
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705 def NewContents(self):
706 """Returns an iterator over the lines in the new version of file.
707
708 The new version is the file in the user's workspace, i.e. the "right hand
709 side".
710
711 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000712 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000714 if self._cached_new_contents is None:
715 self._cached_new_contents = []
716 if not self.IsDirectory():
717 try:
718 self._cached_new_contents = gclient_utils.FileRead(
719 self.AbsoluteLocalPath(), 'rU').splitlines()
720 except IOError:
721 pass # File not found? That's fine; maybe it was deleted.
722 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000724 def ChangedContents(self):
725 """Returns a list of tuples (line number, line text) of all new lines.
726
727 This relies on the scm diff output describing each changed code section
728 with a line of the form
729
730 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
731 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000732 if self._cached_changed_contents is not None:
733 return self._cached_changed_contents[:]
734 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000735 line_num = 0
736
737 if self.IsDirectory():
738 return []
739
740 for line in self.GenerateScmDiff().splitlines():
741 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
742 if m:
743 line_num = int(m.groups(1)[0])
744 continue
745 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000746 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000747 if not line.startswith('-'):
748 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000749 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000750
maruel@chromium.org5de13972009-06-10 18:16:06 +0000751 def __str__(self):
752 return self.LocalPath()
753
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000754 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000755 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000756
maruel@chromium.org58407af2011-04-12 23:15:57 +0000757
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000758class SvnAffectedFile(AffectedFile):
759 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000760 # Method 'NNN' is abstract in class 'NNN' but is not overridden
761 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000762
nick@chromium.orgff526192013-06-10 19:30:26 +0000763 DIFF_CACHE = _SvnDiffCache
764
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000765 def __init__(self, *args, **kwargs):
766 AffectedFile.__init__(self, *args, **kwargs)
767 self._server_path = None
768 self._is_text_file = None
769
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000770 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000771 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000772 self._server_path = scm.SVN.CaptureLocalInfo(
773 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000774 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000775
776 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000777 if self._is_directory is None:
778 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000779 if os.path.exists(path):
780 # Retrieve directly from the file system; it is much faster than
781 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000782 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000783 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000784 self._is_directory = scm.SVN.CaptureLocalInfo(
785 [self.LocalPath()], self._local_root
786 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000787 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000788
789 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000790 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000791 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000792 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000793 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000794
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000795 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000796 if self._is_text_file is None:
797 if self.Action() == 'D':
798 # A deleted file is not a text file.
799 self._is_text_file = False
800 elif self.IsDirectory():
801 self._is_text_file = False
802 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000803 mime_type = scm.SVN.GetFileProperty(
804 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000805 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
806 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000807
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000808
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000809class GitAffectedFile(AffectedFile):
810 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000811 # Method 'NNN' is abstract in class 'NNN' but is not overridden
812 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000813
nick@chromium.orgff526192013-06-10 19:30:26 +0000814 DIFF_CACHE = _GitDiffCache
815
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000816 def __init__(self, *args, **kwargs):
817 AffectedFile.__init__(self, *args, **kwargs)
818 self._server_path = None
819 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000820
821 def ServerPath(self):
822 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000823 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000824 return self._server_path
825
826 def IsDirectory(self):
827 if self._is_directory is None:
828 path = self.AbsoluteLocalPath()
829 if os.path.exists(path):
830 # Retrieve directly from the file system; it is much faster than
831 # querying subversion, especially on Windows.
832 self._is_directory = os.path.isdir(path)
833 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000834 self._is_directory = False
835 return self._is_directory
836
837 def Property(self, property_name):
838 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000839 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000840 return self._properties[property_name]
841
842 def IsTextFile(self):
843 if self._is_text_file is None:
844 if self.Action() == 'D':
845 # A deleted file is not a text file.
846 self._is_text_file = False
847 elif self.IsDirectory():
848 self._is_text_file = False
849 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000850 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
851 return self._is_text_file
852
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000853
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000854class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000855 """Describe a change.
856
857 Used directly by the presubmit scripts to query the current change being
858 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000859
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000860 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000861 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000862 self.KEY: equivalent to tags['KEY']
863 """
864
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000865 _AFFECTED_FILES = AffectedFile
866
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000867 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000868 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000869 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000870 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000871
maruel@chromium.org58407af2011-04-12 23:15:57 +0000872 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000873 self, name, description, local_root, files, issue, patchset, author,
874 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000875 if files is None:
876 files = []
877 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000878 # Convert root into an absolute path.
879 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000880 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000881 self.issue = issue
882 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000883 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000884
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000885 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000887 self._description_without_tags = ''
888 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000889
maruel@chromium.orge085d812011-10-10 19:49:15 +0000890 assert all(
891 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
892
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000893 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000894 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000895 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
896 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000897 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000898
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000899 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000900 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000901 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000902
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000903 def DescriptionText(self):
904 """Returns the user-entered changelist description, minus tags.
905
906 Any line in the user-provided description starting with e.g. "FOO="
907 (whitespace permitted before and around) is considered a tag line. Such
908 lines are stripped out of the description this function returns.
909 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000910 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000911
912 def FullDescriptionText(self):
913 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000914 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000915
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000916 def SetDescriptionText(self, description):
917 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000918
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000919 Also updates the list of tags."""
920 self._full_description = description
921
922 # From the description text, build up a dictionary of key/value pairs
923 # plus the description minus all key/value or "tag" lines.
924 description_without_tags = []
925 self.tags = {}
926 for line in self._full_description.splitlines():
927 m = self.TAG_LINE_RE.match(line)
928 if m:
929 self.tags[m.group('key')] = m.group('value')
930 else:
931 description_without_tags.append(line)
932
933 # Change back to text and remove whitespace at end.
934 self._description_without_tags = (
935 '\n'.join(description_without_tags).rstrip())
936
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000937 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000938 """Returns the repository (checkout) root directory for this change,
939 as an absolute path.
940 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000941 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
943 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000944 """Return tags directly as attributes on the object."""
945 if not re.match(r"^[A-Z_]*$", attr):
946 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000947 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000948
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000949 def AllFiles(self, root=None):
950 """List all files under source control in the repo."""
951 raise NotImplementedError()
952
sail@chromium.org5538e022011-05-12 17:53:16 +0000953 def AffectedFiles(self, include_dirs=False, include_deletes=True,
954 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000955 """Returns a list of AffectedFile instances for all files in the change.
956
957 Args:
958 include_deletes: If false, deleted files will be filtered out.
959 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000960 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000961
962 Returns:
963 [AffectedFile(path, action), AffectedFile(path, action)]
964 """
965 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000966 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000967 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000968 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000969
sail@chromium.org5538e022011-05-12 17:53:16 +0000970 affected = filter(file_filter, affected)
971
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000972 if include_deletes:
973 return affected
974 else:
975 return filter(lambda x: x.Action() != 'D', affected)
976
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000977 def AffectedTextFiles(self, include_deletes=None):
978 """Return a list of the existing text files in a change."""
979 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000980 warn("AffectedTextFiles(include_deletes=%s)"
981 " is deprecated and ignored" % str(include_deletes),
982 category=DeprecationWarning,
983 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000984 return filter(lambda x: x.IsTextFile(),
985 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986
987 def LocalPaths(self, include_dirs=False):
988 """Convenience function."""
989 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
990
991 def AbsoluteLocalPaths(self, include_dirs=False):
992 """Convenience function."""
993 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
994
995 def ServerPaths(self, include_dirs=False):
996 """Convenience function."""
997 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
998
999 def RightHandSideLines(self):
1000 """An iterator over all text lines in "new" version of changed files.
1001
1002 Lists lines from new or modified text files in the change.
1003
1004 This is useful for doing line-by-line regex checks, like checking for
1005 trailing whitespace.
1006
1007 Yields:
1008 a 3 tuple:
1009 the AffectedFile instance of the current file;
1010 integer line number (1-based); and
1011 the contents of the line as a string.
1012 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001013 return _RightHandSideLinesImpl(
1014 x for x in self.AffectedFiles(include_deletes=False)
1015 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016
1017
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001018class SvnChange(Change):
1019 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001020 scm = 'svn'
1021 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +00001022
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001023 def AllFiles(self, root=None):
1024 """List all files under source control in the repo."""
1025 root = root or self.RepositoryRoot()
1026 return subprocess.check_output(
1027 ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
1028
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001029
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001030class GitChange(Change):
1031 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001032 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001033
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001034 def AllFiles(self, root=None):
1035 """List all files under source control in the repo."""
1036 root = root or self.RepositoryRoot()
1037 return subprocess.check_output(
1038 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
1039
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001040
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001041def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001042 """Finds all presubmit files that apply to a given set of source files.
1043
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001044 If inherit-review-settings-ok is present right under root, looks for
1045 PRESUBMIT.py in directories enclosing root.
1046
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001047 Args:
1048 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001049 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001050
1051 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001052 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001053 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001054 files = [normpath(os.path.join(root, f)) for f in files]
1055
1056 # List all the individual directories containing files.
1057 directories = set([os.path.dirname(f) for f in files])
1058
1059 # Ignore root if inherit-review-settings-ok is present.
1060 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1061 root = None
1062
1063 # Collect all unique directories that may contain PRESUBMIT.py.
1064 candidates = set()
1065 for directory in directories:
1066 while True:
1067 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001068 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001069 candidates.add(directory)
1070 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001071 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001072 parent_dir = os.path.dirname(directory)
1073 if parent_dir == directory:
1074 # We hit the system root directory.
1075 break
1076 directory = parent_dir
1077
1078 # Look for PRESUBMIT.py in all candidate directories.
1079 results = []
1080 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001081 try:
1082 for f in os.listdir(directory):
1083 p = os.path.join(directory, f)
1084 if os.path.isfile(p) and re.match(
1085 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1086 results.append(p)
1087 except OSError:
1088 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001089
tobiasjs2836bcf2016-08-16 04:08:16 -07001090 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001091 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
1093
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001094class GetTryMastersExecuter(object):
1095 @staticmethod
1096 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1097 """Executes GetPreferredTryMasters() from a single presubmit script.
1098
1099 Args:
1100 script_text: The text of the presubmit script.
1101 presubmit_path: Project script to run.
1102 project: Project name to pass to presubmit script for bot selection.
1103
1104 Return:
1105 A map of try masters to map of builders to set of tests.
1106 """
1107 context = {}
1108 try:
1109 exec script_text in context
1110 except Exception, e:
1111 raise PresubmitFailure('"%s" had an exception.\n%s'
1112 % (presubmit_path, e))
1113
1114 function_name = 'GetPreferredTryMasters'
1115 if function_name not in context:
1116 return {}
1117 get_preferred_try_masters = context[function_name]
1118 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1119 raise PresubmitFailure(
1120 'Expected function "GetPreferredTryMasters" to take two arguments.')
1121 return get_preferred_try_masters(project, change)
1122
1123
rmistry@google.com5626a922015-02-26 14:03:30 +00001124class GetPostUploadExecuter(object):
1125 @staticmethod
1126 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1127 """Executes PostUploadHook() from a single presubmit script.
1128
1129 Args:
1130 script_text: The text of the presubmit script.
1131 presubmit_path: Project script to run.
1132 cl: The Changelist object.
1133 change: The Change object.
1134
1135 Return:
1136 A list of results objects.
1137 """
1138 context = {}
1139 try:
1140 exec script_text in context
1141 except Exception, e:
1142 raise PresubmitFailure('"%s" had an exception.\n%s'
1143 % (presubmit_path, e))
1144
1145 function_name = 'PostUploadHook'
1146 if function_name not in context:
1147 return {}
1148 post_upload_hook = context[function_name]
1149 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1150 raise PresubmitFailure(
1151 'Expected function "PostUploadHook" to take three arguments.')
1152 return post_upload_hook(cl, change, OutputApi(False))
1153
1154
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001155def _MergeMasters(masters1, masters2):
1156 """Merges two master maps. Merges also the tests of each builder."""
1157 result = {}
1158 for (master, builders) in itertools.chain(masters1.iteritems(),
1159 masters2.iteritems()):
1160 new_builders = result.setdefault(master, {})
1161 for (builder, tests) in builders.iteritems():
1162 new_builders.setdefault(builder, set([])).update(tests)
1163 return result
1164
1165
1166def DoGetTryMasters(change,
1167 changed_files,
1168 repository_root,
1169 default_presubmit,
1170 project,
1171 verbose,
1172 output_stream):
1173 """Get the list of try masters from the presubmit scripts.
1174
1175 Args:
1176 changed_files: List of modified files.
1177 repository_root: The repository root.
1178 default_presubmit: A default presubmit script to execute in any case.
1179 project: Optional name of a project used in selecting trybots.
1180 verbose: Prints debug info.
1181 output_stream: A stream to write debug output to.
1182
1183 Return:
1184 Map of try masters to map of builders to set of tests.
1185 """
1186 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1187 if not presubmit_files and verbose:
1188 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1189 results = {}
1190 executer = GetTryMastersExecuter()
1191
1192 if default_presubmit:
1193 if verbose:
1194 output_stream.write("Running default presubmit script.\n")
1195 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1196 results = _MergeMasters(results, executer.ExecPresubmitScript(
1197 default_presubmit, fake_path, project, change))
1198 for filename in presubmit_files:
1199 filename = os.path.abspath(filename)
1200 if verbose:
1201 output_stream.write("Running %s\n" % filename)
1202 # Accept CRLF presubmit script.
1203 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1204 results = _MergeMasters(results, executer.ExecPresubmitScript(
1205 presubmit_script, filename, project, change))
1206
1207 # Make sets to lists again for later JSON serialization.
1208 for builders in results.itervalues():
1209 for builder in builders:
1210 builders[builder] = list(builders[builder])
1211
1212 if results and verbose:
1213 output_stream.write('%s\n' % str(results))
1214 return results
1215
1216
rmistry@google.com5626a922015-02-26 14:03:30 +00001217def DoPostUploadExecuter(change,
1218 cl,
1219 repository_root,
1220 verbose,
1221 output_stream):
1222 """Execute the post upload hook.
1223
1224 Args:
1225 change: The Change object.
1226 cl: The Changelist object.
1227 repository_root: The repository root.
1228 verbose: Prints debug info.
1229 output_stream: A stream to write debug output to.
1230 """
1231 presubmit_files = ListRelevantPresubmitFiles(
1232 change.LocalPaths(), repository_root)
1233 if not presubmit_files and verbose:
1234 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1235 results = []
1236 executer = GetPostUploadExecuter()
1237 # The root presubmit file should be executed after the ones in subdirectories.
1238 # i.e. the specific post upload hooks should run before the general ones.
1239 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1240 presubmit_files.reverse()
1241
1242 for filename in presubmit_files:
1243 filename = os.path.abspath(filename)
1244 if verbose:
1245 output_stream.write("Running %s\n" % filename)
1246 # Accept CRLF presubmit script.
1247 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1248 results.extend(executer.ExecPresubmitScript(
1249 presubmit_script, filename, cl, change))
1250 output_stream.write('\n')
1251 if results:
1252 output_stream.write('** Post Upload Hook Messages **\n')
1253 for result in results:
1254 result.handle(output_stream)
1255 output_stream.write('\n')
1256
1257 return results
1258
1259
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001260class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001261 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001262 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001263 """
1264 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001265 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001266 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001267 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001268 gerrit_obj: provides basic Gerrit codereview functionality.
1269 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001270 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001271 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001272 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001273 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001274 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001275 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001276 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001277
1278 def ExecPresubmitScript(self, script_text, presubmit_path):
1279 """Executes a single presubmit script.
1280
1281 Args:
1282 script_text: The text of the presubmit script.
1283 presubmit_path: The path to the presubmit file (this will be reported via
1284 input_api.PresubmitLocalPath()).
1285
1286 Return:
1287 A list of result objects, empty if no problems.
1288 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001289
chase@chromium.org8e416c82009-10-06 04:30:44 +00001290 # Change to the presubmit file's directory to support local imports.
1291 main_path = os.getcwd()
1292 os.chdir(os.path.dirname(presubmit_path))
1293
1294 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001295 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001296 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001297 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001298 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001299 try:
1300 exec script_text in context
1301 except Exception, e:
1302 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001303
1304 # These function names must change if we make substantial changes to
1305 # the presubmit API that are not backwards compatible.
1306 if self.committing:
1307 function_name = 'CheckChangeOnCommit'
1308 else:
1309 function_name = 'CheckChangeOnUpload'
1310 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001311 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001312 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001313 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001314 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001315 if not (isinstance(result, types.TupleType) or
1316 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001317 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001318 'Presubmit functions must return a tuple or list')
1319 for item in result:
1320 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001321 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001322 'All presubmit results must be of types derived from '
1323 'output_api.PresubmitResult')
1324 else:
1325 result = () # no error since the script doesn't care about current event.
1326
scottmg86099d72016-09-01 09:16:51 -07001327 input_api.ShutdownPool()
1328
chase@chromium.org8e416c82009-10-06 04:30:44 +00001329 # Return the process to the original working directory.
1330 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001331 return result
1332
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001333
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001334def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001335 committing,
1336 verbose,
1337 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001338 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001339 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001340 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001341 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001342 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001343 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001344 """Runs all presubmit checks that apply to the files in the change.
1345
1346 This finds all PRESUBMIT.py files in directories enclosing the files in the
1347 change (up to the repository root) and calls the relevant entrypoint function
1348 depending on whether the change is being committed or uploaded.
1349
1350 Prints errors, warnings and notifications. Prompts the user for warnings
1351 when needed.
1352
1353 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001354 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001355 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356 verbose: Prints debug info.
1357 output_stream: A stream to write output from presubmit tests to.
1358 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001359 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001360 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001361 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001362 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001363 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001364
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001365 Warning:
1366 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1367 SHOULD be sys.stdin.
1368
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001369 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001370 A PresubmitOutput object. Use output.should_continue() to figure out
1371 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001372 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001373 old_environ = os.environ
1374 try:
1375 # Make sure python subprocesses won't generate .pyc files.
1376 os.environ = os.environ.copy()
1377 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001378
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001379 output = PresubmitOutput(input_stream, output_stream)
1380 if committing:
1381 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001382 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001383 output.write("Running presubmit upload checks ...\n")
1384 start_time = time.time()
1385 presubmit_files = ListRelevantPresubmitFiles(
1386 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1387 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001388 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001389 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001390 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001391 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001392 if default_presubmit:
1393 if verbose:
1394 output.write("Running default presubmit script.\n")
1395 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1396 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1397 for filename in presubmit_files:
1398 filename = os.path.abspath(filename)
1399 if verbose:
1400 output.write("Running %s\n" % filename)
1401 # Accept CRLF presubmit script.
1402 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1403 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001404
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001405 errors = []
1406 notifications = []
1407 warnings = []
1408 for result in results:
1409 if result.fatal:
1410 errors.append(result)
1411 elif result.should_prompt:
1412 warnings.append(result)
1413 else:
1414 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001415
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001416 output.write('\n')
1417 for name, items in (('Messages', notifications),
1418 ('Warnings', warnings),
1419 ('ERRORS', errors)):
1420 if items:
1421 output.write('** Presubmit %s **\n' % name)
1422 for item in items:
1423 item.handle(output)
1424 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001425
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001426 total_time = time.time() - start_time
1427 if total_time > 1.0:
1428 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001429
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001430 if not errors:
1431 if not warnings:
1432 output.write('Presubmit checks passed.\n')
1433 elif may_prompt:
1434 output.prompt_yes_no('There were presubmit warnings. '
1435 'Are you sure you wish to continue? (y/N): ')
1436 else:
1437 output.fail()
1438
1439 global _ASKED_FOR_FEEDBACK
1440 # Ask for feedback one time out of 5.
1441 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001442 output.write(
1443 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1444 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1445 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001446 _ASKED_FOR_FEEDBACK = True
1447 return output
1448 finally:
1449 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001450
1451
1452def ScanSubDirs(mask, recursive):
1453 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001454 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001455 else:
1456 results = []
1457 for root, dirs, files in os.walk('.'):
1458 if '.svn' in dirs:
1459 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001460 if '.git' in dirs:
1461 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001462 for name in files:
1463 if fnmatch.fnmatch(name, mask):
1464 results.append(os.path.join(root, name))
1465 return results
1466
1467
1468def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001469 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001470 files = []
1471 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001472 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473 return files
1474
1475
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001476def load_files(options, args):
1477 """Tries to determine the SCM."""
1478 change_scm = scm.determine_scm(options.root)
1479 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001480 if args:
1481 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001482 if change_scm == 'svn':
1483 change_class = SvnChange
1484 if not files:
1485 files = scm.SVN.CaptureStatus([], options.root)
1486 elif change_scm == 'git':
1487 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001488 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001489 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001490 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001491 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001492 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001493 if not files:
1494 return None, None
1495 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001496 return change_class, files
1497
1498
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001499class NonexistantCannedCheckFilter(Exception):
1500 pass
1501
1502
1503@contextlib.contextmanager
1504def canned_check_filter(method_names):
1505 filtered = {}
1506 try:
1507 for method_name in method_names:
1508 if not hasattr(presubmit_canned_checks, method_name):
1509 raise NonexistantCannedCheckFilter(method_name)
1510 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1511 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1512 yield
1513 finally:
1514 for name, method in filtered.iteritems():
1515 setattr(presubmit_canned_checks, name, method)
1516
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001517
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001518def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001519 """Runs an external program, potentially from a child process created by the
1520 multiprocessing module.
1521
1522 multiprocessing needs a top level function with a single argument.
1523 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001524 cmd_data.kwargs['stdout'] = subprocess.PIPE
1525 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1526 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001527 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001528 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001529 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001530 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001531 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001532 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001533 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1534 if code != 0:
1535 return cmd_data.message(
1536 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1537 if cmd_data.info:
1538 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001539
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001540
sbc@chromium.org013731e2015-02-26 18:28:43 +00001541def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001542 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001543 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001544 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001546 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1547 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001548 parser.add_option("-r", "--recursive", action="store_true",
1549 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001550 parser.add_option("-v", "--verbose", action="count", default=0,
1551 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001552 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001553 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001554 parser.add_option("--description", default='')
1555 parser.add_option("--issue", type='int', default=0)
1556 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001557 parser.add_option("--root", default=os.getcwd(),
1558 help="Search for PRESUBMIT.py up to this directory. "
1559 "If inherit-review-settings-ok is present in this "
1560 "directory, parent directories up to the root file "
1561 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001562 parser.add_option("--upstream",
1563 help="Git only: the base ref or upstream branch against "
1564 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001565 parser.add_option("--default_presubmit")
1566 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001567 parser.add_option("--skip_canned", action='append', default=[],
1568 help="A list of checks to skip which appear in "
1569 "presubmit_canned_checks. Can be provided multiple times "
1570 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001571 parser.add_option("--dry_run", action='store_true',
1572 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001573 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001574 parser.add_option("--gerrit_fetch", action='store_true',
1575 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001576 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1577 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001578 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1579 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001580 # These are for OAuth2 authentication for bots. See also apply_issue.py
1581 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1582 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1583
phajdan.jr@chromium.org2ff30182016-03-23 09:52:51 +00001584 # TODO(phajdan.jr): Update callers and remove obsolete --trybot-json .
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001585 parser.add_option("--trybot-json",
1586 help="Output trybot information to the file specified.")
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001587 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001588 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001589 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001590
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001591 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001592 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001593 elif options.verbose:
1594 logging.basicConfig(level=logging.INFO)
1595 else:
1596 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001597
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001598 if (any((options.rietveld_url, options.rietveld_email_file,
1599 options.rietveld_fetch, options.rietveld_private_key_file))
1600 and any((options.gerrit_url, options.gerrit_fetch))):
1601 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1602 'allowed')
1603
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001604 if options.rietveld_email and options.rietveld_email_file:
1605 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1606 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001607 if options.rietveld_email_file:
1608 with open(options.rietveld_email_file, "rb") as f:
1609 options.rietveld_email = f.read().strip()
1610
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001611 change_class, files = load_files(options, args)
1612 if not change_class:
1613 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001614 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001615
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001616 rietveld_obj, gerrit_obj = None, None
1617
maruel@chromium.org239f4112011-06-03 20:08:23 +00001618 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001619 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001620 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001621 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1622 options.rietveld_url,
1623 options.rietveld_email,
1624 options.rietveld_private_key_file)
1625 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001626 rietveld_obj = rietveld.CachingRietveld(
1627 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001628 auth_config,
1629 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001630 if options.rietveld_fetch:
1631 assert options.issue
1632 props = rietveld_obj.get_issue_properties(options.issue, False)
1633 options.author = props['owner_email']
1634 options.description = props['description']
1635 logging.info('Got author: "%s"', options.author)
1636 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001637
1638 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001639 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001640 rietveld_obj = None
1641 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1642 options.author = gerrit_obj.GetChangeOwner(options.issue)
1643 options.description = gerrit_obj.GetChangeDescription(options.issue,
1644 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001645 logging.info('Got author: "%s"', options.author)
1646 logging.info('Got description: """\n%s\n"""', options.description)
1647
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001648 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001649 with canned_check_filter(options.skip_canned):
1650 results = DoPresubmitChecks(
1651 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001652 options.description,
1653 options.root,
1654 files,
1655 options.issue,
1656 options.patchset,
1657 options.author,
1658 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001659 options.commit,
1660 options.verbose,
1661 sys.stdout,
1662 sys.stdin,
1663 options.default_presubmit,
1664 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001665 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001666 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001667 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001668 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001669 except NonexistantCannedCheckFilter, e:
1670 print >> sys.stderr, (
1671 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1672 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001673 except PresubmitFailure, e:
1674 print >> sys.stderr, e
1675 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1676 print >> sys.stderr, 'If all fails, contact maruel@'
1677 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678
1679
1680if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001681 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001682 try:
1683 sys.exit(main())
1684 except KeyboardInterrupt:
1685 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001686 sys.exit(2)