blob: e52af53353edd9f5fc6e7e9470d8029b824acce5 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Yves Gerey3e707812018-11-28 16:47:49 +010020#include "api/video/encoded_image.h"
21#include "api/video/video_timing.h"
22#include "common_types.h" // NOLINT(build/include)
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020023#include "modules/video_coding/include/video_coding_defines.h"
24#include "modules/video_coding/jitter_estimator.h"
25#include "modules/video_coding/timing.h"
26#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "rtc_base/trace_event.h"
31#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020032#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020033
34namespace webrtc {
35namespace video_coding {
36
37namespace {
philipele0b2f152016-09-28 10:23:49 +020038// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010039constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020040
philipele0b2f152016-09-28 10:23:49 +020041// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010042constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070043
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010044// The time it's allowed for a frame to be late to its rendering prediction and
45// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010046constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010047
philipel65e1f942017-07-24 08:26:53 -070048constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020049} // namespace
50
philipelbe7a9e52016-05-19 12:19:35 +020051FrameBuffer::FrameBuffer(Clock* clock,
52 VCMJitterEstimator* jitter_estimator,
philipela45102f2017-02-22 05:30:39 -080053 VCMTiming* timing,
54 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010055 : decoded_frames_history_(kMaxFramesHistory),
56 clock_(clock),
philipelbe7a9e52016-05-19 12:19:35 +020057 jitter_estimator_(jitter_estimator),
58 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020059 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070060 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080061 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070062 stats_callback_(stats_callback),
63 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs) {}
philipel266f0a42016-11-28 08:49:07 -080064
philipela45102f2017-02-22 05:30:39 -080065FrameBuffer::~FrameBuffer() {}
philipelbe7a9e52016-05-19 12:19:35 +020066
philipel75562822016-09-05 10:57:41 +020067FrameBuffer::ReturnReason FrameBuffer::NextFrame(
68 int64_t max_wait_time_ms,
philipele7c891f2018-02-22 14:35:06 +010069 std::unique_ptr<EncodedFrame>* frame_out,
philipel3042c2d2017-08-18 04:55:02 -070070 bool keyframe_required) {
tommidb23ea62017-03-03 07:21:18 -080071 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
philipel1c056252017-01-31 09:53:12 -080072 int64_t latest_return_time_ms =
73 clock_->TimeInMilliseconds() + max_wait_time_ms;
philipel504c47d2016-06-30 17:33:02 +020074 int64_t wait_ms = max_wait_time_ms;
philipel29f730e2017-03-15 08:10:08 -070075 int64_t now_ms = 0;
philipele0b2f152016-09-28 10:23:49 +020076
77 do {
philipel29f730e2017-03-15 08:10:08 -070078 now_ms = clock_->TimeInMilliseconds();
philipel504c47d2016-06-30 17:33:02 +020079 {
80 rtc::CritScope lock(&crit_);
tommi0a735642017-03-14 06:23:57 -070081 new_continuous_frame_event_.Reset();
philipel29f730e2017-03-15 08:10:08 -070082 if (stopped_)
83 return kStopped;
84
85 wait_ms = max_wait_time_ms;
86
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +010087 // Need to hold |crit_| in order to access frames_to_decode_. therefore we
philipele0b2f152016-09-28 10:23:49 +020088 // set it here in the loop instead of outside the loop in order to not
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +010089 // acquire the lock unnecessarily.
90 frames_to_decode_.clear();
philipelbe7a9e52016-05-19 12:19:35 +020091
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +010092 // |last_continuous_frame_| may be empty below, but nullopt is smaller
93 // than everything else and loop will immediately terminate as expected.
94 for (auto frame_it = frames_.begin();
95 frame_it != frames_.end() &&
96 frame_it->first <= last_continuous_frame_;
philipel146a48b2017-04-20 04:04:38 -070097 ++frame_it) {
philipel93e451b2016-10-06 12:25:13 +020098 if (!frame_it->second.continuous ||
99 frame_it->second.num_missing_decodable > 0) {
philipele0b2f152016-09-28 10:23:49 +0200100 continue;
philipel93e451b2016-10-06 12:25:13 +0200101 }
philipele0b2f152016-09-28 10:23:49 +0200102
philipele7c891f2018-02-22 14:35:06 +0100103 EncodedFrame* frame = frame_it->second.frame.get();
philipel3042c2d2017-08-18 04:55:02 -0700104
105 if (keyframe_required && !frame->is_keyframe())
106 continue;
107
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100108 auto last_decoded_frame_timestamp =
109 decoded_frames_history_.GetLastDecodedFrameTimestamp();
110
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100111 // TODO(https://bugs.webrtc.org/9974): consider removing this check
112 // as it may make a stream undecodable after a very long delay between
113 // frames.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100114 if (last_decoded_frame_timestamp &&
115 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
philipel6d216502018-10-22 14:36:45 +0200116 continue;
117 }
118
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100119 // Only ever return all parts of a superframe. Therefore skip this
120 // frame if it's not a beginning of a superframe.
121 if (frame->inter_layer_predicted) {
122 continue;
123 }
124
125 // Gather all remaining frames for the same superframe.
126 std::vector<FrameMap::iterator> current_superframe;
127 current_superframe.push_back(frame_it);
128 bool last_layer_completed =
129 frame_it->second.frame->is_last_spatial_layer;
130 FrameMap::iterator next_frame_it = frame_it;
131 while (true) {
132 ++next_frame_it;
133 if (next_frame_it == frames_.end() ||
134 next_frame_it->first.picture_id != frame->id.picture_id ||
135 !next_frame_it->second.continuous) {
136 break;
137 }
138 // Check if the next frame has some undecoded references other than
139 // the previous frame in the same superframe.
140 size_t num_allowed_undecoded_refs =
141 (next_frame_it->second.frame->inter_layer_predicted) ? 1 : 0;
142 if (next_frame_it->second.num_missing_decodable >
143 num_allowed_undecoded_refs) {
144 break;
145 }
146 // All frames in the superframe should have the same timestamp.
147 if (frame->Timestamp() != next_frame_it->second.frame->Timestamp()) {
148 RTC_LOG(LS_WARNING)
149 << "Frames in a single superframe have different"
150 " timestamps. Skipping undecodable superframe.";
151 break;
152 }
153 current_superframe.push_back(next_frame_it);
154 last_layer_completed =
155 next_frame_it->second.frame->is_last_spatial_layer;
156 }
157 // Check if the current superframe is complete.
158 // TODO(bugs.webrtc.org/10064): consider returning all available to
159 // decode frames even if the superframe is not complete yet.
160 if (!last_layer_completed) {
161 continue;
162 }
163
164 frames_to_decode_ = std::move(current_superframe);
165
philipel6d216502018-10-22 14:36:45 +0200166 if (frame->RenderTime() == -1) {
Niels Möller23775882018-08-16 10:24:12 +0200167 frame->SetRenderTime(
168 timing_->RenderTimeMs(frame->Timestamp(), now_ms));
philipel6d216502018-10-22 14:36:45 +0200169 }
Ilya Nikolaevskiycd7c21b2019-01-14 15:27:08 +0100170 // If frames in superframe have different render timestamps, it will
171 // confuse jitter buffer and cause dropped frames in render queue.
172 for (size_t i = 1; i < frames_to_decode_.size(); ++i) {
173 frames_to_decode_[i]->second.frame->SetRenderTime(
174 frame->RenderTime());
175 }
philipele0b2f152016-09-28 10:23:49 +0200176 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
177
178 // This will cause the frame buffer to prefer high framerate rather
179 // than high resolution in the case of the decoder not decoding fast
180 // enough and the stream has multiple spatial and temporal layers.
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +0100181 // For multiple temporal layers it may cause non-base layer frames to be
182 // skipped if they are late.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +0100183 if (wait_ms < -kMaxAllowedFrameDelayMs)
philipele0b2f152016-09-28 10:23:49 +0200184 continue;
185
186 break;
187 }
188 } // rtc::Critscope lock(&crit_);
189
philipel1c056252017-01-31 09:53:12 -0800190 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms - now_ms);
philipele0b2f152016-09-28 10:23:49 +0200191 wait_ms = std::max<int64_t>(wait_ms, 0);
tommi0a735642017-03-14 06:23:57 -0700192 } while (new_continuous_frame_event_.Wait(wait_ms));
philipele0b2f152016-09-28 10:23:49 +0200193
philipel29f730e2017-03-15 08:10:08 -0700194 {
195 rtc::CritScope lock(&crit_);
196 now_ms = clock_->TimeInMilliseconds();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100197 std::vector<EncodedFrame*> frames_out;
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100198 for (FrameMap::iterator& frame_it : frames_to_decode_) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100199 RTC_DCHECK(frame_it != frames_.end());
200 EncodedFrame* frame = frame_it->second.frame.release();
philipele0b2f152016-09-28 10:23:49 +0200201
philipel29f730e2017-03-15 08:10:08 -0700202 if (!frame->delayed_by_retransmission()) {
203 int64_t frame_delay;
philipele0754302017-01-25 08:56:23 -0800204
Niels Möller23775882018-08-16 10:24:12 +0200205 if (inter_frame_delay_.CalculateDelay(frame->Timestamp(), &frame_delay,
philipel29f730e2017-03-15 08:10:08 -0700206 frame->ReceivedTime())) {
207 jitter_estimator_->UpdateEstimate(frame_delay, frame->size());
208 }
209
210 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
“Michaelf9fc1712018-08-27 10:08:58 -0500211 if (RttMultExperiment::RttMultEnabled()) {
212 rtt_mult = RttMultExperiment::GetRttMultValue();
213 }
philipel29f730e2017-03-15 08:10:08 -0700214 timing_->SetJitterDelay(jitter_estimator_->GetJitterEstimate(rtt_mult));
215 timing_->UpdateCurrentDelay(frame->RenderTime(), now_ms);
philipele21be1d2017-09-25 06:37:12 -0700216 } else {
“Michaelf9fc1712018-08-27 10:08:58 -0500217 if (RttMultExperiment::RttMultEnabled() ||
218 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay"))
philipel707f2782017-10-02 14:10:28 +0200219 jitter_estimator_->FrameNacked();
philipele0754302017-01-25 08:56:23 -0800220 }
221
stefan95e97542017-05-23 09:52:18 -0700222 // Gracefully handle bad RTP timestamps and render time issues.
223 if (HasBadRenderTiming(*frame, now_ms)) {
224 jitter_estimator_->Reset();
225 timing_->Reset();
Niels Möller23775882018-08-16 10:24:12 +0200226 frame->SetRenderTime(timing_->RenderTimeMs(frame->Timestamp(), now_ms));
stefan95e97542017-05-23 09:52:18 -0700227 }
228
philipel29f730e2017-03-15 08:10:08 -0700229 UpdateJitterDelay();
ilnik2edc6842017-07-06 03:06:50 -0700230 UpdateTimingFrameInfo();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100231 PropagateDecodability(frame_it->second);
brandtr9078d8c2017-04-27 07:07:27 -0700232
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100233 decoded_frames_history_.InsertDecoded(frame_it->first,
234 frame->Timestamp());
235
236 // Remove decoded frame and all undecoded frames before it.
237 frames_.erase(frames_.begin(), ++frame_it);
238
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100239 frames_out.push_back(frame);
240 }
241
242 if (!frames_out.empty()) {
243 if (frames_out.size() == 1) {
244 frame_out->reset(frames_out[0]);
245 } else {
246 frame_out->reset(CombineAndDeleteFrames(frames_out));
247 }
philipel29f730e2017-03-15 08:10:08 -0700248 return kFrameFound;
philipelbe7a9e52016-05-19 12:19:35 +0200249 }
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100250 } // rtc::Critscope lock(&crit_)
tommi0a735642017-03-14 06:23:57 -0700251
252 if (latest_return_time_ms - now_ms > 0) {
philipel1c056252017-01-31 09:53:12 -0800253 // If |next_frame_it_ == frames_.end()| and there is still time left, it
254 // means that the frame buffer was cleared as the thread in this function
255 // was waiting to acquire |crit_| in order to return. Wait for the
256 // remaining time and then return.
257 return NextFrame(latest_return_time_ms - now_ms, frame_out);
philipelbe7a9e52016-05-19 12:19:35 +0200258 }
tommi0a735642017-03-14 06:23:57 -0700259 return kTimeout;
philipelbe7a9e52016-05-19 12:19:35 +0200260}
261
philipele7c891f2018-02-22 14:35:06 +0100262bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
263 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700264 // Assume that render timing errors are due to changes in the video stream.
265 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200266 // Zero render time means render immediately.
267 if (render_time_ms == 0) {
268 return false;
269 }
stefan95e97542017-05-23 09:52:18 -0700270 if (render_time_ms < 0) {
271 return true;
272 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200273 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700274 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
275 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100276 RTC_LOG(LS_WARNING)
277 << "A frame about to be decoded is out of the configured "
278 << "delay bounds (" << frame_delay << " > " << kMaxVideoDelayMs
279 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700280 return true;
281 }
282 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100283 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
284 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700285 return true;
286 }
287 return false;
288}
289
philipel4f6cd6a2016-08-03 10:59:32 +0200290void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800291 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
philipel4f6cd6a2016-08-03 10:59:32 +0200292 rtc::CritScope lock(&crit_);
293 protection_mode_ = mode;
294}
295
philipel504c47d2016-06-30 17:33:02 +0200296void FrameBuffer::Start() {
tommidb23ea62017-03-03 07:21:18 -0800297 TRACE_EVENT0("webrtc", "FrameBuffer::Start");
philipel29f730e2017-03-15 08:10:08 -0700298 rtc::CritScope lock(&crit_);
299 stopped_ = false;
philipel504c47d2016-06-30 17:33:02 +0200300}
301
302void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800303 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
philipel29f730e2017-03-15 08:10:08 -0700304 rtc::CritScope lock(&crit_);
305 stopped_ = true;
tommi0a735642017-03-14 06:23:57 -0700306 new_continuous_frame_event_.Set();
philipel504c47d2016-06-30 17:33:02 +0200307}
308
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100309void FrameBuffer::Clear() {
310 rtc::CritScope lock(&crit_);
311 ClearFramesAndHistory();
312}
313
philipele21be1d2017-09-25 06:37:12 -0700314void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
315 rtc::CritScope lock(&crit_);
316 jitter_estimator_->UpdateRtt(rtt_ms);
317}
318
philipele7c891f2018-02-22 14:35:06 +0100319bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel0fa82a62018-03-19 15:34:53 +0100320 if (frame.id.picture_id < 0)
philipel3b3c9c42017-09-11 09:38:36 -0700321 return false;
322
philipel112adf92017-06-15 09:06:21 -0700323 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100324 if (frame.references[i] < 0 || frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700325 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700326
philipel112adf92017-06-15 09:06:21 -0700327 for (size_t j = i + 1; j < frame.num_references; ++j) {
328 if (frame.references[i] == frame.references[j])
329 return false;
330 }
331 }
332
philipel0fa82a62018-03-19 15:34:53 +0100333 if (frame.inter_layer_predicted && frame.id.spatial_layer == 0)
philipel112adf92017-06-15 09:06:21 -0700334 return false;
335
336 return true;
337}
338
philipele7c891f2018-02-22 14:35:06 +0100339void FrameBuffer::UpdatePlayoutDelays(const EncodedFrame& frame) {
gnishb2a318b2017-05-10 09:21:33 -0700340 TRACE_EVENT0("webrtc", "FrameBuffer::UpdatePlayoutDelays");
341 PlayoutDelay playout_delay = frame.EncodedImage().playout_delay_;
342 if (playout_delay.min_ms >= 0)
343 timing_->set_min_playout_delay(playout_delay.min_ms);
344
345 if (playout_delay.max_ms >= 0)
346 timing_->set_max_playout_delay(playout_delay.max_ms);
philipel0a9f6de2018-02-28 11:29:47 +0100347
348 if (!frame.delayed_by_retransmission())
Niels Möller23775882018-08-16 10:24:12 +0200349 timing_->IncomingTimestamp(frame.Timestamp(), frame.ReceivedTime());
gnishb2a318b2017-05-10 09:21:33 -0700350}
351
philipele7c891f2018-02-22 14:35:06 +0100352int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800353 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200354 RTC_DCHECK(frame);
philipela45102f2017-02-22 05:30:39 -0800355 if (stats_callback_)
ilnik6d5b4d62017-08-30 03:32:14 -0700356 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
357 frame->contentType());
philipel0fa82a62018-03-19 15:34:53 +0100358 const VideoLayerFrameId& id = frame->id;
tommi0a735642017-03-14 06:23:57 -0700359
360 rtc::CritScope lock(&crit_);
philipel29f730e2017-03-15 08:10:08 -0700361
philipel1610f942017-12-12 13:58:31 +0100362 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100363 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200364
philipel112adf92017-06-15 09:06:21 -0700365 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100366 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100367 << id.picture_id << ":"
368 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100369 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700370 return last_continuous_picture_id;
371 }
372
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100373 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100374 if (frame->is_keyframe()) {
375 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100376 << id.picture_id << ":"
377 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100378 << ") but buffer is full, clearing"
379 << " buffer and inserting the frame.";
380 ClearFramesAndHistory();
381 } else {
382 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100383 << id.picture_id << ":"
384 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100385 << ") could not be inserted due to the frame "
386 << "buffer being full, dropping frame.";
387 return last_continuous_picture_id;
388 }
philipele0b2f152016-09-28 10:23:49 +0200389 }
390
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100391 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
392 auto last_decoded_frame_timestamp =
393 decoded_frames_history_.GetLastDecodedFrameTimestamp();
394 if (last_decoded_frame && id <= *last_decoded_frame) {
395 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700396 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800397 // If this frame has a newer timestamp but an earlier picture id then we
398 // assume there has been a jump in the picture id due to some encoder
399 // reconfiguration or some other reason. Even though this is not according
400 // to spec we can still continue to decode from this frame if it is a
401 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100402 RTC_LOG(LS_WARNING)
403 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800404 ClearFramesAndHistory();
405 last_continuous_picture_id = -1;
406 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100407 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100408 << id.picture_id << ":"
409 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100410 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100411 << last_decoded_frame->picture_id << ":"
412 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100413 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800414 return last_continuous_picture_id;
415 }
philipele0b2f152016-09-28 10:23:49 +0200416 }
417
philipel146a48b2017-04-20 04:04:38 -0700418 // Test if inserting this frame would cause the order of the frames to become
419 // ambiguous (covering more than half the interval of 2^16). This can happen
420 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100421 if (!frames_.empty() && id < frames_.begin()->first &&
422 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100423 RTC_LOG(LS_WARNING)
424 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700425 ClearFramesAndHistory();
426 last_continuous_picture_id = -1;
427 }
428
philipel0fa82a62018-03-19 15:34:53 +0100429 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200430
philipel93e451b2016-10-06 12:25:13 +0200431 if (info->second.frame) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100432 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100433 << id.picture_id << ":"
434 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100435 << ") already inserted, dropping frame.";
philipele0b2f152016-09-28 10:23:49 +0200436 return last_continuous_picture_id;
437 }
438
philipel93e451b2016-10-06 12:25:13 +0200439 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
440 return last_continuous_picture_id;
gnishb2a318b2017-05-10 09:21:33 -0700441 UpdatePlayoutDelays(*frame);
philipel0a9f6de2018-02-28 11:29:47 +0100442
philipele0b2f152016-09-28 10:23:49 +0200443 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200444
445 if (info->second.num_missing_continuous == 0) {
446 info->second.continuous = true;
447 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100448 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200449
450 // Since we now have new continuous frames there might be a better frame
451 // to return from NextFrame. Signal that thread so that it again can choose
452 // which frame to return.
tommi0a735642017-03-14 06:23:57 -0700453 new_continuous_frame_event_.Set();
philipele0b2f152016-09-28 10:23:49 +0200454 }
455
456 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200457}
458
philipele0b2f152016-09-28 10:23:49 +0200459void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800460 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200461 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200462
463 std::queue<FrameMap::iterator> continuous_frames;
464 continuous_frames.push(start);
465
466 // A simple BFS to traverse continuous frames.
467 while (!continuous_frames.empty()) {
468 auto frame = continuous_frames.front();
469 continuous_frames.pop();
470
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100471 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
472 last_continuous_frame_ = frame->first;
473 }
philipele0b2f152016-09-28 10:23:49 +0200474
475 // Loop through all dependent frames, and if that frame no longer has
476 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100477 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200478 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700479 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200480
philipel112adf92017-06-15 09:06:21 -0700481 // TODO(philipel): Look into why we've seen this happen.
482 if (frame_ref != frames_.end()) {
483 --frame_ref->second.num_missing_continuous;
484 if (frame_ref->second.num_missing_continuous == 0) {
485 frame_ref->second.continuous = true;
486 continuous_frames.push(frame_ref);
487 }
philipele0b2f152016-09-28 10:23:49 +0200488 }
489 }
490 }
491}
492
493void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800494 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100495 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200496 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200497 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700498 // TODO(philipel): Look into why we've seen this happen.
499 if (ref_info != frames_.end()) {
500 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
501 --ref_info->second.num_missing_decodable;
502 }
philipele0b2f152016-09-28 10:23:49 +0200503 }
504}
505
philipele7c891f2018-02-22 14:35:06 +0100506bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200507 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800508 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100509 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200510
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100511 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
512 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200513
philipel798b2822018-06-11 13:10:14 +0200514 // In this function we determine how many missing dependencies this |frame|
515 // has to become continuous/decodable. If a frame that this |frame| depend
516 // on has already been decoded then we can ignore that dependency since it has
517 // already been fulfilled.
518 //
519 // For all other frames we will register a backwards reference to this |frame|
520 // so that |num_missing_continuous| and |num_missing_decodable| can be
521 // decremented as frames become continuous/are decoded.
522 struct Dependency {
523 VideoLayerFrameId id;
524 bool continuous;
525 };
526 std::vector<Dependency> not_yet_fulfilled_dependencies;
527
528 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200529 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100530 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200531 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100532 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200533 // Was that frame decoded? If not, this |frame| will never become
534 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100535 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700536 int64_t now_ms = clock_->TimeInMilliseconds();
537 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100538 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100539 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
540 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700541 << ") depends on a non-decoded frame more previous than"
542 << " the last decoded frame, dropping frame.";
543 last_log_non_decoded_ms_ = now_ms;
544 }
philipele0b2f152016-09-28 10:23:49 +0200545 return false;
546 }
philipele0b2f152016-09-28 10:23:49 +0200547 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100548 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200549 bool ref_continuous =
550 ref_info != frames_.end() && ref_info->second.continuous;
551 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200552 }
philipelbe7a9e52016-05-19 12:19:35 +0200553 }
554
philipel798b2822018-06-11 13:10:14 +0200555 // Does |frame| depend on the lower spatial layer?
philipelbe7a9e52016-05-19 12:19:35 +0200556 if (frame.inter_layer_predicted) {
philipel0fa82a62018-03-19 15:34:53 +0100557 VideoLayerFrameId ref_key(frame.id.picture_id, frame.id.spatial_layer - 1);
philipel798b2822018-06-11 13:10:14 +0200558 auto ref_info = frames_.find(ref_key);
philipele0b2f152016-09-28 10:23:49 +0200559
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100560 bool lower_layer_decoded =
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100561 last_decoded_frame && *last_decoded_frame == ref_key;
philipel798b2822018-06-11 13:10:14 +0200562 bool lower_layer_continuous =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100563 lower_layer_decoded ||
564 (ref_info != frames_.end() && ref_info->second.continuous);
philipel798b2822018-06-11 13:10:14 +0200565
566 if (!lower_layer_continuous || !lower_layer_decoded) {
567 not_yet_fulfilled_dependencies.push_back(
568 {ref_key, lower_layer_continuous});
philipele0b2f152016-09-28 10:23:49 +0200569 }
philipelbe7a9e52016-05-19 12:19:35 +0200570 }
571
philipel798b2822018-06-11 13:10:14 +0200572 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
573 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
574
575 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
576 if (dep.continuous)
577 --info->second.num_missing_continuous;
578
Elad Alon69321dd2019-01-10 15:02:54 +0100579 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200580 }
philipel93e451b2016-10-06 12:25:13 +0200581
philipelbe7a9e52016-05-19 12:19:35 +0200582 return true;
583}
584
philipelbe742702016-11-30 01:31:40 -0800585void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800586 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800587 if (!stats_callback_)
588 return;
philipelbe742702016-11-30 01:31:40 -0800589
philipela45102f2017-02-22 05:30:39 -0800590 int decode_ms;
591 int max_decode_ms;
592 int current_delay_ms;
593 int target_delay_ms;
594 int jitter_buffer_ms;
595 int min_playout_delay_ms;
596 int render_delay_ms;
597 if (timing_->GetTimings(&decode_ms, &max_decode_ms, &current_delay_ms,
598 &target_delay_ms, &jitter_buffer_ms,
599 &min_playout_delay_ms, &render_delay_ms)) {
600 stats_callback_->OnFrameBufferTimingsUpdated(
601 decode_ms, max_decode_ms, current_delay_ms, target_delay_ms,
602 jitter_buffer_ms, min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800603 }
philipel266f0a42016-11-28 08:49:07 -0800604}
605
ilnik2edc6842017-07-06 03:06:50 -0700606void FrameBuffer::UpdateTimingFrameInfo() {
607 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200608 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100609 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700610 stats_callback_->OnTimingFrameInfoUpdated(*info);
611}
612
philipelfcc60062017-01-18 05:35:20 -0800613void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700614 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
philipelfcc60062017-01-18 05:35:20 -0800615 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100616 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100617 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100618 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800619}
620
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100621EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
622 const std::vector<EncodedFrame*>& frames) const {
623 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100624 EncodedFrame* first_frame = frames[0];
625 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100626 size_t total_length = 0;
627 for (size_t i = 0; i < frames.size(); ++i) {
628 total_length += frames[i]->size();
629 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100630 first_frame->VerifyAndAllocate(total_length);
631
632 // Spatial index of combined frame is set equal to spatial index of its top
633 // spatial layer.
634 first_frame->SetSpatialIndex(last_frame->id.spatial_layer);
635 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
636
637 first_frame->video_timing_mutable()->network2_timestamp_ms =
638 last_frame->video_timing().network2_timestamp_ms;
639 first_frame->video_timing_mutable()->receive_finish_ms =
640 last_frame->video_timing().receive_finish_ms;
641
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100642 // Append all remaining frames to the first one.
Niels Möller9c843902019-01-11 10:21:35 +0100643 uint8_t* buffer = first_frame->data() + first_frame->size();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100644 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100645 EncodedFrame* next_frame = frames[i];
Niels Möller9c843902019-01-11 10:21:35 +0100646 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100647 buffer += next_frame->size();
648 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100649 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100650 first_frame->set_size(total_length);
651 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100652}
653
Niels Möllerbe682d42018-03-27 08:31:45 +0200654FrameBuffer::FrameInfo::FrameInfo() = default;
655FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
656FrameBuffer::FrameInfo::~FrameInfo() = default;
657
philipelbe7a9e52016-05-19 12:19:35 +0200658} // namespace video_coding
659} // namespace webrtc