blob: 8453f17481cc17ba924b83fd0e84d3446140de00 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <memory>
12#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020015#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070017#include "api/jsep.h"
18#include "api/mediastreaminterface.h"
19#include "api/peerconnectioninterface.h"
Yves Gerey2e00abc2018-10-05 15:39:24 +020020#include "api/umametrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020021#include "api/video_codecs/builtin_video_decoder_factory.h"
22#include "api/video_codecs/builtin_video_encoder_factory.h"
Seth Hampson5b4f0752018-04-02 16:31:36 -070023#include "pc/mediasession.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070024#include "pc/mediastream.h"
25#include "pc/mediastreamtrack.h"
26#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080027#include "pc/sdputils.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070028#include "pc/test/fakeaudiocapturemodule.h"
29#include "pc/test/mockpeerconnectionobservers.h"
30#include "rtc_base/checks.h"
31#include "rtc_base/gunit.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070032#include "rtc_base/refcountedobject.h"
33#include "rtc_base/scoped_ref_ptr.h"
34#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020035#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080036#include "test/gmock.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070037
38// This file contains tests for RTP Media API-related behavior of
39// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
40
Steve Anton9158ef62017-11-27 13:01:52 -080041namespace webrtc {
42
43using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
44using ::testing::ElementsAre;
45using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070046using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070047
Henrik Boström31638672017-11-23 17:48:32 +010048const uint32_t kDefaultTimeout = 10000u;
49
50template <typename MethodFunctor>
51class OnSuccessObserver : public rtc::RefCountedObject<
52 webrtc::SetRemoteDescriptionObserverInterface> {
53 public:
54 explicit OnSuccessObserver(MethodFunctor on_success)
55 : on_success_(std::move(on_success)) {}
56
57 // webrtc::SetRemoteDescriptionObserverInterface implementation.
58 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
59 RTC_CHECK(error.ok());
60 on_success_();
61 }
62
63 private:
64 MethodFunctor on_success_;
65};
66
Steve Anton3172c032018-05-03 15:30:18 -070067class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070068 public:
Steve Anton3172c032018-05-03 15:30:18 -070069 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
70 : sdp_semantics_(sdp_semantics),
71 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080072 CreatePeerConnectionFactory(rtc::Thread::Current(),
73 rtc::Thread::Current(),
74 rtc::Thread::Current(),
75 FakeAudioCaptureModule::Create(),
76 CreateBuiltinAudioEncoderFactory(),
77 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +020078 CreateBuiltinVideoEncoderFactory(),
79 CreateBuiltinVideoDecoderFactory(),
80 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -070081 nullptr /* audio_processing */)) {
82 webrtc::metrics::Reset();
83 }
Henrik Boström933d8b02017-10-10 10:05:16 -070084
Steve Anton9158ef62017-11-27 13:01:52 -080085 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
86 return CreatePeerConnection(RTCConfiguration());
87 }
88
Steve Antone831b8c2018-02-01 12:22:16 -080089 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
90 RTCConfiguration config;
91 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -070092 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -080093 }
94
Steve Anton9158ef62017-11-27 13:01:52 -080095 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
96 RTCConfiguration config;
97 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -070098 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -080099 }
100
101 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
102 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700103 RTCConfiguration modified_config = config;
104 modified_config.sdp_semantics = sdp_semantics_;
105 return CreatePeerConnectionInternal(modified_config);
106 }
107
108 protected:
109 const SdpSemantics sdp_semantics_;
110 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
111
112 private:
113 // Private so that tests don't accidentally bypass the SdpSemantics
114 // adjustment.
115 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
116 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200117 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700118 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
119 observer.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200120 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
121 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700122 }
Steve Anton3172c032018-05-03 15:30:18 -0700123};
Henrik Boström933d8b02017-10-10 10:05:16 -0700124
Steve Anton3172c032018-05-03 15:30:18 -0700125class PeerConnectionRtpTest
126 : public PeerConnectionRtpBaseTest,
127 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700128 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700129 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
130};
131
132class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
133 protected:
134 PeerConnectionRtpTestPlanB()
135 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
136};
137
138class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
139 protected:
140 PeerConnectionRtpTestUnifiedPlan()
141 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700142};
143
Henrik Boström31638672017-11-23 17:48:32 +0100144// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
145// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100146
Steve Anton3172c032018-05-03 15:30:18 -0700147TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700148 auto caller = CreatePeerConnection();
149 auto callee = CreatePeerConnection();
150
Steve Anton3172c032018-05-03 15:30:18 -0700151 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700152 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700153
Henrik Boström31638672017-11-23 17:48:32 +0100154 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700155 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100156 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700157
158 if (sdp_semantics_ == SdpSemantics::kPlanB) {
159 // Since we are not supporting the no stream case with Plan B, there should
160 // be a generated stream, even though we didn't set one with AddTrack.
161 ASSERT_EQ(1u, add_track_event.streams.size());
162 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
163 } else {
164 EXPECT_EQ(0u, add_track_event.streams.size());
165 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700166}
167
Steve Anton3172c032018-05-03 15:30:18 -0700168TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700169 auto caller = CreatePeerConnection();
170 auto callee = CreatePeerConnection();
171
Steve Anton3172c032018-05-03 15:30:18 -0700172 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700173 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700174
Henrik Boström31638672017-11-23 17:48:32 +0100175 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100176 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100177 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700178 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100179 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
180 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700181}
182
Steve Anton3172c032018-05-03 15:30:18 -0700183TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700184 auto caller = CreatePeerConnection();
185 auto callee = CreatePeerConnection();
186
Steve Anton3172c032018-05-03 15:30:18 -0700187 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700188 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100189 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700190 ASSERT_TRUE(
191 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
192
Henrik Boström933d8b02017-10-10 10:05:16 -0700193 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700194 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700195
Henrik Boström31638672017-11-23 17:48:32 +0100196 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700197 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
198 callee->observer()->remove_track_events_);
199}
200
Steve Anton3172c032018-05-03 15:30:18 -0700201TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700202 auto caller = CreatePeerConnection();
203 auto callee = CreatePeerConnection();
204
Steve Anton3172c032018-05-03 15:30:18 -0700205 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700206 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100207 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700208 ASSERT_TRUE(
209 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
210
Henrik Boström933d8b02017-10-10 10:05:16 -0700211 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700212 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700213
Henrik Boström31638672017-11-23 17:48:32 +0100214 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700215 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
216 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700217 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700218}
219
Steve Anton3172c032018-05-03 15:30:18 -0700220TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700221 auto caller = CreatePeerConnection();
222 auto callee = CreatePeerConnection();
223
Seth Hampson845e8782018-03-02 11:34:10 -0800224 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700225 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
226 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700227 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100228 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700229 ASSERT_TRUE(
230 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700231
232 // Remove "audio_track1".
233 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700234 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100235 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700236 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800237 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700238 callee->observer()->add_track_events_[0].receiver},
239 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700240 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
241 ASSERT_TRUE(
242 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700243
244 // Remove "audio_track2".
245 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700246 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100247 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700248 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
249 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700250 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700251}
252
Seth Hampson5b4f0752018-04-02 16:31:36 -0700253// Tests the edge case that if a stream ID changes for a given track that both
254// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700255TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700256 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
257 auto caller = CreatePeerConnection();
258 auto callee = CreatePeerConnection();
259
260 const char kStreamId1[] = "stream1";
261 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700262 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700263 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700264 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
265
266 // Change the stream ID of the sender in the session description.
267 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700268 auto* audio_desc =
269 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700270 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
271 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700272 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700273
274 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
275 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
276 kStreamId2);
277 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
278 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
279 kStreamId1);
280}
281
Steve Anton8b815cd2018-02-16 16:14:42 -0800282// Tests that setting a remote description with sending transceivers will fire
283// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700284// with receive only transceivers will not call OnTrack. One transceiver is
285// created without any stream_ids, while the other is created with multiple
286// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700287TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700288 const std::string kStreamId1 = "video_stream1";
289 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700290 auto caller = CreatePeerConnection();
291 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800292
293 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700294 RtpTransceiverInit video_transceiver_init;
295 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
296 auto video_transceiver =
297 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800298
299 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
300
301 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
302 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
303 EXPECT_EQ(audio_transceiver->mid(),
304 callee->pc()->GetTransceivers()[0]->mid());
305 EXPECT_EQ(video_transceiver->mid(),
306 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700307 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
308 callee->pc()->GetTransceivers()[0]->receiver()->streams();
309 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
310 callee->pc()->GetTransceivers()[1]->receiver()->streams();
311 ASSERT_EQ(0u, audio_streams.size());
312 ASSERT_EQ(2u, video_streams.size());
313 EXPECT_EQ(kStreamId1, video_streams[0]->id());
314 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800315}
316
317// Test that doing additional offer/answer exchanges with no changes to tracks
318// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700319TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
320 auto caller = CreatePeerConnection();
321 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800322
323 caller->AddAudioTrack("audio");
324 callee->AddAudioTrack("audio");
325
326 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
327 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
328 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
329
330 // If caller reoffers with no changes expect no additional OnTrack calls.
331 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
332 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
333 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
334
335 // Also if callee reoffers with no changes expect no additional OnTrack calls.
336 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
337 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
338 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
339}
340
341// Test that OnTrack is called when the transceiver direction changes to send
342// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700343TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
344 auto caller = CreatePeerConnection();
345 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800346
347 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
348 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
349 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
350 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
351 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
352
353 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
354 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
355 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
356 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
357
358 // If the direction changes but it is still receiving on the remote side, then
359 // OnTrack should not be fired again.
360 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
361 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
362 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
363 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
364}
365
366// Test that OnTrack is called twice when a sendrecv call is started, the callee
367// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700368TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
369 auto caller = CreatePeerConnection();
370 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800371
372 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
373
374 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
375 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
376 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
377
378 // Put the call on hold by no longer receiving the track.
379 callee->pc()->GetTransceivers()[0]->SetDirection(
380 RtpTransceiverDirection::kInactive);
381
382 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
383 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
384 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
385
386 // Resume the call by changing the direction to recvonly. This should call
387 // OnTrack again on the callee side.
388 callee->pc()->GetTransceivers()[0]->SetDirection(
389 RtpTransceiverDirection::kRecvOnly);
390
391 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
392 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
393 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
394}
395
Steve Anton3172c032018-05-03 15:30:18 -0700396// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700397// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700398TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700399 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100400 auto caller = CreatePeerConnection();
401 auto callee = CreatePeerConnection();
402
Steve Anton3172c032018-05-03 15:30:18 -0700403 caller->AddAudioTrack("audio_track", {});
404
405 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
406 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
407
408 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700409 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700410}
411
412// Test that setting a remote offer twice with no answer in the middle and the
413// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700414// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700415TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700416 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700417 auto caller = CreatePeerConnection();
418 auto callee = CreatePeerConnection();
419
420 auto sender = caller->AddAudioTrack("audio_track", {});
421
422 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
423 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700424 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700425
426 caller->pc()->RemoveTrack(sender);
427
428 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
429 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700430 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
431}
432
433// Test that changing the direction from receiving to not receiving between
434// setting the remote offer and creating / setting the local answer results in
435// a remove track event when SetLocalDescription is called.
436TEST_F(PeerConnectionRtpTestUnifiedPlan,
437 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
438 auto caller = CreatePeerConnection();
439 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
440 auto callee = CreatePeerConnection();
441 callee->AddAudioTrack("audio_track", {});
442
443 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
444 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700445 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700446
447 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
448 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
449
450 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
451 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
452 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700453}
454
455// These tests examine the state of the peer connection as a result of
456// performing SetRemoteDescription().
457
458TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
459 auto caller = CreatePeerConnection();
460 auto callee = CreatePeerConnection();
461
462 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700463 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100464
465 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
466 auto receiver_added = callee->pc()->GetReceivers()[0];
467 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700468
469 if (sdp_semantics_ == SdpSemantics::kPlanB) {
470 // Since we are not supporting the no stream case with Plan B, there should
471 // be a generated stream, even though we didn't set one with AddTrack.
472 ASSERT_EQ(1u, receiver_added->streams().size());
473 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
474 } else {
475 EXPECT_EQ(0u, receiver_added->streams().size());
476 }
Henrik Boström31638672017-11-23 17:48:32 +0100477}
478
Steve Anton3172c032018-05-03 15:30:18 -0700479TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100480 auto caller = CreatePeerConnection();
481 auto callee = CreatePeerConnection();
482
Steve Anton3172c032018-05-03 15:30:18 -0700483 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700484 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100485
486 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
487 auto receiver_added = callee->pc()->GetReceivers()[0];
488 EXPECT_EQ("audio_track", receiver_added->track()->id());
489 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700490 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100491 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
492}
493
Steve Anton3172c032018-05-03 15:30:18 -0700494TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100495 auto caller = CreatePeerConnection();
496 auto callee = CreatePeerConnection();
497
Steve Anton3172c032018-05-03 15:30:18 -0700498 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100499 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700500 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
501
Henrik Boström31638672017-11-23 17:48:32 +0100502 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
503 auto receiver = callee->pc()->GetReceivers()[0];
504 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700505 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100506
Steve Anton3172c032018-05-03 15:30:18 -0700507 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
508 // With Unified Plan the receiver stays but the transceiver transitions to
509 // inactive.
510 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
511 EXPECT_EQ(RtpTransceiverDirection::kInactive,
512 callee->pc()->GetTransceivers()[0]->current_direction());
513 } else {
514 // With Plan B the receiver is removed.
515 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
516 }
Henrik Boström31638672017-11-23 17:48:32 +0100517}
518
Steve Anton3172c032018-05-03 15:30:18 -0700519TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100520 auto caller = CreatePeerConnection();
521 auto callee = CreatePeerConnection();
522
Steve Anton3172c032018-05-03 15:30:18 -0700523 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100524 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700525 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100526 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
527 auto receiver = callee->pc()->GetReceivers()[0];
528 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700529 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100530
Steve Anton3172c032018-05-03 15:30:18 -0700531 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
532 // With Unified Plan the receiver stays but the transceiver transitions to
533 // inactive.
534 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
535 EXPECT_EQ(RtpTransceiverDirection::kInactive,
536 callee->pc()->GetTransceivers()[0]->current_direction());
537 } else {
538 // With Plan B the receiver is removed.
539 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
540 }
Henrik Boström31638672017-11-23 17:48:32 +0100541}
542
Steve Anton3172c032018-05-03 15:30:18 -0700543TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100544 auto caller = CreatePeerConnection();
545 auto callee = CreatePeerConnection();
546
Seth Hampson845e8782018-03-02 11:34:10 -0800547 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700548 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
549 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
550 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
551 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100552
553 // Remove "audio_track1".
554 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700555 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
556
557 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
558 // With Unified Plan the receiver stays but the transceiver transitions to
559 // inactive.
560 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
561 auto transceiver = callee->pc()->GetTransceivers()[0];
562 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
563 EXPECT_EQ(RtpTransceiverDirection::kInactive,
564 transceiver->current_direction());
565 } else {
566 // With Plan B the receiver is removed.
567 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
568 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
569 }
Henrik Boström31638672017-11-23 17:48:32 +0100570
571 // Remove "audio_track2".
572 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700573 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
574
575 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
576 // With Unified Plan the receiver stays but the transceiver transitions to
577 // inactive.
578 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
579 auto transceiver = callee->pc()->GetTransceivers()[1];
580 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
581 EXPECT_EQ(RtpTransceiverDirection::kInactive,
582 transceiver->current_direction());
583 } else {
584 // With Plan B the receiver is removed.
585 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
586 }
Henrik Boström31638672017-11-23 17:48:32 +0100587}
588
Florent Castelliabe301f2018-06-12 18:33:49 +0200589TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
590 auto caller = CreatePeerConnection();
591 auto callee = CreatePeerConnection();
592 auto sender = caller->AddAudioTrack("audio_track");
593 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
594
595 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
596 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
597
598 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
599 auto receiver = callee->pc()->GetReceivers()[0];
600 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
601}
602
603TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
604 auto caller = CreatePeerConnection();
605 auto callee = CreatePeerConnection();
606 auto sender = caller->AddVideoTrack("video_track");
607 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
608
609 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
610 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
611
612 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
613 auto receiver = callee->pc()->GetReceivers()[0];
614 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
615}
616
Henrik Boström31638672017-11-23 17:48:32 +0100617// Invokes SetRemoteDescription() twice in a row without synchronizing the two
618// calls and examine the state of the peer connection inside the callbacks to
619// ensure that the second call does not occur prematurely, contaminating the
620// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700621TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100622 StatesCorrelateWithSetRemoteDescriptionCall) {
623 auto caller = CreatePeerConnection();
624 auto callee = CreatePeerConnection();
625
Henrik Boström31638672017-11-23 17:48:32 +0100626 // Create SDP for adding a track and for removing it. This will be used in the
627 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700628 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100629 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
630 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
631 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
632
633 // In the first SetRemoteDescription() callback, check that we have a
634 // receiver for the track.
635 auto pc = callee->pc();
636 bool srd1_callback_called = false;
637 auto srd1_callback = [&srd1_callback_called, &pc]() {
638 EXPECT_EQ(pc->GetReceivers().size(), 1u);
639 srd1_callback_called = true;
640 };
641
642 // In the second SetRemoteDescription() callback, check that the receiver has
643 // been removed.
644 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
645 // Instead, the transceiver owning the receiver will become inactive.
646 // https://crbug.com/webrtc/7600
647 bool srd2_callback_called = false;
648 auto srd2_callback = [&srd2_callback_called, &pc]() {
649 EXPECT_TRUE(pc->GetReceivers().empty());
650 srd2_callback_called = true;
651 };
652
653 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
654 // calls. The callbacks verify that the two calls are synchronized, as in, the
655 // effects of the second SetRemoteDescription() call must not have happened by
656 // the time the first callback is invoked. If it has then the receiver that is
657 // added as a result of the first SetRemoteDescription() call will already
658 // have been removed as a result of the second SetRemoteDescription() call
659 // when the first callback is invoked.
660 callee->pc()->SetRemoteDescription(
661 std::move(srd1_sdp),
662 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
663 callee->pc()->SetRemoteDescription(
664 std::move(srd2_sdp),
665 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
666 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
667 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
668}
669
Seth Hampson5897a6e2018-04-03 11:16:33 -0700670// Tests that a remote track is created with the signaled MSIDs when they are
671// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
672// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700673TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
674 auto caller = CreatePeerConnection();
675 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700676 const char kStreamId1[] = "stream1";
677 const char kStreamId2[] = "stream2";
678 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
679 {kStreamId1, kStreamId2});
680
681 auto offer = caller->CreateOfferAndSetAsLocal();
682 // Munge the offer to take out everything but the stream_ids.
683 auto contents = offer->description()->contents();
684 ASSERT_TRUE(!contents.empty());
685 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
686 std::vector<std::string> stream_ids =
687 contents[0].media_description()->streams()[0].stream_ids();
688 contents[0].media_description()->mutable_streams().clear();
689 cricket::StreamParams new_stream;
690 new_stream.set_stream_ids(stream_ids);
691 contents[0].media_description()->AddStream(new_stream);
692
693 // Set the remote description and verify that the streams were added to the
694 // receiver correctly.
695 ASSERT_TRUE(
696 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
697 auto receivers = callee->pc()->GetReceivers();
698 ASSERT_EQ(receivers.size(), 1u);
699 ASSERT_EQ(receivers[0]->streams().size(), 2u);
700 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
701 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
702}
703
Seth Hampson5b4f0752018-04-02 16:31:36 -0700704// Tests that with Unified Plan if the the stream id changes for a track when
705// when setting a new remote description, that the media stream is updated
706// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700707// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
708// test.
709TEST_F(PeerConnectionRtpTestUnifiedPlan,
710 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700711 auto caller = CreatePeerConnection();
712 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700713
714 const char kStreamId1[] = "stream1";
715 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700716 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700717 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700718 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
719
720 // Change the stream id of the sender in the session description.
721 auto offer = caller->CreateOfferAndSetAsLocal();
722 auto contents = offer->description()->contents();
723 ASSERT_EQ(contents.size(), 1u);
724 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
725 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
726 {kStreamId2});
727
Steve Anton0f5400a2018-07-17 14:25:36 -0700728 // Set the remote description and verify that the stream was updated
729 // properly.
730 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700731 auto receivers = callee->pc()->GetReceivers();
732 ASSERT_EQ(receivers.size(), 1u);
733 ASSERT_EQ(receivers[0]->streams().size(), 1u);
734 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
735}
736
737// This tests a regression caught by a downstream client, that occured when
738// applying a remote description with a SessionDescription object that
739// contained StreamParams that didn't have ids. Although there were multiple
740// remote audio senders, FindSenderInfo didn't find them as unique, because
741// it looked up by StreamParam.id, which none had. This meant only one
742// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700743TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700744 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
745 auto caller = CreatePeerConnection();
746 auto callee = CreatePeerConnection();
747
748 const char kStreamId1[] = "stream1";
749 const char kStreamId2[] = "stream2";
750 caller->AddAudioTrack("audio_track1", {kStreamId1});
751 caller->AddAudioTrack("audio_track2", {kStreamId2});
752
753 auto offer = caller->CreateOfferAndSetAsLocal();
754 auto mutable_streams =
755 cricket::GetFirstAudioContentDescription(offer->description())
756 ->mutable_streams();
757 ASSERT_EQ(mutable_streams.size(), 2u);
758 // Clear the IDs in the StreamParams.
759 mutable_streams[0].id.clear();
760 mutable_streams[1].id.clear();
761 ASSERT_TRUE(
762 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
763
764 auto receivers = callee->pc()->GetReceivers();
765 ASSERT_EQ(receivers.size(), 2u);
766 ASSERT_EQ(receivers[0]->streams().size(), 1u);
767 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
768 ASSERT_EQ(receivers[1]->streams().size(), 1u);
769 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
770}
771
Henrik Boström31638672017-11-23 17:48:32 +0100772// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100773
774// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700775TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100776 auto caller = CreatePeerConnection();
777 auto callee = CreatePeerConnection();
778
779 std::string error;
780 ASSERT_TRUE(
781 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
782}
783
784// Verifies legacy behavior: The observer is not called if if the peer
785// connection is destroyed because the asynchronous callback is executed in the
786// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700787TEST_P(PeerConnectionRtpTest,
788 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100789 auto caller = CreatePeerConnection();
790 auto callee = CreatePeerConnection();
791
792 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
793 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
794
795 auto offer = caller->CreateOfferAndSetAsLocal();
796 callee->pc()->SetRemoteDescription(observer, offer.release());
797 callee = nullptr;
798 rtc::Thread::Current()->ProcessMessages(0);
799 EXPECT_FALSE(observer->called());
800}
801
Steve Antonf9381f02017-12-14 10:23:57 -0800802// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800803
804// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700805TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
806 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800807 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
808}
809
810// Test that a transceiver created with the audio kind has the correct initial
811// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700812TEST_F(PeerConnectionRtpTestUnifiedPlan,
813 AddTransceiverHasCorrectInitProperties) {
814 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800815
816 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200817 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800818 EXPECT_FALSE(transceiver->stopped());
819 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200820 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800821}
822
823// Test that adding a transceiver with the audio kind creates an audio sender
824// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700825TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800826 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700827 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800828
829 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800830 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800831
832 ASSERT_TRUE(transceiver->sender());
833 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
834
835 ASSERT_TRUE(transceiver->receiver());
836 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
837
838 auto track = transceiver->receiver()->track();
839 ASSERT_TRUE(track);
840 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
841 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
842}
843
844// Test that adding a transceiver with the video kind creates an video sender
845// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700846TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800847 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700848 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800849
850 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800851 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800852
853 ASSERT_TRUE(transceiver->sender());
854 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
855
856 ASSERT_TRUE(transceiver->receiver());
857 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
858
859 auto track = transceiver->receiver()->track();
860 ASSERT_TRUE(track);
861 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
862 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
863}
864
865// Test that after a call to AddTransceiver, the transceiver shows in
866// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
867// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700868TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
869 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800870
871 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
872 EXPECT_EQ(
873 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
874 caller->pc()->GetTransceivers());
875 EXPECT_EQ(
876 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
877 transceiver->sender()},
878 caller->pc()->GetSenders());
879 EXPECT_EQ(
880 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
881 transceiver->receiver()},
882 caller->pc()->GetReceivers());
883}
884
885// Test that the direction passed in through the AddTransceiver init parameter
886// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700887TEST_F(PeerConnectionRtpTestUnifiedPlan,
888 AddTransceiverWithDirectionIsReflected) {
889 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800890
891 RtpTransceiverInit init;
892 init.direction = RtpTransceiverDirection::kSendOnly;
893 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
894 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
895}
896
Steve Anton9158ef62017-11-27 13:01:52 -0800897// Test that calling AddTransceiver with a track creates a transceiver which has
898// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700899TEST_F(PeerConnectionRtpTestUnifiedPlan,
900 AddTransceiverWithTrackCreatesSenderWithTrack) {
901 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800902
903 auto audio_track = caller->CreateAudioTrack("audio track");
904 auto transceiver = caller->AddTransceiver(audio_track);
905
906 auto sender = transceiver->sender();
907 ASSERT_TRUE(sender->track());
908 EXPECT_EQ(audio_track, sender->track());
909
910 auto receiver = transceiver->receiver();
911 ASSERT_TRUE(receiver->track());
912 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
913 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
914 receiver->track()->state());
915}
916
917// Test that calling AddTransceiver twice with the same track creates distinct
918// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700919TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800920 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700921 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800922
923 auto audio_track = caller->CreateAudioTrack("audio track");
924
925 auto transceiver1 = caller->AddTransceiver(audio_track);
926 auto transceiver2 = caller->AddTransceiver(audio_track);
927
928 EXPECT_NE(transceiver1, transceiver2);
929
930 auto sender1 = transceiver1->sender();
931 auto sender2 = transceiver2->sender();
932 EXPECT_NE(sender1, sender2);
933 EXPECT_EQ(audio_track, sender1->track());
934 EXPECT_EQ(audio_track, sender2->track());
935
936 EXPECT_THAT(caller->pc()->GetTransceivers(),
937 UnorderedElementsAre(transceiver1, transceiver2));
938 EXPECT_THAT(caller->pc()->GetSenders(),
939 UnorderedElementsAre(sender1, sender2));
940}
941
Steve Anton3fe1b152017-12-12 10:20:08 -0800942// RtpTransceiver error handling tests.
943
Steve Anton3172c032018-05-03 15:30:18 -0700944TEST_F(PeerConnectionRtpTestUnifiedPlan,
945 AddTransceiverWithInvalidKindReturnsError) {
946 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800947
948 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
949 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
950}
951
Steve Anton3172c032018-05-03 15:30:18 -0700952TEST_F(PeerConnectionRtpTestUnifiedPlan,
953 CanClosePeerConnectionWithoutCrashing) {
954 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800955
956 caller->pc()->Close();
957}
958
Steve Antonf9381f02017-12-14 10:23:57 -0800959// Unified Plan AddTrack tests.
960
Steve Antonf9381f02017-12-14 10:23:57 -0800961// Test that adding an audio track creates a new audio RtpSender with the given
962// track.
Steve Anton3172c032018-05-03 15:30:18 -0700963TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
964 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800965
966 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800967 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800968 ASSERT_TRUE(sender);
969
970 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
971 EXPECT_EQ(audio_track, sender->track());
972}
973
974// Test that adding a video track creates a new video RtpSender with the given
975// track.
Steve Anton3172c032018-05-03 15:30:18 -0700976TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
977 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800978
979 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800980 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800981 ASSERT_TRUE(sender);
982
983 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
984 EXPECT_EQ(video_track, sender->track());
985}
986
987// Test that adding a track to a new PeerConnection creates an RtpTransceiver
988// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -0700989TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
990 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800991
992 auto sender = caller->AddAudioTrack("a");
993 ASSERT_TRUE(sender);
994
995 auto transceivers = caller->pc()->GetTransceivers();
996 ASSERT_EQ(1u, transceivers.size());
997 EXPECT_EQ(sender, transceivers[0]->sender());
998 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
999}
1000
1001// Test that if a transceiver of the same type but no track had been added to
1002// the PeerConnection and later a call to AddTrack is made, the resulting sender
1003// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001004TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1005 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001006
1007 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1008 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001009 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001010 ASSERT_TRUE(sender);
1011
1012 auto transceivers = caller->pc()->GetTransceivers();
1013 ASSERT_EQ(1u, transceivers.size());
1014 EXPECT_EQ(transceiver, transceivers[0]);
1015 EXPECT_EQ(sender, transceiver->sender());
1016 EXPECT_EQ(audio_track, sender->track());
1017}
1018
1019// Test that adding two tracks to a new PeerConnection creates two
1020// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001021TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1022 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001023
1024 auto sender1 = caller->AddAudioTrack("a");
1025 auto sender2 = caller->AddVideoTrack("v");
1026 ASSERT_TRUE(sender2);
1027
1028 auto transceivers = caller->pc()->GetTransceivers();
1029 ASSERT_EQ(2u, transceivers.size());
1030 EXPECT_EQ(sender1, transceivers[0]->sender());
1031 EXPECT_EQ(sender2, transceivers[1]->sender());
1032}
1033
1034// Test that if there are multiple transceivers with no sending track then a
1035// later call to AddTrack will use the one of the same type as the newly-added
1036// track.
Steve Anton3172c032018-05-03 15:30:18 -07001037TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1038 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001039
1040 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1041 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1042 auto sender = caller->AddVideoTrack("v");
1043
1044 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1045 EXPECT_NE(sender, audio_transceiver->sender());
1046 EXPECT_EQ(sender, video_transceiver->sender());
1047}
1048
1049// Test that if the only transceivers that do not have a sending track have a
1050// different type from the added track, then AddTrack will create a new
1051// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001052TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001053 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001054 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001055
1056 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1057 auto sender = caller->AddVideoTrack("v");
1058
1059 auto transceivers = caller->pc()->GetTransceivers();
1060 ASSERT_EQ(2u, transceivers.size());
1061 EXPECT_NE(sender, transceivers[0]->sender());
1062 EXPECT_EQ(sender, transceivers[1]->sender());
1063}
1064
1065// Test that the first available transceiver is reused by AddTrack when multiple
1066// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001067TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001068 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001069 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001070
1071 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1072 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1073 auto sender = caller->AddAudioTrack("a");
1074
1075 auto transceivers = caller->pc()->GetTransceivers();
1076 ASSERT_EQ(2u, transceivers.size());
1077 EXPECT_EQ(sender, transceivers[0]->sender());
1078 EXPECT_NE(sender, transceivers[1]->sender());
1079}
1080
1081// Test that a call to AddTrack that reuses a transceiver will change the
1082// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001083TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001084 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001085 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001086
1087 RtpTransceiverInit init;
1088 init.direction = RtpTransceiverDirection::kInactive;
1089 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1090
1091 caller->observer()->clear_negotiation_needed();
1092 ASSERT_TRUE(caller->AddAudioTrack("a"));
1093 EXPECT_TRUE(caller->observer()->negotiation_needed());
1094
1095 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1096}
1097
1098// Test that a call to AddTrack that reuses a transceiver will change the
1099// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001100TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001101 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001102 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001103
1104 RtpTransceiverInit init;
1105 init.direction = RtpTransceiverDirection::kRecvOnly;
1106 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1107
1108 caller->observer()->clear_negotiation_needed();
1109 ASSERT_TRUE(caller->AddAudioTrack("a"));
1110 EXPECT_TRUE(caller->observer()->negotiation_needed());
1111
1112 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1113}
1114
Steve Anton3172c032018-05-03 15:30:18 -07001115TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001116 const std::string kTrackId = "audio_track";
1117
Steve Anton3172c032018-05-03 15:30:18 -07001118 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001119
1120 auto audio_track = caller->CreateAudioTrack(kTrackId);
1121 auto sender = caller->AddTrack(audio_track);
1122
1123 EXPECT_EQ(kTrackId, sender->id());
1124}
1125
Steve Antonf9381f02017-12-14 10:23:57 -08001126// Unified Plan AddTrack error handling.
1127
Steve Anton3172c032018-05-03 15:30:18 -07001128TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1129 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001130
1131 auto audio_track = caller->CreateAudioTrack("a");
1132 caller->pc()->Close();
1133
1134 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001135 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001136 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001137 EXPECT_FALSE(caller->observer()->negotiation_needed());
1138}
1139
Steve Anton3172c032018-05-03 15:30:18 -07001140TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1141 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001142
1143 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001144 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001145
1146 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001147 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001148 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001149 EXPECT_FALSE(caller->observer()->negotiation_needed());
1150}
1151
1152// Unified Plan RemoveTrack tests.
1153
1154// Test that calling RemoveTrack on a sender with a previously-added track
1155// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001156TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1157 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001158
1159 auto sender = caller->AddAudioTrack("a");
1160 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1161
1162 EXPECT_FALSE(sender->track());
1163}
1164
1165// Test that calling RemoveTrack on a sender where the transceiver is configured
1166// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001167TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001168 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001169 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001170
1171 RtpTransceiverInit init;
1172 init.direction = RtpTransceiverDirection::kSendRecv;
1173 auto transceiver =
1174 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1175
1176 caller->observer()->clear_negotiation_needed();
1177 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1178 EXPECT_TRUE(caller->observer()->negotiation_needed());
1179
1180 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1181 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1182}
1183
1184// Test that calling RemoveTrack on a sender where the transceiver is configured
1185// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001186TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001187 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001188 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001189
1190 RtpTransceiverInit init;
1191 init.direction = RtpTransceiverDirection::kSendOnly;
1192 auto transceiver =
1193 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1194
1195 caller->observer()->clear_negotiation_needed();
1196 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1197 EXPECT_TRUE(caller->observer()->negotiation_needed());
1198
1199 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1200}
1201
1202// Test that calling RemoveTrack with a sender that has a null track results in
1203// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001204TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1205 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001206
1207 auto sender = caller->AddAudioTrack("a");
1208 auto transceiver = caller->pc()->GetTransceivers()[0];
1209 ASSERT_TRUE(sender->SetTrack(nullptr));
1210
1211 caller->observer()->clear_negotiation_needed();
1212 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1213 EXPECT_FALSE(caller->observer()->negotiation_needed());
1214
1215 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1216}
1217
1218// Unified Plan RemoveTrack error handling.
1219
Steve Anton3172c032018-05-03 15:30:18 -07001220TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1221 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001222
1223 auto sender = caller->AddAudioTrack("a");
1224 caller->pc()->Close();
1225
1226 caller->observer()->clear_negotiation_needed();
1227 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1228 EXPECT_FALSE(caller->observer()->negotiation_needed());
1229}
1230
Steve Anton3172c032018-05-03 15:30:18 -07001231TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001232 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001233 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001234
1235 auto sender = caller->AddAudioTrack("a");
1236 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1237
1238 caller->observer()->clear_negotiation_needed();
1239 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1240 EXPECT_FALSE(caller->observer()->negotiation_needed());
1241}
1242
Steve Anton60b6c1d2018-06-13 11:32:27 -07001243// Test that setting offers that add/remove/add a track repeatedly without
1244// setting the appropriate answer in between works.
1245// These are regression tests for bugs.webrtc.org/9401
1246TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1247 auto caller = CreatePeerConnection();
1248
1249 auto sender1 = caller->AddAudioTrack("audio1");
1250 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1251
1252 caller->pc()->RemoveTrack(sender1);
1253 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1254
1255 // This will re-use the transceiver created by the first AddTrack.
1256 auto sender2 = caller->AddAudioTrack("audio2");
1257 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1258
1259 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1260 EXPECT_EQ(sender1, sender2);
1261}
1262TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1263 auto caller = CreatePeerConnection();
1264
1265 auto sender1 = caller->AddVideoTrack("video1");
1266 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1267
1268 caller->pc()->RemoveTrack(sender1);
1269 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1270
1271 // This will re-use the transceiver created by the first AddTrack.
1272 auto sender2 = caller->AddVideoTrack("video2");
1273 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1274
1275 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1276 EXPECT_EQ(sender1, sender2);
1277}
1278
Steve Anton07563732018-06-26 11:13:50 -07001279// Test that CreateOffer succeeds if two tracks with the same label are added.
1280TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1281 auto caller = CreatePeerConnection();
1282
1283 auto audio_sender = caller->AddAudioTrack("track", {});
1284 auto video_sender = caller->AddVideoTrack("track", {});
1285
1286 EXPECT_TRUE(caller->CreateOffer());
1287
1288 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1289 EXPECT_NE(audio_sender->id(), video_sender->id());
1290}
1291
1292// Test that CreateAnswer succeeds if two tracks with the same label are added.
1293TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1294 auto caller = CreatePeerConnection();
1295 auto callee = CreatePeerConnection();
1296
1297 RtpTransceiverInit recvonly;
1298 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1299 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1300 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1301
1302 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1303
1304 auto audio_sender = callee->AddAudioTrack("track", {});
1305 auto video_sender = callee->AddVideoTrack("track", {});
1306
1307 EXPECT_TRUE(callee->CreateAnswer());
1308
1309 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1310 EXPECT_NE(audio_sender->id(), video_sender->id());
1311}
1312
1313// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1314// m= section with a random sender id (different from the first, now rejected,
1315// m= section).
1316TEST_F(PeerConnectionRtpTestUnifiedPlan,
1317 AddRemoveAddTrackGeneratesNewSenderId) {
1318 auto caller = CreatePeerConnection();
1319 auto callee = CreatePeerConnection();
1320
1321 auto track = caller->CreateVideoTrack("video");
1322 auto sender1 = caller->AddTrack(track);
1323 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1324
1325 caller->pc()->RemoveTrack(sender1);
1326 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1327
1328 auto sender2 = caller->AddTrack(track);
1329
1330 EXPECT_NE(sender1, sender2);
1331 EXPECT_NE(sender1->id(), sender2->id());
1332 std::string sender2_id = sender2->id();
1333
1334 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1335
1336 // The sender's ID should not change after negotiation.
1337 EXPECT_EQ(sender2_id, sender2->id());
1338}
1339
Steve Anton52d86772018-02-20 15:48:12 -08001340// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1341// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001342TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001343 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001344 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001345
1346 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1347
1348 caller->observer()->clear_negotiation_needed();
1349 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1350 EXPECT_TRUE(caller->observer()->negotiation_needed());
1351}
1352
1353// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1354// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001355TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001356 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001357 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001358
1359 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1360
1361 caller->observer()->clear_negotiation_needed();
1362 transceiver->SetDirection(transceiver->direction());
1363 EXPECT_FALSE(caller->observer()->negotiation_needed());
1364}
1365
1366// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1367// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001368TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001369 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001370 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001371
1372 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1373 transceiver->Stop();
1374
1375 caller->observer()->clear_negotiation_needed();
1376 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1377 EXPECT_FALSE(caller->observer()->negotiation_needed());
1378}
1379
Florent Castelli892acf02018-10-01 22:47:20 +02001380// Test that AddTransceiver fails if trying to use simulcast using
1381// send_encodings as it isn't currently supported.
1382TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForUnsupportedSimulcast) {
1383 auto caller = CreatePeerConnection();
1384
1385 RtpTransceiverInit init;
1386 init.send_encodings.emplace_back();
1387 init.send_encodings.emplace_back();
1388 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
1389 EXPECT_EQ(result.error().type(), RTCErrorType::UNSUPPORTED_PARAMETER);
1390}
1391
1392// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1393// parameters with the send_encodings parameters.
1394TEST_F(PeerConnectionRtpTestUnifiedPlan,
1395 CheckForUnsupportedEncodingParameters) {
1396 auto caller = CreatePeerConnection();
1397
1398 RtpTransceiverInit init;
1399 init.send_encodings.emplace_back();
1400
1401 auto default_send_encodings = init.send_encodings;
1402
1403 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
1404 // ptime, scale_resolution_down_by, scale_framerate_down_by, rid,
1405 // dependency_rids.
1406 init.send_encodings[0].ssrc = 1;
1407 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1408 caller->pc()
1409 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1410 .error()
1411 .type());
1412 init.send_encodings = default_send_encodings;
1413
1414 init.send_encodings[0].codec_payload_type = 1;
1415 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1416 caller->pc()
1417 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1418 .error()
1419 .type());
1420 init.send_encodings = default_send_encodings;
1421
1422 init.send_encodings[0].fec = RtpFecParameters();
1423 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1424 caller->pc()
1425 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1426 .error()
1427 .type());
1428 init.send_encodings = default_send_encodings;
1429
1430 init.send_encodings[0].rtx = RtpRtxParameters();
1431 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1432 caller->pc()
1433 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1434 .error()
1435 .type());
1436 init.send_encodings = default_send_encodings;
1437
1438 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1439 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1440 caller->pc()
1441 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1442 .error()
1443 .type());
1444 init.send_encodings = default_send_encodings;
1445
1446 init.send_encodings[0].ptime = 1;
1447 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1448 caller->pc()
1449 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1450 .error()
1451 .type());
1452 init.send_encodings = default_send_encodings;
1453
1454 init.send_encodings[0].scale_resolution_down_by = 2.0;
1455 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1456 caller->pc()
1457 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1458 .error()
1459 .type());
1460 init.send_encodings = default_send_encodings;
1461
1462 init.send_encodings[0].rid = "dummy_rid";
1463 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1464 caller->pc()
1465 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1466 .error()
1467 .type());
1468 init.send_encodings = default_send_encodings;
1469
1470 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1471 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1472 caller->pc()
1473 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1474 .error()
1475 .type());
1476}
1477
1478// Test that AddTransceiver transfers the send_encodings to the sender and they
1479// are retained after SetLocalDescription().
1480TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1481 auto caller = CreatePeerConnection();
1482
1483 RtpTransceiverInit init;
1484 init.send_encodings.emplace_back();
1485 init.send_encodings[0].active = false;
1486 init.send_encodings[0].max_bitrate_bps = 180000;
1487
1488 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1489 ASSERT_TRUE(result.ok());
1490
1491 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1492 EXPECT_FALSE(init_send_encodings[0].active);
1493 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1494
1495 auto parameters = result.value()->sender()->GetParameters();
1496 EXPECT_FALSE(parameters.encodings[0].active);
1497 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1498
1499 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1500
1501 parameters = result.value()->sender()->GetParameters();
1502 EXPECT_FALSE(parameters.encodings[0].active);
1503 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1504}
1505
Steve Antone831b8c2018-02-01 12:22:16 -08001506// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1507// options for this kind of signaling: media section based (a=msid) and ssrc
1508// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1509// we want to ensure compatibility with older Plan B endpoints that might expect
1510// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1511// types but answers with the same type as the offer.
1512
Steve Anton3172c032018-05-03 15:30:18 -07001513class PeerConnectionMsidSignalingTest
1514 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001515
1516TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1517 auto caller = CreatePeerConnectionWithUnifiedPlan();
1518 caller->AddAudioTrack("caller_audio");
1519 auto callee = CreatePeerConnectionWithUnifiedPlan();
1520 callee->AddAudioTrack("callee_audio");
1521
1522 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1523
1524 // Offer should have had both a=msid and a=ssrc MSID lines.
1525 auto* offer = callee->pc()->remote_description();
1526 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1527 cricket::kMsidSignalingSsrcAttribute),
1528 offer->description()->msid_signaling());
1529
1530 // Answer should have had only a=msid lines.
1531 auto* answer = caller->pc()->remote_description();
1532 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1533 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001534 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001535 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1536 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1537 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1538 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1539 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001540}
1541
1542TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1543 auto caller = CreatePeerConnectionWithPlanB();
1544 caller->AddAudioTrack("caller_audio");
1545 auto callee = CreatePeerConnectionWithUnifiedPlan();
1546 callee->AddAudioTrack("callee_audio");
1547
1548 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1549
1550 // Offer should have only a=ssrc MSID lines.
1551 auto* offer = callee->pc()->remote_description();
1552 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1553 offer->description()->msid_signaling());
1554
1555 // Answer should have only a=ssrc MSID lines to match the offer.
1556 auto* answer = caller->pc()->remote_description();
1557 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1558 answer->description()->msid_signaling());
1559}
1560
Seth Hampson5b4f0752018-04-02 16:31:36 -07001561// This tests that a Plan B endpoint appropriately sets the remote description
1562// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1563// that signal no stream ids or multiple stream ids we expect that the Plan B
1564// endpoint always has exactly one media stream per track.
1565TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1566 const std::string kStreamId1 = "audio_stream_1";
1567 const std::string kStreamId2 = "audio_stream_2";
1568
1569 auto caller = CreatePeerConnectionWithUnifiedPlan();
1570 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1571 caller->AddVideoTrack("caller_video", {});
1572 auto callee = CreatePeerConnectionWithPlanB();
1573 callee->AddAudioTrack("callee_audio");
1574 caller->AddVideoTrack("callee_video");
1575
1576 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1577
1578 // Offer should have had both a=msid and a=ssrc MSID lines.
1579 auto* offer = callee->pc()->remote_description();
1580 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1581 cricket::kMsidSignalingSsrcAttribute),
1582 offer->description()->msid_signaling());
1583
1584 // Callee should always have 1 stream for all of it's receivers.
1585 const auto& track_events = callee->observer()->add_track_events_;
1586 ASSERT_EQ(2u, track_events.size());
1587 ASSERT_EQ(1u, track_events[0].streams.size());
1588 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1589 ASSERT_EQ(1u, track_events[1].streams.size());
1590 // This autogenerated a stream id for the empty one signalled.
1591 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1592}
1593
Steve Antone831b8c2018-02-01 12:22:16 -08001594TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1595 auto caller = CreatePeerConnectionWithUnifiedPlan();
1596 caller->AddAudioTrack("caller_audio");
1597 auto callee = CreatePeerConnectionWithUnifiedPlan();
1598 callee->AddAudioTrack("callee_audio");
1599
1600 auto offer = caller->CreateOffer();
1601 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1602 // section only.
1603 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1604
1605 ASSERT_TRUE(
1606 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1607 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1608
1609 // Answer should have only a=msid to match the offer.
1610 auto answer = callee->CreateAnswer();
1611 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1612 answer->description()->msid_signaling());
1613}
1614
Steve Anton8e20f172018-03-06 10:55:04 -08001615// Test that the correct UMA metrics are reported for simple/complex SDP.
1616
Steve Anton3172c032018-05-03 15:30:18 -07001617class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001618
1619#ifdef HAVE_SCTP
1620TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1621 auto caller = CreatePeerConnectionWithUnifiedPlan();
1622 caller->CreateDataChannel("dc");
1623 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001624
1625 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001626 // Note that only the callee does ReportSdpFormatReceived.
1627 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1628 "WebRTC.PeerConnection.SdpFormatReceived"));
1629 EXPECT_EQ(
1630 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1631 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001632}
1633#endif // HAVE_SCTP
1634
1635TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1636 auto caller = CreatePeerConnectionWithUnifiedPlan();
1637 caller->AddAudioTrack("audio");
1638 caller->AddVideoTrack("video");
1639 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001640
1641 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001642 // Note that only the callee does ReportSdpFormatReceived.
1643 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1644 "WebRTC.PeerConnection.SdpFormatReceived"));
1645 EXPECT_EQ(
1646 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1647 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001648}
1649
1650TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1651 auto caller = CreatePeerConnectionWithPlanB();
1652 caller->AddVideoTrack("video"); // Video only.
1653 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001654
1655 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1656
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001657 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1658 "WebRTC.PeerConnection.SdpFormatReceived"));
1659 EXPECT_EQ(
1660 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1661 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001662}
1663
1664TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1665 auto caller = CreatePeerConnectionWithUnifiedPlan();
1666 caller->AddAudioTrack("audio1");
1667 caller->AddAudioTrack("audio2");
1668 caller->AddVideoTrack("video");
1669 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001670
1671 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001672 // Note that only the callee does ReportSdpFormatReceived.
1673 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1674 "WebRTC.PeerConnection.SdpFormatReceived"));
1675 EXPECT_EQ(
1676 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1677 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001678}
1679
1680TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1681 auto caller = CreatePeerConnectionWithPlanB();
1682 caller->AddVideoTrack("video1");
1683 caller->AddVideoTrack("video2");
1684 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001685
Steve Antonba42e992018-04-09 14:10:01 -07001686 // This fails since Unified Plan cannot set a session description with
1687 // multiple "Plan B tracks" in the same media section. But we still expect the
1688 // SDP Format to be recorded.
1689 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001690 // Note that only the callee does ReportSdpFormatReceived.
1691 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1692 "WebRTC.PeerConnection.SdpFormatReceived"));
1693 EXPECT_EQ(
1694 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1695 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001696}
1697
Henrik Boström91d039b2018-01-11 17:43:30 +01001698// Sender setups in a call.
1699
Steve Anton3172c032018-05-03 15:30:18 -07001700TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001701 auto caller = CreatePeerConnection();
1702 auto callee = CreatePeerConnection();
1703
1704 auto track = caller->CreateAudioTrack("audio_track");
1705 auto sender1 = caller->AddTrack(track);
1706 ASSERT_TRUE(sender1);
1707 // We need to temporarily reset the track for the subsequent AddTrack() to
1708 // succeed.
1709 EXPECT_TRUE(sender1->SetTrack(nullptr));
1710 auto sender2 = caller->AddTrack(track);
1711 EXPECT_TRUE(sender2);
1712 EXPECT_TRUE(sender1->SetTrack(track));
1713
Steve Anton3172c032018-05-03 15:30:18 -07001714 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1715 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1716 // return true, and doing |callee->SetRemoteDescription()| should work.
1717 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1718 } else {
1719 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1720 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001721}
1722
Steve Anton3172c032018-05-03 15:30:18 -07001723INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1724 PeerConnectionRtpTest,
1725 Values(SdpSemantics::kPlanB,
1726 SdpSemantics::kUnifiedPlan));
1727
Steve Anton9158ef62017-11-27 13:01:52 -08001728} // namespace webrtc