blob: cdd565999b9d535743dbe1054df374237b9a2662 [file] [log] [blame]
Greg Fischer04fcc662016-11-10 10:11:50 -07001// Copyright (c) 2017 The Khronos Group Inc.
2// Copyright (c) 2017 Valve Corporation
3// Copyright (c) 2017 LunarG Inc.
4//
5// Licensed under the Apache License, Version 2.0 (the "License");
6// you may not use this file except in compliance with the License.
7// You may obtain a copy of the License at
8//
9// http://www.apache.org/licenses/LICENSE-2.0
10//
11// Unless required by applicable law or agreed to in writing, software
12// distributed under the License is distributed on an "AS IS" BASIS,
13// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14// See the License for the specific language governing permissions and
15// limitations under the License.
16
dan sinclaireda2cfb2018-08-03 15:06:09 -040017#include "source/opt/inline_pass.h"
GregFe28bd392017-08-01 17:20:13 -060018
dan sinclaireda2cfb2018-08-03 15:06:09 -040019#include <unordered_set>
20#include <utility>
21
22#include "source/cfa.h"
dan sinclair1963a2d2018-08-14 15:01:50 -040023#include "source/util/make_unique.h"
Greg Fischer04fcc662016-11-10 10:11:50 -070024
25// Indices of operands in SPIR-V instructions
26
Greg Fischer04fcc662016-11-10 10:11:50 -070027static const int kSpvFunctionCallFunctionId = 2;
28static const int kSpvFunctionCallArgumentId = 3;
29static const int kSpvReturnValueId = 0;
David Netoefff5fa2017-08-31 15:47:31 -040030static const int kSpvLoopMergeContinueTargetIdInIdx = 1;
Greg Fischer04fcc662016-11-10 10:11:50 -070031
32namespace spvtools {
33namespace opt {
34
Greg Fischer04fcc662016-11-10 10:11:50 -070035uint32_t InlinePass::AddPointerToType(uint32_t type_id,
36 SpvStorageClass storage_class) {
37 uint32_t resultId = TakeNextId();
dan sinclairc7da51a2018-07-12 15:14:43 -040038 std::unique_ptr<Instruction> type_inst(
39 new Instruction(context(), SpvOpTypePointer, 0, resultId,
40 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
41 {uint32_t(storage_class)}},
42 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}}));
Steven Perron476cae62017-10-30 11:13:24 -040043 context()->AddType(std::move(type_inst));
Alan Baker61690852017-12-08 15:33:19 -050044 analysis::Type* pointeeTy;
45 std::unique_ptr<analysis::Pointer> pointerTy;
46 std::tie(pointeeTy, pointerTy) =
47 context()->get_type_mgr()->GetTypeAndPointerType(type_id,
48 SpvStorageClassFunction);
49 context()->get_type_mgr()->RegisterType(resultId, *pointerTy);
Greg Fischer04fcc662016-11-10 10:11:50 -070050 return resultId;
51}
52
53void InlinePass::AddBranch(uint32_t label_id,
dan sinclairc7da51a2018-07-12 15:14:43 -040054 std::unique_ptr<BasicBlock>* block_ptr) {
55 std::unique_ptr<Instruction> newBranch(
56 new Instruction(context(), SpvOpBranch, 0, 0,
57 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070058 (*block_ptr)->AddInstruction(std::move(newBranch));
59}
60
Greg Fischerbba812f2017-05-04 20:55:53 -060061void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id,
Diego Novillod2938e42017-11-08 12:40:02 -050062 uint32_t false_id,
dan sinclairc7da51a2018-07-12 15:14:43 -040063 std::unique_ptr<BasicBlock>* block_ptr) {
64 std::unique_ptr<Instruction> newBranch(
65 new Instruction(context(), SpvOpBranchConditional, 0, 0,
66 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}},
67 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}},
68 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}}));
Greg Fischerbba812f2017-05-04 20:55:53 -060069 (*block_ptr)->AddInstruction(std::move(newBranch));
70}
71
72void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id,
dan sinclairc7da51a2018-07-12 15:14:43 -040073 std::unique_ptr<BasicBlock>* block_ptr) {
74 std::unique_ptr<Instruction> newLoopMerge(new Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050075 context(), SpvOpLoopMerge, 0, 0,
Greg Fischerbba812f2017-05-04 20:55:53 -060076 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}},
77 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}},
78 {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}}));
79 (*block_ptr)->AddInstruction(std::move(newLoopMerge));
80}
81
Greg Fischer04fcc662016-11-10 10:11:50 -070082void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id,
dan sinclairc7da51a2018-07-12 15:14:43 -040083 std::unique_ptr<BasicBlock>* block_ptr) {
84 std::unique_ptr<Instruction> newStore(
85 new Instruction(context(), SpvOpStore, 0, 0,
86 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}},
87 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070088 (*block_ptr)->AddInstruction(std::move(newStore));
89}
90
91void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id,
dan sinclairc7da51a2018-07-12 15:14:43 -040092 std::unique_ptr<BasicBlock>* block_ptr) {
93 std::unique_ptr<Instruction> newLoad(
94 new Instruction(context(), SpvOpLoad, type_id, resultId,
95 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070096 (*block_ptr)->AddInstruction(std::move(newLoad));
97}
98
dan sinclairc7da51a2018-07-12 15:14:43 -040099std::unique_ptr<Instruction> InlinePass::NewLabel(uint32_t label_id) {
100 std::unique_ptr<Instruction> newLabel(
101 new Instruction(context(), SpvOpLabel, 0, label_id, {}));
Greg Fischer04fcc662016-11-10 10:11:50 -0700102 return newLabel;
103}
104
Greg Fischerbba812f2017-05-04 20:55:53 -0600105uint32_t InlinePass::GetFalseId() {
Diego Novillod2938e42017-11-08 12:40:02 -0500106 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400107 false_id_ = get_module()->GetGlobalValue(SpvOpConstantFalse);
Diego Novillod2938e42017-11-08 12:40:02 -0500108 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400109 uint32_t boolId = get_module()->GetGlobalValue(SpvOpTypeBool);
Greg Fischerbba812f2017-05-04 20:55:53 -0600110 if (boolId == 0) {
111 boolId = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400112 get_module()->AddGlobalValue(SpvOpTypeBool, boolId, 0);
Greg Fischerbba812f2017-05-04 20:55:53 -0600113 }
114 false_id_ = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400115 get_module()->AddGlobalValue(SpvOpConstantFalse, false_id_, boolId);
Greg Fischerbba812f2017-05-04 20:55:53 -0600116 return false_id_;
117}
118
Greg Fischer04fcc662016-11-10 10:11:50 -0700119void InlinePass::MapParams(
dan sinclairc7da51a2018-07-12 15:14:43 -0400120 Function* calleeFn, BasicBlock::iterator call_inst_itr,
Greg Fischer04fcc662016-11-10 10:11:50 -0700121 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
122 int param_idx = 0;
dan sinclaire6b95332018-07-09 11:32:29 -0400123 calleeFn->ForEachParam([&call_inst_itr, &param_idx,
dan sinclairc7da51a2018-07-12 15:14:43 -0400124 &callee2caller](const Instruction* cpi) {
dan sinclaire6b95332018-07-09 11:32:29 -0400125 const uint32_t pid = cpi->result_id();
126 (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand(
127 kSpvFunctionCallArgumentId + param_idx);
128 ++param_idx;
129 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700130}
131
132void InlinePass::CloneAndMapLocals(
dan sinclairc7da51a2018-07-12 15:14:43 -0400133 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars,
Greg Fischer04fcc662016-11-10 10:11:50 -0700134 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
135 auto callee_block_itr = calleeFn->begin();
136 auto callee_var_itr = callee_block_itr->begin();
137 while (callee_var_itr->opcode() == SpvOp::SpvOpVariable) {
dan sinclairc7da51a2018-07-12 15:14:43 -0400138 std::unique_ptr<Instruction> var_inst(callee_var_itr->Clone(context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700139 uint32_t newId = TakeNextId();
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100140 get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId);
Greg Fischer04fcc662016-11-10 10:11:50 -0700141 var_inst->SetResultId(newId);
142 (*callee2caller)[callee_var_itr->result_id()] = newId;
143 new_vars->push_back(std::move(var_inst));
Greg Fischerbba812f2017-05-04 20:55:53 -0600144 ++callee_var_itr;
Greg Fischer04fcc662016-11-10 10:11:50 -0700145 }
146}
147
148uint32_t InlinePass::CreateReturnVar(
dan sinclairc7da51a2018-07-12 15:14:43 -0400149 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700150 uint32_t returnVarId = 0;
151 const uint32_t calleeTypeId = calleeFn->type_id();
Steven Perron06b437d2018-02-09 20:33:06 -0500152 analysis::Type* calleeType = context()->get_type_mgr()->GetType(calleeTypeId);
153 if (calleeType->AsVoid() == nullptr) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700154 // Find or create ptr to callee return type.
Steven Perronb86eb682017-12-11 13:10:24 -0500155 uint32_t returnVarTypeId = context()->get_type_mgr()->FindPointerToType(
156 calleeTypeId, SpvStorageClassFunction);
Greg Fischer04fcc662016-11-10 10:11:50 -0700157 if (returnVarTypeId == 0)
158 returnVarTypeId = AddPointerToType(calleeTypeId, SpvStorageClassFunction);
159 // Add return var to new function scope variables.
160 returnVarId = TakeNextId();
dan sinclairc7da51a2018-07-12 15:14:43 -0400161 std::unique_ptr<Instruction> var_inst(
162 new Instruction(context(), SpvOpVariable, returnVarTypeId, returnVarId,
163 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
164 {SpvStorageClassFunction}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -0700165 new_vars->push_back(std::move(var_inst));
166 }
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100167 get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId);
Greg Fischer04fcc662016-11-10 10:11:50 -0700168 return returnVarId;
169}
170
dan sinclairc7da51a2018-07-12 15:14:43 -0400171bool InlinePass::IsSameBlockOp(const Instruction* inst) const {
Greg Fischer04fcc662016-11-10 10:11:50 -0700172 return inst->opcode() == SpvOpSampledImage || inst->opcode() == SpvOpImage;
173}
174
175void InlinePass::CloneSameBlockOps(
dan sinclairc7da51a2018-07-12 15:14:43 -0400176 std::unique_ptr<Instruction>* inst,
Greg Fischer04fcc662016-11-10 10:11:50 -0700177 std::unordered_map<uint32_t, uint32_t>* postCallSB,
dan sinclairc7da51a2018-07-12 15:14:43 -0400178 std::unordered_map<uint32_t, Instruction*>* preCallSB,
179 std::unique_ptr<BasicBlock>* block_ptr) {
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100180 (*inst)->ForEachInId(
181 [&postCallSB, &preCallSB, &block_ptr, this](uint32_t* iid) {
182 const auto mapItr = (*postCallSB).find(*iid);
183 if (mapItr == (*postCallSB).end()) {
184 const auto mapItr2 = (*preCallSB).find(*iid);
185 if (mapItr2 != (*preCallSB).end()) {
186 // Clone pre-call same-block ops, map result id.
dan sinclairc7da51a2018-07-12 15:14:43 -0400187 const Instruction* inInst = mapItr2->second;
188 std::unique_ptr<Instruction> sb_inst(inInst->Clone(context()));
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100189 CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr);
190 const uint32_t rid = sb_inst->result_id();
191 const uint32_t nid = this->TakeNextId();
192 get_decoration_mgr()->CloneDecorations(rid, nid);
193 sb_inst->SetResultId(nid);
194 (*postCallSB)[rid] = nid;
195 *iid = nid;
196 (*block_ptr)->AddInstruction(std::move(sb_inst));
197 }
198 } else {
199 // Reset same-block op operand.
200 *iid = mapItr->second;
201 }
202 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700203}
204
205void InlinePass::GenInlineCode(
dan sinclairc7da51a2018-07-12 15:14:43 -0400206 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
207 std::vector<std::unique_ptr<Instruction>>* new_vars,
208 BasicBlock::iterator call_inst_itr,
209 UptrVectorIterator<BasicBlock> call_block_itr) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700210 // Map from all ids in the callee to their equivalent id in the caller
211 // as callee instructions are copied into caller.
212 std::unordered_map<uint32_t, uint32_t> callee2caller;
213 // Pre-call same-block insts
dan sinclairc7da51a2018-07-12 15:14:43 -0400214 std::unordered_map<uint32_t, Instruction*> preCallSB;
Greg Fischer04fcc662016-11-10 10:11:50 -0700215 // Post-call same-block op ids
216 std::unordered_map<uint32_t, uint32_t> postCallSB;
217
Steven Perronb3daa932018-03-06 11:20:28 -0500218 // Invalidate the def-use chains. They are not kept up to date while
219 // inlining. However, certain calls try to keep them up-to-date if they are
220 // valid. These operations can fail.
dan sinclairc7da51a2018-07-12 15:14:43 -0400221 context()->InvalidateAnalyses(IRContext::kAnalysisDefUse);
Steven Perronb3daa932018-03-06 11:20:28 -0500222
dan sinclairc7da51a2018-07-12 15:14:43 -0400223 Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand(
Greg Fischer04fcc662016-11-10 10:11:50 -0700224 kSpvFunctionCallFunctionId)];
225
David Neto2a1014b2017-08-09 14:59:04 -0400226 // Check for multiple returns in the callee.
greg-lunarg67214782018-11-08 07:11:20 -0700227 auto fi = early_return_funcs_.find(calleeFn->result_id());
228 const bool earlyReturn = fi != early_return_funcs_.end();
Greg Fischerbba812f2017-05-04 20:55:53 -0600229
Greg Fischer04fcc662016-11-10 10:11:50 -0700230 // Map parameters to actual arguments.
231 MapParams(calleeFn, call_inst_itr, &callee2caller);
232
233 // Define caller local variables for all callee variables and create map to
234 // them.
235 CloneAndMapLocals(calleeFn, new_vars, &callee2caller);
236
237 // Create return var if needed.
238 uint32_t returnVarId = CreateReturnVar(calleeFn, new_vars);
239
GregFa699d1a2017-08-29 18:35:05 -0600240 // Create set of callee result ids. Used to detect forward references
241 std::unordered_set<uint32_t> callee_result_ids;
dan sinclairc7da51a2018-07-12 15:14:43 -0400242 calleeFn->ForEachInst([&callee_result_ids](const Instruction* cpi) {
GregFa699d1a2017-08-29 18:35:05 -0600243 const uint32_t rid = cpi->result_id();
Diego Novillod2938e42017-11-08 12:40:02 -0500244 if (rid != 0) callee_result_ids.insert(rid);
GregFa699d1a2017-08-29 18:35:05 -0600245 });
246
David Netoefff5fa2017-08-31 15:47:31 -0400247 // If the caller is in a single-block loop, and the callee has multiple
248 // blocks, then the normal inlining logic will place the OpLoopMerge in
249 // the last of several blocks in the loop. Instead, it should be placed
250 // at the end of the first block. First determine if the caller is in a
251 // single block loop. We'll wait to move the OpLoopMerge until the end
252 // of the regular inlining logic, and only if necessary.
253 bool caller_is_single_block_loop = false;
David Neto25ddfec2017-09-02 19:01:03 -0400254 bool caller_is_loop_header = false;
David Netoefff5fa2017-08-31 15:47:31 -0400255 if (auto* loop_merge = call_block_itr->GetLoopMergeInst()) {
David Neto25ddfec2017-09-02 19:01:03 -0400256 caller_is_loop_header = true;
David Netoefff5fa2017-08-31 15:47:31 -0400257 caller_is_single_block_loop =
258 call_block_itr->id() ==
259 loop_merge->GetSingleWordInOperand(kSpvLoopMergeContinueTargetIdInIdx);
260 }
261
262 bool callee_begins_with_structured_header =
263 (*(calleeFn->begin())).GetMergeInst() != nullptr;
264
Greg Fischer04fcc662016-11-10 10:11:50 -0700265 // Clone and map callee code. Copy caller block code to beginning of
266 // first block and end of last block.
267 bool prevInstWasReturn = false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600268 uint32_t singleTripLoopHeaderId = 0;
269 uint32_t singleTripLoopContinueId = 0;
Greg Fischer04fcc662016-11-10 10:11:50 -0700270 uint32_t returnLabelId = 0;
271 bool multiBlocks = false;
272 const uint32_t calleeTypeId = calleeFn->type_id();
David Neto2a1014b2017-08-09 14:59:04 -0400273 // new_blk_ptr is a new basic block in the caller. New instructions are
274 // written to it. It is created when we encounter the OpLabel
David Netoefff5fa2017-08-31 15:47:31 -0400275 // of the first callee block. It is appended to new_blocks only when
276 // it is complete.
dan sinclairc7da51a2018-07-12 15:14:43 -0400277 std::unique_ptr<BasicBlock> new_blk_ptr;
Greg Fischer04fcc662016-11-10 10:11:50 -0700278 calleeFn->ForEachInst([&new_blocks, &callee2caller, &call_block_itr,
279 &call_inst_itr, &new_blk_ptr, &prevInstWasReturn,
David Neto25ddfec2017-09-02 19:01:03 -0400280 &returnLabelId, &returnVarId, caller_is_loop_header,
David Netoefff5fa2017-08-31 15:47:31 -0400281 callee_begins_with_structured_header, &calleeTypeId,
greg-lunarg67214782018-11-08 07:11:20 -0700282 &multiBlocks, &postCallSB, &preCallSB, earlyReturn,
Greg Fischerbba812f2017-05-04 20:55:53 -0600283 &singleTripLoopHeaderId, &singleTripLoopContinueId,
dan sinclairc7da51a2018-07-12 15:14:43 -0400284 &callee_result_ids, this](const Instruction* cpi) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700285 switch (cpi->opcode()) {
286 case SpvOpFunction:
287 case SpvOpFunctionParameter:
Greg Fischer04fcc662016-11-10 10:11:50 -0700288 // Already processed
289 break;
Steven Perron9a008832018-05-31 20:28:19 -0400290 case SpvOpVariable:
291 if (cpi->NumInOperands() == 2) {
292 assert(callee2caller.count(cpi->result_id()) &&
293 "Expected the variable to have already been mapped.");
294 uint32_t new_var_id = callee2caller.at(cpi->result_id());
295
296 // The initializer must be a constant or global value. No mapped
297 // should be used.
298 uint32_t val_id = cpi->GetSingleWordInOperand(1);
299 AddStore(new_var_id, val_id, &new_blk_ptr);
300 }
301 break;
Alan Baker4246abd2018-04-26 12:22:08 -0400302 case SpvOpUnreachable:
303 case SpvOpKill: {
304 // Generate a return label so that we split the block with the function
305 // call. Copy the terminator into the new block.
306 if (returnLabelId == 0) returnLabelId = this->TakeNextId();
dan sinclairc7da51a2018-07-12 15:14:43 -0400307 std::unique_ptr<Instruction> terminator(
308 new Instruction(context(), cpi->opcode(), 0, 0, {}));
Alan Baker4246abd2018-04-26 12:22:08 -0400309 new_blk_ptr->AddInstruction(std::move(terminator));
310 break;
311 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700312 case SpvOpLabel: {
313 // If previous instruction was early return, insert branch
314 // instruction to return block.
315 if (prevInstWasReturn) {
316 if (returnLabelId == 0) returnLabelId = this->TakeNextId();
317 AddBranch(returnLabelId, &new_blk_ptr);
318 prevInstWasReturn = false;
319 }
320 // Finish current block (if it exists) and get label for next block.
321 uint32_t labelId;
322 bool firstBlock = false;
323 if (new_blk_ptr != nullptr) {
324 new_blocks->push_back(std::move(new_blk_ptr));
325 // If result id is already mapped, use it, otherwise get a new
326 // one.
327 const uint32_t rid = cpi->result_id();
328 const auto mapItr = callee2caller.find(rid);
329 labelId = (mapItr != callee2caller.end()) ? mapItr->second
330 : this->TakeNextId();
331 } else {
332 // First block needs to use label of original block
333 // but map callee label in case of phi reference.
Greg Fischerbba812f2017-05-04 20:55:53 -0600334 labelId = call_block_itr->id();
Greg Fischer04fcc662016-11-10 10:11:50 -0700335 callee2caller[cpi->result_id()] = labelId;
336 firstBlock = true;
337 }
338 // Create first/next block.
dan sinclair1963a2d2018-08-14 15:01:50 -0400339 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(labelId));
Greg Fischer04fcc662016-11-10 10:11:50 -0700340 if (firstBlock) {
341 // Copy contents of original caller block up to call instruction.
342 for (auto cii = call_block_itr->begin(); cii != call_inst_itr;
Steven Perron51ecc732018-02-20 11:24:08 -0500343 cii = call_block_itr->begin()) {
dan sinclairc7da51a2018-07-12 15:14:43 -0400344 Instruction* inst = &*cii;
Steven Perron51ecc732018-02-20 11:24:08 -0500345 inst->RemoveFromList();
dan sinclairc7da51a2018-07-12 15:14:43 -0400346 std::unique_ptr<Instruction> cp_inst(inst);
Greg Fischer04fcc662016-11-10 10:11:50 -0700347 // Remember same-block ops for possible regeneration.
348 if (IsSameBlockOp(&*cp_inst)) {
349 auto* sb_inst_ptr = cp_inst.get();
350 preCallSB[cp_inst->result_id()] = sb_inst_ptr;
351 }
352 new_blk_ptr->AddInstruction(std::move(cp_inst));
353 }
Diego Novillod2938e42017-11-08 12:40:02 -0500354 if (caller_is_loop_header && callee_begins_with_structured_header) {
David Netoefff5fa2017-08-31 15:47:31 -0400355 // We can't place both the caller's merge instruction and another
356 // merge instruction in the same block. So split the calling block.
357 // Insert an unconditional branch to a new guard block. Later,
358 // once we know the ID of the last block, we will move the caller's
359 // OpLoopMerge from the last generated block into the first block.
360 // We also wait to avoid invalidating various iterators.
361 const auto guard_block_id = this->TakeNextId();
362 AddBranch(guard_block_id, &new_blk_ptr);
363 new_blocks->push_back(std::move(new_blk_ptr));
364 // Start the next block.
dan sinclair1963a2d2018-08-14 15:01:50 -0400365 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(guard_block_id));
David Netoefff5fa2017-08-31 15:47:31 -0400366 // Reset the mapping of the callee's entry block to point to
367 // the guard block. Do this so we can fix up phis later on to
368 // satisfy dominance.
369 callee2caller[cpi->result_id()] = guard_block_id;
370 }
greg-lunarg67214782018-11-08 07:11:20 -0700371 // If callee has early return, insert a header block for
David Neto2a1014b2017-08-09 14:59:04 -0400372 // single-trip loop that will encompass callee code. Start postheader
Greg Fischerbba812f2017-05-04 20:55:53 -0600373 // block.
David Netoefff5fa2017-08-31 15:47:31 -0400374 //
375 // Note: Consider the following combination:
376 // - the caller is a single block loop
377 // - the callee does not begin with a structure header
378 // - the callee has multiple returns.
379 // We still need to split the caller block and insert a guard block.
380 // But we only need to do it once. We haven't done it yet, but the
381 // single-trip loop header will serve the same purpose.
greg-lunarg67214782018-11-08 07:11:20 -0700382 if (earlyReturn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600383 singleTripLoopHeaderId = this->TakeNextId();
384 AddBranch(singleTripLoopHeaderId, &new_blk_ptr);
385 new_blocks->push_back(std::move(new_blk_ptr));
dan sinclair1963a2d2018-08-14 15:01:50 -0400386 new_blk_ptr =
387 MakeUnique<BasicBlock>(NewLabel(singleTripLoopHeaderId));
Greg Fischerbba812f2017-05-04 20:55:53 -0600388 returnLabelId = this->TakeNextId();
389 singleTripLoopContinueId = this->TakeNextId();
390 AddLoopMerge(returnLabelId, singleTripLoopContinueId, &new_blk_ptr);
391 uint32_t postHeaderId = this->TakeNextId();
392 AddBranch(postHeaderId, &new_blk_ptr);
393 new_blocks->push_back(std::move(new_blk_ptr));
dan sinclair1963a2d2018-08-14 15:01:50 -0400394 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(postHeaderId));
Greg Fischerbba812f2017-05-04 20:55:53 -0600395 multiBlocks = true;
David Neto860c4192017-08-31 17:33:44 -0400396 // Reset the mapping of the callee's entry block to point to
397 // the post-header block. Do this so we can fix up phis later
398 // on to satisfy dominance.
399 callee2caller[cpi->result_id()] = postHeaderId;
Greg Fischerbba812f2017-05-04 20:55:53 -0600400 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700401 } else {
402 multiBlocks = true;
403 }
404 } break;
405 case SpvOpReturnValue: {
406 // Store return value to return variable.
407 assert(returnVarId != 0);
408 uint32_t valId = cpi->GetInOperand(kSpvReturnValueId).words[0];
409 const auto mapItr = callee2caller.find(valId);
410 if (mapItr != callee2caller.end()) {
411 valId = mapItr->second;
412 }
413 AddStore(returnVarId, valId, &new_blk_ptr);
414
415 // Remember we saw a return; if followed by a label, will need to
416 // insert branch.
417 prevInstWasReturn = true;
418 } break;
419 case SpvOpReturn: {
420 // Remember we saw a return; if followed by a label, will need to
421 // insert branch.
422 prevInstWasReturn = true;
423 } break;
424 case SpvOpFunctionEnd: {
David Neto2a1014b2017-08-09 14:59:04 -0400425 // If there was an early return, we generated a return label id
426 // for it. Now we have to generate the return block with that Id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700427 if (returnLabelId != 0) {
David Neto2a1014b2017-08-09 14:59:04 -0400428 // If previous instruction was return, insert branch instruction
429 // to return block.
Greg Fischer04fcc662016-11-10 10:11:50 -0700430 if (prevInstWasReturn) AddBranch(returnLabelId, &new_blk_ptr);
greg-lunarg67214782018-11-08 07:11:20 -0700431 if (earlyReturn) {
432 // If we generated a loop header for the single-trip loop
433 // to accommodate early returns, insert the continue
David Neto2a1014b2017-08-09 14:59:04 -0400434 // target block now, with a false branch back to the loop header.
435 new_blocks->push_back(std::move(new_blk_ptr));
dan sinclair1963a2d2018-08-14 15:01:50 -0400436 new_blk_ptr =
437 MakeUnique<BasicBlock>(NewLabel(singleTripLoopContinueId));
David Neto2a1014b2017-08-09 14:59:04 -0400438 AddBranchCond(GetFalseId(), singleTripLoopHeaderId, returnLabelId,
439 &new_blk_ptr);
440 }
441 // Generate the return block.
Greg Fischerbba812f2017-05-04 20:55:53 -0600442 new_blocks->push_back(std::move(new_blk_ptr));
dan sinclair1963a2d2018-08-14 15:01:50 -0400443 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(returnLabelId));
Greg Fischer04fcc662016-11-10 10:11:50 -0700444 multiBlocks = true;
445 }
446 // Load return value into result id of call, if it exists.
447 if (returnVarId != 0) {
448 const uint32_t resId = call_inst_itr->result_id();
449 assert(resId != 0);
450 AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr);
451 }
452 // Copy remaining instructions from caller block.
dan sinclairc7da51a2018-07-12 15:14:43 -0400453 for (Instruction* inst = call_inst_itr->NextNode(); inst;
Steven Perron51ecc732018-02-20 11:24:08 -0500454 inst = call_inst_itr->NextNode()) {
455 inst->RemoveFromList();
dan sinclairc7da51a2018-07-12 15:14:43 -0400456 std::unique_ptr<Instruction> cp_inst(inst);
Greg Fischer04fcc662016-11-10 10:11:50 -0700457 // If multiple blocks generated, regenerate any same-block
458 // instruction that has not been seen in this last block.
459 if (multiBlocks) {
460 CloneSameBlockOps(&cp_inst, &postCallSB, &preCallSB, &new_blk_ptr);
461 // Remember same-block ops in this block.
462 if (IsSameBlockOp(&*cp_inst)) {
463 const uint32_t rid = cp_inst->result_id();
464 postCallSB[rid] = rid;
465 }
466 }
467 new_blk_ptr->AddInstruction(std::move(cp_inst));
468 }
469 // Finalize inline code.
470 new_blocks->push_back(std::move(new_blk_ptr));
471 } break;
472 default: {
473 // Copy callee instruction and remap all input Ids.
dan sinclairc7da51a2018-07-12 15:14:43 -0400474 std::unique_ptr<Instruction> cp_inst(cpi->Clone(context()));
David Netoefff5fa2017-08-31 15:47:31 -0400475 cp_inst->ForEachInId([&callee2caller, &callee_result_ids,
476 this](uint32_t* iid) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700477 const auto mapItr = callee2caller.find(*iid);
478 if (mapItr != callee2caller.end()) {
479 *iid = mapItr->second;
GregFa699d1a2017-08-29 18:35:05 -0600480 } else if (callee_result_ids.find(*iid) != callee_result_ids.end()) {
481 // Forward reference. Allocate a new id, map it,
482 // use it and check for it when remapping result ids
483 const uint32_t nid = this->TakeNextId();
484 callee2caller[*iid] = nid;
485 *iid = nid;
Greg Fischer04fcc662016-11-10 10:11:50 -0700486 }
487 });
GregFa699d1a2017-08-29 18:35:05 -0600488 // If result id is non-zero, remap it. If already mapped, use mapped
489 // value, else use next id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700490 const uint32_t rid = cp_inst->result_id();
491 if (rid != 0) {
GregFa699d1a2017-08-29 18:35:05 -0600492 const auto mapItr = callee2caller.find(rid);
493 uint32_t nid;
494 if (mapItr != callee2caller.end()) {
495 nid = mapItr->second;
Diego Novillod2938e42017-11-08 12:40:02 -0500496 } else {
GregFa699d1a2017-08-29 18:35:05 -0600497 nid = this->TakeNextId();
498 callee2caller[rid] = nid;
499 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700500 cp_inst->SetResultId(nid);
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100501 get_decoration_mgr()->CloneDecorations(rid, nid);
Greg Fischer04fcc662016-11-10 10:11:50 -0700502 }
503 new_blk_ptr->AddInstruction(std::move(cp_inst));
504 } break;
505 }
506 });
David Netoefff5fa2017-08-31 15:47:31 -0400507
David Neto25ddfec2017-09-02 19:01:03 -0400508 if (caller_is_loop_header && (new_blocks->size() > 1)) {
David Netoefff5fa2017-08-31 15:47:31 -0400509 // Move the OpLoopMerge from the last block back to the first, where
David Neto25ddfec2017-09-02 19:01:03 -0400510 // it belongs.
David Netoefff5fa2017-08-31 15:47:31 -0400511 auto& first = new_blocks->front();
512 auto& last = new_blocks->back();
513 assert(first != last);
514
515 // Insert a modified copy of the loop merge into the first block.
516 auto loop_merge_itr = last->tail();
517 --loop_merge_itr;
518 assert(loop_merge_itr->opcode() == SpvOpLoopMerge);
dan sinclairc7da51a2018-07-12 15:14:43 -0400519 std::unique_ptr<Instruction> cp_inst(loop_merge_itr->Clone(context()));
David Neto25ddfec2017-09-02 19:01:03 -0400520 if (caller_is_single_block_loop) {
521 // Also, update its continue target to point to the last block.
522 cp_inst->SetInOperand(kSpvLoopMergeContinueTargetIdInIdx, {last->id()});
523 }
David Netoefff5fa2017-08-31 15:47:31 -0400524 first->tail().InsertBefore(std::move(cp_inst));
525
526 // Remove the loop merge from the last block.
Steven Perronbb7802b2017-10-13 14:25:21 -0400527 loop_merge_itr->RemoveFromList();
528 delete &*loop_merge_itr;
David Netoefff5fa2017-08-31 15:47:31 -0400529 }
530
Greg Fischer04fcc662016-11-10 10:11:50 -0700531 // Update block map given replacement blocks.
532 for (auto& blk : *new_blocks) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600533 id2block_[blk->id()] = &*blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700534 }
535}
536
dan sinclairc7da51a2018-07-12 15:14:43 -0400537bool InlinePass::IsInlinableFunctionCall(const Instruction* inst) {
David Netoceb1d4f2017-03-31 10:36:58 -0400538 if (inst->opcode() != SpvOp::SpvOpFunctionCall) return false;
GregFa107d342017-04-25 13:57:20 -0600539 const uint32_t calleeFnId =
540 inst->GetSingleWordOperand(kSpvFunctionCallFunctionId);
541 const auto ci = inlinable_.find(calleeFnId);
542 return ci != inlinable_.cend();
David Netoceb1d4f2017-03-31 10:36:58 -0400543}
544
GregFe28bd392017-08-01 17:20:13 -0600545void InlinePass::UpdateSucceedingPhis(
dan sinclairc7da51a2018-07-12 15:14:43 -0400546 std::vector<std::unique_ptr<BasicBlock>>& new_blocks) {
GregFe28bd392017-08-01 17:20:13 -0600547 const auto firstBlk = new_blocks.begin();
548 const auto lastBlk = new_blocks.end() - 1;
549 const uint32_t firstId = (*firstBlk)->id();
550 const uint32_t lastId = (*lastBlk)->id();
dan sinclairc7da51a2018-07-12 15:14:43 -0400551 const BasicBlock& const_last_block = *lastBlk->get();
David Neto87f9cfa2018-02-02 14:17:42 -0800552 const_last_block.ForEachSuccessorLabel(
553 [&firstId, &lastId, this](const uint32_t succ) {
dan sinclairc7da51a2018-07-12 15:14:43 -0400554 BasicBlock* sbp = this->id2block_[succ];
555 sbp->ForEachPhiInst([&firstId, &lastId](Instruction* phi) {
David Neto87f9cfa2018-02-02 14:17:42 -0800556 phi->ForEachInId([&firstId, &lastId](uint32_t* id) {
557 if (*id == firstId) *id = lastId;
558 });
559 });
GregFe28bd392017-08-01 17:20:13 -0600560 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700561}
562
greg-lunarg67214782018-11-08 07:11:20 -0700563bool InlinePass::HasNoReturnInStructuredConstruct(Function* func) {
564 // If control not structured, do not do loop/return analysis
565 // TODO: Analyze returns in non-structured control flow
566 if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader))
567 return false;
568 const auto structured_analysis = context()->GetStructuredCFGAnalysis();
569 // Search for returns in structured construct.
570 bool return_in_construct = false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600571 for (auto& blk : *func) {
572 auto terminal_ii = blk.cend();
573 --terminal_ii;
greg-lunarg67214782018-11-08 07:11:20 -0700574 if (spvOpcodeIsReturn(terminal_ii->opcode()) &&
575 structured_analysis->ContainingConstruct(blk.id()) != 0) {
576 return_in_construct = true;
577 break;
Greg Fischerbba812f2017-05-04 20:55:53 -0600578 }
579 }
greg-lunarg67214782018-11-08 07:11:20 -0700580 return !return_in_construct;
Greg Fischerbba812f2017-05-04 20:55:53 -0600581}
582
dan sinclairc7da51a2018-07-12 15:14:43 -0400583bool InlinePass::HasNoReturnInLoop(Function* func) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600584 // If control not structured, do not do loop/return analysis
585 // TODO: Analyze returns in non-structured control flow
Steven Perron756b2772017-12-19 14:18:13 -0500586 if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader))
587 return false;
greg-lunarg67214782018-11-08 07:11:20 -0700588 const auto structured_analysis = context()->GetStructuredCFGAnalysis();
589 // Search for returns in structured construct.
Greg Fischerbba812f2017-05-04 20:55:53 -0600590 bool return_in_loop = false;
greg-lunarg67214782018-11-08 07:11:20 -0700591 for (auto& blk : *func) {
592 auto terminal_ii = blk.cend();
Greg Fischerbba812f2017-05-04 20:55:53 -0600593 --terminal_ii;
greg-lunarg67214782018-11-08 07:11:20 -0700594 if (spvOpcodeIsReturn(terminal_ii->opcode()) &&
595 structured_analysis->ContainingLoop(blk.id()) != 0) {
596 return_in_loop = true;
597 break;
Greg Fischerbba812f2017-05-04 20:55:53 -0600598 }
599 }
600 return !return_in_loop;
601}
602
dan sinclairc7da51a2018-07-12 15:14:43 -0400603void InlinePass::AnalyzeReturns(Function* func) {
greg-lunarg67214782018-11-08 07:11:20 -0700604 if (HasNoReturnInLoop(func)) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600605 no_return_in_loop_.insert(func->result_id());
greg-lunarg67214782018-11-08 07:11:20 -0700606 if (!HasNoReturnInStructuredConstruct(func))
607 early_return_funcs_.insert(func->result_id());
Greg Fischerbba812f2017-05-04 20:55:53 -0600608 }
Greg Fischerbba812f2017-05-04 20:55:53 -0600609}
610
dan sinclairc7da51a2018-07-12 15:14:43 -0400611bool InlinePass::IsInlinableFunction(Function* func) {
GregFa107d342017-04-25 13:57:20 -0600612 // We can only inline a function if it has blocks.
Diego Novillod2938e42017-11-08 12:40:02 -0500613 if (func->cbegin() == func->cend()) return false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600614 // Do not inline functions with returns in loops. Currently early return
615 // functions are inlined by wrapping them in a one trip loop and implementing
616 // the returns as a branch to the loop's merge block. However, this can only
617 // done validly if the return was not in a loop in the original function.
618 // Also remember functions with multiple (early) returns.
619 AnalyzeReturns(func);
Steven Perron2d2a5122018-11-29 14:24:58 -0500620 if (no_return_in_loop_.find(func->result_id()) == no_return_in_loop_.cend()) {
621 return false;
622 }
623
624 if (func->IsRecursive()) {
625 return false;
626 }
627
628 return true;
GregFa107d342017-04-25 13:57:20 -0600629}
630
dan sinclairf96b7f12018-07-12 09:08:45 -0400631void InlinePass::InitializeInline() {
Greg Fischerbba812f2017-05-04 20:55:53 -0600632 false_id_ = 0;
633
GregFe28bd392017-08-01 17:20:13 -0600634 // clear collections
Greg Fischer04fcc662016-11-10 10:11:50 -0700635 id2function_.clear();
636 id2block_.clear();
GregFa107d342017-04-25 13:57:20 -0600637 inlinable_.clear();
GregFe28bd392017-08-01 17:20:13 -0600638 no_return_in_loop_.clear();
greg-lunarg67214782018-11-08 07:11:20 -0700639 early_return_funcs_.clear();
GregFe28bd392017-08-01 17:20:13 -0600640
Diego Novillo1040a952017-10-25 13:26:25 -0400641 for (auto& fn : *get_module()) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600642 // Initialize function and block maps.
Greg Fischer04fcc662016-11-10 10:11:50 -0700643 id2function_[fn.result_id()] = &fn;
644 for (auto& blk : fn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600645 id2block_[blk.id()] = &blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700646 }
Greg Fischerbba812f2017-05-04 20:55:53 -0600647 // Compute inlinability
Diego Novillod2938e42017-11-08 12:40:02 -0500648 if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id());
Greg Fischer04fcc662016-11-10 10:11:50 -0700649 }
Eleni Maria Stea045cc8f2018-03-21 11:15:56 +0200650}
Greg Fischer04fcc662016-11-10 10:11:50 -0700651
Diego Novillo1040a952017-10-25 13:26:25 -0400652InlinePass::InlinePass() {}
Greg Fischer04fcc662016-11-10 10:11:50 -0700653
Greg Fischer04fcc662016-11-10 10:11:50 -0700654} // namespace opt
655} // namespace spvtools