Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 1 | // Copyright (c) 2017 The Khronos Group Inc. |
| 2 | // Copyright (c) 2017 Valve Corporation |
| 3 | // Copyright (c) 2017 LunarG Inc. |
| 4 | // |
| 5 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 6 | // you may not use this file except in compliance with the License. |
| 7 | // You may obtain a copy of the License at |
| 8 | // |
| 9 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 10 | // |
| 11 | // Unless required by applicable law or agreed to in writing, software |
| 12 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 13 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 14 | // See the License for the specific language governing permissions and |
| 15 | // limitations under the License. |
| 16 | |
dan sinclair | eda2cfb | 2018-08-03 15:06:09 -0400 | [diff] [blame] | 17 | #include "source/opt/inline_pass.h" |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 18 | |
dan sinclair | eda2cfb | 2018-08-03 15:06:09 -0400 | [diff] [blame] | 19 | #include <unordered_set> |
| 20 | #include <utility> |
| 21 | |
| 22 | #include "source/cfa.h" |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 23 | #include "source/util/make_unique.h" |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 24 | |
| 25 | // Indices of operands in SPIR-V instructions |
| 26 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 27 | static const int kSpvFunctionCallFunctionId = 2; |
| 28 | static const int kSpvFunctionCallArgumentId = 3; |
| 29 | static const int kSpvReturnValueId = 0; |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 30 | static const int kSpvLoopMergeContinueTargetIdInIdx = 1; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 31 | |
| 32 | namespace spvtools { |
| 33 | namespace opt { |
| 34 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 35 | uint32_t InlinePass::AddPointerToType(uint32_t type_id, |
| 36 | SpvStorageClass storage_class) { |
| 37 | uint32_t resultId = TakeNextId(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 38 | std::unique_ptr<Instruction> type_inst( |
| 39 | new Instruction(context(), SpvOpTypePointer, 0, resultId, |
| 40 | {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS, |
| 41 | {uint32_t(storage_class)}}, |
| 42 | {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}})); |
Steven Perron | 476cae6 | 2017-10-30 11:13:24 -0400 | [diff] [blame] | 43 | context()->AddType(std::move(type_inst)); |
Alan Baker | 6169085 | 2017-12-08 15:33:19 -0500 | [diff] [blame] | 44 | analysis::Type* pointeeTy; |
| 45 | std::unique_ptr<analysis::Pointer> pointerTy; |
| 46 | std::tie(pointeeTy, pointerTy) = |
| 47 | context()->get_type_mgr()->GetTypeAndPointerType(type_id, |
| 48 | SpvStorageClassFunction); |
| 49 | context()->get_type_mgr()->RegisterType(resultId, *pointerTy); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 50 | return resultId; |
| 51 | } |
| 52 | |
| 53 | void InlinePass::AddBranch(uint32_t label_id, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 54 | std::unique_ptr<BasicBlock>* block_ptr) { |
| 55 | std::unique_ptr<Instruction> newBranch( |
| 56 | new Instruction(context(), SpvOpBranch, 0, 0, |
| 57 | {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}})); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 58 | (*block_ptr)->AddInstruction(std::move(newBranch)); |
| 59 | } |
| 60 | |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 61 | void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id, |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 62 | uint32_t false_id, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 63 | std::unique_ptr<BasicBlock>* block_ptr) { |
| 64 | std::unique_ptr<Instruction> newBranch( |
| 65 | new Instruction(context(), SpvOpBranchConditional, 0, 0, |
| 66 | {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}}, |
| 67 | {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}}, |
| 68 | {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}})); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 69 | (*block_ptr)->AddInstruction(std::move(newBranch)); |
| 70 | } |
| 71 | |
| 72 | void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 73 | std::unique_ptr<BasicBlock>* block_ptr) { |
| 74 | std::unique_ptr<Instruction> newLoopMerge(new Instruction( |
Alan Baker | a771713 | 2017-11-14 14:11:50 -0500 | [diff] [blame] | 75 | context(), SpvOpLoopMerge, 0, 0, |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 76 | {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}}, |
| 77 | {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}}, |
| 78 | {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}})); |
| 79 | (*block_ptr)->AddInstruction(std::move(newLoopMerge)); |
| 80 | } |
| 81 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 82 | void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 83 | std::unique_ptr<BasicBlock>* block_ptr) { |
| 84 | std::unique_ptr<Instruction> newStore( |
| 85 | new Instruction(context(), SpvOpStore, 0, 0, |
| 86 | {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}, |
| 87 | {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}})); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 88 | (*block_ptr)->AddInstruction(std::move(newStore)); |
| 89 | } |
| 90 | |
| 91 | void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 92 | std::unique_ptr<BasicBlock>* block_ptr) { |
| 93 | std::unique_ptr<Instruction> newLoad( |
| 94 | new Instruction(context(), SpvOpLoad, type_id, resultId, |
| 95 | {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}})); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 96 | (*block_ptr)->AddInstruction(std::move(newLoad)); |
| 97 | } |
| 98 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 99 | std::unique_ptr<Instruction> InlinePass::NewLabel(uint32_t label_id) { |
| 100 | std::unique_ptr<Instruction> newLabel( |
| 101 | new Instruction(context(), SpvOpLabel, 0, label_id, {})); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 102 | return newLabel; |
| 103 | } |
| 104 | |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 105 | uint32_t InlinePass::GetFalseId() { |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 106 | if (false_id_ != 0) return false_id_; |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 107 | false_id_ = get_module()->GetGlobalValue(SpvOpConstantFalse); |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 108 | if (false_id_ != 0) return false_id_; |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 109 | uint32_t boolId = get_module()->GetGlobalValue(SpvOpTypeBool); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 110 | if (boolId == 0) { |
| 111 | boolId = TakeNextId(); |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 112 | get_module()->AddGlobalValue(SpvOpTypeBool, boolId, 0); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 113 | } |
| 114 | false_id_ = TakeNextId(); |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 115 | get_module()->AddGlobalValue(SpvOpConstantFalse, false_id_, boolId); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 116 | return false_id_; |
| 117 | } |
| 118 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 119 | void InlinePass::MapParams( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 120 | Function* calleeFn, BasicBlock::iterator call_inst_itr, |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 121 | std::unordered_map<uint32_t, uint32_t>* callee2caller) { |
| 122 | int param_idx = 0; |
dan sinclair | e6b9533 | 2018-07-09 11:32:29 -0400 | [diff] [blame] | 123 | calleeFn->ForEachParam([&call_inst_itr, ¶m_idx, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 124 | &callee2caller](const Instruction* cpi) { |
dan sinclair | e6b9533 | 2018-07-09 11:32:29 -0400 | [diff] [blame] | 125 | const uint32_t pid = cpi->result_id(); |
| 126 | (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand( |
| 127 | kSpvFunctionCallArgumentId + param_idx); |
| 128 | ++param_idx; |
| 129 | }); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 130 | } |
| 131 | |
| 132 | void InlinePass::CloneAndMapLocals( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 133 | Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars, |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 134 | std::unordered_map<uint32_t, uint32_t>* callee2caller) { |
| 135 | auto callee_block_itr = calleeFn->begin(); |
| 136 | auto callee_var_itr = callee_block_itr->begin(); |
| 137 | while (callee_var_itr->opcode() == SpvOp::SpvOpVariable) { |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 138 | std::unique_ptr<Instruction> var_inst(callee_var_itr->Clone(context())); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 139 | uint32_t newId = TakeNextId(); |
Pierre Moreau | 5bd55f1 | 2018-02-20 19:19:57 +0100 | [diff] [blame] | 140 | get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 141 | var_inst->SetResultId(newId); |
| 142 | (*callee2caller)[callee_var_itr->result_id()] = newId; |
| 143 | new_vars->push_back(std::move(var_inst)); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 144 | ++callee_var_itr; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 145 | } |
| 146 | } |
| 147 | |
| 148 | uint32_t InlinePass::CreateReturnVar( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 149 | Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars) { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 150 | uint32_t returnVarId = 0; |
| 151 | const uint32_t calleeTypeId = calleeFn->type_id(); |
Steven Perron | 06b437d | 2018-02-09 20:33:06 -0500 | [diff] [blame] | 152 | analysis::Type* calleeType = context()->get_type_mgr()->GetType(calleeTypeId); |
| 153 | if (calleeType->AsVoid() == nullptr) { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 154 | // Find or create ptr to callee return type. |
Steven Perron | b86eb68 | 2017-12-11 13:10:24 -0500 | [diff] [blame] | 155 | uint32_t returnVarTypeId = context()->get_type_mgr()->FindPointerToType( |
| 156 | calleeTypeId, SpvStorageClassFunction); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 157 | if (returnVarTypeId == 0) |
| 158 | returnVarTypeId = AddPointerToType(calleeTypeId, SpvStorageClassFunction); |
| 159 | // Add return var to new function scope variables. |
| 160 | returnVarId = TakeNextId(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 161 | std::unique_ptr<Instruction> var_inst( |
| 162 | new Instruction(context(), SpvOpVariable, returnVarTypeId, returnVarId, |
| 163 | {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS, |
| 164 | {SpvStorageClassFunction}}})); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 165 | new_vars->push_back(std::move(var_inst)); |
| 166 | } |
Pierre Moreau | 5bd55f1 | 2018-02-20 19:19:57 +0100 | [diff] [blame] | 167 | get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 168 | return returnVarId; |
| 169 | } |
| 170 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 171 | bool InlinePass::IsSameBlockOp(const Instruction* inst) const { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 172 | return inst->opcode() == SpvOpSampledImage || inst->opcode() == SpvOpImage; |
| 173 | } |
| 174 | |
| 175 | void InlinePass::CloneSameBlockOps( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 176 | std::unique_ptr<Instruction>* inst, |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 177 | std::unordered_map<uint32_t, uint32_t>* postCallSB, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 178 | std::unordered_map<uint32_t, Instruction*>* preCallSB, |
| 179 | std::unique_ptr<BasicBlock>* block_ptr) { |
Pierre Moreau | 5bd55f1 | 2018-02-20 19:19:57 +0100 | [diff] [blame] | 180 | (*inst)->ForEachInId( |
| 181 | [&postCallSB, &preCallSB, &block_ptr, this](uint32_t* iid) { |
| 182 | const auto mapItr = (*postCallSB).find(*iid); |
| 183 | if (mapItr == (*postCallSB).end()) { |
| 184 | const auto mapItr2 = (*preCallSB).find(*iid); |
| 185 | if (mapItr2 != (*preCallSB).end()) { |
| 186 | // Clone pre-call same-block ops, map result id. |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 187 | const Instruction* inInst = mapItr2->second; |
| 188 | std::unique_ptr<Instruction> sb_inst(inInst->Clone(context())); |
Pierre Moreau | 5bd55f1 | 2018-02-20 19:19:57 +0100 | [diff] [blame] | 189 | CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr); |
| 190 | const uint32_t rid = sb_inst->result_id(); |
| 191 | const uint32_t nid = this->TakeNextId(); |
| 192 | get_decoration_mgr()->CloneDecorations(rid, nid); |
| 193 | sb_inst->SetResultId(nid); |
| 194 | (*postCallSB)[rid] = nid; |
| 195 | *iid = nid; |
| 196 | (*block_ptr)->AddInstruction(std::move(sb_inst)); |
| 197 | } |
| 198 | } else { |
| 199 | // Reset same-block op operand. |
| 200 | *iid = mapItr->second; |
| 201 | } |
| 202 | }); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 203 | } |
| 204 | |
| 205 | void InlinePass::GenInlineCode( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 206 | std::vector<std::unique_ptr<BasicBlock>>* new_blocks, |
| 207 | std::vector<std::unique_ptr<Instruction>>* new_vars, |
| 208 | BasicBlock::iterator call_inst_itr, |
| 209 | UptrVectorIterator<BasicBlock> call_block_itr) { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 210 | // Map from all ids in the callee to their equivalent id in the caller |
| 211 | // as callee instructions are copied into caller. |
| 212 | std::unordered_map<uint32_t, uint32_t> callee2caller; |
| 213 | // Pre-call same-block insts |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 214 | std::unordered_map<uint32_t, Instruction*> preCallSB; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 215 | // Post-call same-block op ids |
| 216 | std::unordered_map<uint32_t, uint32_t> postCallSB; |
| 217 | |
Steven Perron | b3daa93 | 2018-03-06 11:20:28 -0500 | [diff] [blame] | 218 | // Invalidate the def-use chains. They are not kept up to date while |
| 219 | // inlining. However, certain calls try to keep them up-to-date if they are |
| 220 | // valid. These operations can fail. |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 221 | context()->InvalidateAnalyses(IRContext::kAnalysisDefUse); |
Steven Perron | b3daa93 | 2018-03-06 11:20:28 -0500 | [diff] [blame] | 222 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 223 | Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand( |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 224 | kSpvFunctionCallFunctionId)]; |
| 225 | |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 226 | // Check for multiple returns in the callee. |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 227 | auto fi = early_return_funcs_.find(calleeFn->result_id()); |
| 228 | const bool earlyReturn = fi != early_return_funcs_.end(); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 229 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 230 | // Map parameters to actual arguments. |
| 231 | MapParams(calleeFn, call_inst_itr, &callee2caller); |
| 232 | |
| 233 | // Define caller local variables for all callee variables and create map to |
| 234 | // them. |
| 235 | CloneAndMapLocals(calleeFn, new_vars, &callee2caller); |
| 236 | |
| 237 | // Create return var if needed. |
| 238 | uint32_t returnVarId = CreateReturnVar(calleeFn, new_vars); |
| 239 | |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 240 | // Create set of callee result ids. Used to detect forward references |
| 241 | std::unordered_set<uint32_t> callee_result_ids; |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 242 | calleeFn->ForEachInst([&callee_result_ids](const Instruction* cpi) { |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 243 | const uint32_t rid = cpi->result_id(); |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 244 | if (rid != 0) callee_result_ids.insert(rid); |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 245 | }); |
| 246 | |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 247 | // If the caller is in a single-block loop, and the callee has multiple |
| 248 | // blocks, then the normal inlining logic will place the OpLoopMerge in |
| 249 | // the last of several blocks in the loop. Instead, it should be placed |
| 250 | // at the end of the first block. First determine if the caller is in a |
| 251 | // single block loop. We'll wait to move the OpLoopMerge until the end |
| 252 | // of the regular inlining logic, and only if necessary. |
| 253 | bool caller_is_single_block_loop = false; |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 254 | bool caller_is_loop_header = false; |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 255 | if (auto* loop_merge = call_block_itr->GetLoopMergeInst()) { |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 256 | caller_is_loop_header = true; |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 257 | caller_is_single_block_loop = |
| 258 | call_block_itr->id() == |
| 259 | loop_merge->GetSingleWordInOperand(kSpvLoopMergeContinueTargetIdInIdx); |
| 260 | } |
| 261 | |
| 262 | bool callee_begins_with_structured_header = |
| 263 | (*(calleeFn->begin())).GetMergeInst() != nullptr; |
| 264 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 265 | // Clone and map callee code. Copy caller block code to beginning of |
| 266 | // first block and end of last block. |
| 267 | bool prevInstWasReturn = false; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 268 | uint32_t singleTripLoopHeaderId = 0; |
| 269 | uint32_t singleTripLoopContinueId = 0; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 270 | uint32_t returnLabelId = 0; |
| 271 | bool multiBlocks = false; |
| 272 | const uint32_t calleeTypeId = calleeFn->type_id(); |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 273 | // new_blk_ptr is a new basic block in the caller. New instructions are |
| 274 | // written to it. It is created when we encounter the OpLabel |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 275 | // of the first callee block. It is appended to new_blocks only when |
| 276 | // it is complete. |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 277 | std::unique_ptr<BasicBlock> new_blk_ptr; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 278 | calleeFn->ForEachInst([&new_blocks, &callee2caller, &call_block_itr, |
| 279 | &call_inst_itr, &new_blk_ptr, &prevInstWasReturn, |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 280 | &returnLabelId, &returnVarId, caller_is_loop_header, |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 281 | callee_begins_with_structured_header, &calleeTypeId, |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 282 | &multiBlocks, &postCallSB, &preCallSB, earlyReturn, |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 283 | &singleTripLoopHeaderId, &singleTripLoopContinueId, |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 284 | &callee_result_ids, this](const Instruction* cpi) { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 285 | switch (cpi->opcode()) { |
| 286 | case SpvOpFunction: |
| 287 | case SpvOpFunctionParameter: |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 288 | // Already processed |
| 289 | break; |
Steven Perron | 9a00883 | 2018-05-31 20:28:19 -0400 | [diff] [blame] | 290 | case SpvOpVariable: |
| 291 | if (cpi->NumInOperands() == 2) { |
| 292 | assert(callee2caller.count(cpi->result_id()) && |
| 293 | "Expected the variable to have already been mapped."); |
| 294 | uint32_t new_var_id = callee2caller.at(cpi->result_id()); |
| 295 | |
| 296 | // The initializer must be a constant or global value. No mapped |
| 297 | // should be used. |
| 298 | uint32_t val_id = cpi->GetSingleWordInOperand(1); |
| 299 | AddStore(new_var_id, val_id, &new_blk_ptr); |
| 300 | } |
| 301 | break; |
Alan Baker | 4246abd | 2018-04-26 12:22:08 -0400 | [diff] [blame] | 302 | case SpvOpUnreachable: |
| 303 | case SpvOpKill: { |
| 304 | // Generate a return label so that we split the block with the function |
| 305 | // call. Copy the terminator into the new block. |
| 306 | if (returnLabelId == 0) returnLabelId = this->TakeNextId(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 307 | std::unique_ptr<Instruction> terminator( |
| 308 | new Instruction(context(), cpi->opcode(), 0, 0, {})); |
Alan Baker | 4246abd | 2018-04-26 12:22:08 -0400 | [diff] [blame] | 309 | new_blk_ptr->AddInstruction(std::move(terminator)); |
| 310 | break; |
| 311 | } |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 312 | case SpvOpLabel: { |
| 313 | // If previous instruction was early return, insert branch |
| 314 | // instruction to return block. |
| 315 | if (prevInstWasReturn) { |
| 316 | if (returnLabelId == 0) returnLabelId = this->TakeNextId(); |
| 317 | AddBranch(returnLabelId, &new_blk_ptr); |
| 318 | prevInstWasReturn = false; |
| 319 | } |
| 320 | // Finish current block (if it exists) and get label for next block. |
| 321 | uint32_t labelId; |
| 322 | bool firstBlock = false; |
| 323 | if (new_blk_ptr != nullptr) { |
| 324 | new_blocks->push_back(std::move(new_blk_ptr)); |
| 325 | // If result id is already mapped, use it, otherwise get a new |
| 326 | // one. |
| 327 | const uint32_t rid = cpi->result_id(); |
| 328 | const auto mapItr = callee2caller.find(rid); |
| 329 | labelId = (mapItr != callee2caller.end()) ? mapItr->second |
| 330 | : this->TakeNextId(); |
| 331 | } else { |
| 332 | // First block needs to use label of original block |
| 333 | // but map callee label in case of phi reference. |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 334 | labelId = call_block_itr->id(); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 335 | callee2caller[cpi->result_id()] = labelId; |
| 336 | firstBlock = true; |
| 337 | } |
| 338 | // Create first/next block. |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 339 | new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(labelId)); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 340 | if (firstBlock) { |
| 341 | // Copy contents of original caller block up to call instruction. |
| 342 | for (auto cii = call_block_itr->begin(); cii != call_inst_itr; |
Steven Perron | 51ecc73 | 2018-02-20 11:24:08 -0500 | [diff] [blame] | 343 | cii = call_block_itr->begin()) { |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 344 | Instruction* inst = &*cii; |
Steven Perron | 51ecc73 | 2018-02-20 11:24:08 -0500 | [diff] [blame] | 345 | inst->RemoveFromList(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 346 | std::unique_ptr<Instruction> cp_inst(inst); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 347 | // Remember same-block ops for possible regeneration. |
| 348 | if (IsSameBlockOp(&*cp_inst)) { |
| 349 | auto* sb_inst_ptr = cp_inst.get(); |
| 350 | preCallSB[cp_inst->result_id()] = sb_inst_ptr; |
| 351 | } |
| 352 | new_blk_ptr->AddInstruction(std::move(cp_inst)); |
| 353 | } |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 354 | if (caller_is_loop_header && callee_begins_with_structured_header) { |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 355 | // We can't place both the caller's merge instruction and another |
| 356 | // merge instruction in the same block. So split the calling block. |
| 357 | // Insert an unconditional branch to a new guard block. Later, |
| 358 | // once we know the ID of the last block, we will move the caller's |
| 359 | // OpLoopMerge from the last generated block into the first block. |
| 360 | // We also wait to avoid invalidating various iterators. |
| 361 | const auto guard_block_id = this->TakeNextId(); |
| 362 | AddBranch(guard_block_id, &new_blk_ptr); |
| 363 | new_blocks->push_back(std::move(new_blk_ptr)); |
| 364 | // Start the next block. |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 365 | new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(guard_block_id)); |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 366 | // Reset the mapping of the callee's entry block to point to |
| 367 | // the guard block. Do this so we can fix up phis later on to |
| 368 | // satisfy dominance. |
| 369 | callee2caller[cpi->result_id()] = guard_block_id; |
| 370 | } |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 371 | // If callee has early return, insert a header block for |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 372 | // single-trip loop that will encompass callee code. Start postheader |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 373 | // block. |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 374 | // |
| 375 | // Note: Consider the following combination: |
| 376 | // - the caller is a single block loop |
| 377 | // - the callee does not begin with a structure header |
| 378 | // - the callee has multiple returns. |
| 379 | // We still need to split the caller block and insert a guard block. |
| 380 | // But we only need to do it once. We haven't done it yet, but the |
| 381 | // single-trip loop header will serve the same purpose. |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 382 | if (earlyReturn) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 383 | singleTripLoopHeaderId = this->TakeNextId(); |
| 384 | AddBranch(singleTripLoopHeaderId, &new_blk_ptr); |
| 385 | new_blocks->push_back(std::move(new_blk_ptr)); |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 386 | new_blk_ptr = |
| 387 | MakeUnique<BasicBlock>(NewLabel(singleTripLoopHeaderId)); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 388 | returnLabelId = this->TakeNextId(); |
| 389 | singleTripLoopContinueId = this->TakeNextId(); |
| 390 | AddLoopMerge(returnLabelId, singleTripLoopContinueId, &new_blk_ptr); |
| 391 | uint32_t postHeaderId = this->TakeNextId(); |
| 392 | AddBranch(postHeaderId, &new_blk_ptr); |
| 393 | new_blocks->push_back(std::move(new_blk_ptr)); |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 394 | new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(postHeaderId)); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 395 | multiBlocks = true; |
David Neto | 860c419 | 2017-08-31 17:33:44 -0400 | [diff] [blame] | 396 | // Reset the mapping of the callee's entry block to point to |
| 397 | // the post-header block. Do this so we can fix up phis later |
| 398 | // on to satisfy dominance. |
| 399 | callee2caller[cpi->result_id()] = postHeaderId; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 400 | } |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 401 | } else { |
| 402 | multiBlocks = true; |
| 403 | } |
| 404 | } break; |
| 405 | case SpvOpReturnValue: { |
| 406 | // Store return value to return variable. |
| 407 | assert(returnVarId != 0); |
| 408 | uint32_t valId = cpi->GetInOperand(kSpvReturnValueId).words[0]; |
| 409 | const auto mapItr = callee2caller.find(valId); |
| 410 | if (mapItr != callee2caller.end()) { |
| 411 | valId = mapItr->second; |
| 412 | } |
| 413 | AddStore(returnVarId, valId, &new_blk_ptr); |
| 414 | |
| 415 | // Remember we saw a return; if followed by a label, will need to |
| 416 | // insert branch. |
| 417 | prevInstWasReturn = true; |
| 418 | } break; |
| 419 | case SpvOpReturn: { |
| 420 | // Remember we saw a return; if followed by a label, will need to |
| 421 | // insert branch. |
| 422 | prevInstWasReturn = true; |
| 423 | } break; |
| 424 | case SpvOpFunctionEnd: { |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 425 | // If there was an early return, we generated a return label id |
| 426 | // for it. Now we have to generate the return block with that Id. |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 427 | if (returnLabelId != 0) { |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 428 | // If previous instruction was return, insert branch instruction |
| 429 | // to return block. |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 430 | if (prevInstWasReturn) AddBranch(returnLabelId, &new_blk_ptr); |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 431 | if (earlyReturn) { |
| 432 | // If we generated a loop header for the single-trip loop |
| 433 | // to accommodate early returns, insert the continue |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 434 | // target block now, with a false branch back to the loop header. |
| 435 | new_blocks->push_back(std::move(new_blk_ptr)); |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 436 | new_blk_ptr = |
| 437 | MakeUnique<BasicBlock>(NewLabel(singleTripLoopContinueId)); |
David Neto | 2a1014b | 2017-08-09 14:59:04 -0400 | [diff] [blame] | 438 | AddBranchCond(GetFalseId(), singleTripLoopHeaderId, returnLabelId, |
| 439 | &new_blk_ptr); |
| 440 | } |
| 441 | // Generate the return block. |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 442 | new_blocks->push_back(std::move(new_blk_ptr)); |
dan sinclair | 1963a2d | 2018-08-14 15:01:50 -0400 | [diff] [blame] | 443 | new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(returnLabelId)); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 444 | multiBlocks = true; |
| 445 | } |
| 446 | // Load return value into result id of call, if it exists. |
| 447 | if (returnVarId != 0) { |
| 448 | const uint32_t resId = call_inst_itr->result_id(); |
| 449 | assert(resId != 0); |
| 450 | AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr); |
| 451 | } |
| 452 | // Copy remaining instructions from caller block. |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 453 | for (Instruction* inst = call_inst_itr->NextNode(); inst; |
Steven Perron | 51ecc73 | 2018-02-20 11:24:08 -0500 | [diff] [blame] | 454 | inst = call_inst_itr->NextNode()) { |
| 455 | inst->RemoveFromList(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 456 | std::unique_ptr<Instruction> cp_inst(inst); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 457 | // If multiple blocks generated, regenerate any same-block |
| 458 | // instruction that has not been seen in this last block. |
| 459 | if (multiBlocks) { |
| 460 | CloneSameBlockOps(&cp_inst, &postCallSB, &preCallSB, &new_blk_ptr); |
| 461 | // Remember same-block ops in this block. |
| 462 | if (IsSameBlockOp(&*cp_inst)) { |
| 463 | const uint32_t rid = cp_inst->result_id(); |
| 464 | postCallSB[rid] = rid; |
| 465 | } |
| 466 | } |
| 467 | new_blk_ptr->AddInstruction(std::move(cp_inst)); |
| 468 | } |
| 469 | // Finalize inline code. |
| 470 | new_blocks->push_back(std::move(new_blk_ptr)); |
| 471 | } break; |
| 472 | default: { |
| 473 | // Copy callee instruction and remap all input Ids. |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 474 | std::unique_ptr<Instruction> cp_inst(cpi->Clone(context())); |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 475 | cp_inst->ForEachInId([&callee2caller, &callee_result_ids, |
| 476 | this](uint32_t* iid) { |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 477 | const auto mapItr = callee2caller.find(*iid); |
| 478 | if (mapItr != callee2caller.end()) { |
| 479 | *iid = mapItr->second; |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 480 | } else if (callee_result_ids.find(*iid) != callee_result_ids.end()) { |
| 481 | // Forward reference. Allocate a new id, map it, |
| 482 | // use it and check for it when remapping result ids |
| 483 | const uint32_t nid = this->TakeNextId(); |
| 484 | callee2caller[*iid] = nid; |
| 485 | *iid = nid; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 486 | } |
| 487 | }); |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 488 | // If result id is non-zero, remap it. If already mapped, use mapped |
| 489 | // value, else use next id. |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 490 | const uint32_t rid = cp_inst->result_id(); |
| 491 | if (rid != 0) { |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 492 | const auto mapItr = callee2caller.find(rid); |
| 493 | uint32_t nid; |
| 494 | if (mapItr != callee2caller.end()) { |
| 495 | nid = mapItr->second; |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 496 | } else { |
GregF | a699d1a | 2017-08-29 18:35:05 -0600 | [diff] [blame] | 497 | nid = this->TakeNextId(); |
| 498 | callee2caller[rid] = nid; |
| 499 | } |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 500 | cp_inst->SetResultId(nid); |
Pierre Moreau | 5bd55f1 | 2018-02-20 19:19:57 +0100 | [diff] [blame] | 501 | get_decoration_mgr()->CloneDecorations(rid, nid); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 502 | } |
| 503 | new_blk_ptr->AddInstruction(std::move(cp_inst)); |
| 504 | } break; |
| 505 | } |
| 506 | }); |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 507 | |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 508 | if (caller_is_loop_header && (new_blocks->size() > 1)) { |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 509 | // Move the OpLoopMerge from the last block back to the first, where |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 510 | // it belongs. |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 511 | auto& first = new_blocks->front(); |
| 512 | auto& last = new_blocks->back(); |
| 513 | assert(first != last); |
| 514 | |
| 515 | // Insert a modified copy of the loop merge into the first block. |
| 516 | auto loop_merge_itr = last->tail(); |
| 517 | --loop_merge_itr; |
| 518 | assert(loop_merge_itr->opcode() == SpvOpLoopMerge); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 519 | std::unique_ptr<Instruction> cp_inst(loop_merge_itr->Clone(context())); |
David Neto | 25ddfec | 2017-09-02 19:01:03 -0400 | [diff] [blame] | 520 | if (caller_is_single_block_loop) { |
| 521 | // Also, update its continue target to point to the last block. |
| 522 | cp_inst->SetInOperand(kSpvLoopMergeContinueTargetIdInIdx, {last->id()}); |
| 523 | } |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 524 | first->tail().InsertBefore(std::move(cp_inst)); |
| 525 | |
| 526 | // Remove the loop merge from the last block. |
Steven Perron | bb7802b | 2017-10-13 14:25:21 -0400 | [diff] [blame] | 527 | loop_merge_itr->RemoveFromList(); |
| 528 | delete &*loop_merge_itr; |
David Neto | efff5fa | 2017-08-31 15:47:31 -0400 | [diff] [blame] | 529 | } |
| 530 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 531 | // Update block map given replacement blocks. |
| 532 | for (auto& blk : *new_blocks) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 533 | id2block_[blk->id()] = &*blk; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 534 | } |
| 535 | } |
| 536 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 537 | bool InlinePass::IsInlinableFunctionCall(const Instruction* inst) { |
David Neto | ceb1d4f | 2017-03-31 10:36:58 -0400 | [diff] [blame] | 538 | if (inst->opcode() != SpvOp::SpvOpFunctionCall) return false; |
GregF | a107d34 | 2017-04-25 13:57:20 -0600 | [diff] [blame] | 539 | const uint32_t calleeFnId = |
| 540 | inst->GetSingleWordOperand(kSpvFunctionCallFunctionId); |
| 541 | const auto ci = inlinable_.find(calleeFnId); |
| 542 | return ci != inlinable_.cend(); |
David Neto | ceb1d4f | 2017-03-31 10:36:58 -0400 | [diff] [blame] | 543 | } |
| 544 | |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 545 | void InlinePass::UpdateSucceedingPhis( |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 546 | std::vector<std::unique_ptr<BasicBlock>>& new_blocks) { |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 547 | const auto firstBlk = new_blocks.begin(); |
| 548 | const auto lastBlk = new_blocks.end() - 1; |
| 549 | const uint32_t firstId = (*firstBlk)->id(); |
| 550 | const uint32_t lastId = (*lastBlk)->id(); |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 551 | const BasicBlock& const_last_block = *lastBlk->get(); |
David Neto | 87f9cfa | 2018-02-02 14:17:42 -0800 | [diff] [blame] | 552 | const_last_block.ForEachSuccessorLabel( |
| 553 | [&firstId, &lastId, this](const uint32_t succ) { |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 554 | BasicBlock* sbp = this->id2block_[succ]; |
| 555 | sbp->ForEachPhiInst([&firstId, &lastId](Instruction* phi) { |
David Neto | 87f9cfa | 2018-02-02 14:17:42 -0800 | [diff] [blame] | 556 | phi->ForEachInId([&firstId, &lastId](uint32_t* id) { |
| 557 | if (*id == firstId) *id = lastId; |
| 558 | }); |
| 559 | }); |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 560 | }); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 561 | } |
| 562 | |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 563 | bool InlinePass::HasNoReturnInStructuredConstruct(Function* func) { |
| 564 | // If control not structured, do not do loop/return analysis |
| 565 | // TODO: Analyze returns in non-structured control flow |
| 566 | if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader)) |
| 567 | return false; |
| 568 | const auto structured_analysis = context()->GetStructuredCFGAnalysis(); |
| 569 | // Search for returns in structured construct. |
| 570 | bool return_in_construct = false; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 571 | for (auto& blk : *func) { |
| 572 | auto terminal_ii = blk.cend(); |
| 573 | --terminal_ii; |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 574 | if (spvOpcodeIsReturn(terminal_ii->opcode()) && |
| 575 | structured_analysis->ContainingConstruct(blk.id()) != 0) { |
| 576 | return_in_construct = true; |
| 577 | break; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 578 | } |
| 579 | } |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 580 | return !return_in_construct; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 581 | } |
| 582 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 583 | bool InlinePass::HasNoReturnInLoop(Function* func) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 584 | // If control not structured, do not do loop/return analysis |
| 585 | // TODO: Analyze returns in non-structured control flow |
Steven Perron | 756b277 | 2017-12-19 14:18:13 -0500 | [diff] [blame] | 586 | if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader)) |
| 587 | return false; |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 588 | const auto structured_analysis = context()->GetStructuredCFGAnalysis(); |
| 589 | // Search for returns in structured construct. |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 590 | bool return_in_loop = false; |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 591 | for (auto& blk : *func) { |
| 592 | auto terminal_ii = blk.cend(); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 593 | --terminal_ii; |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 594 | if (spvOpcodeIsReturn(terminal_ii->opcode()) && |
| 595 | structured_analysis->ContainingLoop(blk.id()) != 0) { |
| 596 | return_in_loop = true; |
| 597 | break; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 598 | } |
| 599 | } |
| 600 | return !return_in_loop; |
| 601 | } |
| 602 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 603 | void InlinePass::AnalyzeReturns(Function* func) { |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 604 | if (HasNoReturnInLoop(func)) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 605 | no_return_in_loop_.insert(func->result_id()); |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 606 | if (!HasNoReturnInStructuredConstruct(func)) |
| 607 | early_return_funcs_.insert(func->result_id()); |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 608 | } |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 609 | } |
| 610 | |
dan sinclair | c7da51a | 2018-07-12 15:14:43 -0400 | [diff] [blame] | 611 | bool InlinePass::IsInlinableFunction(Function* func) { |
GregF | a107d34 | 2017-04-25 13:57:20 -0600 | [diff] [blame] | 612 | // We can only inline a function if it has blocks. |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 613 | if (func->cbegin() == func->cend()) return false; |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 614 | // Do not inline functions with returns in loops. Currently early return |
| 615 | // functions are inlined by wrapping them in a one trip loop and implementing |
| 616 | // the returns as a branch to the loop's merge block. However, this can only |
| 617 | // done validly if the return was not in a loop in the original function. |
| 618 | // Also remember functions with multiple (early) returns. |
| 619 | AnalyzeReturns(func); |
Steven Perron | 2d2a512 | 2018-11-29 14:24:58 -0500 | [diff] [blame^] | 620 | if (no_return_in_loop_.find(func->result_id()) == no_return_in_loop_.cend()) { |
| 621 | return false; |
| 622 | } |
| 623 | |
| 624 | if (func->IsRecursive()) { |
| 625 | return false; |
| 626 | } |
| 627 | |
| 628 | return true; |
GregF | a107d34 | 2017-04-25 13:57:20 -0600 | [diff] [blame] | 629 | } |
| 630 | |
dan sinclair | f96b7f1 | 2018-07-12 09:08:45 -0400 | [diff] [blame] | 631 | void InlinePass::InitializeInline() { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 632 | false_id_ = 0; |
| 633 | |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 634 | // clear collections |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 635 | id2function_.clear(); |
| 636 | id2block_.clear(); |
GregF | a107d34 | 2017-04-25 13:57:20 -0600 | [diff] [blame] | 637 | inlinable_.clear(); |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 638 | no_return_in_loop_.clear(); |
greg-lunarg | 6721478 | 2018-11-08 07:11:20 -0700 | [diff] [blame] | 639 | early_return_funcs_.clear(); |
GregF | e28bd39 | 2017-08-01 17:20:13 -0600 | [diff] [blame] | 640 | |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 641 | for (auto& fn : *get_module()) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 642 | // Initialize function and block maps. |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 643 | id2function_[fn.result_id()] = &fn; |
| 644 | for (auto& blk : fn) { |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 645 | id2block_[blk.id()] = &blk; |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 646 | } |
Greg Fischer | bba812f | 2017-05-04 20:55:53 -0600 | [diff] [blame] | 647 | // Compute inlinability |
Diego Novillo | d2938e4 | 2017-11-08 12:40:02 -0500 | [diff] [blame] | 648 | if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id()); |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 649 | } |
Eleni Maria Stea | 045cc8f | 2018-03-21 11:15:56 +0200 | [diff] [blame] | 650 | } |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 651 | |
Diego Novillo | 1040a95 | 2017-10-25 13:26:25 -0400 | [diff] [blame] | 652 | InlinePass::InlinePass() {} |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 653 | |
Greg Fischer | 04fcc66 | 2016-11-10 10:11:50 -0700 | [diff] [blame] | 654 | } // namespace opt |
| 655 | } // namespace spvtools |