blob: 8be5889c2e4e701add024328a75ec99e1d32dbaa [file] [log] [blame]
Greg Fischer04fcc662016-11-10 10:11:50 -07001// Copyright (c) 2017 The Khronos Group Inc.
2// Copyright (c) 2017 Valve Corporation
3// Copyright (c) 2017 LunarG Inc.
4//
5// Licensed under the Apache License, Version 2.0 (the "License");
6// you may not use this file except in compliance with the License.
7// You may obtain a copy of the License at
8//
9// http://www.apache.org/licenses/LICENSE-2.0
10//
11// Unless required by applicable law or agreed to in writing, software
12// distributed under the License is distributed on an "AS IS" BASIS,
13// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14// See the License for the specific language governing permissions and
15// limitations under the License.
16
17#include "inline_pass.h"
GregFe28bd392017-08-01 17:20:13 -060018
Greg Fischerbba812f2017-05-04 20:55:53 -060019#include "cfa.h"
Greg Fischer04fcc662016-11-10 10:11:50 -070020
21// Indices of operands in SPIR-V instructions
22
Greg Fischer04fcc662016-11-10 10:11:50 -070023static const int kSpvFunctionCallFunctionId = 2;
24static const int kSpvFunctionCallArgumentId = 3;
25static const int kSpvReturnValueId = 0;
Greg Fischerbba812f2017-05-04 20:55:53 -060026static const int kSpvLoopMergeMergeBlockId = 0;
David Netoefff5fa2017-08-31 15:47:31 -040027static const int kSpvLoopMergeContinueTargetIdInIdx = 1;
Greg Fischer04fcc662016-11-10 10:11:50 -070028
29namespace spvtools {
30namespace opt {
31
Greg Fischer04fcc662016-11-10 10:11:50 -070032uint32_t InlinePass::AddPointerToType(uint32_t type_id,
33 SpvStorageClass storage_class) {
34 uint32_t resultId = TakeNextId();
35 std::unique_ptr<ir::Instruction> type_inst(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050036 context(), SpvOpTypePointer, 0, resultId,
Greg Fischer04fcc662016-11-10 10:11:50 -070037 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
38 {uint32_t(storage_class)}},
39 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}}));
Steven Perron476cae62017-10-30 11:13:24 -040040 context()->AddType(std::move(type_inst));
Alan Baker61690852017-12-08 15:33:19 -050041 analysis::Type* pointeeTy;
42 std::unique_ptr<analysis::Pointer> pointerTy;
43 std::tie(pointeeTy, pointerTy) =
44 context()->get_type_mgr()->GetTypeAndPointerType(type_id,
45 SpvStorageClassFunction);
46 context()->get_type_mgr()->RegisterType(resultId, *pointerTy);
Greg Fischer04fcc662016-11-10 10:11:50 -070047 return resultId;
48}
49
50void InlinePass::AddBranch(uint32_t label_id,
Diego Novillod2938e42017-11-08 12:40:02 -050051 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischer04fcc662016-11-10 10:11:50 -070052 std::unique_ptr<ir::Instruction> newBranch(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050053 context(), SpvOpBranch, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050054 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070055 (*block_ptr)->AddInstruction(std::move(newBranch));
56}
57
Greg Fischerbba812f2017-05-04 20:55:53 -060058void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id,
Diego Novillod2938e42017-11-08 12:40:02 -050059 uint32_t false_id,
60 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischerbba812f2017-05-04 20:55:53 -060061 std::unique_ptr<ir::Instruction> newBranch(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050062 context(), SpvOpBranchConditional, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050063 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}},
64 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}},
65 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}}));
Greg Fischerbba812f2017-05-04 20:55:53 -060066 (*block_ptr)->AddInstruction(std::move(newBranch));
67}
68
69void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id,
Diego Novillod2938e42017-11-08 12:40:02 -050070 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Greg Fischerbba812f2017-05-04 20:55:53 -060071 std::unique_ptr<ir::Instruction> newLoopMerge(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050072 context(), SpvOpLoopMerge, 0, 0,
Greg Fischerbba812f2017-05-04 20:55:53 -060073 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}},
74 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}},
75 {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}}));
76 (*block_ptr)->AddInstruction(std::move(newLoopMerge));
77}
78
Greg Fischer04fcc662016-11-10 10:11:50 -070079void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id,
80 std::unique_ptr<ir::BasicBlock>* block_ptr) {
81 std::unique_ptr<ir::Instruction> newStore(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050082 context(), SpvOpStore, 0, 0,
Diego Novillod2938e42017-11-08 12:40:02 -050083 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}},
84 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}}));
Greg Fischer04fcc662016-11-10 10:11:50 -070085 (*block_ptr)->AddInstruction(std::move(newStore));
86}
87
88void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id,
89 std::unique_ptr<ir::BasicBlock>* block_ptr) {
90 std::unique_ptr<ir::Instruction> newLoad(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -050091 context(), SpvOpLoad, type_id, resultId,
Greg Fischer04fcc662016-11-10 10:11:50 -070092 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}}));
93 (*block_ptr)->AddInstruction(std::move(newLoad));
94}
95
96std::unique_ptr<ir::Instruction> InlinePass::NewLabel(uint32_t label_id) {
97 std::unique_ptr<ir::Instruction> newLabel(
Alan Bakera7717132017-11-14 14:11:50 -050098 new ir::Instruction(context(), SpvOpLabel, 0, label_id, {}));
Greg Fischer04fcc662016-11-10 10:11:50 -070099 return newLabel;
100}
101
Greg Fischerbba812f2017-05-04 20:55:53 -0600102uint32_t InlinePass::GetFalseId() {
Diego Novillod2938e42017-11-08 12:40:02 -0500103 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400104 false_id_ = get_module()->GetGlobalValue(SpvOpConstantFalse);
Diego Novillod2938e42017-11-08 12:40:02 -0500105 if (false_id_ != 0) return false_id_;
Diego Novillo1040a952017-10-25 13:26:25 -0400106 uint32_t boolId = get_module()->GetGlobalValue(SpvOpTypeBool);
Greg Fischerbba812f2017-05-04 20:55:53 -0600107 if (boolId == 0) {
108 boolId = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400109 get_module()->AddGlobalValue(SpvOpTypeBool, boolId, 0);
Greg Fischerbba812f2017-05-04 20:55:53 -0600110 }
111 false_id_ = TakeNextId();
Diego Novillo1040a952017-10-25 13:26:25 -0400112 get_module()->AddGlobalValue(SpvOpConstantFalse, false_id_, boolId);
Greg Fischerbba812f2017-05-04 20:55:53 -0600113 return false_id_;
114}
115
Greg Fischer04fcc662016-11-10 10:11:50 -0700116void InlinePass::MapParams(
Diego Novillod2938e42017-11-08 12:40:02 -0500117 ir::Function* calleeFn, ir::BasicBlock::iterator call_inst_itr,
Greg Fischer04fcc662016-11-10 10:11:50 -0700118 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
119 int param_idx = 0;
120 calleeFn->ForEachParam(
121 [&call_inst_itr, &param_idx, &callee2caller](const ir::Instruction* cpi) {
122 const uint32_t pid = cpi->result_id();
123 (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand(
124 kSpvFunctionCallArgumentId + param_idx);
Greg Fischerbba812f2017-05-04 20:55:53 -0600125 ++param_idx;
Greg Fischer04fcc662016-11-10 10:11:50 -0700126 });
127}
128
129void InlinePass::CloneAndMapLocals(
130 ir::Function* calleeFn,
131 std::vector<std::unique_ptr<ir::Instruction>>* new_vars,
132 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
133 auto callee_block_itr = calleeFn->begin();
134 auto callee_var_itr = callee_block_itr->begin();
135 while (callee_var_itr->opcode() == SpvOp::SpvOpVariable) {
Alan Bakera7717132017-11-14 14:11:50 -0500136 std::unique_ptr<ir::Instruction> var_inst(
137 callee_var_itr->Clone(callee_var_itr->context()));
Greg Fischer04fcc662016-11-10 10:11:50 -0700138 uint32_t newId = TakeNextId();
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100139 get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId);
Greg Fischer04fcc662016-11-10 10:11:50 -0700140 var_inst->SetResultId(newId);
141 (*callee2caller)[callee_var_itr->result_id()] = newId;
142 new_vars->push_back(std::move(var_inst));
Greg Fischerbba812f2017-05-04 20:55:53 -0600143 ++callee_var_itr;
Greg Fischer04fcc662016-11-10 10:11:50 -0700144 }
145}
146
147uint32_t InlinePass::CreateReturnVar(
148 ir::Function* calleeFn,
149 std::vector<std::unique_ptr<ir::Instruction>>* new_vars) {
150 uint32_t returnVarId = 0;
151 const uint32_t calleeTypeId = calleeFn->type_id();
Steven Perron06b437d2018-02-09 20:33:06 -0500152 analysis::Type* calleeType = context()->get_type_mgr()->GetType(calleeTypeId);
153 if (calleeType->AsVoid() == nullptr) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700154 // Find or create ptr to callee return type.
Steven Perronb86eb682017-12-11 13:10:24 -0500155 uint32_t returnVarTypeId = context()->get_type_mgr()->FindPointerToType(
156 calleeTypeId, SpvStorageClassFunction);
Greg Fischer04fcc662016-11-10 10:11:50 -0700157 if (returnVarTypeId == 0)
158 returnVarTypeId = AddPointerToType(calleeTypeId, SpvStorageClassFunction);
159 // Add return var to new function scope variables.
160 returnVarId = TakeNextId();
161 std::unique_ptr<ir::Instruction> var_inst(new ir::Instruction(
Alan Bakera7717132017-11-14 14:11:50 -0500162 context(), SpvOpVariable, returnVarTypeId, returnVarId,
Greg Fischer04fcc662016-11-10 10:11:50 -0700163 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
164 {SpvStorageClassFunction}}}));
165 new_vars->push_back(std::move(var_inst));
166 }
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100167 get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId);
Greg Fischer04fcc662016-11-10 10:11:50 -0700168 return returnVarId;
169}
170
171bool InlinePass::IsSameBlockOp(const ir::Instruction* inst) const {
172 return inst->opcode() == SpvOpSampledImage || inst->opcode() == SpvOpImage;
173}
174
175void InlinePass::CloneSameBlockOps(
176 std::unique_ptr<ir::Instruction>* inst,
177 std::unordered_map<uint32_t, uint32_t>* postCallSB,
178 std::unordered_map<uint32_t, ir::Instruction*>* preCallSB,
179 std::unique_ptr<ir::BasicBlock>* block_ptr) {
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100180 (*inst)->ForEachInId(
181 [&postCallSB, &preCallSB, &block_ptr, this](uint32_t* iid) {
182 const auto mapItr = (*postCallSB).find(*iid);
183 if (mapItr == (*postCallSB).end()) {
184 const auto mapItr2 = (*preCallSB).find(*iid);
185 if (mapItr2 != (*preCallSB).end()) {
186 // Clone pre-call same-block ops, map result id.
187 const ir::Instruction* inInst = mapItr2->second;
188 std::unique_ptr<ir::Instruction> sb_inst(
189 inInst->Clone(inInst->context()));
190 CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr);
191 const uint32_t rid = sb_inst->result_id();
192 const uint32_t nid = this->TakeNextId();
193 get_decoration_mgr()->CloneDecorations(rid, nid);
194 sb_inst->SetResultId(nid);
195 (*postCallSB)[rid] = nid;
196 *iid = nid;
197 (*block_ptr)->AddInstruction(std::move(sb_inst));
198 }
199 } else {
200 // Reset same-block op operand.
201 *iid = mapItr->second;
202 }
203 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700204}
205
206void InlinePass::GenInlineCode(
207 std::vector<std::unique_ptr<ir::BasicBlock>>* new_blocks,
208 std::vector<std::unique_ptr<ir::Instruction>>* new_vars,
Steven Perronbb7802b2017-10-13 14:25:21 -0400209 ir::BasicBlock::iterator call_inst_itr,
Greg Fischer04fcc662016-11-10 10:11:50 -0700210 ir::UptrVectorIterator<ir::BasicBlock> call_block_itr) {
211 // Map from all ids in the callee to their equivalent id in the caller
212 // as callee instructions are copied into caller.
213 std::unordered_map<uint32_t, uint32_t> callee2caller;
214 // Pre-call same-block insts
215 std::unordered_map<uint32_t, ir::Instruction*> preCallSB;
216 // Post-call same-block op ids
217 std::unordered_map<uint32_t, uint32_t> postCallSB;
218
Steven Perronb3daa932018-03-06 11:20:28 -0500219 // Invalidate the def-use chains. They are not kept up to date while
220 // inlining. However, certain calls try to keep them up-to-date if they are
221 // valid. These operations can fail.
222 context()->InvalidateAnalyses(ir::IRContext::kAnalysisDefUse);
223
Greg Fischer04fcc662016-11-10 10:11:50 -0700224 ir::Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand(
225 kSpvFunctionCallFunctionId)];
226
David Neto2a1014b2017-08-09 14:59:04 -0400227 // Check for multiple returns in the callee.
228 auto fi = multi_return_funcs_.find(calleeFn->result_id());
229 const bool multiReturn = fi != multi_return_funcs_.end();
Greg Fischerbba812f2017-05-04 20:55:53 -0600230
Greg Fischer04fcc662016-11-10 10:11:50 -0700231 // Map parameters to actual arguments.
232 MapParams(calleeFn, call_inst_itr, &callee2caller);
233
234 // Define caller local variables for all callee variables and create map to
235 // them.
236 CloneAndMapLocals(calleeFn, new_vars, &callee2caller);
237
238 // Create return var if needed.
239 uint32_t returnVarId = CreateReturnVar(calleeFn, new_vars);
240
GregFa699d1a2017-08-29 18:35:05 -0600241 // Create set of callee result ids. Used to detect forward references
242 std::unordered_set<uint32_t> callee_result_ids;
Diego Novillod2938e42017-11-08 12:40:02 -0500243 calleeFn->ForEachInst([&callee_result_ids](const ir::Instruction* cpi) {
GregFa699d1a2017-08-29 18:35:05 -0600244 const uint32_t rid = cpi->result_id();
Diego Novillod2938e42017-11-08 12:40:02 -0500245 if (rid != 0) callee_result_ids.insert(rid);
GregFa699d1a2017-08-29 18:35:05 -0600246 });
247
David Netoefff5fa2017-08-31 15:47:31 -0400248 // If the caller is in a single-block loop, and the callee has multiple
249 // blocks, then the normal inlining logic will place the OpLoopMerge in
250 // the last of several blocks in the loop. Instead, it should be placed
251 // at the end of the first block. First determine if the caller is in a
252 // single block loop. We'll wait to move the OpLoopMerge until the end
253 // of the regular inlining logic, and only if necessary.
254 bool caller_is_single_block_loop = false;
David Neto25ddfec2017-09-02 19:01:03 -0400255 bool caller_is_loop_header = false;
David Netoefff5fa2017-08-31 15:47:31 -0400256 if (auto* loop_merge = call_block_itr->GetLoopMergeInst()) {
David Neto25ddfec2017-09-02 19:01:03 -0400257 caller_is_loop_header = true;
David Netoefff5fa2017-08-31 15:47:31 -0400258 caller_is_single_block_loop =
259 call_block_itr->id() ==
260 loop_merge->GetSingleWordInOperand(kSpvLoopMergeContinueTargetIdInIdx);
261 }
262
263 bool callee_begins_with_structured_header =
264 (*(calleeFn->begin())).GetMergeInst() != nullptr;
265
Greg Fischer04fcc662016-11-10 10:11:50 -0700266 // Clone and map callee code. Copy caller block code to beginning of
267 // first block and end of last block.
268 bool prevInstWasReturn = false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600269 uint32_t singleTripLoopHeaderId = 0;
270 uint32_t singleTripLoopContinueId = 0;
Greg Fischer04fcc662016-11-10 10:11:50 -0700271 uint32_t returnLabelId = 0;
272 bool multiBlocks = false;
273 const uint32_t calleeTypeId = calleeFn->type_id();
David Neto2a1014b2017-08-09 14:59:04 -0400274 // new_blk_ptr is a new basic block in the caller. New instructions are
275 // written to it. It is created when we encounter the OpLabel
David Netoefff5fa2017-08-31 15:47:31 -0400276 // of the first callee block. It is appended to new_blocks only when
277 // it is complete.
Greg Fischer04fcc662016-11-10 10:11:50 -0700278 std::unique_ptr<ir::BasicBlock> new_blk_ptr;
279 calleeFn->ForEachInst([&new_blocks, &callee2caller, &call_block_itr,
280 &call_inst_itr, &new_blk_ptr, &prevInstWasReturn,
David Neto25ddfec2017-09-02 19:01:03 -0400281 &returnLabelId, &returnVarId, caller_is_loop_header,
David Netoefff5fa2017-08-31 15:47:31 -0400282 callee_begins_with_structured_header, &calleeTypeId,
David Neto2a1014b2017-08-09 14:59:04 -0400283 &multiBlocks, &postCallSB, &preCallSB, multiReturn,
Greg Fischerbba812f2017-05-04 20:55:53 -0600284 &singleTripLoopHeaderId, &singleTripLoopContinueId,
David Netoefff5fa2017-08-31 15:47:31 -0400285 &callee_result_ids, this](const ir::Instruction* cpi) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700286 switch (cpi->opcode()) {
287 case SpvOpFunction:
288 case SpvOpFunctionParameter:
289 case SpvOpVariable:
290 // Already processed
291 break;
Alan Baker4246abd2018-04-26 12:22:08 -0400292 case SpvOpUnreachable:
293 case SpvOpKill: {
294 // Generate a return label so that we split the block with the function
295 // call. Copy the terminator into the new block.
296 if (returnLabelId == 0) returnLabelId = this->TakeNextId();
297 std::unique_ptr<ir::Instruction> terminator(
298 new ir::Instruction(context(), cpi->opcode(), 0, 0, {}));
299 new_blk_ptr->AddInstruction(std::move(terminator));
300 break;
301 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700302 case SpvOpLabel: {
303 // If previous instruction was early return, insert branch
304 // instruction to return block.
305 if (prevInstWasReturn) {
306 if (returnLabelId == 0) returnLabelId = this->TakeNextId();
307 AddBranch(returnLabelId, &new_blk_ptr);
308 prevInstWasReturn = false;
309 }
310 // Finish current block (if it exists) and get label for next block.
311 uint32_t labelId;
312 bool firstBlock = false;
313 if (new_blk_ptr != nullptr) {
314 new_blocks->push_back(std::move(new_blk_ptr));
315 // If result id is already mapped, use it, otherwise get a new
316 // one.
317 const uint32_t rid = cpi->result_id();
318 const auto mapItr = callee2caller.find(rid);
319 labelId = (mapItr != callee2caller.end()) ? mapItr->second
320 : this->TakeNextId();
321 } else {
322 // First block needs to use label of original block
323 // but map callee label in case of phi reference.
Greg Fischerbba812f2017-05-04 20:55:53 -0600324 labelId = call_block_itr->id();
Greg Fischer04fcc662016-11-10 10:11:50 -0700325 callee2caller[cpi->result_id()] = labelId;
326 firstBlock = true;
327 }
328 // Create first/next block.
329 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(labelId)));
330 if (firstBlock) {
331 // Copy contents of original caller block up to call instruction.
332 for (auto cii = call_block_itr->begin(); cii != call_inst_itr;
Steven Perron51ecc732018-02-20 11:24:08 -0500333 cii = call_block_itr->begin()) {
334 ir::Instruction* inst = &*cii;
335 inst->RemoveFromList();
336 std::unique_ptr<ir::Instruction> cp_inst(inst);
Greg Fischer04fcc662016-11-10 10:11:50 -0700337 // Remember same-block ops for possible regeneration.
338 if (IsSameBlockOp(&*cp_inst)) {
339 auto* sb_inst_ptr = cp_inst.get();
340 preCallSB[cp_inst->result_id()] = sb_inst_ptr;
341 }
342 new_blk_ptr->AddInstruction(std::move(cp_inst));
343 }
Diego Novillod2938e42017-11-08 12:40:02 -0500344 if (caller_is_loop_header && callee_begins_with_structured_header) {
David Netoefff5fa2017-08-31 15:47:31 -0400345 // We can't place both the caller's merge instruction and another
346 // merge instruction in the same block. So split the calling block.
347 // Insert an unconditional branch to a new guard block. Later,
348 // once we know the ID of the last block, we will move the caller's
349 // OpLoopMerge from the last generated block into the first block.
350 // We also wait to avoid invalidating various iterators.
351 const auto guard_block_id = this->TakeNextId();
352 AddBranch(guard_block_id, &new_blk_ptr);
353 new_blocks->push_back(std::move(new_blk_ptr));
354 // Start the next block.
355 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(guard_block_id)));
356 // Reset the mapping of the callee's entry block to point to
357 // the guard block. Do this so we can fix up phis later on to
358 // satisfy dominance.
359 callee2caller[cpi->result_id()] = guard_block_id;
360 }
361 // If callee has multiple returns, insert a header block for
David Neto2a1014b2017-08-09 14:59:04 -0400362 // single-trip loop that will encompass callee code. Start postheader
Greg Fischerbba812f2017-05-04 20:55:53 -0600363 // block.
David Netoefff5fa2017-08-31 15:47:31 -0400364 //
365 // Note: Consider the following combination:
366 // - the caller is a single block loop
367 // - the callee does not begin with a structure header
368 // - the callee has multiple returns.
369 // We still need to split the caller block and insert a guard block.
370 // But we only need to do it once. We haven't done it yet, but the
371 // single-trip loop header will serve the same purpose.
David Neto2a1014b2017-08-09 14:59:04 -0400372 if (multiReturn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600373 singleTripLoopHeaderId = this->TakeNextId();
374 AddBranch(singleTripLoopHeaderId, &new_blk_ptr);
375 new_blocks->push_back(std::move(new_blk_ptr));
Diego Novillod2938e42017-11-08 12:40:02 -0500376 new_blk_ptr.reset(
377 new ir::BasicBlock(NewLabel(singleTripLoopHeaderId)));
Greg Fischerbba812f2017-05-04 20:55:53 -0600378 returnLabelId = this->TakeNextId();
379 singleTripLoopContinueId = this->TakeNextId();
380 AddLoopMerge(returnLabelId, singleTripLoopContinueId, &new_blk_ptr);
381 uint32_t postHeaderId = this->TakeNextId();
382 AddBranch(postHeaderId, &new_blk_ptr);
383 new_blocks->push_back(std::move(new_blk_ptr));
384 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(postHeaderId)));
385 multiBlocks = true;
David Neto860c4192017-08-31 17:33:44 -0400386 // Reset the mapping of the callee's entry block to point to
387 // the post-header block. Do this so we can fix up phis later
388 // on to satisfy dominance.
389 callee2caller[cpi->result_id()] = postHeaderId;
Greg Fischerbba812f2017-05-04 20:55:53 -0600390 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700391 } else {
392 multiBlocks = true;
393 }
394 } break;
395 case SpvOpReturnValue: {
396 // Store return value to return variable.
397 assert(returnVarId != 0);
398 uint32_t valId = cpi->GetInOperand(kSpvReturnValueId).words[0];
399 const auto mapItr = callee2caller.find(valId);
400 if (mapItr != callee2caller.end()) {
401 valId = mapItr->second;
402 }
403 AddStore(returnVarId, valId, &new_blk_ptr);
404
405 // Remember we saw a return; if followed by a label, will need to
406 // insert branch.
407 prevInstWasReturn = true;
408 } break;
409 case SpvOpReturn: {
410 // Remember we saw a return; if followed by a label, will need to
411 // insert branch.
412 prevInstWasReturn = true;
413 } break;
414 case SpvOpFunctionEnd: {
David Neto2a1014b2017-08-09 14:59:04 -0400415 // If there was an early return, we generated a return label id
416 // for it. Now we have to generate the return block with that Id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700417 if (returnLabelId != 0) {
David Neto2a1014b2017-08-09 14:59:04 -0400418 // If previous instruction was return, insert branch instruction
419 // to return block.
Greg Fischer04fcc662016-11-10 10:11:50 -0700420 if (prevInstWasReturn) AddBranch(returnLabelId, &new_blk_ptr);
David Neto2a1014b2017-08-09 14:59:04 -0400421 if (multiReturn) {
422 // If we generated a loop header to for the single-trip loop
423 // to accommodate multiple returns, insert the continue
424 // target block now, with a false branch back to the loop header.
425 new_blocks->push_back(std::move(new_blk_ptr));
426 new_blk_ptr.reset(
427 new ir::BasicBlock(NewLabel(singleTripLoopContinueId)));
428 AddBranchCond(GetFalseId(), singleTripLoopHeaderId, returnLabelId,
429 &new_blk_ptr);
430 }
431 // Generate the return block.
Greg Fischerbba812f2017-05-04 20:55:53 -0600432 new_blocks->push_back(std::move(new_blk_ptr));
Greg Fischer04fcc662016-11-10 10:11:50 -0700433 new_blk_ptr.reset(new ir::BasicBlock(NewLabel(returnLabelId)));
434 multiBlocks = true;
435 }
436 // Load return value into result id of call, if it exists.
437 if (returnVarId != 0) {
438 const uint32_t resId = call_inst_itr->result_id();
439 assert(resId != 0);
440 AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr);
441 }
442 // Copy remaining instructions from caller block.
Steven Perron51ecc732018-02-20 11:24:08 -0500443 for (ir::Instruction* inst = call_inst_itr->NextNode(); inst;
444 inst = call_inst_itr->NextNode()) {
445 inst->RemoveFromList();
446 std::unique_ptr<ir::Instruction> cp_inst(inst);
Greg Fischer04fcc662016-11-10 10:11:50 -0700447 // If multiple blocks generated, regenerate any same-block
448 // instruction that has not been seen in this last block.
449 if (multiBlocks) {
450 CloneSameBlockOps(&cp_inst, &postCallSB, &preCallSB, &new_blk_ptr);
451 // Remember same-block ops in this block.
452 if (IsSameBlockOp(&*cp_inst)) {
453 const uint32_t rid = cp_inst->result_id();
454 postCallSB[rid] = rid;
455 }
456 }
457 new_blk_ptr->AddInstruction(std::move(cp_inst));
458 }
459 // Finalize inline code.
460 new_blocks->push_back(std::move(new_blk_ptr));
461 } break;
462 default: {
463 // Copy callee instruction and remap all input Ids.
Alan Bakera7717132017-11-14 14:11:50 -0500464 std::unique_ptr<ir::Instruction> cp_inst(cpi->Clone(context()));
David Netoefff5fa2017-08-31 15:47:31 -0400465 cp_inst->ForEachInId([&callee2caller, &callee_result_ids,
466 this](uint32_t* iid) {
Greg Fischer04fcc662016-11-10 10:11:50 -0700467 const auto mapItr = callee2caller.find(*iid);
468 if (mapItr != callee2caller.end()) {
469 *iid = mapItr->second;
GregFa699d1a2017-08-29 18:35:05 -0600470 } else if (callee_result_ids.find(*iid) != callee_result_ids.end()) {
471 // Forward reference. Allocate a new id, map it,
472 // use it and check for it when remapping result ids
473 const uint32_t nid = this->TakeNextId();
474 callee2caller[*iid] = nid;
475 *iid = nid;
Greg Fischer04fcc662016-11-10 10:11:50 -0700476 }
477 });
GregFa699d1a2017-08-29 18:35:05 -0600478 // If result id is non-zero, remap it. If already mapped, use mapped
479 // value, else use next id.
Greg Fischer04fcc662016-11-10 10:11:50 -0700480 const uint32_t rid = cp_inst->result_id();
481 if (rid != 0) {
GregFa699d1a2017-08-29 18:35:05 -0600482 const auto mapItr = callee2caller.find(rid);
483 uint32_t nid;
484 if (mapItr != callee2caller.end()) {
485 nid = mapItr->second;
Diego Novillod2938e42017-11-08 12:40:02 -0500486 } else {
GregFa699d1a2017-08-29 18:35:05 -0600487 nid = this->TakeNextId();
488 callee2caller[rid] = nid;
489 }
Greg Fischer04fcc662016-11-10 10:11:50 -0700490 cp_inst->SetResultId(nid);
Pierre Moreau5bd55f12018-02-20 19:19:57 +0100491 get_decoration_mgr()->CloneDecorations(rid, nid);
Greg Fischer04fcc662016-11-10 10:11:50 -0700492 }
493 new_blk_ptr->AddInstruction(std::move(cp_inst));
494 } break;
495 }
496 });
David Netoefff5fa2017-08-31 15:47:31 -0400497
David Neto25ddfec2017-09-02 19:01:03 -0400498 if (caller_is_loop_header && (new_blocks->size() > 1)) {
David Netoefff5fa2017-08-31 15:47:31 -0400499 // Move the OpLoopMerge from the last block back to the first, where
David Neto25ddfec2017-09-02 19:01:03 -0400500 // it belongs.
David Netoefff5fa2017-08-31 15:47:31 -0400501 auto& first = new_blocks->front();
502 auto& last = new_blocks->back();
503 assert(first != last);
504
505 // Insert a modified copy of the loop merge into the first block.
506 auto loop_merge_itr = last->tail();
507 --loop_merge_itr;
508 assert(loop_merge_itr->opcode() == SpvOpLoopMerge);
Alan Bakera7717132017-11-14 14:11:50 -0500509 std::unique_ptr<ir::Instruction> cp_inst(loop_merge_itr->Clone(context()));
David Neto25ddfec2017-09-02 19:01:03 -0400510 if (caller_is_single_block_loop) {
511 // Also, update its continue target to point to the last block.
512 cp_inst->SetInOperand(kSpvLoopMergeContinueTargetIdInIdx, {last->id()});
513 }
David Netoefff5fa2017-08-31 15:47:31 -0400514 first->tail().InsertBefore(std::move(cp_inst));
515
516 // Remove the loop merge from the last block.
Steven Perronbb7802b2017-10-13 14:25:21 -0400517 loop_merge_itr->RemoveFromList();
518 delete &*loop_merge_itr;
David Netoefff5fa2017-08-31 15:47:31 -0400519 }
520
Greg Fischer04fcc662016-11-10 10:11:50 -0700521 // Update block map given replacement blocks.
522 for (auto& blk : *new_blocks) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600523 id2block_[blk->id()] = &*blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700524 }
525}
526
David Netoceb1d4f2017-03-31 10:36:58 -0400527bool InlinePass::IsInlinableFunctionCall(const ir::Instruction* inst) {
528 if (inst->opcode() != SpvOp::SpvOpFunctionCall) return false;
GregFa107d342017-04-25 13:57:20 -0600529 const uint32_t calleeFnId =
530 inst->GetSingleWordOperand(kSpvFunctionCallFunctionId);
531 const auto ci = inlinable_.find(calleeFnId);
532 return ci != inlinable_.cend();
David Netoceb1d4f2017-03-31 10:36:58 -0400533}
534
GregFe28bd392017-08-01 17:20:13 -0600535void InlinePass::UpdateSucceedingPhis(
536 std::vector<std::unique_ptr<ir::BasicBlock>>& new_blocks) {
537 const auto firstBlk = new_blocks.begin();
538 const auto lastBlk = new_blocks.end() - 1;
539 const uint32_t firstId = (*firstBlk)->id();
540 const uint32_t lastId = (*lastBlk)->id();
David Neto87f9cfa2018-02-02 14:17:42 -0800541 const ir::BasicBlock& const_last_block = *lastBlk->get();
542 const_last_block.ForEachSuccessorLabel(
543 [&firstId, &lastId, this](const uint32_t succ) {
544 ir::BasicBlock* sbp = this->id2block_[succ];
545 sbp->ForEachPhiInst([&firstId, &lastId](ir::Instruction* phi) {
546 phi->ForEachInId([&firstId, &lastId](uint32_t* id) {
547 if (*id == firstId) *id = lastId;
548 });
549 });
GregFe28bd392017-08-01 17:20:13 -0600550 });
Greg Fischer04fcc662016-11-10 10:11:50 -0700551}
552
Greg Fischerbba812f2017-05-04 20:55:53 -0600553bool InlinePass::HasMultipleReturns(ir::Function* func) {
554 bool seenReturn = false;
555 bool multipleReturns = false;
556 for (auto& blk : *func) {
557 auto terminal_ii = blk.cend();
558 --terminal_ii;
Diego Novillod2938e42017-11-08 12:40:02 -0500559 if (terminal_ii->opcode() == SpvOpReturn ||
Greg Fischerbba812f2017-05-04 20:55:53 -0600560 terminal_ii->opcode() == SpvOpReturnValue) {
561 if (seenReturn) {
562 multipleReturns = true;
563 break;
564 }
565 seenReturn = true;
566 }
567 }
568 return multipleReturns;
569}
570
Greg Fischerbba812f2017-05-04 20:55:53 -0600571void InlinePass::ComputeStructuredSuccessors(ir::Function* func) {
572 // If header, make merge block first successor.
573 for (auto& blk : *func) {
Diego Novillofef669f2017-10-30 17:42:26 -0400574 uint32_t mbid = blk.MergeBlockIdIfAny();
575 if (mbid != 0) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600576 block2structured_succs_[&blk].push_back(id2block_[mbid]);
Diego Novillofef669f2017-10-30 17:42:26 -0400577 }
578
579 // Add true successors.
David Neto87f9cfa2018-02-02 14:17:42 -0800580 const auto& const_blk = blk;
581 const_blk.ForEachSuccessorLabel([&blk, this](const uint32_t sbid) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600582 block2structured_succs_[&blk].push_back(id2block_[sbid]);
583 });
584 }
585}
Diego Novillofef669f2017-10-30 17:42:26 -0400586
Greg Fischerbba812f2017-05-04 20:55:53 -0600587InlinePass::GetBlocksFunction InlinePass::StructuredSuccessorsFunction() {
588 return [this](const ir::BasicBlock* block) {
589 return &(block2structured_succs_[block]);
590 };
591}
592
593bool InlinePass::HasNoReturnInLoop(ir::Function* func) {
594 // If control not structured, do not do loop/return analysis
595 // TODO: Analyze returns in non-structured control flow
Steven Perron756b2772017-12-19 14:18:13 -0500596 if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader))
597 return false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600598 // Compute structured block order. This order has the property
599 // that dominators are before all blocks they dominate and merge blocks
600 // are after all blocks that are in the control constructs of their header.
601 ComputeStructuredSuccessors(func);
602 auto ignore_block = [](cbb_ptr) {};
603 auto ignore_edge = [](cbb_ptr, cbb_ptr) {};
604 std::list<const ir::BasicBlock*> structuredOrder;
605 spvtools::CFA<ir::BasicBlock>::DepthFirstTraversal(
Diego Novillod2938e42017-11-08 12:40:02 -0500606 &*func->begin(), StructuredSuccessorsFunction(), ignore_block,
607 [&](cbb_ptr b) { structuredOrder.push_front(b); }, ignore_edge);
Greg Fischerbba812f2017-05-04 20:55:53 -0600608 // Search for returns in loops. Only need to track outermost loop
609 bool return_in_loop = false;
610 uint32_t outerLoopMergeId = 0;
611 for (auto& blk : structuredOrder) {
612 // Exiting current outer loop
Diego Novillod2938e42017-11-08 12:40:02 -0500613 if (blk->id() == outerLoopMergeId) outerLoopMergeId = 0;
Greg Fischerbba812f2017-05-04 20:55:53 -0600614 // Return block
615 auto terminal_ii = blk->cend();
616 --terminal_ii;
Diego Novillod2938e42017-11-08 12:40:02 -0500617 if (terminal_ii->opcode() == SpvOpReturn ||
Greg Fischerbba812f2017-05-04 20:55:53 -0600618 terminal_ii->opcode() == SpvOpReturnValue) {
619 if (outerLoopMergeId != 0) {
620 return_in_loop = true;
621 break;
622 }
Diego Novillod2938e42017-11-08 12:40:02 -0500623 } else if (terminal_ii != blk->cbegin()) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600624 auto merge_ii = terminal_ii;
625 --merge_ii;
626 // Entering outermost loop
627 if (merge_ii->opcode() == SpvOpLoopMerge && outerLoopMergeId == 0)
Diego Novillod2938e42017-11-08 12:40:02 -0500628 outerLoopMergeId =
629 merge_ii->GetSingleWordOperand(kSpvLoopMergeMergeBlockId);
Greg Fischerbba812f2017-05-04 20:55:53 -0600630 }
631 }
632 return !return_in_loop;
633}
634
635void InlinePass::AnalyzeReturns(ir::Function* func) {
636 // Look for multiple returns
637 if (!HasMultipleReturns(func)) {
638 no_return_in_loop_.insert(func->result_id());
639 return;
640 }
David Neto2a1014b2017-08-09 14:59:04 -0400641 multi_return_funcs_.insert(func->result_id());
Greg Fischerbba812f2017-05-04 20:55:53 -0600642 // If multiple returns, see if any are in a loop
Diego Novillod2938e42017-11-08 12:40:02 -0500643 if (HasNoReturnInLoop(func)) no_return_in_loop_.insert(func->result_id());
Greg Fischerbba812f2017-05-04 20:55:53 -0600644}
645
646bool InlinePass::IsInlinableFunction(ir::Function* func) {
GregFa107d342017-04-25 13:57:20 -0600647 // We can only inline a function if it has blocks.
Diego Novillod2938e42017-11-08 12:40:02 -0500648 if (func->cbegin() == func->cend()) return false;
Greg Fischerbba812f2017-05-04 20:55:53 -0600649 // Do not inline functions with returns in loops. Currently early return
650 // functions are inlined by wrapping them in a one trip loop and implementing
651 // the returns as a branch to the loop's merge block. However, this can only
652 // done validly if the return was not in a loop in the original function.
653 // Also remember functions with multiple (early) returns.
654 AnalyzeReturns(func);
David Netoefff5fa2017-08-31 15:47:31 -0400655 return no_return_in_loop_.find(func->result_id()) !=
656 no_return_in_loop_.cend();
GregFa107d342017-04-25 13:57:20 -0600657}
658
Steven Perron476cae62017-10-30 11:13:24 -0400659void InlinePass::InitializeInline(ir::IRContext* c) {
660 InitializeProcessing(c);
Greg Fischer04fcc662016-11-10 10:11:50 -0700661
Greg Fischerbba812f2017-05-04 20:55:53 -0600662 false_id_ = 0;
663
GregFe28bd392017-08-01 17:20:13 -0600664 // clear collections
Greg Fischer04fcc662016-11-10 10:11:50 -0700665 id2function_.clear();
666 id2block_.clear();
Greg Fischerbba812f2017-05-04 20:55:53 -0600667 block2structured_succs_.clear();
GregFa107d342017-04-25 13:57:20 -0600668 inlinable_.clear();
GregFe28bd392017-08-01 17:20:13 -0600669 no_return_in_loop_.clear();
David Neto2a1014b2017-08-09 14:59:04 -0400670 multi_return_funcs_.clear();
GregFe28bd392017-08-01 17:20:13 -0600671
Diego Novillo1040a952017-10-25 13:26:25 -0400672 for (auto& fn : *get_module()) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600673 // Initialize function and block maps.
Greg Fischer04fcc662016-11-10 10:11:50 -0700674 id2function_[fn.result_id()] = &fn;
675 for (auto& blk : fn) {
Greg Fischerbba812f2017-05-04 20:55:53 -0600676 id2block_[blk.id()] = &blk;
Greg Fischer04fcc662016-11-10 10:11:50 -0700677 }
Greg Fischerbba812f2017-05-04 20:55:53 -0600678 // Compute inlinability
Diego Novillod2938e42017-11-08 12:40:02 -0500679 if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id());
Greg Fischer04fcc662016-11-10 10:11:50 -0700680 }
Eleni Maria Stea045cc8f2018-03-21 11:15:56 +0200681}
Greg Fischer04fcc662016-11-10 10:11:50 -0700682
Diego Novillo1040a952017-10-25 13:26:25 -0400683InlinePass::InlinePass() {}
Greg Fischer04fcc662016-11-10 10:11:50 -0700684
Greg Fischer04fcc662016-11-10 10:11:50 -0700685} // namespace opt
686} // namespace spvtools