blob: cea4e2819cb5ab3bb9be9431daf98fd1d5ff33eb [file] [log] [blame]
Kuang-che Wu6e4beca2018-06-27 17:45:02 +08001# -*- coding: utf-8 -*-
Kuang-che Wu88875db2017-07-20 10:47:53 +08002# Copyright 2017 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5"""Bisect command line interface."""
6
7from __future__ import print_function
8import argparse
9import datetime
Kuang-che Wu8b654092018-11-09 17:56:25 +080010import json
Kuang-che Wu88875db2017-07-20 10:47:53 +080011import logging
12import os
13import re
Kuang-che Wu443633f2019-02-27 00:58:33 +080014import signal
Kuang-che Wu88875db2017-07-20 10:47:53 +080015import textwrap
16import time
17
18from bisect_kit import common
Kuang-che Wu385279d2017-09-27 14:48:28 +080019from bisect_kit import configure
Kuang-che Wu88875db2017-07-20 10:47:53 +080020from bisect_kit import core
Kuang-che Wue121fae2018-11-09 16:18:39 +080021from bisect_kit import errors
Kuang-che Wu88875db2017-07-20 10:47:53 +080022from bisect_kit import strategy
23from bisect_kit import util
24
25logger = logging.getLogger(__name__)
26
Kuang-che Wu88875db2017-07-20 10:47:53 +080027DEFAULT_SESSION_NAME = 'default'
28DEFAULT_CONFIDENCE = 0.999
29
Kuang-che Wu0476d1f2019-03-04 19:27:01 +080030# Exit code of bisect eval script. These values are chosen compatible with 'git
31# bisect'.
32EXIT_CODE_OLD = 0
33EXIT_CODE_NEW = 1
34EXIT_CODE_SKIP = 125
35EXIT_CODE_FATAL = 128
36
Kuang-che Wu88875db2017-07-20 10:47:53 +080037
38class ArgTypeError(argparse.ArgumentTypeError):
39 """An error for argument validation failure.
40
41 This not only tells users the argument is wrong but also gives correct
42 example. The main purpose of this error is for argtype_multiplexer, which
43 cascades examples from multiple ArgTypeError.
44 """
45
46 def __init__(self, msg, example):
47 self.msg = msg
48 if isinstance(example, list):
49 self.example = example
50 else:
51 self.example = [example]
52 full_msg = '%s (example value: %s)' % (self.msg, ', '.join(self.example))
53 super(ArgTypeError, self).__init__(full_msg)
54
55
56def argtype_notempty(s):
57 """Validates argument is not an empty string.
58
59 Args:
60 s: string to validate.
61
62 Raises:
63 ArgTypeError if argument is empty string.
64 """
65 if not s:
66 msg = 'should not be empty'
67 raise ArgTypeError(msg, 'foo')
68 return s
69
70
71def argtype_int(s):
72 """Validate argument is a number.
73
74 Args:
75 s: string to validate.
76
77 Raises:
78 ArgTypeError if argument is not a number.
79 """
80 try:
81 return str(int(s))
82 except ValueError:
83 raise ArgTypeError('should be a number', '123')
84
85
Kuang-che Wu603cdad2019-01-18 21:32:55 +080086def argtype_re(pattern, example):
87 r"""Validate argument matches `pattern`.
88
89 Args:
90 pattern: regex pattern
91 example: example string which matches `pattern`
92
93 Returns:
94 A new argtype function which matches regex `pattern`
95 """
96 assert re.match(pattern, example)
97
98 def validate(s):
99 if re.match(pattern, s):
100 return s
101 if re.escape(pattern) == pattern:
102 raise ArgTypeError('should be "%s"' % pattern, pattern)
103 raise ArgTypeError('should match "%s"' % pattern,
104 '"%s" like %s' % (pattern, example))
105
106 return validate
107
108
Kuang-che Wu88875db2017-07-20 10:47:53 +0800109def argtype_multiplexer(*args):
110 r"""argtype multiplexer
111
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800112 This function takes a list of argtypes and creates a new function matching
113 them. Moreover, it gives error message with examples.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800114
Kuang-che Wubaaa4532018-08-15 17:08:10 +0800115 Examples:
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800116 >>> argtype = argtype_multiplexer(argtype_int,
117 argtype_re(r'^r\d+$', 'r123'))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800118 >>> argtype('123')
119 123
120 >>> argtype('r456')
121 r456
122 >>> argtype('hello')
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800123 ArgTypeError: Invalid argument (example value: 123, "r\d+$" like r123)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800124
125 Args:
126 *args: list of argtypes or regex pattern.
127
128 Returns:
129 A new argtype function which matches *args.
130 """
131
132 def validate(s):
133 examples = []
134 for t in args:
Kuang-che Wu88875db2017-07-20 10:47:53 +0800135 try:
136 return t(s)
137 except ArgTypeError as e:
138 examples += e.example
139
140 msg = 'Invalid argument'
141 raise ArgTypeError(msg, examples)
142
143 return validate
144
145
146def argtype_multiplier(argtype):
147 """A new argtype that supports multiplier suffix of the given argtype.
148
Kuang-che Wubaaa4532018-08-15 17:08:10 +0800149 Examples:
Kuang-che Wu88875db2017-07-20 10:47:53 +0800150 Supports the given argtype accepting "foo" as argument, this function
151 generates a new argtype function which accepts argument like "foo*3".
152
153 Returns:
154 A new argtype function which returns (arg, times) where arg is accepted
155 by input `argtype` and times is repeating count. Note that if multiplier is
156 omitted, "times" is 1.
157 """
158
159 def helper(s):
160 m = re.match(r'^(.+)\*(\d+)$', s)
161 try:
162 if m:
163 return argtype(m.group(1)), int(m.group(2))
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800164 return argtype(s), 1
Kuang-che Wu88875db2017-07-20 10:47:53 +0800165 except ArgTypeError as e:
166 # It should be okay to gives multiplier example only for the first one
167 # because it is just "example", no need to enumerate all possibilities.
168 raise ArgTypeError(e.msg, e.example + [e.example[0] + '*3'])
169
170 return helper
171
172
173def argtype_dir_path(s):
174 """Validate argument is an existing directory.
175
176 Args:
177 s: string to validate.
178
179 Raises:
180 ArgTypeError if the path is not a directory.
181 """
182 if not os.path.exists(s):
183 raise ArgTypeError('should be an existing directory', '/path/to/somewhere')
184 if not os.path.isdir(s):
185 raise ArgTypeError('should be a directory', '/path/to/somewhere')
186
187 # Normalize, trim trailing path separators.
188 if len(s) > 1 and s[-1] == os.path.sep:
189 s = s[:-1]
190 return s
191
192
193def _collect_bisect_result_values(values, line):
194 """Collect bisect result values from output line.
195
196 Args:
197 values: Collected values are appending to this list.
198 line: One line of output string.
199 """
200 m = re.match(r'^BISECT_RESULT_VALUES=(.+)', line)
201 if m:
202 try:
203 values.extend(map(float, m.group(1).split()))
204 except ValueError:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800205 raise errors.InternalError(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800206 'BISECT_RESULT_VALUES should be list of floats: %r' % m.group(1))
207
208
Kuang-che Wu88518882017-09-22 16:57:25 +0800209def check_executable(program):
210 """Checks whether a program is executable.
211
212 Args:
213 program: program path in question
214
215 Returns:
216 string as error message if `program` is not executable, or None otherwise.
217 It will return None if unable to determine as well.
218 """
219 returncode = util.call('which', program)
220 if returncode == 127: # No 'which' on this platform, skip the check.
221 return None
222 if returncode == 0: # is executable
223 return None
224
225 hint = ''
226 if not os.path.exists(program):
227 hint = 'Not in PATH?'
228 elif not os.path.isfile(program):
229 hint = 'Not a file'
230 elif not os.access(program, os.X_OK):
231 hint = 'Forgot to chmod +x?'
232 elif '/' not in program:
233 hint = 'Forgot to prepend "./" ?'
234 return '%r is not executable. %s' % (program, hint)
235
236
Kuang-che Wu443633f2019-02-27 00:58:33 +0800237def format_returncode(returncode):
238 if returncode < 0:
239 signum = -returncode
240 signame = 'Unknown'
241 for k, v in vars(signal).items():
242 if k.startswith('SIG') and '_' not in k and v == signum:
243 signame = k
244 return 'terminated by signal %d (%s)' % (signum, signame)
245
246 return 'exited with code %d' % returncode
247
248
Kuang-che Wu88875db2017-07-20 10:47:53 +0800249def do_evaluate(evaluate_cmd, domain, rev):
250 """Invokes evaluator command.
251
252 The `evaluate_cmd` can get the target revision from the environment variable
253 named 'BISECT_REV'.
254
255 The result is determined according to the exit code of evaluator:
256 0: 'old'
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800257 1..124, 126, 127: 'new'
Kuang-che Wu88875db2017-07-20 10:47:53 +0800258 125: 'skip'
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800259 128..255: fatal error
Kuang-che Wu88875db2017-07-20 10:47:53 +0800260 terminated by signal: fatal error
261
262 p.s. the definition of result is compatible with git-bisect(1).
263
264 It also extracts additional values from evaluate_cmd's stdout lines which
265 match the following format:
266 BISECT_RESULT_VALUES=<float>[, <float>]*
267
268 Args:
269 evaluate_cmd: evaluator command.
270 domain: a bisect_kit.core.Domain instance.
271 rev: version to evaluate.
272
273 Returns:
274 (result, values):
275 result is one of 'old', 'new', 'skip'.
276 values are additional collected values, like performance score.
277
278 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800279 errors.ExecutionFatalError if evaluator returned fatal error code.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800280 """
281 env = os.environ.copy()
282 env['BISECT_REV'] = rev
283 domain.setenv(env, rev)
284
285 values = []
286 p = util.Popen(
287 evaluate_cmd,
288 env=env,
289 stdout_callback=lambda line: _collect_bisect_result_values(values, line))
290 returncode = p.wait()
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800291 if returncode < 0 or returncode >= 128:
Kuang-che Wu443633f2019-02-27 00:58:33 +0800292 raise errors.ExecutionFatalError(
293 'eval failed: %s' % format_returncode(returncode))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800294
295 if returncode == 0:
296 return 'old', values
297 if returncode == 125:
298 return 'skip', values
299 return 'new', values
300
301
302def do_switch(switch_cmd, domain, rev):
303 """Invokes switcher command.
304
305 The `switch_cmd` can get the target revision from the environment variable
306 named 'BISECT_REV'.
307
308 The result is determined according to the exit code of switcher:
309 0: switch succeeded
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800310 1..127: 'skip'
311 128..255: fatal error
Kuang-che Wu88875db2017-07-20 10:47:53 +0800312 terminated by signal: fatal error
313
314 In other words, any non-fatal errors are considered as 'skip'.
315
316 Args:
317 switch_cmd: switcher command.
318 domain: a bisect_kit.core.Domain instance.
319 rev: version to switch.
320
321 Returns:
322 None if switch successfully, 'skip' otherwise.
323
324 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800325 errors.ExecutionFatalError if switcher returned fatal error code.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800326 """
327 env = os.environ.copy()
328 env['BISECT_REV'] = rev
329 domain.setenv(env, rev)
330
331 returncode = util.call(*switch_cmd, env=env)
Kuang-che Wu0476d1f2019-03-04 19:27:01 +0800332 if returncode < 0 or returncode >= 128:
Kuang-che Wu443633f2019-02-27 00:58:33 +0800333 raise errors.ExecutionFatalError(
334 'switch failed: %s' % format_returncode(returncode))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800335
336 if returncode != 0:
337 return 'skip'
338 return None
339
340
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800341class BisectorCommandLine(object):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800342 """Bisector command line interface.
343
344 The typical usage pattern:
345
346 if __name__ == '__main__':
Kuang-che Wu68db08a2018-03-30 11:50:34 +0800347 BisectorCommandLine(CustomDomain).main()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800348
349 where CustomDomain is a derived class of core.BisectDomain. See
Kuang-che Wu02170592018-07-09 21:42:44 +0800350 bisect_list.py as example.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800351
352 If you need to control the bisector using python code, the easier way is
353 passing command line arguments to main() function. For example,
354 bisector = Bisector(CustomDomain)
355 bisector.main('init', '--old', '123', '--new', '456')
356 bisector.main('config', 'switch', 'true')
357 bisector.main('config', 'eval', 'true')
358 bisector.main('run')
359 """
360
361 def __init__(self, domain_cls):
362 self.domain_cls = domain_cls
363 self.domain = None
364 self.states = None
365 self.strategy = None
366
367 @property
368 def config(self):
369 return self.states.config
370
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800371 def _format_status(self, status):
372 if status in ('old', 'new'):
Kuang-che Wub6756d42019-01-25 12:19:55 +0800373 return '%s behavior' % status
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800374 return status
375
Kuang-che Wu8b654092018-11-09 17:56:25 +0800376 def _add_sample(self, rev, status, **kwargs):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800377 idx = self.states.rev2idx(rev)
Kuang-che Wu8b654092018-11-09 17:56:25 +0800378 self.states.add_sample(idx, status, **kwargs)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800379 self.strategy.update(idx, status)
380
381 def cmd_reset(self, _opts):
382 """Resets bisect session and clean up saved result."""
383 self.states.reset()
384
385 def cmd_init(self, opts):
386 """Initializes bisect session.
387
388 See init command's help message for more detail.
389 """
390 config, revlist = self.domain_cls.init(opts)
Kuang-che Wu42551dd2018-01-16 17:27:20 +0800391 logger.info('found %d revs to bisect', len(revlist))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800392 logger.debug('revlist %r', revlist)
393 if 'new' not in config:
394 config['new'] = opts.new
395 if 'old' not in config:
396 config['old'] = opts.old
397 assert len(revlist) >= 2
398 assert config['new'] in revlist
399 assert config['old'] in revlist
400 old_idx = revlist.index(config['old'])
401 new_idx = revlist.index(config['new'])
402 assert old_idx < new_idx
403
404 config.update(confidence=opts.confidence, noisy=opts.noisy)
405
406 self.states.init(config, revlist)
407 self.states.save()
408
409 def _switch_and_eval(self, rev, prev_rev=None):
410 """Switches and evaluates given version.
411
412 If current version equals to target, switch step will be skip.
413
414 Args:
415 rev: Target version.
416 prev_rev: Previous version.
417
418 Returns:
419 (step, status, values):
420 step: Last step executed ('switch' or 'eval').
421 status: Execution result ('old', 'new', or 'skip').
422 values: Collected values from eval step. None if last step is 'switch'.
423 """
Kuang-che Wu88875db2017-07-20 10:47:53 +0800424 if prev_rev != rev:
425 logger.debug('switch to rev=%s', rev)
426 t0 = time.time()
427 status = do_switch(self.config['switch'], self.domain, rev)
428 t1 = time.time()
429 if status == 'skip':
430 logger.debug('switch failed => skip')
431 return 'switch', status, None
432 self.states.data['stats']['switch_count'] += 1
433 self.states.data['stats']['switch_time'] += t1 - t0
434
435 logger.debug('eval rev=%s', rev)
436 t0 = time.time()
437 status, values = do_evaluate(self.config['eval'], self.domain, rev)
438 t1 = time.time()
439 if status == 'skip':
440 return 'eval', status, values
441 self.states.data['stats']['eval_count'] += 1
442 self.states.data['stats']['eval_time'] += t1 - t0
443
444 return 'eval', status, values
445
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800446 def _next_idx_iter(self, opts, force):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800447 if opts.revs:
448 for rev in opts.revs:
449 idx = self.states.rev2idx(rev)
450 logger.info('try idx=%d rev=%s (command line specified)', idx, rev)
451 yield idx, rev
452 if opts.once:
453 break
454 else:
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800455 while force or not self.strategy.is_done():
Kuang-che Wu88875db2017-07-20 10:47:53 +0800456 idx = self.strategy.next_idx()
457 rev = self.states.idx2rev(idx)
458 logger.info('try idx=%d rev=%s', idx, rev)
459 yield idx, rev
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800460 force = False
Kuang-che Wu88875db2017-07-20 10:47:53 +0800461 if opts.once:
462 break
463
464 def cmd_run(self, opts):
465 """Performs bisection.
466
467 See run command's help message for more detail.
468
469 Raises:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800470 errors.VerificationFailed: The bisection range is verified false. We
Kuang-che Wu88875db2017-07-20 10:47:53 +0800471 expect 'old' at the first rev and 'new' at last rev.
Kuang-che Wue121fae2018-11-09 16:18:39 +0800472 errors.UnableToProceed: Too many errors to narrow down further the
473 bisection range.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800474 """
Kuang-che Wu8b654092018-11-09 17:56:25 +0800475 # Set dummy values in case exception raised before loop.
476 idx, rev = -1, None
477 try:
478 assert self.config.get('switch')
479 assert self.config.get('eval')
480 self.strategy.rebuild()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800481
Kuang-che Wu8b654092018-11-09 17:56:25 +0800482 prev_rev = None
483 force = opts.force
484 for idx, rev in self._next_idx_iter(opts, force):
485 if not force:
486 # Bail out if bisection range is unlikely true in order to prevent
487 # wasting time. This is necessary because some configurations (say,
488 # confidence) may be changed before cmd_run() and thus the bisection
489 # range becomes not acceptable.
490 self.strategy.check_verification_range()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800491
Kuang-che Wu8b654092018-11-09 17:56:25 +0800492 step, status, values = self._switch_and_eval(rev, prev_rev=prev_rev)
Kuang-che Wu1dc5bd72019-01-19 00:14:46 +0800493 logger.info('rev=%s status => %s', rev, self._format_status(status))
Kuang-che Wu8b654092018-11-09 17:56:25 +0800494 force = False
495
496 self._add_sample(rev, status, values=values)
497 self.states.save()
498
499 # Bail out if bisection range is unlikely true.
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800500 self.strategy.check_verification_range()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800501
Kuang-che Wu8b654092018-11-09 17:56:25 +0800502 if status == 'skip':
503 current_state = self.states.get(idx)
504 if current_state['skip'] > (
505 current_state['old'] + current_state['new'] + 1) * 5:
506 message = 'too much "skip" for rev=%r' % rev
507 raise errors.UnableToProceed(message)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800508
Kuang-che Wu8b654092018-11-09 17:56:25 +0800509 self.strategy.show_summary()
510
511 if step == 'switch' and status == 'skip':
512 # Previous switch failed and thus the current version is unknown. Set
513 # it None, so next switch operation won't be bypassed (due to
514 # optimization).
515 prev_rev = None
516 else:
517 prev_rev = rev
518
519 logger.info('done')
520 old_idx, new_idx = self.strategy.get_range()
521 self.states.add_history('done')
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800522 self.states.save()
Kuang-che Wu8b654092018-11-09 17:56:25 +0800523 except Exception as e:
524 exception_name = e.__class__.__name__
525 self.states.add_history(
526 'failed', text='%s: %s' % (exception_name, e), index=idx, rev=rev)
527 self.states.save()
528 raise
529 finally:
530 if rev:
531 # progress so far
532 old_idx, new_idx = self.strategy.get_range()
533 self.states.add_history(
534 'range',
535 old=self.states.idx2rev(old_idx),
536 new=self.states.idx2rev(new_idx))
537 self.states.save()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800538
539 def cmd_view(self, opts):
Kuang-che Wue80bb872018-11-15 19:45:25 +0800540 """Shows remaining candidates."""
Kuang-che Wu15874b62019-01-11 21:10:27 +0800541 try:
542 self.strategy.rebuild()
543 # Rebuild twice in order to re-estimate noise.
544 self.strategy.rebuild()
545 except errors.VerificationFailed:
546 # Do nothing, go ahead to show existing information anyway.
547 pass
Kuang-che Wue80bb872018-11-15 19:45:25 +0800548
549 old_idx, new_idx = self.strategy.get_range()
550 old, new = map(self.states.idx2rev, [old_idx, new_idx])
551 highlight_old_idx, highlight_new_idx = self.strategy.get_range(
552 self.strategy.confidence / 10.0)
553 summary = {
554 'rev_info': [vars(info).copy() for info in self.states.rev_info],
555 'current_range': (old, new),
556 'highlight_range':
557 map(self.states.idx2rev, [highlight_old_idx, highlight_new_idx]),
558 'prob':
559 self.strategy.prob,
560 'remaining_steps':
561 self.strategy.remaining_steps(),
562 }
563
564 if opts.verbose or opts.json:
565 interesting_indexes = set(range(len(summary['rev_info'])))
566 else:
567 interesting_indexes = set([old_idx, new_idx])
Kuang-che Wu15874b62019-01-11 21:10:27 +0800568 if self.strategy.prob:
569 for i, p in enumerate(self.strategy.prob):
570 if p > 0.05:
571 interesting_indexes.add(i)
Kuang-che Wue80bb872018-11-15 19:45:25 +0800572
573 self.domain.fill_candidate_summary(summary, interesting_indexes)
574
575 if opts.json:
576 print(json.dumps(summary, indent=2, sort_keys=True))
577 else:
578 self.show_summary(summary, interesting_indexes, verbose=opts.verbose)
579
580 def show_summary(self, summary, interesting_indexes, verbose=False):
581 old, new = summary['current_range']
582 old_idx, new_idx = map(self.states.data['revlist'].index, [old, new])
583
Kuang-che Wuaccf9202019-01-04 15:40:42 +0800584 for link in summary.get('links', []):
585 print('%s: %s' % (link['name'], link['url']))
586 if 'note' in link:
587 print(link['note'])
Kuang-che Wue80bb872018-11-15 19:45:25 +0800588
589 print('Range: (%s, %s], %s revs left' % (old, new, (new_idx - old_idx)))
Kuang-che Wua8c987f2019-01-18 14:26:43 +0800590 if summary.get('remaining_steps'):
Kuang-che Wue80bb872018-11-15 19:45:25 +0800591 print('(roughly %d steps)' % summary['remaining_steps'])
592
593 for i, rev_info in enumerate(summary['rev_info']):
594 if (not verbose and not old_idx <= i <= new_idx and
595 not rev_info['result_counter']):
596 continue
597
598 detail = []
Kuang-che Wu05e416e2019-02-21 12:33:52 +0800599 if self.strategy.is_noisy() and summary['prob']:
Kuang-che Wua8c987f2019-01-18 14:26:43 +0800600 detail.append('%.4f%%' % (summary['prob'][i] * 100))
Kuang-che Wue80bb872018-11-15 19:45:25 +0800601 if rev_info['result_counter']:
602 detail.append(str(rev_info['result_counter']))
603 values = sorted(rev_info['values'])
604 if len(values) == 1:
605 detail.append('%.3f' % values[0])
606 elif len(values) > 1:
607 detail.append('n=%d,avg=%.3f,median=%.3f,min=%.3f,max=%.3f' %
608 (len(values), sum(values) / len(values),
609 values[len(values) // 2], values[0], values[-1]))
610
611 print('[%d] %s\t%s' % (i, rev_info['rev'], ' '.join(detail)))
612 if i in interesting_indexes:
613 if 'comment' in rev_info:
614 print('\t%s' % rev_info['comment'])
615 for action in rev_info.get('actions', []):
616 if 'text' in action:
617 print('\t%s' % action['text'])
618 if 'link' in action:
619 print('\t%s' % action['link'])
Kuang-che Wu88875db2017-07-20 10:47:53 +0800620
621 def current_status(self, session=None, session_base=None):
622 """Gets current bisect status.
623
624 Returns:
625 A dict describing current status. It contains following items:
626 inited: True iff the session file is initialized (init command has been
627 invoked). If not, below items are omitted.
628 old: Start of current estimated range.
629 new: End of current estimated range.
Kuang-che Wu8b654092018-11-09 17:56:25 +0800630 verified: The bisect range is already verified.
Kuang-che Wu88875db2017-07-20 10:47:53 +0800631 estimated_noise: New estimated noise.
632 done: True if bisection is done, otherwise False.
633 """
634 self._create_states(session=session, session_base=session_base)
635 if self.states.load():
636 self.strategy = strategy.NoisyBinarySearch(
637 self.states.rev_info,
638 self.states.rev2idx(self.config['old']),
639 self.states.rev2idx(self.config['new']),
640 confidence=self.config['confidence'],
641 observation=self.config['noisy'])
Kuang-che Wu15874b62019-01-11 21:10:27 +0800642 try:
643 self.strategy.rebuild()
644 except errors.VerificationFailed:
645 # Do nothing, go ahead to show existing information anyway.
646 pass
Kuang-che Wu88875db2017-07-20 10:47:53 +0800647 left, right = self.strategy.get_range()
648 estimated_noise = self.strategy.get_noise_observation()
649
650 result = dict(
651 inited=True,
652 old=self.states.idx2rev(left),
653 new=self.states.idx2rev(right),
Kuang-che Wu8b654092018-11-09 17:56:25 +0800654 verified=self.strategy.is_range_verified(),
Kuang-che Wudd7f6f02018-06-28 18:19:30 +0800655 estimated_noise=estimated_noise,
Kuang-che Wu88875db2017-07-20 10:47:53 +0800656 done=self.strategy.is_done())
657 else:
658 result = dict(inited=False)
659 return result
660
Kuang-che Wu8b654092018-11-09 17:56:25 +0800661 def cmd_log(self, opts):
Kuang-che Wu88875db2017-07-20 10:47:53 +0800662 """Prints what has been done so far."""
Kuang-che Wu8b654092018-11-09 17:56:25 +0800663 history = []
Kuang-che Wu88875db2017-07-20 10:47:53 +0800664 for entry in self.states.data['history']:
Kuang-che Wu8b654092018-11-09 17:56:25 +0800665 if opts.before and entry['timestamp'] >= opts.before:
666 continue
667 if opts.after and entry['timestamp'] <= opts.after:
668 continue
669 history.append(entry)
670
671 if opts.json:
672 print(json.dumps(history, indent=2))
673 return
674
675 for entry in history:
676 entry_time = datetime.datetime.fromtimestamp(int(entry['timestamp']))
677 if entry.get('event', 'sample') == 'sample':
678 print('{datetime} {rev} {status} {values} {comment}'.format(
679 datetime=entry_time,
680 rev=entry['rev'],
681 status=entry['status'] + ('*%d' % entry['times']
682 if entry.get('times', 1) > 1 else ''),
683 values=entry.get('values', ''),
684 comment=entry.get('comment', '')))
685 else:
686 print('%s %r' % (entry_time, entry))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800687
688 def cmd_next(self, _opts):
689 """Prints next suggested rev to bisect."""
690 self.strategy.rebuild()
691 if self.strategy.is_done():
692 print('done')
693 return
694
695 idx = self.strategy.next_idx()
696 rev = self.states.idx2rev(idx)
697 print(rev)
698
699 def cmd_switch(self, opts):
700 """Switches to given rev without eval."""
701 assert self.config.get('switch')
702
703 self.strategy.rebuild()
704
705 if opts.rev == 'next':
706 idx = self.strategy.next_idx()
707 rev = self.states.idx2rev(idx)
708 else:
Kuang-che Wu752228c2018-09-05 13:54:22 +0800709 rev = self.domain_cls.intra_revtype(opts.rev)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800710 assert rev
711
712 logger.info('switch to %s', rev)
713 status = do_switch(self.config['switch'], self.domain, rev)
714 if status:
715 print('switch failed')
716
717 def _add_revs_status_helper(self, revs, status):
718 self.strategy.rebuild()
719 for rev, times in revs:
Kuang-che Wu8b654092018-11-09 17:56:25 +0800720 self._add_sample(rev, status, times=times, comment='manual')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800721 self.states.save()
722
723 def cmd_new(self, opts):
724 """Tells bisect engine the said revs have "new" behavior."""
725 logger.info('set [%s] as new', opts.revs)
726 self._add_revs_status_helper(opts.revs, 'new')
727
728 def cmd_old(self, opts):
729 """Tells bisect engine the said revs have "old" behavior."""
730 logger.info('set [%s] as old', opts.revs)
731 self._add_revs_status_helper(opts.revs, 'old')
732
733 def cmd_skip(self, opts):
734 """Tells bisect engine the said revs have "skip" behavior."""
735 logger.info('set [%s] as skip', opts.revs)
736 self._add_revs_status_helper(opts.revs, 'skip')
737
738 def _create_states(self, session=None, session_base=None):
739 if not session:
740 session = DEFAULT_SESSION_NAME
741 if not session_base:
Kuang-che Wu41e8b592018-09-25 17:01:30 +0800742 session_base = configure.get('SESSION_BASE', common.DEFAULT_SESSION_BASE)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800743
744 session_file = os.path.join(session_base, session, self.domain_cls.__name__)
745
746 if self.states:
747 assert self.states.session_file == session_file
748 else:
Kuang-che Wuc5781932018-10-05 00:30:19 +0800749 self.states = core.BisectStates(session_file)
Kuang-che Wu88875db2017-07-20 10:47:53 +0800750
751 def cmd_config(self, opts):
752 """Configures additional setting.
753
754 See config command's help message for more detail.
755 """
756 self.states.load()
757 self.domain = self.domain_cls(self.states.config)
758 if not opts.value:
759 print(self.states.config[opts.key])
760 return
761
762 if opts.key in ['switch', 'eval']:
Kuang-che Wu88518882017-09-22 16:57:25 +0800763 result = check_executable(opts.value[0])
764 if result:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800765 raise errors.ArgumentError('%s command' % opts.key, result)
Kuang-che Wu88518882017-09-22 16:57:25 +0800766
Kuang-che Wu88875db2017-07-20 10:47:53 +0800767 self.states.config[opts.key] = opts.value
768
769 elif opts.key == 'confidence':
770 if len(opts.value) != 1:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800771 raise errors.ArgumentError(
772 'confidence value',
773 'expected 1 value, %d values given' % len(opts.value))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800774 try:
775 self.states.config[opts.key] = float(opts.value[0])
776 except ValueError:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800777 raise errors.ArgumentError('confidence value',
778 'invalid float value: %r' % opts.value[0])
Kuang-che Wu88875db2017-07-20 10:47:53 +0800779
780 elif opts.key == 'noisy':
781 if len(opts.value) != 1:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800782 raise errors.ArgumentError(
783 'noisy value',
784 'expected 1 value, %d values given' % len(opts.value))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800785 self.states.config[opts.key] = opts.value[0]
786
787 else:
Kuang-che Wue121fae2018-11-09 16:18:39 +0800788 # unreachable
789 assert 0
Kuang-che Wu88875db2017-07-20 10:47:53 +0800790
791 self.states.save()
792
793 def create_argument_parser(self, prog):
Kuang-che Wub2376262017-11-20 18:05:24 +0800794 if self.domain_cls.help:
795 description = self.domain_cls.help
796 else:
797 description = 'Bisector for %s' % self.domain_cls.__name__
798 description += textwrap.dedent('''
799 When running switcher and evaluator, it will set BISECT_REV environment
800 variable, indicates current rev to switch/evaluate.
801 ''')
802
Kuang-che Wu88875db2017-07-20 10:47:53 +0800803 parser = argparse.ArgumentParser(
804 prog=prog,
805 formatter_class=argparse.RawDescriptionHelpFormatter,
Kuang-che Wub2376262017-11-20 18:05:24 +0800806 description=description)
Kuang-che Wu385279d2017-09-27 14:48:28 +0800807 common.add_common_arguments(parser)
808 parser.add_argument(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800809 '--session_base',
Kuang-che Wu41e8b592018-09-25 17:01:30 +0800810 default=configure.get('SESSION_BASE', common.DEFAULT_SESSION_BASE),
Kuang-che Wu88875db2017-07-20 10:47:53 +0800811 help='Directory to store sessions (default: %(default)r)')
812 parser.add_argument(
813 '--session',
814 default=DEFAULT_SESSION_NAME,
815 help='Session name (default: %(default)r)')
816 subparsers = parser.add_subparsers(
817 dest='command', title='commands', metavar='<command>')
818
819 parser_reset = subparsers.add_parser(
820 'reset', help='Reset bisect session and clean up saved result')
821 parser_reset.set_defaults(func=self.cmd_reset)
822
823 parser_init = subparsers.add_parser(
824 'init',
825 help='Initializes bisect session',
826 formatter_class=argparse.RawDescriptionHelpFormatter,
827 description=textwrap.dedent('''
828 Besides arguments for 'init' command, you also need to set 'switch'
829 and 'eval' command line via 'config' command.
830 $ bisector config switch <switch command and arguments>
831 $ bisector config eval <eval command and arguments>
832
833 The value of --noisy and --confidence could be changed by 'config'
834 command after 'init' as well.
835 '''))
836 parser_init.add_argument(
837 '--old',
838 required=True,
839 type=self.domain_cls.revtype,
840 help='Start of bisect range, which has old behavior')
841 parser_init.add_argument(
842 '--new',
843 required=True,
844 type=self.domain_cls.revtype,
845 help='End of bisect range, which has new behavior')
846 parser_init.add_argument(
847 '--noisy',
848 help='Enable noisy binary search and specify prior result. '
849 'For example, "old=1/10,new=2/3" means old fail rate is 1/10 '
850 'and new fail rate increased to 2/3. '
851 'Skip if not flaky, say, "new=2/3" means old is always good.')
852 parser_init.add_argument(
853 '--confidence',
854 type=float,
855 default=DEFAULT_CONFIDENCE,
856 help='Confidence level (default: %(default)r)')
857 parser_init.set_defaults(func=self.cmd_init)
858 self.domain_cls.add_init_arguments(parser_init)
859
860 parser_config = subparsers.add_parser(
861 'config', help='Configures additional setting')
862 parser_config.add_argument(
863 'key',
864 choices=['switch', 'eval', 'confidence', 'noisy'],
865 metavar='key',
866 help='What config to change. choices=[%(choices)s]')
867 parser_config.add_argument(
868 'value', nargs=argparse.REMAINDER, help='New value')
869 parser_config.set_defaults(func=self.cmd_config)
870
871 parser_run = subparsers.add_parser(
872 'run',
873 help='Performs bisection',
874 formatter_class=argparse.RawDescriptionHelpFormatter,
875 description=textwrap.dedent('''
876 This command does switch and eval to determine candidates having old or
877 new behavior.
878
879 By default, it attempts to try versions in binary search manner until
880 found the first version having new behavior.
881
882 If version numbers are specified on command line, it just tries those
883 versions and record the result.
884
885 Example:
886 Bisect automatically.
887 $ %(prog)s
888
889 Switch and run version "2.13" and "2.14" and then stop.
890 $ %(prog)s 2.13 2.14
891 '''))
892 parser_run.add_argument(
893 '-1', '--once', action='store_true', help='Only run one step')
894 parser_run.add_argument(
Kuang-che Wu889f68e2018-10-29 14:12:13 +0800895 '--force',
896 action='store_true',
897 help="Run at least once even it's already done")
898 parser_run.add_argument(
Kuang-che Wu88875db2017-07-20 10:47:53 +0800899 'revs',
900 nargs='*',
Kuang-che Wu752228c2018-09-05 13:54:22 +0800901 type=self.domain_cls.intra_revtype,
Kuang-che Wu88875db2017-07-20 10:47:53 +0800902 help='revs to switch+eval; '
903 'default is calculating automatically and run until done')
904 parser_run.set_defaults(func=self.cmd_run)
905
906 parser_switch = subparsers.add_parser(
907 'switch', help='Switch to given rev without eval')
908 parser_switch.add_argument(
Kuang-che Wu603cdad2019-01-18 21:32:55 +0800909 'rev',
910 type=argtype_multiplexer(self.domain_cls.intra_revtype,
911 argtype_re('next', 'next')))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800912 parser_switch.set_defaults(func=self.cmd_switch)
913
914 parser_old = subparsers.add_parser(
915 'old', help='Tells bisect engine the said revs have "old" behavior')
916 parser_old.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800917 'revs',
918 nargs='+',
919 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800920 parser_old.set_defaults(func=self.cmd_old)
921
922 parser_new = subparsers.add_parser(
923 'new', help='Tells bisect engine the said revs have "new" behavior')
924 parser_new.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800925 'revs',
926 nargs='+',
927 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800928 parser_new.set_defaults(func=self.cmd_new)
929
930 parser_skip = subparsers.add_parser(
931 'skip', help='Tells bisect engine the said revs have "skip" behavior')
932 parser_skip.add_argument(
Kuang-che Wu752228c2018-09-05 13:54:22 +0800933 'revs',
934 nargs='+',
935 type=argtype_multiplier(self.domain_cls.intra_revtype))
Kuang-che Wu88875db2017-07-20 10:47:53 +0800936 parser_skip.set_defaults(func=self.cmd_skip)
937
938 parser_view = subparsers.add_parser(
939 'view', help='Shows current progress and candidates')
Kuang-che Wue80bb872018-11-15 19:45:25 +0800940 parser_view.add_argument('--verbose', '-v', action='store_true')
941 parser_view.add_argument('--json', action='store_true')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800942 parser_view.set_defaults(func=self.cmd_view)
943
944 parser_log = subparsers.add_parser(
945 'log', help='Prints what has been done so far')
Kuang-che Wu8b654092018-11-09 17:56:25 +0800946 parser_log.add_argument('--before', type=float)
947 parser_log.add_argument('--after', type=float)
948 parser_log.add_argument(
949 '--json', action='store_true', help='Machine readable output')
Kuang-che Wu88875db2017-07-20 10:47:53 +0800950 parser_log.set_defaults(func=self.cmd_log)
951
952 parser_next = subparsers.add_parser(
953 'next', help='Prints next suggested rev to bisect')
954 parser_next.set_defaults(func=self.cmd_next)
955
956 return parser
957
958 def main(self, *args, **kwargs):
959 """Command line main function.
960
961 Args:
962 *args: Command line arguments.
963 **kwargs: additional non command line arguments passed by script code.
964 {
965 'prog': Program name; optional.
966 }
967 """
Kuang-che Wu385279d2017-09-27 14:48:28 +0800968 common.init()
Kuang-che Wu88875db2017-07-20 10:47:53 +0800969 parser = self.create_argument_parser(kwargs.get('prog'))
970 opts = parser.parse_args(args or None)
971 common.config_logging(opts)
972
973 self._create_states(session=opts.session, session_base=opts.session_base)
974 if opts.command not in ('init', 'reset', 'config'):
975 self.states.load()
976 self.domain = self.domain_cls(self.states.config)
977 self.strategy = strategy.NoisyBinarySearch(
978 self.states.rev_info,
979 self.states.rev2idx(self.config['old']),
980 self.states.rev2idx(self.config['new']),
981 confidence=self.config['confidence'],
982 observation=self.config['noisy'])
983
984 return opts.func(opts)