Mike Frysinger | f1ba7ad | 2022-09-12 05:42:57 -0400 | [diff] [blame] | 1 | # Copyright 2012 The ChromiumOS Authors |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """This module uprevs Chrome for cbuildbot. |
| 6 | |
| 7 | After calling, it prints outs CHROME_VERSION_ATOM=(version atom string). A |
| 8 | caller could then use this atom with emerge to build the newly uprevved version |
| 9 | of Chrome e.g. |
| 10 | |
| 11 | ./cros_mark_chrome_as_stable tot |
| 12 | Returns chrome-base/chromeos-chrome-8.0.552.0_alpha_r1 |
| 13 | |
| 14 | emerge-x86-generic =chrome-base/chromeos-chrome-8.0.552.0_alpha_r1 |
| 15 | """ |
| 16 | |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 17 | import base64 |
Mike Frysinger | a94f125 | 2019-09-12 02:39:28 -0400 | [diff] [blame] | 18 | import distutils.version # pylint: disable=import-error,no-name-in-module |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 19 | import filecmp |
Chris McDonald | b55b703 | 2021-06-17 16:41:32 -0600 | [diff] [blame] | 20 | import logging |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 21 | import os |
| 22 | import re |
Mike Frysinger | e852b07 | 2021-05-21 12:39:03 -0400 | [diff] [blame] | 23 | import urllib.parse |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 24 | |
Chris McDonald | b55b703 | 2021-06-17 16:41:32 -0600 | [diff] [blame] | 25 | from chromite.cbuildbot import cbuildbot_alerts |
Mike Frysinger | a13c04f | 2016-09-01 00:35:17 -0400 | [diff] [blame] | 26 | from chromite.lib import commandline |
Chris McDonald | b55b703 | 2021-06-17 16:41:32 -0600 | [diff] [blame] | 27 | from chromite.lib import constants |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 28 | from chromite.lib import cros_build_lib |
David James | 97d9587 | 2012-11-16 15:09:56 -0800 | [diff] [blame] | 29 | from chromite.lib import git |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 30 | from chromite.lib import gob_util |
Alex Deymo | 075c229 | 2014-09-04 18:31:50 -0700 | [diff] [blame] | 31 | from chromite.lib import portage_util |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 32 | from chromite.lib import timeout_util |
Mike Frysinger | 6cb624a | 2012-05-24 18:17:38 -0400 | [diff] [blame] | 33 | from chromite.scripts import cros_mark_as_stable |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 34 | |
Mike Frysinger | 807d828 | 2022-04-28 22:45:17 -0400 | [diff] [blame] | 35 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 36 | # Helper regex's for finding ebuilds. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 37 | _CHROME_VERSION_REGEX = r"\d+\.\d+\.\d+\.\d+" |
| 38 | _NON_STICKY_REGEX = r"%s[(_rc.*)|(_alpha.*)]+" % _CHROME_VERSION_REGEX |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 39 | |
| 40 | # Dir where all the action happens. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 41 | _OVERLAY_DIR = "%(srcroot)s/third_party/chromiumos-overlay/" |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 42 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 43 | _GIT_COMMIT_MESSAGE = ( |
| 44 | "Marking %(chrome_rev)s for %(chrome_pn)s ebuild " |
| 45 | "with version %(chrome_version)s as stable." |
| 46 | ) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 47 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 48 | # URLs that print lists of chrome revisions between two versions of the browser. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 49 | _CHROME_VERSION_URL = ( |
| 50 | "http://omahaproxy.appspot.com/changelog?" |
| 51 | "old_version=%(old)s&new_version=%(new)s" |
| 52 | ) |
Chris Sosa | dd611df | 2012-02-03 15:26:23 -0800 | [diff] [blame] | 53 | |
| 54 | # Only print links when we rev these types. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 55 | _REV_TYPES_FOR_LINKS = [ |
| 56 | constants.CHROME_REV_LATEST, |
| 57 | constants.CHROME_REV_STICKY, |
| 58 | ] |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 59 | |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 60 | |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 61 | def _GetVersionContents(chrome_version_info): |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 62 | """Get the current Chromium version, from the contents of a VERSION file. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 63 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 64 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 65 | chrome_version_info: The contents of a chromium VERSION file. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 66 | """ |
| 67 | chrome_version_array = [] |
| 68 | for line in chrome_version_info.splitlines(): |
| 69 | chrome_version_array.append(line.rpartition("=")[2]) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 70 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 71 | return ".".join(chrome_version_array) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 72 | |
Mike Frysinger | cc83883 | 2014-05-24 13:10:30 -0400 | [diff] [blame] | 73 | |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 74 | def _GetSpecificVersionUrl(git_url, revision, time_to_wait=600): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 75 | """Returns the Chromium version, from a repository URL and version. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 76 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 77 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 78 | git_url: Repository URL for chromium. |
| 79 | revision: the git revision we want to use. |
| 80 | time_to_wait: the minimum period before abandoning our wait for the |
| 81 | desired revision to be present. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 82 | """ |
| 83 | parsed_url = urllib.parse.urlparse(git_url) |
| 84 | host = parsed_url[1] |
| 85 | path = parsed_url[2].rstrip("/") + ( |
| 86 | "/+/%s/chrome/VERSION?format=text" % revision |
| 87 | ) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 88 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 89 | # Allow for git repository replication lag with sleep/retry loop. |
| 90 | def _fetch(): |
| 91 | return gob_util.FetchUrl(host, path, ignore_404=True) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 92 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 93 | def _wait_msg(_remaining): |
| 94 | logging.info( |
| 95 | "Repository does not yet have revision %s. Sleeping...", revision |
| 96 | ) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 97 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 98 | content = timeout_util.WaitForSuccess( |
| 99 | retry_check=lambda x: not bool(x), |
| 100 | func=_fetch, |
| 101 | timeout=time_to_wait, |
| 102 | period=30, |
| 103 | side_effect_func=_wait_msg, |
| 104 | ) |
| 105 | return _GetVersionContents(base64.b64decode(content).decode("utf-8")) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 106 | |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 107 | |
| 108 | def _GetTipOfTrunkVersionFile(root): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 109 | """Returns the current Chromium version, from a file in a checkout. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 110 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 111 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 112 | root: path to the root of the chromium checkout. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 113 | """ |
| 114 | version_file = os.path.join(root, "src", "chrome", "VERSION") |
| 115 | try: |
| 116 | chrome_version_info = cros_build_lib.run( |
| 117 | ["cat", version_file], stdout=True |
| 118 | ).stdout |
| 119 | except cros_build_lib.RunCommandError as e: |
| 120 | e.msg += "\nCould not read version file at %s." % version_file |
| 121 | raise e |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 122 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 123 | return _GetVersionContents(chrome_version_info) |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 124 | |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 125 | |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 126 | def CheckIfChromeRightForOS(deps_content): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 127 | """Checks if DEPS is right for Chrome OS. |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame] | 128 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 129 | This function checks for a variable called 'buildspec_platforms' to |
| 130 | find out if its 'chromeos' or 'all'. If any of those values, |
| 131 | then it chooses that DEPS. |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame] | 132 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 133 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 134 | deps_content: Content of release buildspec DEPS file. |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame] | 135 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 136 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 137 | True if DEPS is the right Chrome for Chrome OS. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 138 | """ |
| 139 | platforms_search = re.search(r"buildspec_platforms.*\s.*\s", deps_content) |
Dharani Govindan | cbbf69c | 2014-07-29 15:37:39 -0700 | [diff] [blame] | 140 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 141 | if platforms_search: |
| 142 | platforms = platforms_search.group() |
| 143 | if "chromeos" in platforms or "all" in platforms: |
| 144 | return True |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame] | 145 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 146 | return False |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame] | 147 | |
| 148 | |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 149 | def GetLatestRelease(git_url, branch=None): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 150 | """Gets the latest release version from the release tags in the repository. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 151 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 152 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 153 | git_url: URL of git repository. |
| 154 | branch: If set, gets the latest release for branch, otherwise latest |
| 155 | release. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 156 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 157 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 158 | Latest version string. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 159 | """ |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 160 | # TODO(szager): This only works for public release buildspecs in the |
| 161 | # chromium src repository. Internal buildspecs are tracked differently. At |
| 162 | # the time of writing, I can't find any callers that use this method to scan |
| 163 | # for internal buildspecs. But there may be something lurking... |
Stefan Zager | d49d9ff | 2014-08-15 21:33:37 -0700 | [diff] [blame] | 164 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 165 | parsed_url = urllib.parse.urlparse(git_url) |
| 166 | path = parsed_url[2].rstrip("/") + "/+refs/tags?format=JSON" |
| 167 | j = gob_util.FetchUrlJson(parsed_url[1], path, ignore_404=False) |
| 168 | if branch: |
| 169 | chrome_version_re = re.compile(r"^%s\.\d+.*" % branch) |
| 170 | else: |
| 171 | chrome_version_re = re.compile(r"^[0-9]+\..*") |
| 172 | matching_versions = [ |
| 173 | key for key in j.keys() if chrome_version_re.match(key) |
| 174 | ] |
| 175 | matching_versions.sort(key=distutils.version.LooseVersion) |
| 176 | for chrome_version in reversed(matching_versions): |
| 177 | path = parsed_url[2].rstrip() + ( |
| 178 | "/+/refs/tags/%s/DEPS?format=text" % chrome_version |
| 179 | ) |
| 180 | content = gob_util.FetchUrl(parsed_url[1], path, ignore_404=False) |
| 181 | if content: |
| 182 | deps_content = base64.b64decode(content).decode("utf-8") |
| 183 | if CheckIfChromeRightForOS(deps_content): |
| 184 | return chrome_version |
Peter Mayo | ad8173d | 2011-11-08 16:18:23 -0500 | [diff] [blame] | 185 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 186 | return None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 187 | |
| 188 | |
| 189 | def _GetStickyEBuild(stable_ebuilds): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 190 | """Returns the sticky ebuild.""" |
| 191 | sticky_ebuilds = [] |
| 192 | non_sticky_re = re.compile(_NON_STICKY_REGEX) |
| 193 | for ebuild in stable_ebuilds: |
| 194 | if not non_sticky_re.match(ebuild.version): |
| 195 | sticky_ebuilds.append(ebuild) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 196 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 197 | if not sticky_ebuilds: |
| 198 | raise Exception("No sticky ebuilds found") |
| 199 | elif len(sticky_ebuilds) > 1: |
| 200 | logging.warning("More than one sticky ebuild found:") |
| 201 | for ebuild in sticky_ebuilds: |
| 202 | logging.warning(" %s", ebuild.ebuild_path) |
| 203 | logging.warning("Make sure to *not* create xxx.0-r1.ebuilds") |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 204 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 205 | return portage_util.BestEBuild(sticky_ebuilds) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 206 | |
| 207 | |
Alex Deymo | 075c229 | 2014-09-04 18:31:50 -0700 | [diff] [blame] | 208 | class ChromeEBuild(portage_util.EBuild): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 209 | """Thin sub-class of EBuild that adds a chrome_version field.""" |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 210 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 211 | chrome_version_re = re.compile(r".*-(%s|9999).*" % (_CHROME_VERSION_REGEX)) |
| 212 | chrome_version = "" |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 213 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 214 | def __init__(self, path): |
| 215 | portage_util.EBuild.__init__(self, path) |
Andrew Lamb | 701696f | 2023-09-15 17:22:45 +0000 | [diff] [blame^] | 216 | re_match = self.chrome_version_re.match(self.ebuild_path_no_revision) |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 217 | if re_match: |
| 218 | self.chrome_version = re_match.group(1) |
| 219 | |
| 220 | def __str__(self): |
Andrew Lamb | 701696f | 2023-09-15 17:22:45 +0000 | [diff] [blame^] | 221 | return self.ebuild_path |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 222 | |
| 223 | |
David Zeuthen | 665d313 | 2014-08-25 15:27:02 -0400 | [diff] [blame] | 224 | def FindChromeCandidates(package_dir): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 225 | """Return a tuple of chrome's unstable ebuild and stable ebuilds. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 226 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 227 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 228 | package_dir: The path to where the package ebuild is stored. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 229 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 230 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 231 | Tuple [unstable_ebuild, stable_ebuilds]. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 232 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 233 | Raises: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 234 | Exception: if no unstable ebuild exists for Chrome. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 235 | """ |
| 236 | stable_ebuilds = [] |
| 237 | unstable_ebuilds = [] |
| 238 | for path in [ |
| 239 | os.path.join(package_dir, entry) for entry in os.listdir(package_dir) |
| 240 | ]: |
| 241 | if path.endswith(".ebuild"): |
| 242 | ebuild = ChromeEBuild(path) |
| 243 | if not ebuild.chrome_version: |
| 244 | logging.warning("Poorly formatted ebuild found at %s", path) |
| 245 | else: |
| 246 | if "9999" in ebuild.version: |
| 247 | unstable_ebuilds.append(ebuild) |
| 248 | else: |
| 249 | stable_ebuilds.append(ebuild) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 250 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 251 | # Apply some confidence checks. |
| 252 | if not unstable_ebuilds: |
| 253 | raise Exception("Missing 9999 ebuild for %s" % package_dir) |
| 254 | if not stable_ebuilds: |
| 255 | logging.warning("Missing stable ebuild for %s", package_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 256 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 257 | return portage_util.BestEBuild(unstable_ebuilds), stable_ebuilds |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 258 | |
| 259 | |
| 260 | def FindChromeUprevCandidate(stable_ebuilds, chrome_rev, sticky_branch): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 261 | """Finds the Chrome uprev candidate for the given chrome_rev. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 262 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 263 | Using the pre-flight logic, this means the stable ebuild you are uprevving |
| 264 | from. The difference here is that the version could be different and in |
| 265 | that case we want to find it to delete it. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 266 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 267 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 268 | stable_ebuilds: A list of stable ebuilds. |
| 269 | chrome_rev: The chrome_rev designating which candidate to find. |
| 270 | sticky_branch: The branch that is currently sticky with Major/Minor |
| 271 | components. For example: 9.0.553. Can be None but not if chrome_rev |
| 272 | is CHROME_REV_STICKY. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 273 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 274 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 275 | The EBuild, otherwise None if none found. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 276 | """ |
| 277 | candidates = [] |
| 278 | if chrome_rev in [ |
| 279 | constants.CHROME_REV_LOCAL, |
| 280 | constants.CHROME_REV_TOT, |
| 281 | constants.CHROME_REV_SPEC, |
| 282 | ]: |
| 283 | # These are labelled alpha, for historic reasons, |
| 284 | # not just for the fun of confusion. |
| 285 | chrome_branch_re = re.compile(r"%s.*_alpha.*" % _CHROME_VERSION_REGEX) |
| 286 | for ebuild in stable_ebuilds: |
| 287 | if chrome_branch_re.search(ebuild.version): |
| 288 | candidates.append(ebuild) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 289 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 290 | elif chrome_rev == constants.CHROME_REV_STICKY: |
| 291 | assert sticky_branch is not None |
| 292 | chrome_branch_re = re.compile(r"%s\..*" % sticky_branch) |
| 293 | for ebuild in stable_ebuilds: |
| 294 | if chrome_branch_re.search(ebuild.version): |
| 295 | candidates.append(ebuild) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 296 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 297 | else: |
| 298 | chrome_branch_re = re.compile(r"%s.*_rc.*" % _CHROME_VERSION_REGEX) |
| 299 | for ebuild in stable_ebuilds: |
| 300 | if chrome_branch_re.search(ebuild.version): |
| 301 | candidates.append(ebuild) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 302 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 303 | if candidates: |
| 304 | return portage_util.BestEBuild(candidates) |
| 305 | else: |
| 306 | return None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 307 | |
Mike Frysinger | cc83883 | 2014-05-24 13:10:30 -0400 | [diff] [blame] | 308 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 309 | def GetChromeRevisionLinkFromVersions(old_chrome_version, chrome_version): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 310 | """Return appropriately formatted link to revision info, given versions |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 311 | |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 312 | Given two Chrome version strings (e.g. 9.0.533.0), generate a link to a |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 313 | page that prints the Chromium revisions between those two versions. |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 314 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 315 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 316 | old_chrome_version: version to diff from |
| 317 | chrome_version: version to which to diff |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 318 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 319 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 320 | The desired URL. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 321 | """ |
| 322 | return _CHROME_VERSION_URL % { |
| 323 | "old": old_chrome_version, |
| 324 | "new": chrome_version, |
| 325 | } |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 326 | |
Mike Frysinger | 750c5f5 | 2014-09-16 16:16:57 -0400 | [diff] [blame] | 327 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 328 | def GetChromeRevisionListLink(old_chrome, new_chrome, chrome_rev): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 329 | """Returns a link to the list of revisions between two Chromium versions |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 330 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 331 | Given two ChromeEBuilds and the kind of rev we're doing, generate a |
| 332 | link to a page that prints the Chromium changes between those two |
| 333 | revisions, inclusive. |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 334 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 335 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 336 | old_chrome: ebuild for the version to diff from |
| 337 | new_chrome: ebuild for the version to which to diff |
| 338 | chrome_rev: one of constants.VALID_CHROME_REVISIONS |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 339 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 340 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 341 | The desired URL. |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 342 | """ |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 343 | assert chrome_rev in _REV_TYPES_FOR_LINKS |
| 344 | return GetChromeRevisionLinkFromVersions( |
| 345 | old_chrome.chrome_version, new_chrome.chrome_version |
| 346 | ) |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 347 | |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 348 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 349 | def MarkChromeEBuildAsStable( |
| 350 | stable_candidate, |
| 351 | unstable_ebuild, |
| 352 | chrome_pn, |
| 353 | chrome_rev, |
| 354 | chrome_version, |
| 355 | package_dir, |
| 356 | ): |
| 357 | r"""Uprevs the chrome ebuild specified by chrome_rev. |
David James | 629febb | 2012-11-25 13:07:34 -0800 | [diff] [blame] | 358 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 359 | This is the main function that uprevs the chrome_rev from a stable candidate |
| 360 | to its new version. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 361 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 362 | Args: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 363 | stable_candidate: ebuild that corresponds to the stable ebuild we are |
| 364 | revving from. If None, builds a new ebuild given the version |
| 365 | and logic for chrome_rev type with revision set to 1. |
| 366 | unstable_ebuild: ebuild corresponding to the unstable ebuild for chrome. |
| 367 | chrome_pn: package name. |
| 368 | chrome_rev: one of constants.VALID_CHROME_REVISIONS or LOCAL |
| 369 | constants.CHROME_REV_SPEC - Requires commit value. Revs the ebuild |
| 370 | for the specified version and uses the portage suffix of _alpha. |
| 371 | constants.CHROME_REV_TOT - Requires commit value. Revs the ebuild |
| 372 | for the TOT version and uses the portage suffix of _alpha. |
| 373 | constants.CHROME_REV_LOCAL - Requires a chrome_root. Revs the ebuild |
| 374 | for the local version and uses the portage suffix of _alpha. |
| 375 | constants.CHROME_REV_LATEST - This uses the portage suffix of _rc as |
| 376 | they are release candidates for the next sticky version. |
| 377 | constants.CHROME_REV_STICKY - Revs the sticky version. |
| 378 | chrome_version: The \d.\d.\d.\d version of Chrome. |
| 379 | package_dir: Path to the chromeos-chrome package dir. |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 380 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 381 | Returns: |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 382 | Full portage version atom (including rc's, etc) that was revved. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 383 | """ |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 384 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 385 | def IsTheNewEBuildRedundant(new_ebuild, stable_ebuild): |
| 386 | """Returns True if the new ebuild is redundant. |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 387 | |
Alex Klein | 68b270c | 2023-04-14 14:42:50 -0600 | [diff] [blame] | 388 | This is True if the current stable ebuild is an exact copy of the new |
| 389 | one. |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 390 | """ |
| 391 | if not stable_ebuild: |
| 392 | return False |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 393 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 394 | if stable_candidate.chrome_version == new_ebuild.chrome_version: |
| 395 | return filecmp.cmp( |
| 396 | new_ebuild.ebuild_path, stable_ebuild.ebuild_path, shallow=False |
| 397 | ) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 398 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 399 | # Mark latest release and sticky branches as stable. |
| 400 | mark_stable = chrome_rev not in [ |
| 401 | constants.CHROME_REV_TOT, |
| 402 | constants.CHROME_REV_SPEC, |
| 403 | constants.CHROME_REV_LOCAL, |
| 404 | ] |
| 405 | |
| 406 | # Case where we have the last stable candidate with same version just rev. |
| 407 | if stable_candidate and stable_candidate.chrome_version == chrome_version: |
| 408 | new_ebuild_path = "%s-r%d.ebuild" % ( |
| 409 | stable_candidate.ebuild_path_no_revision, |
| 410 | stable_candidate.current_revision + 1, |
| 411 | ) |
| 412 | else: |
| 413 | suffix = "rc" if mark_stable else "alpha" |
| 414 | pf = "%s-%s_%s-r1" % (chrome_pn, chrome_version, suffix) |
| 415 | new_ebuild_path = os.path.join(package_dir, "%s.ebuild" % pf) |
| 416 | |
| 417 | portage_util.EBuild.MarkAsStable( |
| 418 | unstable_ebuild.ebuild_path, |
| 419 | new_ebuild_path, |
| 420 | {}, |
| 421 | make_stable=mark_stable, |
| 422 | ) |
| 423 | new_ebuild = ChromeEBuild(new_ebuild_path) |
| 424 | |
| 425 | # Determine whether this is ebuild is redundant. |
| 426 | if IsTheNewEBuildRedundant(new_ebuild, stable_candidate): |
| 427 | msg = "Previous ebuild with same version found and ebuild is redundant." |
| 428 | logging.info(msg) |
| 429 | os.unlink(new_ebuild_path) |
| 430 | return None |
| 431 | |
| 432 | if stable_candidate and chrome_rev in _REV_TYPES_FOR_LINKS: |
| 433 | cbuildbot_alerts.PrintBuildbotLink( |
| 434 | "Chromium revisions", |
| 435 | GetChromeRevisionListLink(stable_candidate, new_ebuild, chrome_rev), |
| 436 | ) |
| 437 | |
| 438 | git.RunGit(package_dir, ["add", new_ebuild_path]) |
| 439 | if stable_candidate and not stable_candidate.IsSticky(): |
Andrew Lamb | 701696f | 2023-09-15 17:22:45 +0000 | [diff] [blame^] | 440 | git.RunGit(package_dir, ["rm", stable_candidate.ebuild_path]) |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 441 | |
| 442 | portage_util.EBuild.CommitChange( |
| 443 | _GIT_COMMIT_MESSAGE |
| 444 | % { |
| 445 | "chrome_pn": chrome_pn, |
| 446 | "chrome_rev": chrome_rev, |
| 447 | "chrome_version": chrome_version, |
| 448 | }, |
| 449 | package_dir, |
| 450 | ) |
| 451 | |
| 452 | return "%s-%s" % (new_ebuild.package, new_ebuild.version) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 453 | |
| 454 | |
Mike Frysinger | a13c04f | 2016-09-01 00:35:17 -0400 | [diff] [blame] | 455 | def GetParser(): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 456 | """Return a command line parser.""" |
| 457 | parser = commandline.ArgumentParser(description=__doc__) |
| 458 | parser.add_argument("-b", "--boards") |
| 459 | parser.add_argument( |
| 460 | "-c", "--chrome_url", default=constants.CHROMIUM_GOB_URL |
| 461 | ) |
| 462 | parser.add_argument( |
| 463 | "-f", |
| 464 | "--force_version", |
| 465 | help="Chrome version or git revision hash to use", |
| 466 | ) |
| 467 | parser.add_argument( |
| 468 | "-s", |
| 469 | "--srcroot", |
| 470 | default=os.path.join(os.environ["HOME"], "trunk", "src"), |
| 471 | help="Path to the src directory", |
| 472 | ) |
| 473 | parser.add_argument( |
| 474 | "-t", |
| 475 | "--tracking_branch", |
| 476 | default="cros/master", |
| 477 | help="Branch we are tracking changes against", |
| 478 | ) |
| 479 | parser.add_argument("revision", choices=constants.VALID_CHROME_REVISIONS) |
| 480 | return parser |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 481 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 482 | |
Mike Frysinger | a13c04f | 2016-09-01 00:35:17 -0400 | [diff] [blame] | 483 | def main(argv): |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 484 | parser = GetParser() |
| 485 | options = parser.parse_args(argv) |
| 486 | options.Freeze() |
| 487 | chrome_rev = options.revision |
Mike Frysinger | a13c04f | 2016-09-01 00:35:17 -0400 | [diff] [blame] | 488 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 489 | if options.force_version and chrome_rev not in ( |
| 490 | constants.CHROME_REV_SPEC, |
| 491 | constants.CHROME_REV_LATEST, |
| 492 | ): |
| 493 | parser.error( |
| 494 | "--force_version is not compatible with the %r " |
| 495 | "option." % (chrome_rev,) |
| 496 | ) |
David James | fb16001 | 2014-07-01 10:00:57 -0700 | [diff] [blame] | 497 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 498 | overlay_dir = os.path.abspath(_OVERLAY_DIR % {"srcroot": options.srcroot}) |
| 499 | chrome_package_dir = os.path.join(overlay_dir, constants.CHROME_CP) |
| 500 | version_to_uprev = None |
| 501 | sticky_branch = None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 502 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 503 | (unstable_ebuild, stable_ebuilds) = FindChromeCandidates(chrome_package_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 504 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 505 | if chrome_rev == constants.CHROME_REV_LOCAL: |
| 506 | if "CHROME_ROOT" in os.environ: |
| 507 | chrome_root = os.environ["CHROME_ROOT"] |
| 508 | else: |
| 509 | chrome_root = os.path.join(os.environ["HOME"], "chrome_root") |
| 510 | |
| 511 | version_to_uprev = _GetTipOfTrunkVersionFile(chrome_root) |
| 512 | logging.info("Using local source, versioning is untrustworthy.") |
| 513 | elif chrome_rev == constants.CHROME_REV_SPEC: |
| 514 | if "." in options.force_version: |
| 515 | version_to_uprev = options.force_version |
| 516 | else: |
| 517 | commit_to_use = options.force_version |
| 518 | if "@" in commit_to_use: |
| 519 | commit_to_use = commit_to_use.rpartition("@")[2] |
| 520 | version_to_uprev = _GetSpecificVersionUrl( |
| 521 | options.chrome_url, commit_to_use |
| 522 | ) |
| 523 | elif chrome_rev == constants.CHROME_REV_TOT: |
| 524 | commit_to_use = gob_util.GetTipOfTrunkRevision(options.chrome_url) |
| 525 | version_to_uprev = _GetSpecificVersionUrl( |
| 526 | options.chrome_url, commit_to_use |
| 527 | ) |
| 528 | elif chrome_rev == constants.CHROME_REV_LATEST: |
| 529 | if options.force_version: |
| 530 | if "." not in options.force_version: |
| 531 | parser.error( |
| 532 | "%s only accepts released Chrome versions, not SVN or " |
| 533 | "Git revisions." % (chrome_rev,) |
| 534 | ) |
| 535 | version_to_uprev = options.force_version |
| 536 | else: |
| 537 | version_to_uprev = GetLatestRelease(options.chrome_url) |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 538 | else: |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 539 | sticky_ebuild = _GetStickyEBuild(stable_ebuilds) |
| 540 | sticky_version = sticky_ebuild.chrome_version |
| 541 | sticky_branch = sticky_version.rpartition(".")[0] |
| 542 | version_to_uprev = GetLatestRelease(options.chrome_url, sticky_branch) |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 543 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 544 | stable_candidate = FindChromeUprevCandidate( |
| 545 | stable_ebuilds, chrome_rev, sticky_branch |
| 546 | ) |
| 547 | |
| 548 | if stable_candidate: |
| 549 | logging.info("Stable candidate found %s", stable_candidate) |
David James | fb16001 | 2014-07-01 10:00:57 -0700 | [diff] [blame] | 550 | else: |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 551 | logging.info("No stable candidate found.") |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 552 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 553 | tracking_branch = "remotes/m/%s" % os.path.basename(options.tracking_branch) |
| 554 | existing_branch = git.GetCurrentBranch(chrome_package_dir) |
| 555 | work_branch = cros_mark_as_stable.GitBranch( |
| 556 | constants.STABLE_EBUILD_BRANCH, tracking_branch, chrome_package_dir |
| 557 | ) |
| 558 | work_branch.CreateBranch() |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 559 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 560 | # In the case of uprevving overlays that have patches applied to them, |
| 561 | # include the patched changes in the stabilizing branch. |
| 562 | if existing_branch: |
| 563 | git.RunGit(chrome_package_dir, ["rebase", existing_branch]) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 564 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 565 | chrome_version_atom = MarkChromeEBuildAsStable( |
| 566 | stable_candidate, |
| 567 | unstable_ebuild, |
| 568 | "chromeos-chrome", |
| 569 | chrome_rev, |
| 570 | version_to_uprev, |
| 571 | chrome_package_dir, |
| 572 | ) |
| 573 | if chrome_version_atom: |
| 574 | if options.boards: |
| 575 | cros_mark_as_stable.CleanStalePackages( |
| 576 | options.srcroot, |
| 577 | options.boards.split(":"), |
| 578 | [chrome_version_atom], |
| 579 | ) |
David James | d6708c0 | 2012-03-22 10:49:15 -0700 | [diff] [blame] | 580 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 581 | # If we did rev Chrome, now is a good time to uprev other packages. |
| 582 | for other_ebuild in constants.OTHER_CHROME_PACKAGES: |
| 583 | other_ebuild_name = os.path.basename(other_ebuild) |
| 584 | other_package_dir = os.path.join(overlay_dir, other_ebuild) |
| 585 | ( |
| 586 | other_unstable_ebuild, |
| 587 | other_stable_ebuilds, |
| 588 | ) = FindChromeCandidates(other_package_dir) |
| 589 | other_stable_candidate = FindChromeUprevCandidate( |
| 590 | other_stable_ebuilds, chrome_rev, sticky_branch |
| 591 | ) |
| 592 | revved_atom = MarkChromeEBuildAsStable( |
| 593 | other_stable_candidate, |
| 594 | other_unstable_ebuild, |
| 595 | other_ebuild_name, |
| 596 | chrome_rev, |
| 597 | version_to_uprev, |
| 598 | other_package_dir, |
| 599 | ) |
| 600 | if revved_atom and options.boards: |
| 601 | cros_mark_as_stable.CleanStalePackages( |
| 602 | options.srcroot, options.boards.split(":"), [revved_atom] |
| 603 | ) |
David James | d6708c0 | 2012-03-22 10:49:15 -0700 | [diff] [blame] | 604 | |
Alex Klein | 1699fab | 2022-09-08 08:46:06 -0600 | [diff] [blame] | 605 | # Explicit print to communicate to caller. |
| 606 | if chrome_version_atom: |
| 607 | print("CHROME_VERSION_ATOM=%s" % chrome_version_atom) |