Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 1 | #!/usr/bin/python |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """This module uprevs Chrome for cbuildbot. |
| 7 | |
| 8 | After calling, it prints outs CHROME_VERSION_ATOM=(version atom string). A |
| 9 | caller could then use this atom with emerge to build the newly uprevved version |
| 10 | of Chrome e.g. |
| 11 | |
| 12 | ./cros_mark_chrome_as_stable tot |
| 13 | Returns chrome-base/chromeos-chrome-8.0.552.0_alpha_r1 |
| 14 | |
| 15 | emerge-x86-generic =chrome-base/chromeos-chrome-8.0.552.0_alpha_r1 |
| 16 | """ |
| 17 | |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 18 | import filecmp |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 19 | import optparse |
| 20 | import os |
| 21 | import re |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 22 | import sys |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 23 | import time |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 24 | |
Don Garrett | 88b8d78 | 2014-05-13 17:30:55 -0700 | [diff] [blame] | 25 | from chromite.cbuildbot import constants |
| 26 | from chromite.cbuildbot import portage_utilities |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 27 | from chromite.lib import cros_build_lib |
David James | ef74b1c | 2012-11-12 07:47:47 -0800 | [diff] [blame] | 28 | from chromite.lib import gclient |
David James | 97d9587 | 2012-11-16 15:09:56 -0800 | [diff] [blame] | 29 | from chromite.lib import git |
Mike Frysinger | 6cb624a | 2012-05-24 18:17:38 -0400 | [diff] [blame] | 30 | from chromite.scripts import cros_mark_as_stable |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 31 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 32 | # Helper regex's for finding ebuilds. |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 33 | _CHROME_VERSION_REGEX = r'\d+\.\d+\.\d+\.\d+' |
| 34 | _NON_STICKY_REGEX = r'%s[(_rc.*)|(_alpha.*)]+' % _CHROME_VERSION_REGEX |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 35 | |
| 36 | # Dir where all the action happens. |
David James | 629febb | 2012-11-25 13:07:34 -0800 | [diff] [blame] | 37 | _CHROME_OVERLAY_DIR = ('%(srcroot)s/third_party/chromiumos-overlay/' + |
| 38 | constants.CHROME_CP) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 39 | |
| 40 | _GIT_COMMIT_MESSAGE = ('Marking %(chrome_rev)s for chrome ebuild with version ' |
| 41 | '%(chrome_version)s as stable.') |
| 42 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 43 | # URLs that print lists of chrome revisions between two versions of the browser. |
| 44 | _CHROME_VERSION_URL = ('http://omahaproxy.appspot.com/changelog?' |
| 45 | 'old_version=%(old)s&new_version=%(new)s') |
Chris Sosa | dd611df | 2012-02-03 15:26:23 -0800 | [diff] [blame] | 46 | |
| 47 | # Only print links when we rev these types. |
| 48 | _REV_TYPES_FOR_LINKS = [constants.CHROME_REV_LATEST, |
| 49 | constants.CHROME_REV_STICKY] |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 50 | |
| 51 | _CHROME_SVN_TAG = 'CROS_SVN_COMMIT' |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 52 | |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 53 | |
Peter Mayo | f65b841 | 2011-08-26 01:22:21 -0400 | [diff] [blame] | 54 | def _GetSvnUrl(base_url): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 55 | """Returns the path to the svn url for the given chrome branch.""" |
Peter Mayo | f65b841 | 2011-08-26 01:22:21 -0400 | [diff] [blame] | 56 | return os.path.join(base_url, 'trunk') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 57 | |
| 58 | |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 59 | def _GetVersionContents(chrome_version_info): |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 60 | """Returns the current Chromium version, from the contents of a VERSION file. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 61 | |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 62 | Args: |
| 63 | chrome_version_info: The contents of a chromium VERSION file. |
| 64 | """ |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 65 | chrome_version_array = [] |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 66 | for line in chrome_version_info.splitlines(): |
| 67 | chrome_version_array.append(line.rpartition('=')[2]) |
| 68 | |
| 69 | return '.'.join(chrome_version_array) |
| 70 | |
Mike Frysinger | cc83883 | 2014-05-24 13:10:30 -0400 | [diff] [blame] | 71 | |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 72 | def _GetSpecificVersionUrl(base_url, revision, time_to_wait=600): |
| 73 | """Returns the Chromium version, from a repository URL and version. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 74 | |
| 75 | Args: |
| 76 | base_url: URL for the root of the chromium checkout. |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 77 | revision: the SVN revision we want to use. |
| 78 | time_to_wait: the minimum period before abandoning our wait for the |
| 79 | desired revision to be present. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 80 | """ |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 81 | svn_url = os.path.join(_GetSvnUrl(base_url), 'src', 'chrome', 'VERSION') |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 82 | if not revision or not (int(revision) > 0): |
| 83 | raise Exception('Revision must be positive, got %s' % revision) |
| 84 | |
| 85 | start = time.time() |
| 86 | # Use the fact we are SVN, hence ordered. |
| 87 | # Dodge the fact it will silently ignore the revision if it is not |
| 88 | # yet known. (i.e. too high) |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 89 | repo_version = gclient.GetTipOfTrunkSvnRevision(base_url) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 90 | while revision > repo_version: |
| 91 | if time.time() - start > time_to_wait: |
| 92 | raise Exception('Timeout Exceeeded') |
| 93 | |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 94 | msg = 'Repository only has version %s, looking for %s. Sleeping...' |
| 95 | cros_build_lib.Info(msg, repo_version, revision) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 96 | time.sleep(30) |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 97 | repo_version = gclient.GetTipOfTrunkSvnRevision(base_url) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 98 | |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 99 | chrome_version_info = cros_build_lib.RunCommand( |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 100 | ['svn', 'cat', '-r', revision, svn_url], |
| 101 | redirect_stdout=True, |
| 102 | error_message='Could not read version file at %s revision %s.' % |
J. Richard Barnette | d422f62 | 2011-11-17 09:39:46 -0800 | [diff] [blame] | 103 | (svn_url, revision)).output |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 104 | |
| 105 | return _GetVersionContents(chrome_version_info) |
| 106 | |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 107 | |
| 108 | def _GetTipOfTrunkVersionFile(root): |
| 109 | """Returns the current Chromium version, from a file in a checkout. |
| 110 | |
| 111 | Args: |
| 112 | root: path to the root of the chromium checkout. |
| 113 | """ |
| 114 | version_file = os.path.join(root, 'src', 'chrome', 'VERSION') |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 115 | chrome_version_info = cros_build_lib.RunCommand( |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 116 | ['cat', version_file], |
| 117 | redirect_stdout=True, |
J. Richard Barnette | d422f62 | 2011-11-17 09:39:46 -0800 | [diff] [blame] | 118 | error_message='Could not read version file at %s.' % version_file).output |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 119 | |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 120 | return _GetVersionContents(chrome_version_info) |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 121 | |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 122 | |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame^] | 123 | def CheckIfChromeRightForOS(url): |
| 124 | """Checks if DEPS is right for Chrome OS. |
| 125 | |
| 126 | This function checks for a variable called 'buildspec_platforms' to |
| 127 | find out if its 'chromeos' or 'all'. If any of those values, |
| 128 | then it chooses that DEPS. |
| 129 | |
| 130 | Args: |
| 131 | url: url where DEPS file present. |
| 132 | |
| 133 | Returns: |
| 134 | True if DEPS is the right Chrome for Chrome OS. |
| 135 | """ |
| 136 | deps_contents = cros_build_lib.RunCommand(['svn', 'cat', url], |
| 137 | redirect_stdout=True).output |
| 138 | platforms = re.search(r'buildspec_platforms.*\s.*\s', deps_contents).group() |
| 139 | |
| 140 | if 'chromeos' in platforms or 'all' in platforms: |
| 141 | return True |
| 142 | |
| 143 | return False |
| 144 | |
| 145 | |
Yu-Ju Hong | 3980632 | 2014-06-24 16:46:32 -0700 | [diff] [blame] | 146 | def GetLatestRelease(base_url, branch=None): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 147 | """Gets the latest release version from the buildspec_url for the branch. |
| 148 | |
| 149 | Args: |
Don Garrett | 25f309a | 2014-03-19 14:02:12 -0700 | [diff] [blame] | 150 | base_url: Base URL for the SVN repository. |
Mike Frysinger | ad8c6ca | 2014-02-03 11:28:45 -0500 | [diff] [blame] | 151 | branch: If set, gets the latest release for branch, otherwise latest |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 152 | release. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 153 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 154 | Returns: |
| 155 | Latest version string. |
| 156 | """ |
Peter Mayo | f65b841 | 2011-08-26 01:22:21 -0400 | [diff] [blame] | 157 | buildspec_url = os.path.join(base_url, 'releases') |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 158 | svn_ls = cros_build_lib.RunCommand(['svn', 'ls', buildspec_url], |
| 159 | redirect_stdout=True).output |
| 160 | sorted_ls = cros_build_lib.RunCommand(['sort', '--version-sort', '-r'], |
| 161 | input=svn_ls, |
| 162 | redirect_stdout=True).output |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 163 | if branch: |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 164 | chrome_version_re = re.compile(r'^%s\.\d+.*' % branch) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 165 | else: |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 166 | chrome_version_re = re.compile(r'^[0-9]+\..*') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 167 | |
Peter Mayo | ad8173d | 2011-11-08 16:18:23 -0500 | [diff] [blame] | 168 | for chrome_version in sorted_ls.splitlines(): |
J. Richard Barnette | d422f62 | 2011-11-17 09:39:46 -0800 | [diff] [blame] | 169 | if chrome_version_re.match(chrome_version): |
| 170 | deps_url = os.path.join(buildspec_url, chrome_version, 'DEPS') |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 171 | deps_check = cros_build_lib.RunCommand(['svn', 'ls', deps_url], |
| 172 | error_code_ok=True, |
| 173 | redirect_stdout=True).output |
J. Richard Barnette | d422f62 | 2011-11-17 09:39:46 -0800 | [diff] [blame] | 174 | if deps_check == 'DEPS\n': |
Dharani Govindan | 4beb94c | 2014-07-18 13:31:47 -0700 | [diff] [blame^] | 175 | if CheckIfChromeRightForOS(deps_url): |
| 176 | return chrome_version.rstrip('/') |
Peter Mayo | ad8173d | 2011-11-08 16:18:23 -0500 | [diff] [blame] | 177 | |
| 178 | return None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 179 | |
| 180 | |
| 181 | def _GetStickyEBuild(stable_ebuilds): |
| 182 | """Returns the sticky ebuild.""" |
| 183 | sticky_ebuilds = [] |
| 184 | non_sticky_re = re.compile(_NON_STICKY_REGEX) |
| 185 | for ebuild in stable_ebuilds: |
| 186 | if not non_sticky_re.match(ebuild.version): |
| 187 | sticky_ebuilds.append(ebuild) |
| 188 | |
| 189 | if not sticky_ebuilds: |
| 190 | raise Exception('No sticky ebuilds found') |
| 191 | elif len(sticky_ebuilds) > 1: |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 192 | cros_build_lib.Warning('More than one sticky ebuild found') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 193 | |
J. Richard Barnette | f6697cf | 2011-11-18 12:42:08 -0800 | [diff] [blame] | 194 | return portage_utilities.BestEBuild(sticky_ebuilds) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 195 | |
| 196 | |
J. Richard Barnette | f6697cf | 2011-11-18 12:42:08 -0800 | [diff] [blame] | 197 | class ChromeEBuild(portage_utilities.EBuild): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 198 | """Thin sub-class of EBuild that adds a chrome_version field.""" |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 199 | chrome_version_re = re.compile(r'.*%s-(%s|9999).*' % ( |
David James | 629febb | 2012-11-25 13:07:34 -0800 | [diff] [blame] | 200 | constants.CHROME_PN, _CHROME_VERSION_REGEX)) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 201 | chrome_version = '' |
| 202 | |
| 203 | def __init__(self, path): |
J. Richard Barnette | f6697cf | 2011-11-18 12:42:08 -0800 | [diff] [blame] | 204 | portage_utilities.EBuild.__init__(self, path) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 205 | re_match = self.chrome_version_re.match(self.ebuild_path_no_revision) |
| 206 | if re_match: |
| 207 | self.chrome_version = re_match.group(1) |
| 208 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 209 | def __str__(self): |
| 210 | return self.ebuild_path |
| 211 | |
| 212 | |
| 213 | def FindChromeCandidates(overlay_dir): |
| 214 | """Return a tuple of chrome's unstable ebuild and stable ebuilds. |
| 215 | |
| 216 | Args: |
| 217 | overlay_dir: The path to chrome's portage overlay dir. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 218 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 219 | Returns: |
| 220 | Tuple [unstable_ebuild, stable_ebuilds]. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 221 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 222 | Raises: |
| 223 | Exception: if no unstable ebuild exists for Chrome. |
| 224 | """ |
| 225 | stable_ebuilds = [] |
| 226 | unstable_ebuilds = [] |
| 227 | for path in [ |
| 228 | os.path.join(overlay_dir, entry) for entry in os.listdir(overlay_dir)]: |
| 229 | if path.endswith('.ebuild'): |
| 230 | ebuild = ChromeEBuild(path) |
| 231 | if not ebuild.chrome_version: |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 232 | cros_build_lib.Warning('Poorly formatted ebuild found at %s' % path) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 233 | else: |
| 234 | if '9999' in ebuild.version: |
| 235 | unstable_ebuilds.append(ebuild) |
| 236 | else: |
| 237 | stable_ebuilds.append(ebuild) |
| 238 | |
| 239 | # Apply some sanity checks. |
| 240 | if not unstable_ebuilds: |
| 241 | raise Exception('Missing 9999 ebuild for %s' % overlay_dir) |
| 242 | if not stable_ebuilds: |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 243 | cros_build_lib.Warning('Missing stable ebuild for %s' % overlay_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 244 | |
J. Richard Barnette | f6697cf | 2011-11-18 12:42:08 -0800 | [diff] [blame] | 245 | return portage_utilities.BestEBuild(unstable_ebuilds), stable_ebuilds |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 246 | |
| 247 | |
| 248 | def FindChromeUprevCandidate(stable_ebuilds, chrome_rev, sticky_branch): |
| 249 | """Finds the Chrome uprev candidate for the given chrome_rev. |
| 250 | |
| 251 | Using the pre-flight logic, this means the stable ebuild you are uprevving |
| 252 | from. The difference here is that the version could be different and in |
| 253 | that case we want to find it to delete it. |
| 254 | |
| 255 | Args: |
| 256 | stable_ebuilds: A list of stable ebuilds. |
| 257 | chrome_rev: The chrome_rev designating which candidate to find. |
Mike Frysinger | ad8c6ca | 2014-02-03 11:28:45 -0500 | [diff] [blame] | 258 | sticky_branch: The the branch that is currently sticky with Major/Minor |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 259 | components. For example: 9.0.553. Can be None but not if chrome_rev |
| 260 | is CHROME_REV_STICKY. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 261 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 262 | Returns: |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 263 | The EBuild, otherwise None if none found. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 264 | """ |
| 265 | candidates = [] |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 266 | if chrome_rev in [constants.CHROME_REV_LOCAL, constants.CHROME_REV_TOT, |
| 267 | constants.CHROME_REV_SPEC]: |
| 268 | # These are labelled alpha, for historic reasons, |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 269 | # not just for the fun of confusion. |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 270 | chrome_branch_re = re.compile(r'%s.*_alpha.*' % _CHROME_VERSION_REGEX) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 271 | for ebuild in stable_ebuilds: |
| 272 | if chrome_branch_re.search(ebuild.version): |
| 273 | candidates.append(ebuild) |
| 274 | |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 275 | elif chrome_rev == constants.CHROME_REV_STICKY: |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 276 | assert sticky_branch is not None |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 277 | chrome_branch_re = re.compile(r'%s\..*' % sticky_branch) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 278 | for ebuild in stable_ebuilds: |
| 279 | if chrome_branch_re.search(ebuild.version): |
| 280 | candidates.append(ebuild) |
| 281 | |
| 282 | else: |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 283 | chrome_branch_re = re.compile(r'%s.*_rc.*' % _CHROME_VERSION_REGEX) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 284 | for ebuild in stable_ebuilds: |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 285 | if chrome_branch_re.search(ebuild.version): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 286 | candidates.append(ebuild) |
| 287 | |
| 288 | if candidates: |
J. Richard Barnette | f6697cf | 2011-11-18 12:42:08 -0800 | [diff] [blame] | 289 | return portage_utilities.BestEBuild(candidates) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 290 | else: |
| 291 | return None |
| 292 | |
Mike Frysinger | cc83883 | 2014-05-24 13:10:30 -0400 | [diff] [blame] | 293 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 294 | def _AnnotateAndPrint(text, url): |
| 295 | """Add buildbot trappings to print <a href='url'>text</a> in the waterfall. |
| 296 | |
| 297 | Args: |
| 298 | text: Anchor text for the link |
| 299 | url: the URL to which to link |
| 300 | """ |
Don Garrett | e60de90 | 2011-10-17 18:52:05 -0700 | [diff] [blame] | 301 | print >> sys.stderr, '\n@@@STEP_LINK@%(text)s@%(url)s@@@' % { 'text': text, |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 302 | 'url': url } |
| 303 | |
| 304 | def GetChromeRevisionLinkFromVersions(old_chrome_version, chrome_version): |
| 305 | """Return appropriately formatted link to revision info, given versions |
| 306 | |
| 307 | Given two chrome version strings (e.g. 9.0.533.0), generate a link to a |
| 308 | page that prints the Chromium revisions between those two versions. |
| 309 | |
| 310 | Args: |
| 311 | old_chrome_version: version to diff from |
| 312 | chrome_version: version to which to diff |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 313 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 314 | Returns: |
| 315 | The desired URL. |
| 316 | """ |
| 317 | return _CHROME_VERSION_URL % { 'old': old_chrome_version, |
| 318 | 'new': chrome_version } |
| 319 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 320 | def GetChromeRevisionListLink(old_chrome, new_chrome, chrome_rev): |
| 321 | """Returns a link to the list of revisions between two Chromium versions |
| 322 | |
| 323 | Given two ChromeEBuilds and the kind of rev we're doing, generate a |
| 324 | link to a page that prints the Chromium changes between those two |
| 325 | revisions, inclusive. |
| 326 | |
| 327 | Args: |
| 328 | old_chrome: ebuild for the version to diff from |
| 329 | new_chrome: ebuild for the version to which to diff |
| 330 | chrome_rev: one of constants.VALID_CHROME_REVISIONS |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 331 | |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 332 | Returns: |
| 333 | The desired URL. |
| 334 | """ |
Chris Sosa | dd611df | 2012-02-03 15:26:23 -0800 | [diff] [blame] | 335 | assert chrome_rev in _REV_TYPES_FOR_LINKS |
| 336 | return GetChromeRevisionLinkFromVersions(old_chrome.chrome_version, |
| 337 | new_chrome.chrome_version) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 338 | |
Mike Frysinger | cc83883 | 2014-05-24 13:10:30 -0400 | [diff] [blame] | 339 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 340 | def MarkChromeEBuildAsStable(stable_candidate, unstable_ebuild, chrome_rev, |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 341 | chrome_version, commit, overlay_dir): |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 342 | r"""Uprevs the chrome ebuild specified by chrome_rev. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 343 | |
| 344 | This is the main function that uprevs the chrome_rev from a stable candidate |
| 345 | to its new version. |
| 346 | |
| 347 | Args: |
| 348 | stable_candidate: ebuild that corresponds to the stable ebuild we are |
| 349 | revving from. If None, builds the a new ebuild given the version |
| 350 | and logic for chrome_rev type with revision set to 1. |
Mike Frysinger | ad8c6ca | 2014-02-03 11:28:45 -0500 | [diff] [blame] | 351 | unstable_ebuild: ebuild corresponding to the unstable ebuild for chrome. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 352 | chrome_rev: one of constants.VALID_CHROME_REVISIONS or LOCAL |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 353 | constants.CHROME_REV_SPEC - Requires commit value. Revs the ebuild for |
| 354 | the specified version and uses the portage suffix of _alpha. |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 355 | constants.CHROME_REV_TOT - Requires commit value. Revs the ebuild for |
| 356 | the TOT version and uses the portage suffix of _alpha. |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 357 | constants.CHROME_REV_LOCAL - Requires a chrome_root. Revs the ebuild for |
| 358 | the local version and uses the portage suffix of _alpha. |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 359 | constants.CHROME_REV_LATEST - This uses the portage suffix of _rc as they |
| 360 | are release candidates for the next sticky version. |
| 361 | constants.CHROME_REV_STICKY - Revs the sticky version. |
Mike Frysinger | ad8c6ca | 2014-02-03 11:28:45 -0500 | [diff] [blame] | 362 | chrome_version: The \d.\d.\d.\d version of Chrome. |
| 363 | commit: Used with constants.CHROME_REV_TOT. The svn revision of chrome. |
| 364 | overlay_dir: Path to the chromeos-chrome package dir. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 365 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 366 | Returns: |
| 367 | Full portage version atom (including rc's, etc) that was revved. |
| 368 | """ |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 369 | def IsTheNewEBuildRedundant(new_ebuild, stable_ebuild): |
| 370 | """Returns True if the new ebuild is redundant. |
| 371 | |
| 372 | This is True if there if the current stable ebuild is the exact same copy |
David James | 89608f9 | 2012-11-03 14:14:12 -0700 | [diff] [blame] | 373 | of the new one. |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 374 | """ |
| 375 | if not stable_ebuild: |
| 376 | return False |
| 377 | |
| 378 | if stable_candidate.chrome_version == new_ebuild.chrome_version: |
David James | 89608f9 | 2012-11-03 14:14:12 -0700 | [diff] [blame] | 379 | return filecmp.cmp( |
| 380 | new_ebuild.ebuild_path, stable_ebuild.ebuild_path, shallow=False) |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 381 | |
David James | 629febb | 2012-11-25 13:07:34 -0800 | [diff] [blame] | 382 | # Mark latest release and sticky branches as stable. |
| 383 | mark_stable = chrome_rev not in [constants.CHROME_REV_TOT, |
| 384 | constants.CHROME_REV_SPEC, |
| 385 | constants.CHROME_REV_LOCAL] |
| 386 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 387 | # Case where we have the last stable candidate with same version just rev. |
| 388 | if stable_candidate and stable_candidate.chrome_version == chrome_version: |
| 389 | new_ebuild_path = '%s-r%d.ebuild' % ( |
| 390 | stable_candidate.ebuild_path_no_revision, |
| 391 | stable_candidate.current_revision + 1) |
| 392 | else: |
David James | 629febb | 2012-11-25 13:07:34 -0800 | [diff] [blame] | 393 | suffix = 'rc' if mark_stable else 'alpha' |
| 394 | pf = '%s-%s_%s-r1' % (constants.CHROME_PN, chrome_version, suffix) |
| 395 | new_ebuild_path = os.path.join(overlay_dir, '%s.ebuild' % pf) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 396 | |
David James | a679255 | 2012-04-03 10:05:35 -0700 | [diff] [blame] | 397 | chrome_variables = dict() |
| 398 | if commit: |
| 399 | chrome_variables[_CHROME_SVN_TAG] = commit |
| 400 | |
J. Richard Barnette | 0cfc505 | 2011-11-28 14:31:39 -0800 | [diff] [blame] | 401 | portage_utilities.EBuild.MarkAsStable( |
David James | 065b201 | 2012-04-01 14:51:11 -0700 | [diff] [blame] | 402 | unstable_ebuild.ebuild_path, new_ebuild_path, |
David James | a679255 | 2012-04-03 10:05:35 -0700 | [diff] [blame] | 403 | chrome_variables, make_stable=mark_stable) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 404 | new_ebuild = ChromeEBuild(new_ebuild_path) |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 405 | |
| 406 | # Determine whether this is ebuild is redundant. |
| 407 | if IsTheNewEBuildRedundant(new_ebuild, stable_candidate): |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 408 | msg = 'Previous ebuild with same version found and ebuild is redundant.' |
| 409 | cros_build_lib.Info(msg) |
Chris Sosa | 8be3913 | 2011-04-14 12:09:24 -0700 | [diff] [blame] | 410 | os.unlink(new_ebuild_path) |
| 411 | return None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 412 | |
Chris Sosa | dd611df | 2012-02-03 15:26:23 -0800 | [diff] [blame] | 413 | if stable_candidate and chrome_rev in _REV_TYPES_FOR_LINKS: |
Chris Masone | 592cab5 | 2011-08-02 14:05:48 -0700 | [diff] [blame] | 414 | _AnnotateAndPrint('Chromium revisions', |
| 415 | GetChromeRevisionListLink(stable_candidate, |
| 416 | new_ebuild, |
| 417 | chrome_rev)) |
| 418 | |
David James | 67d7325 | 2013-09-19 17:33:12 -0700 | [diff] [blame] | 419 | git.RunGit(overlay_dir, ['add', new_ebuild_path]) |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 420 | if stable_candidate and not stable_candidate.IsSticky(): |
David James | 67d7325 | 2013-09-19 17:33:12 -0700 | [diff] [blame] | 421 | git.RunGit(overlay_dir, ['rm', stable_candidate.ebuild_path]) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 422 | |
J. Richard Barnette | 0cfc505 | 2011-11-28 14:31:39 -0800 | [diff] [blame] | 423 | portage_utilities.EBuild.CommitChange( |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 424 | _GIT_COMMIT_MESSAGE % {'chrome_rev': chrome_rev, |
Mike Frysinger | 2ebe373 | 2012-05-08 17:04:12 -0400 | [diff] [blame] | 425 | 'chrome_version': chrome_version}, |
| 426 | overlay_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 427 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 428 | return '%s-%s' % (new_ebuild.package, new_ebuild.version) |
| 429 | |
| 430 | |
Chris Sosa | d53f8fd | 2011-10-21 15:15:19 -0700 | [diff] [blame] | 431 | def ParseMaxRevision(revision_list): |
| 432 | """Returns the max revision from a list of url@revision string.""" |
David James | 7c352bc | 2013-03-15 14:19:57 -0700 | [diff] [blame] | 433 | revision_re = re.compile(r'.*@(\d+)') |
Chris Sosa | d53f8fd | 2011-10-21 15:15:19 -0700 | [diff] [blame] | 434 | |
| 435 | def RevisionKey(revision): |
| 436 | return revision_re.match(revision).group(1) |
| 437 | |
| 438 | max_revision = max(revision_list.split(), key=RevisionKey) |
| 439 | return max_revision.rpartition('@')[2] |
| 440 | |
| 441 | |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 442 | def main(_argv): |
Chris Sosa | 0f295aa | 2011-10-21 14:10:28 -0700 | [diff] [blame] | 443 | usage_options = '|'.join(constants.VALID_CHROME_REVISIONS) |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 444 | usage = '%s OPTIONS [%s]' % (__file__, usage_options) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 445 | parser = optparse.OptionParser(usage) |
David James | cc09c9b | 2012-01-26 22:10:13 -0800 | [diff] [blame] | 446 | parser.add_option('-b', '--boards', default='x86-generic') |
David James | ef74b1c | 2012-11-12 07:47:47 -0800 | [diff] [blame] | 447 | parser.add_option('-c', '--chrome_url', default=gclient.GetBaseURLs()[0]) |
David James | fb16001 | 2014-07-01 10:00:57 -0700 | [diff] [blame] | 448 | parser.add_option('-f', '--force_version', default=None, |
| 449 | help='Chrome version or SVN revision number to use') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 450 | parser.add_option('-s', '--srcroot', default=os.path.join(os.environ['HOME'], |
| 451 | 'trunk', 'src'), |
| 452 | help='Path to the src directory') |
| 453 | parser.add_option('-t', '--tracking_branch', default='cros/master', |
| 454 | help='Branch we are tracking changes against') |
| 455 | (options, args) = parser.parse_args() |
| 456 | |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 457 | if len(args) != 1 or args[0] not in constants.VALID_CHROME_REVISIONS: |
| 458 | parser.error('Commit requires arg set to one of %s.' |
| 459 | % constants.VALID_CHROME_REVISIONS) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 460 | |
David James | 9a5980e | 2014-07-16 09:37:00 -0700 | [diff] [blame] | 461 | if options.force_version and args[0] not in (constants.CHROME_REV_SPEC, |
| 462 | constants.CHROME_REV_LATEST): |
David James | fb16001 | 2014-07-01 10:00:57 -0700 | [diff] [blame] | 463 | parser.error('--force_version is not compatible with the %r ' |
| 464 | 'option.' % (args[0],)) |
| 465 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 466 | overlay_dir = os.path.abspath(_CHROME_OVERLAY_DIR % |
| 467 | {'srcroot': options.srcroot}) |
| 468 | chrome_rev = args[0] |
| 469 | version_to_uprev = None |
| 470 | commit_to_use = None |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 471 | sticky_branch = None |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 472 | |
| 473 | (unstable_ebuild, stable_ebuilds) = FindChromeCandidates(overlay_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 474 | |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 475 | if chrome_rev == constants.CHROME_REV_LOCAL: |
| 476 | if 'CHROME_ROOT' in os.environ: |
| 477 | chrome_root = os.environ['CHROME_ROOT'] |
| 478 | else: |
| 479 | chrome_root = os.path.join(os.environ['HOME'], 'chrome_root') |
| 480 | |
| 481 | version_to_uprev = _GetTipOfTrunkVersionFile(chrome_root) |
| 482 | commit_to_use = 'Unknown' |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 483 | cros_build_lib.Info('Using local source, versioning is untrustworthy.') |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 484 | elif chrome_rev == constants.CHROME_REV_SPEC: |
David James | fb16001 | 2014-07-01 10:00:57 -0700 | [diff] [blame] | 485 | if '.' in options.force_version: |
| 486 | version_to_uprev = options.force_version |
| 487 | else: |
| 488 | commit_to_use = options.force_version |
| 489 | if '@' in commit_to_use: |
| 490 | commit_to_use = ParseMaxRevision(commit_to_use) |
| 491 | version_to_uprev = _GetSpecificVersionUrl(options.chrome_url, |
| 492 | commit_to_use) |
Peter Mayo | 177500f | 2011-09-09 17:25:23 -0400 | [diff] [blame] | 493 | elif chrome_rev == constants.CHROME_REV_TOT: |
ChromeOS Developer | 03118eb | 2013-02-12 14:27:09 -0800 | [diff] [blame] | 494 | commit_to_use = gclient.GetTipOfTrunkSvnRevision(options.chrome_url) |
petermayo@chromium.org | 163b337 | 2011-09-12 02:06:05 -0400 | [diff] [blame] | 495 | version_to_uprev = _GetSpecificVersionUrl(options.chrome_url, |
| 496 | commit_to_use) |
Ryan Cui | c6e097d | 2011-06-16 12:23:14 -0700 | [diff] [blame] | 497 | elif chrome_rev == constants.CHROME_REV_LATEST: |
David James | 9a5980e | 2014-07-16 09:37:00 -0700 | [diff] [blame] | 498 | if options.force_version: |
| 499 | if '.' not in options.force_version: |
| 500 | parser.error('%s only accepts released Chrome versions, not SVN or ' |
| 501 | 'Git revisions.' % (chrome_rev,)) |
| 502 | version_to_uprev = options.force_version |
| 503 | else: |
| 504 | version_to_uprev = GetLatestRelease(options.chrome_url) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 505 | else: |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 506 | sticky_ebuild = _GetStickyEBuild(stable_ebuilds) |
| 507 | sticky_version = sticky_ebuild.chrome_version |
| 508 | sticky_branch = sticky_version.rpartition('.')[0] |
Yu-Ju Hong | 3980632 | 2014-06-24 16:46:32 -0700 | [diff] [blame] | 509 | version_to_uprev = GetLatestRelease(options.chrome_url, sticky_branch) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 510 | |
| 511 | stable_candidate = FindChromeUprevCandidate(stable_ebuilds, chrome_rev, |
| 512 | sticky_branch) |
| 513 | |
| 514 | if stable_candidate: |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 515 | cros_build_lib.Info('Stable candidate found %s' % stable_candidate) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 516 | else: |
David James | 1b36358 | 2012-12-17 11:53:11 -0800 | [diff] [blame] | 517 | cros_build_lib.Info('No stable candidate found.') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 518 | |
Chris Sosa | 8049f3b | 2011-05-02 20:09:28 -0700 | [diff] [blame] | 519 | tracking_branch = 'remotes/m/%s' % os.path.basename(options.tracking_branch) |
David James | 97d9587 | 2012-11-16 15:09:56 -0800 | [diff] [blame] | 520 | existing_branch = git.GetCurrentBranch(overlay_dir) |
Ryan Cui | 05a31ba | 2011-05-31 17:47:37 -0700 | [diff] [blame] | 521 | work_branch = cros_mark_as_stable.GitBranch(constants.STABLE_EBUILD_BRANCH, |
Mike Frysinger | 2ebe373 | 2012-05-08 17:04:12 -0400 | [diff] [blame] | 522 | tracking_branch, overlay_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 523 | work_branch.CreateBranch() |
David James | d6708c0 | 2012-03-22 10:49:15 -0700 | [diff] [blame] | 524 | |
| 525 | # In the case of uprevving overlays that have patches applied to them, |
| 526 | # include the patched changes in the stabilizing branch. |
| 527 | if existing_branch: |
David James | 67d7325 | 2013-09-19 17:33:12 -0700 | [diff] [blame] | 528 | git.RunGit(overlay_dir, ['rebase', existing_branch]) |
David James | d6708c0 | 2012-03-22 10:49:15 -0700 | [diff] [blame] | 529 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 530 | chrome_version_atom = MarkChromeEBuildAsStable( |
| 531 | stable_candidate, unstable_ebuild, chrome_rev, version_to_uprev, |
Chris Sosa | 9ba4775 | 2012-02-27 15:27:37 -0800 | [diff] [blame] | 532 | commit_to_use, overlay_dir) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 533 | # Explicit print to communicate to caller. |
| 534 | if chrome_version_atom: |
David James | cc09c9b | 2012-01-26 22:10:13 -0800 | [diff] [blame] | 535 | cros_mark_as_stable.CleanStalePackages(options.boards.split(':'), |
| 536 | [chrome_version_atom]) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 537 | print 'CHROME_VERSION_ATOM=%s' % chrome_version_atom |