blob: 39794a818fa0ac223917fc4735e0f65f188947ed [file] [log] [blame]
chrisha@chromium.orgc920ad22012-02-02 18:26:04 +00001# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.org3d235242009-05-15 12:40:48 +00002# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Top-level presubmit script for depot tools.
6
7See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
maruel@chromium.org2a74d372011-03-29 19:05:50 +00008details on the presubmit API built into depot_tools.
maruel@chromium.org3d235242009-05-15 12:40:48 +00009"""
10
dpranke@chromium.org627ea672011-03-11 23:29:03 +000011
maruel@chromium.orgd52417c2011-09-02 20:13:17 +000012def CommonChecks(input_api, output_api, tests_to_black_list):
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000013 results = []
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000014 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000015 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
maruel@chromium.org5d0dc432011-01-03 02:40:37 +000016 r'^cpplint\.py$',
asvitkine@chromium.org63c2c1d2011-09-07 21:41:55 +000017 r'^cpplint_chromium\.py$',
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000018 r'^python_bin[\/\\].+',
chrisha@chromium.orgc920ad22012-02-02 18:26:04 +000019 r'^site-packages-py[0-9]\.[0-9][\/\\].+',
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000020 r'^svn_bin[\/\\].+',
maruel@chromium.org0927b7e2011-11-11 16:06:22 +000021 r'^testing_support[\/\\]_rietveld[\/\\].+']
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000022 results.extend(input_api.canned_checks.RunPylint(
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000023 input_api,
24 output_api,
maruel@chromium.org57e48b82011-06-15 17:34:59 +000025 white_list=[r'.*\.py$'],
maruel@chromium.orgbf38a7e2010-12-14 18:15:54 +000026 black_list=black_list))
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000027
28 # TODO(maruel): Make sure at least one file is modified first.
29 # TODO(maruel): If only tests are modified, only run them.
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000030 results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
31 input_api,
32 output_api,
33 'tests',
maruel@chromium.orgfae707b2011-09-15 18:57:58 +000034 whitelist=[r'.*test\.py$'],
maruel@chromium.orgd52417c2011-09-02 20:13:17 +000035 blacklist=tests_to_black_list))
maruel@chromium.org3c9f7ca2011-04-01 14:52:38 +000036 return results
maruel@chromium.org2a74d372011-03-29 19:05:50 +000037
38
maruel@chromium.org899e1c12011-04-07 17:03:18 +000039def RunGitClTests(input_api, output_api):
maruel@chromium.org2a74d372011-03-29 19:05:50 +000040 """Run all the shells scripts in the directory test.
41 """
maruel@chromium.orgc98c0c52011-04-06 13:39:43 +000042 if input_api.platform == 'win32':
43 # Skip for now as long as the test scripts are bash scripts.
44 return []
45
maruel@chromium.org2a74d372011-03-29 19:05:50 +000046 # First loads a local Rietveld instance.
47 import sys
48 old_sys_path = sys.path
49 try:
50 sys.path = [input_api.PresubmitLocalPath()] + sys.path
maruel@chromium.org0927b7e2011-11-11 16:06:22 +000051 from testing_support import local_rietveld
maruel@chromium.org2a74d372011-03-29 19:05:50 +000052 server = local_rietveld.LocalRietveld()
53 finally:
54 sys.path = old_sys_path
55
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000056 results = []
maruel@chromium.org2a74d372011-03-29 19:05:50 +000057 try:
58 # Start a local rietveld instance to test against.
59 server.start_server()
60 test_path = input_api.os_path.abspath(
61 input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'))
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000062 for test in input_api.os_listdir(test_path):
maruel@chromium.org2a74d372011-03-29 19:05:50 +000063 # test-lib.sh is not an actual test so it should not be run. The other
64 # tests are tests known to fail.
65 DISABLED_TESTS = (
66 'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
67 if test in DISABLED_TESTS or not test.endswith('.sh'):
68 continue
69
70 print('Running %s' % test)
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000071 try:
maruel@chromium.org899e1c12011-04-07 17:03:18 +000072 if input_api.verbose:
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000073 input_api.subprocess.check_call(
74 [input_api.os_path.join(test_path, test)], cwd=test_path)
75 else:
76 input_api.subprocess.check_output(
maruel@chromium.org87e6d332011-09-09 19:01:28 +000077 [input_api.os_path.join(test_path, test)], cwd=test_path,
78 stderr=input_api.subprocess.STDOUT)
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000079 except (OSError, input_api.subprocess.CalledProcessError), e:
80 results.append(output_api.PresubmitError('%s failed\n%s' % (test, e)))
maruel@chromium.org2a74d372011-03-29 19:05:50 +000081 except local_rietveld.Failure, e:
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000082 results.append(output_api.PresubmitError('\n'.join(str(i) for i in e.args)))
maruel@chromium.org2a74d372011-03-29 19:05:50 +000083 finally:
84 server.stop_server()
maruel@chromium.orgccbb7812011-04-06 13:36:23 +000085 return results
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000086
87
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000088def CheckChangeOnUpload(input_api, output_api):
maruel@chromium.orgd52417c2011-09-02 20:13:17 +000089 # Do not run integration tests on upload since they are way too slow.
90 tests_to_black_list = [
91 r'^checkout_test\.py$',
92 r'^gclient_smoketest\.py$',
93 r'^scm_unittest\.py$',
94 ]
95 return CommonChecks(input_api, output_api, tests_to_black_list)
maruel@chromium.orge94aedc2010-12-13 21:11:30 +000096
97
maruel@chromium.orgce30ef72009-05-25 15:20:42 +000098def CheckChangeOnCommit(input_api, output_api):
99 output = []
maruel@chromium.orgd52417c2011-09-02 20:13:17 +0000100 output.extend(CommonChecks(input_api, output_api, []))
maruel@chromium.orge94aedc2010-12-13 21:11:30 +0000101 output.extend(input_api.canned_checks.CheckDoNotSubmit(
102 input_api,
103 output_api))
maruel@chromium.orgd52417c2011-09-02 20:13:17 +0000104 output.extend(RunGitClTests(input_api, output_api))
maruel@chromium.org7b305e82009-05-19 18:24:20 +0000105 return output