blob: 0cafc708a38e2e42c35ea045ab792c8660fa28a1 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
14import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000015import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016
17sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
18
19from testing_support.auto_stub import TestCase
20
21import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000022import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000023import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000024import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000025
tandrii5d48c322016-08-18 16:19:37 -070026def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
27 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
28
29
30CERR1 = callError(1)
31
32
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000033class ChangelistMock(object):
34 # A class variable so we can access it when we don't have access to the
35 # instance that's being set.
36 desc = ""
37 def __init__(self, **kwargs):
38 pass
39 def GetIssue(self):
40 return 1
41 def GetDescription(self):
42 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070043 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000044 ChangelistMock.desc = desc
45
tandrii5d48c322016-08-18 16:19:37 -070046
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000047class PresubmitMock(object):
48 def __init__(self, *args, **kwargs):
49 self.reviewers = []
50 @staticmethod
51 def should_continue():
52 return True
53
54
55class RietveldMock(object):
56 def __init__(self, *args, **kwargs):
57 pass
maruel@chromium.org78936cb2013-04-11 00:17:52 +000058
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000059 @staticmethod
60 def get_description(issue):
61 return 'Issue: %d' % issue
62
maruel@chromium.org78936cb2013-04-11 00:17:52 +000063 @staticmethod
64 def get_issue_properties(_issue, _messages):
65 return {
66 'reviewers': ['joe@chromium.org', 'john@chromium.org'],
67 'messages': [
68 {
69 'approval': True,
70 'sender': 'john@chromium.org',
71 },
72 ],
Andrii Shyshkalov06a25022016-11-24 16:47:00 +010073 'patchsets': [1, 20001],
maruel@chromium.org78936cb2013-04-11 00:17:52 +000074 }
75
iannuccie53c9352016-08-17 14:40:40 -070076 @staticmethod
77 def close_issue(_issue):
78 return 'Closed'
79
skobes6468b902016-10-24 08:45:10 -070080 @staticmethod
81 def get_patch(issue, patchset):
82 return 'patch set from issue %s patchset %s' % (issue, patchset)
83
Andrii Shyshkalov06a25022016-11-24 16:47:00 +010084 @staticmethod
85 def update_description(_issue, _description):
86 return 'Updated'
87
88 @staticmethod
89 def add_comment(_issue, _comment):
90 return 'Commented'
91
92
93
skobes6468b902016-10-24 08:45:10 -070094
95class GitCheckoutMock(object):
96 def __init__(self, *args, **kwargs):
97 pass
98
99 @staticmethod
100 def reset():
101 GitCheckoutMock.conflict = False
102
103 def apply_patch(self, p):
104 if GitCheckoutMock.conflict:
105 raise Exception('failed')
106
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000107
108class WatchlistsMock(object):
109 def __init__(self, _):
110 pass
111 @staticmethod
112 def GetWatchersForPaths(_):
113 return ['joe@example.com']
114
115
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000116class CodereviewSettingsFileMock(object):
117 def __init__(self):
118 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800119 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000120 def read(self):
121 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000122 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000123
124
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000125class AuthenticatorMock(object):
126 def __init__(self, *_args):
127 pass
128 def has_cached_credentials(self):
129 return True
tandrii221ab252016-10-06 08:12:04 -0700130 def authorize(self, http):
131 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000132
133
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_cookie=False):
135 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
136
137 Usage:
138 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
139 CookiesAuthenticatorMockFactory({'host1': 'cookie1'}))
140
141 OR
142 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
143 CookiesAuthenticatorMockFactory(cookie='cookie'))
144 """
145 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800146 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000147 # Intentionally not calling super() because it reads actual cookie files.
148 pass
149 @classmethod
150 def get_gitcookies_path(cls):
151 return '~/.gitcookies'
152 @classmethod
153 def get_netrc_path(cls):
154 return '~/.netrc'
155 def get_auth_header(self, host):
156 if same_cookie:
157 return same_cookie
158 return (hosts_with_creds or {}).get(host)
159 return CookiesAuthenticatorMock
160
kmarshall9249e012016-08-23 12:02:16 -0700161class MockChangelistWithBranchAndIssue():
162 def __init__(self, branch, issue):
163 self.branch = branch
164 self.issue = issue
165 def GetBranch(self):
166 return self.branch
167 def GetIssue(self):
168 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000169
tandriic2405f52016-10-10 08:13:15 -0700170
171class SystemExitMock(Exception):
172 pass
173
174
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000175class TestGitClBasic(unittest.TestCase):
176 def _test_ParseIssueUrl(self, func, url, issue, patchset, hostname, fail):
177 parsed = urlparse.urlparse(url)
178 result = func(parsed)
179 if fail:
180 self.assertIsNone(result)
181 return None
182 self.assertIsNotNone(result)
183 self.assertEqual(result.issue, issue)
184 self.assertEqual(result.patchset, patchset)
185 self.assertEqual(result.hostname, hostname)
186 return result
187
188 def test_ParseIssueURL_rietveld(self):
skobes6468b902016-10-24 08:45:10 -0700189 def test(url, issue=None, patchset=None, hostname=None, fail=None):
190 self._test_ParseIssueUrl(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000191 git_cl._RietveldChangelistImpl.ParseIssueURL,
192 url, issue, patchset, hostname, fail)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000193
194 test('http://codereview.chromium.org/123',
195 123, None, 'codereview.chromium.org')
196 test('https://codereview.chromium.org/123',
197 123, None, 'codereview.chromium.org')
198 test('https://codereview.chromium.org/123/',
199 123, None, 'codereview.chromium.org')
200 test('https://codereview.chromium.org/123/whatever',
201 123, None, 'codereview.chromium.org')
wychen3c1c1722016-08-04 11:46:36 -0700202 test('https://codereview.chromium.org/123/#ps20001',
203 123, 20001, 'codereview.chromium.org')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000204 test('http://codereview.chromium.org/download/issue123_4.diff',
skobes6468b902016-10-24 08:45:10 -0700205 123, 4, 'codereview.chromium.org')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000206 # This looks like bad Gerrit, but is actually valid Rietveld.
207 test('https://chrome-review.source.com/123/4/',
208 123, None, 'chrome-review.source.com')
209
210 test('https://codereview.chromium.org/deadbeaf', fail=True)
211 test('https://codereview.chromium.org/api/123', fail=True)
212 test('bad://codereview.chromium.org/123', fail=True)
213 test('http://codereview.chromium.org/download/issue123_4.diffff', fail=True)
214
215 def test_ParseIssueURL_gerrit(self):
216 def test(url, issue=None, patchset=None, hostname=None, fail=None):
217 self._test_ParseIssueUrl(
218 git_cl._GerritChangelistImpl.ParseIssueURL,
219 url, issue, patchset, hostname, fail)
220
221 test('http://chrome-review.source.com/c/123',
222 123, None, 'chrome-review.source.com')
223 test('https://chrome-review.source.com/c/123/',
224 123, None, 'chrome-review.source.com')
225 test('https://chrome-review.source.com/c/123/4',
226 123, 4, 'chrome-review.source.com')
227 test('https://chrome-review.source.com/#/c/123/4',
228 123, 4, 'chrome-review.source.com')
229 test('https://chrome-review.source.com/c/123/4',
230 123, 4, 'chrome-review.source.com')
231 test('https://chrome-review.source.com/123',
232 123, None, 'chrome-review.source.com')
233 test('https://chrome-review.source.com/123/4',
234 123, 4, 'chrome-review.source.com')
235
236 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
237 test('https://chrome-review.source.com/c/abc/', fail=True)
238 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
239
240 def test_ParseIssueNumberArgument(self):
241 def test(arg, issue=None, patchset=None, hostname=None, fail=False):
242 result = git_cl.ParseIssueNumberArgument(arg)
243 self.assertIsNotNone(result)
244 if fail:
245 self.assertFalse(result.valid)
246 else:
247 self.assertEqual(result.issue, issue)
248 self.assertEqual(result.patchset, patchset)
249 self.assertEqual(result.hostname, hostname)
250
251 test('123', 123)
252 test('', fail=True)
253 test('abc', fail=True)
254 test('123/1', fail=True)
255 test('123a', fail=True)
256 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
257 # Rietveld.
258 test('https://codereview.source.com/123',
259 123, None, 'codereview.source.com')
260 test('https://codereview.source.com/www123', fail=True)
261 # Gerrrit.
262 test('https://chrome-review.source.com/c/123/4',
263 123, 4, 'chrome-review.source.com')
264 test('https://chrome-review.source.com/bad/123/4', fail=True)
265
tandriif9aefb72016-07-01 09:06:51 -0700266 def test_get_bug_line_values(self):
267 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
268 self.assertEqual(f('', ''), [])
269 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
270 self.assertEqual(f('v8', '456'), ['v8:456'])
271 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
272 # Not nice, but not worth carying.
273 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
274 ['v8:456', 'chromium:123', 'v8:123'])
275
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100276 def _test_git_number(self, parent_msg, dest_ref, child_msg,
277 parent_hash='parenthash'):
278 desc = git_cl.ChangeDescription(child_msg)
279 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
280 return desc.description
281
282 def assertEqualByLine(self, actual, expected):
283 self.assertEqual(actual.splitlines(), expected.splitlines())
284
285 def test_git_number_bad_parent(self):
286 with self.assertRaises(ValueError):
287 self._test_git_number('Parent', 'refs/heads/master', 'Child')
288
289 def test_git_number_bad_parent_footer(self):
290 with self.assertRaises(AssertionError):
291 self._test_git_number(
292 'Parent\n'
293 '\n'
294 'Cr-Commit-Position: wrong',
295 'refs/heads/master', 'Child')
296
297 def test_git_number_bad_lineage_ignored(self):
298 actual = self._test_git_number(
299 'Parent\n'
300 '\n'
301 'Cr-Commit-Position: refs/heads/master@{#1}\n'
302 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
303 'refs/heads/master', 'Child')
304 self.assertEqualByLine(
305 actual,
306 'Child\n'
307 '\n'
308 'Cr-Commit-Position: refs/heads/master@{#2}\n'
309 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
310
311 def test_git_number_same_branch(self):
312 actual = self._test_git_number(
313 'Parent\n'
314 '\n'
315 'Cr-Commit-Position: refs/heads/master@{#12}',
316 dest_ref='refs/heads/master',
317 child_msg='Child')
318 self.assertEqualByLine(
319 actual,
320 'Child\n'
321 '\n'
322 'Cr-Commit-Position: refs/heads/master@{#13}')
323
324 def test_git_number_same_branch_with_originals(self):
325 actual = self._test_git_number(
326 'Parent\n'
327 '\n'
328 'Cr-Commit-Position: refs/heads/master@{#12}',
329 dest_ref='refs/heads/master',
330 child_msg='Child\n'
331 '\n'
332 'Some users are smart and insert their own footers\n'
333 '\n'
334 'Cr-Whatever: value\n'
335 'Cr-Commit-Position: refs/copy/paste@{#22}')
336 self.assertEqualByLine(
337 actual,
338 'Child\n'
339 '\n'
340 'Some users are smart and insert their own footers\n'
341 '\n'
342 'Cr-Original-Whatever: value\n'
343 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
344 'Cr-Commit-Position: refs/heads/master@{#13}')
345
346 def test_git_number_new_branch(self):
347 actual = self._test_git_number(
348 'Parent\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/master@{#12}',
351 dest_ref='refs/heads/branch',
352 child_msg='Child')
353 self.assertEqualByLine(
354 actual,
355 'Child\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
358 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
359
360 def test_git_number_lineage(self):
361 actual = self._test_git_number(
362 'Parent\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
365 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
366 dest_ref='refs/heads/branch',
367 child_msg='Child')
368 self.assertEqualByLine(
369 actual,
370 'Child\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
373 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
374
375 def test_git_number_moooooooore_lineage(self):
376 actual = self._test_git_number(
377 'Parent\n'
378 '\n'
379 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
380 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
381 dest_ref='refs/heads/mooore',
382 child_msg='Child')
383 self.assertEqualByLine(
384 actual,
385 'Child\n'
386 '\n'
387 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
388 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
389 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
390
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100391 def test_git_number_ever_moooooooore_lineage(self):
392 self.maxDiff = 10000
393 actual = self._test_git_number(
394 'CQ commit on fresh new branch + numbering.\n'
395 '\n'
396 'NOTRY=True\n'
397 'NOPRESUBMIT=True\n'
398 'BUG=\n'
399 '\n'
400 'Review-Url: https://codereview.chromium.org/2577703003\n'
401 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
402 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
403 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
404 dest_ref='refs/heads/gnumb-test/cl',
405 child_msg='git cl on fresh new branch + numbering.\n'
406 '\n'
407 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
408 self.assertEqualByLine(
409 actual,
410 'git cl on fresh new branch + numbering.\n'
411 '\n'
412 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
413 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
414 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
415 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
416 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100417
418 def test_git_number_cherry_pick(self):
419 actual = self._test_git_number(
420 'Parent\n'
421 '\n'
422 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
423 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
424 dest_ref='refs/heads/branch',
425 child_msg='Child, which is cherry-pick from master\n'
426 '\n'
427 'Cr-Commit-Position: refs/heads/master@{#100}\n'
428 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
429 self.assertEqualByLine(
430 actual,
431 'Child, which is cherry-pick from master\n'
432 '\n'
433 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
434 '\n'
435 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
436 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
437 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
438
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000439
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000440class TestGitCl(TestCase):
441 def setUp(self):
442 super(TestGitCl, self).setUp()
443 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700444 self._calls_done = []
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000445 self.mock(subprocess2, 'call', self._mocked_call)
446 self.mock(subprocess2, 'check_call', self._mocked_call)
447 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700448 self.mock(subprocess2, 'communicate',
449 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000450 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000451 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000452 self.mock(git_common, 'get_or_create_merge_base',
453 lambda *a: (
454 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000455 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000456 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000457 self.mock(git_cl, 'ask_for_data', self._mocked_call)
phajdan.jre328cf92016-08-22 04:12:17 -0700458 self.mock(git_cl, 'write_json', lambda path, contents:
459 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000460 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000461 self.mock(git_cl.rietveld, 'Rietveld', RietveldMock)
maruel@chromium.org4bac4b52012-11-27 20:33:52 +0000462 self.mock(git_cl.rietveld, 'CachingRietveld', RietveldMock)
skobes6468b902016-10-24 08:45:10 -0700463 self.mock(git_cl.checkout, 'GitCheckout', GitCheckoutMock)
464 GitCheckoutMock.reset()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000465 self.mock(git_cl.upload, 'RealMain', self.fail)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000466 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000467 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100468 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
469 lambda *args, **kwargs: self._mocked_call(
470 'GetChangeDetail', *args, **kwargs))
471 self.mock(git_cl.gerrit_util, 'AddReviewers',
472 lambda h, i, add, is_reviewer, notify: self._mocked_call(
473 'AddReviewers', h, i, add, is_reviewer, notify))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000474 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
475 classmethod(lambda _: False))
tandriic2405f52016-10-10 08:13:15 -0700476 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100477 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000478 # It's important to reset settings to not have inter-tests interference.
479 git_cl.settings = None
480
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000481
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000482 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000483 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100484 self.assertEquals([], self.calls)
485 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000486 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100487 raise
488 # Sadly, has_failed() returns True if this OR any other tests before this
489 # one have failed.
490 git_cl.logging.exception(
491 '\nIF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME!\n'
492 'There are un-consumed self.calls after this test has finished.\n'
493 'If you don\'t know which test this is, run:\n'
494 ' tests/git_cl_tests.py -v\n'
495 '\n'
496 'If you are already running just this single test, then **first** '
497 'fix the problem whose exception is emitted below by unittest '
498 'runner.\n'
499 '\n'
500 'Else, to be sure what\'s going on, run this test **alone** with \n'
501 ' tests/git_cl_tests.py TestGitCl.<name>\n'
502 'and follow instructions above.\n' +
503 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000504 finally:
505 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000506
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000507 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000508 self.assertTrue(
509 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700510 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000511 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000512 expected_args, result = top
513
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000514 # Also logs otherwise it could get caught in a try/finally and be hard to
515 # diagnose.
516 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700517 N = 5
518 prior_calls = '\n '.join(
519 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
520 for i, c in enumerate(self._calls_done[-N:]))
521 following_calls = '\n '.join(
522 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
523 for i, c in enumerate(self.calls[:N]))
524 extended_msg = (
525 'A few prior calls:\n %s\n\n'
526 'This (expected):\n @%d: %r\n'
527 'This (actual):\n @%d: %r\n\n'
528 'A few following expected calls:\n %s' %
529 (prior_calls, len(self._calls_done), expected_args,
530 len(self._calls_done), args, following_calls))
531 git_cl.logging.error(extended_msg)
532
tandrii99a72f22016-08-17 14:33:24 -0700533 self.fail('@%d\n'
534 ' Expected: %r\n'
535 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700536 len(self._calls_done), expected_args, args))
537
538 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700539 if isinstance(result, Exception):
540 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000541 return result
542
tandrii48df5812016-10-17 03:55:37 -0700543 def test_LoadCodereviewSettingsFromFile_gerrit(self):
544 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
545 self.calls = [
546 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
547 ((['git', 'config', '--unset-all', 'rietveld.private'],), CERR1),
548 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
549 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
550 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
551 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700552 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
553 CERR1),
554 ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700555 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
556 CERR1),
557 ((['git', 'config', 'gerrit.host', 'true'],), ''),
558 ]
559 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
560
maruel@chromium.orga3353652011-11-30 14:26:57 +0000561 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000562 def _is_gerrit_calls(cls, gerrit=False):
563 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
564 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
565
566 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000567 def _upload_calls(cls, similarity, find_copies, private):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000568 return (cls._git_base_calls(similarity, find_copies) +
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000569 cls._git_upload_calls(private))
maruel@chromium.orga3353652011-11-30 14:26:57 +0000570
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000571 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000572 def _upload_no_rev_calls(cls, similarity, find_copies):
573 return (cls._git_base_calls(similarity, find_copies) +
574 cls._git_upload_no_rev_calls())
575
576 @classmethod
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000577 def _git_base_calls(cls, similarity, find_copies):
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000578 if similarity is None:
579 similarity = '50'
tandrii33a46ff2016-08-23 05:53:40 -0700580 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700581 'branch.master.git-cl-similarity'],), CERR1)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000582 else:
tandrii33a46ff2016-08-23 05:53:40 -0700583 similarity_call = ((['git', 'config',
tandrii5d48c322016-08-18 16:19:37 -0700584 'branch.master.git-cl-similarity', similarity],), '')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000585
586 if find_copies is None:
587 find_copies = True
tandrii5d48c322016-08-18 16:19:37 -0700588 find_copies_call = ((['git', 'config', '--bool',
589 'branch.master.git-find-copies'],), CERR1)
iannucci@chromium.org79540052012-10-19 23:15:26 +0000590 else:
tandrii5d48c322016-08-18 16:19:37 -0700591 val = str(find_copies).lower()
592 find_copies_call = ((['git', 'config', '--bool',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000593 'branch.master.git-find-copies', val],), '')
594
595 if find_copies:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000596 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
scottmgb84b5e32016-11-10 09:25:33 -0800597 '-l100000', '-C'+similarity,
598 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000599 else:
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000600 stat_call = ((['git', 'diff', '--no-ext-diff', '--stat',
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000601 '-M'+similarity, 'fake_ancestor_sha', 'HEAD'],), '+dat')
iannucci@chromium.org79540052012-10-19 23:15:26 +0000602
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000603 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000604 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000605 similarity_call,
606 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
607 find_copies_call,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000608 ] + cls._is_gerrit_calls() + [
tandrii@chromium.org87985d22016-03-24 17:33:33 +0000609 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -0700610 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
611 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000612 ((['git', 'config', 'rietveld.server'],),
613 'codereview.example.com'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000614 ((['git', 'config', 'branch.master.merge'],), 'master'),
615 ((['git', 'config', 'branch.master.remote'],), 'origin'),
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000616 ((['get_or_create_merge_base', 'master', 'master'],),
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000617 'fake_ancestor_sha'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000618 ] + cls._git_sanity_checks('fake_ancestor_sha', 'master') + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000619 ((['git', 'rev-parse', '--show-cdup'],), ''),
620 ((['git', 'rev-parse', 'HEAD'],), '12345'),
621 ((['git', 'diff', '--name-status', '--no-renames', '-r',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000622 'fake_ancestor_sha...', '.'],),
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000623 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -0700624 ((['git', 'config', 'branch.master.rietveldpatchset'],), CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000625 ((['git', 'log', '--pretty=format:%s%n%n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000626 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000627 'foo'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000628 ((['git', 'config', 'user.email'],), 'me@example.com'),
iannucci@chromium.org79540052012-10-19 23:15:26 +0000629 stat_call,
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000630 ((['git', 'log', '--pretty=format:%s\n\n%b',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000631 'fake_ancestor_sha..HEAD'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000632 'desc\n'),
rmistry@google.com90752582014-01-14 21:04:50 +0000633 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
maruel@chromium.orga3353652011-11-30 14:26:57 +0000634 ]
635
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000636 @classmethod
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000637 def _git_upload_no_rev_calls(cls):
638 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000639 ((['git', 'config', 'core.editor'],), ''),
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000640 ]
641
642 @classmethod
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000643 def _git_upload_calls(cls, private):
644 if private:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000645 cc_call = []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000646 private_call = []
647 else:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000648 cc_call = [((['git', 'config', 'rietveld.cc'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000649 private_call = [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000650 ((['git', 'config', 'rietveld.private'],), '')]
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000651
maruel@chromium.orga3353652011-11-30 14:26:57 +0000652 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000653 ((['git', 'config', 'core.editor'],), ''),
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000654 ] + cc_call + private_call + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000655 ((['git', 'config', 'branch.master.base-url'],), ''),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800656 ((['git', 'config', 'remote.origin.url'],), ''),
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000657 ((['git', 'config', 'rietveld.project'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -0700658 ((['git', 'config', 'branch.master.rietveldissue', '1'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000659 ((['git', 'config', 'branch.master.rietveldserver',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000660 'https://codereview.example.com'],), ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000661 ((['git',
tandrii33a46ff2016-08-23 05:53:40 -0700662 'config', 'branch.master.rietveldpatchset', '2'],), ''),
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000663 ] + cls._git_post_upload_calls()
664
665 @classmethod
666 def _git_post_upload_calls(cls):
667 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000668 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
669 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
670 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000671 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000672 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000673 ]
674
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000675 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000676 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000677 fake_ancestor = 'fake_ancestor'
678 fake_cl = 'fake_cl_for_patch'
679 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000680 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000681 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000682 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000683 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000684 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000685 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000686 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000687 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700688 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000689 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000690 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000691 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000692 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000693 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000694 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000695 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000696 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000697 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000698 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000699 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000700
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000701 @staticmethod
bradnelsond975b302016-10-23 12:20:23 -0700702 def _cmd_line(description, args, similarity, find_copies, private, cc):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000703 """Returns the upload command line passed to upload.RealMain()."""
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704 return [
705 'upload', '--assume_yes', '--server',
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000706 'https://codereview.example.com',
maruel@chromium.org71e12a92012-02-14 02:34:15 +0000707 '--message', description
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000708 ] + args + [
bradnelsond975b302016-10-23 12:20:23 -0700709 '--cc', ','.join(['joe@example.com'] + cc),
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000710 ] + (['--private'] if private else []) + [
iannucci@chromium.org79540052012-10-19 23:15:26 +0000711 '--git_similarity', similarity or '50'
Andrii Shyshkalov18975322017-01-25 16:44:13 +0100712 ] + (['--git_no_find_copies'] if find_copies is False else []) + [
sbc@chromium.org5e07e062013-02-28 23:55:44 +0000713 'fake_ancestor_sha', 'HEAD'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000714 ]
715
716 def _run_reviewer_test(
717 self,
718 upload_args,
719 expected_description,
720 returned_description,
721 final_description,
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000722 reviewers,
bradnelsond975b302016-10-23 12:20:23 -0700723 private=False,
724 cc=None):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000725 """Generic reviewer test framework."""
tandrii@chromium.org28253532016-04-14 13:46:56 +0000726 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000727 try:
728 similarity = upload_args[upload_args.index('--similarity')+1]
729 except ValueError:
730 similarity = None
iannucci@chromium.org79540052012-10-19 23:15:26 +0000731
732 if '--find-copies' in upload_args:
733 find_copies = True
734 elif '--no-find-copies' in upload_args:
735 find_copies = False
736 else:
737 find_copies = None
738
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000739 private = '--private' in upload_args
bradnelsond975b302016-10-23 12:20:23 -0700740 cc = cc or []
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000741
742 self.calls = self._upload_calls(similarity, find_copies, private)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000743
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000744 def RunEditor(desc, _, **kwargs):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000745 self.assertEquals(
746 '# Enter a description of the change.\n'
janx@chromium.org104b2db2013-04-18 12:58:40 +0000747 '# This will be displayed on the codereview site.\n'
alancutter@chromium.org63a4d7f2013-05-31 02:22:45 +0000748 '# The first line will also be used as the subject of the review.\n'
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +0000749 '#--------------------This line is 72 characters long'
750 '--------------------\n' +
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000751 expected_description,
752 desc)
753 return returned_description
754 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000755
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000756 def check_upload(args):
iannucci@chromium.org79540052012-10-19 23:15:26 +0000757 cmd_line = self._cmd_line(final_description, reviewers, similarity,
bradnelsond975b302016-10-23 12:20:23 -0700758 find_copies, private, cc)
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000759 self.assertEquals(cmd_line, args)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000760 return 1, 2
761 self.mock(git_cl.upload, 'RealMain', check_upload)
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000762
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000763 git_cl.main(['upload'] + upload_args)
764
765 def test_no_reviewer(self):
766 self._run_reviewer_test(
767 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000768 'desc\n\nBUG=',
769 '# Blah blah comment.\ndesc\n\nBUG=',
770 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000771 [])
772
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000773 def test_keep_similarity(self):
774 self._run_reviewer_test(
775 ['--similarity', '70'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000776 'desc\n\nBUG=',
777 '# Blah blah comment.\ndesc\n\nBUG=',
778 'desc\n\nBUG=',
iannucci@chromium.org53937ba2012-10-02 18:20:43 +0000779 [])
780
iannucci@chromium.org79540052012-10-19 23:15:26 +0000781 def test_keep_find_copies(self):
782 self._run_reviewer_test(
783 ['--no-find-copies'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000784 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000785 '# Blah blah comment.\ndesc\n\nBUG=\n',
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000786 'desc\n\nBUG=',
iannucci@chromium.org79540052012-10-19 23:15:26 +0000787 [])
788
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000789 def test_private(self):
790 self._run_reviewer_test(
791 ['--private'],
792 'desc\n\nBUG=',
793 '# Blah blah comment.\ndesc\n\nBUG=\n',
794 'desc\n\nBUG=',
795 [])
796
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000797 def test_reviewers_cmd_line(self):
798 # Reviewer is passed as-is
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000799 description = 'desc\n\nR=foo@example.com\nBUG='
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000800 self._run_reviewer_test(
801 ['-r' 'foo@example.com'],
802 description,
803 '\n%s\n' % description,
804 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000805 ['--reviewers=foo@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000806
807 def test_reviewer_tbr_overriden(self):
808 # Reviewer is overriden with TBR
809 # Also verifies the regexp work without a trailing LF
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000810 description = 'Foo Bar\n\nTBR=reviewer@example.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000811 self._run_reviewer_test(
812 ['-r' 'foo@example.com'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000813 'desc\n\nR=foo@example.com\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000814 description.strip('\n'),
815 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000816 ['--reviewers=reviewer@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000817
818 def test_reviewer_multiple(self):
819 # Handles multiple R= or TBR= lines.
820 description = (
bradnelsond975b302016-10-23 12:20:23 -0700821 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
822 'CC=more@example.com,people@example.com')
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000823 self._run_reviewer_test(
824 [],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000825 'desc\n\nBUG=',
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000826 description,
827 description,
bradnelsond975b302016-10-23 12:20:23 -0700828 ['--reviewers=another@example.com,reviewer@example.com'],
829 cc=['more@example.com', 'people@example.com'])
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000830
maruel@chromium.orga3353652011-11-30 14:26:57 +0000831 def test_reviewer_send_mail(self):
832 # --send-mail can be used without -r if R= is used
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000833 description = 'Foo Bar\nR=reviewer@example.com'
maruel@chromium.orga3353652011-11-30 14:26:57 +0000834 self._run_reviewer_test(
835 ['--send-mail'],
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000836 'desc\n\nBUG=',
maruel@chromium.orga3353652011-11-30 14:26:57 +0000837 description.strip('\n'),
838 description,
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000839 ['--reviewers=reviewer@example.com', '--send_mail'])
maruel@chromium.orga3353652011-11-30 14:26:57 +0000840
841 def test_reviewer_send_mail_no_rev(self):
842 # Fails without a reviewer.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000843 stdout = StringIO.StringIO()
tandriic2405f52016-10-10 08:13:15 -0700844 self.calls = self._upload_no_rev_calls(None, None) + [
845 ((['DieWithError', 'Must specify reviewers to send email.'],),
846 SystemExitMock())
847 ]
848
849 def RunEditor(desc, _, **kwargs):
850 return desc
851 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
852 self.mock(sys, 'stdout', stdout)
853 with self.assertRaises(SystemExitMock):
maruel@chromium.orga3353652011-11-30 14:26:57 +0000854 git_cl.main(['upload', '--send-mail'])
tandriic2405f52016-10-10 08:13:15 -0700855 self.assertEqual(
856 'Using 50% similarity for rename/copy detection. Override with '
857 '--similarity.\n',
858 stdout.getvalue())
maruel@chromium.orga3353652011-11-30 14:26:57 +0000859
tandriif9aefb72016-07-01 09:06:51 -0700860 def test_bug_on_cmd(self):
861 self._run_reviewer_test(
862 ['--bug=500658,proj:123'],
863 'desc\n\nBUG=500658\nBUG=proj:123',
864 '# Blah blah comment.\ndesc\n\nBUG=500658\nBUG=proj:1234',
865 'desc\n\nBUG=500658\nBUG=proj:1234',
866 [])
867
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100868 def _land_rietveld_common(self, debug=False):
869 if debug:
870 # Very useful due to finally clause in git cl land raising exceptions and
871 # shadowing real cause of failure.
872 self.mock(git_cl, '_IS_BEING_TESTED', True)
873 else:
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100874 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100875
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100876 self.mock(git_cl, '_is_git_numberer_enabled', lambda url, ref:
877 self._mocked_call('_is_git_numberer_enabled', url, ref))
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100878 self.mock(RietveldMock, 'update_description', staticmethod(
879 lambda i, d: self._mocked_call(['update_description', i, d])))
880 self.mock(RietveldMock, 'add_comment', staticmethod(
881 lambda i, c: self._mocked_call(['add_comment', i, c])))
882 self.calls = [
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100883 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
884 ((['git', 'config', 'branch.feature.git-cl-similarity'],), CERR1),
885 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
886 ((['git', 'config', '--bool', 'branch.feature.git-find-copies'],),
887 CERR1),
888 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
889 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800890 ((['git', 'config', 'rietveld.autoupdate'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100891 ((['git', 'config', 'rietveld.server'],),
892 'https://codereview.chromium.org'),
893 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
894 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
895 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
896 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100897 ((['git', 'rev-list', '^feature', 'refs/remotes/origin/master'],),
898 ''), # No commits to rebase, according to local view of origin.
899 ((['git', 'merge-base', 'refs/remotes/origin/master', 'HEAD'],),
900 'fake_ancestor_sha'),
901 ] + self._git_sanity_checks('fake_ancestor_sha', 'feature') + [
902 ((['git', 'rev-parse', '--show-cdup'],), ''),
903 ((['git', 'rev-parse', 'HEAD'],), 'fake_sha'),
904 ((['git', 'diff', '--name-status', '--no-renames', '-r',
905 'fake_ancestor_sha...', '.'],),
906 'M\tfile1.cpp'),
907 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
908 ((['git', 'config', 'branch.feature.rietveldserver'],),
909 'https://codereview.chromium.org'),
910 ((['git', 'config', 'user.email'],), 'user@e.mail'),
911 ((['git', 'config', 'rietveld.tree-status-url'],), CERR1),
912 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50',
913 'fake_ancestor_sha', 'feature'],),
914 # This command just prints smth like this:
915 # file1.cpp | 53 ++++++--
916 # 1 file changed, 33 insertions(+), 20 deletions(-)\n
917 ''),
918 ((['git', 'show-ref', '--quiet', '--verify',
919 'refs/heads/git-cl-commit'],),
920 ''), # 0 return code means branch exists.
921 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
922 ((['git', 'show-ref', '--quiet', '--verify',
923 'refs/heads/git-cl-cherry-pick'],),
924 CERR1), # This means git-cl-cherry-pick branch does not exist.
925 ((['git', 'rev-parse', '--show-cdup'],), ''),
926 ((['git', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
927 ((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
928 ((['git', 'commit', '-m',
929 'Issue: 123\n\nR=john@chromium.org\n\n'
Andrii Shyshkalovf01be222016-12-08 19:21:13 +0100930 'Review-Url: https://codereview.chromium.org/123 .'],), ''),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100931 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
932 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
933 ((['git', 'config', '--get', 'remote.origin.url'],),
934 'https://chromium.googlesource.com/infra/infra'),
935 ]
936
937 def test_land_rietveld(self):
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100938 self._land_rietveld_common(debug=False)
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100939 self.calls += [
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100940 ((['git', 'config', 'remote.origin.url'],),
941 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100942 (('_is_git_numberer_enabled',
943 'https://chromium.googlesource.com/infra/infra',
944 'refs/heads/master'),
945 False),
Andrii Shyshkalov06a25022016-11-24 16:47:00 +0100946 ((['git', 'push', '--porcelain', 'origin', 'HEAD:refs/heads/master'],),
947 ''),
948 ((['git', 'rev-parse', 'HEAD'],), 'fake_sha_rebased'),
949 ((['git', 'checkout', '-q', 'feature'],), ''),
950 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
951 ((['git', 'config', 'rietveld.viewvc-url'],),
952 'https://chromium.googlesource.com/infra/infra/+/'),
953 ((['update_description', 123,
954 'Issue: 123\n\nR=john@chromium.org\n\nCommitted: '
955 'https://chromium.googlesource.com/infra/infra/+/fake_sha_rebased'],),
956 ''),
957 ((['add_comment', 123, 'Committed patchset #2 (id:20001) manually as '
958 'fake_sha_rebased (presubmit successful).'],), ''),
959 ]
960 git_cl.main(['land'])
961
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100962 def test_land_rietveld_git_numberer(self):
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100963 self._land_rietveld_common(debug=False)
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100964
965 # Special mocks to check validity of timestamp.
966 original_git_amend_head = git_cl._git_amend_head
967 def _git_amend_head_mock(msg, tstamp):
968 self._mocked_call(['git_amend_head committer timestamp', tstamp])
969 return original_git_amend_head(msg, tstamp)
970 self.mock(git_cl, '_git_amend_head', _git_amend_head_mock)
971
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100972 self.calls += [
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100973 ((['git', 'config', 'remote.origin.url'],),
974 'https://chromium.googlesource.com/chromium/src'),
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100975 (('_is_git_numberer_enabled',
976 'https://chromium.googlesource.com/chromium/src',
977 'refs/heads/master'),
978 True),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100979 ((['git', 'show', '-s', '--format=%B', 'fake_ancestor_sha'],),
980 'This is parent commit.\n'
981 '\n'
982 'Cr-Commit-Position: refs/heads/master@{#543}\n'
983 'Cr-Branched-From: refs/svn/2014@{#2208}'),
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100984 ((['git', 'show', '-s', '--format=%ct', 'fake_ancestor_sha'],),
985 '1480022355'), # Committer's unix timestamp.
986 ((['git', 'show', '-s', '--format=%ct', 'HEAD'],),
987 '1480024000'),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100988
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100989 ((['git_amend_head committer timestamp', 1480024000],), None),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100990 ((['git', 'commit', '--amend', '-m',
991 'Issue: 123\n\nR=john@chromium.org\n'
992 '\n'
Andrii Shyshkalovf01be222016-12-08 19:21:13 +0100993 'Review-Url: https://codereview.chromium.org/123 .\n'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100994 'Cr-Commit-Position: refs/heads/master@{#544}\n'
995 'Cr-Branched-From: refs/svn/2014@{#2208}'],), ''),
996
997 ((['git', 'push', '--porcelain', 'origin', 'HEAD:refs/heads/master'],),
998 ''),
999 ((['git', 'rev-parse', 'HEAD'],), 'fake_sha_rebased'),
1000 ((['git', 'checkout', '-q', 'feature'],), ''),
1001 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
1002 ((['git', 'config', 'rietveld.viewvc-url'],),
1003 'https://chromium.googlesource.com/infra/infra/+/'),
1004 ((['update_description', 123,
1005 'Issue: 123\n\nR=john@chromium.org\n'
1006 '\n'
Andrii Shyshkalovf01be222016-12-08 19:21:13 +01001007 'Review-Url: https://codereview.chromium.org/123 .\n'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001008 'Cr-Commit-Position: refs/heads/master@{#544}\n'
1009 'Cr-Branched-From: refs/svn/2014@{#2208}\n'
1010 'Committed: '
1011 'https://chromium.googlesource.com/infra/infra/+/fake_sha_rebased'],),
1012 ''),
1013 ((['add_comment', 123, 'Committed patchset #2 (id:20001) manually as '
1014 'fake_sha_rebased (presubmit successful).'],), ''),
1015 ]
1016 git_cl.main(['land'])
1017
1018 def test_land_rietveld_git_numberer_bad_parent(self):
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01001019 self._land_rietveld_common(debug=False)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001020 self.calls += [
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01001021 ((['git', 'config', 'remote.origin.url'],),
1022 'https://chromium.googlesource.com/v8/v8'),
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001023 (('_is_git_numberer_enabled',
1024 'https://chromium.googlesource.com/v8/v8', 'refs/heads/master'),
1025 True),
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01001026
1027 ((['git', 'show', '-s', '--format=%B', 'fake_ancestor_sha'],),
1028 'This is parent commit with no footer.'),
1029
1030 ((['git', 'checkout', '-q', 'feature'],), ''),
1031 ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
1032 ]
1033 with self.assertRaises(ValueError) as cm:
1034 git_cl.main(['land'])
1035 self.assertEqual(cm.exception.message,
1036 'Unable to infer commit position from footers')
1037
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001038 def test_git_numberer_not_whitelisted_repo(self):
1039 self.calls = []
1040 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001041 remote_url='https://chromium.googlesource.com/chromium/tools/build',
1042 remote_ref='refs/whatever')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001043 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001044
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001045 def test_git_numberer_fail_fetch(self):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001046 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1047 self.calls = [
1048 ((['git', 'fetch', 'https://chromium.googlesource.com/chromium/src',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001049 '+refs/meta/config:refs/git_cl/meta/config'],), CERR1),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001050 ]
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001051 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001052 remote_url='https://chromium.googlesource.com/chromium/src',
1053 remote_ref='refs/whatever')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001054 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001055
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001056 def test_git_numberer_valid_configs(self):
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001057 with git_cl.gclient_utils.temporary_directory() as tempdir:
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001058 @contextlib.contextmanager
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001059 def fake_temporary_directory(**kwargs):
1060 yield tempdir
1061 self.mock(git_cl.gclient_utils, 'temporary_directory',
1062 fake_temporary_directory)
1063 self._test_GitNumbererState_valid_configs_inner(tempdir)
1064
1065 def _test_GitNumbererState_valid_configs_inner(self, tempdir):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001066 self.calls = [
1067 ((['git', 'fetch', 'https://chromium.googlesource.com/chromium/src',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001068 '+refs/meta/config:refs/git_cl/meta/config'],), ''),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001069 ((['git', 'show', 'refs/git_cl/meta/config:project.config'],),
1070 '''
1071 [plugin "git-numberer"]
1072 validate-enabled-refglob = refs/else/*
1073 validate-enabled-refglob = refs/heads/*
1074 validate-disabled-refglob = refs/heads/disabled
1075 validate-disabled-refglob = refs/branch-heads/*
1076 '''),
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001077 ((['git', 'config', '-f', os.path.join(tempdir, 'project.config') ,
1078 '--get-all', 'plugin.git-numberer.validate-enabled-refglob'],),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001079 'refs/else/*\n'
1080 'refs/heads/*\n'),
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +00001081 ((['git', 'config', '-f', os.path.join(tempdir, 'project.config') ,
1082 '--get-all', 'plugin.git-numberer.validate-disabled-refglob'],),
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001083 'refs/heads/disabled\n'
1084 'refs/branch-heads/*\n'),
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001085 ] * 3 # 3 tests below have exactly the same IO.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001086
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001087 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001088 remote_url='https://chromium.googlesource.com/chromium/src',
1089 remote_ref='refs/heads/test')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001090 self.assertEqual(res, True)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001091
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001092 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001093 remote_url='https://chromium.googlesource.com/chromium/src',
1094 remote_ref='refs/heads/disabled')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001095 self.assertEqual(res, False)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01001096
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001097 # Validator is disabled by default, even if it's not explicitely in disabled
1098 # refglobs.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001099 res = git_cl._is_git_numberer_enabled(
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001100 remote_url='https://chromium.googlesource.com/chromium/src',
1101 remote_ref='refs/arbitrary/ref')
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001102 self.assertEqual(res, False)
Andrii Shyshkalovcbec8ef2016-12-09 13:54:51 +01001103
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001104 @classmethod
tandrii@chromium.org28253532016-04-14 13:46:56 +00001105 def _gerrit_ensure_auth_calls(cls, issue=None, skip_auth_check=False):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00001106 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +00001107 if skip_auth_check:
1108 return [((cmd, ), 'true')]
1109
tandrii5d48c322016-08-18 16:19:37 -07001110 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001111 if issue:
1112 calls.extend([
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001113 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001114 ])
1115 calls.extend([
1116 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1117 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1118 ((['git', 'config', 'remote.origin.url'],),
1119 'https://chromium.googlesource.com/my/repo'),
1120 ((['git', 'config', 'remote.origin.url'],),
1121 'https://chromium.googlesource.com/my/repo'),
1122 ])
1123 return calls
1124
1125 @classmethod
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001126 def _gerrit_base_calls(cls, issue=None, fetched_description=None):
ukai@chromium.orge8077812012-02-03 03:41:46 +00001127 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001128 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001129 ((['git', 'config', 'branch.master.git-cl-similarity'],),
tandrii5d48c322016-08-18 16:19:37 -07001130 CERR1),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001131 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii5d48c322016-08-18 16:19:37 -07001132 ((['git', 'config', '--bool', 'branch.master.git-find-copies'],),
1133 CERR1),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001134 ] + cls._is_gerrit_calls(True) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001135 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001136 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1137 ((['git', 'config', 'branch.master.gerritissue'],),
tandrii5d48c322016-08-18 16:19:37 -07001138 CERR1 if issue is None else str(issue)),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001139 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001140 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001141 ((['get_or_create_merge_base', 'master',
1142 'refs/remotes/origin/master'],),
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001143 'fake_ancestor_sha'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001144 # Calls to verify branch point is ancestor
1145 ] + (cls._gerrit_ensure_auth_calls(issue=issue) +
1146 cls._git_sanity_checks('fake_ancestor_sha', 'master',
1147 get_remote_branch=False)) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001148 ((['git', 'rev-parse', '--show-cdup'],), ''),
1149 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001150
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001151 ((['git',
mcgrathr@chromium.org9249f642013-06-03 21:36:18 +00001152 'diff', '--name-status', '--no-renames', '-r',
1153 'fake_ancestor_sha...', '.'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001154 'M\t.gitignore\n'),
tandrii33a46ff2016-08-23 05:53:40 -07001155 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001156 ] + ([
1157 (('GetChangeDetail', 'chromium-review.googlesource.com',
1158 '123456', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
1159 {
1160 'change_id': '123456789',
1161 'current_revision': 'sha1_of_current_revision',
1162 'revisions': { 'sha1_of_current_revision': {
1163 'commit': {'message': fetched_description},
1164 }},
1165 }),
1166 ] if issue else [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001167 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001168 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001169 'foo'),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001170 ]) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001171 ((['git', 'config', 'user.email'],), 'me@example.com'),
1172 ((['git',
scottmgb84b5e32016-11-10 09:25:33 -08001173 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50',
1174 'fake_ancestor_sha', 'HEAD'],),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001175 '+dat'),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001176 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001177
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001178 @classmethod
1179 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001180 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001181 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001182 ref_suffix='', title=None, notify=False,
bradnelsond975b302016-10-23 12:20:23 -07001183 post_amend_description=None, issue=None, cc=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001184 if post_amend_description is None:
1185 post_amend_description = description
tandriia60502f2016-06-20 02:01:53 -07001186 calls = []
bradnelsond975b302016-10-23 12:20:23 -07001187 cc = cc or []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001188
tandriia60502f2016-06-20 02:01:53 -07001189 if squash_mode == 'default':
1190 calls.extend([
1191 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
1192 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
1193 ])
1194 elif squash_mode in ('override_squash', 'override_nosquash'):
1195 calls.extend([
1196 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
1197 'true' if squash_mode == 'override_squash' else 'false'),
1198 ])
1199 else:
1200 assert squash_mode in ('squash', 'nosquash')
1201
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001202 # If issue is given, then description is fetched from Gerrit instead.
1203 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001204 calls += [
1205 ((['git', 'log', '--pretty=format:%s\n\n%b',
1206 'fake_ancestor_sha..HEAD'],),
1207 description)]
Aaron Gableb56ad332017-01-06 15:24:31 -08001208 if squash:
1209 title = 'Initial_upload'
1210 else:
1211 if not title:
1212 calls += [
1213 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
1214 (('Title for patchset []: ',), 'User input'),
1215 ]
1216 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +00001217 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001218 calls += [
tandrii@chromium.org10625002016-03-04 20:03:47 +00001219 # DownloadGerritHook(False)
1220 ((False, ),
1221 ''),
1222 # Amending of commit message to get the Change-Id.
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001223 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +00001224 'fake_ancestor_sha..HEAD'],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001225 description),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001226 ((['git', 'commit', '--amend', '-m', description],),
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001227 ''),
bratell@opera.com82b91cd2013-07-09 06:33:41 +00001228 ((['git', 'log', '--pretty=format:%s\n\n%b',
sbc@chromium.org5e07e062013-02-28 23:55:44 +00001229 'fake_ancestor_sha..HEAD'],),
tandrii@chromium.org10625002016-03-04 20:03:47 +00001230 post_amend_description)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001231 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001232 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001233 if not issue:
1234 # Prompting to edit description on first upload.
1235 calls += [
1236 ((['git', 'config', 'core.editor'],), ''),
1237 ((['RunEditor'],), description),
1238 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001239 ref_to_push = 'abcdef0123456789'
1240 calls += [
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001241 ((['git', 'config', 'branch.master.merge'],),
1242 'refs/heads/master'),
1243 ((['git', 'config', 'branch.master.remote'],),
1244 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001245 ((['get_or_create_merge_base', 'master',
1246 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001247 'origin/master'),
1248 ((['git', 'rev-parse', 'HEAD:'],),
1249 '0123456789abcdef'),
1250 ((['git', 'commit-tree', '0123456789abcdef', '-p',
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001251 'origin/master', '-m', description],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001252 ref_to_push),
1253 ]
1254 else:
1255 ref_to_push = 'HEAD'
1256
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001257 calls += [
luqui@chromium.org609f3952015-05-04 22:47:04 +00001258 ((['git', 'rev-list',
1259 expected_upstream_ref + '..' + ref_to_push],), ''),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001260 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001261
Aaron Gable9b713dd2016-12-14 16:04:21 -08001262 if title:
1263 if ref_suffix:
1264 ref_suffix += ',m=' + title
1265 else:
1266 ref_suffix = '%m=' + title
1267
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001268 notify_suffix = 'notify=%s' % ('ALL' if notify else 'NONE')
1269 if ref_suffix:
1270 ref_suffix += ',' + notify_suffix
1271 else:
1272 ref_suffix = '%' + notify_suffix
tandrii@chromium.org074c2af2016-06-03 23:18:40 +00001273
ukai@chromium.orge8077812012-02-03 03:41:46 +00001274 if reviewers:
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001275 ref_suffix += ',' + ','.join('r=%s' % email
1276 for email in sorted(reviewers))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001277 calls += [
tandrii@chromium.org8acd8332016-04-13 12:56:03 +00001278 ((['git', 'push', 'origin',
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001279 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001280 ('remote:\n'
1281 'remote: Processing changes: (\)\n'
1282 'remote: Processing changes: (|)\n'
1283 'remote: Processing changes: (/)\n'
1284 'remote: Processing changes: (-)\n'
1285 'remote: Processing changes: new: 1 (/)\n'
1286 'remote: Processing changes: new: 1, done\n'
1287 'remote:\n'
1288 'remote: New Changes:\n'
1289 'remote: https://chromium-review.googlesource.com/123456 XXX.\n'
1290 'remote:\n'
1291 'To https://chromium.googlesource.com/yyy/zzz\n'
1292 ' * [new branch] hhhh -> refs/for/refs/heads/master\n')),
ukai@chromium.orge8077812012-02-03 03:41:46 +00001293 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001294 if squash:
1295 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001296 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001297 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001298 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001299 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001300 ((['git', 'config', 'branch.master.gerritsquashhash',
1301 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001302 ]
tandrii88189772016-09-29 04:29:57 -07001303 calls += [
1304 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001305 (('AddReviewers', 'chromium-review.googlesource.com',
tandrii88189772016-09-29 04:29:57 -07001306 123456 if squash else None,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001307 ['joe@example.com'] + cc, False, notify), ''),
tandrii88189772016-09-29 04:29:57 -07001308 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001309 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001310 return calls
1311
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001312 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001313 self,
1314 upload_args,
1315 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001316 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001317 squash=True,
1318 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001319 expected_upstream_ref='origin/refs/heads/master',
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001320 ref_suffix='',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001321 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001322 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001323 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001324 issue=None,
1325 cc=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001326 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001327 if squash_mode is None:
1328 if '--no-squash' in upload_args:
1329 squash_mode = 'nosquash'
1330 elif '--squash' in upload_args:
1331 squash_mode = 'squash'
1332 else:
1333 squash_mode = 'default'
1334
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001335 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001336 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001337 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001338 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001339 CookiesAuthenticatorMockFactory(same_cookie='same_cred'))
tandrii16e0b4e2016-06-07 10:34:28 -07001340 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1341 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001342 self.mock(git_cl.gclient_utils, 'RunEditor',
1343 lambda *_, **__: self._mocked_call(['RunEditor']))
1344 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
1345
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001346 self.calls = self._gerrit_base_calls(
1347 issue=issue,
1348 fetched_description=description)
luqui@chromium.org609f3952015-05-04 22:47:04 +00001349 self.calls += self._gerrit_upload_calls(
1350 description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -07001351 squash_mode=squash_mode,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001352 expected_upstream_ref=expected_upstream_ref,
Aaron Gable9b713dd2016-12-14 16:04:21 -08001353 ref_suffix=ref_suffix, title=title, notify=notify,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001354 post_amend_description=post_amend_description,
bradnelsond975b302016-10-23 12:20:23 -07001355 issue=issue, cc=cc)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001356 # Uncomment when debugging.
1357 # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001358 git_cl.main(['upload'] + upload_args)
1359
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001360 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001361 self._run_gerrit_upload_test(
1362 ['--no-squash'],
1363 'desc\n\nBUG=\n',
1364 [],
1365 squash=False,
1366 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
1367
1368 def test_gerrit_upload_without_change_id_override_nosquash(self):
tandrii@chromium.org10625002016-03-04 20:03:47 +00001369 self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001370 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001371 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001372 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001373 [],
tandriia60502f2016-06-20 02:01:53 -07001374 squash=False,
1375 squash_mode='override_nosquash',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001376 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001377
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001378 def test_gerrit_no_reviewer(self):
1379 self._run_gerrit_upload_test(
1380 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001381 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001382 [],
1383 squash=False,
1384 squash_mode='override_nosquash')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001385
tandriieefe8322016-08-17 10:12:24 -07001386 def test_gerrit_patch_bad_chars(self):
1387 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001388 self._run_gerrit_upload_test(
tandriieefe8322016-08-17 10:12:24 -07001389 ['-f', '-t', 'Don\'t put bad cha,.rs'],
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001390 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandriia60502f2016-06-20 02:01:53 -07001391 squash=False,
1392 squash_mode='override_nosquash',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001393 title='Dont_put_bad_chars')
tandriieefe8322016-08-17 10:12:24 -07001394 self.assertIn(
1395 'WARNING: Patchset title may only contain alphanumeric chars '
1396 'and spaces. Cleaned up title:\nDont put bad chars\n',
1397 git_cl.sys.stdout.getvalue())
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001398
ukai@chromium.orge8077812012-02-03 03:41:46 +00001399 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001400 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001401 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001402 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001403 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001404 squash=False,
1405 squash_mode='override_nosquash',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001406 notify=True)
ukai@chromium.orge8077812012-02-03 03:41:46 +00001407
1408 def test_gerrit_reviewer_multiple(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001409 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001410 [],
bradnelsond975b302016-10-23 12:20:23 -07001411 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1412 'CC=more@example.com,people@example.com\n\n'
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001413 'Change-Id: 123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001414 ['reviewer@example.com', 'another@example.com'],
1415 squash=False,
tandrii99a72f22016-08-17 14:33:24 -07001416 squash_mode='override_nosquash',
bradnelsond975b302016-10-23 12:20:23 -07001417 ref_suffix='%l=Code-Review+1',
1418 cc=['more@example.com', 'people@example.com'])
tandriia60502f2016-06-20 02:01:53 -07001419
1420 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001421 self._run_gerrit_upload_test(
1422 [],
1423 'desc\nBUG=\n\nChange-Id: 123456789',
1424 [],
1425 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001426
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001427 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001428 self._run_gerrit_upload_test(
1429 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001430 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001431 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001432 squash=True,
1433 expected_upstream_ref='origin/master')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001434
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001435 def test_gerrit_upload_squash_reupload(self):
1436 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001437 self._run_gerrit_upload_test(
1438 ['--squash'],
1439 description,
1440 [],
1441 squash=True,
1442 expected_upstream_ref='origin/master',
1443 issue=123456)
1444
rmistry@google.com2dd99862015-06-22 12:22:18 +00001445 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001446 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001447 def mock_run_git(*args, **_kwargs):
1448 if args[0] == ['for-each-ref',
1449 '--format=%(refname:short) %(upstream:short)',
1450 'refs/heads']:
1451 # Create a local branch dependency tree that looks like this:
1452 # test1 -> test2 -> test3 -> test4 -> test5
1453 # -> test3.1
1454 # test6 -> test0
1455 branch_deps = [
1456 'test2 test1', # test1 -> test2
1457 'test3 test2', # test2 -> test3
1458 'test3.1 test2', # test2 -> test3.1
1459 'test4 test3', # test3 -> test4
1460 'test5 test4', # test4 -> test5
1461 'test6 test0', # test0 -> test6
1462 'test7', # test7
1463 ]
1464 return '\n'.join(branch_deps)
1465 self.mock(git_cl, 'RunGit', mock_run_git)
1466
1467 class RecordCalls:
1468 times_called = 0
1469 record_calls = RecordCalls()
1470 def mock_CMDupload(*args, **_kwargs):
1471 record_calls.times_called += 1
1472 return 0
1473 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1474
1475 self.calls = [
1476 (('[Press enter to continue or ctrl-C to quit]',), ''),
1477 ]
1478
1479 class MockChangelist():
1480 def __init__(self):
1481 pass
1482 def GetBranch(self):
1483 return 'test1'
1484 def GetIssue(self):
1485 return '123'
1486 def GetPatchset(self):
1487 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001488 def IsGerrit(self):
1489 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001490
1491 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1492 # CMDupload should have been called 5 times because of 5 dependent branches.
1493 self.assertEquals(5, record_calls.times_called)
1494 self.assertEquals(0, ret)
1495
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001496 def test_gerrit_change_id(self):
1497 self.calls = [
1498 ((['git', 'write-tree'], ),
1499 'hashtree'),
1500 ((['git', 'rev-parse', 'HEAD~0'], ),
1501 'branch-parent'),
1502 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1503 'A B <a@b.org> 1456848326 +0100'),
1504 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1505 'C D <c@d.org> 1456858326 +0100'),
1506 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1507 'hashchange'),
1508 ]
1509 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1510 self.assertEqual(change_id, 'Ihashchange')
1511
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001512 def test_desecription_append_footer(self):
1513 for init_desc, footer_line, expected_desc in [
1514 # Use unique desc first lines for easy test failure identification.
1515 ('foo', 'R=one', 'foo\n\nR=one'),
1516 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1517 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1518 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1519 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1520 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1521 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1522 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1523 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1524 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1525 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1526 ]:
1527 desc = git_cl.ChangeDescription(init_desc)
1528 desc.append_footer(footer_line)
1529 self.assertEqual(desc.description, expected_desc)
1530
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001531 def test_update_reviewers(self):
1532 data = [
1533 ('foo', [], 'foo'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001534 ('foo\nR=xx', [], 'foo\nR=xx'),
1535 ('foo\nTBR=xx', [], 'foo\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001536 ('foo', ['a@c'], 'foo\n\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001537 ('foo\nR=xx', ['a@c'], 'foo\n\nR=a@c, xx'),
1538 ('foo\nTBR=xx', ['a@c'], 'foo\n\nR=a@c\nTBR=xx'),
1539 ('foo\nTBR=xx\nR=yy', ['a@c'], 'foo\n\nR=a@c, yy\nTBR=xx'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001540 ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
agable@chromium.org42c20792013-09-12 17:34:49 +00001541 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\n\nR=a@c, xx, bar\nTBR=yy'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001542 ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001543 ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1544 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
1545 # Same as the line before, but full of whitespaces.
1546 (
1547 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'],
1548 'foo\nBar\n\nR=c@c\n BUG =',
1549 ),
1550 # Whitespaces aren't interpreted as new lines.
1551 ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001552 ]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001553 expected = [i[2] for i in data]
1554 actual = []
1555 for orig, reviewers, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001556 obj = git_cl.ChangeDescription(orig)
1557 obj.update_reviewers(reviewers)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001558 actual.append(obj.description)
1559 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001560
wittman@chromium.org455dc922015-01-26 20:15:50 +00001561 def test_get_target_ref(self):
1562 # Check remote or remote branch not present.
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001563 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001564 self.assertEqual(None, git_cl.GetTargetRef(None,
1565 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001566 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001567
wittman@chromium.org455dc922015-01-26 20:15:50 +00001568 # Check default target refs for branches.
1569 self.assertEqual('refs/heads/master',
1570 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001571 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001572 self.assertEqual('refs/heads/master',
1573 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001574 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001575 self.assertEqual('refs/heads/master',
1576 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001577 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001578 self.assertEqual('refs/branch-heads/123',
1579 git_cl.GetTargetRef('origin',
1580 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001581 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001582 self.assertEqual('refs/diff/test',
1583 git_cl.GetTargetRef('origin',
1584 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001585 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001586 self.assertEqual('refs/heads/chrome/m42',
1587 git_cl.GetTargetRef('origin',
1588 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001589 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001590
1591 # Check target refs for user-specified target branch.
1592 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1593 'refs/remotes/branch-heads/123'):
1594 self.assertEqual('refs/branch-heads/123',
1595 git_cl.GetTargetRef('origin',
1596 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001597 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001598 for branch in ('origin/master', 'remotes/origin/master',
1599 'refs/remotes/origin/master'):
1600 self.assertEqual('refs/heads/master',
1601 git_cl.GetTargetRef('origin',
1602 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001603 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001604 for branch in ('master', 'heads/master', 'refs/heads/master'):
1605 self.assertEqual('refs/heads/master',
1606 git_cl.GetTargetRef('origin',
1607 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001608 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001609
wychen@chromium.orga872e752015-04-28 23:42:18 +00001610 def test_patch_when_dirty(self):
1611 # Patch when local tree is dirty
1612 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1613 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1614
1615 def test_diff_when_dirty(self):
1616 # Do 'git cl diff' when local tree is dirty
1617 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1618 self.assertNotEqual(git_cl.main(['diff']), 0)
1619
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001620 @staticmethod
1621 def _get_gerrit_codereview_server_calls(branch, value=None,
1622 git_short_host='host',
1623 detect_branch=True):
1624 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1625
1626 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1627 """
1628 calls = []
1629 if detect_branch:
1630 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
1631 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1632 CERR1 if value is None else value))
1633 if value is None:
1634 calls += [
1635 ((['git', 'config', 'branch.' + branch + '.merge'],),
1636 'refs/heads' + branch),
1637 ((['git', 'config', 'branch.' + branch + '.remote'],),
1638 'origin'),
1639 ((['git', 'config', 'remote.origin.url'],),
1640 'https://%s.googlesource.com/my/repo' % git_short_host),
1641 ]
1642 return calls
1643
tandriidf09a462016-08-18 16:23:55 -07001644 def _patch_common(self, is_gerrit=False, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001645 new_branch=False, git_short_host='host',
1646 detect_gerrit_server=True):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001647 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001648 self.mock(git_cl._RietveldChangelistImpl, 'GetMostRecentPatchset',
1649 lambda x: '60001')
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001650 self.mock(git_cl._RietveldChangelistImpl, 'FetchDescription',
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001651 lambda *args: 'Description')
wychen@chromium.orga872e752015-04-28 23:42:18 +00001652 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1653
tandriidf09a462016-08-18 16:23:55 -07001654 if new_branch:
1655 self.calls = [((['git', 'new-branch', 'master'],), ''),]
1656 else:
1657 self.calls = [((['git', 'symbolic-ref', 'HEAD'],), 'master')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001658
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001659 if not force_codereview:
1660 # These calls detect codereview to use.
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001661 self.calls += [
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001662 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandrii33a46ff2016-08-23 05:53:40 -07001663 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1664 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
tandrii5d48c322016-08-18 16:19:37 -07001665 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001666 ]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001667
1668 if is_gerrit:
1669 if not force_codereview:
1670 self.calls += [
1671 ((['git', 'config', 'gerrit.host'],), 'true'),
1672 ]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001673 if detect_gerrit_server:
1674 self.calls += self._get_gerrit_codereview_server_calls(
1675 'master', git_short_host=git_short_host,
1676 detect_branch=not new_branch and force_codereview)
1677
1678 self.calls += [
1679 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001680 '123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001681 {
1682 'current_revision': '7777777777',
1683 'revisions': {
1684 '1111111111': {
1685 '_number': 1,
1686 'fetch': {'http': {
1687 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1688 'ref': 'refs/changes/56/123456/1',
1689 }},
1690 },
1691 '7777777777': {
1692 '_number': 7,
1693 'fetch': {'http': {
1694 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1695 'ref': 'refs/changes/56/123456/7',
1696 }},
1697 },
1698 },
1699 }),
1700 ]
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001701 else:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001702 self.calls += [
tandrii5d48c322016-08-18 16:19:37 -07001703 ((['git', 'config', 'gerrit.host'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001704 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
skobes6468b902016-10-24 08:45:10 -07001705 ((['git', 'config', 'branch.master.rietveldserver',],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001706 ((['git', 'rev-parse', '--show-cdup'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001707 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001708
tandriidf09a462016-08-18 16:23:55 -07001709 def _common_patch_successful(self, new_branch=False):
1710 self._patch_common(new_branch=new_branch)
wychen@chromium.orga872e752015-04-28 23:42:18 +00001711 self.calls += [
wychen@chromium.orga872e752015-04-28 23:42:18 +00001712 ((['git', 'commit', '-m',
wychen@chromium.org5b3bebb2015-05-28 21:41:43 +00001713 'Description\n\n' +
wychen@chromium.orga872e752015-04-28 23:42:18 +00001714 'patch from issue 123456 at patchset 60001 ' +
1715 '(http://crrev.com/123456#ps60001)'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001716 ((['git', 'config', 'branch.master.rietveldissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001717 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001718 ((['git', 'config', 'branch.master.rietveldserver',
1719 'https://codereview.example.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001720 ((['git', 'config', 'branch.master.rietveldpatchset', '60001'],),
tandrii5d48c322016-08-18 16:19:37 -07001721 ''),
wychen@chromium.orga872e752015-04-28 23:42:18 +00001722 ]
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001723
1724 def test_patch_successful(self):
1725 self._common_patch_successful()
wychen@chromium.orga872e752015-04-28 23:42:18 +00001726 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1727
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001728 def test_patch_successful_new_branch(self):
tandriidf09a462016-08-18 16:23:55 -07001729 self._common_patch_successful(new_branch=True)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00001730 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1731
wychen@chromium.orga872e752015-04-28 23:42:18 +00001732 def test_patch_conflict(self):
1733 self._patch_common()
skobes6468b902016-10-24 08:45:10 -07001734 GitCheckoutMock.conflict = True
wychen@chromium.orga872e752015-04-28 23:42:18 +00001735 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
wittman@chromium.org455dc922015-01-26 20:15:50 +00001736
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001737 def test_gerrit_patch_successful(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001738 self._patch_common(is_gerrit=True, git_short_host='chromium',
1739 detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001740 self.calls += [
1741 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1742 'refs/changes/56/123456/7'],), ''),
1743 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001744 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001745 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001746 ((['git', 'config', 'branch.master.gerritserver',
1747 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001748 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001749 ]
1750 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1751
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001752 def test_patch_force_codereview(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001753 self._patch_common(is_gerrit=True, force_codereview=True,
1754 git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001755 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001756 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001757 'refs/changes/56/123456/7'],), ''),
1758 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001759 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001760 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001761 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001762 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001763 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001764 ]
1765 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456']), 0)
1766
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001767 def test_gerrit_patch_url_successful(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001768 self._patch_common(is_gerrit=True, git_short_host='else',
1769 detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001770 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001771 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001772 'refs/changes/56/123456/1'],), ''),
1773 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001774 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001775 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001776 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001777 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001778 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001779 ]
1780 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001781 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001782
1783 def test_gerrit_patch_conflict(self):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001784 self._patch_common(is_gerrit=True, detect_gerrit_server=False,
1785 git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001786 self.calls += [
1787 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1788 'refs/changes/56/123456/1'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001789 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1790 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1791 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001792 ]
1793 with self.assertRaises(SystemExitMock):
1794 git_cl.main(['patch',
1795 'https://chromium-review.googlesource.com/#/c/123456/1'])
1796
tandriic2405f52016-10-10 08:13:15 -07001797 def test_gerrit_patch_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001798 def notExists(_issue, *_, **kwargs):
1799 self.assertFalse(kwargs['ignore_404'])
1800 raise git_cl.gerrit_util.GerritError(404, '')
1801 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1802
tandriic2405f52016-10-10 08:13:15 -07001803 url = 'https://chromium-review.googlesource.com'
tandriic2405f52016-10-10 08:13:15 -07001804 self.calls = [
1805 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1806 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
1807 ((['git', 'config', 'branch.master.rietveldissue'],), CERR1),
1808 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
1809 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
1810 ((['git', 'config', 'gerrit.host'],), 'true'),
Aaron Gablea45ee112016-11-22 15:14:38 -08001811 ((['DieWithError', 'change 123456 at ' + url + ' does not exist '
tandriic2405f52016-10-10 08:13:15 -07001812 'or you have no access to it'],), SystemExitMock()),
1813 ]
1814 with self.assertRaises(SystemExitMock):
1815 self.assertEqual(1, git_cl.main(['patch', url + '/#/c/123456/1']))
1816
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001817 def _checkout_calls(self):
1818 return [
1819 ((['git', 'config', '--local', '--get-regexp',
1820 'branch\\..*\\.rietveldissue'], ),
1821 ('branch.retrying.rietveldissue 1111111111\n'
1822 'branch.some-fix.rietveldissue 2222222222\n')),
1823 ((['git', 'config', '--local', '--get-regexp',
1824 'branch\\..*\\.gerritissue'], ),
1825 ('branch.ger-branch.gerritissue 123456\n'
1826 'branch.gbranch654.gerritissue 654321\n')),
1827 ]
1828
1829 def test_checkout_gerrit(self):
1830 """Tests git cl checkout <issue>."""
1831 self.calls = self._checkout_calls()
1832 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1833 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1834
1835 def test_checkout_rietveld(self):
1836 """Tests git cl checkout <issue>."""
1837 self.calls = self._checkout_calls()
1838 self.calls += [((['git', 'checkout', 'some-fix'], ), '')]
1839 self.assertEqual(0, git_cl.main(['checkout', '2222222222']))
1840
1841 def test_checkout_not_found(self):
1842 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001843 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001844 self.calls = self._checkout_calls()
1845 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1846
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001847 def test_checkout_no_branch_issues(self):
1848 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001849 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001850 self.calls = [
1851 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001852 'branch\\..*\\.rietveldissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001853 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001854 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001855 ]
1856 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1857
tandrii@chromium.org28253532016-04-14 13:46:56 +00001858 def _test_gerrit_ensure_authenticated_common(self, auth,
1859 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001860 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1861 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1862 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001863 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001864 self.mock(git_cl, 'ask_for_data',
1865 lambda msg: self._mocked_call(['ask_for_data', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001866 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001867 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001868 cl.branch = 'master'
1869 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001870 cl.lookedup_issue = True
1871 return cl
1872
1873 def test_gerrit_ensure_authenticated_missing(self):
1874 cl = self._test_gerrit_ensure_authenticated_common(auth={
1875 'chromium.googlesource.com': 'git is ok, but gerrit one is missing',
1876 })
1877 self.calls.append(
1878 ((['DieWithError',
1879 'Credentials for the following hosts are required:\n'
1880 ' chromium-review.googlesource.com\n'
1881 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1882 'You can (re)generate your credentails by visiting '
1883 'https://chromium-review.googlesource.com/new-password'],), ''),)
1884 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1885
1886 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001887 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001888 cl = self._test_gerrit_ensure_authenticated_common(auth={
1889 'chromium.googlesource.com': 'one',
1890 'chromium-review.googlesource.com': 'other',
1891 })
1892 self.calls.append(
1893 ((['ask_for_data', 'If you know what you are doing, '
qyearsley53f48a12016-09-01 10:45:13 -07001894 'press Enter to continue, Ctrl+C to abort.'],), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001895 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1896
1897 def test_gerrit_ensure_authenticated_ok(self):
1898 cl = self._test_gerrit_ensure_authenticated_common(auth={
1899 'chromium.googlesource.com': 'same',
1900 'chromium-review.googlesource.com': 'same',
1901 })
1902 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1903
tandrii@chromium.org28253532016-04-14 13:46:56 +00001904 def test_gerrit_ensure_authenticated_skipped(self):
1905 cl = self._test_gerrit_ensure_authenticated_common(
1906 auth={}, skip_auth_check=True)
1907 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1908
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001909 def test_cmd_set_commit_rietveld(self):
tandrii4d843592016-07-27 08:22:56 -07001910 self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
1911 lambda _, v: self._mocked_call(['SetFlags', v]))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001912 self.calls = [
1913 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001914 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001915 ((['git', 'config', 'rietveld.autoupdate'],), ''),
1916 ((['git', 'config', 'rietveld.server'],), ''),
1917 ((['git', 'config', 'rietveld.server'],), ''),
1918 ((['git', 'config', 'branch.feature.rietveldserver'],),
1919 'https://codereview.chromium.org'),
tandrii4d843592016-07-27 08:22:56 -07001920 ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001921 ]
1922 self.assertEqual(0, git_cl.main(['set-commit']))
1923
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001924 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001925 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001926 lambda h, i, labels, notify=None:
1927 self._mocked_call(['SetReview', h, i, labels, notify]))
1928
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001929 self.calls = [
1930 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07001931 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
1932 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001933 ((['git', 'config', 'branch.feature.gerritserver'],),
1934 'https://chromium-review.googlesource.com'),
1935 ((['SetReview', 'chromium-review.googlesource.com', 123,
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001936 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001937 ]
tandriid9e5ce52016-07-13 02:32:59 -07001938
1939 def test_cmd_set_commit_gerrit_clear(self):
1940 self._cmd_set_commit_gerrit_common(0)
1941 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1942
1943 def test_cmd_set_commit_gerrit_dry(self):
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001944 self._cmd_set_commit_gerrit_common(1, notify='NONE')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001945 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1946
tandriid9e5ce52016-07-13 02:32:59 -07001947 def test_cmd_set_commit_gerrit(self):
1948 self._cmd_set_commit_gerrit_common(2)
1949 self.assertEqual(0, git_cl.main(['set-commit']))
1950
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001951 def test_description_display(self):
1952 out = StringIO.StringIO()
1953 self.mock(git_cl.sys, 'stdout', out)
1954
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001955 self.mock(git_cl, 'Changelist', ChangelistMock)
1956 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001957
1958 self.assertEqual(0, git_cl.main(['description', '-d']))
1959 self.assertEqual('foo\n', out.getvalue())
1960
1961 def test_description_rietveld(self):
1962 out = StringIO.StringIO()
1963 self.mock(git_cl.sys, 'stdout', out)
martiniss6eda05f2016-06-30 10:18:35 -07001964 self.mock(git_cl.Changelist, 'GetDescription', lambda *args: 'foobar')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001965
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001966 self.assertEqual(0, git_cl.main([
1967 'description', 'https://code.review.org/123123', '-d', '--rietveld']))
1968 self.assertEqual('foobar\n', out.getvalue())
1969
iannucci3c972b92016-08-17 13:24:10 -07001970 def test_StatusFieldOverrideIssueMissingArgs(self):
1971 out = StringIO.StringIO()
1972 self.mock(git_cl.sys, 'stderr', out)
1973
1974 try:
1975 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
1976 except SystemExit as ex:
1977 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001978 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001979
1980 out = StringIO.StringIO()
1981 self.mock(git_cl.sys, 'stderr', out)
1982
1983 try:
1984 self.assertEqual(git_cl.main(['status', '--issue', '1', '--rietveld']), 0)
1985 except SystemExit as ex:
1986 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07001987 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07001988
1989 def test_StatusFieldOverrideIssue(self):
1990 out = StringIO.StringIO()
1991 self.mock(git_cl.sys, 'stdout', out)
1992
1993 def assertIssue(cl_self, *_args):
1994 self.assertEquals(cl_self.issue, 1)
1995 return 'foobar'
1996
1997 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
1998 self.calls = [
1999 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2000 ((['git', 'config', 'rietveld.server'],), ''),
2001 ((['git', 'config', 'rietveld.server'],), ''),
2002 ]
iannuccie53c9352016-08-17 14:40:40 -07002003 self.assertEqual(
2004 git_cl.main(['status', '--issue', '1', '--rietveld', '--field', 'desc']),
2005 0)
iannucci3c972b92016-08-17 13:24:10 -07002006 self.assertEqual(out.getvalue(), 'foobar\n')
2007
iannuccie53c9352016-08-17 14:40:40 -07002008 def test_SetCloseOverrideIssue(self):
2009 def assertIssue(cl_self, *_args):
2010 self.assertEquals(cl_self.issue, 1)
2011 return 'foobar'
2012
2013 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2014 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
2015 self.calls = [
2016 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2017 ((['git', 'config', 'rietveld.server'],), ''),
2018 ((['git', 'config', 'rietveld.server'],), ''),
2019 ]
2020 self.assertEqual(
2021 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2022
2023 def test_SetCommitOverrideIssue(self):
2024 def assertIssue(cl_self, *_args):
2025 self.assertEquals(cl_self.issue, 1)
2026 return 'foobar'
2027
2028 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2029 self.mock(git_cl.Changelist, 'SetCQState', lambda *_: None)
2030 self.calls = [
2031 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2032 ((['git', 'config', 'rietveld.server'],), ''),
2033 ((['git', 'config', 'rietveld.server'],), ''),
2034 ((['git', 'symbolic-ref', 'HEAD'],), ''),
2035 ((['git', 'config', 'rietveld.server'],), ''),
2036 ((['git', 'config', 'rietveld.server'],), ''),
2037 ]
2038 self.assertEqual(
2039 git_cl.main(['set-close', '--issue', '1', '--rietveld']), 0)
2040
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002041 def test_description_gerrit(self):
2042 out = StringIO.StringIO()
2043 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002044 self.calls = [
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002045 (('GetChangeDetail', 'code.review.org',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002046 '123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2047 {
2048 'current_revision': 'sha1',
2049 'revisions': {'sha1': {
2050 'commit': {'message': 'foobar'},
2051 }},
2052 }),
2053 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002054 self.assertEqual(0, git_cl.main([
2055 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
2056 self.assertEqual('foobar\n', out.getvalue())
2057
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002058 def test_description_set_raw(self):
2059 out = StringIO.StringIO()
2060 self.mock(git_cl.sys, 'stdout', out)
2061
2062 self.mock(git_cl, 'Changelist', ChangelistMock)
2063 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2064
2065 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2066 self.assertEqual('hihi', ChangelistMock.desc)
2067
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002068 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002069 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002070
2071 def RunEditor(desc, _, **kwargs):
2072 self.assertEquals(
2073 '# Enter a description of the change.\n'
2074 '# This will be displayed on the codereview site.\n'
2075 '# The first line will also be used as the subject of the review.\n'
2076 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002077 '--------------------\n'
2078 'Some.\n\nBUG=\n\nChange-Id: xxx',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002079 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002080 # Simulate user changing something.
2081 return 'Some.\n\nBUG=123\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002082
dsansomee2d6fd92016-09-08 00:10:47 -07002083 def UpdateDescriptionRemote(_, desc, force=False):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002084 self.assertEquals(desc, 'Some.\n\nBUG=123\n\nChange-Id: xxx')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002085
2086 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2087 self.mock(git_cl.Changelist, 'GetDescription',
2088 lambda *args: current_desc)
2089 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2090 UpdateDescriptionRemote)
2091 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2092
2093 self.calls = [
2094 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002095 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002096 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2097 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002098 ((['git', 'config', 'core.editor'],), 'vi'),
2099 ]
2100 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2101
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002102 def test_description_set_stdin(self):
2103 out = StringIO.StringIO()
2104 self.mock(git_cl.sys, 'stdout', out)
2105
2106 self.mock(git_cl, 'Changelist', ChangelistMock)
2107 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2108
2109 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2110 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2111
kmarshall3bff56b2016-06-06 18:31:47 -07002112 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002113 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2114
kmarshall3bff56b2016-06-06 18:31:47 -07002115 self.calls = \
2116 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2117 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
tandrii33a46ff2016-08-23 05:53:40 -07002118 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002119 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2120 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
tandrii33a46ff2016-08-23 05:53:40 -07002121 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2122 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2123 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002124 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2125 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2126 ((['git', 'branch', '-D', 'foo'],), '')]
2127
kmarshall3bff56b2016-06-06 18:31:47 -07002128 self.mock(git_cl, 'get_cl_statuses',
2129 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002130 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2131 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2132 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002133
2134 self.assertEqual(0, git_cl.main(['archive', '-f']))
2135
2136 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002137 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002138 self.calls = \
2139 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2140 'refs/heads/master'),
tandrii33a46ff2016-08-23 05:53:40 -07002141 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
tandrii5d48c322016-08-18 16:19:37 -07002142 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2143 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
kmarshall3bff56b2016-06-06 18:31:47 -07002144 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2145
kmarshall9249e012016-08-23 12:02:16 -07002146 self.mock(git_cl, 'get_cl_statuses',
2147 lambda branches, fine_grained, max_processes:
2148 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2149
2150 self.assertEqual(1, git_cl.main(['archive', '-f']))
2151
2152 def test_archive_dry_run(self):
2153 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2154
2155 self.calls = \
2156 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2157 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2158 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2159 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2160 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2161 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2162 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2163 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2164 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002165
2166 self.mock(git_cl, 'get_cl_statuses',
2167 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002168 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2169 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2170 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002171
kmarshall9249e012016-08-23 12:02:16 -07002172 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2173
2174 def test_archive_no_tags(self):
2175 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2176
2177 self.calls = \
2178 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2179 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2180 ((['git', 'config', 'branch.master.rietveldissue'],), '1'),
2181 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2182 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2183 ((['git', 'config', 'branch.foo.rietveldissue'],), '456'),
2184 ((['git', 'config', 'branch.bar.rietveldissue'],), CERR1),
2185 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2186 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2187 ((['git', 'branch', '-D', 'foo'],), '')]
2188
2189 self.mock(git_cl, 'get_cl_statuses',
2190 lambda branches, fine_grained, max_processes:
2191 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2192 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2193 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2194
2195 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002196
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002197 def test_cmd_issue_erase_existing(self):
2198 out = StringIO.StringIO()
2199 self.mock(git_cl.sys, 'stdout', out)
2200 self.calls = [
2201 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002202 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2203 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002204 # Let this command raise exception (retcode=1) - it should be ignored.
2205 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002206 CERR1),
2207 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2208 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002209 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2210 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2211 ''),
2212 ]
2213 self.assertEqual(0, git_cl.main(['issue', '0']))
2214
phajdan.jre328cf92016-08-22 04:12:17 -07002215 def test_cmd_issue_json(self):
2216 out = StringIO.StringIO()
2217 self.mock(git_cl.sys, 'stdout', out)
2218 self.calls = [
2219 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002220 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
phajdan.jre328cf92016-08-22 04:12:17 -07002221 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2222 ((['git', 'config', 'rietveld.server'],),
2223 'https://codereview.chromium.org'),
2224 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2225 (('write_json', 'output.json',
2226 {'issue': 123, 'issue_url': 'https://codereview.chromium.org/123'}),
2227 ''),
2228 ]
2229 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2230
tandriide281ae2016-10-12 06:02:30 -07002231 def test_git_cl_try_default_cq_dry_run(self):
tandrii9de9ec62016-07-13 03:01:59 -07002232 self.mock(git_cl.Changelist, 'GetChange',
2233 lambda _, *a: (
2234 self._mocked_call(['GetChange']+list(a))))
2235 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2236 lambda *_, **__: (
2237 self._mocked_call(['DoGetTryMasters'])))
tandrii9de9ec62016-07-13 03:01:59 -07002238 self.mock(git_cl._RietveldChangelistImpl, 'SetCQState',
2239 lambda _, s: self._mocked_call(['SetCQState', s]))
2240 self.calls = [
2241 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002242 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
tandrii9de9ec62016-07-13 03:01:59 -07002243 ((['git', 'config', 'rietveld.autoupdate'],), ''),
2244 ((['git', 'config', 'rietveld.server'],),
2245 'https://codereview.chromium.org'),
2246 ((['git', 'config', 'branch.feature.rietveldserver'],), ''),
2247 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2248 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2249 ((['get_or_create_merge_base', 'feature', 'feature'],),
2250 'fake_ancestor_sha'),
2251 ((['GetChange', 'fake_ancestor_sha', None], ),
2252 git_cl.presubmit_support.GitChange(
2253 '', '', '', '', '', '', '', '')),
2254 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2255 ((['DoGetTryMasters'], ), None),
tandrii9de9ec62016-07-13 03:01:59 -07002256 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2257 ]
2258 out = StringIO.StringIO()
2259 self.mock(git_cl.sys, 'stdout', out)
2260 self.assertEqual(0, git_cl.main(['try']))
2261 self.assertEqual(
2262 out.getvalue(),
2263 'scheduled CQ Dry Run on https://codereview.chromium.org/123\n')
2264
tandrii8c5a3532016-11-04 07:52:02 -07002265 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2266 self.mock(git_cl.Changelist, 'GetChange',
2267 lambda _, *a: (
2268 self._mocked_call(['GetChange']+list(a))))
2269 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2270 lambda *_, **__: (
2271 self._mocked_call(['DoGetTryMasters'])))
2272 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2273 lambda _, s: self._mocked_call(['SetCQState', s]))
2274
tandrii8c5a3532016-11-04 07:52:02 -07002275 self.calls = [
2276 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2277 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2278 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2279 ((['git', 'config', 'branch.feature.gerritserver'],),
2280 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002281 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456', []),
2282 { 'status': 'OPEN' }),
tandrii8c5a3532016-11-04 07:52:02 -07002283 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2284 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2285 ((['get_or_create_merge_base', 'feature', 'feature'],),
2286 'fake_ancestor_sha'),
2287 ((['GetChange', 'fake_ancestor_sha', None], ),
2288 git_cl.presubmit_support.GitChange(
2289 '', '', '', '', '', '', '', '')),
2290 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2291 ((['DoGetTryMasters'], ), None),
2292 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2293 ]
2294 out = StringIO.StringIO()
2295 self.mock(git_cl.sys, 'stdout', out)
2296 self.assertEqual(0, git_cl.main(['try']))
2297 self.assertEqual(
2298 out.getvalue(),
2299 'scheduled CQ Dry Run on '
2300 'https://chromium-review.googlesource.com/123456\n')
2301
2302 def test_git_cl_try_buildbucket_with_properties_rietveld(self):
2303 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2304 lambda _: {
2305 'owner_email': 'owner@e.mail',
2306 'private': False,
2307 'closed': False,
2308 'project': 'depot_tools',
2309 'patchsets': [20001],
2310 })
tandriide281ae2016-10-12 06:02:30 -07002311 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2312 self.calls = [
2313 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2314 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2315 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2316 ((['git', 'config', 'rietveld.server'],),
2317 'https://codereview.chromium.org'),
tandriide281ae2016-10-12 06:02:30 -07002318 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002319 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
tandriide281ae2016-10-12 06:02:30 -07002320 ]
2321
2322 def _buildbucket_retry(*_, **kw):
2323 # self.maxDiff = 10000
2324 body = json.loads(kw['body'])
2325 self.assertEqual(len(body['builds']), 1)
2326 build = body['builds'][0]
2327 params = json.loads(build.pop('parameters_json'))
2328 self.assertEqual(params, {
2329 u'builder_name': u'win',
2330 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2331 u'revision': None}],
2332 u'properties': {
2333 u'category': u'git_cl_try',
2334 u'issue': 123,
2335 u'key': u'val',
2336 u'json': [{u'a': 1}, None],
2337 u'master': u'tryserver.chromium',
2338 u'patch_project': u'depot_tools',
2339 u'patch_storage': u'rietveld',
2340 u'patchset': 20001,
tandriide281ae2016-10-12 06:02:30 -07002341 u'rietveld': u'https://codereview.chromium.org',
2342 }
2343 })
2344 self.assertEqual(build, {
2345 u'bucket': u'master.tryserver.chromium',
2346 u'client_operation_id': u'uuid4',
2347 u'tags': [u'builder:win',
2348 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
borenet6c0efe62016-10-19 08:13:29 -07002349 u'user_agent:git_cl_try',
2350 u'master:tryserver.chromium'],
tandriide281ae2016-10-12 06:02:30 -07002351 })
2352
2353 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2354
2355 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2356 self.assertEqual(0, git_cl.main([
2357 'try', '-m', 'tryserver.chromium', '-b', 'win',
2358 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2359 self.assertRegexpMatches(
2360 git_cl.sys.stdout.getvalue(),
borenet6c0efe62016-10-19 08:13:29 -07002361 'Tried jobs on:\nBucket: master.tryserver.chromium')
2362
tandrii8c5a3532016-11-04 07:52:02 -07002363 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2364 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2365 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2366
tandrii8c5a3532016-11-04 07:52:02 -07002367 self.calls = [
2368 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2369 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2370 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2371 ((['git', 'config', 'branch.feature.gerritserver'],),
2372 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002373 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456', []),
2374 { 'status': 'OPEN' }),
2375 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456',
2376 ['DETAILED_ACCOUNTS']),
tandrii8c5a3532016-11-04 07:52:02 -07002377 {'owner': {'email': 'owner@e.mail'}}),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002378 (('GetChangeDetail', 'chromium-review.googlesource.com', '123456',
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002379 ['ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002380 'project': 'depot_tools',
2381 'revisions': {
2382 'deadbeaf': {
2383 '_number': 6,
2384 },
2385 'beeeeeef': {
2386 '_number': 7,
2387 'fetch': {'http': {
2388 'url': 'https://chromium.googlesource.com/depot_tools',
2389 'ref': 'refs/changes/56/123456/7'
2390 }},
2391 },
2392 },
2393 }),
2394 ]
2395
2396 def _buildbucket_retry(*_, **kw):
2397 # self.maxDiff = 10000
2398 body = json.loads(kw['body'])
2399 self.assertEqual(len(body['builds']), 1)
2400 build = body['builds'][0]
2401 params = json.loads(build.pop('parameters_json'))
2402 self.assertEqual(params, {
2403 u'builder_name': u'win',
2404 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2405 u'revision': None}],
2406 u'properties': {
2407 u'category': u'git_cl_try',
2408 u'key': u'val',
2409 u'json': [{u'a': 1}, None],
2410 u'master': u'tryserver.chromium',
2411
2412 u'patch_gerrit_url':
2413 u'https://chromium-review.googlesource.com',
2414 u'patch_issue': 123456,
2415 u'patch_project': u'depot_tools',
2416 u'patch_ref': u'refs/changes/56/123456/7',
2417 u'patch_repository_url':
2418 u'https://chromium.googlesource.com/depot_tools',
2419 u'patch_set': 7,
2420 u'patch_storage': u'gerrit',
2421 }
2422 })
2423 self.assertEqual(build, {
2424 u'bucket': u'master.tryserver.chromium',
2425 u'client_operation_id': u'uuid4',
2426 u'tags': [
2427 u'builder:win',
2428 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2429 u'user_agent:git_cl_try',
2430 u'master:tryserver.chromium'],
2431 })
2432
2433 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2434
2435 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2436 self.assertEqual(0, git_cl.main([
2437 'try', '-m', 'tryserver.chromium', '-b', 'win',
2438 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2439 self.assertRegexpMatches(
2440 git_cl.sys.stdout.getvalue(),
2441 'Tried jobs on:\nBucket: master.tryserver.chromium')
2442
borenet6c0efe62016-10-19 08:13:29 -07002443 def test_git_cl_try_buildbucket_bucket_flag(self):
tandrii8c5a3532016-11-04 07:52:02 -07002444 self.mock(git_cl._RietveldChangelistImpl, 'GetIssueProperties',
2445 lambda _: {
2446 'owner_email': 'owner@e.mail',
2447 'private': False,
2448 'closed': False,
2449 'project': 'depot_tools',
2450 'patchsets': [20001],
2451 })
borenet6c0efe62016-10-19 08:13:29 -07002452 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2453 self.calls = [
2454 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2455 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2456 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2457 ((['git', 'config', 'rietveld.server'],),
2458 'https://codereview.chromium.org'),
borenet6c0efe62016-10-19 08:13:29 -07002459 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
tandrii8c5a3532016-11-04 07:52:02 -07002460 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
borenet6c0efe62016-10-19 08:13:29 -07002461 ]
2462
2463 def _buildbucket_retry(*_, **kw):
borenet6c0efe62016-10-19 08:13:29 -07002464 body = json.loads(kw['body'])
2465 self.assertEqual(len(body['builds']), 1)
2466 build = body['builds'][0]
2467 params = json.loads(build.pop('parameters_json'))
2468 self.assertEqual(params, {
2469 u'builder_name': u'win',
2470 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2471 u'revision': None}],
2472 u'properties': {
2473 u'category': u'git_cl_try',
2474 u'issue': 123,
2475 u'patch_project': u'depot_tools',
2476 u'patch_storage': u'rietveld',
2477 u'patchset': 20001,
borenet6c0efe62016-10-19 08:13:29 -07002478 u'rietveld': u'https://codereview.chromium.org',
2479 }
2480 })
2481 self.assertEqual(build, {
2482 u'bucket': u'test.bucket',
2483 u'client_operation_id': u'uuid4',
2484 u'tags': [u'builder:win',
2485 u'buildset:patch/rietveld/codereview.chromium.org/123/20001',
2486 u'user_agent:git_cl_try'],
2487 })
2488
2489 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2490
2491 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2492 self.assertEqual(0, git_cl.main([
2493 'try', '-B', 'test.bucket', '-b', 'win']))
2494 self.assertRegexpMatches(
2495 git_cl.sys.stdout.getvalue(),
2496 'Tried jobs on:\nBucket: test.bucket')
tandriide281ae2016-10-12 06:02:30 -07002497
qyearsley123a4682016-10-26 09:12:17 -07002498 def test_git_cl_try_bots_on_multiple_masters(self):
2499 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 20001)
2500 self.calls = [
2501 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2502 ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
2503 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2504 ((['git', 'config', 'rietveld.server'],),
tandrii8c5a3532016-11-04 07:52:02 -07002505 'https://codereview.chromium.org'),
qyearsley123a4682016-10-26 09:12:17 -07002506 ((['git', 'config', 'branch.feature.rietveldserver'],), CERR1),
2507 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2508 ]
2509
2510 def _buildbucket_retry(*_, **kw):
2511 body = json.loads(kw['body'])
2512 self.assertEqual(len(body['builds']), 2)
2513
2514 first_build_params = json.loads(body['builds'][0]['parameters_json'])
2515 self.assertEqual(first_build_params['builder_name'], 'builder1')
2516 self.assertEqual(first_build_params['properties']['master'], 'master1')
2517
2518 first_build_params = json.loads(body['builds'][1]['parameters_json'])
2519 self.assertEqual(first_build_params['builder_name'], 'builder2')
2520 self.assertEqual(first_build_params['properties']['master'], 'master2')
2521
2522 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2523
2524 self.mock(git_cl.urllib2, 'urlopen', lambda _: StringIO.StringIO(
2525 json.dumps({'builder1': ['master1'], 'builder2': ['master2']})))
2526
2527 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2528 self.assertEqual(
2529 0, git_cl.main(['try', '-b', 'builder1', '-b', 'builder2']))
2530 self.assertEqual(
2531 git_cl.sys.stdout.getvalue(),
2532 'Tried jobs on:\n'
2533 'Bucket: master.master1\n'
2534 ' builder1: []\n'
2535 'Bucket: master.master2\n'
2536 ' builder2: []\n'
2537 'To see results here, run: git cl try-results\n'
2538 'To see results in browser, run: git cl web\n')
2539
tandrii16e0b4e2016-06-07 10:34:28 -07002540 def _common_GerritCommitMsgHookCheck(self):
2541 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2542 self.mock(git_cl.os.path, 'abspath',
2543 lambda path: self._mocked_call(['abspath', path]))
2544 self.mock(git_cl.os.path, 'exists',
2545 lambda path: self._mocked_call(['exists', path]))
2546 self.mock(git_cl.gclient_utils, 'FileRead',
2547 lambda path: self._mocked_call(['FileRead', path]))
2548 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2549 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2550 self.calls = [
2551 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2552 ((['abspath', '../'],), '/abs/git_repo_root'),
2553 ]
2554 return git_cl.Changelist(codereview='gerrit', issue=123)
2555
2556 def test_GerritCommitMsgHookCheck_custom_hook(self):
2557 cl = self._common_GerritCommitMsgHookCheck()
2558 self.calls += [
2559 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2560 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2561 '#!/bin/sh\necho "custom hook"')
2562 ]
2563 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2564
2565 def test_GerritCommitMsgHookCheck_not_exists(self):
2566 cl = self._common_GerritCommitMsgHookCheck()
2567 self.calls += [
2568 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2569 ]
2570 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2571
2572 def test_GerritCommitMsgHookCheck(self):
2573 cl = self._common_GerritCommitMsgHookCheck()
2574 self.calls += [
2575 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2576 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2577 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
2578 (('Do you want to remove it now? [Yes/No]',), 'Yes'),
2579 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2580 ''),
2581 ]
2582 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2583
tandriic4344b52016-08-29 06:04:54 -07002584 def test_GerritCmdLand(self):
2585 self.calls += [
2586 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2587 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2588 'deadbeaf'),
2589 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2590 ((['git', 'config', 'branch.feature.gerritserver'],),
2591 'chromium-review.googlesource.com'),
2592 ]
2593 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2594 cl._codereview_impl._GetChangeDetail = lambda _: {
2595 'labels': {},
2596 'current_revision': 'deadbeaf',
2597 }
agable32978d92016-11-01 12:55:02 -07002598 cl._codereview_impl._GetChangeCommit = lambda: {
2599 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002600 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002601 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2602 }
tandriic4344b52016-08-29 06:04:54 -07002603 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002604 out = StringIO.StringIO()
2605 self.mock(sys, 'stdout', out)
tandriic4344b52016-08-29 06:04:54 -07002606 self.assertEqual(0, cl.CMDLand(force=True, bypass_hooks=True, verbose=True))
tandrii8da412c2016-09-07 16:01:07 -07002607 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
agable32978d92016-11-01 12:55:02 -07002608 self.assertRegexpMatches(out.getvalue(), 'Landed as .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002609
tandrii221ab252016-10-06 08:12:04 -07002610 BUILDBUCKET_BUILDS_MAP = {
2611 '9000': {
2612 'id': '9000',
2613 'status': 'STARTED',
2614 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2615 'result_details_json': '{"properties": {}}',
2616 'bucket': 'master.x.y',
2617 'created_by': 'user:someone@chromium.org',
2618 'created_ts': '147200002222000',
2619 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2620 },
2621 '8000': {
2622 'id': '8000',
2623 'status': 'COMPLETED',
2624 'result': 'FAILURE',
2625 'failure_reason': 'BUILD_FAILURE',
2626 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2627 'result_details_json': '{"properties": {}}',
2628 'bucket': 'master.x.y',
2629 'created_by': 'user:someone@chromium.org',
2630 'created_ts': '147200001111000',
2631 'parameters_json': '{"builder_name": "my-builder", "category": ""}',
2632 },
2633 }
2634
2635 def test_write_try_results_json(self):
2636 expected_output = [
2637 {
2638 'buildbucket_id': '8000',
2639 'bucket': 'master.x.y',
2640 'builder_name': 'my-builder',
2641 'status': 'COMPLETED',
2642 'result': 'FAILURE',
2643 'failure_reason': 'BUILD_FAILURE',
2644 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/1',
2645 },
2646 {
2647 'buildbucket_id': '9000',
2648 'bucket': 'master.x.y',
2649 'builder_name': 'my-builder',
2650 'status': 'STARTED',
2651 'result': None,
2652 'failure_reason': None,
2653 'url': 'http://build.cr.org/p/x.y/builders/my-builder/builds/2',
2654 }
2655 ]
2656 self.calls = [(('write_json', 'output.json', expected_output), '')]
2657 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2658
tandrii45b2a582016-10-11 03:14:16 -07002659 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002660 out = StringIO.StringIO()
2661 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002662 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2663 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002664 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2665 self._mocked_call(['get_authenticator_for_host', host]))
2666 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2667 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002668
2669 def _setup_fetch_try_jobs_rietveld(self, *request_results):
2670 self._setup_fetch_try_jobs(most_recent_patchset=20001)
tandrii221ab252016-10-06 08:12:04 -07002671 self.calls += [
2672 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2673 ((['git', 'config', 'branch.feature.rietveldissue'],), '1'),
2674 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2675 ((['git', 'config', 'rietveld.server'],), 'codereview.example.com'),
2676 ((['git', 'config', 'branch.feature.rietveldpatchset'],), '20001'),
2677 ((['git', 'config', 'branch.feature.rietveldserver'],),
2678 'codereview.example.com'),
2679 ((['get_authenticator_for_host', 'codereview.example.com'],),
2680 AuthenticatorMock()),
2681 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2682
2683 def test_fetch_try_jobs_none_rietveld(self):
2684 self._setup_fetch_try_jobs_rietveld({})
tandrii45b2a582016-10-11 03:14:16 -07002685 # Simulate that user isn't logged in.
2686 self.mock(AuthenticatorMock, 'has_cached_credentials', lambda _: False)
tandrii221ab252016-10-06 08:12:04 -07002687 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002688 self.assertRegexpMatches(sys.stdout.getvalue(),
2689 'Warning: Some results might be missing')
tandrii221ab252016-10-06 08:12:04 -07002690 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2691
2692 def test_fetch_try_jobs_some_rietveld(self):
2693 self._setup_fetch_try_jobs_rietveld({
2694 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2695 })
2696 self.assertEqual(0, git_cl.main(['try-results']))
tandrii45b2a582016-10-11 03:14:16 -07002697 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
2698 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2699 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2700
2701 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2702 self._setup_fetch_try_jobs(most_recent_patchset=13)
2703 self.calls += [
2704 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2705 ((['git', 'config', 'branch.feature.rietveldissue'],), CERR1),
2706 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002707 # TODO(tandrii): Uncomment the below if we decide to support checking
2708 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002709 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002710 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002711 ((['git', 'config', 'branch.feature.gerritserver'],),
2712 'https://x-review.googlesource.com'),
2713 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2714 AuthenticatorMock()),
2715 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2716
2717 def test_fetch_try_jobs_none_gerrit(self):
2718 self._setup_fetch_try_jobs_gerrit({})
2719 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002720 # TODO(tandrii): Uncomment the below if we decide to support checking
2721 # patchsets for Gerrit.
2722 # self.assertRegexpMatches(
2723 # sys.stdout.getvalue(),
2724 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002725 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2726
2727 def test_fetch_try_jobs_some_gerrit(self):
2728 self._setup_fetch_try_jobs_gerrit({
2729 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2730 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002731 # TODO(tandrii): Uncomment the below if we decide to support checking
2732 # patchsets for Gerrit.
2733 # self.calls.remove(
2734 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002735 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2736
2737 # ... and doesn't result in warning.
2738 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2739 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002740 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2741 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2742
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002743 def _mock_gerrit_changes_for_detail_cache(self):
2744 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002745
2746 def test_gerrit_change_detail_cache_normalize(self):
2747 self._mock_gerrit_changes_for_detail_cache()
2748 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002749 (('GetChangeDetail', 'host', '2', ['CASE']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002750 ]
2751 cl = git_cl.Changelist(codereview='gerrit')
2752 self.assertEqual(cl._GetChangeDetail(issue=2, options=['CaSe']), 'b')
2753 self.assertEqual(cl._GetChangeDetail(issue=2, options=['CASE']), 'b')
2754 self.assertEqual(cl._GetChangeDetail(issue='2'), 'b')
2755 self.assertEqual(cl._GetChangeDetail(issue=2), 'b')
2756
2757 def test_gerrit_change_detail_cache_simple(self):
2758 self._mock_gerrit_changes_for_detail_cache()
2759 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002760 (('GetChangeDetail', 'host', '1', []), 'a'),
2761 (('GetChangeDetail', 'host', '2', []), 'b'),
2762 (('GetChangeDetail', 'host', '2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002763 ]
2764 cl = git_cl.Changelist(issue=1, codereview='gerrit')
2765 self.assertEqual(cl._GetChangeDetail(), 'a') # Miss.
2766 self.assertEqual(cl._GetChangeDetail(), 'a')
2767 self.assertEqual(cl._GetChangeDetail(issue=2), 'b') # Miss.
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002768 self.assertEqual(cl._GetChangeDetail(issue=2, no_cache=True), 'b2') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002769 self.assertEqual(cl._GetChangeDetail(), 'a')
2770 self.assertEqual(cl._GetChangeDetail(issue=2), 'b2')
2771
2772 def test_gerrit_change_detail_cache_options(self):
2773 self._mock_gerrit_changes_for_detail_cache()
2774 self.calls = [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002775 (('GetChangeDetail', 'host', '1', ['C', 'A', 'B']), 'cab'),
2776 (('GetChangeDetail', 'host', '1', ['A', 'D']), 'ad'),
2777 (('GetChangeDetail', 'host', '1', ['A']), 'a'), # no_cache=True
2778 (('GetChangeDetail', 'host', '1', ['B']), 'b'), # no longer in cache.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002779 ]
2780 cl = git_cl.Changelist(issue=1, codereview='gerrit')
2781 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2782 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2783 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2784 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2785 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2786 self.assertEqual(cl._GetChangeDetail(), 'cab')
2787
2788 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2789 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2790 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2791 self.assertEqual(cl._GetChangeDetail(), 'cab')
2792
2793 # Finally, no_cache should invalidate all caches for given change.
2794 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2795 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2796
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002797
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002798if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01002799 logging.basicConfig(
2800 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00002801 unittest.main()