dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 1 | # Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """A database of OWNERS files.""" |
| 6 | |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 7 | import collections |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 8 | import re |
| 9 | |
| 10 | |
| 11 | # If this is present by itself on a line, this means that everyone can review. |
| 12 | EVERYONE = '*' |
| 13 | |
| 14 | |
| 15 | # Recognizes 'X@Y' email addresses. Very simplistic. |
| 16 | BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 17 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 18 | |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame] | 19 | def _assert_is_collection(obj): |
dpranke@chromium.org | e6a4ab3 | 2011-03-31 01:23:08 +0000 | [diff] [blame] | 20 | assert not isinstance(obj, basestring) |
maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame^] | 21 | # Module 'collections' has no 'Iterable' member |
| 22 | # pylint: disable=E1101 |
dpranke@chromium.org | e6a4ab3 | 2011-03-31 01:23:08 +0000 | [diff] [blame] | 23 | if hasattr(collections, 'Iterable') and hasattr(collections, 'Sized'): |
| 24 | assert (isinstance(obj, collections.Iterable) and |
| 25 | isinstance(obj, collections.Sized)) |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame] | 26 | |
| 27 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 28 | class SyntaxErrorInOwnersFile(Exception): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 29 | def __init__(self, path, lineno, msg): |
| 30 | super(SyntaxErrorInOwnersFile, self).__init__((path, lineno, msg)) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 31 | self.path = path |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 32 | self.lineno = lineno |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 33 | self.msg = msg |
| 34 | |
| 35 | def __str__(self): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 36 | return "%s:%d syntax error: %s" % (self.path, self.lineno, self.msg) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 37 | |
| 38 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 39 | class Database(object): |
| 40 | """A database of OWNERS files for a repository. |
| 41 | |
| 42 | This class allows you to find a suggested set of reviewers for a list |
| 43 | of changed files, and see if a list of changed files is covered by a |
| 44 | list of reviewers.""" |
| 45 | |
| 46 | def __init__(self, root, fopen, os_path): |
| 47 | """Args: |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 48 | root: the path to the root of the Repository |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 49 | open: function callback to open a text file for reading |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 50 | os_path: module/object callback with fields for 'abspath', 'dirname', |
| 51 | 'exists', and 'join' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 52 | """ |
| 53 | self.root = root |
| 54 | self.fopen = fopen |
| 55 | self.os_path = os_path |
| 56 | |
dpranke@chromium.org | 627ea67 | 2011-03-11 23:29:03 +0000 | [diff] [blame] | 57 | # Pick a default email regexp to use; callers can override as desired. |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 58 | self.email_regexp = re.compile(BASIC_EMAIL_REGEXP) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 59 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 60 | # Mapping of owners to the paths they own. |
| 61 | self.owned_by = {EVERYONE: set()} |
| 62 | |
| 63 | # Mapping of paths to authorized owners. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 64 | self.owners_for = {} |
| 65 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 66 | # Set of paths that stop us from looking above them for owners. |
| 67 | # (This is implicitly true for the root directory). |
| 68 | self.stop_looking = set(['']) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 69 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 70 | def reviewers_for(self, files): |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 71 | """Returns a suggested set of reviewers that will cover the files. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 72 | |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 73 | files is a sequence of paths relative to (and under) self.root.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 74 | self._check_paths(files) |
| 75 | self._load_data_needed_for(files) |
| 76 | return self._covering_set_of_owners_for(files) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 77 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 78 | def files_are_covered_by(self, files, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 79 | """Returns whether every file is owned by at least one reviewer.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 80 | return not self.files_not_covered_by(files, reviewers) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 81 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 82 | def files_not_covered_by(self, files, reviewers): |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 83 | """Returns the set of files that are not owned by at least one reviewer. |
| 84 | |
| 85 | Args: |
| 86 | files is a sequence of paths relative to (and under) self.root. |
| 87 | reviewers is a sequence of strings matching self.email_regexp.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 88 | self._check_paths(files) |
| 89 | self._check_reviewers(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 90 | if not reviewers: |
| 91 | return files |
| 92 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 93 | self._load_data_needed_for(files) |
| 94 | files_by_dir = self._files_by_dir(files) |
| 95 | covered_dirs = self._dirs_covered_by(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 96 | uncovered_files = [] |
| 97 | for d, files_in_d in files_by_dir.iteritems(): |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 98 | if not self._is_dir_covered_by(d, covered_dirs): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 99 | uncovered_files.extend(files_in_d) |
| 100 | return set(uncovered_files) |
| 101 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 102 | def _check_paths(self, files): |
| 103 | def _is_under(f, pfx): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 104 | return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx) |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame] | 105 | _assert_is_collection(files) |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 106 | assert all(_is_under(f, self.os_path.abspath(self.root)) for f in files) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 107 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 108 | def _check_reviewers(self, reviewers): |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame] | 109 | _assert_is_collection(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 110 | assert all(self.email_regexp.match(r) for r in reviewers) |
| 111 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 112 | def _files_by_dir(self, files): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 113 | dirs = {} |
| 114 | for f in files: |
| 115 | dirs.setdefault(self.os_path.dirname(f), []).append(f) |
| 116 | return dirs |
| 117 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 118 | def _dirs_covered_by(self, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 119 | dirs = self.owned_by[EVERYONE] |
| 120 | for r in reviewers: |
| 121 | dirs = dirs | self.owned_by.get(r, set()) |
| 122 | return dirs |
| 123 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 124 | def _stop_looking(self, dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 125 | return dirname in self.stop_looking |
| 126 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 127 | def _is_dir_covered_by(self, dirname, covered_dirs): |
| 128 | while not dirname in covered_dirs and not self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 129 | dirname = self.os_path.dirname(dirname) |
| 130 | return dirname in covered_dirs |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 131 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 132 | def _load_data_needed_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 133 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 134 | dirpath = self.os_path.dirname(f) |
| 135 | while not dirpath in self.owners_for: |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 136 | self._read_owners_in_dir(dirpath) |
| 137 | if self._stop_looking(dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 138 | break |
| 139 | dirpath = self.os_path.dirname(dirpath) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 140 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 141 | def _read_owners_in_dir(self, dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 142 | owners_path = self.os_path.join(self.root, dirpath, 'OWNERS') |
| 143 | if not self.os_path.exists(owners_path): |
| 144 | return |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 145 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 146 | lineno = 0 |
| 147 | for line in self.fopen(owners_path): |
| 148 | lineno += 1 |
| 149 | line = line.strip() |
| 150 | if line.startswith('#'): |
| 151 | continue |
| 152 | if line == 'set noparent': |
| 153 | self.stop_looking.add(dirpath) |
| 154 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 155 | if line.startswith('set '): |
| 156 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 157 | 'unknown option: "%s"' % line[4:].strip()) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 158 | if self.email_regexp.match(line) or line == EVERYONE: |
| 159 | self.owned_by.setdefault(line, set()).add(dirpath) |
| 160 | self.owners_for.setdefault(dirpath, set()).add(line) |
| 161 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 162 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 163 | ('line is not a comment, a "set" directive, ' |
| 164 | 'or an email address: "%s"' % line)) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 165 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 166 | def _covering_set_of_owners_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 167 | # TODO(dpranke): implement the greedy algorithm for covering sets, and |
| 168 | # consider returning multiple options in case there are several equally |
| 169 | # short combinations of owners. |
| 170 | every_owner = set() |
| 171 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 172 | dirname = self.os_path.dirname(f) |
| 173 | while dirname in self.owners_for: |
| 174 | every_owner |= self.owners_for[dirname] |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 175 | if self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 176 | break |
| 177 | dirname = self.os_path.dirname(dirname) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 178 | return every_owner |