dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 1 | # Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """A database of OWNERS files.""" |
| 6 | |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 7 | import collections |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 8 | import re |
| 9 | |
| 10 | |
| 11 | # If this is present by itself on a line, this means that everyone can review. |
| 12 | EVERYONE = '*' |
| 13 | |
| 14 | |
| 15 | # Recognizes 'X@Y' email addresses. Very simplistic. |
| 16 | BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 17 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 18 | |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame^] | 19 | def _assert_is_collection(obj): |
| 20 | assert (isinstance(obj, collections.Iterable) and |
| 21 | isinstance(obj, collections.Sized) and |
| 22 | not isinstance(obj, basestring)) |
| 23 | |
| 24 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 25 | class SyntaxErrorInOwnersFile(Exception): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 26 | def __init__(self, path, lineno, msg): |
| 27 | super(SyntaxErrorInOwnersFile, self).__init__((path, lineno, msg)) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 28 | self.path = path |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 29 | self.lineno = lineno |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 30 | self.msg = msg |
| 31 | |
| 32 | def __str__(self): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 33 | return "%s:%d syntax error: %s" % (self.path, self.lineno, self.msg) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 34 | |
| 35 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 36 | class Database(object): |
| 37 | """A database of OWNERS files for a repository. |
| 38 | |
| 39 | This class allows you to find a suggested set of reviewers for a list |
| 40 | of changed files, and see if a list of changed files is covered by a |
| 41 | list of reviewers.""" |
| 42 | |
| 43 | def __init__(self, root, fopen, os_path): |
| 44 | """Args: |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 45 | root: the path to the root of the Repository |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 46 | open: function callback to open a text file for reading |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 47 | os_path: module/object callback with fields for 'abspath', 'dirname', |
| 48 | 'exists', and 'join' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 49 | """ |
| 50 | self.root = root |
| 51 | self.fopen = fopen |
| 52 | self.os_path = os_path |
| 53 | |
dpranke@chromium.org | 627ea67 | 2011-03-11 23:29:03 +0000 | [diff] [blame] | 54 | # Pick a default email regexp to use; callers can override as desired. |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 55 | self.email_regexp = re.compile(BASIC_EMAIL_REGEXP) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 56 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 57 | # Mapping of owners to the paths they own. |
| 58 | self.owned_by = {EVERYONE: set()} |
| 59 | |
| 60 | # Mapping of paths to authorized owners. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 61 | self.owners_for = {} |
| 62 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 63 | # Set of paths that stop us from looking above them for owners. |
| 64 | # (This is implicitly true for the root directory). |
| 65 | self.stop_looking = set(['']) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 66 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 67 | def reviewers_for(self, files): |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 68 | """Returns a suggested set of reviewers that will cover the files. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 69 | |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 70 | files is a sequence of paths relative to (and under) self.root.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 71 | self._check_paths(files) |
| 72 | self._load_data_needed_for(files) |
| 73 | return self._covering_set_of_owners_for(files) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 74 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 75 | def files_are_covered_by(self, files, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 76 | """Returns whether every file is owned by at least one reviewer.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 77 | return not self.files_not_covered_by(files, reviewers) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 78 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 79 | def files_not_covered_by(self, files, reviewers): |
dpranke@chromium.org | fdecfb7 | 2011-03-16 23:27:23 +0000 | [diff] [blame] | 80 | """Returns the set of files that are not owned by at least one reviewer. |
| 81 | |
| 82 | Args: |
| 83 | files is a sequence of paths relative to (and under) self.root. |
| 84 | reviewers is a sequence of strings matching self.email_regexp.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 85 | self._check_paths(files) |
| 86 | self._check_reviewers(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 87 | if not reviewers: |
| 88 | return files |
| 89 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 90 | self._load_data_needed_for(files) |
| 91 | files_by_dir = self._files_by_dir(files) |
| 92 | covered_dirs = self._dirs_covered_by(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 93 | uncovered_files = [] |
| 94 | for d, files_in_d in files_by_dir.iteritems(): |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 95 | if not self._is_dir_covered_by(d, covered_dirs): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 96 | uncovered_files.extend(files_in_d) |
| 97 | return set(uncovered_files) |
| 98 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 99 | def _check_paths(self, files): |
| 100 | def _is_under(f, pfx): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 101 | return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx) |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame^] | 102 | _assert_is_collection(files) |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 103 | assert all(_is_under(f, self.os_path.abspath(self.root)) for f in files) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 104 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 105 | def _check_reviewers(self, reviewers): |
dpranke@chromium.org | 923950f | 2011-03-17 23:40:00 +0000 | [diff] [blame^] | 106 | _assert_is_collection(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 107 | assert all(self.email_regexp.match(r) for r in reviewers) |
| 108 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 109 | def _files_by_dir(self, files): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 110 | dirs = {} |
| 111 | for f in files: |
| 112 | dirs.setdefault(self.os_path.dirname(f), []).append(f) |
| 113 | return dirs |
| 114 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 115 | def _dirs_covered_by(self, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 116 | dirs = self.owned_by[EVERYONE] |
| 117 | for r in reviewers: |
| 118 | dirs = dirs | self.owned_by.get(r, set()) |
| 119 | return dirs |
| 120 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 121 | def _stop_looking(self, dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 122 | return dirname in self.stop_looking |
| 123 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 124 | def _is_dir_covered_by(self, dirname, covered_dirs): |
| 125 | while not dirname in covered_dirs and not self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 126 | dirname = self.os_path.dirname(dirname) |
| 127 | return dirname in covered_dirs |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 128 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 129 | def _load_data_needed_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 130 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 131 | dirpath = self.os_path.dirname(f) |
| 132 | while not dirpath in self.owners_for: |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 133 | self._read_owners_in_dir(dirpath) |
| 134 | if self._stop_looking(dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 135 | break |
| 136 | dirpath = self.os_path.dirname(dirpath) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 137 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 138 | def _read_owners_in_dir(self, dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 139 | owners_path = self.os_path.join(self.root, dirpath, 'OWNERS') |
| 140 | if not self.os_path.exists(owners_path): |
| 141 | return |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 142 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 143 | lineno = 0 |
| 144 | for line in self.fopen(owners_path): |
| 145 | lineno += 1 |
| 146 | line = line.strip() |
| 147 | if line.startswith('#'): |
| 148 | continue |
| 149 | if line == 'set noparent': |
| 150 | self.stop_looking.add(dirpath) |
| 151 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 152 | if line.startswith('set '): |
| 153 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 154 | 'unknown option: "%s"' % line[4:].strip()) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 155 | if self.email_regexp.match(line) or line == EVERYONE: |
| 156 | self.owned_by.setdefault(line, set()).add(dirpath) |
| 157 | self.owners_for.setdefault(dirpath, set()).add(line) |
| 158 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 159 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 160 | ('line is not a comment, a "set" directive, ' |
| 161 | 'or an email address: "%s"' % line)) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 162 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 163 | def _covering_set_of_owners_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 164 | # TODO(dpranke): implement the greedy algorithm for covering sets, and |
| 165 | # consider returning multiple options in case there are several equally |
| 166 | # short combinations of owners. |
| 167 | every_owner = set() |
| 168 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 169 | dirname = self.os_path.dirname(f) |
| 170 | while dirname in self.owners_for: |
| 171 | every_owner |= self.owners_for[dirname] |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 172 | if self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 173 | break |
| 174 | dirname = self.os_path.dirname(dirname) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 175 | return every_owner |