blob: 18dd31153756e6ebeedf42ef7f01da8b3c7f8c74 [file] [log] [blame]
dpranke@chromium.org2a009622011-03-01 02:43:31 +00001# Copyright (c) 2010 The Chromium Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""A database of OWNERS files."""
6
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +00007import collections
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +00008import re
9
10
11# If this is present by itself on a line, this means that everyone can review.
12EVERYONE = '*'
13
14
15# Recognizes 'X@Y' email addresses. Very simplistic.
16BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000017
dpranke@chromium.org2a009622011-03-01 02:43:31 +000018
dpranke@chromium.org923950f2011-03-17 23:40:00 +000019def _assert_is_collection(obj):
20 assert (isinstance(obj, collections.Iterable) and
21 isinstance(obj, collections.Sized) and
22 not isinstance(obj, basestring))
23
24
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000025class SyntaxErrorInOwnersFile(Exception):
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000026 def __init__(self, path, lineno, msg):
27 super(SyntaxErrorInOwnersFile, self).__init__((path, lineno, msg))
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000028 self.path = path
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000029 self.lineno = lineno
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000030 self.msg = msg
31
32 def __str__(self):
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000033 return "%s:%d syntax error: %s" % (self.path, self.lineno, self.msg)
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000034
35
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000036class Database(object):
37 """A database of OWNERS files for a repository.
38
39 This class allows you to find a suggested set of reviewers for a list
40 of changed files, and see if a list of changed files is covered by a
41 list of reviewers."""
42
43 def __init__(self, root, fopen, os_path):
44 """Args:
dpranke@chromium.org2a009622011-03-01 02:43:31 +000045 root: the path to the root of the Repository
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046 open: function callback to open a text file for reading
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000047 os_path: module/object callback with fields for 'abspath', 'dirname',
48 'exists', and 'join'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000049 """
50 self.root = root
51 self.fopen = fopen
52 self.os_path = os_path
53
dpranke@chromium.org627ea672011-03-11 23:29:03 +000054 # Pick a default email regexp to use; callers can override as desired.
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000055 self.email_regexp = re.compile(BASIC_EMAIL_REGEXP)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000056
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000057 # Mapping of owners to the paths they own.
58 self.owned_by = {EVERYONE: set()}
59
60 # Mapping of paths to authorized owners.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000061 self.owners_for = {}
62
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000063 # Set of paths that stop us from looking above them for owners.
64 # (This is implicitly true for the root directory).
65 self.stop_looking = set([''])
dpranke@chromium.org2a009622011-03-01 02:43:31 +000066
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000067 def reviewers_for(self, files):
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000068 """Returns a suggested set of reviewers that will cover the files.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000069
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000070 files is a sequence of paths relative to (and under) self.root."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000071 self._check_paths(files)
72 self._load_data_needed_for(files)
73 return self._covering_set_of_owners_for(files)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000074
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000075 def files_are_covered_by(self, files, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000076 """Returns whether every file is owned by at least one reviewer."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000077 return not self.files_not_covered_by(files, reviewers)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000078
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000079 def files_not_covered_by(self, files, reviewers):
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000080 """Returns the set of files that are not owned by at least one reviewer.
81
82 Args:
83 files is a sequence of paths relative to (and under) self.root.
84 reviewers is a sequence of strings matching self.email_regexp."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000085 self._check_paths(files)
86 self._check_reviewers(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000087 if not reviewers:
88 return files
89
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000090 self._load_data_needed_for(files)
91 files_by_dir = self._files_by_dir(files)
92 covered_dirs = self._dirs_covered_by(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000093 uncovered_files = []
94 for d, files_in_d in files_by_dir.iteritems():
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000095 if not self._is_dir_covered_by(d, covered_dirs):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000096 uncovered_files.extend(files_in_d)
97 return set(uncovered_files)
98
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000099 def _check_paths(self, files):
100 def _is_under(f, pfx):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000101 return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx)
dpranke@chromium.org923950f2011-03-17 23:40:00 +0000102 _assert_is_collection(files)
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000103 assert all(_is_under(f, self.os_path.abspath(self.root)) for f in files)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000104
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000105 def _check_reviewers(self, reviewers):
dpranke@chromium.org923950f2011-03-17 23:40:00 +0000106 _assert_is_collection(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000107 assert all(self.email_regexp.match(r) for r in reviewers)
108
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000109 def _files_by_dir(self, files):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000110 dirs = {}
111 for f in files:
112 dirs.setdefault(self.os_path.dirname(f), []).append(f)
113 return dirs
114
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000115 def _dirs_covered_by(self, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000116 dirs = self.owned_by[EVERYONE]
117 for r in reviewers:
118 dirs = dirs | self.owned_by.get(r, set())
119 return dirs
120
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000121 def _stop_looking(self, dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000122 return dirname in self.stop_looking
123
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000124 def _is_dir_covered_by(self, dirname, covered_dirs):
125 while not dirname in covered_dirs and not self._stop_looking(dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000126 dirname = self.os_path.dirname(dirname)
127 return dirname in covered_dirs
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000128
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000129 def _load_data_needed_for(self, files):
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000130 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000131 dirpath = self.os_path.dirname(f)
132 while not dirpath in self.owners_for:
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000133 self._read_owners_in_dir(dirpath)
134 if self._stop_looking(dirpath):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000135 break
136 dirpath = self.os_path.dirname(dirpath)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000137
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000138 def _read_owners_in_dir(self, dirpath):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000139 owners_path = self.os_path.join(self.root, dirpath, 'OWNERS')
140 if not self.os_path.exists(owners_path):
141 return
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000142
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000143 lineno = 0
144 for line in self.fopen(owners_path):
145 lineno += 1
146 line = line.strip()
147 if line.startswith('#'):
148 continue
149 if line == 'set noparent':
150 self.stop_looking.add(dirpath)
151 continue
dpranke@chromium.org86bbf192011-03-09 21:37:06 +0000152 if line.startswith('set '):
153 raise SyntaxErrorInOwnersFile(owners_path, lineno,
154 'unknown option: "%s"' % line[4:].strip())
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000155 if self.email_regexp.match(line) or line == EVERYONE:
156 self.owned_by.setdefault(line, set()).add(dirpath)
157 self.owners_for.setdefault(dirpath, set()).add(line)
158 continue
dpranke@chromium.org86bbf192011-03-09 21:37:06 +0000159 raise SyntaxErrorInOwnersFile(owners_path, lineno,
160 ('line is not a comment, a "set" directive, '
161 'or an email address: "%s"' % line))
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000162
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000163 def _covering_set_of_owners_for(self, files):
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000164 # TODO(dpranke): implement the greedy algorithm for covering sets, and
165 # consider returning multiple options in case there are several equally
166 # short combinations of owners.
167 every_owner = set()
168 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000169 dirname = self.os_path.dirname(f)
170 while dirname in self.owners_for:
171 every_owner |= self.owners_for[dirname]
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000172 if self._stop_looking(dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000173 break
174 dirname = self.os_path.dirname(dirname)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000175 return every_owner