blob: 5d80cc5512f3408769b5b15e59ec36b50248429c [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
enne@chromium.orge72c5f52013-04-16 00:36:40 +000015import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000016import cPickle # Exposed through the API.
17import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000018import contextlib
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000019import fnmatch
20import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000021import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000022import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000023import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000024import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000025import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000026import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000027import optparse
28import os # Somewhat exposed through the API.
29import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000030import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000031import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000034import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000035import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000036import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000038import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000039import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000040from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041
42# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000043import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000044import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000045import gclient_utils
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000047import owners
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000049import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
53
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000054# Ask for feedback only once in program lifetime.
55_ASKED_FOR_FEEDBACK = False
56
57
maruel@chromium.org899e1c12011-04-07 17:03:18 +000058class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000059 pass
60
61
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000062class CommandData(object):
63 def __init__(self, name, cmd, kwargs, message):
64 self.name = name
65 self.cmd = cmd
66 self.kwargs = kwargs
67 self.message = message
68 self.info = None
69
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000070
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000071def normpath(path):
72 '''Version of os.path.normpath that also changes backward slashes to
73 forward slashes when not running on Windows.
74 '''
75 # This is safe to always do because the Windows version of os.path.normpath
76 # will replace forward slashes with backward slashes.
77 path = path.replace(os.sep, '/')
78 return os.path.normpath(path)
79
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000080
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000081def _RightHandSideLinesImpl(affected_files):
82 """Implements RightHandSideLines for InputApi and GclChange."""
83 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000084 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000085 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000086 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000087
88
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000089class PresubmitOutput(object):
90 def __init__(self, input_stream=None, output_stream=None):
91 self.input_stream = input_stream
92 self.output_stream = output_stream
93 self.reviewers = []
94 self.written_output = []
95 self.error_count = 0
96
97 def prompt_yes_no(self, prompt_string):
98 self.write(prompt_string)
99 if self.input_stream:
100 response = self.input_stream.readline().strip().lower()
101 if response not in ('y', 'yes'):
102 self.fail()
103 else:
104 self.fail()
105
106 def fail(self):
107 self.error_count += 1
108
109 def should_continue(self):
110 return not self.error_count
111
112 def write(self, s):
113 self.written_output.append(s)
114 if self.output_stream:
115 self.output_stream.write(s)
116
117 def getvalue(self):
118 return ''.join(self.written_output)
119
120
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000121# Top level object so multiprocessing can pickle
122# Public access through OutputApi object.
123class _PresubmitResult(object):
124 """Base class for result objects."""
125 fatal = False
126 should_prompt = False
127
128 def __init__(self, message, items=None, long_text=''):
129 """
130 message: A short one-line message to indicate errors.
131 items: A list of short strings to indicate where errors occurred.
132 long_text: multi-line text output, e.g. from another tool
133 """
134 self._message = message
135 self._items = items or []
136 if items:
137 self._items = items
138 self._long_text = long_text.rstrip()
139
140 def handle(self, output):
141 output.write(self._message)
142 output.write('\n')
143 for index, item in enumerate(self._items):
144 output.write(' ')
145 # Write separately in case it's unicode.
146 output.write(str(item))
147 if index < len(self._items) - 1:
148 output.write(' \\')
149 output.write('\n')
150 if self._long_text:
151 output.write('\n***************\n')
152 # Write separately in case it's unicode.
153 output.write(self._long_text)
154 output.write('\n***************\n')
155 if self.fatal:
156 output.fail()
157
158
159# Top level object so multiprocessing can pickle
160# Public access through OutputApi object.
161class _PresubmitAddReviewers(_PresubmitResult):
162 """Add some suggested reviewers to the change."""
163 def __init__(self, reviewers):
164 super(_PresubmitAddReviewers, self).__init__('')
165 self.reviewers = reviewers
166
167 def handle(self, output):
168 output.reviewers.extend(self.reviewers)
169
170
171# Top level object so multiprocessing can pickle
172# Public access through OutputApi object.
173class _PresubmitError(_PresubmitResult):
174 """A hard presubmit error."""
175 fatal = True
176
177
178# Top level object so multiprocessing can pickle
179# Public access through OutputApi object.
180class _PresubmitPromptWarning(_PresubmitResult):
181 """An warning that prompts the user if they want to continue."""
182 should_prompt = True
183
184
185# Top level object so multiprocessing can pickle
186# Public access through OutputApi object.
187class _PresubmitNotifyResult(_PresubmitResult):
188 """Just print something to the screen -- but it's not even a warning."""
189 pass
190
191
192# Top level object so multiprocessing can pickle
193# Public access through OutputApi object.
194class _MailTextResult(_PresubmitResult):
195 """A warning that should be included in the review request email."""
196 def __init__(self, *args, **kwargs):
197 super(_MailTextResult, self).__init__()
198 raise NotImplementedError()
199
200
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000201class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000202 """An instance of OutputApi gets passed to presubmit scripts so that they
203 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000204 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000205 PresubmitResult = _PresubmitResult
206 PresubmitAddReviewers = _PresubmitAddReviewers
207 PresubmitError = _PresubmitError
208 PresubmitPromptWarning = _PresubmitPromptWarning
209 PresubmitNotifyResult = _PresubmitNotifyResult
210 MailTextResult = _MailTextResult
211
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000212 def __init__(self, is_committing):
213 self.is_committing = is_committing
214
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000215 def PresubmitPromptOrNotify(self, *args, **kwargs):
216 """Warn the user when uploading, but only notify if committing."""
217 if self.is_committing:
218 return self.PresubmitNotifyResult(*args, **kwargs)
219 return self.PresubmitPromptWarning(*args, **kwargs)
220
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000221
222class InputApi(object):
223 """An instance of this object is passed to presubmit scripts so they can
224 know stuff about the change they're looking at.
225 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000226 # Method could be a function
227 # pylint: disable=R0201
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000228
maruel@chromium.org3410d912009-06-09 20:56:16 +0000229 # File extensions that are considered source files from a style guide
230 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000231 #
232 # Files without an extension aren't included in the list. If you want to
233 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
234 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000235 DEFAULT_WHITE_LIST = (
236 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000237 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
238 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000239 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000240 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000241 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000242 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000243 )
244
245 # Path regexp that should be excluded from being considered containing source
246 # files. Don't modify this list from a presubmit script!
247 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000248 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000249 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000250 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
251 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000252 # Output directories (just in case)
253 r".*\bDebug[\\\/].*",
254 r".*\bRelease[\\\/].*",
255 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000256 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000257 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000258 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000259 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000260 r"(|.*[\\\/])\.git[\\\/].*",
261 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000262 # There is no point in processing a patch file.
263 r".+\.diff$",
264 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000265 )
266
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000267 def __init__(self, change, presubmit_path, is_committing,
maruel@chromium.org239f4112011-06-03 20:08:23 +0000268 rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 """Builds an InputApi object.
270
271 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000272 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000273 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000274 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000275 rietveld_obj: rietveld.Rietveld client object
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000276 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000277 # Version number of the presubmit_support script.
278 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000279 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000280 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000281 self.rietveld = rietveld_obj
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000282 # TBD
283 self.host_url = 'http://codereview.chromium.org'
284 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000285 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000286
287 # We expose various modules and functions as attributes of the input_api
288 # so that presubmit scripts don't have to import them.
289 self.basename = os.path.basename
290 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000291 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000292 self.cStringIO = cStringIO
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000293 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000294 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000295 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000296 self.os_listdir = os.listdir
297 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000298 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000299 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000300 self.pickle = pickle
301 self.marshal = marshal
302 self.re = re
303 self.subprocess = subprocess
304 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000305 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000306 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000307 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000308 self.urllib2 = urllib2
309
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000310 # To easily fork python.
311 self.python_executable = sys.executable
312 self.environ = os.environ
313
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000314 # InputApi.platform is the platform you're currently running on.
315 self.platform = sys.platform
316
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000317 self.cpu_count = multiprocessing.cpu_count()
318
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000319 # this is done here because in RunTests, the current working directory has
320 # changed, which causes Pool() to explode fantastically when run on windows
321 # (because it tries to load the __main__ module, which imports lots of
322 # things relative to the current working directory).
323 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
324
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000325 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000326 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000327
328 # We carry the canned checks so presubmit scripts can easily use them.
329 self.canned_checks = presubmit_canned_checks
330
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000331 # TODO(dpranke): figure out a list of all approved owners for a repo
332 # in order to be able to handle wildcard OWNERS files?
333 self.owners_db = owners.Database(change.RepositoryRoot(),
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000334 fopen=file, os_path=self.os_path, glob=self.glob)
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000335 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000336 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000337
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000338 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000339 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000340 # Access to a protected member _XX of a client class
341 # pylint: disable=W0212
342 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000343 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000344 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
345 for (a, b, header) in cpplint._re_pattern_templates
346 ]
347
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000348 def PresubmitLocalPath(self):
349 """Returns the local path of the presubmit script currently being run.
350
351 This is useful if you don't want to hard-code absolute paths in the
352 presubmit script. For example, It can be used to find another file
353 relative to the PRESUBMIT.py script, so the whole tree can be branched and
354 the presubmit script still works, without editing its content.
355 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000356 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000357
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000358 def DepotToLocalPath(self, depot_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000359 """Translate a depot path to a local path (relative to client root).
360
361 Args:
362 Depot path as a string.
363
364 Returns:
365 The local path of the depot path under the user's current client, or None
366 if the file is not mapped.
367
368 Remember to check for the None case and show an appropriate error!
369 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000370 return scm.SVN.CaptureLocalInfo([depot_path], self.change.RepositoryRoot()
371 ).get('Path')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000372
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000373 def LocalToDepotPath(self, local_path):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000374 """Translate a local path to a depot path.
375
376 Args:
377 Local path (relative to current directory, or absolute) as a string.
378
379 Returns:
380 The depot path (SVN URL) of the file if mapped, otherwise None.
381 """
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000382 return scm.SVN.CaptureLocalInfo([local_path], self.change.RepositoryRoot()
383 ).get('URL')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000384
sail@chromium.org5538e022011-05-12 17:53:16 +0000385 def AffectedFiles(self, include_dirs=False, include_deletes=True,
386 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000387 """Same as input_api.change.AffectedFiles() except only lists files
388 (and optionally directories) in the same directory as the current presubmit
389 script, or subdirectories thereof.
390 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000391 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000392 if len(dir_with_slash) == 1:
393 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000394
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000395 return filter(
396 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
sail@chromium.org5538e022011-05-12 17:53:16 +0000397 self.change.AffectedFiles(include_dirs, include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000398
399 def LocalPaths(self, include_dirs=False):
400 """Returns local paths of input_api.AffectedFiles()."""
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000401 paths = [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
402 logging.debug("LocalPaths: %s", paths)
403 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000404
405 def AbsoluteLocalPaths(self, include_dirs=False):
406 """Returns absolute local paths of input_api.AffectedFiles()."""
407 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
408
409 def ServerPaths(self, include_dirs=False):
410 """Returns server paths of input_api.AffectedFiles()."""
411 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
412
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000413 def AffectedTextFiles(self, include_deletes=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000414 """Same as input_api.change.AffectedTextFiles() except only lists files
415 in the same directory as the current presubmit script, or subdirectories
416 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000417 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000418 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000419 warn("AffectedTextFiles(include_deletes=%s)"
420 " is deprecated and ignored" % str(include_deletes),
421 category=DeprecationWarning,
422 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000423 return filter(lambda x: x.IsTextFile(),
424 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000425
maruel@chromium.org3410d912009-06-09 20:56:16 +0000426 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
427 """Filters out files that aren't considered "source file".
428
429 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
430 and InputApi.DEFAULT_BLACK_LIST is used respectively.
431
432 The lists will be compiled as regular expression and
433 AffectedFile.LocalPath() needs to pass both list.
434
435 Note: Copy-paste this function to suit your needs or use a lambda function.
436 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000437 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000438 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000439 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000440 if self.re.match(item, local_path):
441 logging.debug("%s matched %s" % (item, local_path))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000442 return True
443 return False
444 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
445 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
446
447 def AffectedSourceFiles(self, source_file):
448 """Filter the list of AffectedTextFiles by the function source_file.
449
450 If source_file is None, InputApi.FilterSourceFile() is used.
451 """
452 if not source_file:
453 source_file = self.FilterSourceFile
454 return filter(source_file, self.AffectedTextFiles())
455
456 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000457 """An iterator over all text lines in "new" version of changed files.
458
459 Only lists lines from new or modified text files in the change that are
460 contained by the directory of the currently executing presubmit script.
461
462 This is useful for doing line-by-line regex checks, like checking for
463 trailing whitespace.
464
465 Yields:
466 a 3 tuple:
467 the AffectedFile instance of the current file;
468 integer line number (1-based); and
469 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000470
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000471 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000472 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000473 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000474 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000475
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000476 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000477 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000478
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000479 Deny reading anything outside the repository.
480 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000481 if isinstance(file_item, AffectedFile):
482 file_item = file_item.AbsoluteLocalPath()
483 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000484 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000485 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000486
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000487 @property
488 def tbr(self):
489 """Returns if a change is TBR'ed."""
490 return 'TBR' in self.change.tags
491
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000492 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000493 tests = []
494 msgs = []
495 for t in tests_mix:
496 if isinstance(t, OutputApi.PresubmitResult):
497 msgs.append(t)
498 else:
499 assert issubclass(t.message, _PresubmitResult)
500 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000501 if self.verbose:
502 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000503 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000504 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000505 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000506 else:
507 msgs.extend(map(CallCommand, tests))
508 return [m for m in msgs if m]
509
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000510
nick@chromium.orgff526192013-06-10 19:30:26 +0000511class _DiffCache(object):
512 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000513 def __init__(self, upstream=None):
514 """Stores the upstream revision against which all diffs will be computed."""
515 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000516
517 def GetDiff(self, path, local_root):
518 """Get the diff for a particular path."""
519 raise NotImplementedError()
520
521
522class _SvnDiffCache(_DiffCache):
523 """DiffCache implementation for subversion."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000524 def __init__(self, *args, **kwargs):
525 super(_SvnDiffCache, self).__init__(*args, **kwargs)
nick@chromium.orgff526192013-06-10 19:30:26 +0000526 self._diffs_by_file = {}
527
528 def GetDiff(self, path, local_root):
529 if path not in self._diffs_by_file:
530 self._diffs_by_file[path] = scm.SVN.GenerateDiff([path], local_root,
531 False, None)
532 return self._diffs_by_file[path]
533
534
535class _GitDiffCache(_DiffCache):
536 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000537 def __init__(self, upstream):
538 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000539 self._diffs_by_file = None
540
541 def GetDiff(self, path, local_root):
542 if not self._diffs_by_file:
543 # Compute a single diff for all files and parse the output; should
544 # with git this is much faster than computing one diff for each file.
545 diffs = {}
546
547 # Don't specify any filenames below, because there are command line length
548 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000549 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
550 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000551
552 # This regex matches the path twice, separated by a space. Note that
553 # filename itself may contain spaces.
554 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
555 current_diff = []
556 keep_line_endings = True
557 for x in unified_diff.splitlines(keep_line_endings):
558 match = file_marker.match(x)
559 if match:
560 # Marks the start of a new per-file section.
561 diffs[match.group('filename')] = current_diff = [x]
562 elif x.startswith('diff --git'):
563 raise PresubmitFailure('Unexpected diff line: %s' % x)
564 else:
565 current_diff.append(x)
566
567 self._diffs_by_file = dict(
568 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
569
570 if path not in self._diffs_by_file:
571 raise PresubmitFailure(
572 'Unified diff did not contain entry for file %s' % path)
573
574 return self._diffs_by_file[path]
575
576
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000577class AffectedFile(object):
578 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000579
580 DIFF_CACHE = _DiffCache
581
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000582 # Method could be a function
583 # pylint: disable=R0201
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000584 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000585 self._path = path
586 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000587 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000588 self._is_directory = None
589 self._properties = {}
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000590 self._cached_changed_contents = None
591 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000592 self._diff_cache = diff_cache
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000593 logging.debug('%s(%s)' % (self.__class__.__name__, self._path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594
595 def ServerPath(self):
596 """Returns a path string that identifies the file in the SCM system.
597
598 Returns the empty string if the file does not exist in SCM.
599 """
nick@chromium.orgff526192013-06-10 19:30:26 +0000600 return ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601
602 def LocalPath(self):
603 """Returns the path of this file on the local disk relative to client root.
604 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000605 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606
607 def AbsoluteLocalPath(self):
608 """Returns the absolute path of this file on the local disk.
609 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000610 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611
612 def IsDirectory(self):
613 """Returns true if this object is a directory."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000614 if self._is_directory is None:
615 path = self.AbsoluteLocalPath()
616 self._is_directory = (os.path.exists(path) and
617 os.path.isdir(path))
618 return self._is_directory
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619
620 def Action(self):
621 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000622 # TODO(maruel): Somewhat crappy, Could be "A" or "A +" for svn but
623 # different for other SCM.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000624 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000626 def Property(self, property_name):
627 """Returns the specified SCM property of this file, or None if no such
628 property.
629 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000630 return self._properties.get(property_name, None)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000631
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000632 def IsTextFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000633 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000634
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000635 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000636 raise NotImplementedError() # Implement when needed
637
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000638 def NewContents(self):
639 """Returns an iterator over the lines in the new version of file.
640
641 The new version is the file in the user's workspace, i.e. the "right hand
642 side".
643
644 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000645 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000647 if self._cached_new_contents is None:
648 self._cached_new_contents = []
649 if not self.IsDirectory():
650 try:
651 self._cached_new_contents = gclient_utils.FileRead(
652 self.AbsoluteLocalPath(), 'rU').splitlines()
653 except IOError:
654 pass # File not found? That's fine; maybe it was deleted.
655 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000657 def ChangedContents(self):
658 """Returns a list of tuples (line number, line text) of all new lines.
659
660 This relies on the scm diff output describing each changed code section
661 with a line of the form
662
663 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
664 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000665 if self._cached_changed_contents is not None:
666 return self._cached_changed_contents[:]
667 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000668 line_num = 0
669
670 if self.IsDirectory():
671 return []
672
673 for line in self.GenerateScmDiff().splitlines():
674 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
675 if m:
676 line_num = int(m.groups(1)[0])
677 continue
678 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000679 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000680 if not line.startswith('-'):
681 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000682 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000683
maruel@chromium.org5de13972009-06-10 18:16:06 +0000684 def __str__(self):
685 return self.LocalPath()
686
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000687 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000688 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689
maruel@chromium.org58407af2011-04-12 23:15:57 +0000690
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000691class SvnAffectedFile(AffectedFile):
692 """Representation of a file in a change out of a Subversion checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000693 # Method 'NNN' is abstract in class 'NNN' but is not overridden
694 # pylint: disable=W0223
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000695
nick@chromium.orgff526192013-06-10 19:30:26 +0000696 DIFF_CACHE = _SvnDiffCache
697
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000698 def __init__(self, *args, **kwargs):
699 AffectedFile.__init__(self, *args, **kwargs)
700 self._server_path = None
701 self._is_text_file = None
702
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000703 def ServerPath(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000704 if self._server_path is None:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000705 self._server_path = scm.SVN.CaptureLocalInfo(
706 [self.LocalPath()], self._local_root).get('URL', '')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000707 return self._server_path
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000708
709 def IsDirectory(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000710 if self._is_directory is None:
711 path = self.AbsoluteLocalPath()
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000712 if os.path.exists(path):
713 # Retrieve directly from the file system; it is much faster than
714 # querying subversion, especially on Windows.
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000715 self._is_directory = os.path.isdir(path)
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000716 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000717 self._is_directory = scm.SVN.CaptureLocalInfo(
718 [self.LocalPath()], self._local_root
719 ).get('Node Kind') in ('dir', 'directory')
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000720 return self._is_directory
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000721
722 def Property(self, property_name):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000723 if not property_name in self._properties:
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000724 self._properties[property_name] = scm.SVN.GetFileProperty(
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000725 self.LocalPath(), property_name, self._local_root).rstrip()
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000726 return self._properties[property_name]
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000727
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000728 def IsTextFile(self):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000729 if self._is_text_file is None:
730 if self.Action() == 'D':
731 # A deleted file is not a text file.
732 self._is_text_file = False
733 elif self.IsDirectory():
734 self._is_text_file = False
735 else:
maruel@chromium.orgd579fcf2011-12-13 20:36:03 +0000736 mime_type = scm.SVN.GetFileProperty(
737 self.LocalPath(), 'svn:mime-type', self._local_root)
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000738 self._is_text_file = (not mime_type or mime_type.startswith('text/'))
739 return self._is_text_file
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000740
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000741
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000742class GitAffectedFile(AffectedFile):
743 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000744 # Method 'NNN' is abstract in class 'NNN' but is not overridden
745 # pylint: disable=W0223
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000746
nick@chromium.orgff526192013-06-10 19:30:26 +0000747 DIFF_CACHE = _GitDiffCache
748
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000749 def __init__(self, *args, **kwargs):
750 AffectedFile.__init__(self, *args, **kwargs)
751 self._server_path = None
752 self._is_text_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000753
754 def ServerPath(self):
755 if self._server_path is None:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000756 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000757 return self._server_path
758
759 def IsDirectory(self):
760 if self._is_directory is None:
761 path = self.AbsoluteLocalPath()
762 if os.path.exists(path):
763 # Retrieve directly from the file system; it is much faster than
764 # querying subversion, especially on Windows.
765 self._is_directory = os.path.isdir(path)
766 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000767 self._is_directory = False
768 return self._is_directory
769
770 def Property(self, property_name):
771 if not property_name in self._properties:
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000772 raise NotImplementedError('TODO(maruel) Implement.')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000773 return self._properties[property_name]
774
775 def IsTextFile(self):
776 if self._is_text_file is None:
777 if self.Action() == 'D':
778 # A deleted file is not a text file.
779 self._is_text_file = False
780 elif self.IsDirectory():
781 self._is_text_file = False
782 else:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000783 self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
784 return self._is_text_file
785
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000786
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000787class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000788 """Describe a change.
789
790 Used directly by the presubmit scripts to query the current change being
791 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000792
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000793 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000794 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000795 self.KEY: equivalent to tags['KEY']
796 """
797
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000798 _AFFECTED_FILES = AffectedFile
799
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000800 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000801 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000802 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000803 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000804
maruel@chromium.org58407af2011-04-12 23:15:57 +0000805 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000806 self, name, description, local_root, files, issue, patchset, author,
807 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000808 if files is None:
809 files = []
810 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000811 # Convert root into an absolute path.
812 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000813 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000814 self.issue = issue
815 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000816 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000817
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000818 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000819 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000820 self._description_without_tags = ''
821 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000822
maruel@chromium.orge085d812011-10-10 19:49:15 +0000823 assert all(
824 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
825
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000826 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000827 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000828 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
829 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000830 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000831
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000832 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000833 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000834 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000835
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000836 def DescriptionText(self):
837 """Returns the user-entered changelist description, minus tags.
838
839 Any line in the user-provided description starting with e.g. "FOO="
840 (whitespace permitted before and around) is considered a tag line. Such
841 lines are stripped out of the description this function returns.
842 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000843 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000844
845 def FullDescriptionText(self):
846 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000847 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000848
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000849 def SetDescriptionText(self, description):
850 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000851
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000852 Also updates the list of tags."""
853 self._full_description = description
854
855 # From the description text, build up a dictionary of key/value pairs
856 # plus the description minus all key/value or "tag" lines.
857 description_without_tags = []
858 self.tags = {}
859 for line in self._full_description.splitlines():
860 m = self.TAG_LINE_RE.match(line)
861 if m:
862 self.tags[m.group('key')] = m.group('value')
863 else:
864 description_without_tags.append(line)
865
866 # Change back to text and remove whitespace at end.
867 self._description_without_tags = (
868 '\n'.join(description_without_tags).rstrip())
869
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000870 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000871 """Returns the repository (checkout) root directory for this change,
872 as an absolute path.
873 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000874 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000875
876 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000877 """Return tags directly as attributes on the object."""
878 if not re.match(r"^[A-Z_]*$", attr):
879 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000880 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000881
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000882 def AllFiles(self, root=None):
883 """List all files under source control in the repo."""
884 raise NotImplementedError()
885
sail@chromium.org5538e022011-05-12 17:53:16 +0000886 def AffectedFiles(self, include_dirs=False, include_deletes=True,
887 file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888 """Returns a list of AffectedFile instances for all files in the change.
889
890 Args:
891 include_deletes: If false, deleted files will be filtered out.
892 include_dirs: True to include directories in the list
sail@chromium.org5538e022011-05-12 17:53:16 +0000893 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894
895 Returns:
896 [AffectedFile(path, action), AffectedFile(path, action)]
897 """
898 if include_dirs:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000899 affected = self._affected_files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000900 else:
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000901 affected = filter(lambda x: not x.IsDirectory(), self._affected_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000902
sail@chromium.org5538e022011-05-12 17:53:16 +0000903 affected = filter(file_filter, affected)
904
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000905 if include_deletes:
906 return affected
907 else:
908 return filter(lambda x: x.Action() != 'D', affected)
909
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000910 def AffectedTextFiles(self, include_deletes=None):
911 """Return a list of the existing text files in a change."""
912 if include_deletes is not None:
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000913 warn("AffectedTextFiles(include_deletes=%s)"
914 " is deprecated and ignored" % str(include_deletes),
915 category=DeprecationWarning,
916 stacklevel=2)
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000917 return filter(lambda x: x.IsTextFile(),
918 self.AffectedFiles(include_dirs=False, include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000919
920 def LocalPaths(self, include_dirs=False):
921 """Convenience function."""
922 return [af.LocalPath() for af in self.AffectedFiles(include_dirs)]
923
924 def AbsoluteLocalPaths(self, include_dirs=False):
925 """Convenience function."""
926 return [af.AbsoluteLocalPath() for af in self.AffectedFiles(include_dirs)]
927
928 def ServerPaths(self, include_dirs=False):
929 """Convenience function."""
930 return [af.ServerPath() for af in self.AffectedFiles(include_dirs)]
931
932 def RightHandSideLines(self):
933 """An iterator over all text lines in "new" version of changed files.
934
935 Lists lines from new or modified text files in the change.
936
937 This is useful for doing line-by-line regex checks, like checking for
938 trailing whitespace.
939
940 Yields:
941 a 3 tuple:
942 the AffectedFile instance of the current file;
943 integer line number (1-based); and
944 the contents of the line as a string.
945 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000946 return _RightHandSideLinesImpl(
947 x for x in self.AffectedFiles(include_deletes=False)
948 if x.IsTextFile())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949
950
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000951class SvnChange(Change):
952 _AFFECTED_FILES = SvnAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000953 scm = 'svn'
954 _changelists = None
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000955
956 def _GetChangeLists(self):
957 """Get all change lists."""
958 if self._changelists == None:
959 previous_cwd = os.getcwd()
960 os.chdir(self.RepositoryRoot())
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000961 # Need to import here to avoid circular dependency.
962 import gcl
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000963 self._changelists = gcl.GetModifiedFiles()
964 os.chdir(previous_cwd)
965 return self._changelists
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000966
967 def GetAllModifiedFiles(self):
968 """Get all modified files."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000969 changelists = self._GetChangeLists()
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000970 all_modified_files = []
971 for cl in changelists.values():
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000972 all_modified_files.extend(
973 [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000974 return all_modified_files
975
976 def GetModifiedFiles(self):
977 """Get modified files in the current CL."""
thestig@chromium.org6bd31702009-09-02 23:29:07 +0000978 changelists = self._GetChangeLists()
979 return [os.path.join(self.RepositoryRoot(), f[1])
980 for f in changelists[self.Name()]]
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000981
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000982 def AllFiles(self, root=None):
983 """List all files under source control in the repo."""
984 root = root or self.RepositoryRoot()
985 return subprocess.check_output(
986 ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
987
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000988
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000989class GitChange(Change):
990 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000991 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000992
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000993 def AllFiles(self, root=None):
994 """List all files under source control in the repo."""
995 root = root or self.RepositoryRoot()
996 return subprocess.check_output(
997 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
998
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000999
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001000def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001 """Finds all presubmit files that apply to a given set of source files.
1002
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001003 If inherit-review-settings-ok is present right under root, looks for
1004 PRESUBMIT.py in directories enclosing root.
1005
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001006 Args:
1007 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001008 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001009
1010 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001011 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001012 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001013 files = [normpath(os.path.join(root, f)) for f in files]
1014
1015 # List all the individual directories containing files.
1016 directories = set([os.path.dirname(f) for f in files])
1017
1018 # Ignore root if inherit-review-settings-ok is present.
1019 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1020 root = None
1021
1022 # Collect all unique directories that may contain PRESUBMIT.py.
1023 candidates = set()
1024 for directory in directories:
1025 while True:
1026 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001028 candidates.add(directory)
1029 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001030 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001031 parent_dir = os.path.dirname(directory)
1032 if parent_dir == directory:
1033 # We hit the system root directory.
1034 break
1035 directory = parent_dir
1036
1037 # Look for PRESUBMIT.py in all candidate directories.
1038 results = []
1039 for directory in sorted(list(candidates)):
1040 p = os.path.join(directory, 'PRESUBMIT.py')
1041 if os.path.isfile(p):
1042 results.append(p)
1043
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001044 logging.debug('Presubmit files: %s' % ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001045 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001046
1047
thestig@chromium.orgde243452009-10-06 21:02:56 +00001048class GetTrySlavesExecuter(object):
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001049 @staticmethod
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001050 def ExecPresubmitScript(script_text, presubmit_path, project, change):
thestig@chromium.orgde243452009-10-06 21:02:56 +00001051 """Executes GetPreferredTrySlaves() from a single presubmit script.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001052
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001053 This will soon be deprecated and replaced by GetPreferredTryMasters().
thestig@chromium.orgde243452009-10-06 21:02:56 +00001054
1055 Args:
1056 script_text: The text of the presubmit script.
bradnelson@google.com78230022011-05-24 18:55:19 +00001057 presubmit_path: Project script to run.
1058 project: Project name to pass to presubmit script for bot selection.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001059
1060 Return:
1061 A list of try slaves.
1062 """
1063 context = {}
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001064 main_path = os.getcwd()
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001065 try:
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001066 os.chdir(os.path.dirname(presubmit_path))
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001067 exec script_text in context
1068 except Exception, e:
1069 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
alokp@chromium.orgf6349642014-03-04 00:52:18 +00001070 finally:
1071 os.chdir(main_path)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001072
1073 function_name = 'GetPreferredTrySlaves'
1074 if function_name in context:
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001075 get_preferred_try_slaves = context[function_name]
1076 function_info = inspect.getargspec(get_preferred_try_slaves)
1077 if len(function_info[0]) == 1:
1078 result = get_preferred_try_slaves(project)
1079 elif len(function_info[0]) == 2:
1080 result = get_preferred_try_slaves(project, change)
1081 else:
1082 result = get_preferred_try_slaves()
thestig@chromium.orgde243452009-10-06 21:02:56 +00001083 if not isinstance(result, types.ListType):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001084 raise PresubmitFailure(
thestig@chromium.orgde243452009-10-06 21:02:56 +00001085 'Presubmit functions must return a list, got a %s instead: %s' %
1086 (type(result), str(result)))
1087 for item in result:
stip@chromium.org68e04192013-11-04 22:14:38 +00001088 if isinstance(item, basestring):
1089 # Old-style ['bot'] format.
1090 botname = item
1091 elif isinstance(item, tuple):
1092 # New-style [('bot', set(['tests']))] format.
1093 botname = item[0]
1094 else:
1095 raise PresubmitFailure('PRESUBMIT.py returned invalid tryslave/test'
1096 ' format.')
1097
1098 if botname != botname.strip():
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001099 raise PresubmitFailure(
1100 'Try slave names cannot start/end with whitespace')
stip@chromium.org68e04192013-11-04 22:14:38 +00001101 if ',' in botname:
maruel@chromium.org3ecc8ea2012-03-10 01:47:46 +00001102 raise PresubmitFailure(
stip@chromium.org68e04192013-11-04 22:14:38 +00001103 'Do not use \',\' separated builder or test names: %s' % botname)
thestig@chromium.orgde243452009-10-06 21:02:56 +00001104 else:
1105 result = []
stip@chromium.org5ca27622013-12-18 17:44:58 +00001106
1107 def valid_oldstyle(result):
1108 return all(isinstance(i, basestring) for i in result)
1109
1110 def valid_newstyle(result):
1111 return (all(isinstance(i, tuple) for i in result) and
1112 all(len(i) == 2 for i in result) and
1113 all(isinstance(i[0], basestring) for i in result) and
1114 all(isinstance(i[1], set) for i in result)
1115 )
1116
1117 # Ensure it's either all old-style or all new-style.
1118 if not valid_oldstyle(result) and not valid_newstyle(result):
1119 raise PresubmitFailure(
1120 'PRESUBMIT.py returned invalid trybot specification!')
1121
thestig@chromium.orgde243452009-10-06 21:02:56 +00001122 return result
1123
1124
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001125class GetTryMastersExecuter(object):
1126 @staticmethod
1127 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1128 """Executes GetPreferredTryMasters() from a single presubmit script.
1129
1130 Args:
1131 script_text: The text of the presubmit script.
1132 presubmit_path: Project script to run.
1133 project: Project name to pass to presubmit script for bot selection.
1134
1135 Return:
1136 A map of try masters to map of builders to set of tests.
1137 """
1138 context = {}
1139 try:
1140 exec script_text in context
1141 except Exception, e:
1142 raise PresubmitFailure('"%s" had an exception.\n%s'
1143 % (presubmit_path, e))
1144
1145 function_name = 'GetPreferredTryMasters'
1146 if function_name not in context:
1147 return {}
1148 get_preferred_try_masters = context[function_name]
1149 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1150 raise PresubmitFailure(
1151 'Expected function "GetPreferredTryMasters" to take two arguments.')
1152 return get_preferred_try_masters(project, change)
1153
1154
rmistry@google.com5626a922015-02-26 14:03:30 +00001155class GetPostUploadExecuter(object):
1156 @staticmethod
1157 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1158 """Executes PostUploadHook() from a single presubmit script.
1159
1160 Args:
1161 script_text: The text of the presubmit script.
1162 presubmit_path: Project script to run.
1163 cl: The Changelist object.
1164 change: The Change object.
1165
1166 Return:
1167 A list of results objects.
1168 """
1169 context = {}
1170 try:
1171 exec script_text in context
1172 except Exception, e:
1173 raise PresubmitFailure('"%s" had an exception.\n%s'
1174 % (presubmit_path, e))
1175
1176 function_name = 'PostUploadHook'
1177 if function_name not in context:
1178 return {}
1179 post_upload_hook = context[function_name]
1180 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1181 raise PresubmitFailure(
1182 'Expected function "PostUploadHook" to take three arguments.')
1183 return post_upload_hook(cl, change, OutputApi(False))
1184
1185
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001186def DoGetTrySlaves(change,
1187 changed_files,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001188 repository_root,
1189 default_presubmit,
bradnelson@google.com78230022011-05-24 18:55:19 +00001190 project,
thestig@chromium.orgde243452009-10-06 21:02:56 +00001191 verbose,
1192 output_stream):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001193 """Get the list of try servers from the presubmit scripts (deprecated).
thestig@chromium.orgde243452009-10-06 21:02:56 +00001194
1195 Args:
1196 changed_files: List of modified files.
1197 repository_root: The repository root.
1198 default_presubmit: A default presubmit script to execute in any case.
bradnelson@google.com78230022011-05-24 18:55:19 +00001199 project: Optional name of a project used in selecting trybots.
thestig@chromium.orgde243452009-10-06 21:02:56 +00001200 verbose: Prints debug info.
1201 output_stream: A stream to write debug output to.
1202
1203 Return:
1204 List of try slaves
1205 """
1206 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1207 if not presubmit_files and verbose:
mdempsky@chromium.orgd59e7612014-03-05 19:55:56 +00001208 output_stream.write("Warning, no PRESUBMIT.py found.\n")
thestig@chromium.orgde243452009-10-06 21:02:56 +00001209 results = []
1210 executer = GetTrySlavesExecuter()
stip@chromium.org5ca27622013-12-18 17:44:58 +00001211
thestig@chromium.orgde243452009-10-06 21:02:56 +00001212 if default_presubmit:
1213 if verbose:
1214 output_stream.write("Running default presubmit script.\n")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001215 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001216 results.extend(executer.ExecPresubmitScript(
1217 default_presubmit, fake_path, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001218 for filename in presubmit_files:
1219 filename = os.path.abspath(filename)
1220 if verbose:
1221 output_stream.write("Running %s\n" % filename)
1222 # Accept CRLF presubmit script.
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +00001223 presubmit_script = gclient_utils.FileRead(filename, 'rU')
stip@chromium.org5ca27622013-12-18 17:44:58 +00001224 results.extend(executer.ExecPresubmitScript(
1225 presubmit_script, filename, project, change))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001226
stip@chromium.org5ca27622013-12-18 17:44:58 +00001227
1228 slave_dict = {}
1229 old_style = filter(lambda x: isinstance(x, basestring), results)
1230 new_style = filter(lambda x: isinstance(x, tuple), results)
1231
1232 for result in new_style:
1233 slave_dict.setdefault(result[0], set()).update(result[1])
1234 slaves = list(slave_dict.items())
1235
1236 slaves.extend(set(old_style))
stip@chromium.org68e04192013-11-04 22:14:38 +00001237
thestig@chromium.orgde243452009-10-06 21:02:56 +00001238 if slaves and verbose:
stip@chromium.org5ca27622013-12-18 17:44:58 +00001239 output_stream.write(', '.join((str(x) for x in slaves)))
thestig@chromium.orgde243452009-10-06 21:02:56 +00001240 output_stream.write('\n')
1241 return slaves
1242
1243
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001244def _MergeMasters(masters1, masters2):
1245 """Merges two master maps. Merges also the tests of each builder."""
1246 result = {}
1247 for (master, builders) in itertools.chain(masters1.iteritems(),
1248 masters2.iteritems()):
1249 new_builders = result.setdefault(master, {})
1250 for (builder, tests) in builders.iteritems():
1251 new_builders.setdefault(builder, set([])).update(tests)
1252 return result
1253
1254
1255def DoGetTryMasters(change,
1256 changed_files,
1257 repository_root,
1258 default_presubmit,
1259 project,
1260 verbose,
1261 output_stream):
1262 """Get the list of try masters from the presubmit scripts.
1263
1264 Args:
1265 changed_files: List of modified files.
1266 repository_root: The repository root.
1267 default_presubmit: A default presubmit script to execute in any case.
1268 project: Optional name of a project used in selecting trybots.
1269 verbose: Prints debug info.
1270 output_stream: A stream to write debug output to.
1271
1272 Return:
1273 Map of try masters to map of builders to set of tests.
1274 """
1275 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1276 if not presubmit_files and verbose:
1277 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1278 results = {}
1279 executer = GetTryMastersExecuter()
1280
1281 if default_presubmit:
1282 if verbose:
1283 output_stream.write("Running default presubmit script.\n")
1284 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1285 results = _MergeMasters(results, executer.ExecPresubmitScript(
1286 default_presubmit, fake_path, project, change))
1287 for filename in presubmit_files:
1288 filename = os.path.abspath(filename)
1289 if verbose:
1290 output_stream.write("Running %s\n" % filename)
1291 # Accept CRLF presubmit script.
1292 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1293 results = _MergeMasters(results, executer.ExecPresubmitScript(
1294 presubmit_script, filename, project, change))
1295
1296 # Make sets to lists again for later JSON serialization.
1297 for builders in results.itervalues():
1298 for builder in builders:
1299 builders[builder] = list(builders[builder])
1300
1301 if results and verbose:
1302 output_stream.write('%s\n' % str(results))
1303 return results
1304
1305
rmistry@google.com5626a922015-02-26 14:03:30 +00001306def DoPostUploadExecuter(change,
1307 cl,
1308 repository_root,
1309 verbose,
1310 output_stream):
1311 """Execute the post upload hook.
1312
1313 Args:
1314 change: The Change object.
1315 cl: The Changelist object.
1316 repository_root: The repository root.
1317 verbose: Prints debug info.
1318 output_stream: A stream to write debug output to.
1319 """
1320 presubmit_files = ListRelevantPresubmitFiles(
1321 change.LocalPaths(), repository_root)
1322 if not presubmit_files and verbose:
1323 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1324 results = []
1325 executer = GetPostUploadExecuter()
1326 # The root presubmit file should be executed after the ones in subdirectories.
1327 # i.e. the specific post upload hooks should run before the general ones.
1328 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1329 presubmit_files.reverse()
1330
1331 for filename in presubmit_files:
1332 filename = os.path.abspath(filename)
1333 if verbose:
1334 output_stream.write("Running %s\n" % filename)
1335 # Accept CRLF presubmit script.
1336 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1337 results.extend(executer.ExecPresubmitScript(
1338 presubmit_script, filename, cl, change))
1339 output_stream.write('\n')
1340 if results:
1341 output_stream.write('** Post Upload Hook Messages **\n')
1342 for result in results:
1343 result.handle(output_stream)
1344 output_stream.write('\n')
1345
1346 return results
1347
1348
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001349class PresubmitExecuter(object):
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001350 def __init__(self, change, committing, rietveld_obj, verbose):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001351 """
1352 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001353 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001354 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001355 rietveld_obj: rietveld.Rietveld client object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001357 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001358 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001359 self.rietveld = rietveld_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001360 self.verbose = verbose
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001361
1362 def ExecPresubmitScript(self, script_text, presubmit_path):
1363 """Executes a single presubmit script.
1364
1365 Args:
1366 script_text: The text of the presubmit script.
1367 presubmit_path: The path to the presubmit file (this will be reported via
1368 input_api.PresubmitLocalPath()).
1369
1370 Return:
1371 A list of result objects, empty if no problems.
1372 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001373
chase@chromium.org8e416c82009-10-06 04:30:44 +00001374 # Change to the presubmit file's directory to support local imports.
1375 main_path = os.getcwd()
1376 os.chdir(os.path.dirname(presubmit_path))
1377
1378 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001379 input_api = InputApi(self.change, presubmit_path, self.committing,
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001380 self.rietveld, self.verbose)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001381 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001382 try:
1383 exec script_text in context
1384 except Exception, e:
1385 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001386
1387 # These function names must change if we make substantial changes to
1388 # the presubmit API that are not backwards compatible.
1389 if self.committing:
1390 function_name = 'CheckChangeOnCommit'
1391 else:
1392 function_name = 'CheckChangeOnUpload'
1393 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001394 context['__args'] = (input_api, OutputApi(self.committing))
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001395 logging.debug('Running %s in %s' % (function_name, presubmit_path))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001396 result = eval(function_name + '(*__args)', context)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +00001397 logging.debug('Running %s done.' % function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001398 if not (isinstance(result, types.TupleType) or
1399 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001400 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001401 'Presubmit functions must return a tuple or list')
1402 for item in result:
1403 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001404 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001405 'All presubmit results must be of types derived from '
1406 'output_api.PresubmitResult')
1407 else:
1408 result = () # no error since the script doesn't care about current event.
1409
chase@chromium.org8e416c82009-10-06 04:30:44 +00001410 # Return the process to the original working directory.
1411 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001412 return result
1413
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001414
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001415def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001416 committing,
1417 verbose,
1418 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001419 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001420 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001421 may_prompt,
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001422 rietveld_obj):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001423 """Runs all presubmit checks that apply to the files in the change.
1424
1425 This finds all PRESUBMIT.py files in directories enclosing the files in the
1426 change (up to the repository root) and calls the relevant entrypoint function
1427 depending on whether the change is being committed or uploaded.
1428
1429 Prints errors, warnings and notifications. Prompts the user for warnings
1430 when needed.
1431
1432 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001433 change: The Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001434 committing: True if 'gcl commit' is running, False if 'gcl upload' is.
1435 verbose: Prints debug info.
1436 output_stream: A stream to write output from presubmit tests to.
1437 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001438 default_presubmit: A default presubmit script to execute in any case.
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001439 may_prompt: Enable (y/n) questions on warning or error.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001440 rietveld_obj: rietveld.Rietveld object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001441
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001442 Warning:
1443 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1444 SHOULD be sys.stdin.
1445
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001446 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001447 A PresubmitOutput object. Use output.should_continue() to figure out
1448 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001449 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001450 old_environ = os.environ
1451 try:
1452 # Make sure python subprocesses won't generate .pyc files.
1453 os.environ = os.environ.copy()
1454 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001455
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001456 output = PresubmitOutput(input_stream, output_stream)
1457 if committing:
1458 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001459 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001460 output.write("Running presubmit upload checks ...\n")
1461 start_time = time.time()
1462 presubmit_files = ListRelevantPresubmitFiles(
1463 change.AbsoluteLocalPaths(True), change.RepositoryRoot())
1464 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001465 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001466 results = []
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +00001467 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001468 if default_presubmit:
1469 if verbose:
1470 output.write("Running default presubmit script.\n")
1471 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1472 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1473 for filename in presubmit_files:
1474 filename = os.path.abspath(filename)
1475 if verbose:
1476 output.write("Running %s\n" % filename)
1477 # Accept CRLF presubmit script.
1478 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1479 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001480
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001481 errors = []
1482 notifications = []
1483 warnings = []
1484 for result in results:
1485 if result.fatal:
1486 errors.append(result)
1487 elif result.should_prompt:
1488 warnings.append(result)
1489 else:
1490 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001491
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001492 output.write('\n')
1493 for name, items in (('Messages', notifications),
1494 ('Warnings', warnings),
1495 ('ERRORS', errors)):
1496 if items:
1497 output.write('** Presubmit %s **\n' % name)
1498 for item in items:
1499 item.handle(output)
1500 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001501
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001502 total_time = time.time() - start_time
1503 if total_time > 1.0:
1504 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001505
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001506 if not errors:
1507 if not warnings:
1508 output.write('Presubmit checks passed.\n')
1509 elif may_prompt:
1510 output.prompt_yes_no('There were presubmit warnings. '
1511 'Are you sure you wish to continue? (y/N): ')
1512 else:
1513 output.fail()
1514
1515 global _ASKED_FOR_FEEDBACK
1516 # Ask for feedback one time out of 5.
1517 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001518 output.write(
1519 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1520 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1521 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001522 _ASKED_FOR_FEEDBACK = True
1523 return output
1524 finally:
1525 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001526
1527
1528def ScanSubDirs(mask, recursive):
1529 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001530 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001531 else:
1532 results = []
1533 for root, dirs, files in os.walk('.'):
1534 if '.svn' in dirs:
1535 dirs.remove('.svn')
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001536 if '.git' in dirs:
1537 dirs.remove('.git')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538 for name in files:
1539 if fnmatch.fnmatch(name, mask):
1540 results.append(os.path.join(root, name))
1541 return results
1542
1543
1544def ParseFiles(args, recursive):
maruel@chromium.org7444c502011-02-09 14:02:11 +00001545 logging.debug('Searching for %s' % args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001546 files = []
1547 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001548 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001549 return files
1550
1551
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001552def load_files(options, args):
1553 """Tries to determine the SCM."""
1554 change_scm = scm.determine_scm(options.root)
1555 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001556 if args:
1557 files = ParseFiles(args, options.recursive)
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001558 if change_scm == 'svn':
1559 change_class = SvnChange
1560 if not files:
1561 files = scm.SVN.CaptureStatus([], options.root)
1562 elif change_scm == 'git':
1563 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001564 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001565 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001566 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001567 else:
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001568 logging.info('Doesn\'t seem under source control. Got %d files' % len(args))
1569 if not files:
1570 return None, None
1571 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001572 return change_class, files
1573
1574
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001575class NonexistantCannedCheckFilter(Exception):
1576 pass
1577
1578
1579@contextlib.contextmanager
1580def canned_check_filter(method_names):
1581 filtered = {}
1582 try:
1583 for method_name in method_names:
1584 if not hasattr(presubmit_canned_checks, method_name):
1585 raise NonexistantCannedCheckFilter(method_name)
1586 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1587 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1588 yield
1589 finally:
1590 for name, method in filtered.iteritems():
1591 setattr(presubmit_canned_checks, name, method)
1592
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001593
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001594def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001595 """Runs an external program, potentially from a child process created by the
1596 multiprocessing module.
1597
1598 multiprocessing needs a top level function with a single argument.
1599 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001600 cmd_data.kwargs['stdout'] = subprocess.PIPE
1601 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1602 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001603 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001604 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001605 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001606 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001607 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001608 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001609 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1610 if code != 0:
1611 return cmd_data.message(
1612 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1613 if cmd_data.info:
1614 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001615
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001616
sbc@chromium.org013731e2015-02-26 18:28:43 +00001617def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001618 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001619 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001620 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001621 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001622 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1623 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001624 parser.add_option("-r", "--recursive", action="store_true",
1625 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001626 parser.add_option("-v", "--verbose", action="count", default=0,
1627 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001628 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001629 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001630 parser.add_option("--description", default='')
1631 parser.add_option("--issue", type='int', default=0)
1632 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001633 parser.add_option("--root", default=os.getcwd(),
1634 help="Search for PRESUBMIT.py up to this directory. "
1635 "If inherit-review-settings-ok is present in this "
1636 "directory, parent directories up to the root file "
1637 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001638 parser.add_option("--upstream",
1639 help="Git only: the base ref or upstream branch against "
1640 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001641 parser.add_option("--default_presubmit")
1642 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001643 parser.add_option("--skip_canned", action='append', default=[],
1644 help="A list of checks to skip which appear in "
1645 "presubmit_canned_checks. Can be provided multiple times "
1646 "to skip multiple canned checks.")
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001647 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
1648 parser.add_option("--gerrit_fetch", help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001649 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1650 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001651 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1652 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001653 # These are for OAuth2 authentication for bots. See also apply_issue.py
1654 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1655 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1656
phajdan.jr@chromium.org2ff30182016-03-23 09:52:51 +00001657 # TODO(phajdan.jr): Update callers and remove obsolete --trybot-json .
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00001658 parser.add_option("--trybot-json",
1659 help="Output trybot information to the file specified.")
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001660 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001661 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001662 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001663
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001664 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001665 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001666 elif options.verbose:
1667 logging.basicConfig(level=logging.INFO)
1668 else:
1669 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001670
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001671 if (any((options.rietveld_url, options.rietveld_email_file,
1672 options.rietveld_fetch, options.rietveld_private_key_file))
1673 and any((options.gerrit_url, options.gerrit_fetch))):
1674 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1675 'allowed')
1676
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001677 if options.rietveld_email and options.rietveld_email_file:
1678 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1679 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001680 if options.rietveld_email_file:
1681 with open(options.rietveld_email_file, "rb") as f:
1682 options.rietveld_email = f.read().strip()
1683
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001684 change_class, files = load_files(options, args)
1685 if not change_class:
1686 parser.error('For unversioned directory, <files> is not optional.')
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001687 logging.info('Found %d file(s).' % len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001688
maruel@chromium.org239f4112011-06-03 20:08:23 +00001689 rietveld_obj = None
1690 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001691 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001692 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001693 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1694 options.rietveld_url,
1695 options.rietveld_email,
1696 options.rietveld_private_key_file)
1697 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001698 rietveld_obj = rietveld.CachingRietveld(
1699 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001700 auth_config,
1701 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001702 if options.rietveld_fetch:
1703 assert options.issue
1704 props = rietveld_obj.get_issue_properties(options.issue, False)
1705 options.author = props['owner_email']
1706 options.description = props['description']
1707 logging.info('Got author: "%s"', options.author)
1708 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001709
1710 if options.gerrit_url and options.gerrit_fetch:
1711 rietveld_obj = None
1712 assert options.issue and options.patchset
1713 props = gerrit_util.GetChangeDetail(
1714 urlparse.urlparse(options.gerrit_url).netloc, str(options.issue),
1715 ['ALL_REVISIONS'])
1716 options.author = props['owner']['email']
1717 for rev, rev_info in props['revisions'].iteritems():
1718 if str(rev_info['_number']) == str(options.patchset):
1719 options.description = gerrit_util.GetChangeDescriptionFromGitiles(
1720 rev_info['fetch']['http']['url'], rev)
1721 break
1722 else:
1723 print >> sys.stderr, ('Patchset %d was not found in Gerrit issue %d' %
1724 options.patchset, options.issue)
1725 return 2
1726 logging.info('Got author: "%s"', options.author)
1727 logging.info('Got description: """\n%s\n"""', options.description)
1728
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001729 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001730 with canned_check_filter(options.skip_canned):
1731 results = DoPresubmitChecks(
1732 change_class(options.name,
1733 options.description,
1734 options.root,
1735 files,
1736 options.issue,
1737 options.patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001738 options.author,
1739 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001740 options.commit,
1741 options.verbose,
1742 sys.stdout,
1743 sys.stdin,
1744 options.default_presubmit,
1745 options.may_prompt,
1746 rietveld_obj)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001747 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001748 except NonexistantCannedCheckFilter, e:
1749 print >> sys.stderr, (
1750 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1751 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001752 except PresubmitFailure, e:
1753 print >> sys.stderr, e
1754 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1755 print >> sys.stderr, 'If all fails, contact maruel@'
1756 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001757
1758
1759if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001760 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001761 try:
1762 sys.exit(main())
1763 except KeyboardInterrupt:
1764 sys.stderr.write('interrupted\n')
1765 sys.exit(1)