blob: 5be7ff6d005b815321d31622651a2606b945ab40 [file] [log] [blame]
dpranke@chromium.org2a009622011-03-01 02:43:31 +00001# Copyright (c) 2010 The Chromium Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""A database of OWNERS files."""
6
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +00007import collections
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +00008import re
9
10
11# If this is present by itself on a line, this means that everyone can review.
12EVERYONE = '*'
13
14
15# Recognizes 'X@Y' email addresses. Very simplistic.
16BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000017
dpranke@chromium.org2a009622011-03-01 02:43:31 +000018
dpranke@chromium.org923950f2011-03-17 23:40:00 +000019def _assert_is_collection(obj):
dpranke@chromium.orge6a4ab32011-03-31 01:23:08 +000020 assert not isinstance(obj, basestring)
maruel@chromium.org725f1c32011-04-01 20:24:54 +000021 # Module 'collections' has no 'Iterable' member
22 # pylint: disable=E1101
dpranke@chromium.orge6a4ab32011-03-31 01:23:08 +000023 if hasattr(collections, 'Iterable') and hasattr(collections, 'Sized'):
24 assert (isinstance(obj, collections.Iterable) and
25 isinstance(obj, collections.Sized))
dpranke@chromium.org923950f2011-03-17 23:40:00 +000026
27
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000028class SyntaxErrorInOwnersFile(Exception):
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000029 def __init__(self, path, lineno, msg):
30 super(SyntaxErrorInOwnersFile, self).__init__((path, lineno, msg))
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000031 self.path = path
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000032 self.lineno = lineno
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000033 self.msg = msg
34
35 def __str__(self):
dpranke@chromium.org86bbf192011-03-09 21:37:06 +000036 return "%s:%d syntax error: %s" % (self.path, self.lineno, self.msg)
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000037
38
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000039class Database(object):
40 """A database of OWNERS files for a repository.
41
42 This class allows you to find a suggested set of reviewers for a list
43 of changed files, and see if a list of changed files is covered by a
44 list of reviewers."""
45
46 def __init__(self, root, fopen, os_path):
47 """Args:
dpranke@chromium.org2a009622011-03-01 02:43:31 +000048 root: the path to the root of the Repository
dpranke@chromium.org2a009622011-03-01 02:43:31 +000049 open: function callback to open a text file for reading
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000050 os_path: module/object callback with fields for 'abspath', 'dirname',
51 'exists', and 'join'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000052 """
53 self.root = root
54 self.fopen = fopen
55 self.os_path = os_path
56
dpranke@chromium.org627ea672011-03-11 23:29:03 +000057 # Pick a default email regexp to use; callers can override as desired.
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000058 self.email_regexp = re.compile(BASIC_EMAIL_REGEXP)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000059
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000060 # Mapping of owners to the paths they own.
61 self.owned_by = {EVERYONE: set()}
62
63 # Mapping of paths to authorized owners.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000064 self.owners_for = {}
65
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000066 # Set of paths that stop us from looking above them for owners.
67 # (This is implicitly true for the root directory).
68 self.stop_looking = set([''])
dpranke@chromium.org2a009622011-03-01 02:43:31 +000069
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000070 def reviewers_for(self, files):
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000071 """Returns a suggested set of reviewers that will cover the files.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000072
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000073 files is a sequence of paths relative to (and under) self.root."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000074 self._check_paths(files)
75 self._load_data_needed_for(files)
76 return self._covering_set_of_owners_for(files)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000077
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000078 def files_are_covered_by(self, files, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000079 """Returns whether every file is owned by at least one reviewer."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000080 return not self.files_not_covered_by(files, reviewers)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000081
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000082 def files_not_covered_by(self, files, reviewers):
dpranke@chromium.orgfdecfb72011-03-16 23:27:23 +000083 """Returns the set of files that are not owned by at least one reviewer.
84
85 Args:
86 files is a sequence of paths relative to (and under) self.root.
87 reviewers is a sequence of strings matching self.email_regexp."""
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000088 self._check_paths(files)
89 self._check_reviewers(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000090 if not reviewers:
91 return files
92
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000093 self._load_data_needed_for(files)
94 files_by_dir = self._files_by_dir(files)
95 covered_dirs = self._dirs_covered_by(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000096 uncovered_files = []
97 for d, files_in_d in files_by_dir.iteritems():
dpranke@chromium.org7eea2592011-03-09 21:35:46 +000098 if not self._is_dir_covered_by(d, covered_dirs):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000099 uncovered_files.extend(files_in_d)
100 return set(uncovered_files)
101
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000102 def _check_paths(self, files):
103 def _is_under(f, pfx):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000104 return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx)
dpranke@chromium.org923950f2011-03-17 23:40:00 +0000105 _assert_is_collection(files)
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000106 assert all(_is_under(f, self.os_path.abspath(self.root)) for f in files)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000107
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000108 def _check_reviewers(self, reviewers):
dpranke@chromium.org923950f2011-03-17 23:40:00 +0000109 _assert_is_collection(reviewers)
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000110 assert all(self.email_regexp.match(r) for r in reviewers)
111
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000112 def _files_by_dir(self, files):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000113 dirs = {}
114 for f in files:
115 dirs.setdefault(self.os_path.dirname(f), []).append(f)
116 return dirs
117
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000118 def _dirs_covered_by(self, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000119 dirs = self.owned_by[EVERYONE]
120 for r in reviewers:
121 dirs = dirs | self.owned_by.get(r, set())
122 return dirs
123
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000124 def _stop_looking(self, dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000125 return dirname in self.stop_looking
126
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000127 def _is_dir_covered_by(self, dirname, covered_dirs):
128 while not dirname in covered_dirs and not self._stop_looking(dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000129 dirname = self.os_path.dirname(dirname)
130 return dirname in covered_dirs
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000131
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000132 def _load_data_needed_for(self, files):
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000133 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000134 dirpath = self.os_path.dirname(f)
135 while not dirpath in self.owners_for:
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000136 self._read_owners_in_dir(dirpath)
137 if self._stop_looking(dirpath):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000138 break
139 dirpath = self.os_path.dirname(dirpath)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000140
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000141 def _read_owners_in_dir(self, dirpath):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000142 owners_path = self.os_path.join(self.root, dirpath, 'OWNERS')
143 if not self.os_path.exists(owners_path):
144 return
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000145
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000146 lineno = 0
147 for line in self.fopen(owners_path):
148 lineno += 1
149 line = line.strip()
150 if line.startswith('#'):
151 continue
152 if line == 'set noparent':
153 self.stop_looking.add(dirpath)
154 continue
dpranke@chromium.org86bbf192011-03-09 21:37:06 +0000155 if line.startswith('set '):
156 raise SyntaxErrorInOwnersFile(owners_path, lineno,
157 'unknown option: "%s"' % line[4:].strip())
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000158 if self.email_regexp.match(line) or line == EVERYONE:
159 self.owned_by.setdefault(line, set()).add(dirpath)
160 self.owners_for.setdefault(dirpath, set()).add(line)
161 continue
dpranke@chromium.org86bbf192011-03-09 21:37:06 +0000162 raise SyntaxErrorInOwnersFile(owners_path, lineno,
163 ('line is not a comment, a "set" directive, '
164 'or an email address: "%s"' % line))
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000165
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000166 def _covering_set_of_owners_for(self, files):
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000167 # TODO(dpranke): implement the greedy algorithm for covering sets, and
168 # consider returning multiple options in case there are several equally
169 # short combinations of owners.
170 every_owner = set()
171 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000172 dirname = self.os_path.dirname(f)
173 while dirname in self.owners_for:
174 every_owner |= self.owners_for[dirname]
dpranke@chromium.org7eea2592011-03-09 21:35:46 +0000175 if self._stop_looking(dirname):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000176 break
177 dirname = self.os_path.dirname(dirname)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000178 return every_owner