pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 11 | #include <list> |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 12 | #include <memory> |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 13 | #include <string> |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 14 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 15 | #include "modules/pacing/paced_sender.h" |
| 16 | #include "system_wrappers/include/clock.h" |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 17 | #include "system_wrappers/include/field_trial.h" |
| 18 | #include "test/field_trial.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "test/gmock.h" |
| 20 | #include "test/gtest.h" |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 21 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 22 | using testing::_; |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 23 | using testing::Field; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 24 | using testing::Return; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 25 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 26 | namespace { |
| 27 | constexpr unsigned kFirstClusterBps = 900000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 28 | constexpr unsigned kSecondClusterBps = 1800000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 29 | |
| 30 | // The error stems from truncating the time interval of probe packets to integer |
| 31 | // values. This results in probing slightly higher than the target bitrate. |
| 32 | // For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets. |
| 33 | constexpr int kBitrateProbingError = 150000; |
| 34 | } // namespace |
| 35 | |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 36 | namespace webrtc { |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 37 | namespace test { |
| 38 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 39 | static const int kTargetBitrateBps = 800000; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 40 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 41 | class MockPacedSenderCallback : public PacedSender::PacketSender { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 42 | public: |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 43 | MOCK_METHOD5(TimeToSendPacket, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 44 | bool(uint32_t ssrc, |
| 45 | uint16_t sequence_number, |
| 46 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 47 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 48 | const PacedPacketInfo& pacing_info)); |
| 49 | MOCK_METHOD2(TimeToSendPadding, |
| 50 | size_t(size_t bytes, const PacedPacketInfo& pacing_info)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 51 | }; |
| 52 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 53 | class PacedSenderPadding : public PacedSender::PacketSender { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 54 | public: |
| 55 | PacedSenderPadding() : padding_sent_(0) {} |
| 56 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 57 | bool TimeToSendPacket(uint32_t ssrc, |
| 58 | uint16_t sequence_number, |
| 59 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 60 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 61 | const PacedPacketInfo& pacing_info) override { |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 62 | return true; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 63 | } |
| 64 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 65 | size_t TimeToSendPadding(size_t bytes, |
| 66 | const PacedPacketInfo& pacing_info) override { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 67 | const size_t kPaddingPacketSize = 224; |
| 68 | size_t num_packets = (bytes + kPaddingPacketSize - 1) / kPaddingPacketSize; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 69 | padding_sent_ += kPaddingPacketSize * num_packets; |
| 70 | return kPaddingPacketSize * num_packets; |
| 71 | } |
| 72 | |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 73 | size_t padding_sent() { return padding_sent_; } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 74 | |
| 75 | private: |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 76 | size_t padding_sent_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 77 | }; |
| 78 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 79 | class PacedSenderProbing : public PacedSender::PacketSender { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 80 | public: |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 81 | PacedSenderProbing() : packets_sent_(0), padding_sent_(0) {} |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 82 | |
| 83 | bool TimeToSendPacket(uint32_t ssrc, |
| 84 | uint16_t sequence_number, |
| 85 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 86 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 87 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 88 | packets_sent_++; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 89 | return true; |
| 90 | } |
| 91 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 92 | size_t TimeToSendPadding(size_t bytes, |
| 93 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 94 | padding_sent_ += bytes; |
| 95 | return padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 96 | } |
| 97 | |
| 98 | int packets_sent() const { return packets_sent_; } |
| 99 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 100 | int padding_sent() const { return padding_sent_; } |
| 101 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 102 | private: |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 103 | int packets_sent_; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 104 | int padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 105 | }; |
| 106 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 107 | class PacedSenderTest : public testing::TestWithParam<std::string> { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 108 | protected: |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 109 | PacedSenderTest() : clock_(123456), field_trial_(GetParam()) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 110 | srand(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 111 | // Need to initialize PacedSender after we initialize clock. |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 112 | send_bucket_.reset(new PacedSender(&clock_, &callback_, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 113 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 114 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 115 | // Default to bitrate probing disabled for testing purposes. Probing tests |
| 116 | // have to enable probing, either by creating a new PacedSender instance or |
| 117 | // by calling SetProbingEnabled(true). |
| 118 | send_bucket_->SetProbingEnabled(false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 119 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
| 120 | |
| 121 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 122 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 123 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 124 | void SendAndExpectPacket(PacedSender::Priority priority, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 125 | uint32_t ssrc, |
| 126 | uint16_t sequence_number, |
| 127 | int64_t capture_time_ms, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 128 | size_t size, |
stefan@webrtc.org | 9b82f5a | 2013-11-13 15:29:21 +0000 | [diff] [blame] | 129 | bool retransmission) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 130 | send_bucket_->InsertPacket(priority, ssrc, sequence_number, capture_time_ms, |
| 131 | size, retransmission); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 132 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 133 | capture_time_ms, retransmission, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 134 | .Times(1) |
| 135 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 136 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 137 | SimulatedClock clock_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 138 | MockPacedSenderCallback callback_; |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 139 | std::unique_ptr<PacedSender> send_bucket_; |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 140 | test::ScopedFieldTrials field_trial_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 141 | }; |
| 142 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 143 | INSTANTIATE_TEST_CASE_P(RoundRobin, |
| 144 | PacedSenderTest, |
| 145 | ::testing::Values("WebRTC-RoundRobinPacing/Disabled/", |
| 146 | "WebRTC-RoundRobinPacing/Enabled/")); |
| 147 | |
| 148 | TEST_P(PacedSenderTest, FirstSentPacketTimeIsSet) { |
asapersson | fc5e81c | 2017-04-19 23:28:53 -0700 | [diff] [blame] | 149 | uint16_t sequence_number = 1234; |
| 150 | const uint32_t kSsrc = 12345; |
| 151 | const size_t kSizeBytes = 250; |
| 152 | const size_t kPacketToSend = 3; |
| 153 | const int64_t kStartMs = clock_.TimeInMilliseconds(); |
| 154 | |
| 155 | // No packet sent. |
| 156 | EXPECT_EQ(-1, send_bucket_->FirstSentPacketTimeMs()); |
| 157 | |
| 158 | for (size_t i = 0; i < kPacketToSend; ++i) { |
| 159 | SendAndExpectPacket(PacedSender::kNormalPriority, kSsrc, sequence_number++, |
| 160 | clock_.TimeInMilliseconds(), kSizeBytes, false); |
| 161 | send_bucket_->Process(); |
| 162 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 163 | } |
| 164 | EXPECT_EQ(kStartMs, send_bucket_->FirstSentPacketTimeMs()); |
| 165 | } |
| 166 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 167 | TEST_P(PacedSenderTest, QueuePacket) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 168 | uint32_t ssrc = 12345; |
| 169 | uint16_t sequence_number = 1234; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 170 | // Due to the multiplicative factor we can send 5 packets during a send |
| 171 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 172 | // (packet size * #send intervals per second) |
| 173 | const size_t packets_to_send = |
| 174 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 175 | for (size_t i = 0; i < packets_to_send; ++i) { |
| 176 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 177 | clock_.TimeInMilliseconds(), 250, false); |
| 178 | } |
| 179 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 180 | int64_t queued_packet_timestamp = clock_.TimeInMilliseconds(); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 181 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 182 | sequence_number, queued_packet_timestamp, 250, |
| 183 | false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 184 | EXPECT_EQ(packets_to_send + 1, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 185 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 186 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 187 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 188 | clock_.AdvanceTimeMilliseconds(4); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 189 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 190 | clock_.AdvanceTimeMilliseconds(1); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 191 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 192 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 193 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 194 | queued_packet_timestamp, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 195 | .Times(1) |
| 196 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 197 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 198 | sequence_number++; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 199 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 200 | |
| 201 | // We can send packets_to_send -1 packets of size 250 during the current |
| 202 | // interval since one packet has already been sent. |
| 203 | for (size_t i = 0; i < packets_to_send - 1; ++i) { |
| 204 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 205 | clock_.TimeInMilliseconds(), 250, false); |
| 206 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 207 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 208 | sequence_number++, clock_.TimeInMilliseconds(), |
| 209 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 210 | EXPECT_EQ(packets_to_send, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 211 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 212 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 213 | } |
| 214 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 215 | TEST_P(PacedSenderTest, PaceQueuedPackets) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 216 | uint32_t ssrc = 12345; |
| 217 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 218 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 219 | // Due to the multiplicative factor we can send 5 packets during a send |
| 220 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 221 | // (packet size * #send intervals per second) |
| 222 | const size_t packets_to_send_per_interval = |
| 223 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 224 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 225 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 226 | clock_.TimeInMilliseconds(), 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 227 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 228 | |
| 229 | for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 230 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 231 | sequence_number++, clock_.TimeInMilliseconds(), |
| 232 | 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 233 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 234 | EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10, |
| 235 | send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 236 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 237 | EXPECT_EQ(packets_to_send_per_interval * 10, |
| 238 | send_bucket_->QueueSizePackets()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 239 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 240 | for (int k = 0; k < 10; ++k) { |
| 241 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 242 | clock_.AdvanceTimeMilliseconds(5); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 243 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, _, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 244 | .Times(packets_to_send_per_interval) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 245 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 246 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 247 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 248 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 249 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 250 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 251 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 252 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 253 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 254 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 255 | |
| 256 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 257 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 258 | clock_.TimeInMilliseconds(), 250, false); |
| 259 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 260 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 261 | sequence_number, clock_.TimeInMilliseconds(), 250, |
| 262 | false); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 263 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 264 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 265 | } |
| 266 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 267 | TEST_P(PacedSenderTest, RepeatedRetransmissionsAllowed) { |
philipel | 7dc719a | 2017-09-29 16:15:25 +0200 | [diff] [blame] | 268 | // Send one packet, then two retransmissions of that packet. |
| 269 | for (size_t i = 0; i < 3; i++) { |
| 270 | constexpr uint32_t ssrc = 333; |
| 271 | constexpr uint16_t sequence_number = 444; |
| 272 | constexpr size_t bytes = 250; |
| 273 | bool is_retransmission = (i != 0); // Original followed by retransmissions. |
| 274 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number, |
| 275 | clock_.TimeInMilliseconds(), bytes, is_retransmission); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 276 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 277 | } |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 278 | send_bucket_->Process(); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 279 | } |
| 280 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 281 | TEST_P(PacedSenderTest, CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) { |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 282 | uint32_t ssrc = 12345; |
| 283 | uint16_t sequence_number = 1234; |
| 284 | |
| 285 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 286 | ssrc, |
| 287 | sequence_number, |
| 288 | clock_.TimeInMilliseconds(), |
| 289 | 250, |
| 290 | false); |
| 291 | |
| 292 | // Expect packet on second ssrc to be queued and sent as well. |
| 293 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 294 | ssrc + 1, |
| 295 | sequence_number, |
| 296 | clock_.TimeInMilliseconds(), |
| 297 | 250, |
| 298 | false); |
| 299 | |
| 300 | clock_.AdvanceTimeMilliseconds(1000); |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 301 | send_bucket_->Process(); |
| 302 | } |
| 303 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 304 | TEST_P(PacedSenderTest, Padding) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 305 | uint32_t ssrc = 12345; |
| 306 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 307 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 308 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 309 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 310 | |
| 311 | // Due to the multiplicative factor we can send 5 packets during a send |
| 312 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 313 | // (packet size * #send intervals per second) |
| 314 | const size_t packets_to_send_per_interval = |
| 315 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 316 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 317 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 318 | clock_.TimeInMilliseconds(), 250, false); |
| 319 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 320 | // No padding is expected since we have sent too much already. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 321 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 322 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 323 | send_bucket_->Process(); |
| 324 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 325 | |
| 326 | // 5 milliseconds later should not send padding since we filled the buffers |
| 327 | // initially. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 328 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 329 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 330 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 331 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 332 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 333 | |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 334 | // 5 milliseconds later we have enough budget to send some padding. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 335 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 336 | .Times(1) |
| 337 | .WillOnce(Return(250)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 338 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 339 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 340 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 341 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 342 | } |
| 343 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 344 | TEST_P(PacedSenderTest, NoPaddingBeforeNormalPacket) { |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 345 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
| 346 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
| 347 | |
| 348 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 349 | send_bucket_->Process(); |
| 350 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 351 | |
| 352 | send_bucket_->Process(); |
| 353 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 354 | |
| 355 | uint32_t ssrc = 12345; |
| 356 | uint16_t sequence_number = 1234; |
| 357 | int64_t capture_time_ms = 56789; |
| 358 | |
| 359 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 360 | capture_time_ms, 250, false); |
| 361 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 362 | .Times(1) |
| 363 | .WillOnce(Return(250)); |
| 364 | send_bucket_->Process(); |
| 365 | } |
| 366 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 367 | TEST_P(PacedSenderTest, VerifyPaddingUpToBitrate) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 368 | uint32_t ssrc = 12345; |
| 369 | uint16_t sequence_number = 1234; |
| 370 | int64_t capture_time_ms = 56789; |
| 371 | const int kTimeStep = 5; |
| 372 | const int64_t kBitrateWindow = 100; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 373 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 374 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 375 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 376 | int64_t start_time = clock_.TimeInMilliseconds(); |
| 377 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 378 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 379 | ssrc, |
| 380 | sequence_number++, |
| 381 | capture_time_ms, |
| 382 | 250, |
| 383 | false); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 384 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 385 | .Times(1) |
| 386 | .WillOnce(Return(250)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 387 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 388 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 389 | } |
| 390 | } |
| 391 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 392 | TEST_P(PacedSenderTest, VerifyAverageBitrateVaryingMediaPayload) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 393 | uint32_t ssrc = 12345; |
| 394 | uint16_t sequence_number = 1234; |
| 395 | int64_t capture_time_ms = 56789; |
| 396 | const int kTimeStep = 5; |
| 397 | const int64_t kBitrateWindow = 10000; |
| 398 | PacedSenderPadding callback; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 399 | send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr)); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 400 | send_bucket_->SetProbingEnabled(false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 401 | send_bucket_->SetEstimatedBitrate(kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 402 | |
| 403 | send_bucket_->SetSendBitrateLimits( |
| 404 | 0 /*allocated_bitrate_bps*/, |
| 405 | kTargetBitrateBps * 2 /* max_padding_bitrate_bps */); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 406 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 407 | int64_t start_time = clock_.TimeInMilliseconds(); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 408 | size_t media_bytes = 0; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 409 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
jbauch | d2a2296 | 2016-02-08 23:18:25 -0800 | [diff] [blame] | 410 | int rand_value = rand(); // NOLINT (rand_r instead of rand) |
| 411 | size_t media_payload = rand_value % 100 + 200; // [200, 300] bytes. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 412 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 413 | sequence_number++, capture_time_ms, |
| 414 | media_payload, false); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 415 | media_bytes += media_payload; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 416 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 417 | send_bucket_->Process(); |
| 418 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 419 | EXPECT_NEAR(kTargetBitrateBps / 1000, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 420 | static_cast<int>(8 * (media_bytes + callback.padding_sent()) / |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 421 | kBitrateWindow), |
| 422 | 1); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 423 | } |
| 424 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 425 | TEST_P(PacedSenderTest, Priority) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 426 | uint32_t ssrc_low_priority = 12345; |
| 427 | uint32_t ssrc = 12346; |
| 428 | uint16_t sequence_number = 1234; |
| 429 | int64_t capture_time_ms = 56789; |
| 430 | int64_t capture_time_ms_low_priority = 1234567; |
| 431 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 432 | // Due to the multiplicative factor we can send 5 packets during a send |
| 433 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 434 | // (packet size * #send intervals per second) |
| 435 | const size_t packets_to_send_per_interval = |
| 436 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 437 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 438 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 439 | clock_.TimeInMilliseconds(), 250, false); |
| 440 | } |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 441 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 442 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 443 | |
| 444 | // Expect normal and low priority to be queued and high to pass through. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 445 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 446 | sequence_number++, capture_time_ms_low_priority, |
| 447 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 448 | |
| 449 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 450 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 451 | sequence_number++, capture_time_ms, 250, false); |
| 452 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 453 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, |
| 454 | sequence_number++, capture_time_ms, 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 455 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 456 | // Expect all high and normal priority to be sent out first. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 457 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 458 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 459 | .Times(packets_to_send_per_interval + 1) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 460 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 461 | |
| 462 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 463 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 464 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 465 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 466 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 467 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 468 | EXPECT_CALL(callback_, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 469 | TimeToSendPacket(ssrc_low_priority, _, |
| 470 | capture_time_ms_low_priority, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 471 | .Times(1) |
| 472 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 473 | |
| 474 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 475 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 476 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 477 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 478 | } |
| 479 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 480 | TEST_P(PacedSenderTest, RetransmissionPriority) { |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 481 | uint32_t ssrc = 12345; |
| 482 | uint16_t sequence_number = 1234; |
| 483 | int64_t capture_time_ms = 45678; |
| 484 | int64_t capture_time_ms_retransmission = 56789; |
| 485 | |
| 486 | // Due to the multiplicative factor we can send 5 packets during a send |
| 487 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 488 | // (packet size * #send intervals per second) |
| 489 | const size_t packets_to_send_per_interval = |
| 490 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 491 | send_bucket_->Process(); |
| 492 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 493 | |
| 494 | // Alternate retransmissions and normal packets. |
| 495 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 496 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 497 | sequence_number++, |
| 498 | capture_time_ms_retransmission, 250, true); |
| 499 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 500 | sequence_number++, capture_time_ms, 250, false); |
| 501 | } |
| 502 | EXPECT_EQ(2 * packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 503 | |
| 504 | // Expect all retransmissions to be sent out first despite having a later |
| 505 | // capture time. |
| 506 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 507 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, false, _)).Times(0); |
| 508 | EXPECT_CALL(callback_, TimeToSendPacket( |
| 509 | ssrc, _, capture_time_ms_retransmission, true, _)) |
| 510 | .Times(packets_to_send_per_interval) |
| 511 | .WillRepeatedly(Return(true)); |
| 512 | |
| 513 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 514 | clock_.AdvanceTimeMilliseconds(5); |
| 515 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 516 | send_bucket_->Process(); |
| 517 | EXPECT_EQ(packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 518 | |
| 519 | // Expect the remaining (non-retransmission) packets to be sent. |
| 520 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 521 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, true, _)).Times(0); |
| 522 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
| 523 | .Times(packets_to_send_per_interval) |
| 524 | .WillRepeatedly(Return(true)); |
| 525 | |
| 526 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 527 | clock_.AdvanceTimeMilliseconds(5); |
| 528 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 529 | send_bucket_->Process(); |
| 530 | |
| 531 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 532 | } |
| 533 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 534 | TEST_P(PacedSenderTest, HighPrioDoesntAffectBudget) { |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 535 | uint32_t ssrc = 12346; |
| 536 | uint16_t sequence_number = 1234; |
| 537 | int64_t capture_time_ms = 56789; |
| 538 | |
| 539 | // As high prio packets doesn't affect the budget, we should be able to send |
| 540 | // a high number of them at once. |
| 541 | for (int i = 0; i < 25; ++i) { |
| 542 | SendAndExpectPacket(PacedSender::kHighPriority, ssrc, sequence_number++, |
| 543 | capture_time_ms, 250, false); |
| 544 | } |
| 545 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 546 | // Low prio packets does affect the budget. |
| 547 | // Due to the multiplicative factor we can send 5 packets during a send |
| 548 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 549 | // (packet size * #send intervals per second) |
| 550 | const size_t packets_to_send_per_interval = |
| 551 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 552 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 553 | SendAndExpectPacket(PacedSender::kLowPriority, ssrc, sequence_number++, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 554 | clock_.TimeInMilliseconds(), 250, false); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 555 | } |
| 556 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc, sequence_number, |
| 557 | capture_time_ms, 250, false); |
| 558 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 559 | clock_.AdvanceTimeMilliseconds(5); |
| 560 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 561 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 562 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 563 | capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 564 | .Times(1) |
| 565 | .WillRepeatedly(Return(true)); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 566 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 567 | clock_.AdvanceTimeMilliseconds(5); |
| 568 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 569 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 570 | } |
| 571 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 572 | TEST_P(PacedSenderTest, Pause) { |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 573 | uint32_t ssrc_low_priority = 12345; |
| 574 | uint32_t ssrc = 12346; |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 575 | uint32_t ssrc_high_priority = 12347; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 576 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 577 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 578 | |
| 579 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 580 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 581 | // Due to the multiplicative factor we can send 5 packets during a send |
| 582 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 583 | // (packet size * #send intervals per second) |
| 584 | const size_t packets_to_send_per_interval = |
| 585 | kTargetBitrateBps * PacedSender::kDefaultPaceMultiplier / (8 * 250 * 200); |
| 586 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 587 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 588 | clock_.TimeInMilliseconds(), 250, false); |
| 589 | } |
| 590 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 591 | send_bucket_->Process(); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 592 | |
| 593 | send_bucket_->Pause(); |
| 594 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 595 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 596 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 597 | sequence_number++, capture_time_ms, 250, false); |
| 598 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 599 | sequence_number++, capture_time_ms, 250, false); |
| 600 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 601 | sequence_number++, capture_time_ms, 250, false); |
| 602 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 603 | clock_.AdvanceTimeMilliseconds(10000); |
| 604 | int64_t second_capture_time_ms = clock_.TimeInMilliseconds(); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 605 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 606 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 607 | sequence_number++, second_capture_time_ms, 250, |
| 608 | false); |
| 609 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 610 | sequence_number++, second_capture_time_ms, 250, |
| 611 | false); |
| 612 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 613 | sequence_number++, second_capture_time_ms, 250, |
| 614 | false); |
| 615 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 616 | |
| 617 | // Expect everything to be queued. |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 618 | EXPECT_EQ(second_capture_time_ms - capture_time_ms, |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 619 | send_bucket_->QueueInMs()); |
| 620 | |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 621 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 622 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 623 | send_bucket_->Process(); |
| 624 | |
| 625 | int64_t expected_time_until_send = 500; |
| 626 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 627 | while (expected_time_until_send >= 0) { |
tommi | 919dce2 | 2017-03-15 07:45:36 -0700 | [diff] [blame] | 628 | // TimeUntilNextProcess must not return 0 when paused. If it does, |
| 629 | // we risk running a busy loop, so ideally it should return a large value. |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 630 | EXPECT_EQ(expected_time_until_send, send_bucket_->TimeUntilNextProcess()); |
| 631 | if (expected_time_until_send == 0) |
| 632 | send_bucket_->Process(); |
| 633 | clock_.AdvanceTimeMilliseconds(5); |
| 634 | expected_time_until_send -= 5; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 635 | } |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 636 | |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 637 | // Expect high prio packets to come out first followed by normal |
| 638 | // prio packets and low prio packets (all in capture order). |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 639 | { |
| 640 | ::testing::InSequence sequence; |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 641 | EXPECT_CALL(callback_, |
| 642 | TimeToSendPacket(ssrc_high_priority, _, capture_time_ms, _, _)) |
| 643 | .Times(packets_to_send_per_interval) |
| 644 | .WillRepeatedly(Return(true)); |
| 645 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_high_priority, _, |
| 646 | second_capture_time_ms, _, _)) |
| 647 | .Times(packets_to_send_per_interval) |
| 648 | .WillRepeatedly(Return(true)); |
| 649 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 650 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 651 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, _, _)) |
| 652 | .Times(1) |
| 653 | .WillRepeatedly(Return(true)); |
| 654 | } |
| 655 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 656 | EXPECT_CALL(callback_, |
| 657 | TimeToSendPacket(ssrc, _, second_capture_time_ms, _, _)) |
| 658 | .Times(1) |
| 659 | .WillRepeatedly(Return(true)); |
| 660 | } |
| 661 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 662 | EXPECT_CALL(callback_, |
| 663 | TimeToSendPacket(ssrc_low_priority, _, capture_time_ms, _, _)) |
| 664 | .Times(1) |
| 665 | .WillRepeatedly(Return(true)); |
| 666 | } |
| 667 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 668 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_low_priority, _, |
| 669 | second_capture_time_ms, _, _)) |
| 670 | .Times(1) |
| 671 | .WillRepeatedly(Return(true)); |
| 672 | } |
| 673 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 674 | send_bucket_->Resume(); |
| 675 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 676 | for (size_t i = 0; i < 4; i++) { |
stefan | 64136af | 2017-08-14 08:03:17 -0700 | [diff] [blame] | 677 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 678 | send_bucket_->Process(); |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 679 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 680 | clock_.AdvanceTimeMilliseconds(5); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 681 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 682 | |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 683 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 684 | } |
| 685 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 686 | TEST_P(PacedSenderTest, ResendPacket) { |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 687 | uint32_t ssrc = 12346; |
| 688 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 689 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 690 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 691 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 692 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 693 | sequence_number, capture_time_ms, 250, false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 694 | clock_.AdvanceTimeMilliseconds(1); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 695 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 696 | sequence_number + 1, capture_time_ms + 1, 250, |
| 697 | false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 698 | clock_.AdvanceTimeMilliseconds(9999); |
| 699 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 700 | send_bucket_->QueueInMs()); |
| 701 | // Fails to send first packet so only one call. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 702 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 703 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 704 | .Times(1) |
| 705 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 706 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 707 | send_bucket_->Process(); |
| 708 | |
| 709 | // Queue remains unchanged. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 710 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 711 | send_bucket_->QueueInMs()); |
| 712 | |
| 713 | // Fails to send second packet. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 714 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 715 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 716 | .Times(1) |
| 717 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 718 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 719 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 720 | .Times(1) |
| 721 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 722 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 723 | send_bucket_->Process(); |
| 724 | |
| 725 | // Queue is reduced by 1 packet. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 726 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms - 1, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 727 | send_bucket_->QueueInMs()); |
| 728 | |
| 729 | // Send second packet and queue becomes empty. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 730 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 731 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 732 | .Times(1) |
| 733 | .WillOnce(Return(true)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 734 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 735 | send_bucket_->Process(); |
| 736 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 737 | } |
| 738 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 739 | TEST_P(PacedSenderTest, ExpectedQueueTimeMs) { |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 740 | uint32_t ssrc = 12346; |
| 741 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 742 | const size_t kNumPackets = 60; |
| 743 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 744 | const int32_t kMaxBitrate = PacedSender::kDefaultPaceMultiplier * 30000; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 745 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 746 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 747 | send_bucket_->SetEstimatedBitrate(30000); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 748 | for (size_t i = 0; i < kNumPackets; ++i) { |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 749 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 750 | clock_.TimeInMilliseconds(), kPacketSize, false); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 751 | } |
| 752 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 753 | // Queue in ms = 1000 * (bytes in queue) *8 / (bits per second) |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 754 | int64_t queue_in_ms = |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 755 | static_cast<int64_t>(1000 * kNumPackets * kPacketSize * 8 / kMaxBitrate); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 756 | EXPECT_EQ(queue_in_ms, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 168f23f | 2014-07-11 13:44:02 +0000 | [diff] [blame] | 757 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 758 | int64_t time_start = clock_.TimeInMilliseconds(); |
| 759 | while (send_bucket_->QueueSizePackets() > 0) { |
| 760 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 761 | if (time_until_process <= 0) { |
| 762 | send_bucket_->Process(); |
| 763 | } else { |
| 764 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 765 | } |
| 766 | } |
| 767 | int64_t duration = clock_.TimeInMilliseconds() - time_start; |
| 768 | |
| 769 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
| 770 | |
sprang | 0a43fef | 2015-11-20 09:00:37 -0800 | [diff] [blame] | 771 | // Allow for aliasing, duration should be within one pack of max time limit. |
| 772 | EXPECT_NEAR(duration, PacedSender::kMaxQueueLengthMs, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 773 | static_cast<int64_t>(1000 * kPacketSize * 8 / kMaxBitrate)); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 774 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 775 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 776 | TEST_P(PacedSenderTest, QueueTimeGrowsOverTime) { |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 777 | uint32_t ssrc = 12346; |
| 778 | uint16_t sequence_number = 1234; |
| 779 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 780 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 781 | send_bucket_->SetEstimatedBitrate(30000); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 782 | SendAndExpectPacket(PacedSender::kNormalPriority, |
| 783 | ssrc, |
| 784 | sequence_number, |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 785 | clock_.TimeInMilliseconds(), |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 786 | 1200, |
| 787 | false); |
| 788 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 789 | clock_.AdvanceTimeMilliseconds(500); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 790 | EXPECT_EQ(500, send_bucket_->QueueInMs()); |
| 791 | send_bucket_->Process(); |
| 792 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 793 | } |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 794 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 795 | TEST_P(PacedSenderTest, ProbingWithInsertedPackets) { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 796 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 797 | const int kInitialBitrateBps = 300000; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 798 | uint32_t ssrc = 12346; |
| 799 | uint16_t sequence_number = 1234; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 800 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 801 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 802 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 803 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 804 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 805 | send_bucket_->SetEstimatedBitrate(kInitialBitrateBps); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 806 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 807 | for (int i = 0; i < 10; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 808 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 809 | sequence_number++, clock_.TimeInMilliseconds(), |
| 810 | kPacketSize, false); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 811 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 812 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 813 | int64_t start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 814 | while (packet_sender.packets_sent() < 5) { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 815 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 816 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 817 | send_bucket_->Process(); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 818 | } |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 819 | int packets_sent = packet_sender.packets_sent(); |
| 820 | // Validate first cluster bitrate. Note that we have to account for number |
| 821 | // of intervals and hence (packets_sent - 1) on the first cluster. |
| 822 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 823 | (clock_.TimeInMilliseconds() - start), |
| 824 | kFirstClusterBps, kBitrateProbingError); |
| 825 | EXPECT_EQ(0, packet_sender.padding_sent()); |
| 826 | |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 827 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 828 | start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 829 | while (packet_sender.packets_sent() < 10) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 830 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 831 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 832 | send_bucket_->Process(); |
| 833 | } |
| 834 | packets_sent = packet_sender.packets_sent() - packets_sent; |
| 835 | // Validate second cluster bitrate. |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 836 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 837 | (clock_.TimeInMilliseconds() - start), |
| 838 | kSecondClusterBps, kBitrateProbingError); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 839 | } |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 840 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 841 | TEST_P(PacedSenderTest, ProbingWithPaddingSupport) { |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 842 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 843 | const int kInitialBitrateBps = 300000; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 844 | uint32_t ssrc = 12346; |
| 845 | uint16_t sequence_number = 1234; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 846 | |
| 847 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 848 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 849 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 850 | send_bucket_->SetEstimatedBitrate(kInitialBitrateBps); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 851 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 852 | for (int i = 0; i < 3; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 853 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 854 | sequence_number++, clock_.TimeInMilliseconds(), |
| 855 | kPacketSize, false); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 856 | } |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 857 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 858 | int64_t start = clock_.TimeInMilliseconds(); |
| 859 | int process_count = 0; |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 860 | while (process_count < 5) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 861 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 862 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 863 | send_bucket_->Process(); |
| 864 | ++process_count; |
| 865 | } |
| 866 | int packets_sent = packet_sender.packets_sent(); |
| 867 | int padding_sent = packet_sender.padding_sent(); |
| 868 | EXPECT_GT(packets_sent, 0); |
| 869 | EXPECT_GT(padding_sent, 0); |
| 870 | // Note that the number of intervals here for kPacketSize is |
| 871 | // packets_sent due to padding in the same cluster. |
| 872 | EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) / |
| 873 | (clock_.TimeInMilliseconds() - start), |
| 874 | kFirstClusterBps, kBitrateProbingError); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 875 | } |
| 876 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 877 | TEST_P(PacedSenderTest, PriorityInversion) { |
| 878 | // In this test capture timestamps are used to order packets, capture |
| 879 | // timestamps are not used in PacketQueue2. |
| 880 | if (webrtc::field_trial::IsEnabled("WebRTC-RoundRobinPacing")) |
| 881 | return; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 882 | uint32_t ssrc = 12346; |
| 883 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 884 | const size_t kPacketSize = 1200; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 885 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 886 | send_bucket_->InsertPacket( |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 887 | PacedSender::kHighPriority, ssrc, sequence_number + 3, |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 888 | clock_.TimeInMilliseconds() + 33, kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 889 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 890 | send_bucket_->InsertPacket( |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 891 | PacedSender::kHighPriority, ssrc, sequence_number + 2, |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 892 | clock_.TimeInMilliseconds() + 33, kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 893 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 894 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, sequence_number, |
| 895 | clock_.TimeInMilliseconds(), kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 896 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 897 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, |
| 898 | sequence_number + 1, clock_.TimeInMilliseconds(), |
| 899 | kPacketSize, true); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 900 | |
| 901 | // Packets from earlier frames should be sent first. |
| 902 | { |
| 903 | ::testing::InSequence sequence; |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 904 | EXPECT_CALL(callback_, |
| 905 | TimeToSendPacket(ssrc, sequence_number, |
| 906 | clock_.TimeInMilliseconds(), true, _)) |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 907 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 908 | EXPECT_CALL(callback_, |
| 909 | TimeToSendPacket(ssrc, sequence_number + 1, |
| 910 | clock_.TimeInMilliseconds(), true, _)) |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 911 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 912 | EXPECT_CALL(callback_, |
| 913 | TimeToSendPacket(ssrc, sequence_number + 3, |
| 914 | clock_.TimeInMilliseconds() + 33, true, _)) |
| 915 | .WillOnce(Return(true)); |
| 916 | EXPECT_CALL(callback_, |
| 917 | TimeToSendPacket(ssrc, sequence_number + 2, |
| 918 | clock_.TimeInMilliseconds() + 33, true, _)) |
| 919 | .WillOnce(Return(true)); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 920 | |
| 921 | while (send_bucket_->QueueSizePackets() > 0) { |
| 922 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 923 | if (time_until_process <= 0) { |
| 924 | send_bucket_->Process(); |
| 925 | } else { |
| 926 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 927 | } |
| 928 | } |
| 929 | } |
| 930 | } |
| 931 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 932 | TEST_P(PacedSenderTest, PaddingOveruse) { |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 933 | uint32_t ssrc = 12346; |
| 934 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 935 | const size_t kPacketSize = 1200; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 936 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 937 | send_bucket_->Process(); |
| 938 | send_bucket_->SetEstimatedBitrate(60000); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 939 | send_bucket_->SetSendBitrateLimits(60000, 0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 940 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 941 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 942 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 943 | send_bucket_->Process(); |
| 944 | |
| 945 | // Add 30kbit padding. When increasing budget, media budget will increase from |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 946 | // negative (overuse) while padding budget will increase from 0. |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 947 | clock_.AdvanceTimeMilliseconds(5); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 948 | send_bucket_->SetSendBitrateLimits(60000, 30000); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 949 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 950 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 951 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 952 | EXPECT_LT(5u, send_bucket_->ExpectedQueueTimeMs()); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 953 | // Don't send padding if queue is non-empty, even if padding budget > 0. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 954 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 955 | send_bucket_->Process(); |
| 956 | } |
| 957 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 958 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 959 | #if 0 |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 960 | TEST_F(PacedSenderTest, AverageQueueTime) { |
| 961 | uint32_t ssrc = 12346; |
| 962 | uint16_t sequence_number = 1234; |
| 963 | const size_t kPacketSize = 1200; |
| 964 | const int kBitrateBps = 10 * kPacketSize * 8; // 10 packets per second. |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 965 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 966 | send_bucket_->SetEstimatedBitrate(kBitrateBps); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 967 | |
| 968 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 969 | |
| 970 | int64_t first_capture_time = clock_.TimeInMilliseconds(); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 971 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 972 | sequence_number, first_capture_time, kPacketSize, |
| 973 | false); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 974 | clock_.AdvanceTimeMilliseconds(10); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 975 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 976 | sequence_number + 1, clock_.TimeInMilliseconds(), |
| 977 | kPacketSize, false); |
| 978 | clock_.AdvanceTimeMilliseconds(10); |
| 979 | |
| 980 | EXPECT_EQ((20 + 10) / 2, send_bucket_->AverageQueueTimeMs()); |
| 981 | |
| 982 | // Only first packet (queued for 20ms) should be removed, leave the second |
| 983 | // packet (queued for 10ms) alone in the queue. |
| 984 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 985 | first_capture_time, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 986 | .Times(1) |
| 987 | .WillRepeatedly(Return(true)); |
| 988 | send_bucket_->Process(); |
| 989 | |
| 990 | EXPECT_EQ(10, send_bucket_->AverageQueueTimeMs()); |
| 991 | |
| 992 | clock_.AdvanceTimeMilliseconds(10); |
| 993 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 994 | first_capture_time + 10, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 995 | .Times(1) |
| 996 | .WillRepeatedly(Return(true)); |
| 997 | for (int i = 0; i < 3; ++i) { |
| 998 | clock_.AdvanceTimeMilliseconds(30); // Max delta. |
| 999 | send_bucket_->Process(); |
| 1000 | } |
| 1001 | |
| 1002 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 1003 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1004 | #endif |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1005 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 1006 | TEST_P(PacedSenderTest, ProbeClusterId) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1007 | uint32_t ssrc = 12346; |
| 1008 | uint16_t sequence_number = 1234; |
| 1009 | const size_t kPacketSize = 1200; |
| 1010 | |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 1011 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1012 | send_bucket_->SetProbingEnabled(true); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1013 | for (int i = 0; i < 10; ++i) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1014 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1015 | sequence_number + i, clock_.TimeInMilliseconds(), |
| 1016 | kPacketSize, false); |
| 1017 | } |
| 1018 | |
| 1019 | // First probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1020 | EXPECT_CALL(callback_, |
| 1021 | TimeToSendPacket(_, _, _, _, |
| 1022 | Field(&PacedPacketInfo::probe_cluster_id, 0))) |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1023 | .Times(5) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1024 | .WillRepeatedly(Return(true)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1025 | for (int i = 0; i < 5; ++i) { |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1026 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1027 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1028 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1029 | |
| 1030 | // Second probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1031 | EXPECT_CALL(callback_, |
| 1032 | TimeToSendPacket(_, _, _, _, |
| 1033 | Field(&PacedPacketInfo::probe_cluster_id, 1))) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1034 | .Times(5) |
| 1035 | .WillRepeatedly(Return(true)); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1036 | for (int i = 0; i < 5; ++i) { |
| 1037 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1038 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1039 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1040 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1041 | // Needed for the Field comparer below. |
| 1042 | const int kNotAProbe = PacedPacketInfo::kNotAProbe; |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1043 | // No more probing packets. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1044 | EXPECT_CALL(callback_, |
| 1045 | TimeToSendPadding( |
| 1046 | _, Field(&PacedPacketInfo::probe_cluster_id, kNotAProbe))) |
| 1047 | .Times(1) |
| 1048 | .WillRepeatedly(Return(500)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1049 | send_bucket_->Process(); |
| 1050 | } |
| 1051 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 1052 | TEST_P(PacedSenderTest, AvoidBusyLoopOnSendFailure) { |
philipel | b61927c | 2017-02-28 07:05:23 -0800 | [diff] [blame] | 1053 | uint32_t ssrc = 12346; |
| 1054 | uint16_t sequence_number = 1234; |
| 1055 | const size_t kPacketSize = kFirstClusterBps / (8000 / 10); |
| 1056 | |
| 1057 | send_bucket_->SetSendBitrateLimits(kTargetBitrateBps, kTargetBitrateBps); |
| 1058 | send_bucket_->SetProbingEnabled(true); |
| 1059 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1060 | sequence_number, clock_.TimeInMilliseconds(), |
| 1061 | kPacketSize, false); |
| 1062 | |
| 1063 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, _, _)) |
| 1064 | .WillOnce(Return(true)); |
| 1065 | send_bucket_->Process(); |
| 1066 | EXPECT_EQ(10, send_bucket_->TimeUntilNextProcess()); |
| 1067 | clock_.AdvanceTimeMilliseconds(9); |
| 1068 | |
| 1069 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)) |
| 1070 | .Times(2) |
| 1071 | .WillRepeatedly(Return(0)); |
| 1072 | send_bucket_->Process(); |
| 1073 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
| 1074 | clock_.AdvanceTimeMilliseconds(1); |
| 1075 | send_bucket_->Process(); |
| 1076 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 1077 | } |
| 1078 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1079 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 1080 | #if 0 |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1081 | TEST_F(PacedSenderTest, QueueTimeWithPause) { |
| 1082 | const size_t kPacketSize = 1200; |
| 1083 | const uint32_t kSsrc = 12346; |
| 1084 | uint16_t sequence_number = 1234; |
| 1085 | |
| 1086 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1087 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1088 | kPacketSize, false); |
| 1089 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1090 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1091 | kPacketSize, false); |
| 1092 | |
| 1093 | clock_.AdvanceTimeMilliseconds(100); |
| 1094 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1095 | |
| 1096 | send_bucket_->Pause(); |
| 1097 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1098 | |
| 1099 | // In paused state, queue time should not increase. |
| 1100 | clock_.AdvanceTimeMilliseconds(100); |
| 1101 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1102 | |
| 1103 | send_bucket_->Resume(); |
| 1104 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1105 | |
| 1106 | clock_.AdvanceTimeMilliseconds(100); |
| 1107 | EXPECT_EQ(200, send_bucket_->AverageQueueTimeMs()); |
| 1108 | } |
| 1109 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 1110 | TEST_P(PacedSenderTest, QueueTimePausedDuringPush) { |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1111 | const size_t kPacketSize = 1200; |
| 1112 | const uint32_t kSsrc = 12346; |
| 1113 | uint16_t sequence_number = 1234; |
| 1114 | |
| 1115 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1116 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1117 | kPacketSize, false); |
| 1118 | clock_.AdvanceTimeMilliseconds(100); |
| 1119 | send_bucket_->Pause(); |
| 1120 | clock_.AdvanceTimeMilliseconds(100); |
| 1121 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1122 | |
| 1123 | // Add a new packet during paused phase. |
| 1124 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1125 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1126 | kPacketSize, false); |
| 1127 | // From a queue time perspective, packet inserted during pause will have zero |
| 1128 | // queue time. Average queue time will then be (0 + 100) / 2 = 50. |
| 1129 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1130 | |
| 1131 | clock_.AdvanceTimeMilliseconds(100); |
| 1132 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1133 | |
| 1134 | send_bucket_->Resume(); |
| 1135 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1136 | |
| 1137 | clock_.AdvanceTimeMilliseconds(100); |
| 1138 | EXPECT_EQ(150, send_bucket_->AverageQueueTimeMs()); |
| 1139 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1140 | #endif |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1141 | |
| 1142 | // TODO(sprang): Extract PacketQueue from PacedSender so that we can test |
| 1143 | // removing elements while paused. (This is possible, but only because of semi- |
| 1144 | // racy condition so can't easily be tested). |
| 1145 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 1146 | } // namespace test |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1147 | } // namespace webrtc |