Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 11 | #include <cstddef> |
| 12 | #include <cstdint> |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 13 | #include <utility> |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 14 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 15 | #include "absl/memory/memory.h" |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 16 | #include "api/units/time_delta.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 17 | #include "modules/pacing/packet_router.h" |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 18 | #include "modules/rtp_rtcp/include/rtp_header_extension_map.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "modules/rtp_rtcp/mocks/mock_rtp_rtcp.h" |
| 20 | #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" |
| 21 | #include "rtc_base/checks.h" |
Steve Anton | 10542f2 | 2019-01-11 09:11:00 -0800 | [diff] [blame] | 22 | #include "rtc_base/fake_clock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 23 | #include "test/gmock.h" |
| 24 | #include "test/gtest.h" |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 25 | |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 26 | namespace webrtc { |
| 27 | |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 28 | // TODO(eladalon): Restructure and/or replace the existing monolithic tests |
| 29 | // (only some of the test are monolithic) according to the new |
| 30 | // guidelines - small tests for one thing at a time. |
| 31 | // (I'm not removing any tests during CL, so as to demonstrate no regressions.) |
| 32 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 33 | namespace { |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 34 | |
| 35 | using ::testing::_; |
| 36 | using ::testing::AnyNumber; |
| 37 | using ::testing::AtLeast; |
| 38 | using ::testing::Field; |
| 39 | using ::testing::Gt; |
| 40 | using ::testing::Le; |
| 41 | using ::testing::NiceMock; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 42 | using ::testing::Property; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 43 | using ::testing::Return; |
| 44 | using ::testing::ReturnPointee; |
| 45 | using ::testing::SaveArg; |
| 46 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 47 | constexpr int kProbeMinProbes = 5; |
| 48 | constexpr int kProbeMinBytes = 1000; |
| 49 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 50 | } // namespace |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 51 | |
eladalon | 32040ef | 2017-08-02 06:29:00 -0700 | [diff] [blame] | 52 | TEST(PacketRouterTest, Sanity_NoModuleRegistered_TimeToSendPacket) { |
| 53 | PacketRouter packet_router; |
| 54 | |
| 55 | constexpr uint16_t ssrc = 1234; |
| 56 | constexpr uint16_t sequence_number = 17; |
| 57 | constexpr uint64_t timestamp = 7890; |
| 58 | constexpr bool retransmission = false; |
| 59 | const PacedPacketInfo paced_info(1, kProbeMinProbes, kProbeMinBytes); |
| 60 | |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 61 | EXPECT_EQ(RtpPacketSendResult::kPacketNotFound, |
| 62 | packet_router.TimeToSendPacket(ssrc, sequence_number, timestamp, |
| 63 | retransmission, paced_info)); |
eladalon | 32040ef | 2017-08-02 06:29:00 -0700 | [diff] [blame] | 64 | } |
| 65 | |
| 66 | TEST(PacketRouterTest, Sanity_NoModuleRegistered_TimeToSendPadding) { |
| 67 | PacketRouter packet_router; |
| 68 | |
| 69 | constexpr size_t bytes = 300; |
| 70 | const PacedPacketInfo paced_info(1, kProbeMinProbes, kProbeMinBytes); |
| 71 | |
| 72 | EXPECT_EQ(packet_router.TimeToSendPadding(bytes, paced_info), 0u); |
| 73 | } |
| 74 | |
| 75 | TEST(PacketRouterTest, Sanity_NoModuleRegistered_OnReceiveBitrateChanged) { |
| 76 | PacketRouter packet_router; |
| 77 | |
| 78 | const std::vector<uint32_t> ssrcs = {1, 2, 3}; |
| 79 | constexpr uint32_t bitrate_bps = 10000; |
| 80 | |
| 81 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_bps); |
| 82 | } |
| 83 | |
| 84 | TEST(PacketRouterTest, Sanity_NoModuleRegistered_SendRemb) { |
| 85 | PacketRouter packet_router; |
| 86 | |
| 87 | const std::vector<uint32_t> ssrcs = {1, 2, 3}; |
| 88 | constexpr uint32_t bitrate_bps = 10000; |
| 89 | |
| 90 | EXPECT_FALSE(packet_router.SendRemb(bitrate_bps, ssrcs)); |
| 91 | } |
| 92 | |
| 93 | TEST(PacketRouterTest, Sanity_NoModuleRegistered_SendTransportFeedback) { |
| 94 | PacketRouter packet_router; |
| 95 | |
| 96 | rtcp::TransportFeedback feedback; |
| 97 | |
| 98 | EXPECT_FALSE(packet_router.SendTransportFeedback(&feedback)); |
| 99 | } |
| 100 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 101 | TEST(PacketRouterTest, TimeToSendPacket) { |
| 102 | PacketRouter packet_router; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 103 | NiceMock<MockRtpRtcp> rtp_1; |
| 104 | NiceMock<MockRtpRtcp> rtp_2; |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 105 | |
| 106 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 107 | packet_router.AddSendRtpModule(&rtp_2, false); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 108 | |
| 109 | const uint16_t kSsrc1 = 1234; |
| 110 | uint16_t sequence_number = 17; |
| 111 | uint64_t timestamp = 7890; |
| 112 | bool retransmission = false; |
| 113 | |
| 114 | // Send on the first module by letting rtp_1 be sending with correct ssrc. |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 115 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(true)); |
| 116 | ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1)); |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 117 | EXPECT_CALL(rtp_1, TimeToSendPacket( |
| 118 | kSsrc1, sequence_number, timestamp, retransmission, |
| 119 | Field(&PacedPacketInfo::probe_cluster_id, 1))) |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 120 | .Times(1) |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 121 | .WillOnce(Return(RtpPacketSendResult::kSuccess)); |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 122 | EXPECT_CALL(rtp_2, TimeToSendPacket).Times(0); |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 123 | EXPECT_EQ(RtpPacketSendResult::kSuccess, |
| 124 | packet_router.TimeToSendPacket( |
| 125 | kSsrc1, sequence_number, timestamp, retransmission, |
| 126 | PacedPacketInfo(1, kProbeMinProbes, kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 127 | |
| 128 | // Send on the second module by letting rtp_2 be sending, but not rtp_1. |
| 129 | ++sequence_number; |
| 130 | timestamp += 30; |
| 131 | retransmission = true; |
| 132 | const uint16_t kSsrc2 = 4567; |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 133 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(false)); |
| 134 | ON_CALL(rtp_2, SendingMedia).WillByDefault(Return(true)); |
| 135 | ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2)); |
| 136 | EXPECT_CALL(rtp_1, TimeToSendPacket).Times(0); |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 137 | EXPECT_CALL(rtp_2, TimeToSendPacket( |
| 138 | kSsrc2, sequence_number, timestamp, retransmission, |
| 139 | Field(&PacedPacketInfo::probe_cluster_id, 2))) |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 140 | .Times(1) |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 141 | .WillOnce(Return(RtpPacketSendResult::kSuccess)); |
| 142 | EXPECT_EQ(RtpPacketSendResult::kSuccess, |
| 143 | packet_router.TimeToSendPacket( |
| 144 | kSsrc2, sequence_number, timestamp, retransmission, |
| 145 | PacedPacketInfo(2, kProbeMinProbes, kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 146 | |
| 147 | // No module is sending, hence no packet should be sent. |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 148 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(false)); |
| 149 | ON_CALL(rtp_2, SendingMedia).WillByDefault(Return(false)); |
| 150 | EXPECT_CALL(rtp_1, TimeToSendPacket).Times(0); |
| 151 | EXPECT_CALL(rtp_2, TimeToSendPacket).Times(0); |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 152 | EXPECT_EQ(RtpPacketSendResult::kPacketNotFound, |
| 153 | packet_router.TimeToSendPacket( |
| 154 | kSsrc1, sequence_number, timestamp, retransmission, |
| 155 | PacedPacketInfo(1, kProbeMinProbes, kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 156 | |
| 157 | // Add a packet with incorrect ssrc and test it's dropped in the router. |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 158 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(true)); |
| 159 | ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1)); |
| 160 | ON_CALL(rtp_2, SendingMedia).WillByDefault(Return(true)); |
| 161 | ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2)); |
| 162 | EXPECT_CALL(rtp_1, TimeToSendPacket).Times(0); |
| 163 | EXPECT_CALL(rtp_2, TimeToSendPacket).Times(0); |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 164 | EXPECT_EQ(RtpPacketSendResult::kPacketNotFound, |
| 165 | packet_router.TimeToSendPacket( |
| 166 | kSsrc1 + kSsrc2, sequence_number, timestamp, retransmission, |
| 167 | PacedPacketInfo(1, kProbeMinProbes, kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 168 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 169 | packet_router.RemoveSendRtpModule(&rtp_1); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 170 | |
| 171 | // rtp_1 has been removed, try sending a packet on that ssrc and make sure |
| 172 | // it is dropped as expected by not expecting any calls to rtp_1. |
Danil Chapovalov | db59de3 | 2019-06-26 11:06:41 +0200 | [diff] [blame] | 173 | ON_CALL(rtp_2, SendingMedia).WillByDefault(Return(true)); |
| 174 | ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2)); |
| 175 | EXPECT_CALL(rtp_2, TimeToSendPacket).Times(0); |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 176 | EXPECT_EQ(RtpPacketSendResult::kPacketNotFound, |
| 177 | packet_router.TimeToSendPacket( |
| 178 | kSsrc1, sequence_number, timestamp, retransmission, |
| 179 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 180 | kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 181 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 182 | packet_router.RemoveSendRtpModule(&rtp_2); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 183 | } |
| 184 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 185 | TEST(PacketRouterTest, TimeToSendPadding) { |
| 186 | PacketRouter packet_router; |
| 187 | |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 188 | const uint16_t kSsrc1 = 1234; |
| 189 | const uint16_t kSsrc2 = 4567; |
| 190 | |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 191 | NiceMock<MockRtpRtcp> rtp_1; |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 192 | EXPECT_CALL(rtp_1, RtxSendStatus()).WillOnce(Return(kRtxOff)); |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 193 | EXPECT_CALL(rtp_1, SSRC()).WillRepeatedly(Return(kSsrc1)); |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 194 | NiceMock<MockRtpRtcp> rtp_2; |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 195 | // rtp_2 will be prioritized for padding. |
| 196 | EXPECT_CALL(rtp_2, RtxSendStatus()).WillOnce(Return(kRtxRedundantPayloads)); |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 197 | EXPECT_CALL(rtp_2, SSRC()).WillRepeatedly(Return(kSsrc2)); |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 198 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 199 | packet_router.AddSendRtpModule(&rtp_2, false); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 200 | |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 201 | // Default configuration, sending padding on all modules sending media, |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 202 | // ordered by priority (based on rtx mode). |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 203 | const size_t requested_padding_bytes = 1000; |
| 204 | const size_t sent_padding_bytes = 890; |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 205 | EXPECT_CALL(rtp_2, SendingMedia()).Times(1).WillOnce(Return(true)); |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 206 | EXPECT_CALL(rtp_2, HasBweExtensions()).Times(1).WillOnce(Return(true)); |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 207 | EXPECT_CALL(rtp_2, |
| 208 | TimeToSendPadding(requested_padding_bytes, |
| 209 | Field(&PacedPacketInfo::probe_cluster_id, 111))) |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 210 | .Times(1) |
| 211 | .WillOnce(Return(sent_padding_bytes)); |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 212 | EXPECT_CALL(rtp_1, SendingMedia()).Times(1).WillOnce(Return(true)); |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 213 | EXPECT_CALL(rtp_1, HasBweExtensions()).Times(1).WillOnce(Return(true)); |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 214 | EXPECT_CALL(rtp_1, |
| 215 | TimeToSendPadding(requested_padding_bytes - sent_padding_bytes, |
| 216 | Field(&PacedPacketInfo::probe_cluster_id, 111))) |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 217 | .Times(1) |
| 218 | .WillOnce(Return(requested_padding_bytes - sent_padding_bytes)); |
| 219 | EXPECT_EQ(requested_padding_bytes, |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 220 | packet_router.TimeToSendPadding( |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 221 | requested_padding_bytes, |
| 222 | PacedPacketInfo(111, kProbeMinBytes, kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 223 | |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 224 | // Let only the lower priority module be sending and verify the padding |
| 225 | // request is routed there. |
| 226 | EXPECT_CALL(rtp_2, SendingMedia()).Times(1).WillOnce(Return(false)); |
| 227 | EXPECT_CALL(rtp_2, TimeToSendPadding(requested_padding_bytes, _)).Times(0); |
| 228 | EXPECT_CALL(rtp_1, SendingMedia()).Times(1).WillOnce(Return(true)); |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 229 | EXPECT_CALL(rtp_1, HasBweExtensions()).Times(1).WillOnce(Return(true)); |
stefan | 16b0221 | 2017-01-27 07:12:16 -0800 | [diff] [blame] | 230 | EXPECT_CALL(rtp_1, TimeToSendPadding(_, _)) |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 231 | .Times(1) |
| 232 | .WillOnce(Return(sent_padding_bytes)); |
| 233 | EXPECT_EQ(sent_padding_bytes, |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 234 | packet_router.TimeToSendPadding( |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 235 | requested_padding_bytes, |
| 236 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 237 | kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 238 | |
| 239 | // No sending module at all. |
| 240 | EXPECT_CALL(rtp_1, SendingMedia()).Times(1).WillOnce(Return(false)); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 241 | EXPECT_CALL(rtp_1, TimeToSendPadding(requested_padding_bytes, _)).Times(0); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 242 | EXPECT_CALL(rtp_2, SendingMedia()).Times(1).WillOnce(Return(false)); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 243 | EXPECT_CALL(rtp_2, TimeToSendPadding(_, _)).Times(0); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 244 | EXPECT_EQ(0u, packet_router.TimeToSendPadding( |
| 245 | requested_padding_bytes, |
| 246 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 247 | kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 248 | |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 249 | // Only one module has BWE extensions. |
| 250 | EXPECT_CALL(rtp_1, SendingMedia()).Times(1).WillOnce(Return(true)); |
| 251 | EXPECT_CALL(rtp_1, HasBweExtensions()).Times(1).WillOnce(Return(false)); |
| 252 | EXPECT_CALL(rtp_1, TimeToSendPadding(requested_padding_bytes, _)).Times(0); |
| 253 | EXPECT_CALL(rtp_2, SendingMedia()).Times(1).WillOnce(Return(true)); |
| 254 | EXPECT_CALL(rtp_2, HasBweExtensions()).Times(1).WillOnce(Return(true)); |
| 255 | EXPECT_CALL(rtp_2, TimeToSendPadding(requested_padding_bytes, _)) |
| 256 | .Times(1) |
| 257 | .WillOnce(Return(sent_padding_bytes)); |
| 258 | EXPECT_EQ(sent_padding_bytes, |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 259 | packet_router.TimeToSendPadding( |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 260 | requested_padding_bytes, |
| 261 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 262 | kProbeMinBytes))); |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 263 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 264 | packet_router.RemoveSendRtpModule(&rtp_1); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 265 | |
| 266 | // rtp_1 has been removed, try sending padding and make sure rtp_1 isn't asked |
| 267 | // to send by not expecting any calls. Instead verify rtp_2 is called. |
| 268 | EXPECT_CALL(rtp_2, SendingMedia()).Times(1).WillOnce(Return(true)); |
stefan | 53b6cc3 | 2017-02-03 08:13:57 -0800 | [diff] [blame] | 269 | EXPECT_CALL(rtp_2, HasBweExtensions()).Times(1).WillOnce(Return(true)); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 270 | EXPECT_CALL(rtp_2, TimeToSendPadding(requested_padding_bytes, _)).Times(1); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 271 | EXPECT_EQ(0u, packet_router.TimeToSendPadding( |
| 272 | requested_padding_bytes, |
| 273 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 274 | kProbeMinBytes))); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 275 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 276 | packet_router.RemoveSendRtpModule(&rtp_2); |
Peter Boström | 3dd5d1d | 2016-02-25 16:56:48 +0100 | [diff] [blame] | 277 | } |
| 278 | |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 279 | TEST(PacketRouterTest, GeneratePaddingPicksCorrectModule) { |
| 280 | PacketRouter packet_router; |
| 281 | |
| 282 | // Two RTP modules. The first (prioritized due to rtx) isn't sending media so |
| 283 | // should not be called. |
| 284 | const uint16_t kSsrc1 = 1234; |
| 285 | const uint16_t kSsrc2 = 4567; |
| 286 | |
| 287 | NiceMock<MockRtpRtcp> rtp_1; |
| 288 | ON_CALL(rtp_1, RtxSendStatus()).WillByDefault(Return(kRtxRedundantPayloads)); |
| 289 | ON_CALL(rtp_1, SSRC()).WillByDefault(Return(kSsrc1)); |
| 290 | ON_CALL(rtp_1, SendingMedia()).WillByDefault(Return(false)); |
| 291 | ON_CALL(rtp_1, HasBweExtensions()).WillByDefault(Return(false)); |
| 292 | |
| 293 | NiceMock<MockRtpRtcp> rtp_2; |
| 294 | ON_CALL(rtp_2, RtxSendStatus()).WillByDefault(Return(kRtxOff)); |
| 295 | ON_CALL(rtp_2, SSRC()).WillByDefault(Return(kSsrc2)); |
| 296 | ON_CALL(rtp_2, SendingMedia()).WillByDefault(Return(true)); |
| 297 | ON_CALL(rtp_2, HasBweExtensions()).WillByDefault(Return(true)); |
| 298 | |
| 299 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 300 | packet_router.AddSendRtpModule(&rtp_2, false); |
| 301 | |
| 302 | const size_t kPaddingSize = 123; |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 303 | const size_t kExpectedPaddingPackets = 1; |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 304 | EXPECT_CALL(rtp_1, GeneratePadding(_)).Times(0); |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 305 | EXPECT_CALL(rtp_2, GeneratePadding(kPaddingSize)) |
| 306 | .WillOnce([&](size_t padding_size) { |
| 307 | return std::vector<std::unique_ptr<RtpPacketToSend>>( |
| 308 | kExpectedPaddingPackets); |
| 309 | }); |
| 310 | auto generated_padding = packet_router.GeneratePadding(kPaddingSize); |
| 311 | EXPECT_EQ(generated_padding.size(), kExpectedPaddingPackets); |
Erik Språng | 478cb46 | 2019-06-26 15:49:27 +0200 | [diff] [blame] | 312 | |
| 313 | packet_router.RemoveSendRtpModule(&rtp_1); |
| 314 | packet_router.RemoveSendRtpModule(&rtp_2); |
| 315 | } |
| 316 | |
Erik Språng | 8b7ca4a | 2018-05-17 13:43:35 +0200 | [diff] [blame] | 317 | TEST(PacketRouterTest, PadsOnLastActiveMediaStream) { |
| 318 | PacketRouter packet_router; |
| 319 | |
| 320 | const uint16_t kSsrc1 = 1234; |
| 321 | const uint16_t kSsrc2 = 4567; |
| 322 | const uint16_t kSsrc3 = 8901; |
| 323 | |
| 324 | // First two rtp modules send media and have rtx. |
| 325 | NiceMock<MockRtpRtcp> rtp_1; |
| 326 | EXPECT_CALL(rtp_1, RtxSendStatus()) |
| 327 | .WillRepeatedly(Return(kRtxRedundantPayloads)); |
| 328 | EXPECT_CALL(rtp_1, SSRC()).WillRepeatedly(Return(kSsrc1)); |
| 329 | EXPECT_CALL(rtp_1, SendingMedia()).WillRepeatedly(Return(true)); |
| 330 | EXPECT_CALL(rtp_1, HasBweExtensions()).WillRepeatedly(Return(true)); |
| 331 | |
| 332 | NiceMock<MockRtpRtcp> rtp_2; |
| 333 | EXPECT_CALL(rtp_2, RtxSendStatus()) |
| 334 | .WillRepeatedly(Return(kRtxRedundantPayloads)); |
| 335 | EXPECT_CALL(rtp_2, SSRC()).WillRepeatedly(Return(kSsrc2)); |
| 336 | EXPECT_CALL(rtp_2, SendingMedia()).WillRepeatedly(Return(true)); |
| 337 | EXPECT_CALL(rtp_2, HasBweExtensions()).WillRepeatedly(Return(true)); |
| 338 | |
| 339 | // Third module is sending media, but does not support rtx. |
| 340 | NiceMock<MockRtpRtcp> rtp_3; |
| 341 | EXPECT_CALL(rtp_3, RtxSendStatus()).WillRepeatedly(Return(kRtxOff)); |
| 342 | EXPECT_CALL(rtp_3, SSRC()).WillRepeatedly(Return(kSsrc3)); |
| 343 | EXPECT_CALL(rtp_3, SendingMedia()).WillRepeatedly(Return(true)); |
| 344 | EXPECT_CALL(rtp_3, HasBweExtensions()).WillRepeatedly(Return(true)); |
| 345 | |
| 346 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 347 | packet_router.AddSendRtpModule(&rtp_2, false); |
| 348 | packet_router.AddSendRtpModule(&rtp_3, false); |
| 349 | |
| 350 | const size_t kPaddingBytes = 100; |
| 351 | |
| 352 | // Initially, padding will be sent on last added rtp module that sends media |
| 353 | // and supports rtx. |
| 354 | EXPECT_CALL(rtp_2, TimeToSendPadding(kPaddingBytes, _)) |
| 355 | .Times(1) |
| 356 | .WillOnce(Return(kPaddingBytes)); |
| 357 | packet_router.TimeToSendPadding(kPaddingBytes, PacedPacketInfo()); |
| 358 | |
| 359 | // Send media on first module. Padding should be sent on that module. |
| 360 | EXPECT_CALL(rtp_1, TimeToSendPacket(kSsrc1, _, _, _, _)); |
| 361 | packet_router.TimeToSendPacket(kSsrc1, 0, 0, false, PacedPacketInfo()); |
| 362 | |
| 363 | EXPECT_CALL(rtp_1, TimeToSendPadding(kPaddingBytes, _)) |
| 364 | .Times(1) |
| 365 | .WillOnce(Return(kPaddingBytes)); |
| 366 | packet_router.TimeToSendPadding(kPaddingBytes, PacedPacketInfo()); |
| 367 | |
| 368 | // Send media on second module. Padding should be sent there. |
| 369 | EXPECT_CALL(rtp_2, TimeToSendPacket(kSsrc2, _, _, _, _)); |
| 370 | packet_router.TimeToSendPacket(kSsrc2, 0, 0, false, PacedPacketInfo()); |
| 371 | |
| 372 | EXPECT_CALL(rtp_2, TimeToSendPadding(kPaddingBytes, _)) |
| 373 | .Times(1) |
| 374 | .WillOnce(Return(kPaddingBytes)); |
| 375 | packet_router.TimeToSendPadding(kPaddingBytes, PacedPacketInfo()); |
| 376 | |
| 377 | // Remove second module, padding should now fall back to first module. |
| 378 | packet_router.RemoveSendRtpModule(&rtp_2); |
| 379 | EXPECT_CALL(rtp_1, TimeToSendPadding(kPaddingBytes, _)) |
| 380 | .Times(1) |
| 381 | .WillOnce(Return(kPaddingBytes)); |
| 382 | packet_router.TimeToSendPadding(kPaddingBytes, PacedPacketInfo()); |
| 383 | |
| 384 | // Remove first module too, leaving only the one without rtx. |
| 385 | packet_router.RemoveSendRtpModule(&rtp_1); |
| 386 | |
| 387 | EXPECT_CALL(rtp_3, TimeToSendPadding(kPaddingBytes, _)) |
| 388 | .Times(1) |
| 389 | .WillOnce(Return(kPaddingBytes)); |
| 390 | packet_router.TimeToSendPadding(kPaddingBytes, PacedPacketInfo()); |
| 391 | |
| 392 | packet_router.RemoveSendRtpModule(&rtp_3); |
| 393 | } |
| 394 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 395 | TEST(PacketRouterTest, SenderOnlyFunctionsRespectSendingMedia) { |
| 396 | PacketRouter packet_router; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 397 | NiceMock<MockRtpRtcp> rtp; |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 398 | packet_router.AddSendRtpModule(&rtp, false); |
Peter Boström | 3dd5d1d | 2016-02-25 16:56:48 +0100 | [diff] [blame] | 399 | static const uint16_t kSsrc = 1234; |
| 400 | EXPECT_CALL(rtp, SSRC()).WillRepeatedly(Return(kSsrc)); |
| 401 | EXPECT_CALL(rtp, SendingMedia()).WillRepeatedly(Return(false)); |
| 402 | |
| 403 | // Verify that TimeToSendPacket does not end up in a receiver. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 404 | EXPECT_CALL(rtp, TimeToSendPacket(_, _, _, _, _)).Times(0); |
Erik Språng | d287962 | 2019-05-10 08:29:01 -0700 | [diff] [blame] | 405 | EXPECT_EQ(RtpPacketSendResult::kPacketNotFound, |
| 406 | packet_router.TimeToSendPacket( |
| 407 | kSsrc, 1, 1, false, |
| 408 | PacedPacketInfo(PacedPacketInfo::kNotAProbe, kProbeMinBytes, |
| 409 | kProbeMinBytes))); |
Peter Boström | 3dd5d1d | 2016-02-25 16:56:48 +0100 | [diff] [blame] | 410 | // Verify that TimeToSendPadding does not end up in a receiver. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 411 | EXPECT_CALL(rtp, TimeToSendPadding(_, _)).Times(0); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 412 | EXPECT_EQ(0u, packet_router.TimeToSendPadding( |
| 413 | 200, PacedPacketInfo(PacedPacketInfo::kNotAProbe, |
| 414 | kProbeMinBytes, kProbeMinBytes))); |
Peter Boström | 3dd5d1d | 2016-02-25 16:56:48 +0100 | [diff] [blame] | 415 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 416 | packet_router.RemoveSendRtpModule(&rtp); |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 417 | } |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 418 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 419 | TEST(PacketRouterTest, AllocateSequenceNumbers) { |
| 420 | PacketRouter packet_router; |
| 421 | |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 422 | const uint16_t kStartSeq = 0xFFF0; |
| 423 | const size_t kNumPackets = 32; |
| 424 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 425 | packet_router.SetTransportWideSequenceNumber(kStartSeq - 1); |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 426 | |
| 427 | for (size_t i = 0; i < kNumPackets; ++i) { |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 428 | uint16_t seq = packet_router.AllocateSequenceNumber(); |
sprang | 867fb52 | 2015-08-03 04:38:41 -0700 | [diff] [blame] | 429 | uint32_t expected_unwrapped_seq = static_cast<uint32_t>(kStartSeq) + i; |
| 430 | EXPECT_EQ(static_cast<uint16_t>(expected_unwrapped_seq & 0xFFFF), seq); |
| 431 | } |
| 432 | } |
stefan | bba9dec | 2016-02-01 04:39:55 -0800 | [diff] [blame] | 433 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 434 | TEST(PacketRouterTest, SendTransportFeedback) { |
| 435 | PacketRouter packet_router; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 436 | NiceMock<MockRtpRtcp> rtp_1; |
| 437 | NiceMock<MockRtpRtcp> rtp_2; |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 438 | |
| 439 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 440 | packet_router.AddReceiveRtpModule(&rtp_2, false); |
stefan | bba9dec | 2016-02-01 04:39:55 -0800 | [diff] [blame] | 441 | |
| 442 | rtcp::TransportFeedback feedback; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 443 | EXPECT_CALL(rtp_1, SendFeedbackPacket(_)).Times(1).WillOnce(Return(true)); |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 444 | packet_router.SendTransportFeedback(&feedback); |
| 445 | packet_router.RemoveSendRtpModule(&rtp_1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 446 | EXPECT_CALL(rtp_2, SendFeedbackPacket(_)).Times(1).WillOnce(Return(true)); |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 447 | packet_router.SendTransportFeedback(&feedback); |
| 448 | packet_router.RemoveReceiveRtpModule(&rtp_2); |
stefan | bba9dec | 2016-02-01 04:39:55 -0800 | [diff] [blame] | 449 | } |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 450 | |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 451 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 452 | TEST(PacketRouterTest, DoubleRegistrationOfSendModuleDisallowed) { |
| 453 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 454 | NiceMock<MockRtpRtcp> module; |
| 455 | |
| 456 | constexpr bool remb_candidate = false; // Value irrelevant. |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 457 | packet_router.AddSendRtpModule(&module, remb_candidate); |
| 458 | EXPECT_DEATH(packet_router.AddSendRtpModule(&module, remb_candidate), ""); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 459 | |
| 460 | // Test tear-down |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 461 | packet_router.RemoveSendRtpModule(&module); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 462 | } |
| 463 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 464 | TEST(PacketRouterTest, DoubleRegistrationOfReceiveModuleDisallowed) { |
| 465 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 466 | NiceMock<MockRtpRtcp> module; |
| 467 | |
| 468 | constexpr bool remb_candidate = false; // Value irrelevant. |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 469 | packet_router.AddReceiveRtpModule(&module, remb_candidate); |
| 470 | EXPECT_DEATH(packet_router.AddReceiveRtpModule(&module, remb_candidate), ""); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 471 | |
| 472 | // Test tear-down |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 473 | packet_router.RemoveReceiveRtpModule(&module); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 474 | } |
| 475 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 476 | TEST(PacketRouterTest, RemovalOfNeverAddedSendModuleDisallowed) { |
| 477 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 478 | NiceMock<MockRtpRtcp> module; |
| 479 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 480 | EXPECT_DEATH(packet_router.RemoveSendRtpModule(&module), ""); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 481 | } |
| 482 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 483 | TEST(PacketRouterTest, RemovalOfNeverAddedReceiveModuleDisallowed) { |
| 484 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 485 | NiceMock<MockRtpRtcp> module; |
| 486 | |
eladalon | b1338fe | 2017-08-01 09:36:19 -0700 | [diff] [blame] | 487 | EXPECT_DEATH(packet_router.RemoveReceiveRtpModule(&module), ""); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 488 | } |
| 489 | #endif // RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 490 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 491 | TEST(PacketRouterRembTest, LowerEstimateToSendRemb) { |
| 492 | rtc::ScopedFakeClock clock; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 493 | NiceMock<MockRtpRtcp> rtp; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 494 | PacketRouter packet_router; |
| 495 | |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 496 | packet_router.AddSendRtpModule(&rtp, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 497 | |
| 498 | uint32_t bitrate_estimate = 456; |
| 499 | const std::vector<uint32_t> ssrcs = {1234}; |
| 500 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 501 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 502 | |
| 503 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 504 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 505 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 506 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 507 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 508 | // Lower the estimate with more than 3% to trigger a call to SetRemb right |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 509 | // away. |
| 510 | bitrate_estimate = bitrate_estimate - 100; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 511 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 512 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 513 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 514 | packet_router.RemoveSendRtpModule(&rtp); |
| 515 | } |
| 516 | |
| 517 | TEST(PacketRouterRembTest, VerifyIncreasingAndDecreasing) { |
| 518 | rtc::ScopedFakeClock clock; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 519 | NiceMock<MockRtpRtcp> rtp; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 520 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 521 | packet_router.AddSendRtpModule(&rtp, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 522 | |
| 523 | uint32_t bitrate_estimate[] = {456, 789}; |
| 524 | std::vector<uint32_t> ssrcs = {1234, 5678}; |
| 525 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 526 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate[0]); |
| 527 | |
| 528 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 529 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate[0], ssrcs)).Times(1); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 530 | clock.AdvanceTime(TimeDelta::ms(1000)); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 531 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate[0]); |
| 532 | |
| 533 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate[1] + 100); |
| 534 | |
| 535 | // Lower the estimate to trigger a callback. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 536 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate[1], ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 537 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate[1]); |
| 538 | |
| 539 | packet_router.RemoveSendRtpModule(&rtp); |
| 540 | } |
| 541 | |
| 542 | TEST(PacketRouterRembTest, NoRembForIncreasedBitrate) { |
| 543 | rtc::ScopedFakeClock clock; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 544 | NiceMock<MockRtpRtcp> rtp; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 545 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 546 | packet_router.AddSendRtpModule(&rtp, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 547 | |
| 548 | uint32_t bitrate_estimate = 456; |
| 549 | std::vector<uint32_t> ssrcs = {1234, 5678}; |
| 550 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 551 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 552 | |
| 553 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 554 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 555 | clock.AdvanceTime(TimeDelta::ms(1000)); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 556 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 557 | |
| 558 | // Increased estimate shouldn't trigger a callback right away. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 559 | EXPECT_CALL(rtp, SetRemb(_, _)).Times(0); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 560 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate + 1); |
| 561 | |
| 562 | // Decreasing the estimate less than 3% shouldn't trigger a new callback. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 563 | EXPECT_CALL(rtp, SetRemb(_, _)).Times(0); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 564 | int lower_estimate = bitrate_estimate * 98 / 100; |
| 565 | packet_router.OnReceiveBitrateChanged(ssrcs, lower_estimate); |
| 566 | |
| 567 | packet_router.RemoveSendRtpModule(&rtp); |
| 568 | } |
| 569 | |
| 570 | TEST(PacketRouterRembTest, ChangeSendRtpModule) { |
| 571 | rtc::ScopedFakeClock clock; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 572 | NiceMock<MockRtpRtcp> rtp_send; |
| 573 | NiceMock<MockRtpRtcp> rtp_recv; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 574 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 575 | packet_router.AddSendRtpModule(&rtp_send, true); |
| 576 | packet_router.AddReceiveRtpModule(&rtp_recv, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 577 | |
| 578 | uint32_t bitrate_estimate = 456; |
| 579 | std::vector<uint32_t> ssrcs = {1234, 5678}; |
| 580 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 581 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 582 | |
| 583 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 584 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 585 | EXPECT_CALL(rtp_send, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 586 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 587 | |
| 588 | // Decrease estimate to trigger a REMB. |
| 589 | bitrate_estimate = bitrate_estimate - 100; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 590 | EXPECT_CALL(rtp_send, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 591 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 592 | |
| 593 | // Remove the sending module -> should get remb on the second module. |
| 594 | packet_router.RemoveSendRtpModule(&rtp_send); |
| 595 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 596 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 597 | |
| 598 | bitrate_estimate = bitrate_estimate - 100; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 599 | EXPECT_CALL(rtp_recv, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 600 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 601 | |
| 602 | packet_router.RemoveReceiveRtpModule(&rtp_recv); |
| 603 | } |
| 604 | |
| 605 | TEST(PacketRouterRembTest, OnlyOneRembForRepeatedOnReceiveBitrateChanged) { |
| 606 | rtc::ScopedFakeClock clock; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 607 | NiceMock<MockRtpRtcp> rtp; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 608 | PacketRouter packet_router; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 609 | packet_router.AddSendRtpModule(&rtp, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 610 | |
| 611 | uint32_t bitrate_estimate = 456; |
| 612 | const std::vector<uint32_t> ssrcs = {1234}; |
| 613 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 614 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 615 | |
| 616 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 617 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 618 | EXPECT_CALL(rtp, SetRemb(_, _)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 619 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 620 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 621 | // Lower the estimate, should trigger a call to SetRemb right away. |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 622 | bitrate_estimate = bitrate_estimate - 100; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 623 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 624 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 625 | |
| 626 | // Call OnReceiveBitrateChanged again, this should not trigger a new callback. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 627 | EXPECT_CALL(rtp, SetRemb(_, _)).Times(0); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 628 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 629 | packet_router.RemoveSendRtpModule(&rtp); |
| 630 | } |
| 631 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 632 | TEST(PacketRouterRembTest, SetMaxDesiredReceiveBitrateLimitsSetRemb) { |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 633 | rtc::ScopedFakeClock clock; |
| 634 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 635 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 636 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 637 | constexpr bool remb_candidate = true; |
| 638 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 639 | |
Danil Chapovalov | 1de4b62 | 2017-12-13 13:35:10 +0100 | [diff] [blame] | 640 | const int64_t cap_bitrate = 100000; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 641 | EXPECT_CALL(remb_sender, SetRemb(Le(cap_bitrate), _)).Times(AtLeast(1)); |
| 642 | EXPECT_CALL(remb_sender, SetRemb(Gt(cap_bitrate), _)).Times(0); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 643 | |
| 644 | const std::vector<uint32_t> ssrcs = {1234}; |
| 645 | packet_router.SetMaxDesiredReceiveBitrate(cap_bitrate); |
| 646 | packet_router.OnReceiveBitrateChanged(ssrcs, cap_bitrate + 5000); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 647 | clock.AdvanceTime(TimeDelta::ms(1000)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 648 | packet_router.OnReceiveBitrateChanged(ssrcs, cap_bitrate - 5000); |
| 649 | |
| 650 | // Test tear-down. |
| 651 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 652 | } |
| 653 | |
| 654 | TEST(PacketRouterRembTest, |
| 655 | SetMaxDesiredReceiveBitrateTriggersRembWhenMoreRestrictive) { |
| 656 | rtc::ScopedFakeClock clock; |
| 657 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 658 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 659 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 660 | constexpr bool remb_candidate = true; |
| 661 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 662 | |
Danil Chapovalov | 1de4b62 | 2017-12-13 13:35:10 +0100 | [diff] [blame] | 663 | const int64_t measured_bitrate_bps = 150000; |
| 664 | const int64_t cap_bitrate_bps = measured_bitrate_bps - 5000; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 665 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 666 | EXPECT_CALL(remb_sender, SetRemb(measured_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 667 | packet_router.OnReceiveBitrateChanged(ssrcs, measured_bitrate_bps); |
| 668 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 669 | EXPECT_CALL(remb_sender, SetRemb(cap_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 670 | packet_router.SetMaxDesiredReceiveBitrate(cap_bitrate_bps); |
| 671 | |
| 672 | // Test tear-down. |
| 673 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 674 | } |
| 675 | |
| 676 | TEST(PacketRouterRembTest, |
| 677 | SetMaxDesiredReceiveBitrateDoesNotTriggerRembWhenAsRestrictive) { |
| 678 | rtc::ScopedFakeClock clock; |
| 679 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 680 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 681 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 682 | constexpr bool remb_candidate = true; |
| 683 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 684 | |
| 685 | const uint32_t measured_bitrate_bps = 150000; |
| 686 | const uint32_t cap_bitrate_bps = measured_bitrate_bps; |
| 687 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 688 | EXPECT_CALL(remb_sender, SetRemb(measured_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 689 | packet_router.OnReceiveBitrateChanged(ssrcs, measured_bitrate_bps); |
| 690 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 691 | EXPECT_CALL(remb_sender, SetRemb(_, _)).Times(0); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 692 | packet_router.SetMaxDesiredReceiveBitrate(cap_bitrate_bps); |
| 693 | |
| 694 | // Test tear-down. |
| 695 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 696 | } |
| 697 | |
| 698 | TEST(PacketRouterRembTest, |
| 699 | SetMaxDesiredReceiveBitrateDoesNotTriggerRembWhenLessRestrictive) { |
| 700 | rtc::ScopedFakeClock clock; |
| 701 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 702 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 703 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 704 | constexpr bool remb_candidate = true; |
| 705 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 706 | |
| 707 | const uint32_t measured_bitrate_bps = 150000; |
| 708 | const uint32_t cap_bitrate_bps = measured_bitrate_bps + 500; |
| 709 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 710 | EXPECT_CALL(remb_sender, SetRemb(measured_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 711 | packet_router.OnReceiveBitrateChanged(ssrcs, measured_bitrate_bps); |
| 712 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 713 | EXPECT_CALL(remb_sender, SetRemb(_, _)).Times(0); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 714 | packet_router.SetMaxDesiredReceiveBitrate(cap_bitrate_bps); |
| 715 | |
| 716 | // Test tear-down. |
| 717 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 718 | } |
| 719 | |
| 720 | TEST(PacketRouterRembTest, |
| 721 | SetMaxDesiredReceiveBitrateTriggersRembWhenNoRecentMeasure) { |
| 722 | rtc::ScopedFakeClock clock; |
| 723 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 724 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 725 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 726 | constexpr bool remb_candidate = true; |
| 727 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 728 | |
| 729 | const uint32_t measured_bitrate_bps = 150000; |
| 730 | const uint32_t cap_bitrate_bps = measured_bitrate_bps + 5000; |
| 731 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 732 | EXPECT_CALL(remb_sender, SetRemb(measured_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 733 | packet_router.OnReceiveBitrateChanged(ssrcs, measured_bitrate_bps); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 734 | clock.AdvanceTime(TimeDelta::ms(1000)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 735 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 736 | EXPECT_CALL(remb_sender, SetRemb(cap_bitrate_bps, _)); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 737 | packet_router.SetMaxDesiredReceiveBitrate(cap_bitrate_bps); |
| 738 | |
| 739 | // Test tear-down. |
| 740 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 741 | } |
| 742 | |
| 743 | TEST(PacketRouterRembTest, |
| 744 | SetMaxDesiredReceiveBitrateTriggersRembWhenNoMeasures) { |
| 745 | rtc::ScopedFakeClock clock; |
| 746 | PacketRouter packet_router; |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 747 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 748 | NiceMock<MockRtpRtcp> remb_sender; |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 749 | constexpr bool remb_candidate = true; |
| 750 | packet_router.AddSendRtpModule(&remb_sender, remb_candidate); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 751 | |
| 752 | // Set cap. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 753 | EXPECT_CALL(remb_sender, SetRemb(100000, _)).Times(1); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 754 | packet_router.SetMaxDesiredReceiveBitrate(100000); |
| 755 | // Increase cap. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 756 | EXPECT_CALL(remb_sender, SetRemb(200000, _)).Times(1); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 757 | packet_router.SetMaxDesiredReceiveBitrate(200000); |
| 758 | // Decrease cap. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 759 | EXPECT_CALL(remb_sender, SetRemb(150000, _)).Times(1); |
danilchap | 4708537 | 2017-08-10 06:03:57 -0700 | [diff] [blame] | 760 | packet_router.SetMaxDesiredReceiveBitrate(150000); |
| 761 | |
| 762 | // Test tear-down. |
| 763 | packet_router.RemoveSendRtpModule(&remb_sender); |
| 764 | } |
| 765 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 766 | // Only register receiving modules and make sure we fallback to trigger a REMB |
| 767 | // packet on this one. |
| 768 | TEST(PacketRouterRembTest, NoSendingRtpModule) { |
| 769 | rtc::ScopedFakeClock clock; |
eladalon | 6c9556e | 2017-07-10 03:33:00 -0700 | [diff] [blame] | 770 | NiceMock<MockRtpRtcp> rtp; |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 771 | PacketRouter packet_router; |
| 772 | |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 773 | packet_router.AddReceiveRtpModule(&rtp, true); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 774 | |
| 775 | uint32_t bitrate_estimate = 456; |
| 776 | const std::vector<uint32_t> ssrcs = {1234}; |
| 777 | |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 778 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 779 | |
| 780 | // Call OnReceiveBitrateChanged twice to get a first estimate. |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 781 | clock.AdvanceTime(TimeDelta::ms(1000)); |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 782 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 783 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 784 | |
| 785 | // Lower the estimate to trigger a new packet REMB packet. |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 786 | EXPECT_CALL(rtp, SetRemb(bitrate_estimate - 100, ssrcs)).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 787 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate - 100); |
| 788 | |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 789 | EXPECT_CALL(rtp, UnsetRemb()).Times(1); |
nisse | 0584331 | 2017-04-18 23:38:35 -0700 | [diff] [blame] | 790 | packet_router.RemoveReceiveRtpModule(&rtp); |
| 791 | } |
| 792 | |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 793 | TEST(PacketRouterRembTest, NonCandidateSendRtpModuleNotUsedForRemb) { |
| 794 | rtc::ScopedFakeClock clock; |
| 795 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 796 | NiceMock<MockRtpRtcp> module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 797 | |
| 798 | constexpr bool remb_candidate = false; |
| 799 | |
| 800 | packet_router.AddSendRtpModule(&module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 801 | |
| 802 | constexpr uint32_t bitrate_estimate = 456; |
| 803 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 804 | EXPECT_CALL(module, SetRemb(_, _)).Times(0); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 805 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 806 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 807 | |
| 808 | // Test tear-down |
| 809 | packet_router.RemoveSendRtpModule(&module); |
| 810 | } |
| 811 | |
| 812 | TEST(PacketRouterRembTest, CandidateSendRtpModuleUsedForRemb) { |
| 813 | rtc::ScopedFakeClock clock; |
| 814 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 815 | NiceMock<MockRtpRtcp> module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 816 | |
| 817 | constexpr bool remb_candidate = true; |
| 818 | |
| 819 | packet_router.AddSendRtpModule(&module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 820 | |
| 821 | constexpr uint32_t bitrate_estimate = 456; |
| 822 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 823 | EXPECT_CALL(module, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 824 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 825 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 826 | |
| 827 | // Test tear-down |
| 828 | packet_router.RemoveSendRtpModule(&module); |
| 829 | } |
| 830 | |
| 831 | TEST(PacketRouterRembTest, NonCandidateReceiveRtpModuleNotUsedForRemb) { |
| 832 | rtc::ScopedFakeClock clock; |
| 833 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 834 | NiceMock<MockRtpRtcp> module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 835 | |
| 836 | constexpr bool remb_candidate = false; |
| 837 | |
| 838 | packet_router.AddReceiveRtpModule(&module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 839 | |
| 840 | constexpr uint32_t bitrate_estimate = 456; |
| 841 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 842 | EXPECT_CALL(module, SetRemb(_, _)).Times(0); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 843 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 844 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 845 | |
| 846 | // Test tear-down |
| 847 | packet_router.RemoveReceiveRtpModule(&module); |
| 848 | } |
| 849 | |
| 850 | TEST(PacketRouterRembTest, CandidateReceiveRtpModuleUsedForRemb) { |
| 851 | rtc::ScopedFakeClock clock; |
| 852 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 853 | NiceMock<MockRtpRtcp> module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 854 | |
| 855 | constexpr bool remb_candidate = true; |
| 856 | |
| 857 | packet_router.AddReceiveRtpModule(&module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 858 | |
| 859 | constexpr uint32_t bitrate_estimate = 456; |
| 860 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 861 | EXPECT_CALL(module, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 862 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 863 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 864 | |
| 865 | // Test tear-down |
| 866 | packet_router.RemoveReceiveRtpModule(&module); |
| 867 | } |
| 868 | |
| 869 | TEST(PacketRouterRembTest, |
| 870 | SendCandidatePreferredOverReceiveCandidate_SendModuleAddedFirst) { |
| 871 | rtc::ScopedFakeClock clock; |
| 872 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 873 | NiceMock<MockRtpRtcp> send_module; |
| 874 | NiceMock<MockRtpRtcp> receive_module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 875 | |
| 876 | constexpr bool remb_candidate = true; |
| 877 | |
| 878 | // Send module added - activated. |
| 879 | packet_router.AddSendRtpModule(&send_module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 880 | |
| 881 | // Receive module added - the send module remains the active one. |
| 882 | packet_router.AddReceiveRtpModule(&receive_module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 883 | |
| 884 | constexpr uint32_t bitrate_estimate = 456; |
| 885 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 886 | EXPECT_CALL(send_module, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
| 887 | EXPECT_CALL(receive_module, SetRemb(_, _)).Times(0); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 888 | |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 889 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 890 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 891 | |
| 892 | // Test tear-down |
| 893 | packet_router.RemoveReceiveRtpModule(&receive_module); |
| 894 | packet_router.RemoveSendRtpModule(&send_module); |
| 895 | } |
| 896 | |
| 897 | TEST(PacketRouterRembTest, |
| 898 | SendCandidatePreferredOverReceiveCandidate_ReceiveModuleAddedFirst) { |
| 899 | rtc::ScopedFakeClock clock; |
| 900 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 901 | NiceMock<MockRtpRtcp> send_module; |
| 902 | NiceMock<MockRtpRtcp> receive_module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 903 | |
| 904 | constexpr bool remb_candidate = true; |
| 905 | |
| 906 | // Receive module added - activated. |
| 907 | packet_router.AddReceiveRtpModule(&receive_module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 908 | |
| 909 | // Send module added - replaces receive module as active. |
| 910 | packet_router.AddSendRtpModule(&send_module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 911 | |
| 912 | constexpr uint32_t bitrate_estimate = 456; |
| 913 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 914 | EXPECT_CALL(send_module, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
| 915 | EXPECT_CALL(receive_module, SetRemb(_, _)).Times(0); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 916 | |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 917 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 918 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 919 | |
| 920 | // Test tear-down |
| 921 | packet_router.RemoveReceiveRtpModule(&receive_module); |
| 922 | packet_router.RemoveSendRtpModule(&send_module); |
| 923 | } |
| 924 | |
| 925 | TEST(PacketRouterRembTest, ReceiveModuleTakesOverWhenLastSendModuleRemoved) { |
| 926 | rtc::ScopedFakeClock clock; |
| 927 | PacketRouter packet_router; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 928 | NiceMock<MockRtpRtcp> send_module; |
| 929 | NiceMock<MockRtpRtcp> receive_module; |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 930 | |
| 931 | constexpr bool remb_candidate = true; |
| 932 | |
| 933 | // Send module active, receive module inactive. |
| 934 | packet_router.AddSendRtpModule(&send_module, remb_candidate); |
| 935 | packet_router.AddReceiveRtpModule(&receive_module, remb_candidate); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 936 | |
| 937 | // Send module removed - receive module becomes active. |
| 938 | packet_router.RemoveSendRtpModule(&send_module); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 939 | constexpr uint32_t bitrate_estimate = 456; |
| 940 | const std::vector<uint32_t> ssrcs = {1234}; |
Danil Chapovalov | 51e21aa | 2017-10-10 17:46:26 +0200 | [diff] [blame] | 941 | EXPECT_CALL(send_module, SetRemb(_, _)).Times(0); |
| 942 | EXPECT_CALL(receive_module, SetRemb(bitrate_estimate, ssrcs)).Times(1); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 943 | |
Sebastian Jansson | 5f83cf0 | 2018-05-08 14:52:22 +0200 | [diff] [blame] | 944 | clock.AdvanceTime(TimeDelta::ms(1000)); |
eladalon | 822ff2b | 2017-08-01 06:30:28 -0700 | [diff] [blame] | 945 | packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate); |
| 946 | |
| 947 | // Test tear-down |
| 948 | packet_router.RemoveReceiveRtpModule(&receive_module); |
| 949 | } |
| 950 | |
Erik Språng | f6468d2 | 2019-07-05 16:53:43 +0200 | [diff] [blame^] | 951 | TEST(PacketRouterTest, SendPacketWithoutTransportSequenceNumbers) { |
| 952 | PacketRouter packet_router; |
| 953 | NiceMock<MockRtpRtcp> rtp_1; |
| 954 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 955 | |
| 956 | const uint16_t kSsrc1 = 1234; |
| 957 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(true)); |
| 958 | ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1)); |
| 959 | |
| 960 | // Send a packet without TransportSequenceNumber extension registered, |
| 961 | // packets sent should not have the extension set. |
| 962 | RtpHeaderExtensionMap extension_manager; |
| 963 | auto packet = absl::make_unique<RtpPacketToSend>(&extension_manager); |
| 964 | packet->SetSsrc(kSsrc1); |
| 965 | EXPECT_CALL( |
| 966 | rtp_1, |
| 967 | TrySendPacket( |
| 968 | Property(&RtpPacketToSend::HasExtension<TransportSequenceNumber>, |
| 969 | false), |
| 970 | _)) |
| 971 | .WillOnce(Return(true)); |
| 972 | packet_router.SendPacket(std::move(packet), PacedPacketInfo()); |
| 973 | |
| 974 | packet_router.RemoveSendRtpModule(&rtp_1); |
| 975 | } |
| 976 | |
| 977 | TEST(PacketRouterTest, SendPacketAssignsTransportSequenceNumbers) { |
| 978 | PacketRouter packet_router; |
| 979 | NiceMock<MockRtpRtcp> rtp_1; |
| 980 | NiceMock<MockRtpRtcp> rtp_2; |
| 981 | |
| 982 | packet_router.AddSendRtpModule(&rtp_1, false); |
| 983 | packet_router.AddSendRtpModule(&rtp_2, false); |
| 984 | |
| 985 | const uint16_t kSsrc1 = 1234; |
| 986 | const uint16_t kSsrc2 = 2345; |
| 987 | |
| 988 | ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(true)); |
| 989 | ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1)); |
| 990 | ON_CALL(rtp_2, SendingMedia).WillByDefault(Return(true)); |
| 991 | ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2)); |
| 992 | |
| 993 | RtpHeaderExtensionMap extension_manager; |
| 994 | const int kTransportSequenceNumberExtensionId = 1; |
| 995 | extension_manager.Register(kRtpExtensionTransportSequenceNumber, |
| 996 | kTransportSequenceNumberExtensionId); |
| 997 | |
| 998 | uint16_t transport_sequence_number = 0; |
| 999 | |
| 1000 | auto packet = absl::make_unique<RtpPacketToSend>(&extension_manager); |
| 1001 | EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>()); |
| 1002 | packet->SetSsrc(kSsrc1); |
| 1003 | EXPECT_CALL( |
| 1004 | rtp_1, |
| 1005 | TrySendPacket( |
| 1006 | Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>, |
| 1007 | transport_sequence_number), |
| 1008 | _)) |
| 1009 | .WillOnce(Return(true)); |
| 1010 | packet_router.SendPacket(std::move(packet), PacedPacketInfo()); |
| 1011 | |
| 1012 | ++transport_sequence_number; |
| 1013 | packet = absl::make_unique<RtpPacketToSend>(&extension_manager); |
| 1014 | EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>()); |
| 1015 | packet->SetSsrc(kSsrc2); |
| 1016 | |
| 1017 | // There will be a failed attempt to send on kSsrc1 before trying |
| 1018 | // the correct RTP module. |
| 1019 | EXPECT_CALL(rtp_1, TrySendPacket).WillOnce(Return(false)); |
| 1020 | EXPECT_CALL( |
| 1021 | rtp_2, |
| 1022 | TrySendPacket( |
| 1023 | Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>, |
| 1024 | transport_sequence_number), |
| 1025 | _)) |
| 1026 | .WillOnce(Return(true)); |
| 1027 | packet_router.SendPacket(std::move(packet), PacedPacketInfo()); |
| 1028 | |
| 1029 | packet_router.RemoveSendRtpModule(&rtp_1); |
| 1030 | packet_router.RemoveSendRtpModule(&rtp_2); |
| 1031 | } |
| 1032 | |
Stefan Holmer | e590416 | 2015-03-26 11:11:06 +0100 | [diff] [blame] | 1033 | } // namespace webrtc |