Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 1 | #!/usr/bin/env lucicfg |
| 2 | |
| 3 | # Copyright (c) 2019 The WebRTC project authors. All rights reserved. |
| 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
Christoffer Jansson | a814c56 | 2021-09-09 13:44:54 +0200 | [diff] [blame] | 7 | # https://chromium.googlesource.com/infra/luci/luci-go/+/main/lucicfg/doc/ |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 8 | |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 9 | """LUCI project configuration for WebRTC CQ and CI.""" |
| 10 | |
Vadim Shtayura | c3b2756 | 2021-10-25 17:05:37 -0700 | [diff] [blame] | 11 | lucicfg.check_version("1.29.1") |
Mirko Bonadei | 9189d9c | 2020-06-09 21:54:18 +0200 | [diff] [blame] | 12 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 13 | WEBRTC_GIT = "https://webrtc.googlesource.com/src" |
| 14 | WEBRTC_GERRIT = "https://webrtc-review.googlesource.com/src" |
Mirko Bonadei | f4b78bf | 2021-04-29 11:23:41 +0200 | [diff] [blame] | 15 | WEBRTC_TROOPER_EMAIL = "webrtc-troopers-robots@google.com" |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 16 | |
Mirko Bonadei | 32ca486 | 2020-03-11 10:39:45 +0100 | [diff] [blame] | 17 | GOMA_BACKEND_WEBRTC_RBE_PROD = { |
Mirko Bonadei | 1e90534 | 2020-03-04 09:39:42 +0100 | [diff] [blame] | 18 | "$build/goma": { |
| 19 | "server_host": "goma.chromium.org", |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 20 | "use_luci_auth": True, |
| 21 | }, |
Mirko Bonadei | 1e90534 | 2020-03-04 09:39:42 +0100 | [diff] [blame] | 22 | } |
| 23 | |
Mirko Bonadei | 84360ca | 2020-03-12 08:35:48 +0100 | [diff] [blame] | 24 | GOMA_BACKEND_WEBRTC_IOS_RBE_PROD = { |
| 25 | "$build/goma": { |
| 26 | "server_host": "goma.chromium.org", |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 27 | "use_luci_auth": True, |
Mirko Bonadei | 84360ca | 2020-03-12 08:35:48 +0100 | [diff] [blame] | 28 | }, |
Artem Titov | 1d47d31 | 2020-11-03 14:45:52 +0100 | [diff] [blame] | 29 | "$depot_tools/osx_sdk": {"sdk_version": "12a7209"}, |
Mirko Bonadei | 84360ca | 2020-03-12 08:35:48 +0100 | [diff] [blame] | 30 | } |
| 31 | |
Patrik Höglund | 3916a97 | 2019-12-04 13:19:38 +0100 | [diff] [blame] | 32 | GOMA_BACKEND_RBE_ATS_PROD = { |
| 33 | "$build/goma": { |
| 34 | "server_host": "goma.chromium.org", |
Mirko Bonadei | 2688eca | 2020-03-25 09:15:54 +0100 | [diff] [blame] | 35 | "use_luci_auth": True, |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 36 | "enable_ats": True, |
| 37 | }, |
Patrik Höglund | 3916a97 | 2019-12-04 13:19:38 +0100 | [diff] [blame] | 38 | } |
| 39 | |
Mirko Bonadei | 5aafd47 | 2021-04-21 10:42:00 +0200 | [diff] [blame] | 40 | # Disable ATS on CQ/try. |
| 41 | GOMA_BACKEND_RBE_NO_ATS_PROD = { |
| 42 | "$build/goma": { |
| 43 | "server_host": "goma.chromium.org", |
| 44 | "use_luci_auth": True, |
| 45 | "enable_ats": False, |
| 46 | }, |
| 47 | } |
| 48 | |
Artem Titov | 70d45af | 2021-10-11 13:25:18 +0200 | [diff] [blame] | 49 | # Add names of builders to remove from LKGR finder to this list. This is |
| 50 | # useful when a failure can be safely ignored while fixing it without |
| 51 | # blocking the LKGR finder on it. |
| 52 | skipped_lkgr_bots = [ |
Artem Titov | 70d45af | 2021-10-11 13:25:18 +0200 | [diff] [blame] | 53 | ] |
| 54 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 55 | # Top-level configs: |
| 56 | |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 57 | # Enable LUCI Realms support. |
| 58 | lucicfg.enable_experiment("crbug.com/1085650") |
| 59 | |
Andrii Shyshkalov | 32515d4 | 2021-04-29 14:39:42 +0200 | [diff] [blame] | 60 | # Launch all builds in "realms-aware mode", crbug.com/1177975. |
| 61 | luci.builder.defaults.experiments.set({"luci.use_realms": 100}) |
Andrii Shyshkalov | 20b2187 | 2021-04-28 15:10:53 +0200 | [diff] [blame] | 62 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 63 | lucicfg.config( |
| 64 | config_dir = ".", |
| 65 | tracked_files = [ |
| 66 | "commit-queue.cfg", |
| 67 | "cr-buildbucket.cfg", |
| 68 | "luci-logdog.cfg", |
| 69 | "luci-milo.cfg", |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 70 | "luci-notify.cfg", |
Oleh Prypin | 705b6a6 | 2019-04-03 23:10:51 +0200 | [diff] [blame] | 71 | "luci-notify/**/*", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 72 | "luci-scheduler.cfg", |
| 73 | "project.cfg", |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 74 | "realms.cfg", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 75 | ], |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 76 | lint_checks = ["default"], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 77 | ) |
| 78 | |
| 79 | luci.project( |
| 80 | name = "webrtc", |
| 81 | buildbucket = "cr-buildbucket.appspot.com", |
| 82 | logdog = "luci-logdog.appspot.com", |
| 83 | milo = "luci-milo.appspot.com", |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 84 | notify = "luci-notify.appspot.com", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 85 | scheduler = "luci-scheduler.appspot.com", |
| 86 | swarming = "chromium-swarm.appspot.com", |
| 87 | acls = [ |
| 88 | acl.entry( |
| 89 | [acl.BUILDBUCKET_READER, acl.LOGDOG_READER, acl.PROJECT_CONFIGS_READER, acl.SCHEDULER_READER], |
| 90 | groups = ["all"], |
| 91 | ), |
| 92 | acl.entry(acl.LOGDOG_WRITER, groups = ["luci-logdog-chromium-writers"]), |
| 93 | acl.entry(acl.SCHEDULER_OWNER, groups = ["project-webrtc-admins"]), |
| 94 | ], |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 95 | bindings = [ |
| 96 | luci.binding( |
| 97 | roles = "role/swarming.poolOwner", |
| 98 | groups = "project-webrtc-admins", |
| 99 | ), |
| 100 | luci.binding( |
| 101 | roles = "role/swarming.poolViewer", |
| 102 | groups = "all", |
| 103 | ), |
Andrii Shyshkalov | 2961b64 | 2021-04-29 14:01:53 +0200 | [diff] [blame] | 104 | # Allow any WebRTC build to trigger a test ran under chromium-tester@ |
| 105 | # task service account. |
| 106 | luci.binding( |
| 107 | roles = "role/swarming.taskServiceAccount", |
| 108 | users = [ |
| 109 | "chromium-tester@chops-service-accounts.iam.gserviceaccount.com", |
| 110 | ], |
| 111 | ), |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 112 | ], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 113 | ) |
| 114 | |
| 115 | luci.logdog( |
| 116 | gs_bucket = "chromium-luci-logdog", |
| 117 | ) |
| 118 | |
| 119 | luci.milo( |
| 120 | logo = "https://storage.googleapis.com/chrome-infra/webrtc-logo-vert-retro-255x305.png", |
| 121 | ) |
| 122 | |
Owen Rodley | a55c38e | 2020-06-15 11:16:10 +1000 | [diff] [blame] | 123 | luci.notify(tree_closing_enabled = True) |
| 124 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 125 | luci.cq( |
| 126 | status_host = "chromium-cq-status.appspot.com", |
| 127 | submit_max_burst = 1, |
| 128 | submit_burst_delay = 1 * time.minute, |
| 129 | ) |
| 130 | |
| 131 | luci.gitiles_poller( |
Christoffer Jansson | fa64689 | 2021-06-28 17:34:20 +0200 | [diff] [blame] | 132 | name = "webrtc-gitiles-trigger-main", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 133 | bucket = "ci", |
| 134 | repo = WEBRTC_GIT, |
Christoffer Jansson | fa64689 | 2021-06-28 17:34:20 +0200 | [diff] [blame] | 135 | refs = ["refs/heads/main"], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 136 | ) |
| 137 | |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 138 | # Swarming permissions: |
| 139 | |
Andrii Shyshkalov | c26aaad | 2021-04-27 16:47:26 +0200 | [diff] [blame] | 140 | luci.realm(name = "pools/cron", bindings = [ |
| 141 | # Unlike WebRTC's own builders, other projects need an explicit grant to use this pool. |
| 142 | luci.binding( |
| 143 | roles = "role/swarming.poolUser", |
| 144 | projects = "libyuv", |
| 145 | ), |
| 146 | ]) |
| 147 | |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 148 | luci.realm(name = "pools/ci") |
Andrii Shyshkalov | c26aaad | 2021-04-27 16:47:26 +0200 | [diff] [blame] | 149 | luci.realm(name = "pools/ci-tests", bindings = [ |
| 150 | # Allow task service accounts of .ci pool/bucket to trigger tasks here. |
| 151 | luci.binding( |
| 152 | roles = "role/swarming.poolUser", |
| 153 | groups = "project-webrtc-ci-task-accounts", |
| 154 | ), |
| 155 | # Allow tasks here to use .ci task service accounts. |
| 156 | luci.binding( |
| 157 | roles = "role/swarming.taskServiceAccount", |
| 158 | groups = "project-webrtc-ci-task-accounts", |
| 159 | ), |
| 160 | ]) |
| 161 | |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 162 | luci.realm(name = "pools/try") |
Andrii Shyshkalov | c26aaad | 2021-04-27 16:47:26 +0200 | [diff] [blame] | 163 | luci.realm(name = "pools/try-tests", bindings = [ |
| 164 | # Allow task service accounts of .try pool/bucket to trigger tasks here. |
| 165 | luci.binding( |
| 166 | roles = "role/swarming.poolUser", |
| 167 | groups = "project-webrtc-try-task-accounts", |
| 168 | ), |
| 169 | # Allow tasks here to use .try task service accounts. |
| 170 | luci.binding( |
| 171 | roles = "role/swarming.taskServiceAccount", |
| 172 | groups = "project-webrtc-try-task-accounts", |
| 173 | ), |
| 174 | ]) |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 175 | |
Mirko Bonadei | 4cf0fc7 | 2021-08-31 17:38:10 +0200 | [diff] [blame] | 176 | # Allow to use LED & Swarming "Debug" feature to a larger group but only on perf bots / builders. |
| 177 | luci.realm(name = "pools/perf", bindings = [ |
| 178 | luci.binding( |
| 179 | roles = "role/swarming.poolUser", |
| 180 | groups = "project-webrtc-led-users", |
| 181 | ), |
| 182 | ]) |
| 183 | luci.binding( |
| 184 | realm = "perf", |
| 185 | roles = "role/swarming.taskTriggerer", |
| 186 | groups = "project-webrtc-led-users", |
| 187 | ) |
| 188 | |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 189 | # Allow admins to use LED & Swarming "Debug" feature on all WebRTC bots. |
| 190 | luci.binding( |
| 191 | realm = "@root", |
| 192 | roles = "role/swarming.poolUser", |
| 193 | groups = "project-webrtc-admins", |
| 194 | ) |
| 195 | luci.binding( |
| 196 | realm = "@root", |
| 197 | roles = "role/swarming.taskTriggerer", |
| 198 | groups = "project-webrtc-admins", |
| 199 | ) |
| 200 | |
Mirko Bonadei | 4cf0fc7 | 2021-08-31 17:38:10 +0200 | [diff] [blame] | 201 | # Allow to use LED & Swarming "Debug" feature to a larger group but only on try bots / builders. |
Andrii Shyshkalov | 0efa6da | 2021-04-26 20:40:33 +0200 | [diff] [blame] | 202 | luci.binding( |
| 203 | realm = "pools/try", |
| 204 | roles = "role/swarming.poolUser", |
| 205 | groups = "project-webrtc-led-users", |
| 206 | ) |
| 207 | luci.binding( |
| 208 | realm = "try", |
| 209 | roles = "role/swarming.taskTriggerer", |
| 210 | groups = "project-webrtc-led-users", |
| 211 | ) |
| 212 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 213 | # Bucket definitions: |
| 214 | |
| 215 | luci.bucket( |
| 216 | name = "try", |
| 217 | acls = [ |
| 218 | acl.entry(acl.BUILDBUCKET_TRIGGERER, groups = [ |
| 219 | "service-account-cq", |
| 220 | "project-webrtc-tryjob-access", |
| 221 | ]), |
| 222 | ], |
| 223 | ) |
| 224 | |
| 225 | luci.bucket( |
| 226 | name = "ci", |
| 227 | acls = [ |
Oleh Prypin | f35939d | 2019-05-03 20:42:38 +0200 | [diff] [blame] | 228 | acl.entry(acl.BUILDBUCKET_TRIGGERER, groups = [ |
| 229 | "project-webrtc-ci-schedulers", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 230 | ]), |
Jeremy Leconte | 2e25bb5 | 2020-07-16 09:38:56 +0200 | [diff] [blame] | 231 | acl.entry(acl.BUILDBUCKET_TRIGGERER, groups = [ |
| 232 | # Allow Pinpoint to trigger builds for bisection |
| 233 | "service-account-chromeperf", |
| 234 | ]), |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 235 | ], |
| 236 | ) |
| 237 | |
| 238 | luci.bucket( |
| 239 | name = "perf", |
| 240 | acls = [ |
| 241 | acl.entry(acl.BUILDBUCKET_TRIGGERER, users = [ |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 242 | "webrtc-ci-builder@chops-service-accounts.iam.gserviceaccount.com", |
| 243 | ]), |
| 244 | ], |
| 245 | ) |
| 246 | |
| 247 | luci.bucket( |
| 248 | name = "cron", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 249 | ) |
| 250 | |
| 251 | # Commit queue definitions: |
| 252 | |
| 253 | luci.cq_group( |
| 254 | name = "cq", |
| 255 | tree_status_host = "webrtc-status.appspot.com", |
Christoffer Jansson | 1746b25 | 2021-05-31 16:03:55 +0200 | [diff] [blame] | 256 | watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/heads/master", "refs/heads/main"])], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 257 | acls = [ |
| 258 | acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), |
| 259 | acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), |
| 260 | ], |
| 261 | retry_config = cq.RETRY_ALL_FAILURES, |
Oleh Prypin | 5416f2d | 2019-08-02 09:43:15 +0200 | [diff] [blame] | 262 | cancel_stale_tryjobs = True, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 263 | ) |
| 264 | |
| 265 | luci.cq_group( |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 266 | name = "cq_branch", |
| 267 | watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/branch-heads/.+"])], |
| 268 | acls = [ |
| 269 | acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-committers"]), |
| 270 | acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), |
| 271 | ], |
| 272 | retry_config = cq.RETRY_ALL_FAILURES, |
Oleh Prypin | 5416f2d | 2019-08-02 09:43:15 +0200 | [diff] [blame] | 273 | cancel_stale_tryjobs = True, |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 274 | ) |
| 275 | |
| 276 | luci.cq_group( |
| 277 | name = "cq_infra", |
| 278 | watch = [cq.refset(repo = WEBRTC_GERRIT, refs = ["refs/heads/infra/config"])], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 279 | acls = [ |
| 280 | acl.entry(acl.CQ_COMMITTER, groups = ["project-webrtc-admins"]), |
| 281 | acl.entry(acl.CQ_DRY_RUNNER, groups = ["project-webrtc-tryjob-access"]), |
| 282 | ], |
| 283 | retry_config = cq.RETRY_ALL_FAILURES, |
Oleh Prypin | 5416f2d | 2019-08-02 09:43:15 +0200 | [diff] [blame] | 284 | cancel_stale_tryjobs = True, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 285 | ) |
| 286 | |
| 287 | luci.cq_tryjob_verifier( |
| 288 | builder = "presubmit", |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 289 | cq_group = "cq_infra", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 290 | ) |
| 291 | |
Oleh Prypin | e56cd9b | 2019-05-29 21:14:31 +0200 | [diff] [blame] | 292 | luci.cq_tryjob_verifier( |
| 293 | builder = "webrtc-internal:g3.webrtc-internal.try/internal_compile_lite", |
| 294 | owner_whitelist = ["project-webrtc-internal-tryjob-access"], |
| 295 | cq_group = "cq", |
| 296 | ) |
| 297 | |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 298 | # Notifier definitions: |
| 299 | |
| 300 | luci.notifier( |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 301 | name = "post_submit_failure_notifier", |
| 302 | on_new_status = ["FAILURE"], |
Mirko Bonadei | f4b78bf | 2021-04-29 11:23:41 +0200 | [diff] [blame] | 303 | notify_emails = [WEBRTC_TROOPER_EMAIL], |
Christoffer Jansson | 1663501 | 2021-10-25 16:32:38 +0200 | [diff] [blame] | 304 | notify_blamelist = True, |
Oleh Prypin | 705b6a6 | 2019-04-03 23:10:51 +0200 | [diff] [blame] | 305 | template = luci.notifier_template( |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 306 | name = "build_failure", |
| 307 | body = io.read_file("luci-notify/email-templates/build_failure.template"), |
Oleh Prypin | 705b6a6 | 2019-04-03 23:10:51 +0200 | [diff] [blame] | 308 | ), |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 309 | ) |
| 310 | |
| 311 | luci.notifier( |
| 312 | name = "cron_notifier", |
Jeremy Leconte | 67a904e | 2020-07-08 11:48:18 +0200 | [diff] [blame] | 313 | on_new_status = ["FAILURE", "INFRA_FAILURE"], |
Mirko Bonadei | f4b78bf | 2021-04-29 11:23:41 +0200 | [diff] [blame] | 314 | notify_emails = [WEBRTC_TROOPER_EMAIL], |
Oleh Prypin | 705b6a6 | 2019-04-03 23:10:51 +0200 | [diff] [blame] | 315 | template = luci.notifier_template( |
| 316 | name = "cron", |
| 317 | body = io.read_file("luci-notify/email-templates/cron.template"), |
| 318 | ), |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 319 | ) |
| 320 | |
Jeremy Leconte | 67a904e | 2020-07-08 11:48:18 +0200 | [diff] [blame] | 321 | luci.notifier( |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 322 | name = "infra_failure_notifier", |
Jeremy Leconte | 67a904e | 2020-07-08 11:48:18 +0200 | [diff] [blame] | 323 | on_new_status = ["INFRA_FAILURE"], |
Mirko Bonadei | f4b78bf | 2021-04-29 11:23:41 +0200 | [diff] [blame] | 324 | notify_emails = [WEBRTC_TROOPER_EMAIL], |
Jeremy Leconte | 67a904e | 2020-07-08 11:48:18 +0200 | [diff] [blame] | 325 | template = luci.notifier_template( |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 326 | name = "infra_failure", |
| 327 | body = io.read_file("luci-notify/email-templates/infra_failure.template"), |
Jeremy Leconte | 67a904e | 2020-07-08 11:48:18 +0200 | [diff] [blame] | 328 | ), |
| 329 | ) |
| 330 | |
Owen Rodley | 6b721ba | 2020-05-26 10:04:20 +1000 | [diff] [blame] | 331 | # Tree closer definitions: |
| 332 | |
| 333 | luci.tree_closer( |
| 334 | name = "webrtc_tree_closer", |
| 335 | tree_status_host = "webrtc-status.appspot.com", |
Owen Rodley | 6b721ba | 2020-05-26 10:04:20 +1000 | [diff] [blame] | 336 | # TODO: These step filters are copied verbatim from Gatekeeper, for testing |
| 337 | # that LUCI-Notify would take the exact same actions. Once we've switched |
| 338 | # over, this should be updated - several of these steps don't exist in |
| 339 | # WebRTC recipes. |
| 340 | failed_step_regexp = [ |
| 341 | "bot_update", |
| 342 | "compile", |
| 343 | "gclient runhooks", |
| 344 | "runhooks", |
| 345 | "update", |
| 346 | "extract build", |
| 347 | "cleanup_temp", |
| 348 | "taskkill", |
| 349 | "compile", |
| 350 | "gn", |
| 351 | ], |
| 352 | failed_step_regexp_exclude = ".*\\(experimental\\).*", |
| 353 | ) |
| 354 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 355 | # Recipe definitions: |
| 356 | |
| 357 | def recipe(recipe, pkg = "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"): |
| 358 | return luci.recipe( |
| 359 | name = recipe.split("/")[-1], |
| 360 | cipd_package = pkg, |
Christoffer Jansson | a814c56 | 2021-09-09 13:44:54 +0200 | [diff] [blame] | 361 | cipd_version = "refs/heads/main", |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 362 | recipe = recipe, |
| 363 | ) |
| 364 | |
| 365 | recipe("chromium_trybot") |
| 366 | recipe("run_presubmit") |
| 367 | recipe("webrtc/auto_roll_webrtc_deps") |
| 368 | recipe("webrtc/ios") |
| 369 | recipe("webrtc/ios_api_framework") |
| 370 | recipe("webrtc/libfuzzer") |
| 371 | recipe("webrtc/more_configs") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 372 | recipe("webrtc/standalone") |
Mirko Bonadei | 54bbd1c | 2020-12-14 15:54:46 +0100 | [diff] [blame] | 373 | recipe("webrtc/update_webrtc_binary_version") |
Jeff Yoon | f421c68 | 2020-12-17 00:16:22 -0800 | [diff] [blame] | 374 | recipe("lkgr_finder", pkg = "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 375 | |
| 376 | # Console definitions: |
| 377 | |
Josip Sokcevic | 5a906ed | 2021-06-28 08:55:46 -0700 | [diff] [blame] | 378 | luci.console_view(name = "ci", title = "Main", repo = WEBRTC_GIT, header = "console-header.textpb", refs = ["refs/heads/master", "refs/heads/main"]) |
| 379 | luci.console_view(name = "perf", title = "Perf", repo = WEBRTC_GIT, header = "console-header.textpb", refs = ["refs/heads/master", "refs/heads/main"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 380 | luci.list_view(name = "cron", title = "Cron") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 381 | luci.list_view(name = "try", title = "Tryserver") |
| 382 | |
| 383 | def add_milo(builder, views): |
| 384 | """Add Milo console entries for the builder. |
| 385 | |
| 386 | Args: |
| 387 | builder: builder name (str). |
| 388 | views: dict where keys are names of consoles and values are either a |
| 389 | category for the console (str, pipe-separated) or True, which means |
| 390 | adding to a list view rather than a console. |
| 391 | """ |
| 392 | for view_name, category in views.items(): |
| 393 | if category == None: |
| 394 | continue |
| 395 | elif type(category) == "string": |
| 396 | category, _, short_name = category.rpartition("|") |
| 397 | luci.console_view_entry( |
| 398 | console_view = view_name, |
| 399 | builder = builder, |
| 400 | category = category or None, |
| 401 | short_name = short_name or None, |
| 402 | ) |
| 403 | elif category == True: |
| 404 | luci.list_view_entry( |
| 405 | list_view = view_name, |
| 406 | builder = builder, |
| 407 | ) |
| 408 | else: |
| 409 | fail("Unexpected value for category: %r" % category) |
| 410 | |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 411 | lkgr_builders = {} |
| 412 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 413 | # Builder-defining functions: |
| 414 | |
Artem Titarenko | f6588b7 | 2019-11-14 14:28:11 +0100 | [diff] [blame] | 415 | def webrtc_builder( |
| 416 | name, |
| 417 | recipe = "standalone", |
| 418 | dimensions = {}, |
Mirko Bonadei | 825f9c2 | 2020-07-01 11:52:39 +0200 | [diff] [blame] | 419 | properties = {}, |
Artem Titarenko | f6588b7 | 2019-11-14 14:28:11 +0100 | [diff] [blame] | 420 | priority = 30, |
| 421 | execution_timeout = 2 * time.hour, |
Mirko Bonadei | b7ef460 | 2020-07-01 13:28:26 +0200 | [diff] [blame] | 422 | goma_jobs = None, |
Artem Titarenko | f6588b7 | 2019-11-14 14:28:11 +0100 | [diff] [blame] | 423 | **kwargs): |
Mirko Bonadei | b7ef460 | 2020-07-01 13:28:26 +0200 | [diff] [blame] | 424 | """WebRTC specific wrapper around luci.builder. |
| 425 | |
| 426 | Args: |
| 427 | name: builder name (str). |
| 428 | recipe: string with the name of the recipe to run. |
| 429 | dimensions: dict of Swarming dimensions (strings) to search machines by. |
| 430 | properties: dict of properties to pass to the recipe (on top of the default ones). |
| 431 | priority: int [1-255] or None, indicating swarming task priority, lower is |
| 432 | more important. If None, defer the decision to Buildbucket service. |
| 433 | execution_timeout: int or None, how long to wait for a running build to finish before |
| 434 | forcefully aborting it and marking the build as timed out. If None, |
| 435 | defer the decision to Buildbucket service. |
| 436 | goma_jobs: int or None, number of jobs to be used by the builder. If None, defer the |
| 437 | decition to the goma module. |
| 438 | **kwargs: Pass on to webrtc_builder / luci.builder. |
| 439 | Returns: |
| 440 | A luci.builder. |
| 441 | """ |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 442 | dimensions = merge_dicts({"cpu": "x86-64"}, dimensions) |
| 443 | |
Mirko Bonadei | b7ef460 | 2020-07-01 13:28:26 +0200 | [diff] [blame] | 444 | if goma_jobs != None: |
| 445 | goma_additional_params = {"$build/goma": {"jobs": goma_jobs}} |
| 446 | properties = merge_dicts(properties, goma_additional_params) |
Ye Kuang | 8df2049 | 2020-10-15 14:54:17 +0900 | [diff] [blame] | 447 | properties = merge_dicts(properties, { |
| 448 | "$recipe_engine/isolated": { |
| 449 | "server": "https://isolateserver.appspot.com", |
| 450 | }, |
| 451 | }) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 452 | return luci.builder( |
| 453 | name = name, |
Oleh Prypin | 705b6a6 | 2019-04-03 23:10:51 +0200 | [diff] [blame] | 454 | executable = recipe, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 455 | dimensions = {k: v for k, v in dimensions.items() if v != None}, |
Mirko Bonadei | b7ef460 | 2020-07-01 13:28:26 +0200 | [diff] [blame] | 456 | properties = properties, |
Artem Titarenko | f6588b7 | 2019-11-14 14:28:11 +0100 | [diff] [blame] | 457 | execution_timeout = execution_timeout, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 458 | priority = priority, |
| 459 | build_numbers = True, |
| 460 | swarming_tags = ["vpython:native-python-wrapper"], |
Jeremy Leconte | f231211 | 2021-11-12 11:55:27 +0100 | [diff] [blame^] | 461 | resultdb_settings = resultdb.settings(enable = True), |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 462 | **kwargs |
| 463 | ) |
| 464 | |
| 465 | def ci_builder( |
| 466 | name, |
| 467 | ci_cat, |
| 468 | perf_cat = None, |
| 469 | fyi_cat = None, |
| 470 | properties = {}, |
| 471 | dimensions = {}, |
| 472 | prioritized = False, |
Oleh Prypin | f5432c5 | 2019-03-19 15:10:37 +0100 | [diff] [blame] | 473 | enabled = True, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 474 | **kwargs): |
Oleh Prypin | e567767 | 2019-04-25 12:21:35 +0200 | [diff] [blame] | 475 | """Add a post-submit builder. |
| 476 | |
| 477 | Args: |
| 478 | name: builder name (str). |
| 479 | ci_cat: the category + name for the /ci/ console, or None to omit from the console. |
| 480 | perf_cat: the category + name for the /perf/ console, or None to omit from the console. |
| 481 | fyi_cat: the category + name for the /fyi/ console, or None to omit from the console. |
| 482 | properties: dict of properties to pass to the recipe (on top of the default ones). |
| 483 | dimensions: dict of Swarming dimensions (strings) to search machines by. |
| 484 | prioritized: True to make this builder have a higher priority and never batch builds. |
| 485 | enabled: False to exclude this builder from consoles and failure notifications. |
| 486 | **kwargs: Pass on to webrtc_builder / luci.builder. |
| 487 | Returns: |
| 488 | A luci.builder. |
| 489 | |
| 490 | Notifications are also disabled if a builder is not on either of /ci/ or /perf/ consoles. |
| 491 | """ |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 492 | if prioritized: |
| 493 | kwargs["triggering_policy"] = scheduler.greedy_batching( |
| 494 | max_batch_size = 1, |
| 495 | max_concurrent_invocations = 3, |
| 496 | ) |
| 497 | kwargs["priority"] = 29 |
| 498 | |
Oleh Prypin | f5432c5 | 2019-03-19 15:10:37 +0100 | [diff] [blame] | 499 | if enabled: |
| 500 | add_milo(name, {"ci": ci_cat, "perf": perf_cat, "fyi": fyi_cat}) |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 501 | if ci_cat: |
| 502 | lkgr_builders[name] = True |
Artem Titov | 70d45af | 2021-10-11 13:25:18 +0200 | [diff] [blame] | 503 | notifies = ["post_submit_failure_notifier", "infra_failure_notifier"] if enabled and (ci_cat or perf_cat) else None |
| 504 | if notifies and name not in skipped_lkgr_bots: |
| 505 | notifies.append("webrtc_tree_closer") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 506 | return webrtc_builder( |
| 507 | name = name, |
Garrett Beaty | 4a106ce | 2020-09-09 14:51:23 -0700 | [diff] [blame] | 508 | properties = merge_dicts({"builder_group": "client.webrtc"}, properties), |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 509 | dimensions = merge_dicts({"pool": "luci.webrtc.ci"}, dimensions), |
| 510 | bucket = "ci", |
| 511 | service_account = "webrtc-ci-builder@chops-service-accounts.iam.gserviceaccount.com", |
Christoffer Jansson | fa64689 | 2021-06-28 17:34:20 +0200 | [diff] [blame] | 512 | triggered_by = ["webrtc-gitiles-trigger-main"] if enabled else None, |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 513 | repo = WEBRTC_GIT, |
Artem Titov | 70d45af | 2021-10-11 13:25:18 +0200 | [diff] [blame] | 514 | notifies = notifies, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 515 | **kwargs |
| 516 | ) |
| 517 | |
| 518 | def try_builder( |
| 519 | name, |
| 520 | try_cat = True, |
| 521 | fyi_cat = None, |
| 522 | properties = {}, |
| 523 | dimensions = {}, |
| 524 | cq = {}, |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 525 | branch_cq = True, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 526 | **kwargs): |
Oleh Prypin | e567767 | 2019-04-25 12:21:35 +0200 | [diff] [blame] | 527 | """Add a pre-submit builder. |
| 528 | |
| 529 | Args: |
| 530 | name: builder name (str). |
| 531 | try_cat: boolean, whether to include this builder in the /try/ console. See also: `add_milo`. |
| 532 | fyi_cat: the category + name for the /fyi/ console, or None to omit from the console. |
| 533 | properties: dict of properties to pass to the recipe (on top of the default ones). |
| 534 | dimensions: dict of Swarming dimensions (strings) to search machines by. |
| 535 | cq: None to exclude this from all commit queues, or a dict of kwargs for cq_tryjob_verifier. |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 536 | branch_cq: False to exclude this builder just from the release-branch CQ. |
Oleh Prypin | e567767 | 2019-04-25 12:21:35 +0200 | [diff] [blame] | 537 | **kwargs: Pass on to webrtc_builder / luci.builder. |
| 538 | Returns: |
| 539 | A luci.builder. |
| 540 | """ |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 541 | add_milo(name, {"try": try_cat, "fyi": fyi_cat}) |
| 542 | if cq != None: |
| 543 | luci.cq_tryjob_verifier( |
| 544 | builder = name, |
| 545 | cq_group = "cq", |
| 546 | **cq |
| 547 | ) |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 548 | if branch_cq: |
| 549 | luci.cq_tryjob_verifier( |
| 550 | builder = name, |
| 551 | cq_group = "cq_branch", |
| 552 | **cq |
| 553 | ) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 554 | |
| 555 | return webrtc_builder( |
| 556 | name = name, |
Garrett Beaty | 4a106ce | 2020-09-09 14:51:23 -0700 | [diff] [blame] | 557 | properties = merge_dicts({"builder_group": "tryserver.webrtc"}, properties), |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 558 | dimensions = merge_dicts({"pool": "luci.webrtc.try"}, dimensions), |
| 559 | bucket = "try", |
| 560 | service_account = "webrtc-try-builder@chops-service-accounts.iam.gserviceaccount.com", |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 561 | notifies = ["infra_failure_notifier"], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 562 | **kwargs |
| 563 | ) |
| 564 | |
| 565 | def perf_builder( |
| 566 | name, |
| 567 | perf_cat, |
| 568 | recipe = "standalone", |
| 569 | properties = {}, |
| 570 | dimensions = {}, |
| 571 | **kwargs): |
| 572 | add_milo(name, {"perf": perf_cat}) |
| 573 | return webrtc_builder( |
| 574 | name = name, |
| 575 | recipe = recipe, |
Garrett Beaty | 4a106ce | 2020-09-09 14:51:23 -0700 | [diff] [blame] | 576 | properties = merge_dicts({"builder_group": "client.webrtc.perf"}, properties), |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 577 | dimensions = merge_dicts({"pool": "luci.webrtc.perf", "os": "Linux", "cpu": None}, dimensions), |
| 578 | bucket = "perf", |
| 579 | service_account = "webrtc-ci-builder@chops-service-accounts.iam.gserviceaccount.com", |
| 580 | # log_base of 1.7 means: |
| 581 | # when there are P pending builds, LUCI will batch the first B builds. |
| 582 | # P: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 ... |
| 583 | # B: 1 1 2 2 3 3 3 3 4 4 4 4 4 4 5 ... |
Jeremy Leconte | ea2016b | 2020-07-01 09:47:22 +0200 | [diff] [blame] | 584 | triggering_policy = scheduler.logarithmic_batching(log_base = 1.7), |
Christoffer Jansson | 1663501 | 2021-10-25 16:32:38 +0200 | [diff] [blame] | 585 | repo = WEBRTC_GIT, |
Artem Titarenko | f6588b7 | 2019-11-14 14:28:11 +0100 | [diff] [blame] | 586 | execution_timeout = 3 * time.hour, |
Mirko Bonadei | 875a27a | 2020-07-11 15:04:58 +0200 | [diff] [blame] | 587 | notifies = ["post_submit_failure_notifier", "infra_failure_notifier"], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 588 | **kwargs |
| 589 | ) |
| 590 | |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 591 | def android_perf_builder( |
| 592 | name, |
| 593 | perf_cat, |
| 594 | recipe = "standalone", |
| 595 | properties = {}, |
| 596 | dimensions = {}, |
| 597 | **kwargs): |
| 598 | return perf_builder( |
| 599 | name = name, |
| 600 | perf_cat = perf_cat, |
| 601 | recipe = recipe, |
| 602 | properties = merge_dicts(GOMA_BACKEND_WEBRTC_RBE_PROD, properties), |
| 603 | dimensions = dimensions, |
| 604 | **kwargs |
| 605 | ) |
| 606 | |
| 607 | def linux_perf_builder( |
| 608 | name, |
| 609 | perf_cat, |
| 610 | recipe = "standalone", |
| 611 | properties = {}, |
| 612 | dimensions = {}, |
| 613 | **kwargs): |
| 614 | return perf_builder( |
| 615 | name = name, |
| 616 | perf_cat = perf_cat, |
| 617 | recipe = recipe, |
| 618 | properties = merge_dicts(GOMA_BACKEND_WEBRTC_RBE_PROD, properties), |
| 619 | dimensions = dimensions, |
| 620 | **kwargs |
| 621 | ) |
| 622 | |
| 623 | def mac_perf_builder( |
| 624 | name, |
| 625 | perf_cat, |
| 626 | recipe = "standalone", |
| 627 | properties = {}, |
| 628 | dimensions = {}, |
| 629 | **kwargs): |
| 630 | return perf_builder( |
| 631 | name = name, |
| 632 | perf_cat = perf_cat, |
| 633 | recipe = recipe, |
| 634 | properties = merge_dicts(GOMA_BACKEND_WEBRTC_RBE_PROD, properties), |
| 635 | dimensions = dimensions, |
| 636 | **kwargs |
| 637 | ) |
| 638 | |
| 639 | def win_perf_builder( |
| 640 | name, |
| 641 | perf_cat, |
| 642 | recipe = "standalone", |
| 643 | properties = {}, |
| 644 | dimensions = {}, |
| 645 | **kwargs): |
| 646 | return perf_builder( |
| 647 | name = name, |
| 648 | perf_cat = perf_cat, |
| 649 | recipe = recipe, |
| 650 | properties = merge_dicts(GOMA_BACKEND_RBE_ATS_PROD, properties), |
| 651 | dimensions = dimensions, |
| 652 | **kwargs |
| 653 | ) |
| 654 | |
Mirko Bonadei | 54bbd1c | 2020-12-14 15:54:46 +0100 | [diff] [blame] | 655 | def cron_builder(name, dimensions = {}, service_account = None, **kwargs): |
| 656 | if service_account == None: |
| 657 | service_account = "chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com" |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 658 | add_milo(name, {"cron": True}) |
| 659 | return webrtc_builder( |
| 660 | name = name, |
| 661 | dimensions = merge_dicts({"pool": "luci.webrtc.cron", "os": "Linux"}, dimensions), |
| 662 | bucket = "cron", |
Mirko Bonadei | 54bbd1c | 2020-12-14 15:54:46 +0100 | [diff] [blame] | 663 | service_account = service_account, |
Oleh Prypin | 71d1742 | 2019-03-28 08:43:16 +0100 | [diff] [blame] | 664 | notifies = ["cron_notifier"], |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 665 | **kwargs |
| 666 | ) |
| 667 | |
| 668 | # Helpers: |
| 669 | |
| 670 | def merge_dicts(a, b): |
| 671 | """Return the result of merging two dicts. |
| 672 | |
| 673 | If matching values are both dicts or both lists, they will be merged (non-recursively). |
| 674 | |
| 675 | Args: |
| 676 | a: first dict. |
| 677 | b: second dict (takes priority). |
| 678 | Returns: |
| 679 | Merged dict. |
| 680 | """ |
| 681 | a = dict(a) |
| 682 | for k, bv in b.items(): |
| 683 | av = a.get(k) |
| 684 | if type(av) == "dict" and type(bv) == "dict": |
| 685 | a[k] = dict(av) |
| 686 | a[k].update(bv) |
| 687 | elif type(av) == "list" and type(bv) == "list": |
| 688 | a[k] = av + bv |
| 689 | else: |
| 690 | a[k] = bv |
| 691 | return a |
| 692 | |
| 693 | def normal_builder_factory(**common_kwargs): |
| 694 | def builder(*args, **kwargs): |
| 695 | return ci_builder(*args, **merge_dicts(common_kwargs, kwargs)) |
| 696 | |
| 697 | def try_job(*args, **kwargs): |
| 698 | return try_builder(*args, **merge_dicts(common_kwargs, kwargs)) |
| 699 | |
| 700 | return builder, try_job |
| 701 | |
| 702 | # Mixins: |
| 703 | |
| 704 | linux_builder, linux_try_job = normal_builder_factory( |
| 705 | dimensions = {"os": "Linux", "inside_docker": "0"}, |
Mirko Bonadei | 32ca486 | 2020-03-11 10:39:45 +0100 | [diff] [blame] | 706 | properties = GOMA_BACKEND_WEBRTC_RBE_PROD, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 707 | ) |
| 708 | |
| 709 | android_builder, android_try_job = normal_builder_factory( |
| 710 | dimensions = {"os": "Linux"}, |
Mirko Bonadei | 32ca486 | 2020-03-11 10:39:45 +0100 | [diff] [blame] | 711 | properties = GOMA_BACKEND_WEBRTC_RBE_PROD, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 712 | ) |
| 713 | |
Mirko Bonadei | 5aafd47 | 2021-04-21 10:42:00 +0200 | [diff] [blame] | 714 | def win_builder(*args, **kwargs): |
| 715 | return ci_builder( |
| 716 | *args, |
| 717 | **merge_dicts({ |
| 718 | "dimensions": {"os": "Windows"}, |
| 719 | "properties": GOMA_BACKEND_RBE_ATS_PROD, |
| 720 | }, kwargs) |
| 721 | ) |
| 722 | |
| 723 | def win_try_job(*args, **kwargs): |
| 724 | return try_builder( |
| 725 | *args, |
| 726 | **merge_dicts({ |
| 727 | "dimensions": {"os": "Windows"}, |
| 728 | "properties": GOMA_BACKEND_RBE_NO_ATS_PROD, |
| 729 | }, kwargs) |
| 730 | ) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 731 | |
| 732 | mac_builder, mac_try_job = normal_builder_factory( |
| 733 | dimensions = {"os": "Mac"}, |
Mirko Bonadei | 32ca486 | 2020-03-11 10:39:45 +0100 | [diff] [blame] | 734 | properties = GOMA_BACKEND_WEBRTC_RBE_PROD, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 735 | ) |
| 736 | |
| 737 | ios_builder, ios_try_job = normal_builder_factory( |
Mirko Bonadei | 8096c23 | 2020-08-26 21:44:42 +0200 | [diff] [blame] | 738 | dimensions = {"os": "Mac-10.15"}, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 739 | recipe = "ios", |
Mirko Bonadei | 84360ca | 2020-03-12 08:35:48 +0100 | [diff] [blame] | 740 | properties = GOMA_BACKEND_WEBRTC_IOS_RBE_PROD, |
| 741 | caches = [swarming.cache("osx_sdk")], |
| 742 | ) |
| 743 | |
Mirko Bonadei | a7677a3 | 2021-10-05 08:31:36 +0200 | [diff] [blame] | 744 | ios_builder_macos11, ios_try_job_macos11 = normal_builder_factory( |
Mirko Bonadei | e680bce | 2021-10-03 12:05:13 +0200 | [diff] [blame] | 745 | dimensions = {"os": "Mac-11"}, |
Mirko Bonadei | 84360ca | 2020-03-12 08:35:48 +0100 | [diff] [blame] | 746 | recipe = "ios", |
Mirko Bonadei | a7677a3 | 2021-10-05 08:31:36 +0200 | [diff] [blame] | 747 | properties = GOMA_BACKEND_WEBRTC_IOS_RBE_PROD, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 748 | caches = [swarming.cache("osx_sdk")], |
| 749 | ) |
| 750 | |
| 751 | # Actual builder configuration: |
| 752 | |
| 753 | android_builder("Android32 (M Nexus5X)(dbg)", "Android|arm|dbg") |
| 754 | android_try_job("android_compile_arm_dbg", cq = None) |
| 755 | android_try_job("android_arm_dbg") |
| 756 | android_builder("Android32 (M Nexus5X)", "Android|arm|rel") |
Andrey Logvin | 849978d | 2021-09-14 10:20:19 +0000 | [diff] [blame] | 757 | android_try_job("android_arm_rel") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 758 | android_builder("Android32 Builder arm", "Android|arm|size", perf_cat = "Android|arm|Builder|", prioritized = True) |
| 759 | android_try_job("android_compile_arm_rel") |
Mirko Bonadei | 86b4f2d | 2020-07-08 14:24:48 +0200 | [diff] [blame] | 760 | android_perf_builder("Perf Android32 (M Nexus5)", "Android|arm|Tester|M Nexus5", triggered_by = ["Android32 Builder arm"]) |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 761 | android_perf_builder("Perf Android32 (M AOSP Nexus6)", "Android|arm|Tester|M AOSP Nexus6", triggered_by = ["Android32 Builder arm"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 762 | android_try_job("android_compile_arm64_dbg", cq = None) |
| 763 | android_try_job("android_arm64_dbg", cq = None) |
| 764 | android_builder("Android64 (M Nexus5X)", "Android|arm64|rel") |
| 765 | android_try_job("android_arm64_rel") |
| 766 | android_builder("Android64 Builder arm64", "Android|arm64|size", perf_cat = "Android|arm64|Builder|", prioritized = True) |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 767 | android_perf_builder("Perf Android64 (M Nexus5X)", "Android|arm64|Tester|M Nexus5X", triggered_by = ["Android64 Builder arm64"]) |
| 768 | android_perf_builder("Perf Android64 (O Pixel2)", "Android|arm64|Tester|O Pixel2", triggered_by = ["Android64 Builder arm64"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 769 | android_try_job("android_compile_arm64_rel") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 770 | android_builder("Android64 Builder x64 (dbg)", "Android|x64|dbg") |
| 771 | android_try_job("android_compile_x64_dbg") |
| 772 | android_try_job("android_compile_x64_rel", cq = None) |
| 773 | android_builder("Android32 Builder x86 (dbg)", "Android|x86|dbg") |
| 774 | android_try_job("android_compile_x86_dbg") |
| 775 | android_builder("Android32 Builder x86", "Android|x86|rel") |
| 776 | android_try_job("android_compile_x86_rel") |
| 777 | android_builder("Android32 (more configs)", "Android|arm|more", recipe = "more_configs") |
| 778 | android_try_job("android_arm_more_configs", recipe = "more_configs") |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 779 | android_try_job("android_chromium_compile", recipe = "chromium_trybot", branch_cq = False) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 780 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 781 | ios_builder("iOS64 Debug", "iOS|arm64|dbg") |
| 782 | ios_try_job("ios_compile_arm64_dbg") |
| 783 | ios_builder("iOS64 Release", "iOS|arm64|rel") |
| 784 | ios_try_job("ios_compile_arm64_rel") |
Artem Titov | 1d47d31 | 2020-11-03 14:45:52 +0100 | [diff] [blame] | 785 | ios_builder("iOS64 Sim Debug (iOS 14.0)", "iOS|x64|14") |
Andrey Logvin | 81320ad | 2021-06-02 16:45:09 +0000 | [diff] [blame] | 786 | ios_try_job("ios_sim_x64_dbg_ios14") |
Artem Titov | 1d47d31 | 2020-11-03 14:45:52 +0100 | [diff] [blame] | 787 | ios_builder("iOS64 Sim Debug (iOS 13)", "iOS|x64|13") |
Andrey Logvin | 81320ad | 2021-06-02 16:45:09 +0000 | [diff] [blame] | 788 | ios_try_job("ios_sim_x64_dbg_ios13") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 789 | ios_builder("iOS64 Sim Debug (iOS 12)", "iOS|x64|12") |
Andrey Logvin | 81320ad | 2021-06-02 16:45:09 +0000 | [diff] [blame] | 790 | ios_try_job("ios_sim_x64_dbg_ios12") |
Mirko Bonadei | a7677a3 | 2021-10-05 08:31:36 +0200 | [diff] [blame] | 791 | ios_builder_macos11("iOS API Framework Builder", "iOS|fat|size", recipe = "ios_api_framework", prioritized = True) |
| 792 | ios_try_job_macos11("ios_api_framework", recipe = "ios_api_framework") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 793 | |
| 794 | linux_builder("Linux32 Debug", "Linux|x86|dbg") |
| 795 | linux_try_job("linux_x86_dbg") |
| 796 | linux_builder("Linux32 Release", "Linux|x86|rel") |
| 797 | linux_try_job("linux_x86_rel") |
| 798 | linux_builder("Linux64 Debug", "Linux|x64|dbg") |
| 799 | linux_try_job("linux_dbg", cq = None) |
| 800 | linux_try_job("linux_compile_dbg") |
| 801 | linux_builder("Linux64 Release", "Linux|x64|rel") |
| 802 | linux_try_job("linux_rel") |
| 803 | linux_builder("Linux64 Builder", "Linux|x64|size", perf_cat = "Linux|x64|Builder|", prioritized = True) |
| 804 | linux_try_job("linux_compile_rel") |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 805 | linux_perf_builder("Perf Linux Trusty", "Linux|x64|Tester|Trusty", triggered_by = ["Linux64 Builder"]) |
Christoffer Jansson | 627cb05 | 2021-06-29 12:34:58 +0200 | [diff] [blame] | 806 | linux_perf_builder("Perf Linux Bionic", "Linux|x64|Tester|Bionic", triggered_by = ["Linux64 Builder"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 807 | linux_builder("Linux32 Debug (ARM)", "Linux|arm|dbg") |
| 808 | linux_try_job("linux_compile_arm_dbg") |
| 809 | linux_builder("Linux32 Release (ARM)", "Linux|arm|rel") |
| 810 | linux_try_job("linux_compile_arm_rel") |
| 811 | linux_builder("Linux64 Debug (ARM)", "Linux|arm64|dbg") |
| 812 | linux_try_job("linux_compile_arm64_dbg") |
| 813 | linux_builder("Linux64 Release (ARM)", "Linux|arm64|rel") |
| 814 | linux_try_job("linux_compile_arm64_rel") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 815 | linux_builder("Linux Asan", "Linux|x64|asan") |
| 816 | linux_try_job("linux_asan") |
| 817 | linux_builder("Linux MSan", "Linux|x64|msan") |
| 818 | linux_try_job("linux_msan") |
| 819 | linux_builder("Linux Tsan v2", "Linux|x64|tsan") |
| 820 | linux_try_job("linux_tsan2") |
| 821 | linux_builder("Linux UBSan", "Linux|x64|ubsan") |
| 822 | linux_try_job("linux_ubsan") |
| 823 | linux_builder("Linux UBSan vptr", "Linux|x64|ubsan") |
| 824 | linux_try_job("linux_ubsan_vptr") |
| 825 | linux_builder("Linux64 Release (Libfuzzer)", "Linux|x64|fuzz", recipe = "libfuzzer") |
| 826 | linux_try_job("linux_libfuzzer_rel", recipe = "libfuzzer") |
| 827 | linux_builder("Linux (more configs)", "Linux|x64|more", recipe = "more_configs") |
| 828 | linux_try_job("linux_more_configs", recipe = "more_configs") |
Oleh Prypin | 7d1cabe | 2019-03-14 15:10:30 +0100 | [diff] [blame] | 829 | linux_try_job("linux_chromium_compile", recipe = "chromium_trybot", branch_cq = False) |
Mirko Bonadei | 40de50f | 2019-11-07 11:23:47 +0100 | [diff] [blame] | 830 | linux_try_job("linux_chromium_compile_dbg", recipe = "chromium_trybot", branch_cq = False) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 831 | |
| 832 | mac_builder("Mac64 Debug", "Mac|x64|dbg") |
Mirko Bonadei | 36a79c5 | 2021-10-15 19:52:52 +0200 | [diff] [blame] | 833 | mac_try_job("mac_dbg", cq = None) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 834 | mac_try_job("mac_compile_dbg") |
| 835 | mac_builder("Mac64 Release", "Mac|x64|rel") |
Mirko Bonadei | 624568e | 2021-10-15 15:31:57 +0200 | [diff] [blame] | 836 | mac_try_job("mac_rel") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 837 | mac_try_job("mac_compile_rel", cq = None) |
| 838 | mac_builder("Mac64 Builder", ci_cat = None, perf_cat = "Mac|x64|Builder|") |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 839 | mac_perf_builder("Perf Mac 10.11", "Mac|x64|Tester|10.11", triggered_by = ["Mac64 Builder"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 840 | mac_builder("Mac Asan", "Mac|x64|asan") |
Andrey Logvin | a950122 | 2021-04-27 18:08:39 +0000 | [diff] [blame] | 841 | mac_try_job("mac_asan") |
Mirko Bonadei | 2f407ea | 2021-08-31 07:27:22 +0000 | [diff] [blame] | 842 | mac_try_job("mac_chromium_compile", recipe = "chromium_trybot", dimensions = {"cores": "8"}, branch_cq = False) |
Christoffer Jansson | b21c950 | 2021-06-09 16:15:39 +0200 | [diff] [blame] | 843 | mac_builder("MacARM64 M1 Release", "Mac|arm64M1|rel", dimensions = {"cpu": "arm64-64-Apple_M1"}) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 844 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 845 | win_builder("Win32 Debug (Clang)", "Win Clang|x86|dbg") |
| 846 | win_try_job("win_x86_clang_dbg", cq = None) |
| 847 | win_try_job("win_compile_x86_clang_dbg") |
| 848 | win_builder("Win32 Release (Clang)", "Win Clang|x86|rel") |
| 849 | win_try_job("win_x86_clang_rel") |
| 850 | win_try_job("win_compile_x86_clang_rel", cq = None) |
| 851 | win_builder("Win32 Builder (Clang)", ci_cat = None, perf_cat = "Win|x86|Builder|") |
Mirko Bonadei | 1264377 | 2020-03-27 13:16:35 +0100 | [diff] [blame] | 852 | win_perf_builder("Perf Win7", "Win|x86|Tester|7", triggered_by = ["Win32 Builder (Clang)"]) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 853 | win_builder("Win64 Debug (Clang)", "Win Clang|x64|dbg") |
| 854 | win_try_job("win_x64_clang_dbg", cq = None) |
| 855 | win_try_job("win_x64_clang_dbg_win8", cq = None) |
| 856 | win_try_job("win_x64_clang_dbg_win10", cq = None) |
| 857 | win_try_job("win_compile_x64_clang_dbg") |
| 858 | win_builder("Win64 Release (Clang)", "Win Clang|x64|rel") |
| 859 | win_try_job("win_x64_clang_rel", cq = None) |
| 860 | win_try_job("win_compile_x64_clang_rel") |
Mirko Bonadei | afbe33d | 2019-05-31 09:27:54 +0200 | [diff] [blame] | 861 | win_builder("Win64 ASan", "Win Clang|x64|asan") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 862 | win_try_job("win_asan") |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 863 | win_builder("Win (more configs)", "Win Clang|x86|more", recipe = "more_configs") |
| 864 | win_try_job("win_x86_more_configs", recipe = "more_configs") |
Mirko Bonadei | 825f9c2 | 2020-07-01 11:52:39 +0200 | [diff] [blame] | 865 | win_try_job("win_chromium_compile", recipe = "chromium_trybot", branch_cq = False, goma_jobs = 150) |
| 866 | win_try_job("win_chromium_compile_dbg", recipe = "chromium_trybot", branch_cq = False, goma_jobs = 150) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 867 | |
| 868 | linux_try_job( |
| 869 | "presubmit", |
| 870 | recipe = "run_presubmit", |
| 871 | properties = {"repo_name": "webrtc", "runhooks": True}, |
| 872 | priority = 28, |
| 873 | cq = {"disable_reuse": True}, |
| 874 | ) |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 875 | |
| 876 | cron_builder( |
| 877 | "Auto-roll - WebRTC DEPS", |
| 878 | recipe = "auto_roll_webrtc_deps", |
Oleh Prypin | dc68a72 | 2019-06-25 10:43:13 +0200 | [diff] [blame] | 879 | schedule = "0 */2 * * *", # Every 2 hours. |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 880 | ) |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 881 | |
Mirko Bonadei | 54bbd1c | 2020-12-14 15:54:46 +0100 | [diff] [blame] | 882 | cron_builder( |
| 883 | "WebRTC version update", |
| 884 | recipe = "update_webrtc_binary_version", |
| 885 | schedule = "0 4 * * *", # Every day at 4am. |
| 886 | service_account = "webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com", |
| 887 | ) |
| 888 | |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 889 | lkgr_config = { |
| 890 | "project": "webrtc", |
| 891 | "source_url": WEBRTC_GIT, |
| 892 | "status_url": "https://webrtc-status.appspot.com", |
Christoffer Jansson | 7593804 | 2021-10-21 16:56:34 +0200 | [diff] [blame] | 893 | "allowed_lag": 150, # hours |
| 894 | "allowed_gap": 4, # commits behind |
Mirko Bonadei | f4b78bf | 2021-04-29 11:23:41 +0200 | [diff] [blame] | 895 | "error_recipients": WEBRTC_TROOPER_EMAIL, |
Michael Achenbach | 09dd7dc | 2019-07-26 15:26:11 +0200 | [diff] [blame] | 896 | "buckets": { |
| 897 | "webrtc/ci": { |
| 898 | # bucket alias: luci.webrtc.ci |
Mirko Bonadei | ab3ff26 | 2020-12-18 10:17:43 +0100 | [diff] [blame] | 899 | "builders": [ |
| 900 | b |
| 901 | for b in sorted(lkgr_builders) |
| 902 | if b not in skipped_lkgr_bots |
| 903 | ], |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 904 | }, |
Michael Achenbach | 09dd7dc | 2019-07-26 15:26:11 +0200 | [diff] [blame] | 905 | "chromium/webrtc.fyi": { |
| 906 | # bucket alias: luci.chromium.webrtc.fyi |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 907 | "builders": [ |
| 908 | "WebRTC Chromium FYI Android Builder (dbg)", |
| 909 | "WebRTC Chromium FYI Android Builder ARM64 (dbg)", |
| 910 | "WebRTC Chromium FYI Android Builder", |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 911 | "WebRTC Chromium FYI Android Tests (dbg) (M Nexus5X)", |
landrey | 3f32392 | 2021-10-21 07:30:03 +0000 | [diff] [blame] | 912 | "WebRTC Chromium FYI Android Tests (dbg) (N Nexus5X)", |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 913 | "WebRTC Chromium FYI Linux Builder (dbg)", |
| 914 | "WebRTC Chromium FYI Linux Builder", |
| 915 | "WebRTC Chromium FYI Linux Tester", |
| 916 | "WebRTC Chromium FYI Mac Builder (dbg)", |
| 917 | "WebRTC Chromium FYI Mac Builder", |
| 918 | "WebRTC Chromium FYI Mac Tester", |
| 919 | "WebRTC Chromium FYI Win Builder (dbg)", |
Andrey Logvin | 7228ba1 | 2021-09-15 17:59:21 +0000 | [diff] [blame] | 920 | "WebRTC Chromium FYI Win Builder", |
Andrey Logvin | 7484d1b8 | 2021-09-15 17:32:39 +0000 | [diff] [blame] | 921 | "WebRTC Chromium FYI Win10 Tester", |
| 922 | "WebRTC Chromium FYI Win7 Tester", |
| 923 | "WebRTC Chromium FYI Win8 Tester", |
Mirko Bonadei | 2f05cfe | 2020-11-25 10:41:58 +0100 | [diff] [blame] | 924 | "WebRTC Chromium FYI ios-device", |
Björn Terelius | c20ed6b | 2021-06-21 14:31:35 +0200 | [diff] [blame] | 925 | "WebRTC Chromium FYI ios-simulator", |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 926 | ], |
| 927 | }, |
| 928 | }, |
| 929 | } |
| 930 | |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 931 | cron_builder( |
| 932 | "WebRTC lkgr finder", |
| 933 | recipe = "lkgr_finder", |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 934 | properties = { |
| 935 | "project": "webrtc", |
| 936 | "repo": WEBRTC_GIT, |
| 937 | "ref": "refs/heads/lkgr", |
Christoffer Jansson | e9fcc7b | 2021-06-29 13:02:15 +0200 | [diff] [blame] | 938 | "src_ref": "refs/heads/main", |
Oleh Prypin | 8f0dc31 | 2019-05-31 15:54:35 +0200 | [diff] [blame] | 939 | "lkgr_status_gs_path": "chromium-webrtc/lkgr-status", |
| 940 | "config": lkgr_config, |
| 941 | }, |
Oleh Prypin | 1a0593f | 2019-03-11 09:43:28 +0100 | [diff] [blame] | 942 | schedule = "*/10 * * * *", # Every 10 minutes. |
| 943 | ) |