blob: ca7a6f2b6fdfc3a20c7e6022cc521ece9a1d5e9d [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020014#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020015#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020016#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
17#include "modules/rtp_rtcp/include/rtp_cvo.h"
18#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
19#include "modules/rtp_rtcp/include/rtp_header_parser.h"
20#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
21#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
22#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
23#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
24#include "modules/rtp_rtcp/source/rtp_packet_received.h"
25#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
26#include "modules/rtp_rtcp/source/rtp_sender.h"
27#include "modules/rtp_rtcp/source/rtp_sender_video.h"
28#include "modules/rtp_rtcp/source/rtp_utility.h"
29#include "rtc_base/arraysize.h"
30#include "rtc_base/buffer.h"
31#include "rtc_base/ptr_util.h"
32#include "rtc_base/rate_limiter.h"
33#include "test/field_trial.h"
34#include "test/gmock.h"
35#include "test/gtest.h"
36#include "test/mock_transport.h"
Mirko Bonadei71207422017-09-15 13:58:09 +020037#include "typedefs.h" // NOLINT(build/include)
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000038
39namespace webrtc {
40
andrew@webrtc.org8a442592011-12-16 21:24:30 +000041namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000042const int kTransmissionTimeOffsetExtensionId = 1;
43const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000044const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070045const int kVideoTimingExtensionId = 12;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000046const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080047const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const uint32_t kTimestamp = 10;
49const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080050const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000051const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000052const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000053const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevelExtensionId = 9;
55const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000056const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000057const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000058const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020059const size_t kGenericHeaderLength = 1;
60const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070061const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062
Danil Chapovalov5e57b172016-09-02 19:15:59 +020063using ::testing::_;
64using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070065using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000066
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000067uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020068 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000069}
70
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000071class LoopbackTransportTest : public webrtc::Transport {
72 public:
danilchap12ba1862016-10-26 02:41:55 -070073 LoopbackTransportTest() : total_bytes_sent_(0), last_packet_id_(-1) {
74 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
75 kTransmissionTimeOffsetExtensionId);
76 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
77 kAbsoluteSendTimeExtensionId);
78 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
79 kTransportSequenceNumberExtensionId);
80 receivers_extensions_.Register(kRtpExtensionVideoRotation,
81 kVideoRotationExtensionId);
82 receivers_extensions_.Register(kRtpExtensionAudioLevel,
83 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070084 receivers_extensions_.Register(kRtpExtensionVideoTiming,
85 kVideoTimingExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000086 }
danilchap12ba1862016-10-26 02:41:55 -070087
stefan1d8a5062015-10-02 03:39:33 -070088 bool SendRtp(const uint8_t* data,
89 size_t len,
90 const PacketOptions& options) override {
Stefan Holmerf5dca482016-01-27 12:58:51 +010091 last_packet_id_ = options.packet_id;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000092 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070093 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
94 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070095 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000096 }
danilchap162abd32015-12-10 02:39:40 -080097 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -070098 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
99 int packets_sent() { return sent_packets_.size(); }
100
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000101 size_t total_bytes_sent_;
Stefan Holmerf5dca482016-01-27 12:58:51 +0100102 int last_packet_id_;
danilchap12ba1862016-10-26 02:41:55 -0700103 std::vector<RtpPacketReceived> sent_packets_;
104
105 private:
106 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000107};
108
Elad Alon4a87e1c2017-10-03 16:11:34 +0200109MATCHER_P(SameRtcEventTypeAs, value, "") {
110 return value == arg->GetType();
111}
112
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000113} // namespace
114
sprangebbf8a82015-09-21 15:11:14 -0700115class MockRtpPacketSender : public RtpPacketSender {
116 public:
117 MockRtpPacketSender() {}
118 virtual ~MockRtpPacketSender() {}
119
Peter Boströme23e7372015-10-08 11:44:14 +0200120 MOCK_METHOD6(InsertPacket,
121 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700122 uint32_t ssrc,
123 uint16_t sequence_number,
124 int64_t capture_time_ms,
125 size_t bytes,
126 bool retransmission));
127};
128
Stefan Holmerf5dca482016-01-27 12:58:51 +0100129class MockTransportSequenceNumberAllocator
130 : public TransportSequenceNumberAllocator {
131 public:
132 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
133};
134
asapersson35151f32016-05-02 23:44:01 -0700135class MockSendPacketObserver : public SendPacketObserver {
136 public:
137 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
138};
139
Stefan Holmera246cfb2016-08-23 17:51:42 +0200140class MockTransportFeedbackObserver : public TransportFeedbackObserver {
141 public:
elad.alond12a8e12017-03-23 11:04:48 -0700142 MOCK_METHOD4(AddPacket,
143 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200144 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800145 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200146};
147
minyue3a407ee2017-04-03 01:10:33 -0700148class MockOverheadObserver : public OverheadObserver {
149 public:
150 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
151};
152
153class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000154 protected:
155 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000156 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800157 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000158 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700159 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000160 rtp_sender_(),
161 payload_(kPayload),
162 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700163 kMarkerBit(true),
164 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
165 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000166
Erik Språng7b52f102018-02-07 14:37:37 +0100167 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200168
Erik Språng7b52f102018-02-07 14:37:37 +0100169 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700170 rtp_sender_.reset(new RTPSender(
171 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800172 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700173 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100174 &retransmission_rate_limiter_, nullptr, populate_network2));
Danil Chapovalov31e4e802016-08-03 18:27:40 +0200175 rtp_sender_->SetSendPayloadType(kPayload);
brandtr9dfff292016-11-14 05:14:50 -0800176 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700177 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800178 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179 }
180
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000181 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700182 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700183 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700184 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
185 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200186 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700187 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700188 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000189 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000190 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000191 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700192 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000193
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000194 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800195 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000196 }
197
198 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800199 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
200 }
201
202 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
203 bool marker_bit,
204 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000205 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000206 EXPECT_EQ(payload_, rtp_header.payloadType);
207 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
208 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
209 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800210 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000211 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000212 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000213
danilchapb6f1fb52016-10-19 06:11:39 -0700214 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
215 bool marker_bit,
216 uint32_t timestamp,
217 int64_t capture_time_ms) {
218 auto packet = rtp_sender_->AllocatePacket();
219 packet->SetPayloadType(payload_type);
220 packet->SetMarker(marker_bit);
221 packet->SetTimestamp(timestamp);
222 packet->set_capture_time_ms(capture_time_ms);
223 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
224 return packet;
225 }
226
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000227 void SendPacket(int64_t capture_time_ms, int payload_length) {
228 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700229 auto packet =
230 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
231 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000232
233 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700234 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
235 kAllowRetransmission,
236 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000237 }
asapersson35151f32016-05-02 23:44:01 -0700238
239 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700240 const uint32_t kTimestamp = 1234;
241 const uint8_t kPayloadType = 127;
242 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
243 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
244 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
245 0, 1500));
246
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700247 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200248 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700249 sizeof(kPayloadData), nullptr, nullptr, nullptr,
250 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700251 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000252};
253
Peter Boströme23e7372015-10-08 11:44:14 +0200254// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
255// default code path.
256class RtpSenderTestWithoutPacer : public RtpSenderTest {
257 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100258 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200259};
260
spranga8ae6f22017-09-04 07:23:56 -0700261class TestRtpSenderVideo : public RTPSenderVideo {
262 public:
263 TestRtpSenderVideo(Clock* clock,
264 RTPSender* rtp_sender,
265 FlexfecSender* flexfec_sender)
266 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
267 ~TestRtpSenderVideo() override {}
268
269 StorageType GetStorageType(const RTPVideoHeader& header,
270 int32_t retransmission_settings,
271 int64_t expected_retransmission_time_ms) {
272 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
273 retransmission_settings,
274 expected_retransmission_time_ms);
275 }
276};
277
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000278class RtpSenderVideoTest : public RtpSenderTest {
279 protected:
danilchap162abd32015-12-10 02:39:40 -0800280 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200281 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100282 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000283 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700284 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000285 }
spranga8ae6f22017-09-04 07:23:56 -0700286 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000287};
288
minyue3a407ee2017-04-03 01:10:33 -0700289TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200290 // Configure rtp_sender with csrc.
291 std::vector<uint32_t> csrcs;
292 csrcs.push_back(0x23456789);
293 rtp_sender_->SetCsrcs(csrcs);
294
295 auto packet = rtp_sender_->AllocatePacket();
296
297 ASSERT_TRUE(packet);
298 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
299 EXPECT_EQ(csrcs, packet->Csrcs());
300}
301
minyue3a407ee2017-04-03 01:10:33 -0700302TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200303 // Configure rtp_sender with extensions.
304 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
305 kRtpExtensionTransmissionTimeOffset,
306 kTransmissionTimeOffsetExtensionId));
307 ASSERT_EQ(
308 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
309 kAbsoluteSendTimeExtensionId));
310 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
311 kAudioLevelExtensionId));
312 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
313 kRtpExtensionTransportSequenceNumber,
314 kTransportSequenceNumberExtensionId));
315 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
316 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
317
318 auto packet = rtp_sender_->AllocatePacket();
319
320 ASSERT_TRUE(packet);
321 // Preallocate BWE extensions RtpSender set itself.
322 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
323 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
324 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
325 // Do not allocate media specific extensions.
326 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
327 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
328}
329
minyue3a407ee2017-04-03 01:10:33 -0700330TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200331 auto packet = rtp_sender_->AllocatePacket();
332 ASSERT_TRUE(packet);
333 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
334
335 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
336
337 EXPECT_EQ(sequence_number, packet->SequenceNumber());
338 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
339}
340
minyue3a407ee2017-04-03 01:10:33 -0700341TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200342 auto packet = rtp_sender_->AllocatePacket();
343 ASSERT_TRUE(packet);
344
345 rtp_sender_->SetSendingMediaStatus(false);
346 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
347}
348
minyue3a407ee2017-04-03 01:10:33 -0700349TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPadding) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200350 constexpr size_t kPaddingSize = 100;
351 auto packet = rtp_sender_->AllocatePacket();
352 ASSERT_TRUE(packet);
353
philipel8aadd502017-02-23 02:56:13 -0800354 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200355 packet->SetMarker(false);
356 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
357 // Packet without marker bit doesn't allow padding.
philipel8aadd502017-02-23 02:56:13 -0800358 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200359
360 packet->SetMarker(true);
361 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
362 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800363 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364}
365
minyue3a407ee2017-04-03 01:10:33 -0700366TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200367 constexpr size_t kPaddingSize = 100;
368 auto packet = rtp_sender_->AllocatePacket();
369 ASSERT_TRUE(packet);
370 packet->SetMarker(true);
371 packet->SetTimestamp(kTimestamp);
372
373 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800374 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200375
376 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700377 // Verify padding packet timestamp.
378 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200379}
380
minyue3a407ee2017-04-03 01:10:33 -0700381TEST_P(RtpSenderTestWithoutPacer,
382 TransportFeedbackObserverGetsCorrectByteCount) {
383 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
384 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
385 rtp_sender_.reset(new RTPSender(
386 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
387 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100388 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false));
minyue3a407ee2017-04-03 01:10:33 -0700389 rtp_sender_->SetSSRC(kSsrc);
390 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
391 kRtpExtensionTransportSequenceNumber,
392 kTransportSequenceNumberExtensionId));
393 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
394 .WillOnce(testing::Return(kTransportSequenceNumber));
395
396 const size_t expected_bytes =
397 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
398 kRtpOverheadBytesPerPacket
399 : sizeof(kPayloadData) + kGenericHeaderLength;
400
401 EXPECT_CALL(feedback_observer_,
402 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
403 expected_bytes, PacedPacketInfo()))
404 .Times(1);
405 EXPECT_CALL(mock_overhead_observer,
406 OnOverheadChanged(kRtpOverheadBytesPerPacket))
407 .Times(1);
408 SendGenericPayload();
409}
410
411TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200412 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800413 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
414 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +0100415 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800416 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100417 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
418 kRtpExtensionTransportSequenceNumber,
419 kTransportSequenceNumberExtensionId));
420
Stefan Holmerf5dca482016-01-27 12:58:51 +0100421 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
422 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700423 EXPECT_CALL(send_packet_observer_,
424 OnSendPacket(kTransportSequenceNumber, _, _))
425 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700426
427 EXPECT_CALL(feedback_observer_,
428 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
429 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200430 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700431
432 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100433
danilchap12ba1862016-10-26 02:41:55 -0700434 const auto& packet = transport_.last_sent_packet();
435 uint16_t transport_seq_no;
436 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
437 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
438 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100439}
440
minyue3a407ee2017-04-03 01:10:33 -0700441TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700442 SendGenericPayload();
443}
asapersson35151f32016-05-02 23:44:01 -0700444
minyue3a407ee2017-04-03 01:10:33 -0700445TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700446 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
447 kRtpExtensionTransportSequenceNumber,
448 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700449 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
450 .WillOnce(testing::Return(kTransportSequenceNumber));
451 EXPECT_CALL(send_packet_observer_,
452 OnSendPacket(kTransportSequenceNumber, _, _))
453 .Times(1);
454
455 SendGenericPayload();
456}
457
minyue3a407ee2017-04-03 01:10:33 -0700458TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800459 rtp_sender_.reset(new RTPSender(
460 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
461 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
462 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100463 &retransmission_rate_limiter_, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800464 rtp_sender_->SetSequenceNumber(kSeqNum);
465 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200466 rtp_sender_->SetStorePacketsStatus(true, 10);
467 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
468 kRtpExtensionTransportSequenceNumber,
469 kTransportSequenceNumberExtensionId));
470
brandtr9dfff292016-11-14 05:14:50 -0800471 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200472 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
473 .WillOnce(testing::Return(kTransportSequenceNumber));
474 EXPECT_CALL(send_packet_observer_,
475 OnSendPacket(kTransportSequenceNumber, _, _))
476 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700477 EXPECT_CALL(feedback_observer_,
478 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
479 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200480 .Times(1);
481
482 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800483 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
484 fake_clock_.TimeInMilliseconds(), false,
485 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200486
danilchap12ba1862016-10-26 02:41:55 -0700487 const auto& packet = transport_.last_sent_packet();
488 uint16_t transport_seq_no;
489 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
490 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
491 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200492}
493
Erik Språng7b52f102018-02-07 14:37:37 +0100494TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700495 rtp_sender_->SetStorePacketsStatus(true, 10);
496 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
497 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
498 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
499 auto packet = rtp_sender_->AllocatePacket();
500 packet->SetPayloadType(kPayload);
501 packet->SetMarker(true);
502 packet->SetTimestamp(kTimestamp);
503 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700504 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700505 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
506 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
507 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700508
509 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100510 {
511 EXPECT_CALL(
512 mock_paced_sender_,
513 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
514 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
515 kAllowRetransmission,
516 RtpPacketSender::kNormalPriority));
517 }
ilnik04f4d122017-06-19 07:18:55 -0700518 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100519 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
520 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700521 EXPECT_EQ(1, transport_.packets_sent());
522 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
523
danilchapce251812017-09-11 12:24:41 -0700524 VideoSendTiming video_timing;
525 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
526 &video_timing));
527 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100528}
ilnik04f4d122017-06-19 07:18:55 -0700529
Erik Språng7b52f102018-02-07 14:37:37 +0100530TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
531 SetUpRtpSender(true, true);
532 rtp_sender_->SetStorePacketsStatus(true, 10);
533 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
534 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
535 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
536 auto packet = rtp_sender_->AllocatePacket();
537 packet->SetPayloadType(kPayload);
538 packet->SetMarker(true);
539 packet->SetTimestamp(kTimestamp);
540 packet->set_capture_time_ms(capture_time_ms);
541 const uint16_t kPacerExitMs = 1234u;
542 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
543 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
544 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
545 size_t packet_size = packet->size();
546
547 const int kStoredTimeInMs = 100;
548 {
549 EXPECT_CALL(
550 mock_paced_sender_,
551 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
552 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
553 kAllowRetransmission,
554 RtpPacketSender::kNormalPriority));
555 }
ilnik04f4d122017-06-19 07:18:55 -0700556 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
557 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
558 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100559 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700560 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
561
Erik Språng7b52f102018-02-07 14:37:37 +0100562 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700563 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
564 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100565 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
566 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700567}
568
minyue3a407ee2017-04-03 01:10:33 -0700569TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200570 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800571 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200572 EXPECT_CALL(mock_rtc_event_log_,
573 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000574
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000575 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000576 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800577 kRtpExtensionTransmissionTimeOffset,
578 kTransmissionTimeOffsetExtensionId));
579 EXPECT_EQ(
580 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
581 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000582 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700583 auto packet =
584 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
585 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000586
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000587 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700588 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
589 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700590 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000591
danilchap12ba1862016-10-26 02:41:55 -0700592 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000593
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000594 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000595 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000596
brandtr9dfff292016-11-14 05:14:50 -0800597 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800598 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000599
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000600 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700601 EXPECT_EQ(1, transport_.packets_sent());
602 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
603
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000604 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700605 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000606
607 // Verify transmission time offset.
608 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000609 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000610 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000611 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000612}
613
minyue3a407ee2017-04-03 01:10:33 -0700614TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200615 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800616 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200617 EXPECT_CALL(mock_rtc_event_log_,
618 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000619
620 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000621 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800622 kRtpExtensionTransmissionTimeOffset,
623 kTransmissionTimeOffsetExtensionId));
624 EXPECT_EQ(
625 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
626 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000627 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700628 auto packet =
629 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
630 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000631
632 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700633 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
634 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700635 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000636
danilchap12ba1862016-10-26 02:41:55 -0700637 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000638
terelius5d332ac2016-01-14 14:37:39 -0800639 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800640 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000641
642 const int kStoredTimeInMs = 100;
643 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
644
danilchapb6f1fb52016-10-19 06:11:39 -0700645 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700646 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000647
brandtr9dfff292016-11-14 05:14:50 -0800648 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800649 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000650
651 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700652 EXPECT_EQ(1, transport_.packets_sent());
653 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000654
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000655 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700656 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000657
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000658 // Verify transmission time offset.
659 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000660 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000661 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
662 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
663}
664
665// This test sends 1 regular video packet, then 4 padding packets, and then
666// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700667TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000668 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800669 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800670 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200671 EXPECT_CALL(mock_rtc_event_log_,
672 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
673 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000674
675 uint16_t seq_num = kSeqNum;
676 uint32_t timestamp = kTimestamp;
677 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000678 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000679 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800680 kRtpExtensionTransmissionTimeOffset,
681 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000682 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800683 EXPECT_EQ(
684 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
685 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000686 rtp_header_len += 4; // 4 bytes extension.
687 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
688
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000689 webrtc::RTPHeader rtp_header;
690
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000691 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700692 auto packet =
693 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200694 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700695 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000696
697 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700698 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
699 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700700 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000701
702 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700703 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000704
705 const int kStoredTimeInMs = 100;
706 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800707 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800708 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000709 // Packet should now be sent. This test doesn't verify the regular video
710 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700711 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000712 timestamp += 90 * kStoredTimeInMs;
713
714 // Send padding 4 times, waiting 50 ms between each.
715 for (int i = 0; i < 4; ++i) {
716 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000717 const size_t kPaddingBytes = 100;
718 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000719 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800720 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800721 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000722
723 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700724 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000725 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700726 transport_.last_sent_packet().size());
727
728 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700729 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000730
Stefan Holmer586b19b2015-09-18 11:14:31 +0200731 // Verify sequence number and timestamp. The timestamp should be the same
732 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000733 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200734 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000735 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200736 int offset = timestamp - media_packet_timestamp;
737 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000738 uint64_t expected_send_time =
739 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
740 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
741 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
742 timestamp += 90 * kPaddingPeriodMs;
743 }
744
745 // Send a regular video packet again.
746 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700747 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
748 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000749
brandtr9dfff292016-11-14 05:14:50 -0800750 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
751 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800752
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000753 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700754 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
755 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700756 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000757
brandtr9dfff292016-11-14 05:14:50 -0800758 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800759 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000760 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700761 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
762 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
763 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000764
765 // Verify sequence number and timestamp.
766 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
767 EXPECT_EQ(timestamp, rtp_header.timestamp);
768 // Verify transmission time offset. This packet is sent without delay.
769 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
770 uint64_t expected_send_time =
771 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000772 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000773}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000774
minyue3a407ee2017-04-03 01:10:33 -0700775TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700776 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
777 kRtpExtensionTransportSequenceNumber,
778 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700779 rtp_sender_->SetStorePacketsStatus(true, 10);
780
781 EXPECT_CALL(send_packet_observer_,
782 OnSendPacket(kTransportSequenceNumber, _, _))
783 .Times(1);
784 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
785 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800786 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
787 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700788
789 SendGenericPayload(); // Packet passed to pacer.
790 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800791 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
792 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800793 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700794 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700795}
796
minyue3a407ee2017-04-03 01:10:33 -0700797TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700798 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
799 kRtpExtensionTransportSequenceNumber,
800 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700801 rtp_sender_->SetStorePacketsStatus(true, 10);
802
803 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
804 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
805 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800806 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
807 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700808
809 SendGenericPayload(); // Packet passed to pacer.
810 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800811 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
812 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800813 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700814 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700815}
816
minyue3a407ee2017-04-03 01:10:33 -0700817TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700818 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800819 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700820 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800821 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Erik Språng7b52f102018-02-07 14:37:37 +0100822 nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800823 rtp_sender_->SetSequenceNumber(kSeqNum);
824 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700825 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
826 kRtpExtensionTransportSequenceNumber,
827 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700828 rtp_sender_->SetSequenceNumber(kSeqNum);
829 rtp_sender_->SetStorePacketsStatus(true, 10);
830
831 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800832 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
833 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700834
835 SendGenericPayload(); // Packet passed to pacer.
836 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800837 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
838 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800839 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700840 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700841}
842
minyue3a407ee2017-04-03 01:10:33 -0700843TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000844 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800845 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700846 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800847 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Erik Språng7b52f102018-02-07 14:37:37 +0100848 &retransmission_rate_limiter_, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000849 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800850 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800851 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000852
853 uint16_t seq_num = kSeqNum;
854 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000855 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800856 EXPECT_EQ(
857 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
858 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000859 rtp_header_len += 4; // 4 bytes extension.
860 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
861
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000862 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000863 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000864
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000865 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800866 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
867 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800868 // Expect all packets go through the pacer.
869 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800870 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800871 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +0200872 EXPECT_CALL(mock_rtc_event_log_,
873 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800874 .Times(kNumPayloadSizes);
875
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000876 // Send 10 packets of increasing size.
877 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
878 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700879 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000880 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800881 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800882 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000883 fake_clock_.AdvanceTimeMilliseconds(33);
884 }
terelius429c3452016-01-21 05:42:04 -0800885
Elad Alon4a87e1c2017-10-03 16:11:34 +0200886 EXPECT_CALL(mock_rtc_event_log_,
887 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -0800888 .Times(::testing::AtLeast(4));
889
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000890 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700891 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700892 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700893 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800894 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000895
Peter Boströmac547a62015-09-17 23:03:57 +0200896 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700897 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
pbos2d566682015-09-28 09:59:31 -0700898 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700899 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800900 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000901
pbos2d566682015-09-28 09:59:31 -0700902 EXPECT_CALL(transport, SendRtp(_, kPayloadSizes[kNumPayloadSizes - 1] +
stefan1d8a5062015-10-02 03:39:33 -0700903 rtp_header_len + kRtxHeaderSize,
904 _))
pbos2d566682015-09-28 09:59:31 -0700905 .WillOnce(testing::Return(true));
stefan1d8a5062015-10-02 03:39:33 -0700906 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700907 .WillOnce(testing::Return(true));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000908 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800909 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000910}
911
minyue3a407ee2017-04-03 01:10:33 -0700912TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000913 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
914 const uint8_t payload_type = 127;
915 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
916 0, 1500));
917 uint8_t payload[] = {47, 11, 32, 93, 89};
918
919 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700920 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
921 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
922 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000923
danilchap96c15872016-11-21 01:35:29 -0800924 auto sent_payload = transport_.last_sent_packet().payload();
925 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000926 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
927 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800928 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000929
930 // Send delta frame
931 payload[0] = 13;
932 payload[1] = 42;
933 payload[4] = 13;
934
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700935 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
936 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700937 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000938
danilchap96c15872016-11-21 01:35:29 -0800939 sent_payload = transport_.last_sent_packet().payload();
940 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000941 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
942 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800943 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000944}
945
minyue3a407ee2017-04-03 01:10:33 -0700946TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800947 constexpr int kMediaPayloadType = 127;
948 constexpr int kFlexfecPayloadType = 118;
949 constexpr uint32_t kMediaSsrc = 1234;
950 constexpr uint32_t kFlexfecSsrc = 5678;
951 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -0700952 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -0800953 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -0700954 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -0700955 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -0800956
957 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -0800958 rtp_sender_.reset(new RTPSender(
959 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
960 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
961 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +0100962 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -0800963 rtp_sender_->SetSSRC(kMediaSsrc);
964 rtp_sender_->SetSequenceNumber(kSeqNum);
965 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
966 rtp_sender_->SetStorePacketsStatus(true, 10);
967
968 // Parameters selected to generate a single FEC packet per media packet.
969 FecProtectionParams params;
970 params.fec_rate = 15;
971 params.max_fec_frames = 1;
972 params.fec_mask_type = kFecMaskRandom;
973 rtp_sender_->SetFecParameters(params, params);
974
brandtr9dfff292016-11-14 05:14:50 -0800975 EXPECT_CALL(mock_paced_sender_,
976 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
977 _, _, false));
978 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -0800979 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -0800980 kFlexfecSsrc, _, _, _, false))
981 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -0800982 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +0200983 EXPECT_CALL(mock_rtc_event_log_,
984 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
985 .Times(2);
philipel8aadd502017-02-23 02:56:13 -0800986 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
987 fake_clock_.TimeInMilliseconds(),
988 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800989 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
990 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -0800991 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800992 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -0800993 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
994 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -0800995 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -0800996 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -0800997 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
998 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
999 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1000 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001001}
1002
ilnik10894992017-06-21 08:23:19 -07001003// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1004// should be removed.
1005TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1006 constexpr int kMediaPayloadType = 127;
1007 constexpr int kFlexfecPayloadType = 118;
1008 constexpr uint32_t kMediaSsrc = 1234;
1009 constexpr uint32_t kFlexfecSsrc = 5678;
1010 const std::vector<RtpExtension> kNoRtpExtensions;
1011 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001012
ilnik10894992017-06-21 08:23:19 -07001013 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
1014 kNoRtpExtensions, kNoRtpExtensionSizes,
1015 nullptr /* rtp_state */, &fake_clock_);
1016
1017 // Reset |rtp_sender_| to use FlexFEC.
1018 rtp_sender_.reset(new RTPSender(
1019 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1020 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1021 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001022 &retransmission_rate_limiter_, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001023 rtp_sender_->SetSSRC(kMediaSsrc);
1024 rtp_sender_->SetSequenceNumber(kSeqNum);
1025 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1026 rtp_sender_->SetStorePacketsStatus(true, 10);
1027
ilnike4350192017-06-29 02:27:44 -07001028 // Need extension to be registered for timing frames to be sent.
1029 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1030 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1031
ilnik10894992017-06-21 08:23:19 -07001032 // Parameters selected to generate a single FEC packet per media packet.
1033 FecProtectionParams params;
1034 params.fec_rate = 15;
1035 params.max_fec_frames = 1;
1036 params.fec_mask_type = kFecMaskRandom;
1037 rtp_sender_->SetFecParameters(params, params);
1038
1039 EXPECT_CALL(mock_paced_sender_,
1040 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1041 _, _, false));
1042 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1043 kFlexfecSsrc, _, _, _, false))
1044 .Times(0); // Not called because packet should not be protected.
1045
1046 const uint32_t kTimestamp = 1234;
1047 const uint8_t kPayloadType = 127;
1048 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1049 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1050 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1051 0, 1500));
1052 RTPVideoHeader video_header;
1053 memset(&video_header, 0, sizeof(RTPVideoHeader));
sprangba050a62017-08-18 02:51:12 -07001054 video_header.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001055 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1056 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001057 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1058 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001059
Elad Alon4a87e1c2017-10-03 16:11:34 +02001060 EXPECT_CALL(mock_rtc_event_log_,
1061 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1062 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001063 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1064 fake_clock_.TimeInMilliseconds(),
1065 false, PacedPacketInfo()));
1066 ASSERT_EQ(1, transport_.packets_sent());
1067 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1068 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1069 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1070 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1071
1072 // Now try to send not a timing frame.
1073 uint16_t flexfec_seq_num;
1074 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1075 kFlexfecSsrc, _, _, _, false))
1076 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1077 EXPECT_CALL(mock_paced_sender_,
1078 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1079 kSeqNum + 1, _, _, false));
sprangba050a62017-08-18 02:51:12 -07001080 video_header.video_timing.flags = TimingFrameFlags::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001081 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1082 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001083 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1084 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001085
Elad Alon4a87e1c2017-10-03 16:11:34 +02001086 EXPECT_CALL(mock_rtc_event_log_,
1087 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1088 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001089 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1090 fake_clock_.TimeInMilliseconds(),
1091 false, PacedPacketInfo()));
1092 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1093 fake_clock_.TimeInMilliseconds(),
1094 false, PacedPacketInfo()));
1095 ASSERT_EQ(3, transport_.packets_sent());
1096 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1097 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1098 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1099 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1100 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1101 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1102 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1103 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1104}
1105
minyue3a407ee2017-04-03 01:10:33 -07001106TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001107 constexpr int kMediaPayloadType = 127;
1108 constexpr int kFlexfecPayloadType = 118;
1109 constexpr uint32_t kMediaSsrc = 1234;
1110 constexpr uint32_t kFlexfecSsrc = 5678;
1111 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001112 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001113 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001114 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001115 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001116
1117 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng7b52f102018-02-07 14:37:37 +01001118 rtp_sender_.reset(
1119 new RTPSender(false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1120 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1121 &mock_rtc_event_log_, &send_packet_observer_,
1122 &retransmission_rate_limiter_, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001123 rtp_sender_->SetSSRC(kMediaSsrc);
1124 rtp_sender_->SetSequenceNumber(kSeqNum);
1125 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1126
1127 // Parameters selected to generate a single FEC packet per media packet.
1128 FecProtectionParams params;
1129 params.fec_rate = 15;
1130 params.max_fec_frames = 1;
1131 params.fec_mask_type = kFecMaskRandom;
1132 rtp_sender_->SetFecParameters(params, params);
1133
Elad Alon4a87e1c2017-10-03 16:11:34 +02001134 EXPECT_CALL(mock_rtc_event_log_,
1135 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1136 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001137 SendGenericPayload();
1138 ASSERT_EQ(2, transport_.packets_sent());
1139 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1140 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1141 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1142 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1143 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1144 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1145}
1146
minyue3a407ee2017-04-03 01:10:33 -07001147TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001148 constexpr int kMediaPayloadType = 127;
1149 constexpr int kFlexfecPayloadType = 118;
1150 constexpr uint32_t kMediaSsrc = 1234;
1151 constexpr uint32_t kFlexfecSsrc = 5678;
1152 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001153 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001154 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001155 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001156 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001157
1158 // Reset |rtp_sender_| to use FlexFEC.
1159 rtp_sender_.reset(new RTPSender(
1160 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1161 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1162 &mock_rtc_event_log_, &send_packet_observer_,
Erik Språng7b52f102018-02-07 14:37:37 +01001163 &retransmission_rate_limiter_, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001164 rtp_sender_->SetSSRC(kMediaSsrc);
1165 rtp_sender_->SetSequenceNumber(kSeqNum);
1166 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1167
1168 // Parameters selected to generate a single FEC packet per media packet.
1169 FecProtectionParams params;
1170 params.fec_rate = 15;
1171 params.max_fec_frames = 1;
1172 params.fec_mask_type = kFecMaskRandom;
1173 rtp_sender_->SetFecParameters(params, params);
1174
1175 constexpr size_t kNumMediaPackets = 10;
1176 constexpr size_t kNumFecPackets = kNumMediaPackets;
1177 constexpr int64_t kTimeBetweenPacketsMs = 10;
1178 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1179 .Times(kNumMediaPackets + kNumFecPackets);
1180 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1181 SendGenericPayload();
1182 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1183 }
1184 constexpr size_t kRtpHeaderLength = 12;
1185 constexpr size_t kFlexfecHeaderLength = 20;
1186 constexpr size_t kGenericCodecHeaderLength = 1;
1187 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1188 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1189 kGenericCodecHeaderLength + kPayloadLength;
1190 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1191 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1192 rtp_sender_->FecOverheadRate(), 500);
1193}
1194
minyue3a407ee2017-04-03 01:10:33 -07001195TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001196 class TestCallback : public FrameCountObserver {
1197 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001198 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Oleh Prypin01aa2102018-03-09 14:49:01 +00001199 virtual ~TestCallback() {}
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001200
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001201 void FrameCountUpdated(const FrameCounts& frame_counts,
1202 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001203 ++num_calls_;
1204 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001205 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001206 }
1207
1208 uint32_t num_calls_;
1209 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001210 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001211 } callback;
1212
Erik Språng7b52f102018-02-07 14:37:37 +01001213 rtp_sender_.reset(new RTPSender(
1214 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1215 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
1216 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001217 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001218 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1219 const uint8_t payload_type = 127;
1220 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1221 0, 1500));
1222 uint8_t payload[] = {47, 11, 32, 93, 89};
1223 rtp_sender_->SetStorePacketsStatus(true, 1);
1224 uint32_t ssrc = rtp_sender_->SSRC();
1225
terelius5d332ac2016-01-14 14:37:39 -08001226 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1227 .Times(::testing::AtLeast(2));
1228
spranga8ae6f22017-09-04 07:23:56 -07001229 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1230 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1231 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001232
1233 EXPECT_EQ(1U, callback.num_calls_);
1234 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001235 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1236 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001237
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001238 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1239 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001240 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001241
1242 EXPECT_EQ(2U, callback.num_calls_);
1243 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001244 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1245 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001246
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001247 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001248}
1249
minyue3a407ee2017-04-03 01:10:33 -07001250TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001251 class TestCallback : public BitrateStatisticsObserver {
1252 public:
sprangcd349d92016-07-13 09:11:28 -07001253 TestCallback()
1254 : BitrateStatisticsObserver(),
1255 num_calls_(0),
1256 ssrc_(0),
1257 total_bitrate_(0),
1258 retransmit_bitrate_(0) {}
Oleh Prypin01aa2102018-03-09 14:49:01 +00001259 virtual ~TestCallback() {}
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001260
sprangcd349d92016-07-13 09:11:28 -07001261 void Notify(uint32_t total_bitrate,
1262 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001263 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001264 ++num_calls_;
1265 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001266 total_bitrate_ = total_bitrate;
1267 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001268 }
1269
1270 uint32_t num_calls_;
1271 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001272 uint32_t total_bitrate_;
1273 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001274 } callback;
Erik Språng7b52f102018-02-07 14:37:37 +01001275 rtp_sender_.reset(
1276 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1277 nullptr, &callback, nullptr, nullptr, nullptr, nullptr,
1278 &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001279 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001280
sprangcd349d92016-07-13 09:11:28 -07001281 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1282 // number of packets selected so that we fill (but don't overflow) the one
1283 // second averaging window.
1284 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001285 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001286 const uint32_t kNumPackets =
1287 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001288 // Overhead = 12 bytes RTP header + 1 byte generic header.
1289 const uint32_t kPacketOverhead = 13;
1290
1291 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1292 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001293 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1294 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001295 uint8_t payload[] = {47, 11, 32, 93, 89};
1296 rtp_sender_->SetStorePacketsStatus(true, 1);
1297 uint32_t ssrc = rtp_sender_->SSRC();
1298
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001299 // Initial process call so we get a new time window.
1300 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001301
1302 // Send a few frames.
1303 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001304 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1305 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001306 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001307 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1308 }
1309
1310 rtp_sender_->ProcessBitrate();
1311
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001312 // We get one call for every stats updated, thus two calls since both the
1313 // stream stats and the retransmit stats are updated once.
1314 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001315 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001316 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1317 // Bitrate measured over delta between last and first timestamp, plus one.
1318 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1319 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1320 const uint32_t kExpectedRateBps =
1321 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1322 kExpectedWindowMs;
1323 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001324
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001325 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001326}
1327
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001328class RtpSenderAudioTest : public RtpSenderTest {
1329 protected:
1330 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001331
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001332 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001333 payload_ = kAudioPayload;
Erik Språng7b52f102018-02-07 14:37:37 +01001334 rtp_sender_.reset(
1335 new RTPSender(true, &fake_clock_, &transport_, nullptr, nullptr,
1336 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1337 nullptr, &retransmission_rate_limiter_, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001338 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001339 rtp_sender_->SetSequenceNumber(kSeqNum);
1340 }
1341};
1342
minyue3a407ee2017-04-03 01:10:33 -07001343TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001344 class TestCallback : public StreamDataCountersCallback {
1345 public:
danilchap162abd32015-12-10 02:39:40 -08001346 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Oleh Prypin01aa2102018-03-09 14:49:01 +00001347 virtual ~TestCallback() {}
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001348
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001349 void DataCountersUpdated(const StreamDataCounters& counters,
1350 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001351 ssrc_ = ssrc;
1352 counters_ = counters;
1353 }
1354
1355 uint32_t ssrc_;
1356 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001357
1358 void MatchPacketCounter(const RtpPacketCounter& expected,
1359 const RtpPacketCounter& actual) {
1360 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1361 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1362 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1363 EXPECT_EQ(expected.packets, actual.packets);
1364 }
1365
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001366 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1367 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001368 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1369 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001370 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001371 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001372 } callback;
1373
1374 const uint8_t kRedPayloadType = 96;
1375 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001376 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1377 const uint8_t payload_type = 127;
1378 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1379 0, 1500));
1380 uint8_t payload[] = {47, 11, 32, 93, 89};
1381 rtp_sender_->SetStorePacketsStatus(true, 1);
1382 uint32_t ssrc = rtp_sender_->SSRC();
1383
1384 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1385
1386 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001387 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001388 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1389 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001390 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001391 expected.transmitted.payload_bytes = 6;
1392 expected.transmitted.header_bytes = 12;
1393 expected.transmitted.padding_bytes = 0;
1394 expected.transmitted.packets = 1;
1395 expected.retransmitted.payload_bytes = 0;
1396 expected.retransmitted.header_bytes = 0;
1397 expected.retransmitted.padding_bytes = 0;
1398 expected.retransmitted.packets = 0;
1399 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001400 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001401
1402 // Retransmit a frame.
1403 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
1404 rtp_sender_->ReSendPacket(seqno, 0);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001405 expected.transmitted.payload_bytes = 12;
1406 expected.transmitted.header_bytes = 24;
1407 expected.transmitted.packets = 2;
1408 expected.retransmitted.payload_bytes = 6;
1409 expected.retransmitted.header_bytes = 12;
1410 expected.retransmitted.padding_bytes = 0;
1411 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001412 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001413
1414 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001415 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001416 expected.transmitted.payload_bytes = 12;
1417 expected.transmitted.header_bytes = 36;
1418 expected.transmitted.padding_bytes = kMaxPaddingSize;
1419 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001420 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001421
brandtrf1bb4762016-11-07 03:05:06 -08001422 // Send ULPFEC.
1423 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001424 FecProtectionParams fec_params;
1425 fec_params.fec_mask_type = kFecMaskRandom;
1426 fec_params.fec_rate = 1;
1427 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001428 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001429 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001430 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1431 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001432 expected.transmitted.payload_bytes = 40;
1433 expected.transmitted.header_bytes = 60;
1434 expected.transmitted.packets = 5;
1435 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001436 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001437
sprang867fb522015-08-03 04:38:41 -07001438 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001439}
1440
minyue3a407ee2017-04-03 01:10:33 -07001441TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001442 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1443 const uint8_t payload_type = 127;
1444 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1445 0, 1500));
1446 uint8_t payload[] = {47, 11, 32, 93, 89};
1447
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001448 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001449 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1450 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001451
danilchap96c15872016-11-21 01:35:29 -08001452 auto sent_payload = transport_.last_sent_packet().payload();
1453 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001454}
1455
minyue3a407ee2017-04-03 01:10:33 -07001456TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001457 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001458 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1459 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001460
1461 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1462 const uint8_t payload_type = 127;
1463 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1464 0, 1500));
1465 uint8_t payload[] = {47, 11, 32, 93, 89};
1466
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001467 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001468 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1469 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001470
danilchap96c15872016-11-21 01:35:29 -08001471 auto sent_payload = transport_.last_sent_packet().payload();
1472 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001473 // Verify AudioLevel extension.
1474 bool voice_activity;
1475 uint8_t audio_level;
1476 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1477 &voice_activity, &audio_level));
1478 EXPECT_EQ(kAudioLevel, audio_level);
1479 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001480}
1481
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001482// As RFC4733, named telephone events are carried as part of the audio stream
1483// and must use the same sequence number and timestamp base as the regular
1484// audio channel.
1485// This test checks the marker bit for the first packet and the consequent
1486// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001487// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001488TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001489 const char* kDtmfPayloadName = "telephone-event";
1490 const uint32_t kPayloadFrequency = 8000;
1491 const uint8_t kPayloadType = 126;
1492 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1493 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001494 // For Telephone events, payload is not added to the registered payload list,
1495 // it will register only the payload used for audio stream.
1496 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001497 const char* kPayloadName = "payload_name";
1498 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1499 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001500 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1501 // DTMF event key=9, duration=500 and attenuationdB=10
1502 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1503 // During start, it takes the starting timestamp as last sent timestamp.
1504 // The duration is calculated as the difference of current and last sent
1505 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001506 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1507 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1508 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001509 // DTMF Sample Length is (Frequency/1000) * Duration.
1510 // So in this case, it is (8000/1000) * 500 = 4000.
1511 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001512 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001513 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1514 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001515
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001516 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001517 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001518
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001519 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001520 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1521 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001522 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001523 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001524}
1525
minyue3a407ee2017-04-03 01:10:33 -07001526TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001527 const char* kPayloadName = "GENERIC";
1528 const uint8_t kPayloadType = 127;
1529 rtp_sender_->SetSSRC(1234);
1530 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001531 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001532 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001533
danilchap162abd32015-12-10 02:39:40 -08001534 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1535 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001536 uint8_t payload[] = {47, 11, 32, 93, 89};
1537
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001538 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001539 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1540 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001541
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001542 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001543 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1544 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001545
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001546 StreamDataCounters rtp_stats;
1547 StreamDataCounters rtx_stats;
1548 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001549
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001550 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001551 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001552 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1553 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1554 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1555 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1556 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1557 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001558
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001559 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001560 rtp_stats.transmitted.payload_bytes +
1561 rtp_stats.transmitted.header_bytes +
1562 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001563 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001564 rtx_stats.transmitted.payload_bytes +
1565 rtx_stats.transmitted.header_bytes +
1566 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001567
danilchap162abd32015-12-10 02:39:40 -08001568 EXPECT_EQ(
1569 transport_.total_bytes_sent_,
1570 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001571}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001572
minyue3a407ee2017-04-03 01:10:33 -07001573TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001574 const int32_t kPacketSize = 1400;
1575 const int32_t kNumPackets = 30;
1576
sprangcd349d92016-07-13 09:11:28 -07001577 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1578
sprang38778b02015-09-29 09:48:22 -07001579 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001580 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001581 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001582 for (int32_t i = 0; i < kNumPackets; ++i) {
1583 sequence_numbers.push_back(kStartSequenceNumber + i);
1584 fake_clock_.AdvanceTimeMilliseconds(1);
1585 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1586 }
danilchap12ba1862016-10-26 02:41:55 -07001587 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001588
1589 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1590
1591 // Resending should work - brings the bandwidth up to the limit.
1592 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1593 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001594 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001595 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001596
sprangcd349d92016-07-13 09:11:28 -07001597 // Must be at least 5ms in between retransmission attempts.
1598 fake_clock_.AdvanceTimeMilliseconds(5);
1599
sprang38778b02015-09-29 09:48:22 -07001600 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001601 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001602 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001603}
1604
minyue3a407ee2017-04-03 01:10:33 -07001605TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001606 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001607 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1608 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001609
danilchapc1600c52016-10-26 03:33:11 -07001610 RTPVideoHeader hdr = {0};
1611 hdr.rotation = kVideoRotation_0;
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001612 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001613 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001614 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001615
danilchapc1600c52016-10-26 03:33:11 -07001616 VideoRotation rotation;
1617 EXPECT_TRUE(
1618 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1619 EXPECT_EQ(kVideoRotation_0, rotation);
1620}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001621
ilnik04f4d122017-06-19 07:18:55 -07001622TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1623 uint8_t kFrame[kMaxPacketLength];
1624 const int64_t kPacketizationTimeMs = 100;
1625 const int64_t kEncodeStartDeltaMs = 10;
1626 const int64_t kEncodeFinishDeltaMs = 50;
1627 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1628 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1629
1630 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1631
1632 RTPVideoHeader hdr = {0};
sprangba050a62017-08-18 02:51:12 -07001633 hdr.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001634 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1635 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1636
1637 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
1638 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
1639 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001640 sizeof(kFrame), nullptr, &hdr,
1641 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001642 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001643 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1644 &timing));
1645 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1646 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1647 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1648}
1649
minyue3a407ee2017-04-03 01:10:33 -07001650TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001651 uint8_t kFrame[kMaxPacketLength];
1652 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1653 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1654
1655 RTPVideoHeader hdr = {0};
1656 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001657 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1658 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1659 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001660
1661 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001662 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1663 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1664 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001665
1666 VideoRotation rotation;
1667 EXPECT_TRUE(
1668 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1669 EXPECT_EQ(kVideoRotation_0, rotation);
1670}
1671
minyue3a407ee2017-04-03 01:10:33 -07001672TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001673 uint8_t kFrame[kMaxPacketLength];
1674 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1675 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1676
1677 RTPVideoHeader hdr = {0};
1678 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001679 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1680 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1681 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001682
spranga8ae6f22017-09-04 07:23:56 -07001683 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1684 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1685 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001686
1687 VideoRotation rotation;
1688 EXPECT_TRUE(
1689 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1690 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001691}
magjed71eb61c2016-09-08 03:24:58 -07001692
1693// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1694// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001695TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001696 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1697 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1698 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1699 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1700 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1701 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1702 const int flip_bit = 1 << 2;
1703 const int camera_bit = 1 << 3;
1704 EXPECT_EQ(kVideoRotation_0,
1705 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1706 EXPECT_EQ(kVideoRotation_90,
1707 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1708 EXPECT_EQ(kVideoRotation_180,
1709 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1710 EXPECT_EQ(kVideoRotation_270,
1711 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1712}
1713
spranga8ae6f22017-09-04 07:23:56 -07001714TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1715 RTPVideoHeader header;
1716 header.codec = kRtpVideoGeneric;
1717
1718 EXPECT_EQ(kDontRetransmit,
1719 rtp_sender_video_->GetStorageType(
1720 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1721 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1722 header, kRetransmitBaseLayer,
1723 kDefaultExpectedRetransmissionTimeMs));
1724 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1725 header, kRetransmitHigherLayers,
1726 kDefaultExpectedRetransmissionTimeMs));
1727 EXPECT_EQ(kAllowRetransmission,
1728 rtp_sender_video_->GetStorageType(
1729 header, kConditionallyRetransmitHigherLayers,
1730 kDefaultExpectedRetransmissionTimeMs));
1731 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1732 header, kRetransmitAllPackets,
1733 kDefaultExpectedRetransmissionTimeMs));
1734}
1735
1736TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1737 RTPVideoHeader header;
1738 header.codec = kRtpVideoH264;
1739 header.codecHeader.H264.packetization_mode =
1740 H264PacketizationMode::NonInterleaved;
1741
1742 EXPECT_EQ(kDontRetransmit,
1743 rtp_sender_video_->GetStorageType(
1744 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1745 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1746 header, kRetransmitBaseLayer,
1747 kDefaultExpectedRetransmissionTimeMs));
1748 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1749 header, kRetransmitHigherLayers,
1750 kDefaultExpectedRetransmissionTimeMs));
1751 EXPECT_EQ(kAllowRetransmission,
1752 rtp_sender_video_->GetStorageType(
1753 header, kConditionallyRetransmitHigherLayers,
1754 kDefaultExpectedRetransmissionTimeMs));
1755 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1756 header, kRetransmitAllPackets,
1757 kDefaultExpectedRetransmissionTimeMs));
1758}
1759
1760TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1761 RTPVideoHeader header;
1762 header.codec = kRtpVideoVp8;
1763 header.codecHeader.VP8.temporalIdx = 0;
1764
1765 EXPECT_EQ(kDontRetransmit,
1766 rtp_sender_video_->GetStorageType(
1767 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1768 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1769 header, kRetransmitBaseLayer,
1770 kDefaultExpectedRetransmissionTimeMs));
1771 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1772 header, kRetransmitHigherLayers,
1773 kDefaultExpectedRetransmissionTimeMs));
1774 EXPECT_EQ(kAllowRetransmission,
1775 rtp_sender_video_->GetStorageType(
1776 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1777 kDefaultExpectedRetransmissionTimeMs));
1778 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1779 header, kConditionallyRetransmitHigherLayers,
1780 kDefaultExpectedRetransmissionTimeMs));
1781 EXPECT_EQ(
1782 kAllowRetransmission,
1783 rtp_sender_video_->GetStorageType(
1784 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1785 kDefaultExpectedRetransmissionTimeMs));
1786 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1787 header, kRetransmitAllPackets,
1788 kDefaultExpectedRetransmissionTimeMs));
1789}
1790
1791TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1792 RTPVideoHeader header;
1793 header.codec = kRtpVideoVp8;
1794
1795 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1796 header.codecHeader.VP8.temporalIdx = tid;
1797
1798 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1799 header, kRetransmitOff,
1800 kDefaultExpectedRetransmissionTimeMs));
1801 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1802 header, kRetransmitBaseLayer,
1803 kDefaultExpectedRetransmissionTimeMs));
1804 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1805 header, kRetransmitHigherLayers,
1806 kDefaultExpectedRetransmissionTimeMs));
1807 EXPECT_EQ(kAllowRetransmission,
1808 rtp_sender_video_->GetStorageType(
1809 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1810 kDefaultExpectedRetransmissionTimeMs));
1811 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1812 header, kRetransmitAllPackets,
1813 kDefaultExpectedRetransmissionTimeMs));
1814 }
1815}
1816
1817TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1818 RTPVideoHeader header;
1819 header.codec = kRtpVideoVp9;
1820
1821 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1822 header.codecHeader.VP9.temporal_idx = tid;
1823
1824 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1825 header, kRetransmitOff,
1826 kDefaultExpectedRetransmissionTimeMs));
1827 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1828 header, kRetransmitBaseLayer,
1829 kDefaultExpectedRetransmissionTimeMs));
1830 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1831 header, kRetransmitHigherLayers,
1832 kDefaultExpectedRetransmissionTimeMs));
1833 EXPECT_EQ(kAllowRetransmission,
1834 rtp_sender_video_->GetStorageType(
1835 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1836 kDefaultExpectedRetransmissionTimeMs));
1837 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1838 header, kRetransmitAllPackets,
1839 kDefaultExpectedRetransmissionTimeMs));
1840 }
1841}
1842
1843TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1844 const int64_t kFrameIntervalMs = 33;
1845 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1846 const uint8_t kSettings =
1847 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1848
1849 // Insert VP8 frames for all temporal layers, but stop before the final index.
1850 RTPVideoHeader header;
1851 header.codec = kRtpVideoVp8;
1852
1853 // Fill averaging window to prevent rounding errors.
1854 constexpr int kNumRepetitions =
1855 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1856 kFrameIntervalMs;
1857 constexpr int kPattern[] = {0, 2, 1, 2};
1858 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1859 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1860 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1861 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1862 }
1863
1864 // Since we're at the start of the pattern, the next expected frame in TL0 is
1865 // right now. We will wait at most one expected retransmission time before
1866 // acknowledging that it did not arrive, which means this frame and the next
1867 // will not be retransmitted.
1868 header.codecHeader.VP8.temporalIdx = 1;
1869 EXPECT_EQ(StorageType::kDontRetransmit,
1870 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1871 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1872 EXPECT_EQ(StorageType::kDontRetransmit,
1873 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1874 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1875
1876 // The TL0 frame did not arrive. So allow retransmission.
1877 EXPECT_EQ(StorageType::kAllowRetransmission,
1878 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1879 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1880
1881 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1882 // in three frames away. TL0 is still too far in the past. So, allow
1883 // retransmission.
1884 header.codecHeader.VP8.temporalIdx = 2;
1885 EXPECT_EQ(StorageType::kAllowRetransmission,
1886 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1887 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1888
1889 // Another TL2, next in TL1 is two frames away. Allow again.
1890 EXPECT_EQ(StorageType::kAllowRetransmission,
1891 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1892 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1893
1894 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1895 // for retransmission.
1896 EXPECT_EQ(StorageType::kDontRetransmit,
1897 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1898}
1899
1900TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1901 const int64_t kFrameIntervalMs = 200;
1902 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1903 const int32_t kSettings =
1904 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1905
1906 // Insert VP8 frames for all temporal layers, but stop before the final index.
1907 RTPVideoHeader header;
1908 header.codec = kRtpVideoVp8;
1909
1910 // Fill averaging window to prevent rounding errors.
1911 constexpr int kNumRepetitions =
1912 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1913 kFrameIntervalMs;
1914 constexpr int kPattern[] = {0, 2, 2, 2};
1915 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1916 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1917
1918 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1919 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1920 }
1921
1922 // Since we're at the start of the pattern, the next expected frame will be
1923 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1924 // we don't store for retransmission because we expect a frame in a lower
1925 // layer, but that last frame in TL1 was a long time ago in absolute terms,
1926 // so allow retransmission anyway.
1927 header.codecHeader.VP8.temporalIdx = 1;
1928 EXPECT_EQ(StorageType::kAllowRetransmission,
1929 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1930}
1931
minyue3a407ee2017-04-03 01:10:33 -07001932TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001933 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01001934 rtp_sender_.reset(new RTPSender(
1935 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1936 nullptr, nullptr, nullptr, nullptr, nullptr,
1937 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08001938 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001939
michaelt4da30442016-11-17 01:38:43 -08001940 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001941 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001942 SendGenericPayload();
1943
1944 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1945 kTransmissionTimeOffsetExtensionId);
1946
1947 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001948 // 12B + 8B = 20B
1949 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001950 SendGenericPayload();
1951}
1952
minyue3a407ee2017-04-03 01:10:33 -07001953TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001954 MockOverheadObserver mock_overhead_observer;
Erik Språng7b52f102018-02-07 14:37:37 +01001955 rtp_sender_.reset(new RTPSender(
1956 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1957 nullptr, nullptr, nullptr, nullptr, nullptr,
1958 &retransmission_rate_limiter_, &mock_overhead_observer, false));
nisse7d59f6b2017-02-21 03:40:24 -08001959 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001960
1961 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001962 SendGenericPayload();
1963 SendGenericPayload();
1964}
1965
minyue3a407ee2017-04-03 01:10:33 -07001966TEST_P(RtpSenderTest, SendAudioPadding) {
stefan53b6cc32017-02-03 08:13:57 -08001967 MockTransport transport;
1968 const bool kEnableAudio = true;
1969 rtp_sender_.reset(new RTPSender(
1970 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
1971 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Erik Språng7b52f102018-02-07 14:37:37 +01001972 nullptr, &retransmission_rate_limiter_, nullptr, false));
stefan53b6cc32017-02-03 08:13:57 -08001973 rtp_sender_->SetSendPayloadType(kPayload);
1974 rtp_sender_->SetSequenceNumber(kSeqNum);
1975 rtp_sender_->SetTimestampOffset(0);
1976 rtp_sender_->SetSSRC(kSsrc);
1977
1978 const size_t kPaddingSize = 59;
1979 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
1980 .WillOnce(testing::Return(true));
philipelc7bf32a2017-02-17 03:59:43 -08001981 EXPECT_EQ(kPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001982 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001983
1984 // Requested padding size is too small, will send a larger one.
1985 const size_t kMinPaddingSize = 50;
1986 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
1987 .WillOnce(testing::Return(true));
philipel8aadd502017-02-23 02:56:13 -08001988 EXPECT_EQ(
1989 kMinPaddingSize,
1990 rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001991}
minyue3a407ee2017-04-03 01:10:33 -07001992
sprang168794c2017-07-06 04:38:06 -07001993TEST_P(RtpSenderTest, SendsKeepAlive) {
1994 MockTransport transport;
Erik Språng7b52f102018-02-07 14:37:37 +01001995 rtp_sender_.reset(
1996 new RTPSender(false, &fake_clock_, &transport, nullptr, nullptr, nullptr,
1997 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
1998 nullptr, &retransmission_rate_limiter_, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07001999 rtp_sender_->SetSendPayloadType(kPayload);
2000 rtp_sender_->SetSequenceNumber(kSeqNum);
2001 rtp_sender_->SetTimestampOffset(0);
2002 rtp_sender_->SetSSRC(kSsrc);
2003
2004 const uint8_t kKeepalivePayloadType = 20;
2005 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2006
2007 EXPECT_CALL(transport, SendRtp(_, _, _))
2008 .WillOnce(
2009 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2010 const PacketOptions& options) {
2011 webrtc::RTPHeader rtp_header;
2012 RtpUtility::RtpHeaderParser parser(packet, len);
2013 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2014 EXPECT_FALSE(rtp_header.markerBit);
2015 EXPECT_EQ(0U, rtp_header.paddingLength);
2016 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2017 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2018 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2019 EXPECT_EQ(0u, len - rtp_header.headerLength);
2020 return true;
2021 }));
2022
2023 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2024 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2025}
2026
minyue3a407ee2017-04-03 01:10:33 -07002027INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2028 RtpSenderTest,
2029 ::testing::Bool());
2030INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2031 RtpSenderTestWithoutPacer,
2032 ::testing::Bool());
2033INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2034 RtpSenderVideoTest,
2035 ::testing::Bool());
2036INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2037 RtpSenderAudioTest,
2038 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002039} // namespace webrtc