henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2011 The WebRTC Project Authors. All rights reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
jbauch | 555604a | 2016-04-26 03:13:22 -0700 | [diff] [blame] | 11 | #include <memory> |
| 12 | |
nisse | c8ee882 | 2017-01-18 07:20:55 -0800 | [diff] [blame^] | 13 | #include "webrtc/base/checks.h" |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 14 | #include "webrtc/base/common.h" |
| 15 | #include "webrtc/base/gunit.h" |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 16 | #include "webrtc/base/event.h" |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 17 | #include "webrtc/base/messagehandler.h" |
| 18 | #include "webrtc/base/messagequeue.h" |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 19 | #include "webrtc/base/sharedexclusivelock.h" |
| 20 | #include "webrtc/base/thread.h" |
| 21 | #include "webrtc/base/timeutils.h" |
| 22 | |
| 23 | namespace rtc { |
| 24 | |
Peter Boström | 0c4e06b | 2015-10-07 12:23:21 +0200 | [diff] [blame] | 25 | static const uint32_t kMsgRead = 0; |
| 26 | static const uint32_t kMsgWrite = 0; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 27 | static const int kNoWaitThresholdInMs = 10; |
| 28 | static const int kWaitThresholdInMs = 80; |
| 29 | static const int kProcessTimeInMs = 100; |
| 30 | static const int kProcessTimeoutInMs = 5000; |
| 31 | |
| 32 | class SharedExclusiveTask : public MessageHandler { |
| 33 | public: |
| 34 | SharedExclusiveTask(SharedExclusiveLock* shared_exclusive_lock, |
| 35 | int* value, |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 36 | Event* done) |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 37 | : shared_exclusive_lock_(shared_exclusive_lock), |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 38 | value_(value), |
| 39 | done_(done) { |
| 40 | worker_thread_.reset(new Thread()); |
| 41 | worker_thread_->Start(); |
| 42 | } |
| 43 | |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 44 | protected: |
jbauch | 555604a | 2016-04-26 03:13:22 -0700 | [diff] [blame] | 45 | std::unique_ptr<Thread> worker_thread_; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 46 | SharedExclusiveLock* shared_exclusive_lock_; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 47 | int* value_; |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 48 | Event* done_; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 49 | }; |
| 50 | |
| 51 | class ReadTask : public SharedExclusiveTask { |
| 52 | public: |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 53 | ReadTask(SharedExclusiveLock* shared_exclusive_lock, int* value, Event* done) |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 54 | : SharedExclusiveTask(shared_exclusive_lock, value, done) { |
| 55 | } |
| 56 | |
| 57 | void PostRead(int* value) { |
Taylor Brandstetter | 5d97a9a | 2016-06-10 14:17:27 -0700 | [diff] [blame] | 58 | worker_thread_->Post(RTC_FROM_HERE, this, kMsgRead, |
| 59 | new TypedMessageData<int*>(value)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 60 | } |
| 61 | |
| 62 | private: |
| 63 | virtual void OnMessage(Message* message) { |
nisse | c8ee882 | 2017-01-18 07:20:55 -0800 | [diff] [blame^] | 64 | RTC_CHECK(rtc::Thread::Current() == worker_thread_.get()); |
| 65 | RTC_CHECK(message != NULL); |
| 66 | RTC_CHECK(message->message_id == kMsgRead); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 67 | |
| 68 | TypedMessageData<int*>* message_data = |
| 69 | static_cast<TypedMessageData<int*>*>(message->pdata); |
| 70 | |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 71 | { |
| 72 | SharedScope ss(shared_exclusive_lock_); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 73 | *message_data->data() = *value_; |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 74 | done_->Set(); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 75 | } |
| 76 | delete message->pdata; |
| 77 | message->pdata = NULL; |
| 78 | } |
| 79 | }; |
| 80 | |
| 81 | class WriteTask : public SharedExclusiveTask { |
| 82 | public: |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 83 | WriteTask(SharedExclusiveLock* shared_exclusive_lock, int* value, Event* done) |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 84 | : SharedExclusiveTask(shared_exclusive_lock, value, done) { |
| 85 | } |
| 86 | |
| 87 | void PostWrite(int value) { |
Taylor Brandstetter | 5d97a9a | 2016-06-10 14:17:27 -0700 | [diff] [blame] | 88 | worker_thread_->Post(RTC_FROM_HERE, this, kMsgWrite, |
| 89 | new TypedMessageData<int>(value)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 90 | } |
| 91 | |
| 92 | private: |
| 93 | virtual void OnMessage(Message* message) { |
nisse | c8ee882 | 2017-01-18 07:20:55 -0800 | [diff] [blame^] | 94 | RTC_CHECK(rtc::Thread::Current() == worker_thread_.get()); |
| 95 | RTC_CHECK(message != NULL); |
| 96 | RTC_CHECK(message->message_id == kMsgWrite); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 97 | |
| 98 | TypedMessageData<int>* message_data = |
| 99 | static_cast<TypedMessageData<int>*>(message->pdata); |
| 100 | |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 101 | { |
| 102 | ExclusiveScope es(shared_exclusive_lock_); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 103 | *value_ = message_data->data(); |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 104 | done_->Set(); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 105 | } |
| 106 | delete message->pdata; |
| 107 | message->pdata = NULL; |
| 108 | } |
| 109 | }; |
| 110 | |
| 111 | // Unit test for SharedExclusiveLock. |
| 112 | class SharedExclusiveLockTest |
| 113 | : public testing::Test { |
| 114 | public: |
| 115 | SharedExclusiveLockTest() : value_(0) { |
| 116 | } |
| 117 | |
| 118 | virtual void SetUp() { |
| 119 | shared_exclusive_lock_.reset(new SharedExclusiveLock()); |
| 120 | } |
| 121 | |
| 122 | protected: |
jbauch | 555604a | 2016-04-26 03:13:22 -0700 | [diff] [blame] | 123 | std::unique_ptr<SharedExclusiveLock> shared_exclusive_lock_; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 124 | int value_; |
| 125 | }; |
| 126 | |
henrike@webrtc.org | c732a3e | 2014-10-09 22:08:15 +0000 | [diff] [blame] | 127 | TEST_F(SharedExclusiveLockTest, TestSharedShared) { |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 128 | int value0, value1; |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 129 | Event done0(false, false), done1(false, false); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 130 | ReadTask reader0(shared_exclusive_lock_.get(), &value_, &done0); |
| 131 | ReadTask reader1(shared_exclusive_lock_.get(), &value_, &done1); |
| 132 | |
| 133 | // Test shared locks can be shared without waiting. |
| 134 | { |
| 135 | SharedScope ss(shared_exclusive_lock_.get()); |
| 136 | value_ = 1; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 137 | reader0.PostRead(&value0); |
| 138 | reader1.PostRead(&value1); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 139 | |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 140 | EXPECT_TRUE(done0.Wait(kProcessTimeoutInMs)); |
| 141 | EXPECT_TRUE(done1.Wait(kProcessTimeoutInMs)); |
| 142 | EXPECT_EQ(1, value0); |
| 143 | EXPECT_EQ(1, value1); |
| 144 | } |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 145 | } |
| 146 | |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 147 | TEST_F(SharedExclusiveLockTest, TestSharedExclusive) { |
| 148 | Event done(false, false); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 149 | WriteTask writer(shared_exclusive_lock_.get(), &value_, &done); |
| 150 | |
| 151 | // Test exclusive lock needs to wait for shared lock. |
| 152 | { |
| 153 | SharedScope ss(shared_exclusive_lock_.get()); |
| 154 | value_ = 1; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 155 | writer.PostWrite(2); |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 156 | EXPECT_FALSE(done.Wait(kProcessTimeInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 157 | } |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 158 | EXPECT_TRUE(done.Wait(kProcessTimeoutInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 159 | EXPECT_EQ(2, value_); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 160 | } |
| 161 | |
henrike@webrtc.org | c732a3e | 2014-10-09 22:08:15 +0000 | [diff] [blame] | 162 | TEST_F(SharedExclusiveLockTest, TestExclusiveShared) { |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 163 | int value; |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 164 | Event done(false, false); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 165 | ReadTask reader(shared_exclusive_lock_.get(), &value_, &done); |
| 166 | |
| 167 | // Test shared lock needs to wait for exclusive lock. |
| 168 | { |
| 169 | ExclusiveScope es(shared_exclusive_lock_.get()); |
| 170 | value_ = 1; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 171 | reader.PostRead(&value); |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 172 | EXPECT_FALSE(done.Wait(kProcessTimeInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 173 | value_ = 2; |
| 174 | } |
| 175 | |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 176 | EXPECT_TRUE(done.Wait(kProcessTimeoutInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 177 | EXPECT_EQ(2, value); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 178 | } |
| 179 | |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 180 | TEST_F(SharedExclusiveLockTest, TestExclusiveExclusive) { |
| 181 | Event done(false, false); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 182 | WriteTask writer(shared_exclusive_lock_.get(), &value_, &done); |
| 183 | |
| 184 | // Test exclusive lock needs to wait for exclusive lock. |
| 185 | { |
| 186 | ExclusiveScope es(shared_exclusive_lock_.get()); |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 187 | // Start the writer task only after holding the lock, to ensure it need |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 188 | value_ = 1; |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 189 | writer.PostWrite(2); |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 190 | EXPECT_FALSE(done.Wait(kProcessTimeInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 191 | EXPECT_EQ(1, value_); |
| 192 | } |
| 193 | |
skvlad | efc5ae9 | 2016-10-05 15:58:12 -0700 | [diff] [blame] | 194 | EXPECT_TRUE(done.Wait(kProcessTimeoutInMs)); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 195 | EXPECT_EQ(2, value_); |
henrike@webrtc.org | f048872 | 2014-05-13 18:00:26 +0000 | [diff] [blame] | 196 | } |
| 197 | |
| 198 | } // namespace rtc |