Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | #include "rtc_base/experiments/field_trial_parser.h" |
Jonas Olsson | 97d84ef | 2019-04-11 11:53:26 +0200 | [diff] [blame] | 11 | |
| 12 | #include "rtc_base/experiments/field_trial_list.h" |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 13 | #include "rtc_base/gunit.h" |
| 14 | #include "system_wrappers/include/field_trial.h" |
| 15 | #include "test/field_trial.h" |
Jonas Olsson | 97d84ef | 2019-04-11 11:53:26 +0200 | [diff] [blame] | 16 | #include "test/gmock.h" |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 17 | |
| 18 | namespace webrtc { |
| 19 | namespace { |
| 20 | const char kDummyExperiment[] = "WebRTC-DummyExperiment"; |
| 21 | |
| 22 | struct DummyExperiment { |
| 23 | FieldTrialFlag enabled = FieldTrialFlag("Enabled"); |
| 24 | FieldTrialParameter<double> factor = FieldTrialParameter<double>("f", 0.5); |
| 25 | FieldTrialParameter<int> retries = FieldTrialParameter<int>("r", 5); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 26 | FieldTrialParameter<unsigned> size = FieldTrialParameter<unsigned>("s", 3); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 27 | FieldTrialParameter<bool> ping = FieldTrialParameter<bool>("p", 0); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 28 | FieldTrialParameter<std::string> hash = |
| 29 | FieldTrialParameter<std::string>("h", "a80"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 30 | |
| 31 | explicit DummyExperiment(std::string field_trial) { |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 32 | ParseFieldTrial({&enabled, &factor, &retries, &size, &ping, &hash}, |
| 33 | field_trial); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 34 | } |
| 35 | DummyExperiment() { |
| 36 | std::string trial_string = field_trial::FindFullName(kDummyExperiment); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 37 | ParseFieldTrial({&enabled, &factor, &retries, &size, &ping, &hash}, |
| 38 | trial_string); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 39 | } |
| 40 | }; |
| 41 | |
| 42 | enum class CustomEnum { |
Sebastian Jansson | 2c74d85 | 2018-06-26 10:30:16 +0200 | [diff] [blame] | 43 | kDefault = 0, |
| 44 | kRed = 1, |
| 45 | kBlue = 2, |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 46 | }; |
Jonas Olsson | 97d84ef | 2019-04-11 11:53:26 +0200 | [diff] [blame] | 47 | |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 48 | } // namespace |
| 49 | |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 50 | TEST(FieldTrialParserTest, ParsesValidParameters) { |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 51 | DummyExperiment exp("Enabled,f:-1.7,r:2,s:10,p:1,h:x7c"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 52 | EXPECT_TRUE(exp.enabled.Get()); |
| 53 | EXPECT_EQ(exp.factor.Get(), -1.7); |
| 54 | EXPECT_EQ(exp.retries.Get(), 2); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 55 | EXPECT_EQ(exp.size.Get(), 10u); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 56 | EXPECT_EQ(exp.ping.Get(), true); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 57 | EXPECT_EQ(exp.hash.Get(), "x7c"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 58 | } |
| 59 | TEST(FieldTrialParserTest, InitializesFromFieldTrial) { |
| 60 | test::ScopedFieldTrials field_trials( |
| 61 | "WebRTC-OtherExperiment/Disabled/" |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 62 | "WebRTC-DummyExperiment/Enabled,f:-1.7,r:2,s:10,p:1,h:x7c/" |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 63 | "WebRTC-AnotherExperiment/Enabled,f:-3.1,otherstuff:beef/"); |
| 64 | DummyExperiment exp; |
| 65 | EXPECT_TRUE(exp.enabled.Get()); |
| 66 | EXPECT_EQ(exp.factor.Get(), -1.7); |
| 67 | EXPECT_EQ(exp.retries.Get(), 2); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 68 | EXPECT_EQ(exp.size.Get(), 10u); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 69 | EXPECT_EQ(exp.ping.Get(), true); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 70 | EXPECT_EQ(exp.hash.Get(), "x7c"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 71 | } |
| 72 | TEST(FieldTrialParserTest, UsesDefaults) { |
| 73 | DummyExperiment exp(""); |
| 74 | EXPECT_FALSE(exp.enabled.Get()); |
| 75 | EXPECT_EQ(exp.factor.Get(), 0.5); |
| 76 | EXPECT_EQ(exp.retries.Get(), 5); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 77 | EXPECT_EQ(exp.size.Get(), 3u); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 78 | EXPECT_EQ(exp.ping.Get(), false); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 79 | EXPECT_EQ(exp.hash.Get(), "a80"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 80 | } |
| 81 | TEST(FieldTrialParserTest, CanHandleMixedInput) { |
| 82 | DummyExperiment exp("p:true,h:,Enabled"); |
| 83 | EXPECT_TRUE(exp.enabled.Get()); |
| 84 | EXPECT_EQ(exp.factor.Get(), 0.5); |
| 85 | EXPECT_EQ(exp.retries.Get(), 5); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 86 | EXPECT_EQ(exp.size.Get(), 3u); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 87 | EXPECT_EQ(exp.ping.Get(), true); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 88 | EXPECT_EQ(exp.hash.Get(), ""); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 89 | } |
Sebastian Jansson | ec76466 | 2018-09-03 11:31:26 +0200 | [diff] [blame] | 90 | TEST(FieldTrialParserTest, ParsesDoubleParameter) { |
| 91 | FieldTrialParameter<double> double_param("f", 0.0); |
| 92 | ParseFieldTrial({&double_param}, "f:45%"); |
| 93 | EXPECT_EQ(double_param.Get(), 0.45); |
| 94 | ParseFieldTrial({&double_param}, "f:34 %"); |
| 95 | EXPECT_EQ(double_param.Get(), 0.34); |
| 96 | ParseFieldTrial({&double_param}, "f:0.67"); |
| 97 | EXPECT_EQ(double_param.Get(), 0.67); |
| 98 | } |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 99 | TEST(FieldTrialParserTest, IgnoresNewKey) { |
| 100 | DummyExperiment exp("Disabled,r:-11,foo"); |
| 101 | EXPECT_FALSE(exp.enabled.Get()); |
| 102 | EXPECT_EQ(exp.factor.Get(), 0.5); |
| 103 | EXPECT_EQ(exp.retries.Get(), -11); |
| 104 | } |
| 105 | TEST(FieldTrialParserTest, IgnoresInvalid) { |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 106 | DummyExperiment exp("Enabled,f,p:,r:%,,s:-1,:foo,h"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 107 | EXPECT_TRUE(exp.enabled.Get()); |
| 108 | EXPECT_EQ(exp.factor.Get(), 0.5); |
| 109 | EXPECT_EQ(exp.retries.Get(), 5); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 110 | EXPECT_EQ(exp.size.Get(), 3u); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 111 | EXPECT_EQ(exp.ping.Get(), false); |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 112 | EXPECT_EQ(exp.hash.Get(), "a80"); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 113 | } |
Sebastian Jansson | b22f077 | 2018-11-19 17:44:33 +0100 | [diff] [blame] | 114 | TEST(FieldTrialParserTest, IgnoresOutOfRange) { |
| 115 | FieldTrialConstrained<double> low("low", 10, absl::nullopt, 100); |
| 116 | FieldTrialConstrained<double> high("high", 10, 5, absl::nullopt); |
| 117 | ParseFieldTrial({&low, &high}, "low:1000,high:0"); |
| 118 | EXPECT_EQ(low.Get(), 10); |
| 119 | EXPECT_EQ(high.Get(), 10); |
| 120 | ParseFieldTrial({&low, &high}, "low:inf,high:nan"); |
| 121 | EXPECT_EQ(low.Get(), 10); |
| 122 | EXPECT_EQ(high.Get(), 10); |
| 123 | ParseFieldTrial({&low, &high}, "low:20,high:20"); |
| 124 | EXPECT_EQ(low.Get(), 20); |
| 125 | EXPECT_EQ(high.Get(), 20); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 126 | |
| 127 | FieldTrialConstrained<unsigned> size("size", 5, 1, 10); |
| 128 | ParseFieldTrial({&size}, "size:0"); |
| 129 | EXPECT_EQ(size.Get(), 5u); |
Sebastian Jansson | b22f077 | 2018-11-19 17:44:33 +0100 | [diff] [blame] | 130 | } |
Sebastian Jansson | d69998a | 2018-12-20 12:25:19 +0100 | [diff] [blame] | 131 | TEST(FieldTrialParserTest, ReadsValuesFromFieldWithoutKey) { |
| 132 | FieldTrialFlag enabled("Enabled"); |
| 133 | FieldTrialParameter<int> req("", 10); |
| 134 | ParseFieldTrial({&enabled, &req}, "Enabled,20"); |
| 135 | EXPECT_EQ(req.Get(), 20); |
| 136 | ParseFieldTrial({&req}, "30"); |
| 137 | EXPECT_EQ(req.Get(), 30); |
| 138 | } |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 139 | TEST(FieldTrialParserTest, ParsesOptionalParameters) { |
Danil Chapovalov | 0a1d189 | 2018-06-21 11:48:25 +0200 | [diff] [blame] | 140 | FieldTrialOptional<int> max_count("c", absl::nullopt); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 141 | ParseFieldTrial({&max_count}, ""); |
Sebastian Jansson | fea4637 | 2018-09-03 10:15:13 +0200 | [diff] [blame] | 142 | EXPECT_FALSE(max_count.GetOptional().has_value()); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 143 | ParseFieldTrial({&max_count}, "c:10"); |
Sebastian Jansson | fea4637 | 2018-09-03 10:15:13 +0200 | [diff] [blame] | 144 | EXPECT_EQ(max_count.GetOptional().value(), 10); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 145 | ParseFieldTrial({&max_count}, "c"); |
Sebastian Jansson | fea4637 | 2018-09-03 10:15:13 +0200 | [diff] [blame] | 146 | EXPECT_FALSE(max_count.GetOptional().has_value()); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 147 | ParseFieldTrial({&max_count}, "c:20"); |
Sebastian Jansson | fea4637 | 2018-09-03 10:15:13 +0200 | [diff] [blame] | 148 | EXPECT_EQ(max_count.GetOptional().value(), 20); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 149 | ParseFieldTrial({&max_count}, "c:"); |
Sebastian Jansson | fea4637 | 2018-09-03 10:15:13 +0200 | [diff] [blame] | 150 | EXPECT_EQ(max_count.GetOptional().value(), 20); |
Bjorn Terelius | 9f00f0e | 2019-08-30 09:39:31 +0200 | [diff] [blame] | 151 | |
| 152 | FieldTrialOptional<unsigned> max_size("c", absl::nullopt); |
| 153 | ParseFieldTrial({&max_size}, ""); |
| 154 | EXPECT_FALSE(max_size.GetOptional().has_value()); |
| 155 | ParseFieldTrial({&max_size}, "c:10"); |
| 156 | EXPECT_EQ(max_size.GetOptional().value(), 10u); |
| 157 | ParseFieldTrial({&max_size}, "c"); |
| 158 | EXPECT_FALSE(max_size.GetOptional().has_value()); |
| 159 | ParseFieldTrial({&max_size}, "c:20"); |
| 160 | EXPECT_EQ(max_size.GetOptional().value(), 20u); |
| 161 | |
Philip Eliasson | 29ab487 | 2019-09-10 14:05:43 +0000 | [diff] [blame] | 162 | FieldTrialOptional<std::string> optional_string("s", std::string("ab")); |
| 163 | ParseFieldTrial({&optional_string}, "s:"); |
| 164 | EXPECT_EQ(optional_string.GetOptional().value(), ""); |
| 165 | ParseFieldTrial({&optional_string}, "s"); |
| 166 | EXPECT_FALSE(optional_string.GetOptional().has_value()); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 167 | } |
| 168 | TEST(FieldTrialParserTest, ParsesCustomEnumParameter) { |
Sebastian Jansson | 2c74d85 | 2018-06-26 10:30:16 +0200 | [diff] [blame] | 169 | FieldTrialEnum<CustomEnum> my_enum("e", CustomEnum::kDefault, |
| 170 | {{"default", CustomEnum::kDefault}, |
| 171 | {"red", CustomEnum::kRed}, |
| 172 | {"blue", CustomEnum::kBlue}}); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 173 | ParseFieldTrial({&my_enum}, ""); |
| 174 | EXPECT_EQ(my_enum.Get(), CustomEnum::kDefault); |
| 175 | ParseFieldTrial({&my_enum}, "e:red"); |
| 176 | EXPECT_EQ(my_enum.Get(), CustomEnum::kRed); |
Sebastian Jansson | 2c74d85 | 2018-06-26 10:30:16 +0200 | [diff] [blame] | 177 | ParseFieldTrial({&my_enum}, "e:2"); |
| 178 | EXPECT_EQ(my_enum.Get(), CustomEnum::kBlue); |
| 179 | ParseFieldTrial({&my_enum}, "e:5"); |
| 180 | EXPECT_EQ(my_enum.Get(), CustomEnum::kBlue); |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 181 | } |
Jonas Olsson | 97d84ef | 2019-04-11 11:53:26 +0200 | [diff] [blame] | 182 | |
Sebastian Jansson | 9eb3886 | 2018-06-14 16:47:42 +0200 | [diff] [blame] | 183 | } // namespace webrtc |