denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2016 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #import <Foundation/Foundation.h> |
| 12 | #import <OCMock/OCMock.h> |
| 13 | |
ehmaldonado | eaaae9e | 2017-07-07 03:09:51 -0700 | [diff] [blame] | 14 | #include "webrtc/rtc_base/gunit.h" |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 15 | |
kthelgason | 2f08879 | 2017-05-30 01:48:47 -0700 | [diff] [blame] | 16 | #include "Video/avfoundationformatmapper.h" |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 17 | |
| 18 | |
| 19 | // Width and height don't play any role so lets use predefined values throughout |
| 20 | // the tests. |
| 21 | static const int kFormatWidth = 789; |
| 22 | static const int kFormatHeight = 987; |
| 23 | |
| 24 | // Hardcoded framrate to be used throughout the tests. |
| 25 | static const int kFramerate = 30; |
| 26 | |
| 27 | // Same width and height is used so it's ok to expect same cricket::VideoFormat |
| 28 | static cricket::VideoFormat expectedFormat = |
| 29 | cricket::VideoFormat(kFormatWidth, |
| 30 | kFormatHeight, |
| 31 | cricket::VideoFormat::FpsToInterval(kFramerate), |
| 32 | cricket::FOURCC_NV12); |
| 33 | |
| 34 | // Mock class for AVCaptureDeviceFormat. |
| 35 | // Custom implementation needed because OCMock cannot handle the |
| 36 | // CMVideoDescriptionRef mocking. |
| 37 | @interface AVCaptureDeviceFormatMock : NSObject |
| 38 | |
| 39 | @property (nonatomic, assign) CMVideoFormatDescriptionRef format; |
| 40 | @property (nonatomic, strong) OCMockObject *rangeMock; |
| 41 | |
| 42 | - (instancetype)initWithMediaSubtype:(FourCharCode)subtype |
| 43 | minFps:(float)minFps |
| 44 | maxFps:(float)maxFps; |
| 45 | + (instancetype)validFormat; |
| 46 | + (instancetype)invalidFpsFormat; |
| 47 | + (instancetype)invalidMediaSubtypeFormat; |
| 48 | |
| 49 | @end |
| 50 | |
| 51 | @implementation AVCaptureDeviceFormatMock |
| 52 | |
| 53 | @synthesize format = _format; |
| 54 | @synthesize rangeMock = _rangeMock; |
| 55 | |
| 56 | - (instancetype)initWithMediaSubtype:(FourCharCode)subtype |
| 57 | minFps:(float)minFps |
| 58 | maxFps:(float)maxFps { |
| 59 | if (self = [super init]) { |
| 60 | CMVideoFormatDescriptionCreate(nil, subtype, kFormatWidth, kFormatHeight, |
| 61 | nil, &_format); |
| 62 | // We can use OCMock for the range. |
| 63 | _rangeMock = [OCMockObject mockForClass:[AVFrameRateRange class]]; |
| 64 | [[[_rangeMock stub] andReturnValue:@(minFps)] minFrameRate]; |
| 65 | [[[_rangeMock stub] andReturnValue:@(maxFps)] maxFrameRate]; |
| 66 | } |
| 67 | |
| 68 | return self; |
| 69 | } |
| 70 | |
| 71 | + (instancetype)validFormat { |
| 72 | AVCaptureDeviceFormatMock *instance = [[AVCaptureDeviceFormatMock alloc] |
| 73 | initWithMediaSubtype:kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange |
| 74 | minFps:0.0 |
| 75 | maxFps:30.0]; |
| 76 | return instance; |
| 77 | } |
| 78 | |
| 79 | + (instancetype)invalidFpsFormat { |
| 80 | AVCaptureDeviceFormatMock *instance = [[AVCaptureDeviceFormatMock alloc] |
| 81 | initWithMediaSubtype:kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange |
| 82 | minFps:0.0 |
| 83 | maxFps:22.0]; |
| 84 | return instance; |
| 85 | } |
| 86 | |
| 87 | + (instancetype)invalidMediaSubtypeFormat { |
| 88 | AVCaptureDeviceFormatMock *instance = [[AVCaptureDeviceFormatMock alloc] |
| 89 | initWithMediaSubtype:kCVPixelFormatType_420YpCbCr8Planar |
| 90 | minFps:0.0 |
| 91 | maxFps:60.0]; |
| 92 | return instance; |
| 93 | } |
| 94 | |
| 95 | - (void)dealloc { |
| 96 | if (_format != nil) { |
| 97 | CFRelease(_format); |
| 98 | _format = nil; |
| 99 | } |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 100 | } |
| 101 | |
| 102 | // Redefinition of AVCaptureDevice methods we want to mock. |
| 103 | - (CMVideoFormatDescriptionRef)formatDescription { |
| 104 | return self.format; |
| 105 | } |
| 106 | |
| 107 | - (NSArray *)videoSupportedFrameRateRanges { |
| 108 | return @[ self.rangeMock ]; |
| 109 | } |
| 110 | |
| 111 | @end |
| 112 | |
| 113 | TEST(AVFormatMapperTest, SuportedCricketFormatsWithInvalidFramerateFormats) { |
| 114 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 115 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 116 | |
| 117 | // Valid media subtype, invalid framerate |
| 118 | AVCaptureDeviceFormatMock* mock = |
| 119 | [AVCaptureDeviceFormatMock invalidFpsFormat]; |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 120 | OCMStub([mockDevice formats]).andReturn(@[ mock ]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 121 | |
| 122 | // when |
| 123 | std::set<cricket::VideoFormat> result = |
| 124 | webrtc::GetSupportedVideoFormatsForDevice(mockDevice); |
| 125 | |
| 126 | // then |
| 127 | EXPECT_TRUE(result.empty()); |
| 128 | } |
| 129 | |
| 130 | TEST(AVFormatMapperTest, SuportedCricketFormatsWithInvalidFormats) { |
| 131 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 132 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 133 | |
| 134 | // Invalid media subtype, valid framerate |
| 135 | AVCaptureDeviceFormatMock* mock = |
| 136 | [AVCaptureDeviceFormatMock invalidMediaSubtypeFormat]; |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 137 | OCMStub([mockDevice formats]).andReturn(@[ mock ]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 138 | |
| 139 | // when |
| 140 | std::set<cricket::VideoFormat> result = |
| 141 | webrtc::GetSupportedVideoFormatsForDevice(mockDevice); |
| 142 | |
| 143 | // then |
| 144 | EXPECT_TRUE(result.empty()); |
| 145 | } |
| 146 | |
| 147 | TEST(AVFormatMapperTest, SuportedCricketFormats) { |
| 148 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 149 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 150 | |
| 151 | // valid media subtype, valid framerate |
| 152 | AVCaptureDeviceFormatMock* mock = [AVCaptureDeviceFormatMock validFormat]; |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 153 | OCMStub([mockDevice formats]).andReturn(@[ mock ]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 154 | |
| 155 | // when |
| 156 | std::set<cricket::VideoFormat> result = |
| 157 | webrtc::GetSupportedVideoFormatsForDevice(mockDevice); |
| 158 | |
| 159 | // then |
ehmaldonado | da8dcfb | 2017-01-04 07:11:23 -0800 | [diff] [blame] | 160 | EXPECT_EQ(1u, result.size()); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 161 | // make sure the set has the expected format |
| 162 | EXPECT_EQ(expectedFormat, *result.begin()); |
| 163 | } |
| 164 | |
| 165 | TEST(AVFormatMapperTest, MediaSubtypePreference) { |
| 166 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 167 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 168 | |
| 169 | // valid media subtype, valid framerate |
| 170 | AVCaptureDeviceFormatMock* mockOne = [[AVCaptureDeviceFormatMock alloc] |
| 171 | initWithMediaSubtype:kCVPixelFormatType_420YpCbCr8BiPlanarFullRange |
| 172 | minFps:0.0 |
| 173 | maxFps:30.0]; |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 174 | // valid media subtype, valid framerate. |
| 175 | // This media subtype should be the preffered one. |
| 176 | AVCaptureDeviceFormatMock* mockTwo = [[AVCaptureDeviceFormatMock alloc] |
| 177 | initWithMediaSubtype:kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange |
| 178 | minFps:0.0 |
| 179 | maxFps:30.0]; |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 180 | OCMStub([mockDevice lockForConfiguration:[OCMArg setTo:nil]]).andReturn(YES); |
| 181 | OCMStub([mockDevice unlockForConfiguration]); |
| 182 | NSArray* array = @[ mockOne, mockTwo ]; |
| 183 | OCMStub([mockDevice formats]).andReturn(array); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 184 | |
| 185 | // to verify |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 186 | OCMExpect([mockDevice setActiveFormat:(AVCaptureDeviceFormat*)mockTwo]); |
| 187 | OCMExpect( |
| 188 | [mockDevice setActiveVideoMinFrameDuration:CMTimeMake(1, kFramerate)]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 189 | |
| 190 | // when |
| 191 | bool resultFormat = |
| 192 | webrtc::SetFormatForCaptureDevice(mockDevice, nil, expectedFormat); |
| 193 | |
| 194 | // then |
| 195 | EXPECT_TRUE(resultFormat); |
| 196 | [mockDevice verify]; |
| 197 | } |
| 198 | |
| 199 | TEST(AVFormatMapperTest, SetFormatWhenDeviceCannotLock) { |
| 200 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 201 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 202 | [[[mockDevice stub] andReturnValue:@(NO)] |
| 203 | lockForConfiguration:[OCMArg setTo:nil]]; |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 204 | [[[mockDevice stub] andReturn:@[]] formats]; |
| 205 | |
| 206 | // when |
| 207 | bool resultFormat = webrtc::SetFormatForCaptureDevice(mockDevice, nil, |
| 208 | cricket::VideoFormat()); |
| 209 | |
| 210 | // then |
| 211 | EXPECT_FALSE(resultFormat); |
| 212 | } |
| 213 | |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 214 | TEST(AVFormatMapperTest, SetFormatWhenFormatIsIncompatible) { |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 215 | // given |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 216 | id mockDevice = OCMClassMock([AVCaptureDevice class]); |
| 217 | OCMStub([mockDevice formats]).andReturn(@[]); |
| 218 | OCMStub([mockDevice lockForConfiguration:[OCMArg setTo:nil]]).andReturn(YES); |
| 219 | NSException* testException = |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 220 | [NSException exceptionWithName:@"Test exception" |
| 221 | reason:@"Raised from unit tests" |
| 222 | userInfo:nil]; |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 223 | OCMStub([mockDevice setActiveFormat:[OCMArg any]]).andThrow(testException); |
| 224 | OCMExpect([mockDevice unlockForConfiguration]); |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 225 | |
| 226 | // when |
| 227 | bool resultFormat = webrtc::SetFormatForCaptureDevice(mockDevice, nil, |
| 228 | cricket::VideoFormat()); |
| 229 | |
| 230 | // then |
| 231 | EXPECT_FALSE(resultFormat); |
denicija | 907abd8 | 2017-02-28 09:14:45 -0800 | [diff] [blame] | 232 | |
| 233 | // TODO(denicija): Remove try-catch when Chromium rolls this change: |
| 234 | // https://github.com/erikdoe/ocmock/commit/de1419415581dc307045e54bfe9c98c86efea96b |
| 235 | // Without it, stubbed exceptions are being re-raised on [mock verify]. |
| 236 | // More information here: |
| 237 | //https://github.com/erikdoe/ocmock/issues/241 |
| 238 | @try { |
| 239 | [mockDevice verify]; |
| 240 | } @catch (NSException* exception) { |
| 241 | if ([exception.reason isEqual:testException.reason]) { |
| 242 | // Nothing dangerous here |
| 243 | EXPECT_TRUE([exception.reason isEqualToString:exception.reason]); |
| 244 | } |
| 245 | } |
denicija | 28c2487 | 2016-12-06 05:22:49 -0800 | [diff] [blame] | 246 | } |