blob: e704aeba5a9ee2b7a1db2422d0c09c2ed94109a2 [file] [log] [blame]
Amit Hilbuchaa584152019-02-06 17:09:52 -08001/*
2 * Copyright 2019 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Harald Alvestrandc24a2182022-02-23 13:44:59 +000011#include <algorithm>
12#include <iterator>
13#include <map>
Mirko Bonadei317a1f02019-09-17 17:06:18 +020014#include <memory>
Amit Hilbuchaa584152019-02-06 17:09:52 -080015#include <ostream> // no-presubmit-check TODO(webrtc:8982)
Harald Alvestrandc24a2182022-02-23 13:44:59 +000016#include <string>
17#include <utility>
18#include <vector>
Amit Hilbuchaa584152019-02-06 17:09:52 -080019
20#include "absl/algorithm/container.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000021#include "absl/strings/string_view.h"
22#include "api/audio/audio_mixer.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080023#include "api/audio_codecs/builtin_audio_decoder_factory.h"
24#include "api/audio_codecs/builtin_audio_encoder_factory.h"
25#include "api/create_peerconnection_factory.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000026#include "api/jsep.h"
Amit Hilbuchf4770402019-04-08 14:11:57 -070027#include "api/media_types.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000028#include "api/peer_connection_interface.h"
Amit Hilbuchf4770402019-04-08 14:11:57 -070029#include "api/rtc_error.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000030#include "api/rtp_parameters.h"
31#include "api/rtp_sender_interface.h"
32#include "api/rtp_transceiver_direction.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080033#include "api/rtp_transceiver_interface.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000034#include "api/scoped_refptr.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080035#include "api/uma_metrics.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000036#include "api/video/video_codec_constants.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080037#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000039#include "media/base/rid_description.h"
40#include "media/base/stream_params.h"
41#include "modules/audio_device/include/audio_device.h"
42#include "modules/audio_processing/include/audio_processing.h"
43#include "pc/channel_interface.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080044#include "pc/peer_connection_wrapper.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000045#include "pc/session_description.h"
46#include "pc/simulcast_description.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080047#include "pc/test/fake_audio_capture_module.h"
48#include "pc/test/mock_peer_connection_observers.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000049#include "rtc_base/checks.h"
50#include "rtc_base/strings/string_builder.h"
51#include "rtc_base/thread.h"
52#include "rtc_base/unique_id_generator.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080053#include "system_wrappers/include/metrics.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080054#include "test/gmock.h"
Harald Alvestrandc24a2182022-02-23 13:44:59 +000055#include "test/gtest.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080056
57using ::testing::Contains;
58using ::testing::Each;
59using ::testing::ElementsAre;
60using ::testing::ElementsAreArray;
61using ::testing::Eq;
62using ::testing::Field;
63using ::testing::IsEmpty;
64using ::testing::Ne;
Amit Hilbuche2a284d2019-03-05 12:36:31 -080065using ::testing::Pair;
Amit Hilbuchaa584152019-02-06 17:09:52 -080066using ::testing::Property;
67using ::testing::SizeIs;
68
69using cricket::MediaContentDescription;
70using cricket::RidDescription;
71using cricket::SimulcastDescription;
72using cricket::SimulcastLayer;
73using cricket::StreamParams;
74
75namespace cricket {
76
77std::ostream& operator<<( // no-presubmit-check TODO(webrtc:8982)
78 std::ostream& os, // no-presubmit-check TODO(webrtc:8982)
79 const SimulcastLayer& layer) {
80 if (layer.is_paused) {
81 os << "~";
82 }
83 return os << layer.rid;
84}
85
86} // namespace cricket
87
88namespace {
89
90std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
91 const std::vector<bool>& active) {
92 RTC_DCHECK_EQ(rids.size(), active.size());
93 std::vector<SimulcastLayer> result;
94 absl::c_transform(rids, active, std::back_inserter(result),
95 [](const std::string& rid, bool is_active) {
96 return SimulcastLayer(rid, !is_active);
97 });
98 return result;
99}
100std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
101 bool active) {
102 return CreateLayers(rids, std::vector<bool>(rids.size(), active));
103}
104
Ying Wangef3998f2019-12-09 13:06:53 +0100105#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800106std::vector<SimulcastLayer> CreateLayers(int num_layers, bool active) {
107 rtc::UniqueStringGenerator rid_generator;
108 std::vector<std::string> rids;
109 for (int i = 0; i < num_layers; ++i) {
110 rids.push_back(rid_generator());
111 }
112 return CreateLayers(rids, active);
113}
Ying Wangef3998f2019-12-09 13:06:53 +0100114#endif
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800115
Amit Hilbuchaa584152019-02-06 17:09:52 -0800116} // namespace
Ying Wangef3998f2019-12-09 13:06:53 +0100117
Amit Hilbuchaa584152019-02-06 17:09:52 -0800118namespace webrtc {
119
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200120class PeerConnectionSimulcastTests : public ::testing::Test {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800121 public:
122 PeerConnectionSimulcastTests()
123 : pc_factory_(
124 CreatePeerConnectionFactory(rtc::Thread::Current(),
125 rtc::Thread::Current(),
126 rtc::Thread::Current(),
127 FakeAudioCaptureModule::Create(),
128 CreateBuiltinAudioEncoderFactory(),
129 CreateBuiltinAudioDecoderFactory(),
130 CreateBuiltinVideoEncoderFactory(),
131 CreateBuiltinVideoDecoderFactory(),
132 nullptr,
133 nullptr)) {}
134
135 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
136 MockPeerConnectionObserver* observer) {
137 PeerConnectionInterface::RTCConfiguration config;
138 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
139 PeerConnectionDependencies pcd(observer);
Florent Castelli72424402022-04-06 03:45:10 +0200140 auto result =
141 pc_factory_->CreatePeerConnectionOrError(config, std::move(pcd));
142 EXPECT_TRUE(result.ok());
Niels Möllerafb246b2022-04-20 14:26:50 +0200143 observer->SetPeerConnectionInterface(result.value().get());
Florent Castelli72424402022-04-06 03:45:10 +0200144 return result.MoveValue();
Amit Hilbuchaa584152019-02-06 17:09:52 -0800145 }
146
147 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWrapper() {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200148 auto observer = std::make_unique<MockPeerConnectionObserver>();
Amit Hilbuchaa584152019-02-06 17:09:52 -0800149 auto pc = CreatePeerConnection(observer.get());
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200150 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
151 std::move(observer));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800152 }
153
Amit Hilbuch619b2942019-02-26 15:55:19 -0800154 void ExchangeOfferAnswer(PeerConnectionWrapper* local,
155 PeerConnectionWrapper* remote,
156 const std::vector<SimulcastLayer>& answer_layers) {
157 auto offer = local->CreateOfferAndSetAsLocal();
158 // Remove simulcast as the second peer connection won't support it.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800159 RemoveSimulcast(offer.get());
Amit Hilbuch619b2942019-02-26 15:55:19 -0800160 std::string err;
161 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
162 auto answer = remote->CreateAnswerAndSetAsLocal();
163 // Setup the answer to look like a server response.
164 auto mcd_answer = answer->description()->contents()[0].media_description();
165 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
166 for (const SimulcastLayer& layer : answer_layers) {
167 receive_layers.AddLayer(layer);
168 }
169 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
170 }
171
Amit Hilbuchaa584152019-02-06 17:09:52 -0800172 RtpTransceiverInit CreateTransceiverInit(
173 const std::vector<SimulcastLayer>& layers) {
174 RtpTransceiverInit init;
175 for (const SimulcastLayer& layer : layers) {
176 RtpEncodingParameters encoding;
177 encoding.rid = layer.rid;
178 encoding.active = !layer.is_paused;
179 init.send_encodings.push_back(encoding);
180 }
181 return init;
182 }
183
184 rtc::scoped_refptr<RtpTransceiverInterface> AddTransceiver(
185 PeerConnectionWrapper* pc,
Florent Castellie1b685a2021-04-30 19:11:37 +0200186 const std::vector<SimulcastLayer>& layers,
187 cricket::MediaType media_type = cricket::MEDIA_TYPE_VIDEO) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800188 auto init = CreateTransceiverInit(layers);
Florent Castellie1b685a2021-04-30 19:11:37 +0200189 return pc->AddTransceiver(media_type, init);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800190 }
191
192 SimulcastDescription RemoveSimulcast(SessionDescriptionInterface* sd) {
193 auto mcd = sd->description()->contents()[0].media_description();
194 auto result = mcd->simulcast_description();
195 mcd->set_simulcast_description(SimulcastDescription());
196 return result;
197 }
198
199 void AddRequestToReceiveSimulcast(const std::vector<SimulcastLayer>& layers,
200 SessionDescriptionInterface* sd) {
201 auto mcd = sd->description()->contents()[0].media_description();
202 SimulcastDescription simulcast;
203 auto& receive_layers = simulcast.receive_layers();
204 for (const SimulcastLayer& layer : layers) {
205 receive_layers.AddLayer(layer);
206 }
207 mcd->set_simulcast_description(simulcast);
208 }
209
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800210 void ValidateTransceiverParameters(
Amit Hilbuchaa584152019-02-06 17:09:52 -0800211 rtc::scoped_refptr<RtpTransceiverInterface> transceiver,
212 const std::vector<SimulcastLayer>& layers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800213 auto parameters = transceiver->sender()->GetParameters();
214 std::vector<SimulcastLayer> result_layers;
215 absl::c_transform(parameters.encodings, std::back_inserter(result_layers),
216 [](const RtpEncodingParameters& encoding) {
217 return SimulcastLayer(encoding.rid, !encoding.active);
218 });
219 EXPECT_THAT(result_layers, ElementsAreArray(layers));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800220 }
221
222 private:
223 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
224};
225
Ying Wangef3998f2019-12-09 13:06:53 +0100226#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800227// This class is used to test the metrics emitted for simulcast.
228class PeerConnectionSimulcastMetricsTests
229 : public PeerConnectionSimulcastTests,
230 public ::testing::WithParamInterface<int> {
231 protected:
232 PeerConnectionSimulcastMetricsTests() { webrtc::metrics::Reset(); }
233
234 std::map<int, int> LocalDescriptionSamples() {
235 return metrics::Samples(
236 "WebRTC.PeerConnection.Simulcast.ApplyLocalDescription");
237 }
238 std::map<int, int> RemoteDescriptionSamples() {
239 return metrics::Samples(
240 "WebRTC.PeerConnection.Simulcast.ApplyRemoteDescription");
241 }
242};
Ying Wangef3998f2019-12-09 13:06:53 +0100243#endif
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800244
Amit Hilbuchaa584152019-02-06 17:09:52 -0800245// Validates that RIDs are supported arguments when adding a transceiver.
246TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithRid) {
247 auto pc = CreatePeerConnectionWrapper();
248 auto layers = CreateLayers({"f"}, true);
249 auto transceiver = AddTransceiver(pc.get(), layers);
250 ASSERT_TRUE(transceiver);
251 auto parameters = transceiver->sender()->GetParameters();
252 // Single RID should be removed.
253 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800254 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800255}
256
257TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithSimulcast) {
258 auto pc = CreatePeerConnectionWrapper();
259 auto layers = CreateLayers({"f", "h", "q"}, true);
260 auto transceiver = AddTransceiver(pc.get(), layers);
261 ASSERT_TRUE(transceiver);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800262 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800263}
264
265TEST_F(PeerConnectionSimulcastTests, RidsAreAutogeneratedIfNotProvided) {
266 auto pc = CreatePeerConnectionWrapper();
267 auto init = CreateTransceiverInit(CreateLayers({"f", "h", "q"}, true));
268 for (RtpEncodingParameters& parameters : init.send_encodings) {
269 parameters.rid = "";
270 }
271 auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
272 auto parameters = transceiver->sender()->GetParameters();
273 ASSERT_EQ(3u, parameters.encodings.size());
274 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800275 Each(Field("rid", &RtpEncodingParameters::rid, Ne(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800276}
277
278// Validates that an error is returned when there is a mix of supplied and not
279// supplied RIDs in a call to AddTransceiver.
280TEST_F(PeerConnectionSimulcastTests, MustSupplyAllOrNoRidsInSimulcast) {
281 auto pc_wrapper = CreatePeerConnectionWrapper();
282 auto pc = pc_wrapper->pc();
283 // Cannot create a layer with empty RID. Remove the RID after init is created.
284 auto layers = CreateLayers({"f", "h", "remove"}, true);
285 auto init = CreateTransceiverInit(layers);
286 init.send_encodings[2].rid = "";
287 auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
288 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type());
289}
290
Amit Hilbuchf4770402019-04-08 14:11:57 -0700291// Validates that an error is returned when illegal RIDs are supplied.
292TEST_F(PeerConnectionSimulcastTests, ChecksForIllegalRidValues) {
293 auto pc_wrapper = CreatePeerConnectionWrapper();
294 auto pc = pc_wrapper->pc();
295 auto layers = CreateLayers({"f", "h", "~q"}, true);
296 auto init = CreateTransceiverInit(layers);
297 auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
298 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type());
299}
300
Amit Hilbuch2297d332019-02-19 12:49:22 -0800301// Validates that a single RID is removed from the encoding layer.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800302TEST_F(PeerConnectionSimulcastTests, SingleRidIsRemovedFromSessionDescription) {
303 auto pc = CreatePeerConnectionWrapper();
304 auto transceiver = AddTransceiver(pc.get(), CreateLayers({"1"}, true));
305 auto offer = pc->CreateOfferAndSetAsLocal();
306 ASSERT_TRUE(offer);
307 auto contents = offer->description()->contents();
308 ASSERT_EQ(1u, contents.size());
309 EXPECT_THAT(contents[0].media_description()->streams(),
310 ElementsAre(Property(&StreamParams::has_rids, false)));
311}
312
313TEST_F(PeerConnectionSimulcastTests, SimulcastLayersRemovedFromTail) {
314 static_assert(
315 kMaxSimulcastStreams < 8,
316 "Test assumes that the platform does not allow 8 simulcast layers");
317 auto pc = CreatePeerConnectionWrapper();
318 auto layers = CreateLayers({"1", "2", "3", "4", "5", "6", "7", "8"}, true);
319 std::vector<SimulcastLayer> expected_layers;
320 std::copy_n(layers.begin(), kMaxSimulcastStreams,
321 std::back_inserter(expected_layers));
322 auto transceiver = AddTransceiver(pc.get(), layers);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800323 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800324}
325
326// Checks that an offfer to send simulcast contains a SimulcastDescription.
327TEST_F(PeerConnectionSimulcastTests, SimulcastAppearsInSessionDescription) {
328 auto pc = CreatePeerConnectionWrapper();
329 std::vector<std::string> rids({"f", "h", "q"});
330 auto layers = CreateLayers(rids, true);
331 auto transceiver = AddTransceiver(pc.get(), layers);
332 auto offer = pc->CreateOffer();
333 ASSERT_TRUE(offer);
334 auto contents = offer->description()->contents();
335 ASSERT_EQ(1u, contents.size());
336 auto content = contents[0];
337 auto mcd = content.media_description();
338 ASSERT_TRUE(mcd->HasSimulcast());
339 auto simulcast = mcd->simulcast_description();
340 EXPECT_THAT(simulcast.receive_layers(), IsEmpty());
341 // The size is validated separately because GetAllLayers() flattens the list.
342 EXPECT_THAT(simulcast.send_layers(), SizeIs(3));
343 std::vector<SimulcastLayer> result = simulcast.send_layers().GetAllLayers();
344 EXPECT_THAT(result, ElementsAreArray(layers));
345 auto streams = mcd->streams();
346 ASSERT_EQ(1u, streams.size());
347 auto stream = streams[0];
348 EXPECT_FALSE(stream.has_ssrcs());
349 EXPECT_TRUE(stream.has_rids());
350 std::vector<std::string> result_rids;
351 absl::c_transform(stream.rids(), std::back_inserter(result_rids),
352 [](const RidDescription& rid) { return rid.rid; });
353 EXPECT_THAT(result_rids, ElementsAreArray(rids));
354}
355
356// Checks that Simulcast layers propagate to the sender parameters.
357TEST_F(PeerConnectionSimulcastTests, SimulcastLayersAreSetInSender) {
358 auto local = CreatePeerConnectionWrapper();
359 auto remote = CreatePeerConnectionWrapper();
360 auto layers = CreateLayers({"f", "h", "q"}, true);
361 auto transceiver = AddTransceiver(local.get(), layers);
362 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800363 {
364 SCOPED_TRACE("after create offer");
365 ValidateTransceiverParameters(transceiver, layers);
366 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800367 // Remove simulcast as the second peer connection won't support it.
368 auto simulcast = RemoveSimulcast(offer.get());
369 std::string error;
370 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
371 auto answer = remote->CreateAnswerAndSetAsLocal();
372
373 // Setup an answer that mimics a server accepting simulcast.
374 auto mcd_answer = answer->description()->contents()[0].media_description();
375 mcd_answer->mutable_streams().clear();
376 auto simulcast_layers = simulcast.send_layers().GetAllLayers();
377 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
378 for (const auto& layer : simulcast_layers) {
379 receive_layers.AddLayer(layer);
380 }
381 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800382 {
383 SCOPED_TRACE("after set remote");
384 ValidateTransceiverParameters(transceiver, layers);
385 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800386}
387
388// Checks that paused Simulcast layers propagate to the sender parameters.
389TEST_F(PeerConnectionSimulcastTests, PausedSimulcastLayersAreDisabledInSender) {
390 auto local = CreatePeerConnectionWrapper();
391 auto remote = CreatePeerConnectionWrapper();
392 auto layers = CreateLayers({"f", "h", "q"}, {true, false, true});
393 auto server_layers = CreateLayers({"f", "h", "q"}, {true, false, false});
394 RTC_DCHECK_EQ(layers.size(), server_layers.size());
395 auto transceiver = AddTransceiver(local.get(), layers);
396 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800397 {
398 SCOPED_TRACE("after create offer");
399 ValidateTransceiverParameters(transceiver, layers);
400 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800401
402 // Remove simulcast as the second peer connection won't support it.
403 RemoveSimulcast(offer.get());
404 std::string error;
405 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
406 auto answer = remote->CreateAnswerAndSetAsLocal();
407
408 // Setup an answer that mimics a server accepting simulcast.
409 auto mcd_answer = answer->description()->contents()[0].media_description();
410 mcd_answer->mutable_streams().clear();
411 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
412 for (const SimulcastLayer& layer : server_layers) {
413 receive_layers.AddLayer(layer);
414 }
415 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800416 {
417 SCOPED_TRACE("after set remote");
418 ValidateTransceiverParameters(transceiver, server_layers);
419 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800420}
421
422// Checks that when Simulcast is not supported by the remote party, then all
Amit Hilbuch2297d332019-02-19 12:49:22 -0800423// the layers (except the first) are removed.
424TEST_F(PeerConnectionSimulcastTests, SimulcastRejectedRemovesExtraLayers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800425 auto local = CreatePeerConnectionWrapper();
426 auto remote = CreatePeerConnectionWrapper();
427 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800428 auto transceiver = AddTransceiver(local.get(), layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800429 ExchangeOfferAnswer(local.get(), remote.get(), {});
Amit Hilbuch2297d332019-02-19 12:49:22 -0800430 auto parameters = transceiver->sender()->GetParameters();
431 // Should only have the first layer.
432 EXPECT_THAT(parameters.encodings,
433 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq("1"))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800434}
435
Amit Hilbuch2297d332019-02-19 12:49:22 -0800436// Checks that if Simulcast is supported by remote party, but some layers are
437// rejected, then only rejected layers are removed from the sender.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800438TEST_F(PeerConnectionSimulcastTests, RejectedSimulcastLayersAreDeactivated) {
439 auto local = CreatePeerConnectionWrapper();
440 auto remote = CreatePeerConnectionWrapper();
Florent Castelli3fbf1e22019-07-04 17:09:05 +0200441 auto layers = CreateLayers({"1", "2", "3"}, true);
442 auto expected_layers = CreateLayers({"2", "3"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800443 auto transceiver = AddTransceiver(local.get(), layers);
444 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800445 {
446 SCOPED_TRACE("after create offer");
447 ValidateTransceiverParameters(transceiver, layers);
448 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800449 // Remove simulcast as the second peer connection won't support it.
450 auto removed_simulcast = RemoveSimulcast(offer.get());
451 std::string error;
452 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
453 auto answer = remote->CreateAnswerAndSetAsLocal();
454 auto mcd_answer = answer->description()->contents()[0].media_description();
455 // Setup the answer to look like a server response.
456 // Remove one of the layers to reject it in the answer.
457 auto simulcast_layers = removed_simulcast.send_layers().GetAllLayers();
458 simulcast_layers.erase(simulcast_layers.begin());
459 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
460 for (const auto& layer : simulcast_layers) {
461 receive_layers.AddLayer(layer);
462 }
463 ASSERT_TRUE(mcd_answer->HasSimulcast());
464 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800465 {
466 SCOPED_TRACE("after set remote");
467 ValidateTransceiverParameters(transceiver, expected_layers);
468 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800469}
470
471// Checks that simulcast is set up correctly when the server sends an offer
472// requesting to receive simulcast.
473TEST_F(PeerConnectionSimulcastTests, ServerSendsOfferToReceiveSimulcast) {
474 auto local = CreatePeerConnectionWrapper();
475 auto remote = CreatePeerConnectionWrapper();
476 auto layers = CreateLayers({"f", "h", "q"}, true);
477 AddTransceiver(local.get(), layers);
478 auto offer = local->CreateOfferAndSetAsLocal();
479 // Remove simulcast as a sender and set it up as a receiver.
480 RemoveSimulcast(offer.get());
481 AddRequestToReceiveSimulcast(layers, offer.get());
482 std::string error;
483 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
484 auto transceiver = remote->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200485 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800486 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800487 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800488}
489
490// Checks that SetRemoteDescription doesn't attempt to associate a transceiver
491// when simulcast is requested by the server.
492TEST_F(PeerConnectionSimulcastTests, TransceiverIsNotRecycledWithSimulcast) {
493 auto local = CreatePeerConnectionWrapper();
494 auto remote = CreatePeerConnectionWrapper();
495 auto layers = CreateLayers({"f", "h", "q"}, true);
496 AddTransceiver(local.get(), layers);
497 auto offer = local->CreateOfferAndSetAsLocal();
498 // Remove simulcast as a sender and set it up as a receiver.
499 RemoveSimulcast(offer.get());
500 AddRequestToReceiveSimulcast(layers, offer.get());
501 // Call AddTrack so that a transceiver is created.
502 remote->AddVideoTrack("fake_track");
503 std::string error;
504 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
505 auto transceivers = remote->pc()->GetTransceivers();
506 ASSERT_EQ(2u, transceivers.size());
507 auto transceiver = transceivers[1];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200508 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800509 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800510 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800511}
512
Amit Hilbuch619b2942019-02-26 15:55:19 -0800513// Checks that if the number of layers changes during negotiation, then any
514// outstanding get/set parameters transaction is invalidated.
515TEST_F(PeerConnectionSimulcastTests, ParametersAreInvalidatedWhenLayersChange) {
516 auto local = CreatePeerConnectionWrapper();
517 auto remote = CreatePeerConnectionWrapper();
518 auto layers = CreateLayers({"1", "2", "3"}, true);
519 auto transceiver = AddTransceiver(local.get(), layers);
520 auto parameters = transceiver->sender()->GetParameters();
521 ASSERT_EQ(3u, parameters.encodings.size());
522 // Response will reject simulcast altogether.
523 ExchangeOfferAnswer(local.get(), remote.get(), {});
524 auto result = transceiver->sender()->SetParameters(parameters);
525 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.type());
526}
527
528// Checks that even though negotiation modifies the sender's parameters, an
529// outstanding get/set parameters transaction is not invalidated.
530// This test negotiates twice because initial parameters before negotiation
531// is missing critical information and cannot be set on the sender.
532TEST_F(PeerConnectionSimulcastTests,
533 NegotiationDoesNotInvalidateParameterTransactions) {
534 auto local = CreatePeerConnectionWrapper();
535 auto remote = CreatePeerConnectionWrapper();
536 auto layers = CreateLayers({"1", "2", "3"}, true);
537 auto expected_layers = CreateLayers({"1", "2", "3"}, false);
538 auto transceiver = AddTransceiver(local.get(), layers);
539 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
540
541 // Verify that negotiation does not invalidate the parameters.
542 auto parameters = transceiver->sender()->GetParameters();
543 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
544
545 auto result = transceiver->sender()->SetParameters(parameters);
546 EXPECT_TRUE(result.ok());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800547 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800548}
549
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800550// Tests that simulcast is disabled if the RID extension is not negotiated
551// regardless of if the RIDs and simulcast attribute were negotiated properly.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800552TEST_F(PeerConnectionSimulcastTests, NegotiationDoesNotHaveRidExtension) {
553 auto local = CreatePeerConnectionWrapper();
554 auto remote = CreatePeerConnectionWrapper();
555 auto layers = CreateLayers({"1", "2", "3"}, true);
556 auto expected_layers = CreateLayers({"1"}, true);
557 auto transceiver = AddTransceiver(local.get(), layers);
558 auto offer = local->CreateOfferAndSetAsLocal();
559 // Remove simulcast as the second peer connection won't support it.
560 RemoveSimulcast(offer.get());
561 std::string err;
562 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
563 auto answer = remote->CreateAnswerAndSetAsLocal();
564 // Setup the answer to look like a server response.
565 // Drop the RID header extension.
566 auto mcd_answer = answer->description()->contents()[0].media_description();
567 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
568 for (const SimulcastLayer& layer : layers) {
569 receive_layers.AddLayer(layer);
570 }
571 cricket::RtpHeaderExtensions extensions;
572 for (auto extension : mcd_answer->rtp_header_extensions()) {
573 if (extension.uri != RtpExtension::kRidUri) {
574 extensions.push_back(extension);
575 }
576 }
577 mcd_answer->set_rtp_header_extensions(extensions);
578 EXPECT_EQ(layers.size(), mcd_answer->simulcast_description()
579 .receive_layers()
580 .GetAllLayers()
581 .size());
582 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800583 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800584}
Ying Wangef3998f2019-12-09 13:06:53 +0100585
Florent Castellie1b685a2021-04-30 19:11:37 +0200586TEST_F(PeerConnectionSimulcastTests, SimulcastAudioRejected) {
587 auto local = CreatePeerConnectionWrapper();
588 auto remote = CreatePeerConnectionWrapper();
589 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
590 auto transceiver =
591 AddTransceiver(local.get(), layers, cricket::MEDIA_TYPE_AUDIO);
592 // Should only have the first layer.
593 auto parameters = transceiver->sender()->GetParameters();
594 EXPECT_EQ(1u, parameters.encodings.size());
595 EXPECT_THAT(parameters.encodings,
596 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
597 ExchangeOfferAnswer(local.get(), remote.get(), {});
598 // Still have a single layer after negotiation
599 parameters = transceiver->sender()->GetParameters();
600 EXPECT_EQ(1u, parameters.encodings.size());
601 EXPECT_THAT(parameters.encodings,
602 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
603}
604
Ying Wangef3998f2019-12-09 13:06:53 +0100605#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800606//
607// Checks the logged metrics when simulcast is not used.
608TEST_F(PeerConnectionSimulcastMetricsTests, NoSimulcastUsageIsLogged) {
609 auto local = CreatePeerConnectionWrapper();
610 auto remote = CreatePeerConnectionWrapper();
611 auto layers = CreateLayers(0, true);
612 AddTransceiver(local.get(), layers);
613 ExchangeOfferAnswer(local.get(), remote.get(), layers);
614
615 EXPECT_THAT(LocalDescriptionSamples(),
616 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
617 EXPECT_THAT(RemoteDescriptionSamples(),
618 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
619}
620
621// Checks the logged metrics when spec-compliant simulcast is used.
622TEST_F(PeerConnectionSimulcastMetricsTests, SpecComplianceIsLogged) {
623 auto local = CreatePeerConnectionWrapper();
624 auto remote = CreatePeerConnectionWrapper();
625 auto layers = CreateLayers(3, true);
626 AddTransceiver(local.get(), layers);
627 ExchangeOfferAnswer(local.get(), remote.get(), layers);
628
629 // Expecting 2 invocations of each, because we have 2 peer connections.
630 // Only the local peer connection will be aware of simulcast.
631 // The remote peer connection will think that there is no simulcast.
632 EXPECT_THAT(LocalDescriptionSamples(),
633 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
634 Pair(kSimulcastApiVersionSpecCompliant, 1)));
635 EXPECT_THAT(RemoteDescriptionSamples(),
636 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
637 Pair(kSimulcastApiVersionSpecCompliant, 1)));
638}
639
640// Checks the logged metrics when and incoming request to send spec-compliant
641// simulcast is received from the remote party.
642TEST_F(PeerConnectionSimulcastMetricsTests, IncomingSimulcastIsLogged) {
643 auto local = CreatePeerConnectionWrapper();
644 auto remote = CreatePeerConnectionWrapper();
645 auto layers = CreateLayers(3, true);
646 AddTransceiver(local.get(), layers);
647 auto offer = local->CreateOfferAndSetAsLocal();
648 EXPECT_THAT(LocalDescriptionSamples(),
649 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
650
651 // Remove simulcast as a sender and set it up as a receiver.
652 RemoveSimulcast(offer.get());
653 AddRequestToReceiveSimulcast(layers, offer.get());
654 std::string error;
655 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
656 EXPECT_THAT(RemoteDescriptionSamples(),
657 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
658
659 auto transceiver = remote->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200660 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800661 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
662 EXPECT_THAT(LocalDescriptionSamples(),
663 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 2)));
664}
665
666// Checks that a spec-compliant simulcast offer that is rejected is logged.
667TEST_F(PeerConnectionSimulcastMetricsTests, RejectedSimulcastIsLogged) {
668 auto local = CreatePeerConnectionWrapper();
669 auto remote = CreatePeerConnectionWrapper();
670 auto layers = CreateLayers({"1", "2", "3"}, true);
671 AddTransceiver(local.get(), layers);
672 auto offer = local->CreateOfferAndSetAsLocal();
673 EXPECT_THAT(LocalDescriptionSamples(),
674 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
675 RemoveSimulcast(offer.get());
676 std::string error;
677 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
678 EXPECT_THAT(RemoteDescriptionSamples(),
679 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
680
681 auto answer = remote->CreateAnswerAndSetAsLocal();
682 EXPECT_THAT(LocalDescriptionSamples(),
683 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
684 Pair(kSimulcastApiVersionSpecCompliant, 1)));
685 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
686 EXPECT_THAT(RemoteDescriptionSamples(),
687 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
688}
689
690// Checks the logged metrics when legacy munging simulcast technique is used.
691TEST_F(PeerConnectionSimulcastMetricsTests, LegacySimulcastIsLogged) {
692 auto local = CreatePeerConnectionWrapper();
693 auto remote = CreatePeerConnectionWrapper();
694 auto layers = CreateLayers(0, true);
695 AddTransceiver(local.get(), layers);
696 auto offer = local->CreateOffer();
697 // Munge the SDP to set up legacy simulcast.
698 const std::string end_line = "\r\n";
699 std::string sdp;
700 offer->ToString(&sdp);
701 rtc::StringBuilder builder(sdp);
702 builder << "a=ssrc:1111 cname:slimshady" << end_line;
703 builder << "a=ssrc:2222 cname:slimshady" << end_line;
704 builder << "a=ssrc:3333 cname:slimshady" << end_line;
705 builder << "a=ssrc-group:SIM 1111 2222 3333" << end_line;
706
707 SdpParseError parse_error;
708 auto sd =
709 CreateSessionDescription(SdpType::kOffer, builder.str(), &parse_error);
710 ASSERT_TRUE(sd) << parse_error.line << parse_error.description;
711 std::string error;
712 EXPECT_TRUE(local->SetLocalDescription(std::move(sd), &error)) << error;
713 EXPECT_THAT(LocalDescriptionSamples(),
714 ElementsAre(Pair(kSimulcastApiVersionLegacy, 1)));
715 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
716 EXPECT_THAT(RemoteDescriptionSamples(),
717 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
718 auto answer = remote->CreateAnswerAndSetAsLocal();
719 EXPECT_THAT(LocalDescriptionSamples(),
720 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
721 Pair(kSimulcastApiVersionLegacy, 1)));
722 // Legacy simulcast is not signaled in remote description.
723 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
724 EXPECT_THAT(RemoteDescriptionSamples(),
725 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
726}
727
728// Checks that disabling simulcast is logged in the metrics.
729TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsLogged) {
730 auto local = CreatePeerConnectionWrapper();
731 auto remote = CreatePeerConnectionWrapper();
732 auto layers = CreateLayers({"1", "2", "3"}, true);
733 AddTransceiver(local.get(), layers);
734 auto offer = local->CreateOfferAndSetAsLocal();
735 RemoveSimulcast(offer.get());
736 std::string error;
737 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
738 auto answer = remote->CreateAnswerAndSetAsLocal();
739 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
740
741 EXPECT_EQ(1, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
742 EXPECT_EQ(1,
743 metrics::NumEvents("WebRTC.PeerConnection.Simulcast.Disabled", 1));
744}
745
746// Checks that the disabled metric is not logged if simulcast is not disabled.
747TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsNotLogged) {
748 auto local = CreatePeerConnectionWrapper();
749 auto remote = CreatePeerConnectionWrapper();
750 auto layers = CreateLayers({"1", "2", "3"}, true);
751 AddTransceiver(local.get(), layers);
752 ExchangeOfferAnswer(local.get(), remote.get(), layers);
753
754 EXPECT_EQ(0, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
755}
756
757const int kMaxLayersInMetricsTest = 8;
758
759// Checks that the number of send encodings is logged in a metric.
760TEST_P(PeerConnectionSimulcastMetricsTests, NumberOfSendEncodingsIsLogged) {
761 auto local = CreatePeerConnectionWrapper();
762 auto num_layers = GetParam();
763 auto layers = CreateLayers(num_layers, true);
764 AddTransceiver(local.get(), layers);
765 EXPECT_EQ(1, metrics::NumSamples(
766 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings"));
767 EXPECT_EQ(1, metrics::NumEvents(
768 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings",
769 num_layers));
770}
771
772INSTANTIATE_TEST_SUITE_P(NumberOfSendEncodings,
773 PeerConnectionSimulcastMetricsTests,
774 ::testing::Range(0, kMaxLayersInMetricsTest));
Ying Wangef3998f2019-12-09 13:06:53 +0100775#endif
Amit Hilbuchaa584152019-02-06 17:09:52 -0800776} // namespace webrtc